<@wumpus>
unless someone implements https://github.com/bitcoin/bitcoin/issues/8973 to make onion connections come in on either an alternative port or a unix socket, it's unsafe to whitelist 127.0.0.1 [by default]
< bitcoin-git>
[bitcoin] practicalswift closed pull request #10212: Make sure parameter names in .cpp and .h files are in sync (master...make-doxygen-happy-by-using-consistent-parameter-names) https://github.com/bitcoin/bitcoin/pull/10212
< bitcoin-git>
[bitcoin] paveljanik opened pull request #10272: [Tests] Prevent warning: variable 'x' is uninitialized (master...20170425_FastRandomContext_test_warnings) https://github.com/bitcoin/bitcoin/pull/10272
< bitcoin-git>
[bitcoin] fanquake opened pull request #10271: Use std::thread::hardware_concurrency, instead of Boost, to determine available cores (master...replace-boost-getnumcores) https://github.com/bitcoin/bitcoin/pull/10271
< bitcoin-git>
[bitcoin] fanquake opened pull request #10270: Remove Clang workaround for Boost 1.46 (master...remove-boost-clang-workaround) https://github.com/bitcoin/bitcoin/pull/10270
<@wumpus>
BlueMatt: ah yes the "apply all the buzzwords to bitcoin mining, see what sticks" approach
< BlueMatt>
wumpus: the same bottom-of-the-barrel buzzword bingo that came up with "using normal computers to simulate quantum computers to do bitcoin mining"
<@wumpus>
"using deep learning frameworks in bitcoin mining", that's hilarious, what bottom-of-the-barrel buzzword factory did that come out of
< bitcoin-git>
[bitcoin] kallewoof opened pull request #10267: New -readconfig argument for including external configuration files (master...feature-config-readconfig) https://github.com/bitcoin/bitcoin/pull/10267
< bitcoin-git>
[bitcoin] jonasschnelli closed pull request #10254: [Qt] Remove shutdown poll timer and replace it with a signal (master...2017/04/qt_shutdown) https://github.com/bitcoin/bitcoin/pull/10254
< achow101>
I made dummy github user non-github-bitcoin (https://github.com/non-github-bitcoin) to account for the commits made by the people who committed but don't have github accounts. right now it has sirius-m (github removed it from saracen to allow me to add that account) and lasloh. I'll be asking github to also let me add s_nakamoto which is currently under invalid-email-address. I think it would be prudent to give the repo maintainers
< bitcoin-git>
[bitcoin] jimmysong opened pull request #10255: [test] Add test for listaddressgroupings (master...test_listaddressgroupings) https://github.com/bitcoin/bitcoin/pull/10255
< bitcoin-git>
[bitcoin] jonasschnelli opened pull request #10254: [Qt] Remove shutdown poll timer and replace it with a signal (master...2017/04/qt_shutdown) https://github.com/bitcoin/bitcoin/pull/10254
< bitcoin-git>
[bitcoin] jtimon closed pull request #10227: Make functions in validation.cpp static: (master...b14-chainparams-validation-static) https://github.com/bitcoin/bitcoin/pull/10227
< bitcoin-git>
[bitcoin] jonasschnelli opened pull request #10251: Add balances cache / GUI: use a signal instead of a poll thread (master...2017/04/gui_rm_locks) https://github.com/bitcoin/bitcoin/pull/10251
< sipa>
there is something crazy in this reasoning: bitcoin core is too annoying to use due to resource usage, thus people switch to electrum, but then complain they can't easily run their own server... which is even more expensive than just running a full node wallet in the first place
<@wumpus>
of course there are more electrum users, that doesn't invalidate anything I said, most people running bitcoin core do not run an electrum server
< bitcoin-git>
[bitcoin] practicalswift opened pull request #10246: Silence "warning: "MSG_DONTWAIT" redefined" when compiling under Linux (master...silence-msg_dontwait-warning) https://github.com/bitcoin/bitcoin/pull/10246
< bitcoin-git>
[bitcoin] shigeya opened pull request #10245: Minor fix in build documentation for FreeBSD 11 (master...freebsd-11-build-doc-fix) https://github.com/bitcoin/bitcoin/pull/10245
< gribble>
https://github.com/bitcoin/bitcoin/issues/10189 | devtools/net: add a verifier for scriptable changes. Use it to make CNode::id private. by theuni · Pull Request #10189 · bitcoin/bitcoin · GitHub
< jtimon>
wumpus: it seems to interfere with prevector templates in prevector_tests.cpp, see https://github.com/bitcoin/bitcoin/pull/10193/commits/cfef34884684e71c6f43ef3e4f2e87590fc87c9e for the trick to make the PR pass travis. probably I should remove that commit already, but I wanted to make sure the commits after removing BOOST_REVERSE_FOREACH weren't breaking something else, plus that commit is kind of the link that maybe answers your
< jtimon>
regarding https://github.com/bitcoin/bitcoin/pull/10193 I'm still failing at replacing BOOST_REVERSE_FOREACH and I don't understand why, maybe I should reduce the scope of the PR (I moved from working stuff to trying to fully remove boost/foreach.hpp by popular demand)
< gribble>
https://github.com/bitcoin/bitcoin/issues/10179 | Give CValidationInterface Support for calling notifications on the CScheduler Thread by TheBlueMatt · Pull Request #10179 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/10179 | Give CValidationInterface Support for calling notifications on the CScheduler Thread by TheBlueMatt · Pull Request #10179 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] jonasschnelli opened pull request #10241: Allow tests to pass even when stderr got populated (master...2017/04/test_stderr) https://github.com/bitcoin/bitcoin/pull/10241
< bitcoin-git>
[bitcoin] laanwj closed pull request #10143: [net] Allow disconnectnode RPC to be called with node id (master...disconnect_node_by_id) https://github.com/bitcoin/bitcoin/pull/10143
< bitcoin-git>
bitcoin/master e367ad5 John Newbery: [tests] rename nodehandling to disconnectban
< gribble>
https://github.com/bitcoin/bitcoin/issues/10207 | Clarify importprivkey help text ... example of blank label without rescan by wtogami · Pull Request #10207 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] TheBlueMatt opened pull request #10235: Track keypool entries as internal vs external in memory (master...2017-04-wallet-more-keypool-cache) https://github.com/bitcoin/bitcoin/pull/10235
< bitcoin-git>
[bitcoin] jnewbery opened pull request #10234: [net] listbanned RPC and QT should show correct banned subnets (master...list_banned_correctly) https://github.com/bitcoin/bitcoin/pull/10234
< gribble>
https://github.com/bitcoin/bitcoin/issues/10179 | Give CValidationInterface Support for calling notifications on the CScheduler Thread by TheBlueMatt · Pull Request #10179 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] laanwj closed pull request #10226: wallet: Use boost to more portably ensure -wallet specifies only a filename (master...refactor_wallet_pathsep) https://github.com/bitcoin/bitcoin/pull/10226
< bitcoin-git>
bitcoin/master 64c45aa Wladimir J. van der Laan: Merge #10226: wallet: Use boost to more portably ensure -wallet specifies only a filename...
< bitcoin-git>
bitcoin/master a4186dd Luke Dashjr: wallet: Use boost to more portably ensure -wallet specifies only a filename
< gribble>
https://github.com/bitcoin/bitcoin/issues/10226 | wallet: Use boost to more portably ensure -wallet specifies only a filename by luke-jr · Pull Request #10226 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/9494 | Introduce an ArgsManager class encapsulating cs_args, mapArgs and mapMultiArgs by jtimon · Pull Request #9494 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/10189 | devtools/net: add a verifier for scriptable changes. Use it to make CNode::id private. by theuni · Pull Request #10189 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] jtimon opened pull request #10227: Make functions in validation.cpp static: (master...b14-chainparams-validation-static) https://github.com/bitcoin/bitcoin/pull/10227
< bitcoin-git>
[bitcoin] luke-jr opened pull request #10226: wallet: Use boost to more portably ensure -wallet specifies only a filename (master...refactor_wallet_pathsep) https://github.com/bitcoin/bitcoin/pull/10226
<@wumpus>
alternatively, the bitcoin stack exchange can be useful for community support, it doesn't rely on people being who know being around at the time
<@wumpus>
general questions like that belong in#bitcoin
<@wumpus>
yes, wrong channel, this is about concrete development of the source code on github, may be better to ask in #bitcoin-wizards or such
<@wumpus>
yes I tried that about an hour ago, on a few nodes. Please don't repeat yourself. This channel is not for idle bitcoin discussion or technical help but for development discussion
< sipa>
no offence, but this channel is about development of bitcoin core
< NicolasDorier>
sipa: https://github.com/bitcoin/bitcoin/pull/10195 is really too hard to review for me. I think an easier approach for review, would be to make a first PR which only change CCoinView class while making no change to the underlying storage. Then a second PR dealing with the storage change/optimization.
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #10207: Clarify importprivkey help text ... example of blank label without rescan (master...importprivkey) https://github.com/bitcoin/bitcoin/pull/10207
< bitcoin-git>
bitcoin/master 50a1cc0 MarcoFalke: Merge #10207: Clarify importprivkey help text ... example of blank label without rescan...
< bitcoin-git>
bitcoin/master c9e31c3 Warren Togami: Clarify importprivkey help text with example of blank label without rescan...
< morcos>
I'm happy enough to just exclude in all my bitcoin.conf files, but just want to see if everyone else is ok with the leveldb log spam... it prints a lot of useless messages right at startup (where everythign else you care about is printed)
< bitcoin-git>
[bitcoin] TheBlueMatt opened pull request #10221: Stop treating coinbase outputs differently in GUI: show them at 1conf (master...2017-04-no-coinbase-display-lag) https://github.com/bitcoin/bitcoin/pull/10221
<@wumpus>
SopaXorzTaker: good sleuthing, but no, you don't have to be afraid I run random scripts from the internet on anything important, let alone bitcoin-related ones