2016-07-21

< GitHub197> [bitcoin] jtimon closed pull request #8345: Introduce Consensus::GetFlags() and hide IsSuperMajority() (master...0.12.99-consensus-flags) https://github.com/bitcoin/bitcoin/pull/8345
< GitHub111> [bitcoin] NicolasDorier closed pull request #8344: Consensus: Use pindex for ISM check (master...not-using-block) https://github.com/bitcoin/bitcoin/pull/8344
< btcdrak> NicolasDorier: this was the discussion on it https://botbot.me/freenode/bitcoin-core-dev/2016-07-17/?msg=69776851&page=1
< GitHub87> [bitcoin] laanwj closed pull request #8347: Trivial: Make CBlockIndex param const in ContextualCheckBlockHeader and ContextualCheckBlock (master...0.12.99-consensus-const-lost) https://github.com/bitcoin/bitcoin/pull/8347
< GitHub37> bitcoin/master 381917f Wladimir J. van der Laan: Merge #8347: Trivial: Make CBlockIndex param const in ContextualCheckBlockHeader and ContextualCheckBlock...
< GitHub37> bitcoin/master 6f3d616 Jorge Timón: Trivial: Make CBlockIndex param const in ContextualCheckBlockHeader and ContextualCheckBlock
< GitHub37> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/04af3cfe8fa9...381917f610e3
< wumpus> OH I was misreading that, looking at the github page it seemed like jtimon was still adding commits to it, but it says "added a commit to jtimon/bitcoin that referenced this pull request", I think that's new?
< NicolasDorier> wumpus: last is https://github.com/bitcoin/bitcoin/pull/8347 of jtimon and I let you sleep in peace
< GitHub57> [bitcoin] laanwj closed pull request #8341: Consensus: Remove calls to error() from ContextualCheckBlock (master...error-calls) https://github.com/bitcoin/bitcoin/pull/8341
< GitHub43> bitcoin/master 04af3cf Wladimir J. van der Laan: Merge #8341: Consensus: Remove calls to error() from ContextualCheckBlock...
< GitHub43> bitcoin/master 7821889 NicolasDorier: Consensus: Remove calls to error() from ContextualCheckBlock
< GitHub43> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6f4092da80bc...04af3cfe8fa9
< NicolasDorier> wumpus: I just rebased https://github.com/bitcoin/bitcoin/pull/8341 (the second stupid trivial one)
< GitHub69> [bitcoin] laanwj closed pull request #8342: Consensus: Trivial transform BOOST_FOREACH into for loop (master...removeforeach) https://github.com/bitcoin/bitcoin/pull/8342
< GitHub64> bitcoin/master 6f4092d Wladimir J. van der Laan: Merge #8342: Consensus: Trivial transform BOOST_FOREACH into for loop...
< GitHub64> bitcoin/master a3e1984 NicolasDorier: Consensus: Trivial transform BOOST_FOREACH into for loop
< GitHub64> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8e048f40cc25...6f4092da80bc
< NicolasDorier> wumpus: can you merge https://github.com/bitcoin/bitcoin/pull/8342 and https://github.com/bitcoin/bitcoin/pull/8341 when you have time (two trivial already acked commits)

2016-07-20

< GitHub29> [bitcoin] Hektve87 closed pull request #8385: Can't automatically merge (0.8...master) https://github.com/bitcoin/bitcoin/pull/8385
< GitHub51> [bitcoin] Hektve87 opened pull request #8385: Can't automatically merge (0.8...master) https://github.com/bitcoin/bitcoin/pull/8385
< bsm117532> It looks like this test was in Bitcoin around 0.9x and earlier but was removed.
< bsm117532> So, it should trigger segwit deserialization. But bitcoin does not trigger segwit deserialization and I don't see why...
< bsm117532> instagibbs: might as well add the empty-witness check to your PR. https://github.com/instagibbs/bitcoin/blob/txinerr/src/script/interpreter.cpp#L1320
< Chris_Stewart_5> bsm117532: I'm getting confused with actually checking the signature, which has to be an 'unsigned char' https://github.com/bitcoin/bitcoin/blob/master/src/script/interpreter.cpp#L1209
< GitHub167> [bitcoin] instagibbs opened pull request #8384: Add witness data output to TxInError messages (master...txinerr) https://github.com/bitcoin/bitcoin/pull/8384
< GitHub22> [bitcoin] jonasschnelli closed pull request #8382: Fix formatting error (0.13...patch-4) https://github.com/bitcoin/bitcoin/pull/8382
< GitHub69> bitcoin/0.13 66dde4e Jonas Schnelli: Merge #8382: Fix formatting error...
< GitHub69> bitcoin/0.13 ea91961 Chris Moore: Fix formatting error...
< GitHub69> [bitcoin] jonasschnelli pushed 2 new commits to 0.13: https://github.com/bitcoin/bitcoin/compare/ebea65121e6c...66dde4edf733
< bsm117532> Could we remove SCRIPT_VERIFY_WITNESS from this call? https://github.com/bitcoin/bitcoin/blob/master/src/rpc/rawtransaction.cpp#L821
< bsm117532> Running: bitcoin-cli signrawtransaction
< GitHub104> [bitcoin] dooglus opened pull request #8382: Fix formatting error (0.13...patch-4) https://github.com/bitcoin/bitcoin/pull/8382
< Chris_Stewart_5> sipa: I'm looking closer at CBloomFilter, and does nHashFuncs/nTweak need to be prefaced with a compact size int as well? https://github.com/bitcoin/bitcoin/blob/f17032f703288d43a76cffe8fa89b87ade9e3074/src/bloom.h#L50
< GitHub128> [bitcoin] jonasschnelli closed pull request #6481: [mining] allow other signal listeners to provide scripts for mining (master...2015/07/enhance_mining_flexibility) https://github.com/bitcoin/bitcoin/pull/6481
< GitHub65> [bitcoin] jl2012 opened pull request #8381: Make witness v0 outputs non-standard (master...patch-15) https://github.com/bitcoin/bitcoin/pull/8381
< GitHub70> [bitcoin] jafaber opened pull request #8380: fix typo: propagation relay -> delay (0.13...patch-1) https://github.com/bitcoin/bitcoin/pull/8380
< GitHub11> bitcoin/0.13 ebea651 Patrick Strateman: Move SetMinVersion for FEATURE_HD to SetHDMasterKey...
< GitHub11> [bitcoin] laanwj pushed 1 new commit to 0.13: https://github.com/bitcoin/bitcoin/commit/ebea65121e6c62f6b6acd79408a681b987126a0d
< GitHub114> [bitcoin] laanwj closed pull request #8378: [Wallet]Move SetMinVersion for FEATURE_HD to SetHDMasterKey (master...2016-07-19-cwallet-initloadwallet-ordering) https://github.com/bitcoin/bitcoin/pull/8378
< GitHub113> bitcoin/master 8e048f4 Wladimir J. van der Laan: Merge #8378: [Wallet]Move SetMinVersion for FEATURE_HD to SetHDMasterKey...
< GitHub113> bitcoin/master 6523fca Patrick Strateman: Move SetMinVersion for FEATURE_HD to SetHDMasterKey
< GitHub113> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c98abf2c7099...8e048f40cc25
< GitHub104> bitcoin/0.13 f0ff08d Wladimir J. van der Laan: Merge #8379: Remove duplicated name in release notes...
< GitHub104> bitcoin/0.13 48b9208 Johnson Lau: Remove duplicated name in release notes
< GitHub104> [bitcoin] laanwj pushed 2 new commits to 0.13: https://github.com/bitcoin/bitcoin/compare/1fe7f4040781...f0ff08d7841c
< GitHub109> [bitcoin] laanwj closed pull request #8379: Remove duplicated name in release notes (0.13...patch-14) https://github.com/bitcoin/bitcoin/pull/8379
< GitHub102> [bitcoin] jl2012 opened pull request #8379: Remove duplicated name in release notes (0.13...patch-14) https://github.com/bitcoin/bitcoin/pull/8379
< jonasschnelli> <*highlight>[04:46:15] <phantomcircuit:#bitcoin-core-dev> jonasschnelli, fyi qa/rpc-tests/wallet-hd.py passes even when i changed usehd to createhdwallet
< jonasschnelli> [23:45:16] <phantomcircuit:#bitcoin-core-dev> jonasschnelli, why does CHDKeyStore::PrivateKeyDerivation take the keypath as a string?
< Raccoon> | #BITCOIN-DEV |## | MISSES |-  | YOU |\\ | GAVIN, |## | COME |\\ | HOME |-  | ! |::
< GitHub168> bitcoin/0.13 1fe7f40 Cory Fields: build: fix non-deterministic biplist...
< GitHub168> [bitcoin] laanwj pushed 1 new commit to 0.13: https://github.com/bitcoin/bitcoin/commit/1fe7f404078121ad370ec955aa23befa322549bb
< GitHub99> [bitcoin] laanwj closed pull request #8373: Fix OSX non-deterministic dmg (master...biplist-determinism) https://github.com/bitcoin/bitcoin/pull/8373
< GitHub21> bitcoin/master c98abf2 Wladimir J. van der Laan: Merge #8373: Fix OSX non-deterministic dmg...
< GitHub21> bitcoin/master 3b3ce25 Cory Fields: build: fix non-deterministic biplist...
< GitHub21> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/045106b4f13c...c98abf2c7099
< GitHub9> [bitcoin] pstratem opened pull request #8378: Move SetMinVersion for FEATURE_HD to SetHDMasterKey (master...2016-07-19-cwallet-initloadwallet-ordering) https://github.com/bitcoin/bitcoin/pull/8378
< GitHub106> [bitcoin] pstratem opened pull request #8377: Rename usdhd option to createhdwallet (master...2016-07-16-cwallet-createhdwallet) https://github.com/bitcoin/bitcoin/pull/8377
< luke-jr> sipa: if reality is they will, then reality is highly against Bitcoin surviving
< GitHub99> [bitcoin] pstratem opened pull request #8376: Fix exception message to reference actual thrower. (master...2016-07-19-cwallet-sethmasterkey) https://github.com/bitcoin/bitcoin/pull/8376

2016-07-19

< GitHub8> [bitcoin] pstratem opened pull request #8375: Move key derivation logic from GenerateNewKey to DeriveNewKey (master...2016-07-19-cwallet-derivenewkey) https://github.com/bitcoin/bitcoin/pull/8375
< Chris_Stewart_5> Is nFilterBytes suppose to be a compact sized unsigned integer on this documentation? https://bitcoin.org/en/developer-reference#filterload
< achow101> ab0a5e271e81fb48cf355f866a105eca12713260e703da35330ae66e03336367 bitcoin-osx-0.13-res.yml
< achow101> 0269f915640886ba16c73450ab2dbcdde0304fa79807414c7e0cf4d4ba8f39df src/bitcoin-0.13.99.tar.gz
< achow101> fc5a233b3be260ec7be63f699bbc128240ad190692cd5d4a82cc1352eb3c57df bitcoin-0.13.99-osx64.tar.gz
< achow101> e2e33efea3d2c86d34391b3be20d032343b359909cdbe55b1153ba109ae5af4f bitcoin-0.13.99-osx-unsigned.tar.gz
< achow101> 9fa6b31128eee2cfa535774fe4eebaa384f0471c094ce6ee6aefe9aef93f134b bitcoin-0.13.99-osx-unsigned.dmg
< GitHub18> [bitcoin] sdaftuar opened pull request #8374: Add release notes for mining changes (0.13...release-notes-mining) https://github.com/bitcoin/bitcoin/pull/8374
< GitHub16> [bitcoin] theuni opened pull request #8373: Fix OSX non-deterministic dmg (master...biplist-determinism) https://github.com/bitcoin/bitcoin/pull/8373
< cfields> achow101 / jonasschnelli: either of you have the bitcoin-0.13.0-osx-unsigned.tar.gz available?
< achow101> cfields: everything I built is at https://github.com/achow101/bitcoin/releases/tag/v0.13.0rc1. sigs have been PR'ed
< GitHub185> [bitcoin] UdjinM6 opened pull request #8372: Fix AddRef() usage for CNode (master...fixNodeRefCount) https://github.com/bitcoin/bitcoin/pull/8372
< MarcoFalke> three builders, three different bitcoin-0.13.0-osx-unsigned.tar.gz
< GitHub182> [bitcoin] jonasschnelli opened pull request #8371: [Qt] Add out-of-sync modal info layer (master...2016/07/UI-out-of-sync) https://github.com/bitcoin/bitcoin/pull/8371
< wumpus> compiling bitcoin is quite CPU intensive, so the i/o overhead may be very little in comparison, it may not be the same for every project
< jonasschnelli> 19499e5a569d5d8685a043bf3e5cf9d34450733333295b636af84d7a2589d881 bitcoin-0.13.0-x86_64-linux-gnu.tar.gz
< jonasschnelli> linux build complete: hashes to compare: https://bitcoin.jonasschnelli.ch/releasebuilds/v0.13.0rc1/
< wumpus> yes --url bitcoin=${URI} --commit bitcoin=${COMMIT} can be very useful. You can also use local paths.
< jonasschnelli> stuff like: --url bitcoin="+giturl+"
< jonasschnelli> I had to add some html / apaxy hacks to get the html pages up: https://bitcoin.jonasschnelli.ch/releasebuilds/v0.13.0rc1/
< GitHub180> [bitcoin] jonasschnelli opened pull request #8369: [FOR LATER USE][WIP][Wallet] add support for a flexible "set of features" (master...2016/07/wallet_features) https://github.com/bitcoin/bitcoin/pull/8369
< * MarcoFalke> googles "release process bitcoin" and copies the commands
< GitHub184> bitcoin/0.13 d6bb231 Wladimir J. van der Laan: Merge #8360: doc: Add a few items to release notes...
< GitHub126> [bitcoin] laanwj closed pull request #8360: doc: Add a few items to release notes (0.13...2016_07_release_notes) https://github.com/bitcoin/bitcoin/pull/8360
< GitHub184> bitcoin/0.13 ded0599 Wladimir J. van der Laan: doc: Add a few items to release notes...
< GitHub184> [bitcoin] laanwj pushed 2 new commits to 0.13: https://github.com/bitcoin/bitcoin/compare/ec8f5fc8b5f6...d6bb231a9fa9
< GitHub184> bitcoin/0.13 ec8f5fc Wladimir J. van der Laan: doc: Add list of pulls and authors to release notes
< GitHub184> [bitcoin] laanwj pushed 1 new commit to 0.13: https://github.com/bitcoin/bitcoin/commit/ec8f5fc8b5f68ddf7fed0d74a5ec82e6b03f7f92
< GitHub48> bitcoin/0.13 24f117e Wladimir J. van der Laan: Merge #8366: [0.13] [Wallet] Ensure <0.13 clients can't open HD wallets...
< GitHub48> bitcoin/0.13 3b38a6a Jonas Schnelli: [Wallet] Ensure <0.13 clients can't open HD wallets
< GitHub68> [bitcoin] laanwj closed pull request #8366: [0.13] [Wallet] Ensure <0.13 clients can't open HD wallets (0.13...2016/07/hd_minversion) https://github.com/bitcoin/bitcoin/pull/8366
< GitHub48> [bitcoin] laanwj pushed 2 new commits to 0.13: https://github.com/bitcoin/bitcoin/compare/fca1a415cec6...24f117ef05f5
< GitHub41> [bitcoin] laanwj closed pull request #8367: [Wallet] Ensure <0.13 clients can't open HD wallets (master...2016/07/hd_minversion_014) https://github.com/bitcoin/bitcoin/pull/8367
< GitHub123> bitcoin/master 045106b Wladimir J. van der Laan: Merge #8367: [Wallet] Ensure <0.13 clients can't open HD wallets...
< GitHub123> bitcoin/master a4f137f Jonas Schnelli: [Wallet] Ensure <0.13 clients can't open HD wallets
< GitHub123> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ca7550e128a3...045106b4f13c
< GitHub24> bitcoin/0.13 fca1a41 Suhas Daftuar: Rename "block cost" to "block weight"...
< GitHub24> [bitcoin] laanwj pushed 1 new commit to 0.13: https://github.com/bitcoin/bitcoin/commit/fca1a415cec6b7655448ce8b30778784ab4c181e
< GitHub19> [bitcoin] laanwj closed pull request #8363: Rename "block cost" to "block weight" (master...cost-to-weight) https://github.com/bitcoin/bitcoin/pull/8363
< GitHub70> bitcoin/master ca7550e Wladimir J. van der Laan: Merge #8363: Rename "block cost" to "block weight"...
< GitHub70> bitcoin/master 2c06bae Suhas Daftuar: Rename "block cost" to "block weight"
< GitHub70> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5e3557b8e363...ca7550e128a3
< GitHub99> [bitcoin] laanwj closed pull request #8361: Some 0.13 release notes about p2p changes (0.13...relnotes-0.13) https://github.com/bitcoin/bitcoin/pull/8361
< GitHub114> bitcoin/0.13 a07c8a0 Wladimir J. van der Laan: Merge #8361: Some 0.13 release notes about p2p changes...
< GitHub114> bitcoin/0.13 df85463 Pieter Wuille: Some 0.13 release notes about p2p changes
< GitHub114> [bitcoin] laanwj pushed 2 new commits to 0.13: https://github.com/bitcoin/bitcoin/compare/37269105c881...a07c8a032c0d

2016-07-18

< GitHub83> [bitcoin] jonasschnelli opened pull request #8367: [Wallet] Ensure <0.13 clients can't open HD wallets (master...2016/07/hd_minversion_014) https://github.com/bitcoin/bitcoin/pull/8367
< GitHub57> [bitcoin] jonasschnelli closed pull request #8343: [Wallet] Ensure <0.13 clients can't open HD wallets (master...2016/07/hd_minversion) https://github.com/bitcoin/bitcoin/pull/8343
< GitHub175> [bitcoin] jonasschnelli opened pull request #8366: [Wallet] Ensure <0.13 clients can't open HD wallets (0.13...2016/07/hd_minversion) https://github.com/bitcoin/bitcoin/pull/8366
< GitHub89> [bitcoin] sipa opened pull request #8365: Treat high-sigop transactions as larger rather than rejecting them (master...unifysigopcost) https://github.com/bitcoin/bitcoin/pull/8365
< GitHub50> [bitcoin] f139975 opened pull request #8364: Fix counting of sigops cost in mempool check (master...fix-mempool-sigops) https://github.com/bitcoin/bitcoin/pull/8364
< GitHub36> [bitcoin] sdaftuar opened pull request #8363: Rename "block cost" to "block weight" (master...cost-to-weight) https://github.com/bitcoin/bitcoin/pull/8363
< luke-jr> of prior versions of Bitcoin
< GitHub116> [bitcoin] sdaftuar opened pull request #8362: Scale legacy sigop count in CreateNewBlock (master...coinbase-sigops-scale) https://github.com/bitcoin/bitcoin/pull/8362
< sdaftuar> sipa: luke-jr: speaking of sigops, i just noticed this, looks like a bug? https://github.com/bitcoin/bitcoin/blob/master/src/miner.cpp#L190
< jonasschnelli> ah... IBD is also true if I start bitcoin-core with 200 blocks behind. Right?
< GitHub87> [bitcoin] sipa opened pull request #8361: Some 0.13 release notes about p2p changes (0.13...relnotes-0.13) https://github.com/bitcoin/bitcoin/pull/8361
< GitHub75> [bitcoin] laanwj opened pull request #8360: doc: Add a few items to release notes (0.13...2016_07_release_notes) https://github.com/bitcoin/bitcoin/pull/8360
< GitHub181> [bitcoin] laanwj pushed 1 new commit to 0.13: https://github.com/bitcoin/bitcoin/commit/37269105c8817a2922410ec17d976263cd589987
< GitHub181> bitcoin/0.13 3726910 Wladimir J. van der Laan: build: Release notes update...
< GitHub24> bitcoin/master 5e3557b Wladimir J. van der Laan: doc: Clean out release notes...
< GitHub24> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/5e3557b8e36308a27dbeb528569abe638c4d01dd
< wumpus> for 0.13 there's still plenty of work to do for the release notes: https://github.com/bitcoin/bitcoin/issues/7678
< GitHub85> bitcoin/master 6c0336c Wladimir J. van der Laan: build: bump version to 0.13.99...
< GitHub85> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/6c0336c7723da274c8312b82ed2a138f5d57158f
< GitHub83> bitcoin/master e4382fb Wladimir J. van der Laan: qt: periodic translations update
< GitHub83> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/e4382fbef56a0e04b0ed834e8b3a3a16f81db149
< GitHub184> [bitcoin] laanwj closed pull request #8359: mining: Improve `-blockmaxcost` help message (master...2016_07_blockmaxcost_doc) https://github.com/bitcoin/bitcoin/pull/8359
< GitHub67> bitcoin/master 03c56f6 Wladimir J. van der Laan: Merge #8359: mining: Improve `-blockmaxcost` help message...
< GitHub67> bitcoin/master 8cef5bd Wladimir J. van der Laan: mining: Improve `-blockmaxcost` help message...
< GitHub67> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8cb288a6b37d...03c56f62c2fd
< GitHub7> [bitcoin] laanwj opened pull request #8359: mining: Improve `-blockmaxcost` help message (master...2016_07_blockmaxcost_doc) https://github.com/bitcoin/bitcoin/pull/8359
< GitHub191> [bitcoin] MarcoFalke opened pull request #8358: [doc] gbuild: Set memory explicitly (default is too low) (master...Mf1607-docBuild) https://github.com/bitcoin/bitcoin/pull/8358
< GitHub77> [bitcoin] laanwj closed pull request #8354: mining: Rename `-blockmaxcost` to `-blockmaxweight` (master...2016_07_block_weight) https://github.com/bitcoin/bitcoin/pull/8354
< GitHub20> [bitcoin] MarcoFalke closed pull request #7615: [WIP] [wallet] Couple minimum change with minimum relay fee (master...Mf1602-walletMinChange) https://github.com/bitcoin/bitcoin/pull/7615
< GitHub49> [bitcoin] laanwj closed pull request #8320: Fix 0.12 release notes on block relaying (master...0.12-release-notes-block-relaying) https://github.com/bitcoin/bitcoin/pull/8320
< GitHub5> bitcoin/master 8cb288a Wladimir J. van der Laan: Merge #8320: Fix 0.12 release notes on block relaying...
< GitHub5> bitcoin/master d6dc1bc Krzysztof Jurewicz: Fix 0.12 release notes on block relaying...
< GitHub5> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f5660d381a37...8cb288a6b37d
< GitHub127> [bitcoin] maiiz opened pull request #8357: Update coins.cpp (master...maiiz-patch-1) https://github.com/bitcoin/bitcoin/pull/8357
< GitHub190> [bitcoin] NicolasDorier opened pull request #8356: Wallet: Minimum output value depends on fee instead of minTxRelayFee (master...wallet-min-output) https://github.com/bitcoin/bitcoin/pull/8356
< GitHub94> [bitcoin] maiiz closed pull request #8355: [Wallet]fix relaypriority calculation error Issues #8334 (master...issues-8334) https://github.com/bitcoin/bitcoin/pull/8355
< GitHub46> [bitcoin] maiiz opened pull request #8355: [Wallet]fix relaypriority calculation error Issues #8334 (master...issues-8334) https://github.com/bitcoin/bitcoin/pull/8355
< GitHub37> [bitcoin] laanwj closed pull request #8295: Mining-related fixups for 0.13.0 (master...cnb-segwit) https://github.com/bitcoin/bitcoin/pull/8295
< GitHub81> bitcoin/master d2e46e1 Suhas Daftuar: Remove addScoreTxs()
< GitHub81> bitcoin/master 6dd4bc2 Suhas Daftuar: Exclude witness transactions in addPackageTxs() pre-segwit activation
< GitHub81> bitcoin/master f15c2cd Suhas Daftuar: CreateNewBlock: add support for size-accounting to addPackageTxs...
< GitHub81> [bitcoin] laanwj pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/238300b39894...f5660d381a37
< GitHub68> [bitcoin] laanwj opened pull request #8354: mining: Rename `-blockmaxcost` to `-blockmaxweight` (master...2016_07_block_weight) https://github.com/bitcoin/bitcoin/pull/8354
< GitHub6> [bitcoin] laanwj closed pull request #8323: Add HD keypath to CKeyMetadata, report metadata in validateaddress (master...2016/07/hd_013) https://github.com/bitcoin/bitcoin/pull/8323
< GitHub1> bitcoin/master 986c223 Jonas Schnelli: [Wallet] print hd masterkeyid in getwalletinfo
< GitHub1> bitcoin/master b1c7b24 Jonas Schnelli: [Wallet] report optional HDKeypath/HDMasterKeyId in validateaddress
< GitHub1> bitcoin/master 5b95dd2 Jonas Schnelli: [Wallet] extend CKeyMetadata with HD keypath
< GitHub1> [bitcoin] laanwj pushed 7 new commits to master: https://github.com/bitcoin/bitcoin/compare/37303934fe8f...238300b39894
< GitHub135> [bitcoin] laanwj closed pull request #8305: Improve handling of unconnecting headers (master...fix-relay-2hr-rule) https://github.com/bitcoin/bitcoin/pull/8305
< GitHub121> bitcoin/master 3730393 Wladimir J. van der Laan: Merge #8305: Improve handling of unconnecting headers...
< GitHub121> bitcoin/master e91cf4b Suhas Daftuar: Add test for handling of unconnecting headers
< GitHub121> bitcoin/master 96fa953 Suhas Daftuar: Improve handling of unconnecting headers...
< GitHub121> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/bc94b8748782...37303934fe8f
< GitHub157> [bitcoin] maiiz closed pull request #8336: TX fees and policy: fix relaypriority calculation error Issues #8334 (master...issues-8334) https://github.com/bitcoin/bitcoin/pull/8336
< GitHub30> [bitcoin] Tyler-Hardin closed pull request #8349: Qt: Clearer warning about being out of sync (master...issue8060) https://github.com/bitcoin/bitcoin/pull/8349

2016-07-17

< GitHub65> [bitcoin] yurizhykin opened pull request #8353: Trivial: tiny c++11 refactors (master...cpp11) https://github.com/bitcoin/bitcoin/pull/8353
< GitHub139> [bitcoin] Gitju opened pull request #8352: Trivial: Fix typo in bitcoin_es_UY.ts (master...patch-1) https://github.com/bitcoin/bitcoin/pull/8352
< jtimon> well, at the very least we have to maintain this failure: https://github.com/bitcoin/bitcoin/blob/master/src/main.cpp#L3547 don't we?
< GitHub36> [bitcoin] Tyler-Hardin opened pull request #8349: Qt: Clearer warning about being out of sync (master...issue8060) https://github.com/bitcoin/bitcoin/pull/8349
< GitHub171> [bitcoin] jtimon opened pull request #8348: Trivial: Segwit: Don't call IsWitnessEnabled from ContextualCheckBlock (master...0.12.99-consensus-segwit) https://github.com/bitcoin/bitcoin/pull/8348

2016-07-16

< GitHub197> [bitcoin] jtimon opened pull request #8347: Trivial: Make CBlockIndex param const in ContextualCheckBlockHeader and ContextualCheckBlock (master...0.12.99-consensus-const-lost) https://github.com/bitcoin/bitcoin/pull/8347
< GitHub25> [bitcoin] jtimon opened pull request #8346: Mempool: Use Consensus::CheckTxInputs direclty over main::CheckInputs (master...0.12.99-consensus-mempool-checks) https://github.com/bitcoin/bitcoin/pull/8346
< GitHub120> [bitcoin] jtimon opened pull request #8345: Introduce Consensus::GetFlags() and hide IsSuperMajority() (master...0.12.99-consensus-flags) https://github.com/bitcoin/bitcoin/pull/8345
< GitHub167> [bitcoin] NicolasDorier opened pull request #8344: Consensus: Use pindex for ISM check (master...not-using-block) https://github.com/bitcoin/bitcoin/pull/8344
< luke-jr> why was https://github.com/bitcoin/bitcoin/pull/7774 merged? :/

2016-07-15

< GitHub55> [bitcoin] jonasschnelli opened pull request #8343: [Wallet] Ensure <0.13 clients can't open HD wallets (master...2016/07/hd_minversion) https://github.com/bitcoin/bitcoin/pull/8343
< GitHub167> [bitcoin] NicolasDorier opened pull request #8342: Consensus: Trivial transform BOOST_FOREACH into for loop (master...removeforeach) https://github.com/bitcoin/bitcoin/pull/8342
< GitHub29> [bitcoin] NicolasDorier opened pull request #8341: Consensus: Remove calls to error() from ContextualCheckBlock (master...error-calls) https://github.com/bitcoin/bitcoin/pull/8341
< superduper> SUPER AMAZING! I can multiply your bitcoin using block-chain exploding technology. Send me some BTC and get MUCH more back! WOW! PM me to begin!

2016-07-14

< GitHub177> [bitcoin] jtimon closed pull request #8328: Consensus: Rename: Move consensus code to the consensus directory (master...0.12.99-consensus-rename) https://github.com/bitcoin/bitcoin/pull/8328
< jtimon> so it seems the consensus folder thing is not clear, see? not that hard to say no fast, closing #8328 and taking the renames out of https://github.com/jtimon/bitcoin/commits/0.12.99-consensus (and #8329 and #8337 )
< bsm117532> wumpus: FWIW I'm working on a commercial product that will include a bitcoin full node. It needs to fund transactions for many users, so the "label" idea sounds appropriate. But, I'll mostly be querying txids. (Which is one reason I've been working on getting segwit into python-bitcoinlib)
< petertodd> maaku: fwiw, I already do that kind of separation in python-bitcoinlib, with everything consensus under bitcoin.core
< petertodd> maaku: that's how I learned how the bitcoin protocol works
< petertodd> maaku: my usual advice to people is to follow the block acceptance logic and read the consensus code to understand how the bitcoin protocol works
<@wumpus> well if bitcoin core's wallet is unusable for commercial use, I wonder what wallet is..
< gmaxwell> I was getting flammed on reddit that it's common knoweldge that bitcoin core's wallet was unusuable for commercial use. I tried to get some unpacking there: https://www.reddit.com/r/Bitcoin/comments/4snk48/roger_ver_and_his_supporters_are_pushing_policies/d5bb73w?context=3 might be worth looking at the comments.
< petertodd> gmaxwell: well, my advice is to either use a lite-client w/ up-to-date full node, or if you're using bitcoin core, plan to put it behind an up-to-date node
< jtimon> btcdrak: I didn't knew, never used the bitcoin slack
<@wumpus> and it's not used anywhere yet in bitcoin
<@wumpus> sdaftuar: I don't think all items of https://github.com/bitcoin/bitcoin/issues/8294 are currenly being addressed in PRs?
<@wumpus> #link https://github.com/bitcoin/bitcoin/pull/8295 Mining-related fixups for 0.13.0 also by sdaftuar
<@wumpus> #link https://github.com/bitcoin/bitcoin/pull/8305 Improve handling of unconnecting headers by sdaftuar
< gmaxwell> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier
< sdaftuar> bsm2357: you might find it helpful to review the p2p-segwit.py test in qa/rpc-tests, see for instance https://github.com/bitcoin/bitcoin/blob/master/qa/rpc-tests/p2p-segwit.py#L1236
< cool_guy> ASTOUNDING! I have discovered blockchain exploding technology. Send me your bitcoin and I will return MUCH more back to you, INSTANTLY. This is totally legitimate & vouched by the OPS of this channel. PM me to begin!
< jtimon> I believe we need it for this single error message: https://github.com/bitcoin/bitcoin/blob/master/src/main.cpp#L1959
< jtimon> first step is completing libconsensus while allowing bitcoin core to keep using its internals
< jtimon> sipa: yeah at some point if we want to completely separate libconsensus, after bitcoin core itself calls its API, I see no other option than to duplicate some of the code in bitcoin core, but seems too far away in the future to be a big concern
< jtimon> I think it takes less time to read the changes in the makefile https://github.com/bitcoin/bitcoin/pull/8328/files#diff-480477e89f9b6ddafb30c4383dcdd705R90 than explaining but whatever...
< jtimon> if people can't review the trivial things then they will never review the cool stuff like https://github.com/jtimon/bitcoin/commit/4215929d563097f19d8059dff8b0f7d5ba7aee59
< jonasschnelli> sipa: while you are around (heh!), mind doing a quick review on https://github.com/bitcoin/bips/compare/master...jonasschnelli:2016/07/bip151_hkdf? Only technical, language will be checked by Jonathan Cross
< jtimon> in https://github.com/jtimon/bitcoin/commits/0.12.99-consensus there are big architectural changes though
< jtimon> NicolasDorier: updated https://github.com/jtimon/bitcoin/commits/0.12.99-consensus VerifyTx just lacks CheckTransaction (because it would be redundant with the call in CheckBlock()) now in there
< GitHub199> [bitcoin] laanwj closed pull request #8324: [Wallet] keep HD seed during salvagewallet (master...2016/07/hd_salvage) https://github.com/bitcoin/bitcoin/pull/8324
< GitHub179> bitcoin/master bc94b87 Wladimir J. van der Laan: Merge #8324: [Wallet] keep HD seed during salvagewallet...
< GitHub179> bitcoin/master b993671 Jonas Schnelli: [Wallet] keep HD seed during salvagewallet
< GitHub179> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/af9b7a9f2f73...bc94b8748782
< GitHub111> [bitcoin] MarcoFalke closed pull request #8340: [qa] Solve trivial merge conflict in p2p-segwit.py (master...Mf1607-qaSolveMerge) https://github.com/bitcoin/bitcoin/pull/8340
< GitHub128> bitcoin/master af9b7a9 MarcoFalke: Merge #8340: [qa] Solve trivial merge conflict in p2p-segwit.py...
< GitHub128> bitcoin/master 66668c4 MarcoFalke: [qa] Solve merge conflict of 4324bd237c3147fc153ba5046c211f03e8ac956a
< GitHub128> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ca40ef6029c1...af9b7a9f2f73
< GitHub51> [bitcoin] MarcoFalke opened pull request #8340: [qa] Solve merge conflict of 4324bd237c3147fc153ba5046c211f03e8ac956a (master...Mf1607-qaSolveMerge) https://github.com/bitcoin/bitcoin/pull/8340
< GitHub79> [bitcoin] laanwj closed pull request #8312: Fix mempool DoS vulnerability from malleated transactions (master...mempool-malleability) https://github.com/bitcoin/bitcoin/pull/8312
< GitHub56> bitcoin/master ca40ef6 Wladimir J. van der Laan: Merge #8312: Fix mempool DoS vulnerability from malleated transactions...
< GitHub56> bitcoin/master 46c9620 Suhas Daftuar: Test that unnecessary witnesses can't be used for mempool DoS...
< GitHub56> bitcoin/master bb66a11 Suhas Daftuar: Fix DoS vulnerability in mempool acceptance...
< GitHub56> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/4324bd237c31...ca40ef6029c1
< GitHub181> [bitcoin] laanwj closed pull request #8311: Rename CTxinWitness -> CTxInWitness (master...CTxInWitness) https://github.com/bitcoin/bitcoin/pull/8311
< GitHub15> bitcoin/master 4324bd2 Wladimir J. van der Laan: Merge #8311: Rename CTxinWitness -> CTxInWitness...
< GitHub15> bitcoin/master 36ae37a Bob McElrath: Rename CTxinWitness -> CTxInWitness
< GitHub15> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1bc9c8085f71...4324bd237c31
< GitHub138> [bitcoin] laanwj closed pull request #8271: [bugfix] Do not send witnesses in cmpctblock (master...nowitnesscb) https://github.com/bitcoin/bitcoin/pull/8271
< GitHub69> bitcoin/master 1bc9c80 Wladimir J. van der Laan: Merge #8271: [bugfix] Do not send witnesses in cmpctblock...
< GitHub69> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4831a16223db...1bc9c8085f71
< GitHub69> bitcoin/master 252675e Pieter Wuille: Do not send witnesses in cmpctblock
< GitHub118> [bitcoin] NicolasDorier opened pull request #8339: Consensuslib: Block Verify / Transaction Verify [Work in progress] (master...blkconsensus) https://github.com/bitcoin/bitcoin/pull/8339
< phantomcircuit> i tried that first and somehow screwed it up so i ended up copying bitcoin-tx stuff but that's not great cause i actually do want multiple executables

2016-07-13

< shangzhou> sipa: the bitcoin.sipa.be data looks like not up to date
< MiraclePerson> SUPER!!!! Want more bitcoin? Send me some Bitcoin and I'll instantly send you MORE back. I use special block-chain exploding skills. Totally safe & secure. Vouched by all the OPS! Pm me to begin!
< shatoshi> INCREDIBLE! Send me some bitcoin and I can turn it into MUCH more, using special blockchain accelerating technology. Your bitcoin wallet will explode! Guaranteed to work & vouched by the OPS. PM me to begin!
< sipa> ack, let's move to #bitcoin
< petertodd> sipa: note that the change from longest-chain to most-work was in 0.3.3 https://github.com/bitcoin/bitcoin/commit/40cd0369419323f8d7385950e20342e998c994e1#diff-623e3fd6da1a45222eeec71496747b31R420
< xinxi_> i mean, if a Bitcoin client of a very low version sees a block generated by the newest version of Bitcoin client, what will happen?
< petertodd> xinxi_: (modulo radical redesigns of how bitcoin works, like my client-side validation concepts)
< petertodd> sipa: example: the switch to most-work-chain from bitcoin 0.1's longest-chain rule is something I'd definitely call a hard-fork
< petertodd> xinxi_: (there is a "bitcoin foundation", but they don't pay anyone, and are essentially bankrupt last I checked)
< petertodd> xinxi_: many do - there's no "bitcoin foundation" that pays core developers, but there's lots of ways to get paid
< xinxi_> petertodd: So Bitcoin Core developers get paid?
< sipa> xinxi_: by 'scripting' we mean bitcoin Script here, which is the language used inside transaction outputs to describe the condition under which they can be spent
< petertodd> xinxi_: I'm a consultant, who works pretty much full time on contracts in this space (including Bitcoin Core development contracts)
< petertodd> xinxi_: for example basically all my scalability research is stuff that I do knowing full well that it may never be able to be deployed on bitcoin
< petertodd> xinxi_: whereas if you want high certainty of being able to deploy your work in production on bitcoin, you'll need to set your sights lower to thinks that can be done in a soft-fork
< petertodd> xinxi_: I'm just saying, that anything that for any work you do that may require a hard-fork to deploy, you should accept that you may need to create a new currency, economically distint from bitcoin, to deploy your work in production
< petertodd> xinxi_: I'd suggest you take that kind of discussion to #bitcoin-wizards at least
< xinxi_> i need to make sure that tremendous amount of effort that could make Bitcoin even greater will be deployed.
< sipa> it is off topic for the developer of bitcoin core, which is what this channel is about
< jtimon> yep, sorry, #bitcoin I guess
< jeremyrubin> xinxi_: probably discuss this on #bitcoin
< sturles> xinxi_: All bitcoin users.
< jtimon> xinxi_: here's a few different ways to coordinate activation, the last 3 in there use bip 9 : https://github.com/jtimon/bitcoin/blob/0.12.99-consensus/src/consensus/versionbits.cpp#L172
< Chris_Stewart_5> sipa: Is there documentation for addrman any where? Doesn't seem to be in the p2p networking part: https://bitcoin.org/en/developer-reference#p2p-network
< xinxi_> jtimon: cool. so all the code in libconsensus is in this directory https://github.com/jtimon/bitcoin/tree/0.12.99-consensus/src/consensus, right?
< jtimon> xinxi_: right now the longest branch I have is https://github.com/jtimon/bitcoin/tree/0.12.99-consensus but I still have things to cherry pick from https://github.com/jtimon/bitcoin/commits/jt (plus some things that will just have to be new)
< bsm2357> Hmmm. Taking this question to #bitcoin-dev.
< jtimon> and I will continue in https://github.com/jtimon/bitcoin/tree/0.12.99-consensus but I won't open more PRs for now
< jtimon> kanzure: NicolasDorier: https://github.com/bitcoin/bitcoin/pull/8337
< GitHub147> [bitcoin] jtimon reopened pull request #8328: Consensus: Rename: Move consensus code to the consensus directory (master...0.12.99-consensus-rename) https://github.com/bitcoin/bitcoin/pull/8328
< GitHub12> [bitcoin] jtimon closed pull request #8328: Consensus: Rename: Move consensus code to the consensus directory (master...0.12.99-consensus-rename) https://github.com/bitcoin/bitcoin/pull/8328
< jonasschnelli> sipa, gmaxwell: maybe you find time to quickly review the BIP151 switch from HMAC_SHA512 "KDF" to HKDF: https://github.com/bitcoin/bips/compare/master...jonasschnelli:2016/07/bip151_hkdf?expand=1
< jonasschnelli> sipa, gmaxwell: mind doing a review of https://github.com/bitcoin/bitcoin/pull/8323? I'd like and I think its important to have this in 0.13