< July 2025 >
Su Mo Tu We Th Fr Sa 12345678910111213 14 15 16 17 18 19
20 21 22 23 24 25 26
27 28 29 30 31
2017-06-07
< bitcoin-git>
[bitcoin] sipa closed pull request #10523: Perform member initialization in initialization lists where possible (master...initialization-list) https://github.com/bitcoin/bitcoin/pull/10523
< bitcoin-git>
bitcoin/master be3e042 Pieter Wuille: Merge #10523: Perform member initialization in initialization lists where possible...
< bitcoin-git>
bitcoin/master 656dbd8 practicalswift: Perform member initialization in initialization lists where possible
< bitcoin-git>
[bitcoin] practicalswift opened pull request #10545: Use list initialization (C++11) for maps/vectors instead of boost::assign::map_list_of/list_of (master...list_of) https://github.com/bitcoin/bitcoin/pull/10545
< bitcoin-git>
[bitcoin] laanwj closed pull request #10201: pass Consensus::Params& to functions in validation.cpp and make them static (master...consensusparams-receivedblocktransactions) https://github.com/bitcoin/bitcoin/pull/10201
< bitcoin-git>
bitcoin/master 1b708f2 Wladimir J. van der Laan: Merge #10201: pass Consensus::Params& to functions in validation.cpp and make them static...
< bitcoin-git>
bitcoin/master 24980a3 Mario Dian: Make functions in validation.cpp static and pass chainparams...
< bitcoin-git>
[bitcoin] jnewbery opened pull request #10540: Salvage wallet should not set the aggressive flag on Db::verify() (master...fixsalvage) https://github.com/bitcoin/bitcoin/pull/10540
< bitcoin-git>
[bitcoin] laanwj closed pull request #10539: doc: Mention update manpages in release process (master...2017_06_release_process_manpage_update) https://github.com/bitcoin/bitcoin/pull/10539
< bitcoin-git>
[bitcoin] laanwj opened pull request #10539: doc: Mention update manpages in release process (master...2017_06_release_process_manpage_update) https://github.com/bitcoin/bitcoin/pull/10539
< bitcoin-git>
bitcoin/0.14 5e408d9 Wladimir J. van der Laan: doc: Update manpages for 0.14.2
< bitcoin-git>
[bitcoin] TheBlueMatt opened pull request #10537: Few Minor per-utxo assert-semantics re-adds and tweak (master...2017-06-per-utxo-fixes) https://github.com/bitcoin/bitcoin/pull/10537
2017-06-05
< bitcoin-git>
[bitcoin] practicalswift opened pull request #10536: Remove unreachable or otherwise redundant code (master...unreachable) https://github.com/bitcoin/bitcoin/pull/10536
< bitcoin-git>
[bitcoin] practicalswift closed pull request #10527: Use parentheses to clarify intended precedence when using bitwise operations (master...clarify-precedence) https://github.com/bitcoin/bitcoin/pull/10527
< bitcoin-git>
[bitcoin] achow101 opened pull request #10533: [tests] Use cookie auth instead of rpcuser and rpcpassword (master...tests-use-cookie-auth) https://github.com/bitcoin/bitcoin/pull/10533
< BlueMatt>
;;later tell sipa sipa__ is it just my C++11-lack-of-sanity, or am I suppose to find https://github.com/bitcoin/bitcoin/blob/master/src/coins.cpp#L99 gross as fuck? std::move(it->second.coin) then a few lines later it->second.coin.function_call()?
< spudowiar>
I'm not talking about the RPC interface Bitcoin Core normally uses
< spudowiar>
Then on first run, Bitcoin Core could allow you to select a vendor and then a device
< spudowiar>
I'm also going to add a listhwwdevices which could be used on the first run to list all the devices so Bitcoin Core can ask the user to select one
< bitcoin-git>
[bitcoin] pavlosantoniou opened pull request #10530: Fix possibly unsafe accesses of array in class base_uint<BITS>. (master...master) https://github.com/bitcoin/bitcoin/pull/10530
< sipa>
for historical reasons, bitcoin treats txids as little-endian 256-bit numbers, and when printing them for human consumption, uses big-endian (because that's how we format numbers)
< bitcoin-git>
[bitcoin] practicalswift opened pull request #10527: Use parentheses to clarify intended precedence when using bitwise operations (master...clarify-precedence) https://github.com/bitcoin/bitcoin/pull/10527
< spudowiar>
One issue with this patch is that it runs on the UI thread so Bitcoin-Qt hangs while you confirm it on the hardware wallet
< spudowiar>
The command is `src/qt/bitcoin-qt -testnet -hardwarewallet=contrib/bitcoin-hww-trezor`
< gmaxwell>
luke-jr: perhaps you should take it seriously when many people are telling you that this is a lot like Bitcoin XT or Bitcoin Classic's hardfork, but you've just defined yourself into a corner.
< spudowiar>
One issue I have is that waiting for the output of the command is run on the UI thread, so Bitcoin Core appears to hang :/
< bitcoin-git>
[bitcoin] practicalswift opened pull request #10523: Perform member initialization in initialization lists where possible (master...initialization-list) https://github.com/bitcoin/bitcoin/pull/10523
< spudowiar>
It's basically mimicking the API, because you could just as easily have the HWW plugin connect to the Bitcoin Core over HTTP RPC
< spudowiar>
luke-jr: Because then you can do "Bitcoin Core asks HWW signrawtransaction", "HWW asks Bitcoin Core gettransaction", "HWW responds to signrawtransaction"
< spudowiar>
But I could do stdin, stdout and a file descriptor for a socket (to the Bitcoin daemon RPC server)
< bitcoin-git>
[bitcoin] jonasschnelli opened pull request #10517: Factor out CCoinsView based AreInputsStandard/IsWitnessStandard (master...2017/06/policy_compile) https://github.com/bitcoin/bitcoin/pull/10517
< gmaxwell>
spudowiar: but you can't do anything with bitcoin transactions without also having bitcoin transaction ser/des support! and then you have to worry about that your json format cannot losslessly represent a transaction. Decoderawtransaction cannot. E.g. it can't encoding different choices for encoding in varints.
< bitcoin-git>
[bitcoin] sipa closed pull request #10500: Avoid CWalletTx copies in GetAddressBalances and GetAddressGroupings (master...pr/wtxcopy) https://github.com/bitcoin/bitcoin/pull/10500
< bitcoin-git>
bitcoin/master 098b01d Pieter Wuille: Merge #10500: Avoid CWalletTx copies in GetAddressBalances and GetAddressGroupings...
< bitcoin-git>
bitcoin/master b9b814a Russell Yanofsky: Avoid CWalletTx copies in GetAddressBalances and GetAddressGroupings
< spudowiar>
If there's an error, it returns a non-zero status and the message on stdin is used as the failure message in Bitcoin Core
< spudowiar>
Then Bitcoin Core verifies that
< gmaxwell>
uh? perhaps but you have to be able to handle the bitcoin seralization in order to compute any hashes over it.
< spudowiar>
gmaxwell: Is JSON alright for serializing data for hardware wallet support? I think it'll be easier for the external tools than normal Bitcoin serialization
< bitcoin-git>
[bitcoin] luke-jr opened pull request #10512: Rework same-chain from abusing DoS banning, to explicit checks (master...samechain_rework) https://github.com/bitcoin/bitcoin/pull/10512
< gribble>
https://github.com/bitcoin/bitcoin/issues/10179 | Give CValidationInterface Support for calling notifications on the CScheduler Thread by TheBlueMatt · Pull Request #10179 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] sipa opened pull request #10503: Use REJECT_DUPLICATE for already known and conflicted txn (master...more61duplicate) https://github.com/bitcoin/bitcoin/pull/10503
< gmaxwell>
holy crap Block Filter Digest profiling post on bitcoin-dev.
< bitcoin-git>
[bitcoin] jtimon opened pull request #10502: scripted-diff: Remove BOOST_FOREACH, Q_FOREACH and PAIRTYPE (master...b15-boost-foreach) https://github.com/bitcoin/bitcoin/pull/10502
< bitcoin-git>
[bitcoin] laanwj closed pull request #10475: [RPC] getmempoolinfo mempoolminfee is a BTC/KB feerate (master...poolfeerate) https://github.com/bitcoin/bitcoin/pull/10475
< bitcoin-git>
bitcoin/master 39039b1 Wladimir J. van der Laan: Merge #10475: [RPC] getmempoolinfo mempoolminfee is a BTC/KB feerate...
< bitcoin-git>
bitcoin/master f128f78 Gregory Sanders: getmempool mempoolminfee is a BTC/KB feerate
< bitcoin-git>
[bitcoin] practicalswift opened pull request #10498: Use static_cast instead of C-style casts for non-fundamental types (master...static_cast) https://github.com/bitcoin/bitcoin/pull/10498
< bitcoin-git>
bitcoin/0.14 9e3ad50 Cory Fields: net: only enforce the services required to connect...