2018-01-30

< bitcoin-git> bitcoin/master aac6bce Wladimir J. van der Laan: test: Make ua_comment test pass on 0.16.0...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9cb230905088...f0295becbf3e
< bitcoin-git> [bitcoin] laanwj reopened pull request #12302: test: Make ua_comment test pass on 0.16.0 (master...2017_01_uacomment_test_fix) https://github.com/bitcoin/bitcoin/pull/12302
< provoostenator> Made some progress: https://github.com/bitcoin-core/docs/issues/15
< provoostenator> Ah wait, it's more subtle. These instructions use "ifconfig" which isn't installed on Debian by default: https://github.com/bitcoin-core/docs/blob/master/gitian-building/gitian-building-setup-gitian-debian.md#setting-up-debian-for-gitian-building
< wumpus> I understand the consensus code for bitcoin is set in stone, but surely the interface for the test framework isn't
< bitcoin-git> [bitcoin] laanwj closed pull request #12302: test: Make ua_comment test pass on 0.16.0 (master...2017_01_uacomment_test_fix) https://github.com/bitcoin/bitcoin/pull/12302
< arubi> daemon stopped, I mkdir 'wallet/' in datadir, moved all my wallet .dats in there, added a new 'wallet=30_01_28_btc_segwit.dat' line in bitcoin.conf, started the daemon, and the new wallet file with this name was created in the datadir root. somewhat surprising, I'm able to getwalletinfo for both this new wallet and old wallets that are now in wallet/ using the -rpcwallet= set
< bitcoin-git> [bitcoin] laanwj opened pull request #12302: test: Make ua_comment test pass on 0.16.0 (master...2017_01_uacomment_test_fix) https://github.com/bitcoin/bitcoin/pull/12302
< provoostenator> The guide is very clear until after the Setup Gitian section. After that there's too many options. https://github.com/bitcoin-core/docs/blob/master/gitian-building.md#getting-and-building-the-inputs
< cfields> BlueMatt: got a stale bitcoin-config.h around somewhere?
< BlueMatt> cfields: -DHAVE_CONFIG_H is passed to moc-qt5 (make claims it is, at least), and if I put an ENABLE_WALLET inside the if defined(HAVE_CONFIG_H) it works fine, but somehow bitcoin-config.h isnt getting included
< provoostenator> I wasnt' the first ot notice: https://github.com/bitcoin-core/docs/pull/6
< cfields> achow101: bitcoin-0.16.0-osx-unsigned.dmg
< cfields> (config/bitcoin-config.h)
< sdaftuar> luke-jr: I'm trying to restore a document I authored to its original text. I don't know why this needs a discussion on bitcoin-dev?
< luke-jr> sdaftuar: I don't understand this question: https://github.com/bitcoin/bips/pull/639#issuecomment-361642505
< wumpus> I've added changelog and author information to https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.16.0-Release-notes
< wumpus> the release notes still need work, if anyone feels like improving them please do so on the wiki, https://github.com/bitcoin/bitcoin/issues/11054 https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.16.0-Release-notes
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/9cb2309050880c2887b4b5f7a7231e4fc6dc3f47
< bitcoin-git> bitcoin/master 9cb2309 Wladimir J. van der Laan: doc: Update manpages to 0.16.99...
< bitcoin-git> bitcoin/master 4602dc7 Wladimir J. van der Laan: build: Bump version to 0.16.99...
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/4602dc704ae83bd08d0d6e835b760cc9ab8fea37
< bitcoin-git> bitcoin/0.16 66bc647 Wladimir J. van der Laan: doc: Update manpages to 0.16.0...
< bitcoin-git> bitcoin/0.16 5c242b2 Wladimir J. van der Laan: build: bump version to 0.16.0...
< bitcoin-git> [bitcoin] laanwj created 0.16 (+2 new commits): https://github.com/bitcoin/bitcoin/compare/5c242b211eda^...66bc647e8c65
< xabbix> gmaxwell: that means that I should not at any circumstances have a `time` value of two weeks ago if I installed bitcoin-core today?
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12252: Require all tests to follow naming convention (master...rename_tests_no_leeway) https://github.com/bitcoin/bitcoin/pull/12252
< bitcoin-git> bitcoin/master 8d57319 MarcoFalke: Merge #12252: Require all tests to follow naming convention...
< bitcoin-git> bitcoin/master 125f4a4 Anthony Towns: [tests] Require all tests to follow naming convention
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/10847fe2d82b...8d573198638e
< bitcoin-git> bitcoin/master 10847fe Wladimir J. van der Laan: qt: Periodic translations update...
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/10847fe2d82bd4ffe5be499fd9ad64b6fee78a33
< bitcoin-git> [bitcoin] laanwj closed pull request #12266: Move scheduler/threadGroup into common-init instead of per-app (master...2018-01-common-init) https://github.com/bitcoin/bitcoin/pull/12266
< bitcoin-git> bitcoin/master 3448907 Wladimir J. van der Laan: Merge #12266: Move scheduler/threadGroup into common-init instead of per-app...
< bitcoin-git> bitcoin/master 082a61c Matt Corallo: Move scheduler/threadGroup into common-init instead of per-app...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7936446268e2...3448907a68e0
< wumpus> milestone 0.16.1 has the fd changes now: https://github.com/bitcoin/bitcoin/milestone/34
< gribble> https://github.com/bitcoin/bitcoin/issues/12274 | http: avoid fd exhaustion by theuni · Pull Request #12274 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12266 | Move scheduler/threadGroup into common-init instead of per-app by TheBlueMatt · Pull Request #12266 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12297 | Improve CWallet::IsAllFromMe for false results by promag · Pull Request #12297 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12299 | Improve CWallet::IsFromMe for positive results by promag · Pull Request #12299 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #12276: Remove duplicate mapWallet lookups (master...2018-01-mapwallet) https://github.com/bitcoin/bitcoin/pull/12276
< bitcoin-git> bitcoin/master 7936446 Wladimir J. van der Laan: Merge #12276: Remove duplicate mapWallet lookups...
< bitcoin-git> bitcoin/master 039425c João Barbosa: [wallet] Remove duplicate mapWallet lookups
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/288deacdbe08...7936446268e2
< bitcoin-git> [bitcoin] laanwj closed pull request #12278: Add special error for genesis coinbase to getrawtransaction (master...201801_genesis_gettransaction_error) https://github.com/bitcoin/bitcoin/pull/12278
< bitcoin-git> bitcoin/master 288deac Wladimir J. van der Laan: Merge #12278: Add special error for genesis coinbase to getrawtransaction...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7cf1aea5cfcc...288deacdbe08
< bitcoin-git> bitcoin/master ee11121 MeshCollider: Add special error for genesis coinbase to gettransaction
< bitcoin-git> [bitcoin] laanwj closed pull request #12294: [Docs] Create NetBSD build instructions and fix compilation (master...netbsd-build-docs) https://github.com/bitcoin/bitcoin/pull/12294
< bitcoin-git> bitcoin/master 11c5827 fanquake: [build] Add NETBSD leveldb target to configure.ac
< bitcoin-git> bitcoin/master 336685e Randolf Richardson: [build] Add db4_cxx to bitcoin_find_bdb48.m4...
< bitcoin-git> bitcoin/master 1944fa3 Randolf Richardson: [doc] Create build-netbsd.md
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/9d9c4185fada...7cf1aea5cfcc
< gribble> https://github.com/bitcoin/bitcoin/issues/12300 | [Tests] Adding --enable-mainnet configuration option for ChainParams by jeffrade · Pull Request #12300 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jeffrade opened pull request #12300: [Tests] Adding --enable-mainnet configuration option for ChainParams (master...mainnet_chain_config) https://github.com/bitcoin/bitcoin/pull/12300
< bitcoin-git> [bitcoin] promag opened pull request #12299: Improve CWallet::IsFromMe for positive results (master...2018-01-isfromme) https://github.com/bitcoin/bitcoin/pull/12299

2018-01-29

< bitcoin-git> [bitcoin] promag opened pull request #12298: Refactor HaveKeys to early return on false result (master...2018-01-ismine-havekeys) https://github.com/bitcoin/bitcoin/pull/12298
< bitcoin-git> [bitcoin] promag opened pull request #12297: Improve CWallet::IsAllFromMe for false results (master...2018-01-isallfromme) https://github.com/bitcoin/bitcoin/pull/12297
< instagibbs> promag, these seemed reasonable to me to move https://github.com/instagibbs/bitcoin/commit/718f05cab5fe632c5dc4e3c689d5e4cd51331089
< promag> MarcoFalke: what is the difference between TransactionCanBeBumped and https://github.com/bitcoin/bitcoin/blob/master/src/wallet/feebumper.cpp#L48-L69 ?
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #12296: wallet: Only fee-bump and non-conflicted/non-confirmed txes (master...Mf1801-walletFeeBumpNoConf) https://github.com/bitcoin/bitcoin/pull/12296
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12293: [rpc] Mention that HD is enabled if hdmasterkeyid is present (master...is-hd-enabled-rpc) https://github.com/bitcoin/bitcoin/pull/12293
< bitcoin-git> bitcoin/master 9d9c418 MarcoFalke: Merge #12293: [rpc] Mention that HD is enabled if hdmasterkeyid is present...
< bitcoin-git> bitcoin/master c6b6385 fanquake: [rpc] Mention that HD is enabled if hdmasterkeyid is present
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/90d41049f90b...9d9c4185fada
< capa66> sorry i'll take this to #bitcoin
< capa66> hello, I havea question about segwit addresses in bitcoin-core, if i generate an address using addwitnessaddress can i send to that address and see the balance in bitcoin-qt?
< bitcoin-git> [bitcoin] practicalswift opened pull request #12295: tests: Fix accidental redefinition via list comprehension. Enable lint-python.sh checking for this gotcha. (master...accidental-redefinition-of-variable) https://github.com/bitcoin/bitcoin/pull/12295
< bitcoin-git> [bitcoin] laanwj closed pull request #11989: [build] .gitignore: add QT Creator artifacts (master...ignore-qt-creator-artifacts) https://github.com/bitcoin/bitcoin/pull/11989
< bitcoin-git> bitcoin/master 90d4104 Wladimir J. van der Laan: Merge #11989: [build] .gitignore: add QT Creator artifacts...
< bitcoin-git> bitcoin/master ac5104f Sjors Provoost: [build] .gitignore: add QT Creator artifacts
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6378e5c51414...90d41049f90b
< bitcoin-git> [bitcoin] laanwj closed pull request #11711: bitcoin_qt.m4: Minor fixes and clean-ups. (master...bitcoin-qt-m4-cleanup) https://github.com/bitcoin/bitcoin/pull/11711
< bitcoin-git> bitcoin/master 079f4b2 Werner Lemberg: bitcoin_qt.m4: Add missing braces around variables in autoconf messages.
< bitcoin-git> bitcoin/master 8695315 Werner Lemberg: bitcoin_qt.m4: Use correct M4 quoting characters.
< bitcoin-git> bitcoin/master db32a4f Werner Lemberg: bitcoin_qt.m4: Improve QT_VERSION tests....
< bitcoin-git> [bitcoin] laanwj pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/eebe4580bc8d...6378e5c51414
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12292: [tests] Fix names of excluded extended tests for travis (master...rename_tests_fix_travis) https://github.com/bitcoin/bitcoin/pull/12292
< bitcoin-git> bitcoin/master eebe458 MarcoFalke: Merge #12292: [tests] Fix names of excluded extended tests for travis...
< bitcoin-git> bitcoin/master a2808cf Anthony Towns: [tests] Fix names of excluded extended tests for travis
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c0ae864ef51d...eebe4580bc8d
< bitcoin-git> [bitcoin] fanquake closed pull request #11969: logs: Improve "mempool min fee not met" error (master...mempoolfix) https://github.com/bitcoin/bitcoin/pull/11969
< gribble> https://github.com/bitcoin/bitcoin/issues/11989 | [build] .gitignore: add QT Creator artifacts by Sjors · Pull Request #11989 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #11577: Fix warnings (-Wsign-compare) when building with DEBUG_ADDRMAN (master...DEBUG_ADDRMAN-warnings) https://github.com/bitcoin/bitcoin/pull/11577
< bitcoin-git> bitcoin/master c0ae864 Wladimir J. van der Laan: Merge #11577: Fix warnings (-Wsign-compare) when building with DEBUG_ADDRMAN...
< bitcoin-git> bitcoin/master 6eddd43 practicalswift: Fix warnings when building with DEBUG_ADDRMAN...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f3c7062b7bbf...c0ae864ef51d
< bitcoin-git> [bitcoin] fanquake closed pull request #12125: [Docs] Create NetBSD build instructions and fix compilation. (master...master) https://github.com/bitcoin/bitcoin/pull/12125
< bitcoin-git> [bitcoin] fanquake opened pull request #12294: [Docs] Create NetBSD build instructions and fix compilation (master...netbsd-build-docs) https://github.com/bitcoin/bitcoin/pull/12294
< bitcoin-git> [bitcoin] laanwj closed pull request #12159: Use the character based overload for std::string::find. (master...use_char_overload_find) https://github.com/bitcoin/bitcoin/pull/12159
< bitcoin-git> bitcoin/master f3c7062 Wladimir J. van der Laan: Merge #12159: Use the character based overload for std::string::find....
< bitcoin-git> bitcoin/master a73aab7 Alin Rus: Use the character based overload for std::string::find....
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9220426280d0...f3c7062b7bbf
< bitcoin-git> [bitcoin] fanquake closed pull request #12042: Add hdenabled flag in getwalletinfo (master...getwalletinfo/hdenabledflag) https://github.com/bitcoin/bitcoin/pull/12042
< bitcoin-git> [bitcoin] fanquake opened pull request #12293: [rpc] Mention that HD is enabled if hdmasterkeyid is present (master...is-hd-enabled-rpc) https://github.com/bitcoin/bitcoin/pull/12293
< bitcoin-git> [bitcoin] ajtowns opened pull request #12292: [tests] Fix names of excluded extended tests for travis (master...rename_tests_fix_travis) https://github.com/bitcoin/bitcoin/pull/12292
< wumpus> stange "make check" timeouts on bitcoin-i686-w64-mingw32 on travis https://travis-ci.org/bitcoin/bitcoin/jobs/334642991#L2656
< bitcoin-git> bitcoin/master 9220426 Wladimir J. van der Laan: Merge #12108: [Refactor] Remove unused fQuit var from checkqueue.h...
< bitcoin-git> [bitcoin] laanwj closed pull request #12108: [Refactor] Remove unused fQuit var from checkqueue.h (master...20180107_checkqueue_ref) https://github.com/bitcoin/bitcoin/pull/12108
< bitcoin-git> bitcoin/master 30ded3e donaloconnor: [Refactor] Remove unused fQuit var from checkqueue.h
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3fa1ab4368cf...9220426280d0
< bitcoin-git> [bitcoin] fanquake closed pull request #11759: Docs: reflow the text and add better markup (master...jasan/little_text_fixes) https://github.com/bitcoin/bitcoin/pull/11759
< bitcoin-git> [bitcoin] fanquake closed pull request #11971: [docs]: include README with binary releases (master...bindoc) https://github.com/bitcoin/bitcoin/pull/11971
< bitcoin-git> [bitcoin] laanwj closed pull request #12095: [contrib] Use BDB_LIBS/CFLAGS and pass --disable-replication (master...db4-script-flags) https://github.com/bitcoin/bitcoin/pull/12095
< gribble> https://github.com/bitcoin/bitcoin/issues/12108 | [Refactor] Remove unused fQuit var from checkqueue.h by donaloconnor · Pull Request #12108 · bitcoin/bitcoin · GitHub
< bitcoin-git> bitcoin/master f3196a0 fanquake: [contrib] Add --disable-replication to install_db4
< bitcoin-git> bitcoin/master 3fa1ab4 Wladimir J. van der Laan: Merge #12095: [contrib] Use BDB_LIBS/CFLAGS and pass --disable-replication...
< bitcoin-git> bitcoin/master 311a423 fanquake: [contrib] Use BDB_LIBS/CFLAGS in install_db4
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/000ac4fd015c...3fa1ab4368cf
< gribble> https://github.com/bitcoin/bitcoin/issues/12095 | [contrib] Use BDB_LIBS/CFLAGS and pass --disable-replication by fanquake · Pull Request #12095 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #12197: Log debug build status and warn when running benchmarks (master...2018_01_debug_in_log) https://github.com/bitcoin/bitcoin/pull/12197
< bitcoin-git> bitcoin/master 000ac4f Wladimir J. van der Laan: Merge #12197: Log debug build status and warn when running benchmarks...
< bitcoin-git> bitcoin/master 34328b4 Wladimir J. van der Laan: Use PACKAGE_NAME instead of hardcoding application name in log message
< bitcoin-git> bitcoin/master 0c74e2e Wladimir J. van der Laan: Log debug build status and warn when running benchmarks...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/1213be6c3a09...000ac4fd015c
< bitcoin-git> [bitcoin] laanwj closed pull request #12217: qa: Add missing syncwithvalidationinterfacequeue to tests (master...Mf1801-qaWalletMempoolAsyncTake2) https://github.com/bitcoin/bitcoin/pull/12217
< bitcoin-git> bitcoin/master 1213be6 Wladimir J. van der Laan: Merge #12217: qa: Add missing syncwithvalidationinterfacequeue to tests...
< bitcoin-git> bitcoin/master fa796bb MarcoFalke: qa: Add missing syncwithvalidationinterfacequeue to tests
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9cf6393a4f82...1213be6c3a09
< Dizzle> i.e. Blockchain Dev Conference, Bitcoin Super Conference, etc
< gribble> https://github.com/bitcoin/bitcoin/issues/12179 | "abandon transaction" only removed tx from display until client restart · Issue #12179 · bitcoin/bitcoin · GitHub

2018-01-28

< Jack> Join:#bitcoin
< Jack> #bitcoin
< Jack> If wrong forum for such questions let me know. I downloaded bitcoin core, used bitcoin-qt.exe, can see folder of blocks in data location I created.
< bitcoin-git> [bitcoin] annanay25 opened pull request #12288: [WIP][NET] Add NATPMP support. (master...natpmp-support) https://github.com/bitcoin/bitcoin/pull/12288
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #12287: Fix missing cs_main lock for GuessVerificationProgress() (master...2018/01/rescan_lock) https://github.com/bitcoin/bitcoin/pull/12287
< bitcoin-git> [bitcoin] tamasblummer opened pull request #12286: Wallet: Resolve compiler warnings in ec_privkey_import_der (master...master) https://github.com/bitcoin/bitcoin/pull/12286
< bitcoin-git> [bitcoin] practicalswift opened pull request #12284: tests: Remove assigned but never used local variables (master...remove-assigned-but-never-used-local-variables) https://github.com/bitcoin/bitcoin/pull/12284
< bitcoin-git> [bitcoin] practicalswift opened pull request #12283: Fix typos (master...typos-20180128) https://github.com/bitcoin/bitcoin/pull/12283
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12270: Update chainTxData for 0.16 (master...2018_01_chainstats) https://github.com/bitcoin/bitcoin/pull/12270
< bitcoin-git> bitcoin/master 9cf6393 MarcoFalke: Merge #12270: Update chainTxData for 0.16...
< bitcoin-git> bitcoin/master a8c344b Wladimir J. van der Laan: Update chainTxData for 0.16...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2ae7cf8ef5be...9cf6393a4f82

2018-01-27

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #12282: wallet: Bump and Abandon only on non-conflicted txes (master...Mf1801-walletBumpAbandonOnlyNonConflictedTxes) https://github.com/bitcoin/bitcoin/pull/12282
< bitcoin-git> [bitcoin] sipa closed pull request #12281: New Miner (master...master) https://github.com/bitcoin/bitcoin/pull/12281
< bitcoin-git> [bitcoin] Sadrainbow opened pull request #12281: New Miner (master...master) https://github.com/bitcoin/bitcoin/pull/12281
< bitcoin-git> [bitcoin] MeshCollider opened pull request #12278: Add special error for genesis coinbase to gettransaction (master...201801_genesis_gettransaction_error) https://github.com/bitcoin/bitcoin/pull/12278
< bitcoin-git> [bitcoin] fanquake closed pull request #12277: master (master...lochacoin-master) https://github.com/bitcoin/bitcoin/pull/12277
< gribble> https://github.com/bitcoin/bitcoin/issues/12277 | master by lochacoin · Pull Request #12277 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] lochacoin opened pull request #12277: master (master...lochacoin-master) https://github.com/bitcoin/bitcoin/pull/12277

2018-01-26

< MarcoFalke> Is it worth holding back a nightly-alpha rc due to the open pulls in https://github.com/bitcoin/bitcoin/milestone/30 ?
< bitcoin-git> [bitcoin] promag opened pull request #12276: [wallet] Remove duplicate mapWallet lookups (master...2018-01-mapwallet) https://github.com/bitcoin/bitcoin/pull/12276
< bitcoin-git> [bitcoin] ryanofsky opened pull request #12275: Improve ScanForWalletTransactions return value (master...pr/scanstat) https://github.com/bitcoin/bitcoin/pull/12275
< mrannanay> Just wanted to make sure that we only need TCP port mapping between node and gateway as implemented here - https://github.com/bitcoin/bitcoin/blob/master/src/net.cpp#L1512
< bitcoin-git> [bitcoin] theuni opened pull request #12274: http: avoid fd exhaustion (master...http-fd-limit) https://github.com/bitcoin/bitcoin/pull/12274
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #12273: rpc: Add back missing cs_main lock in getrawmempool (master...Mf1801-rpcMempoolGetLock) https://github.com/bitcoin/bitcoin/pull/12273

2018-01-25

< gribble> https://github.com/bitcoin/bitcoin/issues/12271 | Improving fee bumping in Core · Issue #12271 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12257 | [wallet] Use destination groups instead of coins in coin select by kallewoof · Pull Request #12257 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12270 | Update chainTxData for 0.16 by laanwj · Pull Request #12270 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12266 | Move scheduler/threadGroup into common-init instead of per-app by TheBlueMatt · Pull Request #12266 · bitcoin/bitcoin · GitHub
< jtimon> although not a huge bug, https://github.com/bitcoin/bitcoin/pull/12172 is a bugfix (and a simple one)...
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator
< bitcoin-git> [bitcoin] Ov3rlo4d reopened pull request #12029: Build: Add a makefile target for Doxygen documentation (master...make-doxygen) https://github.com/bitcoin/bitcoin/pull/12029
< bitcoin-git> [bitcoin] Ov3rlo4d closed pull request #12029: Build: Add a makefile target for Doxygen documentation (master...make-doxygen) https://github.com/bitcoin/bitcoin/pull/12029
< bitcoin-git> [bitcoin] laanwj opened pull request #12270: Update chainTxData for 0.16 (master...2018_01_chainstats) https://github.com/bitcoin/bitcoin/pull/12270
< bitcoin-git> bitcoin/master 2ae7cf8 Wladimir J. van der Laan: Merge #12269: Update defaultAssumeValid to block 506067...
< bitcoin-git> [bitcoin] laanwj closed pull request #12269: Update defaultAssumeValid to block 506067 (master...201801-update-assumevalid) https://github.com/bitcoin/bitcoin/pull/12269
< bitcoin-git> bitcoin/master bde8bcd Gregory Maxwell: Update defaultAssumeValid according to release-process.md....
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/16bac24f60fa...2ae7cf8ef5be
< bitcoin-git> bitcoin/master 1e90544 Wladimir J. van der Laan: net: Update hardcoded seeds...
< bitcoin-git> bitcoin/master 16bac24 Wladimir J. van der Laan: Merge #12262: net: Hardcoded seed update...
< bitcoin-git> bitcoin/master 55f52bd Wladimir J. van der Laan: contrib: Update ATTERN_AGENT to include 0.15.x
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/598a9c4e4dcd...16bac24f60fa
< bitcoin-git> [bitcoin] gmaxwell opened pull request #12269: Update defaultAssumeValid to block 506067 (master...201801-update-assumevalid) https://github.com/bitcoin/bitcoin/pull/12269
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12264: Fix versionbits warning test (master...fix_versionbits_warning_test) https://github.com/bitcoin/bitcoin/pull/12264
< bitcoin-git> bitcoin/master 3bbd843 John Newbery: Improve comments/logging in p2p-versionbits-warning.py
< bitcoin-git> bitcoin/master 1e2e09e John Newbery: Fix intermittent failure in p2p-versionbits-warning.py...
< bitcoin-git> bitcoin/master ef2beb2 John Newbery: Fix flake8 warnings in p2p-versionbits-warning.py
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/6970b30c6f1d...598a9c4e4dcd
< jnewbery> our Travis linter only checks for F401 (module imported but unused), but in general it's preferable to follow PEP8, all other things being equal: https://github.com/bitcoin/bitcoin/blob/6970b30c6f1d2be7947295fe18f2390649b17a4b/test/functional/README.md#style-guidelines
< gribble> https://github.com/bitcoin/bitcoin/issues/12265 | [test] fundrawtransaction: lock watch-only shared address by kallewoof · Pull Request #12265 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] statebits closed pull request #12267: Update blockchain size in Ravencoin/doc/Readme (master...master) https://github.com/bitcoin/bitcoin/pull/12267
< bitcoin-git> [bitcoin] statebits opened pull request #12267: Update blockchain size in Ravencoin/doc/Readme (master...master) https://github.com/bitcoin/bitcoin/pull/12267
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #12266: Move scheduler/threadGroup into common-init instead of per-app (master...2018-01-common-init) https://github.com/bitcoin/bitcoin/pull/12266
< gribble> https://github.com/bitcoin/bitcoin/issues/12266 | Move scheduler/threadGroup into common-init instead of per-app by TheBlueMatt · Pull Request #12266 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] kallewoof opened pull request #12265: [test] fundrawtransaction: lock watch-only shared address (master...test-fundrawtransaction-lockunspent) https://github.com/bitcoin/bitcoin/pull/12265
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #11774: [tests] Rename functional tests (master...rename_tests) https://github.com/bitcoin/bitcoin/pull/11774
< bitcoin-git> bitcoin/master 90600bc Anthony Towns: [tests] Rename wallet_* functional tests.
< bitcoin-git> bitcoin/master 61b8f7f Anthony Towns: [tests] Rename p2p_* functional tests.
< bitcoin-git> bitcoin/master ca6523d Anthony Towns: [tests] Rename feature_* functional tests.
< bitcoin-git> [bitcoin] MarcoFalke pushed 7 new commits to master: https://github.com/bitcoin/bitcoin/compare/f359afcc4104...6970b30c6f1d

2018-01-24

< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12261: qt: Bump BLOCK_CHAIN_SIZE to 200GB (master...2018_01_block_chain_size) https://github.com/bitcoin/bitcoin/pull/12261
< bitcoin-git> bitcoin/master ba490d2 Wladimir J. van der Laan: qt: Bump BLOCK_CHAIN_SIZE to 200GB...
< bitcoin-git> bitcoin/master f359afc MarcoFalke: Merge #12261: qt: Bump BLOCK_CHAIN_SIZE to 200GB...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7abb0f0929bd...f359afcc4104
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #12194: Add change type option to fundrawtransaction (master...2018-01-fundrawtransaction-changetype) https://github.com/bitcoin/bitcoin/pull/12194
< bitcoin-git> bitcoin/master 31dbd5a João Barbosa: [wallet] Add change type to CCoinControl
< bitcoin-git> bitcoin/master 536ddeb João Barbosa: [rpc] Add change_type option to fundrawtransaction
< bitcoin-git> bitcoin/master 16f6f59 João Barbosa: [qa] Test fundrawtransaction with change_type option
< bitcoin-git> [bitcoin] jonasschnelli pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/eadb2dacc3c6...7abb0f0929bd
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #12213: Add address type option to addmultisigaddress (master...2018-01-addmultisigaddress-address-type) https://github.com/bitcoin/bitcoin/pull/12213
< bitcoin-git> bitcoin/master eadb2da Jonas Schnelli: Merge #12213: Add address type option to addmultisigaddress...
< bitcoin-git> bitcoin/master f523c6b João Barbosa: [qa] Use address type in addmultisigaddress to avoid addwitnessaddress
< bitcoin-git> bitcoin/master 886a92f João Barbosa: [rpc] Add address type option to addmultisigaddress
< bitcoin-git> [bitcoin] jonasschnelli pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/cc5870a4057f...eadb2dacc3c6
< bitcoin-git> [bitcoin] jnewbery opened pull request #12264: Fix versionbits warning test (master...fix_versionbits_warning_test) https://github.com/bitcoin/bitcoin/pull/12264
< bitcoin-git> [bitcoin] laanwj closed pull request #12251: initwallet: Do not translate highly technical addresstype help (master...Mf1801-walletNoTranslateInitHelp) https://github.com/bitcoin/bitcoin/pull/12251
< bitcoin-git> bitcoin/master cc5870a Wladimir J. van der Laan: Merge #12251: initwallet: Do not translate highly technical addresstype help...
< bitcoin-git> bitcoin/master fa7ecbf MarcoFalke: initwallet: Do not translate highly technical addresstype help
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6e3fe936090d...cc5870a4057f
< bitcoin-git> [bitcoin] laanwj opened pull request #12262: net: Hardcoded seed update (master...2018_01_seed_update) https://github.com/bitcoin/bitcoin/pull/12262
< gribble> https://github.com/bitcoin/bitcoin/issues/10962 | Stop translating command-line option help? · Issue #10962 · bitcoin/bitcoin · GitHub
< promag> I guess project:bitcoin/bitcoin/8 will be updated in the next days?
< gribble> https://github.com/bitcoin/bitcoin/issues/12251 | initwallet: Do not translate highly technical addresstype help by MarcoFalke · Pull Request #12251 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj opened pull request #12261: qt: Bump BLOCK_CHAIN_SIZE to 200GB (master...2018_01_block_chain_size) https://github.com/bitcoin/bitcoin/pull/12261
< bitcoin-git> [bitcoin] fwolfst opened pull request #12260: [Trivial] link mentioned scripted-diff-commit (developer-doc) (master...LINK_COMMIT_IN_DOC_DEVNOTES) https://github.com/bitcoin/bitcoin/pull/12260
< gribble> https://github.com/bitcoin/bitcoin/issues/12213 | Add address type to addmultisigaddress and createmultisig by promag · Pull Request #12213 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12253 | SegWit support for importmulti · Issue #12253 · bitcoin/bitcoin · GitHub
< bitcoin-git> bitcoin/master 6e3fe93 Wladimir J. van der Laan: qt: Update translation source file...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e37ca2be91bd...6e3fe936090d
< bitcoin-git> bitcoin/master 1e0d6e9 Wladimir J. van der Laan: tx: Update transifex slug for 0.16...
< gribble> https://github.com/bitcoin/bitcoin/issues/12194 | Add change type option to fundrawtransaction by promag · Pull Request #12194 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #12250: Make CKey::Load references const (master...pr/keyload) https://github.com/bitcoin/bitcoin/pull/12250
< bitcoin-git> bitcoin/master e37ca2b Wladimir J. van der Laan: Merge #12250: Make CKey::Load references const...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/95941396fff8...e37ca2be91bd
< bitcoin-git> bitcoin/master 04ededf Russell Yanofsky: Make CKey::Load references const...
< gribble> https://github.com/bitcoin/bitcoin/issues/12194 | Add change type option to fundrawtransaction by promag · Pull Request #12194 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12213 | Add address type to addmultisigaddress and createmultisig by promag · Pull Request #12213 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #12119: [wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH (master...bech32-change) https://github.com/bitcoin/bitcoin/pull/12119
< bitcoin-git> bitcoin/master 9594139 Wladimir J. van der Laan: Merge #12119: [wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH...
< bitcoin-git> bitcoin/master 596c446 Sjors Provoost: [wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/126000ba9e7f...95941396fff8
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12089: qa: Make TestNodeCLI command optional in send_cli (master...Mf1801-qaCliOptions) https://github.com/bitcoin/bitcoin/pull/12089
< bitcoin-git> bitcoin/master 126000b MarcoFalke: Merge #12089: qa: Make TestNodeCLI command optional in send_cli...
< bitcoin-git> bitcoin/master fae7b14 MarcoFalke: qa: Make TestNodeCLI command optional in send_cli
< bitcoin-git> bitcoin/master ffffb10 MarcoFalke: qa: Rename cli.args to cli.options...
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/69ec021969a4...126000ba9e7f
< bitcoin-git> [bitcoin] laanwj closed pull request #11415: [RPC] Disallow using addresses in createmultisig (master...createmultisig-no-addr) https://github.com/bitcoin/bitcoin/pull/11415
< bitcoin-git> bitcoin/master 69ec021 Wladimir J. van der Laan: Merge #11415: [RPC] Disallow using addresses in createmultisig...
< bitcoin-git> bitcoin/master 1df206f Andrew Chow: Disallow using addresses in createmultisig...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6e89de5ba7ce...69ec021969a4
< gribble> https://github.com/bitcoin/bitcoin/issues/11415 | [RPC] Disallow using addresses in createmultisig by achow101 · Pull Request #11415 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12213 | Add address type to addmultisigaddress and createmultisig by promag · Pull Request #12213 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #11512: Use GetDesireableServiceFlags in seeds, dnsseeds, fixing static seed adding (master...2017-10-seed-service-bits-cleanups) https://github.com/bitcoin/bitcoin/pull/11512
< bitcoin-git> bitcoin/master 62e7642 Matt Corallo: Fall back to oneshot for DNS Seeds which don't support filtering....
< bitcoin-git> bitcoin/master fb6f6b1 Matt Corallo: bluematt's testnet-seed now supports x9 (and is just a static list)
< bitcoin-git> bitcoin/master 51ae766 Matt Corallo: Use GetDesireableServiceFlags in static seeds, document this....
< bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/8470e64724cb...6e89de5ba7ce
< bitcoin-git> [bitcoin] laanwj closed pull request #11281: Avoid permanent cs_main/cs_wallet lock during RescanFromTime (master...2017/09/rescan_locks) https://github.com/bitcoin/bitcoin/pull/11281
< bitcoin-git> bitcoin/master dbf8556 Jonas Schnelli: Add RAII wallet rescan reserver
< bitcoin-git> bitcoin/master bc356b4 Jonas Schnelli: Make sure WalletRescanReserver has successfully reserved the rescan
< bitcoin-git> bitcoin/master 8d0b610 Jonas Schnelli: Avoid pemanent cs_main/cs_wallet lock during wallet rescans
< bitcoin-git> [bitcoin] laanwj pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/b5e4b9b5100e...8470e64724cb
< kallewoof> gmaxwell: I think I've got it. Not sure what reviewers will say though (I wrapped CWallet::CreateTransaction and called the original twice for the case where avoid-partial is unset)... https://github.com/bitcoin/bitcoin/pull/12257/commits/3af1fac480fa08f92cd611ce93885d4501acc676
< kallewoof> I was hoping to do all this in SelectCoins. (My patch currently looks like this: https://github.com/bitcoin/bitcoin/pull/12257/commits/4593c6164891e5d766b33952702195288a241b2d)
< bitcoin-git> [bitcoin] fanquake closed pull request #12258: Change app name, datadir location/settings (master...master) https://github.com/bitcoin/bitcoin/pull/12258
< kallewoof> gmaxwell: just not sure what to base the criteria on. Maybe that's a different PR. It's simply a matter of calling https://github.com/bitcoin/bitcoin/pull/12257/files#diff-b2bb174788c7409b671c46ccc86034bdR4228 with false once and true once and comparing.
< bitcoin-git> [bitcoin] tviho opened pull request #12258: Change app name, datadir location/settings (master...master) https://github.com/bitcoin/bitcoin/pull/12258
< Randolf> ProfMac: There is a #bitcoin-dev channel.
< bitcoin-git> [bitcoin] kallewoof opened pull request #12257: [wallet] Use destination groups instead of coins in coin select (master...feature-addrgrouped-coinselect) https://github.com/bitcoin/bitcoin/pull/12257
< r251d> promag: could you please clarify your nit about commit body cleanup for mryandao at https://github.com/bitcoin/bitcoin/pull/12240 ?
< r251d> mryandao: I think "commit body" refers to the commit message at https://github.com/bitcoin/bitcoin/pull/12240/commits/acde12c2f651912fdd04e4e50638502d5de26e91
< bitcoin-git> [bitcoin] dongcarl opened pull request #12255: Update bitcoin.service to conform to init.md (master...patch-2) https://github.com/bitcoin/bitcoin/pull/12255
< bitcoin-git> [bitcoin] jimpo opened pull request #12254: BIP 158: Compact Block Filters for Light Clients (master...bip-158) https://github.com/bitcoin/bitcoin/pull/12254

2018-01-23

< jojeyh> hey trying to setup private regtest chain locally. running the command 'bitcoind -regtest -daemon' outputs usual phrase 'Bitcoin server starting.." but 'ps aux' returns no process running it
< bitcoin-git> [bitcoin] ajtowns opened pull request #12252: Require all tests to follow naming convention (master...rename_tests_no_leeway) https://github.com/bitcoin/bitcoin/pull/12252
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #12251: initwallet: Do not translate highly technical addresstype help (master...Mf1801-walletNoTranslateInitHelp) https://github.com/bitcoin/bitcoin/pull/12251
< gribble> https://github.com/bitcoin/bitcoin/issues/11739 | Enforce SCRIPT_VERIFY_P2SH and SCRIPT_VERIFY_WITNESS from genesis by sdaftuar · Pull Request #11739 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] ryanofsky opened pull request #12250: Make CKey::Load references const (master...pr/keyload) https://github.com/bitcoin/bitcoin/pull/12250
< sipa> no version of bitcoin ever added the genesis block to the txindex, which is the reason why the genesis coinbase output is unspendable
< bitcoin-git> [bitcoin] fanquake closed pull request #12247: ZSnarks tech integration (master...HODLCoin0.11.3) https://github.com/bitcoin/bitcoin/pull/12247
< bitcoin-git> [bitcoin] karibik opened pull request #12247: ZSnarks tech integration (master...HODLCoin0.11.3) https://github.com/bitcoin/bitcoin/pull/12247
< bitcoin-git> [bitcoin] luke-jr opened pull request #12246: Bugfix: Only run bitcoin-tx tests when bitcoin-tx is enabled (master...separate_utils) https://github.com/bitcoin/bitcoin/pull/12246
< jtimon> sdaftuar: oh, I had missed https://github.com/bitcoin/bitcoin/pull/11739 till today, good one

2018-01-22

< bitcoin-git> [bitcoin] fanquake closed pull request #12242: 0.8 (0.8...0.8) https://github.com/bitcoin/bitcoin/pull/12242
< bitcoin-git> [bitcoin] russhianhere opened pull request #12242: 0.8 (0.8...0.8) https://github.com/bitcoin/bitcoin/pull/12242
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12187: [Docs] Updating benchmarkmarking.md with an updated sample output (master...benchmark_output) https://github.com/bitcoin/bitcoin/pull/12187
< bitcoin-git> bitcoin/master b5e4b9b MarcoFalke: Merge #12187: [Docs] Updating benchmarkmarking.md with an updated sample output...
< bitcoin-git> bitcoin/master b21244e Jeff Rade: Updating benchmarkmarking.md with an updated sample output and help options
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b987ca4ee495...b5e4b9b5100e
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12227: test_runner: Readable output if create_cache.py fails (master...pr/runcache) https://github.com/bitcoin/bitcoin/pull/12227
< bitcoin-git> bitcoin/master ac96e78 Russell Yanofsky: test_runner: Readable output if create_cache.py fails...
< bitcoin-git> bitcoin/master b987ca4 MarcoFalke: Merge #12227: test_runner: Readable output if create_cache.py fails...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b03013396cb2...b987ca4ee495
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12241: [trivial][docs] Fix incorrect link in /test/ README.md (master...trivial-fix-util-link) https://github.com/bitcoin/bitcoin/pull/12241
< bitcoin-git> bitcoin/master b030133 MarcoFalke: Merge #12241: [trivial][docs] Fix incorrect link in /test/ README.md...
< bitcoin-git> bitcoin/master bf18977 fanquake: [trivial][docs] Fix incorrect link in /test/ README.md
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f4c942e36154...b03013396cb2
< gribble> https://github.com/bitcoin/bitcoin/issues/11642 | Visual Hashes for Bitcoin Addresses · Issue #11642 · bitcoin/bitcoin · GitHub
< zelest> I think I just had a quite clever idea... What about showing bitcoin addresses in certain colors? E.g, convert it to hex and pick the 6 values (like, 2 form the beginning, 2 from the middle, 2 from the last) and use it as RGB and color it..