< GitHub120>
[bitcoin] laanwj closed pull request #6693: Set Windows TCP buffers to 64KB to match OSX and Unix (master...issue_6554) https://github.com/bitcoin/bitcoin/pull/6693
< GitHub35>
bitcoin/master 755b4ba Wladimir J. van der Laan: Merge pull request #5574...
< GitHub67>
bitcoin/master c53d48a Jorge Timón: BIP70: Chainparams: DRY: Make qt/guiutil.cpp fit BIP70 chain name strings...
< gmaxwell>
wumpus: I heard from andytoshi that you've been keeping him honest on rust-bitcoin. :)
< wumpus>
yes that solves one problem but causes many others. We tried forcing the locale to C in bitcoin for a while but this messed with file name encodings on windows.
< GitHub138>
bitcoin/0.11 40941d9 David A. Harding: [Docs] First-draft release notes for 0.11.2RC1
< GitHub138>
bitcoin/0.11 929b2c7 David A. Harding: [docs] Minor revisions to 0.11.2RC1 release notes...
< GitHub138>
bitcoin/0.11 9149589 David A. Harding: [docs] 0.11.2 release notes: add sipa graphs & leveldb note...
< wumpus>
not saying that is not the way forward to 'find' the same datadir in bitcoin-cli and bitcoind, as well as other software, but it doesn't quite make it easier
< GitHub126>
[bitcoin] laanwj opened pull request #6970: Fix crash in validateaddress with -disablewallet (master...2015_11_rpc_validateaddress_crash) https://github.com/bitcoin/bitcoin/pull/6970
< Luke-Jr>
~/.config/Bitcoin/Bitcoin-Qt.conf
< wumpus>
bitcoin, by design, only has one datadir. If you move it, everything moves with it
< Luke-Jr>
does bitcoin-qt use strDataDir for the config location too? :/
< wumpus>
indeed it's the same for finding bitcoin.conf
< gmaxwell>
wumpus: I'd still suggest adding (hopefully) 1/2 LOC: code to use RegQuery to find the same location in bitcoind/bitcoin-cli.
< gmaxwell>
Luke-Jr: I think we could probably just add code that reads the registry in the same way RandAddSeedPerfmon and looks to the same place QT looks, and call that from bitcoind/bitcoin-cli on windows, and document the location so other programs can look. No?
< gmaxwell>
wumpus: sometimes we have to... there are dozens of windows ifdefs in the code. Unless you think linking bitcoind/bitcoin-cli to QT is a better plan. :)
< wumpus>
gmaxwell: qsettings is the qt equivalent of adding command line arguments, you can pass a datadir to bitcoin-cli and it will work
< Luke-Jr>
wumpus: my main concern is BFGMiner, not bitcoin-cli
< gmaxwell>
wumpus: it is a bit broken that changing your datadir breaks bitcoind / bitcoin-cli from finding it.
< wumpus>
most people that want to use RPC with bitcoin-qt will use the debug console
< wumpus>
maybe 1% of users actually use bitcoin-qt with bitcoin-cli, 0.1% uses it with a changed datadir through qt
< wumpus>
bitcoin.conf is usually in the same directory as the cookie so it won't avoid *any* problems
< wumpus>
otherwise I'd just have made it write a rpcuser and rpcpassword to bitcoin.conf
< dgenr8>
writing to bitcoin.conf should be controlled by a setting in bitcoin.conf
< gmaxwell>
then you have the "how do you find bitcoin.conf" problem.
< wumpus>
don't write to bitcoin.conf
< Luke-Jr>
it's tempting to change this to write to bitcoin.conf instead of QSettings then
< gmaxwell>
using something QT specific for handling finding the datadir on windows was probably what should have been avoided, since bitcoind and bitcoin-cli also need to find the data directory.
< Luke-Jr>
if it's overridden via bitcoin.conf or cmdline, it uses that; otherwise the platform default
< Luke-Jr>
wumpus: so what if cookie file uses the same logic as bitcoin-cli for datadir? this seems to work in all cases..?
< Luke-Jr>
gmaxwell: bitcoin-qt gets datadir from Windows registry, Mac registry-equivalent, or an INI file on Linux; based on user input at first run
< wumpus>
bitcoin-qt allows choosing a data directory on first start in the GUI, this is stored inthe qt settings
< wumpus>
bitcoin-cli and bitcoind don't care about that
< gmaxwell>
wait why isn't bitcoin-qt and bitcoin-cli finding the same datadir?!
< Luke-Jr>
would it be terrible to have Bitcoin-Qt get strDataDir from a special QSettings that explicitly uses <default datadir>/datadir.ini or something?
< wumpus>
any software that knows the bitcoin data dir can communicate with bitcoin{d,qt} if server=1
< Luke-Jr>
I thought the whole point of the cookie file was so Bitcoin-Qt users didn't need to configure RPC explicitly
< wumpus>
pass the right datadir to bitcoin-cli and it should work
< Luke-Jr>
awful lot considering bitcoin-cli is just a testing tool, and bitcoind users should be capable of configuring bitcoin.conf anyway :x
< wumpus>
to let bitcoind and bitcoin-cli communicate given just the datadir
< wumpus>
qt has its own settings, bitcoind/bitcoin-cli are not able to access those
< Luke-Jr>
dcousens: bitcoin-qt supports overriding the data dir from a QSettings value
< Luke-Jr>
wait, is that a bug for Core? that bitcoin-cli won't find -qt's cookie file?
< Luke-Jr>
thoughts on a bitcoin-cli -printdatadir option or something?
< GitHub157>
[bitcoin] laanwj opened pull request #6969: doc: there is no libboost-base-dev, add missing sudo in release notes (master...2015_11_docfix) https://github.com/bitcoin/bitcoin/pull/6969
2015-11-08
< gmaxwell>
Has someone actually compared MTP to blocktime over the history of the bitcoin network to figure out what the median correction is precisely?
< GitHub174>
[bitcoin] harding opened pull request #6968: [Docs] First-draft release notes for 0.11.2RC1 (0.11...release-notes-0.11.2) https://github.com/bitcoin/bitcoin/pull/6968
< harding>
PRab: oh, I was looking for what to put on the release notes section of the Bitcoin.org website when 0.11.2 gets released. (We usually put up a draft PR when the RCs start getting built.)
< GitHub183>
[bitcoin] TheBlueMatt opened pull request #6967: Use Pieter's signing subkey instead of his primary key (master...verify-commits-fixes) https://github.com/bitcoin/bitcoin/pull/6967
< GitHub55>
[bitcoin] TheBlueMatt closed pull request #6964: Use Pieter's signing subkey instead of his primary key (master...verify-commits-fixes) https://github.com/bitcoin/bitcoin/pull/6964
< GitHub160>
bitcoin/0.11 984587a Wladimir J. van der Laan: bump version to 0.11.2
< GitHub189>
[bitcoin] pstratem opened pull request #6966: Cache CWalletDB pointer in CWallet to improve performance (master...wallet_speedup) https://github.com/bitcoin/bitcoin/pull/6966
< gmaxwell>
Bitcoin Core used to have a number of other adhoc additional security measures which have been dropped.
2015-11-06
< GitHub124>
[bitcoin] TheBlueMatt opened pull request #6965: Benchmark sanity checks and fork checks in ConnectBlock (master...bench) https://github.com/bitcoin/bitcoin/pull/6965
< GitHub14>
[bitcoin] TheBlueMatt opened pull request #6964: Benchmark sanity checks and fork checks in ConnectBlock (master...verify-commits-fixes) https://github.com/bitcoin/bitcoin/pull/6964
< gmaxwell>
sdaftuar: a verify with libsecp256k1 as it's used in bitcoin core is 280 times slower than a single run of the sha256 compression function. That PR ends up calling the sha256 compression function twice.
< GitHub30>
bitcoin/0.11 4e895b0 Pieter Wuille: Always flush block and undo when switching to new file...
< GitHub13>
[bitcoin] MarcoFalke opened pull request #6962: translations: Don't translate markup or force English grammar (master...MarcoFalke-2015-translations) https://github.com/bitcoin/bitcoin/pull/6962
< jonasschnelli>
when i restore my snapshot based on a ~synced chain with #6917, bitcoin-core crashed,... but can be started again with 100% success. Can that be a problem? I assume no?
< jonasschnelli>
restarted win8.1 ... restarted bitcoin-qt from 6948
< GitHub41>
bitcoin/0.11 df616ae Wladimir J. van der Laan: Merge pull request #6884...
< GitHub41>
bitcoin/0.11 f720c5f Mark Friedenbach: Enable policy enforcing GetMedianTimePast as the end point of lock-time constraints...
< GitHub41>
bitcoin/0.11 a1d3c6f Mark Friedenbach: Add rules--presently disabled--for using GetMedianTimePast as endpoint for lock-time calculations...
< GitHub47>
bitcoin/master 3038eb6 Wladimir J. van der Laan: Merge pull request #6934...
< GitHub47>
bitcoin/master d1c3762 Gregory Maxwell: Revert "Revert "Enable policy enforcing GetMedianTimePast as the end point of lock-time constraints""...
< GitHub47>
bitcoin/master e4e5334 Gregory Maxwell: Restore MedianTimePast for locktime....
< gmaxwell>
But we do not couple soft-forks to bitcoin core major releases.
< davec>
I brought it up over in bitcoin-dev, but I'll put it here too for visibility. As of block 583930 on testnet, the CLTV soft fork is active although there is a lot of hash power still mining under the pre-CLTV rules.
< GitHub40>
[bitcoin] laanwj closed pull request #6938: build: If both Qt4 and Qt5 are installed, use Qt5 (master...2015_11_prefer_qt5) https://github.com/bitcoin/bitcoin/pull/6938
< GitHub145>
bitcoin/master 193f7b5 Wladimir J. van der Laan: Merge pull request #6938...
< GitHub120>
[bitcoin] laanwj opened pull request #6938: build: If both Qt4 and Qt5 are installed, use Qt5 (master...2015_11_prefer_qt5) https://github.com/bitcoin/bitcoin/pull/6938
< GitHub126>
[bitcoin] laanwj closed pull request #6905: Use constants and minor fixes by luke-jr (master...lukejr-constants-no-mergeConf) https://github.com/bitcoin/bitcoin/pull/6905
< GitHub158>
bitcoin/master 5f9260f Luke Dashjr: Bugfix: If genproclimit is omitted to RPC setgenerate, don't change it; also show correct default in getmininginfo
< GitHub158>
bitcoin/master 420a82f Luke Dashjr: Bugfix: Describe dblogsize option correctly (it refers to the wallet database, not memory pool)
< GitHub158>
bitcoin/master caa3d42 Luke Dashjr: Bugfix: RPC: blockchain: Display correct defaults in help for verifychain method
< Eliel_>
It looks like the curl example in the help text you get with "bitcoin-cli help" does not work as is. It has the address list doubly JSON encoded while bitcoind doesn't expect two layers of JSON as input.
< GitHub76>
[bitcoin] laanwj opened pull request #6926: tests: Initialize networking on windows (master...2015_10_tests_networking_init) https://github.com/bitcoin/bitcoin/pull/6926
< GitHub69>
[bitcoin] Diapolo opened pull request #6921: [Trivial] remove unneeded spaces from init.cpp (master...trivial_typo_space) https://github.com/bitcoin/bitcoin/pull/6921
< GitHub48>
[bitcoin] Diapolo opened pull request #6920: remove unneded include from rpcserver.cpp and rpcclient.cpp (master...univalue) https://github.com/bitcoin/bitcoin/pull/6920
< GitHub195>
[bitcoin] laanwj opened pull request #6919: Backport chainstate obfuscation to 0.11 (0.11...2015_10_backport_chainstate_obfuscation) https://github.com/bitcoin/bitcoin/pull/6919
< belcher>
oh damn this channel, didnt realise, ask in #bitcoin
< diegoviola>
will bitcoin core implement SPV like electrum and seeds?
2015-10-30
< GitHub146>
[bitcoin] laanwj closed pull request #6906: Reject invalid pubkeys when reading ckey items from the wallet. (master...ckey_pubkey_check) https://github.com/bitcoin/bitcoin/pull/6906
< GitHub164>
bitcoin/master 48b5b84 Wladimir J. van der Laan: Merge pull request #6906...
< GitHub164>
bitcoin/master 30d9662 Gregory Maxwell: Reject invalid pubkeys when reading ckey items from the wallet....