2017-02-19

< Arvidt> Wladimir J. van der Laan (Bitcoin Core binary release signing key) <laanwj@gmail.com> 01EA 5486 DE18 A882 D4C2 6845 90C8 019E 36C2 E964 is expired
< luke-jr> wumpus: the original reason I brought it up, was translators confusing it for "About Bitcoin-Qt". but that has since been resolved in other ways, so
< gmaxwell> I think all this is kind of pointless, user use of bitcoin is dying because of sync resource requirements.
< gmaxwell> I think that would be dandy. I dunno what about Bitcoin would say.
< luke-jr> so the menu would have About Bitcoin Core and About Bitcoin; and the former's dialog have a link for About Qt?
< gmaxwell> luke-jr: It might be better to put the QT link though on the about bitcoin core page though.
< luke-jr> re "About Qt": we're using "About %1" now anyway, so the translation issue is presumably gone, and Qt might actually be worth promoting anyway; thinking perhaps what would be an improvement there is to add an "About Bitcoin" :p
< bitcoin-git> [bitcoin] fanquake closed pull request #8660: txoutsbyaddress index (take 2) (master...cozz8) https://github.com/bitcoin/bitcoin/pull/8660

2017-02-18

< luke-jr> thoughts on a GUI screen showing what #bitcoin-watch used to? https://en.bitcoin.it/wiki/Bitcoin-Watch
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #9657: Improve rpc-tests.py (master...improvepytests2) https://github.com/bitcoin/bitcoin/pull/9657
< bitcoin-git> bitcoin/master afd38e7 John Newbery: Improve rpc-tests.py arguments...
< bitcoin-git> bitcoin/master 1581ecb John Newbery: Use configparser in rpc-tests.py...
< bitcoin-git> bitcoin/master 91bffff John Newbery: Use argparse in rpc_tests.py...
< bitcoin-git> [bitcoin] MarcoFalke pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/aa5fa642b0e7...7ff4a538a868
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #9696: [trivial] Fix recently introduced typos in comments (master...fix-recently-introduced-typos) https://github.com/bitcoin/bitcoin/pull/9696
< bitcoin-git> bitcoin/master aa5fa64 MarcoFalke: Merge #9696: [trivial] Fix recently introduced typos in comments...
< bitcoin-git> bitcoin/master 0c9b9b7 practicalswift: [trivial] Fix recently introduced typos in comments
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8efd1c820b9a...aa5fa642b0e7
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #9795: doc: Update manpages for master (laanwj) (master...Mf1602-docManMaster) https://github.com/bitcoin/bitcoin/pull/9795
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #9744: Remove unused module from rpc-tests (master...remove-unused-modules-from-rpc-tests) https://github.com/bitcoin/bitcoin/pull/9744
< bitcoin-git> bitcoin/master 8efd1c8 MarcoFalke: Merge #9744: Remove unused module from rpc-tests...
< bitcoin-git> bitcoin/master a432aa0 Takashi Mitsuta: Remove unused module from rpc-tests
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/50a226563cd8...8efd1c820b9a
< bitcoin-git> [bitcoin] mitchellcash opened pull request #9794: Minor update to qrencode package builder (master...minor_depends_fix) https://github.com/bitcoin/bitcoin/pull/9794
< gribble> https://github.com/bitcoin/bitcoin/issues/122 | Spent per txout by sipa · Pull Request #122 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/135 | [mac os x] Crash on exit · Issue #135 · bitcoin/bitcoin · GitHub
< fanquake> 8c42c1f996935fc0f2a13616d8b0f557594b23588e7781f72c9ebe53ef097cbd bitcoin-0.14.0-osx-unsigned.dmg
< bitcoin-git> [bitcoin] kobake closed pull request #9793: Vs2015 wip (master...vs2015-wip) https://github.com/bitcoin/bitcoin/pull/9793
< bitcoin-git> [bitcoin] kobake opened pull request #9793: Vs2015 wip (master...vs2015-wip) https://github.com/bitcoin/bitcoin/pull/9793
< bitcoin-git> [bitcoin] sipa opened pull request #9792: FastRandomContext improvements and switch to ChaCha20 (master...chacha) https://github.com/bitcoin/bitcoin/pull/9792
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #9788: gitian: bump descriptors for master (master...gitian-bump-0.15) https://github.com/bitcoin/bitcoin/pull/9788
< bitcoin-git> bitcoin/master 50a2265 MarcoFalke: Merge #9788: gitian: bump descriptors for master...
< bitcoin-git> bitcoin/master 8e5cca0 Cory Fields: gitian: bump descriptors for master...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/12f46fa7d87d...50a226563cd8
< cfields> Binary files bitcoin-0.14.0-me/bin/bitcoin-qt and bitcoin-0.14.0-achow/bin/bitcoin-qt differ
< cfields> achow101: can you drop your bitcoin-0.14.0-osx64.tar.gz somewhere?

2017-02-17

< sipa> in past times, it seems "Qt" was even understood to refer to the bitcoin core program name
< * luke-jr> wonders if we should remove "About Qt" from the menu. It seems (without knowing the languages) translators are interpreting "Qt" as "Bitcoin-Qt"
< bitcoin-git> [bitcoin] sipa opened pull request #9791: Avoid VLA in hash.h (master...novla) https://github.com/bitcoin/bitcoin/pull/9791
< bitcoin-git> [bitcoin] luke-jr opened pull request #9790: doc/release-notes: Various cleanups (0.14...0.14-relnotes) https://github.com/bitcoin/bitcoin/pull/9790
< sipa> i'm running master as of a few hours ago, plus my sanitize fixes, on bitcoin.sipa.be, with tsan and ubsan enabled
< bitcoin-git> [bitcoin] theuni opened pull request #9789: build: disallow variable length arrays (master...no-vla) https://github.com/bitcoin/bitcoin/pull/9789
< wumpus> instagibbs: see #bitcoin
< bitcoin-git> [bitcoin] theuni opened pull request #9788: gitian: bump descriptors for master (master...gitian-bump-0.15) https://github.com/bitcoin/bitcoin/pull/9788
< gribble> https://github.com/bitcoin/bitcoin/issues/8487 | Persist the datadir after option reset by achow101 · Pull Request #8487 · bitcoin/bitcoin · GitHub
< bitcoin-git> bitcoin/0.14 2afefea Cory Fields: boost: remove iostreams includes...
< bitcoin-git> bitcoin/0.14 973e345 Pieter Wuille: Move BIP70_MAX_PAYMENTREQUEST_SIZE to header...
< bitcoin-git> bitcoin/0.14 f873564 Pieter Wuille: Make KEY_SIZE a compile-time constant...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to 0.14: https://github.com/bitcoin/bitcoin/compare/04396bcc058e...2afefeade6e6
< bitcoin-git> [bitcoin] laanwj closed pull request #9786: boost: remove iostreams includes (master...no-iostreams) https://github.com/bitcoin/bitcoin/pull/9786
< bitcoin-git> bitcoin/master 12f46fa Wladimir J. van der Laan: Merge #9786: boost: remove iostreams includes...
< bitcoin-git> bitcoin/master 3301587 Cory Fields: boost: remove iostreams includes...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/df42bcdbfebe...12f46fa7d87d
< bitcoin-git> [bitcoin] laanwj closed pull request #9785: Avoid variable length arrays (master...constkeysize) https://github.com/bitcoin/bitcoin/pull/9785
< bitcoin-git> bitcoin/master df42bcd Wladimir J. van der Laan: Merge #9785: Avoid variable length arrays...
< bitcoin-git> bitcoin/master c801c82 Pieter Wuille: Move BIP70_MAX_PAYMENTREQUEST_SIZE to header
< bitcoin-git> bitcoin/master 914fad1 Pieter Wuille: Make KEY_SIZE a compile-time constant
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/f87e8f53920a...df42bcdbfebe
< bitcoin-git> bitcoin/0.14 04396bc Wladimir J. van der Laan: Merge #9784: Restore removed release notes....
< bitcoin-git> bitcoin/0.14 1577f07 Gregory Maxwell: Restore removed release notes.
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to 0.14: https://github.com/bitcoin/bitcoin/compare/618709141147...04396bcc058e
< bitcoin-git> [bitcoin] theuni opened pull request #9787: [WIP] release: add a few performance-related notes (0.14...update-release-notes) https://github.com/bitcoin/bitcoin/pull/9787
< bitcoin-git> bitcoin/0.14 6187091 Wladimir J. van der Laan: doc: Add changelog for 0.14.0 to release notes
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/618709141147f74771da0795cf0dccb47c606d24
< bitcoin-git> [bitcoin] theuni opened pull request #9786: boost: remove iostreams includes (master...no-iostreams) https://github.com/bitcoin/bitcoin/pull/9786
< wumpus> would be good to include the paymentrequest change in https://github.com/bitcoin/bitcoin/pull/9785 too
< cfields> I remember this one getting snagged as a vla at one point: https://github.com/bitcoin/bitcoin/blob/master/src/hash.h#L30
< bitcoin-git> [bitcoin] sipa opened pull request #9785: Make KEY_SIZE a compile-time constant (master...constkeysize) https://github.com/bitcoin/bitcoin/pull/9785
< Chris_Stewart_5> The Chronicles of Bitcoin Core (TM)
< wumpus> brg444 did a nice writeup on bitcoin core performance improvements
< wumpus> i'm certainly in favor of publishing awesome developer changes in bitcoin core, but I'm not sure the release notes is the right place for that
< gribble> https://github.com/bitcoin/bitcoin/issues/7689 | Replace OpenSSL AES with ctaes-based version by sipa · Pull Request #7689 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] gmaxwell opened pull request #9784: Restore removed release notes. (0.14...release_notes) https://github.com/bitcoin/bitcoin/pull/9784
< bitcoin-git> bitcoin/0.14 871e19a Wladimir J. van der Laan: doc: Add list of authors to release notes...
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/871e19ac84ae71b3d22928d5cb3bbf4f0f013b07
< bitcoin-git> [bitcoin] laanwj closed pull request #9783: release: bump gitian descriptors for a new 0.14 package cache (0.14...gitian-descriptor-bump) https://github.com/bitcoin/bitcoin/pull/9783
< Chris_Stewart_5> Will this 'normalize' function in secp256k1 strip uneccessary padding on signatures? https://github.com/bitcoin/bitcoin/blob/master/src/pubkey.cpp#L183
< bitcoin-git> [bitcoin] theuni opened pull request #9783: release: bump gitian descriptors for a new 0.14 package cache (0.14...gitian-descriptor-bump) https://github.com/bitcoin/bitcoin/pull/9783
< bitcoin-git> bitcoin/0.14 268c390 Wladimir J. van der Laan: doc: Update manpages for 0.14.0
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/268c390d02d99a4a93a0a01221e273d2b9695ff7
< wumpus> the full node guide mentions pruning as well https://bitcoin.org/en/full-node#configuration-tuning , though it doesn't mention that currently pruned nodes will not serve blocks
< Arvidt> Is it better for Bitcoin to run a full node, or is it also ok ok to run a pruned node with 100 GiB (-prune=100000) ?
< bitcoin-git> bitcoin/0.14 1a02ecc Wladimir J. van der Laan: doc: Update release notes from wiki
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/1a02ecc73af4b4ac36da1bd04f9e7eddf640e48f
< bitcoin-git> bitcoin/0.14 f68e441 Wladimir J. van der Laan: qt: pre-rc1 translations update
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/f68e4414d77aeb60d8dee1b2e53a195ff15b2c48
< bitcoin-git> bitcoin/master f87e8f5 Wladimir J. van der Laan: build: bump version to 0.14.99...
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/f87e8f53920adfa80a3f4af9435370dc272c3783
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/bc69f34b3537a7d34fb7f89b4acd619749bc6cc2
< bitcoin-git> bitcoin/0.14 bc69f34 Wladimir J. van der Laan: build: bump version to 0.14.0
< bitcoin-git> [bitcoin] laanwj closed pull request #9761: Use 2 hour grace period for key timestamps in importmulti rescans (master...pr/multigrace) https://github.com/bitcoin/bitcoin/pull/9761
< bitcoin-git> bitcoin/master 38d3e9e Russell Yanofsky: [qa] Extend import-rescan.py to test imports on pruned nodes.
< bitcoin-git> bitcoin/master c28583d Russell Yanofsky: [qa] Extend import-rescan.py to test specific key timestamps
< bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/ad168ef4e308...9828f9a9962c
< bitcoin-git> bitcoin/master 8be0866 Russell Yanofsky: [qa] Simplify import-rescan.py...
< bitcoin-git> [bitcoin] laanwj closed pull request #9778: Add two hour buffer to manual pruning (master...2hrprune) https://github.com/bitcoin/bitcoin/pull/9778
< bitcoin-git> bitcoin/master ad168ef Wladimir J. van der Laan: Merge #9778: Add two hour buffer to manual pruning...
< bitcoin-git> bitcoin/master 91fb506 Alex Morcos: Add two hour buffer to manual pruning
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3c02b957402e...ad168ef4e308
< bitcoin-git> [bitcoin] laanwj closed pull request #9779: Update nMinimumChainWork and defaultAssumeValid. (master...update_chainparams) https://github.com/bitcoin/bitcoin/pull/9779
< bitcoin-git> bitcoin/master 3f78e46 Gregory Maxwell: Update nMinimumChainWork and defaultAssumeValid.
< bitcoin-git> bitcoin/master 3c02b95 Wladimir J. van der Laan: Merge #9779: Update nMinimumChainWork and defaultAssumeValid....
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8dee82217708...3c02b957402e
< wumpus> building bitcoin core apparently breaks power supplies now :-) things should be back to normal, restarting testing gitian builds in a bit
< bitcoin-git> [bitcoin] laanwj closed pull request #9777: Handle unusual maxsigcachesize gracefully (master...sigcache2) https://github.com/bitcoin/bitcoin/pull/9777
< bitcoin-git> bitcoin/master 8dee822 Wladimir J. van der Laan: Merge #9777: Handle unusual maxsigcachesize gracefully...
< bitcoin-git> bitcoin/master 55c403b John Newbery: Ensure `-maxsigcachesize` is in valid range...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/afae75fd3dad...8dee82217708
< gmaxwell> If someone argued that adding encryption to Bitcoin would make some state actors hate bitcoin, I think that could be pretty easily refuted.
< luke-jr> gmaxwell: or possibly scared of what State actors opposing encryption might do to them/Bitcoin

2017-02-16

< gribble> https://github.com/bitcoin/bitcoin/issues/9707 | Fix RPC failure testing by jnewbery · Pull Request #9707 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9768 | [qa] [WIP] Add logging to test_framework.py by jnewbery · Pull Request #9768 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9657 | Improve rpc-tests.py by jnewbery · Pull Request #9657 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9577 | Fix docstrings in qa tests by jnewbery · Pull Request #9577 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9497 | CCheckQueue Unit Tests by JeremyRubin · Pull Request #9497 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9495 | Fix CCheckQueue IsIdle (potential) race condition by JeremyRubin · Pull Request #9495 · bitcoin/bitcoin · GitHub
< jeremyrubin> travis-gate was really a sad week for bitcoin ;)
< bitcoin-git> [bitcoin] jnewbery opened pull request #9780: Suppress noisy output from qa tests in Travis (master...travislogging) https://github.com/bitcoin/bitcoin/pull/9780
< wumpus> well if the first line contains python3 it should be run with python 3, lacking that there is no general way to detect whether code is python2 or python3. But believe me, the bitcoin core python scripts need to be run with python 3.
< wumpus> you should run all the bitcoin core scripts with python 3
< jnewbery> jonasschnelli: My preference would be to also move the bitcoin-util-test.py and bctest.py (and data for those tests) from src/test to whatever you rename qa to. Those tests seem much more like the integration tests in qa than the unit tests in src/test
< petertodd> gmaxwell: re: VM image being snapshotted and restored, that's basically a case where reusing a secret is by itself harmful - is there an example in Bitcoin where that's the case, now that we do deterministic signing?
< bitcoin-git> [bitcoin] gmaxwell opened pull request #9779: Update nMinimumChainWork and defaultAssumeValid. (master...update_chainparams) https://github.com/bitcoin/bitcoin/pull/9779
< gribble> https://github.com/bitcoin/bitcoin/issues/9773 | WIP: Return errors from importmulti if complete rescans are not successful (on top of #9761) by ryanofsky · Pull Request #9773 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9619 | Bugfix: RPC/Mining: GBT should return 1 MB sizelimit before segwit activates by luke-jr · Pull Request #9619 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9761 | Use 2 hour grace period for key timestamps in importmulti rescans by ryanofsky · Pull Request #9761 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9760 | [wallet] Remove importmulti always-true check by ryanofsky · Pull Request #9760 · bitcoin/bitcoin · GitHub
< gmaxwell> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier
< gribble> https://github.com/bitcoin/bitcoin/issues/9524 | rpc: Dont FlushStateToDisk when pruneblockchain(0) by MarcoFalke · Pull Request #9524 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9524 | rpc: Dont FlushStateToDisk when pruneblockchain(0) by MarcoFalke · Pull Request #9524 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] morcos opened pull request #9778: Add two hour buffer to manual pruning (master...2hrprune) https://github.com/bitcoin/bitcoin/pull/9778
< bitcoin-git> [bitcoin] jnewbery opened pull request #9777: Handle unusual maxsigcachesize gracefully (master...sigcache2) https://github.com/bitcoin/bitcoin/pull/9777
< bitcoin-git> [bitcoin] laanwj closed pull request #9675: Fix typo and spelling inconsistency in CONTRIBUTING.md (master...fix_typo_in_contributing) https://github.com/bitcoin/bitcoin/pull/9675
< bitcoin-git> bitcoin/master afae75f Wladimir J. van der Laan: Merge #9675: Fix typo and spelling inconsistency in CONTRIBUTING.md...
< bitcoin-git> bitcoin/master 36164fa Koki Takahashi: Fix typo and spelling inconsistency in CONTRIBUTING.md...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8743320d6cb3...afae75fd3dad
< bitcoin-git> [bitcoin] laanwj closed pull request #9763: [Trivial] Update comments referencing main.cpp (master...comments) https://github.com/bitcoin/bitcoin/pull/9763
< bitcoin-git> bitcoin/master 8743320 Wladimir J. van der Laan: Merge #9763: [Trivial] Update comments referencing main.cpp...
< bitcoin-git> bitcoin/master 00e623d CryptAxe: [Trivial] Update comments referencing main.cpp
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e43a58514dd3...8743320d6cb3
< gribble> https://github.com/bitcoin/bitcoin/issues/9675 | Fix typo and spelling inconsistency in CONTRIBUTING.md by kokifpen · Pull Request #9675 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9696 | [trivial] Fix recently introduced typos in comments by practicalswift · Pull Request #9696 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9763 | [Trivial] Update comments referencing main.cpp by CryptAxe · Pull Request #9763 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9761 | Use 2 hour grace period for key timestamps in importmulti rescans by ryanofsky · Pull Request #9761 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9671 | Fix super-unlikely race introduced in 236618061a445d2cb11e72 by TheBlueMatt · Pull Request #9671 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9773 | WIP: Return errors from importmulti if complete rescans are not successful by ryanofsky · Pull Request #9773 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj force-pushed master from df2f34d to e43a585: https://github.com/bitcoin/bitcoin/commits/master
< MarcoFalke_> maybe you `git push bitcoin` in another tab?
< gribble> https://github.com/bitcoin/bitcoin/issues/9771 | Add missing cs_wallet lock that triggers new lock held assertion by ryanofsky · Pull Request #9771 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #9770: Allow maxsigcachesize to be zero (master...sigcachemaxsize) https://github.com/bitcoin/bitcoin/pull/9770
< bitcoin-git> bitcoin/master df2f34d Wladimir J. van der Laan: Merge #9770: Allow maxsigcachesize to be zero...
< bitcoin-git> bitcoin/master d72fe44 John Newbery: Allow maxsigcachesize to be zero...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e43a58514dd3...df2f34dcad55
< midnightmagic> windows file locking works fine for monolithic files that are only modified by the software modifying them, even in 10,000+ user database environments far busier than I suspect bitcoin's databases will ever be.
< wumpus> on windows, copying *from* the bitcoin folder while bitcoin core is running can even cause it to crash
< gribble> https://github.com/bitcoin/bitcoin/issues/9524 | rpc: Dont FlushStateToDisk when pruneblockchain(0) by MarcoFalke · Pull Request #9524 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #9771: Add missing cs_wallet lock that triggers new lock held assertion (master...pr/loadlock) https://github.com/bitcoin/bitcoin/pull/9771
< bitcoin-git> bitcoin/master e43a585 Wladimir J. van der Laan: Merge #9771: Add missing cs_wallet lock that triggers new lock held assertion...
< bitcoin-git> bitcoin/master 07afcd6 Russell Yanofsky: Add missing cs_wallet lock that triggers new lock held assertion...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f8af89a91820...e43a58514dd3
< bitcoin-git> [bitcoin] laanwj closed pull request #9764: wallet: Prevent "overrides a member function but is not marked 'override'" warnings (master...2017_02_wallet_inconsistent_missing_override) https://github.com/bitcoin/bitcoin/pull/9764
< bitcoin-git> bitcoin/master f8af89a Wladimir J. van der Laan: Merge #9764: wallet: Prevent "overrides a member function but is not marked 'override'" warnings...
< bitcoin-git> bitcoin/master 6c5427d Wladimir J. van der Laan: wallet: Prevent "overrides a member function but is not marked 'override'" warnings...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1e92e041ddc8...f8af89a91820
< bitcoin-git> [bitcoin] laanwj closed pull request #9765: Harden against mistakes handling invalid blocks (master...fix-checkblock-call) https://github.com/bitcoin/bitcoin/pull/9765
< bitcoin-git> bitcoin/master 1e92e04 Wladimir J. van der Laan: Merge #9765: Harden against mistakes handling invalid blocks...
< bitcoin-git> bitcoin/master ba803ef Suhas Daftuar: Harden against mistakes handling invalid blocks...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7a93af8340d9...1e92e041ddc8
< bitcoin-git> [bitcoin] jmcorgan opened pull request #9774: Enable host lookups for -proxy and -onion parameters (master...hostname-lookups) https://github.com/bitcoin/bitcoin/pull/9774

2017-02-15

< bitcoin-git> [bitcoin] pstratem closed pull request #9762: Add txdetails parameter to getblock. (master...2017-02-14-getblock-includetxs) https://github.com/bitcoin/bitcoin/pull/9762
< bitcoin-git> [bitcoin] ryanofsky opened pull request #9773: WIP: Return errors from importmulti if complete rescans are not successful (master...pr/multicheck) https://github.com/bitcoin/bitcoin/pull/9773
< bitcoin-git> [bitcoin] ryanofsky opened pull request #9771: Add missing cs_wallet lock that triggers new lock held assertion (master...pr/loadlock) https://github.com/bitcoin/bitcoin/pull/9771
< gribble> https://github.com/bitcoin/bitcoin/issues/9725 | CValidationInterface Cleanups by TheBlueMatt · Pull Request #9725 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jnewbery reopened pull request #9770: Allow maxsigcachesize to be zero (master...sigcachemaxsize) https://github.com/bitcoin/bitcoin/pull/9770
< bitcoin-git> [bitcoin] jnewbery closed pull request #9770: Allow maxsigcachesize to be zero (master...sigcachemaxsize) https://github.com/bitcoin/bitcoin/pull/9770
< bitcoin-git> [bitcoin] jnewbery opened pull request #9770: Allow maxsigcachesize to be zero (master...sigcachemaxsize) https://github.com/bitcoin/bitcoin/pull/9770
< bitcoin-git> [bitcoin] jnewbery opened pull request #9768: [qa] [WIP] Add logging to test_framework.py (master...rpctestlogging) https://github.com/bitcoin/bitcoin/pull/9768
< bitcoin-git> [bitcoin] sipa closed pull request #9767: 0.9 (master...0.9) https://github.com/bitcoin/bitcoin/pull/9767
< bitcoin-git> [bitcoin] jaladin1222 opened pull request #9767: 0.9 (master...0.9) https://github.com/bitcoin/bitcoin/pull/9767
< bitcoin-git> [bitcoin] laanwj closed pull request #9756: Return error when importmulti called with invalid address. (master...pr/multiaddr) https://github.com/bitcoin/bitcoin/pull/9756
< bitcoin-git> bitcoin/master 7a93af8 Wladimir J. van der Laan: Merge #9756: Return error when importmulti called with invalid address....
< bitcoin-git> bitcoin/master 9acf25c Russell Yanofsky: Return error when importmulti called with invalid address....
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/476cc47da084...7a93af8340d9
< bitcoin-git> [bitcoin] jnewbery opened pull request #9766: Add --exclude option to rpc-tests.py (master...rpctestexclude) https://github.com/bitcoin/bitcoin/pull/9766
< bitcoin-git> [bitcoin] laanwj closed pull request #9758: Selectively suppress deprecation warnings (master...2017/02/deprac_warns) https://github.com/bitcoin/bitcoin/pull/9758
< bitcoin-git> bitcoin/master 476cc47 Wladimir J. van der Laan: Merge #9758: Selectively suppress deprecation warnings...
< bitcoin-git> bitcoin/master 4b6cccc Jonas Schnelli: Selectively suppress deprecation warnings
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d8e8b06bd065...476cc47da084
< bitcoin-git> [bitcoin] sdaftuar opened pull request #9765: Harden against mistakes handling invalid blocks (master...fix-checkblock-call) https://github.com/bitcoin/bitcoin/pull/9765
< bitcoin-git> [bitcoin] NicolasDorier closed pull request #8460: Parametrize buried soft fork in regtest and refactor (master...buriedsf) https://github.com/bitcoin/bitcoin/pull/8460
< wumpus> Victorsueca: depends on whether someone picks up https://github.com/bitcoin/bitcoin/pull/5525
< bitcoin-git> [bitcoin] laanwj opened pull request #9764: wallet: Prevent "overrides a member function but is not marked 'override'" warnings (master...2017_02_wallet_inconsistent_missing_override) https://github.com/bitcoin/bitcoin/pull/9764
< bitcoin-git> [bitcoin] laanwj closed pull request #9108: Use importmulti timestamp when importing watch only keys (on top of #9682) (master...watchtime) https://github.com/bitcoin/bitcoin/pull/9108
< bitcoin-git> bitcoin/master d8e8b06 Wladimir J. van der Laan: Merge #9108: Use importmulti timestamp when importing watch only keys (on top of #9682)...
< bitcoin-git> bitcoin/master a80f98b Russell Yanofsky: Use importmulti timestamp when importing watch only keys...
< bitcoin-git> bitcoin/master a58370e Russell Yanofsky: Dedup nTimeFirstKey update logic...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/4c69d683f22a...d8e8b06bd065
< bitcoin-git> [bitcoin] laanwj closed pull request #9553: Use z = std::max(x - y, 0) instead of z = x - y; if (z < 0) z = 0; (master...std-max) https://github.com/bitcoin/bitcoin/pull/9553
< bitcoin-git> bitcoin/master 4c69d68 Wladimir J. van der Laan: Merge #9553: Use z = std::max(x - y, 0) instead of z = x - y; if (z < 0) z = 0;...
< bitcoin-git> bitcoin/master a47da4b practicalswift: Use z = std::max(x - y, 0); instead of z = x - y; if (z < 0) z = 0;
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a441db01b527...4c69d683f22a
< bakunin> hiho, just wanted to say thank you, bitcoin core developers, you are doing an outstanding job.-Thank you very much.
< bitcoin-git> [bitcoin] CryptAxe opened pull request #9763: [Trivial] Update comments referencing main.cpp (master...comments) https://github.com/bitcoin/bitcoin/pull/9763
< Arvidt_> @sipa thanks for the tip. I took the second example from https://en.bitcoin.it/wiki/Protocol_documentation#version to bitcoind and got a VERACK :-)
< gribble> https://github.com/bitcoin/bitcoin/issues/9761 | Use 2 hour grace period for key timestamps in importmulti rescans by ryanofsky · Pull Request #9761 · bitcoin/bitcoin · GitHub

2017-02-14

< bitcoin-git> [bitcoin] pstratem opened pull request #9762: Add txdetails parameter to getblock. (master...2017-02-14-getblock-includetxs) https://github.com/bitcoin/bitcoin/pull/9762
< bitcoin-git> [bitcoin] ryanofsky opened pull request #9761: Use 2 hour grace period for key timestamps in importmulti rescans (master...pr/multigrace) https://github.com/bitcoin/bitcoin/pull/9761
< bitcoin-git> [bitcoin] ryanofsky opened pull request #9760: [wallet] Remove importmulti always-true check (master...pr/multitaut) https://github.com/bitcoin/bitcoin/pull/9760
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #9755: Bugfix: Qt/Options: Restore persistent "restart required" notice (master...bugfix_gui_opts_restartreq) https://github.com/bitcoin/bitcoin/pull/9755
< bitcoin-git> bitcoin/master a441db0 Jonas Schnelli: Merge #9755: Bugfix: Qt/Options: Restore persistent "restart required" notice...
< bitcoin-git> bitcoin/master 0b4f273 Luke Dashjr: Bugfix: Qt/Options: Restore persistent "restart required" notice
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e87ce95fbdc6...a441db01b527
< bitcoin-git> [bitcoin] laanwj closed pull request #9720: net: fix banning and disallow sending messages before receiving verack (master...fix-ban) https://github.com/bitcoin/bitcoin/pull/9720
< bitcoin-git> bitcoin/master 8502e7a Cory Fields: net: parse reject earlier...
< bitcoin-git> bitcoin/master cbfc5a6 Cory Fields: net: require a verack before responding to anything else...
< bitcoin-git> bitcoin/master c45b9fb Cory Fields: net: correctly ban before the handshake is complete...
< bitcoin-git> [bitcoin] laanwj pushed 7 new commits to master: https://github.com/bitcoin/bitcoin/compare/b08656e34314...e87ce95fbdc6
< bitcoin-git> [bitcoin] laanwj closed pull request #9715: Disconnect peers which we do not receive VERACKs from within 60 sec (master...2017-02-disconnect-no-verack) https://github.com/bitcoin/bitcoin/pull/9715
< bitcoin-git> bitcoin/master b436f92 Matt Corallo: qa: Expose on-connection to mininode listeners
< bitcoin-git> bitcoin/master 8aaba7a Matt Corallo: qa: mininode learns when a socket connects, not its first action
< bitcoin-git> bitcoin/master 2cbd119 Matt Corallo: Disconnect peers which we do not receive VERACKs from within 60 sec
< bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/edc9e63c5799...b08656e34314
< bitcoin-git> [bitcoin] laanwj closed pull request #9682: Require timestamps for importmulti keys (master...pr/multinow) https://github.com/bitcoin/bitcoin/pull/9682
< bitcoin-git> bitcoin/master 3cf9917 Russell Yanofsky: Add test to check new importmulti "now" value...
< bitcoin-git> bitcoin/master 266a811 Russell Yanofsky: Use MTP for importmulti "now" timestamps
< bitcoin-git> bitcoin/master 442887f Russell Yanofsky: Require timestamps for importmulti keys...
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/ec66d06e6ef3...edc9e63c5799
< wumpus> just bumped the expiration dates for my key (0x74810B012346C9A6) and the bitcoin core release signing key (0x90C8019E36C2E964) two years forward, you might want to re-fetch them
< bitcoin-git> [bitcoin] laanwj closed pull request #9751: Mini fix bincoin against bitcoin (master...patch-1) https://github.com/bitcoin/bitcoin/pull/9751
< bitcoin-git> [bitcoin] laanwj closed pull request #9735: devtools: Handle Qt formatting characters edge-case in update-translations.py (master...2017_02_qt_translations) https://github.com/bitcoin/bitcoin/pull/9735
< bitcoin-git> bitcoin/master ec66d06 Wladimir J. van der Laan: Merge #9735: devtools: Handle Qt formatting characters edge-case in update-translations.py...
< bitcoin-git> bitcoin/master 7179e7c Wladimir J. van der Laan: qt: Periodic translations update
< bitcoin-git> bitcoin/master 5e903a5 Wladimir J. van der Laan: devtools: Handle Qt formatting characters edge-case in update-translations.py...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/d978c41e1ec4...ec66d06e6ef3
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #9758: Selectively suppress deprecation warnings (master...2017/02/deprac_warns) https://github.com/bitcoin/bitcoin/pull/9758
< jonasschnelli> Would it make sense to mention something about the net refactoring in the 0.14er release notes? https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.14.0-Release-notes
< luke-jr> AFAIK there isn't a bitcoin.conf in datadir/testnet3?
< achow101> does testnet use the bitcoin.conf in the datadir or one in datadir/testnet3?

2017-02-13

< bitcoin-git> [bitcoin] ryanofsky opened pull request #9756: Return error when importmulti called with invalid address. (master...pr/multiaddr) https://github.com/bitcoin/bitcoin/pull/9756
< bitcoin-git> [bitcoin] luke-jr opened pull request #9755: Bugfix: Qt/Options: Restore persistent "restart required" notice (master...bugfix_gui_opts_restartreq) https://github.com/bitcoin/bitcoin/pull/9755
< bitcoin-git> [bitcoin] richardkiss opened pull request #9754: Change NULLFAIL => SIG_NULLFAIL. (master...feature/unify_sig_nullfail) https://github.com/bitcoin/bitcoin/pull/9754
< bitcoin-git> [bitcoin] ryanofsky opened pull request #9753: Add static_assert to prevent VARINT(<signed value>) (master...pr/varint-assert) https://github.com/bitcoin/bitcoin/pull/9753
< jcorgan> is there a particular reason bitcoin.conf only allows IP parameters by address and not hostname/dns name, other than "it hasn't been written yet"?
< bitcoin-git> [bitcoin] DATSEC opened pull request #9751: Mini fix (master...patch-1) https://github.com/bitcoin/bitcoin/pull/9751
< bitcoin-git> [bitcoin] rohundhar opened pull request #9750: Bloomfilter: parameter variables made constant (master...bloomVar) https://github.com/bitcoin/bitcoin/pull/9750
< morcos> luke-jr: right! that's why we need to work towards a bitcoin where there is no policy!! all txs look the same
< luke-jr> it's rational to filter SPK reuse in hopes of improving Bitcoin privacy, for example
< morcos> i also dislike the use of policy as something that tries to constrain users to use bitcoin in a certain way.. if its not necessary for DoS prevention or resource allocation, then good usage policies/options should be at the wallet level
< luke-jr> I don't like the direction Core is changing to where everything must be exclusively economic incentives. Bitcoin can't work with mere economic incentives as things are today. The way things are heading, Core is no longer a reference implementation, but a specific political agenda to the exclusion of others.
< luke-jr> because some miners actually care about Bitcoin
< jcorgan> is there a particular reason bitcoin.conf only allows IP parameters by address and not hostname/dns name, other than "it hasn't been written yet"?
< bitcoin-git> [bitcoin] luke-jr opened pull request #9749: If -spkreuse=0, ensure transactions in mempool always have unique scriptPubKeys (master...unique_spk_mempool) https://github.com/bitcoin/bitcoin/pull/9749

2017-02-12

< bitcoin-git> [bitcoin] fanquake closed pull request #9748: config.txt (master...patch-1) https://github.com/bitcoin/bitcoin/pull/9748
< bitcoin-git> [bitcoin] vosa88 opened pull request #9748: config.txt (master...patch-1) https://github.com/bitcoin/bitcoin/pull/9748
< bitcoin-git> [bitcoin] kobake closed pull request #9747: Vs2015 (master...vs2015) https://github.com/bitcoin/bitcoin/pull/9747
< bitcoin-git> [bitcoin] kobake opened pull request #9747: Vs2015 (master...vs2015) https://github.com/bitcoin/bitcoin/pull/9747
< bitcoin-git> [bitcoin] 34ro opened pull request #9745: [RPC] Getting confirmations command (master...add-getconfirmations-to-rpc) https://github.com/bitcoin/bitcoin/pull/9745
< bitcoin-git> [bitcoin] 34ro opened pull request #9744: Remove unused module from rpc-tests (master...remove-unused-modules-from-rpc-tests) https://github.com/bitcoin/bitcoin/pull/9744

2017-02-11

< bitcoin-git> [bitcoin] sipa opened pull request #9743: Fix several potential issues found by sanitizers (master...fsanitize) https://github.com/bitcoin/bitcoin/pull/9743
< bitcoin-git> [bitcoin] laanwj reopened pull request #3716: GUI: Receive: Remove option to reuse a previous address (master...gui_remove_addrreuse) https://github.com/bitcoin/bitcoin/pull/3716
< bitcoin-git> [bitcoin] laanwj closed pull request #9736: Pre-0.14.0 hardcoded seeds update (master...2017_02_dnsseeds) https://github.com/bitcoin/bitcoin/pull/9736
< bitcoin-git> bitcoin/master a60677e Wladimir J. van der Laan: Pre-0.14.0 hardcoded seeds update
< bitcoin-git> bitcoin/master bfa9393 Wladimir J. van der Laan: contrib/seeds: Update PATTERN_AGENT...
< bitcoin-git> bitcoin/master 4dfac2c Wladimir J. van der Laan: Update seeds tooling to Python 3...
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/a06ede9a138d...d978c41e1ec4
< gribble> https://github.com/bitcoin/bitcoin/issues/3716 | GUI: Receive: Remove option to reuse a previous address by luke-jr · Pull Request #3716 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] aideca opened pull request #9740: Add friendly output to dumpwallet (master...dumpwallet) https://github.com/bitcoin/bitcoin/pull/9740
< bitcoin-git> [bitcoin] sipa closed pull request #9708: Clean up all known races/platform-specific UB at the time PR was opened (master...2017-02-fix-copystats-races) https://github.com/bitcoin/bitcoin/pull/9708
< bitcoin-git> bitcoin/master ae683c1 Matt Corallo: Avoid copying CNodeStats to make helgrind OK with buggy std::string
< bitcoin-git> bitcoin/master 644f123 Matt Corallo: Make nTimeConnected const in CNode
< bitcoin-git> bitcoin/master 321d0fc Cory Fields: net: fix a few races. Credit @TheBlueMatt...
< bitcoin-git> [bitcoin] sipa pushed 11 new commits to master: https://github.com/bitcoin/bitcoin/compare/b860915f8b0d...a06ede9a138d

2017-02-10

< gribble> https://github.com/bitcoin/bitcoin/issues/9720 | net: fix banning and disallow sending messages before receiving verack by theuni · Pull Request #9720 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jnewbery opened pull request #9739: Fix BIP68 activation test (master...fixbip68testing) https://github.com/bitcoin/bitcoin/pull/9739
< sipa> look at what bitcoin core does
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #9707: Fix RPC failure testing (master...rpctestassert) https://github.com/bitcoin/bitcoin/pull/9707
< bitcoin-git> bitcoin/master b860915 MarcoFalke: Merge #9707: Fix RPC failure testing...
< bitcoin-git> bitcoin/master 9db8eec John Newbery: Fix RPC failure testing...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2447c1024e60...b860915f8b0d
< bitcoin-git> [bitcoin] jnewbery opened pull request #9738: gettxoutproof() should return consistent result (master...fixgettxoutproof) https://github.com/bitcoin/bitcoin/pull/9738
< bitcoin-git> bitcoin/master 2447c10 Wladimir J. van der Laan: Merge #9698: net: fix socket close race...
< bitcoin-git> [bitcoin] laanwj closed pull request #9698: net: fix socket close race (master...fix-socket-disconnect2) https://github.com/bitcoin/bitcoin/pull/9698
< bitcoin-git> bitcoin/master 9a0b784 Cory Fields: net: add a lock around hSocket
< bitcoin-git> bitcoin/master 45e2e08 Cory Fields: net: rearrange so that socket accesses can be grouped together
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/33f3b21407a3...2447c1024e60
< bitcoin-git> [bitcoin] rebroad opened pull request #9737: Don't disconnect feeler connections prematurely (master...ServicesIrrelevantForFeelerConnections) https://github.com/bitcoin/bitcoin/pull/9737
< bitcoin-git> [bitcoin] laanwj opened pull request #9736: Pre-0.14.0 hardcoded seeds update (master...2017_02_dnsseeds) https://github.com/bitcoin/bitcoin/pull/9736
< bitcoin-git> [bitcoin] laanwj opened pull request #9735: devtools: Handle Qt formatting characters edge-case in update-translations.py (master...2017_02_qt_translations) https://github.com/bitcoin/bitcoin/pull/9735
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #9730: Remove bitseed.xf2.org form the dns seed list (master...2017/02/seeds) https://github.com/bitcoin/bitcoin/pull/9730
< bitcoin-git> bitcoin/master 33f3b21 Jonas Schnelli: Merge #9730: Remove bitseed.xf2.org form the dns seed list...