2018-03-22

< bitcoin-git> bitcoin/master c8330d4 MarcoFalke: qa: Use node.datadir instead of tmpdir in test framework
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/185d48473e43...6d36f599f88e
< bitcoin-git> [bitcoin] laanwj closed pull request #12718: [Tests] Require exact match in assert_start_raises_init_eror (jnewbery) (master...Mf1803-qaRegexInitError) https://github.com/bitcoin/bitcoin/pull/12718
< bitcoin-git> bitcoin/master fae1374 MarcoFalke: qa: Allow for partial_match when checking init error...
< bitcoin-git> bitcoin/master 5812273 John Newbery: [Tests] Require exact match in assert_start_raises_init_eror()
< bitcoin-git> bitcoin/master 0ec08a6 John Newbery: [Tests] Move assert_start_raises_init_error method to TestNode
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/ad823178e85a...185d48473e43
< bitcoin-git> [bitcoin] laanwj closed pull request #12704: base58: use map instead of strchr() when decode (master...b58_bitmap) https://github.com/bitcoin/bitcoin/pull/12704
< bitcoin-git> bitcoin/master ad82317 Wladimir J. van der Laan: Merge #12704: base58: use map instead of strchr() when decode...
< bitcoin-git> bitcoin/master bcab47b Kevin Pan: use base58 map instead of strchr()
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e0f7515f5500...ad823178e85a
< bitcoin-git> [bitcoin] Empact closed pull request #12745: Expose node relay fee settings in help, independent of -help-debug (master...expose-relay-fee-settings-help) https://github.com/bitcoin/bitcoin/pull/12745
< bitcoin-git> [bitcoin] eklitzke closed pull request #12649: Add documentation about generating flame graphs. (master...flamegraphs) https://github.com/bitcoin/bitcoin/pull/12649

2018-03-21

< bitcoin-git> [bitcoin] sipa closed pull request #12750: Replace boost::call_once with std::call_once (master...21032018_call_once) https://github.com/bitcoin/bitcoin/pull/12750
< bitcoin-git> bitcoin/master 57dae3f donaloconnor: Replace boost::call_once with std::call_once
< bitcoin-git> bitcoin/master e0f7515 Pieter Wuille: Merge #12750: Replace boost::call_once with std::call_once...
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2b1c50b9352a...e0f7515f5500
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12747: Fix typos (master...typos-201803) https://github.com/bitcoin/bitcoin/pull/12747
< bitcoin-git> bitcoin/master 2b1c50b MarcoFalke: Merge #12747: Fix typos...
< bitcoin-git> bitcoin/master d27327c practicalswift: Fix typos
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2405ce1df043...2b1c50b9352a
< bitcoin-git> [bitcoin] sipa opened pull request #12752: [MOVEONLY] Move compressor utility functions out of class (master...201803_movecompress) https://github.com/bitcoin/bitcoin/pull/12752
< sipa> "bitcoin-cli help validateaddress" should show:
< bitcoin-git> [bitcoin] donaloconnor opened pull request #12750: Replace boost::call_once with std::call_once (master...21032018_call_once) https://github.com/bitcoin/bitcoin/pull/12750
< sipa> no, to bitcoind, not to bitcoin-cli
< arubi> yep, full command : `$HOME/software/install/bitcoin/regtest/bin/bitcoin-cli -deprecatedrpc=validateaddress -conf=$HOME/.bitcoin/regtest.conf -rpcuser=regtest_daemon -rpcpassword=LygXyhO0-T5g-IJOQD2TILdlbTOkrd0FCz3rbZ7jC3M= validateaddress mxFyMiGBuZp8sjXUDjQBVgevf4K3sh3HEZ`
< bitcoin-git> [bitcoin] instagibbs opened pull request #12749: feebumper: discard change outputs below discard rate (master...discardbump) https://github.com/bitcoin/bitcoin/pull/12749
< gribble> https://github.com/bitcoin/bitcoin/issues/10762 | [wallet] Remove Wallet dependencies from init.cpp by jnewbery · Pull Request #10762 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12694 | Actually disable BnB when there are preset inputs by achow101 · Pull Request #12694 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12746: tests: Remove unused argument max_invalid from check_estimates(...) (master...check_estimates-max_invalid) https://github.com/bitcoin/bitcoin/pull/12746
< bitcoin-git> bitcoin/master 2405ce1 MarcoFalke: Merge #12746: tests: Remove unused argument max_invalid from check_estimates(...)...
< bitcoin-git> bitcoin/master a004eb1 practicalswift: tests: Remove unused argument max_invalid from check_estimates(...)
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/310dc61ea3e2...2405ce1df043
< bitcoin-git> [bitcoin] laanwj closed pull request #12723: Qt5: Warning users about invalid-BIP21 URI bitcoin:// (master...qt5-uri-error-message) https://github.com/bitcoin/bitcoin/pull/12723
< bitcoin-git> bitcoin/master 310dc61 Wladimir J. van der Laan: Merge #12723: Qt5: Warning users about invalid-BIP21 URI bitcoin://...
< bitcoin-git> bitcoin/master b7fbcc5 Alexey Ivanov: Qt: Warn users about invalid-BIP21 URI bitcoin://
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4ad3b3c72c73...310dc61ea3e2
< fanquake> If you have info/debug logs ect, opening an issue is a good option: https://github.com/bitcoin/bitcoin/issues . Assuming you are running 0.16.0 ?
< bcqtsyncprob> I assure you, I have problems with bitcoin core, and it's not disk-space, network etc. related at all
< fanquake> try #bitcoin
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12716: Fix typos and cleanup in various files (master...fix-typos) https://github.com/bitcoin/bitcoin/pull/12716
< bitcoin-git> bitcoin/master 4ad3b3c MarcoFalke: Merge #12716: Fix typos and cleanup in various files...
< bitcoin-git> bitcoin/master 4d9b425 Dimitris Apostolou: Fix typos
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9b8b1079ddab...4ad3b3c72c73
< timothy> p3tr: I'm using ExecStartPost=/bin/sh -c 'while sleep 10; do /home/bitcoin/bin/bitcoin-cli ping && break; done'
< bitcoin-git> [bitcoin] practicalswift opened pull request #12747: Fix typos (master...typos-201803) https://github.com/bitcoin/bitcoin/pull/12747
< bitcoin-git> [bitcoin] practicalswift opened pull request #12746: tests: Remove unused argument max_invalid from check_estimates(...) (master...check_estimates-max_invalid) https://github.com/bitcoin/bitcoin/pull/12746
< bitcoin-git> [bitcoin] Empact opened pull request #12745: Expose node relay fee settings in help, independent of -help-debug (master...expose-relay-fee-settings-help) https://github.com/bitcoin/bitcoin/pull/12745
< gribble> https://github.com/bitcoin/bitcoin/issues/12723 | Qt5: Warning users about invalid-BIP21 URI bitcoin:// by krab · Pull Request #12723 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] practicalswift closed pull request #11694: rpc: Add missing cs_main lock in getblocktemplate(...) (master...missing-lock-in-getblocktemplate) https://github.com/bitcoin/bitcoin/pull/11694
< bitcoin-git> [bitcoin] eklitzke opened pull request #12744: Completely eliminate dependency on boost::program_options (master...program_options) https://github.com/bitcoin/bitcoin/pull/12744
< gribble> https://github.com/bitcoin/bitcoin/issues/12254 | BIP 158: Compact Block Filters for Light Clients by jimpo · Pull Request #12254 · bitcoin/bitcoin · GitHub
< Randolf> CubicEar_: Well, one good place to start, depending on your level of programming expertise, is: https://www.github.com/bitcoin/
< bitcoin-git> [bitcoin] sipa opened pull request #12743: Fix csBestBlock/cvBlockChange waiting in rpc/mining (master...201803_waitblockchange) https://github.com/bitcoin/bitcoin/pull/12743
< CubicEar_> Bitcoin Devs = Heros
< bitcoin-git> [bitcoin] sipa closed pull request #12737: Remove unnecessary NONNEGATIVE_SIGNED (master...pr/nosigned) https://github.com/bitcoin/bitcoin/pull/12737
< bitcoin-git> bitcoin/master 9b8b107 Pieter Wuille: Merge #12737: Remove unnecessary NONNEGATIVE_SIGNED...
< bitcoin-git> bitcoin/master 34ca750 Russell Yanofsky: Remove unnecessary NONNEGATIVE_SIGNED...
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4ba3d4f4393d...9b8b1079ddab
< bitcoin-git> [bitcoin] sipa opened pull request #12742: Make FastRandomContext support standard C++11 RNG interface (master...201803_stdrandom) https://github.com/bitcoin/bitcoin/pull/12742
< gribble> https://github.com/bitcoin/bitcoin/issues/4676 | Follow standard Unix daemon practices · Issue #4676 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sipa opened pull request #12740: Add native support for serializing char arrays without FLATDATA (master...201803_chararray) https://github.com/bitcoin/bitcoin/pull/12740

2018-03-20

< bitcoin-git> [bitcoin] pedrobranco opened pull request #12739: Fix unlocking of an already spent output (master...bugfix/fix-lockunspent-deadlock) https://github.com/bitcoin/bitcoin/pull/12739
< bitcoin-git> [bitcoin] ryanofsky opened pull request #12737: Remove unnecessary NONNEGATIVE_SIGNED (master...pr/nosigned) https://github.com/bitcoin/bitcoin/pull/12737
< Randolf> I like Bitcoin, and if there's an area that needs someone to help I feel like I should.
< achow101> wumpus: on https://www.transifex.com/bitcoin/teams/, do you see a button that says "manage collaborators"?
< achow101> for the bitcoin org
< bitcoin-git> [bitcoin] lutangar opened pull request #12736: [RPC][Refactoring] Meaningful error code when called with wrong number of arguments (master...error-code-for-param-number) https://github.com/bitcoin/bitcoin/pull/12736
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12728: [tests] rename TestNode to TestP2PConn in tests (master...rename_test_node) https://github.com/bitcoin/bitcoin/pull/12728
< bitcoin-git> bitcoin/master 4ba3d4f MarcoFalke: Merge #12728: [tests] rename TestNode to TestP2PConn in tests...
< bitcoin-git> bitcoin/master 728667b John Newbery: scripted-diff: rename TestNode to TestP2PConn in tests...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/55f490a79fc5...4ba3d4f4393d
< bitcoin-git> [bitcoin] laanwj closed pull request #12652: bitcoin-cli: Provide a better error message when bitcoind is not running (master...bitcoin-cli-error-message-when-bitcoind-is-not-running) https://github.com/bitcoin/bitcoin/pull/12652
< bitcoin-git> bitcoin/master 8b2ef27 practicalswift: tests: Test connecting with non-existing RPC cookie file
< bitcoin-git> bitcoin/master a2b2476 practicalswift: tests: Test connecting to a non-existing server
< bitcoin-git> bitcoin/master de04fde practicalswift: bitcoin-cli: Provide a better error message when bitcoind is not running...
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/e47682633817...55f490a79fc5
< wumpus> luke-jr: e.g. no access to https://www.transifex.com/bitcoin/teams/
< bitcoin-git> [bitcoin] laanwj closed pull request #12721: Qt: remove "new" button during receive-mode in addressbook (master...2018/03/addr_new_btn) https://github.com/bitcoin/bitcoin/pull/12721
< bitcoin-git> bitcoin/master e476826 Wladimir J. van der Laan: Merge #12721: Qt: remove "new" button during receive-mode in addressbook...
< bitcoin-git> bitcoin/master d843db7 Jonas Schnelli: Qt: remove "new" button during receive-mode in addressbook
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8ee5c7b74717...e47682633817
< fanquake> eklitze also, are you moving 12649 to the docs repo? Will ACK if you just link from the dev notes in /bitcoin
< jonasschnelli> sipa: can you comment here: https://github.com/bitcoin/bitcoin/pull/12653#issuecomment-374246044?
< gribble> https://github.com/bitcoin/bitcoin/issues/10785 | Serialization improvements by sipa · Pull Request #10785 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11857 | Build tx index in parallel with validation by jimpo · Pull Request #11857 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sipa opened pull request #12731: Support serialization as another type without casting (master...201803_astype) https://github.com/bitcoin/bitcoin/pull/12731

2018-03-19

< sipa> please take any further discussion elsewhere, it has nothing to do with bitcoin core's software development
< sipa> as far as using the signmessage functionality in bitcoin core goes, you can use validateaddress to extract the public key for an address (if it's yours), and then sign with the P1PKH address corresponding to that key instead
< sipa> bitcoin addresses are not identities
< bcamacho> luke-jr or sipa: Is there a link regarding deprecation for signmessage? I was reviewing the developer documentation and it has no mention of the deprecation: https://bitcoin.org/en/developer-reference#signmessage
< luke-jr> bitcoin.org hosts a mirror of some keys, but you should probably verify the keys are correct from multiple sources, or someone you know/trust personally
< sipa> jimpo: looking at https://github.com/bitcoin/bitcoin/commit/9ff9435ccb6668c96d6c554129a31e5de6df4dda, it uses GetOp to determine what to index
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12727: [RPC] Remove unreachable help conditions in rpcwallet.cpp (master...unreachable-help-condition) https://github.com/bitcoin/bitcoin/pull/12727
< bitcoin-git> bitcoin/master 8ee5c7b MarcoFalke: Merge #12727: [RPC] Remove unreachable help conditions in rpcwallet.cpp...
< bitcoin-git> bitcoin/master e5468a1 lutangar: Remove unreachable help conditions
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ee7b67e2784a...8ee5c7b74717
< bitcoin-git> [bitcoin] ryanofsky opened pull request #12729: Get rid of ambiguous OutputType::NONE value (master...pr/nonone) https://github.com/bitcoin/bitcoin/pull/12729
< gribble> https://github.com/bitcoin/bitcoin/issues/12254 | BIP 158: Compact Block Filters for Light Clients by jimpo · Pull Request #12254 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sipa closed pull request #12712: Support serialization as another type without casting (master...201803_astype) https://github.com/bitcoin/bitcoin/pull/12712
< bitcoin-git> [bitcoin] jnewbery opened pull request #12728: [tests] rename TestNode to TestP2PConn in tests (master...rename_test_node) https://github.com/bitcoin/bitcoin/pull/12728
< bitcoin-git> [bitcoin] laanwj closed pull request #9753: Add static_assert to prevent VARINT(<signed value>) (master...pr/varint-assert) https://github.com/bitcoin/bitcoin/pull/9753
< bitcoin-git> bitcoin/master ee7b67e Wladimir J. van der Laan: Merge #9753: Add static_assert to prevent VARINT(<signed value>)...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ebdf84c9601e...ee7b67e2784a
< bitcoin-git> bitcoin/master 499d95e Russell Yanofsky: Add static_assert to prevent VARINT(<signed value>)...
< bitcoin-git> [bitcoin] laanwj closed pull request #12700: Document RPC method aliasing (master...pr/alias) https://github.com/bitcoin/bitcoin/pull/12700
< bitcoin-git> bitcoin/master ebdf84c Wladimir J. van der Laan: Merge #12700: Document RPC method aliasing...
< bitcoin-git> bitcoin/master 4c317d8 Russell Yanofsky: Document RPC method aliasing...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/93634f296e0b...ebdf84c9601e
< bitcoin-git> [bitcoin] laanwj closed pull request #12553: Prefer wait_until over polling with time.sleep (master...wait-until) https://github.com/bitcoin/bitcoin/pull/12553
< bitcoin-git> bitcoin/master 93634f2 Wladimir J. van der Laan: Merge #12553: Prefer wait_until over polling with time.sleep...
< bitcoin-git> bitcoin/master 9d7f839 Ben Woosley: test: Use os.path.join consistently in feature_pruning tests
< bitcoin-git> bitcoin/master 81b0822 Ben Woosley: test: Use wait_until in tests where time was used for polling
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/c39dd2ef59c9...93634f296e0b
< bitcoin-git> [bitcoin] lutangar opened pull request #12727: [RPC][Trivial] Remove unreachable help conditions in `rpcwallet.cpp` (master...unreachable-help-condition) https://github.com/bitcoin/bitcoin/pull/12727
< bitcoin-git> [bitcoin] laanwj closed pull request #12408: wallet: Change output type globals to members (master...Mf1802-walletChangeTypeMember) https://github.com/bitcoin/bitcoin/pull/12408
< bitcoin-git> bitcoin/master c39dd2e Wladimir J. van der Laan: Merge #12408: wallet: Change output type globals to members...
< bitcoin-git> bitcoin/master fab8a6f MarcoFalke: wallet: Change output type globals to members
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6324c68aa017...c39dd2ef59c9
< bitcoin-git> [bitcoin] laanwj closed pull request #12678: build: Fix a few compilation issues with Clang 7 and -Werror (master...master-compilation-fixes-with-clang7-werror) https://github.com/bitcoin/bitcoin/pull/12678
< bitcoin-git> bitcoin/master 8ae4132 Vasil Dimov: Remove redundant checks for MSG_* from configure.ac...
< bitcoin-git> bitcoin/master 71129e0 Vasil Dimov: Do not check for main() in libminiupnpc...
< bitcoin-git> bitcoin/master 8c632f7 Vasil Dimov: ax_boost_{chrono,unit_test_framework}.m4: take changes from upstream...
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/872c921c0a20...6324c68aa017
< setpill> i followed the instructions on https://github.com/bitcoin-core/docs/blob/master/gitian-building/gitian-building-setup-gitian-debian.md including the rc.local stuff, not sure what i missed
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12720: qa: Avoiding 'file' function name from python2 (master...pr_12437_variable_rename) https://github.com/bitcoin/bitcoin/pull/12720
< bitcoin-git> bitcoin/master 0dbb32b Jeff Rade: Avoiding 'file' function name from python2 with more descriptive variable naming
< bitcoin-git> bitcoin/master 872c921 MarcoFalke: Merge #12720: qa: Avoiding 'file' function name from python2...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/00d1680498c5...872c921c0a20
< bitcoin-git> [bitcoin] fanquake closed pull request #12725: LCoin (master...master) https://github.com/bitcoin/bitcoin/pull/12725
< bitcoin-git> [bitcoin] mathhoang88 opened pull request #12725: LCoin (master...master) https://github.com/bitcoin/bitcoin/pull/12725
< bitcoin-git> [bitcoin] krab opened pull request #12723: Qt5: Warning users about invalid-BIP21 URI bitcoin:// (master...qt5-uri-error-message) https://github.com/bitcoin/bitcoin/pull/12723
< wump> so we've kind of reached a dead end on transifex, not being able to set team permissions, https://github.com/bitcoin/bitcoin/issues/12657#issuecomment-373956561 Does anyone know if seone gets on Freenode?
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #12721: Qt: remove "new" button during receive-mode in addressbook (master...2018/03/addr_new_btn) https://github.com/bitcoin/bitcoin/pull/12721
< gribble> https://github.com/bitcoin/bitcoin/issues/9502 | [Qt] Add option to pause/resume block downloads by jonasschnelli · Pull Request #9502 · bitcoin/bitcoin · GitHub

2018-03-18

< bitcoin-git> [bitcoin] jeffrade opened pull request #12720: Avoiding 'file' function name from python2 (master...pr_12437_variable_rename) https://github.com/bitcoin/bitcoin/pull/12720
< Lis> Would appreciate an opinion about authenticated rest api for bitcoin :)
< bitcoin-git> [bitcoin] practicalswift opened pull request #12719: tests: Add note about test suite naming convention in developer-notes.md (master...consistent-test-naming) https://github.com/bitcoin/bitcoin/pull/12719
< achow101> anyways, this is not the correct channel for asking for help. Go to #bitcoin, bitcoin.stackexchange.com, or bitcointalk.org
< VictorTrueBitcoi> devs please help, whats going on with my bitcoin core wallet, i never change pass, and computer without access, and pass wrong, i had bitcoincore 0.15.0.1 after update 0.15.1 pass wass wrong, but few time is working, and now again pass wrong
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #12718: [Tests] Require exact match in assert_start_raises_init_eror (jnewbery) (master...Mf1803-qaRegexInitError) https://github.com/bitcoin/bitcoin/pull/12718
< bitcoin-git> [bitcoin] romanz opened pull request #12717: Handle UTXO retrieval when ignoring the mempool (master...master) https://github.com/bitcoin/bitcoin/pull/12717
< eklitzke> leveldb has another cache layer that isn't really used by bitcoin
< bitcoin-git> [bitcoin] rex4539 closed pull request #12593: Fix typos and cleanup in various files (master...rex4539-typos) https://github.com/bitcoin/bitcoin/pull/12593
< bitcoin-git> [bitcoin] rex4539 opened pull request #12716: Fix typos and cleanup in various files (master...fix-typos) https://github.com/bitcoin/bitcoin/pull/12716
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #12510: test: Add rpc_bind test to default-run tests (master...2018_02_reinstate_rpcbind_test) https://github.com/bitcoin/bitcoin/pull/12510
< meshcollider> Try #bitcoin or bitcoin.stackexchange.com
< meshcollider> VictorTrueBitcoi: this is not the right place, this is a channel for the development of bitcoin core not for support
< bitcoin-git> [bitcoin] hkjn opened pull request #12715: depends: Add 'make clean' rule (master...clean-depends) https://github.com/bitcoin/bitcoin/pull/12715
< bitcoin-git> [bitcoin] sipa opened pull request #12714: Introduce interface for signing providers (master...201803_signingprovider) https://github.com/bitcoin/bitcoin/pull/12714
< bitcoin-git> [bitcoin] eklitzke opened pull request #12713: Fix unintuitive boolean option parsing behavior (master...bool-option-parsing) https://github.com/bitcoin/bitcoin/pull/12713

2018-03-17

< bitcoin-git> [bitcoin] sipa opened pull request #12712: Support serialization as another type without casting (master...201803_astype) https://github.com/bitcoin/bitcoin/pull/12712
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12710: Append scripts to new test_list array to fix bad assignment (master...PR_12437_test_runner_fix) https://github.com/bitcoin/bitcoin/pull/12710
< bitcoin-git> bitcoin/master 00d1680 MarcoFalke: Merge #12710: Append scripts to new test_list array to fix bad assignment...
< bitcoin-git> bitcoin/master b0fec8d Jeff Rade: Append scripts to new test_list array to fix bad assignment
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/585db41e9ab7...00d1680498c5
< bitcoin-git> [bitcoin] WhiteSymmetry opened pull request #12711: Update build-windows.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/12711
< bitcoin-git> [bitcoin] jeffrade opened pull request #12710: Append scripts to new test_list array to fix bad assignment (master...PR_12437_test_runner_fix) https://github.com/bitcoin/bitcoin/pull/12710
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12437: [Trivial] Simplify if-else blocks and more descriptive variable naming (master...test_runner_refactor) https://github.com/bitcoin/bitcoin/pull/12437
< bitcoin-git> bitcoin/master 585db41 MarcoFalke: Merge #12437: [Trivial] Simplify if-else blocks and more descriptive variable naming...
< bitcoin-git> bitcoin/master 97bcd36 Jeff Rade: [Trivial] Simplify if-else blocks and more descriptive variable naming
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/af20f9b1d485...585db41e9ab7
< bitcoin-git> [bitcoin] fanquake closed pull request #12707: log: Be less confusing in the way we inform the user that logging has started (master...scrolling-can-be-fun-but-this-is-too-much-fun) https://github.com/bitcoin/bitcoin/pull/12707
< bitcoin-git> [bitcoin] sipa closed pull request #12542: Remove redundant includes. Conform to header include guidelines. (master...include-guidelines) https://github.com/bitcoin/bitcoin/pull/12542

2018-03-16

< bitcoin-git> bitcoin/master af20f9b Pieter Wuille: Merge #12542: Remove redundant includes. Conform to header include guidelines....
< bitcoin-git> bitcoin/master 7ef46d0 practicalswift: Remove redundant includes. Conform to header include guidelines....
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7be9a9a570c1...af20f9b1d485
< bitcoin-git> [bitcoin] instagibbs opened pull request #12709: shuffle sendmany recipients ordering, since caller cannot control (master...shuffleoutputs) https://github.com/bitcoin/bitcoin/pull/12709
< bitcoin-git> [bitcoin] sipa opened pull request #12708: Make verify-commits.sh test that merges are clean (master...201803_cleanmerge) https://github.com/bitcoin/bitcoin/pull/12708
< bitcoin-git> [bitcoin] practicalswift opened pull request #12707: log: Be less confusing in the way we inform the user that logging has started (master...scrolling-can-be-fun-but-this-is-too-much-fun) https://github.com/bitcoin/bitcoin/pull/12707
< hkjn0> I found https://cmake.org/cmake/help/v3.0/variable/CMAKE_INSTALL_PREFIX.html which looked promising, but doesn't quite do it: 'libtool: install: /usr/bin/install -c bitcoind /usr/local/bin/usr/local/src/bitcoin/depends/armv7l-unknown-linux-gnueabihf/bin/bitcoind'
< hkjn0> i.e instead of bitcoind being installed in /usr/local/bin, I get: 'libtool: install: /usr/bin/install -c bitcoind /usr/local/src/bitcoin/depends/armv7l-unknown-linux-gnueabihf/bin/bitcoind'
< rex_4539> karelb Translations are in https://www.transifex.com/bitcoin
< karelb> @spudowiar (not here now) had an idea - that it would be good to separate RPC documentation from the code, so things like https://github.com/bitcoin-core/bitcoincore.org/pull/526 could be generated (and fixed) more easily. I was thinking which format is best
< karelb> Where do translations lie in bitcoin core source code?
< bitcoin-git> [bitcoin] kallewoof opened pull request #12705: Importmulti private key support (master...importmulti-wif-support) https://github.com/bitcoin/bitcoin/pull/12705
< bitcoin-git> [bitcoin] bitkevin opened pull request #12704: base58: use map instead of strchr() when decode (master...b58_bitmap) https://github.com/bitcoin/bitcoin/pull/12704
< gribble> https://github.com/bitcoin/bitcoin/issues/11403 | SegWit wallet support by sipa · Pull Request #11403 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] kallewoof closed pull request #12701: [wallet] importprivkey: explicit rescan for known key (master...importprivkey-explicit-rescan) https://github.com/bitcoin/bitcoin/pull/12701
< bitcoin-git> [bitcoin] kallewoof opened pull request #12702: [wallet] [rpc] [doc] importprivkey: hint about importmulti (master...importprivkey-importmulti-hint) https://github.com/bitcoin/bitcoin/pull/12702
< bitcoin-git> [bitcoin] kallewoof opened pull request #12701: [wallet] importprivkey: explicit rescan for known key (master...importprivkey-explicit-rescan) https://github.com/bitcoin/bitcoin/pull/12701
< gribble> https://github.com/bitcoin/bitcoin/issues/10785 | Serialization improvements by sipa · Pull Request #10785 · bitcoin/bitcoin · GitHub

2018-03-15

< bitcoin-git> [bitcoin] sipa closed pull request #12683: Fix more constness violations in serialization code (master...201803_moreser) https://github.com/bitcoin/bitcoin/pull/12683
< bitcoin-git> bitcoin/master 7be9a9a Pieter Wuille: Merge #12683: Fix more constness violations in serialization code...
< bitcoin-git> bitcoin/master 172f5fa Pieter Wuille: Support deserializing into temporaries...
< bitcoin-git> bitcoin/master 2761bca Pieter Wuille: Merge READWRITEMANY into READWRITE
< bitcoin-git> [bitcoin] sipa pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/2bac3e484114...7be9a9a570c1
< bitcoin-git> [bitcoin] sipa closed pull request #12621: Avoid querying unnecessary model data when filtering transactions (master...2018-03-transaction-filter-avoid-querying) https://github.com/bitcoin/bitcoin/pull/12621
< bitcoin-git> bitcoin/master 2bac3e4 Pieter Wuille: Merge #12621: Avoid querying unnecessary model data when filtering transactions...
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/df529dcc65e8...2bac3e484114
< bitcoin-git> bitcoin/master 1ee72a8 João Barbosa: qt: Avoid querying unnecessary model data when filtering transactions
< gribble> https://github.com/bitcoin/bitcoin/issues/12621 | Avoid querying unnecessary model data when filtering transactions by promag · Pull Request #12621 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sipa closed pull request #12693: Remove unused variable in SortForBlock (master...unused-sort-for-block-param) https://github.com/bitcoin/bitcoin/pull/12693
< bitcoin-git> bitcoin/master df529dc Pieter Wuille: Merge #12693: Remove unused variable in SortForBlock...
< bitcoin-git> bitcoin/master bb079a0 Drew Rasmussen: Remove unused variable in SortForBlock
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/947c25ead21a...df529dcc65e8
< bitcoin-git> [bitcoin] ryanofsky opened pull request #12700: Document RPC method aliasing (master...pr/alias) https://github.com/bitcoin/bitcoin/pull/12700
< achow101> Murch: sipa: btw started doing SRD here: https://github.com/achow101/bitcoin/tree/srd-fallback
< sipa> Particular implementations of lightning may or may not require you to run particular bitcoin implementations, but that depends heavily on what software is involved.
< sipa> Randolf: Lightning is implemented by software like c-lightning and lnd. Bitcoin is implemented by software like Bitcoin Core and btcd. They are otherwise unrelated.
< gribble> https://github.com/bitcoin/bitcoin/issues/10637 | Coin Selection with Murchs algorithm by achow101 · Pull Request #10637 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12605 | High level road map for coin selection changes · Issue #12605 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11402 | [wallet] Use shared pointer for wallet instances by promag · Pull Request #11402 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12587 | Introduce g_wallet_manager, prepare for better dynamic wallet loading/unloading by jonasschnelli · Pull Request #12587 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10244 | Refactor: separate gui from wallet and node by ryanofsky · Pull Request #10244 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11383 | Basic Multiwallet GUI support by luke-jr · Pull Request #11383 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10740 | [WIP] [wallet] dynamic loading/unloading of wallets by jnewbery · Pull Request #10740 · bitcoin/bitcoin · GitHub
< Randolf> I'm thinking that it may be good to indicate it prominently on the bitcoin.org web site or a readme file clearly.
< Randolf> achow101: Well, I see the question come up from time-to-time in the #bitcoin channel, and in other IRC channels there's disagreement about whether it's fully implemented or at all.
< sipa> and if you mean Bitcoin Core, that has nothing to do with Lightning
< sipa> there is no such thing as "Bitcoin 0.16"
< Randolf> There seems to be confusion about whether Lightning Network is supported in Bitcoin 0.16.
< gribble> https://github.com/bitcoin/bitcoin/issues/12254 | BIP 158: Compact Block Filters for Light Clients by jimpo · Pull Request #12254 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11383 | Basic Multiwallet GUI support by luke-jr · Pull Request #11383 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12560 | [wallet][RPC] Set or generate a new HD seed by achow101 · Pull Request #12560 · bitcoin/bitcoin · GitHub
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator
< bitcoin-git> [bitcoin] instagibbs opened pull request #12699: Shuffle transaction inputs before returning from SelectCoins (master...shuffleinputs) https://github.com/bitcoin/bitcoin/pull/12699
< gribble> https://github.com/bitcoin/bitcoin/issues/12624 | Release schedule for 0.17.0 · Issue #12624 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #12431: Only call NotifyBlockTip when chainActive changes (master...jamesob/2018-02-prevent-bad-latestblock) https://github.com/bitcoin/bitcoin/pull/12431
< bitcoin-git> bitcoin/master 947c25e Wladimir J. van der Laan: Merge #12431: Only call NotifyBlockTip when chainActive changes...
< bitcoin-git> bitcoin/master f98b543 James O'Beirne: Only call NotifyBlockTip when the active chain changes...
< bitcoin-git> bitcoin/master 152b7fb James O'Beirne: [tests] Add a (failing) test for waitforblockheight...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/e057589dc67f...947c25ead21a
< bitcoin-git> [bitcoin] eklitzke opened pull request #12696: Fix possible data race when committing block files (master...fsync) https://github.com/bitcoin/bitcoin/pull/12696
< bitcoin-git> [bitcoin] eklitzke opened pull request #12695: [build] Fix some strange behavior with --enable-debug (master...enabledebug) https://github.com/bitcoin/bitcoin/pull/12695
< bitcoin-git> [bitcoin] kallewoof closed pull request #10877: [rpc] Verbose flags for chaining and scripting (master...verbose-flagging) https://github.com/bitcoin/bitcoin/pull/10877
< bitcoin-git> [bitcoin] kallewoof closed pull request #10585: [WIP] PoW connection slots (master...pow-connection-slots) https://github.com/bitcoin/bitcoin/pull/10585
< bitcoin-git> [bitcoin] kallewoof closed pull request #10386: [WIP] [wallet] Optional '-avoidreuse' flag which defaults to not reusing addresses in sends (master...feature-white-black-address) https://github.com/bitcoin/bitcoin/pull/10386
< bitcoin-git> [bitcoin] achow101 opened pull request #12694: Actually disable BnB when there are preset inputs (master...fix-preset-coins-bnb) https://github.com/bitcoin/bitcoin/pull/12694
< bitcoin-git> [bitcoin] drewx2 opened pull request #12693: Remove unused variable in SortForBlock (master...unused-sort-for-block-param) https://github.com/bitcoin/bitcoin/pull/12693
< bitcoin-git> [bitcoin] eklitzke opened pull request #12692: Add configure options for various -fsanitize flags (master...sanitize) https://github.com/bitcoin/bitcoin/pull/12692
< gribble> https://github.com/bitcoin/bitcoin/issues/12690 | LevelDB "corrupted compressed block contents" errors · Issue #12690 · bitcoin/bitcoin · GitHub
< eklitzke> if you notice anyone on github opening issues about corrupted chainstate databases (i know this is a fairly common issue for people to open), direct them to #12690 and ask them to compile bitcoin with the new leveldb error log messages which are in master now

2018-03-14

< bitcoin-git> [bitcoin] eklitzke opened pull request #12689: Smarter default behavior for -printtoconsole (master...console) https://github.com/bitcoin/bitcoin/pull/12689
< gribble> https://github.com/bitcoin/bitcoin/issues/12621 | Avoid querying unnecessary model data when filtering transactions by promag · Pull Request #12621 · bitcoin/bitcoin · GitHub
< santiago0> I'm IT student. Never participated to bigger projects. How do you manage bitcoin source code? What IDE are you using?
< bitcoin-git> [bitcoin] dooglus closed pull request #11085: Add 'sethdseed' RPC to initialize or replace HD seed. (master...set_hd_seed) https://github.com/bitcoin/bitcoin/pull/11085
< gribble> https://github.com/bitcoin/bitcoin/issues/11497 | Hide accounts system behind deprecation switch by achow101 · Pull Request #11497 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/7729 | rpc: introduce label API for wallet by laanwj · Pull Request #7729 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11536 | Rename account to label where appropriate by ryanofsky · Pull Request #11536 · bitcoin/bitcoin · GitHub
< iyahjeff> Hi there. Anyone running a full BTC node on Linux that would be kind enough to paste me the output of “du -shm .bitcoin/blocks/”
< bitcoin-git> [bitcoin] Sjors closed pull request #12687: Remove unused -testsafemode [AKA: why this PR is wrong] (master...2018-03/testsafemode) https://github.com/bitcoin/bitcoin/pull/12687
< bitcoin-git> [bitcoin] Sjors opened pull request #12687: Remove unused -testsafemode [AKA: why this PR is wrong] (master...2018-03/testsafemode) https://github.com/bitcoin/bitcoin/pull/12687
< bitcoin-git> [bitcoin] laanwj closed pull request #10637: Coin Selection with Murch's algorithm (master...bnb-coin-select) https://github.com/bitcoin/bitcoin/pull/10637
< bitcoin-git> bitcoin/master f84fed8 Andrew Chow: Store effective value, fee, and long term fee in CInputCoin...
< bitcoin-git> bitcoin/master 0185939 Andrew Chow: Implement Branch and Bound coin selection in a new file...
< bitcoin-git> bitcoin/master 12ec29d Andrew Chow: Calculate and store the number of bytes required to spend an input
< bitcoin-git> [bitcoin] laanwj pushed 14 new commits to master: https://github.com/bitcoin/bitcoin/compare/e7721e667260...e057589dc67f
< bitcoin-git> [bitcoin] laanwj closed pull request #12586: docs: Update osx brew install instruction (master...homebrew-python3-python) https://github.com/bitcoin/bitcoin/pull/12586
< bitcoin-git> bitcoin/master e7721e6 Wladimir J. van der Laan: Merge #12586: docs: Update osx brew install instruction...
< bitcoin-git> bitcoin/master 59f4795 fanquake: docs: Update osx brew install instruction
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/de2fcaa89a61...e7721e667260
< bitcoin-git> [bitcoin] laanwj closed pull request #12668: Doc: do update before fetching packages in WSL build guide (master...patch-1) https://github.com/bitcoin/bitcoin/pull/12668
< bitcoin-git> bitcoin/master de2fcaa Wladimir J. van der Laan: Merge #12668: Doc: do update before fetching packages in WSL build guide...
< bitcoin-git> bitcoin/master e29c6c8 Nick Vercammen: Ubuntu xenial first dependencies...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/56cc022112af...de2fcaa89a61
< bitcoin-git> [bitcoin] laanwj closed pull request #12636: backport: #11995 Fix Qt build with Xcode 9 (0.16...qt-fix-backport) https://github.com/bitcoin/bitcoin/pull/12636
< gribble> https://github.com/bitcoin/bitcoin/issues/12507 | Interrupt rescan on shutdown request by promag · Pull Request #12507 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12668 | Doc: Ubuntu xenial first dependencies by nvercamm · Pull Request #12668 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #12080: Add support to search the address book (master...2018-01-searchaddressbook) https://github.com/bitcoin/bitcoin/pull/12080
< bitcoin-git> bitcoin/master 56cc022 Wladimir J. van der Laan: Merge #12080: Add support to search the address book...
< bitcoin-git> bitcoin/master c316fdf João Barbosa: [qt] Add support to search the address book
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/05042d38ba56...56cc022112af
< bitcoin-git> [bitcoin] laanwj closed pull request #12666: configure: UniValue 1.0.4 is required for pushKV(, bool) (master...univalue-1.0.4-required) https://github.com/bitcoin/bitcoin/pull/12666
< bitcoin-git> bitcoin/master 05042d3 Wladimir J. van der Laan: Merge #12666: configure: UniValue 1.0.4 is required for pushKV(, bool)...
< bitcoin-git> bitcoin/master 8172d3a Luke Dashjr: configure: UniValue 1.0.4 is required for pushKV(, bool)
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7fb8fb43a630...05042d38ba56
< wumpus> fanquake: at least the documentation for it should go into the docs repo, so that it's with the other menagerie of gitian building methods. If there are scripts that are more-or-less bound to the bitcoin core release schedule they can be in our repo. Not sure.
< gribble> https://github.com/bitcoin/bitcoin/issues/12656 | Add scripts for doing gitian builds on any platform using VirtualBox + Vagrant + Packer by maaku · Pull Request #12656 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12657 | Serbian Translation / Cyrillic and Latin - Needs better distinction on Transifex · Issue #12657 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #12510: test: Add rpc_bind test to default-run tests (master...2018_02_reinstate_rpcbind_test) https://github.com/bitcoin/bitcoin/pull/12510
< bitcoin-git> [bitcoin] fanquake closed pull request #12316: Upgrade depends/build system to use Qt 5.9.4 (master...patch-1) https://github.com/bitcoin/bitcoin/pull/12316
< gribble> https://github.com/bitcoin/bitcoin/issues/12316 | Upgrade depends/build system to use Qt 5.9.4 by thijstriemstra · Pull Request #12316 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12460 | Assert CPubKey::ValidLength to the pubkeys header-relevant size by Empact · Pull Request #12460 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake closed pull request #12685: [gui] script addresses for sending, not signing (master...master) https://github.com/bitcoin/bitcoin/pull/12685
< bitcoin-git> [bitcoin] laanwj closed pull request #12102: Apply hardening measures in bitcoind systemd service file (master...systemd-hardening) https://github.com/bitcoin/bitcoin/pull/12102
< bitcoin-git> bitcoin/master 7fb8fb4 Wladimir J. van der Laan: Merge #12102: Apply hardening measures in bitcoind systemd service file...
< bitcoin-git> bitcoin/master 79ddfad Florian Schmaus: Apply hardening measurements in bitcoind systemd service file...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c4219ff3786e...7fb8fb43a630
< gribble> https://github.com/bitcoin/bitcoin/issues/12102 | Apply hardening measures in bitcoind systemd service file by Flowdalic · Pull Request #12102 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #12625: depends: biplist 1.0.3 (master...biplist-1-0-3) https://github.com/bitcoin/bitcoin/pull/12625
< bitcoin-git> bitcoin/master c4219ff Wladimir J. van der Laan: Merge #12625: depends: biplist 1.0.3...
< bitcoin-git> bitcoin/master 4ef82f1 fanquake: depends: biplist 1.0.3
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ce6ffe196e9b...c4219ff3786e
< bitcoin-git> [bitcoin] laanwj closed pull request #12638: qa: Cache only chain and wallet for regtest datadir (master...Mf1803-qaMempoolCache) https://github.com/bitcoin/bitcoin/pull/12638
< bitcoin-git> bitcoin/master ce6ffe1 Wladimir J. van der Laan: Merge #12638: qa: Cache only chain and wallet for regtest datadir...
< bitcoin-git> bitcoin/master fa23105 MarcoFalke: qa: Cache only chain and wallet for regtest datadir
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9f04c8e23118...ce6ffe196e9b
< gribble> https://github.com/bitcoin/bitcoin/issues/11383 | Basic Multiwallet GUI support by luke-jr · Pull Request #11383 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] practicalswift opened pull request #12686: travis: Generate a trap for signed arithmetic overflows (enable -ftrapv) (master...trapv) https://github.com/bitcoin/bitcoin/pull/12686
< gribble> https://github.com/bitcoin/bitcoin/issues/12599 | [gui] Use base58 script hash address as example by bill-walker · Pull Request #12599 · bitcoin/bitcoin · GitHub