< jnewbery>
sipa: I can think of a couple of good solutions to the old encrypted wallet at start: 1. have a bitcoin-wallet util that can topup the keypool offline. 2. have a `loadwallet` RPC that can decrypt on load
< gribble>
https://github.com/bitcoin/bitcoin/issues/10672 | Avoid division by zero in the case of a corrupt estimates file by practicalswift · Pull Request #10672 · bitcoin/bitcoin · GitHub
< ryanofsky>
i think changes to bitcoin-cli are simple but ugly
< jnewbery>
with (2), the bitcoin-cli caller needs to change to include a `-usewallet` argument. With (1) the entire invocation needs to change
< jnewbery>
I think (2) is better in that respect. We need to modify bitcoin-cli, but we have those changes already coded. With (1), every script that calls wallet methods using bitcoin-cli needs to be changed because positional arguments are no longer supported
< ryanofsky>
yes named arguments require no changes to bitcoin-cli
< jnewbery>
> countervailing tradeoffs like having to modify bitcoin-cli
< ryanofsky>
your second reason is reason sipa & gmaxwell like approaches (2)&(3) over approach (1), in that respect there is no distiniction between (2)/(3), and countervailing tradeoffs like having to modify bitcoin-cli and other things i mentioned above
< gribble>
https://github.com/bitcoin/bitcoin/issues/10579 | [RPC] Split signrawtransaction into wallet and non-wallet RPC command by achow101 · Pull Request #10579 · bitcoin/bitcoin · GitHub
< ryanofsky>
also just to list other practical advantages i see in (1) over (2/3). Requires no changes to bitcoin-cli. Is properly documented, easy to understand, just a param. Encourages named arguments. Allows checking wallet name for safety even with multiprocess.
< ryanofsky>
i also want to point out that there we are talking about 1 practical tradeoff between 1 & 2/3, there are other practical advantages to 1 like not having to modify bitcoin-cli
< sipa>
BlueMatt: the bitcoin specific shims can be trivially patched to pass that through
< bitcoin-git>
[bitcoin] gmaxwell opened pull request #10854: Avoid using sizes on non-fixed-width types to derive protocol constants. (master...rbf-numlimit-fix) https://github.com/bitcoin/bitcoin/pull/10854
< gribble>
https://github.com/bitcoin/bitcoin/issues/10672 | Avoid division by zero in the case of a corrupt estimates file by practicalswift · Pull Request #10672 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/10831 | Batch flushing operations to the walletdb during top up and increase keypool size. by gmaxwell · Pull Request #10831 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] laanwj closed pull request #10831: Batch flushing operations to the walletdb during top up and increase keypool size. (master...topup_batch_flush) https://github.com/bitcoin/bitcoin/pull/10831
< bitcoin-git>
bitcoin/master 30d8f3a Gregory Maxwell: Pushdown walletdb though CWallet::AddKeyPubKey to avoid flushes....
< bitcoin-git>
[bitcoin] laanwj closed pull request #10832: init: Factor out AppInitLockDataDirectory and fix startup core dump issue (master...2017_07_appinitlockdatadirectory) https://github.com/bitcoin/bitcoin/pull/10832
< bitcoin-git>
bitcoin/master 89bb036 Wladimir J. van der Laan: Merge #10832: init: Factor out AppInitLockDataDirectory and fix startup core dump issue...
< bitcoin-git>
bitcoin/master dba485d Wladimir J. van der Laan: init: Factor out AppInitLockDataDirectory...
< gmaxwell>
wumpus: I liked it except for one concern, the parity between the CLI and RPC is a major learing curve improvement. If we went down the path of a highly cooked bitcoin-cli then knoweldge wouldn't automatically transfer between them, improvements wouldn't automatically transfer, etc.
< gmaxwell>
rename bitcoin-cli bitcoin-rpc and we create a real bitcoin-cli ? :P
< bitcoin-git>
[bitcoin] jnewbery closed pull request #10841: [rpc] Give users one final warning before removing getinfo (master...deprecate_getinfo) https://github.com/bitcoin/bitcoin/pull/10841
< gribble>
https://github.com/bitcoin/bitcoin/issues/10831 | Batch flushing operations to the walletdb during top up and increase keypool size. by gmaxwell · Pull Request #10831 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] practicalswift closed pull request #10847: Enable devirtualization opportunities by using the final specifier (C++11) (master...devirtualization) https://github.com/bitcoin/bitcoin/pull/10847
< gribble>
https://github.com/bitcoin/bitcoin/issues/10831 | Batch flushing operations to the walletdb during top up and increase keypool size. by gmaxwell · Pull Request #10831 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/10831 | Batch flushing operations to the walletdb during top up and increase keypool size. by gmaxwell · Pull Request #10831 · bitcoin/bitcoin · GitHub
< bitcoin-git>
bitcoin/master 3895e25 MarcoFalke: Merge #10842: Fix incorrect Doxygen tag (@ince → @since). Doxygen parameter name matching....
< bitcoin-git>
bitcoin/master 2c2e90d practicalswift: Fix incorrect Doxygen tag (@ince → @since). Make Doxygen parameter names match actual parameter names.
< bitcoin-git>
[bitcoin] practicalswift opened pull request #10847: Enable devirtualization opportunities by using the final specifier (C++11) (master...devirtualization) https://github.com/bitcoin/bitcoin/pull/10847
< bitcoin-git>
bitcoin/master 1fc783f MarcoFalke: Merge #10739: test: Move variable `state` down where it is used...
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #10739: test: Move variable `state` down where it is used (master...20170704_Wshadow_txvalidationcache_tests) https://github.com/bitcoin/bitcoin/pull/10739
< bitcoin-git>
bitcoin/master 5618b7d Pavel Janík: Do not shadow upper local variable `state`.
< bitcoin-git>
[bitcoin] practicalswift opened pull request #10843: Add attribute [[noreturn]] (C++11) to functions that will not return (master...noreturn) https://github.com/bitcoin/bitcoin/pull/10843
< bitcoin-git>
[bitcoin] practicalswift opened pull request #10842: Fix incorrect Doxygen tag (@ince → @since) (master...doxygen-since) https://github.com/bitcoin/bitcoin/pull/10842
< bitcoin-git>
[bitcoin] jnewbery opened pull request #10841: [rpc] Give users one final warning before depracating getinfo (master...deprecate_getinfo) https://github.com/bitcoin/bitcoin/pull/10841
< sipa>
your question is about how bitcoin transactions work
< sipa>
or #bitcoin
< sipa>
not here, try bitcoin.stackexchange.com
< AsadSalman>
I'm working in the bitcoin core, trying to get the amount of a transaction sent into the mempool
< bitcoin-git>
[bitcoin] practicalswift opened pull request #10839: Don't use pass by reference to const for cheaply-copied types (bool, char, etc.). (master...dont-pass-by-reference-for-cheaply-copied-types) https://github.com/bitcoin/bitcoin/pull/10839
< bitcoin-git>
[bitcoin] paveljanik opened pull request #10835: Do not shadow a field of 'reverse_range<T>' (master...20170715_Wshadow_reverseiterator) https://github.com/bitcoin/bitcoin/pull/10835
< jamesob>
If I wanted to do some kind of analysis on the UTXO set, is my best bet forking and making use of CCoinsView somehow? is https://github.com/bitcoin/bitcoin/pull/7759 worth resurrecting?
< bitcoin-git>
[bitcoin] gmaxwell opened pull request #10831: Batch flushing operations to the walletdb during top up and increase keypool size. (master...topup_batch_flush) https://github.com/bitcoin/bitcoin/pull/10831
< bitcoin-git>
[bitcoin] sipa closed pull request #10557: Make check to distinguish between orphan txs and old txs more efficient. (master...dontcheckoutputs) https://github.com/bitcoin/bitcoin/pull/10557
< bitcoin-git>
bitcoin/master 66270a4 Pieter Wuille: Merge #10557: Make check to distinguish between orphan txs and old txs more efficient....
< bitcoin-git>
bitcoin/master 18bacec Alex Morcos: Make check to distinguish between orphan txs and old txs more efficient....
< To7>
Core dev, time to protect Bitcoin differently.
< bitcoin-git>
[bitcoin] fametrano opened pull request #10825: Net set regtest JSON-RPC port to 18443 to avoid conflict with testnet 18332 (master...fametrano-regtestport) https://github.com/bitcoin/bitcoin/pull/10825
< mmgen>
yet #bitcoin-core-dev doesn't
< mmgen>
arubi: agreed, this is offtop, but #bitcoin-dev requires registration doesn't it?
< arubi>
mmgen, then your sig is not valid. it's too off topic here. we can move to #bitcoin-dev if you want
< bitcoin-git>
[bitcoin] promag opened pull request #10824: Avoid unnecessary work in SetNetworkActive (master...2017-07-set-network-active) https://github.com/bitcoin/bitcoin/pull/10824
< bitcoin-git>
[bitcoin] greenaddress opened pull request #10823: Allow all mempool txs to be replaced after a configurable timeout (default 6h) (master...replace-by-fee-old-transactions) https://github.com/bitcoin/bitcoin/pull/10823
< wumpus>
sipa: hah, no need to wait for that, I compile bitcoin core on openbsd quite a lot
< gribble>
https://github.com/bitcoin/bitcoin/issues/10275 | [rpc] Allow fetching tx directly from specified block in getrawtransaction by kallewoof · Pull Request #10275 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] jtimon opened pull request #10822: TOTEST: Also server txo from gettxout (not just utxo and mempool) (master...b15-rpc-txo) https://github.com/bitcoin/bitcoin/pull/10822
< bitcoin-git>
[bitcoin] laanwj closed pull request #10806: build: verify that the assembler can handle crc32 functions (master...configure-check-asm) https://github.com/bitcoin/bitcoin/pull/10806
< bitcoin-git>
bitcoin/master db825d2 Wladimir J. van der Laan: Merge #10806: build: verify that the assembler can handle crc32 functions...
< bitcoin-git>
bitcoin/master d34d77a Cory Fields: build: verify that the assembler can handle crc32 functions...
< luke-jr>
the only ways I see to improve on how we do it now are 1) we lost a manpage for bitcoin.conf, and 2) they ideally would be auto-generated during the build
< rhavar>
If you can see why that model doesn't pick the obvious solution (the one you can force it to), I'd be happy to give you a $100 in bitcoin or something :P
< rhavar>
I got like 10-15 emails yesterday from people freaking out after the bitcoin.org notice lolz ><
< gribble>
https://github.com/bitcoin/bitcoin/issues/8498 | Near-Bugfix: Optimization: Minimize the number of times it is checked that no money... by jtimon · Pull Request #8498 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] laanwj opened pull request #10818: init: Keep track of whether data directory locked, don't cleanup if not (master...2017_05_locked_datadir) https://github.com/bitcoin/bitcoin/pull/10818
< bitcoin-git>
[bitcoin] morcos opened pull request #10816: Properly forbid -salvagewallet and -zapwallettxes for multi wallet. (master...multiwallet_parameters) https://github.com/bitcoin/bitcoin/pull/10816
< gribble>
https://github.com/bitcoin/bitcoin/issues/10604 | [wallet] [tests] Add listwallets RPC, include wallet name in `getwalletinfo` and add multiwallet test by jnewbery · Pull Request #10604 · bitcoin/bitcoin · GitHub