< gmaxwell>
luke-jr: perhaps you should take it seriously when many people are telling you that this is a lot like Bitcoin XT or Bitcoin Classic's hardfork, but you've just defined yourself into a corner.
< spudowiar>
One issue I have is that waiting for the output of the command is run on the UI thread, so Bitcoin Core appears to hang :/
< bitcoin-git>
[bitcoin] practicalswift opened pull request #10523: Perform member initialization in initialization lists where possible (master...initialization-list) https://github.com/bitcoin/bitcoin/pull/10523
< spudowiar>
It's basically mimicking the API, because you could just as easily have the HWW plugin connect to the Bitcoin Core over HTTP RPC
< spudowiar>
luke-jr: Because then you can do "Bitcoin Core asks HWW signrawtransaction", "HWW asks Bitcoin Core gettransaction", "HWW responds to signrawtransaction"
< spudowiar>
But I could do stdin, stdout and a file descriptor for a socket (to the Bitcoin daemon RPC server)
< bitcoin-git>
[bitcoin] jonasschnelli opened pull request #10517: Factor out CCoinsView based AreInputsStandard/IsWitnessStandard (master...2017/06/policy_compile) https://github.com/bitcoin/bitcoin/pull/10517
< gmaxwell>
spudowiar: but you can't do anything with bitcoin transactions without also having bitcoin transaction ser/des support! and then you have to worry about that your json format cannot losslessly represent a transaction. Decoderawtransaction cannot. E.g. it can't encoding different choices for encoding in varints.
< bitcoin-git>
[bitcoin] sipa closed pull request #10500: Avoid CWalletTx copies in GetAddressBalances and GetAddressGroupings (master...pr/wtxcopy) https://github.com/bitcoin/bitcoin/pull/10500
< bitcoin-git>
bitcoin/master 098b01d Pieter Wuille: Merge #10500: Avoid CWalletTx copies in GetAddressBalances and GetAddressGroupings...
< bitcoin-git>
bitcoin/master b9b814a Russell Yanofsky: Avoid CWalletTx copies in GetAddressBalances and GetAddressGroupings
< spudowiar>
If there's an error, it returns a non-zero status and the message on stdin is used as the failure message in Bitcoin Core
< spudowiar>
Then Bitcoin Core verifies that
< gmaxwell>
uh? perhaps but you have to be able to handle the bitcoin seralization in order to compute any hashes over it.
< spudowiar>
gmaxwell: Is JSON alright for serializing data for hardware wallet support? I think it'll be easier for the external tools than normal Bitcoin serialization
< bitcoin-git>
[bitcoin] luke-jr opened pull request #10512: Rework same-chain from abusing DoS banning, to explicit checks (master...samechain_rework) https://github.com/bitcoin/bitcoin/pull/10512
< gribble>
https://github.com/bitcoin/bitcoin/issues/10179 | Give CValidationInterface Support for calling notifications on the CScheduler Thread by TheBlueMatt · Pull Request #10179 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] sipa opened pull request #10503: Use REJECT_DUPLICATE for already known and conflicted txn (master...more61duplicate) https://github.com/bitcoin/bitcoin/pull/10503
< gmaxwell>
holy crap Block Filter Digest profiling post on bitcoin-dev.
< bitcoin-git>
[bitcoin] jtimon opened pull request #10502: scripted-diff: Remove BOOST_FOREACH, Q_FOREACH and PAIRTYPE (master...b15-boost-foreach) https://github.com/bitcoin/bitcoin/pull/10502
< bitcoin-git>
[bitcoin] laanwj closed pull request #10475: [RPC] getmempoolinfo mempoolminfee is a BTC/KB feerate (master...poolfeerate) https://github.com/bitcoin/bitcoin/pull/10475
< bitcoin-git>
bitcoin/master 39039b1 Wladimir J. van der Laan: Merge #10475: [RPC] getmempoolinfo mempoolminfee is a BTC/KB feerate...
< bitcoin-git>
bitcoin/master f128f78 Gregory Sanders: getmempool mempoolminfee is a BTC/KB feerate
< bitcoin-git>
[bitcoin] practicalswift opened pull request #10498: Use static_cast instead of C-style casts for non-fundamental types (master...static_cast) https://github.com/bitcoin/bitcoin/pull/10498
< bitcoin-git>
bitcoin/0.14 9e3ad50 Cory Fields: net: only enforce the services required to connect...
< bitcoin-git>
[bitcoin] practicalswift opened pull request #10493: Use range-based for loops (C+11) when looping over map elements (master...map) https://github.com/bitcoin/bitcoin/pull/10493
2017-05-31
< qwebirc808709>
http://bitcoin-fast.com/ (min deposit is 0.01 Bitcoins) 200% Return of your selected invested amount in 100 Hours.
< instagibbs>
Paiten, #bitcoin for user questions :)
< cfields>
jonasschnelli: I finally got around to taking a look at bitcoin-wallet-tool. Ping me when you have a few min to discuss
< bitcoin-git>
[bitcoin] practicalswift opened pull request #10483: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL (master...nullptr) https://github.com/bitcoin/bitcoin/pull/10483
< jtimon>
sipa: do you want me to s/blockHash/hashBlock/ in https://github.com/bitcoin/bitcoin/pull/10339 ? I'm fine, but I wasn't trying to use hungarian notation there, just blockHash as opposed to txHash
< bitcoin-git>
[bitcoin] jnewbery opened pull request #10479: [trivial] Fix comment for ForceSetArg() (master...trivial_forcesetarg_comment) https://github.com/bitcoin/bitcoin/pull/10479
< bitcoin-git>
[bitcoin] laanwj opened pull request #10478: rpc: Add listen address to incoming connections in `getpeerinfo` (master...2017_05_peer_listenaddr) https://github.com/bitcoin/bitcoin/pull/10478
< bitcoin-git>
[bitcoin] cg31 opened pull request #10477: Use C++ initializer to initialze map and implement map comparator as const (master...master) https://github.com/bitcoin/bitcoin/pull/10477
< bitcoin-git>
[bitcoin] laanwj closed pull request #10460: Broadcast address every day, not 9 hours (master...hour_is_not_24_minutes) https://github.com/bitcoin/bitcoin/pull/10460
< bitcoin-git>
bitcoin/master 5c63d66 Wladimir J. van der Laan: Merge #10460: Broadcast address every day, not 9 hours...
< bitcoin-git>
bitcoin/master 010d68e Pieter Wuille: Broadcast address every day, not 9 hours
< warren>
I ask now because of BIP154 which does have a reference implementation for current bitcoin.
< bitcoin-git>
[bitcoin] pavlosantoniou opened pull request #10471: Denote function CNode::GetRecvVersion() as const (master...master) https://github.com/bitcoin/bitcoin/pull/10471
2017-05-27
< bitcoin-git>
[bitcoin] mchrostowski opened pull request #10470: Fix for listsinceblock not filtering conflicted transactions (master...listsinceblock-filter-conflicts) https://github.com/bitcoin/bitcoin/pull/10470
< jtimon>
gmaxwell: updated https://github.com/bitcoin/bitcoin/pull/10462 with my proposed modifications to bip8, the first commit implements the original specification. I hope people like the changes
< bitcoin-git>
[bitcoin] sipa closed pull request #10445: Add test for empty chain and reorg consistency for gettxoutsetinfo. (master...test_more_gettxoutset) https://github.com/bitcoin/bitcoin/pull/10445
< bitcoin-git>
bitcoin/master b4b057a Pieter Wuille: Merge #10445: Add test for empty chain and reorg consistency for gettxoutsetinfo....
< bitcoin-git>
bitcoin/master 513da90 Gregory Maxwell: Add test for empty chain and reorg consistency for gettxoutsetinfo.
< bitcoin-git>
bitcoin/master 822755a Pieter Wuille: Fix: make CCoinsViewDbCursor::Seek work for missing keys...
< da2ce7>
If Bitcoin XT was a soft-fork, I would checkpoint so that my node would NEVER reorg onto their chain, even if they gain a majority hashrate.
< da2ce7>
Or dose Bitcoin Core not want to merge in such code?
< instagibbs>
discussion has been moved to #bitcoin, fwiw...
< petertodd>
luke-jr: chances are the majority of bitcoin users aren't on any social media at all you know...
< jtimon>
of course it is, but yeah, let's go #bitcoin or something
< jcorgan>
this is #bitcoin-dev or even #bitcoin territory, can we please get back to business
< jonasschnelli>
sdfkjs23: this channel is specific for bitcoin-core (the client) development. General bitcoin protocol and consensus discussion shall happen in #bitcoin-dev
< gmaxwell>
sdfkjs23: nonsense. we are not netural. E.g. We support Bitcoin and are not ambivilant towards things that would damage it. Would you suggest the project also merge a switch that if set allows mtgox to make 600k bitcoin out of thin air to replace the losses, 'neutral' right?
< sipa>
sdfkjs23: bitcoin core implements bitcoin's consensus rules... we need to make a judgement about what those rules are, as they can change and are not under our control
< gmaxwell>
luke-jr: I think you're pusing the same kind of irresponsiblity as classic did, just this time it happens to be in favor of changes I want. But I still reject it just the same, the purpose of the system is to come to consensus. Intentionally splitting it is in no ones interest except that of opponents to bitcoin. If you had an order of magnitude more support than I've seen (and perhaps I've mi
< sipa>
sdfkjs23: it's open source, anyone can repackage the software in any way they like, and i encourage everyone to do so (as long as they don't misrepresent the choices made)... but Bitcoin Core as a project has established some practices, and those include not accepting consensus rule changes without broad support and weighing the risks - it seems most people in this room now believe that bar isn't
< jonasschnelli>
gmaxwell: hmm... bitcoin.m4 should prefere qt5 though... strange
< wumpus>
(last time I tried tray icon support on ubuntu 16.04, with self-compiled bitcoin-qt on qt5 it seemed to work fine for me, btw, maybe they've fixed it, at least on some versions... or it's somehow dependent on a combination of circumstances)
< wumpus>
there's an issue for qt4 eol, but apparently some people are still relying on it, so if they want to spend work on supporting it it's 100% fine by me, just don't expect me to: https://github.com/bitcoin/bitcoin/issues/8263