2021-10-18

<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23300: test: Implicitly sync after generate*, unless opted out (master...2110-testSyncImp) https://github.com/bitcoin/bitcoin/pull/23300
<bitcoin-git> [bitcoin] laanwj deleted 0 commit to 0.17: https://github.com/bitcoin/bitcoin/compare/2f4f2d382bd7...000000000000
<bitcoin-git> [bitcoin] laanwj pushed tag v0.17-final: https://github.com/bitcoin/bitcoin/compare/v0.17-final
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23207: test: Delete generate* calls from TestNode (master...2110-testDelGen) https://github.com/bitcoin/bitcoin/pull/23207
<bitcoin-git> bitcoin/master fac62e6 MarcoFalke: test: Delete generate* calls from TestNode
<bitcoin-git> bitcoin/master fac7f61 MarcoFalke: test: Use generate* node RPC, not wallet RPC
<bitcoin-git> bitcoin/master faac1cd MarcoFalke: test: Use generate* from TestFramework, not TestNode
<bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/ef596923a86e...2e82af46e237
<bitcoin-git> [bitcoin] laanwj pushed tag v0.16-final: https://github.com/bitcoin/bitcoin/compare/v0.16-final
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23299: Add missing gettimeofday to syscall sandbox (master...2110-timeSys) https://github.com/bitcoin/bitcoin/pull/23299
<bitcoin-git> [bitcoin] fanquake merged pull request #23080: test: check abandoned tx in listsinceblock (master...2021-09-improv-test-listsinceblock) https://github.com/bitcoin/bitcoin/pull/23080
<bitcoin-git> bitcoin/master bda620a brunoerg: test: check abandoned tx in listsinceblock
<bitcoin-git> bitcoin/master ef59692 fanquake: Merge bitcoin/bitcoin#23080: test: check abandoned tx in listsinceblock
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3bf40d06a22e...ef596923a86e

2021-10-17

<luke-jr> speaking of which, someone was complaining about C++17 in #bitcoin earlier
<Davidbak> oh. hmm. maybe it should be revved up to C++17 (does Bitcoin Core accept/require c++17?) and constexpr'd all the way?
<gribble> https://github.com/bitcoin/bitcoin/issues/23050 | log: change an incorrect fee to fee rate, and vice-versa by jonatack · Pull Request #23050 · bitcoin/bitcoin · GitHub
<prayank> Organizing a dev meetup because that will help me and everyone involved achive their goals. Mine is to improve Bitcoin doesn't matter if it affects my own life.
<prayank> There is no "rage quit" thing in this, just that I don't want to become another r/bitcoin moon kid with some C++ knowledge. I have my own identity and thoughts.

2021-10-16

<prayank> He has been contributing to this repository which is used by 98% Bitcoin nodes for years. Still looking for proper funding. But always helped me and others with noob questions on IRC.
<bitcoin-git> [bitcoin] stratospher opened pull request #23294: refactor: remove redundant inclusion of header files in the fuzz tests (master...fuzz-remove-redundant-headers) https://github.com/bitcoin/bitcoin/pull/23294
<bitcoin-git> [bitcoin] kennanmell opened pull request #23293: consensus: Add comment to COIN constant. (master...master) https://github.com/bitcoin/bitcoin/pull/23293
<Guest81> The backup wallet of bitcoin purchased in 2009 is still there. If the transaction password is forgotten, can it be retrieved?
<Guest81> The backup wallet of bitcoin purchased in 2009 is still there. If the transaction password is forgotten, can it be retrieved?
<gribble> https://github.com/bitcoin/bitcoin/issues/23193 | DNS seed node lookup is ambiguous in some (rare) scenarios · Issue #23193 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] fanquake merged pull request #23268: p2p: Use absolute FQDN for DNS seed domains (master...dns-seed-fqdn) https://github.com/bitcoin/bitcoin/pull/23268
<bitcoin-git> bitcoin/master feedb9c fanquake: Merge bitcoin/bitcoin#23268: p2p: Use absolute FQDN for DNS seed domains
<bitcoin-git> bitcoin/master ca2c313 Prayank: Use absolute FQDN for DNS seed domains
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/02ccf1086ea0...feedb9c84e72

2021-10-15

<bitcoin-git> [bitcoin] jamesob opened pull request #23289: test: add stress tests for initialization (master...2021-10-stress-test-init) https://github.com/bitcoin/bitcoin/pull/23289
<Davidbak> i know nothing more than what it says in the docs at https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#sanitizers which suggests they're normally off.
<yanmaani> I mean I suppose there must be something wrong, if it's not a known issue and bitcoin builds normally for everyone else.
<yanmaani> from a fresh install, I can't build bitcoin core. I get the error:
<yanmaani> Is there a way to totally clean out the bitcoin repository, more than doing make clean? mk clean still leaves some stuff, like ./configure
<bitcoin-git> [bitcoin] achow101 opened pull request #23288: tests: remove usage of LegacyScriptPubKeyMan from some wallet tests (master...rm-testWallet-tests) https://github.com/bitcoin/bitcoin/pull/23288
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23220: ci: Reduce Windows memory for faster scheduling (master...211007-mem1) https://github.com/bitcoin/bitcoin/pull/23220
<bitcoin-git> bitcoin/master 146831f MarcoFalke: ci: Reduce Windows memory for faster scheduling
<bitcoin-git> bitcoin/master 02ccf10 MarcoFalke: Merge bitcoin/bitcoin#23220: ci: Reduce Windows memory for faster scheduli...
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e504e9a8ed50...02ccf1086ea0
<andytoshi> OTOH this originates in https://github.com/bitcoin/bitcoin/pull/8149/commits/2b1f6f9ccf36f1e0a2c9d99154e1642f796d7c2b where it looks like sipa was deliberately converting sigop counts from unsigned int to int64_ts
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23286: ci, refactor: Disable binaries for Android task explicitly (master...211015-android) https://github.com/bitcoin/bitcoin/pull/23286
<bitcoin-git> bitcoin/master e504e9a MarcoFalke: Merge bitcoin/bitcoin#23286: ci, refactor: Disable binaries for Android ta...
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4dbba3bac70f...e504e9a8ed50
<bitcoin-git> bitcoin/master 67bb6b5 Hennadii Stepanov: ci, refactor: Disable binaries for Android task explicitly
<andytoshi> in this line https://github.com/bitcoin/bitcoin/blob/master/src/consensus/tx_verify.cpp#L164 we are add-assigning a size_t to an int64_t, which ubsan flags as an integer sign change
<gribble> https://github.com/bitcoin/bitcoin/issues/23268 | p2p: Use absolute FQDN for DNS seed domains by prayank23 · Pull Request #23268 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] theStack opened pull request #23287: test: get and decode tx with a single `gettransaction` RPC call (master...202110-test-fetch_and_decode_tx_with_single_RPC_call) https://github.com/bitcoin/bitcoin/pull/23287
<bitcoin-git> [bitcoin] hebasto opened pull request #23286: ci, refactor: Disable binaries for Android task explicitly (master...211015-android) https://github.com/bitcoin/bitcoin/pull/23286
<bitcoin-git> [bitcoin] laanwj merged pull request #22863: policy: document dust threshold for Taproot outputs (master...dust_threshold_doc) https://github.com/bitcoin/bitcoin/pull/22863
<bitcoin-git> bitcoin/master 4dbba3b W. J. van der Laan: Merge bitcoin/bitcoin#22863: policy: document dust threshold for Taproot o...
<bitcoin-git> bitcoin/master d873db7 Antoine Poinsot: policy: document we intentionally don't lower the dust threshold for Tapro...
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ce19f4fd37c8...4dbba3bac70f
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23284: doc: update release notes for 22539 (master...22539_releasenotes_update) https://github.com/bitcoin/bitcoin/pull/23284
<bitcoin-git> bitcoin/master ce19f4f MarcoFalke: Merge bitcoin/bitcoin#23284: doc: update release notes for 22539
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1884ce2f4c2c...ce19f4fd37c8
<bitcoin-git> bitcoin/master 5307351 Antoine Poinsot: doc: update release notes for 22539
<bitcoin-git> [bitcoin] darosior opened pull request #23284: doc: update release notes for 22539 (master...22539_releasenotes_update) https://github.com/bitcoin/bitcoin/pull/23284
<bitcoin-git> [bitcoin] laanwj merged pull request #22937: refactor: Forbid calling unsafe fs::path(std::string) constructor and fs::path::string() method (master...pr/u8path) https://github.com/bitcoin/bitcoin/pull/22937
<bitcoin-git> bitcoin/master 1884ce2 W. J. van der Laan: Merge bitcoin/bitcoin#22937: refactor: Forbid calling unsafe fs::path(std:...
<bitcoin-git> bitcoin/master 6544ea5 Russell Yanofsky: refactor: Block unsafe fs::path std::string conversion calls
<bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/6419bdfeb130...1884ce2f4c2c
<bitcoin-git> bitcoin/master b39a477 Russell Yanofsky: refactor: Add fs::PathToString, fs::PathFromString, u8string, u8path funct...
<Kiminuo> Hi, what do the hashes here https://github.com/bitcoin/bitcoin/pull/22937#issuecomment-943439492 actually mean? Is there like a one sentence explanation of that?
<gribble> https://github.com/bitcoin/bitcoin/issues/22763 | fuzz: execute each file in dir without fuzz engine by prakash1512 · Pull Request #22763 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/21496 | fuzz: execute each file in dir without fuzz engine by AnthonyRonning · Pull Request #21496 · bitcoin/bitcoin · GitHub
<Davidbak> in `randomenv.cpp` a `memory_cleanse` is done (https://github.com/bitcoin/bitcoin/blame/master/src/randomenv.cpp#L92) for a vector full of Windows performance data. Why? (It doesn't seem security related to me, so I'm wondering about the philosophy. Note that at line 87 just above the vector is resized without cleansing the soon-to-be-freed data.)
<bitcoin-git> [bitcoin] theuni opened pull request #23282: build: remove build stubs for external leveldb (master...no_external_leveldb) https://github.com/bitcoin/bitcoin/pull/23282
<bitcoin-git> [bitcoin] theStack opened pull request #23281: test: check that bumpfee RPC fails for txs with descendants in mempool (master...202110-test-bumpfee_test_descendant_in_mempool) https://github.com/bitcoin/bitcoin/pull/23281

2021-10-14

<shiza> We should just report the problem to the packager, that's all. Whenever Bitcoin is important, they'll assign it to a packager handling less packages, and chance for sloppy upgrades will be smaller.
<luke-jr> if LevelDB has a bug, that bug must NOT be fixed for Bitcoin.
<luke-jr> shiza: LevelDB is consensus-critical code for Bitcoin. If it's being maintained without care for consensus, then it's not safe.
<luke-jr> if they did, ordinary leveldb version bumps would not affect their bitcoin packages
<luke-jr> Talkless: we've told distros time and time again, they can't just treat Bitcoin consensus deps like normal deps :/
<bitcoin-git> [bitcoin] dongcarl opened pull request #23280: init: Coalesce Chainstate loading sequence between {,non-}unittest codepaths (master...2021-09-kernel-lib-v3) https://github.com/bitcoin/bitcoin/pull/23280
<bitcoin-git> [bitcoin] laanwj merged pull request #23093: Add ability to flush keypool and always flush when upgrading non-HD to HD (master...202109_keypoolrefill) https://github.com/bitcoin/bitcoin/pull/23093
<bitcoin-git> bitcoin/master 6f6f7bb Samuel Dobson: Make legacy wallet upgrades from non-HD to HD always flush the keypool
<bitcoin-git> bitcoin/master 2434b10 Samuel Dobson: Fix outdated keypool size default
<bitcoin-git> bitcoin/master 22cc797 Samuel Dobson: Add newkeypool RPC to flush the keypool
<bitcoin-git> [bitcoin] laanwj pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/a845f1ccc66c...6419bdfeb130
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23275: [22.x] Add historical & clean out 22.0 rel notess (22.x...clean_out_rel_notess) https://github.com/bitcoin/bitcoin/pull/23275
<bitcoin-git> bitcoin/22.x dff2261 fanquake: doc: clean out release-notes.md
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to 22.x: https://github.com/bitcoin/bitcoin/compare/a0988140b714...12b315484d1a
<bitcoin-git> bitcoin/22.x 12b3154 MarcoFalke: Merge bitcoin/bitcoin#23275: [22.x] Add historical & clean out 22.0 rel no...
<bitcoin-git> bitcoin/22.x 405f581 W. J. van der Laan: doc: Add historical release notes for 22.0
<bitcoin-git> [bitcoin] fanquake merged pull request #23269: build: remove redundant warning flags (master...further_flag_cleanup) https://github.com/bitcoin/bitcoin/pull/23269
<bitcoin-git> bitcoin/master 12712fa fanquake: build: remove -Wsign-compare
<bitcoin-git> bitcoin/master 0375906 fanquake: build: use loop-analysis over range-loop-analysis
<bitcoin-git> bitcoin/master 5239af0 fanquake: build: remove -Wswitch
<bitcoin-git> [bitcoin] fanquake pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/5a044daea423...a845f1ccc66c
<bitcoin-git> [bitcoin] Empact closed pull request #23270: Bump minimum python version to 3.7 (master...2021-10-python-3.7) https://github.com/bitcoin/bitcoin/pull/23270
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23242: qt: Prefix makefile variables with QT_ (master...2021-10-qt-makefile) https://github.com/bitcoin/bitcoin/pull/23242
<bitcoin-git> bitcoin/master 5a044da MarcoFalke: Merge bitcoin/bitcoin#23242: qt: Prefix makefile variables with QT_
<bitcoin-git> bitcoin/master eb04bad João Barbosa: scripted-diff: Prefix makefile variables with QT_
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ec4e43c21c78...5a044daea423
<bitcoin-git> [bitcoin] prayank23 reopened pull request #23268: p2p: Use absolute FQDN for DNS seed domains (master...dns-seed-fqdn) https://github.com/bitcoin/bitcoin/pull/23268
<bitcoin-git> [bitcoin] prayank23 closed pull request #23268: p2p: Use absolute FQDN for DNS seed domains (master...dns-seed-fqdn) https://github.com/bitcoin/bitcoin/pull/23268
<theStack> cfields: no it's not preventing me from doing something, i just stumbled upon it in the course of investigating the TODO in PeerManagerImpl::NewPoWValidBlock() (https://github.com/bitcoin/bitcoin/blob/ec4e43c21c78b267915732e917268e81ba94e686/src/net_processing.cpp#L1542)
<bitcoin-git> [bitcoin] meshcollider merged pull request #23235: Reduce unnecessary default logging (master...202110-acceptblockheader-silence) https://github.com/bitcoin/bitcoin/pull/23235
<bitcoin-git> bitcoin/master da94ebc Anthony Towns: validation: move header validation error logging to VALIDATION debug categ...
<bitcoin-git> bitcoin/master 1d7d835 Anthony Towns: validation: include block hash when reporting prev block not found errors
<bitcoin-git> bitcoin/master 31b2b80 Anthony Towns: blockstorage: use debug log category
<bitcoin-git> [bitcoin] meshcollider pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/71a85fbd09b5...ec4e43c21c78
<bitcoin-git> [bitcoin] rooprob opened pull request #23277: Add size check on meta.key_origin.path (master...bugfix/21605-segfault-in-legacyscriptpubkeyman) https://github.com/bitcoin/bitcoin/pull/23277
<bitcoin-git> [bitcoin] fanquake opened pull request #23276: [22.x] Backports for 22.x (22.x...initial_backports_22_1) https://github.com/bitcoin/bitcoin/pull/23276
<bitcoin-git> [bitcoin] fanquake opened pull request #23275: [22.x] Add historical & clean out 22.0 rel notess (22.x...clean_out_rel_notess) https://github.com/bitcoin/bitcoin/pull/23275
<gribble> https://github.com/bitcoin/bitcoin/issues/23093 | Add ability to flush keypool and always flush when upgrading non-HD to HD by meshcollider · Pull Request #23093 · bitcoin/bitcoin · GitHub

2021-10-13

<bitcoin-git> [bitcoin] hebasto closed pull request #22764: build: Include qt sources for parsing with extract_strings.py (master...210821-translation) https://github.com/bitcoin/bitcoin/pull/22764
<bitcoin-git> [bitcoin] sipa closed pull request #23272: Update COPYING (master...patch-1) https://github.com/bitcoin/bitcoin/pull/23272
<bitcoin-git> [bitcoin] khan201kp opened pull request #23272: Update COPYING (master...patch-1) https://github.com/bitcoin/bitcoin/pull/23272
<bitcoin-git> [bitcoin] stratospher opened pull request #23271: crypto: Fix K1/K2 use in the comments in ChaCha20-Poly1305 AEAD (master...fix-k1-k2) https://github.com/bitcoin/bitcoin/pull/23271
<bitcoin-git> [gui] laanwj opened pull request #454: qt: Use only Qt translation primitives in GUI code (master...2021-10-qt-use-at-translation) https://github.com/bitcoin-core/gui/pull/454
<bitcoin-git> [bitcoin] laanwj merged pull request #23148: build: Fix guix linker-loader path and add check_ELF_interpreter (master...2021-09-fix-loader-quick) https://github.com/bitcoin/bitcoin/pull/23148
<bitcoin-git> bitcoin/master 71a85fb W. J. van der Laan: Merge bitcoin/bitcoin#23148: build: Fix guix linker-loader path and add ch...
<bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/da13c7b18afc...71a85fbd09b5
<bitcoin-git> bitcoin/master b96adcb Carl Dong: guix: Fix powerpc64(le) dynamic linker name
<bitcoin-git> bitcoin/master 1527b7e Carl Dong: symbol-check: Check requested ELF interpreter
<bitcoin-git> [bitcoin] laanwj merged pull request #22392: scripts: use LIEF for ELF security & symbol checks (master...lief_elf) https://github.com/bitcoin/bitcoin/pull/22392
<bitcoin-git> bitcoin/master 309eac9 fanquake: scripts: use LIEF for ELF checks in symbol-check.py
<bitcoin-git> bitcoin/master 8242ae2 fanquake: scripts: only parse the binary once in symbol-check.py
<bitcoin-git> [bitcoin] laanwj pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/28d5074343d2...da13c7b18afc
<bitcoin-git> bitcoin/master 610a8a8 Carl Dong: test-*-check: Pass in *FLAGS and compile with them
<bitcoin-git> [bitcoin] laanwj merged pull request #23253: bitcoin-tx: Reject non-integral and out of range int strings (master...2110-utilTxSeqId) https://github.com/bitcoin/bitcoin/pull/23253
<bitcoin-git> bitcoin/master fafab8e MarcoFalke: bitcoin-tx: Reject non-integral and out of range sequence ids
<bitcoin-git> bitcoin/master fa6f29d MarcoFalke: bitcoin-tx: Reject non-integral and out of range multisig numbers
<bitcoin-git> bitcoin/master fa53d3d MarcoFalke: test: Check that bitcoin-tx accepts whitespace around sequence id and mult...
<bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/a9f642870849...28d5074343d2
<bitcoin-git> [bitcoin] Empact opened pull request #23270: Bump minimum python version to 3.7 (master...2021-10-python-3.7) https://github.com/bitcoin/bitcoin/pull/23270
<prayank> sipa: Are there any changes required in https://github.com/sipa/bitcoin-seeder/ based on https://github.com/bitcoin/bitcoin/issues/23193 ?
<bitcoin-git> [bitcoin] fanquake opened pull request #23269: build: remove redundant warning flags (master...further_flag_cleanup) https://github.com/bitcoin/bitcoin/pull/23269
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23003: multiprocess: Make interfaces::Chain::isTaprootActive non-const (master...pr/ipc-tapc) https://github.com/bitcoin/bitcoin/pull/23003
<bitcoin-git> bitcoin/master a9f6428 MarcoFalke: Merge bitcoin/bitcoin#23003: multiprocess: Make interfaces::Chain::isTapro...
<bitcoin-git> bitcoin/master 7e88f61 Russell Yanofsky: multiprocess: Make interfaces::Chain::isTaprootActive non-const
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/39872f5ed43d...a9f642870849
<bitcoin-git> [bitcoin] fanquake merged pull request #23149: build: make --enable-werror just -Werror (master...make_enable_werror_full_werror) https://github.com/bitcoin/bitcoin/pull/23149
<bitcoin-git> bitcoin/master 39872f5 fanquake: Merge bitcoin/bitcoin#23149: build: make --enable-werror just -Werror
<bitcoin-git> bitcoin/master 38fd709 fanquake: build: make --enable-werror just -Werror
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/810ce36d54e4...39872f5ed43d
<sipa> the same is true for other cryptographic constructs (e.g. ECDSA signatures contain big-endian serialized numbers, but from bitcoin's perspective, they're just byte arrays)
<sipa> bitcoin historically treated all byte arrays as little-endian numbers
<Davidbak> one more comment: i especially find the endianness issue funny for bitcoin because in addition to the usual on-the-wire format vs. internal representation issues you typically get bitcoin also has - for some unknown historical reason? - the issue of people _visualizing_ addresses/hashes/etc differently than the internal representation - how the heck did _that_ happen?
<Davidbak> Huh. So the mainframe guys wanting to run bitcoin core on big iron might run into incompatibilities, eh?
<sipa> davidbak: well, yes, i'm not lying when i say you and i, on our home desktop systems, on different linux distributions, with different versions of everything, will very realistically succeed in producing bit for bit identical bitcoin core binaries if you run the guix-based build system
<Davidbak> how does the bitcoin build system give you that?
<fanquake> There may be multiple solutions, but Bitcoin Core has had a solution to this problem for ~10 years now, and Guix is a good next step.
<Davidbak> i do get all this - and plenty of people are working on reproducible builds, not just bitcoin - and it still isn't available out-of-the-box without work
<sipa> bitcoin core contributors have contributed patches to various building/system tools to make sure nothing breaks the reproducibility
<Davidbak> well reproducible builds are good for many reasons, bitcoin obviously depends on that for trust (and reliability of the consensus) but over the years there _have_ been other tools developed, that have gained traction in the overall C++ community, that address that well. As a newbie I AM NOT COMING IN AND CRITICIZING or saying "Why aren't you doing thing in this obvious better way, you old fogies!?" - but as a very long
<sipa> for bitcoin core we really want reproducibility, because of the view that maintainers should be trusted the least amount possible

2021-10-12

<sipa> also, this discussion is perhaps more appropriate for #bitcoin-core-builds
<sipa> so it lets bitcoin core's build script (the contrib/guix/guix-build) instantiate an exactly specified build environment, with exact versions of compilers, dependencies, everything
<Davidbak> ah! my use case wasn't _running_ bitcoin core (i've got _that_ set up) but building - a container that had all tools + dependencies would be sweet ...
<sipa> also some discussion on an project-maintained one here: https://github.com/bitcoin-core/packaging/issues/55
<gene> found an unofficial docker repo: https://github.com/amacneil/docker-bitcoin (old and archived)
<Davidbak> speaking of which - is there a container already set up for building bitcoin core? I didn't spot anything like that at github.com/bitcoin or github.com/bitcoin-core
<Davidbak> ok! that's the validation I wanted (because setting up GPG on my system might lead to running down a rathole I'd rather not do at the moment when I'm keen on getting the bitcoin core build running)
<bitcoin-git> [bitcoin] prayank23 opened pull request #23268: p2p: Use absolute FQDN for DNS seed domains (master...dns-seed-fqdn) https://github.com/bitcoin/bitcoin/pull/23268
<bitcoin-git> [bitcoin] brunoerg opened pull request #23267: test: bip125-replaceable in listsinceblock (master...2021-10-test-bip125-listsinceblock) https://github.com/bitcoin/bitcoin/pull/23267
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23213: rest: Return error when header count is not integral (master...2110-restInt) https://github.com/bitcoin/bitcoin/pull/23213
<bitcoin-git> bitcoin/master 810ce36 MarcoFalke: Merge bitcoin/bitcoin#23213: rest: Return error when header count is not i...
<bitcoin-git> bitcoin/master fa8d492 MarcoFalke: rest: Return error when header count is not integral
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8df7eee5e1c8...810ce36d54e4
<Guest99100> michaelfolkson Thanks for the reply. I have noticed the Bitcoin-core-dev channel as well, though I have worked my way from old to new chats (Currently in 2015). Do you have any idea when the core team 'officially' switched from bitcoin-dev ti butcoin-core-dev?
<michaelfolkson> Guest99100: I can't help with your missing logs but I'd recommend looking at the #bitcoin-core-dev log archives too if you haven't already. I suspect a lot of consensus discussions were on that channel as the separation between Core as an implementation and the protocol was potentially less understood/less recognized 5-6 years ago
<Guest99100> http://azure.erisian.com.au/~aj/tmp/irc/, but I've also looked for archives in bitcoinstats by using web archives such as https://web.archive.org/web/20170415065445/http://bitcoinstats.com/irc/bitcoin-dev/logs/2015/07/04 and https://archive.vn. Could anyone help me with this?
<Guest99100> Hi, I'm looking for someone to help me dig up old bitcoin-dev archives. I'm analyzing consensus change events in Bitcoin for a research project, and have realized that there is an important gap in the IRC logs that I'm looking at. The missing samples are mainly 2015-07-03, 2015-07-04 and 2015-07-05. I've gathered chat-logs in this period from
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23132: test: Change background_cs from pointer to reference in validation_chainstate_tests (master...2109-testStarToAmpersand) https://github.com/bitcoin/bitcoin/pull/23132
<bitcoin-git> bitcoin/master fa4d0aa MarcoFalke: test: * -> &
<bitcoin-git> bitcoin/master 8df7eee MarcoFalke: Merge bitcoin/bitcoin#23132: test: Change background_cs from pointer to re...
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fbbbc594ad2f...8df7eee5e1c8
<bitcoin-git> [bitcoin] meshcollider merged pull request #23227: bitcoin-tx: Avoid treating integer overflow as OP_0 (master...2110-ToIntegral) https://github.com/bitcoin/bitcoin/pull/23227
<bitcoin-git> bitcoin/master fa053c0 MarcoFalke: style: Fix whitespace in Parse* functions
<bitcoin-git> bitcoin/master fa03dec MarcoFalke: refactor: Use C++11 range based for loop in ParseScript
<bitcoin-git> bitcoin/master fad55e7 MarcoFalke: doc: Fixup ToIntegral docs
<bitcoin-git> [bitcoin] meshcollider pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/e418a8e675e4...fbbbc594ad2f
<bitcoin-git> [bitcoin] meshcollider opened pull request #23258: doc: Fix outdated comments referring to ::ChainActive() (master...202110_outdated_chainstate_comments) https://github.com/bitcoin/bitcoin/pull/23258
<bitcoin-git> [bitcoin] fanquake merged pull request #23255: util: Add mincore and clone3 to syscall sandbox (master...2110-syscall) https://github.com/bitcoin/bitcoin/pull/23255
<bitcoin-git> bitcoin/master e418a8e fanquake: Merge bitcoin/bitcoin#23255: util: Add mincore and clone3 to syscall sandb...
<bitcoin-git> bitcoin/master fab4073 MarcoFalke: util: Add mincore and clone3 to syscall sandbox
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1790a8ddacae...e418a8e675e4
<BlueMatt> any update on https://github.com/bitcoin/bitcoin/pull/17631 ? Would be nice.
<bitcoin-git> [gui] luke-jr closed pull request #216: Support building without embedded monospace font (master...optional_font) https://github.com/bitcoin-core/gui/pull/216

2021-10-11

<yanmaani> But something like p2pool would be on-topic, because it can be used with bitcoin?
<sipa> anything you want to propose/discuss in the context of bitcoin
<sipa> no, it's specifically not about bitcoin core (which is just an implementation)
<yanmaani> But it's not just patches for Bitcoin Core, right
<sipa> bitcoin development
<yanmaani> What is on-topic for the bitcoin-dev list, exactly?
<sipa> for almost all things relates to Bitcoin Core developmemt, you can think of cryptographic algorithms as black boxes
<sipa> heh, that would be offtopic here; DES isn't used in Bitcoin (and considered way too weak nowadays)
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23255: util: Add mincore and clone3 to syscall sandbox (master...2110-syscall) https://github.com/bitcoin/bitcoin/pull/23255
<meshcollider> I accidentally offended drahtbot https://github.com/bitcoin/bitcoin/pull/16807#issuecomment-939993269
<bitcoin-git> [bitcoin] hieblmi opened pull request #23254: Fix typo and grammar (master...patch-1) https://github.com/bitcoin/bitcoin/pull/23254
<bitcoin-git> [bitcoin] hebasto closed pull request #20544: build: Do not repeat warning names in -Werror=... options (master...201202-werror) https://github.com/bitcoin/bitcoin/pull/20544
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23253: bitcoin-tx: Reject non-integral and out of range sequence ids (master...2110-utilTxSeqId) https://github.com/bitcoin/bitcoin/pull/23253
<jnewbery> gleb7: It's ready for review, but I'm not 100% sure that https://github.com/bitcoin/bitcoin/pull/22910/commits/16cef1ba368302531672ffe81d19bf70e61bd127 doesn't change behaviour in some subtle way. I'd need to do a very careful review of it and possibly add more tests to make sure.
<bitcoin-git> [bitcoin] hebasto closed pull request #23250: test pull request (master...master) https://github.com/bitcoin/bitcoin/pull/23250
<bitcoin-git> [bitcoin] SatoshiBitcoin opened pull request #23250: test pull request (master...master) https://github.com/bitcoin/bitcoin/pull/23250
<bitcoin-git> [bitcoin] dougEfresh opened pull request #23249: util: ParseByteUnits - Parse a string with a suffix unit (master...util-parsebyteunit) https://github.com/bitcoin/bitcoin/pull/23249
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #22794: test: Verify if wallet is compiled in rpc_invalid_address_message.py test (master...split_invalid_address_message_test) https://github.com/bitcoin/bitcoin/pull/22794
<bitcoin-git> bitcoin/master 1790a8d MarcoFalke: Merge bitcoin/bitcoin#22794: test: Verify if wallet is compiled in rpc_inv...
<bitcoin-git> bitcoin/master c2fbdca lsilva01: Add BECH32_INVALID_VERSION test
<bitcoin-git> bitcoin/master b142f79 lsilva01: skip test_getaddressinfo() if wallet is disabled
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5b7210c8745d...1790a8ddacae
<gribble> https://github.com/bitcoin/bitcoin/issues/22910 | [RFC] Encapsulate asmap in NetGroupManager by jnewbery · Pull Request #22910 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] fanquake merged pull request #22409: configure: keep relative paths in debug info (master...debug_keep_relative_path) https://github.com/bitcoin/bitcoin/pull/22409
<bitcoin-git> bitcoin/master 5b7210c fanquake: Merge bitcoin/bitcoin#22409: configure: keep relative paths in debug info
<bitcoin-git> bitcoin/master 0bc666b S3RK: doc: add info for debugging with relative paths
<bitcoin-git> bitcoin/master a8b515c S3RK: configure: keep relative paths in debug info
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/829d3e0e7135...5b7210c8745d
<bitcoin-git> [bitcoin] fanquake merged pull request #23199: refactor: use `{Read,Write}BE32` helpers for BIP32 nChild (de)serialization (master...202110-refactor-use_be32_helpers_for_bip32_nchild) https://github.com/bitcoin/bitcoin/pull/23199
<bitcoin-git> bitcoin/master 829d3e0 fanquake: Merge bitcoin/bitcoin#23199: refactor: use `{Read,Write}BE32` helpers for ...
<bitcoin-git> bitcoin/master 7fc487a Sebastian Falbesoner: refactor: use `{Read,Write}BE32` helpers for BIP32 nChild (de)serialization
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/01129ca37272...829d3e0e7135
<bitcoin-git> [bitcoin] fanquake merged pull request #23214: Replace stoul with ToIntegral in dbwrapper (master...2110-dbwInt) https://github.com/bitcoin/bitcoin/pull/23214
<bitcoin-git> bitcoin/master fa165e9 MarcoFalke: Replace stoul with ToIntegral in dbwrapper
<bitcoin-git> bitcoin/master 01129ca fanquake: Merge bitcoin/bitcoin#23214: Replace stoul with ToIntegral in dbwrapper
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d1e63aa45469...01129ca37272
<bitcoin-git> [bitcoin] fanquake merged pull request #23168: build: no-longer fail default configure if BDB isn't available (master...dont_fail_no_bdb_default_configure) https://github.com/bitcoin/bitcoin/pull/23168
<bitcoin-git> bitcoin/master d1e63aa fanquake: Merge bitcoin/bitcoin#23168: build: no-longer fail default configure if BD...
<bitcoin-git> bitcoin/master 747cd17 fanquake: build: no-longer fail default configure if BDB isn't available
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/15587b4f1d21...d1e63aa45469

2021-10-10

<sipa> davidbak: in any case, questions about setting up a dev env tend to also be welcome in #bitcoin-core-pr-reviews i've noticed
<Davidbak> no, i'm new to bitcoin-core but not to development, but for you: that claim will remain to be seen until I produce
<hebasto> davidbak: #bitcoin-core-pr-reviews
<sipa> davidbak: you're probably better off asking people who more recently started participating; both luke-jr and i have been around for a while, like jonatack's guide (https://jonatack.github.io/articles/how-to-contribute-pull-requests-to-bitcoin-core) and amiti's (https://medium.com/@amitiu/onboarding-to-bitcoin-core-7c1a83b20365)
<Davidbak> ok. luke-jr - is "good first issues" still considered a good way to onboard to bitcoin-core development? And with or without the "PR Club" for getting tips?
<Davidbak> anyway, that was created 2020-04-29, and apparently two people worked on PRs - https://github.com/bitcoin/bitcoin/pull/19117 and https://github.com/bitcoin/bitcoin/pull/18827 - rather quickly after that (also April/May 2020) - both of which went nowhere.
<gribble> https://github.com/bitcoin/bitcoin/issues/18222 | Add `blockfilterindex = p2wpkh` · Issue #18222 · bitcoin/bitcoin · GitHub
<Davidbak> I'm looking around after reading the "how to get involved" information - which points to "good first issue" issues. And one of the first ones there is #18222 - https://github.com/bitcoin/bitcoin/issues/18822
<gribble> https://github.com/bitcoin/bitcoin/issues/20664 | Add scanblocks RPC call by jonasschnelli · Pull Request #20664 · bitcoin/bitcoin · GitHub
<stick> I see there is CJDNS being added to bitcoin-core

2021-10-09

<bitcoin-git> [gui] promag closed pull request #450: Prefix makefile variables with QT_ (master...2021-10-qt-makefile) https://github.com/bitcoin-core/gui/pull/450
<bitcoin-git> [bitcoin] promag opened pull request #23242: qt: Prefix makefile variables with QT_ (master...2021-10-qt-makefile) https://github.com/bitcoin/bitcoin/pull/23242
<bitcoin-git> [gui] promag opened pull request #450: Prefix makefile variables with QT_ (master...2021-10-qt-makefile) https://github.com/bitcoin-core/gui/pull/450
<bitcoin-git> bitcoin/master 15587b4 Hennadii Stepanov: Merge bitcoin-core/gui#448: Add helper to load font
<bitcoin-git> bitcoin/master d54ec27 João Barbosa: qt: Add helper to load font
<bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/927586990eb9...15587b4f1d21
<bitcoin-git> [gui] hebasto merged pull request #448: Add helper to load font (master...2021-10-font-helper) https://github.com/bitcoin-core/gui/pull/448
<Kiminuo> prayank: I'm quite happy with the PR as is. Jeremy proposed https://github.com/bitcoin/bitcoin/pull/21422#issuecomment-819566377 but I'm not entirely sure if it is necessary to change it that way.
<gribble> https://github.com/bitcoin/bitcoin/issues/21422 | Add feerate histogram to getmempoolinfo by kiminuo · Pull Request #21422 · bitcoin/bitcoin · GitHub
<Kiminuo> Ha, merged master with https://github.com/bitcoin/bitcoin/pull/22937 and it works
<prayank> I have tried writing few PowerShell scripts for Bitcoin Core but never used utf 8 in them
<Kiminuo> Anyway, I'm recompiling the PR again and trying to find out why https://github.com/bitcoin/bitcoin/pull/22937 fails for me and it works for you
<bitcoin-git> [bitcoin] ajtowns opened pull request #23235: Reduce unnecessary default logging (master...202110-acceptblockheader-silence) https://github.com/bitcoin/bitcoin/pull/23235

2021-10-08

<gribble> https://github.com/bitcoin/bitcoin/issues/23201 | wallet: Allow users to specify input weights when funding a transaction by achow101 · Pull Request #23201 · bitcoin/bitcoin · GitHub
<achow101> #bitcoin-core-dev Wallet Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik petertodd
<Sp79> Hello. Can someone help me with some info? I want to know how was bitcoin.pdf whitepaper was embedded in the bitcoin blockchain
<gribble> https://github.com/bitcoin/bitcoin/issues/23202 | wallet: allow psbtbumpfee to work with txs with external inputs by achow101 · Pull Request #23202 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/23201 | wallet: Allow users to specify input weights when funding a transaction by achow101 · Pull Request #23201 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23227: bitcoin-tx: Avoid treating overflow as OP_0 (master...2110-ToIntegral) https://github.com/bitcoin/bitcoin/pull/23227
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #23216: clang-format: Set BraceWrapping:AfterControlStatement:MultiLine (master...2110-srcFormat) https://github.com/bitcoin/bitcoin/pull/23216
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23185: test: Add ParseMoney and ParseScript tests (master...2110-ToIntegral) https://github.com/bitcoin/bitcoin/pull/23185
<bitcoin-git> bitcoin/master 9275869 MarcoFalke: Merge bitcoin/bitcoin#23185: test: Add ParseMoney and ParseScript tests
<bitcoin-git> bitcoin/master fa1477e MarcoFalke: test: Add ParseMoney and ParseScript tests
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/97e2435ac43f...927586990eb9
<bitcoin-git> [bitcoin] dougEfresh closed pull request #23224: [RFC] util: Add suffix byte unit parser for ArgsManager (master...add-args-byte-units) https://github.com/bitcoin/bitcoin/pull/23224
<meshcollider> Guest8477: for most help, #bitcoin would be a better channel to ask in
<gribble> https://github.com/bitcoin/bitcoin/issues/23056 | configure script failure · Issue #23056 · bitcoin/bitcoin · GitHub
<fanquake> The only users who get blocked from bitcoin/bitcoin are the ones posting outright nonsense / spam.
<bitcoin-git> [bitcoin] fanquake merged pull request #23053: [fuzz] Use public methods in addrman fuzz tests (master...2021-09-addrman-fuzzer-public-methods2) https://github.com/bitcoin/bitcoin/pull/23053
<bitcoin-git> bitcoin/master 90ad8ad John Newbery: [fuzz] Make RandAddr() a free function in fuzz/addrman.cpp
<bitcoin-git> [bitcoin] fanquake pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/99e53967c85c...97e2435ac43f
<bitcoin-git> bitcoin/master 491975c John Newbery: [fuzz] Pass FuzzedDataProvider& into Fill() in addrman fuzz tests
<bitcoin-git> bitcoin/master 56303e3 John Newbery: [fuzz] Create a FastRandomContext in addrman fuzz tests
<bitcoin-git> [bitcoin] fanquake merged pull request #23188: wallet: fund transaction external input cleanups (master...fundtx-external-inputs_cleanups) https://github.com/bitcoin/bitcoin/pull/23188
<bitcoin-git> bitcoin/master 99e5396 fanquake: Merge bitcoin/bitcoin#23188: wallet: fund transaction external input clean...
<bitcoin-git> bitcoin/master 4356878 Gregory Sanders: External input fund support cleanups
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/991753e4d50e...99e53967c85c
<bitcoin-git> [bitcoin] theuni opened pull request #23226: c++20: Opt-in to modeling view and borrowed_range for Span (master...borrowed-span) https://github.com/bitcoin/bitcoin/pull/23226

2021-10-07

<jeremyrubin> counterpoint, not getting segwit would have been pretty bad for bitcoin overall, no? should we let 'bullies' who don't want bitcoin to progress to roadblock the rest of the network? if we can't get an important upgrade in the face of bad actors, that sounds bad for bitcoin...
<jeremyrubin> many changes to bitcoin core affect the consensus code
<jeremyrubin> i think that leads to the way that we do soft forks for bitcoin being no more unsafe than other changes we make
<jeremyrubin> tbh soft forks aren't particularly more or less dangerous than other changes we make to bitcoin
<michaelfolkson> lightlike: I'm not sure whether the only way you get peer review is by marking it as "high priority for review" and a "blocker" on Bitcoin Core
<bitcoin-git> [bitcoin] katesalazar opened pull request #23225: Reject float at satoshi_round (master...20211006) https://github.com/bitcoin/bitcoin/pull/23225
<gribble> https://github.com/bitcoin/bitcoin/issues/23174 | validation: have LoadBlockIndex account for snapshot use by jamesob · Pull Request #23174 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] dougEfresh opened pull request #23224: [RFC] util: Add suffix byte unit parser for ArgsManager (master...add-args-byte-units) https://github.com/bitcoin/bitcoin/pull/23224
<gribble> https://github.com/bitcoin/bitcoin/issues/21702 | Implement BIP-119 Validation (CheckTemplateVerify) by JeremyRubin · Pull Request #21702 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/21943 | Dedup and RAII-fy the creation of a copy of CConnman::vNodes by vasild · Pull Request #21943 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/22702 | Add allocator for node based containers by martinus · Pull Request #22702 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/21702 | Implement BIP-119 Validation (CheckTemplateVerify) by JeremyRubin · Pull Request #21702 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/22950 | [p2p] Pimpl AddrMan to abstract implementation details by amitiuttarwar · Pull Request #22950 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/22539 | Re-include RBF replacement txs in fee estimation by darosior · Pull Request #22539 · bitcoin/bitcoin · GitHub
<laanwj> https://github.com/bitcoin/bitcoin/projects/8 9 blockers, 2 chasing concept ACK
<laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos
<bitcoin-git> [bitcoin] jonatack opened pull request #23223: Add NoLockLoggingTestingSetup to test utilities, use in checkqueue_tests (master...alleviate-checkqueue-tests-contention-logging) https://github.com/bitcoin/bitcoin/pull/23223
<bitcoin-git> [bitcoin] laanwj merged pull request #23118: test: refactor: introduce `script_util` helper for creating P2PK scripts (master...202109-test-add_helper_for_creating_p2pk_scripts) https://github.com/bitcoin/bitcoin/pull/23118
<bitcoin-git> bitcoin/master 991753e W. J. van der Laan: Merge bitcoin/bitcoin#23118: test: refactor: introduce `script_util` helpe...
<bitcoin-git> bitcoin/master 429b493 Sebastian Falbesoner: test: introduce script_util helper for creating P2PK scripts