< wumpus>
there's no reason bitcoind couldn't have a dynamic settings mechanism, with some configuration that automatically gets re-loaded on next run, for example the bitcoin-rw.conf idea
< wumpus>
e.g. nearly all of these are nonsense https://www.transifex.com/bitcoin/bitcoin/translate/#de/$/104570304?user=pehotinec, sometimes he copies slightly similar messages to make it look ok, sometimes he just copies the English message, in any cast this seems deliberate
< jnewbery>
but specifying the wrong -dbcache on the command line for bitcoin-cli cannot lead to loss of funds
< jnewbery>
>we don't complain in bitcoin-cli that -dbcache is specfied
< gribble>
https://github.com/bitcoin/bitcoin/issues/10267 | New -includeconf argument for including external configuration files by kallewoof · Pull Request #10267 · bitcoin/bitcoin · GitHub
< sipa>
but we don't complain in bitcoin-cli that -dbcache is specfied, right?
< jnewbery>
I think Russ is thinking about the case where someone starts bitcoind with -wallet=mybusinesswallet.dat in the conf file, then calls `bitcoin-cli -wallet=mypersonalwallet.dat send ...` and is confused that money is sent from their business wallet even though they specified a different wallet
< ryanofsky>
yes that's why i said "on bitcoin-cli command line"
< ryanofsky>
maybe also consider making it an error for user to specify -wallet on bitcoin-cli command line if it will be ignored
< wumpus>
why owuld that be strange? bitcoin-cli has lots of arguments that are not used by bitcoind
< jnewbery>
having a `useargument` argument that is used by bitcoin-cli but is not used by bitcoind seems strange to me
< wumpus>
if bitcoin-cli would not read the config file at all, or a different config file, I'd be ok with it
< ryanofsky>
wumpus, yes, the tradeoff for having bitcoin-cli accept a wallet argument is having to ignore wallet values from the config file
< wumpus>
e.g. you might want to set a default wallet for bitcoin-cli to use in the configuration file, you can't use -wallet for that
< wumpus>
I don't think re-using -wallet for bitcoin-cli is a good idea
< sipa>
jonasschnelli: but it's not so different from how -rpcport for bitcoind means "the port to listen on" nd for bitcoin-cli means "the port to connect to"
< jnewbery>
but how -usewallet is interpreted is differentiated as well - acted on by bitcoin-cli, ignored by bitcoind, and you haven't decided on whether it should be ignored or not by bitcoin-qt
< ryanofsky>
that is a drawback. if you want bitcoin-cli to be able to use wallet filename from a config file, you have to call the option something other than -wallet
< jonasschnelli>
I just can't follow why you would want to add code to differenciate -wallet in bitcoin conf to -wallet passed into bitcoin-cli
< ryanofsky>
users should just be shown an error if they are expecting bitcoin-cli to send an single rpc command to multiple wallets
< bitcoin-git>
[bitcoin] laanwj closed pull request #10857: [RPC] Add a deprecation warning to getinfo's output (master...deprecate-getinfo) https://github.com/bitcoin/bitcoin/pull/10857
< bitcoin-git>
bitcoin/master d445a2c Wladimir J. van der Laan: Merge #10857: [RPC] Add a deprecation warning to getinfo's output...
< bitcoin-git>
bitcoin/master 1c9b818 Andrew Chow: getinfo deprecation warning
< jonasschnelli>
ryanofsky: a) because its to different things (and users should learn that from the beginning), b) -usewallet could be reused for bitcoin-Qt (until there is a GUI way to select the wallet)
< bitcoin-git>
[bitcoin] achow101 opened pull request #10874: [RPC] getblockchaininfo: Loop through the bip9 soft fork deployments instead of hard coding (master...getblockchaininfo-bip9-loop) https://github.com/bitcoin/bitcoin/pull/10874
2017-07-18
< bitcoin-git>
[bitcoin] eklitzke opened pull request #10873: Use a condition variable for shutdown notifications (master...shutdown_notify) https://github.com/bitcoin/bitcoin/pull/10873
< bitcoin-git>
[bitcoin] eklitzke opened pull request #10872: Docs: Syntax highlight shell commands in the building notes (master...hilite) https://github.com/bitcoin/bitcoin/pull/10872
< bitcoin-git>
[bitcoin] achow101 opened pull request #10871: Handle getinfo in bitcoin-cli w/ -getinfo (revival of #8843) (master...cli-getinfo) https://github.com/bitcoin/bitcoin/pull/10871
< bitcoin-git>
[bitcoin] jonasschnelli opened pull request #10870: [Qt] Use wallet 0 in rpc console if running with multiple wallets (master...2017/07/qt_mw) https://github.com/bitcoin/bitcoin/pull/10870
< ryanofsky>
url encoding was suggested when there were still wallet ids. if you want to check for CHARS_ALPHA_NUM in bitcoin-cli instead of percent encoding, that seems fine, though a little more fragile (because maybe we will allow another class of characters in bitcoind and bitcoin-cli will break)
< bitcoin-git>
[bitcoin] jonasschnelli opened pull request #10867: Allow only a single -usewallet argument (master...2017/07/multiwallet_bitcoincli) https://github.com/bitcoin/bitcoin/pull/10867
< bitcoin-git>
[bitcoin] laanwj closed pull request #10784: Do not allow users to get keys from keypool without reserving them (master...2017-07-keep-change) https://github.com/bitcoin/bitcoin/pull/10784
< bitcoin-git>
bitcoin/master 9e8d6a3 Wladimir J. van der Laan: Merge #10784: Do not allow users to get keys from keypool without reserving them...
< bitcoin-git>
bitcoin/master cf82a9e Matt Corallo: Do not allow users to get keys from keypool without reserving them...
< gribble>
https://github.com/bitcoin/bitcoin/issues/10784 | Do not allow users to get keys from keypool without reserving them by TheBlueMatt · Pull Request #10784 · bitcoin/bitcoin · GitHub
< bitcoin-git>
bitcoin/master dd2185c Jonas Schnelli: Register wallet endpoint
< gribble>
https://github.com/bitcoin/bitcoin/issues/10784 | Do not allow users to get keys from keypool without reserving them by TheBlueMatt · Pull Request #10784 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] practicalswift opened pull request #10866: Add mutex requirement for AddToCompactExtraTransactions(…) (master...lock-requirement-for-AddToCompactExtraTransactions) https://github.com/bitcoin/bitcoin/pull/10866
< bitcoin-git>
[bitcoin] corebob opened pull request #10865: Move CloseSocket out of SetSocketNonBlocking in netbase.cpp (master...20170718-refactor-1) https://github.com/bitcoin/bitcoin/pull/10865
< bitcoin-git>
[bitcoin] corebob closed pull request #10863: Fix leaking a socket handle if call to SetSocketNonBlocking failed (master...20170718-fix-leak-1) https://github.com/bitcoin/bitcoin/pull/10863
< bitcoin-git>
[bitcoin] practicalswift opened pull request #10864: Avoid redundant redeclaration of GetWarnings(const string&) (master...GetWarnings-in-warnings.h) https://github.com/bitcoin/bitcoin/pull/10864
< bitcoin-git>
[bitcoin] corebob opened pull request #10863: Fix leaking a socket handle if call to SetSocketNonBlocking failed (master...20170718-fix-leak-1) https://github.com/bitcoin/bitcoin/pull/10863
< Guest38971>
Understood my question was hypethical. My main concern is if I am running my node how can I test BIP148 suppost. I found a link that allows me to download bitcoin core with BIP148 support, but I did not know if this was trustworthy. Thank you
< sipa>
Bitcoin Core at this point does not support BIP148
< Guest38971>
lets say I wanted my node to support bip148. What do I need to configure in order to allow this? I am currently running bitcoin core 0.14.2 am I just ammending a line of code into the config file? I just need a reference if possible or is it advised to just wait for a release from bitcoin core?. I do not know if this is the proper channel for this so I apologize in advance. Thank you very much for the help.
< bitcoin-git>
[bitcoin] jtimon opened pull request #10859: RPC: gettxout: Slightly improve doc and tests (master...b15-rpc-gettxout-mempool) https://github.com/bitcoin/bitcoin/pull/10859
< bitcoin-git>
[bitcoin] achow101 opened pull request #10858: [RPC] Add "errors" field to getblockchaininfo and unify "errors" field in get*info RPCs (master...getblockchaininfo-errors) https://github.com/bitcoin/bitcoin/pull/10858
< bitcoin-git>
[bitcoin] achow101 opened pull request #10857: [RPC] Add a deprecation warning to getinfo's output (master...deprecate-getinfo) https://github.com/bitcoin/bitcoin/pull/10857
< jnewbery>
sipa: I can think of a couple of good solutions to the old encrypted wallet at start: 1. have a bitcoin-wallet util that can topup the keypool offline. 2. have a `loadwallet` RPC that can decrypt on load
< gribble>
https://github.com/bitcoin/bitcoin/issues/10672 | Avoid division by zero in the case of a corrupt estimates file by practicalswift · Pull Request #10672 · bitcoin/bitcoin · GitHub
< ryanofsky>
i think changes to bitcoin-cli are simple but ugly
< jnewbery>
with (2), the bitcoin-cli caller needs to change to include a `-usewallet` argument. With (1) the entire invocation needs to change
< jnewbery>
I think (2) is better in that respect. We need to modify bitcoin-cli, but we have those changes already coded. With (1), every script that calls wallet methods using bitcoin-cli needs to be changed because positional arguments are no longer supported
< ryanofsky>
yes named arguments require no changes to bitcoin-cli
< jnewbery>
> countervailing tradeoffs like having to modify bitcoin-cli
< ryanofsky>
your second reason is reason sipa & gmaxwell like approaches (2)&(3) over approach (1), in that respect there is no distiniction between (2)/(3), and countervailing tradeoffs like having to modify bitcoin-cli and other things i mentioned above
< gribble>
https://github.com/bitcoin/bitcoin/issues/10579 | [RPC] Split signrawtransaction into wallet and non-wallet RPC command by achow101 · Pull Request #10579 · bitcoin/bitcoin · GitHub
< ryanofsky>
also just to list other practical advantages i see in (1) over (2/3). Requires no changes to bitcoin-cli. Is properly documented, easy to understand, just a param. Encourages named arguments. Allows checking wallet name for safety even with multiprocess.
< ryanofsky>
i also want to point out that there we are talking about 1 practical tradeoff between 1 & 2/3, there are other practical advantages to 1 like not having to modify bitcoin-cli
< sipa>
BlueMatt: the bitcoin specific shims can be trivially patched to pass that through
< bitcoin-git>
[bitcoin] gmaxwell opened pull request #10854: Avoid using sizes on non-fixed-width types to derive protocol constants. (master...rbf-numlimit-fix) https://github.com/bitcoin/bitcoin/pull/10854
< gribble>
https://github.com/bitcoin/bitcoin/issues/10672 | Avoid division by zero in the case of a corrupt estimates file by practicalswift · Pull Request #10672 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/10831 | Batch flushing operations to the walletdb during top up and increase keypool size. by gmaxwell · Pull Request #10831 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] laanwj closed pull request #10831: Batch flushing operations to the walletdb during top up and increase keypool size. (master...topup_batch_flush) https://github.com/bitcoin/bitcoin/pull/10831
< bitcoin-git>
bitcoin/master 30d8f3a Gregory Maxwell: Pushdown walletdb though CWallet::AddKeyPubKey to avoid flushes....
< bitcoin-git>
[bitcoin] laanwj closed pull request #10832: init: Factor out AppInitLockDataDirectory and fix startup core dump issue (master...2017_07_appinitlockdatadirectory) https://github.com/bitcoin/bitcoin/pull/10832
< bitcoin-git>
bitcoin/master 89bb036 Wladimir J. van der Laan: Merge #10832: init: Factor out AppInitLockDataDirectory and fix startup core dump issue...
< bitcoin-git>
bitcoin/master dba485d Wladimir J. van der Laan: init: Factor out AppInitLockDataDirectory...
< gmaxwell>
wumpus: I liked it except for one concern, the parity between the CLI and RPC is a major learing curve improvement. If we went down the path of a highly cooked bitcoin-cli then knoweldge wouldn't automatically transfer between them, improvements wouldn't automatically transfer, etc.
< gmaxwell>
rename bitcoin-cli bitcoin-rpc and we create a real bitcoin-cli ? :P
< bitcoin-git>
[bitcoin] jnewbery closed pull request #10841: [rpc] Give users one final warning before removing getinfo (master...deprecate_getinfo) https://github.com/bitcoin/bitcoin/pull/10841
< gribble>
https://github.com/bitcoin/bitcoin/issues/10831 | Batch flushing operations to the walletdb during top up and increase keypool size. by gmaxwell · Pull Request #10831 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] practicalswift closed pull request #10847: Enable devirtualization opportunities by using the final specifier (C++11) (master...devirtualization) https://github.com/bitcoin/bitcoin/pull/10847
< gribble>
https://github.com/bitcoin/bitcoin/issues/10831 | Batch flushing operations to the walletdb during top up and increase keypool size. by gmaxwell · Pull Request #10831 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/10831 | Batch flushing operations to the walletdb during top up and increase keypool size. by gmaxwell · Pull Request #10831 · bitcoin/bitcoin · GitHub
< bitcoin-git>
bitcoin/master 3895e25 MarcoFalke: Merge #10842: Fix incorrect Doxygen tag (@ince → @since). Doxygen parameter name matching....
< bitcoin-git>
bitcoin/master 2c2e90d practicalswift: Fix incorrect Doxygen tag (@ince → @since). Make Doxygen parameter names match actual parameter names.
< bitcoin-git>
[bitcoin] practicalswift opened pull request #10847: Enable devirtualization opportunities by using the final specifier (C++11) (master...devirtualization) https://github.com/bitcoin/bitcoin/pull/10847
< bitcoin-git>
bitcoin/master 1fc783f MarcoFalke: Merge #10739: test: Move variable `state` down where it is used...
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #10739: test: Move variable `state` down where it is used (master...20170704_Wshadow_txvalidationcache_tests) https://github.com/bitcoin/bitcoin/pull/10739