2021-10-07

<bitcoin-git> bitcoin/master 991753e W. J. van der Laan: Merge bitcoin/bitcoin#23118: test: refactor: introduce `script_util` helpe...
<bitcoin-git> [bitcoin] hebasto opened pull request #23220: ci: Reduce Windows memory for faster scheduling (master...211007-mem1) https://github.com/bitcoin/bitcoin/pull/23220
<bitcoin-git> [bitcoin] jonatack opened pull request #23219: p2p: remove unneeded CNetAddr vector in LookupSubNet() and update/tidy up (master...LookupSubNet-todo-fix) https://github.com/bitcoin/bitcoin/pull/23219
<bitcoin-git> [bitcoin] laanwj merged pull request #23196: util: Make syscall sandbox compilable with kernel 4.4.0 (master...2021-10-syscall-sandbox2) https://github.com/bitcoin/bitcoin/pull/23196
<bitcoin-git> bitcoin/master 6334ff7 W. J. van der Laan: Merge bitcoin/bitcoin#23196: util: Make syscall sandbox compilable with ke...
<bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/6f0cbc75be76...6334ff7364e2
<bitcoin-git> bitcoin/master ac402e7 W. J. van der Laan: util: Conditionalize some syscalls in syscall name table
<bitcoin-git> bitcoin/master 64085b3 W. J. van der Laan: util: Add __NR_copy_file_range syscall constant for sandbox
<bitcoin-git> [bitcoin] laanwj merged pull request #22539: Re-include RBF replacement txs in fee estimation (master...fee_est_rbf) https://github.com/bitcoin/bitcoin/pull/22539
<bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/c0b6c96eee7c...6f0cbc75be76
<bitcoin-git> bitcoin/master 06c5ce9 Antoine Poinsot: Re-include RBF replacement txs in fee estimation
<bitcoin-git> bitcoin/master 053415b Antoine Poinsot: qa: split run_test into smaller parts
<bitcoin-git> bitcoin/master 4556406 Antoine Poinsot: qa: test fee estimation with replacement transactions
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23218: p2p: Use mocktime for ping timeout (master...2110-mockPingTime) https://github.com/bitcoin/bitcoin/pull/23218
<bitcoin-git> [bitcoin] hebasto opened pull request #23217: [DO NOT MERGE] ci: Test required resources for native Windows tasks (master...211007-mem) https://github.com/bitcoin/bitcoin/pull/23217
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23216: clang-format: Set BraceWrapping:AfterControlStatement:MultiLine (master...2110-srcFormat) https://github.com/bitcoin/bitcoin/pull/23216
<bitcoin-git> [bitcoin] hebasto opened pull request #23215: ci: Add vcpkg downloads cache (master...211007-ci) https://github.com/bitcoin/bitcoin/pull/23215
<gribble> https://github.com/bitcoin/bitcoin/issues/22539 | Re-include RBF replacement txs in fee estimation by darosior · Pull Request #22539 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23214: Replace stoul with ToIntegral in dbwrapper (master...2110-dbwInt) https://github.com/bitcoin/bitcoin/pull/23214
<bitcoin-git> [gui] promag opened pull request #448: qt: Add helper to load font (master...2021-10-font-helper) https://github.com/bitcoin-core/gui/pull/448
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23146: Test transactions conflicted by double spend in listtransactions (master...test-txns-conflicted-by-double-spend-in-listtransactions) https://github.com/bitcoin/bitcoin/pull/23146
<bitcoin-git> bitcoin/master 502f50d Jon Atack: Test transactions conflicted by double spend in listtransactions
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b4437d7dfe23...c0b6c96eee7c
<bitcoin-git> bitcoin/master c0b6c96 MarcoFalke: Merge bitcoin/bitcoin#23146: Test transactions conflicted by double spend ...
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23210: test: Replace satoshi_round with int() or Decimal() (master...2110-testRound) https://github.com/bitcoin/bitcoin/pull/23210
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f8911de619d4...b4437d7dfe23
<bitcoin-git> bitcoin/master fa2ac58 MarcoFalke: test: Replace satoshi_round with int() or Decimal()
<bitcoin-git> bitcoin/master b4437d7 MarcoFalke: Merge bitcoin/bitcoin#23210: test: Replace satoshi_round with int() or Dec...
<bitcoin-git> [bitcoin] fanquake closed pull request #22844: feature: enable mypy to run without --ignore-imports (master...josibake-fix-mypy-import-errors) https://github.com/bitcoin/bitcoin/pull/22844
<bitcoin-git> [bitcoin] fanquake opened pull request #23212: lint: enable mypy import checking (master...22844_fixedup) https://github.com/bitcoin/bitcoin/pull/23212
<bitcoin-git> [bitcoin] fanquake merged pull request #23172: doc: Extract FundTxDoc in rpcwallet (master...2110-docRpcWallet) https://github.com/bitcoin/bitcoin/pull/23172
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0500a22d8c78...f8911de619d4
<bitcoin-git> bitcoin/master fafff13 MarcoFalke: doc: Extract FundTxDoc
<bitcoin-git> bitcoin/master f8911de fanquake: Merge bitcoin/bitcoin#23172: doc: Extract FundTxDoc in rpcwallet
<bitcoin-git> [bitcoin] fanquake merged pull request #23208: util: Add mremap syscall to AllowAddressSpaceAccess (master...2110-syscall) https://github.com/bitcoin/bitcoin/pull/23208
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a68de12c0ebf...0500a22d8c78
<bitcoin-git> bitcoin/master 0500a22 fanquake: Merge bitcoin/bitcoin#23208: util: Add mremap syscall to AllowAddressSpace...
<bitcoin-git> bitcoin/master fab360a MarcoFalke: util: Add mremap syscall to AllowAddressSpaceAccess
<bitcoin-git> [bitcoin] theStack opened pull request #23211: refactor: move `update_*` structs from txmempool.h to .cpp file (master...202110-refactor-various_mempool_cleanups) https://github.com/bitcoin/bitcoin/pull/23211
<gribble> https://github.com/bitcoin/bitcoin/issues/23168 | build: no-longer fail default configure if BDB isnt available by fanquake · Pull Request #23168 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] fanquake merged pull request #22890: doc: Replace a link to Qt precompiled binaries with compile instructions (master...210904-msvc) https://github.com/bitcoin/bitcoin/pull/22890
<bitcoin-git> bitcoin/master c4139f0 Hennadii Stepanov: doc: Replace a link to Qt precompiled binaries with compile instructions
<bitcoin-git> bitcoin/master 5e42f2a Hennadii Stepanov: build: Make <QtBaseDir> default name Qt and VS versions agnostic
<bitcoin-git> bitcoin/master 6bc4398 Hennadii Stepanov: doc: Suggest using jom instead of nmake
<bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/577b0ffd2ea4...a68de12c0ebf

2021-10-06

<andytoshi> should there be a LOCK(pwallet->cs_wallet) before this line in MaybeCompactWalletDB? https://github.com/bitcoin/bitcoin/blob/master/src/wallet/walletdb.cpp#L1048
<gene> practicalswift: are you around? wondering if you used mull on bitcoin (for mutation testing)?
<bitcoin-git> [gui] hebasto merged pull request #409: Fix window title of wallet loading window (master...wallet-window-title) https://github.com/bitcoin-core/gui/pull/409
<bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7962c97a2e5a...577b0ffd2ea4
<bitcoin-git> bitcoin/master 577b0ff Hennadii Stepanov: Merge bitcoin-core/gui#409: Fix window title of wallet loading window
<bitcoin-git> bitcoin/master 01bff8f Shashwat: qt: Fix WalletControllerActivity progress dialog title
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bb8550b7887d...7962c97a2e5a
<bitcoin-git> bitcoin/master faa5e17 MarcoFalke: RPCConsole: Throw when overflowing size_t type for array indices
<bitcoin-git> bitcoin/master 7962c97 MarcoFalke: Merge bitcoin-core/gui#446: RPCConsole: Throw when overflowing size_t type...
<bitcoin-git> [gui] MarcoFalke merged pull request #446: RPCConsole: Throw when overflowing size_t type for array indices (master...2110-qtRpcCons) https://github.com/bitcoin-core/gui/pull/446
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23209: test: Avoid RPC roundtrip in MiniWallet get_descriptor() (master...2110-testMini) https://github.com/bitcoin/bitcoin/pull/23209
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/66d11b14357c...bb8550b7887d
<bitcoin-git> bitcoin/master bb8550b MarcoFalke: Merge bitcoin/bitcoin#23209: test: Avoid RPC roundtrip in MiniWallet get_d...
<bitcoin-git> bitcoin/master fa3ab7b MarcoFalke: test: Avoid RPC roundtrip in MiniWallet get_descriptor()
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23210: test: Replace satoshi_round with int() or Decimal() (master...2110-testRound) https://github.com/bitcoin/bitcoin/pull/23210
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23209: test: Avoid RPC roundtrip in MiniWallet get_descriptor() (master...2110-testMini) https://github.com/bitcoin/bitcoin/pull/23209
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23208: util: Add mremap syscall to AllowAddressSpaceAccess (master...2110-syscall) https://github.com/bitcoin/bitcoin/pull/23208
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23207: test: Delete generate* calls from TestNode (master...2110-testDelGen) https://github.com/bitcoin/bitcoin/pull/23207
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23200: Fix intermittent failure in wallet_send.py and rpc_fundrawtransaction.py (master...202110_fix_external_tests) https://github.com/bitcoin/bitcoin/pull/23200
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/113b863f0773...66d11b14357c
<bitcoin-git> bitcoin/master eb02dbb Samuel Dobson: Use self.generate not node.generate throughout tests
<bitcoin-git> bitcoin/master 75a9305 Samuel Dobson: Fix intermittent test failures due to missing sync_all
<bitcoin-git> bitcoin/master 66d11b1 MarcoFalke: Merge bitcoin/bitcoin#23200: Fix intermittent failure in wallet_send.py an...
<bitcoin-git> [bitcoin] fanquake closed pull request #22758: bitcoin/bitcoin:alpine-static on hub.docker.com (master...master) https://github.com/bitcoin/bitcoin/pull/22758
<bitcoin-git> [bitcoin] fanquake opened pull request #23203: [POC] build: static musl libc based bitcoind (with LTO) (master...depends_musl_cross_make) https://github.com/bitcoin/bitcoin/pull/23203
<bitcoin-git> [bitcoin] achow101 opened pull request #23202: wallet: allow psbtbumpfee to work with txs with external inputs (master...bumpfee-ext-inputs) https://github.com/bitcoin/bitcoin/pull/23202
<bitcoin-git> [bitcoin] fanquake closed pull request #23195: doc: fixes #23073 Updated the Release Process (master...update_release_process) https://github.com/bitcoin/bitcoin/pull/23195

2021-10-05

<bitcoin-git> [bitcoin] achow101 opened pull request #23201: wallet: Allow users to specify input weights when funding a transaction (master...ext-input-weight) https://github.com/bitcoin/bitcoin/pull/23201
<bitcoin-git> [bitcoin] meshcollider opened pull request #23200: Fix intermittent failure in wallet_send.py and rpc_fundrawtransaction.py (master...202110_fix_external_tests) https://github.com/bitcoin/bitcoin/pull/23200
<bitcoin-git> [bitcoin] theStack opened pull request #23199: refactor: use `{Read,Write}BE32` helpers for BIP32 nChild (de)serialization (master...202110-refactor-use_be32_helpers_for_bip32_nchild) https://github.com/bitcoin/bitcoin/pull/23199
<bitcoin-git> [gui] stratospher opened pull request #447: Never disable HD status icon (master...enable-watch-only-icon) https://github.com/bitcoin-core/gui/pull/447
<bitcoin-git> [bitcoin] CallMeMisterOwl opened pull request #23198: build: fixes #23073 Parse version information in msvc-autogen.py (master...auto_gen_issue) https://github.com/bitcoin/bitcoin/pull/23198
<bitcoin-git> [bitcoin] CallMeMisterOwl closed pull request #23194: build: Parse version information in msvc-autogen.py (master...auto_gen_MSVC_issue) https://github.com/bitcoin/bitcoin/pull/23194
<bitcoin-git> [bitcoin] jonatack opened pull request #23197: p2p: fix CSubNet::ToString() UBSan and banman fuzz crash (master...fix-netaddress-UB-and-banman-fuzz-crash) https://github.com/bitcoin/bitcoin/pull/23197
<bitcoin-git> [bitcoin] laanwj opened pull request #23196: util: Make syscall sandbox compilable with kernel 4.4.0 (master...2021-10-syscall-sandbox2) https://github.com/bitcoin/bitcoin/pull/23196
<gribble> https://github.com/bitcoin/bitcoin/issues/143 | Fix deadlocks in getaccountaddress, setaccount, sendfrom RPC calls by jgarzik · Pull Request #143 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] CallMeMisterOwl opened pull request #23195: doc: fixes #23073 Updated the Release Process (master...update_release_process) https://github.com/bitcoin/bitcoin/pull/23195
<bitcoin-git> [bitcoin] CallMeMisterOwl opened pull request #23194: script: fixes #23073 Added new function to build_msvc/msvc-autogen.py (master...auto_gen_MSVC_issue) https://github.com/bitcoin/bitcoin/pull/23194
<amiti> cfields: speedy indeed, but I think jnewbery has him beat https://github.com/bitcoin/bitcoin/pull/23053#issuecomment-933517415, he rebased yesterday!
<gribble> https://github.com/bitcoin/bitcoin/issues/23053 | [fuzz] Use public methods in addrman fuzz tests by jnewbery · Pull Request #23053 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/23140 | Make CAddrman::Select_ select buckets, not positions, first by sipa · Pull Request #23140 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] laanwj merged pull request #23162: contrib: Ask for captcha in signet getcoins.py (master...2021-10-getcoins) https://github.com/bitcoin/bitcoin/pull/23162
<bitcoin-git> bitcoin/master a6d9675 W. J. van der Laan: contrib: Ask for captcha in signet getcoins.py
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/89b910711c00...113b863f0773
<bitcoin-git> bitcoin/master 113b863 W. J. van der Laan: Merge bitcoin/bitcoin#23162: contrib: Ask for captcha in signet getcoins.p...
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #23183: C++20 designated initializer test WIP DONOTMERGE!!!11 @@ (master...2110-test) https://github.com/bitcoin/bitcoin/pull/23183
<bitcoin-git> [bitcoin] laanwj merged pull request #23178: util: Fix GUIX build with syscall sandbox (master...2021-10-guix-linux-sandbox) https://github.com/bitcoin/bitcoin/pull/23178
<bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c4fc8994427c...89b910711c00
<bitcoin-git> bitcoin/master 8289d19 W. J. van der Laan: util: Define SECCOMP_RET_KILL_PROCESS if not provided by the headers
<bitcoin-git> bitcoin/master 2d02799 W. J. van der Laan: util: Make sure syscall numbers used in profile are defined
<bitcoin-git> bitcoin/master 89b9107 W. J. van der Laan: Merge bitcoin/bitcoin#23178: util: Fix GUIX build with syscall sandbox
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #22950: [p2p] Pimpl AddrMan to abstract implementation details (master...2021-09-impl-addrman-pimpl) https://github.com/bitcoin/bitcoin/pull/22950
<bitcoin-git> [bitcoin] MarcoFalke pushed 14 commits to master: https://github.com/bitcoin/bitcoin/compare/c79d9fb2f6e5...c4fc8994427c
<bitcoin-git> bitcoin/master 5faa7dd Amiti Uttarwar: [move-only] Move CAddrMan function definitions to cpp
<bitcoin-git> bitcoin/master f2e5f38 Amiti Uttarwar: [move-only] Match ordering of CAddrMan declarations and definitions
<bitcoin-git> bitcoin/master 8af5b54 Amiti Uttarwar: [addrman] Introduce CAddrMan::Impl to encapsulate addrman implementation.
<gribble> https://github.com/bitcoin/bitcoin/issues/19461 | multiprocess: Add bitcoin-gui -ipcconnect option by ryanofsky · Pull Request #19461 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23191: build: Disable -Wbraced-scalar-init, which is incompatible with -Wc++11-narrowing (master...2110-buildW) https://github.com/bitcoin/bitcoin/pull/23191
<bitcoin-git> [gui] MarcoFalke opened pull request #446: RPCConsole: Throw when overflowing size_t type for array indices (master...2110-qtRpcCons) https://github.com/bitcoin-core/gui/pull/446
<bitcoin-git> [bitcoin] instagibbs opened pull request #23188: wallet: fund transaction external input cleanups (master...fundtx-external-inputs_cleanups) https://github.com/bitcoin/bitcoin/pull/23188
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23185: test: Add ParseMoney and ParseScript tests (master...2110-ToIntegral) https://github.com/bitcoin/bitcoin/pull/23185
<bitcoin-git> [bitcoin] brunoerg closed pull request #23135: test: Use asset_equal utils where possible in feature_nulldummy (master...2021-09-assert_equal) https://github.com/bitcoin/bitcoin/pull/23135
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #23184: Use stricter ToIntegral over LocaleIndependentAtoi where possible (master...2110-ToIntegral) https://github.com/bitcoin/bitcoin/pull/23184
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23184: Use stricter ToIntegral over LocaleIndependentAtoi where possible (master...2110-ToIntegral) https://github.com/bitcoin/bitcoin/pull/23184
<jonatack> right, running this gives an overview: ./src/bitcoin-cli -addrinfo
<jonatack> note, getnodeaddresses takes a network argument, so can also: ./src/bitcoin-cli getnodeaddresses 0 ipv4 | jq 'map(select(.address | contains(":")))'
<vasild> Am I the only one? I ran: bitcoin-cli getnodeaddresses 0 |jq 'map(select(.network == "ipv4" and (.address |contains(":"))))'
<prayank> michaelfolkson: Do you really think I commented anything in this PR that does not make sense? I was not aware of all this else would have completely avoided and let others decide. I won't be reviewing any PR in future for this author in any repository. Also started contributing in Knots so it might help me do better things with less people and peace: https://github.com/bitcoinknots/bitcoin/discussions/39
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23179: sandbox: add `newfstatat` & `copy_file_range` to allowed filesystem syscalls (master...add_newfstatat_to_syscall_exceptions) https://github.com/bitcoin/bitcoin/pull/23179
<bitcoin-git> bitcoin/master 44d77d2 fanquake: sandbox: add copy_file_range to allowed filesystem syscalls
<bitcoin-git> bitcoin/master ee08741 fanquake: sandbox: add newfstatat to allowed filesystem syscalls
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/371f0aeeb4b1...c79d9fb2f6e5
<bitcoin-git> bitcoin/master c79d9fb MarcoFalke: Merge bitcoin/bitcoin#23179: sandbox: add `newfstatat` & `copy_file_range`...
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23182: build: add python3.10 alias to AC_PATH_PROGS call in configure (master...python_3_10_configure) https://github.com/bitcoin/bitcoin/pull/23182
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/816e15ee81a2...371f0aeeb4b1
<bitcoin-git> bitcoin/master ef15c57 fanquake: build: add python3.10 alias to AC_PATH_PROGS call in configure
<bitcoin-git> bitcoin/master 371f0ae MarcoFalke: Merge bitcoin/bitcoin#23182: build: add python3.10 alias to AC_PATH_PROGS ...
<gribble> https://github.com/bitcoin/bitcoin/issues/17211 | Allow fundrawtransaction and walletcreatefundedpsbt to take external inputs by achow101 · Pull Request #17211 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/23121 | [policy] check ancestor feerate in RBF, remove BIP125 Rule2 by glozow · Pull Request #23121 · bitcoin/bitcoin · GitHub
<glozow> prayank: I blocked you on my personal github account. It has nothing to do with the repo or maintainers. The help text for blocking a user says "Prevent this user from interacting with your repositories and sending you notifications." I didn't realize it would stop you from commenting on my PR in the Bitcoin Core repo. My apologies to everybody for the confusion.
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23183: C++20 test WIP DONOTMERGE!!!11 @@ (master...2110-test) https://github.com/bitcoin/bitcoin/pull/23183
<meshcollider> prayank: indeed, it can only be a github bug, it is absolutely not censorship. I have copied your questions onto the PR for you: https://github.com/bitcoin/bitcoin/pull/23121#issuecomment-934154169
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #22951: consensus: move amount.h into consensus (master...move_amount_h_consensus) https://github.com/bitcoin/bitcoin/pull/22951
<bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/9e530c6352c3...816e15ee81a2
<bitcoin-git> bitcoin/master d09071d fanquake: [MOVEONLY] consensus: move amount.h into consensus
<bitcoin-git> bitcoin/master 863e52f fanquake: consensus: make COIN & MAX_MONEY constexpr
<bitcoin-git> bitcoin/master 9d0379c fanquake: consensus: use <cstdint> over <stdint.h> in amount.h
<vasild> prayank: on github (that is not specific to bitcoin) it is possible to lock one PR for everybody (in which case "Conversation was locked..." is displayed). Or it is possible to ban one person from all PRs in a repository. But it is not possible to ban one person from one PR.
<prayank> Two questions for PR author: 1. Unconfirmed UTXO are discouraged in Core. Does this PR change default behaviour? Context: https://github.com/bitcoin-core/gui/issues/242 2. Why do you think it's not a bug if attacker can confirm a tx with less fee rate by replacing? It can be exploited if we had on chain DeFi but I am not sure what all projects are currently impacted
<vasild> this is how I found peers to connect to: https://www.erisian.com.au/bitcoin-core-dev/log-2021-10-04.html#l-469
<gribble> https://github.com/bitcoin/bitcoin/issues/23121 | [policy] check ancestor feerate in RBF, remove BIP125 Rule2 by glozow · Pull Request #23121 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] fanquake opened pull request #23182: build: add python3.10 alias to AC_PATH_PROGS call in configure (master...python_3_10_configure) https://github.com/bitcoin/bitcoin/pull/23182
<bitcoin-git> [bitcoin] PastaPastaPasta opened pull request #23181: refactor: remove references to deprecated values under std::allocator (master...btc-allocator) https://github.com/bitcoin/bitcoin/pull/23181
<bitcoin-git> [bitcoin] fanquake opened pull request #23179: sandbox: add newfstatat to allowed filesystem syscalls (master...add_newfstatat_to_syscall_exceptions) https://github.com/bitcoin/bitcoin/pull/23179
<bitcoin-git> [bitcoin] D4nte closed pull request #19349: doc: Include wallet path to relevant RPC calls (master...doc-wallet) https://github.com/bitcoin/bitcoin/pull/19349
<gribble> https://github.com/bitcoin/bitcoin/issues/20487 | Add syscall sandboxing using seccomp-bpf (Linux secure computing mode) by practicalswift · Pull Request #20487 · bitcoin/bitcoin · GitHub

2021-10-04

<bitcoin-git> [bitcoin] laanwj opened pull request #23178: util: Fix GUIX build with syscall sandbox (master...2021-10-guix-linux-sandbox) https://github.com/bitcoin/bitcoin/pull/23178
<gribble> https://github.com/bitcoin/bitcoin/issues/1 | JSON-RPC support for mobile devices ("ultra-lightweight" clients) · Issue #1 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] laanwj merged pull request #20487: Add syscall sandboxing using seccomp-bpf (Linux secure computing mode) (master...seccomp-bpf-2020-11) https://github.com/bitcoin/bitcoin/pull/20487
<bitcoin-git> bitcoin/master 4747da3 practicalswift: Add syscall sandboxing (seccomp-bpf)
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/42fedb4acd3c...9e530c6352c3
<bitcoin-git> bitcoin/master 9e530c6 W. J. van der Laan: Merge bitcoin/bitcoin#20487: Add syscall sandboxing using seccomp-bpf (Lin...
<bitcoin-git> [bitcoin] jonatack opened pull request #23175: Add CJDNS network to -addrinfo and -netinfo (master...add-cjdns-to-addrinfo-and-netinfo) https://github.com/bitcoin/bitcoin/pull/23175
<bitcoin-git> [bitcoin] jamesob opened pull request #23174: validation: have LoadBlockIndex account for snapshot use (master...2021-10-au-loadblockindex) https://github.com/bitcoin/bitcoin/pull/23174
<gribble> https://github.com/bitcoin/bitcoin/issues/15936 | Unify bitcoin-qt and bitcoind persistent settings by ryanofsky · Pull Request #15936 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] jnewbery opened pull request #23173: Add `ChainstateManager::ProcessTransaction` (master...2021-09-process-transaction) https://github.com/bitcoin/bitcoin/pull/23173
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23156: refactor: Remove unused ParsePrechecks and ParseDouble (master...2110-refactorParseInt) https://github.com/bitcoin/bitcoin/pull/23156
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/cdb4dfcbf1c8...42fedb4acd3c
<bitcoin-git> bitcoin/master fa9d72a MarcoFalke: Remove unused ParseDouble and ParsePrechecks
<bitcoin-git> bitcoin/master fa3cd28 MarcoFalke: refactor: Remove unused ParsePrechecks from ParseIntegral
<bitcoin-git> bitcoin/master 42fedb4 MarcoFalke: Merge bitcoin/bitcoin#23156: refactor: Remove unused ParsePrechecks and Pa...
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23172: doc: Extract FundTxDoc (master...2110-docRpcWallet) https://github.com/bitcoin/bitcoin/pull/23172
<gribble> https://github.com/bitcoin/bitcoin/issues/15936 | Unify bitcoin-qt and bitcoind persistent settings by ryanofsky · Pull Request #15936 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] MarcoFalke reopened pull request #23156: refactor: Remove unused ParsePrechecks and ParseDouble (master...2110-refactorParseInt) https://github.com/bitcoin/bitcoin/pull/23156
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #23156: refactor: Remove unused ParsePrechecks and ParseDouble (master...2110-refactorParseInt) https://github.com/bitcoin/bitcoin/pull/23156
<bitcoin-git> [bitcoin] laanwj merged pull request #20452: util: Replace use of locale dependent atoi(…) with locale-independent std::from_chars(…) (C++17) (master...remove-atoi) https://github.com/bitcoin/bitcoin/pull/20452
<bitcoin-git> bitcoin/master 4343f11 practicalswift: Replace use of locale dependent atoi(…) with locale-independent std::from_...
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c6f710ec9855...cdb4dfcbf1c8
<bitcoin-git> bitcoin/master cdb4dfc W. J. van der Laan: Merge bitcoin/bitcoin#20452: util: Replace use of locale dependent atoi(…)...
<gribble> https://github.com/bitcoin/bitcoin/issues/17211 | Allow fundrawtransaction and walletcreatefundedpsbt to take external inputs by achow101 · Pull Request #17211 · bitcoin/bitcoin · GitHub
<Kiminuo> https://github.com/bitcoin/bitcoin/pull/22918/checks?check_run_id=3788171337 - does anybody understand why this fails?
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23052: test: use miniwallet in test_rpc function in feature_rbf.py (master...master) https://github.com/bitcoin/bitcoin/pull/23052
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/573b4621cc1f...c6f710ec9855
<bitcoin-git> bitcoin/master 74c0d81 Shubhankar: test: use miniwallet in test_rpc() function in feature_rbf.py
<bitcoin-git> bitcoin/master c6f710e MarcoFalke: Merge bitcoin/bitcoin#23052: test: use miniwallet in test_rpc function in ...
<bitcoin-git> [bitcoin] meshcollider merged pull request #17211: Allow fundrawtransaction and walletcreatefundedpsbt to take external inputs (master...fundtx-external-inputs) https://github.com/bitcoin/bitcoin/pull/17211
<bitcoin-git> bitcoin/master d5cfb86 Andrew Chow: Allow Coin Selection be able to take external inputs
<bitcoin-git> [bitcoin] meshcollider pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/446b70669645...573b4621cc1f
<bitcoin-git> bitcoin/master a00eb38 Andrew Chow: Allow CInputCoin to also be constructed with COutPoint and CTxOut
<bitcoin-git> bitcoin/master 38f5642 Andrew Chow: allow fundtx rpcs to work with external inputs
<bitcoin-git> [bitcoin] darosior opened pull request #23171: qa: test descriptors with mixed xpubs and const pubkeys (master...desc_test_mix) https://github.com/bitcoin/bitcoin/pull/23171
<laanwj> i think we should try to get the CI for https://github.com/bitcoin-core/bitcoincore.org, i don't like blindly merging anything
<gribble> https://github.com/bitcoin/bitcoin/issues/23119 | test: replace bare asserts with assertion helpers (assert_equal() etc.) · Issue #23119 · bitcoin/bitcoin · GitHub
<vincenzopalazzo> Hello guys, I'm working on #23119 and I decided to slip the work in different PR, I would like to know if this approach is good for the review dev, and you preferer it all at once? My start PR is https://github.com/bitcoin/bitcoin/pull/23127
<bitcoin-git> [bitcoin] martinus opened pull request #23169: Fix `-Wmaybe-uninitialized` warnings found by building with `-flto` (master...2021-10-fix-Wmaybe-uninitialized-warnings) https://github.com/bitcoin/bitcoin/pull/23169
<gribble> https://github.com/bitcoin/bitcoin/issues/22966 | doc: Improve documentation around the ACK statement by jarolrod · Pull Request #22966 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] fanquake opened pull request #23168: build: no-longer fail default configure if BDB isn't available (master...dont_fail_no_bdb_default_configure) https://github.com/bitcoin/bitcoin/pull/23168
<gribble> https://github.com/bitcoin/bitcoin/issues/17211 | Allow fundrawtransaction and walletcreatefundedpsbt to take external inputs by achow101 · Pull Request #17211 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] meshcollider closed pull request #23090: Deprecate `main` and `test` `-chain` params (master...20210924) https://github.com/bitcoin/bitcoin/pull/23090

2021-10-03

<bitcoin-git> [gui] luke-jr opened pull request #444: Qt: Network Watch tool (master...gui_netwatch) https://github.com/bitcoin-core/gui/pull/444
<darosior> achow101: in descriptor_tests, DoCheck assumes a descriptor with xpubs has no raw keys https://github.com/bitcoin/bitcoin/blob/446b706696451ae1a66ac416f347d734c5741d7c/src/test/descriptor_tests.cpp#L190-L208 . Descriptors with both are supported, right? Just want to be sure
<gribble> https://github.com/bitcoin/bitcoin/issues/17211 | Allow fundrawtransaction and walletcreatefundedpsbt to take external inputs by achow101 · Pull Request #17211 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/10609 | Feature request: pruned chain and getrawtransaction · Issue #10609 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] fanquake merged pull request #23151: doc: Combine 23.0 release notes (master...2110-docRel) https://github.com/bitcoin/bitcoin/pull/23151
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/35a31d5f7e9c...446b70669645
<bitcoin-git> bitcoin/master fad5a18 MarcoFalke: doc: Combine 23.0 release notes
<bitcoin-git> bitcoin/master 446b706 fanquake: Merge bitcoin/bitcoin#23151: doc: Combine 23.0 release notes
<bitcoin-git> [bitcoin] fanquake closed pull request #23163: Create CNAME (master...master) https://github.com/bitcoin/bitcoin/pull/23163
<bitcoin-git> [bitcoin] Iceymann18777 opened pull request #23163: Create CNAME (master...master) https://github.com/bitcoin/bitcoin/pull/23163

2021-10-02

<gribble> https://github.com/bitcoin/bitcoin/issues/22154 | Add OutputType::BECH32M and related wallet support for fetching bech32m addresses by achow101 · Pull Request #22154 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/12119 | [wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH by Sjors · Pull Request #12119 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] laanwj opened pull request #23162: contrib: Ask for captcha in signet getcoins.py (master...2021-10-getcoins) https://github.com/bitcoin/bitcoin/pull/23162

2021-10-01

<bitcoin-git> [bitcoin] glozow opened pull request #23157: txmempool -/-> validation 1/2: improve performance of check() and remove dependency on validation (master...2021-09-speed-mempool-check) https://github.com/bitcoin/bitcoin/pull/23157
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23156: refactor: Remove unused ParsePrechecks from ParseIntegral (master...2110-refactorParseInt) https://github.com/bitcoin/bitcoin/pull/23156
<bitcoin-git> [bitcoin] jamesob opened pull request #23155: rpc: various fixups for dumptxoutset (master...2021-10-au-rpc-fixes) https://github.com/bitcoin/bitcoin/pull/23155
<bitcoin-git> [bitcoin] jamesob opened pull request #23154: doc: add assumeutxo notes (master...2021-10-assumeutxo-doc) https://github.com/bitcoin/bitcoin/pull/23154
<prayank> Does anyone who is positive about Bitcoin development have any thoughts on this PR?
<laanwj> i've read some of the things you wrote and you seem to be nothing but negative about bitcoin development
<bitcoin-git> [bitcoin] katesalazar opened pull request #23153: Add an argparse abbreviated mode to --failfast (master...patch-1) https://github.com/bitcoin/bitcoin/pull/23153
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23136: test: update fee rate assertion helper in the functional test framework (master...update-assert_fee_amount) https://github.com/bitcoin/bitcoin/pull/23136
<bitcoin-git> bitcoin/master 35a31d5 MarcoFalke: Merge bitcoin/bitcoin#23136: test: update fee rate assertion helper in the...
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/46b4937bc16c...35a31d5f7e9c
<bitcoin-git> bitcoin/master b658d7d Jon Atack: test: update assert_fee_amount() in test_framework/util.py
<bitcoin-git> [bitcoin] laanwj merged pull request #22585: fuzz: add guide to fuzzing with Eclipser v1.x (master...patch-2) https://github.com/bitcoin/bitcoin/pull/22585
<bitcoin-git> [bitcoin] laanwj merged pull request #23142: Return false on corrupt tx rather than asserting (master...202109_no_assert_corruption) https://github.com/bitcoin/bitcoin/pull/23142
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/29b030bca31d...46b4937bc16c
<bitcoin-git> bitcoin/master 46b4937 W. J. van der Laan: Merge bitcoin/bitcoin#23142: Return false on corrupt tx rather than assert...
<bitcoin-git> bitcoin/master 0ab4c3b Samuel Dobson: Return false on corrupt tx rather than asserting
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4e1de1fc5905...29b030bca31d
<bitcoin-git> bitcoin/master 29b030b W. J. van der Laan: Merge bitcoin/bitcoin#22585: fuzz: add guide to fuzzing with Eclipser v1.x...
<bitcoin-git> bitcoin/master 6e1150e Alex Groce: fuzz: add guide to fuzzing with Eclipser v1.x
<bitcoin-git> [bitcoin] fanquake opened pull request #23152: build: add `--enable-lto` configuration option (master...experiment_with_lto) https://github.com/bitcoin/bitcoin/pull/23152
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23151: doc: Combine 23.0 release notes (master...2110-docRel) https://github.com/bitcoin/bitcoin/pull/23151
<bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/33b0696d3106...4e1de1fc5905
<bitcoin-git> bitcoin/master 5bf6587 Niklas Gögge: [test] Test that -blocksonly nodes do not request high bandwidth mode.
<bitcoin-git> bitcoin/master 0dc8bf5 Niklas Gögge: [net processing] Dont request compact blocks in blocks-only mode
<bitcoin-git> bitcoin/master 5e231c1 Niklas Gögge: [test] Test that -blocksonly nodes do not send getdata(CMPCT) on a low ban...
<bitcoin-git> [bitcoin] fanquake closed pull request #23150: Update README.md - grammar fixes (master...patch-1) https://github.com/bitcoin/bitcoin/pull/23150
<bitcoin-git> [bitcoin] evil-maid opened pull request #23150: Update README.md - grammar fixes (master...patch-1) https://github.com/bitcoin/bitcoin/pull/23150
<bitcoin-git> [bitcoin] fanquake opened pull request #23149: build: make --enable-werror just -Werror (master...make_enable_werror_full_werror) https://github.com/bitcoin/bitcoin/pull/23149
<bitcoin-git> [bitcoin] fanquake closed pull request #23147: refactor: rename DBErrors::RESCAN_REQUIRED to NEED_RESCAN (master...202110_rename_rescan_enum) https://github.com/bitcoin/bitcoin/pull/23147
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/571bb94dfb50...33b0696d3106
<bitcoin-git> bitcoin/master 8615507 Samuel Dobson: scripted-diff: rename DBErrors::RESCAN_REQUIRED to NEED_RESCAN
<bitcoin-git> bitcoin/master 33b0696 fanquake: Merge bitcoin/bitcoin#23147: refactor: rename DBErrors::RESCAN_REQUIRED to...

2021-09-30

<Guest64> Guys, hello. Tell me who's in the subject. I send a certain amount of money from Bitcoin Core to a Bitcoin address, the commission is generally acceptable. But the balance of the wallet itself is reduced by an amount that is 42 times more than the amount of funds sent. I canceled the operation. What can be wrong?
<bitcoin-git> [bitcoin] meshcollider closed pull request #23141: test: Fix intermitent failure in wallet_basic.py (master...202109_fix_test_rounding) https://github.com/bitcoin/bitcoin/pull/23141
<bitcoin-git> [bitcoin] meshcollider opened pull request #23147: trivial refactor: rename DBErrors::RESCAN_REQUIRED to NEED_RESCAN (master...202110_rename_rescan_enum) https://github.com/bitcoin/bitcoin/pull/23147
<luke-jr> I tried this but no review: https://github.com/bitcoin/bitcoin/pull/17356
<bitcoin-git> [bitcoin] kiminuo closed pull request #21577: refactor: Remove superfluous "return" from "addUnchecked" in txmempool.cpp (master...feature/2021-04-02-superfluous-return) https://github.com/bitcoin/bitcoin/pull/21577
<bitcoin-git> [bitcoin] achow101 closed pull request #18789: qt: Add Create Unsigned button to SendConfirmationDialog (master...create-unsigned-sendconfdialog) https://github.com/bitcoin/bitcoin/pull/18789
<bitcoin-git> [gui] achow101 opened pull request #441: Add Create Unsigned button to SendConfirmationDialog (master...create-unsigned-sendconfdialog) https://github.com/bitcoin-core/gui/pull/441
<core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
<bitcoin-git> [bitcoin] meshcollider closed pull request #23123: Remove `-rescan` startup parameter (master...202109_remove_rescan) https://github.com/bitcoin/bitcoin/pull/23123
<laanwj> https://github.com/bitcoin/bitcoin/pull/20487 Add syscall sandboxing using seccomp-bpf (Linux secure computing mode)
<laanwj> https://github.com/bitcoin/bitcoin/projects/8 7 blockers, 2 chasing concept ACK at the moment
<core-meetingbot> Meeting started Thu Sep 30 19:01:54 2021 UTC. The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
<bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/9013f23b0a6e...571bb94dfb50
<bitcoin-git> bitcoin/master f963b0f Samuel Dobson: Corrupt wallet tx shouldn't trigger rescan of all wallets
<bitcoin-git> bitcoin/master 6c00649 Samuel Dobson: Remove outdated dummy wallet -salvagewallet arg
<bitcoin-git> bitcoin/master bccd1d9 Samuel Dobson: Remove -rescan startup parameter
<bitcoin-git> [gui] shaavan closed pull request #437: Show received bitcoins in green (master...green-coins) https://github.com/bitcoin-core/gui/pull/437
<laanwj> it's fairly easy with make to make a mistake with regard to ordering dependencies which causes issues (either errors or non-determinism) with high parallelism, if you find such a issue with bitcoin core please report it
<sipa> i build bitcoin core with -j48
<laanwj> i don't know about useless? bitcoin core's build should have plenty of potential parallelism, i once saw a screenshot of someone building on a 64-core machine, all cores 100%, though probably this won't be the case in the latter parts of the process during linking etc which have to merge a lot of build artifacts
<bitcoin-git> [bitcoin] jonatack opened pull request #23146: Test transactions conflicted by double spend in listtransactions (master...test-txns-conflicted-by-double-spend-in-listtransactions) https://github.com/bitcoin/bitcoin/pull/23146
<laanwj> jamesob: not that i know, there's https://bitcoincore.org/bin/bitcoin-core-22.0/SHA256SUMS.ots but it gets generated prior to upload, it's not part of any of the attestations
<bitcoin-git> [gui] hebasto merged pull request #342: wallet: Move wallets loading out from the main GUI thread (master...210521-wallet) https://github.com/bitcoin-core/gui/pull/342
<bitcoin-git> [bitcoin] hebasto pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/2d8e0c0c3c0d...9013f23b0a6e
<bitcoin-git> bitcoin/master f9b633e Hennadii Stepanov: qt, wallet: Move activity progress dialog from data member to local
<bitcoin-git> bitcoin/master 4a024fc Hennadii Stepanov: qt, wallet, refactor: Move connection to QObject::deleteLater to ctor
<bitcoin-git> bitcoin/master f6991cb Hennadii Stepanov: qt, wallet: Add LoadWalletsActivity class
<TallTim> I'd like to report using addnode to sync bitcoin core client with my personal full node has sped up my sync time. Thanks again to sipa for the advice.
<bitcoin-git> [gui] hebasto closed pull request #59: Do not block GUI thread in RPCConsole (master...200814-rpc) https://github.com/bitcoin-core/gui/pull/59
<bitcoin-git> [bitcoin] laanwj merged pull request #20457: util: Make Parse{Int,UInt}{32,64} use locale independent std::from_chars(…) (C++17) instead of locale dependent strto{l,ll,ul,ull} (master...locale-independent-parseint) https://github.com/bitcoin/bitcoin/pull/20457
<bitcoin-git> bitcoin/master 4747db8 practicalswift: util: Introduce ToIntegral<T>(const std::string&) for locale independent p...
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1cf7fb9fd658...2d8e0c0c3c0d
<bitcoin-git> bitcoin/master 2d8e0c0 W. J. van der Laan: Merge bitcoin/bitcoin#20457: util: Make Parse{Int,UInt}{32,64} use locale ...
<bitcoin-git> [bitcoin] laanwj merged pull request #23104: log: Avoid breaking single log lines over multiple lines in the log file (master...2109-logCont) https://github.com/bitcoin/bitcoin/pull/23104
<bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/7f81f5459ffa...1cf7fb9fd658
<bitcoin-git> bitcoin/master fa6c1e8 MarcoFalke: test: Fix typos in tests
<bitcoin-git> bitcoin/master faffaa8 MarcoFalke: log: Avoid broken SELECTCOINS log
<bitcoin-git> bitcoin/master faeae29 MarcoFalke: log: Avoid broken DEBUG_LOCKORDER log
<bitcoin-git> [bitcoin] laanwj merged pull request #23082: build: improve gexauxval() detection, remove getauxval() weak linking (master...remove_weak_auxval) https://github.com/bitcoin/bitcoin/pull/23082
<bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/bd40cd81083a...7f81f5459ffa
<bitcoin-git> bitcoin/master 4446ef0 fanquake: build: remove support for weak linking getauxval()
<bitcoin-git> bitcoin/master e56100c fanquake: build: remove arm includes from getauxval() check
<bitcoin-git> bitcoin/master 7f81f54 W. J. van der Laan: Merge bitcoin/bitcoin#23082: build: improve gexauxval() detection, remove ...
<fedecuci> Hi guys, I am curious, how many people have a very strong understanding of the Bitcoin protocol and source code? I am talking about people that are comfortable with at least 80% of the codebase and would know almost immediately where to go to fix a bug in case it arises. Any estimate?
<bitcoin-git> [bitcoin] fanquake merged pull request #23133: Update crc32c subtree (master...2109-subtreeCrc32c) https://github.com/bitcoin/bitcoin/pull/23133
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/dbbb7fbcc02e...bd40cd81083a
<bitcoin-git> bitcoin/master 1d44513 MarcoFalke: Squashed 'src/crc32c/' changes from b5ef9be675..0d624261ef
<bitcoin-git> bitcoin/master fac1c13 MarcoFalke: Update crc32c subtree
<bitcoin-git> bitcoin/master bd40cd8 fanquake: Merge bitcoin/bitcoin#23133: Update crc32c subtree
<bitcoin-git> [bitcoin] laanwj merged pull request #23130: doc: Revert "Remove outdated comments" and place comment correctly (master...210929-revert) https://github.com/bitcoin/bitcoin/pull/23130
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/80b4e8fb87a2...dbbb7fbcc02e
<bitcoin-git> bitcoin/master 8ff3743 Hennadii Stepanov: Revert "doc: Remove outdated comments"
<bitcoin-git> bitcoin/master dbbb7fb W. J. van der Laan: Merge bitcoin/bitcoin#23130: doc: Revert "Remove outdated comments" and pl...
<bitcoin-git> [bitcoin] laanwj merged pull request #23112: wallet: enable SQLite extended result codes (master...202109-wallet-enable_sqlite_extended_result_codes) https://github.com/bitcoin/bitcoin/pull/23112
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/81e7748bc18a...80b4e8fb87a2
<bitcoin-git> bitcoin/master 90be29c Sebastian Falbesoner: wallet: enable SQLite extended result codes
<bitcoin-git> bitcoin/master 80b4e8f W. J. van der Laan: Merge bitcoin/bitcoin#23112: wallet: enable SQLite extended result codes
<bitcoin-git> [gui] laanwj merged pull request #336: Do not exit and re-enter main event loop during shutdown (master...210516-loop) https://github.com/bitcoin-core/gui/pull/336
<bitcoin-git> bitcoin/master 13f6188 Hennadii Stepanov: qt: Add GUIUtil::ShowModalDialogAndDeleteOnClose
<bitcoin-git> [bitcoin] laanwj pushed 11 commits to master: https://github.com/bitcoin/bitcoin/compare/f52929063f48...81e7748bc18a
<bitcoin-git> bitcoin/master 7830cd0 Hennadii Stepanov: qt, refactor: Keep OptionsDialog in the main event loop
<bitcoin-git> bitcoin/master 59f7ba4 Hennadii Stepanov: qt, refactor: Keep CoinControlDialog in the main event loop
<vasild> in case anybody is curious how many incoming connections his node is getting (and lazy to type wretched bash commands), assuming debug=net is switched off on the node: bitcoin-cli logging '["net"]' && sleep 3600 && bitcoin-cli logging '[]' '["net"]'
<bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/69a66dcd0dac...f52929063f48
<bitcoin-git> bitcoin/master f529290 Hennadii Stepanov: Merge bitcoin-core/gui#439: Do not show unused widgets at startup
<bitcoin-git> bitcoin/master 489060d Hennadii Stepanov: qt: Do not show unused widgets at startup
<vasild> laanwj: right, a "node" victim.com:80 that never speaks bitcoin p2p would propagate less and fall out of addrmans. So a rate from a well propagated real bitcoin node with public ipv4 address and port 80 would give an upper bound. If that is not high enough to be considered as a dos attack, then a lower number will also not be.
<gribble> https://github.com/bitcoin/bitcoin/issues/23136 | test: update fee rate assertion helper in the functional test framework by jonatack · Pull Request #23136 · bitcoin/bitcoin · GitHub