2016-12-14

< bitcoin-git> bitcoin/master da9cdd2 Gregory Maxwell: Do not run functions with necessary side-effects in assert()
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/26fe5c98ab6a...82ccac739e2a
< bitcoin-git> [bitcoin] laanwj closed pull request #9264: 0.13.2 backports (0.13...2016_12_backports_0_13) https://github.com/bitcoin/bitcoin/pull/9264
< gribble> https://github.com/bitcoin/bitcoin/issues/9262 | Prefer coins that have fewer ancestors, sanity check txn before ATMP by instagibbs · Pull Request #9262 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] gmaxwell opened pull request #9344: Do not run functions with necessary side-effects in assert() (master...assert_no_sideeffects) https://github.com/bitcoin/bitcoin/pull/9344
< gmaxwell> jonasschnelli: want to go comment on http://bitcoin.stackexchange.com/questions/50125/failing-to-build-bitcoin-core-v0-13-1-on-debian-stretch and point out its fixed in master?

2016-12-13

< bitcoin-git> [bitcoin] morcos opened pull request #9343: Don't create change at dust limit (master...noneconomicchange) https://github.com/bitcoin/bitcoin/pull/9343
< gribble> https://github.com/bitcoin/bitcoin/issues/9279 | Consensus: Move CFeeRate out of libconsensus by jtimon · Pull Request #9279 · bitcoin/bitcoin · GitHub
< jtimon> btw, morcos, your change to the dust variable will probably less painful after https://github.com/bitcoin/bitcoin/pull/9279/commits/59ed6874612a0c4c410fc6016c21cdde68c42601
< morcos> Can we add one of those checkboxes that lets bitcoin-qt send back diagnostics to us about how it's actually used so we can improve it? :)
< bitcoin-git> [bitcoin] richardkiss opened pull request #9342: Change SIG_NULLFAIL => NULLFAIL. (master...feature/unify_nullfail) https://github.com/bitcoin/bitcoin/pull/9342
< jtimon> sorry, can't access github now, but rebased https://github.com/bitcoin/bitcoin/pull/9279 and the windows builds keep failing in a way I cannot understand or reproduce, it says "int64_t does not name a type". Any help welcomed
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #9340: [0.13] Update secp256k1 subtree (0.13...Mf1612-013subtree) https://github.com/bitcoin/bitcoin/pull/9340
< bitcoin-git> [bitcoin] laanwj closed pull request #9326: Update for OpenSSL 1.1 API. (master...openssl_api11) https://github.com/bitcoin/bitcoin/pull/9326
< bitcoin-git> bitcoin/master 26fe5c9 Wladimir J. van der Laan: Merge #9326: Update for OpenSSL 1.1 API....
< bitcoin-git> bitcoin/master b05b1af Gregory Maxwell: Fix qt/paymentrequestplus.cpp for OpenSSL 1.1 API....
< bitcoin-git> bitcoin/master bae1eef Gregory Maxwell: Fix wallet/test/crypto_tests.cpp for OpenSSL 1.1 API....
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/5233aefa3f52...26fe5c98ab6a
< bitcoin-git> [bitcoin] laanwj closed pull request #9305: Refactor: Removed begin/end_ptr functions. (master...remove-begin-end_ptr-usage) https://github.com/bitcoin/bitcoin/pull/9305
< bitcoin-git> bitcoin/master 5233aef Wladimir J. van der Laan: Merge #9305: Refactor: Removed begin/end_ptr functions....
< bitcoin-git> bitcoin/master 8c1dbc5 Karl-Johan Alm: Refactor: Removed begin/end_ptr functions.
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/cfd5e6b1dc32...5233aefa3f52
< bitcoin-git> [bitcoin] laanwj closed pull request #9334: Update to latest libsecp256k1 (master...secp) https://github.com/bitcoin/bitcoin/pull/9334
< bitcoin-git> bitcoin/master 547a53d Pieter Wuille: Update libsecp256k1 to master
< bitcoin-git> bitcoin/master cfd5e6b Wladimir J. van der Laan: Merge #9334: Update to latest libsecp256k1...
< bitcoin-git> bitcoin/master 7b49f22 Pieter Wuille: Squashed 'src/secp256k1/' changes from 7a49cac..8225239...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/b6abdc77d39c...cfd5e6b1dc32
< bitcoin-git> [bitcoin] laanwj closed pull request #9302: Return txid even if ATMP fails for new transaction (master...failedtxid) https://github.com/bitcoin/bitcoin/pull/9302
< bitcoin-git> bitcoin/master b6abdc7 Wladimir J. van der Laan: Merge #9302: Return txid even if ATMP fails for new transaction...
< bitcoin-git> bitcoin/master b3a7410 Pieter Wuille: Return txid even if ATMP fails for new transaction
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e6ba5068f107...b6abdc77d39c
< gribble> https://github.com/bitcoin/bitcoin/issues/9290 | Make RelayWalletTransaction attempt to AcceptToMemoryPool. by gmaxwell · Pull Request #9290 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9302 | Return txid even if ATMP fails for new transaction by sipa · Pull Request #9302 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #9335: Fix typo in test/data/tx_valid.json (master...feature/typo) https://github.com/bitcoin/bitcoin/pull/9335
< bitcoin-git> bitcoin/master e6ba506 MarcoFalke: Merge #9335: Fix typo in test/data/tx_valid.json...
< bitcoin-git> bitcoin/master e49a252 Richard Kiss: Fix spelling.
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/76fcd9d50341...e6ba5068f107
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #9064: unify capitalization of "bitcoin address" (master...changeCaps) https://github.com/bitcoin/bitcoin/pull/9064
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #9339: Revert segwit. Increase block size to 8MB for Bitcoin Ocho. Bitcoin Ocho is the future. (master...master) https://github.com/bitcoin/bitcoin/pull/9339
< bitcoin-git> [bitcoin] goku1997 opened pull request #9339: Revert segwit. Increase block size to 8MB for Bitcoin Ocho. Bitcoin Ocho is the future. (master...master) https://github.com/bitcoin/bitcoin/pull/9339
< bitcoin-git> [bitcoin] rebroad opened pull request #9338: Stripe downloads to reduce stallers occuring (master...ReduceStalling) https://github.com/bitcoin/bitcoin/pull/9338
< Lightsword> main thing I’m noticing is a huge GBT call time variance reduction when I removed these 4 lines https://github.com/bitcoin/bitcoin/blob/0.13/src/miner.cpp#L192-L195
< Lightsword> think it would be reasonable to remove this TestBlockValidity check in 0.13 for miners? https://github.com/bitcoin/bitcoin/blob/0.13/src/miner.cpp#L193-L195

2016-12-12

< bitcoin-git> [bitcoin] richardkiss closed pull request #9336: Change SIG_NULLFAIL => NULLFAIL. (master...feature/unify_nullfail) https://github.com/bitcoin/bitcoin/pull/9336
< bitcoin-git> [bitcoin] richardkiss opened pull request #9336: Change SIG_NULLFAIL => NULLFAIL. (master...feature/unify_nullfail) https://github.com/bitcoin/bitcoin/pull/9336
< bitcoin-git> [bitcoin] richardkiss opened pull request #9335: Fix spelling. (master...feature/typo) https://github.com/bitcoin/bitcoin/pull/9335
< gribble> https://github.com/bitcoin/bitcoin/issues/9236 | Fix races for strMiscWarning and fLargeWork*Found, make QT runawayException use GetWarnings by gmaxwell · Pull Request #9236 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9302 | Return txid even if ATMP fails for new transaction by sipa · Pull Request #9302 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9290 | Make RelayWalletTransaction attempt to AcceptToMemoryPool. by gmaxwell · Pull Request #9290 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sipa opened pull request #9334: Update to latest libsecp256k1 (master...secp) https://github.com/bitcoin/bitcoin/pull/9334
< gribble> https://github.com/bitcoin/bitcoin/issues/8501 | Add mempool statistics collector by jonasschnelli · Pull Request #8501 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] ryanofsky opened pull request #9333: [trivial] Add comment documenting CWalletTx::mapValue (master...pr/comment-mapvalue) https://github.com/bitcoin/bitcoin/pull/9333
< bitcoin-git> [bitcoin] ryanofsky opened pull request #9332: Let wallet importmulti RPC accept labels for standard scriptPubKeys (on top of #9331) (master...pr/script-label) https://github.com/bitcoin/bitcoin/pull/9332
< bitcoin-git> [bitcoin] ryanofsky opened pull request #9331: [qa] Add test for rescan feature of wallet key import RPCs (master...pr/test-import-rescan) https://github.com/bitcoin/bitcoin/pull/9331
< jtimon> mmhmm, shouldn't https://github.com/bitcoin/bitcoin/blob/master/src/serialize.h#L259 use std::numeric_limits<uint32_t>::max() instead of std::numeric_limits<unsigned int>::max() ?
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #9330: [Qt] Console: add security warning (master...2016/12/qt_add_sec) https://github.com/bitcoin/bitcoin/pull/9330
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #9329: [Qt] Console: allow empty arguments (master...2016/12/fix_qt_empty_args) https://github.com/bitcoin/bitcoin/pull/9329
< bitcoin-git> [bitcoin] gmaxwell opened pull request #9326: Fix wallet/test/crypto_tests.cpp for OpenSSL 1.1 API. (master...openssl_api11) https://github.com/bitcoin/bitcoin/pull/9326
< gmaxwell> https://github.com/bitcoin-core/secp256k1/pull/433 okay thats the libsecp256k1 part, I'll go do the bitcoin-core part.
< bitcoin-git> [bitcoin] rebroad opened pull request #9325: Allow first cmpctblock/blocktxn received to be processed (rather than first requested) (master...ProcessFirstCmpct) https://github.com/bitcoin/bitcoin/pull/9325
< BlueMatt> https://github.com/bitcoin/bitcoin/blob/master/src/addrman.cpp#L38 its not the first time he's blocked things from the future
< bitcoin-git> [bitcoin] sipa closed pull request #9324: Increase block size to 8MB for Bitcoin Ocho. Bitcoin Ocho is the future. (master...master) https://github.com/bitcoin/bitcoin/pull/9324
< bitcoin-git> [bitcoin] goku1997 opened pull request #9324: Increase block size to 8MB for Bitcoin Ocho. Bitcoin Ocho is the future. (master...master) https://github.com/bitcoin/bitcoin/pull/9324

2016-12-11

< bitcoin-git> [bitcoin] gmaxwell opened pull request #9323: [0.13] Add release notes for wallet/mempool rejections. (PR #9302 and #9290) (0.13...mempool_relnote) https://github.com/bitcoin/bitcoin/pull/9323
< bitcoin-git> [bitcoin] rebroad closed pull request #9300: Check for oversized getblocktxn message. (master...CheckOversizedGetblocktxns) https://github.com/bitcoin/bitcoin/pull/9300
< bitcoin-git> [bitcoin] rebroad closed pull request #9055: Skip processing of cmpctblocks we have previously downloaded. (master...SkipCmpctblocksPreviouslyDownloaded) https://github.com/bitcoin/bitcoin/pull/9055
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #9322: [qa] Don't set unknown rpcserialversion (master...Mf1612-qaSerial) https://github.com/bitcoin/bitcoin/pull/9322
< bitcoin-git> [bitcoin] gmaxwell opened pull request #9319: Break addnode out from the outbound connection limits. (master...addnode_own_count) https://github.com/bitcoin/bitcoin/pull/9319
< sipa_> try #bitcoin or #bitcoin-dev... bitcoin core can't do this
< meow> i was wondering if i wanted to test myself and make a simple bitcoin app that is a website which allows you to enter an address and then list all the addresses that have sent the given address bitcoin, how would i go about doing this at a high level?

2016-12-10

< bitcoin-git> [bitcoin] MarcoFalke closed pull request #9309: [qa] Wallet needs to stay unlocked for whole test (master...rarerpcfail) https://github.com/bitcoin/bitcoin/pull/9309
< bitcoin-git> bitcoin/master 76fcd9d MarcoFalke: Merge #9309: [qa] Wallet needs to stay unlocked for whole test...
< bitcoin-git> bitcoin/master 9359f8a Alex Morcos: Wallet needs to stay unlocked for whole test
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a1dcf2e1087b...76fcd9d50341
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #9316: [wallet] Disable free transactions when relay is disabled (master...Mf1612-sendFreeNo) https://github.com/bitcoin/bitcoin/pull/9316
< gribble> https://github.com/bitcoin/bitcoin/issues/9138 | Improve fee estimation by morcos · Pull Request #9138 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] rebroad opened pull request #9315: Request announcement by cmpctblock AFTER requesting cmpctblock/blocktxn (master...RequestAnnounceAfter) https://github.com/bitcoin/bitcoin/pull/9315
< bitcoin-git> [bitcoin] sipa closed pull request #9240: Remove txConflicted (master...removeTxConflicted) https://github.com/bitcoin/bitcoin/pull/9240
< bitcoin-git> bitcoin/master a1dcf2e Pieter Wuille: Merge #9240: Remove txConflicted...
< bitcoin-git> bitcoin/master a874ab5 Alex Morcos: remove internal tracking of mempool conflicts for reporting to wallet
< bitcoin-git> bitcoin/master bf663f8 Alex Morcos: remove external usage of mempool conflict tracking
< bitcoin-git> [bitcoin] sipa pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/d38b0d7a6b60...a1dcf2e1087b
< bitcoin-git> [bitcoin] sipa closed pull request #9307: Remove undefined FetchCoins method declaration (master...pr/coins-delfetch) https://github.com/bitcoin/bitcoin/pull/9307
< bitcoin-git> bitcoin/master d38b0d7 Pieter Wuille: Merge #9307: Remove undefined FetchCoins method declaration...
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/815640ec6af9...d38b0d7a6b60
< bitcoin-git> bitcoin/master fe41f58 Russell Yanofsky: Remove undefined FetchCoins method declaration
< bitcoin-git> bitcoin/master 815640e Pieter Wuille: Merge #9295: [Wallet] Bugfix: Fundrawtransaction: don't terminate when keypool is empty...
< bitcoin-git> [bitcoin] sipa closed pull request #9295: [Wallet] Bugfix: Fundrawtransaction: don't terminate when keypool is empty (master...2016/12/fix_frt) https://github.com/bitcoin/bitcoin/pull/9295
< bitcoin-git> bitcoin/master 1a6eacb Jonas Schnelli: [QA] add fundrawtransaction test on a locked wallet with empty keypool
< bitcoin-git> bitcoin/master c24a4f5 Jonas Schnelli: [Wallet] Bugfix: FRT: don't terminate when keypool is empty
< bitcoin-git> [bitcoin] sipa pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/72bf1b3d0962...815640ec6af9

2016-12-09

< gribble> https://github.com/bitcoin/bitcoin/issues/9290 | Make RelayWalletTransaction attempt to AcceptToMemoryPool. by gmaxwell · Pull Request #9290 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/6722 | Limit mempool by throwing away the cheapest txn and setting min relay fee to it by TheBlueMatt · Pull Request #6722 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] morcos opened pull request #9313: If we don't allow free txs, always send a fee filter (master...minminfee) https://github.com/bitcoin/bitcoin/pull/9313
< gribble> https://github.com/bitcoin/bitcoin/issues/9295 | An error has occurred and has been logged. Please contact this bot's administrator for more information.
< bitcoin-git> [bitcoin] morcos opened pull request #9312: Increase mempool expiry time to 2 weeks (master...longerexpiry) https://github.com/bitcoin/bitcoin/pull/9312
< gribble> https://github.com/bitcoin/bitcoin/issues/9167 | IsAllFromMe by morcos · Pull Request #9167 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] morcos opened pull request #9311: Flush wallet after abandontransaction (master...flushwalletonabandon) https://github.com/bitcoin/bitcoin/pull/9311
< bitcoin-git> [bitcoin] ryanofsky opened pull request #9310: Assert FRESH validity in CCoinsViewCache::BatchWrite (on top of #9308) (master...pr/coins-batch-assert) https://github.com/bitcoin/bitcoin/pull/9310
< bitcoin-git> [bitcoin] morcos opened pull request #9309: Spurious RPC test failure (master...rarerpcfail) https://github.com/bitcoin/bitcoin/pull/9309
< instagibbs> Teroxice, try #bitcoin
< achow101> bitcoin core does not have multiwallet support
< achow101> Teroxice: bitcore or bitcoin core? There is a difference.
< Teroxice> bitcoin core
< bitcoin-git> [bitcoin] ryanofsky opened pull request #9308: [test] Add CCoinsViewCache Access/Modify/Write tests (master...pr/coins-test) https://github.com/bitcoin/bitcoin/pull/9308
< bitcoin-git> [bitcoin] ryanofsky opened pull request #9307: [trivial] Remove undefined FetchCoins method declaration (master...pr/coins-delfetch) https://github.com/bitcoin/bitcoin/pull/9307
< bitcoin-git> [bitcoin] ryanofsky opened pull request #9306: Make CCoinsViewCache::Cursor() return latest data (master...pr/coins-cursor) https://github.com/bitcoin/bitcoin/pull/9306
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #9303: Update comments in ctaes (master...ctaes) https://github.com/bitcoin/bitcoin/pull/9303
< bitcoin-git> bitcoin/master 72bf1b3 MarcoFalke: Merge #9303: Update comments in ctaes...
< bitcoin-git> bitcoin/master 760765d Pieter Wuille: Update ctaes
< bitcoin-git> bitcoin/master 8501bed Pieter Wuille: Squashed 'src/crypto/ctaes/' changes from cd3c3ac..003a4ac...
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/86017842d6ef...72bf1b3d0962
< bitcoin-git> [bitcoin] kallewoof opened pull request #9305: Refactor: Removed begin/end_ptr functions. (master...remove-begin-end_ptr-usage) https://github.com/bitcoin/bitcoin/pull/9305
< bitcoin-git> [bitcoin] droark opened pull request #9304: Allow linearization scripts to support little endian hashes (master...master) https://github.com/bitcoin/bitcoin/pull/9304
< bitcoin-git> [bitcoin] sipa opened pull request #9303: Update comments in ctaes (master...ctaes) https://github.com/bitcoin/bitcoin/pull/9303

2016-12-08

< btcdrak> Can I scrounge some urgent review for https://github.com/bitcoin/libblkmaker/pull/6 please. It's required for some downstream miners for segwit.
< gribble> https://github.com/bitcoin/bitcoin/issues/9290 | Make RelayWalletTransaction attempt to AcceptToMemoryPool. by gmaxwell · Pull Request #9290 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sipa opened pull request #9302: Return txid even if ATMP fails for new transaction (master...failedtxid) https://github.com/bitcoin/bitcoin/pull/9302
< gribble> https://github.com/bitcoin/bitcoin/issues/9290 | Make RelayWalletTransaction attempt to AcceptToMemoryPool. by gmaxwell · Pull Request #9290 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9262 | Prefer coins that have fewer ancestors, sanity check txn before ATMP by instagibbs · Pull Request #9262 · bitcoin/bitcoin · GitHub
< gmaxwell> These things (and the open backport PR) are the only things I'm perosnally tracking for 0.13.2 (I made a call in #bitcoin this morning for bugreports against 0.13.1 with an eye towards getting 0.13.2 ready).
< gribble> https://github.com/bitcoin/bitcoin/issues/9262 | Prefer coins that have fewer ancestors, sanity check txn before ATMP by instagibbs · Pull Request #9262 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9290 | Make RelayWalletTransaction attempt to AcceptToMemoryPool. by gmaxwell · Pull Request #9290 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9290 | Make RelayWalletTransaction attempt to AcceptToMemoryPool. by gmaxwell · Pull Request #9290 · bitcoin/bitcoin · GitHub
< gmaxwell> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier
< gribble> https://github.com/bitcoin/bitcoin/issues/9023 | Add logging to bitcoin-util-test.py by jnewbery · Pull Request #9023 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/8837 | allow bitcoin-tx to parse partial transactions by jnewbery · Pull Request #8837 · bitcoin/bitcoin · GitHub
< morcos> btcdrak: maybe something to do with https://github.com/bitcoin/bitcoin/pull/9100 ?
< gribble> https://github.com/bitcoin/bitcoin/issues/7562 | Bump transaction version default to 2 by btcdrak · Pull Request #7562 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9053 | IBD using chainwork instead of height and not using header timestamps by gmaxwell · Pull Request #9053 · bitcoin/bitcoin · GitHub
< wumpus> BlueMatt: https://github.com/bitcoin/bitcoin/pull/9293 also there was some discussino here earlier
< bitcoin-git> bitcoin/0.13 5b93eee Gregory Maxwell: Remove GetTotalBlocksEstimate and checkpoint tests that test nothing....
< bitcoin-git> bitcoin/0.13 ad20cdd Gregory Maxwell: IBD check uses minimumchain work instead of checkpoints....
< bitcoin-git> bitcoin/0.13 4c71fc4 Matt Corallo: Remove duplicate nBlocksEstimate cmp (we already checked IsIBD())...
< bitcoin-git> [bitcoin] laanwj pushed 5 new commits to 0.13: https://github.com/bitcoin/bitcoin/compare/0a4aa876230c...e591c1049fe5
< wumpus> sipa: seed.bitcoin.sipa.be is not returning any results here
< bitcoin-git> [bitcoin] laanwj closed pull request #9291: Remove mapOrphanTransactionsByPrev from DoS_tests (master...reallyoneorphan) https://github.com/bitcoin/bitcoin/pull/9291
< bitcoin-git> bitcoin/master 8601784 Wladimir J. van der Laan: Merge #9291: Remove mapOrphanTransactionsByPrev from DoS_tests...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9851a8461d52...86017842d6ef
< bitcoin-git> bitcoin/master 819ca3f Pieter Wuille: Remove mapOrphanTransactionsByPrev from DoS_tests...
< bitcoin-git> [bitcoin] laanwj closed pull request #9255: qt: layoutAboutToChange signal is called layoutAboutToBeChanged (master...2016_12_qt_signals_warnings) https://github.com/bitcoin/bitcoin/pull/9255
< bitcoin-git> bitcoin/master f36349e Wladimir J. van der Laan: qt: Remove on_toggleNetworkActiveButton_clicked from RPCConsole...
< bitcoin-git> bitcoin/master 9851a84 Wladimir J. van der Laan: Merge #9255: qt: layoutAboutToChange signal is called layoutAboutToBeChanged...
< bitcoin-git> bitcoin/master 297cc20 Wladimir J. van der Laan: qt: layoutAboutToChange signal is called layoutAboutToBeChanged...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/2044e37bebc6...9851a8461d52
< bitcoin-git> [bitcoin] laanwj closed pull request #9266: Bugfix: Qt/RPCConsole: Put column enum in the right places (master...bugfix_datarole) https://github.com/bitcoin/bitcoin/pull/9266
< bitcoin-git> bitcoin/master 2044e37 Wladimir J. van der Laan: Merge #9266: Bugfix: Qt/RPCConsole: Put column enum in the right places...
< bitcoin-git> bitcoin/master df17fe0 Luke Dashjr: Bugfix: Qt/RPCConsole: Put column enum in the right places...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d52ce89bd220...2044e37bebc6
< bitcoin-git> [bitcoin] laanwj closed pull request #9299: Remove no longer needed check for premature v2 txs (master...morev2txstuff) https://github.com/bitcoin/bitcoin/pull/9299
< bitcoin-git> bitcoin/master d52ce89 Wladimir J. van der Laan: Merge #9299: Remove no longer needed check for premature v2 txs...
< bitcoin-git> bitcoin/master b919179 Alex Morcos: remove no longer needed check for premature v2 txs
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ea33f197ef1e...d52ce89bd220
< bitcoin-git> [bitcoin] laanwj closed pull request #9276: Some minor testing cleanups (master...rpccleanup) https://github.com/bitcoin/bitcoin/pull/9276
< bitcoin-git> bitcoin/master 30b620c Alex Morcos: remove obsolete run-bitcoind-for-test.sh
< bitcoin-git> bitcoin/master 2a99522 Alex Morcos: remove relaypriority from rpc tests
< bitcoin-git> bitcoin/master e2184cc Alex Morcos: Reorder RPC tests for running time
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/09c4fd157c5b...ea33f197ef1e
< bitcoin-git> [bitcoin] rebroad opened pull request #9300: Check for oversized getblocktxn message. (master...CheckOversizedGetblocktxns) https://github.com/bitcoin/bitcoin/pull/9300

2016-12-07

< sipa> btcdrak: did you run the bitcoin-tx tests?
< btcdrak> can someone restart https://travis-ci.org/bitcoin/bitcoin/builds/182083275 please?
< bitcoin-git> [bitcoin] morcos opened pull request #9299: Remove no longer needed check for premature v2 txs (master...morev2txstuff) https://github.com/bitcoin/bitcoin/pull/9299
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #9298: [Wallet] use CHDPubKey, don't store child priv keys in db, derive on the fly (master...2016/12/hd_no_priv) https://github.com/bitcoin/bitcoin/pull/9298
< bitcoin-git> [bitcoin] gmaxwell closed pull request #9286: Time-based expiration in LimitOrphanTxSize only when map is full. (master...defer_orphan_exp) https://github.com/bitcoin/bitcoin/pull/9286

2016-12-06

< bitcoin-git> [bitcoin] Mirobit opened pull request #9297: Various RPC help outputs updated (master...rpchelp12/16) https://github.com/bitcoin/bitcoin/pull/9297
< bitcoin-git> [bitcoin] sipa closed pull request #9268: Fix rounding privacy leak introduced in #9260 (master...2016-12-feefilterrounder) https://github.com/bitcoin/bitcoin/pull/9268
< bitcoin-git> bitcoin/master 09c4fd1 Pieter Wuille: Merge #9268: Fix rounding privacy leak introduced in #9260...
< bitcoin-git> bitcoin/master 9b9324e Matt Corallo: Fix rounding privacy leak introduced in #9260
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/fde7d99c4d7d...09c4fd157c5b
< Chris_Stewart_5> sipa: re: yesterdays convo about syncing, seems like another guy had a similar experience that I did in #bitcoin, not sure if this is a concern or not
< bitcoin-git> [bitcoin] laanwj closed pull request #9296: Fix missed change to WalletTx structure (master...fixwallettx) https://github.com/bitcoin/bitcoin/pull/9296
< bitcoin-git> bitcoin/master 28f8ae8 Alex Morcos: Fix missed change to WalletTx structure
< bitcoin-git> bitcoin/master fde7d99 Wladimir J. van der Laan: Merge #9296: Fix missed change to WalletTx structure...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e15660c16f75...fde7d99c4d7d
< jonasschnelli> But lets first fix Bitcoin
< gribble> https://github.com/bitcoin/bitcoin/issues/8501 | Add mempool statistics collector by jonasschnelli · Pull Request #8501 · bitcoin/bitcoin · GitHub
< jonasschnelli> MarcoFalke: Oops, I think i change the tags you made on https://github.com/bitcoin/bitcoin/pull/9295
< bitcoin-git> [bitcoin] morcos opened pull request #9296: Fix missed change to WalletTx structure (master...fixwallettx) https://github.com/bitcoin/bitcoin/pull/9296
< gribble> https://github.com/bitcoin/bitcoin/issues/8580 | Make CTransaction actually immutable by sipa · Pull Request #8580 · bitcoin/bitcoin · GitHub
< MarcoFalke> I can't send any coins: bitcoin-qt: ./primitives/transaction.h:331: void SerializeTransaction(const TxType&, Stream&) [with Stream = CDataStream; TxType = CTransaction]: Assertion `tx.wit.vtxinwit.size() <= tx.vin.size()' failed.
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #9295: [Wallet] Bugfix: Fundrawtransaction: don't terminate when keypool is empty (master...2016/12/fix_frt) https://github.com/bitcoin/bitcoin/pull/9295
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #9280: [Qt] Show ModalOverlay by pressing the progress bar, allow hiding (master...2016/12/qt_modal) https://github.com/bitcoin/bitcoin/pull/9280
< bitcoin-git> bitcoin/master e15660c Jonas Schnelli: Merge #9280: [Qt] Show ModalOverlay by pressing the progress bar, allow hiding...
< bitcoin-git> bitcoin/master 89a3723 Jonas Schnelli: [Qt] Show ModalOverlay by pressing the progress bar, disabled show() in sync mode
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/919db037f1f5...e15660c16f75
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #9274: [qa] Use cached utxo set to fix performance regression (master...Mf1612-qaPruningCacheUtxos) https://github.com/bitcoin/bitcoin/pull/9274
< bitcoin-git> bitcoin/master 919db03 MarcoFalke: Merge #9274: [qa] Use cached utxo set to fix performance regression...
< bitcoin-git> bitcoin/master fa2ecc4 MarcoFalke: [qa] pruning: Use cached utxo set to run faster
< bitcoin-git> bitcoin/master fab1af3 MarcoFalke: [qa] maxuploadtarget: Use cached utxo set
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/ed8d693c71b0...919db037f1f5
< wumpus> MarcoFalke: I've invited him to bitcoin and bitcoin-core (as read-only member), team page should still be updated
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #7685: Add bloom filter usage statistics (master...2016/03/bf_stats) https://github.com/bitcoin/bitcoin/pull/7685
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #8182: [Qt] Add simple opt-in-RBF support (master...2016/04/qt_rbf_set_new) https://github.com/bitcoin/bitcoin/pull/8182
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #9238: Ignore BIP35 mempool command by default (master...2016/11/dis_mempool) https://github.com/bitcoin/bitcoin/pull/9238
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #9294: Use internal HD chain for change outputs (hd split) (master...2016/12/hd_split) https://github.com/bitcoin/bitcoin/pull/9294
< bitcoin-git> [bitcoin] gmaxwell opened pull request #9293: [0.13 Backport] IBD using chainwork instead of height and not using header timestamp (#9053) (0.13...9053_backport) https://github.com/bitcoin/bitcoin/pull/9293
< bitcoin-git> [bitcoin] sipa opened pull request #9292: Complain when unknown rpcserialversion is specified (master...nofutureserial) https://github.com/bitcoin/bitcoin/pull/9292
< gribble> https://github.com/bitcoin/bitcoin/issues/9194 | Add option to return non-segwit serialization via rpc by instagibbs · Pull Request #9194 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #9194: Add option to return non-segwit serialization via rpc (master...nonswserialrpc) https://github.com/bitcoin/bitcoin/pull/9194
< bitcoin-git> bitcoin/master ed8d693 Wladimir J. van der Laan: Merge #9194: Add option to return non-segwit serialization via rpc...
< bitcoin-git> bitcoin/master 412bab2 instagibbs: Adapt ZMQ/rest serialization to take rpcserialversion arg
< bitcoin-git> bitcoin/master bc7ff8d Gregory Sanders: Add option to return non-segwit serialization via rpc
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/7d5d44969b4a...ed8d693c71b0
< jonasschnelli> ref: [18:40:09] <morcos:#bitcoin-core-dev> jonasschnelli: you around?
< jonasschnelli> <*highlight>[18:40:09] <morcos:#bitcoin-core-dev> jonasschnelli: you around?
< gmaxwell> TD-Linux: was telling me recently he planned on having an actual RiscV chip soon... but not one that would be anywhere near powerful enough to run bitcoin core. :P
< gribble> https://github.com/bitcoin/bitcoin/issues/9053 | IBD using chainwork instead of height and not using header timestamps by gmaxwell · Pull Request #9053 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sipa opened pull request #9291: Remove mapOrphanTransactionsByPrev from DoS_tests (master...reallyoneorphan) https://github.com/bitcoin/bitcoin/pull/9291
< bitcoin-git> [bitcoin] gmaxwell opened pull request #9290: Make RelayWalletTransaction attempt to AcceptToMemoryPool. (master...resend_retries_mempool) https://github.com/bitcoin/bitcoin/pull/9290
< wumpus> so did anyone compile bitcoin for risc-v yet? :)
< bitcoin-git> [bitcoin] theuni opened pull request #9289: net: drop boost::thread_group (master...connman-threads) https://github.com/bitcoin/bitcoin/pull/9289
< bitcoin-git> [bitcoin] theuni closed pull request #8631: Nuke boost::thread and boost::thread_group (master...no-interrupt-threads) https://github.com/bitcoin/bitcoin/pull/8631
< bitcoin-git> [bitcoin] morcos opened pull request #9288: Fix a bug if the min fee is 0 for FeeFilterRounder (master...fixFFRbug) https://github.com/bitcoin/bitcoin/pull/9288
< gmaxwell> sipa: thoughts on merging https://github.com/bitcoin/bitcoin/pull/9268 to unbust master while the actual algorithim here gets fixed?
< dcousens> rm -rf ~/.bitcoin, git clean -xdf, ./autogen.sh, ./configure --disable-bench --disable-tests --disable-wallet --without-miniupnpc, make -j4, ./src/bitcoind -minrelaytxfee=0.00000001 ---- that was my previous steps, I'm retrying them now
< gmaxwell> (takes like 15 minutes to comile bitcoin on my laptop)
< dcousens> like, fresh compile, fresh .bitcoin, deadlocks on -minrelaytxfee=0.00000001
< dcousens> scratch that, still happens on a fresh .bitcoin :) (yay)
< dcousens> OK, interestingly this doesn't happen on a fresh .bitcoin (tried locally)
< bitcoin-git> [bitcoin] gmaxwell opened pull request #9286: Time-based expiration in LimitOrphanTxSize only when map is full. (master...defer_orphan_exp) https://github.com/bitcoin/bitcoin/pull/9286

2016-12-05

< gmaxwell> on *nix: ps aux | grep bitcoin to get the bitcoind pid then gdb -p <pid> to attach. then run thread apply all bt full to get backtraces from every thread, and 0bin that to me, and then you can type q<enter> to quit
< gribble> https://github.com/bitcoin/bitcoin/issues/8501 | Add mempool statistics collector by jonasschnelli · Pull Request #8501 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #9284: Suppress some annoying deprecation warnings (OSX) (master...2016/12/osx_warnings) https://github.com/bitcoin/bitcoin/pull/9284
< bitcoin-git> [bitcoin] laanwj closed pull request #9282: CMutableTransaction is defined as struct (master...20161205_CMutableTransaction_is_struct) https://github.com/bitcoin/bitcoin/pull/9282
< bitcoin-git> bitcoin/master 7d5d449 Wladimir J. van der Laan: Merge #9282: CMutableTransaction is defined as struct...
< bitcoin-git> bitcoin/master c4b6fa8 Pavel Janík: CMutableTransaction is defined as struct.
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c01f16aaa0ed...7d5d44969b4a
< bitcoin-git> [bitcoin] laanwj closed pull request #9165: SendMoney: use already-calculated balance (master...triv-curbal) https://github.com/bitcoin/bitcoin/pull/9165
< bitcoin-git> bitcoin/master c01f16a Wladimir J. van der Laan: Merge #9165: SendMoney: use already-calculated balance...
< bitcoin-git> bitcoin/master ea83d00 instagibbs: SendMoney: use already-calculated balance
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/43e8150ef690...c01f16aaa0ed
< bitcoin-git> [bitcoin] sipa opened pull request #9283: A few more CTransactionRef optimizations (master...sharedblock2) https://github.com/bitcoin/bitcoin/pull/9283
< bitcoin-git> [bitcoin] paveljanik opened pull request #9282: CMutableTransaction is defined as struct (master...20161205_CMutableTransaction_is_struct) https://github.com/bitcoin/bitcoin/pull/9282
< bitcoin-git> [bitcoin] laanwj closed pull request #9269: Align struct COrphan definition (master...oneorphan) https://github.com/bitcoin/bitcoin/pull/9269
< bitcoin-git> bitcoin/master 43e8150 Wladimir J. van der Laan: Merge #9269: Align struct COrphan definition...
< bitcoin-git> bitcoin/master 2efc438 Pieter Wuille: Align struct COrphan definition
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/613bda418f83...43e8150ef690
< bitcoin-git> bitcoin/master 613bda4 Wladimir J. van der Laan: Merge #8613: LevelDB 1.19...
< bitcoin-git> bitcoin/master 605d701 Pieter Wuille: Merge in LevelDB 1.19 changes
< bitcoin-git> bitcoin/master 634ad51 Pieter Wuille: Squashed 'src/leveldb/' changes from 20ca81f..a31c8aa...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/d04aebaec7bb...613bda418f83
< bitcoin-git> [bitcoin] kallewoof opened pull request #9281: Refactor: Removed using namespace <xxx> from bench/ & test/ sources (master...no-using-namespace-bench-test) https://github.com/bitcoin/bitcoin/pull/9281
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #9280: [Qt] Show ModalOverlay by pressing the progress bar, allow hiding (master...2016/12/qt_modal) https://github.com/bitcoin/bitcoin/pull/9280
< bitcoin-git> [bitcoin] laanwj closed pull request #9014: Fix block-connection performance regression (master...2016-10-fix-tx-regression) https://github.com/bitcoin/bitcoin/pull/9014
< bitcoin-git> bitcoin/master ae4db44 Matt Corallo: Create a shared_ptr for the block we're connecting in ActivateBCS
< bitcoin-git> bitcoin/master 6fdd43b Matt Corallo: Add struct to track block-connect-time-generated info for callbacks
< bitcoin-git> bitcoin/master fd9d890 Matt Corallo: Keep blocks as shared_ptrs, instead of copying txn in ConnectTip
< bitcoin-git> [bitcoin] laanwj pushed 7 new commits to master: https://github.com/bitcoin/bitcoin/compare/46904ee5d2ce...d04aebaec7bb
< bitcoin-git> bitcoin/master c3f5673 Pieter Wuille: Make CWalletTx store a CTransactionRef instead of inheriting
< bitcoin-git> bitcoin/master 42fd8de Pieter Wuille: Make DecodeHexTx return a CMutableTransaction
< bitcoin-git> bitcoin/master a188353 Pieter Wuille: Switch GetTransaction to returning a CTransactionRef
< bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/4d955fc5824b...46904ee5d2ce
< bitcoin-git> [bitcoin] jtimon closed pull request #7820: Consensus: Policy: Move CFeeRate out of consensus module and create CPolicy interface (master...0.12.99-consensus-dust-out) https://github.com/bitcoin/bitcoin/pull/7820
< bitcoin-git> [bitcoin] jtimon opened pull request #9279: Consensus: Move CFeeRate out of libconsensus (master...0.13-consensus-dust-out-minimal) https://github.com/bitcoin/bitcoin/pull/9279
< sipa> essentially, i think we should first introduce clean abstractions between certain modules inside bitcoin core, in such a way that it's effectively bitcoind using a consensus library already, without it being exposed
< jtimon> even if we only expose the version with our implementation, I think it would be good to abstract consensus storage even for bitcoin core rewardless of libconsensus users
< gmaxwell> I just feel that the purpose of these changes is no longer clear. Expecting the user to implement complex interfaces with bitcoin specific and consensus critical behavior is at odds with what I understood to be the stated goal.

2016-12-04

< bitcoin-git> [bitcoin] MarcoFalke closed pull request #9277: clear typo "skipepd" changed to "skipped" (master...patch-12) https://github.com/bitcoin/bitcoin/pull/9277
< bitcoin-git> [bitcoin] s-matthew-english opened pull request #9277: clear typo "skipepd" changed to "skipped" (master...patch-12) https://github.com/bitcoin/bitcoin/pull/9277
< gribble> https://github.com/bitcoin/bitcoin/issues/7779 | An error has occurred and has been logged. Please contact this bot's administrator for more information.
< jtimon> regarding the validation flags, I replaced #7779 with https://github.com/bitcoin/bitcoin/pull/9271 (although got errors in unittests because we're already relying on the consensus flags being coupled for testing it seems)
< jtimon> and the way I implemented it there, is also inneficient for bitcoin core
< jtimon> this kind of thing (for the abstracted storage) is disruptive though https://github.com/bitcoin/bitcoin/pull/8493/commits/0a1ff996c5db5265742e3e90f3690a0b8d9cf045
< jtimon> btw, as always comments on https://github.com/bitcoin/bitcoin/pull/8493 welcomed
< gmaxwell> so long as the requirements are very clear and simple... where no bitcoin specific understanding is required... sure. though doing that without breaking efficiency might be hard.
< jtimon> providing a wrapper that includes the same storage as bitcoin core, as an extended library should be easy
< jtimon> but bitcoin core is currently way more than that, so...
< bitcoin-git> [bitcoin] morcos opened pull request #9276: Some minor testing cleanups (master...rpccleanup) https://github.com/bitcoin/bitcoin/pull/9276
< BlueMatt> well once the bitcoin core codebase "eats its own dogfood", as it were, we can take the storage layer we have and expose that optionally
< BlueMatt> jtimon: essentially, yes, PNB, PNBH, some initialization api (see https://github.com/TheBlueMatt/bitcoin/blob/2016-12-cconsensus/src/validation.cpp#L80) and a utxo-state-accessor/loadblock-accessor api
< bitcoin-git> bitcoin/master 4d955fc Jonas Schnelli: Merge #9218: qt: Show progress overlay when clicking spinner icon...
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #9218: qt: Show progress overlay when clicking spinner icon (master...2016_11_overlay_when_clicking_sync_icon) https://github.com/bitcoin/bitcoin/pull/9218
< bitcoin-git> bitcoin/master 042f9fa Wladimir J. van der Laan: qt: Show progress overlay when clicking spinner icon...
< bitcoin-git> bitcoin/master 827d9a3 Wladimir J. van der Laan: qt: Replace NetworkToggleStatusBarControl with generic ClickableLabel...
< bitcoin-git> [bitcoin] jonasschnelli pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/2efcfa5acfac...4d955fc5824b
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #9274: [qa] pruning: Use cached utxo set to run faster (master...Mf1612-qaPruningCacheUtxos) https://github.com/bitcoin/bitcoin/pull/9274
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #9273: Remove unused CDiskBlockPos* argument from ProcessNewBlock (master...2016-12-remove-unused-pnb-param) https://github.com/bitcoin/bitcoin/pull/9273

2016-12-03

< bitcoin-git> [bitcoin] jtimon closed pull request #7779: Discussion: Consensus: There's only one type of consensus flags (master...0.12.99-consensus-unify-flags) https://github.com/bitcoin/bitcoin/pull/7779
< wumpus> strange, bitcoin-git shows the close notice but not the merge on the 0.13 branch
< bitcoin-git> [bitcoin] laanwj closed pull request #9267: Disable fee estimates for a confirm target of 1 block (0.13...backport9239) https://github.com/bitcoin/bitcoin/pull/9267
< bitcoin-git> [bitcoin] jtimon reopened pull request #9271: Discusion : 0.13 consensus flags error (master...0.13-consensus-flags-error) https://github.com/bitcoin/bitcoin/pull/9271
< bitcoin-git> [bitcoin] jtimon closed pull request #9271: Discusion : 0.13 consensus flags error (master...0.13-consensus-flags-error) https://github.com/bitcoin/bitcoin/pull/9271