<bitcoin-git>
[bitcoin] apoelstra opened pull request #27337: wallet: allow importing descriptors that have no xprivs, even in a privkey-enabled wallet (master...2023-03--wallet-error) https://github.com/bitcoin/bitcoin/pull/27337
<bitcoin-git>
[bitcoin] martinus closed pull request #23169: fix initialization in FastRandomContext: removes undefined behavior & uninitialized read (master...2021-10-fix-Wmaybe-uninitialized-warnings) https://github.com/bitcoin/bitcoin/pull/23169
<bitcoin-git>
[bitcoin] martinus opened pull request #27334: util: implement `noexcept` move assignment & move ctor for `prevector` (master...2023-03-prevector-move) https://github.com/bitcoin/bitcoin/pull/27334
<martinus>
In prevector.h, the destructor calls "_union.indirect_contents.indirect = nullptr;". Any particular reason why this is done? It's done that ever since https://github.com/bitcoin/bitcoin/pull/6914/ was merged in 2015
<bitcoin-git>
[bitcoin] vstoyanov opened pull request #27333: ci: cleanup of CI_EXEC & CI_EXEC_ROOT (refs #27321) (master...bitcoin#27321) https://github.com/bitcoin/bitcoin/pull/27333
<bitcoin-git>
[bitcoin] aureleoules closed pull request #26858: wallet: Use defined purposes instead of inlining (master...2023-01-purpose-refactor) https://github.com/bitcoin/bitcoin/pull/26858
2023-03-25
<_aj_>
andytoshi: char s[7] = "bitcoin"; errors with "initializer-string for char array is too long" in c++ apparently
<andytoshi>
i suspect it's a bit more subtle ... if you do `unsigned char s[8s = "bitcoin";` it'll include the terminator. if you do `unsigned char s[7] = "bitcoin"` it'll silently chop it off .. if you do `unsigned char s[] = "bitcoin"` it'll include it, same as [8]
<andytoshi>
i was searching for 'Bitcoin seed' but the code uses {'B','i','t','c','o','i','n',' ','s','e','e','d'}
<andytoshi>
does bitcoin core do the "Master key generation" described in BIP 32 anywhere?
<bitcoin-git>
[bitcoin] martinus opened pull request #27331: refactor: extract CCheckQueue's data handling into a separate container "Bag" (master...2023-03-bag) https://github.com/bitcoin/bitcoin/pull/27331
<bitcoin-git>
[bitcoin] pinheadmz closed pull request #27327: I want more bitcoins! Haven't had time to buy at $0.2 😒 (master...patch-1) https://github.com/bitcoin/bitcoin/pull/27327
<bitcoin-git>
[bitcoin] SValentyn opened pull request #27327: I want more bitcoins! Haven't had time to buy at $0.2 😒 (master...patch-1) https://github.com/bitcoin/bitcoin/pull/27327
<bitcoin-git>
[bitcoin] fanquake opened pull request #27326: guix: combine and document `enable_werror` (master...guix_glibc_simplify_werror) https://github.com/bitcoin/bitcoin/pull/27326
<bitcoin-git>
[bitcoin] theStack opened pull request #27325: test: various `converttopsbt` check cleanups in rpc_psbt.py (master...test_psbt_cleanups) https://github.com/bitcoin/bitcoin/pull/27325
<bitcoin-git>
[bitcoin] jonatack opened pull request #27322: move-only: IsDeprecatedRPCEnabled to rpc/util to fix CI builds when called from wallet (master...2023-03-fix-IsDeprecatedRPCEnabled-build-errors) https://github.com/bitcoin/bitcoin/pull/27322
<bitcoin-git>
[bitcoin] fanquake merged pull request #27028: ci: Cache more stuff in the ci images: msan, iwyu, pip, sdks (master...2301-ci-cache-apt-🚴) https://github.com/bitcoin/bitcoin/pull/27028
<bitcoin-git>
[bitcoin] john-moffett opened pull request #27317: log: Check that the timestamp string is non-empty to avoid undefined behavior (master...2023_04_FixTimestampPotentialUB) https://github.com/bitcoin/bitcoin/pull/27317
<bitcoin-git>
[bitcoin] fanquake closed pull request #26296: [DEMO] Integrate `bitcoin-tidy` clang-tidy plugin - warn on uninitialized members of aggregate types (master...integrate_cory_tidy) https://github.com/bitcoin/bitcoin/pull/26296
<bitcoin-git>
[bitcoin] hebasto opened pull request #27314: build, qt: Fix handling of `CXX=clang++` when building `qt` package (master...230323-qt-clang) https://github.com/bitcoin/bitcoin/pull/27314
<ezero>
Is this the right channel to get some help with compiler errors when attempting to build bitcoin-core or should I use bitcoin-core-builds for that?
2023-03-22
<bitcoin-git>
[bitcoin] achow101 opened pull request #27308: bumpfee: avoid making bumped transactions with too low fee when replacing outputs (master...fix-bumpfee-replaced-outputs-fee-calc) https://github.com/bitcoin/bitcoin/pull/27308
<bitcoin-git>
[bitcoin] ishaanam opened pull request #27307: wallet: track mempool conflicts with wallet transactions (master...track_mempool_wallet_conflicts) https://github.com/bitcoin/bitcoin/pull/27307
<bitcoin-git>
[bitcoin] pinheadmz opened pull request #27303: system: cache config file path before potentially updating datadir (master...cache-conf-file) https://github.com/bitcoin/bitcoin/pull/27303
<bitcoin-git>
[bitcoin] ryanofsky opened pull request #27302: init: Error if ignored bitcoin.conf file is found (master...pr/ignoredconf) https://github.com/bitcoin/bitcoin/pull/27302
<bitcoin-git>
[bitcoin] achow101 merged pull request #27271: RPC: Fix fund transaction crash when at 0-value, 0-fee (master...empty_value_crash) https://github.com/bitcoin/bitcoin/pull/27271
<bitcoin-git>
bitcoin/master fc7c21f Andrew Chow: Merge bitcoin/bitcoin#27271: RPC: Fix fund transaction crash when at 0-val...
<bitcoin-git>
[bitcoin] brunoerg opened pull request #27295: test: add support for all networks in `deserialize_v2` (master...2023-03-improv-deserialize-v2) https://github.com/bitcoin/bitcoin/pull/27295
<ariard>
Thanks for the confirmation than Chaincode has issued the letter. And what is the proper use of the bitcoin-core-dev it should be evaluated in the light of ~10y of chan existence - In the past it has been used to chat about blurring of private/public issues. E.g bip editorship during taproot drama.
<bitcoin-git>
[bitcoin] TheCharlatan opened pull request #27294: refactor: Move chain names to the kernel namespace (master...kernelChainName) https://github.com/bitcoin/bitcoin/pull/27294
<michaelfolkson>
ajonas: So it *is* a legal firm representing Chaincode I'm assuming from that. Is there another IRC channel that you'd prefer to discuss it on? #bitcoin-dev?
<ajonas>
We don't believe this is a proper use of the bitcoin-core-dev channel, and nothing is preventing ariard from engaging with Chaincode employees in an appropriate and professional manner.
<bitcoin-git>
[bitcoin] instagibbs closed pull request #26398: Replace MIN_STANDARD_TX_NONWITNESS_SIZE to preclude 64 non-witness bytes only (master...relax_too_small_tx_equality) https://github.com/bitcoin/bitcoin/pull/26398
2023-03-20
<bitcoin-git>
[bitcoin] achow101 opened pull request #27286: wallet: Keep track of the wallet's own transaction outputs in memory (master...wallet-txos) https://github.com/bitcoin/bitcoin/pull/27286
<bitcoin-git>
[bitcoin] hebasto closed pull request #27285: build: Link `libbitcoinkernel` to `libbitcoin_util` (master...230320-util) https://github.com/bitcoin/bitcoin/pull/27285
<bitcoin-git>
[bitcoin] hebasto opened pull request #27285: build: Link `libbitcoinkernel` to `libbitcoin_util` (master...230320-util) https://github.com/bitcoin/bitcoin/pull/27285
<achow101>
I saw in #bitcoin that you said you saw only one inactivehdseed when you did dumpwallet, so the wallet definitely is detecting it
<bitcoin-git>
[bitcoin] instagibbs opened pull request #27271: Fix fund transaction case at 0-value, 0-fee (master...empty_value_crash) https://github.com/bitcoin/bitcoin/pull/27271
<bitcoin-git>
bitcoin/master e194e3e Sebastian Falbesoner: test: PSBT: eliminate magic numbers for global unsigned tx key (0)
<bitcoin-git>
bitcoin/master dd78e3f Sebastian Falbesoner: test: speedup rpc_psbt.py by whitelisting peers (immediate tx relay)
<sipa>
Also yes bitcoin.conf can override it, and the GUI settings perhaps too (unsure about this).
<bugs_>
unless there is an entry in bitcoin.conf for dbcache
<ajonas>
#proposedmeetingtopic annual bitcoin core dev survey
<bitcoin-git>
[gui] hernanmarino opened pull request #722: Wallet : Allow user to navigate options while encrypting at creation (master...wallet-encryption-navigation) https://github.com/bitcoin-core/gui/pull/722
<bitcoin-git>
[bitcoin] dergoegge opened pull request #27270: refactor, net processing: Avoid CNode::m_relays_txs usage (master...2023-03-no-cnode-txrelays) https://github.com/bitcoin/bitcoin/pull/27270
<bitcoin-git>
[bitcoin] stratospher opened pull request #27264: p2p: Improve diversification of new connections (master...p2p-diverse-new-conn) https://github.com/bitcoin/bitcoin/pull/27264
<bitcoin-git>
[bitcoin] pinheadmz closed pull request #27263: logging: accept "none" as argument for rpc logging (master...logging-none) https://github.com/bitcoin/bitcoin/pull/27263
<bitcoin-git>
[bitcoin] pinheadmz opened pull request #27263: logging: accept "none" as argument for rpc logging (master...logging-none) https://github.com/bitcoin/bitcoin/pull/27263
<bitcoin-git>
[gui] rebroad opened pull request #720: Correct poor grammar in wallet synchronization warning. (master...UpdateSyncWarningText) https://github.com/bitcoin-core/gui/pull/720
<bitcoin-git>
[bitcoin] dergoegge opened pull request #27257: refactor, net: End friendship of CNode, CConnman and ConnmanTestMsg (master...2023-03-cnode-friends) https://github.com/bitcoin/bitcoin/pull/27257