2022-12-29

<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/4654506c3014...b9028b2e263a
<bitcoin-git> bitcoin/master 4dbcdf2 Hennadii Stepanov: bench: Suppress output when running with `-sanity-check` option
<bitcoin-git> bitcoin/master f1e8959 Hennadii Stepanov: test: Drop no longer required bench output redirection
<bitcoin-git> bitcoin/master b9028b2 MarcoFalke: Merge bitcoin/bitcoin#26481: bench: Suppress output when running with `-sa...

2022-12-28

<bitcoin-git> [bitcoin] hebasto opened pull request #26766: ci: Use clang-15 and IWYU v0.19 in "tidy" task (master...221228-clang15) https://github.com/bitcoin/bitcoin/pull/26766
<bitcoin-git> [bitcoin] hebasto closed pull request #26759: test: Drop no longer needed `race:epoll_ctl` TSan suppression (master...221227-epoll) https://github.com/bitcoin/bitcoin/pull/26759
<bitcoin-git> [bitcoin] andrewtoth closed pull request #26755: p2p: cache compact block message to use for low bandwidth CMPCT_BLOCK (master...cache-cmpctblk-msg) https://github.com/bitcoin/bitcoin/pull/26755
<bitcoin-git> [bitcoin] hebasto opened pull request #26763: ci: Treat IWYU violations as errors (master...221228-iwyu) https://github.com/bitcoin/bitcoin/pull/26763
<bitcoin-git> bitcoin/master a3f5e54 Hennadii Stepanov: test: Drop no longer needed `race:epoll_ctl` TSan suppression
<bitcoin-git> bitcoin/master 4654506 MarcoFalke: Merge bitcoin/bitcoin#26759: test: Drop no longer needed `race:epoll_ctl` ...
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e9262ea32a6e...4654506c3014
<bitcoin-git> [gui] hernanmarino opened pull request #692: GUI: Debug Console implementation of generate method (master...generate-gui-console) https://github.com/bitcoin-core/gui/pull/692
<bitcoin-git> [bitcoin] hebasto opened pull request #26762: refactor: Make `CCheckQueue` RAII-styled (master...221228-queue) https://github.com/bitcoin/bitcoin/pull/26762
<bitcoin-git> [bitcoin] theStack opened pull request #26761: wallet: fully migrate address book entries for watchonly/solvable wallets (master...202212-migratewallet_persist_addressbook) https://github.com/bitcoin/bitcoin/pull/26761

2022-12-27

<bitcoin-git> [bitcoin] hebasto opened pull request #26759: test: Drop no longer needed `race:epoll_ctl` TSan suppression (master...221227-epoll) https://github.com/bitcoin/bitcoin/pull/26759
<bitcoin-git> [bitcoin] hebasto opened pull request #26758: clang-tidy: Add `performance-no-automatic-move` check (master...221227-tidy-nam) https://github.com/bitcoin/bitcoin/pull/26758
<bitcoin-git> [bitcoin] w0xlt opened pull request #26756: wallet: Replace `GetBalance()` logic with `AvailableCoins()` (master...balance_coin_selection) https://github.com/bitcoin/bitcoin/pull/26756

2022-12-26

<bitcoin-git> [bitcoin] andrewtoth opened pull request #26755: p2p: cache compact block message to use for low bandwidth CMPCT_BLOCK (master...cache-cmpctblk-msg) https://github.com/bitcoin/bitcoin/pull/26755
<bitcoin-git> [gui] furszy opened pull request #690: bugfix, catch invalid networks combination crash (master...2022_gui_catch_netparam_crash) https://github.com/bitcoin-core/gui/pull/690
<bitcoin-git> [bitcoin] w0xlt opened pull request #26752: wallet: Remove `mempool_sequence` from interface methods (master...remove_mempool_sequence) https://github.com/bitcoin/bitcoin/pull/26752

2022-12-25

<bitcoin-git> [bitcoin] MarcoFalke merged pull request #26750: Insert and bump copyright headers (master...221225-copyright) https://github.com/bitcoin/bitcoin/pull/26750
<bitcoin-git> bitcoin/master e9262ea MarcoFalke: Merge bitcoin/bitcoin#26750: Insert and bump copyright headers
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/06dd571534c8...e9262ea32a6e
<bitcoin-git> bitcoin/master 306ccd4 Hennadii Stepanov: scripted-diff: Bump copyright headers
<bitcoin-git> bitcoin/master 3ae76ea Hennadii Stepanov: scripted-diff: Insert missed copyright header
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #26748: doc: Update license year range to 2023 (master...year-2023) https://github.com/bitcoin/bitcoin/pull/26748
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f3bc1a72825f...06dd571534c8
<bitcoin-git> bitcoin/master e9abb13 Suriyaa Sundararuban: doc: Update license year range to 2023
<bitcoin-git> bitcoin/master 06dd571 MarcoFalke: Merge bitcoin/bitcoin#26748: doc: Update license year range to 2023
<bitcoin-git> [bitcoin] hebasto opened pull request #26750: Insert and bump copyright headers (master...221225-copyright) https://github.com/bitcoin/bitcoin/pull/26750

2022-12-24

<bitcoin-git> [bitcoin] hebasto opened pull request #26749: refactor: Use move semanitcs in favour of custom swap functions (master...221224-move) https://github.com/bitcoin/bitcoin/pull/26749
<bitcoin-git> [bitcoin] suriyaa opened pull request #26748: doc: Update license year range to 2023 (master...year-2023) https://github.com/bitcoin/bitcoin/pull/26748

2022-12-23

<bitcoin-git> [bitcoin] fanquake pushed 2 commits to 24.x: https://github.com/bitcoin/bitcoin/compare/b3f866a8dfd6...0da38b6b0e74
<bitcoin-git> bitcoin/24.x 0662105 Andrew Chow: qt: Load PSBTs using istreambuf_iterator rather than istream_iterator
<bitcoin-git> bitcoin/24.x 0da38b6 fanquake: Merge bitcoin/bitcoin#26735: [24.x] qt: Load PSBTs using istreambuf_iterat...
<bitcoin-git> [bitcoin] fanquake merged pull request #26735: [24.x] qt: Load PSBTs using istreambuf_iterator rather than istream_iterator (24.x...2212-backport-gui-psbt-whitespace-fix-🔈) https://github.com/bitcoin/bitcoin/pull/26735
<bitcoin-git> [bitcoin] theStack opened pull request #26747: wallet: fix confusing error / GUI crash on cross-chain legacy wallet restore (master...202212-wallet-fix_restorewallet_bdb_crosschain) https://github.com/bitcoin/bitcoin/pull/26747

2022-12-22

<bitcoin-git> [bitcoin] de-nazify-bitcoin opened pull request #26744: De-nazify Bitcoin! - Kicking out the Ukranian neo-nazi Hennadii Stepanov from the Bitcoin organization (master...patch-1) https://github.com/bitcoin/bitcoin/pull/26744
<bitcoin-git> [bitcoin] fjahr opened pull request #26742: http: Track active requests and wait for last to finish - 2nd attempt (master...202212-pr19420) https://github.com/bitcoin/bitcoin/pull/26742
<bitcoin-git> [bitcoin] jessebarton opened pull request #26741: doc: FreeBSD DataDirectoryGroupReadable Setting (master...tor-freebsd-DataDirectoryGroupReadable) https://github.com/bitcoin/bitcoin/pull/26741
<taylorfrommynode> 2022-12-22T16:21:35Z Error: Failed to load database path '/home/bitcoin/.bitcoin'. Data is not in recognized format.
<taylorfrommynode> I communicated the workaround of moving the wallet.dat file into a folder, but many users are still seeing a secondary issue. The log hits an error referencing the entire Bitcoin folder.
<p2plife> fyi, on #bitcoin user chown claims his bitcoin-qt crashes with out of bounds. still there although AFK
<bitcoin-git> [bitcoin] glozow closed pull request #22290: Package Mempool Submission with Package Fee-Bumping (master...package-mempool-accept) https://github.com/bitcoin/bitcoin/pull/22290
<gribble> https://github.com/bitcoin/bitcoin/issues/26739 | Unable to open descriptor wallets that are not in a wallet directory · Issue #26739 · bitcoin/bitcoin · GitHub

2022-12-21

<bitcoin-git> [bitcoin] achow101 opened pull request #26740: wallet: Migrate wallets that are not in a wallet dir (master...migrate-plain-wallet-file) https://github.com/bitcoin/bitcoin/pull/26740
<p2plife> excellent success and as usual top notch developer's support for Bitcoin
<taylorfrommynode> Success! Putting it inside a folder causes bitcoin to start as expected.
<taylorfrommynode> 4 drwxr-xr-x 6 bitcoin bitcoin 4096 Dec 21 14:31 bitcoin
<taylorfrommynode> What seems extra concerning is that some users report this error even after removing the bad wallet or removing it from bitcoin.conf, they still get an error about the format of the whole datadir.
<taylorfrommynode> Error: Failed to load database path '/home/bitcoin/.bitcoin'. Data is not in recognized format.
<sipa> Is bitcoind running as user bitcoin?
<taylorfrommynode> 12 -rw------- 1 bitcoin bitcoin 12288 Dec 21 13:37 wallet.dat
<taylorfrommynode> admin@myNode:/mnt/hdd/mynode/bitcoin$ file wallet.dat
<taylorfrommynode> That's the path to the main bitcoin data folder.
<taylorfrommynode> Error: Failed to load database path '/home/bitcoin/.bitcoin'. Data is not in recognized format.
<bitcoin-git> [bitcoin] glozow closed pull request #26265: POLICY: Relax MIN_STANDARD_TX_NONWITNESS_SIZE to 65 non-witness bytes (master...relax_too_small_tx) https://github.com/bitcoin/bitcoin/pull/26265
<taylorfrommynode> In bitcoin.conf like this
<taylorfrommynode> OK, I can post here now as well. I'm seeing a pretty prevalent issue when upgrading devices from v23.0 to v24.0 where Bitcoin fails to start, often on the second restart after upgrading to v24. The log reports a message, but it isn't overly helpful and just says wallet.dat cannot be opened.
<p2plife> user on #bitcoin claims after upgrade to 0.24 some old wallets broke. taylorfrommynode (voice in #bitcoin)
<bitcoin-git> bitcoin/master f3bc1a7 Andrew Chow: Merge bitcoin/bitcoin#26265: POLICY: Relax MIN_STANDARD_TX_NONWITNESS_SIZE...
<bitcoin-git> bitcoin/master b2aa9e8 Greg Sanders: Add release note for MIN_STANDARD_TX_NONWITNESS_SIZE relaxation
<bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/6d40a1a7e7f0...f3bc1a72825f
<bitcoin-git> bitcoin/master 8c5b364 Greg Sanders: Relax MIN_STANDARD_TX_NONWITNESS_SIZE to 65 non-witness bytes
<bitcoin-git> [bitcoin] brunoerg opened pull request #26738: test: add coverage for unknown wallet flag in `setwalletflag` (master...2022-12-setwalletflag-unknown-error) https://github.com/bitcoin/bitcoin/pull/26738
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #26694: test: `get_previous_releases.py`: M1/M2 macs can't run unsigned arm64 binaries; self-sign when needed (master...2022-12-fix_mac_arm64_previous_releases) https://github.com/bitcoin/bitcoin/pull/26694
<bitcoin-git> bitcoin/master 7121fd8 kdmukai: test: self-sign previous release binaries for arm64 macOS
<bitcoin-git> bitcoin/master dc12f2e kdmukai: test: improve error msg on previous release tarball extraction failure
<bitcoin-git> bitcoin/master 6d40a1a MarcoFalke: Merge bitcoin/bitcoin#26694: test: `get_previous_releases.py`: M1/M2 macs ...
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/3e536ea9ac95...6d40a1a7e7f0
<bitcoin-git> [bitcoin] fanquake merged pull request #26683: ci: Use `CONFIG_SITE` variable and `--prefix` option properly (master...221210-ci-dep) https://github.com/bitcoin/bitcoin/pull/26683
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/dd7d82bec03c...3e536ea9ac95
<bitcoin-git> bitcoin/master 574e50a Hennadii Stepanov: ci: Use `CONFIG_SITE` variable and `--prefix` option properly
<bitcoin-git> bitcoin/master d3a8434 fanquake: ci: remove --prefix from msan job
<bitcoin-git> bitcoin/master 3e536ea fanquake: Merge bitcoin/bitcoin#26683: ci: Use `CONFIG_SITE` variable and `--prefix`...
<bitcoin-git> [bitcoin] fanquake merged pull request #26734: doc: Fixup getrawtransaction RPC docs (master...doc-getrawtransaction) https://github.com/bitcoin/bitcoin/pull/26734
<bitcoin-git> bitcoin/master 97115de Douglas Chimento: doc: Refactor/Format getrawtransaction RPC docs and add ScriptPubKeyDoc fu...
<bitcoin-git> bitcoin/master dd7d82b fanquake: Merge bitcoin/bitcoin#26734: doc: Fixup getrawtransaction RPC docs
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4cd6b3b55724...dd7d82bec03c
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #26735: [24.x] qt: Load PSBTs using istreambuf_iterator rather than istream_iterator (24.x...2212-backport-gui-psbt-whitespace-fix-🔈) https://github.com/bitcoin/bitcoin/pull/26735
<bitcoin-git> bitcoin/master 4cd6b3b MarcoFalke: Merge bitcoin-core/gui#687: Load PSBTs using istreambuf_iterator rather th...
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0139a0d5c02a...4cd6b3b55724
<bitcoin-git> bitcoin/master bb5ea1d Andrew Chow: qt: Load PSBTs using istreambuf_iterator rather than istream_iterator
<bitcoin-git> [gui] MarcoFalke merged pull request #687: Load PSBTs using istreambuf_iterator rather than istream_iterator (master...load-psbt-istreambuf) https://github.com/bitcoin-core/gui/pull/687
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #26722: test: speed up the two slowest functional tests by 18-35% via `keypoolrefill()` (master...wallet_fundrawtransaction_speedup) https://github.com/bitcoin/bitcoin/pull/26722
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8456bfac6ba2...0139a0d5c02a
<bitcoin-git> bitcoin/master 31fdc54 kdmukai: test: speed up wallet_fundrawtransaction.py and wallet_sendall.py
<bitcoin-git> bitcoin/master 0139a0d MarcoFalke: Merge bitcoin/bitcoin#26722: test: speed up the two slowest functional tes...

2022-12-20

<bitcoin-git> [bitcoin] achow101 closed pull request #26638: test: prefer sqlite for wallet tests (master...wallet_test_prefer_sqlite) https://github.com/bitcoin/bitcoin/pull/26638
<bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/cbcad79eefd7...8456bfac6ba2
<bitcoin-git> bitcoin/master 8e0faba S3RK: test: make wallet_migration.py pass with both wallet flags
<bitcoin-git> bitcoin/master 17554ef S3RK: test: prefer sqlite for wallet tests
<bitcoin-git> bitcoin/master 8456bfa Andrew Chow: Merge bitcoin/bitcoin#26638: test: prefer sqlite for wallet tests
<bitcoin-git> [bitcoin] yusufsahinhamza opened pull request #26733: test: Add test for `sendmany` rpc that uses `subtractfeefrom` parameter (master...add-sendmany-test) https://github.com/bitcoin/bitcoin/pull/26733
<bytes1440000> Happy Holidays. I wanted to make this happier for someone else as it was the first time someone appreciated my efforts in last few years. It wasnt bitcoin or bitcoin core but nostr.
<bytes1440000> Hi michaelfolkson, my email on bitcoin-dev was not ranting, raving or throwing toys. It was 90% facts with links and 10% opinion.
<bitcoin-git> [bitcoin] furszy opened pull request #26732: wallet: tx creation, don't select outputs from txes that are being replaced (master...2022_wallet_do_not_select_utxo_from_the_tx_being_replaced) https://github.com/bitcoin/bitcoin/pull/26732
<bitcoin-git> [bitcoin] achow101 merged pull request #21576: rpc, gui: bumpfee signer support (master...2021/04/signer_bumpfee) https://github.com/bitcoin/bitcoin/pull/21576
<bitcoin-git> bitcoin/master 2c07cfa Sjors Provoost: gui: bumpfee signer support
<bitcoin-git> bitcoin/master 304ece9 Sjors Provoost: rpc: document bools in FillPSBT() calls
<bitcoin-git> bitcoin/master 7e02a33 Sjors Provoost: rpc: bumpfee signer support
<bitcoin-git> [bitcoin] achow101 pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/497f26552b36...cbcad79eefd7
<bitcoin-git> [gui] hebasto merged pull request #605: Delete splash screen widget early (master...220522-splash) https://github.com/bitcoin-core/gui/pull/605
<bitcoin-git> bitcoin/master 1b22849 Hennadii Stepanov: qt: Drop no longer used `SplashScreen::finish()` slot
<bitcoin-git> [bitcoin] hebasto pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/dcdfd72861c0...497f26552b36
<bitcoin-git> bitcoin/master 5299cfe Hennadii Stepanov: qt: Delete splash screen widget explicitly
<bitcoin-git> bitcoin/master 10811af Hennadii Stepanov: qt: Drop no longer used `BitcoinApplication::splashFinished()` signal
<bitcoin-git> [bitcoin] brunoerg opened pull request #26731: test: add coverage for invalid parameter in `keypoolrefill` (master...2022-12-keypool-invalid-parameter) https://github.com/bitcoin/bitcoin/pull/26731
<bitcoin-git> [bitcoin] fanquake closed pull request #26581: CI: Bump CI Lint base image from bionic to jammy (master...ci-bump) https://github.com/bitcoin/bitcoin/pull/26581
<bitcoin-git> [bitcoin] brunoerg opened pull request #26730: test: add coverage for `purpose` arg in `listlabels` (master...2022-12-wallet-labels-verbose) https://github.com/bitcoin/bitcoin/pull/26730
<bitcoin-git> [bitcoin] fjahr closed pull request #19949: cli: Parse and allow hash value (master...jsonerr) https://github.com/bitcoin/bitcoin/pull/19949
<bitcoin-git> [bitcoin] fanquake merged pull request #26721: test, lint: add `crypted` to `ignore-words` (master...2022-12-fix-codespell-walletload) https://github.com/bitcoin/bitcoin/pull/26721
<bitcoin-git> bitcoin/master a4defcd brunoerg: test, lint: add `crypted` to `ignore-words`
<bitcoin-git> bitcoin/master dcdfd72 fanquake: Merge bitcoin/bitcoin#26721: test, lint: add `crypted` to `ignore-words`
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8ab19237e11e...dcdfd72861c0
<sipa> In the Bitcoin Core source code, see key_io.cpp for higher-level conversions between witness programs and addresses.

2022-12-19

<bitcoin-git> [bitcoin] achow101 closed pull request #23417: wallet, spkm: Move key management from DescriptorScriptPubKeyMan to wallet level KeyManager (master...wallet-keyman) https://github.com/bitcoin/bitcoin/pull/23417
<bitcoin-git> [bitcoin] achow101 opened pull request #26728: wallet: Have the wallet store the key for automatically generated descriptors (master...wallet-knows-master-key) https://github.com/bitcoin/bitcoin/pull/26728
<bitcoin-git> [bitcoin] fanquake opened pull request #26727: rpc: remove optional from fStateStats fields (master...remove_fstatestats_post_26515) https://github.com/bitcoin/bitcoin/pull/26727
<bitcoin-git> [bitcoin] fanquake closed pull request #26723: test: call `keypoolrefill` with priv key disabled should throw an error (master...2022-12-keypool-error-privatekey) https://github.com/bitcoin/bitcoin/pull/26723
<bitcoin-git> bitcoin/master 8ab1923 MarcoFalke: Merge bitcoin/bitcoin#26723: test: call `keypoolrefill` with priv key disa...
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3d974960d38b...8ab19237e11e
<bitcoin-git> bitcoin/master ec63a48 brunoerg: test: call `keypoolrefill` with private keys disabled should throw an error
<bitcoin-git> [bitcoin] fanquake closed pull request #26515: rpc: skip getpeerinfo for a peer without CNodeStateStats (master...202211_getpeerinfo_allornothing) https://github.com/bitcoin/bitcoin/pull/26515
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/65f5cfda656c...3d974960d38b
<bitcoin-git> bitcoin/master 6fefd49 Martin Zumsande: rpc: Require NodeStateStats object in getpeerinfo
<bitcoin-git> bitcoin/master 3d97496 MarcoFalke: Merge bitcoin/bitcoin#26515: rpc: skip getpeerinfo for a peer without CNod...
<gribble> https://github.com/bitcoin/bitcoin/issues/25871 | contrib: add vasild to trusted keys by vasild · Pull Request #25871 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] willcl-ark closed pull request #26725: lint: fix lint-tests.py failing on correct names (master...lint-name-test) https://github.com/bitcoin/bitcoin/pull/26725
<bitcoin-git> [bitcoin] willcl-ark opened pull request #26725: lint: fix lint-tests.py failing on correct names (master...lint-name-test) https://github.com/bitcoin/bitcoin/pull/26725
<fanquake> To github.com:bitcoin-core/bitcoin-detached-sigs.git
<bitcoin-git> [bitcoin] fanquake merged pull request #25311: refactor: remove CBlockIndex copy construction (master...2022-06-cblockindex-delete-copy) https://github.com/bitcoin/bitcoin/pull/25311
<bitcoin-git> bitcoin/master 36c201f James O'Beirne: remove CBlockIndex copy construction
<bitcoin-git> bitcoin/master 65f5cfd fanquake: Merge bitcoin/bitcoin#25311: refactor: remove CBlockIndex copy construction
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bd13d6b36921...65f5cfda656c
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #26656: tests: Improve runtime of some tests when `--enable-debug` (master...faster-test-runner-when-debug) https://github.com/bitcoin/bitcoin/pull/26656
<bitcoin-git> bitcoin/master 4ad7272 Andrew Chow: tests: reduce number of generated blocks for wallet_import_rescan
<bitcoin-git> bitcoin/master 544cbf7 Andrew Chow: tests: Use batched RPC in feature_fee_estimation
<bitcoin-git> bitcoin/master 6c872d5 Andrew Chow: tests: Initialize sigops draining script with bytes in feature_taproot
<bitcoin-git> [bitcoin] MarcoFalke pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/8b05f13ddb1e...bd13d6b36921
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #26717: test: Improve `check-doc.py` pattern (master...221217-doc) https://github.com/bitcoin/bitcoin/pull/26717
<bitcoin-git> bitcoin/master 2b77a33 Hennadii Stepanov: test: Improve `check-doc.py` pattern
<bitcoin-git> bitcoin/master 8b05f13 MarcoFalke: Merge bitcoin/bitcoin#26717: test: Improve `check-doc.py` pattern
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cb32328d1b80...8b05f13ddb1e

2022-12-18

<bitcoin-git> [bitcoin] brunoerg opened pull request #26723: test: call `keypoolrefill` with priv key disabled should throw an error (master...2022-12-keypool-error-privatekey) https://github.com/bitcoin/bitcoin/pull/26723
<bitcoin-git> [gui] achow101 opened pull request #687: qt: Load PSBTs using istreambuf_iterator rather than istream_iterator (master...load-psbt-istreambuf) https://github.com/bitcoin-core/gui/pull/687
<bitcoin-git> [bitcoin] kdmukai opened pull request #26722: test: speed up the two slowest functional tests by 18-35% via `keypoolrefill()` (master...wallet_fundrawtransaction_speedup) https://github.com/bitcoin/bitcoin/pull/26722
<bitcoin-git> [bitcoin] brunoerg opened pull request #26721: test, lint: add `crypted` to `ignore-words` (master...2022-12-fix-codespell-walletload) https://github.com/bitcoin/bitcoin/pull/26721
<bitcoin-git> [bitcoin] furszy opened pull request #26720: wallet: coin selection, don't return results that exceed the max allowed weight (master...2022_coin_selection_weight) https://github.com/bitcoin/bitcoin/pull/26720

2022-12-17

<bitcoin-git> [bitcoin] hebasto opened pull request #26717: test: Improve `check-doc.py` pattern (master...221217-doc) https://github.com/bitcoin/bitcoin/pull/26717
<bitcoin-git> [bitcoin] hebasto opened pull request #26716: ci: Build python from source in "lint" task (master...221217-pyenv) https://github.com/bitcoin/bitcoin/pull/26716
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6c01323d9d18...cb32328d1b80
<bitcoin-git> bitcoin/master 48033d4 Hennadii Stepanov: clang-tidy: Fix `performance-for-range-copy` in headers
<bitcoin-git> bitcoin/master cb32328 MarcoFalke: Merge bitcoin/bitcoin#26710: refactor: Fix `performance-for-range-copy` in...
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #26710: refactor: Fix `performance-for-range-copy` in headers (master...221216-tidy-range) https://github.com/bitcoin/bitcoin/pull/26710
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/caa22406809e...6c01323d9d18
<bitcoin-git> bitcoin/master adb7dba Hennadii Stepanov: clang-tidy: Fix `modernize-use-nullptr` in headers
<bitcoin-git> bitcoin/master 6c01323 MarcoFalke: Merge bitcoin/bitcoin#26708: clang-tidy: Fix `modernize-use-nullptr` in he...
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #26708: clang-tidy: Fix `modernize-use-nullptr` in headers (master...221215-tidy-null) https://github.com/bitcoin/bitcoin/pull/26708
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #26120: refactor: Make bitcoin-util grind_task tsan friendly (master...2209-tsan-less-sad-💥) https://github.com/bitcoin/bitcoin/pull/26120
<bitcoin-git> bitcoin/master caa2240 MarcoFalke: Merge bitcoin/bitcoin#26120: refactor: Make bitcoin-util grind_task tsan f...
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/66c08e741dc8...caa22406809e
<bitcoin-git> bitcoin/master fafcc94 MacroFake: Make bitcoin-util grind_task tsan friendly
<bitcoin-git> [bitcoin] JeremyRubin closed pull request #21702: Implement BIP-119 Validation (CheckTemplateVerify) (24.x...checktemplateverify-rebase-4-15-21) https://github.com/bitcoin/bitcoin/pull/21702

2022-12-16

<bitcoin-git> [bitcoin] achow101 merged pull request #24865: rpc: Enable wallet import on pruned nodes and add test (master...2022-04-importwallet-pruned) https://github.com/bitcoin/bitcoin/pull/24865
<bitcoin-git> bitcoin/master e6906fc Aurèle Oulès: rpc: Enable wallet import on pruned nodes
<bitcoin-git> bitcoin/master 564b580 Aurèle Oulès: test: Introduce MIN_BLOCKS_TO_KEEP constant
<bitcoin-git> bitcoin/master 71d9a7c Aurèle Oulès: test: Wallet imports on pruned nodes
<bitcoin-git> [bitcoin] achow101 pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/7386da7a0b08...66c08e741dc8
<core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
<furszy> thus why ended up coding https://github.com/bitcoin-core/gui/pull/666
<Murch1> The Bitcoin Core wallet should really keep track of its UTXO pool instead of recalculating it from its list of transactions every time it needs it
<sipa> e.g. you know that any signature that your bitcoin core wallet will be involved in, will have access to that wallet's private key
<darosior> Yeah. Also rust-miniscript is experimenting with another approach: https://github.com/rust-bitcoin/rust-miniscript/pull/481
<gribble> https://github.com/bitcoin/bitcoin/issues/24149 | Signing support for Miniscript Descriptors by darosior · Pull Request #24149 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/26567 | Wallet: estimate the size of signed inputs using descriptors by darosior · Pull Request #26567 · bitcoin/bitcoin · GitHub
<achow101> #bitcoin-core-dev Wallet Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr furszy gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack josibake jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos Murch nehan NicolasDorier
<core-meetingbot> Meeting started Fri Dec 16 19:00:22 2022 UTC. The chair is achow101. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
<bitcoin-git> [bitcoin] achow101 opened pull request #26715: Introduce `MockableDatabase` for wallet unit tests (master...test-wallet-corrupt) https://github.com/bitcoin/bitcoin/pull/26715
<bitcoin-git> [bitcoin] brunoerg opened pull request #26714: test: add coverage for unparsable `-maxuploadtarget` (master...2022-12-maxuploadtarget-parse-test) https://github.com/bitcoin/bitcoin/pull/26714
<sdaftuar> _aj_: i think you'll run into the same issues we have in Bitcoin Core's logic wrt DoS. fundamentally we don't have a total ordering on transaction desirability, and that leads to the DoS concerns we have
<bitcoin-git> [bitcoin] JeremyRubin closed pull request #22876: [TESTS] Update Transaction Tests to permit setting a flag as always on and disabling the exhaustive failure test (master...update-txvalid-json) https://github.com/bitcoin/bitcoin/pull/22876
<bitcoin-git> [bitcoin] JeremyRubin closed pull request #23309: [WIP] Add a basic python REST API Server Wrapper (master...rest-python) https://github.com/bitcoin/bitcoin/pull/23309
<bitcoin-git> [bitcoin] JeremyRubin closed pull request #22954: [TESTS] Allow tx_invalid.json tests to include flag rules for if_unset: [A,B,C] then_unset: [D] (master...if_unset_then_unset) https://github.com/bitcoin/bitcoin/pull/22954
<bitcoin-git> [bitcoin] fanquake merged pull request #26709: doc: add 23.1 release notes (master...historical_rel_notes_23_1) https://github.com/bitcoin/bitcoin/pull/26709
<bitcoin-git> bitcoin/master 7386da7 fanquake: Merge bitcoin/bitcoin#26709: doc: add 23.1 release notes
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5055d07edf46...7386da7a0b08
<bitcoin-git> bitcoin/master a272480 fanquake: doc: add 23.1 release notes
<gribble> https://github.com/bitcoin/bitcoin/issues/26711 | [WIP] validate package transactions with their in-package ancestor sets by glozow · Pull Request #26711 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/26711 | [WIP] validate package transactions with their in-package ancestor sets by glozow · Pull Request #26711 · bitcoin/bitcoin · GitHub
<bitcoin-git> [gui] hebasto opened pull request #686: clang-tidy, qt: Force checks for headers in `src/qt` (master...221216-tidy) https://github.com/bitcoin-core/gui/pull/686
<bitcoin-git> [bitcoin] glozow opened pull request #26711: [WIP] validate package transactions with their in-package ancestor sets (master...2022-12-subpackages) https://github.com/bitcoin/bitcoin/pull/26711
<bitcoin-git> [bitcoin] hebasto opened pull request #26710: clang-tidy: Fix `performance-for-range-copy` in headers (master...221216-tidy-range) https://github.com/bitcoin/bitcoin/pull/26710
<bitcoin-git> [bitcoin] fanquake pushed tag v23.1: https://github.com/bitcoin/bitcoin/compare/v23.1
<bitcoin-git> bitcoin/master c39619e Hennadii Stepanov: clang-tidy: Fix `readability-redundant-string-init` in headers
<bitcoin-git> bitcoin/master 5055d07 MarcoFalke: Merge bitcoin-core/gui#685: clang-tidy: Fix `readability-redundant-string-...
<bitcoin-git> [gui] MarcoFalke merged pull request #685: clang-tidy: Fix `readability-redundant-string-init` in headers (master...221215-tidy-string) https://github.com/bitcoin-core/gui/pull/685
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/03708dac0ac6...5055d07edf46

2022-12-15

<bitcoin-git> [gui] hebasto opened pull request #685: clang-tidy: Fix `readability-redundant-string-init` in headers (master...221215-tidy-string) https://github.com/bitcoin-core/gui/pull/685
<bitcoin-git> [bitcoin] hebasto opened pull request #26708: clang-tidy: Fix `modernize-use-nullptr` in headers (master...221215-tidy-null) https://github.com/bitcoin/bitcoin/pull/26708
<bitcoin-git> [bitcoin] hebasto opened pull request #26707: clang-tidy: Fix `performance-move-const-arg` in headers (master...221215-tidy-move) https://github.com/bitcoin/bitcoin/pull/26707
<core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
<aureleoules> It contains a pre-compiled bitcoin-core with ccache (thus the image is heavy) but the first compilation is fast
<brunoerg> reminding that it's not a generalist C++ tool, but focused on Bitcoin Core, because we have e.g. CAmount a = 1; and most tools can't deal with it
<gribble> https://github.com/bitcoin/bitcoin/issues/25871 | contrib: add vasild to trusted keys by vasild · Pull Request #25871 · bitcoin/bitcoin · GitHub
<achow101> #topic https://github.com/bitcoin/bitcoin/pull/25871 (bytes1440000)
<core-meetingbot> topic: https://github.com/bitcoin/bitcoin/pull/25871 (bytes1440000)
<achow101> and also reminder that we now have https://github.com/orgs/bitcoin/projects/5 where people can add their own PRs
<achow101> https://github.com/orgs/bitcoin/projects/1 anything to add/merge/remove?
<achow101> There is one preproposed meeting topic: https://github.com/bitcoin/bitcoin/pull/25871 (bytes1440000)
<achow101> #bitcoin-core-dev Meeting: achow101 aj amiti ariard b10c BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik petertodd
<core-meetingbot> Meeting started Thu Dec 15 19:03:37 2022 UTC. The chair is achow101. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
<bitcoin-git> [bitcoin] dhruv reopened pull request #24545: BIP324: Enable v2 P2P encrypted transport (master...bip324-enable) https://github.com/bitcoin/bitcoin/pull/24545
<gribble> https://github.com/bitcoin/bitcoin/issues/24545 | BIP324: Enable v2 P2P encrypted transport by dhruv · Pull Request #24545 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] dhruv closed pull request #24545: BIP324: Enable v2 P2P encrypted transport (master...bip324-enable) https://github.com/bitcoin/bitcoin/pull/24545
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #26706: doc: Properly report optional RPC args (master...2212-doc-rpc-🐵) https://github.com/bitcoin/bitcoin/pull/26706
<bitcoin-git> [bitcoin] hebasto opened pull request #26705: clang-tidy: Check headers and fixes them (master...221215-tidy) https://github.com/bitcoin/bitcoin/pull/26705
<gribble> https://github.com/bitcoin/bitcoin/issues/3 | Encrypt wallet · Issue #3 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/3 | Encrypt wallet · Issue #3 · bitcoin/bitcoin · GitHub
<darosior> jamesob: also rule2 since you are using ACP, a replacement with a lower ancestor feerate could be accepted. See https://github.com/bitcoin/bitcoin/pull/23121#issuecomment-929475999.
<gribble> https://github.com/bitcoin/bitcoin/issues/4 | Export/Import wallet in a human readable, future-proof format · Issue #4 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #26704: doc: add 22.1 release notes (master...historical_rel_notes_22_1) https://github.com/bitcoin/bitcoin/pull/26704
<bitcoin-git> bitcoin/master 062e4e9 fanquake: doc: add 22.1 release notes
<bitcoin-git> bitcoin/master 03708da MarcoFalke: Merge bitcoin/bitcoin#26704: doc: add 22.1 release notes
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9a72119e7e27...03708dac0ac6
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #26651: test: Avoid intermittent timeout in feature_assumevalid.py (master...2212-test-fix-assumevalid-🌞) https://github.com/bitcoin/bitcoin/pull/26651
<bitcoin-git> bitcoin/master fa34e5f MarcoFalke: test: Avoid intermittent timeout in feature_assumevalid.py
<bitcoin-git> bitcoin/master 9a72119 MarcoFalke: Merge bitcoin/bitcoin#26651: test: Avoid intermittent timeout in feature_a...
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ba47a4ba97e9...9a72119e7e27
<bitcoin-git> [bitcoin] fanquake opened pull request #26704: doc: add 22.1 release notes (master...historical_rel_notes_22_1) https://github.com/bitcoin/bitcoin/pull/26704
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #19262: rpc: Replace OMITTED_NAMED_ARG with OMITTED (master...2006-rpcHelpRefactor) https://github.com/bitcoin/bitcoin/pull/19262
<bitcoin-git> [bitcoin] theStack opened pull request #26702: walletdb: refactor: drop unused `FindWalletTx` parameter and rename (master...202212-walletdb-refactor_simplify_findwallettx) https://github.com/bitcoin/bitcoin/pull/26702

2022-12-14

<gribble> https://github.com/bitcoin/bitcoin/issues/3 | Encrypt wallet · Issue #3 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/3 | Encrypt wallet · Issue #3 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] achow101 merged pull request #26668: wallet: if only have one output type, don't perform "mixed" coin selection (master...2022_wallet_double_coin_selection) https://github.com/bitcoin/bitcoin/pull/26668
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/678889e6c623...ba47a4ba97e9
<bitcoin-git> bitcoin/master 89c1491 furszy: wallet: if only have one output type, don't perform "mixed" coin selection
<bitcoin-git> bitcoin/master ba47a4b Andrew Chow: Merge bitcoin/bitcoin#26668: wallet: if only have one output type, don't p...
<bitcoin-git> [bitcoin] brunoerg opened pull request #26701: contrib: make DNS seeds file an argument in CLI (`makeseeds`) (master...2022-12-seeds-improv) https://github.com/bitcoin/bitcoin/pull/26701
<bytes1440000> #proposedmeetingtopic https://github.com/bitcoin/bitcoin/pull/25871
<bytes1440000> Why is this pull request not being reviewed or merged? https://github.com/bitcoin/bitcoin/pull/25871
<bitcoin-git> [bitcoin] aureleoules opened pull request #26700: rpc: Prevent unloading a wallet when rescanning (master...2022-12-rescan-tests) https://github.com/bitcoin/bitcoin/pull/26700
<bitcoin-git> [bitcoin] furszy opened pull request #26699: wallet, gui: getAvailableBalance skips selected coins (master...2022_bugfix_wallet_getavailablebalance) https://github.com/bitcoin/bitcoin/pull/26699
<gribble> https://github.com/bitcoin/bitcoin/issues/26618 | rpc: Prevent unloading a wallet when rescanning by aureleoules · Pull Request #26618 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #26659: [23.x] bump version to v23.1 (23.x...23_1_final) https://github.com/bitcoin/bitcoin/pull/26659
<bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to 23.x: https://github.com/bitcoin/bitcoin/compare/ea9aa3f02f70...ffef91a5c18a
<bitcoin-git> bitcoin/23.x 9371365 fanquake: build: bump version to 23.1 final
<bitcoin-git> bitcoin/23.x 5847826 fanquake: doc: update manual pages for 23.1
<bitcoin-git> bitcoin/23.x 8a16391 fanquake: doc: update release notes for 23.1
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #26689: test: add add_wallet_options to TestShell (master...josibake-add-wallet-options-test-shell) https://github.com/bitcoin/bitcoin/pull/26689
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/daf881de9db1...678889e6c623
<bitcoin-git> bitcoin/master bcb7123 josibake: test: add add_wallet_options to TestShell
<bitcoin-git> bitcoin/master 678889e MarcoFalke: Merge bitcoin/bitcoin#26689: test: add add_wallet_options to TestShell
<bitcoin-git> [bitcoin] LarryRuane closed pull request #26619: log: expand BCLog::LogFlags (categories) to 64 bits (master...2022-11-log-categories-64) https://github.com/bitcoin/bitcoin/pull/26619
<bitcoin-git> [bitcoin] LarryRuane opened pull request #26697: logging: use std::bitset for categories (master...2022-12-log-categories-stdbitset) https://github.com/bitcoin/bitcoin/pull/26697

2022-12-13

<bitcoin-git> bitcoin/master daf881d Andrew Chow: Merge bitcoin/bitcoin#23319: rpc: Return fee and prevout (utxos) to getraw...
<bitcoin-git> bitcoin/master f866971 Douglas Chimento: rpc: Return fee and prevout(s) to getrawtransaction
<bitcoin-git> [bitcoin] achow101 merged pull request #23319: rpc: Return fee and prevout (utxos) to getrawtransaction (master...23264-fee-getrawtransaction) https://github.com/bitcoin/bitcoin/pull/23319
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ffa32ab108a4...daf881de9db1
<bitcoin-git> [gui] hebasto merged pull request #682: Don't directly delete abandoned txes from GUI (master...2022_11_FixAbandonTxGUI) https://github.com/bitcoin-core/gui/pull/682
<bitcoin-git> bitcoin/master ffa32ab Hennadii Stepanov: Merge bitcoin-core/gui#682: Don't directly delete abandoned txes from GUI
<bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8f3021155e8c...ffa32ab108a4
<bitcoin-git> bitcoin/master e75d227 John Moffett: Minor fix: Don't directly delete abandoned txes
<bitcoin-git> [bitcoin] achow101 merged pull request #26643: wallet: Move fee underpayment check to after all fee has been set (master...move-fee-underpay-check) https://github.com/bitcoin/bitcoin/pull/26643
<bitcoin-git> bitcoin/master e5daf97 Andrew Chow: wallet: Rename nFeeRet in CreateTransactionInternal to current_fee
<bitcoin-git> bitcoin/master c1a84f1 Andrew Chow: wallet: Move fee underpayment check to after fee setting
<bitcoin-git> bitcoin/master 798430d Andrew Chow: wallet: Sanity check fee paid cannot be negative
<bitcoin-git> [bitcoin] achow101 pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/a4baf3f17748...8f3021155e8c
<bitcoin-git> [gui] meshcollider closed pull request #536: Add address error location to GUI (master...202201_bech32_error_gui) https://github.com/bitcoin-core/gui/pull/536
<stickies-v> getting error message `Failed to checkout 135e8326adee7f86da83e8aa409905a1de4a5b2e: object not found!` when that commit is definitely on origin: https://github.com/bitcoin/bitcoin/commit/135e8326adee7f86da83e8aa409905a1de4a5b2e
<stickies-v> anything wrong with our cirrus instances? suddenly all my CI jobs failing: https://github.com/bitcoin/bitcoin/pull/26506/checks?check_run_id=10070556876 - can't see anything in recent commits that would trigger it
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #26628: RPC: Reject RPC requests with same named parameter specified multiple times (master...pr/nmult) https://github.com/bitcoin/bitcoin/pull/26628
<bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/968f03e65c98...a4baf3f17748
<bitcoin-git> bitcoin/master e2c3b18 Ryan Ofsky: test: Add RPC tests for same named parameter specified more than once
<bitcoin-git> bitcoin/master 6bd1d20 Ryan Ofsky: rpc: Make it an error server-side to specify same named parameter multiple...
<bitcoin-git> bitcoin/master d1ca563 Ryan Ofsky: bitcoin-cli: Make it an error to specify the "args" parameter two differen...
<bitcoin-git> [bitcoin] glozow opened pull request #26695: bench: BlockAssembler on a mempool with packages (master...2022-12-bench-miner) https://github.com/bitcoin/bitcoin/pull/26695
<bitcoin-git> [bitcoin] kdmukai opened pull request #26694: test: `get_previous_releases.py`: M1/M2 macs can't run the unsigned v23.0 arm64 binary; fall back to x86_64 binary (master...2022-12-fix_mac_arm64_previous_releases) https://github.com/bitcoin/bitcoin/pull/26694
<bitcoin-git> [bitcoin] willcl-ark opened pull request #26693: build: special instruction check script (master...18603_si_check) https://github.com/bitcoin/bitcoin/pull/26693
<stickies-v> in https://github.com/bitcoin/bitcoin/blob/968f03e65c98a9a36aea6c57a29306839b0ada57/src/util/result.h#L65-L69, it seems that we want to return an rvalue ref (`T&&`) but since the return type is just `T` - my intuition is that we will be passing by value instead? I think I must be wrong, but I don't understand why - any insights (or links/pointers) appreciated (cc author ryanofsky)
<bitcoin-git> [bitcoin] fanquake closed pull request #26692: doc: Fix typo in comment (master...fix-typo-implemenation) https://github.com/bitcoin/bitcoin/pull/26692
<bitcoin-git> [bitcoin] fanquake closed pull request #26477: validation: fix broken maxtipage comparison (master...2022-11-fix-maxtipage) https://github.com/bitcoin/bitcoin/pull/26477
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/6061eb656410...968f03e65c98
<bitcoin-git> bitcoin/master a451e83 James O'Beirne: fix: validation: cast now() to seconds for maxtipage comparison
<bitcoin-git> bitcoin/master e4be0e9 James O'Beirne: test: add -maxtipage test for the maximum allowable value
<bitcoin-git> bitcoin/master 968f03e fanquake: Merge bitcoin/bitcoin#26477: validation: fix broken maxtipage comparison
<bitcoin-git> [bitcoin] kristapsk opened pull request #26692: doc: Fix typo in comment (master...fix-typo-implemenation) https://github.com/bitcoin/bitcoin/pull/26692
<bitcoin-git> [bitcoin] sipa opened pull request #26691: Update secp256k1 subtree to libsecp256k1 version 0.2.0 (master...secp256k1) https://github.com/bitcoin/bitcoin/pull/26691

2022-12-12

<kdmukai> fanquake: ya. "bitcoin-qt: code object is not signed at all" vs "Signature size=8958" etc.
<fanquake> if you run codesign —display —versbose and pass either bitcoin-qt bin, you’ll see what I mean.
<fanquake> The bitcoin-qt in the tarball wont be code signed. It likely would have just run ok on previous versions of macOS. However with newer versions of macOS that is less likely the case
<kdmukai> then just directly downloaded the dmg version from https://bitcoincore.org/bin/bitcoin-core-23.0/ and that installed and ran fine. When Sjors ran a diff on the two v23.0 bitcoin-qt binaries (the one from the tar.gz vs what was unpacked from the dmg), they came up as different, which confounded Sjors.
<bitcoin-git> [bitcoin] achow101 opened pull request #26690: wallet: Refactor database cursor into its own object with proper return codes (master...walletdb-cursor-unstupidfy) https://github.com/bitcoin/bitcoin/pull/26690
<bitcoin-git> [bitcoin] josibake opened pull request #26689: test: add add_wallet_options to TestShell (master...josibake-add-wallet-options-test-shell) https://github.com/bitcoin/bitcoin/pull/26689