<bitcoin-git>
[bitcoin] fanquake merged pull request #24600: doc: mention that BDB is for the legacy wallet in build-freebsd.md (master...freebsd_legacy_descriptor_switch) https://github.com/bitcoin/bitcoin/pull/24600
<bitcoin-git>
bitcoin/master 95cac21 fanquake: Merge bitcoin/bitcoin#24600: doc: mention that BDB is for the legacy walle...
<bitcoin-git>
bitcoin/master b5ba3b5 fanquake: doc: mention that BDB is for the legacy wallet in build-freebsd.md
<bitcoin-git>
bitcoin/master daae288 Jon Atack: doc, init: add links to doc/cjdns.md
2022-03-24
<bitcoin-git>
[bitcoin] luke-jr reopened pull request #16228: Bugfix: make check: Only run tests that were compiled (master...bugfix_raii_check_fail) https://github.com/bitcoin/bitcoin/pull/16228
<bitcoin-git>
[bitcoin] luke-jr closed pull request #16228: Bugfix: make check: Only run tests that were compiled (master...bugfix_raii_check_fail) https://github.com/bitcoin/bitcoin/pull/16228
<bitcoin-git>
[bitcoin] MarcoFalke reopened pull request #24662: addrman: Use sytem time instead of adjusted network time (master...2203-add-🔍) https://github.com/bitcoin/bitcoin/pull/24662
<bitcoin-git>
[bitcoin] MarcoFalke closed pull request #24662: addrman: Use sytem time instead of adjusted network time (master...2203-add-🔍) https://github.com/bitcoin/bitcoin/pull/24662
<bitcoin-git>
[bitcoin] fanquake merged pull request #24658: doc: mention that BDB is for the legacy wallet in build-netbsd.md (master...netbsd_descriptor_reorder) https://github.com/bitcoin/bitcoin/pull/24658
<bitcoin-git>
bitcoin/master 7ac7198 fanquake: doc: mention that BDB is for the legacy wallet in build-netbsd.md
<bitcoin-git>
bitcoin/master 7d0e42a fanquake: Merge bitcoin/bitcoin#24658: doc: mention that BDB is for the legacy walle...
<bitcoin-git>
[bitcoin] fanquake opened pull request #24658: doc: mention that BDB is for the legacy wallet in build-netbsd.md (master...netbsd_descriptor_reorder) https://github.com/bitcoin/bitcoin/pull/24658
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #24656: refactor: Move mempool RPCs to rpc/mempool (master...2203-more-mempool-🍢) https://github.com/bitcoin/bitcoin/pull/24656
<cocoon>
luke-jr: BIPs are not part of core. How do you explain this to whole world including laanwj who knows this exists: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2021-April/018871.html. I have tried my best to share they use an implementation they like or fork but NETWORK EFFECT is a thing you cannot go against. If you every try to do
<cocoon>
marketing for knots, more github activity, more tweets, more mailing list indirect involvement, r/bitcoin suggesting as an alternative etc. maybe it would work. I would encourage people for both: core and knots.
<luke-jr>
(also, while the topic of bitcoin/bitcoin group members would be on-topic here, things like "what impl people run" does indeed seem better suited for #bitcoin and broader community chats; let's stick to just dev-specific topics here, so non-devs can more readily participate in the other topics ☺)
<luke-jr>
to be clear, BIPs are not part of Core. The bitcoin github org just has multiple groups and multiple projects.
<cocoon>
my concerns: percentage of nodes run core for bitcoin? percentage of people that use core org for bip and read that they need post on a mailing list? do we have a process to add/remove people in this? can we improve this?
<bitcoin-git>
[bitcoin] achow101 merged pull request #24560: wallet: Use single FastRandomContext when creating a wallet tx (master...2203-RandWallet-🗾) https://github.com/bitcoin/bitcoin/pull/24560
<bitcoin-git>
bitcoin/master 77773b0 MarcoFalke: wallet: Pass FastRandomContext& to DiscourageFeeSniping
<bitcoin-git>
bitcoin/master fa7deaa MarcoFalke: wallet: Pass FastRandomContext& to coin selection
<bitcoin-git>
bitcoin/master 3ab96f2 Andrew Chow: Merge bitcoin/bitcoin#24560: wallet: Use single FastRandomContext when cre...
<cocoon>
michaelfolkson: lmao this was shared in this channel and they were added in bitcoin core github org
<michaelfolkson>
cocoon: #bitcoin please
<cocoon>
and I am not surprised by the last 2 people added or their employer or things they didn't want in bitcoin
<cocoon>
michaelfolkson: adding to github org has a meaning in bitcoin/bitcoin and bitcoin-core/gui. if you think there is no other github org maintaining implementations for bitcoin then its either a misunderstanding or centralization. I understand this does not involve merge permissions.
<cocoon>
3: github needs org, bitcoin doesn't so these things can be separated
<cocoon>
1: adding to org for a project on github can be decided by the owners but this project is different from others. It is used by most of the nodes in bitcoin network claimed to be decentralized network for money and bip repo belongs to same organization.
<bitcoin-git>
[bitcoin] josibake opened pull request #24653: test, refactor: use `MiniWallet` in `test/functional/interface_zmg` (master...josibake-make-interfaces-zmq-test-use-miniwallet) https://github.com/bitcoin/bitcoin/pull/24653
<bitcoin-git>
[bitcoin] fanquake opened pull request #24652: doc: rewrite OpenBSD build docs for 7.0 (master...openbsd_wallet_doc_cleanupp) https://github.com/bitcoin/bitcoin/pull/24652
<bitcoin-git>
bitcoin/master 7f90dc2 Vasil Dimov: options: flip listenonion to false if not listening
<bitcoin-git>
bitcoin/master f9ed0ae Hennadii Stepanov: Merge bitcoin-core/gui#568: options: flip listenonion to false if not list...
<bitcoin-git>
[bitcoin] fanquake closed pull request #24610: test, lint: check bash version before executing codespell (master...2022-03-bash-lint-spelling) https://github.com/bitcoin/bitcoin/pull/24610
<laanwj>
fanquake: ACK on inviting 0xb10c, i'm surprised they weren't yet! btw, please invite people to bitcoincore org as well if you invite them for bitcoin to keep the lists in sync
<bitcoin-git>
[bitcoin] hebasto closed pull request #24648: Revert "net: do not advertise address where nobody is listening" (master...220323-listen) https://github.com/bitcoin/bitcoin/pull/24648
<bitcoin-git>
[bitcoin] S3RK opened pull request #24649: wallet: do not count wallet utxos as external (master...wallet_correct_external_utxo) https://github.com/bitcoin/bitcoin/pull/24649
<bitcoin-git>
[bitcoin] hebasto opened pull request #24648: Revert "net: do not advertise address where nobody is listening" (master...220323-listen) https://github.com/bitcoin/bitcoin/pull/24648
<gribble>
https://github.com/bitcoin/bitcoin/issues/24294 | RPC: Switch getblockfrompeer back to standard param names blockhash and nodeid by luke-jr · Pull Request #24294 · bitcoin/bitcoin · GitHub
<bitcoin-git>
[bitcoin] jessebarton opened pull request #24646: doc: remove unneeded documentation on basic package management on FreeBSD (master...freebsd_remove_basic_doc_info) https://github.com/bitcoin/bitcoin/pull/24646
<bitcoin-git>
[bitcoin] jessebarton closed pull request #24618: doc: Update OpenBSD build docs, added resources for pkg_add and doas (master...openbsd_install_doc_doas) https://github.com/bitcoin/bitcoin/pull/24618
<bitcoin-git>
[bitcoin] achow101 opened pull request #24644: wallet: add tracepoints and algorithm information to coin selection (master...tracepoints-coin-selection) https://github.com/bitcoin/bitcoin/pull/24644
<bitcoin-git>
[bitcoin] luke-jr opened pull request #24640: Bugfix: RPC/blockchain: Correct description of getblockchaininfo's pruneheight result (master...fix_rpcdoc_gbci_pruneheight_desc) https://github.com/bitcoin/bitcoin/pull/24640
<sipa>
The purpose of this effort is making sure that (b) can run without Bitcoin Core wallet, so that we don't lose test coverage of those non-wallet components.
<sipa>
In case the Bitcoin Core wallet is disabled, (a) is pointless; there just isn't anything to be tested.
<sipa>
@michaelfolkson: The Bitcoin Core wallet is interacted with for two reasons in the functional tests: (a) for testing the Bitcoin Core wallet or (b) because a test needs *a* wallet-like thing to construct transactions for the purpose of testing some non-wallet component of Bitcoin Core.
<sipa>
I think it's just that tests should only be interacting with the Bitcoin Core wallet if they're trying to test the Bitcoin Core wallet. But there are lots of tests that need a wallet for something, but not for the thing being tested. Those should use MiniWallet.
<bitcoin-git>
[bitcoin] hebasto opened pull request #24639: guix: Drop code for the unsupported `i686-linux-gnu` host (master...220322-guix686) https://github.com/bitcoin/bitcoin/pull/24639
<bitcoin-git>
[bitcoin] fanquake closed pull request #23507: Refactor: Improve API design of `ScriptToUniv`, `TxToUniv` etc to return the `UniValue` instead of mutating a parameter/reference (master...ret_UniValue_instead_of_pass_by_ref) https://github.com/bitcoin/bitcoin/pull/23507
<bitcoin-git>
[bitcoin] theStack opened pull request #24637: test: use MiniWallet for mempool_package_onemore.py (master...20220322-test-use_MiniWallet_for_mempool_packages_onemore) https://github.com/bitcoin/bitcoin/pull/24637
<bitcoin-git>
[bitcoin] fanquake merged pull request #24627: test: Limit scope of id global which is shared between subtests (master...2203-gid-🥒) https://github.com/bitcoin/bitcoin/pull/24627
<bitcoin-git>
[bitcoin] MarcoFalke closed pull request #20751: [fuzzing] Use subprocess.Popen call directly, remove use of thread pool. (master...2020-12-22-fuzz-test-runner) https://github.com/bitcoin/bitcoin/pull/20751
<bitcoin-git>
bitcoin/master e3206c9 MarcoFalke: Merge bitcoin/bitcoin#24605: test: Use MiniWallet in feature_coinstatsinde...
<manbruhpig>
Hello, I am completely clueless when it comes to doing this sort of stuff. But is it at all possible to chat privately with a bitcoin core dev?
<bitcoin-git>
[bitcoin] luke-jr reopened pull request #24629: Bugfix: RPC/blockchain: pruneblockchain: Return the height of the actual last pruned block (master...bugfix_rpc_prunebc_retval) https://github.com/bitcoin/bitcoin/pull/24629
<bitcoin-git>
[bitcoin] luke-jr closed pull request #24629: Bugfix: RPC/blockchain: pruneblockchain: Return the height of the actual last pruned block (master...bugfix_rpc_prunebc_retval) https://github.com/bitcoin/bitcoin/pull/24629
2022-03-21
<bitcoin-git>
[bitcoin] luke-jr opened pull request #24633: Bugfix: configure: Quote SUPPRESS_WARNINGS sufficiently to preserve brackets (master...bugfix_suppresswarnings_regex) https://github.com/bitcoin/bitcoin/pull/24633
<bitcoin-git>
[bitcoin] 1440000bytes opened pull request #24632: print `Warnings:` only if warning returned (master...getinfo-warning) https://github.com/bitcoin/bitcoin/pull/24632
<gribble>
https://github.com/bitcoin/bitcoin/issues/559 | -acceptnonstdtxn option to skip "non-standard transaction" checks by luke-jr · Pull Request #559 · bitcoin/bitcoin · GitHub
<bitcoin-git>
[bitcoin] achow101 merged pull request #13226: Optimize SelectCoinsBnB by tracking the selection by index rather than by position (master...select-bnb-by-index) https://github.com/bitcoin/bitcoin/pull/13226
<bitcoin-git>
bitcoin/master 1dd0923 Ben Woosley: refactor: Track BnB selection by index
<bitcoin-git>
bitcoin/master def43a4 Ben Woosley: refactor: Rename i to curr_try in SelectCoinsBnB
<bitcoin-git>
bitcoin/master 9d20052 Ben Woosley: doc: Revise comments and whitespace to clarify
<bitcoin-git>
[bitcoin] mzumsande opened pull request #24630: index: reset indexes when running reindex-chainstate (master...202203_index_reindex_cs) https://github.com/bitcoin/bitcoin/pull/24630
<bitcoin-git>
[bitcoin] luke-jr opened pull request #24629: Bugfix: RPC/blockchain: pruneblockchain: Return the height of the actual last pruned block (master...bugfix_rpc_prunebc_retval) https://github.com/bitcoin/bitcoin/pull/24629
<cocoon>
stickies-v: I was able to find a node with non default port on mainnet by running bitcoin-core-23.0/test.rc2: "addr": "95.161.13.44:59333". Should be a successful test according to vasild as it was auto outbound connection and port is not 8333.
<bitcoin-git>
[bitcoin] fanquake closed pull request #21073: wallet: check when create wallets for the reserved name "wallets" (master...sanitycheck) https://github.com/bitcoin/bitcoin/pull/21073
<bitcoin-git>
[bitcoin] fanquake closed pull request #14866: [wip] util: Improve evaluation of includeconf lines in network sections of the config file (master...includeconf_eval_at_its_position) https://github.com/bitcoin/bitcoin/pull/14866
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #24627: test: Limit scope of id global which is shared between subtests (master...2203-gid-🥒) https://github.com/bitcoin/bitcoin/pull/24627
<bitcoin-git>
[bitcoin] MarcoFalke closed pull request #17443: Drop checkFinalTx and use Median Time Past to check finality of wallet transactions (master...2019-11-fix-final-wallet) https://github.com/bitcoin/bitcoin/pull/17443
<bitcoin-git>
[bitcoin] MarcoFalke closed pull request #16199: rpc: fix showing wrong amount when not all inputs are from me in gettransaction (master...master) https://github.com/bitcoin/bitcoin/pull/16199
<bitcoin-git>
[bitcoin] mzumsande opened pull request #24626: init: disallow reindex-chainstate when pruning (master...202203_reindex_cs_prune) https://github.com/bitcoin/bitcoin/pull/24626
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #24625: Replace struct update_fee_delta with lambda (master...2203-refactor-fee-delta-🔶) https://github.com/bitcoin/bitcoin/pull/24625
<bitcoin-git>
bitcoin/master 3a46399 fanquake: build: remove unused QMAKE_* VARs
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #23880: p2p: Serialize cmpctblock at most once in NewPoWValidBlock (master...2112-p2pAsync) https://github.com/bitcoin/bitcoin/pull/23880