2021-06-25

< bitcoin-git> [bitcoin] Sjors opened pull request #22341: rpc: add getxpub (master...2021/06/getxpub) https://github.com/bitcoin/bitcoin/pull/22341
< bitcoin-git> [bitcoin] dergoegge opened pull request #22340: Use legacy relaying to download blocks in blocks-only mode (master...nocmpct_blocksonly) https://github.com/bitcoin/bitcoin/pull/22340
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19362: rpc/blockchain: Reset scantxoutset progress before inferring descriptors (master...rpc-scantxoutset-reset-progress) https://github.com/bitcoin/bitcoin/pull/19362
< bitcoin-git> bitcoin/master 3e306ee MarcoFalke: Merge bitcoin/bitcoin#19362: rpc/blockchain: Reset scantxoutset progress b...
< bitcoin-git> bitcoin/master 8c4129b Pavol Rusnak: rpc: reset scantxoutset progress on finish
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/246daf1f537d...3e306ee1d5c7
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #22322: fuzz: Check banman roundtrip (master...2106-fuzzBanman) https://github.com/bitcoin/bitcoin/pull/22322
< bitcoin-git> bitcoin/master 246daf1 MarcoFalke: Merge bitcoin/bitcoin#22322: fuzz: Check banman roundtrip
< bitcoin-git> bitcoin/master fa485d0 MarcoFalke: fuzz: Check banman roundtrip
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b2f5c38333fd...246daf1f537d
< bitcoin-git> [bitcoin] hebasto opened pull request #22339: doc: Update actual minimum supported compiler versions (master...210625-std) https://github.com/bitcoin/bitcoin/pull/22339

2021-06-24

< michaelfolkson> Bitcoin StackExchange, Bitcoin Core PR review club, Bitcoin Optech too.
< Guest30> Hi, I'm looking to contribute to this community and/or the bitcoin core codebase. What's the best way for me to get started? Can someone point me in the right direction? Thanks!
< core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
< bitcoin-git> [bitcoin] sanket1729 opened pull request #22338: Change MAX_OPCODE to OP_CHECKSIGADD (master...opcode_test) https://github.com/bitcoin/bitcoin/pull/22338
<@gribble> https://github.com/bitcoin/bitcoin/issues/20861 | BIP 350: Implement Bech32m and use it for v1+ segwit addresses by sipa · Pull Request #20861 · bitcoin/bitcoin · GitHub
<@gribble> https://github.com/bitcoin/bitcoin/issues/19362 | rpc/blockchain: Reset scantxoutset progress before inferring descriptors by prusnak · Pull Request #19362 · bitcoin/bitcoin · GitHub
< sipa> where is advancing bitcoin?
< michaelfolkson> I'm biased but Advancing Bitcoin might be a good candidate conference. Especially as it would want some Core devs to speak and is more technical
<@gribble> https://github.com/bitcoin/bitcoin/issues/19438 | Introduce deploymentstatus by ajtowns · Pull Request #19438 · bitcoin/bitcoin · GitHub
< laanwj> https://github.com/bitcoin/bitcoin/milestone/47 we're slowly but surely getting through 22.0-tagged PRs
< laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos
< core-meetingbot> Meeting started Thu Jun 24 19:01:17 2021 UTC. The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
< bitcoin-git> [bitcoin] achow101 opened pull request #22337: wallet: Use bilingual_str for errors (master...wallet-bilingualstr) https://github.com/bitcoin/bitcoin/pull/22337
< GIANTWORLDKEEPER> anyone knows why ban on #bitcoin-core-dev at freenode?
< andytoshi> MarcoFalke: just want to say thanks for https://github.com/bitcoin/bitcoin/pull/20560 ... i am merging (and build/test/fuzzing) all the 22.0 PRs from bitcoin into elements one-by-one, and the speedup building the fuzztests is *incredible*, i'm getting through PRs 25-30% faster
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #22327: cli: Avoid truncating -rpcwaittimeout (master...2106-cliTrunkTime) https://github.com/bitcoin/bitcoin/pull/22327
< bitcoin-git> bitcoin/master b2f5c38 MarcoFalke: Merge bitcoin/bitcoin#22327: cli: Avoid truncating -rpcwaittimeout
< bitcoin-git> bitcoin/master fa34cb8 MarcoFalke: cli: Avoid truncating -rpcwaittimeout
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0553d75268a9...b2f5c38333fd
< bitcoin-git> [bitcoin] kiminuo opened pull request #22336: [TESTBED][NO-MERGE][POC] Use std::filesystem. Remove Boost Filesystem & System (master...feature/use_std_filesystem_testbed) https://github.com/bitcoin/bitcoin/pull/22336
< bitcoin-git> [bitcoin] theStack opened pull request #22335: doc: recommend `--disable-external-signer` in OpenBSD build guide (master...202106-doc-openbsd_mention_missing_external_signer_support) https://github.com/bitcoin/bitcoin/pull/22335
< bitcoin-git> bitcoin/master 699dfcd Andrew Chow: Opportunistically use bech32m change addresses if available
< bitcoin-git> [bitcoin] laanwj merged pull request #22154: Add OutputType::BECH32M and related wallet support for fetching bech32m addresses (master...outputtype-bech32m) https://github.com/bitcoin/bitcoin/pull/22154
< bitcoin-git> bitcoin/master 0262536 Andrew Chow: Add OutputType::BECH32M
< bitcoin-git> bitcoin/master 177c15d Andrew Chow: Limit LegacyScriptPubKeyMan address types
< bitcoin-git> [bitcoin] laanwj pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/b7565c708dc1...0553d75268a9
< bitcoin-git> [bitcoin] laanwj merged pull request #22250: doc: add basic I2P documentation (master...i2p_doc) https://github.com/bitcoin/bitcoin/pull/22250
< bitcoin-git> bitcoin/master b7565c7 W. J. van der Laan: Merge bitcoin/bitcoin#22250: doc: add basic I2P documentation
< bitcoin-git> bitcoin/master 78cdab1 Vasil Dimov: doc: sort entries in doc/README.md#Miscellaneous alphabetically
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/e59ea87954fa...b7565c708dc1
< bitcoin-git> bitcoin/master cad487b Vasil Dimov: doc: add basic I2P documentation
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #22311: test: Add missing syncwithvalidationinterfacequeue in p2p_blockfilters (master...2106-testsyncwithvalidationinterfacequeue) https://github.com/bitcoin/bitcoin/pull/22311
< bitcoin-git> bitcoin/master fa1668b MarcoFalke: test: Run pep-8
< bitcoin-git> bitcoin/master faa211f MarcoFalke: test: Misc cleanup
< bitcoin-git> bitcoin/master facd97a MarcoFalke: scripted-diff: Renames
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/d6a59166a187...e59ea87954fa
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #22257: test: refactor: various (de)serialization helpers cleanups/improvements (master...202106-test-refactor-replace_manual_deser_with_fromtohex) https://github.com/bitcoin/bitcoin/pull/22257
< bitcoin-git> bitcoin/master 1914054 Sebastian Falbesoner: scripted-diff: test: rename `FromHex` to `from_hex`
< bitcoin-git> bitcoin/master a79396f Sebastian Falbesoner: test: remove `ToHex` helper, use .serialize().hex() instead
< bitcoin-git> bitcoin/master 2ce7b47 Sebastian Falbesoner: test: introduce `tx_from_hex` helper for tx deserialization
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/c31161f4f79b...d6a59166a187
< bitcoin-git> [bitcoin] fanquake merged pull request #22306: [test] Improvements to p2p_addr_relay.py (master...2021-06-addr-tests) https://github.com/bitcoin/bitcoin/pull/22306
< bitcoin-git> [bitcoin] fanquake merged pull request #22320: build: set minimum required Boost to 1.64.0 (master...minimum_ubuntu_18_04) https://github.com/bitcoin/bitcoin/pull/22320
< bitcoin-git> bitcoin/master 957f358 fanquake: build: remove check for Boost Process header
< bitcoin-git> bitcoin/master df2c933 fanquake: build: remove workaround for Boost and std::atomic
< bitcoin-git> bitcoin/master 2bf2116 fanquake: build: set minimum required Boost to 1.64.0
< bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/bfa885898a5f...c31161f4f79b
< bitcoin-git> bitcoin/master ef2f149 Amiti Uttarwar: [test] Update GetAddrStore callers to use AddrReceiver
< bitcoin-git> bitcoin/master 09dc073 Amiti Uttarwar: [test] Allow AddrReceiver to be used more generally
< bitcoin-git> bitcoin/master e8c67ea Amiti Uttarwar: [test] Add functionality to AddrReceiver
< bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/a196c89317dd...bfa885898a5f
< bitcoin-git> [bitcoin] laanwj closed pull request #22294: build: Perform boost::process detection with BOOST_CPPFLAGS (master...2021-06-boost-process-detection) https://github.com/bitcoin/bitcoin/pull/22294
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #22270: test: Add bitcoin-util tests (+refactors) (master...2106-utilTestDoc) https://github.com/bitcoin/bitcoin/pull/22270
< bitcoin-git> bitcoin/master fa3c1ee MarcoFalke: Remove unused includes from bitcoin-util
< bitcoin-git> bitcoin/master fa30492 MarcoFalke: test: Add bitcoin-util tests
< bitcoin-git> bitcoin/master fa831e7 MarcoFalke: build_msvc: Add bitcoin-util.exe
< bitcoin-git> [bitcoin] MarcoFalke pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/7317e14a44c6...a196c89317dd
< bitcoin-git> [bitcoin] S3RK opened pull request #22334: wallet: do not spam about non-existent spk managers (master...stop_non_existing_spkman_spam) https://github.com/bitcoin/bitcoin/pull/22334
< bitcoin-git> [gui] luke-jr opened pull request #368: Bugfix: GUI: When restoring table columns, still set their minimum column width and stretch on last section (master...bugfix_gui_restored_columns_stretch) https://github.com/bitcoin-core/gui/pull/368

2021-06-23

< bitcoin-git> [bitcoin] dhruv opened pull request #22331: [crypto] Fix K1/K2 use in ChaCha20-Poly1305 AEAD (master...15649-followups) https://github.com/bitcoin/bitcoin/pull/22331
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #22263: refactor: wrap CCoinsViewCursor in unique_ptr (master...2021-06-cursor-unique-ptr) https://github.com/bitcoin/bitcoin/pull/22263
< bitcoin-git> bitcoin/master 7ad414f James O'Beirne: doc: add comment about CCoinsViewDBCursor constructor
< bitcoin-git> bitcoin/master 0f8a5a4 James O'Beirne: move-only(ish): don't expose CCoinsViewDBCursor
< bitcoin-git> bitcoin/master 615c1ad James O'Beirne: refactor: wrap CCoinsViewCursor in unique_ptr
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/c0e30933e0d3...7317e14a44c6
< bitcoin-git> [bitcoin] theStack opened pull request #22330: test: use MiniWallet for simple doublespend sub-test in feature_rbf.py (master...202106-test-feature_rbf_use_miniwallet_for_doublespend) https://github.com/bitcoin/bitcoin/pull/22330
< vasild> jonatack: posted a summary at https://github.com/bitcoin/bitcoin/issues/21389#issuecomment-866925116, will sleep over this and re-evaluate
<@gribble> https://github.com/bitcoin/bitcoin/issues/21526 | validation: UpdateTip/CheckBlockIndex assumeutxo support by jamesob · Pull Request #21526 · bitcoin/bitcoin · GitHub
<@gribble> https://github.com/bitcoin/bitcoin/issues/21389 | It is possible to open >1 connections to the same I2P node · Issue #21389 · bitcoin/bitcoin · GitHub
<@gribble> https://github.com/bitcoin/bitcoin/issues/22112 | Force port 0 in I2P by vasild · Pull Request #22112 · bitcoin/bitcoin · GitHub
<@gribble> https://github.com/bitcoin/bitcoin/issues/21514 | p2p: Ignore ports on I2P addresses by vasild · Pull Request #21514 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #22323: doc: spelling update (master...spelling-update) https://github.com/bitcoin/bitcoin/pull/22323
< bitcoin-git> bitcoin/master c0e3093 MarcoFalke: Merge bitcoin/bitcoin#22323: doc: spelling update
< bitcoin-git> bitcoin/master 184d453 Jon Atack: script, doc: spelling update
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/567670bec5ec...c0e30933e0d3
<@gribble> https://github.com/bitcoin/bitcoin/issues/22179 | Torv2 removal followups by vasild · Pull Request #22179 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #22327: cli: Avoid truncating -rpcwaittimeout (master...2106-cliTrunkTime) https://github.com/bitcoin/bitcoin/pull/22327
< bitcoin-git> [bitcoin] jonatack opened pull request #22323: script, doc: spelling update (master...spelling-update) https://github.com/bitcoin/bitcoin/pull/22323
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #22322: fuzz: Check banman roundtrip (master...2106-fuzzBanman) https://github.com/bitcoin/bitcoin/pull/22322
< bitcoin-git> bitcoin/master c7388e5 Pieter Wuille: Report address as solvable based on inferred descriptor
< bitcoin-git> bitcoin/master d637a9b Pieter Wuille: Taproot descriptor inference
< bitcoin-git> [bitcoin] meshcollider merged pull request #22166: Add support for inferring tr() descriptors (master...202106_infer_tap) https://github.com/bitcoin/bitcoin/pull/22166
< bitcoin-git> bitcoin/master 29e5dd1 Pieter Wuille: consensus refactor: extract ComputeTapleafHash, ComputeTaprootMerkleRoot
< bitcoin-git> [bitcoin] meshcollider pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/d6e0d78c3155...567670bec5ec
< vasild> it will only be a problem if some bitcoin node exists which uses SAM 3.2 and "listens" on port 8333 only (checks TO_PORT and drops the incoming connection if it is not 8333)
<@gribble> https://github.com/bitcoin/bitcoin/issues/22250 | doc: add basic I2P documentation by vasild · Pull Request #22250 · bitcoin/bitcoin · GitHub
< vasild> MarcoFalke: am I supposed to edit https://github.com/bitcoin-core/bitcoin-devwiki/wiki/22.0-Release-Notes-draft directly and add the above?
<@gribble> https://github.com/bitcoin/bitcoin/issues/20685 | Add I2P support using I2P SAM by vasild · Pull Request #20685 · bitcoin/bitcoin · GitHub
< vasild> * Added support for running Bitcoin Core as an [I2P (Invisible Internet Project)](https://en.wikipedia.org/wiki/I2P) service and connect to such services. See doc/i2p.md for details. (#20685)
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20966: banman: save the banlist in a JSON format on disk (master...json_bans) https://github.com/bitcoin/bitcoin/pull/20966
< bitcoin-git> bitcoin/master 24b10eb Vasil Dimov: doc: fix grammar in doc/files.md
< bitcoin-git> bitcoin/master dd4e957 Vasil Dimov: test: ensure banlist can be read from disk after restart
< bitcoin-git> bitcoin/master d197977 Vasil Dimov: banman: save the banlist in a JSON format on disk
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/03aa59a4e58f...d6e0d78c3155
< bitcoin-git> [bitcoin] hebasto opened pull request #22321: build: Avoid qt-specific @GLIBC_2.28 symbols for compatibility (master...210623-statx) https://github.com/bitcoin/bitcoin/pull/22321
< bitcoin-git> [bitcoin] fanquake opened pull request #22320: build: set minimum required Boost to 1.64.0 (master...minimum_ubuntu_18_04) https://github.com/bitcoin/bitcoin/pull/22320
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #22313: test: Add missing sync_all to feature_coinstatsindex (master...2106-testSync) https://github.com/bitcoin/bitcoin/pull/22313
< bitcoin-git> bitcoin/master 03aa59a MarcoFalke: Merge bitcoin/bitcoin#22313: test: Add missing sync_all to feature_coinsta...
< bitcoin-git> bitcoin/master fafd916 MarcoFalke: test: Add missing sync_all to feature_coinstatsindex
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c93e123dc72b...03aa59a4e58f
< bitcoin-git> [bitcoin] hebasto opened pull request #22318: build: Avoid @GLIBC_2.25 symbols for compatibility (master...210623-random) https://github.com/bitcoin/bitcoin/pull/22318
< bitcoin-git> [bitcoin] prayank23 closed pull request #21157: doc: Improve Tor docs (master...tor-docs-add) https://github.com/bitcoin/bitcoin/pull/21157
< bitcoin-git> [bitcoin] prayank23 opened pull request #22317: doc: Highlight DNS requests part in tor.md (master...highlight-dns-request) https://github.com/bitcoin/bitcoin/pull/22317
< bitcoin-git> [bitcoin] prayank23 opened pull request #22316: doc: Add 5 privacy recommendations in tor.md (master...tor-privacy-recommend) https://github.com/bitcoin/bitcoin/pull/22316

2021-06-22

< darosior> morcos: why does the fee estimator disregard CPFP? You mentioned in https://www.mail-archive.com/bitcoin-development@lists.sourceforge.net/msg06405.html that it would skew estimates, but how so? I don't have statistics but i think CPFP is widely used on the network and might be even more in the future with package relay and it becoming a first
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #22308: wallet: Add missing BlockUntilSyncedToCurrentChain (master...2106-wallet) https://github.com/bitcoin/bitcoin/pull/22308
< bitcoin-git> bitcoin/master c93e123 MarcoFalke: Merge bitcoin/bitcoin#22308: wallet: Add missing BlockUntilSyncedToCurrent...
< bitcoin-git> bitcoin/master fa27baa MarcoFalke: Revert "test: Add temporary logging to debug #20975"
< bitcoin-git> bitcoin/master fadb550 MarcoFalke: wallet: Add missing BlockUntilSyncedToCurrentChain
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/327e2691f6e0...c93e123dc72b
< dhruv> BIP324 question: Does the 3-byte encrypted length in the proposed AEAD construct include the 3 bytes of the length itself? The test vector here seems to imply so but it would be nice to confirm: https://github.com/bitcoin/bitcoin/blob/327e2691f6e0498aa868af965bb4a951c5be17c5/src/test/crypto_tests.cpp#L710
<@gribble> https://github.com/bitcoin/bitcoin/issues/17487 | coins: allow write to disk without cache drop by jamesob · Pull Request #17487 · bitcoin/bitcoin · GitHub
< bitcoin-git> [gui] luke-jr opened pull request #366: Dark Mode fixes/portability (master...gui_palettechange) https://github.com/bitcoin-core/gui/pull/366
< bitcoin-git> [bitcoin] nourou4them opened pull request #22314: doc: Install WSL on non-system drive and compile Bitcoin (master...patch-1) https://github.com/bitcoin/bitcoin/pull/22314
<@gribble> https://github.com/bitcoin/bitcoin/issues/22263 | refactor: wrap CCoinsViewCursor in unique_ptr by jamesob · Pull Request #22263 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #22313: test: Add missing sync_all to feature_coinstatsindex (master...2106-testSync) https://github.com/bitcoin/bitcoin/pull/22313
< bitcoin-git> [bitcoin] siv2r opened pull request #22312: changes for wait_for_getheaders to include hash_list (master...modify-wait-getheaders) https://github.com/bitcoin/bitcoin/pull/22312
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #22311: test: Add missing syncwithvalidationinterfacequeue in p2p_blockfilters (master...2106-testsyncwithvalidationinterfacequeue) https://github.com/bitcoin/bitcoin/pull/22311
< bitcoin-git> [bitcoin] ariard opened pull request #22310: test: Add functional test for replacement penalty check (master...2021-06-add-rbf5-test) https://github.com/bitcoin/bitcoin/pull/22310
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #22309: blockstorage: Add missing atomic include (master...2106-include) https://github.com/bitcoin/bitcoin/pull/22309
< bitcoin-git> bitcoin/master 327e269 MarcoFalke: Merge bitcoin/bitcoin#22309: blockstorage: Add missing atomic include
< bitcoin-git> bitcoin/master fa2d21f MarcoFalke: add missing atomic include
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/672870ab7ba5...327e2691f6e0
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #22309: blockstorage: Add missing atomic include (master...2106-include) https://github.com/bitcoin/bitcoin/pull/22309
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #22308: wallet: Add missing BlockUntilSyncedToCurrentChain (master...2106-wallet) https://github.com/bitcoin/bitcoin/pull/22308
< bitcoin-git> [bitcoin] rebroad opened pull request #22307: Detect when GETBLOCKTXN requests are ignored. (master...DetectIngoredGetblocktxns) https://github.com/bitcoin/bitcoin/pull/22307
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #22201: test: Fix TestShell to allow running in Jupyter Notebook (master...josibake-parse-only-known-arguments-in-testshell) https://github.com/bitcoin/bitcoin/pull/22201
< bitcoin-git> bitcoin/master 168b6c3 Josiah Baker: add dummy file param to fix jupyter
< bitcoin-git> bitcoin/master 672870a MarcoFalke: Merge bitcoin/bitcoin#22201: test: Fix TestShell to allow running in Jupyt...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/398dd6783389...672870ab7ba5
< bitcoin-git> [bitcoin] amitiuttarwar opened pull request #22306: [test] Improvements to p2p_addr_relay.py (master...2021-06-addr-tests) https://github.com/bitcoin/bitcoin/pull/22306
< bitcoin-git> [bitcoin] hebasto opened pull request #22305: build: Avoid fcntl64@GLIBC_2.28 in libsqlite3.a (master...210622-fcntl) https://github.com/bitcoin/bitcoin/pull/22305

2021-06-21

< bitcoin-git> [bitcoin] hebasto closed pull request #22304: CryptoGraphyBTC><Acnre1ccfdo. (master...patch-8) https://github.com/bitcoin/bitcoin/pull/22304
< bitcoin-git> [bitcoin] amanciojsilvjr opened pull request #22304: CryptoGraphyBTC><Acnre1ccfdo. (master...patch-8) https://github.com/bitcoin/bitcoin/pull/22304
< bitcoin-git> [bitcoin] sipa closed pull request #22303: Create Bitcoin<>nuclear.defense (master...patch-4) https://github.com/bitcoin/bitcoin/pull/22303
< bitcoin-git> [bitcoin] amanciojsilvjr opened pull request #22303: Create Bitcoin<>nuclear.defense (master...patch-4) https://github.com/bitcoin/bitcoin/pull/22303
< bitcoin-git> [bitcoin] sipa closed pull request #22302: Create Bitcoin<>nuclear.defense (master...patch-6) https://github.com/bitcoin/bitcoin/pull/22302
< bitcoin-git> [bitcoin] amanciojsilvjr opened pull request #22302: Create Bitcoin<>nuclear.defense (master...patch-6) https://github.com/bitcoin/bitcoin/pull/22302
< bitcoin-git> [bitcoin] sipa closed pull request #22301: Amanciojsilvjr patch 2 (master...amanciojsilvjr-patch-2) https://github.com/bitcoin/bitcoin/pull/22301
< bitcoin-git> [bitcoin] amanciojsilvjr reopened pull request #22301: Amanciojsilvjr patch 2 (master...amanciojsilvjr-patch-2) https://github.com/bitcoin/bitcoin/pull/22301
< bitcoin-git> [bitcoin] amanciojsilvjr closed pull request #22301: Amanciojsilvjr patch 2 (master...amanciojsilvjr-patch-2) https://github.com/bitcoin/bitcoin/pull/22301
< bitcoin-git> [bitcoin] amanciojsilvjr opened pull request #22301: Amanciojsilvjr patch 2 (master...amanciojsilvjr-patch-2) https://github.com/bitcoin/bitcoin/pull/22301
< bitcoin-git> [bitcoin] sipa closed pull request #22300: Create Bitcoin<>nuclear.defense (master...patch-6) https://github.com/bitcoin/bitcoin/pull/22300
< bitcoin-git> [bitcoin] amanciojsilvjr opened pull request #22300: Create Bitcoin<>nuclear.defense (master...patch-6) https://github.com/bitcoin/bitcoin/pull/22300
< bitcoin-git> [bitcoin] sipa closed pull request #22299: Create Bitcoin<>nuclear.defense (master...patch-4) https://github.com/bitcoin/bitcoin/pull/22299
< bitcoin-git> [bitcoin] amanciojsilvjr opened pull request #22299: Create Bitcoin<>nuclear.defense (master...patch-4) https://github.com/bitcoin/bitcoin/pull/22299
< bitcoin-git> [bitcoin] sipa closed pull request #22298: CryptoGraphyBTC (master...master) https://github.com/bitcoin/bitcoin/pull/22298
< bitcoin-git> [bitcoin] amanciojsilvjr opened pull request #22298: CryptoGraphyBTC (master...master) https://github.com/bitcoin/bitcoin/pull/22298
< bitcoin-git> [bitcoin] sipa closed pull request #22297: Bitcoin<>nuclear (master...master) https://github.com/bitcoin/bitcoin/pull/22297
< bitcoin-git> [bitcoin] amanciojsilvjr opened pull request #22297: Bitcoin<>nuclear (master...master) https://github.com/bitcoin/bitcoin/pull/22297
< dongcarl> Sorry, just caught up on the discussion here... orionwl[m] laanwj hebasto see #bitcoin-core-builds for some of my thoughts
< angela> Hello! :) I have been reading a lot about bitcoin recently and have been thoroughly moved! I want to start understanding and contributing to bitcoin-core. Can someone recommend good newbie contributor resources? Thanks
< bitcoin-git> [bitcoin] amitiuttarwar reopened pull request #21528: [p2p] Reduce addr blackholes (master...2021-03-addr-defer2) https://github.com/bitcoin/bitcoin/pull/21528
< bitcoin-git> [bitcoin] amitiuttarwar closed pull request #21528: [p2p] Reduce addr blackholes (master...2021-03-addr-defer2) https://github.com/bitcoin/bitcoin/pull/21528
< * MarcoFalke> (mic) Release notes now being edited on https://github.com/bitcoin-core/bitcoin-devwiki/wiki/22.0-Release-Notes-draft
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #22296: doc: Final merge of release notes snippets, mv to wiki (master...2106-doRel) https://github.com/bitcoin/bitcoin/pull/22296
< bitcoin-git> bitcoin/master 398dd67 MarcoFalke: Merge bitcoin/bitcoin#22296: doc: Final merge of release notes snippets, m...
< bitcoin-git> bitcoin/master fa09fd1 MarcoFalke: doc: Final merge of release notes snippets
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/74013641e035...398dd6783389
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #22296: doc: Final merge of release notes snippets (master...2106-doRel) https://github.com/bitcoin/bitcoin/pull/22296
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #22089: test: MiniWallet: fix fee calculation for P2PK and check tx vsize (master...202105-test-miniwallet-fix_p2pk_fee_calculation) https://github.com/bitcoin/bitcoin/pull/22089
< bitcoin-git> bitcoin/master 7401364 MarcoFalke: Merge bitcoin/bitcoin#22089: test: MiniWallet: fix fee calculation for P2P...
< bitcoin-git> bitcoin/master d6d2ab9 Sebastian Falbesoner: test: MiniWallet: fix fee calculation for P2PK and check tx vsize
< bitcoin-git> bitcoin/master ce024b1 Sebastian Falbesoner: test: MiniWallet: force P2PK signature to have fixed size (71 bytes)
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/6556da77d75f...74013641e035
< bitcoin-git> [bitcoin] laanwj merged pull request #21056: rpc: Add a `-rpcwaittimeout` parameter to limit time spent waiting (master...rpcwait-timeout) https://github.com/bitcoin/bitcoin/pull/21056
< bitcoin-git> bitcoin/master f76cb10 Christian Decker: rpc: Prefix rpcwaittimeout error with details on its nature
< bitcoin-git> bitcoin/master a7fcc8e Christian Decker: rpc: Add a `-rpcwaittimeout` parameter to limit time spent waiting
< bitcoin-git> bitcoin/master c490e17 Christian Decker: doc: Add release notes for the `-rpcwaittimeout` cli parameter
< bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/6a67366fdc3e...6556da77d75f
< Kiminuo> Hi, would anyone know how to correctly write L1562 ad L1563 here https://github.com/bitcoin/bitcoin/pull/21422#pullrequestreview-675206546?
< bitcoin-git> [bitcoin] laanwj opened pull request #22294: build: Perform boost::process detection with BOOST_CPPFLAGS (master...2021-06-boost-process-detection) https://github.com/bitcoin/bitcoin/pull/22294
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #20509: net: CAddress deser: use stream's version, not what's coming from disk (master...caddress_deser_version) https://github.com/bitcoin/bitcoin/pull/20509
< bitcoin-git> [bitcoin] laanwj merged pull request #19033: http: Release work queue after event base finish (master...2020-05-fix-race-interrupt-http-server) https://github.com/bitcoin/bitcoin/pull/19033
< bitcoin-git> bitcoin/master 6a67366 W. J. van der Laan: Merge bitcoin/bitcoin#19033: http: Release work queue after event base fin...
< bitcoin-git> bitcoin/master 4e353cb João Barbosa: http: Release work queue after event base finish
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f6a25bea826e...6a67366fdc3e
< hebasto> are we going to provide ARM 32-bit binaries for 22.0 release? (context - https://github.com/bitcoin/bitcoin/pull/22287#issuecomment-864741303)
< bitcoin-git> [bitcoin] laanwj merged pull request #22147: p2p: Protect last outbound HB compact block peer (master...2021-06-reserve-outbound-hb) https://github.com/bitcoin/bitcoin/pull/22147
< bitcoin-git> bitcoin/master f6a25be W. J. van der Laan: Merge bitcoin/bitcoin#22147: p2p: Protect last outbound HB compact block p...
< bitcoin-git> bitcoin/master 30aee2d Pieter Wuille: tests: Add test for compact block HB selection
< bitcoin-git> bitcoin/master 6efbcec Suhas Daftuar: Protect last outbound HB compact block peer
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/a305a687e70c...f6a25bea826e
< bitcoin-git> [bitcoin] laanwj merged pull request #22244: devtools: Correctly extract symbol versions in symbol-check (master...2021-06-pixie) https://github.com/bitcoin/bitcoin/pull/22244
< bitcoin-git> bitcoin/master e8cd370 W. J. van der Laan: devtools: Integrate ARCH_MIN_GLIBC_VER table into MAX_VERSIONS in symbol-c...
< bitcoin-git> bitcoin/master a33381a W. J. van der Laan: devtools: Add xkb version to symbol-check
< bitcoin-git> bitcoin/master 19e598b W. J. van der Laan: devtools: Fix verneed section parsing in pixie
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/965e93743454...a305a687e70c

2021-06-20

< bitcoin-git> [bitcoin] jonatack opened pull request #22292: bench, doc: benchmarking updates and fixups (master...benchmarking-updates) https://github.com/bitcoin/bitcoin/pull/22292
< bitcoin-git> [bitcoin] ViralTaco opened pull request #22291: Added comment about narrow contract for Span(T* begin, T* end) ctor (master...master) https://github.com/bitcoin/bitcoin/pull/22291
< bitcoin-git> [bitcoin] glozow opened pull request #22290: Package Mempool Submission with Package Fee-Bumping (master...package-mempool-accept) https://github.com/bitcoin/bitcoin/pull/22290
< bitcoin-git> [bitcoin] adriansmares opened pull request #22288: Resolve Tor control plane address (master...feature/tor-control-dns-resolve) https://github.com/bitcoin/bitcoin/pull/22288
< bitcoin-git> [bitcoin] hebasto reopened pull request #22287: build: Avoid fcntl64@GLIBC_2.28 symbol when --enable-glibc-back-compat (master...210619-fcntl) https://github.com/bitcoin/bitcoin/pull/22287
< bitcoin-git> [bitcoin] hebasto closed pull request #22287: build: Avoid fcntl64@GLIBC_2.28 symbol when --enable-glibc-back-compat (master...210619-fcntl) https://github.com/bitcoin/bitcoin/pull/22287
< bitcoin-git> [bitcoin] hebasto opened pull request #22287: build: Avoid fcntl64@GLIBC_2.28 symbol when --enable-glibc-back-compat (master...210619-fcntl) https://github.com/bitcoin/bitcoin/pull/22287

2021-06-19

< kittywhiskers> i think the idea of having a refactor where all references to bitcoin in filenames are replaced with core and all mentions of Bitcoin in the source lead back to a static variable is worth considering
< kittywhiskers> similar to the PR that unified all uses of BTC across the codebase, now that with the word Bitcoin itself
< kittywhiskers> would a PR that tries to unify all instances of the word "Bitcoin" be welcome?
< kittywhiskers> i did some preliminary work on getting bitcoin core to build using cmake, like how monero does it
< sipa> we do have our fork of leveldb; https://github.com/bitcoin-core/leveldb
< bitcoin-git> [bitcoin] whitslack opened pull request #22285: contrib/init: (OpenRC) use -startupnotify to wait for startup completion (master...openrc-startupnotify) https://github.com/bitcoin/bitcoin/pull/22285
< bitcoin-git> [bitcoin] jonatack opened pull request #22284: p2p, refactor: performance improvements to ProtectEvictionCandidatesByRatio() (master...ProtectEvictionCandidatesByRatio-perf-enhancements) https://github.com/bitcoin/bitcoin/pull/22284
< bitcoin-git> [bitcoin] dgoncharov opened pull request #22283: build: Replace $(AT) with .SILENCE. (master...replace_AT_with_dotsilence) https://github.com/bitcoin/bitcoin/pull/22283
< bitcoin-git> [bitcoin] klementtan opened pull request #22282: refactor: CheckFinalTx pass by reference instead of ptr (master...CheckFinalTx_ptr_to_ref) https://github.com/bitcoin/bitcoin/pull/22282
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #22192: [0.20] gitian: Use custom MacOS code signing tool (0.20...0.20-signapple) https://github.com/bitcoin/bitcoin/pull/22192
< bitcoin-git> bitcoin/0.20 9c7c0e6 Andrew Chow: gitian: use signapple to create the MacOS code signature
< bitcoin-git> bitcoin/0.20 f834485 Andrew Chow: gitian: use signapple to apply the MacOS code signature
< bitcoin-git> bitcoin/0.20 a2650f6 Andrew Chow: gitian: install signapple in gitian-osx-signer.yml
< bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to 0.20: https://github.com/bitcoin/bitcoin/compare/5d2ebdd2b71f...466acb3fbcf5
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #22191: [0.21] gitian: Use custom MacOS code signing tool (0.21...0.21-signapple) https://github.com/bitcoin/bitcoin/pull/22191
< bitcoin-git> bitcoin/0.21 27d691b Andrew Chow: gitian: use signapple to create the MacOS code signature
< bitcoin-git> bitcoin/0.21 2f33e33 Andrew Chow: gitian: use signapple to apply the MacOS code signature
< bitcoin-git> bitcoin/0.21 65ce833 Andrew Chow: gitian: install signapple in gitian-osx-signer.yml
< bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to 0.21: https://github.com/bitcoin/bitcoin/compare/419f9b3b3b7c...926f76cb205c
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #22279: fuzz: add missing ECCVerifyHandle to base_encode_decode (master...2021-06--fuzztestix) https://github.com/bitcoin/bitcoin/pull/22279
< bitcoin-git> bitcoin/master 965e937 MarcoFalke: Merge bitcoin/bitcoin#22279: fuzz: add missing ECCVerifyHandle to base_enc...
< bitcoin-git> bitcoin/master 906d791 Andrew Poelstra: fuzz: add missing ECCVerifyHandle to base_encode_decode
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e172ea880498...965e93743454
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #22210: test: Use MiniWallet in test_no_inherited_signaling RBF test (master...2106-testMiniWallet) https://github.com/bitcoin/bitcoin/pull/22210
< bitcoin-git> bitcoin/master fab7e99 MarcoFalke: test: Use MiniWallet in test_no_inherited_signaling RBF test
< bitcoin-git> bitcoin/master fab871f MarcoFalke: test: Remove unused generate() from test
< bitcoin-git> bitcoin/master faff3f3 MarcoFalke: test: Add txin.sequence option to MiniWallet
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/0f47e01d7d49...e172ea880498
< bitcoin-git> [bitcoin] hebasto opened pull request #22281: build: Avoid @GLIBC_2.29 libm symbols when --enable-glibc-back-compat (master...210619-lm) https://github.com/bitcoin/bitcoin/pull/22281

2021-06-18

<@gribble> https://github.com/bitcoin/bitcoin/issues/22252 | policy: Trim Packages when transaction with same txid exists in mempool by glozow · Pull Request #22252 · bitcoin/bitcoin · GitHub
< ariard> glozow: have a look on my last comment in #22252 but also on my mail published today highlighting my thinking and the context we should consider, here https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2021-June/019084.html
< bitcoin-git> [bitcoin] apoelstra opened pull request #22279: fuzz: add missing ECCVerifyHandle to base_encode_decode (master...2021-06--fuzztestix) https://github.com/bitcoin/bitcoin/pull/22279
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #22278: Add LIFETIMEBOUND to CScript where needed (master...2106-scriptBound) https://github.com/bitcoin/bitcoin/pull/22278
< core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
<@gribble> https://github.com/bitcoin/bitcoin/issues/22275 | A few follow-ups for taproot signing by sipa · Pull Request #22275 · bitcoin/bitcoin · GitHub
<@gribble> https://github.com/bitcoin/bitcoin/issues/21329 | descriptor wallet: Cache last hardened xpub and use in normalized descriptors by achow101 · Pull Request #21329 · bitcoin/bitcoin · GitHub
<@gribble> https://github.com/bitcoin/bitcoin/issues/22166 | Add support for inferring tr() descriptors by sipa · Pull Request #22166 · bitcoin/bitcoin · GitHub
<@gribble> https://github.com/bitcoin/bitcoin/issues/22154 | Add OutputType::BECH32M and related wallet support for fetching bech32m addresses by achow101 · Pull Request #22154 · bitcoin/bitcoin · GitHub
<@gribble> https://github.com/bitcoin/bitcoin/issues/19651 | wallet: importdescriptors update existing by S3RK · Pull Request #19651 · bitcoin/bitcoin · GitHub
<@gribble> https://github.com/bitcoin/bitcoin/issues/22154 | Add OutputType::BECH32M and related wallet support for fetching bech32m addresses by achow101 · Pull Request #22154 · bitcoin/bitcoin · GitHub
<@gribble> https://github.com/bitcoin/bitcoin/issues/19651 | wallet: importdescriptors update existing by S3RK · Pull Request #19651 · bitcoin/bitcoin · GitHub
<@gribble> https://github.com/bitcoin/bitcoin/issues/21329 | descriptor wallet: Cache last hardened xpub and use in normalized descriptors by achow101 · Pull Request #21329 · bitcoin/bitcoin · GitHub
<@gribble> https://github.com/bitcoin/bitcoin/issues/22154 | Add OutputType::BECH32M and related wallet support for fetching bech32m addresses by achow101 · Pull Request #22154 · bitcoin/bitcoin · GitHub
<@gribble> https://github.com/bitcoin/bitcoin/issues/22166 | Add support for inferring tr() descriptors by sipa · Pull Request #22166 · bitcoin/bitcoin · GitHub
<@gribble> https://github.com/bitcoin/bitcoin/issues/22166 | Add support for inferring tr() descriptors by sipa · Pull Request #22166 · bitcoin/bitcoin · GitHub
<@gribble> https://github.com/bitcoin/bitcoin/issues/22154 | Add OutputType::BECH32M and related wallet support for fetching bech32m addresses by achow101 · Pull Request #22154 · bitcoin/bitcoin · GitHub
<@gribble> https://github.com/bitcoin/bitcoin/issues/21365 | Basic Taproot signing support for descriptor wallets by sipa · Pull Request #21365 · bitcoin/bitcoin · GitHub
< achow101> #bitcoin-core-dev wallet Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik petertodd
< core-meetingbot> Meeting started Fri Jun 18 19:01:11 2021 UTC. The chair is achow101. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
< bitcoin-git> [bitcoin] laanwj merged pull request #20923: signet miner followups (master...202101-signet-tweak) https://github.com/bitcoin/bitcoin/pull/20923
< bitcoin-git> bitcoin/master e665438 Anthony Towns: contrib/signet/miner: Automatic timestamp for first block
< bitcoin-git> bitcoin/master 1a45cd2 Anthony Towns: contrib/signet: Fix typos
< bitcoin-git> bitcoin/master a383ce5 Anthony Towns: contrib/signet/miner: --grind-cmd is required for calibrate
< bitcoin-git> [bitcoin] laanwj pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/da1e6d5911f0...0f47e01d7d49
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #14604: tests: Add test and refactor feature_block.py (master...feature-block-test) https://github.com/bitcoin/bitcoin/pull/14604
< bitcoin-git> bitcoin/master da1e6d5 MarcoFalke: Merge bitcoin/bitcoin#14604: tests: Add test and refactor feature_block.py...
< bitcoin-git> bitcoin/master 5531119 sanket1729: Added new test for future blocks reacceptance
< bitcoin-git> bitcoin/master 511a5af sanket1729: Fixed inconsistencies between code and comments
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/0844084c13af...da1e6d5911f0
< jonatack> yes, this reviewer encountered that issue IIUC: https://github.com/bitcoin/bitcoin/pull/22250#issuecomment-861824184
< vasild> I am not sure either, but it just does not seem right if a user has bothered to setup I2P proxy and configure bitcoin core to use it and to have 0 i2p connections (same for tor)
< vasild> should we use the seeds to establish at least one I2P connection, makes sense if the user has bothered setting up an I2P/SAM proxy? Came from https://github.com/bitcoin/bitcoin/pull/22250#discussion_r654480480
< vasild> so, is https://github.com/bitcoin/bitcoin/pull/20234 ok? any concerns or comments needed?
< vasild> laanwj: "it's not possible to not bind a P2P port at all" -- https://github.com/bitcoin/bitcoin/pull/20234 is not supposed to change this behavior which is - no, you can't specify "don't bind at all" using -bind=... if -bind is not given then we bind on 0.0.0.0, if -bind=foo is given then we bind on foo
<@gribble> https://github.com/bitcoin/bitcoin/issues/20234 | net: dont extra bind for Tor if binds are restricted by vasild · Pull Request #20234 · bitcoin/bitcoin · GitHub
<@gribble> https://github.com/bitcoin/bitcoin/issues/20234 | net: dont extra bind for Tor if binds are restricted by vasild · Pull Request #20234 · bitcoin/bitcoin · GitHub
< vasild> and also I did not want to turn the bitcoin doc i2p.md into "how to install and configure i2p router", which obviously belongs to that i2p router docs
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #19281: test: fix dangling bitcoind in functional tests (master...test_terminate_gracefully) https://github.com/bitcoin/bitcoin/pull/19281
< vasild> laanwj: "~monthly segfaults" -- I hope you mean i2pd, not bitcoin core
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #22249: test: kill process group to avoid dangling processes when using `--failfast` (master...test_kill_process_group) https://github.com/bitcoin/bitcoin/pull/22249
< bitcoin-git> bitcoin/master 0844084 MarcoFalke: Merge bitcoin/bitcoin#22249: test: kill process group to avoid dangling pr...
< bitcoin-git> bitcoin/master 451b96f S3RK: test: kill process group to avoid dangling processes
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/da69d9965a11...0844084c13af
<@gribble> https://github.com/bitcoin/bitcoin/issues/22250 | doc: add basic I2P documentation by vasild · Pull Request #22250 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] glozow reopened pull request #22253: validation: distinguish between same tx and same-nonwitness-data tx in mempool (master...2021-06-same-txid-diff-wtxid) https://github.com/bitcoin/bitcoin/pull/22253
< bitcoin-git> [bitcoin] glozow closed pull request #22253: validation: distinguish between same tx and same-nonwitness-data tx in mempool (master...2021-06-same-txid-diff-wtxid) https://github.com/bitcoin/bitcoin/pull/22253
< michaelfolkson> amiti: My two cents. I don't think you could have done any more to ensure everyone was aware of the PR and I can see why you're frustrated. A Bitcoin Core PR review club, bringing it up in P2P meeting(s), bringing it up in Core dev meeting, mailing list post etc
< vasild> gleb: Your input on https://github.com/bitcoin/bitcoin/pull/21528 would be very valuable.
< vasild> I said that "you *seem* to be unaware of previous" works because there are no comments from you on those discussion threads. I think it would have helped if you posted a comment on e.g. https://github.com/bitcoin/bitcoin/pull/17194 "this (or similar) problem is addressed by other means in https://github.com/bitcoin/bitcoin/pull/21528"
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #22277: test: Properly set BIP34 height in CreateNewBlock_validity unit test (master...2106-test34) https://github.com/bitcoin/bitcoin/pull/22277
< bitcoin-git> [bitcoin] SpicaLab opened pull request #22276: gui: update text to eliminate safety hazards (0.21...0.21) https://github.com/bitcoin/bitcoin/pull/22276
< bitcoin-git> [bitcoin] fanquake closed pull request #22142: build: split depends Qt into native and target builds (master...split_qt_again) https://github.com/bitcoin/bitcoin/pull/22142
< bitcoin-git> [bitcoin] fanquake merged pull request #21871: scripts: add checks for minimum required OS versions (master...new_tests_on_lief) https://github.com/bitcoin/bitcoin/pull/21871
< bitcoin-git> bitcoin/master c972345 fanquake: scripts: check minimum required Windows version is set