2022-03-23

<bitcoin-git> bitcoin/master fae5d06 MarcoFalke: Remove unused feebumper code
<bitcoin-git> bitcoin/master cea230e fanquake: Merge bitcoin/bitcoin#24562: Remove unused feebumper code
<bitcoin-git> [bitcoin] fanquake merged pull request #24635: test: Run non-wallet tests only once (master...2203-noWalletOnce-🌘) https://github.com/bitcoin/bitcoin/pull/24635
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/30041261a315...ce05f838f145
<bitcoin-git> bitcoin/master fa7a576 MarcoFalke: test: Run non-wallet tests only once
<bitcoin-git> bitcoin/master ce05f83 fanquake: Merge bitcoin/bitcoin#24635: test: Run non-wallet tests only once
<bitcoin-git> [bitcoin] fanquake merged pull request #24582: Move txoutproof RPCs to txoutproof.cpp (master...2203-txoutproof-move-🍤) https://github.com/bitcoin/bitcoin/pull/24582
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3ab96f2945cc...30041261a315
<bitcoin-git> bitcoin/master fa2d176 MarcoFalke: Move txoutproof RPCs to txoutproof.cpp
<bitcoin-git> bitcoin/master 3004126 fanquake: Merge bitcoin/bitcoin#24582: Move txoutproof RPCs to txoutproof.cpp
<michaelfolkson> MarcoFalke: GitHub is saying you haven't yet uploaded your public key (unverified) https://github.com/bitcoin/bitcoin/pull/24635
<cocoon> luke-jr: BIPs are not part of core. How do you explain this to whole world including laanwj who knows this exists: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2021-April/018871.html. I have tried my best to share they use an implementation they like or fork but NETWORK EFFECT is a thing you cannot go against. If you every try to do
<cocoon> marketing for knots, more github activity, more tweets, more mailing list indirect involvement, r/bitcoin suggesting as an alternative etc. maybe it would work. I would encourage people for both: core and knots.
<luke-jr> (also, while the topic of bitcoin/bitcoin group members would be on-topic here, things like "what impl people run" does indeed seem better suited for #bitcoin and broader community chats; let's stick to just dev-specific topics here, so non-devs can more readily participate in the other topics ☺)
<luke-jr> to be clear, BIPs are not part of Core. The bitcoin github org just has multiple groups and multiple projects.
<cocoon> my concerns: percentage of nodes run core for bitcoin? percentage of people that use core org for bip and read that they need post on a mailing list? do we have a process to add/remove people in this? can we improve this?
<bitcoin-git> [bitcoin] achow101 merged pull request #24560: wallet: Use single FastRandomContext when creating a wallet tx (master...2203-RandWallet-🗾) https://github.com/bitcoin/bitcoin/pull/24560
<bitcoin-git> bitcoin/master 77773b0 MarcoFalke: wallet: Pass FastRandomContext& to DiscourageFeeSniping
<bitcoin-git> bitcoin/master fa7deaa MarcoFalke: wallet: Pass FastRandomContext& to coin selection
<bitcoin-git> bitcoin/master 3ab96f2 Andrew Chow: Merge bitcoin/bitcoin#24560: wallet: Use single FastRandomContext when cre...
<bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/f9ed0aec1bd4...3ab96f2945cc
<cocoon> michaelfolkson: lmao this was shared in this channel and they were added in bitcoin core github org
<michaelfolkson> cocoon: #bitcoin please
<cocoon> and I am not surprised by the last 2 people added or their employer or things they didn't want in bitcoin
<cocoon> michaelfolkson: adding to github org has a meaning in bitcoin/bitcoin and bitcoin-core/gui. if you think there is no other github org maintaining implementations for bitcoin then its either a misunderstanding or centralization. I understand this does not involve merge permissions.
<bitcoin-git> [gui] hebasto merged pull request #568: options: flip listenonion to false if not listening (master...fListen) https://github.com/bitcoin-core/gui/pull/568
<cocoon> 3: github needs org, bitcoin doesn't so these things can be separated
<cocoon> 1: adding to org for a project on github can be decided by the owners but this project is different from others. It is used by most of the nodes in bitcoin network claimed to be decentralized network for money and bip repo belongs to same organization.
<bitcoin-git> [bitcoin] josibake opened pull request #24653: test, refactor: use `MiniWallet` in `test/functional/interface_zmg` (master...josibake-make-interfaces-zmq-test-use-miniwallet) https://github.com/bitcoin/bitcoin/pull/24653
<bitcoin-git> [bitcoin] fanquake opened pull request #24652: doc: rewrite OpenBSD build docs for 7.0 (master...openbsd_wallet_doc_cleanupp) https://github.com/bitcoin/bitcoin/pull/24652
<bitcoin-git> [bitcoin] fanquake closed pull request #22509: test: Use MiniWallet in mempool_accept.py (master...mini_memaccept) https://github.com/bitcoin/bitcoin/pull/22509
<bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bc562b9ef81d...f9ed0aec1bd4
<bitcoin-git> bitcoin/master 7f90dc2 Vasil Dimov: options: flip listenonion to false if not listening
<bitcoin-git> bitcoin/master f9ed0ae Hennadii Stepanov: Merge bitcoin-core/gui#568: options: flip listenonion to false if not list...
<bitcoin-git> [bitcoin] fanquake closed pull request #24610: test, lint: check bash version before executing codespell (master...2022-03-bash-lint-spelling) https://github.com/bitcoin/bitcoin/pull/24610
<laanwj> fanquake: ACK on inviting 0xb10c, i'm surprised they weren't yet! btw, please invite people to bitcoincore org as well if you invite them for bitcoin to keep the lists in sync
<hebasto> begging to review https://github.com/bitcoin-core/gui/pull/568 which fixes a bug/regression in the v23.0rc2 GUI
<bitcoin-git> [bitcoin] hebasto closed pull request #24648: Revert "net: do not advertise address where nobody is listening" (master...220323-listen) https://github.com/bitcoin/bitcoin/pull/24648
<bitcoin-git> [gui] vasild opened pull request #568: options: flip listenonion to false if not listening (master...fListen) https://github.com/bitcoin-core/gui/pull/568
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24646: doc: remove unneeded documentation on basic package management on FreeBSD (master...freebsd_remove_basic_doc_info) https://github.com/bitcoin/bitcoin/pull/24646
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d6f225f5c9f8...bc562b9ef81d
<bitcoin-git> bitcoin/master 38a1b0b jessebarton: doc: remove unneeded documentation on basic package management on FreeBSD
<bitcoin-git> bitcoin/master bc562b9 MarcoFalke: Merge bitcoin/bitcoin#24646: doc: remove unneeded documentation on basic p...
<bitcoin-git> [bitcoin] fanquake opened pull request #24650: build: require libtool 2.4.6 (master...require_libtool_2_4_6) https://github.com/bitcoin/bitcoin/pull/24650
<fanquake> I have invited https://github.com/0xB10C to the bitcoin/bitcoin org
<bitcoin-git> [bitcoin] S3RK opened pull request #24649: wallet: do not count wallet utxos as external (master...wallet_correct_external_utxo) https://github.com/bitcoin/bitcoin/pull/24649
<bitcoin-git> [bitcoin] hebasto opened pull request #24648: Revert "net: do not advertise address where nobody is listening" (master...220323-listen) https://github.com/bitcoin/bitcoin/pull/24648
<gribble> https://github.com/bitcoin/bitcoin/issues/24294 | RPC: Switch getblockfrompeer back to standard param names blockhash and nodeid by luke-jr · Pull Request #24294 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] jessebarton opened pull request #24646: doc: remove unneeded documentation on basic package management on FreeBSD (master...freebsd_remove_basic_doc_info) https://github.com/bitcoin/bitcoin/pull/24646
<bitcoin-git> [bitcoin] jessebarton closed pull request #24618: doc: Update OpenBSD build docs, added resources for pkg_add and doas (master...openbsd_install_doc_doas) https://github.com/bitcoin/bitcoin/pull/24618

2022-03-22

<bitcoin-git> [bitcoin] fanquake closed pull request #24645: 23.x (master...23.x) https://github.com/bitcoin/bitcoin/pull/24645
<bitcoin-git> [bitcoin] amogyisabogy1 opened pull request #24645: 23.x (master...23.x) https://github.com/bitcoin/bitcoin/pull/24645
<bitcoin-git> [bitcoin] achow101 opened pull request #24644: wallet: add tracepoints and algorithm information to coin selection (master...tracepoints-coin-selection) https://github.com/bitcoin/bitcoin/pull/24644
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #24641: Add AGGREGATE_NO_COPY_ONLY_MOVE helper (master...2203-copy-move-🌺) https://github.com/bitcoin/bitcoin/pull/24641
<bitcoin-git> [bitcoin] fanquake closed pull request #21061: [p2p] Introduce node rebroadcast module (master...2021-01-the-realest-rebroadcast) https://github.com/bitcoin/bitcoin/pull/21061
<bitcoin-git> [bitcoin] luke-jr opened pull request #24640: Bugfix: RPC/blockchain: Correct description of getblockchaininfo's pruneheight result (master...fix_rpcdoc_gbci_pruneheight_desc) https://github.com/bitcoin/bitcoin/pull/24640
<sipa> The purpose of this effort is making sure that (b) can run without Bitcoin Core wallet, so that we don't lose test coverage of those non-wallet components.
<sipa> In case the Bitcoin Core wallet is disabled, (a) is pointless; there just isn't anything to be tested.
<sipa> @michaelfolkson: The Bitcoin Core wallet is interacted with for two reasons in the functional tests: (a) for testing the Bitcoin Core wallet or (b) because a test needs *a* wallet-like thing to construct transactions for the purpose of testing some non-wallet component of Bitcoin Core.
<sipa> I think it's just that tests should only be interacting with the Bitcoin Core wallet if they're trying to test the Bitcoin Core wallet. But there are lots of tests that need a wallet for something, but not for the thing being tested. Those should use MiniWallet.
<bitcoin-git> [bitcoin] hebasto opened pull request #24639: guix: Drop code for the unsupported `i686-linux-gnu` host (master...220322-guix686) https://github.com/bitcoin/bitcoin/pull/24639
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24624: qt: Avoid potential -Wdeprecated-enum-enum-conversion warnings (master...220321-enum) https://github.com/bitcoin/bitcoin/pull/24624
<bitcoin-git> bitcoin/master f05cf59 MarcoFalke: Merge bitcoin/bitcoin#24624: qt: Avoid potential -Wdeprecated-enum-enum-co...
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/2948d6dea098...f05cf59d91eb
<bitcoin-git> bitcoin/master d8641f0 Hennadii Stepanov: qt: Use human-readable strings in preference to hard-coded integers
<bitcoin-git> bitcoin/master acd98ad Hennadii Stepanov: qt: Avoid potential -Wdeprecated-enum-enum-conversion warning
<bitcoin-git> [bitcoin] fanquake closed pull request #23507: Refactor: Improve API design of `ScriptToUniv`, `TxToUniv` etc to return the `UniValue` instead of mutating a parameter/reference (master...ret_UniValue_instead_of_pass_by_ref) https://github.com/bitcoin/bitcoin/pull/23507
<bitcoin-git> [bitcoin] theStack opened pull request #24637: test: use MiniWallet for mempool_package_onemore.py (master...20220322-test-use_MiniWallet_for_mempool_packages_onemore) https://github.com/bitcoin/bitcoin/pull/24637
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #24636: doc: Fix decodepsbt docs (master...2203-docBug-💧) https://github.com/bitcoin/bitcoin/pull/24636
<bitcoin-git> [bitcoin] fanquake closed pull request #24448: Guix: Fix building for i686-linux-gnu (master...guix_linux_i686) https://github.com/bitcoin/bitcoin/pull/24448
<bitcoin-git> [bitcoin] laanwj merged pull request #15423: torcontrol: Query Tor for correct -onion configuration (master...tor_socks_port) https://github.com/bitcoin/bitcoin/pull/15423
<bitcoin-git> bitcoin/master 2948d6d laanwj: Merge bitcoin/bitcoin#15423: torcontrol: Query Tor for correct -onion conf...
<bitcoin-git> bitcoin/master b2774fc Luke Dashjr: torcontrol: Query Tor for correct -onion configuration
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/44dbf918d3ab...2948d6dea098
<bitcoin-git> [bitcoin] fanquake closed pull request #18086: Accurately account for mempool index memory (master...201910_accounting_allocator) https://github.com/bitcoin/bitcoin/pull/18086
<bitcoin-git> [bitcoin] fanquake closed pull request #22698: Implement RBF inherited signaling and fix getmempoolentry returned bip125-replaceable status (master...fix_bip125_inherited_signaling) https://github.com/bitcoin/bitcoin/pull/22698
<gribble> https://github.com/bitcoin/bitcoin/issues/22708 | build, qt: Add Wayland support for Linux builds with depends by hebasto · Pull Request #22708 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] fanquake merged pull request #24627: test: Limit scope of id global which is shared between subtests (master...2203-gid-🥒) https://github.com/bitcoin/bitcoin/pull/24627
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/138d55e6a024...44dbf918d3ab
<bitcoin-git> bitcoin/master fa9086d MarcoFalke: test: Limit scope of id global which is shared between subtests
<bitcoin-git> bitcoin/master 44dbf91 fanquake: Merge bitcoin/bitcoin#24627: test: Limit scope of id global which is share...
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #15068: Install icon & .desktop file to XDG data (master...xdg) https://github.com/bitcoin/bitcoin/pull/15068
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #20751: [fuzzing] Use subprocess.Popen call directly, remove use of thread pool. (master...2020-12-22-fuzz-test-runner) https://github.com/bitcoin/bitcoin/pull/20751
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24579: doc: Fix getblockchaininfo/getdeploymentinfo RPC docs (master...2203-docRpc-🔅) https://github.com/bitcoin/bitcoin/pull/24579
<bitcoin-git> bitcoin/master facd5d9 MarcoFalke: doc: Fix getblockchaininfo/getdeploymentinfo RPC docs
<bitcoin-git> bitcoin/master 138d55e MarcoFalke: Merge bitcoin/bitcoin#24579: doc: Fix getblockchaininfo/getdeploymentinfo ...
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b8f498f80dbb...138d55e6a024
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24535: test: Fix generate calls and comments in feature_segwit (master...2203-test_fix_seg-🏌) https://github.com/bitcoin/bitcoin/pull/24535
<bitcoin-git> bitcoin/master b8f498f MarcoFalke: Merge bitcoin/bitcoin#24535: test: Fix generate calls and comments in feat...
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e3206c9445f8...b8f498f80dbb
<bitcoin-git> bitcoin/master fa8593f MarcoFalke: test: Fix generate calls and comments in feature_segwit
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #24635: test: Run non-wallet tests only once (master...2203-noWalletOnce-🌘) https://github.com/bitcoin/bitcoin/pull/24635
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24605: test: Use MiniWallet in feature_coinstatsindex (master...2203-mini-🐧) https://github.com/bitcoin/bitcoin/pull/24605
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/e66630cc87c0...e3206c9445f8
<bitcoin-git> bitcoin/master fa48ea3 MarcoFalke: Use MiniWallet in feature_coinstatsindex
<bitcoin-git> bitcoin/master fab6143 MarcoFalke: test: Refactor MiniWallet get_utxo helper
<bitcoin-git> bitcoin/master e3206c9 MarcoFalke: Merge bitcoin/bitcoin#24605: test: Use MiniWallet in feature_coinstatsinde...
<manbruhpig> Hello, I am completely clueless when it comes to doing this sort of stuff. But is it at all possible to chat privately with a bitcoin core dev?
<bitcoin-git> [bitcoin] luke-jr reopened pull request #24629: Bugfix: RPC/blockchain: pruneblockchain: Return the height of the actual last pruned block (master...bugfix_rpc_prunebc_retval) https://github.com/bitcoin/bitcoin/pull/24629
<bitcoin-git> [bitcoin] luke-jr closed pull request #24629: Bugfix: RPC/blockchain: pruneblockchain: Return the height of the actual last pruned block (master...bugfix_rpc_prunebc_retval) https://github.com/bitcoin/bitcoin/pull/24629

2022-03-21

<bitcoin-git> [bitcoin] luke-jr opened pull request #24633: Bugfix: configure: Quote SUPPRESS_WARNINGS sufficiently to preserve brackets (master...bugfix_suppresswarnings_regex) https://github.com/bitcoin/bitcoin/pull/24633
<bitcoin-git> [bitcoin] 1440000bytes opened pull request #24632: print `Warnings:` only if warning returned (master...getinfo-warning) https://github.com/bitcoin/bitcoin/pull/24632
<gribble> https://github.com/bitcoin/bitcoin/issues/559 | -acceptnonstdtxn option to skip "non-standard transaction" checks by luke-jr · Pull Request #559 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/929 | Support for Tonal Bitcoin units (ᵇTBC, ˢTBC, and TBC) by luke-jr · Pull Request #929 · bitcoin/bitcoin · GitHub
<Kiminuo> laanwj Does https://github.com/bitcoin/bitcoin/pull/23732 look ok to you now?
<bitcoin-git> [bitcoin] achow101 merged pull request #13226: Optimize SelectCoinsBnB by tracking the selection by index rather than by position (master...select-bnb-by-index) https://github.com/bitcoin/bitcoin/pull/13226
<bitcoin-git> [bitcoin] achow101 pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/91d12344b1e5...e66630cc87c0
<bitcoin-git> bitcoin/master 1dd0923 Ben Woosley: refactor: Track BnB selection by index
<bitcoin-git> bitcoin/master def43a4 Ben Woosley: refactor: Rename i to curr_try in SelectCoinsBnB
<bitcoin-git> bitcoin/master 9d20052 Ben Woosley: doc: Revise comments and whitespace to clarify
<bitcoin-git> [bitcoin] mzumsande opened pull request #24630: index: reset indexes when running reindex-chainstate (master...202203_index_reindex_cs) https://github.com/bitcoin/bitcoin/pull/24630
<bitcoin-git> [bitcoin] luke-jr opened pull request #24629: Bugfix: RPC/blockchain: pruneblockchain: Return the height of the actual last pruned block (master...bugfix_rpc_prunebc_retval) https://github.com/bitcoin/bitcoin/pull/24629
<cocoon> stickies-v: I was able to find a node with non default port on mainnet by running bitcoin-core-23.0/test.rc2: "addr": "95.161.13.44:59333". Should be a successful test according to vasild as it was auto outbound connection and port is not 8333.
<bitcoin-git> [bitcoin] dongcarl closed pull request #21671: guix: Always canonicalize HOST using `./depends/config.sub` (master...2021-03-guix-canonicalization-HOST) https://github.com/bitcoin/bitcoin/pull/21671
<bitcoin-git> [bitcoin] fanquake closed pull request #21073: wallet: check when create wallets for the reserved name "wallets" (master...sanitycheck) https://github.com/bitcoin/bitcoin/pull/21073
<bitcoin-git> [bitcoin] fanquake closed pull request #14866: [wip] util: Improve evaluation of includeconf lines in network sections of the config file (master...includeconf_eval_at_its_position) https://github.com/bitcoin/bitcoin/pull/14866
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #24627: test: Limit scope of id global which is shared between subtests (master...2203-gid-🥒) https://github.com/bitcoin/bitcoin/pull/24627
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #21312: wallet: remove lock during `listaddressgroupings` (master...listaddressgroupings-no-lock) https://github.com/bitcoin/bitcoin/pull/21312
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #21781: Security enhancements to ChaCha20::SetKey and CSignatureCache::ComputeEntryECDSA (master...fix-setkey-computeentryecdsa) https://github.com/bitcoin/bitcoin/pull/21781
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #19280: Verify the block filter hash when reading from disk. (master...2020-06-14-blockfilterindex-checksums) https://github.com/bitcoin/bitcoin/pull/19280
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #19116: [WIP] wallet: use BlockFilterIndex in ScanForWalletTransactions (master...2020-05-29-generate-pubkeys) https://github.com/bitcoin/bitcoin/pull/19116
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #21224: [p2p] Halt processing of unrequested transactions (master...2021-02-halt-processing-unrequested) https://github.com/bitcoin/bitcoin/pull/21224
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #19621: [RFC] Package-relay: sender-initiated (master...2020-07-sender-package-relay-poc) https://github.com/bitcoin/bitcoin/pull/19621
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #17443: Drop checkFinalTx and use Median Time Past to check finality of wallet transactions (master...2019-11-fix-final-wallet) https://github.com/bitcoin/bitcoin/pull/17443
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #16199: rpc: fix showing wrong amount when not all inputs are from me in gettransaction (master...master) https://github.com/bitcoin/bitcoin/pull/16199
<bitcoin-git> [bitcoin] mzumsande opened pull request #24626: init: disallow reindex-chainstate when pruning (master...202203_reindex_cs_prune) https://github.com/bitcoin/bitcoin/pull/24626
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #24625: Replace struct update_fee_delta with lambda (master...2203-refactor-fee-delta-🔶) https://github.com/bitcoin/bitcoin/pull/24625
<bitcoin-git> [bitcoin] hebasto opened pull request #24624: build: Add -Wdeprecated-enum-enum-conversion (master...220321-enum) https://github.com/bitcoin/bitcoin/pull/24624
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #24623: test: Add diamond-shape prioritisetransaction test (master...2203-test-diamond-👟) https://github.com/bitcoin/bitcoin/pull/24623
<bitcoin-git> [bitcoin] fanquake merged pull request #24613: build: remove unused QMAKE_* VARs (master...qt_unused_install_name_tool) https://github.com/bitcoin/bitcoin/pull/24613
<bitcoin-git> bitcoin/master 91d1234 fanquake: Merge bitcoin/bitcoin#24613: build: remove unused QMAKE_* VARs
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6c72f3192a2b...91d12344b1e5
<bitcoin-git> bitcoin/master 3a46399 fanquake: build: remove unused QMAKE_* VARs
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23880: p2p: Serialize cmpctblock at most once in NewPoWValidBlock (master...2112-p2pAsync) https://github.com/bitcoin/bitcoin/pull/23880
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/75e34ed718fd...6c72f3192a2b
<bitcoin-git> bitcoin/master fa61dd4 MarcoFalke: p2p: Serialize cmpctblock at most once in NewPoWValidBlock
<bitcoin-git> bitcoin/master 6c72f31 MarcoFalke: Merge bitcoin/bitcoin#23880: p2p: Serialize cmpctblock at most once in New...
<bitcoin-git> [bitcoin] fanquake closed pull request #24589: sha512.cpp improvements (master...master) https://github.com/bitcoin/bitcoin/pull/24589
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24601: ci: add ci/scratch dir to .gitignore (master...add-ci-scratch-gitignore) https://github.com/bitcoin/bitcoin/pull/24601
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ae005a647ffa...75e34ed718fd
<bitcoin-git> bitcoin/master 75e34ed MarcoFalke: Merge bitcoin/bitcoin#24601: ci: add ci/scratch dir to .gitignore
<bitcoin-git> bitcoin/master 7027595 josibake: add ci/scratch dir to gitignore
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #21232: index: display specific error message when fatal index error occurs (master...2021/specific_indexerror_message) https://github.com/bitcoin/bitcoin/pull/21232
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #24622: Rename use_android_ndk23.patch to use_android_ndk23.patch2 (master...patch-1) https://github.com/bitcoin/bitcoin/pull/24622
<bitcoin-git> [bitcoin] torimoore4 opened pull request #24622: Rename use_android_ndk23.patch to use_android_ndk23.patch2 (master...patch-1) https://github.com/bitcoin/bitcoin/pull/24622

2022-03-20

<bitcoin-git> [bitcoin] hebasto opened pull request #24620: build: Fix ccache behavior when cross-compiling for darwin hosts (master...220320-ccache) https://github.com/bitcoin/bitcoin/pull/24620
<bitcoin-git> bitcoin/master 77f24aa Jon Atack: gui: improve "Address Relay" translator comments and tooltip in peers tab
<bitcoin-git> bitcoin/master 81ef1f7 Jon Atack: gui: improve "Addresses Processed" translator comments and tooltip in peer...
<bitcoin-git> bitcoin/master 4d2b503 Jon Atack: gui: improve "Addresses Rate-Limited" translator comments and tooltip in p...
<bitcoin-git> [bitcoin] hebasto pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/2320d31aaacd...ae005a647ffa
<bitcoin-git> [gui] hebasto merged pull request #554: Add and improve translator comments and tooltips for peers tab address fields (master...improve-peers-tab-address-fields-extracomments-and-tooltips) https://github.com/bitcoin-core/gui/pull/554

2022-03-19

<bitcoin-git> [bitcoin] fanquake closed pull request #24569: [POC] guix: cross-architecture reproducibility (x86_64 & aarch64) (master...cross_arch_reproducibility) https://github.com/bitcoin/bitcoin/pull/24569
<gribble> https://github.com/bitcoin/bitcoin/issues/21702 | Implement BIP-119 Validation (CheckTemplateVerify) by JeremyRubin · Pull Request #21702 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] jessebarton opened pull request #24618: doc: Update OpenBSD build docs, added resources for pkg_add and doas (master...openbsd_install_doc_doas) https://github.com/bitcoin/bitcoin/pull/24618
<bitcoin-git> [bitcoin] RandyMcMillan closed pull request #24090: net/p2p: change nScore and nBestScore data types to int64_t (master...1642450390-issue-24049) https://github.com/bitcoin/bitcoin/pull/24090
<bitcoin-git> [bitcoin] RandyMcMillan closed pull request #24143: WIP: net/p2p:rename command*/Command/* to message*/Message* (master...1643068742-rename-COMMAND_SIZE-to-MESSAGE_SIZE) https://github.com/bitcoin/bitcoin/pull/24143
<hebasto> luke-jr: my merge permissions are limited to the main branch and the gui repo pulls, so leaving https://github.com/bitcoin-core/gui/pull/555 merging/backporting to 23.x up to other fellow maintainers

2022-03-18

<bitcoin-git> [bitcoin] achow101 opened pull request #24615: guix: Map guix store prefixes to /usr for cross-architecture reproducibility (master...guix-cross-arch-repro) https://github.com/bitcoin/bitcoin/pull/24615
<bitcoin-git> [bitcoin] fanquake merged pull request #24608: doc: clarify that BDB is only required for the legacy wallet in build-unix.md (master...build_unix_correct_bdb_note) https://github.com/bitcoin/bitcoin/pull/24608
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/66e2d21ef203...2320d31aaacd
<bitcoin-git> bitcoin/master 307215b fanquake: doc: clarify that BDB is only required for the legacy wallet
<bitcoin-git> bitcoin/master 2320d31 fanquake: Merge bitcoin/bitcoin#24608: doc: clarify that BDB is only required for th...
<luke-jr> hebasto: https://github.com/bitcoin-core/gui/pull/555 should just be github-merge.py'd into the 23.x branch
<bitcoin-git> [bitcoin] fanquake closed pull request #24614: Readme update (master...master) https://github.com/bitcoin/bitcoin/pull/24614
<bitcoin-git> [bitcoin] atuta opened pull request #24614: Readme update (master...master) https://github.com/bitcoin/bitcoin/pull/24614
<bitcoin-git> [bitcoin] fanquake opened pull request #24613: build: remove unused QMAKE_* VARs (master...qt_unused_install_name_tool) https://github.com/bitcoin/bitcoin/pull/24613
<bitcoin-git> [bitcoin] willcl-ark opened pull request #24611: Add fish completions (master...fish_completions) https://github.com/bitcoin/bitcoin/pull/24611
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24578: test: Fix intermittent failure in feature_segwit (master...2203-testInt-💮) https://github.com/bitcoin/bitcoin/pull/24578
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a7b3123feadb...66e2d21ef203
<bitcoin-git> bitcoin/master 66e2d21 MarcoFalke: Merge bitcoin/bitcoin#24578: test: Fix intermittent failure in feature_seg...
<bitcoin-git> bitcoin/master d6b24e1 DrahtBot: test: Fix intermittent failure in feature_segwit
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24609: Clarify -maxtimeadjustment that only outbound peers influence timedata (master...maxtimeadjustment-outbound-peers-only) https://github.com/bitcoin/bitcoin/pull/24609
<bitcoin-git> bitcoin/master 1bba72d Jon Atack: Clarify in -maxtimeadjustment that only outbound peers influence time data
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a17df4e876f9...a7b3123feadb
<bitcoin-git> bitcoin/master a7b3123 MarcoFalke: Merge bitcoin/bitcoin#24609: Clarify -maxtimeadjustment that only outbound...
<bitcoin-git> [bitcoin] brunoerg opened pull request #24610: test, lint: check bash version before executing codespell (master...2022-03-bash-lint-spelling) https://github.com/bitcoin/bitcoin/pull/24610
<jonatack13> Question, do people using some platforms (macOS?) need to wrap bitcoin-cli string arguments in quotes? i.e. getnodeaddresses 0 "onion" ... or is it fine without quotes for everyone
<bitcoin-git> [bitcoin] jonatack opened pull request #24609: Clarify -maxtimeadjustment that only outbound peers influence timedata (master...maxtimeadjustment-outbound-peers-only) https://github.com/bitcoin/bitcoin/pull/24609
<bitcoin-git> [bitcoin] fanquake opened pull request #24608: doc: clarify that BDB is only required for the legacy wallet in build-unix.md (master...build_unix_correct_bdb_note) https://github.com/bitcoin/bitcoin/pull/24608
<bitcoin-git> [bitcoin] josibake closed pull request #24570: test, refactor: fund tx deterministically in `feature_coinstatindex` (master...josibake-make-coinstatindex-test-deterministic) https://github.com/bitcoin/bitcoin/pull/24570
<bitcoin-git> [bitcoin] fanquake merged pull request #24603: macdeploy: remove unused detached-sig-apply.sh (master...unused_detached_sig_apply) https://github.com/bitcoin/bitcoin/pull/24603
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e09cf64c4828...a17df4e876f9
<bitcoin-git> bitcoin/master a17df4e fanquake: Merge bitcoin/bitcoin#24603: macdeploy: remove unused detached-sig-apply.s...
<bitcoin-git> bitcoin/master 979271a fanquake: macdeploy: remove unused detached-sig-apply
<sipa> please, not here; ask in #bitcoin or look on https://bitcoin.stackexchange.com
<KillerWasp> mmmm, ok, i finally download the source codes of berkeley db and boost-libs, compiling it and use it for bitcoin-core in the configure step.
<vasild> (count connected, outbound peers with non-default port): bitcoin-cli getpeerinfo |jq 'map(select(.inbound == false)) |map(select(.addr |endswith(":8333") |not)) |length'
<vasild> (count connected, outbound peers with default port): bitcoin-cli getpeerinfo |jq 'map(select(.inbound == false)) |map(select(.addr |endswith(":8333"))) |length'
<vasild> (get all known peers): bitcoin-cli getnodeaddresses 0 > /tmp/getnodeaddresses0
<luke-jr> KillerWasp: #bitcoin
<KillerWasp> i get bitcoin-22.0.tar.gz from your own site: https://bitcoincore.org/en/download/
<gribble> https://github.com/bitcoin/bitcoin/issues/791507 | HTTP Error 404: Not Found
<Guest99> MarcoFalke: https://bitcoin-irc.chaincode.com/bitcoin-core-dev/2022-03-17#791507 this is important and not everyone would understand it. I love the way you shared it, exactly. Dont expect things wont change, almost everything around it and less people testing.
<bitcoin-git> [bitcoin] jonatack opened pull request #24606: Change -maxtimeadjustment default from 70 minutes to 0 (master...default-zero-maxtimeadjustment) https://github.com/bitcoin/bitcoin/pull/24606

2022-03-17

<Guest7843> jonatack: it wasnt me. we can select our own nick in webchat using this url: https://web.libera.chat/#bitcoin-core-dev and GuestN can be anyone. N depends if its available imo. Guest99 at 00:00 UTC wont me same as Guest99 at 00:30 most of the times.
<laanwj> this channel is for implementation issues, the mailing list or #bitcoin-wizards would be a better place to discuss proposed consensus changes
<Guest28> jonatack ok! Is there any chance the upcoming Mimblewimble solution on extension blocks on Litecoin will come to Bitcoin Core? :)
<gribble> https://github.com/bitcoin/bitcoin/issues/7573 | P2P: add maxtimeadjustment command line option by mruddy · Pull Request #7573 · bitcoin/bitcoin · GitHub
<Guest28> Hi, I would like to know if there is some upcoming privacy method to Bitcoin Core. Even something basic like PayJoin would be nice. Thx!
<jonatack> lightlike: yes, mentioned that during the meeting (https://www.erisian.com.au/bitcoin-core-dev/log-2022-03-17.html#l-592)
<laanwj> that said, system time in seconds is a pretty lousy fingerprinting vector, and besides, it's also part of many lower level network packets already, so removing it from the bitcoin protocol doesn't do that much to prevent it being used
<gribble> https://github.com/bitcoin/bitcoin/issues/23631 | p2p: Dont use timestamps from inbound peers for Adjusted Time by mzumsande · Pull Request #23631 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24585: doc: mention that BDB is for the legacy wallet in build-osx.md (master...build_osx_descriptor_legacy_switch) https://github.com/bitcoin/bitcoin/pull/24585
<bitcoin-git> bitcoin/master e09cf64 MarcoFalke: Merge bitcoin/bitcoin#24585: doc: mention that BDB is for the legacy walle...
<bitcoin-git> bitcoin/master bf84677 fanquake: doc: cleanup wallet docs in build-osx.md
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/8435d7f11a89...e09cf64c4828
<bitcoin-git> bitcoin/master 57f3f5c fanquake: doc: s/Compiler/Dependency in dependencies.md
<gribble> https://github.com/bitcoin/bitcoin/issues/7573 | P2P: add maxtimeadjustment command line option by mruddy · Pull Request #7573 · bitcoin/bitcoin · GitHub
<dongcarl> Hi all I just set up https://github.com/bitcoin/bitcoin/projects/18 to keep track of all the libbitcoinkernel PRs
<core-meetingbot`> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
<laanwj> i mean, with all the complications and exceptions it's not realistic as an attack on bitcoin, that's all i was trying to say
<MarcoFalke> adjust your system time to Bitcoin (timechain) MTP
<laanwj> in any case, if you're serious about mitigating attacks on timeservers i'd guess that has a much bigger scope than bitcoin
<gribble> https://github.com/bitcoin/bitcoin/issues/4521 | AddTimeData will never update nTimeOffset past 199 samples · Issue #4521 · bitcoin/bitcoin · GitHub
<MarcoFalke> Jup, any business or third party software should have a test suite to check that their use of Bitcoin Core doesn't break with an upgrade
<gribble> https://github.com/bitcoin/bitcoin/issues/24555 | doc: create initial doc/cjdns.md for CJDNS how-to documentation by jonatack · Pull Request #24555 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/21528 | [p2p] Reduce addr blackholes by amitiuttarwar · Pull Request #21528 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/23508 | Add getdeploymentinfo RPC by ajtowns · Pull Request #23508 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/16807 | Let validateaddress locate error in Bech32 address by meshcollider · Pull Request #16807 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/23542 | net: open p2p connections to nodes that listen on non-default ports by vasild · Pull Request #23542 · bitcoin/bitcoin · GitHub
<stickies-v> From the release notes (https://github.com/bitcoin-core/bitcoin-devwiki/wiki/23.0-Release-Notes-draft), I've selected the 5 changes I think most worthwhile to test, and 1 extra if I have time to get to it. I'd very much appreciate feedback on if you think anything else should really be included, and if maybe something can be omitted.
<gribble> https://github.com/bitcoin/bitcoin/issues/24555 | doc: create initial doc/cjdns.md for CJDNS how-to documentation by jonatack · Pull Request #24555 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/22693 | RPC/Wallet: Add "use_txids" to output of getaddressinfo by luke-jr · Pull Request #22693 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/23595 | util: Add ParseHex () helper by MarcoFalke · Pull Request #23595 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/24058 | BIP-322 basic support by kallewoof · Pull Request #24058 · bitcoin/bitcoin · GitHub
<laanwj> https://github.com/bitcoin/bitcoin/projects/8 at the moment there's 8 blockers, 1 chasing concept ACK
<laanwj> welcome to the weekly bitcoin-core-dev general meeting
<laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball
<core-meetingbot`> Meeting started Thu Mar 17 19:00:09 2022 UTC. The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #24605: 2203 mini 🐧 (master...2203-mini-🐧) https://github.com/bitcoin/bitcoin/pull/24605
<gribble> https://github.com/bitcoin/bitcoin/issues/23417 | wallet, spkm: Move key management from DescriptorScriptPubKeyMan to wallet level KeyManager by achow101 · Pull Request #23417 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] fanquake opened pull request #24604: build: fix copypasta in OpenBSD C{XX} flags (master...openbsd_copy_pasta) https://github.com/bitcoin/bitcoin/pull/24604
<bitcoin-git> [bitcoin] fanquake opened pull request #24603: macdeploy: remove unused detached-sig-apply.sh (master...unused_detached_sig_apply) https://github.com/bitcoin/bitcoin/pull/24603
<stickies-v> #proposedmeetingtopic important changes in 23.0 to cover in the new RC Testing Guide (see https://github.com/bitcoin-core/bitcoin-devwiki/wiki/22.0-Release-Candidate-Testing-Guide)
<bitcoin-git> [bitcoin] mzumsande opened pull request #24602: fuzz: add target for coinselection algorithms (master...202203_fuzz_coinselection) https://github.com/bitcoin/bitcoin/pull/24602
<bitcoin-git> [bitcoin] josibake opened pull request #24601: ci: add ci/scratch dir to .gitignore (master...add-ci-scratch-gitignore) https://github.com/bitcoin/bitcoin/pull/24601
<bitcoin-git> [bitcoin] fanquake opened pull request #24600: doc: mention that BDB is for the legacy wallet in build-freebsd.md (master...freebsd_legacy_descriptor_switch) https://github.com/bitcoin/bitcoin/pull/24600
<bitcoin-git> [bitcoin] fanquake opened pull request #24599: guix: remove mingw-w64 std::filesystem workaround (master...remove_newlib_workaround) https://github.com/bitcoin/bitcoin/pull/24599
<bitcoin-git> [bitcoin] prusnak opened pull request #24598: Add *.xip to .gitignore (master...gitignore-xip) https://github.com/bitcoin/bitcoin/pull/24598
<bitcoin-git> [bitcoin] laanwj merged pull request #24593: [23.x] macOS / build backports (23.x...more_macos_backports_rc3) https://github.com/bitcoin/bitcoin/pull/24593
<bitcoin-git> [bitcoin] fanquake merged pull request #24597: doc, guix: Include `arm64-apple-darwin` into codesigned archs (master...220317-docs) https://github.com/bitcoin/bitcoin/pull/24597
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bf2c0fb2a264...8435d7f11a89
<bitcoin-git> bitcoin/master 1f4801b Hennadii Stepanov: doc, guix: Include arm64-apple-darwin into codesigned archs
<bitcoin-git> bitcoin/master 8435d7f fanquake: Merge bitcoin/bitcoin#24597: doc, guix: Include `arm64-apple-darwin` into ...
<laanwj> please take general usage questions to #bitcoin
<Alexthek1d> Does bitcoin-core copy the data temporarily to the drive of the OS first (so "caching") or in memory/RAM and then to the external hdd?
<Alexthek1d> if you download the full node with bitcoin-core and i choose an external hard drive as target for the node:
<bitcoin-git> [bitcoin] hebasto opened pull request #24597: doc, guix: Include `arm64-apple-darwin` into codesigned archs (master...220317-docs) https://github.com/bitcoin/bitcoin/pull/24597
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24472: fuzz: execute each file in dir without fuzz engine (master...202203-phuzztesting) https://github.com/bitcoin/bitcoin/pull/24472
<bitcoin-git> bitcoin/master f59bee3 Anthony Towns: fuzz: execute each file in dir without fuzz engine
<bitcoin-git> bitcoin/master bf2c0fb MarcoFalke: Merge bitcoin/bitcoin#24472: fuzz: execute each file in dir without fuzz e...
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/601bfc417d1f...bf2c0fb2a264
<bitcoin-git> [bitcoin] hebasto opened pull request #24596: [23.x] GUI backport (23.x...220317-23.x-backport) https://github.com/bitcoin/bitcoin/pull/24596
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24515: Only load BlockMan in BlockMan member functions (master...2022-03-kirby-p2.5) https://github.com/bitcoin/bitcoin/pull/24515
<bitcoin-git> bitcoin/master 3bbb6fe Carl Dong: style-only: Various blockstorage.cpp cleanups
<bitcoin-git> bitcoin/master 5be9ee3 Anthony Towns: refactor: more const annotations for uses of CBlockIndex*
<bitcoin-git> [bitcoin] MarcoFalke pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/aece56624941...601bfc417d1f
<bitcoin-git> bitcoin/master 42e56d9 Carl Dong: style-only: No need for std::pair for vSortedByHeight
<bitcoin-git> [gui] hebasto merged pull request #555: Restore Send button when using external signer (master...2022/02/send_button) https://github.com/bitcoin-core/gui/pull/555
<bitcoin-git> [bitcoin] hebasto pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/74f8c551e9ba...aece56624941
<bitcoin-git> bitcoin/master 4b5a6cd Sjors Provoost: refactor: helper function signWithExternalSigner()
<bitcoin-git> bitcoin/master 2efdfb8 Sjors Provoost: gui: restore Send for external signer
<bitcoin-git> bitcoin/master 026b5b4 Sjors Provoost: move-only: helper function to present PSBT
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24553: contrib: fix signet miner (sighash mismatch) (master...202203-contrib-fix_signet_miner_sighash_mismatch) https://github.com/bitcoin/bitcoin/pull/24553
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d6cb4e8ff0d0...74f8c551e9ba
<bitcoin-git> bitcoin/master 12cc020 Sebastian Falbesoner: contrib: fix signet miner (sighash mismatch)
<bitcoin-git> bitcoin/master 74f8c55 MarcoFalke: Merge bitcoin/bitcoin#24553: contrib: fix signet miner (sighash mismatch)
<bitcoin-git> [bitcoin] ajtowns opened pull request #24595: WIP remove g_versionbitscache global (master...202202-cchainparams-chainstatemanager) https://github.com/bitcoin/bitcoin/pull/24595
<bitcoin-git> [bitcoin] ajtowns closed pull request #24563: wallet: Don't override sighash specified in PSBT (master...202203-fillpsbt) https://github.com/bitcoin/bitcoin/pull/24563

2022-03-16

<luke-jr> would be good to get https://github.com/bitcoin-core/gui/pull/555 in for rc3 - 2 utACKs currently
<bitcoin-git> [bitcoin] gruve-p opened pull request #24594: doc: update release-process.md with correct codesigning url (master...patch-1) https://github.com/bitcoin/bitcoin/pull/24594
<bitcoin-git> [bitcoin] fanquake opened pull request #24593: [23.x] macOS / build backports (23.x...more_macos_backports_rc3) https://github.com/bitcoin/bitcoin/pull/24593
<gribble> https://github.com/bitcoin/bitcoin/issues/24563 | wallet: Dont override sighash specified in PSBT by ajtowns · Pull Request #24563 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] fanquake merged pull request #24549: guix: Use $HOST instead of generic osx{64} for macOS artifacts (master...220313-arm64) https://github.com/bitcoin/bitcoin/pull/24549
<bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/9b56b2e2a7f5...d6cb4e8ff0d0
<bitcoin-git> bitcoin/master 933a430 Hennadii Stepanov: guix: Use $HOST instead of generic osx{64} for macOS artifacts
<bitcoin-git> bitcoin/master 4b4b04a Hennadii Stepanov: guix: Drop "-signed" suffix for signed macOS .dmg files
<bitcoin-git> bitcoin/master 53dd616 Hennadii Stepanov: guix: Use "win64" for Windows artifacts consistently
<bitcoin-git> [bitcoin] fanquake merged pull request #24588: doc: Drop a note about Intel-based Macs (master...220316-intel) https://github.com/bitcoin/bitcoin/pull/24588
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/114754adf455...9b56b2e2a7f5
<bitcoin-git> bitcoin/master 9b56b2e fanquake: Merge bitcoin/bitcoin#24588: doc: Drop a note about Intel-based Macs
<bitcoin-git> bitcoin/master e359ba6 Hennadii Stepanov: doc: Drop a note about Intel-based Macs
<bitcoin-git> [bitcoin] achow101 merged pull request #24519: doc: update multisig-tutorial.md to descriptor wallet by default (master...multisig-tutorial-update) https://github.com/bitcoin/bitcoin/pull/24519
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b8992f2d4ae4...114754adf455
<bitcoin-git> bitcoin/master 114754a Andrew Chow: Merge bitcoin/bitcoin#24519: doc: update multisig-tutorial.md to descripto...
<bitcoin-git> bitcoin/master 5347c97 Jon Atack: doc: update multisig-tutorial.md to default wallet type
<bitcoin-git> [bitcoin] achow101 merged pull request #24592: doc: Delete old line of code that was commented out (master...2022-03-delete-comment) https://github.com/bitcoin/bitcoin/pull/24592
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3617d225628f...b8992f2d4ae4
<bitcoin-git> bitcoin/master b8992f2 Andrew Chow: Merge bitcoin/bitcoin#24592: doc: Delete old line of code that was comment...
<bitcoin-git> bitcoin/master 9a5b4d7 Michael Folkson: doc: Delete old line of code that was commented out
<bitcoin-git> [bitcoin] michaelfolkson opened pull request #24592: doc: Delete old line of code that was commented out (master...2022-03-delete-comment) https://github.com/bitcoin/bitcoin/pull/24592
<bitcoin-git> [bitcoin] kibnakamoto opened pull request #24589: sha512.cpp improvements (master...master) https://github.com/bitcoin/bitcoin/pull/24589
<bitcoin-git> [bitcoin] hebasto opened pull request #24588: doc: Drop a note about Intel-based Macs (master...220316-intel) https://github.com/bitcoin/bitcoin/pull/24588
<bitcoin-git> [bitcoin] ayush933 opened pull request #24587: test: use MiniWallet for rpc_createmultisig.py (master...createmultisig-miniwallet) https://github.com/bitcoin/bitcoin/pull/24587
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #14752: tests: Unit tests for IsPayToWitnessScriptHash and IsWitnessProgram (master...script-segwit-tests) https://github.com/bitcoin/bitcoin/pull/14752