2023-01-10

<bitcoin-git> bitcoin/master 1c9457b MarcoFalke: Merge bitcoin/bitcoin#26856: ci: Run one task with all tests on credits
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0e81d119e09d...1c9457bc8b06
<bitcoin-git> [bitcoin] Sjors closed pull request #21928: wallet: allow toggling external_signer flag (master...2021/05/hww-toggle) https://github.com/bitcoin/bitcoin/pull/21928
<bitcoin-git> [bitcoin] andyoknen opened pull request #26862: Customize onion port & disable bind if service not started (master...feat/customize-onion-port) https://github.com/bitcoin/bitcoin/pull/26862
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #26851: ci: Remove unused busybox workaround (master...2301-ci-busybox-🙉) https://github.com/bitcoin/bitcoin/pull/26851
<bitcoin-git> bitcoin/master 0e81d11 MarcoFalke: Merge bitcoin/bitcoin#26851: ci: Remove unused busybox workaround
<bitcoin-git> bitcoin/master fac424f MarcoFalke: ci: Create named symbol for BINS_SCRATCH_DIR
<bitcoin-git> bitcoin/master fadfae4 MarcoFalke: ci: Remove unused busybox workaround
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1aedc3b6c81b...0e81d119e09d
<bitcoin-git> [bitcoin] achow101 closed pull request #26841: tests: Allow tests to use a loopback address other than 127.0.0.1 for more test runner parallelism (master...tests-allow-other-locahost) https://github.com/bitcoin/bitcoin/pull/26841

2023-01-09

<bitcoin-git> [bitcoin] achow101 closed pull request #26618: rpc: Prevent unloading a wallet when rescanning (master...2022-11-unloadwallet-with-rescan) https://github.com/bitcoin/bitcoin/pull/26618
<bitcoin-git> bitcoin/master 1aedc3b Andrew Chow: Merge bitcoin/bitcoin#26618: rpc: Prevent unloading a wallet when rescanni...
<bitcoin-git> bitcoin/master 109cbb8 Aurèle Oulès: doc: Add release notes for #26618
<bitcoin-git> bitcoin/master b13902d Aurèle Oulès: rpc: Prevent unloading a wallet when rescanning
<bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/39363a4b9451...1aedc3b6c81b
<bitcoin-git> [gui] john-moffett opened pull request #695: Fix: misleading RPC console wallet message (master...2023_01_FixNoWalletRPCConsoleMessage) https://github.com/bitcoin-core/gui/pull/695
<bitcoin-git> [bitcoin] vasild opened pull request #26859: fuzz: extend ConsumeNetAddr() to return I2P and CJDNS addresses (master...ConsumeNetAddr_I2P_CJDNS) https://github.com/bitcoin/bitcoin/pull/26859
<bitcoin-git> [bitcoin] aureleoules opened pull request #26858: wallet: Use defined purposes instead of inlining (master...2023-01-purpose-refactor) https://github.com/bitcoin/bitcoin/pull/26858
<bitcoin-git> [bitcoin] jamesob opened pull request #26857: OP_VAULT draft (master...2023-01-opvault) https://github.com/bitcoin/bitcoin/pull/26857
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #26856: ci: Run one task with all tests on credits (master...2301-ci-credits-tests-fun-👱) https://github.com/bitcoin/bitcoin/pull/26856
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #26854: test: Fix intermittent timeout in p2p_permissions.py (master...2301-test-timeout-p2p-perm-💙) https://github.com/bitcoin/bitcoin/pull/26854
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #26822: p2p, rpc: don't allow past absolute timestamp in `setban` (master...2023-01-fix-ban-time) https://github.com/bitcoin/bitcoin/pull/26822
<bitcoin-git> bitcoin/master abccb27 brunoerg: test: add coverage for absolute timestamp in `setban`
<bitcoin-git> bitcoin/master 39363a4 MarcoFalke: Merge bitcoin/bitcoin#26822: p2p, rpc: don't allow past absolute timestamp...
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/49aefc2c2e3c...39363a4b9451
<bitcoin-git> bitcoin/master b99f1f2 brunoerg: p2p, rpc: don't allow past absolute timestamp in `setban`
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #26851: ci: Remove unused busybox workaround (master...2301-ci-busybox-🙉) https://github.com/bitcoin/bitcoin/pull/26851
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #26850: ci: Stop and remove CI container (master...2301-ci-container-stop-💺) https://github.com/bitcoin/bitcoin/pull/26850
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #26843: ci: Fix ci_native_fuzz_msan CONTAINER_NAME (master...2301-ci-fix-name-msan-🕒) https://github.com/bitcoin/bitcoin/pull/26843
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/adc41cf3b22f...49aefc2c2e3c
<bitcoin-git> bitcoin/master fa4e98c MarcoFalke: ci: Fix ci_native_fuzz_msan CONTAINER_NAME
<bitcoin-git> bitcoin/master 49aefc2 MarcoFalke: Merge bitcoin/bitcoin#26843: ci: Fix ci_native_fuzz_msan CONTAINER_NAME

2023-01-08

<bitcoin-git> [bitcoin] mzumsande opened pull request #26847: p2p: track AddrMan totals by network and table, improve precision of adding fixed seeds (master...202212_addrman_tracknets) https://github.com/bitcoin/bitcoin/pull/26847
<gribble> https://github.com/bitcoin/bitcoin/issues/26226 | Bump minimum python version to 3.7 by MarcoFalke · Pull Request #26226 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/24017 | Bump Python dependency version by fjahr · Pull Request #24017 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/23270 | Bump minimum python version to 3.7 by Empact · Pull Request #23270 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] fanquake closed pull request #26846: Update CONTRIBUTING.md to improve grammar (master...patch-2) https://github.com/bitcoin/bitcoin/pull/26846
<bitcoin-git> [bitcoin] CodeMaster7000 opened pull request #26846: Update CONTRIBUTING.md to improve grammar (master...patch-2) https://github.com/bitcoin/bitcoin/pull/26846

2023-01-07

<bitcoin-git> [bitcoin] fanquake closed pull request #26845: Update README.md (master...master) https://github.com/bitcoin/bitcoin/pull/26845
<bitcoin-git> [bitcoin] JuanPabloLeber opened pull request #26845: Update README.md (master...master) https://github.com/bitcoin/bitcoin/pull/26845
<bitcoin-git> [bitcoin] whitslack opened pull request #26844: Net: Pass `MSG_MORE` flag when sending non-final network messages (round 2) (master...MSG_MORE) https://github.com/bitcoin/bitcoin/pull/26844
<michaelfolkson> Hey. A WSJ journalist has emailed me requesting a call to chat about the community of developers who "maintain" (I assume they mean contribute to) Bitcoin Core for a story
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #26843: ci: Fix ci_native_fuzz_msan CONTAINER_NAME (master...2301-ci-fix-name-msan-🕒) https://github.com/bitcoin/bitcoin/pull/26843
<bitcoin-git> [bitcoin] fanquake closed pull request #26842: Setting up stuff (master...HardiskTest) https://github.com/bitcoin/bitcoin/pull/26842
<bitcoin-git> [bitcoin] HardiskFromYT opened pull request #26842: Setting up stuff (master...HardiskTest) https://github.com/bitcoin/bitcoin/pull/26842
<bitcoin-git> [bitcoin] achow101 opened pull request #26841: tests: Allow tests to use a loopback address other than 127.0.0.1 for more test runner parallelism (master...tests-allow-other-locahost) https://github.com/bitcoin/bitcoin/pull/26841
<bitcoin-git> [bitcoin] KolbyML opened pull request #26840: refactor: importpubkey, importprivkey, importaddress, importmulti, and importdescriptors rpc (master...refactor-imports) https://github.com/bitcoin/bitcoin/pull/26840

2023-01-06

<bitcoin-git> [bitcoin] john-moffett opened pull request #26839: Add support for RNDR/RNDRRS for AArch64 on Linux (master...2023_01_RNDRSupportLinux) https://github.com/bitcoin/bitcoin/pull/26839
<bitcoin-git> [bitcoin] jonatack opened pull request #26838: doc: I2P documentation updates (master...2023-01-i2p-documentation-updates) https://github.com/bitcoin/bitcoin/pull/26838
<bitcoin-git> [bitcoin] vasild opened pull request #26837: I2P network optimizations (master...i2p_session_pool) https://github.com/bitcoin/bitcoin/pull/26837
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #26805: tests: Use unique port for ZMQ tests to allow for multiple test instances (master...parallel-zmq-test) https://github.com/bitcoin/bitcoin/pull/26805
<bitcoin-git> bitcoin/master c6119f4 Andrew Chow: tests: Use unique port for ZMQ tests
<bitcoin-git> bitcoin/master adc41cf MarcoFalke: Merge bitcoin/bitcoin#26805: tests: Use unique port for ZMQ tests to allow...
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/911a40ead256...adc41cf3b22f
<bitcoin-git> [bitcoin] furszy opened pull request #26836: wallet: finish addressbook encapsulation (master...2022_wallet_finish_addressbook_encapsulation) https://github.com/bitcoin/bitcoin/pull/26836
<bitcoin-git> [bitcoin] fanquake opened pull request #26835: scripts: add PE Canary check to security-check (master...win_sec_canary) https://github.com/bitcoin/bitcoin/pull/26835
<bitcoin-git> [bitcoin] fanquake merged pull request #26557: build: Update Boost to 1.81.0 in depends (master...221123-boost) https://github.com/bitcoin/bitcoin/pull/26557
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/2cfe37962343...911a40ead256
<bitcoin-git> bitcoin/master 2427468 Hennadii Stepanov: doc: Update Boost version in doc/dependencies.md
<bitcoin-git> bitcoin/master e8b4201 Hennadii Stepanov: build: Update Boost to 1.81.0 in depends
<bitcoin-git> bitcoin/master 911a40e fanquake: Merge bitcoin/bitcoin#26557: build: Update Boost to 1.81.0 in depends
<bitcoin-git> [bitcoin] fanquake opened pull request #26834: contrib: remove install_db4.sh (master...remove_install_db4) https://github.com/bitcoin/bitcoin/pull/26834
<bitcoin-git> [bitcoin] fanquake opened pull request #26833: build: allow NO_BOOST=1 & NO_LIBEVENT=1 in depends (master...allow_depends_no_boost_no_event) https://github.com/bitcoin/bitcoin/pull/26833
<bitcoin-git> [bitcoin] fanquake opened pull request #26832: compat: move (win) S_* defines into bdb (master...dont_exclude_stat_win_bdb) https://github.com/bitcoin/bitcoin/pull/26832
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #26823: refactor: Work around Werror=free-nonheap-object in AssumeCalculateMemPoolAncestors (master...2301-s390x-refactor-gcc-bug-📧) https://github.com/bitcoin/bitcoin/pull/26823
<bitcoin-git> bitcoin/master 2cfe379 MarcoFalke: Merge bitcoin/bitcoin#26823: refactor: Work around Werror=free-nonheap-obj...
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b4fb0a3255d3...2cfe37962343
<bitcoin-git> bitcoin/master faa86ee MarcoFalke: refactor: Work around Werror=free-nonheap-object in AssumeCalculateMemPool...
<bitcoin-git> [bitcoin] achow101 opened pull request #26829: init: Remove unnecessary sensitive flag from rpcbind (master...dont-hide-rpcbind-log) https://github.com/bitcoin/bitcoin/pull/26829

2023-01-05

<lisper29> last table entry at: https://en.wikipedia.org/wiki/Timeline_of_the_far_future . And I'll tell all users of my program that in dealing with cryptography (which underlies bitcoin), there are these negligibly likely events. That's enough agonising for now :-)
<bitcoin-git> [bitcoin] andrewtoth opened pull request #26828: assumeutxo: catch and log fs::remove error instead of two exist checks (master...assumeutxo-remove-fix) https://github.com/bitcoin/bitcoin/pull/26828
<bitcoin-git> [bitcoin] fanquake opened pull request #26827: doc: use "std lib clock" over "C++11 clock" (master...doc_std_lib_clocks) https://github.com/bitcoin/bitcoin/pull/26827
<bitcoin-git> [bitcoin] fanquake opened pull request #26826: refactor: remove windows-only compat.h usage in randomenv (master...windows_randomenv_compat_usage) https://github.com/bitcoin/bitcoin/pull/26826
<bitcoin-git> [bitcoin] fanquake opened pull request #26825: build: remove already tested headers from AC_CHECK_HEADERS (master...remove_already_tested_headers) https://github.com/bitcoin/bitcoin/pull/26825
<bitcoin-git> [bitcoin] fanquake opened pull request #26824: build: fix configuring with only bitcoin-util (master...fix_bitcoin_util_configure) https://github.com/bitcoin/bitcoin/pull/26824
<core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
<achow101> LarryRuane: I think anything in the high prio board and the pr status board (https://github.com/orgs/bitcoin/projects/5/views/1)
<gribble> https://github.com/bitcoin/bitcoin/issues/25740 | assumeutxo: background validation completion by jamesob · Pull Request #25740 · bitcoin/bitcoin · GitHub
<achow101> #bitcoin-core-dev Meeting: achow101 aj amiti ariard b10c BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik petertodd
<core-meetingbot> Meeting started Thu Jan 5 19:02:41 2023 UTC. The chair is achow101. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #26823: refactor: Work around Werror=free-nonheap-object in AssumeCalculateMemPoolAncestors (master...2301-s390x-refactor-gcc-bug-📧) https://github.com/bitcoin/bitcoin/pull/26823
<bitcoin-git> [bitcoin] brunoerg opened pull request #26822: p2p, rpc: don't allow past absolute timestamp in `setban` (master...2023-01-fix-ban-time) https://github.com/bitcoin/bitcoin/pull/26822
<jamesob> Surprising that this is dead code in the functional test suite: https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/script.py#L817-L820
<bitcoin-git> [bitcoin] hebasto opened pull request #26821: refactor: Make `ThreadHTTP` return void (master...220105-http) https://github.com/bitcoin/bitcoin/pull/26821
<bitcoin-git> [bitcoin] achow101 merged pull request #26761: wallet: fully migrate address book entries for watchonly/solvable wallets (master...202212-migratewallet_persist_addressbook) https://github.com/bitcoin/bitcoin/pull/26761
<bitcoin-git> bitcoin/master 730e14a Sebastian Falbesoner: test: wallet: check that labels are migrated to watchonly wallet
<bitcoin-git> bitcoin/master b4fb0a3 Andrew Chow: Merge bitcoin/bitcoin#26761: wallet: fully migrate address book entries fo...
<bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/3212d104f4ac...b4fb0a3255d3
<bitcoin-git> bitcoin/master d5f4ae7 Sebastian Falbesoner: wallet: fully migrate address book entries for watchonly/solvable wallets
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23829: refactor: use braced init for integer literals instead of c style casts (master...use-braced-init) https://github.com/bitcoin/bitcoin/pull/23829
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/61f35159ffad...3212d104f4ac
<bitcoin-git> bitcoin/master f2fc03e Pasta: refactor: use braced init for integer constants instead of c style casts
<bitcoin-git> bitcoin/master 3212d10 MarcoFalke: Merge bitcoin/bitcoin#23829: refactor: use braced init for integer literal...
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #26818: test: Fix feature_startupnotify intermittent issue (master...2301-test-fix-s-🐫) https://github.com/bitcoin/bitcoin/pull/26818
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/296e88225096...61f35159ffad
<bitcoin-git> bitcoin/master fac810b MarcoFalke: test: Fix feature_startupnotify intermittent issue
<bitcoin-git> bitcoin/master 61f3515 MarcoFalke: Merge bitcoin/bitcoin#26818: test: Fix feature_startupnotify intermittent ...
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #26818: test: Fix feature_startupnotify intermittent issue (master...2301-test-fix-s-🐫) https://github.com/bitcoin/bitcoin/pull/26818
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #26817: doc: Remove copyright years (master...2301-doc-copy-🍼) https://github.com/bitcoin/bitcoin/pull/26817
<p2plife> the result is that these messaged (seen with grep "init message" ~/.bitcoin/debug.log) are all ending with bytes e2 80 a6, and then the newline 0a
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #26598: contrib: remove builder keys (master...drop_non_guix_keys) https://github.com/bitcoin/bitcoin/pull/26598
<bitcoin-git> [bitcoin] zpv closed pull request #26815: builder-keys: remove luke-jr (master...patch-1) https://github.com/bitcoin/bitcoin/pull/26815
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/360e047a7102...296e88225096
<bitcoin-git> bitcoin/master e6864fa fanquake: contrib: remove builder keys
<bitcoin-git> bitcoin/master 296e882 MarcoFalke: Merge bitcoin/bitcoin#26598: contrib: remove builder keys

2023-01-04

<bitcoin-git> [bitcoin] achow101 merged pull request #26747: wallet: fix confusing error / GUI crash on cross-chain legacy wallet restore (master...202212-wallet-fix_restorewallet_bdb_crosschain) https://github.com/bitcoin/bitcoin/pull/26747
<bitcoin-git> bitcoin/master 21ad4e2 Sebastian Falbesoner: test: add coverage for cross-chain wallet restore
<bitcoin-git> bitcoin/master 360e047 Andrew Chow: Merge bitcoin/bitcoin#26747: wallet: fix confusing error / GUI crash on cr...
<bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/cabeae43ea6e...360e047a7102
<bitcoin-git> bitcoin/master 8c7222b Sebastian Falbesoner: wallet: fix GUI crash on cross-chain legacy wallet restore
<bitcoin-git> [bitcoin] achow101 closed pull request #26809: compat: use STDIN_FILENO over 0 (master...compat_STDIN_FILENO) https://github.com/bitcoin/bitcoin/pull/26809
<bitcoin-git> bitcoin/master 585c672 fanquake: compat: use STDIN_FILENO over 0
<bitcoin-git> bitcoin/master cabeae4 Andrew Chow: Merge bitcoin/bitcoin#26809: compat: use STDIN_FILENO over 0
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/196a43eddb96...cabeae43ea6e
<bitcoin-git> [bitcoin] zpv opened pull request #26815: builder-keys: remove luke-jr (master...patch-1) https://github.com/bitcoin/bitcoin/pull/26815
<bitcoin-git> [bitcoin] glozow merged pull request #26603: doc: CalculateSequenceLocks: prevHeights entries are set to 0, not removed (master...docs-fix-CalculateSequenceLocks) https://github.com/bitcoin/bitcoin/pull/26603
<bitcoin-git> [bitcoin] glozow pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/65ecf24b5c42...196a43eddb96
<bitcoin-git> bitcoin/master f537127 stickies-v: doc: fix: prevHeights entries are set to 0, not removed
<bitcoin-git> bitcoin/master 196a43e glozow: Merge bitcoin/bitcoin#26603: doc: CalculateSequenceLocks: prevHeights entr...
<bitcoin-git> [bitcoin] fanquake opened pull request #26814: random: remove windows-only compat.h usage (master...prune_compat_random) https://github.com/bitcoin/bitcoin/pull/26814
<bitcoin-git> [bitcoin] glozow merged pull request #26752: wallet: Remove `mempool_sequence` from interface methods (master...remove_mempool_sequence) https://github.com/bitcoin/bitcoin/pull/26752
<bitcoin-git> [bitcoin] glozow pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/a27324148089...65ecf24b5c42
<bitcoin-git> bitcoin/master bf19069 w0xlt: wallet: remove `mempool_sequence` from `transactionAddedToMempool`
<bitcoin-git> bitcoin/master 55696a0 w0xlt: wallet: remove `mempool_sequence` from `transactionRemovedFromMempool`
<bitcoin-git> bitcoin/master 65ecf24 glozow: Merge bitcoin/bitcoin#26752: wallet: Remove `mempool_sequence` from interf...
<bitcoin-git> [bitcoin] achow101 merged pull request #26020: test: Change coinselection parameter location to make tests independent (master...fix-bnb-search-test-param) https://github.com/bitcoin/bitcoin/pull/26020
<bitcoin-git> bitcoin/master a273241 Andrew Chow: Merge bitcoin/bitcoin#26020: test: Change coinselection parameter location...
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/139ba2bf121c...a27324148089
<bitcoin-git> bitcoin/master b942c94 yancy: test: Change coinselection parameter location to make tests independent
<lisper29> achow101: I've created this as you suggested: https://github.com/bitcoin/bitcoin/issues/26813
<bitcoin-git> [bitcoin] achow101 merged pull request #25234: bench: add benchmark for wallet 'AvailableCoins' function. (master...2022_bench_wallet_available_coins) https://github.com/bitcoin/bitcoin/pull/25234
<bitcoin-git> bitcoin/master 139ba2b Andrew Chow: Merge bitcoin/bitcoin#25234: bench: add benchmark for wallet 'AvailableCoi...
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bf3b58941356...139ba2bf121c
<bitcoin-git> bitcoin/master 3a4f8bc furszy: bench: add benchmark for wallet 'AvailableCoins' function.
<earnestly> Related, but not exactly: https://github.com/bitcoin/bitcoin/issues/10468
<lisper29> bitcoind's (24.0.1) listreceivedbyaddress always returns an empty array for a watch-only wallet when it's of type descriptor (not legacy). Anyone know if that's expected behaviour, or a potential bug? (This problem doesn't occur with a legacy watch-only wallet, only a descriptor watch-only wallet.) Helpful people in #bitcoin suggested I ask in here. Thanks in advance.
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #26811: test: Add debug log for 25644 (master...2301-test-debug-🕰) https://github.com/bitcoin/bitcoin/pull/26811
<bitcoin-git> [bitcoin] vasild opened pull request #26812: test: add end-to-end tests for CConnman and PeerManager (master...e2e_tests) https://github.com/bitcoin/bitcoin/pull/26812
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #26811: test: Add debug log for 25644 (master...2301-test-debug-🕰) https://github.com/bitcoin/bitcoin/pull/26811
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #26791: ci: Properly set COMMIT_RANGE in lint task (master...2301-ci-lint-🥗) https://github.com/bitcoin/bitcoin/pull/26791
<bitcoin-git> bitcoin/master bf3b589 MarcoFalke: Merge bitcoin/bitcoin#26791: ci: Properly set COMMIT_RANGE in lint task
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4bb840a45311...bf3b58941356
<bitcoin-git> bitcoin/master fa5cbf2 MarcoFalke: ci: Properly set COMMIT_RANGE in lint task
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #26802: test: Use same Python executable for subprocesses as for `all-lint.py` (master...all-lint-python-executable) https://github.com/bitcoin/bitcoin/pull/26802
<bitcoin-git> bitcoin/master 4bb840a MarcoFalke: Merge bitcoin/bitcoin#26802: test: Use same Python executable for subproce...
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2ec97825e708...4bb840a45311
<bitcoin-git> bitcoin/master f6eadaa Kristaps Kaupe: Use same Python executable for subprocesses as for all-lint.py
<bitcoin-git> [bitcoin] fanquake opened pull request #26810: debian: remove nonexistent files from copyright (master...remove_redundant_copyright) https://github.com/bitcoin/bitcoin/pull/26810
<bitcoin-git> [bitcoin] fanquake opened pull request #26809: compat: use STDIN_FILENO over 0 (master...compat_STDIN_FILENO) https://github.com/bitcoin/bitcoin/pull/26809
<bitcoin-git> [bitcoin] fanquake closed pull request #26787: Update build-osx.md (master...master) https://github.com/bitcoin/bitcoin/pull/26787
<bitcoin-git> [bitcoin] fanquake merged pull request #26771: doc: Correct linked Microsoft URLs (master...build-windows) https://github.com/bitcoin/bitcoin/pull/26771
<bitcoin-git> bitcoin/master 2ec9782 fanquake: Merge bitcoin/bitcoin#26771: doc: Correct linked Microsoft URLs
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4717a5aa31bc...2ec97825e708
<bitcoin-git> bitcoin/master f84e445 Suriyaa Sundararuban: doc: Correct linked Microsoft URLs
<bitcoin-git> [bitcoin] fanquake merged pull request #26772: contrib: fix sha256 check in install_db4.sh for FreeBSD (master...freebsd_db4_fix) https://github.com/bitcoin/bitcoin/pull/26772
<bitcoin-git> [bitcoin] fanquake merged pull request #26795: rpc: Correct RPCHelpMan for fundrawtransaction's input_weights field (master...rpc/fundrawtransaction-input-weights) https://github.com/bitcoin/bitcoin/pull/26795
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/53653060c147...4717a5aa31bc
<bitcoin-git> bitcoin/master 22e9afe Murray Nesbitt: use sha256 command instead of sha256sum on FreeBSD
<bitcoin-git> bitcoin/master 4717a5a fanquake: Merge bitcoin/bitcoin#26772: contrib: fix sha256 check in install_db4.sh f...
<bitcoin-git> bitcoin/master 927b8d4 jdjkelly@gmail.com: rpc: Correct RPCHelpMan for fundrawtransaction's input_weights field
<bitcoin-git> bitcoin/master 5365306 MarcoFalke: Merge bitcoin/bitcoin#26795: rpc: Correct RPCHelpMan for fundrawtransactio...
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/03254c22296a...53653060c147
<bitcoin-git> [bitcoin] glozow merged pull request #19909: refactor: Remove unused CTxMemPool::clear() helper (master...2009-noTxpoolClear) https://github.com/bitcoin/bitcoin/pull/19909
<bitcoin-git> bitcoin/master fa818e1 MarcoFalke: txmempool: Remove unused clear() member function
<bitcoin-git> bitcoin/master 03254c2 glozow: Merge bitcoin/bitcoin#19909: refactor: Remove unused CTxMemPool::clear() h...
<bitcoin-git> [bitcoin] glozow pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3f8591d46b46...03254c22296a

2023-01-03

<bitcoin-git> [bitcoin] achow101 merged pull request #26661: wallet: Coin Selection, return accurate error messages (master...2022_wallet_coin_selection_accurate_errors) https://github.com/bitcoin/bitcoin/pull/26661
<bitcoin-git> bitcoin/master e5e147f furszy: wallet: refactor eight consecutive 'AttemptSelection' calls into a loop
<bitcoin-git> bitcoin/master 7e8340a furszy: wallet: make SelectCoins flow return util::Result
<bitcoin-git> bitcoin/master 0aa065b furszy: wallet: return accurate error messages from Coin Selection
<bitcoin-git> [bitcoin] achow101 pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/80fc1af09627...3f8591d46b46
<bitcoin-git> [bitcoin] jonatack opened pull request #26801: script: drop E275 rule in lint-python.py for flake8 5.0.4, update dependencies (master...2023-01-python-linter-drop-E275-rule-and-update-dependencies) https://github.com/bitcoin/bitcoin/pull/26801
<laanwj> it's printed the "merged pull request" zillions of times to #bitcoin-commits, and mastodon because i re-sent it to test 😅
<bitcoin-git> [bitcoin] achow101 merged pull request #26192: rpc: Improve error when wallet is already loaded (master...2022-09-load-wallet-err) https://github.com/bitcoin/bitcoin/pull/26192
<achow101> laanwj: I think bitcoin-git is dead?

2023-01-02

<bytes1440000> poeple are talking shit about him on social media dont realize he never forced anyone to donate and was passionate to work for bitcoin all these years.
<bytes1440000> anyway, whoever has stolen luke's btc or other things that might affect bitcoin pls be aware its not easy. cashout wont be easy, if caught, you will go to jail and return btc. If caught elsewhere many bitcoiners wont have any hesiation to shoot you on sight.
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #26791: ci: Properly set COMMIT_RANGE in lint task (master...2301-ci-lint-🥗) https://github.com/bitcoin/bitcoin/pull/26791
<bitcoin-git> [gui] john-moffett opened pull request #693: Fix segfault when shutdown during wallet open (master...2022_12_29_FixSegfaultOnCloseWalletPopup) https://github.com/bitcoin-core/gui/pull/693

2023-01-01

<bitcoin-git> [bitcoin] MarcoFalke merged pull request #26775: ci: Revert tsan task changes (master...2212-tsan-revert-🎨) https://github.com/bitcoin/bitcoin/pull/26775
<bitcoin-git> bitcoin/master faa835e MarcoFalke: Revert "test: Drop no longer needed `race:epoll_ctl` TSan suppression"
<bitcoin-git> bitcoin/master fa5d9a0 MarcoFalke: Revert "ci: Use clang-15 in tsan task"
<bitcoin-git> bitcoin/master fabb6af MarcoFalke: ci: Remove duplicate CC and CXX from tsan task
<bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/8575d5d84265...d8bdee0fc889
<bitcoin-git> [bitcoin] Bhaney44 opened pull request #26787: Update build-osx.md (master...master) https://github.com/bitcoin/bitcoin/pull/26787
<bitcoin-git> [bitcoin] fanquake closed pull request #26785: Update README.md to improve grammar (master...patch-1) https://github.com/bitcoin/bitcoin/pull/26785

2022-12-31

<bitcoin-git> [bitcoin] andrewtoth closed pull request #26782: p2p: cache block hash in ProcessGetBlockData and CMPCTBLOCK processing (master...cache-block-header-hash) https://github.com/bitcoin/bitcoin/pull/26782
<bitcoin-git> [bitcoin] CodeMaster7000 opened pull request #26785: Update README.md to improve grammar (master...patch-1) https://github.com/bitcoin/bitcoin/pull/26785
<bitcoin-git> [bitcoin] hebasto closed pull request #26784: Update key_io.cpp (master...patch-1) https://github.com/bitcoin/bitcoin/pull/26784
<bitcoin-git> [bitcoin] SmashedFrenzy16 opened pull request #26784: Update key_io.cpp (master...patch-1) https://github.com/bitcoin/bitcoin/pull/26784
<bitcoin-git> [bitcoin] andrewtoth opened pull request #26782: p2p: cache block hash in ProcessGetBlockData and CMPCTBLOCK processing (master...cache-block-header-hash) https://github.com/bitcoin/bitcoin/pull/26782
<bitcoin-git> [bitcoin] hebasto opened pull request #26781: Release `LockData::dd_mutex` before calling `*_detected` functions (master...221231-lock) https://github.com/bitcoin/bitcoin/pull/26781
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #26777: rpc: Remove duplicate field in RPCHelpMan for gettransactions (master...rpc/get-transactions-typo) https://github.com/bitcoin/bitcoin/pull/26777
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/65de8eeeca29...8575d5d84265
<bitcoin-git> bitcoin/master 090ad51 Joshua Kelly: rpc: Remove duplicate field in RPCHelpMan for gettransactions
<bitcoin-git> bitcoin/master 8575d5d MarcoFalke: Merge bitcoin/bitcoin#26777: rpc: Remove duplicate field in RPCHelpMan for...
<bitcoin-git> [bitcoin] furszy opened pull request #26780: rpc: simplify scan blocks (master...2022_simplify_scan_blocks) https://github.com/bitcoin/bitcoin/pull/26780

2022-12-30

<bitcoin-git> [bitcoin] jdjkelly opened pull request #26777: rpc: Remove duplicate field in RPCHelpMan for gettransactions (master...rpc/get-transactions-typo) https://github.com/bitcoin/bitcoin/pull/26777
<bitcoin-git> [bitcoin] hebasto opened pull request #26776: Drop `CCheckQueue::nIdle` (master...221230-queue) https://github.com/bitcoin/bitcoin/pull/26776
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #26775: ci: Revert tsan task changes (master...2212-tsan-revert-🎨) https://github.com/bitcoin/bitcoin/pull/26775
<bitcoin-git> [bitcoin] murrayn opened pull request #26773: doc: FreeBSD build doc should suggest db4 for legacy wallet support (master...use_db4_on_freebsd) https://github.com/bitcoin/bitcoin/pull/26773
<bitcoin-git> [bitcoin] murrayn opened pull request #26772: script: fix sha256 check in contrib/install_db4.sh for FreeBSD (master...freebsd_db4_fix) https://github.com/bitcoin/bitcoin/pull/26772

2022-12-29

<bitcoin-git> [bitcoin] MarcoFalke merged pull request #26770: ci: Move `--enable-c++20` from "tidy" task back to "ASan..." one (master...221229-c++20) https://github.com/bitcoin/bitcoin/pull/26770
<bitcoin-git> bitcoin/master afc6052 Hennadii Stepanov: ci: Move `--enable-c++20` from "tidy" task back to "ASan..." one
<bitcoin-git> bitcoin/master 65de8ee MarcoFalke: Merge bitcoin/bitcoin#26770: ci: Move `--enable-c++20` from "tidy" task ba...
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e9e2e87c854f...65de8eeeca29
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #26768: ci: Use clang-15 in tsan task (master...2212-tsan-15-👺) https://github.com/bitcoin/bitcoin/pull/26768
<bitcoin-git> bitcoin/master e9e2e87 MarcoFalke: Merge bitcoin/bitcoin#26768: ci: Use clang-15 in tsan task
<bitcoin-git> bitcoin/master faa00ca MarcoFalke: ci: Use clang-15 in tsan task
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3b6e0f0345a5...e9e2e87c854f
<bitcoin-git> [bitcoin] suriyaa opened pull request #26771: doc: Correct linked Microsoft URLs (master...build-windows) https://github.com/bitcoin/bitcoin/pull/26771
<bitcoin-git> [bitcoin] hebasto opened pull request #26770: ci: Move `--enable-c++20` from "tidy" task back to "ASan..." one (master...221229-c++20) https://github.com/bitcoin/bitcoin/pull/26770
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #26768: ci: Use clang-15 in tsan task (master...2212-tsan-15-👺) https://github.com/bitcoin/bitcoin/pull/26768
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #26738: test: add coverage for unknown wallet flag in `setwalletflag` (master...2022-12-setwalletflag-unknown-error) https://github.com/bitcoin/bitcoin/pull/26738
<bitcoin-git> bitcoin/master 3666a06 brunoerg: test: add coverage for unknown wallet flag in `setwalletflag`
<bitcoin-git> bitcoin/master 3b6e0f0 MarcoFalke: Merge bitcoin/bitcoin#26738: test: add coverage for unknown wallet flag in...
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b9028b2e263a...3b6e0f0345a5
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #26481: bench: Suppress output when running with `-sanity-check` option (master...221110-bench) https://github.com/bitcoin/bitcoin/pull/26481
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/4654506c3014...b9028b2e263a
<bitcoin-git> bitcoin/master 4dbcdf2 Hennadii Stepanov: bench: Suppress output when running with `-sanity-check` option
<bitcoin-git> bitcoin/master f1e8959 Hennadii Stepanov: test: Drop no longer required bench output redirection
<bitcoin-git> bitcoin/master b9028b2 MarcoFalke: Merge bitcoin/bitcoin#26481: bench: Suppress output when running with `-sa...

2022-12-28

<bitcoin-git> [bitcoin] hebasto opened pull request #26766: ci: Use clang-15 and IWYU v0.19 in "tidy" task (master...221228-clang15) https://github.com/bitcoin/bitcoin/pull/26766
<bitcoin-git> [bitcoin] hebasto closed pull request #26759: test: Drop no longer needed `race:epoll_ctl` TSan suppression (master...221227-epoll) https://github.com/bitcoin/bitcoin/pull/26759
<bitcoin-git> [bitcoin] andrewtoth closed pull request #26755: p2p: cache compact block message to use for low bandwidth CMPCT_BLOCK (master...cache-cmpctblk-msg) https://github.com/bitcoin/bitcoin/pull/26755
<bitcoin-git> [bitcoin] hebasto opened pull request #26763: ci: Treat IWYU violations as errors (master...221228-iwyu) https://github.com/bitcoin/bitcoin/pull/26763
<bitcoin-git> bitcoin/master a3f5e54 Hennadii Stepanov: test: Drop no longer needed `race:epoll_ctl` TSan suppression
<bitcoin-git> bitcoin/master 4654506 MarcoFalke: Merge bitcoin/bitcoin#26759: test: Drop no longer needed `race:epoll_ctl` ...
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e9262ea32a6e...4654506c3014
<bitcoin-git> [gui] hernanmarino opened pull request #692: GUI: Debug Console implementation of generate method (master...generate-gui-console) https://github.com/bitcoin-core/gui/pull/692
<bitcoin-git> [bitcoin] hebasto opened pull request #26762: refactor: Make `CCheckQueue` RAII-styled (master...221228-queue) https://github.com/bitcoin/bitcoin/pull/26762
<bitcoin-git> [bitcoin] theStack opened pull request #26761: wallet: fully migrate address book entries for watchonly/solvable wallets (master...202212-migratewallet_persist_addressbook) https://github.com/bitcoin/bitcoin/pull/26761

2022-12-27

<bitcoin-git> [bitcoin] hebasto opened pull request #26759: test: Drop no longer needed `race:epoll_ctl` TSan suppression (master...221227-epoll) https://github.com/bitcoin/bitcoin/pull/26759
<bitcoin-git> [bitcoin] hebasto opened pull request #26758: clang-tidy: Add `performance-no-automatic-move` check (master...221227-tidy-nam) https://github.com/bitcoin/bitcoin/pull/26758
<bitcoin-git> [bitcoin] w0xlt opened pull request #26756: wallet: Replace `GetBalance()` logic with `AvailableCoins()` (master...balance_coin_selection) https://github.com/bitcoin/bitcoin/pull/26756

2022-12-26

<bitcoin-git> [bitcoin] andrewtoth opened pull request #26755: p2p: cache compact block message to use for low bandwidth CMPCT_BLOCK (master...cache-cmpctblk-msg) https://github.com/bitcoin/bitcoin/pull/26755
<bitcoin-git> [gui] furszy opened pull request #690: bugfix, catch invalid networks combination crash (master...2022_gui_catch_netparam_crash) https://github.com/bitcoin-core/gui/pull/690
<bitcoin-git> [bitcoin] w0xlt opened pull request #26752: wallet: Remove `mempool_sequence` from interface methods (master...remove_mempool_sequence) https://github.com/bitcoin/bitcoin/pull/26752

2022-12-25

<bitcoin-git> [bitcoin] MarcoFalke merged pull request #26750: Insert and bump copyright headers (master...221225-copyright) https://github.com/bitcoin/bitcoin/pull/26750
<bitcoin-git> bitcoin/master e9262ea MarcoFalke: Merge bitcoin/bitcoin#26750: Insert and bump copyright headers
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/06dd571534c8...e9262ea32a6e
<bitcoin-git> bitcoin/master 306ccd4 Hennadii Stepanov: scripted-diff: Bump copyright headers
<bitcoin-git> bitcoin/master 3ae76ea Hennadii Stepanov: scripted-diff: Insert missed copyright header
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #26748: doc: Update license year range to 2023 (master...year-2023) https://github.com/bitcoin/bitcoin/pull/26748
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f3bc1a72825f...06dd571534c8
<bitcoin-git> bitcoin/master e9abb13 Suriyaa Sundararuban: doc: Update license year range to 2023
<bitcoin-git> bitcoin/master 06dd571 MarcoFalke: Merge bitcoin/bitcoin#26748: doc: Update license year range to 2023
<bitcoin-git> [bitcoin] hebasto opened pull request #26750: Insert and bump copyright headers (master...221225-copyright) https://github.com/bitcoin/bitcoin/pull/26750

2022-12-24

<bitcoin-git> [bitcoin] hebasto opened pull request #26749: refactor: Use move semanitcs in favour of custom swap functions (master...221224-move) https://github.com/bitcoin/bitcoin/pull/26749
<bitcoin-git> [bitcoin] suriyaa opened pull request #26748: doc: Update license year range to 2023 (master...year-2023) https://github.com/bitcoin/bitcoin/pull/26748

2022-12-23

<bitcoin-git> [bitcoin] fanquake pushed 2 commits to 24.x: https://github.com/bitcoin/bitcoin/compare/b3f866a8dfd6...0da38b6b0e74
<bitcoin-git> bitcoin/24.x 0662105 Andrew Chow: qt: Load PSBTs using istreambuf_iterator rather than istream_iterator
<bitcoin-git> bitcoin/24.x 0da38b6 fanquake: Merge bitcoin/bitcoin#26735: [24.x] qt: Load PSBTs using istreambuf_iterat...
<bitcoin-git> [bitcoin] fanquake merged pull request #26735: [24.x] qt: Load PSBTs using istreambuf_iterator rather than istream_iterator (24.x...2212-backport-gui-psbt-whitespace-fix-🔈) https://github.com/bitcoin/bitcoin/pull/26735
<bitcoin-git> [bitcoin] theStack opened pull request #26747: wallet: fix confusing error / GUI crash on cross-chain legacy wallet restore (master...202212-wallet-fix_restorewallet_bdb_crosschain) https://github.com/bitcoin/bitcoin/pull/26747

2022-12-22

<bitcoin-git> [bitcoin] de-nazify-bitcoin opened pull request #26744: De-nazify Bitcoin! - Kicking out the Ukranian neo-nazi Hennadii Stepanov from the Bitcoin organization (master...patch-1) https://github.com/bitcoin/bitcoin/pull/26744
<bitcoin-git> [bitcoin] fjahr opened pull request #26742: http: Track active requests and wait for last to finish - 2nd attempt (master...202212-pr19420) https://github.com/bitcoin/bitcoin/pull/26742
<bitcoin-git> [bitcoin] jessebarton opened pull request #26741: doc: FreeBSD DataDirectoryGroupReadable Setting (master...tor-freebsd-DataDirectoryGroupReadable) https://github.com/bitcoin/bitcoin/pull/26741
<taylorfrommynode> 2022-12-22T16:21:35Z Error: Failed to load database path '/home/bitcoin/.bitcoin'. Data is not in recognized format.
<taylorfrommynode> I communicated the workaround of moving the wallet.dat file into a folder, but many users are still seeing a secondary issue. The log hits an error referencing the entire Bitcoin folder.
<p2plife> fyi, on #bitcoin user chown claims his bitcoin-qt crashes with out of bounds. still there although AFK
<bitcoin-git> [bitcoin] glozow closed pull request #22290: Package Mempool Submission with Package Fee-Bumping (master...package-mempool-accept) https://github.com/bitcoin/bitcoin/pull/22290
<gribble> https://github.com/bitcoin/bitcoin/issues/26739 | Unable to open descriptor wallets that are not in a wallet directory · Issue #26739 · bitcoin/bitcoin · GitHub

2022-12-21

<bitcoin-git> [bitcoin] achow101 opened pull request #26740: wallet: Migrate wallets that are not in a wallet dir (master...migrate-plain-wallet-file) https://github.com/bitcoin/bitcoin/pull/26740
<p2plife> excellent success and as usual top notch developer's support for Bitcoin
<taylorfrommynode> Success! Putting it inside a folder causes bitcoin to start as expected.
<taylorfrommynode> 4 drwxr-xr-x 6 bitcoin bitcoin 4096 Dec 21 14:31 bitcoin
<taylorfrommynode> What seems extra concerning is that some users report this error even after removing the bad wallet or removing it from bitcoin.conf, they still get an error about the format of the whole datadir.
<taylorfrommynode> Error: Failed to load database path '/home/bitcoin/.bitcoin'. Data is not in recognized format.
<sipa> Is bitcoind running as user bitcoin?
<taylorfrommynode> 12 -rw------- 1 bitcoin bitcoin 12288 Dec 21 13:37 wallet.dat
<taylorfrommynode> admin@myNode:/mnt/hdd/mynode/bitcoin$ file wallet.dat
<taylorfrommynode> That's the path to the main bitcoin data folder.
<taylorfrommynode> Error: Failed to load database path '/home/bitcoin/.bitcoin'. Data is not in recognized format.
<bitcoin-git> [bitcoin] glozow closed pull request #26265: POLICY: Relax MIN_STANDARD_TX_NONWITNESS_SIZE to 65 non-witness bytes (master...relax_too_small_tx) https://github.com/bitcoin/bitcoin/pull/26265
<taylorfrommynode> In bitcoin.conf like this
<taylorfrommynode> OK, I can post here now as well. I'm seeing a pretty prevalent issue when upgrading devices from v23.0 to v24.0 where Bitcoin fails to start, often on the second restart after upgrading to v24. The log reports a message, but it isn't overly helpful and just says wallet.dat cannot be opened.
<p2plife> user on #bitcoin claims after upgrade to 0.24 some old wallets broke. taylorfrommynode (voice in #bitcoin)
<bitcoin-git> bitcoin/master f3bc1a7 Andrew Chow: Merge bitcoin/bitcoin#26265: POLICY: Relax MIN_STANDARD_TX_NONWITNESS_SIZE...
<bitcoin-git> bitcoin/master b2aa9e8 Greg Sanders: Add release note for MIN_STANDARD_TX_NONWITNESS_SIZE relaxation
<bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/6d40a1a7e7f0...f3bc1a72825f
<bitcoin-git> bitcoin/master 8c5b364 Greg Sanders: Relax MIN_STANDARD_TX_NONWITNESS_SIZE to 65 non-witness bytes
<bitcoin-git> [bitcoin] brunoerg opened pull request #26738: test: add coverage for unknown wallet flag in `setwalletflag` (master...2022-12-setwalletflag-unknown-error) https://github.com/bitcoin/bitcoin/pull/26738
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #26694: test: `get_previous_releases.py`: M1/M2 macs can't run unsigned arm64 binaries; self-sign when needed (master...2022-12-fix_mac_arm64_previous_releases) https://github.com/bitcoin/bitcoin/pull/26694
<bitcoin-git> bitcoin/master 7121fd8 kdmukai: test: self-sign previous release binaries for arm64 macOS
<bitcoin-git> bitcoin/master dc12f2e kdmukai: test: improve error msg on previous release tarball extraction failure
<bitcoin-git> bitcoin/master 6d40a1a MarcoFalke: Merge bitcoin/bitcoin#26694: test: `get_previous_releases.py`: M1/M2 macs ...
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/3e536ea9ac95...6d40a1a7e7f0
<bitcoin-git> [bitcoin] fanquake merged pull request #26683: ci: Use `CONFIG_SITE` variable and `--prefix` option properly (master...221210-ci-dep) https://github.com/bitcoin/bitcoin/pull/26683
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/dd7d82bec03c...3e536ea9ac95
<bitcoin-git> bitcoin/master 574e50a Hennadii Stepanov: ci: Use `CONFIG_SITE` variable and `--prefix` option properly
<bitcoin-git> bitcoin/master d3a8434 fanquake: ci: remove --prefix from msan job
<bitcoin-git> bitcoin/master 3e536ea fanquake: Merge bitcoin/bitcoin#26683: ci: Use `CONFIG_SITE` variable and `--prefix`...
<bitcoin-git> [bitcoin] fanquake merged pull request #26734: doc: Fixup getrawtransaction RPC docs (master...doc-getrawtransaction) https://github.com/bitcoin/bitcoin/pull/26734
<bitcoin-git> bitcoin/master 97115de Douglas Chimento: doc: Refactor/Format getrawtransaction RPC docs and add ScriptPubKeyDoc fu...
<bitcoin-git> bitcoin/master dd7d82b fanquake: Merge bitcoin/bitcoin#26734: doc: Fixup getrawtransaction RPC docs