<bitcoin-git>
bitcoin/master bb5ea1d Andrew Chow: qt: Load PSBTs using istreambuf_iterator rather than istream_iterator
<bitcoin-git>
[gui] MarcoFalke merged pull request #687: Load PSBTs using istreambuf_iterator rather than istream_iterator (master...load-psbt-istreambuf) https://github.com/bitcoin-core/gui/pull/687
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #26722: test: speed up the two slowest functional tests by 18-35% via `keypoolrefill()` (master...wallet_fundrawtransaction_speedup) https://github.com/bitcoin/bitcoin/pull/26722
<bitcoin-git>
bitcoin/master 8e0faba S3RK: test: make wallet_migration.py pass with both wallet flags
<bitcoin-git>
bitcoin/master 17554ef S3RK: test: prefer sqlite for wallet tests
<bitcoin-git>
bitcoin/master 8456bfa Andrew Chow: Merge bitcoin/bitcoin#26638: test: prefer sqlite for wallet tests
<bitcoin-git>
[bitcoin] yusufsahinhamza opened pull request #26733: test: Add test for `sendmany` rpc that uses `subtractfeefrom` parameter (master...add-sendmany-test) https://github.com/bitcoin/bitcoin/pull/26733
<bytes1440000>
Happy Holidays. I wanted to make this happier for someone else as it was the first time someone appreciated my efforts in last few years. It wasnt bitcoin or bitcoin core but nostr.
<bytes1440000>
Hi michaelfolkson, my email on bitcoin-dev was not ranting, raving or throwing toys. It was 90% facts with links and 10% opinion.
<bitcoin-git>
[bitcoin] furszy opened pull request #26732: wallet: tx creation, don't select outputs from txes that are being replaced (master...2022_wallet_do_not_select_utxo_from_the_tx_being_replaced) https://github.com/bitcoin/bitcoin/pull/26732
<sipa>
In the Bitcoin Core source code, see key_io.cpp for higher-level conversions between witness programs and addresses.
2022-12-19
<bitcoin-git>
[bitcoin] achow101 closed pull request #23417: wallet, spkm: Move key management from DescriptorScriptPubKeyMan to wallet level KeyManager (master...wallet-keyman) https://github.com/bitcoin/bitcoin/pull/23417
<bitcoin-git>
[bitcoin] achow101 opened pull request #26728: wallet: Have the wallet store the key for automatically generated descriptors (master...wallet-knows-master-key) https://github.com/bitcoin/bitcoin/pull/26728
<bitcoin-git>
[bitcoin] fanquake opened pull request #26727: rpc: remove optional from fStateStats fields (master...remove_fstatestats_post_26515) https://github.com/bitcoin/bitcoin/pull/26727
<bitcoin-git>
[bitcoin] fanquake closed pull request #26723: test: call `keypoolrefill` with priv key disabled should throw an error (master...2022-12-keypool-error-privatekey) https://github.com/bitcoin/bitcoin/pull/26723
<bitcoin-git>
[bitcoin] brunoerg opened pull request #26723: test: call `keypoolrefill` with priv key disabled should throw an error (master...2022-12-keypool-error-privatekey) https://github.com/bitcoin/bitcoin/pull/26723
<bitcoin-git>
[gui] achow101 opened pull request #687: qt: Load PSBTs using istreambuf_iterator rather than istream_iterator (master...load-psbt-istreambuf) https://github.com/bitcoin-core/gui/pull/687
<bitcoin-git>
[bitcoin] kdmukai opened pull request #26722: test: speed up the two slowest functional tests by 18-35% via `keypoolrefill()` (master...wallet_fundrawtransaction_speedup) https://github.com/bitcoin/bitcoin/pull/26722
<bitcoin-git>
[bitcoin] brunoerg opened pull request #26721: test, lint: add `crypted` to `ignore-words` (master...2022-12-fix-codespell-walletload) https://github.com/bitcoin/bitcoin/pull/26721
<bitcoin-git>
[bitcoin] furszy opened pull request #26720: wallet: coin selection, don't return results that exceed the max allowed weight (master...2022_coin_selection_weight) https://github.com/bitcoin/bitcoin/pull/26720
<Murch1>
The Bitcoin Core wallet should really keep track of its UTXO pool instead of recalculating it from its list of transactions every time it needs it
<sipa>
e.g. you know that any signature that your bitcoin core wallet will be involved in, will have access to that wallet's private key
<bitcoin-git>
[bitcoin] achow101 opened pull request #26715: Introduce `MockableDatabase` for wallet unit tests (master...test-wallet-corrupt) https://github.com/bitcoin/bitcoin/pull/26715
<bitcoin-git>
[bitcoin] brunoerg opened pull request #26714: test: add coverage for unparsable `-maxuploadtarget` (master...2022-12-maxuploadtarget-parse-test) https://github.com/bitcoin/bitcoin/pull/26714
<sdaftuar>
_aj_: i think you'll run into the same issues we have in Bitcoin Core's logic wrt DoS. fundamentally we don't have a total ordering on transaction desirability, and that leads to the DoS concerns we have
<bitcoin-git>
[bitcoin] JeremyRubin closed pull request #22876: [TESTS] Update Transaction Tests to permit setting a flag as always on and disabling the exhaustive failure test (master...update-txvalid-json) https://github.com/bitcoin/bitcoin/pull/22876
<bitcoin-git>
[bitcoin] JeremyRubin closed pull request #23309: [WIP] Add a basic python REST API Server Wrapper (master...rest-python) https://github.com/bitcoin/bitcoin/pull/23309
<bitcoin-git>
[bitcoin] JeremyRubin closed pull request #22954: [TESTS] Allow tx_invalid.json tests to include flag rules for if_unset: [A,B,C] then_unset: [D] (master...if_unset_then_unset) https://github.com/bitcoin/bitcoin/pull/22954
<aureleoules>
It contains a pre-compiled bitcoin-core with ccache (thus the image is heavy) but the first compilation is fast
<brunoerg>
reminding that it's not a generalist C++ tool, but focused on Bitcoin Core, because we have e.g. CAmount a = 1; and most tools can't deal with it
<bitcoin-git>
bitcoin/master 89c1491 furszy: wallet: if only have one output type, don't perform "mixed" coin selection
<bitcoin-git>
bitcoin/master ba47a4b Andrew Chow: Merge bitcoin/bitcoin#26668: wallet: if only have one output type, don't p...
<bitcoin-git>
[bitcoin] brunoerg opened pull request #26701: contrib: make DNS seeds file an argument in CLI (`makeseeds`) (master...2022-12-seeds-improv) https://github.com/bitcoin/bitcoin/pull/26701
<bitcoin-git>
[bitcoin] LarryRuane opened pull request #26697: logging: use std::bitset for categories (master...2022-12-log-categories-stdbitset) https://github.com/bitcoin/bitcoin/pull/26697
2022-12-13
<bitcoin-git>
bitcoin/master daf881d Andrew Chow: Merge bitcoin/bitcoin#23319: rpc: Return fee and prevout (utxos) to getraw...
<bitcoin-git>
bitcoin/master f866971 Douglas Chimento: rpc: Return fee and prevout(s) to getrawtransaction
<bitcoin-git>
[bitcoin] achow101 merged pull request #23319: rpc: Return fee and prevout (utxos) to getrawtransaction (master...23264-fee-getrawtransaction) https://github.com/bitcoin/bitcoin/pull/23319
<bitcoin-git>
bitcoin/master e75d227 John Moffett: Minor fix: Don't directly delete abandoned txes
<bitcoin-git>
[bitcoin] achow101 merged pull request #26643: wallet: Move fee underpayment check to after all fee has been set (master...move-fee-underpay-check) https://github.com/bitcoin/bitcoin/pull/26643
<bitcoin-git>
bitcoin/master e5daf97 Andrew Chow: wallet: Rename nFeeRet in CreateTransactionInternal to current_fee
<bitcoin-git>
bitcoin/master c1a84f1 Andrew Chow: wallet: Move fee underpayment check to after fee setting
<bitcoin-git>
bitcoin/master 798430d Andrew Chow: wallet: Sanity check fee paid cannot be negative
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #26628: RPC: Reject RPC requests with same named parameter specified multiple times (master...pr/nmult) https://github.com/bitcoin/bitcoin/pull/26628
<bitcoin-git>
bitcoin/master e2c3b18 Ryan Ofsky: test: Add RPC tests for same named parameter specified more than once
<bitcoin-git>
bitcoin/master 6bd1d20 Ryan Ofsky: rpc: Make it an error server-side to specify same named parameter multiple...
<bitcoin-git>
bitcoin/master d1ca563 Ryan Ofsky: bitcoin-cli: Make it an error to specify the "args" parameter two differen...
<bitcoin-git>
[bitcoin] glozow opened pull request #26695: bench: BlockAssembler on a mempool with packages (master...2022-12-bench-miner) https://github.com/bitcoin/bitcoin/pull/26695
<bitcoin-git>
[bitcoin] kdmukai opened pull request #26694: test: `get_previous_releases.py`: M1/M2 macs can't run the unsigned v23.0 arm64 binary; fall back to x86_64 binary (master...2022-12-fix_mac_arm64_previous_releases) https://github.com/bitcoin/bitcoin/pull/26694
<kdmukai>
fanquake: ya. "bitcoin-qt: code object is not signed at all" vs "Signature size=8958" etc.
<fanquake>
if you run codesign —display —versbose and pass either bitcoin-qt bin, you’ll see what I mean.
<fanquake>
The bitcoin-qt in the tarball wont be code signed. It likely would have just run ok on previous versions of macOS. However with newer versions of macOS that is less likely the case
<kdmukai>
then just directly downloaded the dmg version from https://bitcoincore.org/bin/bitcoin-core-23.0/ and that installed and ran fine. When Sjors ran a diff on the two v23.0 bitcoin-qt binaries (the one from the tar.gz vs what was unpacked from the dmg), they came up as different, which confounded Sjors.
<bitcoin-git>
[bitcoin] achow101 opened pull request #26690: wallet: Refactor database cursor into its own object with proper return codes (master...walletdb-cursor-unstupidfy) https://github.com/bitcoin/bitcoin/pull/26690
<bitcoin-git>
[bitcoin] josibake opened pull request #26689: test: add add_wallet_options to TestShell (master...josibake-add-wallet-options-test-shell) https://github.com/bitcoin/bitcoin/pull/26689
<bitcoin-git>
[bitcoin] hebasto opened pull request #26688: Move `CopyrightHolders()` and `LicenseInfo()` into `libbitcoin_common` (master...221212-common) https://github.com/bitcoin/bitcoin/pull/26688
<bitcoin-git>
[bitcoin] 1440000bytes closed pull request #26682: doc: add expectation that dns seed domain should not be used for other things (master...doc-seed) https://github.com/bitcoin/bitcoin/pull/26682
<bytes1440000>
DNS seed domain for bitcoin core has has only one thing
<bytes1440000>
However, I have seen vulnerability in website leads to bigger things. Why take risks for all bitcoin core users? Use domain only for bitcoin core dns seed and other domains for other things.
<bitcoin-git>
[bitcoin] 1440000bytes opened pull request #26682: doc: add expectation that dns seed domain should not be used for other things (master...doc-seed) https://github.com/bitcoin/bitcoin/pull/26682
<bitcoin-git>
[bitcoin] yusufsahinhamza opened pull request #26681: net, contrib: Fix checking bad dns seeds without casting (master...fix-makeseeds-bug) https://github.com/bitcoin/bitcoin/pull/26681
<bitcoin-git>
[bitcoin] achow101 opened pull request #26679: wallet: Skip rescanning if wallet is more recent than tip (master...skip-newer-wallet-rescan) https://github.com/bitcoin/bitcoin/pull/26679
<bitcoin-git>
[bitcoin] john-moffett opened pull request #26675: wallet: For feebump, ignore abandoned descendant spends (master...2022_12_Bumpfee_ignore_abandoned) https://github.com/bitcoin/bitcoin/pull/26675
<bitcoin-git>
[bitcoin] AaronDewes opened pull request #26674: Add reindex=auto flag to automatically reindex corrupt data (master...auto-recovery) https://github.com/bitcoin/bitcoin/pull/26674
<pinheadmz>
any recco's for installing bitcoin core in a github CI action? trying wget bitcoincore.org now, takes like 10 minutes just to download
<stacie>
vasild: I could be mistaken but I think there might be enums for most of these things? For example, the ConnectionType enum in src/node/connection_types.h. I will admit this new RPC is pushing the limits of both my C++ and Bitcoin Core knowledge :)
<bitcoin-git>
[bitcoin] furszy opened pull request #26668: wallet: if only have one output type, don't perform "mixed" coin selection (master...2022_wallet_double_coin_selection) https://github.com/bitcoin/bitcoin/pull/26668