<prayank>
Coin Control is important and should always remain part of bitcoin wallets that care about privacy. If UX needs to be improved there can be a checkbox in settings to disable it. Or if wallet has no coin control but cluster control, removing it will not reduce errors it will change nature of errors and create new issues.
<prayank>
Sorry if this looks offtopic because of link but concept is ontopic. After working on several privacy related PRs in Core and then WW2 I realized core is not that bad with no marketing and coinjoin. Privacy is expressing yourself selectively. Everything is public on Bitcoin but if user wants to share links of transactions with less people that is privacy.
<bitcoin-git>
[bitcoin] hebasto opened pull request #24265: Drop StripRedundantLastElementsOfPath() function and re-enable Windows tests (master...220204-norm) https://github.com/bitcoin/bitcoin/pull/24265
<bitcoin-git>
[bitcoin] MarcoFalke closed pull request #23545: scripted-diff: Use clang-tidy syntax for C++ named arguments (master...2109-docNamedArgs) https://github.com/bitcoin/bitcoin/pull/23545
<bitcoin-git>
[gui] hebasto merged pull request #524: Replace int with std::chrono in for the timer->setInterval() argument (master...220112-chrono) https://github.com/bitcoin-core/gui/pull/524
<bitcoin-git>
[bitcoin] brunoerg opened pull request #24258: test: check localaddresses in getnetworkinfo for nodes with proxy (master...2022-02-check-localaddresses) https://github.com/bitcoin/bitcoin/pull/24258
<achow101>
apparently bull bitcoin (an exchange) uses sffo to make their users pay the fee if they want to opt out of batched transactions. limiting to manual would break that use case
<Guest>
I am new to git.. I am trying to push a commit regarding this (https://github.com/bitcoin/bitcoin/issues/20576) .. I am getting this message when I am trying to push the code remote: Permission to bitcoin/bitcoin.git denied to anshu-khare-design ..
<Guest>
Hii I have successfully built Bitcoin core on Windows with the help of Visual Studio.. I want to take this (https://github.com/bitcoin/bitcoin/issues/20576) issue as the starting point of contribution.. Could you please tell some code pointers related to this issue?
<bitcoin-git>
[bitcoin] jarolrod opened pull request #24241: doc: cleanup doc on need of Developer Account to obtain macOS SDK (master...macdeploy-readme-cleanups) https://github.com/bitcoin/bitcoin/pull/24241
<bitcoin-git>
[bitcoin] laanwj merged pull request #23948: build: add support for FreeBSD to depends (master...depends_support_freebsd) https://github.com/bitcoin/bitcoin/pull/23948
<bitcoin-git>
[bitcoin] theuni opened pull request #24240: depends: fix capnp's descriptor for make download (master...fix-capnp-fetch) https://github.com/bitcoin/bitcoin/pull/24240
<bitcoin-git>
[bitcoin] mzumsande opened pull request #24239: test: fix ceildiv division by using integers (master...202201_test_ceilingfix) https://github.com/bitcoin/bitcoin/pull/24239
<bitcoin-git>
[bitcoin] theStack opened pull request #24238: random: use arc4random on OpenBSD (master...202202-random-use_arc4random_on_OpenBSD) https://github.com/bitcoin/bitcoin/pull/24238
<bitcoin-git>
bitcoin/master a41976a MarcoFalke: Merge bitcoin/bitcoin#24223: test: use MiniWallet for interface_rest.py
<vasild>
Shall we target https://github.com/bitcoin/bitcoin/pull/23542 for 23.0? I think there is a consensus that it should be done in general and some discussion about the details - which ports to consider "bad" and where to document/define those.
2022-02-01
<bitcoin-git>
[bitcoin] jamesob opened pull request #24232: assumeutxo: add init and completion logic (master...2022-02-au-init-and-completion) https://github.com/bitcoin/bitcoin/pull/24232
<prayank>
random_man: I am assuming you already have a mentor but it looking for more resources: 1. Compile bitcoin core, run 2 or more regtest nodes, connect them, try different RPC commands etc. 2. Ask questions on stackexchange, read posts on mailing list, reddit, twitter etc. 3. Review pull requests that are easier to understand initially. Example:#24180
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #24231: streams: Fix read-past-the-end and integer overflows (master...2201-streamIgnore) https://github.com/bitcoin/bitcoin/pull/24231
<bitcoin-git>
[bitcoin] achow101 merged pull request #24083: Revert "Add to spends only transcations from me" (master...restore_wallet_conflicts) https://github.com/bitcoin/bitcoin/pull/24083
<michaelfolkson>
random_man: Start with #bitcoin-core-pr-reviews channel and https://bitcoincore.reviews/. That has some resources for new contributors at the bottom
<random_man>
hello, I am participating in the summer of bitcoin. I am looking forward to contributing to bitcoin core, so can anyone guide me as this is my first open-source thing.
<bitcoin-git>
[bitcoin] MarcoFalke closed pull request #17704: depends: Set default depends fallback url to drahtbot.space (master...1912-dependsDrahtBot) https://github.com/bitcoin/bitcoin/pull/17704
<bitcoin-git>
[bitcoin] ryanofsky opened pull request #24230: indexes: Stop using node API and locking cs_main, improve sync logic (master...pr/indexy) https://github.com/bitcoin/bitcoin/pull/24230
<bitcoin-git>
[bitcoin] MarcoFalke reopened pull request #17704: depends: Set default depends fallback url to drahtbot.space (master...1912-dependsDrahtBot) https://github.com/bitcoin/bitcoin/pull/17704
<bitcoin-git>
[bitcoin] Sjors opened pull request #24226: rpc: warn that nodes ignore requests for old stale blocks (master...2022/02/dontfetcholdblocks) https://github.com/bitcoin/bitcoin/pull/24226
<Guest>
directory [C:\Users\Dell\bitcoin\build_msvc\libbitcoin_qt\libbitcoin_qt.vcxproj]C:\Users\Dell\bitcoin\src\qt\addresstablemodel.h(8,10): fatal error C1083: Cannot open include file: 'QAbstractTableModel': No such file or directory [C:\Users\Dell\bitcoin\build_msvc\libbitcoin_qt\libbitcoin_q
<Guest>
Hii.. I have finally built Qt on Windows.. But when I run "msbuild -property:Configuration=Release -maxCpuCount -verbosity:minimal bitcoin.sln" on x64 Native Tools Command Promptfor VS2019, I get following messages :C:\Users\Dell\bitcoin\src\qt\addressbookpage.h(8,10): fatal error C1083: Cannot open include file: 'QDialog': No such file or
2022-01-31
<bitcoin-git>
[bitcoin] theStack opened pull request #24223: test: use MiniWallet for interface_rest.py (master...202201-test-use_MiniWallet_for_interface_rest) https://github.com/bitcoin/bitcoin/pull/24223
<bitcoin-git>
[bitcoin] RandyMcMillan closed pull request #24222: cirrus: add yum clean all to CentOS 8 sequence (master...1643660765-add-yum-clean-all) https://github.com/bitcoin/bitcoin/pull/24222
<bitcoin-git>
[bitcoin] RandyMcMillan opened pull request #24222: cirrus: add yum clean all to CentOS 8 sequence (master...1643660765-add-yum-clean-all) https://github.com/bitcoin/bitcoin/pull/24222
<bitcoin-git>
[gui] RandyMcMillan opened pull request #540: gui: network graph - show/hide panels based on window width/height (master...1643654791-show-hide-gui-elements-based-on-size) https://github.com/bitcoin-core/gui/pull/540
<bitcoin-git>
[bitcoin] jonatack opened pull request #24220: validation, refactor: remove cs_main lock from CChainState::IsInitialBlockDownload() (master...remove-cs_main-lock-from-IsInitialBlockDownload) https://github.com/bitcoin/bitcoin/pull/24220
<bitcoin-git>
[bitcoin] PastaPastaPasta opened pull request #24213: refactor: use Span in random.*; make GetRand a template, remove GetRandInt (master...refactor-random) https://github.com/bitcoin/bitcoin/pull/24213
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #24103: Replace RecursiveMutex `m_cs_chainstate` with Mutex, and rename it (master...m_cs_chainstate_mutex) https://github.com/bitcoin/bitcoin/pull/24103
<bitcoin-git>
[bitcoin] fanquake merged pull request #24111: build: force CRCCheck in Windows installer (master...force_win_installer_crccheck) https://github.com/bitcoin/bitcoin/pull/24111
<bitcoin-git>
[bitcoin] jonatack opened pull request #24199: Add cs_main annotation to WriteBatchSync(), drop lock in CDiskBlockIndex (master...remove-cs_main-lock-in-CDiskBlockIndex) https://github.com/bitcoin/bitcoin/pull/24199
2022-01-28
<bitcoin-git>
[bitcoin] brunoerg opened pull request #24198: wallet, rpc: add wtxid in WalletTxToJSON (master...2022-01-listtransactions-wtxid) https://github.com/bitcoin/bitcoin/pull/24198
<sipa>
Our current codebase in bitcoin core can already compute witness sizes.
<bitcoin-git>
[bitcoin] jonatack opened pull request #24197: Replace lock with thread safety annotation in CBlockTreeDB::LoadBlockIndexGuts() (master...replace-lock-with-annotation-in-LoadBlockIndexGuts) https://github.com/bitcoin/bitcoin/pull/24197
<michaelfolkson>
[19:52:04] <sipa> I mean, it could... but there is no need for it. E.g. we could have a bitcoin-miniscript-compiler tool, or a "compileminiscript" RPC. But I doubt we'll want to put all that functionality inside bitcoin core, as it can be done externally just as well.
<sipa>
I mean, it could... but there is no need for it. E.g. we could have a bitcoin-miniscript-compiler tool, or a "compileminiscript" RPC. But I doubt we'll want to put all that functionality inside bitcoin core, as it can be done externally just as well.
<sipa>
The thing that would be integrated into Bitcoin Core is the miniscript side of things, i.e., the output of the policy compiler if that's what you use to construct it.
<sipa>
michaelfolkson: Not sure how clear that is, but what is shown/entered on my miniscript site (https://bitcoin.sipa.be/miniscript/) is two very different languages. They look similar which may make it confusing, but their purpose is completely different. One is the policy language, which is for writing "under what conditions should my output be spendable". The other is miniscript (which is a 1-to-1 mapping with Bitcoin Script, but a bit more readable). The
<sipa>
That's right. It needs Bitcoin Core right now.
<sipa>
Miniscript is just a bunch of source files which are mostly intended to be integrated into Bitcoin Core.
<sipa>
it'll just be merged into bitcoin core
<sipa>
But that's not something I'm expecting would be integrated into Bitcoin Core.
<sipa>
In the long term, with the miniscript codebase integrated into bitcoin core, a significant part of the logic around descriptors and signing can be handled by miniscript, which does lots of things generically.
<sipa>
Ok, so, currently the bitcoin core codebase doesn't have miniscript implemented.
<bitcoin-git>
[bitcoin] PastaPastaPasta opened pull request #24185: refactor: only use explicit reinterpret/const casts, not implicit (master...explicit-reinterpret-cast) https://github.com/bitcoin/bitcoin/pull/24185