2021-05-11

< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21895: refactor: Add TSA annotations to the WorkQueue class members (master...210509-tsa) https://github.com/bitcoin/bitcoin/pull/21895
< bitcoin-git> bitcoin/master 34b04ee Hennadii Stepanov: refactor: Add TSA annotations to the WorkQueue class members
< bitcoin-git> bitcoin/master d2f6d29 MarcoFalke: Merge bitcoin/bitcoin#21895: refactor: Add TSA annotations to the WorkQueu...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4a267057617a...d2f6d2976f50

2021-05-10

< bitcoin-git> [bitcoin] fanquake closed pull request #21880: wallet: remove GetScriptPubKeyMan spam (master...GetScriptPubKeyMan-spam) https://github.com/bitcoin/bitcoin/pull/21880
< bitcoin-git> [bitcoin] fanquake merged pull request #21902: refactor: Remove useless extern keyword (master...2105-cppExtern) https://github.com/bitcoin/bitcoin/pull/21902
< bitcoin-git> bitcoin/master 4a26705 fanquake: Merge bitcoin/bitcoin#21902: refactor: Remove useless extern keyword
< bitcoin-git> bitcoin/master fa4bbd3 MarcoFalke: refactor: Remove useless extern keyword
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4bc3b1634984...4a267057617a
< bitcoin-git> [gui] hebasto closed pull request #227: Add URI info into -help output (master...210224-help) https://github.com/bitcoin-core/gui/pull/227
< bitcoin-git> [gui] hebasto merged pull request #293: Enable wordWrap for Services (master...enable-wordwrap-services) https://github.com/bitcoin-core/gui/pull/293
< bitcoin-git> bitcoin/master 4bc3b16 Hennadii Stepanov: Merge bitcoin-core/gui#293: Enable wordWrap for Services
< bitcoin-git> bitcoin/master a0f7978 randymcmillan: qt: enable wordWrap for peers-tab detail services
< bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b49fe0a75aef...4bc3b1634984
< bitcoin-git> bitcoin/master 3bad0b3 unknown: Remove user input from URI error message
< bitcoin-git> bitcoin/master b49fe0a Hennadii Stepanov: Merge bitcoin-core/gui#280: Remove user input from URI error message
< bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a2bdbdb358dd...b49fe0a75aef
< bitcoin-git> [gui] hebasto merged pull request #280: Remove user input from URI error message (master...uri-error) https://github.com/bitcoin-core/gui/pull/280
< bitcoin-git> bitcoin/master a2bdbdb Hennadii Stepanov: Merge bitcoin-core/gui#194: Save/restore RPCConsole geometry only for wind...
< bitcoin-git> bitcoin/master 01d9586 Hennadii Stepanov: qt: Save/restore RPCConsole geometry only for window
< bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8d7125f80e2b...a2bdbdb358dd
< bitcoin-git> [gui] hebasto merged pull request #194: Save/restore RPCConsole geometry only for window (master...210121-window) https://github.com/bitcoin-core/gui/pull/194
< bitcoin-git> bitcoin/master 8d7125f Hennadii Stepanov: Merge bitcoin-core/gui#257: refactor: Use template function qOverload in s...
< bitcoin-git> bitcoin/master cdbc2bd Hennadii Stepanov: qt: Use template function qOverload in signal-slot connections
< bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d8ae29ec8f08...8d7125f80e2b
< bitcoin-git> [gui] hebasto merged pull request #257: refactor: Use template function qOverload in signal-slot connections (master...210323-overload) https://github.com/bitcoin-core/gui/pull/257
< bitcoin-git> [bitcoin] hebasto opened pull request #21907: wallet: Do not iterate system folders on Windows (master...210510-win) https://github.com/bitcoin/bitcoin/pull/21907
< bitcoin-git> [bitcoin] promag opened pull request #21906: refactor: Preserve const in cast on CTransactionSignatureSerializer (master...2021-05-fix-cast) https://github.com/bitcoin/bitcoin/pull/21906
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21900: test: use MiniWallet for feature_csv_activation.py (master...20210507-test-convert_csvtest_miniwallet) https://github.com/bitcoin/bitcoin/pull/21900
< bitcoin-git> bitcoin/master bd7f27d Sebastian Falbesoner: refactor: feature_csv_activation.py: move tx helper functions to methods
< bitcoin-git> bitcoin/master d8ae29e MarcoFalke: Merge bitcoin/bitcoin#21900: test: use MiniWallet for feature_csv_activati...
< bitcoin-git> bitcoin/master 2eca46b Sebastian Falbesoner: test: use MiniWallet for feature_csv_activation.py
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/32692d26813b...d8ae29ec8f08
< bitcoin-git> [bitcoin] Crypt-iQ opened pull request #21905: net: set nMessageSize to 0 in CMessageHeader ctor (master...cmessageheader_signchange_05102021) https://github.com/bitcoin/bitcoin/pull/21905
< bitcoin-git> [bitcoin] laanwj merged pull request #21359: rpc: include_unsafe option for fundrawtransaction (master...fund-raw-transaction-allow-unsafe) https://github.com/bitcoin/bitcoin/pull/21359
< bitcoin-git> bitcoin/master 11d6459 t-bast: rpc: include_unsafe option for fundrawtransaction
< bitcoin-git> bitcoin/master 32692d2 W. J. van der Laan: Merge bitcoin/bitcoin#21359: rpc: include_unsafe option for fundrawtransac...
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8bed1706eac4...32692d26813b
< bitcoin-git> bitcoin/master 8bed170 Hennadii Stepanov: Merge bitcoin-core/gui#296: Do not use QObject::tr plural syntax for numbe...
< bitcoin-git> bitcoin/master 3adde72 Hennadii Stepanov: qt: Do not use QObject::tr plural syntax for numbers with a unit symbol
< bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c9b051b58fc4...8bed1706eac4
< bitcoin-git> [gui] hebasto merged pull request #296: Do not use QObject::tr plural syntax for numbers with a unit symbol (master...210425-plurals) https://github.com/bitcoin-core/gui/pull/296
< bitcoin-git> [bitcoin] laanwj merged pull request #21891: fuzz: Remove strprintf test cases that are known to fail (master...2105-fuzzStr) https://github.com/bitcoin/bitcoin/pull/21891
< bitcoin-git> bitcoin/master facfc0f MarcoFalke: fuzz: Remove strprintf test cases that are known to fail
< bitcoin-git> bitcoin/master c9b051b W. J. van der Laan: Merge bitcoin/bitcoin#21891: fuzz: Remove strprintf test cases that are kn...
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c49d24664790...c9b051b58fc4
< bitcoin-git> [bitcoin] laanwj merged pull request #21745: refactor: Add missing includes in pubkey.cpp/pubkey.h (master...refactor_imports_pubkey) https://github.com/bitcoin/bitcoin/pull/21745
< bitcoin-git> bitcoin/master 71c824e William Bright: cleaned up and added missing "include" statements for pubkey.cpp and pubke...
< bitcoin-git> bitcoin/master c49d246 W. J. van der Laan: Merge bitcoin/bitcoin#21745: refactor: Add missing includes in pubkey.cpp/...
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f8176b768a1c...c49d24664790
< bitcoin-git> [gui] laanwj opened pull request #323: qt: English translations update (master...2021-05-translations-update) https://github.com/bitcoin-core/gui/pull/323
< bitcoin-git> [bitcoin] laanwj merged pull request #21836: scripted-diff: Replace three dots with ellipsis in the UI strings (master...210502-ellipsis) https://github.com/bitcoin/bitcoin/pull/21836
< bitcoin-git> bitcoin/master f8176b7 W. J. van der Laan: Merge bitcoin/bitcoin#21836: scripted-diff: Replace three dots with ellips...
< bitcoin-git> bitcoin/master d66f283 Hennadii Stepanov: scripted-diff: Replace three dots with ellipsis in the UI strings
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1a60c547fd4d...f8176b768a1c
< bitcoin-git> [bitcoin] laanwj merged pull request #21749: test: Bump shellcheck version (master...210422-shell) https://github.com/bitcoin/bitcoin/pull/21749
< bitcoin-git> bitcoin/master 1a60c54 W. J. van der Laan: Merge bitcoin/bitcoin#21749: test: Bump shellcheck version
< bitcoin-git> bitcoin/master 08f3dbb Hennadii Stepanov: test: Bump shellcheck version
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1591e350495f...1a60c547fd4d
< bitcoin-git> [bitcoin] laanwj merged pull request #21708: build: Drop pointless sed commands (master...210416-sed) https://github.com/bitcoin/bitcoin/pull/21708
< bitcoin-git> bitcoin/master 1591e35 W. J. van der Laan: Merge bitcoin/bitcoin#21708: build: Drop pointless sed commands
< bitcoin-git> bitcoin/master f52fafc Hennadii Stepanov: build: Drop pointless sed commands
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/adf784341002...1591e350495f
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #19381: Fix UBSan warnings triggered when loading corrupt mempool.dat files (master...loadmempool-UB) https://github.com/bitcoin/bitcoin/pull/19381
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21902: refactor: Remove useless extern keyword (master...2105-cppExtern) https://github.com/bitcoin/bitcoin/pull/21902
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21786: wallet: ensure sat/vB feerates are in range (mantissa of 3) (master...ensure-sat-vb-feerates-are-in-range) https://github.com/bitcoin/bitcoin/pull/21786
< bitcoin-git> bitcoin/master b503327 Jon Atack: test: type error and out of range fee rates where missing
< bitcoin-git> bitcoin/master c5fd434 Jon Atack: test: explicit fee rates with invalid amounts
< bitcoin-git> bitcoin/master ea6f76b Jon Atack: test: improve zero-value explicit fee rate coverage
< bitcoin-git> [bitcoin] MarcoFalke pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/2a22d903f3da...adf784341002
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21897: rpc: adjust incorrect RPCHelpMan types (master...202104-rpctypes) https://github.com/bitcoin/bitcoin/pull/21897
< bitcoin-git> bitcoin/master 7031721 Karl-Johan Alm: rpc/listaddressgroupings: redefine inner-most array as ARR_FIXED
< bitcoin-git> bitcoin/master d9e2183 Karl-Johan Alm: rpc: include OBJ_USER_KEY in RPCArg constructor checks
< bitcoin-git> bitcoin/master 8500f7b Karl-Johan Alm: rpc/createrawtransaction: redefine addresses as OBJ_USER_KEYS
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/3028a1e3848e...2a22d903f3da
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21581: streams: Accept URef obj for VectorReader unserialize (master...2104-streamUref) https://github.com/bitcoin/bitcoin/pull/21581
< bitcoin-git> bitcoin/master 3028a1e MarcoFalke: Merge bitcoin/bitcoin#21581: streams: Accept URef obj for VectorReader uns...
< bitcoin-git> bitcoin/master fa2204f MarcoFalke: streams: Accept URef obj for VectorReader unserialize
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/86e04741dd7f...3028a1e3848e
< bitcoin-git> [bitcoin] fanquake merged pull request #21890: fuzz: Limit ParseISO8601DateTime fuzzing to 32-bit (master...2105-fuzzTime32) https://github.com/bitcoin/bitcoin/pull/21890
< bitcoin-git> bitcoin/master 86e0474 fanquake: Merge bitcoin/bitcoin#21890: fuzz: Limit ParseISO8601DateTime fuzzing to 3...
< bitcoin-git> bitcoin/master fa1aa6c MarcoFalke: fuzz: Limit ParseISO8601DateTime fuzzing to 32-bit
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5925f1e65276...86e04741dd7f
< sipa> also, in what context? in the bitcoin core codebase? using rpc? with some library? some api?

2021-05-09

< bitcoin-git> [bitcoin] theStack opened pull request #21900: test: use MiniWallet for feature_csv_activation.py (master...20210507-test-convert_csvtest_miniwallet) https://github.com/bitcoin/bitcoin/pull/21900
< yanmaani> does bitcoin have a notion of "intrinsically valid transaction"?
< bitcoin-git> [bitcoin] fanquake closed pull request #21898: Add Whitepaper Link (master...patch-1) https://github.com/bitcoin/bitcoin/pull/21898
< bitcoin-git> [bitcoin] fanquake closed pull request #21899: 0.21 (master...0.21) https://github.com/bitcoin/bitcoin/pull/21899
< bitcoin-git> [bitcoin] mrkingfoxx opened pull request #21899: 0.21 (master...0.21) https://github.com/bitcoin/bitcoin/pull/21899
< bitcoin-git> [bitcoin] wawesomeNOGUI opened pull request #21898: Add Whitepaper Link (master...patch-1) https://github.com/bitcoin/bitcoin/pull/21898
< bitcoin-git> [bitcoin] kallewoof opened pull request #21897: rpc: adjust incorrect RPCHelpMan types (master...202104-rpctypes) https://github.com/bitcoin/bitcoin/pull/21897
< bitcoin-git> [bitcoin] hebasto opened pull request #21895: refactor: Add TSA annotations to the WorkQueue class members (master...210509-tsa) https://github.com/bitcoin/bitcoin/pull/21895
< bitcoin-git> [bitcoin] Bushstar opened pull request #21894: gitignore: Add JetBrains CLion (master...gitignore-clion) https://github.com/bitcoin/bitcoin/pull/21894
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21892: fuzz: Avoid excessively large min fee rate in tx_pool (master...2105-fuzzPool) https://github.com/bitcoin/bitcoin/pull/21892
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21891: fuzz: Remove strprintf test cases that are known to fail (master...2105-fuzzStr) https://github.com/bitcoin/bitcoin/pull/21891
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21890: fuzz: Limit ParseISO8601DateTime fuzzing to 32-bit (master...2105-fuzzTime32) https://github.com/bitcoin/bitcoin/pull/21890
< bitcoin-git> [bitcoin] fanquake opened pull request #21889: macho: check for control flow instrumentation (master...build_boost_fcf_protectcion) https://github.com/bitcoin/bitcoin/pull/21889
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21872: net: Sanitize message type for logging (master...2021-05-sanitize-messagetype) https://github.com/bitcoin/bitcoin/pull/21872
< bitcoin-git> bitcoin/master 5925f1e MarcoFalke: Merge bitcoin/bitcoin#21872: net: Sanitize message type for logging
< bitcoin-git> bitcoin/master 09205b3 W. J. van der Laan: net: Clarify message header validation errors
< bitcoin-git> bitcoin/master 955eee7 W. J. van der Laan: net: Sanitize message type for logging
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/8d5a0583c497...5925f1e65276
< bitcoin-git> [bitcoin] fanquake closed pull request #21135: scripts: check for control flow instrumentation in security-check.py (master...security_check_cf_protection) https://github.com/bitcoin/bitcoin/pull/21135
< bitcoin-git> [bitcoin] fanquake merged pull request #21869: depends: Add missing -D_LIBCPP_DEBUG=1 to debug flags (master...2105-dependsDebug) https://github.com/bitcoin/bitcoin/pull/21869
< bitcoin-git> bitcoin/master 8d5a058 fanquake: Merge bitcoin/bitcoin#21869: depends: Add missing -D_LIBCPP_DEBUG=1 to deb...
< bitcoin-git> bitcoin/master fa9249a MarcoFalke: depends: Add missing -D_LIBCPP_DEBUG=1 to debug flags
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/21d6fed81550...8d5a0583c497
< bitcoin-git> bitcoin/master 21d6fed fanquake: Merge bitcoin/bitcoin#21884: fuzz: Remove unused --enable-danger-fuzz-link...
< bitcoin-git> [bitcoin] fanquake merged pull request #21884: fuzz: Remove unused --enable-danger-fuzz-link-all option (master...2105-fuzzNoDanger) https://github.com/bitcoin/bitcoin/pull/21884
< bitcoin-git> bitcoin/master fa27d6d MarcoFalke: fuzz: Remove unused --enable-danger-fuzz-link-all option
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9313c4e6aa4b...21d6fed81550

2021-05-08

< bitcoin-git> [gui] hebasto opened pull request #322: Improve Overview tab look on Windows (master...210508-frame) https://github.com/bitcoin-core/gui/pull/322
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21884: fuzz: Remove unused --enable-danger-fuzz-link-all option (master...2105-fuzzNoDanger) https://github.com/bitcoin/bitcoin/pull/21884

2021-05-07

< bitcoin-git> [bitcoin] fanquake closed pull request #21883: doc: remove 'experimental' word. (master...patch-1) https://github.com/bitcoin/bitcoin/pull/21883
< bitcoin-git> [bitcoin] jaanauati opened pull request #21883: doc: remove 'experimental' word. (master...patch-1) https://github.com/bitcoin/bitcoin/pull/21883
< luke-jr> conman: I was just pointing out it's been documented explicitly as *not* required since 2012 https://github.com/bitcoin/bips/blob/master/bip-0022.mediawiki
< gmaxwell> conman: unfortunately bitcoin exposes far too much consensus innards to edge devices, it's a big problem... because it creates interactions with edge devices that ought not exist.
< sipa> anyway, i agree it's unlikely that bitcoin core would ever be in a position where it needs to set that field
< conman> are there any plans for any scriptsig strings to come from there or can I assume it will be blank with the current bitcoin core?
< bitcoin-git> [bitcoin] hebasto opened pull request #21882: build: Fix undefined reference to __mulodi4 (master...210507-fuzz32) https://github.com/bitcoin/bitcoin/pull/21882
< gmaxwell> then Bitcoin deploys a softfork that turns OP_NOP3 into some new relative timelock. Boom all those outputs become forever unspendable and they lose 10,000 BTC.
< gmaxwell> Say litecoin had some OP_INPUT_WASNT_CREATED_IN_THE_SAME_BLOCK which it used as OP_NOP3. Then some exchange was using that on litecoin and starts using it on bitcoin, and f2pool is mining it. It's harmless-- doesn't do anything. Over the next year they assign 10,000 BTC to those outputs.
< gmaxwell> Unclear why they stopped, other than maybe just that they failed to drop the bitcoin price.
< core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
< gribble> https://github.com/bitcoin/bitcoin/issues/21365 | Basic Taproot signing support for descriptor wallets by sipa · Pull Request #21365 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/21365 | Basic Taproot signing support for descriptor wallets by sipa · Pull Request #21365 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20534 | sat/b values arent validated to be in-range · Issue #20534 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/21786 | wallet: ensure sat/vB feerates are in range (mantissa of 3) by jonatack · Pull Request #21786 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17331 | Use effective values throughout coin selection by achow101 · Pull Request #17331 · bitcoin/bitcoin · GitHub
< achow101> #bitcoin-core-dev Wallet Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik petertodd phantomcircuit promag
< core-meetingbot> Meeting started Fri May 7 19:01:56 2021 UTC. The chair is achow101. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
< bitcoin-git> [bitcoin] klementtan opened pull request #21880: wallet: remove GetScriptPubKeyMan spam (master...GetScriptPubKeyMan-spam) https://github.com/bitcoin/bitcoin/pull/21880
< gmaxwell> michaelfolkson: please don't direct people to ##taproot-activation for asking technical questions about how bitcoin works.
< bitcoin-git> [bitcoin] vasild closed pull request #21700: net: expand Sock and fuzz-test more of CConnman (master...Sock_expand) https://github.com/bitcoin/bitcoin/pull/21700
< bitcoin-git> [bitcoin] vasild opened pull request #21879: Wrap accept() and extend usage of Sock (master...SockAccept) https://github.com/bitcoin/bitcoin/pull/21879
< bitcoin-git> [bitcoin] vasild opened pull request #21878: fubar everything (master...Sock_all_over_the_place) https://github.com/bitcoin/bitcoin/pull/21878
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21874: fuzz: Add WRITE_ALL_FUZZ_TARGETS_AND_ABORT (master...2105-fuzzWRITE_ALL_FUZZ_TARGETS_AND_ABORT) https://github.com/bitcoin/bitcoin/pull/21874
< bitcoin-git> bitcoin/master 9313c4e MarcoFalke: Merge bitcoin/bitcoin#21874: fuzz: Add WRITE_ALL_FUZZ_TARGETS_AND_ABORT
< bitcoin-git> bitcoin/master fa5cb6b MarcoFalke: fuzz: Add WRITE_ALL_FUZZ_TARGETS_AND_ABORT
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/eb9a1fe03779...9313c4e6aa4b
< bitcoin-git> [bitcoin] jbampton opened pull request #21875: doc: fix spelling (master...fix-spelling) https://github.com/bitcoin/bitcoin/pull/21875
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21874: fuzz: Add WRITE_ALL_FUZZ_TARGETS_AND_ABORT (master...2105-fuzzWRITE_ALL_FUZZ_TARGETS_AND_ABORT) https://github.com/bitcoin/bitcoin/pull/21874
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21802: refactor: Avoid UB in util/asmap (advance a dereferenceable iterator outside its valid range) (master...2104-asmapRefactor) https://github.com/bitcoin/bitcoin/pull/21802
< bitcoin-git> bitcoin/master eb9a1fe MarcoFalke: Merge bitcoin/bitcoin#21802: refactor: Avoid UB in util/asmap (advance a d...
< bitcoin-git> bitcoin/master fa09871 MarcoFalke: refactor: Avoid sign-compare compiler warning in util/asmap
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a33f360fcdd2...eb9a1fe03779
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21873: test: minor fixes & improvements for files linter test (master...files-lint-fixups) https://github.com/bitcoin/bitcoin/pull/21873
< bitcoin-git> bitcoin/master a33f360 MarcoFalke: Merge bitcoin/bitcoin#21873: test: minor fixes & improvements for files li...
< bitcoin-git> bitcoin/master 2227fc4 windsok: test: minor fixes & improvements for files linter test
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a0d1d487e93d...a33f360fcdd2
< bitcoin-git> [bitcoin] fanquake merged pull request #21845: net processing: Don't require locking cs_main before calling RelayTransactions() (master...2021-05-internal_relay_txs) https://github.com/bitcoin/bitcoin/pull/21845
< bitcoin-git> bitcoin/master a0d1d48 fanquake: Merge bitcoin/bitcoin#21845: net processing: Don't require locking cs_main...
< bitcoin-git> bitcoin/master 39e1971 John Newbery: [net processing] Add internal _RelayTransactions()
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/06d573f053c6...a0d1d487e93d
< bitcoin-git> [bitcoin] windsok opened pull request #21873: test: minor fixes & improvements for files linter test (master...files-lint-fixups) https://github.com/bitcoin/bitcoin/pull/21873

2021-05-06

< jeremyrubin> responding to https://github.com/bitcoin/bitcoin/pull/21702#discussion_r616863828 shedcolor comment, does anyone have any feelings on renaming "StandardTemplateHash" to "BIP119Hash" and renaming "BasicStandardTemplate" to "StandardBareBIP119Output"?
< core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
< michaelfolkson> I heard about it through this https://github.com/bitcoin/bitcoin/pull/21856
< gribble> https://github.com/bitcoin/bitcoin/issues/17331 | Use effective values throughout coin selection by achow101 · Pull Request #17331 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17331 | Use effective values throughout coin selection by achow101 · Pull Request #17331 · bitcoin/bitcoin · GitHub
< wumpus> 10 current blockers on review in https://github.com/bitcoin/bitcoin/projects/8
< wumpus> welcome to the weekly bitcoin-core-dev meeting, there is one proposed meeting topic from http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt: Plan for future Core fuzzing using OSS-Fuzz (michaelfolkson)
< wumpus> #bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik
< core-meetingbot> Meeting started Thu May 6 19:00:26 2021 UTC. The chair is wumpus. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
< bitcoin-git> [bitcoin] laanwj opened pull request #21872: net: Sanitize message type for logging (master...2021-05-sanitize-messagetype) https://github.com/bitcoin/bitcoin/pull/21872
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21867: test: use MiniWallet for p2p_blocksonly.py (master...20210505-test-convert_p2pblocksonly_miniwallet) https://github.com/bitcoin/bitcoin/pull/21867
< bitcoin-git> bitcoin/master 06d573f MarcoFalke: Merge bitcoin/bitcoin#21867: test: use MiniWallet for p2p_blocksonly.py
< bitcoin-git> bitcoin/master 9f767e8 Sebastian Falbesoner: test: use MiniWallet for p2p_blocksonly.py
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1fcf66af6826...06d573f053c6
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21798: fuzz: Create a block template in tx_pool targets (master...2104-fuzzMempool) https://github.com/bitcoin/bitcoin/pull/21798
< bitcoin-git> bitcoin/master fa61ce5 MarcoFalke: fuzz: Limit mocktime to MTP in tx_pool targets
< bitcoin-git> bitcoin/master fab646b MarcoFalke: fuzz: Use correct variant of ConsumeRandomLengthString instead of hardcodi...
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/9c05da4a5c57...1fcf66af6826
< bitcoin-git> bitcoin/master fae2c8b MarcoFalke: fuzz: Allow to pass min/max to ConsumeTime
< bitcoin-git> [bitcoin] fanquake opened pull request #21871: scripts: add checks for minimum required OS versions (master...new_tests_on_lief) https://github.com/bitcoin/bitcoin/pull/21871
< bitcoin-git> [gui] MarcoFalke closed pull request #321: Remove `gui_issue` from issue templates (master...issue-templates) https://github.com/bitcoin-core/gui/pull/321
< bitcoin-git> [bitcoin] prayank23 opened pull request #21870: Add `config.yml` (master...issue-templates) https://github.com/bitcoin/bitcoin/pull/21870
< bitcoin-git> [gui] prayank23 opened pull request #321: Remove `gui_issue` from issue templates (master...issue-templates) https://github.com/bitcoin-core/gui/pull/321
< bitcoin-git> [gui] RandyMcMillan opened pull request #320: qt: mempool stats chart (master...mempool_graph_rebase) https://github.com/bitcoin-core/gui/pull/320
< bitcoin-git> [bitcoin] fanquake merged pull request #21865: ci: Properly pass msan cflags (master...2105-ciMsan) https://github.com/bitcoin/bitcoin/pull/21865
< bitcoin-git> bitcoin/master 9c05da4 fanquake: Merge bitcoin/bitcoin#21865: ci: Properly pass msan cflags
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f8575bce3118...9c05da4a5c57
< bitcoin-git> bitcoin/master fa3bbcf MarcoFalke: ci: Properly pass msan cflags
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21869: depends: Add missing -D_LIBCPP_DEBUG=1 to debug flags (master...2105-dependsDebug) https://github.com/bitcoin/bitcoin/pull/21869
< bitcoin-git> [bitcoin] theStack opened pull request #21867: test: use MiniWallet for p2p_blocksonly.py (master...20210505-test-convert_p2pblocksonly_miniwallet) https://github.com/bitcoin/bitcoin/pull/21867

2021-05-05

< bitcoin-git> [bitcoin] dongcarl opened pull request #21866: [Bundle 7/7] validation: Farewell, global Chainstate! (master...2020-10-libbitcoinruntime-v9) https://github.com/bitcoin/bitcoin/pull/21866
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21865: ci: Properly pass msan cflags (master...2105-ciMsan) https://github.com/bitcoin/bitcoin/pull/21865
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21864: fix permissions on 00_setup_env_native_fuzz_with_msan.sh (master...2021-05-lint) https://github.com/bitcoin/bitcoin/pull/21864
< bitcoin-git> bitcoin/master f8575bc MarcoFalke: Merge bitcoin/bitcoin#21864: fix permissions on 00_setup_env_native_fuzz_w...
< bitcoin-git> bitcoin/master d48565d glozow: fix permissions on 00_setup_env_native_fuzz_with_msan
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/128b98fce36d...f8575bce3118
< bitcoin-git> [bitcoin] glozow opened pull request #21864: fix permissions on 00_setup_env_native_fuzz_with_msan.sh (master...2021-05-lint) https://github.com/bitcoin/bitcoin/pull/21864
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #21863: ci: Set depends DEBUG=1 for msan tasks to get line numbers (master...2105-ciMsanDebug) https://github.com/bitcoin/bitcoin/pull/21863
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21863: ci: Set depends DEBUG=1 for msan tasks to get line numbers (master...2105-ciMsanDebug) https://github.com/bitcoin/bitcoin/pull/21863
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21681: validation: fix ActivateSnapshot to use hardcoded nChainTx (master...2021-04-au-nchaintx-fix) https://github.com/bitcoin/bitcoin/pull/21681
< bitcoin-git> bitcoin/master 128b98f MarcoFalke: Merge bitcoin/bitcoin#21681: validation: fix ActivateSnapshot to use hardc...
< bitcoin-git> bitcoin/master 91d93aa James O'Beirne: validation: remove nchaintx from assumeutxo metadata
< bitcoin-git> bitcoin/master 931684b James O'Beirne: validation: fix ActivateSnapshot to use hardcoded nChainTx
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/32f1f021bf99...128b98fce36d
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21817: refactor: Replace &foo[0] with foo.data() (master...2104-refactorData) https://github.com/bitcoin/bitcoin/pull/21817
< bitcoin-git> bitcoin/master face961 MarcoFalke: refactor: Use only one temporary buffer in CreateObfuscateKey
< bitcoin-git> bitcoin/master fa05ddd MarcoFalke: refactor: Use CPubKey vector constructor where possible
< bitcoin-git> bitcoin/master fabb6df Guido Vranken: script: Replace address-of idiom with vector data() method
< bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/1b9a5236e99f...32f1f021bf99
< bitcoin-git> [bitcoin] laanwj merged pull request #21740: test: add new python linter to check file names and permissions (master...file-permissions-linter) https://github.com/bitcoin/bitcoin/pull/21740
< bitcoin-git> bitcoin/master 46b025e windsok: test: add new python linter to check file names and permissions
< bitcoin-git> bitcoin/master 1b9a523 W. J. van der Laan: Merge bitcoin/bitcoin#21740: test: add new python linter to check file nam...
< bitcoin-git> bitcoin/master 6f6bb3e windsok: test: fix file permissions on various scripts
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b8b68014129e...1b9a5236e99f
< bitcoin-git> [bitcoin] laanwj merged pull request #21710: doc: update helps for addnode rpc and -addnode/-maxconnections config options (master...update-addnode-docs) https://github.com/bitcoin/bitcoin/pull/21710
< bitcoin-git> bitcoin/master b4fcbcf Jon Atack: doc: update -maxconnections config option help
< bitcoin-git> bitcoin/master 79685a8 Jon Atack: doc: update -addnode config option help
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/a0f46028fcd2...b8b68014129e
< bitcoin-git> bitcoin/master 2896c6c Jon Atack: doc: update addnode rpc help
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21814: test: Fix feature_config_args.py intermittent issue (master...2104-testInt3) https://github.com/bitcoin/bitcoin/pull/21814
< bitcoin-git> bitcoin/master a0f4602 MarcoFalke: Merge bitcoin/bitcoin#21814: test: Fix feature_config_args.py intermittent...
< bitcoin-git> bitcoin/master fab1eb6 MarcoFalke: test: Fix feature_config_args.py intermittent issue
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/576300afb0ec...a0f46028fcd2
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21856: doc: add OSS-Fuzz section to fuzzing.md doc (master...add-oss-fuzz) https://github.com/bitcoin/bitcoin/pull/21856
< bitcoin-git> bitcoin/master 576300a MarcoFalke: Merge bitcoin/bitcoin#21856: doc: add OSS-Fuzz section to fuzzing.md doc
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/54617fad9988...576300afb0ec
< bitcoin-git> bitcoin/master 47c3ea0 Adam Jonas: doc: add OSS-Fuzz section to fuzzing.md doc
< bitcoin-git> bitcoin/0.21 8584a44 W. J. van der Laan: doc: Archive and clean out release notes post-0.21.1
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.21: https://github.com/bitcoin/bitcoin/compare/bbd89d23b3d0...8584a4460d52
< bitcoin-git> [bitcoin] laanwj merged pull request #21709: doc: update reduce-memory.md and bitcoin.conf -maxconnections info (master...update-reduce-memory-doc) https://github.com/bitcoin/bitcoin/pull/21709
< bitcoin-git> bitcoin/master 54617fa W. J. van der Laan: Merge bitcoin/bitcoin#21709: doc: update reduce-memory.md and bitcoin.conf...
< bitcoin-git> bitcoin/master 300234a Jon Atack: doc: update bitcoin.conf maxconnections info
< bitcoin-git> bitcoin/master 9268270 Jon Atack: doc: update reduce-memory.md peer connections info
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/3275c6e578b4...54617fad9988
< wumpus> fanquake: thanks for making the release 0.21.1 on github https://github.com/bitcoin/bitcoin/releases/tag/v0.21.1, i forgot
< bitcoin-git> [bitcoin] laanwj merged pull request #21727: refactor: Move more stuff to blockstorage (master...2104-blockstorage) https://github.com/bitcoin/bitcoin/pull/21727
< bitcoin-git> bitcoin/master fa7e64d MarcoFalke: move-only: Move constants to blockstorage
< bitcoin-git> bitcoin/master fa247a3 MarcoFalke: refactor: Move block storage globals to blockstorage
< bitcoin-git> bitcoin/master fa81c30 MarcoFalke: refactor: Move pruning/reindex/importing globals to blockstorage
< bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/23109cc5485b...3275c6e578b4
< bitcoin-git> [bitcoin] laanwj merged pull request #21753: doc: add -addrinfo to tor docs (master...tor-doc-addrinfo) https://github.com/bitcoin/bitcoin/pull/21753
< bitcoin-git> bitcoin/master 23109cc W. J. van der Laan: Merge bitcoin/bitcoin#21753: doc: add -addrinfo to tor docs
< bitcoin-git> bitcoin/master 65f30e4 Jon Atack: doc: add -addrinfo troubleshooting section to tor.md
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/75b3a32f033b...23109cc5485b
< bitcoin-git> [bitcoin] laanwj merged pull request #21821: test: Add missing test for empty P2WSH redeem (master...2105-testP2WSHemptyRedeem) https://github.com/bitcoin/bitcoin/pull/21821
< bitcoin-git> bitcoin/master fa80a11 MarcoFalke: test: Add missing test for empty P2WSH redeem
< bitcoin-git> bitcoin/master 75b3a32 W. J. van der Laan: Merge bitcoin/bitcoin#21821: test: Add missing test for empty P2WSH redeem...
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fb43d7cb1e60...75b3a32f033b
< bitcoin-git> [bitcoin] laanwj merged pull request #21787: test: fix off-by-ones in rpc_fundrawtransaction assertions (master...fix-fundrawtxn-assertions) https://github.com/bitcoin/bitcoin/pull/21787
< bitcoin-git> bitcoin/master fb43d7c W. J. van der Laan: Merge bitcoin/bitcoin#21787: test: fix off-by-ones in rpc_fundrawtransacti...
< bitcoin-git> bitcoin/master f09e6b2 Jon Atack: test: fix off-by-ones in rpc_fundrawtransaction
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/df21e500d6bc...fb43d7cb1e60
< bitcoin-git> [bitcoin] laanwj merged pull request #21427: depends: Fix id_string invocations (master...2021-03-fix-build_id_construction) https://github.com/bitcoin/bitcoin/pull/21427
< bitcoin-git> bitcoin/master df21e50 W. J. van der Laan: Merge bitcoin/bitcoin#21427: depends: Fix id_string invocations
< bitcoin-git> bitcoin/master fa872c9 Carl Dong: depends: Fix id_string invocations
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cdcf82622d49...df21e500d6bc
< bitcoin-git> [gui] kristapsk opened pull request #319: gui: Paste button in Open URI dialog (master...uri-paste) https://github.com/bitcoin-core/gui/pull/319
< bitcoin-git> [bitcoin] laanwj merged pull request #21629: build: fix configuring when building depends with NO_BDB=1 (master...fixup_depends_sqlite_only_build) https://github.com/bitcoin/bitcoin/pull/21629
< bitcoin-git> bitcoin/master cdcf826 W. J. van der Laan: Merge bitcoin/bitcoin#21629: build: fix configuring when building depends ...
< bitcoin-git> bitcoin/master a549188 fanquake: build: fix configuring when building depends with NO_BDB=1
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b7c2625703f4...cdcf82622d49
< bitcoin-git> [bitcoin] laanwj merged pull request #21664: contrib: use LIEF for macOS and Windows symbol & security checks (master...macos_win_lief) https://github.com/bitcoin/bitcoin/pull/21664
< bitcoin-git> bitcoin/master 7e7eae7 fanquake: contrib: use f strings in security-check.py
< bitcoin-git> bitcoin/master 465967b fanquake: gitian: install LIEF in gitian container
< bitcoin-git> bitcoin/master 2e7a9f7 fanquake: guix: install LIEF in Guix container
< bitcoin-git> [bitcoin] laanwj pushed 12 commits to master: https://github.com/bitcoin/bitcoin/compare/00a9b0647ee3...b7c2625703f4
< bitcoin-git> [bitcoin] jonatack closed pull request #21855: fuzz: enable passing a max value to FuzzedDataProvider::ConsumeEnum() (master...ConsumeEnum-enable-passing-max-value) https://github.com/bitcoin/bitcoin/pull/21855
< bitcoin-git> [gui] jarolrod opened pull request #318: Add `Copy address` Peers Tab Context Menu Action (master...copy-addr-peer) https://github.com/bitcoin-core/gui/pull/318
< bitcoin-git> [bitcoin] laanwj merged pull request #21799: guix: Use `gcc-8` across the board (master...2021-04-guix-gcc-memcmp) https://github.com/bitcoin/bitcoin/pull/21799
< bitcoin-git> bitcoin/master 00a9b06 W. J. van der Laan: Merge bitcoin/bitcoin#21799: guix: Use `gcc-8` across the board
< bitcoin-git> bitcoin/master c90f6e5 Carl Dong: guix: Consistently use gcc-8 for $HOST
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/779aaa7f03b2...00a9b0647ee3
< bitcoin-git> [gui] jarolrod opened pull request #317: Direction col peers (master...direction-col-peers) https://github.com/bitcoin-core/gui/pull/317
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21862: test: Set regtest.BIP65Height = 112 to speed up tests (master...2105-testFasterBip65) https://github.com/bitcoin/bitcoin/pull/21862
< jnewbery> (I still don't think you need a class for VersionBitsCache though: https://github.com/bitcoin/bitcoin/pull/19438#pullrequestreview-644568911)
< gribble> https://github.com/bitcoin/bitcoin/issues/19438 | Introduce deploymentstatus by ajtowns · Pull Request #19438 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/21789 | refactor: Remove ::Params() global from CChainState by MarcoFalke · Pull Request #21789 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18685 | consensus: Simplify ConnectTrace by jnewbery · Pull Request #18685 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21860: [0.21] Backport update to Boost download URL (0.21...backport_boost_download) https://github.com/bitcoin/bitcoin/pull/21860
< bitcoin-git> bitcoin/0.21 856de5b fdov: build,boost: update download url.
< bitcoin-git> bitcoin/0.21 bbd89d2 MarcoFalke: Merge bitcoin/bitcoin#21860: [0.21] Backport update to Boost download URL
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to 0.21: https://github.com/bitcoin/bitcoin/compare/194b9b8792d9...bbd89d23b3d0
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21754: test: Run feature_cltv with MiniWallet (master...2104-testCltvNoWallet) https://github.com/bitcoin/bitcoin/pull/21754
< bitcoin-git> bitcoin/master fa066f1 MarcoFalke: test: Run feature_cltv with MiniWallet
< bitcoin-git> bitcoin/master fa5591d MarcoFalke: test: Hide tx rehash in helper
< bitcoin-git> bitcoin/master fa5f938 MarcoFalke: test: Remove new_tx reference
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/dc8da2a68554...779aaa7f03b2
< bitcoin-git> bitcoin/master dc8da2a fanquake: Merge bitcoin/bitcoin#21824: refactor: [index] Replace deprecated char wit...
< bitcoin-git> [bitcoin] fanquake merged pull request #21824: refactor: [index] Replace deprecated char with uint8_t in serialization (master...2105-refactorUint8_t) https://github.com/bitcoin/bitcoin/pull/21824
< bitcoin-git> bitcoin/master fafb880 MarcoFalke: refactor: [index] Replace deprecated char with uint8_t in serialization
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3f8f238deb5a...dc8da2a68554
< bitcoin-git> [bitcoin] fanquake opened pull request #21860: [0.21] Backport update to Boost download URL (0.21...backport_boost_download) https://github.com/bitcoin/bitcoin/pull/21860
< bitcoin-git> [bitcoin] sipa opened pull request #21859: Add minisketch subtree and integrate in build/test (master...202105_minisketch) https://github.com/bitcoin/bitcoin/pull/21859

2021-05-04

< gmaxwell> ./bitcoin-cli getpeerinfo | jq -c '.[] | select(."bytessent_per_msg"."tx">0) | select(."bytesrecv_per_msg"."tx">0) | select(."inbound"==false) | ."bytessent_per_msg"."tx"/."bytesrecv_per_msg"."tx"'
< sipa> ./src/bitcoin-cli getpeerinfo | jq -r 'map("\(if .inbound then "I" else "O" end) \((.bytessent_per_msg.tx // 0) / ((.bytessent_per_msg.tx // 0) + (1 + .bytesrecv_per_msg.tx // 0)))") | .[]' | sort -g
< bitcoin-git> [bitcoin] fanquake closed pull request #21854: doc: make small corrections (v0.21.1 release notes) (master...patch-1) https://github.com/bitcoin/bitcoin/pull/21854
< gmaxwell> well, sipa is weird but his bitcoin node isn't. :P
< gmaxwell> Like, have we made a series of single steps that were logcal but gives a weird outcome? Step 1. relay faster to outbound peers because we control them, so they're less likely to be spies monitoring our txn. Step 2. Introduce reconcillation, but make flooding only happen for reachable nodes because it has some moral similarity to step 1. Conclusion, 80% of bitcoin nodes no longer participate
< gmaxwell> for one thing it takes 80% or whatever of bitcoin nodes out of participation in rapidly forwarding transactions, which seems ... like a really big step to take without an obvious reason.
< gmaxwell> Basically nowhere else in the bitcoin protocol is there this in/out distinction -- just in tx relay privacy timers (which were 'recently' introduced relatively speaking) and in peer eviction.
< gmaxwell> gleb: I think in general when we talk about erlay (e.g. in the paper and elsewhere) we use this "non-reachable peer" terminology, but non-reachability doesn't exist explicitly anywhere in the implementation of bitcoin core or the bitcoin protocol... so although non-reachable peers were a good concept for modling, it can be a little confusing when it comes to the implementation.
< sipa> gleb: was it needed to include minisketch in bitcoin-tx?