<bitcoin-git>
[bitcoin] pinheadmz opened pull request #27053: wallet: reuse change dest when re-creating TX with avoidpartialspends (master...change-addresses) https://github.com/bitcoin/bitcoin/pull/27053
<bitcoin-git>
[bitcoin] achow101 merged pull request #26345: refactor: modernize the implementation of uint256.* (master...refactor/uint256-modernize) https://github.com/bitcoin/bitcoin/pull/26345
<bitcoin-git>
bitcoin/master 935acdc pasta: refactor: modernize the implementation of uint256.*
<bitcoin-git>
bitcoin/master 52ddbd5 Andrew Chow: Merge bitcoin/bitcoin#26345: refactor: modernize the implementation of uin...
<bitcoin-git>
[bitcoin] LarryRuane opened pull request #27052: test: rpc: add last block announcement time to getpeerinfo result (master...2023-02-getpeerinfo) https://github.com/bitcoin/bitcoin/pull/27052
<bitcoin-git>
[bitcoin] fanquake closed pull request #21319: RPC/Blockchain: Optimise getblock for simple disk-hex case (master...getblock_optimise) https://github.com/bitcoin/bitcoin/pull/21319
<bitcoin-git>
[bitcoin] fanquake closed pull request #25050: CValidationInterface: ValidationInterfaceUnregistering, called when being unregistered (master...validationIF_unregister) https://github.com/bitcoin/bitcoin/pull/25050
<bitcoin-git>
bitcoin/master 82f895d Martin Leitner-Ankerl: Update nanobench to version v4.3.10
<bitcoin-git>
bitcoin/master d8f9826 fanquake: Merge bitcoin/bitcoin#27030: Update nanobench to version v4.3.10
<bitcoin-git>
[bitcoin] fanquake merged pull request #27009: validation: Skip VerifyDB checks of level =3 if dbcache is too small (master...202301_verifychain_assertfix) https://github.com/bitcoin/bitcoin/pull/27009
<bitcoin-git>
bitcoin/master c497a19 John Moffett: Fix comment about how wallet txs are sorted
<bitcoin-git>
bitcoin/master daebf9e Hennadii Stepanov: Merge bitcoin-core/gui#705: doc: Fix comment about how wallet txs are sort...
<bitcoin-git>
[gui] hebasto merged pull request #705: doc: Fix comment about how wallet txs are sorted (master...2023_01_FixIncorrectCommentTTM) https://github.com/bitcoin-core/gui/pull/705
<bitcoin-git>
[bitcoin] pinheadmz opened pull request #27039: blockstorage: do not flush block to disk if it is already there (master...reindex-read-only) https://github.com/bitcoin/bitcoin/pull/27039
<bitcoin-git>
[bitcoin] fanquake opened pull request #27038: security-check: test for `_FORTIFY_SOURCE` usage in release binaries (master...sec_check_fortify_source) https://github.com/bitcoin/bitcoin/pull/27038
<bitcoin-git>
[bitcoin] darosior opened pull request #27037: rpc: decode Miniscript descriptor when possible in decodescript (master...decodescript_miniscript) https://github.com/bitcoin/bitcoin/pull/27037
<bitcoin-git>
[bitcoin] john-moffett opened pull request #27036: test: Remove last uses of snprintf and simplify (master...2023_02_FixDBWrapperTest) https://github.com/bitcoin/bitcoin/pull/27036
<bitcoin-git>
[bitcoin] theStack opened pull request #27035: test: simplify and speedup mempool_updatefromblock.py by using MiniWallet (master...202302-test-use_MiniWallet_for_mempool_updatefromblock) https://github.com/bitcoin/bitcoin/pull/27035
<bitcoin-git>
[bitcoin] furszy opened pull request #27034: rpc: make importaddress compatible with descriptors wallet (master...2022_rpc_importaddress_descriptors_compatible) https://github.com/bitcoin/bitcoin/pull/27034
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #26875: Tests: Fill out dust limit unit test for known types except bare multisig (master...add_dust_limits) https://github.com/bitcoin/bitcoin/pull/26875
<bitcoin-git>
bitcoin/master b093f56 Greg Sanders: Fill out dust limit unit test for known types except bare multisig
<bitcoin-git>
bitcoin/master aaa5597 MarcoFalke: Merge bitcoin/bitcoin#26875: Tests: Fill out dust limit unit test for know...
<hebasto>
as Ubuntu Bionic reaches "End of Standard Support" in April 2023, can we consider it is no longer supported as a build platform for Bitcoin Core v25+ ?
<bitcoin-git>
[bitcoin] hebasto closed pull request #24363: ci: Catch assertion error message into logs for test_bitcoin.exe (master...220216-assert) https://github.com/bitcoin/bitcoin/pull/24363
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #27033: ci: Store depends in volume, not host folder (master...2302-ci-depends-vol-🏆) https://github.com/bitcoin/bitcoin/pull/27033
<sipa>
Maybe a bit more practical, do you expect that the txt range/asn map file will become part of the bitcoin core source repo? or just the combined binary dat file? or neither?
<fjahr>
but people can not expect Bitcoin core maintainers to do that work for them
<bitcoin-git>
[bitcoin] hebasto closed pull request #23609: build: Add -fvisibility=hidden flag for macOS host (master...211126-reduce) https://github.com/bitcoin/bitcoin/pull/23609
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #27028: ci: Cache more stuff in the ci images: msan, iwyu, pip, sdks (master...2301-ci-cache-apt-🚴) https://github.com/bitcoin/bitcoin/pull/27028
<bitcoin-git>
[bitcoin] fanquake merged pull request #27012: ci: Print iwyu patch in git diff format (master...2302-ci-iwyu-git-diff-📖) https://github.com/bitcoin/bitcoin/pull/27012
<fjahr>
And yeah, that was my understanding that we would work towards shipping a file with Bitcoin Core. Maybe in the first iteration it gets shipped with the release but it’s not used by default. However users could use the included file by just passing -asmap=1 and they don’t have to get the file from somewhere and provide it explicitly. I think that might be a good intermediate step. Of course they should still be able to
<bitcoin-git>
[bitcoin] Xekyo opened pull request #27021: Implement Mini version of BlockAssembler to calculate mining scores (master...add-mini-miner) https://github.com/bitcoin/bitcoin/pull/27021
<bitcoin-git>
[bitcoin] achow101 merged pull request #26910: wallet: migrate wallet, exit early if no legacy data exist (master...2022_wallet_prevent_descriptors_migration) https://github.com/bitcoin/bitcoin/pull/26910
<bitcoin-git>
bitcoin/master 6d31900 furszy: wallet: migrate wallet, exit early if no legacy data exist
<bitcoin-git>
bitcoin/master fdd363e Andrew Chow: Merge bitcoin/bitcoin#26910: wallet: migrate wallet, exit early if no lega...
<codo>
Does bitcoin-git detect when there is conversation and then keeps silent? Or is there no github activity because people are busy having the conversation?
<sipa>
Also, have you thought about how the data would (eventually) be included in Bitcoin Core? My thinking is that over time we'd perhaps just want it built into the binary, and that this built-in version would be used as default unless overridden. For auditability, that probably means a way to export the encoded asmap data, and/or RPCs to perform lookups in it.
<sipa>
I don't understand where the multimap idea fits in. I realize that there can be conflicting data, so there are multiple ASNs for a single IP range, but even if this were encodable in the asmap file format, how would Bitcoin Core use it? Unless there is a useful way to incorporate this information, my thinking is that you just need a deterministic mechanism for picking one of the options.
<gribble>
https://github.com/bitcoin/bitcoin/issues/27018 | mempool / miner: regularly flush below-minrelayfeerate entries, mine everything in the mempool by glozow · Pull Request #27018 · bitcoin/bitcoin · GitHub
<bitcoin-git>
[bitcoin] glozow opened pull request #27018: mempool / miner: regularly flush below-minrelayfeerate entries, mine everything in the mempool (master...2023-01-flushandmine) https://github.com/bitcoin/bitcoin/pull/27018
<bitcoin-git>
[bitcoin] fanquake opened pull request #27016: mapport: require miniupnpc API version 17 or later (master...mostly_non_broken_upnp_verions) https://github.com/bitcoin/bitcoin/pull/27016
<bitcoin-git>
bitcoin/master 47c174d willcl-ark: doc: NetPermissionFlags for tx relay in blocksonly
<bitcoin-git>
bitcoin/master 22ccf4e glozow: Merge bitcoin/bitcoin#26991: doc: followups to #26471
<bitcoin-git>
[bitcoin] fanquake merged pull request #25974: test, build: Separate `read_json` function into its own module (master...220901-test) https://github.com/bitcoin/bitcoin/pull/25974
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #26705: clang-tidy: Fix `modernize-use-default-member-init` in headers and force to check all headers (master...221215-tidy) https://github.com/bitcoin/bitcoin/pull/26705
<bitcoin-git>
bitcoin/master 96ee992 Hennadii Stepanov: clang-tidy: Fix `modernize-use-default-member-init` in headers
<bitcoin-git>
bitcoin/master b0e9169 Hennadii Stepanov: clang-tidy: Force to check all headers
<bitcoin-git>
bitcoin/master dfc01cc Vasil Dimov: net: simplify the call to vProcessMsg.splice()
<bitcoin-git>
bitcoin/master ba39ffe MarcoFalke: Merge bitcoin/bitcoin#26888: net: simplify the call to vProcessMsg.splice()
<phantomcircuit>
achow101: to be clear i dont think that the existing blockfilterindex has any value for bitcoin core, it's only value is in generating the filters for clients
<fjahr>
laanwj created it after the conversation here https://bitcoin-irc.chaincode.com/bitcoin-core-dev/2021-11-11#736102 but it was probably deleted at some point because it wasn't used yet, just would have been nice to get a heads-up. Or maybe my head made up the repo and it was just the admin group.
<bitcoin-git>
bitcoin/master d35595a Martin Zumsande: addrman: add function to return size by network and table
<bitcoin-git>
bitcoin/master c77c877 Martin Zumsande: net: Load fixed seeds from reachable networks for which we don't have addr...
<bitcoin-git>
[bitcoin] theStack opened pull request #27010: refactor: use `Hash` helpers for double-SHA256 calculations (master...202301-refactor-use_double_sha256_helper) https://github.com/bitcoin/bitcoin/pull/27010
<bitcoin-git>
[bitcoin] mzumsande opened pull request #27009: validation: Skip VerifyDB checks of level =3 if dbcache is too small (master...202301_verifychain_assertfix) https://github.com/bitcoin/bitcoin/pull/27009
<larryruane>
Has anyone looked into thread fuzzing? Ping @MacroFake @lightlike ... I'm thinking I'd look into what's out there and seeing if we can apply these ideas to bitcoin core to discover and fix thread synchronization bugs
<bitcoin-git>
[bitcoin] fanquake merged pull request #23670: build: Build minisketch test in `make check`, not in `make` (master...211204-check) https://github.com/bitcoin/bitcoin/pull/23670
<sipa>
not policy, the bitcoin core codebase has nothing to do with that
<fjahr>
I have put one up at gitlab.sighash.org. I only cloned the bitcoin core repos so far, happy to give people access if they want to try stuff out or to hear ideas what would be interesting next steps. Just ping me in a DM.
<bitcoin-git>
[bitcoin] furszy opened pull request #27006: reduce cs_main scope, guard block index 'nFile' under a local mutex (master...2022_reduce_cs_main_scope_blockindex_nfile) https://github.com/bitcoin/bitcoin/pull/27006
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #27005: util: Use steady clock for logging timer (master...2301-log-steady-clock-🔆) https://github.com/bitcoin/bitcoin/pull/27005
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #27004: test: Use std::unique_ptr over manual delete in coins_tests (master...2301-test-uniq-ptr-🕴) https://github.com/bitcoin/bitcoin/pull/27004
<willcl_ark>
I am curious then about the decodescript output for this scriptsig: `bitcoin-cli decoderawtransaction (bitcoin-cli getrawtransaction 061959f1a3360d3781a870b2d43f73f7105b194b22f3765fcb9b8f545f9c8317) | jq -r ."vin"[0]."scriptSig"."hex"` ? I don't think this is a witness_v0_scripthash? But I also might be interpreting this wrong
<bitcoin-git>
[bitcoin] achow101 merged pull request #26998: depends: ensure we are appending to sqlite cflags (master...msan_flags_missing) https://github.com/bitcoin/bitcoin/pull/26998
<bitcoin-git>
bitcoin/master 56a03f1 fanquake: depends: ensure we are appending to sqlite cflags
<bitcoin-git>
bitcoin/master ceb74b8 Andrew Chow: Merge bitcoin/bitcoin#26998: depends: ensure we are appending to sqlite cf...
<bitcoin-git>
[bitcoin] achow101 merged pull request #26999: A few follow-ups to #17487 (coins write without cache drop) (master...202301_flush_coins_followup) https://github.com/bitcoin/bitcoin/pull/26999
<bitcoin-git>
bitcoin/master 98db35c Pieter Wuille: Follow coding style for named arguments
<freedom-core-dev>
fanquake: i wont and you can try to stop me as you did with other things. brink is not bitcoin. i will engage in constructive dev discussion when you stop politics and censorship.
<freedom-core-dev>
i know you celebrate rage quits, now you would have to deal with some people who really believe in bitcoin and wont quit
<freedom-core-dev>
_aj_: you have done more to send devs and users away from bitcoin
<bitcoin-git>
[bitcoin] sipa opened pull request #26999: A few follow-ups to #17487 (coins write without cache drop) (master...202301_flush_coins_followup) https://github.com/bitcoin/bitcoin/pull/26999
<freedom-core-dev>
Are you an attacker on bitcoin?
<freedom-core-dev>
3. Why was your (1) not shared in bitcoin optech?
<freedom-core-dev>
4. Why do you share CIA links in normal bitcoin discussions?
<bitcoin-git>
bitcoin/master fa02591 MarcoFalke: doc: Export threadsafety.h from sync.h
<bitcoin-git>
[bitcoin] fanquake opened pull request #26998: depends: ensure we are appending to sqlite cflags (master...msan_flags_missing) https://github.com/bitcoin/bitcoin/pull/26998
<bitcoin-git>
[bitcoin] fanquake merged pull request #17487: coins: allow write to disk without cache drop (master...2019-11-au-coins-erase) https://github.com/bitcoin/bitcoin/pull/17487
<bitcoin-git>
bitcoin/master 2c3cbd6 James O'Beirne: test: add use of Sync() to coins tests
<bitcoin-git>
bitcoin/master 79cedc3 James O'Beirne: coins: add Sync() method to allow flush without cacheCoins drop
<bitcoin-git>
bitcoin/master 6d8affc James O'Beirne: test: refactor: clarify the coins simulation
<bitcoin-git>
[bitcoin] fanquake merged pull request #26649: refactor: Use AutoFile and HashVerifier (without ser-type and ser-version) where possible (master...2212-ser-type-ver-👬) https://github.com/bitcoin/bitcoin/pull/26649
<bitcoin-git>
[bitcoin] pablomartin4btc opened pull request #26990: bitcoin:cli add validation to -generate command to avoid confusion when it's used with -rpcwallet (master...bitcoin-cli-generate-validation-when-rpcwallet) https://github.com/bitcoin/bitcoin/pull/26990
2023-01-29
<bitcoin-git>
[bitcoin] stratospher opened pull request #26988: [rpc]: Add test-only RPC addrmaninfo for new/tried table address count (master...rpc_addrmaninfo) https://github.com/bitcoin/bitcoin/pull/26988
<bitcoin-git>
[bitcoin] fanquake merged pull request #22811: build: Fix depends build system when working with subtargets (master...210826-subtarget) https://github.com/bitcoin/bitcoin/pull/22811