2022-05-26

<bitcoin-git> bitcoin/master a0e8aff Andrew Chow: Merge bitcoin/bitcoin#25003: tracing: fix `coin_selection:aps_create_tx_in...
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2642dee1364d...a0e8aff6051b
<bitcoin-git> [gui] hebasto closed pull request #492: Show ToolTip on Network Traffic graph (master...NetworkGraphTooltip) https://github.com/bitcoin-core/gui/pull/492
<bitcoin-git> [gui] hebasto closed pull request #484: Don't clear traffic graph when changing interval (master...RetainNetworkGraphOnIntervalChange) https://github.com/bitcoin-core/gui/pull/484
<bitcoin-git> [gui] hebasto closed pull request #435: Move third-party tx URL setting from Display to Wallet options tab (master...move-3partytx-setting) https://github.com/bitcoin-core/gui/pull/435
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #15936: interfaces: Expose settings.json methods to GUI (master...pr/qtset) https://github.com/bitcoin/bitcoin/pull/15936
<bitcoin-git> bitcoin/master 77fabff Ryan Ofsky: init: Remove Shutdown() node.args reset
<bitcoin-git> bitcoin/master f9fdcec Ryan Ofsky: settings: Add resetSettings() method
<bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/48eec3234749...2642dee1364d
<bitcoin-git> bitcoin/master 0e55bc6 Ryan Ofsky: settings: Add update/getPersistent/isIgnored methods
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25222: refactor: Pass reference to LookUpStats (master...2205-ref-stat-😶) https://github.com/bitcoin/bitcoin/pull/25222
<bitcoin-git> [bitcoin] laanwj merged pull request #25216: Doc: Fix parameter in hwm example block (master...patch-1) https://github.com/bitcoin/bitcoin/pull/25216
<bitcoin-git> bitcoin/master 48eec32 laanwj: Merge bitcoin/bitcoin#25216: Doc: Fix parameter in hwm example block
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c324b07a541a...48eec3234749
<bitcoin-git> bitcoin/master 43ff37f mutatrum: Update zmq.md: Fix parameter in hwm example block
<bitcoin-git> [bitcoin] laanwj merged pull request #25210: doc: remove misleading AreInputsStandard() comment (master...2022-05-areinputsstandard-comment) https://github.com/bitcoin/bitcoin/pull/25210
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4901631dac6a...c324b07a541a
<bitcoin-git> bitcoin/master be6d431 James O'Beirne: doc: remove misleading AreInputsStandard() comment
<bitcoin-git> bitcoin/master c324b07 laanwj: Merge bitcoin/bitcoin#25210: doc: remove misleading AreInputsStandard() co...
<bitcoin-git> [bitcoin] laanwj merged pull request #25202: log: Use severity-based logging for leveldb/libevent messages, reverse LogPrintLevel order (master...2022-05-logging-improved) https://github.com/bitcoin/bitcoin/pull/25202
<bitcoin-git> bitcoin/master 18ec120 laanwj: http: Use severity-based logging for messages from libevent
<bitcoin-git> bitcoin/master ce92071 laanwj: leveldb: Log messages from leveldb with category and debug level
<bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/cacbdbaa9531...4901631dac6a
<bitcoin-git> bitcoin/master bd971bf laanwj: logging: Unconditionally log levels >= WARN
<bitcoin-git> [bitcoin] laanwj merged pull request #25132: consensus: Add BIP-341 specified constraints in `ComputeTaprootMerkleRoot` (master...compute-taproot-merkle-root-asserts) https://github.com/bitcoin/bitcoin/pull/25132
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/192d639a6b1b...cacbdbaa9531
<bitcoin-git> bitcoin/master bd7c5e2 David Bakin: Add BIP-341 specified constraints to `ComputeTaprootMerkleRoot`
<bitcoin-git> bitcoin/master cacbdba laanwj: Merge bitcoin/bitcoin#25132: consensus: Add BIP-341 specified constraints ...
<bitcoin-git> [gui] hebasto opened pull request #607: refactor: Skip manual signal disconnection in descructors (master...220526-handler) https://github.com/bitcoin-core/gui/pull/607
<gribble> https://github.com/bitcoin/bitcoin/issues/25201 | windeploy: Renewed windows code signing certificate by achow101 · Pull Request #25201 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] antoinedesbois opened pull request #25221: Improve CMedianFilter algorithm (master...timedata_bench) https://github.com/bitcoin/bitcoin/pull/25221
<bitcoin-git> [bitcoin] brunoerg opened pull request #25220: rpc: fix incorrect warning for address type p2sh-segwit in createmultisig (master...2022-05-fix-incorrect-warning-createmultisig) https://github.com/bitcoin/bitcoin/pull/25220
<jamesob> dongcarl: it's a trick for allowing that annotation to work with nullable locks; it just doesn't enforce anything if there's no lock. See https://github.com/bitcoin/bitcoin/pull/22415#issuecomment-875999127

2022-05-25

<jonatack> dongcarl: if possible, maybe pass a reference that cannot be nullptr (otherwise add an assert?) am thinking of https://github.com/bitcoin/bitcoin/pull/25016/commits/86ce844d3b287012f27c7b0bad6d11c9bdd3120e for example
<bitcoin-git> [bitcoin] achow101 merged pull request #25213: fuzz: fix crash at coinselection, add missing fee rate. (master...2022_fuzz_solve_coinselection) https://github.com/bitcoin/bitcoin/pull/25213
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b4f686952a60...192d639a6b1b
<bitcoin-git> bitcoin/master c97e961 furszy: fuzz: coinselection, add missing fee rate.
<bitcoin-git> bitcoin/master 192d639 Andrew Chow: Merge bitcoin/bitcoin#25213: fuzz: fix crash at coinselection, add missing...
<bitcoin-git> [bitcoin] natanleung opened pull request #25219: test: deploymentinfo.cpp unit tests (master...deploymentinfo_unit_test) https://github.com/bitcoin/bitcoin/pull/25219
<bitcoin-git> [bitcoin] furszy opened pull request #25218: wallet: introduce generic 'Result' classes and connect it to `CreateTransaction` and `GetNewDestination` (master...2022_generic_result) https://github.com/bitcoin/bitcoin/pull/25218
<bitcoin-git> [bitcoin] jonatack opened pull request #25217: scripts and tools: update lint-logs.py with LogPrintLevel() (master...update-logs-linter-script-with-LogPrintLevel) https://github.com/bitcoin/bitcoin/pull/25217
<bitcoin-git> [bitcoin] mutatrum opened pull request #25216: Update zmq.md: Fix parameter in hwm example block (master...patch-1) https://github.com/bitcoin/bitcoin/pull/25216
<bitcoin-git> [bitcoin] dongcarl opened pull request #25215: [kernel 2d/n] Reduce CTxMemPool constructor call sites (master...2022-03-libbitcoinkernel-reduce-mempool-ctor) https://github.com/bitcoin/bitcoin/pull/25215
<bitcoin-git> [bitcoin] ryanofsky opened pull request #25214: libmultiprocess build fix: ipc/capnp/init.capnp.h: No such file or directory (master...pr/mpdep) https://github.com/bitcoin/bitcoin/pull/25214
<bitcoin-git> [bitcoin] furszy opened pull request #25213: fuzz: fix crash at coinselection, add missing fee rate. (master...2022_fuzz_solve_coinselection) https://github.com/bitcoin/bitcoin/pull/25213
<bitcoin-git> [bitcoin] fanquake closed pull request #25212: Create Bitcoin (master...patch-1) https://github.com/bitcoin/bitcoin/pull/25212
<bitcoin-git> [bitcoin] Aw761678 reopened pull request #25212: Create Bitcoin (master...patch-1) https://github.com/bitcoin/bitcoin/pull/25212
<bitcoin-git> [bitcoin] Aw761678 closed pull request #25212: Create Bitcoin (master...patch-1) https://github.com/bitcoin/bitcoin/pull/25212
<bitcoin-git> [bitcoin] Aw761678 opened pull request #25212: Create Bitcoin (master...patch-1) https://github.com/bitcoin/bitcoin/pull/25212
<sipa> TallTim: This channel is about the development of the Bitcoin Core software, an implementation of the Bitcoin protocol. It is not the place to discuss the direction the Bitcoin protocol itself is going.
<gribble> https://github.com/bitcoin/bitcoin/issues/20165 | Only relay Taproot spends if next block has it active by sipa · Pull Request #20165 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/15846 | [POLICY] Make sending to future native witness outputs standard by sipa · Pull Request #15846 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] jamesob opened pull request #25210: doc: remove misleading AreInputsStandard() comment (master...2022-05-areinputsstandard-comment) https://github.com/bitcoin/bitcoin/pull/25210
<jamesob> I've noticed that future witness version pubkeys are considered standard: https://github.com/jamesob/bitcoin/blob/fcf6c8f4eb217763545ede1766831a6b93f583bd/src/script/standard.cpp#L172-L176. I'm kind of surprised by that, because I would have figured once we introduce a new witness version, we wouldn't want unupgraded nodes relaying the new
<bitcoin-git> [bitcoin] laanwj merged pull request #25197: contrib: Remove keys that are no longer used for merging (master...220524-keys) https://github.com/bitcoin/bitcoin/pull/25197
<bitcoin-git> bitcoin/master d4b3dc5 Hennadii Stepanov: contrib: Remove keys that are no longer used for merging
<bitcoin-git> bitcoin/master b4f6869 laanwj: Merge bitcoin/bitcoin#25197: contrib: Remove keys that are no longer used ...
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8c721fff3a00...b4f686952a60
<bitcoin-git> [bitcoin] laanwj merged pull request #25180: [22.x] qt: Avoid crash on startup if int specified in settings.json (22.x...pr/setint22) https://github.com/bitcoin/bitcoin/pull/25180
<bitcoin-git> bitcoin/22.x 344537c Ryan Ofsky: qt: Avoid crash on startup if int specified in settings.json
<bitcoin-git> bitcoin/22.x 04fdd64 laanwj: Merge bitcoin/bitcoin#25180: [22.x] qt: Avoid crash on startup if int spec...
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to 22.x: https://github.com/bitcoin/bitcoin/compare/cb13ba6d1172...04fdd644b43a
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #22956: validation: log CChainState::CheckBlockIndex() consistency checks (master...CheckBlockIndex-logging) https://github.com/bitcoin/bitcoin/pull/22956
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25192: test: add coverage for unknown value to -blockfilterindex (master...2022-05-unknown-blockfilter) https://github.com/bitcoin/bitcoin/pull/25192
<bitcoin-git> bitcoin/master 8c721ff MacroFake: Merge bitcoin/bitcoin#25192: test: add coverage for unknown value to -bloc...
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bd57b4e0c01b...8c721fff3a00
<bitcoin-git> bitcoin/master 295ff61 brunoerg: test: add coverage for unknown -blockfilterindex
<bitcoin-git> [bitcoin] fanquake merged pull request #24757: build, ci: add `DEBUG_LOCKCONTENTION` to --enable-debug and CI (master...add-DEBUG_LOCKCONTENTION-to-enable-debug) https://github.com/bitcoin/bitcoin/pull/24757
<bitcoin-git> bitcoin/master bd5dbc3 Jon Atack: doc: update developer notes wrt --enable-debug and DEBUG_LOCKCONTENTION
<bitcoin-git> bitcoin/master 345647c Jon Atack: ci: add DEBUG_LOCKCONTENTION to CI task containing DEBUG_LOCKORDER
<bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/90e49c1ececd...bd57b4e0c01b
<bitcoin-git> bitcoin/master 247d170 Jon Atack: build: add DEBUG_LOCKCONTENTION to --enable-debug configuration
<bitcoin-git> [bitcoin] theStack opened pull request #25204: rpc: remove deprecated top-level fee fields from mempool entries (master...202205-rpc-remove_deprecated_top_level_fee_fields) https://github.com/bitcoin/bitcoin/pull/25204

2022-05-24

<bitcoin-git> [gui] jarolrod closed pull request #585: Replace QRegExp with QRegularExpression (master...qregexp-obsolete) https://github.com/bitcoin-core/gui/pull/585
<bitcoin-git> [gui] jarolrod opened pull request #606: Replace QRegExp with QRegularExpression (master...regexp-obsolete) https://github.com/bitcoin-core/gui/pull/606
<bitcoin-git> [bitcoin] MiranDaniel closed pull request #25182: doc: Fix Markdown formatting (master...master) https://github.com/bitcoin/bitcoin/pull/25182
<bitcoin-git> [bitcoin] jonatack opened pull request #25203: log: de-dupe TOR/I2P/NET category prefixes and update their LogPrintf ones (master...logging-updates) https://github.com/bitcoin/bitcoin/pull/25203
<bitcoin-git> [bitcoin] laanwj opened pull request #25202: log: Use severity-based logging for leveldb/libevent messages (master...2022-05-logging-improved) https://github.com/bitcoin/bitcoin/pull/25202
<bitcoin-git> [bitcoin] laanwj merged pull request #24464: logging: Add severity level to logs (master...log_level) https://github.com/bitcoin/bitcoin/pull/24464
<bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/700808754884...90e49c1ececd
<bitcoin-git> bitcoin/master a829064 klementtan: logging: Add severity level to logs.
<bitcoin-git> bitcoin/master e11cdc9 klementtan: logging: Add log severity level to net.cpp
<bitcoin-git> bitcoin/master 90e49c1 laanwj: Merge bitcoin/bitcoin#24464: logging: Add severity level to logs
<bitcoin-git> [bitcoin] achow101 opened pull request #25201: windeploy: Renewed windows code signing certificate (master...2022-05-win-cert) https://github.com/bitcoin/bitcoin/pull/25201
<bitcoin-git> [bitcoin] Empact opened pull request #25200: doc: Fix spelling errors identified by codespell in coments (master...2022-05-codespell) https://github.com/bitcoin/bitcoin/pull/25200
<bitcoin-git> [bitcoin] laanwj merged pull request #24410: [kernel 2a/n] Split hashing/index `GetUTXOStats` codepaths, decouple from `coinstatsindex` (master...2022-02-libbitcoinkernel-p2-coinstats-minimal) https://github.com/bitcoin/bitcoin/pull/24410
<bitcoin-git> bitcoin/master 52b1939 Carl Dong: kernel: Remove unnecessary blockfilter{index,}.cpp
<bitcoin-git> bitcoin/master 0848db9 Carl Dong: fuzz: Remove useless GetUTXOStats fuzz case
<bitcoin-git> bitcoin/master 1022948 Carl Dong: includes: Remove rpc/util.h -> node/coinstats.h
<bitcoin-git> [bitcoin] laanwj pushed 16 commits to master: https://github.com/bitcoin/bitcoin/compare/88989063705b...700808754884
<bitcoin-git> [bitcoin] hebasto opened pull request #25197: contrib: Remove keys that are no longer used for merging (master...220524-keys) https://github.com/bitcoin/bitcoin/pull/25197
<bitcoin-git> [bitcoin] fanquake closed pull request #25196: Create bitcoin (master...patch-1) https://github.com/bitcoin/bitcoin/pull/25196
<bitcoin-git> [bitcoin] Zphyero opened pull request #25196: Create bitcoin (master...patch-1) https://github.com/bitcoin/bitcoin/pull/25196
<bitcoin-git> bitcoin/master 8898906 Hennadii Stepanov: Merge bitcoin-core/gui#593: Getting ready to Qt 6 (8/n). Use `QRegularExpr...
<bitcoin-git> [bitcoin] hebasto pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/136863443300...88989063705b
<bitcoin-git> bitcoin/master 5c5d8f2 Hennadii Stepanov: qt, test: Add tests for searching in `AddressBookPage` dialog
<bitcoin-git> bitcoin/master e280087 Hennadii Stepanov: qt: Use `QRegularExpression` in `AddressBookSortFilterProxyModel` class
<bitcoin-git> [gui] hebasto merged pull request #593: Getting ready to Qt 6 (8/n). Use `QRegularExpression` in `AddressBookSortFilterProxyModel` class (master...220423-re) https://github.com/bitcoin-core/gui/pull/593
<bitcoin-git> bitcoin/master 31122aa Ryan Ofsky: refactor: Pass interfaces::Node references to OptionsModel constructor
<bitcoin-git> bitcoin/master 1368634 Hennadii Stepanov: Merge bitcoin-core/gui#601: refactor: Pass interfaces::Node references to ...
<bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/aa5cd3cc6d47...136863443300
<bitcoin-git> [gui] hebasto merged pull request #601: refactor: Pass interfaces::Node references to OptionsModel constructor (master...pr/qtnode) https://github.com/bitcoin-core/gui/pull/601
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25149: refactor: Add thread safety annotation to `BanMan::SweepBanned()` (master...220516-bantsa) https://github.com/bitcoin/bitcoin/pull/25149
<bitcoin-git> bitcoin/master ab75388 Hennadii Stepanov: refactor: Remove redundant scope in `BanMan::SweepBanned()`
<bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/44037a29129a...aa5cd3cc6d47
<bitcoin-git> bitcoin/master 3919059 Hennadii Stepanov: refactor: Move code from ctor into private `BanMan::LoadBanlist()`
<bitcoin-git> bitcoin/master 52c0b3e Hennadii Stepanov: refactor: Add thread safety annotation to `BanMan::SweepBanned()`

2022-05-23

<bitcoin-git> [bitcoin] mzumsande opened pull request #25193: indexes: Read the locator's top block during init, allow interaction with reindex-chainstate (master...202205_index_allow_reindex_chainstate) https://github.com/bitcoin/bitcoin/pull/25193
<bitcoin-git> [bitcoin] brunoerg opened pull request #25192: test: add coverage for unknown value to -blockfilterindex (master...2022-05-unknown-blockfilter) https://github.com/bitcoin/bitcoin/pull/25192
<bitcoin-git> [bitcoin] hebasto opened pull request #25191: build: Make `--with-gui=qt6` configure option available on macOS (master...220523-qt6-mac) https://github.com/bitcoin/bitcoin/pull/25191
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25176: Fix frequent -netinfo JSON errors from missing getpeerinfo#relaytxes (master...fix-netinfo-json-errors-from-null-getpeerinfo-relaytxes-field) https://github.com/bitcoin/bitcoin/pull/25176
<bitcoin-git> bitcoin/master a17c5e9 Jon Atack: Rename NetinfoRequestHandler::is_block_relay data member to is_tx_relay
<bitcoin-git> bitcoin/master 44037a2 MacroFake: Merge bitcoin/bitcoin#25176: Fix frequent -netinfo JSON errors from missin...
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/fbb90c44ac8a...44037a29129a
<bitcoin-git> bitcoin/master f0bb7db Jon Atack: Fix frequent -netinfo JSON errors from null getpeerinfo#relaytxes
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25015: test: Use permissions from git in lint-files.py (master...2022-04-lint-permissions-git) https://github.com/bitcoin/bitcoin/pull/25015
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/3368f84c4359...fbb90c44ac8a
<bitcoin-git> bitcoin/master 48d2e80 laanwj: test: Don't use shell=True in `lint-files.py`
<bitcoin-git> bitcoin/master 908fb7e laanwj: test: Use permissions from git in `lint-files.py`
<bitcoin-git> bitcoin/master fbb90c4 MacroFake: Merge bitcoin/bitcoin#25015: test: Use permissions from git in lint-files....
<bitcoin-git> [bitcoin] achow101 merged pull request #25083: Set effective_value when initializing a COutput (master...draft-CalculateEffectiveValue2) https://github.com/bitcoin/bitcoin/pull/25083
<bitcoin-git> bitcoin/master 3368f84 Andrew Chow: Merge bitcoin/bitcoin#25083: Set effective_value when initializing a COutp...
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5ebff43025e4...3368f84c4359
<bitcoin-git> bitcoin/master 6fbb0ed ishaanam: Set effective_value when initializing a COutput
<bitcoin-git> bitcoin/master baa3ddc furszy: doc: add release notes about `getreceivedbylabel` returning an error if th...
<bitcoin-git> bitcoin/master 5ebff43 Andrew Chow: Merge bitcoin/bitcoin#25122: rpc: getreceivedbylabel, return early if no a...
<bitcoin-git> [bitcoin] achow101 merged pull request #25122: rpc: getreceivedbylabel, return early if no addresses were found in the address book (master...2022_RPC_getreceivedbylabel_return_early) https://github.com/bitcoin/bitcoin/pull/25122
<bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/66e3b16b8b10...5ebff43025e4
<bitcoin-git> bitcoin/master 8897a21 furszy: rpc: getreceivedbylabel, don't loop over the entire wallet txs map if no d...
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25184: refactor: Remove defunct attributes.h includes (master...2022-05-attributes-include) https://github.com/bitcoin/bitcoin/pull/25184
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/dfe11a1a7eac...66e3b16b8b10
<bitcoin-git> bitcoin/master 71a8dbe Ben Woosley: refactor: Remove defunct attributes.h includes
<bitcoin-git> bitcoin/master 66e3b16 MacroFake: Merge bitcoin/bitcoin#25184: refactor: Remove defunct attributes.h includes
<bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6d20f4b92090...dfe11a1a7eac
<bitcoin-git> bitcoin/master 252f363 Hennadii Stepanov: qt: Replace `QCoreApplication::quit()` with `QCoreApplication::exit(0)`
<bitcoin-git> bitcoin/master dfe11a1 Hennadii Stepanov: Merge bitcoin-core/gui#586: Getting ready to Qt 6 (6/n). Replace `QCoreApp...
<bitcoin-git> [gui] hebasto merged pull request #586: Getting ready to Qt 6 (6/n). Replace `QCoreApplication::quit()` with `QCoreApplication::exit(0)` (master...220416-quit) https://github.com/bitcoin-core/gui/pull/586
<bitcoin-git> [gui] hebasto closed pull request #440: Do not require restart if overridden option is modified (master...210929-restart) https://github.com/bitcoin-core/gui/pull/440
<bitcoin-git> [bitcoin] fanquake merged pull request #25178: doc: remove passing `--disable-external-signer` in OpenBSD build guide (master...202205-doc-update_openbsd_build_docs_71) https://github.com/bitcoin/bitcoin/pull/25178
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b0e16eb3ac93...6d20f4b92090
<bitcoin-git> bitcoin/master 9ecb0a3 Sebastian Falbesoner: doc: remove passing `--disable-external-signer` in OpenBSD build guide
<bitcoin-git> bitcoin/master 6d20f4b fanquake: Merge bitcoin/bitcoin#25178: doc: remove passing `--disable-external-signe...
<bitcoin-git> [bitcoin] S3RK closed pull request #24580: test: coinselection edge cases (master...coinselection_tests) https://github.com/bitcoin/bitcoin/pull/24580

2022-05-22

<bitcoin-git> bitcoin/master a63b60f Ryan Ofsky: refactor: Add OptionsModel getOption/setOption methods
<bitcoin-git> bitcoin/master b0e16eb Hennadii Stepanov: Merge bitcoin-core/gui#600: refactor: Add OptionsModel getOption/setOption...
<bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/640eb772e556...b0e16eb3ac93
<bitcoin-git> [gui] hebasto merged pull request #600: refactor: Add OptionsModel getOption/setOption methods (master...pr/qtopt) https://github.com/bitcoin-core/gui/pull/600
<bitcoin-git> [gui] hebasto opened pull request #605: Delete splash screen widget early (master...220522-splash) https://github.com/bitcoin-core/gui/pull/605
<bitcoin-git> [bitcoin] trizko closed pull request #25186: Add assertion in example_test.py for chaincode labs assignment (master...ccl-challenge) https://github.com/bitcoin/bitcoin/pull/25186
<bitcoin-git> [bitcoin] trizko opened pull request #25186: Add assertion in example_test.py for chaincode labs assignment (master...ccl-challenge) https://github.com/bitcoin/bitcoin/pull/25186

2022-05-21

<pinheadmz_> These comments "...after removing optional annex": https://github.com/bitcoin/bitcoin/blob/master/src/policy/policy.cpp#L260
<bitcoin-git> [bitcoin] Empact opened pull request #25184: refactor: Remove defunct attributes.h includes (master...2022-05-attributes-include) https://github.com/bitcoin/bitcoin/pull/25184
<bitcoin-git> [gui] hebasto closed pull request #592: Drop wildcard support for address/label search in `AddressBookPage` (master...220423-wildcard) https://github.com/bitcoin-core/gui/pull/592
<bitcoin-git> [bitcoin] mruddy closed pull request #24912: refactor: update CBlockIndex::nChainTx to be uint64_t (master...nchaintx_type) https://github.com/bitcoin/bitcoin/pull/24912
<bitcoin-git> [bitcoin] aureleoules opened pull request #25183: rpc: Witness-only inputs for fundrawtransaction (master...2022-05-witness-only-fundrawtransaction) https://github.com/bitcoin/bitcoin/pull/25183
<luke-jr> david-bakin: various historical aspects of Bitcoin do some crazy things re endian

2022-05-20

<bitcoin-git> [bitcoin] MiranDaniel opened pull request #25182: doc: Fix Markdown formatting (master...master) https://github.com/bitcoin/bitcoin/pull/25182
<gribble> https://github.com/bitcoin/bitcoin/issues/24494 | wallet: generate random change target for each tx for better privacy by glozow · Pull Request #24494 · bitcoin/bitcoin · GitHub
<core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
<gribble> https://github.com/bitcoin/bitcoin/issues/23475 | wallet: add config to prioritize a solution that doesnt create change in coin selection by brunoerg · Pull Request #23475 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/24752 | wallet: increase BnB upper limit by S3RK · Pull Request #24752 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/23475 | wallet: add config to prioritize a solution that doesnt create change in coin selection by brunoerg · Pull Request #23475 · bitcoin/bitcoin · GitHub
<jonatack> might be good for people to weigh in on https://github.com/bitcoin/bitcoin/issues/25130
<gribble> https://github.com/bitcoin/bitcoin/issues/24580 | test: coinselection edge cases by S3RK · Pull Request #24580 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/24580 | test: coinselection edge cases by S3RK · Pull Request #24580 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/24584 | wallet: avoid mixing different `OutputTypes` during coin selection by josibake · Pull Request #24584 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/25083 | Set effective_value when initializing a COutput by ishaanam · Pull Request #25083 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/25005 | wallet: remove extra wtx lookup in AvailableCoins + several code cleanups. by furszy · Pull Request #25005 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/24584 | wallet: avoid mixing different `OutputTypes` during coin selection by josibake · Pull Request #24584 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/24699 | wallet: Improve AvailableCoins performance by reducing duplicated operations by achow101 · Pull Request #24699 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/25083 | Set effective_value when initializing a COutput by ishaanam · Pull Request #25083 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/25118 | wallet: unify “allow/block other inputs“ concept by furszy · Pull Request #25118 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/25005 | wallet: remove extra wtx lookup in AvailableCoins + several code cleanups. by furszy · Pull Request #25005 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/25122 | rpc: getreceivedbylabel, return early if no addresses were found in the address book by furszy · Pull Request #25122 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/25122 | rpc: getreceivedbylabel, return early if no addresses were found in the address book by furszy · Pull Request #25122 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/24649 | wallet: do not count wallet utxos as external by S3RK · Pull Request #24649 · bitcoin/bitcoin · GitHub
<achow101> #bitcoin-core-dev Wallet Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos Murch nehan NicolasDorier paveljanik
<core-meetingbot> Meeting started Fri May 20 19:01:43 2022 UTC. The chair is achow101. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25064: [kernel 2b/n] Add `ChainstateManager::m_adjusted_time_callback` (master...2022-05-libbitcoinkernel-adjtime) https://github.com/bitcoin/bitcoin/pull/25064
<bitcoin-git> bitcoin/master 04c31c1 Carl Dong: Add ChainstateManager::m_adjusted_time_callback
<bitcoin-git> bitcoin/master 53494bc Carl Dong: validation: Have ChainstateManager own m_chainparams
<bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/aac99faa66e2...640eb772e556
<bitcoin-git> bitcoin/master dbe45c3 Carl Dong: Add ChainstateManagerOpts, using as ::Options
<bitcoin-git> [gui] ryanofsky opened pull request #603: Add settings.json prune-prev, proxy-prev, onion-prev settings (master...pr/qtkeep) https://github.com/bitcoin-core/gui/pull/603
<bitcoin-git> [bitcoin] theStack opened pull request #25178: doc: remove passing `--disable-external-signer` in OpenBSD build guide (master...202205-doc-update_openbsd_build_docs_71) https://github.com/bitcoin/bitcoin/pull/25178
<bitcoin-git> [bitcoin] jonatack opened pull request #25176: Fix frequent -netinfo JSON errors from missing getpeerinfo#relaytxes (master...fix-netinfo-json-errors-from-null-getpeerinfo-relaytxes-field) https://github.com/bitcoin/bitcoin/pull/25176
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25168: refactor: Avoid passing params where not needed (master...2205-remove-bloat-🏮) https://github.com/bitcoin/bitcoin/pull/25168
<bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/8c61374ba782...4d0c00dffd13
<bitcoin-git> bitcoin/master fa4ee53 MacroFake: Do not pass time getter to Chainstate helpers
<bitcoin-git> bitcoin/master faf012b MacroFake: Do not pass Consensus::Params& to Chainstate helpers
<bitcoin-git> bitcoin/master fafe5c0 MacroFake: Do not pass CChainParams& to BlockAssembler constructor
<bitcoin-git> [bitcoin] hebasto opened pull request #25175: refactor: Improve thread safety analysis by propagating some negative capabilities (master...220520-nega) https://github.com/bitcoin/bitcoin/pull/25175
<bitcoin-git> [gui] hebasto merged pull request #581: refactor: Revamp `ClientModel` code to handle core signals (master...220410-invoke) https://github.com/bitcoin-core/gui/pull/581
<hebasto> has bitcoin-git bot just got another holiday?
<bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0cd1a2eff9e0...8118970c869f
<bitcoin-git> bitcoin/master e3daeca João Barbosa: scripted-diff: replace deprecated Q_OS_MAC with Q_OS_MACOS
<bitcoin-git> bitcoin/master 8118970 Hennadii Stepanov: Merge bitcoin-core/gui#594: scripted-diff: replace deprecated Q_OS_MAC wit...
<bitcoin-git> [gui] hebasto merged pull request #594: scripted-diff: replace deprecated Q_OS_MAC with Q_OS_MACOS (master...q_os_macos) https://github.com/bitcoin-core/gui/pull/594
<bitcoin-git> [bitcoin] laanwj merged pull request #23595: util: Add ParseHexstd::byte() helper (master...2111-utilHexByte) https://github.com/bitcoin/bitcoin/pull/23595
<bitcoin-git> bitcoin/master facd1fb MarcoFalke: refactor: Use Span of std::byte in CExtKey::SetSeed
<bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/a7e3afb22136...0cd1a2eff9e0
<bitcoin-git> bitcoin/master fabdf81 MarcoFalke: test: Add test for embedded null in hex string
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25171: rpc: wallet: remove `-deprecatedrpc=exclude_coinbase` logic (master...202205-rpc-remove_deprecated_include_coinbase_option) https://github.com/bitcoin/bitcoin/pull/25171
<bitcoin-git> bitcoin/master a7e3afb MacroFake: Merge bitcoin/bitcoin#25171: rpc: wallet: remove `-deprecatedrpc=exclude_c...
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/a39002e0c642...a7e3afb22136
<bitcoin-git> bitcoin/master ef0aa74 Sebastian Falbesoner: rpc: wallet: remove `-deprecatedrpc=exclude_coinbase` logic
<bitcoin-git> bitcoin/master a4703ce Sebastian Falbesoner: doc: add release notes about removal of the `deprecatedrpc=exclude_coinbas...
<gribble> https://github.com/bitcoin/bitcoin/issues/24150 | refactor: move index class members from protected to private by jonatack · Pull Request #24150 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4a8709821e64...a39002e0c642
<bitcoin-git> bitcoin/master fafae67 MacroFake: build: Enable RPC_DOC_CHECK on --enable-debug
<bitcoin-git> bitcoin/master a39002e fanquake: Merge bitcoin/bitcoin#25170: build: Enable RPC_DOC_CHECK on --enable-debug
<bitcoin-git> [bitcoin] fanquake merged pull request #25170: build: Enable RPC_DOC_CHECK on --enable-debug (master...2205-enable-rpc-doc-check-on-debug-🗿) https://github.com/bitcoin/bitcoin/pull/25170
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24830: init: Allow -proxy="" setting values (master...pr/proxy) https://github.com/bitcoin/bitcoin/pull/24830
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d433f59f1eb8...4a8709821e64
<bitcoin-git> bitcoin/master 1d4122d Ryan Ofsky: init: Allow -proxy="" setting values
<bitcoin-git> bitcoin/master 4a87098 MacroFake: Merge bitcoin/bitcoin#24830: init: Allow -proxy="" setting values
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25173: test: add coverage for unknown network in -onlynet (master...2022-05-unknown-onlynet) https://github.com/bitcoin/bitcoin/pull/25173
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6407c0e8a33f...d433f59f1eb8
<bitcoin-git> bitcoin/master 055d94d brunoerg: test: add coverage for unknown network in -onlynet
<bitcoin-git> bitcoin/master d433f59 MacroFake: Merge bitcoin/bitcoin#25173: test: add coverage for unknown network in -on...
<gribble> https://github.com/bitcoin/bitcoin/issues/25120 | test: fix DWARF string_view linker error in blockfilter_tests by jonatack · Pull Request #25120 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] fanquake merged pull request #25101: Add mockable clock type (master...2205-mock-clock-😃) https://github.com/bitcoin/bitcoin/pull/25101
<bitcoin-git> bitcoin/master 6407c0e fanquake: Merge bitcoin/bitcoin#25101: Add mockable clock type
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0de36941eca1...6407c0e8a33f
<bitcoin-git> bitcoin/master fa305fd MarcoFalke: Add mockable clock type and TicksSinceEpoch helper

2022-05-19

<bitcoin-git> [bitcoin] ajtowns opened pull request #25174: net/net_processing: Add thread safety related annotations for CNode and Peer (master...202205-net-lock-annotations) https://github.com/bitcoin/bitcoin/pull/25174
<gribble> https://github.com/bitcoin/bitcoin/issues/25153 | scripted-diff: Use getInt over get_int/get_int64 by MarcoFalke · Pull Request #25153 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/24410 | [kernel 2a/n] Split hashing/index `GetUTXOStats` codepaths, decouple from `coinstatsindex` by dongcarl · Pull Request #24410 · bitcoin/bitcoin · GitHub
<dongcarl> libbitcoinkernel #24410 reviewers: I would love feedback on this: https://github.com/bitcoin/bitcoin/pull/24410#issuecomment-1132161124
<bitcoin-git> [gui] ryanofsky opened pull request #602: Unify bitcoin-qt and bitcoind persistent settings #15936 (master...pr/qtsopt) https://github.com/bitcoin-core/gui/pull/602
<bitcoin-git> [bitcoin] brunoerg opened pull request #25173: test: add coverage for unknown network in -onlynet (master...2022-05-unknown-onlynet) https://github.com/bitcoin/bitcoin/pull/25173
<bitcoin-git> [gui] ryanofsky opened pull request #601: refactor: Pass interfaces::Node references to OptionsModel constructor (master...pr/qtnode) https://github.com/bitcoin-core/gui/pull/601
<bitcoin-git> [gui] ryanofsky opened pull request #600: refactor: Add OptionsModel getOption/setOption methods (master...pr/qtopt) https://github.com/bitcoin-core/gui/pull/600
<core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
<gribble> https://github.com/bitcoin/bitcoin/issues/23595 | util: Add ParseHex () helper by MarcoFalke · Pull Request #23595 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/22702 | Add allocator for node based containers by martinus · Pull Request #22702 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/23443 | p2p: Erlay support signaling by naumenkogs · Pull Request #23443 · bitcoin/bitcoin · GitHub
<laanwj> there's currently 12 blockers and 2 chasing concept ACK in https://github.com/bitcoin/bitcoin/projects/8
<laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard b10c BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo
<core-meetingbot> Meeting started Thu May 19 19:00:00 2022 UTC. The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
<david-bakin> Decl of CTxOut in transactionh shows it is a struct with a CAmount and a CScript - it serializes as one after the other. I think it would be clearer if the 2 fields were in fact serialized separately as it shows in BIP-341. That's in fact what I did in the unit tests I'm writing - see https://github.com/bitcoin/bitcoin/pull/25097/files#diff-21483d0e032747850208f21325b29cde89e9c1f
<bitcoin-git> [bitcoin] fanquake opened pull request #25172: refactor: use std:: for mem*( funcs (master...use_std_variants) https://github.com/bitcoin/bitcoin/pull/25172
<bitcoin-git> [bitcoin] fanquake merged pull request #25153: scripted-diff: Use getIntT over get_int/get_int64 (master...2205-uni-int-🗝) https://github.com/bitcoin/bitcoin/pull/25153
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e18fd4763e77...0de36941eca1
<bitcoin-git> [bitcoin] theStack opened pull request #25171: rpc: wallet: remove `-deprecatedrpc=exclude_coinbase` logic (master...202205-rpc-remove_deprecated_include_coinbase_option) https://github.com/bitcoin/bitcoin/pull/25171
<bitcoin-git> [bitcoin] fanquake merged pull request #25074: index: During sync, commit best block after indexing (master...202205_index_sync_order) https://github.com/bitcoin/bitcoin/pull/25074
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/345d860f3818...e18fd4763e77
<bitcoin-git> bitcoin/master 7171ebc Martin Zumsande: index: Don't commit a best block before indexing it during sync
<bitcoin-git> bitcoin/master e18fd47 fanquake: Merge bitcoin/bitcoin#25074: index: During sync, commit best block after i...
<bitcoin-git> [bitcoin] sdaftuar closed pull request #20726: p2p: Add DISABLETX message for negotiating block-relay-only connections (master...2020-12-negotiate-block-relay) https://github.com/bitcoin/bitcoin/pull/20726
<bitcoin-git> [bitcoin] fanquake merged pull request #25166: doc: Add link to NetBSD release (master...NetBSD-release-link) https://github.com/bitcoin/bitcoin/pull/25166
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fdb82a30bed2...345d860f3818
<bitcoin-git> bitcoin/master 174f58c Marnix: Add link to NetBSD release
<bitcoin-git> bitcoin/master 345d860 fanquake: Merge bitcoin/bitcoin#25166: doc: Add link to NetBSD release
<bitcoin-git> [bitcoin] fanquake merged pull request #25147: Net processing: follow ups to #20799 (removing support for v1 compact blocks) (master...20205_20799_follow_ups) https://github.com/bitcoin/bitcoin/pull/25147
<bitcoin-git> bitcoin/master bf6526f John Newbery: [test] Remove segwit argument from build_block_on_tip()
<bitcoin-git> bitcoin/master fdb82a3 fanquake: Merge bitcoin/bitcoin#25147: Net processing: follow ups to #20799 (removin...
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/986bae8e7248...fdb82a30bed2
<bitcoin-git> bitcoin/master c65bf50 John Newbery: Remove fUseWTXID parameter from CBlockHeaderAndShortTxIDs constructor
<bitcoin-git> [bitcoin] fanquake merged pull request #22778: net processing: Reduce resource usage for inbound block-relay-only connections (master...2021-02-tx-relay-init) https://github.com/bitcoin/bitcoin/pull/22778
<bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/bb83aba6c98b...986bae8e7248
<bitcoin-git> bitcoin/master 42e3250 John Newbery: [net processing] [refactor] Move m_next_send_feefilter and m_fee_filter_se...
<bitcoin-git> bitcoin/master 290a8da John Newbery: [net processing] Comment all TxRelay members
<bitcoin-git> bitcoin/master b0a4ac9 John Newbery: [net processing] Add m_tx_relay_mutex to protect m_tx_relay ptr
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25170: build: Enable RPC_DOC_CHECK on --enable-debug (master...2205-enable-rpc-doc-check-on-debug-🗿) https://github.com/bitcoin/bitcoin/pull/25170
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25161: rpc: Put undocumented JSON failure mode behind a runtime flag (master...master) https://github.com/bitcoin/bitcoin/pull/25161
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7b3343f3009d...bb83aba6c98b
<bitcoin-git> bitcoin/master b953ea6 Suhail Saqan: rpc: Put undocumented JSON failure mode behind a runtime flag
<bitcoin-git> bitcoin/master bb83aba MacroFake: Merge bitcoin/bitcoin#25161: rpc: Put undocumented JSON failure mode behin...

2022-05-18

<bitcoin-git> [bitcoin] hebasto opened pull request #25169: guix: Simplify code for Linux builds (master...220518-inputs) https://github.com/bitcoin/bitcoin/pull/25169
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25108: tidy: add modernize-use-default-member-init (master...modernize_use_default_Member_init) https://github.com/bitcoin/bitcoin/pull/25108
<bitcoin-git> bitcoin/master ac6fbf2 fanquake: tidy: use modernize-use-default-member-init
<bitcoin-git> bitcoin/master 7b3343f MacroFake: Merge bitcoin/bitcoin#25108: tidy: add modernize-use-default-member-init
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/e016c00e98b8...7b3343f3009d
<bitcoin-git> bitcoin/master 7aa40f5 fanquake: refactor: use C++11 default initializers
<dhruv> jonatack: that seems to imply i need access to the crash-* file. and CI doesn't seem to be commiting the crash seed to here? https://github.com/bitcoin-core/qa-assets/tree/main/fuzz_seed_corpus Am I missing something?
<bitcoin-git> bitcoin/master 5dc6d92 Sebastian Falbesoner: test: make BIP157 messages default-constructible (MESSAGEMAP compatibility)
<bitcoin-git> bitcoin/master e016c00 MacroFake: Merge bitcoin/bitcoin#25126: test: add BIP157 message parsing support (via...
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25126: test: add BIP157 message parsing support (via MESSAGEMAP) (master...202205-test-support_BIP157_deser_via_messagemap) https://github.com/bitcoin/bitcoin/pull/25126
<bitcoin-git> bitcoin/master 71e4cfe Sebastian Falbesoner: test: p2p: add missing BIP157 message types to MESSAGEMAP
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/002411dc5375...e016c00e98b8
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25168: refactor: Avoid passing params where not needed (master...2205-remove-bloat-🏮) https://github.com/bitcoin/bitcoin/pull/25168
<david-bakin> I have a non-bitcoin-specific "process" question: If I get a suggestion in a PR that has actual code and the button "commit suggestion" and I press the button - how does that fix, committed in bitcoin/bitcoin, get back to my fork? Do I just do it manually (create a patch any apply it) or??
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25157: Fix -rpcwait with -netinfo returning negative time durations (master...update-time-in-rpcwait-and-netinfo) https://github.com/bitcoin/bitcoin/pull/25157
<bitcoin-git> bitcoin/master 3a998d2 Jon Atack: Use steady_clock in ConnectAndCallRPC and inline time call in loop conditi...
<bitcoin-git> bitcoin/master 002411d MacroFake: Merge bitcoin/bitcoin#25157: Fix -rpcwait with -netinfo returning negative...
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/629e250cbdee...002411dc5375
<bitcoin-git> bitcoin/master 3799d2d Jon Atack: Fix -rpcwait with -netinfo printing negative time durations
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25148: refactor: Remove `NO_THREAD_SAFETY_ANALYSIS` from non-test/benchmarking code (master...220516-todo) https://github.com/bitcoin/bitcoin/pull/25148
<bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/139f789d7a9f...629e250cbdee
<bitcoin-git> bitcoin/master ca446f2 Hennadii Stepanov: Add proper thread safety annotation to `CachedTxGetAvailableCredit()`
<bitcoin-git> bitcoin/master 8cfe93e Hennadii Stepanov: Add proper thread safety annotation to `CWallet::GetTxConflicts()`
<bitcoin-git> bitcoin/master a55db4e Hennadii Stepanov: Add more proper thread safety annotations