<bitcoin-git>
[bitcoin] glozow merged pull request #26603: doc: CalculateSequenceLocks: prevHeights entries are set to 0, not removed (master...docs-fix-CalculateSequenceLocks) https://github.com/bitcoin/bitcoin/pull/26603
<lisper29>
bitcoind's (24.0.1) listreceivedbyaddress always returns an empty array for a watch-only wallet when it's of type descriptor (not legacy). Anyone know if that's expected behaviour, or a potential bug? (This problem doesn't occur with a legacy watch-only wallet, only a descriptor watch-only wallet.) Helpful people in #bitcoin suggested I ask in here. Thanks in advance.
<bitcoin-git>
bitcoin/master fa5cbf2 MarcoFalke: ci: Properly set COMMIT_RANGE in lint task
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #26802: test: Use same Python executable for subprocesses as for `all-lint.py` (master...all-lint-python-executable) https://github.com/bitcoin/bitcoin/pull/26802
<bitcoin-git>
bitcoin/master 4bb840a MarcoFalke: Merge bitcoin/bitcoin#26802: test: Use same Python executable for subproce...
<bitcoin-git>
[bitcoin] jonatack opened pull request #26801: script: drop E275 rule in lint-python.py for flake8 5.0.4, update dependencies (master...2023-01-python-linter-drop-E275-rule-and-update-dependencies) https://github.com/bitcoin/bitcoin/pull/26801
<laanwj>
it's printed the "merged pull request" zillions of times to #bitcoin-commits, and mastodon because i re-sent it to test 😅
<bitcoin-git>
[bitcoin] achow101 merged pull request #26192: rpc: Improve error when wallet is already loaded (master...2022-09-load-wallet-err) https://github.com/bitcoin/bitcoin/pull/26192
<achow101>
laanwj: I think bitcoin-git is dead?
2023-01-02
<bytes1440000>
poeple are talking shit about him on social media dont realize he never forced anyone to donate and was passionate to work for bitcoin all these years.
<bytes1440000>
anyway, whoever has stolen luke's btc or other things that might affect bitcoin pls be aware its not easy. cashout wont be easy, if caught, you will go to jail and return btc. If caught elsewhere many bitcoiners wont have any hesiation to shoot you on sight.
<bitcoin-git>
[gui] john-moffett opened pull request #693: Fix segfault when shutdown during wallet open (master...2022_12_29_FixSegfaultOnCloseWalletPopup) https://github.com/bitcoin-core/gui/pull/693
<bitcoin-git>
[bitcoin] jdjkelly opened pull request #26777: rpc: Remove duplicate field in RPCHelpMan for gettransactions (master...rpc/get-transactions-typo) https://github.com/bitcoin/bitcoin/pull/26777
<bitcoin-git>
[bitcoin] murrayn opened pull request #26773: doc: FreeBSD build doc should suggest db4 for legacy wallet support (master...use_db4_on_freebsd) https://github.com/bitcoin/bitcoin/pull/26773
<bitcoin-git>
[bitcoin] murrayn opened pull request #26772: script: fix sha256 check in contrib/install_db4.sh for FreeBSD (master...freebsd_db4_fix) https://github.com/bitcoin/bitcoin/pull/26772
2022-12-29
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #26770: ci: Move `--enable-c++20` from "tidy" task back to "ASan..." one (master...221229-c++20) https://github.com/bitcoin/bitcoin/pull/26770
<bitcoin-git>
bitcoin/master afc6052 Hennadii Stepanov: ci: Move `--enable-c++20` from "tidy" task back to "ASan..." one
<bitcoin-git>
[bitcoin] hebasto opened pull request #26770: ci: Move `--enable-c++20` from "tidy" task back to "ASan..." one (master...221229-c++20) https://github.com/bitcoin/bitcoin/pull/26770
<bitcoin-git>
[bitcoin] w0xlt opened pull request #26756: wallet: Replace `GetBalance()` logic with `AvailableCoins()` (master...balance_coin_selection) https://github.com/bitcoin/bitcoin/pull/26756
2022-12-26
<bitcoin-git>
[bitcoin] andrewtoth opened pull request #26755: p2p: cache compact block message to use for low bandwidth CMPCT_BLOCK (master...cache-cmpctblk-msg) https://github.com/bitcoin/bitcoin/pull/26755
<bitcoin-git>
[bitcoin] hebasto opened pull request #26749: refactor: Use move semanitcs in favour of custom swap functions (master...221224-move) https://github.com/bitcoin/bitcoin/pull/26749
<bitcoin-git>
[bitcoin] de-nazify-bitcoin opened pull request #26744: De-nazify Bitcoin! - Kicking out the Ukranian neo-nazi Hennadii Stepanov from the Bitcoin organization (master...patch-1) https://github.com/bitcoin/bitcoin/pull/26744
<bitcoin-git>
[bitcoin] fjahr opened pull request #26742: http: Track active requests and wait for last to finish - 2nd attempt (master...202212-pr19420) https://github.com/bitcoin/bitcoin/pull/26742
<taylorfrommynode>
2022-12-22T16:21:35Z Error: Failed to load database path '/home/bitcoin/.bitcoin'. Data is not in recognized format.
<taylorfrommynode>
I communicated the workaround of moving the wallet.dat file into a folder, but many users are still seeing a secondary issue. The log hits an error referencing the entire Bitcoin folder.
<p2plife>
fyi, on #bitcoin user chown claims his bitcoin-qt crashes with out of bounds. still there although AFK
<bitcoin-git>
[bitcoin] achow101 opened pull request #26740: wallet: Migrate wallets that are not in a wallet dir (master...migrate-plain-wallet-file) https://github.com/bitcoin/bitcoin/pull/26740
<p2plife>
excellent success and as usual top notch developer's support for Bitcoin
<taylorfrommynode>
Success! Putting it inside a folder causes bitcoin to start as expected.
<taylorfrommynode>
What seems extra concerning is that some users report this error even after removing the bad wallet or removing it from bitcoin.conf, they still get an error about the format of the whole datadir.
<taylorfrommynode>
Error: Failed to load database path '/home/bitcoin/.bitcoin'. Data is not in recognized format.
<taylorfrommynode>
OK, I can post here now as well. I'm seeing a pretty prevalent issue when upgrading devices from v23.0 to v24.0 where Bitcoin fails to start, often on the second restart after upgrading to v24. The log reports a message, but it isn't overly helpful and just says wallet.dat cannot be opened.
<p2plife>
user on #bitcoin claims after upgrade to 0.24 some old wallets broke. taylorfrommynode (voice in #bitcoin)
<bitcoin-git>
bitcoin/master f3bc1a7 Andrew Chow: Merge bitcoin/bitcoin#26265: POLICY: Relax MIN_STANDARD_TX_NONWITNESS_SIZE...
<bitcoin-git>
[bitcoin] brunoerg opened pull request #26738: test: add coverage for unknown wallet flag in `setwalletflag` (master...2022-12-setwalletflag-unknown-error) https://github.com/bitcoin/bitcoin/pull/26738
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #26735: [24.x] qt: Load PSBTs using istreambuf_iterator rather than istream_iterator (24.x...2212-backport-gui-psbt-whitespace-fix-🔈) https://github.com/bitcoin/bitcoin/pull/26735
<bitcoin-git>
bitcoin/master 4cd6b3b MarcoFalke: Merge bitcoin-core/gui#687: Load PSBTs using istreambuf_iterator rather th...
<bitcoin-git>
bitcoin/master bb5ea1d Andrew Chow: qt: Load PSBTs using istreambuf_iterator rather than istream_iterator
<bitcoin-git>
[gui] MarcoFalke merged pull request #687: Load PSBTs using istreambuf_iterator rather than istream_iterator (master...load-psbt-istreambuf) https://github.com/bitcoin-core/gui/pull/687
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #26722: test: speed up the two slowest functional tests by 18-35% via `keypoolrefill()` (master...wallet_fundrawtransaction_speedup) https://github.com/bitcoin/bitcoin/pull/26722
<bitcoin-git>
bitcoin/master 8e0faba S3RK: test: make wallet_migration.py pass with both wallet flags
<bitcoin-git>
bitcoin/master 17554ef S3RK: test: prefer sqlite for wallet tests
<bitcoin-git>
bitcoin/master 8456bfa Andrew Chow: Merge bitcoin/bitcoin#26638: test: prefer sqlite for wallet tests
<bitcoin-git>
[bitcoin] yusufsahinhamza opened pull request #26733: test: Add test for `sendmany` rpc that uses `subtractfeefrom` parameter (master...add-sendmany-test) https://github.com/bitcoin/bitcoin/pull/26733
<bytes1440000>
Happy Holidays. I wanted to make this happier for someone else as it was the first time someone appreciated my efforts in last few years. It wasnt bitcoin or bitcoin core but nostr.
<bytes1440000>
Hi michaelfolkson, my email on bitcoin-dev was not ranting, raving or throwing toys. It was 90% facts with links and 10% opinion.
<bitcoin-git>
[bitcoin] furszy opened pull request #26732: wallet: tx creation, don't select outputs from txes that are being replaced (master...2022_wallet_do_not_select_utxo_from_the_tx_being_replaced) https://github.com/bitcoin/bitcoin/pull/26732
<sipa>
In the Bitcoin Core source code, see key_io.cpp for higher-level conversions between witness programs and addresses.
2022-12-19
<bitcoin-git>
[bitcoin] achow101 closed pull request #23417: wallet, spkm: Move key management from DescriptorScriptPubKeyMan to wallet level KeyManager (master...wallet-keyman) https://github.com/bitcoin/bitcoin/pull/23417
<bitcoin-git>
[bitcoin] achow101 opened pull request #26728: wallet: Have the wallet store the key for automatically generated descriptors (master...wallet-knows-master-key) https://github.com/bitcoin/bitcoin/pull/26728
<bitcoin-git>
[bitcoin] fanquake opened pull request #26727: rpc: remove optional from fStateStats fields (master...remove_fstatestats_post_26515) https://github.com/bitcoin/bitcoin/pull/26727
<bitcoin-git>
[bitcoin] fanquake closed pull request #26723: test: call `keypoolrefill` with priv key disabled should throw an error (master...2022-12-keypool-error-privatekey) https://github.com/bitcoin/bitcoin/pull/26723
<bitcoin-git>
[bitcoin] brunoerg opened pull request #26723: test: call `keypoolrefill` with priv key disabled should throw an error (master...2022-12-keypool-error-privatekey) https://github.com/bitcoin/bitcoin/pull/26723
<bitcoin-git>
[gui] achow101 opened pull request #687: qt: Load PSBTs using istreambuf_iterator rather than istream_iterator (master...load-psbt-istreambuf) https://github.com/bitcoin-core/gui/pull/687
<bitcoin-git>
[bitcoin] kdmukai opened pull request #26722: test: speed up the two slowest functional tests by 18-35% via `keypoolrefill()` (master...wallet_fundrawtransaction_speedup) https://github.com/bitcoin/bitcoin/pull/26722
<bitcoin-git>
[bitcoin] brunoerg opened pull request #26721: test, lint: add `crypted` to `ignore-words` (master...2022-12-fix-codespell-walletload) https://github.com/bitcoin/bitcoin/pull/26721
<bitcoin-git>
[bitcoin] furszy opened pull request #26720: wallet: coin selection, don't return results that exceed the max allowed weight (master...2022_coin_selection_weight) https://github.com/bitcoin/bitcoin/pull/26720
<Murch1>
The Bitcoin Core wallet should really keep track of its UTXO pool instead of recalculating it from its list of transactions every time it needs it
<sipa>
e.g. you know that any signature that your bitcoin core wallet will be involved in, will have access to that wallet's private key
<bitcoin-git>
[bitcoin] achow101 opened pull request #26715: Introduce `MockableDatabase` for wallet unit tests (master...test-wallet-corrupt) https://github.com/bitcoin/bitcoin/pull/26715
<bitcoin-git>
[bitcoin] brunoerg opened pull request #26714: test: add coverage for unparsable `-maxuploadtarget` (master...2022-12-maxuploadtarget-parse-test) https://github.com/bitcoin/bitcoin/pull/26714
<sdaftuar>
_aj_: i think you'll run into the same issues we have in Bitcoin Core's logic wrt DoS. fundamentally we don't have a total ordering on transaction desirability, and that leads to the DoS concerns we have
<bitcoin-git>
[bitcoin] JeremyRubin closed pull request #22876: [TESTS] Update Transaction Tests to permit setting a flag as always on and disabling the exhaustive failure test (master...update-txvalid-json) https://github.com/bitcoin/bitcoin/pull/22876
<bitcoin-git>
[bitcoin] JeremyRubin closed pull request #23309: [WIP] Add a basic python REST API Server Wrapper (master...rest-python) https://github.com/bitcoin/bitcoin/pull/23309
<bitcoin-git>
[bitcoin] JeremyRubin closed pull request #22954: [TESTS] Allow tx_invalid.json tests to include flag rules for if_unset: [A,B,C] then_unset: [D] (master...if_unset_then_unset) https://github.com/bitcoin/bitcoin/pull/22954