<BlueMatt[m]>
so, kinda annoying that no flush happens if bitcoin core is idle for an hour, but ultimately the issue could also appear in prod if there's a reorg while a node that just crashed is offline
<BlueMatt[m]>
the issue was basically that some folks were running bitcoin core on regtest and calling `generatetoaddress`, some software was seeing the block, persisting its "latest chain tip", then the bitcoin node was crashing (even after an hour, but basically docker container shutdown was just kill'ing) and on restart the block was gone. the aforementioned software would then later load its "latest chain tip", not have any idea where that
<bitcoin-git>
[bitcoin] jamesob opened pull request #26419: log: mempool: log removal reason in validation interface (master...2022-10-log-mempool-removal-reason) https://github.com/bitcoin/bitcoin/pull/26419
<bitcoin-git>
[bitcoin] achow101 opened pull request #26418: Fix signing of multi_a and rawtr scripts with wallets that only have corresponding keys (master...fix-psbt-multia) https://github.com/bitcoin/bitcoin/pull/26418
2022-10-28
<bitcoin-git>
[bitcoin] mzumsande opened pull request #26417: test: fix intermittent failure in feature_index_prune.py (master...202210_testfix_indexprune) https://github.com/bitcoin/bitcoin/pull/26417
<bitcoin-git>
[bitcoin] achow101 closed pull request #26416: Initialize optional members of ChainstateManagerOpts to nullopt (master...fix-warnings) https://github.com/bitcoin/bitcoin/pull/26416
<bitcoin-git>
[bitcoin] achow101 opened pull request #26416: Initialize optional members of ChainstateManagerOpts to nullopt (master...fix-warnings) https://github.com/bitcoin/bitcoin/pull/26416
<bitcoin-git>
[bitcoin] achow101 closed pull request #24975: bench: remove from available_coins with reference, vout size (master...pool_bench) https://github.com/bitcoin/bitcoin/pull/24975
<bitcoin-git>
[bitcoin] andrewtoth opened pull request #26415: rpc,rest: read raw block in getblock verbosity 0 and rest_block bin and hex (master...read-raw-block) https://github.com/bitcoin/bitcoin/pull/26415
<josie[m]>
id start contributing to the bitcoin GUI if we had built in tetris :D
<laanwj>
fjahr: hah yes... a long time ago there used to be this awful system that paid out per commit... this encouraged a lot of people to try to get *something* into bitcoin core, the most trivial and cosmetic changes
<achow101>
luke-jr: I think org owners are also the only ones that can add new members? and also migrate repos in/out of the org (e.g. we might want to move libmultiprocess into bitcoin-core)
<luke-jr>
FWIW, lack of bitcoin org ownership prevented me from adding Kalle to the bips repo a while back, but I'm not sure I want that kind of access (in terms of becoming a possible target)
<achow101>
speaking of permissions, of the current owners of the bitcoin and bitcoin-core orgs, only 1 is a current maintainer, the rest former
<jonatack>
lightlike: that twitter poll only had 160 respondants; it may be interesting to do one from an account with more reach like the bitcoin core org one
<bitcoin-git>
[bitcoin] achow101 closed pull request #26349: rpc: make `address` field optional `list{transactions, sinceblock}` response (master...issue_26338) https://github.com/bitcoin/bitcoin/pull/26349
<bitcoin-git>
[bitcoin] glozow merged pull request #26382: [24.x] p2p: Handle IsContinuationOfLowWorkHeadersSync return value correctly when new headers sync is started (24.x...2022-10-backport-26355) https://github.com/bitcoin/bitcoin/pull/26382
<bitcoin-git>
[gui] hebasto closed pull request #473: Enable a non-linear network traffic option (click to toggle between linear and non-linear) (master...NonLinearTraffic) https://github.com/bitcoin-core/gui/pull/473
<bitcoin-git>
bitcoin/master 25ee74d Sebastian Falbesoner: test: add SipHash implementation for generic data in Python
<bitcoin-git>
[gui] hebasto closed pull request #363: Peers window: Show direction in a new column, with clearer icon (master...qt_peers_directionarrow) https://github.com/bitcoin-core/gui/pull/363
<bitcoin-git>
[bitcoin] achow101 merged pull request #23927: rpc: Pruning nodes can not fetch blocks before syncing past their height (master...2021-12-prunefutureblockfetch) https://github.com/bitcoin/bitcoin/pull/23927
<bitcoin-git>
bitcoin/master faf4487 MacroFake: Move ::nMaxTipAge into ChainstateManager
<bitcoin-git>
bitcoin/master fa29d0b MacroFake: Move ::hashAssumeValid into ChainstateManager
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #26275: Fix crash on deriveaddresses when index is 2147483647 (2^31-1) (master...fix-deriveaddresses-crash) https://github.com/bitcoin/bitcoin/pull/26275
<bitcoin-git>
bitcoin/master cf28837 MacroFake: Merge bitcoin/bitcoin#26275: Fix crash on deriveaddresses when index is 21...
<bitcoin-git>
bitcoin/master 9153ff3 muxator: rpc: add non-regression test about deriveaddresses crash when index is 214...
<bitcoin-git>
bitcoin/master addf9d6 muxator: rpc: fix crash in deriveaddresses when derivation index is 2147483647
<bitcoin-git>
[bitcoin] MarcoFalke reopened pull request #26287: Temporarily disable -mempoolfullrbf for the main chain (master...2210-fullrbf-🚡) https://github.com/bitcoin/bitcoin/pull/26287
<bitcoin-git>
[bitcoin] kcalvinalvin opened pull request #26390: index: Compare deserialized block hash with the block hash from the blockindex (master...2022-07-13-blockfilter-check-block-hash) https://github.com/bitcoin/bitcoin/pull/26390
<ariard>
"The level of support for RBF and LN in the Bitcoin ecosystem" yeah here dual-funding and consort have most faster than last year expecations, I think acinq is thinking to use it in prod soon and we have also LDK users interested by dual-funding/splicing, WIP support, dunno in the CLN ecosystem
<glozow>
If somebody could help get in touch with miners it would be really nice to hear what their plans are and/or what a reasonable timeline could be. It's the biggest missing piece of information for me, but I don't think we can speculate whether/when they'll do something because it's rational or because a Bitcoin Core option makes it easy.
<bitcoin-git>
[bitcoin] hebasto opened pull request #26388: ci: Use macos-ventura-xcode:14.1 image for "macOS native" task (master...221025-ventura) https://github.com/bitcoin/bitcoin/pull/26388
<bitcoin-git>
bitcoin/master 393be86 Hennadii Stepanov: build, msvc: Drop no longer required macro definitions for leveldb
2022-10-24
<bitcoin-git>
[bitcoin] sipa opened pull request #26383: Add feature_taproot case involved invalid internal pubkey (master...202210_invalid_internal) https://github.com/bitcoin/bitcoin/pull/26383
<bytes1440000>
Context: Recent default that is being discussed in some PRs in bitcoin core and on mailing list
<bytes1440000>
I am not sure how useful is this poll with 25 votes but I am not a big twitter influencer. It was about "defaults" in bitcoin projects and kind of mixed response: https://twitter.com/1440000bytes/status/1584311735741140992
<bitcoin-git>
[bitcoin] aureleoules reopened pull request #24865: rpc: Enable wallet import on pruned nodes and add test (master...2022-04-importwallet-pruned) https://github.com/bitcoin/bitcoin/pull/24865
<bitcoin-git>
[bitcoin] aureleoules closed pull request #24865: rpc: Enable wallet import on pruned nodes and add test (master...2022-04-importwallet-pruned) https://github.com/bitcoin/bitcoin/pull/24865
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #26380: Revert "test: check importing wallets when blocks are pruned throw an error" (master...2210-test-revert-📒) https://github.com/bitcoin/bitcoin/pull/26380
<bitcoin-git>
[bitcoin] glozow opened pull request #26382: [24.x] p2p: Handle IsContinuationOfLowWorkHeadersSync return value correctly when new headers sync is started (24.x...2022-10-backport-26355) https://github.com/bitcoin/bitcoin/pull/26382
<bitcoin-git>
[bitcoin] glozow merged pull request #26355: p2p: Handle IsContinuationOfLowWorkHeadersSync return value correctly when new headers sync is started (master...2022-10-nbits-headerssync) https://github.com/bitcoin/bitcoin/pull/26355
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #26378: refactor: Pass reference to last header, not pointer (master...2210-p2p-less-pointers-🍟) https://github.com/bitcoin/bitcoin/pull/26378
<bitcoin-git>
[bitcoin] hebasto opened pull request #26377: test: Make `system_tests/run_command` test locale and platform agnostic (master...221024-nonloc) https://github.com/bitcoin/bitcoin/pull/26377
<bitcoin-git>
bitcoin/22.x 2c6c628 Hennadii Stepanov: Prevent data race for `pathHandlers`
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #26350: [22.x] Revert "build: Use Homebrew's sqlite package if it is available" (22.x...revert_slow_macos_sqlite_22_x) https://github.com/bitcoin/bitcoin/pull/26350
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #26333: [23.x] Revert "build: Use Homebrew's sqlite package if it is available" (23.x...revert_slow_macos_sqlite_23_x) https://github.com/bitcoin/bitcoin/pull/26333
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #26376: test: Use type-safe NodeSeconds for TestMemPoolEntryHelper (master...2210-time-🏾) https://github.com/bitcoin/bitcoin/pull/26376
<bitcoin-git>
[bitcoin] MarcoFalke closed pull request #26361: NO MERGE gui test [skip ci] [ci skip] (master...2210-no-merge-gui-test-🏌) https://github.com/bitcoin/bitcoin/pull/26361
<bitcoin-git>
[gui] MarcoFalke merged pull request #673: Use fallback value for Version and User Agent during peer connection (master...2022-09-display-fallback-for-gui-peers-version-and-user-agent) https://github.com/bitcoin-core/gui/pull/673
<bitcoin-git>
bitcoin/master 8fb3fd2 MacroFake: Merge bitcoin-core/gui#673: Use fallback value for Version and User Agent ...
<bitcoin-git>
bitcoin/master c2a21c0 Jon Atack: gui: use fallback value for Version and User Agent during peer connection
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #26358: doc: Rearrange a few lines in the dependency graph of libraries (master...patch-1) https://github.com/bitcoin/bitcoin/pull/26358
<bitcoin-git>
bitcoin/master 1184a66 Stacie Waleyko: doc: Rearrange some lines in the dependency graph of libraries
<bitcoin-git>
bitcoin/master c056735 MacroFake: Merge bitcoin/bitcoin#26358: doc: Rearrange a few lines in the dependency ...
<sipa>
bitcoin core doesn't require the peer to ping ever, at all
<bitcoin-git>
[bitcoin] andrewtoth opened pull request #26375: validation, zmq: pass block in UpdatedBlockTip to avoid duplicate read (master...no-read-zmq) https://github.com/bitcoin/bitcoin/pull/26375
<bitcoin-git>
[bitcoin] fanquake merged pull request #26302: refactor: Use type-safe time point for CWallet::m_next_resend (master...2210-wallet-time-🤗) https://github.com/bitcoin/bitcoin/pull/26302
<ariard>
that type of PR: https://github.com/bitcoin/bitcoin/pull/25434#issuecomment-1288227190 blocked on lot of context across layers, let me think that it could be interesting to have a board/wiki page on "Mempool" subjects and to know if progress is blocked on the mailing list/meeting discussions/conceptual code review/lack of review bandwidth etc
<sipa>
i suspect bitcoin core has always done this, but other implementations may or may not have relied on the assumption that it always is
<bitcoin-git>
[bitcoin] hebasto opened pull request #26372: build, msvc: Drop no longer required macro definitions for leveldb (master...221023-msvc-cleanup) https://github.com/bitcoin/bitcoin/pull/26372
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #26248: net: Set relay in version msg to peers with relay permission in -blocksonly mode (master...2210-version-relay-🥐) https://github.com/bitcoin/bitcoin/pull/26248
<bitcoin-git>
[bitcoin] aureleoules closed pull request #25903: Use static member functions from class instead of instances (master...2022-08-tidy-use-static-functions) https://github.com/bitcoin/bitcoin/pull/25903
<bitcoin-git>
[bitcoin] fanquake opened pull request #26360: build: remove threadinterrupt from libbitcoinkernel (master...kernel_remove_threadinterrupt) https://github.com/bitcoin/bitcoin/pull/26360
<bitcoin-git>
[bitcoin] fanquake merged pull request #25727: util, config: error on startup if `conf` or `reindex` are set in config file (master...josibake-update-config-errors) https://github.com/bitcoin/bitcoin/pull/25727
<bitcoin-git>
bitcoin/master 6bcd7e2 Andrew Chow: wallet: Correctly check ismine for sendall
<bitcoin-git>
bitcoin/master 708b72b Andrew Chow: test: Test that sendall works with watchonly spending specific utxos
<bitcoin-git>
bitcoin/master b132c85 Andrew Chow: wallet: Check utxo prevout index out of bounds in sendall
<bitcoin-git>
[bitcoin] naumenkogs opened pull request #26359: p2p, refactor: #23443 (Erlay support signaling) follow-ups (master...2021-11-erlay1_followup) https://github.com/bitcoin/bitcoin/pull/26359
<bitcoin-git>
[bitcoin] satsie opened pull request #26358: doc: Rearrange a few lines in the dependency graph of libraries (master...patch-1) https://github.com/bitcoin/bitcoin/pull/26358
<NorrinRadd>
ariard i read it. it basically kills zero conf but he also said there's something worse; replacements will be further incentized by changes in exchange rates, where customers will adjust their sats paid lower if bitcoin goes up in price after the purchase was made. which creates business risk for the zero conf merchants.
<glozow>
ariard: my impression is an agreement that it is inevitable, but if it happens before users have a lot of access to LN, it might just make Bitcoin worse
<gribble>
https://github.com/bitcoin/bitcoin/issues/25600 | p2p: Advertise `NODE_FULL_RBF` and connect to 4 outbound full-rbf peers if `-mempoolfullrbf` is set by ariard · Pull Request #25600 · bitcoin/bitcoin · GitHub
<jarolrod>
development on bitcoin-core/gui-qml has been slow, at times it's only been me working on it, but that is where the future of the gui is
<ariard>
achow101: tbh, few contributors have already to live in a multi repo world, in the sense monitoring libsecp256k1, the bips repo, the bolts repo, maybe a lightning implem, maybe bitcoin-inquisition, sounds more a question of personal time-management
<hebasto>
quoting fanquake from oct 15 "I think merging GUI development back into the main repo would quite be a regression. As far as I'm aware, for non-GUI contributors, it's been a great filter for keeping all the not-related-to-bitcoin GUI stuff out of their inboxes (probably similar for the thousands of bitcoin/bitcoin subscribers)."
<achow101>
While I agree that we should want to have components of Bitcoin Core separated into separate repos, I think doing so now is premature. We should perhaps wait until it is possible to fully separate componenets before doing so. That way, cloning the main repo does not fetch the GUI repo, and work on each specific component requires going to each individual repo to even get the code.
<achow101>
contributors as the GUI is in the main repo, so work can be done in a fork of the main repo before realizing that the GUI repo exists. There was also a concern about funding as some funders may not recognize that the GUI repo is in fact part of Bitcoin Core.
<jarolrod>
i don't have a strong opinion on wether we move in the development from bitcoin-core/gui into bitcoin/bitcoin
<bitcoin-git>
[bitcoin] NorrinRadd opened pull request #26356: test: Use a consistent assert functions: ref #23119 (master...issue/23119/part-1) https://github.com/bitcoin/bitcoin/pull/26356
<gribble>
https://github.com/bitcoin/bitcoin/issues/25515 | net, test: Virtualise CConnman and add initial PeerManager unit tests by dergoegge · Pull Request #25515 · bitcoin/bitcoin · GitHub