2022-05-31

<bitcoin-git> bitcoin/22.x d2e0c27 MacroFake: Merge bitcoin/bitcoin#25250: [22.x] test: replace hashlib.ripemd160 with a...
<bitcoin-git> bitcoin/22.x ea3e028 Pieter Wuille: Swap out hashlib.ripemd160 for own implementation
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to 22.x: https://github.com/bitcoin/bitcoin/compare/34cb63e89597...d2e0c27e45ab
<bitcoin-git> bitcoin/22.x 5203691 Pieter Wuille: Add pure Python RIPEMD-160
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25246: Revert "build: more robustly check for fcf-protection support" (master...remove_clang_7_note) https://github.com/bitcoin/bitcoin/pull/25246
<bitcoin-git> bitcoin/master a7973bf fanquake: Revert "build: more robustly check for fcf-protection support"
<bitcoin-git> bitcoin/master bd6c5e4 MacroFake: Merge bitcoin/bitcoin#25246: Revert "build: more robustly check for fcf-pr...
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b9ef5a10e2fa...bd6c5e410829

2022-05-30

<bitcoin-git> [bitcoin] brunoerg opened pull request #25253: test: add coverage for non-hex value to -minimumchainwork (master...2022-05-minimumchainwork-nonhex) https://github.com/bitcoin/bitcoin/pull/25253
<bitcoin-git> bitcoin/master 151009c Hennadii Stepanov: qt, wallet, refactor: Drop unused `WalletModel::PaymentRequestExpired`
<bitcoin-git> bitcoin/master b9ef5a1 Hennadii Stepanov: Merge bitcoin-core/gui#609: wallet, refactor: Drop unused `WalletModel::Pa...
<bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/269fa667f248...b9ef5a10e2fa
<bitcoin-git> [gui] hebasto merged pull request #609: wallet, refactor: Drop unused `WalletModel::PaymentRequestExpired` (master...220529-expired) https://github.com/bitcoin-core/gui/pull/609
<bitcoin-git> [bitcoin] fanquake opened pull request #25251: Consolidate Windows ASLR workarounds for upstream secp256k1 changes (master...libsecp256k1_no_more_static_export) https://github.com/bitcoin/bitcoin/pull/25251
<instagibbs> _aj_, https://github.com/bitcoin/bitcoin/issues/22028 dun dun dunn
<sipa> @theStack Oh, this isn't the *bitcoin* version message, but the version of the transport protocol I'm talking about.
<bitcoin-git> bitcoin/22.x 34cb63e laanwj: Merge bitcoin/bitcoin#25242: [22.x] rpc: Capture potentially large UniValu...
<bitcoin-git> [bitcoin] laanwj merged pull request #25242: [22.x] rpc: Capture potentially large UniValue by ref for rpcdoccheck (22.x...2205-uni-no-copy-📊) https://github.com/bitcoin/bitcoin/pull/25242
<bitcoin-git> bitcoin/22.x 7fcac96 Martin Zumsande: rpc: Capture potentially large UniValue by ref for rpcdoccheck
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to 22.x: https://github.com/bitcoin/bitcoin/compare/04fdd644b43a...34cb63e89597
<bitcoin-git> [bitcoin] laanwj merged pull request #25241: [23.x] rpc: Capture potentially large UniValue by ref for rpcdoccheck (23.x...2205-uni-no-copy-📊) https://github.com/bitcoin/bitcoin/pull/25241
<bitcoin-git> bitcoin/23.x 7fcac96 Martin Zumsande: rpc: Capture potentially large UniValue by ref for rpcdoccheck
<bitcoin-git> bitcoin/23.x c3936cc laanwj: Merge bitcoin/bitcoin#25241: [23.x] rpc: Capture potentially large UniValu...
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to 23.x: https://github.com/bitcoin/bitcoin/compare/fcf6c8f4eb21...c3936cc53dab
<bitcoin-git> [gui] hebasto opened pull request #612: refactor: Drop unused `QFrame`s in `SendCoinsEntry` (master...220530-sendcoins) https://github.com/bitcoin-core/gui/pull/612
<theStack> sipa: thanks, good to know. that explains why there are PRs around implementing elligator squared pubkeys (both in secp256k1 and bitcoin core), but no mention of it in the (obviously outdated) spec i read
<theStack> bip324 question about handshake: in older slides (from breaking bitcoin 2019) i saw it was proposed that only odd pubkeys (i.e. starting with 0x03) are allowed, but the current BIP states only even pubkeys (i.e. starting with 0x02) are. any specific reason for this change?
<sipa> And Bitcoin Core from back then cannot be used unmodified against today's OpenSSL's versions.
<sipa> Well, it didn't happen with Bitcoin Core versions from 2014 linked against OpenSSL from 2014 and before.
<sipa> but i believe that no version of bitcoin core (including very old ones) would emit such encodings
<sipa> there are certainly DER private key encodings that are valid but bitcoin core today wouldn't be able to parse, as it doesn't have a full DER parser
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25250: [22.x] test: replace hashlib.ripemd160 with an own implementation (22.x...2205-backport-ripemd160-👥) https://github.com/bitcoin/bitcoin/pull/25250
<sipa> it's not clear to me whether this is an issue for the bitcoin core codebase at all (includin historical versions)
<DavidBakin> so that means someone with such a wallet can't in fact use a newer bitcoin core to read it?
<div72> laanwj: You're right, I've encountered the issue in a downstream where OpenSSL was still being used. The chances of this affecting Bitcoin is pretty slim as a wallet from a 7y old version which needs to be compiled with a pre 3 recent OpenSSL version is needed.
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25044: test: Use MiniWallet in rpc_rawtransaction.py (master...test_rawtransaction_miniwallet) https://github.com/bitcoin/bitcoin/pull/25044
<bitcoin-git> bitcoin/master 269fa66 MacroFake: Merge bitcoin/bitcoin#25044: test: Use MiniWallet in rpc_rawtransaction.py
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ad9e5eaf77bf...269fa667f248
<bitcoin-git> bitcoin/master e93046c Daniela Brozzoni: MOVEONLY: Move signrawtransactionwithwallet test
<bitcoin-git> bitcoin/master e895900 Daniela Brozzoni: test: Use MiniWallet in rpc_rawtransaction.py
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25249: Bump univalue subtree (master...2205-univalue-🎖) https://github.com/bitcoin/bitcoin/pull/25249
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25248: refactor: Add LIFETIMEBOUND / -Wdangling-gsl to Assert() (master...2205-assert-lifetime-🐜) https://github.com/bitcoin/bitcoin/pull/25248
<gribble> https://github.com/bitcoin/bitcoin/issues/20640 | wallet, refactor: return out-params of CreateTransaction() as optional struct by theStack · Pull Request #20640 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] laanwj merged pull request #24424: doc: release process chainparams updates (master...release-process-chainparams-updates) https://github.com/bitcoin/bitcoin/pull/24424
<bitcoin-git> bitcoin/master 318655c Jon Atack: Add missing references to signet in the release process
<bitcoin-git> bitcoin/master b4d2d74 Jon Atack: Release process: specify blockchain/chain_state units, reduce repetition
<bitcoin-git> bitcoin/master e538ead laanwj: Release process: exclude huge files for mainnet m_assumed_blockchain_size
<bitcoin-git> [bitcoin] laanwj pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/8779adbdda76...ad9e5eaf77bf
<b10c> theStack: not sure if you've seen https://bip324.com/sections/code-review/ (RE https://github.com/bitcoin/bitcoin/pull/24545#issuecomment-1141148561) also not sure if that's up-to-date
<bitcoin-git> [gui] hebasto opened pull request #611: test, refactor: Use the same shutdown path as in bitcoin-qt binary (master...220530-exec2) https://github.com/bitcoin-core/gui/pull/611
<bytes1440000> hebasto: I followed everything from https://github.com/bitcoin/bitcoin/blob/master/doc/build-android.md but still get the same error as shared by achow101 in https://github.com/bitcoin/bitcoin/issues/22522 when compiling with https://github.com/bitcoin/bitcoin/pull/22555
<bitcoin-git> [bitcoin] fanquake opened pull request #25246: Revert "build: more robustly check for fcf-protection support" (master...remove_clang_7_note) https://github.com/bitcoin/bitcoin/pull/25246
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25245: refactor: Remove no-op TIME_INIT on deser (master...2205-no-time-deser-🌗) https://github.com/bitcoin/bitcoin/pull/25245
<bitcoin-git> [bitcoin] fanquake opened pull request #25244: build: pass bdb cppflags only where needed (master...use_bdb_cppflags_needed) https://github.com/bitcoin/bitcoin/pull/25244
<gribble> https://github.com/bitcoin/bitcoin/issues/20640 | wallet, refactor: return out-params of CreateTransaction() as optional struct by theStack · Pull Request #20640 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] suhailsaqan opened pull request #25243: test: autogenerate bash completion (master...bash-completion) https://github.com/bitcoin/bitcoin/pull/25243
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25242: [22.x] rpc: Capture potentially large UniValue by ref for rpcdoccheck (22.x...2205-uni-no-copy-📊) https://github.com/bitcoin/bitcoin/pull/25242
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25241: [23.x] rpc: Capture potentially large UniValue by ref for rpcdoccheck (23.x...2205-uni-no-copy-📊) https://github.com/bitcoin/bitcoin/pull/25241
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25233: compat: remove glibcxx sanity checks (master...remove_glibcxx_sanity) https://github.com/bitcoin/bitcoin/pull/25233
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e3b7f10b1066...8779adbdda76
<bitcoin-git> bitcoin/master cc61bc2 fanquake: compat: remove glibcxx sanity checks
<bitcoin-git> bitcoin/master 8779adb MacroFake: Merge bitcoin/bitcoin#25233: compat: remove glibcxx sanity checks
<laanwj> but maybe i'm missing something, or this is an ancient wallet from the time bitcoin's wallet still used openssl?
<bitcoin-git> [bitcoin] fanquake merged pull request #25237: rpc: Capture UniValue by ref for rpcdoccheck (master...202205_rpcdoc_capture) https://github.com/bitcoin/bitcoin/pull/25237
<bitcoin-git> bitcoin/master e3b7f10 fanquake: Merge bitcoin/bitcoin#25237: rpc: Capture UniValue by ref for rpcdoccheck
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b6ab45ae5c91...e3b7f10b1066
<bitcoin-git> bitcoin/master 20ff499 Martin Zumsande: rpc: Capture potentially large UniValue by ref for rpcdoccheck
<laanwj> div72: how do you even get a foreign key into that function? i don't think it's considered an issue because afaik, that function is only used for loading wallets, and it only supports the keys generated by bitcoin core itself
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25204: rpc: remove deprecated top-level fee fields from mempool entries (master...202205-rpc-remove_deprecated_top_level_fee_fields) https://github.com/bitcoin/bitcoin/pull/25204
<bitcoin-git> bitcoin/master b6ab45a MacroFake: Merge bitcoin/bitcoin#25204: rpc: remove deprecated top-level fee fields f...
<bitcoin-git> bitcoin/master 885694d Sebastian Falbesoner: doc: add release note about removal of `deprecatedrpc=fees` flag
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/fb7437f66f9d...b6ab45ae5c91
<bitcoin-git> bitcoin/master 387ae8b Sebastian Falbesoner: rpc: remove deprecated fee fields from mempool entries
<bitcoin-git> [bitcoin] 1440000bytes closed pull request #25236: wallet: use vector instead of list for transactions (master...listtx-memory) https://github.com/bitcoin/bitcoin/pull/25236

2022-05-29

<bitcoin-git> [bitcoin] fanquake merged pull request #25231: ci: Install documented packages for "Win64" CI task (master...220528-posix) https://github.com/bitcoin/bitcoin/pull/25231
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ba48fcf4a40c...fb7437f66f9d
<bitcoin-git> bitcoin/master 3ffc190 Hennadii Stepanov: ci: Install documented packages for "Win64" CI task
<bitcoin-git> bitcoin/master fb7437f fanquake: Merge bitcoin/bitcoin#25231: ci: Install documented packages for "Win64" C...
<bitcoin-git> [bitcoin] telberrak closed pull request #25240: log Nonce (master...master) https://github.com/bitcoin/bitcoin/pull/25240
<bitcoin-git> [bitcoin] telberrak reopened pull request #25240: log Nonce (master...master) https://github.com/bitcoin/bitcoin/pull/25240
<bitcoin-git> [bitcoin] telberrak closed pull request #25240: log Nonce (master...master) https://github.com/bitcoin/bitcoin/pull/25240
<bitcoin-git> [bitcoin] telberrak opened pull request #25240: log Nonce (master...master) https://github.com/bitcoin/bitcoin/pull/25240
<bitcoin-git> [bitcoin] kristapsk closed pull request #25238: script: Disable SC1004 check in `contrib/devtools/gen-bitcoin-conf.sh` (master...shellcheck-disable=SC1004) https://github.com/bitcoin/bitcoin/pull/25238
<bitcoin-git> [bitcoin] furszy opened pull request #25239: wallet: 'CommitTransaction', remove extra wtx lookup and add exception for db write error (master...2022_wallet_CommitTransaction_extra_lookup) https://github.com/bitcoin/bitcoin/pull/25239
<bitcoin-git> [gui] hebasto opened pull request #610: wallet: Detect `DuplicateAddress` earlier (master...220529-dupaddr) https://github.com/bitcoin-core/gui/pull/610
<bitcoin-git> [bitcoin] kristapsk opened pull request #25238: script: Disable SC1004 check in `contrib/devtools/gen-bitcoin-conf.sh` (master...shellcheck-disable=SC1004) https://github.com/bitcoin/bitcoin/pull/25238
<bitcoin-git> [gui] hebasto opened pull request #609: qt, wallet, refactor: Drop unused `WalletModel::PaymentRequestExpired` (master...220529-expired) https://github.com/bitcoin-core/gui/pull/609
<bitcoin-git> [gui] hebasto opened pull request #608: qt, wallet, refactor: Make `WalletModel::sendCoins()` return `void` (master...220529-sendcoins) https://github.com/bitcoin-core/gui/pull/608
<bitcoin-git> [bitcoin] mzumsande opened pull request #25237: rpc: Capture UniValue by ref for rpcdoccheck (master...202205_rpcdoc_capture) https://github.com/bitcoin/bitcoin/pull/25237

2022-05-28

<bitcoin-git> [bitcoin] 1440000bytes opened pull request #25236: wallet: use vector instead of list for transactions (master...listtx-memory) https://github.com/bitcoin/bitcoin/pull/25236
<bitcoin-git> [bitcoin] amadeuszpawlik opened pull request #25235: GetExternalSigner(): fail if multiple signers are found (master...fail_with_multiple_ext_signers) https://github.com/bitcoin/bitcoin/pull/25235
<bitcoin-git> [bitcoin] furszy opened pull request #25234: bench: add benchmark for wallet 'AvailableCoins' function. (master...2022_bench_wallet_available_coins) https://github.com/bitcoin/bitcoin/pull/25234
<bitcoin-git> [bitcoin] fanquake opened pull request #25233: compat: remove glibcxx sanity checks (master...remove_glibcxx_sanity) https://github.com/bitcoin/bitcoin/pull/25233
<bitcoin-git> [bitcoin] AaronDewes opened pull request #25232: Faster getblock API (master...perf/faster-getblock) https://github.com/bitcoin/bitcoin/pull/25232
<bitcoin-git> [bitcoin] hebasto opened pull request #25231: ci: Install documented packages for "Win64" CI task (master...220528-posix) https://github.com/bitcoin/bitcoin/pull/25231
<bitcoin-git> [bitcoin] hebasto reopened pull request #20728: ci: Fix COMMIT_RANGE variable value for cloned repos (master...201220-cirrus) https://github.com/bitcoin/bitcoin/pull/20728
<bitcoin-git> [bitcoin] fanquake merged pull request #25224: Get time less often in AddrManImpl::ResolveCollisions_() (master...2205-time-less-🐠) https://github.com/bitcoin/bitcoin/pull/25224
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/345457b542b6...ba48fcf4a40c
<bitcoin-git> bitcoin/master fa27ee8 MarcoFalke: Get time less often in AddrManImpl::ResolveCollisions_()
<bitcoin-git> bitcoin/master ba48fcf fanquake: Merge bitcoin/bitcoin#25224: Get time less often in AddrManImpl::ResolveCo...
<gribble> https://github.com/bitcoin/bitcoin/issues/20728 | ci: Fix COMMIT_RANGE variable value for cloned repos by hebasto · Pull Request #20728 · bitcoin/bitcoin · GitHub
<DavidBakin> it does, it's just a fork of bitcoin/bitcoin - oh wait, i read something in the cirrus ci docs that it _only pulls your branch_ that triggered it - let me investigate

2022-05-27

<bitcoin-git> [bitcoin] jamesob opened pull request #25228: test: add BIP-125 rule 5 testcase with default mempool (master...2022-05-bip125-rule5-test) https://github.com/bitcoin/bitcoin/pull/25228
<fanquake> davidbakin: you can just run the scripts locally, in the exact same many as the ci: https://github.com/bitcoin/bitcoin/tree/master/ci
<DavidBakin> huh. i just want to be able to, for example, pass lint and win64 on my own rather than wait for bitcoin/bitcoin to find it in my PR. thanks!
<_aj_> omg, setting up CI for a bitcoin fork is easy now? <3 you guys
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25227: Return empty vector on invalid hex encoding (master...2205-reject-non-hex-🌲) https://github.com/bitcoin/bitcoin/pull/25227
<bitcoin-git> [bitcoin] fanquake merged pull request #25214: multiprocess build fix: ipc/capnp/init.capnp.h: No such file or directory (master...pr/mpdep) https://github.com/bitcoin/bitcoin/pull/25214
<bitcoin-git> bitcoin/master 44904aa Ryan Ofsky: multiprocess build cleanup: comment on manual dependencies
<bitcoin-git> bitcoin/master 345457b fanquake: Merge bitcoin/bitcoin#25214: multiprocess build fix: ipc/capnp/init.capnp....
<bitcoin-git> bitcoin/master 6e1c16c Ryan Ofsky: multiprocess build fix: ipc/capnp/init.capnp.h: No such file or directory
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/3ba6dd6f4bb4...345457b542b6
<gribble> https://github.com/bitcoin/bitcoin/issues/5 | Make the version number the protocol version and not the client version · Issue #5 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24408: rpc: add rpc to get mempool txs spending specific prevouts (master...get-mempool-spending-tx) https://github.com/bitcoin/bitcoin/pull/24408
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/57bf12523cf9...3ba6dd6f4bb4
<bitcoin-git> bitcoin/master 4185570 t-bast: Add RPC to get mempool txs spending outputs
<bitcoin-git> bitcoin/master 3ba6dd6 MacroFake: Merge bitcoin/bitcoin#24408: rpc: add rpc to get mempool txs spending spec...
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24934: refactor, miner: Delete call to UpdatePackagesForAdded at beginning of addPackageTxs (master...2022-04-delete-UpdatePackagesForAdded) https://github.com/bitcoin/bitcoin/pull/24934
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/66bb4df41059...57bf12523cf9
<bitcoin-git> bitcoin/master 7036cf5 KevinMusgrave: Delete UpdatePackagesForAdded at beginning of addPackageTxs.
<bitcoin-git> bitcoin/master 57bf125 MacroFake: Merge bitcoin/bitcoin#24934: refactor, miner: Delete call to UpdatePackage...
<jamesob> Oh - the answer is that in the test setup, we manually specify the descendant count limit: https://github.com/jamesob/bitcoin/blob/c5e67be03bb06a5d7885c55db1f016fbf2333fe3/test/functional/feature_rbf.py#L42. So I'm still confused by RBF rule 5.
<jamesob> I'm not understanding why the 26th iteration of this loop doesn't hit a "too many descendants for tx" error, anyone know? https://github.com/jamesob/bitcoin/blob/c5e67be03bb06a5d7885c55db1f016fbf2333fe3/test/functional/feature_rbf.py#L370-L376
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25224: Get time less often in AddrManImpl::ResolveCollisions_() (master...2205-time-less-🐠) https://github.com/bitcoin/bitcoin/pull/25224
<bitcoin-git> [bitcoin] fanquake merged pull request #25201: windeploy: Renewed windows code signing certificate (master...2022-05-win-cert) https://github.com/bitcoin/bitcoin/pull/25201
<bitcoin-git> bitcoin/master 7e9fe6d Andrew Chow: windeploy: Renewed windows code signing certificate
<bitcoin-git> bitcoin/master 66bb4df fanquake: Merge bitcoin/bitcoin#25201: windeploy: Renewed windows code signing certi...
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/77e125c486d0...66bb4df41059
<gribble> https://github.com/bitcoin/bitcoin/issues/21878 | Make all networking code mockable by vasild · Pull Request #21878 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/24356 | refactor: replace CConnman::SocketEvents() with mockable Sock::WaitMany() by vasild · Pull Request #24356 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25217: scripts and tools: update lint-logs.py to detect LogPrintLevel, mention WalletLogPrintf (master...update-logs-linter-script-with-LogPrintLevel) https://github.com/bitcoin/bitcoin/pull/25217
<bitcoin-git> bitcoin/master 77e125c MacroFake: Merge bitcoin/bitcoin#25217: scripts and tools: update lint-logs.py to det...
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c5e67be03bb0...77e125c486d0
<bitcoin-git> bitcoin/master 75848ec Jon Atack: scripts and tools: update lint-logs.py to detect LogPrintLevel()

2022-05-26

<gribble> https://github.com/bitcoin/bitcoin/issues/5 | Make the version number the protocol version and not the client version · Issue #5 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/5 | Make the version number the protocol version and not the client version · Issue #5 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/25065 | [kernel 2c/n] Introduce `kernel::Context`, encapsulate global init/teardown by dongcarl · Pull Request #25065 · bitcoin/bitcoin · GitHub
<laanwj> i guess we should add the next inststallment of bitcoin kernel
<laanwj> 8 blockers, 2 chasing concept ACK in https://github.com/bitcoin/bitcoin/projects/8 currently
<laanwj> welcome to the weekly bitcoin-core-dev IRC meeting
<laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard b10c BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo
<bitcoin-git> [bitcoin] laanwj merged pull request #24032: Add defaults to vDeployments to avoid uninitialized variables (master...202112-deployments) https://github.com/bitcoin/bitcoin/pull/24032
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a0e8aff6051b...c5e67be03bb0
<bitcoin-git> bitcoin/master c4c5b9c Anthony Towns: consensus/params: set default values for BIP9Deployment
<bitcoin-git> bitcoin/master c5e67be laanwj: Merge bitcoin/bitcoin#24032: Add defaults to vDeployments to avoid uniniti...
<bitcoin-git> [bitcoin] dongcarl opened pull request #25223: miner: Make `mempool` optional, stop constructing temporary empty mempools (master...2022-05-kernelargs-mempool-miner) https://github.com/bitcoin/bitcoin/pull/25223
<bitcoin-git> [bitcoin] achow101 merged pull request #25003: tracing: fix `coin_selection:aps_create_tx_internal` calling logic (master...202204-tracing_fix_coin_selection-aps_create_tx_internal_log) https://github.com/bitcoin/bitcoin/pull/25003
<bitcoin-git> bitcoin/master 6b63673 Sebastian Falbesoner: tracing: fix `coin_selection:aps_create_tx_internal` calling logic
<bitcoin-git> bitcoin/master a0e8aff Andrew Chow: Merge bitcoin/bitcoin#25003: tracing: fix `coin_selection:aps_create_tx_in...
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2642dee1364d...a0e8aff6051b
<bitcoin-git> [gui] hebasto closed pull request #492: Show ToolTip on Network Traffic graph (master...NetworkGraphTooltip) https://github.com/bitcoin-core/gui/pull/492
<bitcoin-git> [gui] hebasto closed pull request #484: Don't clear traffic graph when changing interval (master...RetainNetworkGraphOnIntervalChange) https://github.com/bitcoin-core/gui/pull/484
<bitcoin-git> [gui] hebasto closed pull request #435: Move third-party tx URL setting from Display to Wallet options tab (master...move-3partytx-setting) https://github.com/bitcoin-core/gui/pull/435
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #15936: interfaces: Expose settings.json methods to GUI (master...pr/qtset) https://github.com/bitcoin/bitcoin/pull/15936
<bitcoin-git> bitcoin/master 77fabff Ryan Ofsky: init: Remove Shutdown() node.args reset
<bitcoin-git> bitcoin/master f9fdcec Ryan Ofsky: settings: Add resetSettings() method
<bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/48eec3234749...2642dee1364d
<bitcoin-git> bitcoin/master 0e55bc6 Ryan Ofsky: settings: Add update/getPersistent/isIgnored methods
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25222: refactor: Pass reference to LookUpStats (master...2205-ref-stat-😶) https://github.com/bitcoin/bitcoin/pull/25222
<bitcoin-git> [bitcoin] laanwj merged pull request #25216: Doc: Fix parameter in hwm example block (master...patch-1) https://github.com/bitcoin/bitcoin/pull/25216
<bitcoin-git> bitcoin/master 48eec32 laanwj: Merge bitcoin/bitcoin#25216: Doc: Fix parameter in hwm example block
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c324b07a541a...48eec3234749
<bitcoin-git> bitcoin/master 43ff37f mutatrum: Update zmq.md: Fix parameter in hwm example block
<bitcoin-git> [bitcoin] laanwj merged pull request #25210: doc: remove misleading AreInputsStandard() comment (master...2022-05-areinputsstandard-comment) https://github.com/bitcoin/bitcoin/pull/25210
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4901631dac6a...c324b07a541a
<bitcoin-git> bitcoin/master be6d431 James O'Beirne: doc: remove misleading AreInputsStandard() comment
<bitcoin-git> bitcoin/master c324b07 laanwj: Merge bitcoin/bitcoin#25210: doc: remove misleading AreInputsStandard() co...
<bitcoin-git> [bitcoin] laanwj merged pull request #25202: log: Use severity-based logging for leveldb/libevent messages, reverse LogPrintLevel order (master...2022-05-logging-improved) https://github.com/bitcoin/bitcoin/pull/25202
<bitcoin-git> bitcoin/master 18ec120 laanwj: http: Use severity-based logging for messages from libevent
<bitcoin-git> bitcoin/master ce92071 laanwj: leveldb: Log messages from leveldb with category and debug level
<bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/cacbdbaa9531...4901631dac6a
<bitcoin-git> bitcoin/master bd971bf laanwj: logging: Unconditionally log levels >= WARN
<bitcoin-git> [bitcoin] laanwj merged pull request #25132: consensus: Add BIP-341 specified constraints in `ComputeTaprootMerkleRoot` (master...compute-taproot-merkle-root-asserts) https://github.com/bitcoin/bitcoin/pull/25132
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/192d639a6b1b...cacbdbaa9531
<bitcoin-git> bitcoin/master bd7c5e2 David Bakin: Add BIP-341 specified constraints to `ComputeTaprootMerkleRoot`
<bitcoin-git> bitcoin/master cacbdba laanwj: Merge bitcoin/bitcoin#25132: consensus: Add BIP-341 specified constraints ...
<bitcoin-git> [gui] hebasto opened pull request #607: refactor: Skip manual signal disconnection in descructors (master...220526-handler) https://github.com/bitcoin-core/gui/pull/607
<gribble> https://github.com/bitcoin/bitcoin/issues/25201 | windeploy: Renewed windows code signing certificate by achow101 · Pull Request #25201 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] antoinedesbois opened pull request #25221: Improve CMedianFilter algorithm (master...timedata_bench) https://github.com/bitcoin/bitcoin/pull/25221
<bitcoin-git> [bitcoin] brunoerg opened pull request #25220: rpc: fix incorrect warning for address type p2sh-segwit in createmultisig (master...2022-05-fix-incorrect-warning-createmultisig) https://github.com/bitcoin/bitcoin/pull/25220
<jamesob> dongcarl: it's a trick for allowing that annotation to work with nullable locks; it just doesn't enforce anything if there's no lock. See https://github.com/bitcoin/bitcoin/pull/22415#issuecomment-875999127

2022-05-25

<jonatack> dongcarl: if possible, maybe pass a reference that cannot be nullptr (otherwise add an assert?) am thinking of https://github.com/bitcoin/bitcoin/pull/25016/commits/86ce844d3b287012f27c7b0bad6d11c9bdd3120e for example
<bitcoin-git> [bitcoin] achow101 merged pull request #25213: fuzz: fix crash at coinselection, add missing fee rate. (master...2022_fuzz_solve_coinselection) https://github.com/bitcoin/bitcoin/pull/25213
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b4f686952a60...192d639a6b1b
<bitcoin-git> bitcoin/master c97e961 furszy: fuzz: coinselection, add missing fee rate.
<bitcoin-git> bitcoin/master 192d639 Andrew Chow: Merge bitcoin/bitcoin#25213: fuzz: fix crash at coinselection, add missing...
<bitcoin-git> [bitcoin] natanleung opened pull request #25219: test: deploymentinfo.cpp unit tests (master...deploymentinfo_unit_test) https://github.com/bitcoin/bitcoin/pull/25219
<bitcoin-git> [bitcoin] furszy opened pull request #25218: wallet: introduce generic 'Result' classes and connect it to `CreateTransaction` and `GetNewDestination` (master...2022_generic_result) https://github.com/bitcoin/bitcoin/pull/25218
<bitcoin-git> [bitcoin] jonatack opened pull request #25217: scripts and tools: update lint-logs.py with LogPrintLevel() (master...update-logs-linter-script-with-LogPrintLevel) https://github.com/bitcoin/bitcoin/pull/25217
<bitcoin-git> [bitcoin] mutatrum opened pull request #25216: Update zmq.md: Fix parameter in hwm example block (master...patch-1) https://github.com/bitcoin/bitcoin/pull/25216
<bitcoin-git> [bitcoin] dongcarl opened pull request #25215: [kernel 2d/n] Reduce CTxMemPool constructor call sites (master...2022-03-libbitcoinkernel-reduce-mempool-ctor) https://github.com/bitcoin/bitcoin/pull/25215
<bitcoin-git> [bitcoin] ryanofsky opened pull request #25214: libmultiprocess build fix: ipc/capnp/init.capnp.h: No such file or directory (master...pr/mpdep) https://github.com/bitcoin/bitcoin/pull/25214
<bitcoin-git> [bitcoin] furszy opened pull request #25213: fuzz: fix crash at coinselection, add missing fee rate. (master...2022_fuzz_solve_coinselection) https://github.com/bitcoin/bitcoin/pull/25213
<bitcoin-git> [bitcoin] fanquake closed pull request #25212: Create Bitcoin (master...patch-1) https://github.com/bitcoin/bitcoin/pull/25212
<bitcoin-git> [bitcoin] Aw761678 reopened pull request #25212: Create Bitcoin (master...patch-1) https://github.com/bitcoin/bitcoin/pull/25212
<bitcoin-git> [bitcoin] Aw761678 closed pull request #25212: Create Bitcoin (master...patch-1) https://github.com/bitcoin/bitcoin/pull/25212
<bitcoin-git> [bitcoin] Aw761678 opened pull request #25212: Create Bitcoin (master...patch-1) https://github.com/bitcoin/bitcoin/pull/25212
<sipa> TallTim: This channel is about the development of the Bitcoin Core software, an implementation of the Bitcoin protocol. It is not the place to discuss the direction the Bitcoin protocol itself is going.
<gribble> https://github.com/bitcoin/bitcoin/issues/20165 | Only relay Taproot spends if next block has it active by sipa · Pull Request #20165 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/15846 | [POLICY] Make sending to future native witness outputs standard by sipa · Pull Request #15846 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] jamesob opened pull request #25210: doc: remove misleading AreInputsStandard() comment (master...2022-05-areinputsstandard-comment) https://github.com/bitcoin/bitcoin/pull/25210
<jamesob> I've noticed that future witness version pubkeys are considered standard: https://github.com/jamesob/bitcoin/blob/fcf6c8f4eb217763545ede1766831a6b93f583bd/src/script/standard.cpp#L172-L176. I'm kind of surprised by that, because I would have figured once we introduce a new witness version, we wouldn't want unupgraded nodes relaying the new
<bitcoin-git> [bitcoin] laanwj merged pull request #25197: contrib: Remove keys that are no longer used for merging (master...220524-keys) https://github.com/bitcoin/bitcoin/pull/25197
<bitcoin-git> bitcoin/master d4b3dc5 Hennadii Stepanov: contrib: Remove keys that are no longer used for merging
<bitcoin-git> bitcoin/master b4f6869 laanwj: Merge bitcoin/bitcoin#25197: contrib: Remove keys that are no longer used ...
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8c721fff3a00...b4f686952a60
<bitcoin-git> [bitcoin] laanwj merged pull request #25180: [22.x] qt: Avoid crash on startup if int specified in settings.json (22.x...pr/setint22) https://github.com/bitcoin/bitcoin/pull/25180
<bitcoin-git> bitcoin/22.x 344537c Ryan Ofsky: qt: Avoid crash on startup if int specified in settings.json
<bitcoin-git> bitcoin/22.x 04fdd64 laanwj: Merge bitcoin/bitcoin#25180: [22.x] qt: Avoid crash on startup if int spec...
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to 22.x: https://github.com/bitcoin/bitcoin/compare/cb13ba6d1172...04fdd644b43a
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #22956: validation: log CChainState::CheckBlockIndex() consistency checks (master...CheckBlockIndex-logging) https://github.com/bitcoin/bitcoin/pull/22956
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25192: test: add coverage for unknown value to -blockfilterindex (master...2022-05-unknown-blockfilter) https://github.com/bitcoin/bitcoin/pull/25192
<bitcoin-git> bitcoin/master 8c721ff MacroFake: Merge bitcoin/bitcoin#25192: test: add coverage for unknown value to -bloc...
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bd57b4e0c01b...8c721fff3a00
<bitcoin-git> bitcoin/master 295ff61 brunoerg: test: add coverage for unknown -blockfilterindex
<bitcoin-git> [bitcoin] fanquake merged pull request #24757: build, ci: add `DEBUG_LOCKCONTENTION` to --enable-debug and CI (master...add-DEBUG_LOCKCONTENTION-to-enable-debug) https://github.com/bitcoin/bitcoin/pull/24757
<bitcoin-git> bitcoin/master bd5dbc3 Jon Atack: doc: update developer notes wrt --enable-debug and DEBUG_LOCKCONTENTION
<bitcoin-git> bitcoin/master 345647c Jon Atack: ci: add DEBUG_LOCKCONTENTION to CI task containing DEBUG_LOCKORDER
<bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/90e49c1ececd...bd57b4e0c01b
<bitcoin-git> bitcoin/master 247d170 Jon Atack: build: add DEBUG_LOCKCONTENTION to --enable-debug configuration
<bitcoin-git> [bitcoin] theStack opened pull request #25204: rpc: remove deprecated top-level fee fields from mempool entries (master...202205-rpc-remove_deprecated_top_level_fee_fields) https://github.com/bitcoin/bitcoin/pull/25204

2022-05-24

<bitcoin-git> [gui] jarolrod closed pull request #585: Replace QRegExp with QRegularExpression (master...qregexp-obsolete) https://github.com/bitcoin-core/gui/pull/585
<bitcoin-git> [gui] jarolrod opened pull request #606: Replace QRegExp with QRegularExpression (master...regexp-obsolete) https://github.com/bitcoin-core/gui/pull/606
<bitcoin-git> [bitcoin] MiranDaniel closed pull request #25182: doc: Fix Markdown formatting (master...master) https://github.com/bitcoin/bitcoin/pull/25182
<bitcoin-git> [bitcoin] jonatack opened pull request #25203: log: de-dupe TOR/I2P/NET category prefixes and update their LogPrintf ones (master...logging-updates) https://github.com/bitcoin/bitcoin/pull/25203
<bitcoin-git> [bitcoin] laanwj opened pull request #25202: log: Use severity-based logging for leveldb/libevent messages (master...2022-05-logging-improved) https://github.com/bitcoin/bitcoin/pull/25202
<bitcoin-git> [bitcoin] laanwj merged pull request #24464: logging: Add severity level to logs (master...log_level) https://github.com/bitcoin/bitcoin/pull/24464
<bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/700808754884...90e49c1ececd
<bitcoin-git> bitcoin/master a829064 klementtan: logging: Add severity level to logs.
<bitcoin-git> bitcoin/master e11cdc9 klementtan: logging: Add log severity level to net.cpp
<bitcoin-git> bitcoin/master 90e49c1 laanwj: Merge bitcoin/bitcoin#24464: logging: Add severity level to logs
<bitcoin-git> [bitcoin] achow101 opened pull request #25201: windeploy: Renewed windows code signing certificate (master...2022-05-win-cert) https://github.com/bitcoin/bitcoin/pull/25201
<bitcoin-git> [bitcoin] Empact opened pull request #25200: doc: Fix spelling errors identified by codespell in coments (master...2022-05-codespell) https://github.com/bitcoin/bitcoin/pull/25200
<bitcoin-git> [bitcoin] laanwj merged pull request #24410: [kernel 2a/n] Split hashing/index `GetUTXOStats` codepaths, decouple from `coinstatsindex` (master...2022-02-libbitcoinkernel-p2-coinstats-minimal) https://github.com/bitcoin/bitcoin/pull/24410
<bitcoin-git> bitcoin/master 52b1939 Carl Dong: kernel: Remove unnecessary blockfilter{index,}.cpp
<bitcoin-git> bitcoin/master 0848db9 Carl Dong: fuzz: Remove useless GetUTXOStats fuzz case
<bitcoin-git> bitcoin/master 1022948 Carl Dong: includes: Remove rpc/util.h -> node/coinstats.h
<bitcoin-git> [bitcoin] laanwj pushed 16 commits to master: https://github.com/bitcoin/bitcoin/compare/88989063705b...700808754884
<bitcoin-git> [bitcoin] hebasto opened pull request #25197: contrib: Remove keys that are no longer used for merging (master...220524-keys) https://github.com/bitcoin/bitcoin/pull/25197
<bitcoin-git> [bitcoin] fanquake closed pull request #25196: Create bitcoin (master...patch-1) https://github.com/bitcoin/bitcoin/pull/25196
<bitcoin-git> [bitcoin] Zphyero opened pull request #25196: Create bitcoin (master...patch-1) https://github.com/bitcoin/bitcoin/pull/25196
<bitcoin-git> bitcoin/master 8898906 Hennadii Stepanov: Merge bitcoin-core/gui#593: Getting ready to Qt 6 (8/n). Use `QRegularExpr...
<bitcoin-git> [bitcoin] hebasto pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/136863443300...88989063705b
<bitcoin-git> bitcoin/master 5c5d8f2 Hennadii Stepanov: qt, test: Add tests for searching in `AddressBookPage` dialog
<bitcoin-git> bitcoin/master e280087 Hennadii Stepanov: qt: Use `QRegularExpression` in `AddressBookSortFilterProxyModel` class
<bitcoin-git> [gui] hebasto merged pull request #593: Getting ready to Qt 6 (8/n). Use `QRegularExpression` in `AddressBookSortFilterProxyModel` class (master...220423-re) https://github.com/bitcoin-core/gui/pull/593
<bitcoin-git> bitcoin/master 31122aa Ryan Ofsky: refactor: Pass interfaces::Node references to OptionsModel constructor
<bitcoin-git> bitcoin/master 1368634 Hennadii Stepanov: Merge bitcoin-core/gui#601: refactor: Pass interfaces::Node references to ...
<bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/aa5cd3cc6d47...136863443300
<bitcoin-git> [gui] hebasto merged pull request #601: refactor: Pass interfaces::Node references to OptionsModel constructor (master...pr/qtnode) https://github.com/bitcoin-core/gui/pull/601
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25149: refactor: Add thread safety annotation to `BanMan::SweepBanned()` (master...220516-bantsa) https://github.com/bitcoin/bitcoin/pull/25149
<bitcoin-git> bitcoin/master ab75388 Hennadii Stepanov: refactor: Remove redundant scope in `BanMan::SweepBanned()`
<bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/44037a29129a...aa5cd3cc6d47
<bitcoin-git> bitcoin/master 3919059 Hennadii Stepanov: refactor: Move code from ctor into private `BanMan::LoadBanlist()`
<bitcoin-git> bitcoin/master 52c0b3e Hennadii Stepanov: refactor: Add thread safety annotation to `BanMan::SweepBanned()`

2022-05-23

<bitcoin-git> [bitcoin] mzumsande opened pull request #25193: indexes: Read the locator's top block during init, allow interaction with reindex-chainstate (master...202205_index_allow_reindex_chainstate) https://github.com/bitcoin/bitcoin/pull/25193
<bitcoin-git> [bitcoin] brunoerg opened pull request #25192: test: add coverage for unknown value to -blockfilterindex (master...2022-05-unknown-blockfilter) https://github.com/bitcoin/bitcoin/pull/25192
<bitcoin-git> [bitcoin] hebasto opened pull request #25191: build: Make `--with-gui=qt6` configure option available on macOS (master...220523-qt6-mac) https://github.com/bitcoin/bitcoin/pull/25191
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25176: Fix frequent -netinfo JSON errors from missing getpeerinfo#relaytxes (master...fix-netinfo-json-errors-from-null-getpeerinfo-relaytxes-field) https://github.com/bitcoin/bitcoin/pull/25176
<bitcoin-git> bitcoin/master a17c5e9 Jon Atack: Rename NetinfoRequestHandler::is_block_relay data member to is_tx_relay
<bitcoin-git> bitcoin/master 44037a2 MacroFake: Merge bitcoin/bitcoin#25176: Fix frequent -netinfo JSON errors from missin...
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/fbb90c44ac8a...44037a29129a
<bitcoin-git> bitcoin/master f0bb7db Jon Atack: Fix frequent -netinfo JSON errors from null getpeerinfo#relaytxes
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25015: test: Use permissions from git in lint-files.py (master...2022-04-lint-permissions-git) https://github.com/bitcoin/bitcoin/pull/25015
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/3368f84c4359...fbb90c44ac8a
<bitcoin-git> bitcoin/master 48d2e80 laanwj: test: Don't use shell=True in `lint-files.py`
<bitcoin-git> bitcoin/master 908fb7e laanwj: test: Use permissions from git in `lint-files.py`
<bitcoin-git> bitcoin/master fbb90c4 MacroFake: Merge bitcoin/bitcoin#25015: test: Use permissions from git in lint-files....
<bitcoin-git> [bitcoin] achow101 merged pull request #25083: Set effective_value when initializing a COutput (master...draft-CalculateEffectiveValue2) https://github.com/bitcoin/bitcoin/pull/25083
<bitcoin-git> bitcoin/master 3368f84 Andrew Chow: Merge bitcoin/bitcoin#25083: Set effective_value when initializing a COutp...
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5ebff43025e4...3368f84c4359
<bitcoin-git> bitcoin/master 6fbb0ed ishaanam: Set effective_value when initializing a COutput
<bitcoin-git> bitcoin/master baa3ddc furszy: doc: add release notes about `getreceivedbylabel` returning an error if th...
<bitcoin-git> bitcoin/master 5ebff43 Andrew Chow: Merge bitcoin/bitcoin#25122: rpc: getreceivedbylabel, return early if no a...
<bitcoin-git> [bitcoin] achow101 merged pull request #25122: rpc: getreceivedbylabel, return early if no addresses were found in the address book (master...2022_RPC_getreceivedbylabel_return_early) https://github.com/bitcoin/bitcoin/pull/25122
<bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/66e3b16b8b10...5ebff43025e4
<bitcoin-git> bitcoin/master 8897a21 furszy: rpc: getreceivedbylabel, don't loop over the entire wallet txs map if no d...
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25184: refactor: Remove defunct attributes.h includes (master...2022-05-attributes-include) https://github.com/bitcoin/bitcoin/pull/25184
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/dfe11a1a7eac...66e3b16b8b10
<bitcoin-git> bitcoin/master 71a8dbe Ben Woosley: refactor: Remove defunct attributes.h includes
<bitcoin-git> bitcoin/master 66e3b16 MacroFake: Merge bitcoin/bitcoin#25184: refactor: Remove defunct attributes.h includes
<bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6d20f4b92090...dfe11a1a7eac
<bitcoin-git> bitcoin/master 252f363 Hennadii Stepanov: qt: Replace `QCoreApplication::quit()` with `QCoreApplication::exit(0)`
<bitcoin-git> bitcoin/master dfe11a1 Hennadii Stepanov: Merge bitcoin-core/gui#586: Getting ready to Qt 6 (6/n). Replace `QCoreApp...
<bitcoin-git> [gui] hebasto merged pull request #586: Getting ready to Qt 6 (6/n). Replace `QCoreApplication::quit()` with `QCoreApplication::exit(0)` (master...220416-quit) https://github.com/bitcoin-core/gui/pull/586
<bitcoin-git> [gui] hebasto closed pull request #440: Do not require restart if overridden option is modified (master...210929-restart) https://github.com/bitcoin-core/gui/pull/440
<bitcoin-git> [bitcoin] fanquake merged pull request #25178: doc: remove passing `--disable-external-signer` in OpenBSD build guide (master...202205-doc-update_openbsd_build_docs_71) https://github.com/bitcoin/bitcoin/pull/25178
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b0e16eb3ac93...6d20f4b92090
<bitcoin-git> bitcoin/master 9ecb0a3 Sebastian Falbesoner: doc: remove passing `--disable-external-signer` in OpenBSD build guide
<bitcoin-git> bitcoin/master 6d20f4b fanquake: Merge bitcoin/bitcoin#25178: doc: remove passing `--disable-external-signe...
<bitcoin-git> [bitcoin] S3RK closed pull request #24580: test: coinselection edge cases (master...coinselection_tests) https://github.com/bitcoin/bitcoin/pull/24580

2022-05-22

<bitcoin-git> bitcoin/master a63b60f Ryan Ofsky: refactor: Add OptionsModel getOption/setOption methods
<bitcoin-git> bitcoin/master b0e16eb Hennadii Stepanov: Merge bitcoin-core/gui#600: refactor: Add OptionsModel getOption/setOption...
<bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/640eb772e556...b0e16eb3ac93
<bitcoin-git> [gui] hebasto merged pull request #600: refactor: Add OptionsModel getOption/setOption methods (master...pr/qtopt) https://github.com/bitcoin-core/gui/pull/600
<bitcoin-git> [gui] hebasto opened pull request #605: Delete splash screen widget early (master...220522-splash) https://github.com/bitcoin-core/gui/pull/605
<bitcoin-git> [bitcoin] trizko closed pull request #25186: Add assertion in example_test.py for chaincode labs assignment (master...ccl-challenge) https://github.com/bitcoin/bitcoin/pull/25186
<bitcoin-git> [bitcoin] trizko opened pull request #25186: Add assertion in example_test.py for chaincode labs assignment (master...ccl-challenge) https://github.com/bitcoin/bitcoin/pull/25186

2022-05-21

<pinheadmz_> These comments "...after removing optional annex": https://github.com/bitcoin/bitcoin/blob/master/src/policy/policy.cpp#L260