<robertspigler>
bitcoin/contrib/seeds/nodes_main.txt, I still don't have any automatic outbound or inbound I2P peers. Is this an issue with preferential peering?
<bitcoin-git>
[bitcoin] sipa opened pull request #26105: Use ReadLE64 in uint256::GetUint64 instead of duplicating logic (master...202209_uint256_readle64) https://github.com/bitcoin/bitcoin/pull/26105
<bitcoin-git>
[bitcoin] Xekyo closed pull request #26104: coin selection: Check whether feerate is higher than long_term_feerate only once (master...2022-09-high-feerate-optimization) https://github.com/bitcoin/bitcoin/pull/26104
<bitcoin-git>
[bitcoin] Xekyo opened pull request #26104: Check whether feerate is higher than long_term_feerate only once (master...2022-09-high-feerate-optimization) https://github.com/bitcoin/bitcoin/pull/26104
<kouloumos>
Great! thank you everyone, I'll look into including 25717 and give progress updates in https://github.com/bitcoin/bitcoin/issues/26092 . Please reach out with ideas and feedback. Thanks!
<bitcoin-git>
[bitcoin] stickies-v opened pull request #26103: refactor: mempool: use CTxMemPool::Limits (master...mempool-simplify-fn-signatures) https://github.com/bitcoin/bitcoin/pull/26103
<kouloumos>
From the release notes ( https://github.com/bitcoin-core/bitcoin-devwiki/wiki/24.0-Release-Notes-draft ), I've already included testing guidance for 4 changes that I think most worthwhile to test and I have 1 pending. I'd appreciate feedback on if you think anything else should be included, and if maybe something can be omitted.
<gribble>
https://github.com/bitcoin/bitcoin/issues/26005 | Wallet: Fix error handling (copy_file failure in RestoreWallet, and in general via interfaces) by luke-jr · Pull Request #26005 · bitcoin/bitcoin · GitHub
<bitcoin-git>
[bitcoin] sipa reopened pull request #26065: i2p: use the same destination type for transient and persistent addresses (master...i2p_transient_addr_type) https://github.com/bitcoin/bitcoin/pull/26065
<bitcoin-git>
[bitcoin] sipa closed pull request #26065: i2p: use the same destination type for transient and persistent addresses (master...i2p_transient_addr_type) https://github.com/bitcoin/bitcoin/pull/26065
<bitcoin-git>
[bitcoin] aureleoules opened pull request #26102: test: test_runner option to run tests in priority (master...2022-09-test-runner-priority) https://github.com/bitcoin/bitcoin/pull/26102
<bitcoin-git>
[bitcoin] theuni opened pull request #26101: script: create V1SigVersion for functions which should only accept taproot/tapscript (master...explicit-v1-scriptver) https://github.com/bitcoin/bitcoin/pull/26101
<fanquake>
if there is anything on https://github.com/bitcoin/bitcoin/milestone/54 that needs notes, or something that will be in 24.x that is missing from the milestone and needs notes, please point it out / add to the wiki etc
<_aj_>
sipa: make `bitcoin-cli getnetworkinfo | jq .bytessent.full-outbound.inv` report cumulative stats (so you still have info after a peer disconnects)?
<bitcoin-git>
[bitcoin] vasild opened pull request #26100: doc: clarify that NetPermissionFlags::Implicit is only about whitelists (master...netperm_implicit_comment) https://github.com/bitcoin/bitcoin/pull/26100
<bitcoin-git>
[bitcoin] fanquake opened pull request #26099: build: remove duplicate / unneeded libs from bench_bitcoin (master...bench_duplicate_linking) https://github.com/bitcoin/bitcoin/pull/26099
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #26084: sendall: check if the maxtxfee has been exceeded (master...sendall_maxtxfee) https://github.com/bitcoin/bitcoin/pull/26084
<bitcoin-git>
bitcoin/master 6f8e381 ishaanam: sendall: check if the maxtxfee has been exceeded
<bitcoin-git>
bitcoin/master 718304d MacroFake: Merge bitcoin/bitcoin#26084: sendall: check if the maxtxfee has been excee...
<bitcoin-git>
[bitcoin] jonatack opened pull request #26095: doc: fix spelling identified by codespell and update ignored words (master...2022-09-14-spelling-updates) https://github.com/bitcoin/bitcoin/pull/26095
<bitcoin-git>
[bitcoin] aureleoules opened pull request #26094: rpc: Return block hash & height in getbalances, gettransaction and getwalletinfo (master...return-blockhash-with-wallet-calls) https://github.com/bitcoin/bitcoin/pull/26094
<vasild>
I am studying Erlay. Is it aiming to optimize the traffic made by inv/tx messages? This is my understanding so far: https://github.com/vasild/bitcoin/wiki/Erlay, I must be missing something because it seems that traffic is just 2.4% from the total traffic. Or my node is giving me skewed results?
<elichai2>
Is there any reason not to implement an allocation free implementation for https://github.com/bitcoin/bitcoin/blob/master/src/consensus/merkle.cpp#L67? it seems like that would be possible via a "recursion" algorithm (traverse down the tree to a leaf, then hash it with its neighbor, go up and then traverse into the sibling, slowly rising up the tree until you get the final root hash)
<bitcoin-git>
[bitcoin] ishaanam opened pull request #26084: sendall: check if the maxtxfee has been exceeded (master...sendall_maxtxfee) https://github.com/bitcoin/bitcoin/pull/26084
2022-09-13
<bitcoin-git>
[bitcoin] glozow closed pull request #26083: Revert "sendall: check if the maxtxfee has been exceeded" (master...revert-26081-sendall_maxtxfee) https://github.com/bitcoin/bitcoin/pull/26083
<bitcoin-git>
[bitcoin] glozow opened pull request #26083: Revert "sendall: check if the maxtxfee has been exceeded" (master...revert-26081-sendall_maxtxfee) https://github.com/bitcoin/bitcoin/pull/26083
<bitcoin-git>
[bitcoin] glozow merged pull request #26081: sendall: check if the maxtxfee has been exceeded (master...sendall_maxtxfee) https://github.com/bitcoin/bitcoin/pull/26081
<bitcoin-git>
[bitcoin] luke-jr opened pull request #26082: RPC/Wallet: Access wallets via interfaces::Wallet (master...rpc_wallet_interfaces) https://github.com/bitcoin/bitcoin/pull/26082
<bitcoin-git>
[bitcoin] ishaanam opened pull request #26081: sendall: check if the maxtxfee has been exceeded (master...sendall_maxtxfee) https://github.com/bitcoin/bitcoin/pull/26081
<bitcoin-git>
[bitcoin] hebasto opened pull request #26079: Revert "doc: note that brew installed qt is not supported" (master...220913-brew) https://github.com/bitcoin/bitcoin/pull/26079
<bitcoin-git>
[bitcoin] brunoerg opened pull request #26078: p2p: return `CSubNet` in `LookupSubNet` (master...2022-09-csubnet-lookup) https://github.com/bitcoin/bitcoin/pull/26078
<gribble>
https://github.com/bitcoin/bitcoin/issues/25858 | psbt: Only include PSBT_OUT_TAP_TREE when the output has a script path by achow101 · Pull Request #25858 · bitcoin/bitcoin · GitHub
<gribble>
https://github.com/bitcoin/bitcoin/issues/25856 | [BugFix] Make PSBT serializations 174 compliant by excluding empty taptree from serialization by JeremyRubin · Pull Request #25856 · bitcoin/bitcoin · GitHub
<bitcoin-git>
[bitcoin] fanquake merged pull request #26070: build: Quiet warnings in symlinked headers installed from homebrew (master...fix-brew-usrlocal) https://github.com/bitcoin/bitcoin/pull/26070
<bitcoin-git>
[bitcoin] Sjors opened pull request #26076: Switch hardened derivation marker to h in descriptors (master...2022/09/descriptors_h) https://github.com/bitcoin/bitcoin/pull/26076
<bitcoin-git>
[bitcoin] fanquake opened pull request #26075: contrib: remove 32bit linux code from release scripts (master...remove_32bit_linux_scripts) https://github.com/bitcoin/bitcoin/pull/26075
<bitcoin-git>
[bitcoin] theuni opened pull request #26070: Quiet warnings in symlinked headers installed from homebrew (master...fix-brew-usrlocal) https://github.com/bitcoin/bitcoin/pull/26070
<sipa>
(from a database of good bitcoin nodes it currently knows about)
<sipa>
@jamesob bitcoin.jonaschnelli.ch pointing to a machine on hetzner is exactly that: jonas' crawler having discovered a bitcoin node running on hetzner's network, and exposing that via dns
<jamesob>
no, I'm saying that bitcoin.jonaschnelli.ch points to a machine on Hetzner
<sipa>
this is not a hetzner user running a seed, i assume, but jonasschnelli's crawler having discovered a bitcoin node on hetzner, and exporting that through his dns seed
<sipa>
but for bitcoin dns seeds it's expected
<jamesob0>
in my syslog: "Sep 12 09:54:13 apu2 dnsmasq[7035]: possible DNS-rebind attack detected: bitcoin.jonasschnelli.ch"
<bitcoin-git>
[bitcoin] aureleoules opened pull request #26066: wallet: Refactor and document CoinControl (master...2022-09-refactor-coincontrol) https://github.com/bitcoin/bitcoin/pull/26066
<bitcoin-git>
[bitcoin] vasild opened pull request #26065: i2p: use the same destination type for transient and persistent addresses (master...i2p_transient_addr_type) https://github.com/bitcoin/bitcoin/pull/26065
<bitcoin-git>
[bitcoin] brunoerg opened pull request #26054: test: verify active chaintip after invalidating an unknown block (master...2022-09-fix-test-invalidateblock) https://github.com/bitcoin/bitcoin/pull/26054
<bitcoin-git>
[bitcoin] furszy opened pull request #26053: rpc: bugfix, 'add_inputs' default value is true unless 'inputs' are provided (master...2022_rpc_wallet_fix_help_add_inputs) https://github.com/bitcoin/bitcoin/pull/26053
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #26040: doc: comment "add only reachable addresses to addrman" (master...onlynet_dns-comment) https://github.com/bitcoin/bitcoin/pull/26040
<bitcoin-git>
bitcoin/master ce42570 Kristaps Kaupe: doc: comment "add only reachable addresses to addrman"
<vasild>
for now I am trying to verify this claim "transaction announcements account for 30–50% of the overall Bitcoin traffic" from the erlay paper (https://arxiv.org/pdf/1905.10518.pdf)
<hebasto>
is a fix of a translation bug, which causes an error on Transifex, supposed to be merged after "string freeze"? (context -- https://github.com/bitcoin-core/gui/pull/664, an my opinion is "yes")
2022-09-08
<bytes1440000>
I am using bitcoin core for wallets. Let me know if there are any issues.
<bytes1440000>
i can't decide what sipa does.. he is humble and one of the best bitcoin devs
<bitcoin-git>
[bitcoin] aureleoules opened pull request #26045: rpc: Optimize serialization disk space of dumptxoutset (master...2022-09-dumputxoset-compact) https://github.com/bitcoin/bitcoin/pull/26045
2022-09-07
<bitcoin-git>
[bitcoin] kristapsk opened pull request #26040: doc: comment "add only reachable addresses to addrman" (master...onlynet_dns-comment) https://github.com/bitcoin/bitcoin/pull/26040
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #26039: rpc: Return RPC_TYPE_ERROR, not RPC_MISC_ERROR on type mismatch (1/2) (master...2209-rpc-type-🔤) https://github.com/bitcoin/bitcoin/pull/26039
<bitcoin-git>
[bitcoin] brunoerg opened pull request #26038: test: invalidating an unknown block throws an error (master...2022-09-unknown-block-invalidate) https://github.com/bitcoin/bitcoin/pull/26038
<bitcoin-git>
[bitcoin] hebasto opened pull request #26037: test: Fix `wallet_{basic,listsinceblock}.py` for BDB-only wallets (master...220907-bdb) https://github.com/bitcoin/bitcoin/pull/26037
<bitcoin-git>
[bitcoin] furszy opened pull request #26021: wallet: bugfix, load a wallet with an unknown/corrupt descriptor causes a fatal error (master...2022_wallet_fix_descriptor_unserialization) https://github.com/bitcoin/bitcoin/pull/26021
<bitcoin-git>
[bitcoin] yancyribbens opened pull request #26020: test: Change coinselection parameter location to make tests independent (master...fix-bnb-search-test-param) https://github.com/bitcoin/bitcoin/pull/26020
<bitcoin-git>
[bitcoin] fanquake opened pull request #26018: guix: consistently use -ffile-prefix-map (master...guix_ffile_prefix_map) https://github.com/bitcoin/bitcoin/pull/26018