2021-02-02

< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19509: Per-Peer Message Capture (master...message-dump) https://github.com/bitcoin/bitcoin/pull/19509
< Kiminuo> Hi, I was thinking that it would be nice to replace: https://github.com/bitcoin/bitcoin/pull/20744/files#diff-2bd57d7fbec4bb262834d155c304ebe15d26f73fea87c75ff273df3529a15510R1819 with a function. So I did https://github.com/bitcoin/bitcoin/pull/21052/files#diff-56faa53f40da7bfc47077d7c93254d0d1f7eba69a3c5d88f67be9505f334178eR42 but this is problematic because it introduces a new circular dependency: fs -> random -> logging -> fs where I add
< bitcoin-git> bitcoin/master f2a77ff Troy Giorshev: Add CaptureMessage
< bitcoin-git> bitcoin/master 4d1a582 Troy Giorshev: Call CaptureMessage at appropriate locations
< bitcoin-git> bitcoin/master dbf779d Troy Giorshev: Clean PushMessage and ProcessMessages
< bitcoin-git> [bitcoin] MarcoFalke pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/1e69800d5e60...384e090f9345
< bitcoin-git> [bitcoin] laanwj merged pull request #21059: Drop boost/preprocessor dependencies (master...210201-macro) https://github.com/bitcoin/bitcoin/pull/21059
< bitcoin-git> bitcoin/master e99db77 Hennadii Stepanov: Drop boost/preprocessor dependencies
< bitcoin-git> bitcoin/master 1e69800 Wladimir J. van der Laan: Merge #21059: Drop boost/preprocessor dependencies
< bitcoin-git> bitcoin/master 12f5028 Hennadii Stepanov: refactor: Move STRINGIZE macro to macros.h
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/f72d80b07af8...1e69800d5e60
< wumpus> I don't think the author needs write permission normally for cirrus builds we have these enabled for all PRs on bitcoin
< real_or_random> https://github.com/bitcoin-core/secp256k1/pull/889 cirrus ci doesn't build this PR. I suspect because the author doesn't have write permission.
< gribble> https://github.com/bitcoin/bitcoin/issues/17245 | wallet: Remove Boost from DecodeDumpTime by elichai · Pull Request #17245 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake opened pull request #21064: refactor: use std::shared_mutex & remove Boost Thread (master...use_std_shared_mutex) https://github.com/bitcoin/bitcoin/pull/21064
< bitcoin-git> [bitcoin] S3RK opened pull request #21063: wallet, rpc: update listdescriptors response format (master...listdescriptors_format) https://github.com/bitcoin/bitcoin/pull/21063
< gribble> https://github.com/bitcoin/bitcoin/issues/21051 | Fix -Wmismatched-tags warnings by hebasto · Pull Request #21051 · bitcoin/bitcoin · GitHub

2021-02-01

< bitcoin-git> [gui] RandyMcMillan opened pull request #208: docs: update README notes for /interfaces (master...interfaces-notes) https://github.com/bitcoin-core/gui/pull/208
< gribble> https://github.com/bitcoin/bitcoin/issues/21051 | Fix -Wmismatched-tags warnings by hebasto · Pull Request #21051 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] cdecker opened pull request #21056: rpc: Add a `-rpcwaittimeout` parameter to limit time spent waiting (master...rpcwait-timeout) https://github.com/bitcoin/bitcoin/pull/21056
< bitcoin-git> [bitcoin] dongcarl opened pull request #21055: [Bundle 3/n] Prune remaining g_chainman usage in validation functions (master...2020-09-reduce-validation-ccsactiveglobal-usage) https://github.com/bitcoin/bitcoin/pull/21055
< bitcoin-git> [bitcoin] theStack opened pull request #21053: rpc, test: document {previous,next}blockhash as optional (master...2021-rpc-test-document-previousnextblockhash-as-optional) https://github.com/bitcoin/bitcoin/pull/21053
< bitcoin-git> [bitcoin] laanwj merged pull request #20464: refactor: Treat CDataStream bytes as uint8_t (master...2011-dataStream) https://github.com/bitcoin/bitcoin/pull/20464
< bitcoin-git> bitcoin/master fada14b MarcoFalke: Treat CDataStream bytes as uint8_t
< bitcoin-git> bitcoin/master faa96f8 MarcoFalke: Remove unused CDataStream methods
< bitcoin-git> bitcoin/master fa8bdb0 MarcoFalke: refactor: Drop CDataStream constructors in favor of one taking a Span of b...
< bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/56fcf93349c3...2c0fc856a6b0
< bitcoin-git> [bitcoin] laanwj merged pull request #21026: doc: Document use of make-tag script to make tags (master...2021-01-make-tag) https://github.com/bitcoin/bitcoin/pull/21026
< bitcoin-git> bitcoin/master 56fcf93 Wladimir J. van der Laan: Merge #21026: doc: Document use of make-tag script to make tags
< bitcoin-git> bitcoin/master cc30dfb Wladimir J. van der Laan: doc: Document use of make-tag script to make tags
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d0d256536cdf...56fcf93349c3
< bitcoin-git> [bitcoin] laanwj closed pull request #20951: doc: APS explanation clarified in 0.21.0 release notes (master...patch-1) https://github.com/bitcoin/bitcoin/pull/20951
< bitcoin-git> [bitcoin] kiminuo opened pull request #21052: [draft] refactor: Replace fs::unique_path with GetUniquePath(path) calls (master...feature/fs-unique-path) https://github.com/bitcoin/bitcoin/pull/21052
< bitcoin-git> [bitcoin] hebasto opened pull request #21051: Fix -Wmismatched-tags warnings (master...210201-warning) https://github.com/bitcoin/bitcoin/pull/21051
< bitcoin-git> [bitcoin] laanwj merged pull request #21016: refactor: remove boost::thread_group usage (master...remove_boost_threadgroup) https://github.com/bitcoin/bitcoin/pull/21016
< bitcoin-git> bitcoin/master dc8be12 fanquake: refactor: remove boost::thread_group usage
< bitcoin-git> bitcoin/master d0d2565 Wladimir J. van der Laan: Merge #21016: refactor: remove boost::thread_group usage
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/44f4bcd302d6...d0d256536cdf
< bitcoin-git> [gui] hebasto closed pull request #87: Choose monospaced font in C++ code rather in `*.ui` file (master...200910-mono) https://github.com/bitcoin-core/gui/pull/87
< bitcoin-git> [gui] hebasto opened pull request #207: scripted-diff: Use Courier New as tabular figures font in Overview page (master...210201-mono) https://github.com/bitcoin-core/gui/pull/207
< bitcoin-git> [bitcoin] laanwj merged pull request #20749: [Bundle 1/n] Prune g_chainman usage related to ::LookupBlockIndex (master...2020-09-libbitcoinruntime-v4) https://github.com/bitcoin/bitcoin/pull/20749
< bitcoin-git> bitcoin/master eae54e6 Carl Dong: scripted-diff: Use BlockManager::LookupBlockIndex
< bitcoin-git> bitcoin/master 15d20f4 Carl Dong: validation: Move LookupBlockIndex to BlockManager
< bitcoin-git> bitcoin/master f92dc65 Carl Dong: validation: Guard the active_chainstate with cs_main
< bitcoin-git> [bitcoin] laanwj pushed 18 commits to master: https://github.com/bitcoin/bitcoin/compare/636e754a8175...44f4bcd302d6
< bitcoin-git> [gui] jonatack opened pull request #206: Display fRelayTxes and bip152_highbandwidth_{to, from} in peer details (master...add-fields-to-peer-details) https://github.com/bitcoin-core/gui/pull/206
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20941: rpc: document RPC_TRANSACTION_ALREADY_IN_CHAIN exception (master...rpcman-sendrawtx) https://github.com/bitcoin/bitcoin/pull/20941
< bitcoin-git> bitcoin/master 636e754 MarcoFalke: Merge #20941: rpc: document RPC_TRANSACTION_ALREADY_IN_CHAIN exception
< bitcoin-git> bitcoin/master 74d23bf Jarol Rodriguez: rpc: document RPC_TRANSACTION_ALREADY_IN_CHAIN exception
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/87394b6741df...636e754a8175
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20868: validation: remove redundant check on pindex (master...redundant-check-validation) https://github.com/bitcoin/bitcoin/pull/20868
< bitcoin-git> bitcoin/master c943282 jarolrod: validation: remove redundant check on pindex
< bitcoin-git> bitcoin/master 87394b6 MarcoFalke: Merge #20868: validation: remove redundant check on pindex
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7dc4807691b9...87394b6741df
< bitcoin-git> [bitcoin] meshcollider merged pull request #20040: wallet: Refactor OutputGroups to handle fees and spending eligibility on grouping (master...inner-groupoutputs) https://github.com/bitcoin/bitcoin/pull/20040
< bitcoin-git> bitcoin/master 99b399a Andrew Chow: Move fee setting of OutputGroup to Insert
< bitcoin-git> bitcoin/master 2acad03 Andrew Chow: Remove OutputGroup non-default constructors
< bitcoin-git> bitcoin/master 6148a8a Andrew Chow: Move GroupOutputs into SelectCoinsMinConf
< bitcoin-git> [bitcoin] meshcollider pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/4c55f92c7644...7dc4807691b9
< bitcoin-git> [bitcoin] S3RK opened pull request #21049: Add release notes for listdescriptors RPC (master...patch-1) https://github.com/bitcoin/bitcoin/pull/21049
< bitcoin-git> [bitcoin] EthanHeilman opened pull request #21045: [wip] build: adds switch to enable/disable randomized base address in MSVC builds (master...winnoaslr) https://github.com/bitcoin/bitcoin/pull/21045

2021-01-31

< bitcoin-git> [bitcoin] practicalswift opened pull request #21043: net: Avoid UBSan warning in ProcessMessage(...) (master...ubsan-nTime) https://github.com/bitcoin/bitcoin/pull/21043
< bitcoin-git> [bitcoin] fjahr closed pull request #19168: Refactor: Improve setup_clean_chain semantics (master...test_chain) https://github.com/bitcoin/bitcoin/pull/19168
< bitcoin-git> [bitcoin] fjahr opened pull request #21042: doc, test: Improve setup_clean_chain documentation (master...scc-docs) https://github.com/bitcoin/bitcoin/pull/21042
< bitcoin-git> [bitcoin] practicalswift opened pull request #21041: log: Move "Pre-allocating up to position 0x[…] in […].dat" log message to debug category (master...pre-allocation-up-to-position-0xff-in-foo.dat) https://github.com/bitcoin/bitcoin/pull/21041
< Talkless> Would "getwhitepaper [directory]" RPC for retrieving bitcoin.pdf (using https://bitcoinhackers.org/@jb55/105595146491662406 technique, working for pruned nodes) be considered "waste of reviewer time" ? :)
< bitcoin-git> [gui] hebasto opened pull request #205: Save/restore TransactionView and recentRequestsView tables column sizes (master...210131-header) https://github.com/bitcoin-core/gui/pull/205
< bitcoin-git> [gui] hebasto opened pull request #204: Drop buggy TableViewLastColumnResizingFixer class (master...210131-resize) https://github.com/bitcoin-core/gui/pull/204
< bitcoin-git> [bitcoin] kootoopas opened pull request #21040: wallet: Fix already-being-loaded message grammar (master...fix-wallet-being-loaded-error-message) https://github.com/bitcoin/bitcoin/pull/21040
< bitcoin-git> [bitcoin] fanquake opened pull request #21039: refactor: don't throw in GetChainName() (master...dont_throw_getchainname) https://github.com/bitcoin/bitcoin/pull/21039
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20954: test: Declare `nodes` type in test_framework.py. (master...feature/202101-test_framework-types) https://github.com/bitcoin/bitcoin/pull/20954
< bitcoin-git> bitcoin/master 4c55f92 MarcoFalke: Merge #20954: test: Declare `nodes` type in test_framework.py.
< bitcoin-git> bitcoin/master 5353b0c Kiminuo: Change type definitions for "chain" and "setup_clean_chain" from type comm...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1f514332eda2...4c55f92c7644
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21037: fuzz: Avoid designated initialization (C++20) in fuzz tests (master...c++20-false-start) https://github.com/bitcoin/bitcoin/pull/21037
< bitcoin-git> bitcoin/master 1f51433 MarcoFalke: Merge #21037: fuzz: Avoid designated initialization (C++20) in fuzz tests
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/16b784d95336...1f514332eda2
< bitcoin-git> bitcoin/master dee2d6f practicalswift: fuzz: Avoid designated initialization (C++20) in fuzz tests
< bitcoin-git> [bitcoin] wodry closed pull request #20582: [doc] Fix documentation of options onlynet and listenonion (master...patch-1) https://github.com/bitcoin/bitcoin/pull/20582

2021-01-30

< dr_orlovsky> so the task is to copy strings from bitcoin repo into transifex?
< dr_orlovsky> The file in bitcoin repo is a correct translation. What is the master source: transifex or the repo?
< sipa> well bitcoin core (and several other software) accepts bech32 v1+ addresses for sending
< bitcoin-git> [gui] jonatack reopened pull request #201: gui: ensure inbound block relay peers have relevant services (master...inbound-block-relay) https://github.com/bitcoin-core/gui/pull/201
< bitcoin-git> [gui] jonatack closed pull request #201: gui: ensure inbound block relay peers have relevant services (master...inbound-block-relay) https://github.com/bitcoin-core/gui/pull/201
< bitcoin-git> [gui] jonatack opened pull request #203: gui: display plain "Inbound" in peer details, add #162/#163 release notes (master...display-plain-inbound-and-add-release-notes) https://github.com/bitcoin-core/gui/pull/203
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #21038: Merge pull request #1 from bitcoin/master (master...master) https://github.com/bitcoin/bitcoin/pull/21038
< bitcoin-git> [bitcoin] FndNur1Labs opened pull request #21038: Merge pull request #1 from bitcoin/master (master...master) https://github.com/bitcoin/bitcoin/pull/21038
< bitcoin-git> [bitcoin] practicalswift opened pull request #21037: fuzz: Avoid designated initialization (C++20) in fuzz tests (master...c++20-false-start) https://github.com/bitcoin/bitcoin/pull/21037
< bitcoin-git> [bitcoin] fanquake opened pull request #21036: gitian: Bump descriptors to Focal for 22.0 (master...gitian_bump_22_0) https://github.com/bitcoin/bitcoin/pull/21036

2021-01-29

< bitcoin-git> [bitcoin] ryanofsky opened pull request #21035: Remove pointer cast in CRPCTable::dumpArgMap (master...pr/argmap) https://github.com/bitcoin/bitcoin/pull/21035
< dongcarl> sipa: This is also why we can't just use the bitcoin-core package currently in Guix :-)
< sipa> dongcarl: so is it fair to say that guix (and the binaries it builds) are all living in their own little world, and are unconventional in that they're all built to live the... but what we want for the bitcoin core release builds isn't so much building something that lives there, but using the guix-world stuff to build a "normal" binary?
< dongcarl> roconnor: Right, nix and guix binaries both share this trait of doing the -rpath and setting a weird dynamic linker. Both these behaviours are thoroughly reverted in the Bitcoin Core guix build
< core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
< core-meetingbot> Meeting started Fri Jan 29 19:38:36 2021 UTC. The chair is jonasschnelli. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
< gribble> https://github.com/bitcoin/bitcoin/issues/20205 | wallet: Properly support a wallet id by achow101 · Pull Request #20205 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19136 | wallet: add parent_desc to getaddressinfo by achow101 · Pull Request #19136 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj merged pull request #20689: contrib: replace binary verification script verify.sh with python rewrite (master...202012-contrib-replace-verify-binaries-script-with-python) https://github.com/bitcoin/bitcoin/pull/20689
< bitcoin-git> bitcoin/master 16b784d Wladimir J. van der Laan: Merge #20689: contrib: replace binary verification script verify.sh with p...
< bitcoin-git> bitcoin/master c86b9a6 Sebastian Falbesoner: contrib: remove verify.sh
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c8b83510f42c...16b784d95336
< bitcoin-git> bitcoin/master c84838e Sebastian Falbesoner: contrib: binary verification script verify.sh rewritten in python
< gribble> https://github.com/bitcoin/bitcoin/issues/16546 | External signer support - Wallet Box edition by Sjors · Pull Request #16546 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19145 | Add hash_type MUHASH for gettxoutsetinfo by fjahr · Pull Request #19145 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19136 | wallet: add parent_desc to getaddressinfo by achow101 · Pull Request #19136 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20391 | wallet: introduce setfeerate (an improved settxfee, in sat/vB) by jonatack · Pull Request #20391 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20040 | wallet: Refactor OutputGroups to handle fees and spending eligibility on grouping by achow101 · Pull Request #20040 · bitcoin/bitcoin · GitHub
< meshcollider> #bitcoin-core-dev Wallet Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik petertodd
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #20630: Allow providing local signatures in gitian osx signer (master...2020/12/macos_gitian_signer) https://github.com/bitcoin/bitcoin/pull/20630
< bitcoin-git> [bitcoin] fanquake closed pull request #21031: Merge #20724: Cleanup of -debug=net log messages (master...crazy) https://github.com/bitcoin/bitcoin/pull/21031
< bitcoin-git> [bitcoin] RonSherfey opened pull request #21031: Merge #20724: Cleanup of -debug=net log messages (master...crazy) https://github.com/bitcoin/bitcoin/pull/21031
< bitcoin-git> [bitcoin] fanquake opened pull request #21030: refactor: move load block thread into ChainstateManager (master...revive_marco_val_loadblock_thread) https://github.com/bitcoin/bitcoin/pull/21030
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20724: Cleanup of -debug=net log messages (master...202012-net-log-cleanup) https://github.com/bitcoin/bitcoin/pull/20724
< bitcoin-git> bitcoin/master 1230210 Anthony Towns: net_processing: additional debug logging for ignored messages
< bitcoin-git> bitcoin/master f7edea3 Anthony Towns: net: make debug logging conditional on -debug=net
< bitcoin-git> bitcoin/master a410ae8 Anthony Towns: net, net_processing: log disconnect reasons with -debug=net
< bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/40dd757bf6ce...c8b83510f42c
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21012: ci: Fuzz with integer sanitizer (master...2101-fuzzIntSan) https://github.com/bitcoin/bitcoin/pull/21012
< bitcoin-git> bitcoin/master 40dd757 MarcoFalke: Merge #21012: ci: Fuzz with integer sanitizer
< bitcoin-git> bitcoin/master faff399 MarcoFalke: ci: Fuzz with integer sanitizer
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bc5f26d4eee5...40dd757bf6ce
< bitcoin-git> [gui] MarcoFalke merged pull request #139: doc: Improve gui/src/qt README.md (master...improve-qt-readme) https://github.com/bitcoin-core/gui/pull/139
< bitcoin-git> bitcoin/master bc5f26d MarcoFalke: Merge bitcoin-core/gui#139: doc: Improve gui/src/qt README.md
< bitcoin-git> bitcoin/master 5d1f260 Jarol Rodriguez: Improve gui/src/qt README.md
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e21338292015...bc5f26d4eee5
< bitcoin-git> [gui] RandyMcMillan opened pull request #202: peers-tab: bug fix right panel toggle (master...peers-tab-sidepanel) https://github.com/bitcoin-core/gui/pull/202
< bitcoin-git> [bitcoin] luke-jr opened pull request #21029: bitcoin-cli: Correct docs (no "generatenewaddress" exists) (master...cli_doc_geNnewaddr) https://github.com/bitcoin/bitcoin/pull/21029
< bitcoin-git> [bitcoin] luke-jr opened pull request #21028: doc/bips: Add BIPs 44, 49, and 84 (master...bips_44-49-84) https://github.com/bitcoin/bitcoin/pull/21028

2021-01-28

< bitcoin-git> [gui] jonatack opened pull request #201: gui: ensure inbound block relay peers have relevant services (master...inbound-block-relay) https://github.com/bitcoin-core/gui/pull/201
< bitcoin-git> [bitcoin] laanwj merged pull request #20963: gitian-linux: Build binaries for 64-bit POWER (continued) (master...2021-01-power) https://github.com/bitcoin/bitcoin/pull/20963
< bitcoin-git> bitcoin/master 00f67c8 Luke Dashjr: gitian-linux: Build binaries for 64-bit POWER
< bitcoin-git> bitcoin/master 798bc0b Luke Dashjr: Support glibc-back-compat on 64-bit POWER
< bitcoin-git> bitcoin/master 63fc2b1 Luke Dashjr: gitian: Properly quote arguments in wrappers
< bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/80e16cadd56c...6a726cb534ed
< luke-jr> MarcoFalke: can you please upstream https://github.com/bitcoin-core/univalue/pull/24 ?
< gribble> https://github.com/bitcoin/bitcoin/issues/21025 | validation: Guard the active_chainstate with cs_main by dongcarl · Pull Request #21025 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj opened pull request #21026: doc: Document use of make-tag script to make tags (master...2021-01-make-tag) https://github.com/bitcoin/bitcoin/pull/21026
< luke-jr> MarcoFalke: aha, it was a libevent dep for just bitcoin-tx builds
< luke-jr> wumpus: a trusted Bitcoin Core source repo
< wumpus> luke-jr: have you seen https://github.com/bitcoin-core/bitcoin-maintainer-tools#gitian-verify ? it makes things much easier
< MarcoFalke> when building a tag, the archive looks like `bitcoin-22.0.tar.gz`, not `bitcoin-fffffff.targ.gz`
< dongcarl> Since that one-liner includes src/bitcoin-f1694757ddbc.tar.gz, it does commit to the bitcoin source
< dongcarl> Here's the way fanquake and I have been verifying our outputs: https://github.com/bitcoin/bitcoin/pull/17920#issuecomment-765109583
< warren> There is a way however for users to opt-out of automatic distro upgrades. The .rpm distributed by bitcoincore.org would be identical to the package distributed by Fedora except the Epoch number is higher. That way the Fedora package will never be seen as "newer". It retains the property desired by Bitcoin Core project that nobody is forced into automatic upgrades.
< wumpus> luke-jr: otoh if the guix trusted base is compromised so will the bitcoin core binaries
< aj> MarcoFalke: bitcoin's not going in stream/rhel, surely
< warren> 1) Bitcoin Core switch to Guix for release builds (when possible ... Guix is missing some of the architectures?) I believe we want a replacement for what Gitian used to do including exporting a particular tag from git, naming and versioning the output tarballs, anything else?
< warren> I will not be able to stop them from distributing not-deterministic Bitcoin Core for much longer.
< warren> A bit concerning to me is Fedora is again approaching possible packaging and distribution of Bitcoin Core. While the openssl-based risk is now eliminated, I now intend to package Guix for Fedora and use that to make binary identical builds. I think I can handle the Fedora specific parts of this. But Guix for Bitcoin Core releases is still missing a few parts of what Gitian used to do?
< ariard> but yeah libmultiprocess should be moved under bitcoin-core
< gribble> https://github.com/bitcoin/bitcoin/issues/21025 | validation: Guard the active_chainstate with cs_main by dongcarl · Pull Request #21025 · bitcoin/bitcoin · GitHub
< aj> re 19160, it needs rebase? also is there any roadmap for libmultiprocessing, it's out of tree, but seems pretty bitcoin specific? has it really been reviewed much?
< gribble> https://github.com/bitcoin/bitcoin/issues/20391 | wallet: introduce setfeerate (an improved settxfee, in sat/vB) by jonatack · Pull Request #20391 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19820 | Transactions propagation design goals · Issue #19820 · bitcoin/bitcoin · GitHub
< warren> Suggested Topic: A bit concerning to me is Fedora is again approaching possible packaging and distribution of Bitcoin Core. While the openssl-based risk is now eliminated, I now intend to package Guix for Fedora and use that to make binary identical builds. I think I can handle the Fedora specific parts of this. But Guix for Bitcoin Core releases is still missing a few parts of what Gitian used to do?
< wumpus> https://github.com/bitcoin/bitcoin/projects/8 11 blockers, 1 bugfix, 2 chasing concept ACK
< gribble> https://github.com/bitcoin/bitcoin/issues/19160 | multiprocess: Add basic spawn and IPC support by ryanofsky · Pull Request #19160 · bitcoin/bitcoin · GitHub
< wumpus> #bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik
< bitcoin-git> [bitcoin] dongcarl opened pull request #21025: validation: Guard the active_chainstate with cs_main (master...2021-01-chainman-activechainstate-locking) https://github.com/bitcoin/bitcoin/pull/21025
< bitcoin-git> [bitcoin] laanwj merged pull request #20012: rpc: Remove duplicate name and argNames from CRPCCommand (master...2009-rpcCheckMapping) https://github.com/bitcoin/bitcoin/pull/20012
< bitcoin-git> bitcoin/master fa04f9b MarcoFalke: rpc: Remove duplicate name and argNames from CRPCCommand
< bitcoin-git> bitcoin/master fa92912 MarcoFalke: rpc: Use RPCHelpMan for check-rpc-mappings linter
< bitcoin-git> bitcoin/master faf8356 MarcoFalke: rpc: [refactor] Use concise C++11 code in CRPCConvertTable constructor
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/6ba2ffd28b6b...80e16cadd56c
< vasild> All bugs have been fixed and Bitcoin Core has no issues!
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #21024: appveyor: image: Previous Visual Studio 2019 (master...2101-ciAppveyorPrev) https://github.com/bitcoin/bitcoin/pull/21024
< dongcarl> Anyone experimented with Radicle yet and have a bitcoin-core radicle ID?
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21024: appveyor: image: Previous Visual Studio 2019 (master...2101-ciAppveyorPrev) https://github.com/bitcoin/bitcoin/pull/21024
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21004: contrib: Fix docker args conditional in gitian-build (master...improve-gitian-build-py) https://github.com/bitcoin/bitcoin/pull/21004
< bitcoin-git> bitcoin/master 6ba2ffd MarcoFalke: Merge #21004: contrib: Fix docker args conditional in gitian-build
< bitcoin-git> bitcoin/master 624091b setpill: Fix docker args conditional
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4d5eaf7a90bc...6ba2ffd28b6b
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21023: fuzz: Disable shuffle when merge=1 (master...2101-fuzzMerge) https://github.com/bitcoin/bitcoin/pull/21023
< bitcoin-git> [bitcoin] fanquake opened pull request #21022: [Not for merge] pthread sanity check (master...broken_shared_mutex_sanity_check) https://github.com/bitcoin/bitcoin/pull/21022
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20995: fuzz: Avoid initializing version to less than MIN_PEER_PROTO_VERSION (master...2101-fuzzVersion0) https://github.com/bitcoin/bitcoin/pull/20995
< bitcoin-git> bitcoin/master 4d5eaf7 MarcoFalke: Merge #20995: fuzz: Avoid initializing version to less than MIN_PEER_PROTO...
< bitcoin-git> bitcoin/master fad3d76 MarcoFalke: fuzz: Avoid initializing version to less than MIN_PEER_PROTO_VERSION
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/68692d33c6c5...4d5eaf7a90bc
< bitcoin-git> bitcoin/master fa99e33 MarcoFalke: fuzz: move-only FillNode implementation to cpp file
< bitcoin-git> [bitcoin] fanquake closed pull request #21021: Seems like time... (master...patch-1) https://github.com/bitcoin/bitcoin/pull/21021
< bitcoin-git> [bitcoin] chrismaddern opened pull request #21021: Seems like time... (master...patch-1) https://github.com/bitcoin/bitcoin/pull/21021
< prayank> wumpus: I found only one thing that explains the risks involved in Dandelion on SE: https://bitcoin.stackexchange.com/a/81504/ My issues are mainly related to implementation of the this commit: https://github.com/dandelion-org/bitcoin/commit/d043e36bbe9249a78cf751c80b8d876b7d9f07ea in present code's master branch because lot of things have changed since 2018
< prayank> wumpus: Not sure if I should comment on this but it's been helpful sometimes and for few things I had to ask questions on r/bitcoin and other places.
< wumpus> prayank: i keep being surprised how actually-helpful the bitcoin stackexchange is
< prayank> wumpus: I was trying to experiment with Dandelion and had few issues. Will try again this week and write about all the issues. One basic question was answered by 0xb10c on SE: https://bitcoin.stackexchange.com/questions/99602/dumpmempool-and-loadmempool-in-src-validation-cpp
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #21012: ci: Fuzz with integer sanitizer (master...2101-fuzzIntSan) https://github.com/bitcoin/bitcoin/pull/21012
< gribble> https://github.com/bitcoin/bitcoin/issues/20749 | [Bundle 1/n] Prune g_chainman usage related to ::LookupBlockIndex by dongcarl · Pull Request #20749 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20749 | [Bundle 1/n] Prune g_chainman usage related to ::LookupBlockIndex by dongcarl · Pull Request #20749 · bitcoin/bitcoin · GitHub
< bitcoin-git> [gui] jonasschnelli merged pull request #85: Remove unused "What's This" button in dialogs on Windows OS (master...200907-whatsit) https://github.com/bitcoin-core/gui/pull/85
< bitcoin-git> bitcoin/master ac7ccd6 Hennadii Stepanov: scripted-diff: Remove unused "What's This" button in dialogs on Windows
< bitcoin-git> bitcoin/master 68692d3 Jonas Schnelli: Merge bitcoin-core/gui#85: Remove unused "What's This" button in dialogs o...
< bitcoin-git> bitcoin/master b695148 Hennadii Stepanov: qt: Add flags to prevent a "What's This" button on Windows OS
< bitcoin-git> [bitcoin] jonasschnelli pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/759518354377...68692d33c6c5
< bitcoin-git> bitcoin/master 7595183 Jonas Schnelli: Merge bitcoin-core/gui#72: util: Log static plugins meta data and used sty...
< bitcoin-git> bitcoin/master 957895c Hennadii Stepanov: util: Log static plugins meta data and style
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/02b01651c562...759518354377
< bitcoin-git> [gui] jonasschnelli merged pull request #72: util: Log static plugins meta data and used style (master...200812-log) https://github.com/bitcoin-core/gui/pull/72
< bitcoin-git> bitcoin/master 02b0165 Jonas Schnelli: Merge bitcoin-core/gui#177: Use "fusion" style on macOS Big Sur with old Q...
< bitcoin-git> bitcoin/master 4e1154d Hennadii Stepanov: qt: Use "fusion" style on macOS Big Sur with old Qt
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9deba2de764f...02b01651c562
< bitcoin-git> [gui] jonasschnelli merged pull request #177: Use "fusion" style on macOS Big Sur with old Qt (master...210107-style) https://github.com/bitcoin-core/gui/pull/177
< jonasschnelli> ^ --- ithubmerge.pushmirrors=git@github.com:bitcoin-core/gui.git
< bitcoin-git> [bitcoin] fctorial opened pull request #21020: Add check for gnu sed inplace replace (master...gnu_sed) https://github.com/bitcoin/bitcoin/pull/21020
< sipa> sob3rkid: this channel is for development bitcoin core, a specific implementation of the bitcoin protocol
< gribble> https://github.com/bitcoin/bitcoin/issues/19806 | validation: UTXO snapshot activation by jamesob · Pull Request #19806 · bitcoin/bitcoin · GitHub
< dongcarl> In the meeting on the 14th, people asked jamesob and me to take a look at potential AssumeUTXO and chainman-deglobalization conflicts and if a certain merge order is preferable. Here is the result: https://github.com/bitcoin/bitcoin/pull/19806#issuecomment-768673523
< bitcoin-git> [bitcoin] meshcollider merged pull request #20226: wallet, rpc: add listdescriptors command (master...listdescriptors) https://github.com/bitcoin/bitcoin/pull/20226
< bitcoin-git> bitcoin/master 9deba2d Samuel Dobson: Merge #20226: wallet, rpc: add listdescriptors command
< bitcoin-git> bitcoin/master 647b81b Ivan Metlushko: wallet, rpc: add listdescriptors command
< bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d1ddead09a58...9deba2de764f

2021-01-27

< shesek> I filed an issue for conflicted wallet transactions: https://github.com/bitcoin/bitcoin/issues/21018
< gribble> https://github.com/bitcoin/bitcoin/issues/20892 | tests: Run both descriptor and legacy tests within a single test invocation by achow101 · Pull Request #20892 · bitcoin/bitcoin · GitHub
< S3RK> luke-jr wrt https://github.com/bitcoin/bitcoin/pull/20226#issuecomment-768392164 I've pushed updated test with my comment so it won't fail anymore. Sorry it wasn't clear from my original comment
< bitcoin-git> bitcoin/master f3153dc Jon Atack: gui: improve markup handling of connection type tooltip
< bitcoin-git> bitcoin/master 79a2576 Jon Atack: doc: update ConnectionType Doxygen documentation
< bitcoin-git> bitcoin/master 4f09615 Jon Atack: gui: return inbound {full, block} relay type in peer details
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/15a9df070615...d1ddead09a58
< bitcoin-git> [gui] laanwj merged pull request #180: Peer details: connection type follow-ups (master...peer-details-connection-type-followups) https://github.com/bitcoin-core/gui/pull/180
< bitcoin-git> [bitcoin] laanwj closed pull request #20957: doc: Update tor.md for notes on how to preserve v2 urls (with a not recommended note) (master...tor-controlport-docs) https://github.com/bitcoin/bitcoin/pull/20957
< bitcoin-git> [bitcoin] laanwj merged pull request #20964: rpc: Add specific error code for "wallet already loaded" (master...2021-01-wallet-already-loaded-rpc) https://github.com/bitcoin/bitcoin/pull/20964
< bitcoin-git> bitcoin/master 15a9df0 Wladimir J. van der Laan: Merge #20964: rpc: Add specific error code for "wallet already loaded"
< bitcoin-git> bitcoin/master a6739cc Wladimir J. van der Laan: rpc: Add specific error code for "wallet already loaded"
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/11d3b5833671...15a9df070615
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20757: doc: tor.md and -onlynet help updates (master...tor-md-doc-updates) https://github.com/bitcoin/bitcoin/pull/20757
< bitcoin-git> bitcoin/master 9af99b6 Jon Atack: doc: update/improve automatic tor section of tor.md
< bitcoin-git> bitcoin/master dfc4ce1 saibato: doc: update -proxy, -onion and -onlynet info in tor.md
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/e130ff38c91a...11d3b5833671
< bitcoin-git> bitcoin/master 784a278 Jon Atack: doc: update -onlynet help in src/init.cpp
< vasild> MarcoFalke: wrt https://github.com/jnewbery/bitcoin/pull/18#issuecomment-768216999: -use_value_profile=1 does not make much difference, if any
< bitcoin-git> [bitcoin] fanquake opened pull request #21016: refactor: remove boost::thread_group usage (master...remove_boost_threadgroup) https://github.com/bitcoin/bitcoin/pull/21016
< bitcoin-git> [gui] Bosch-0 opened pull request #199: Added updated bitcoin PNG / SVG icon (master...bitcoin_icon) https://github.com/bitcoin-core/gui/pull/199
< fanquake> It seems quite annoying if GitHub will close issues in the bitcoin-core/gui repo, when I, or potentially anyone else, push to their own repos (fanquake/bitcoin)
< fanquake> I fetched upstream, merged it into my bitcoin fork, then pushed that back to GitHub (fanquake/bitcoin).
< gribble> https://github.com/bitcoin/bitcoin/issues/101 | Shy clients by gavinandresen · Pull Request #101 · bitcoin/bitcoin · GitHub

2021-01-26

< bitcoin-git> [bitcoin] dhruv opened pull request #21015: Make all of net_processing (and some of net) use std::chrono types (master...pr-20044) https://github.com/bitcoin/bitcoin/pull/21015
< sipa> norisgOG: this is getting off topic; there are several answers about this on https://bitcoin.stackexchange.com, and people are probably willing to help on #bitcoin
< norisgOG> I followed the build process in doc/unix-build but its missing the configure: error: libdb_cxx headers missing, Bitcoin Core requires this library for wallet functionality
< bitcoin-git> [bitcoin] stackman27 opened pull request #21014: test: Run mempool_accept.py even with wallet disabled (master...diswallet_mempoolaccept) https://github.com/bitcoin/bitcoin/pull/21014
< vasild> jnewbery: review https://github.com/jnewbery/bitcoin/pull/18 carefully, it looks a bit suspicious to me.
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #21012: ci: Fuzz with integer sanitizer (master...2101-fuzzIntSan) https://github.com/bitcoin/bitcoin/pull/21012
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #20044: Make all of net_processing (and some of net) use std::chrono types (master...202009_chrono_types) https://github.com/bitcoin/bitcoin/pull/20044
< vasild> https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-Current-Priorities -- all entries are from Jan 27, but today is Jan 26.
< gribble> https://github.com/bitcoin/bitcoin/issues/20557 | addrman: Fix new table bucketing during unserialization by jnewbery · Pull Request #20557 · bitcoin/bitcoin · GitHub
< wumpus> jonatack: seems like a nice tool, the only thing i dislike is that it's written in go, i'd managed to avoid having to install a go toolchain on my bitcoin dev VM until now :-)
< jnewbery> ok, let's call the meeting there. Homework for next meeting on Feb 9 is to fill in your priorities in https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-Current-Priorities so we have something to talk about
< gribble> https://github.com/bitcoin/bitcoin/issues/20044 | Make all of net_processing (and some of net) use std::chrono types by sipa · Pull Request #20044 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/26 | Confirmations not appearing for sent coins after recovering wallet from archive · Issue #26 · bitcoin/bitcoin · GitHub
< jnewbery> #bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik petertodd
< jnewbery> wumpus: I have pr -> https://github.com/bitcoin/bitcoin/pull/%s and bc -> https://github.com/bitcoin/bitcoin/search?q=%s . The second one is particularly useful for jumping from a commit hash in git to the commit/PR in github
< gribble> https://github.com/bitcoin/bitcoin/issues/26 | Confirmations not appearing for sent coins after recovering wallet from archive · Issue #26 · bitcoin/bitcoin · GitHub
< jnewbery> Hi folks. We have a p2p meeting in about 25 minutes. Two proposed topics at https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings#26-jan-2021
< aj> wumpus: i setup https://github.com/bitcoin/bitcoin/pull/%s as a bookmark in firefox with the keyword "btc" so i can type "btc 12345" in the url bar to get to PR 12345
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21012: ci: Fuzz with integer sanitizer (master...2101-fuzzIntSan) https://github.com/bitcoin/bitcoin/pull/21012
< gribble> https://github.com/bitcoin/bitcoin/issues/21008 | test: fix zmq test flakiness, improve speed by theStack · Pull Request #21008 · bitcoin/bitcoin · GitHub
< wumpus> viraltaco_: again, #bitcoin please
< bitcoin-git> bitcoin/master e130ff3 MarcoFalke: Merge bitcoin-core/gui#183: Add include for std::bind.
< bitcoin-git> bitcoin/master 2a39ccf sinetek: Add include for std::bind.
< bitcoin-git> [gui] MarcoFalke merged pull request #183: Add include for std::bind. (master...functional) https://github.com/bitcoin-core/gui/pull/183
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5f65f135977e...e130ff38c91a
< bitcoin-git> bitcoin/master 5f65f13 Jonas Schnelli: Merge bitcoin-core/gui#189: qt: drop workaround for QTBUG-42503 which was ...
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d38e2d9a19c9...5f65f135977e
< bitcoin-git> bitcoin/master a2a3f4c Pavol Rusnak: qt: drop workaround for QTBUG-42503 which was fixed in Qt 5.5.0
< bitcoin-git> [gui] jonasschnelli merged pull request #189: qt: drop workaround for QTBUG-42503 which was fixed in Qt 5.5.0 (master...qtbug-42503) https://github.com/bitcoin-core/gui/pull/189
< bitcoin-git> [gui] jonasschnelli merged pull request #186: Add information to "Confirm fee bump" window (master...bump-fee) https://github.com/bitcoin-core/gui/pull/186
< bitcoin-git> bitcoin/master d38e2d9 Jonas Schnelli: Merge bitcoin-core/gui#186: Add information to "Confirm fee bump" window
< bitcoin-git> bitcoin/master 232d1f9 Prayank: Add information to "Confirm fee bump" window
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/32d44d2b1ca3...d38e2d9a19c9
< wumpus> this channel is for development, it is not a general bitcoin related social channel
< wumpus> #bitcoin please
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21000: fuzz: Add UBSan suppressions needed for fuzz tests to not warn under -fsanitize=integer (master...fsanitize-integer) https://github.com/bitcoin/bitcoin/pull/21000
< bitcoin-git> bitcoin/master 32d44d2 MarcoFalke: Merge #21000: fuzz: Add UBSan suppressions needed for fuzz tests to not wa...
< bitcoin-git> bitcoin/master f0f8b1a practicalswift: fuzz: Add UBSan suppressions needed for fuzz tests to not warn under -fsan...
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ce75fc36edc8...32d44d2b1ca3
< bitcoin-git> bitcoin/master 58232e3 practicalswift: fuzz: Avoid -fsanitize=integer warnings in fuzzing harnesses
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20971: test: Work around libFuzzer deadlock (master...2101-fuzzDeadlock) https://github.com/bitcoin/bitcoin/pull/20971
< bitcoin-git> bitcoin/master ce75fc3 MarcoFalke: Merge #20971: test: Work around libFuzzer deadlock
< bitcoin-git> bitcoin/master fa39c8a MarcoFalke: test: Work around libFuzzer deadlock
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cbe439629e2b...ce75fc36edc8