<bitcoin-git>
[bitcoin] fanquake merged pull request #22890: doc: Replace a link to Qt precompiled binaries with compile instructions (master...210904-msvc) https://github.com/bitcoin/bitcoin/pull/22890
<bitcoin-git>
bitcoin/master c4139f0 Hennadii Stepanov: doc: Replace a link to Qt precompiled binaries with compile instructions
<bitcoin-git>
bitcoin/master 5e42f2a Hennadii Stepanov: build: Make <QtBaseDir> default name Qt and VS versions agnostic
<bitcoin-git>
bitcoin/master 6bc4398 Hennadii Stepanov: doc: Suggest using jom instead of nmake
<bitcoin-git>
[gui] MarcoFalke merged pull request #446: RPCConsole: Throw when overflowing size_t type for array indices (master...2110-qtRpcCons) https://github.com/bitcoin-core/gui/pull/446
<bitcoin-git>
[bitcoin] fanquake opened pull request #23203: [POC] build: static musl libc based bitcoind (with LTO) (master...depends_musl_cross_make) https://github.com/bitcoin/bitcoin/pull/23203
<bitcoin-git>
[bitcoin] achow101 opened pull request #23202: wallet: allow psbtbumpfee to work with txs with external inputs (master...bumpfee-ext-inputs) https://github.com/bitcoin/bitcoin/pull/23202
<bitcoin-git>
[bitcoin] fanquake closed pull request #23195: doc: fixes #23073 Updated the Release Process (master...update_release_process) https://github.com/bitcoin/bitcoin/pull/23195
2021-10-05
<bitcoin-git>
[bitcoin] achow101 opened pull request #23201: wallet: Allow users to specify input weights when funding a transaction (master...ext-input-weight) https://github.com/bitcoin/bitcoin/pull/23201
<bitcoin-git>
[bitcoin] meshcollider opened pull request #23200: Fix intermittent failure in wallet_send.py and rpc_fundrawtransaction.py (master...202110_fix_external_tests) https://github.com/bitcoin/bitcoin/pull/23200
<bitcoin-git>
[bitcoin] theStack opened pull request #23199: refactor: use `{Read,Write}BE32` helpers for BIP32 nChild (de)serialization (master...202110-refactor-use_be32_helpers_for_bip32_nchild) https://github.com/bitcoin/bitcoin/pull/23199
<bitcoin-git>
[bitcoin] CallMeMisterOwl opened pull request #23198: build: fixes #23073 Parse version information in msvc-autogen.py (master...auto_gen_issue) https://github.com/bitcoin/bitcoin/pull/23198
<bitcoin-git>
[bitcoin] CallMeMisterOwl closed pull request #23194: build: Parse version information in msvc-autogen.py (master...auto_gen_MSVC_issue) https://github.com/bitcoin/bitcoin/pull/23194
<bitcoin-git>
[bitcoin] jonatack opened pull request #23197: p2p: fix CSubNet::ToString() UBSan and banman fuzz crash (master...fix-netaddress-UB-and-banman-fuzz-crash) https://github.com/bitcoin/bitcoin/pull/23197
<bitcoin-git>
[bitcoin] laanwj opened pull request #23196: util: Make syscall sandbox compilable with kernel 4.4.0 (master...2021-10-syscall-sandbox2) https://github.com/bitcoin/bitcoin/pull/23196
<bitcoin-git>
[bitcoin] CallMeMisterOwl opened pull request #23195: doc: fixes #23073 Updated the Release Process (master...update_release_process) https://github.com/bitcoin/bitcoin/pull/23195
<bitcoin-git>
[bitcoin] CallMeMisterOwl opened pull request #23194: script: fixes #23073 Added new function to build_msvc/msvc-autogen.py (master...auto_gen_MSVC_issue) https://github.com/bitcoin/bitcoin/pull/23194
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #23191: build: Disable -Wbraced-scalar-init, which is incompatible with -Wc++11-narrowing (master...2110-buildW) https://github.com/bitcoin/bitcoin/pull/23191
<bitcoin-git>
[gui] MarcoFalke opened pull request #446: RPCConsole: Throw when overflowing size_t type for array indices (master...2110-qtRpcCons) https://github.com/bitcoin-core/gui/pull/446
<bitcoin-git>
[bitcoin] instagibbs opened pull request #23188: wallet: fund transaction external input cleanups (master...fundtx-external-inputs_cleanups) https://github.com/bitcoin/bitcoin/pull/23188
<bitcoin-git>
[bitcoin] brunoerg closed pull request #23135: test: Use asset_equal utils where possible in feature_nulldummy (master...2021-09-assert_equal) https://github.com/bitcoin/bitcoin/pull/23135
<bitcoin-git>
[bitcoin] MarcoFalke closed pull request #23184: Use stricter ToIntegral over LocaleIndependentAtoi where possible (master...2110-ToIntegral) https://github.com/bitcoin/bitcoin/pull/23184
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #23184: Use stricter ToIntegral over LocaleIndependentAtoi where possible (master...2110-ToIntegral) https://github.com/bitcoin/bitcoin/pull/23184
<jonatack>
right, running this gives an overview: ./src/bitcoin-cli -addrinfo
<jonatack>
note, getnodeaddresses takes a network argument, so can also: ./src/bitcoin-cli getnodeaddresses 0 ipv4 | jq 'map(select(.address | contains(":")))'
<vasild>
Am I the only one? I ran: bitcoin-cli getnodeaddresses 0 |jq 'map(select(.network == "ipv4" and (.address |contains(":"))))'
<prayank>
michaelfolkson: Do you really think I commented anything in this PR that does not make sense? I was not aware of all this else would have completely avoided and let others decide. I won't be reviewing any PR in future for this author in any repository. Also started contributing in Knots so it might help me do better things with less people and peace: https://github.com/bitcoinknots/bitcoin/discussions/39
<glozow>
prayank: I blocked you on my personal github account. It has nothing to do with the repo or maintainers. The help text for blocking a user says "Prevent this user from interacting with your repositories and sending you notifications." I didn't realize it would stop you from commenting on my PR in the Bitcoin Core repo. My apologies to everybody for the confusion.
<bitcoin-git>
bitcoin/master d09071d fanquake: [MOVEONLY] consensus: move amount.h into consensus
<bitcoin-git>
bitcoin/master 863e52f fanquake: consensus: make COIN & MAX_MONEY constexpr
<bitcoin-git>
bitcoin/master 9d0379c fanquake: consensus: use <cstdint> over <stdint.h> in amount.h
<vasild>
prayank: on github (that is not specific to bitcoin) it is possible to lock one PR for everybody (in which case "Conversation was locked..." is displayed). Or it is possible to ban one person from all PRs in a repository. But it is not possible to ban one person from one PR.
<prayank>
Two questions for PR author: 1. Unconfirmed UTXO are discouraged in Core. Does this PR change default behaviour? Context: https://github.com/bitcoin-core/gui/issues/242 2. Why do you think it's not a bug if attacker can confirm a tx with less fee rate by replacing? It can be exploited if we had on chain DeFi but I am not sure what all projects are currently impacted
<bitcoin-git>
[bitcoin] fanquake opened pull request #23182: build: add python3.10 alias to AC_PATH_PROGS call in configure (master...python_3_10_configure) https://github.com/bitcoin/bitcoin/pull/23182
<bitcoin-git>
[bitcoin] PastaPastaPasta opened pull request #23181: refactor: remove references to deprecated values under std::allocator (master...btc-allocator) https://github.com/bitcoin/bitcoin/pull/23181
<bitcoin-git>
[bitcoin] fanquake opened pull request #23179: sandbox: add newfstatat to allowed filesystem syscalls (master...add_newfstatat_to_syscall_exceptions) https://github.com/bitcoin/bitcoin/pull/23179
<bitcoin-git>
bitcoin/master 9e530c6 W. J. van der Laan: Merge bitcoin/bitcoin#20487: Add syscall sandboxing using seccomp-bpf (Lin...
<bitcoin-git>
[bitcoin] jonatack opened pull request #23175: Add CJDNS network to -addrinfo and -netinfo (master...add-cjdns-to-addrinfo-and-netinfo) https://github.com/bitcoin/bitcoin/pull/23175
<bitcoin-git>
[bitcoin] jamesob opened pull request #23174: validation: have LoadBlockIndex account for snapshot use (master...2021-10-au-loadblockindex) https://github.com/bitcoin/bitcoin/pull/23174
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #23052: test: use miniwallet in test_rpc function in feature_rbf.py (master...master) https://github.com/bitcoin/bitcoin/pull/23052
<bitcoin-git>
bitcoin/master a00eb38 Andrew Chow: Allow CInputCoin to also be constructed with COutPoint and CTxOut
<bitcoin-git>
bitcoin/master 38f5642 Andrew Chow: allow fundtx rpcs to work with external inputs
<bitcoin-git>
[bitcoin] darosior opened pull request #23171: qa: test descriptors with mixed xpubs and const pubkeys (master...desc_test_mix) https://github.com/bitcoin/bitcoin/pull/23171
<vincenzopalazzo>
Hello guys, I'm working on #23119 and I decided to slip the work in different PR, I would like to know if this approach is good for the review dev, and you preferer it all at once? My start PR is https://github.com/bitcoin/bitcoin/pull/23127
<bitcoin-git>
[bitcoin] martinus opened pull request #23169: Fix `-Wmaybe-uninitialized` warnings found by building with `-flto` (master...2021-10-fix-Wmaybe-uninitialized-warnings) https://github.com/bitcoin/bitcoin/pull/23169
<gribble>
https://github.com/bitcoin/bitcoin/issues/22154 | Add OutputType::BECH32M and related wallet support for fetching bech32m addresses by achow101 · Pull Request #22154 · bitcoin/bitcoin · GitHub
<gribble>
https://github.com/bitcoin/bitcoin/issues/12119 | [wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH by Sjors · Pull Request #12119 · bitcoin/bitcoin · GitHub
<bitcoin-git>
[bitcoin] fanquake opened pull request #23149: build: make --enable-werror just -Werror (master...make_enable_werror_full_werror) https://github.com/bitcoin/bitcoin/pull/23149
<Guest64>
Guys, hello. Tell me who's in the subject. I send a certain amount of money from Bitcoin Core to a Bitcoin address, the commission is generally acceptable. But the balance of the wallet itself is reduced by an amount that is 42 times more than the amount of funds sent. I canceled the operation. What can be wrong?
<laanwj>
it's fairly easy with make to make a mistake with regard to ordering dependencies which causes issues (either errors or non-determinism) with high parallelism, if you find such a issue with bitcoin core please report it
<sipa>
i build bitcoin core with -j48
<laanwj>
i don't know about useless? bitcoin core's build should have plenty of potential parallelism, i once saw a screenshot of someone building on a 64-core machine, all cores 100%, though probably this won't be the case in the latter parts of the process during linking etc which have to merge a lot of build artifacts
<bitcoin-git>
[bitcoin] jonatack opened pull request #23146: Test transactions conflicted by double spend in listtransactions (master...test-txns-conflicted-by-double-spend-in-listtransactions) https://github.com/bitcoin/bitcoin/pull/23146
<bitcoin-git>
[gui] hebasto merged pull request #342: wallet: Move wallets loading out from the main GUI thread (master...210521-wallet) https://github.com/bitcoin-core/gui/pull/342
<bitcoin-git>
bitcoin/master f9b633e Hennadii Stepanov: qt, wallet: Move activity progress dialog from data member to local
<bitcoin-git>
bitcoin/master 4a024fc Hennadii Stepanov: qt, wallet, refactor: Move connection to QObject::deleteLater to ctor
<bitcoin-git>
bitcoin/master f6991cb Hennadii Stepanov: qt, wallet: Add LoadWalletsActivity class
<TallTim>
I'd like to report using addnode to sync bitcoin core client with my personal full node has sped up my sync time. Thanks again to sipa for the advice.
<bitcoin-git>
bitcoin/master 4446ef0 fanquake: build: remove support for weak linking getauxval()
<bitcoin-git>
bitcoin/master e56100c fanquake: build: remove arm includes from getauxval() check
<bitcoin-git>
bitcoin/master 7f81f54 W. J. van der Laan: Merge bitcoin/bitcoin#23082: build: improve gexauxval() detection, remove ...
<fedecuci>
Hi guys, I am curious, how many people have a very strong understanding of the Bitcoin protocol and source code? I am talking about people that are comfortable with at least 80% of the codebase and would know almost immediately where to go to fix a bug in case it arises. Any estimate?
<bitcoin-git>
bitcoin/master 90be29c Sebastian Falbesoner: wallet: enable SQLite extended result codes
<bitcoin-git>
bitcoin/master 80b4e8f W. J. van der Laan: Merge bitcoin/bitcoin#23112: wallet: enable SQLite extended result codes
<bitcoin-git>
[gui] laanwj merged pull request #336: Do not exit and re-enter main event loop during shutdown (master...210516-loop) https://github.com/bitcoin-core/gui/pull/336
<bitcoin-git>
bitcoin/master 7830cd0 Hennadii Stepanov: qt, refactor: Keep OptionsDialog in the main event loop
<bitcoin-git>
bitcoin/master 59f7ba4 Hennadii Stepanov: qt, refactor: Keep CoinControlDialog in the main event loop
<vasild>
in case anybody is curious how many incoming connections his node is getting (and lazy to type wretched bash commands), assuming debug=net is switched off on the node: bitcoin-cli logging '["net"]' && sleep 3600 && bitcoin-cli logging '[]' '["net"]'
<bitcoin-git>
bitcoin/master f529290 Hennadii Stepanov: Merge bitcoin-core/gui#439: Do not show unused widgets at startup
<bitcoin-git>
bitcoin/master 489060d Hennadii Stepanov: qt: Do not show unused widgets at startup
<vasild>
laanwj: right, a "node" victim.com:80 that never speaks bitcoin p2p would propagate less and fall out of addrmans. So a rate from a well propagated real bitcoin node with public ipv4 address and port 80 would give an upper bound. If that is not high enough to be considered as a dos attack, then a lower number will also not be.
<gribble>
https://github.com/bitcoin/bitcoin/issues/23136 | test: update fee rate assertion helper in the functional test framework by jonatack · Pull Request #23136 · bitcoin/bitcoin · GitHub
<bitcoin-git>
[bitcoin] meshcollider opened pull request #23142: Return false on corrupt tx rather than asserting (master...202109_no_assert_corruption) https://github.com/bitcoin/bitcoin/pull/23142
<michaelfolkson>
jawed: Happened on #bitcoin-dev channel. I'll send a summary and a conversation log to the mailing list
<bitcoin-git>
[bitcoin] meshcollider opened pull request #23141: Fix intermitent failure in wallet_basic.py (master...202109_fix_test_rounding) https://github.com/bitcoin/bitcoin/pull/23141
2021-09-29
<gribble>
https://github.com/bitcoin/bitcoin/issues/22949 | fee: Round up fee calculation to avoid a lower than expected feerate by achow101 · Pull Request #22949 · bitcoin/bitcoin · GitHub
<bitcoin-git>
[gui] hebasto opened pull request #440: Do not require restart if overridden option is modified (master...210929-restart) https://github.com/bitcoin-core/gui/pull/440
<bitcoin-git>
[bitcoin] sipa opened pull request #23140: Make CAddrman::Select_ select buckets, not positions, first (master...202109_addrmanbias) https://github.com/bitcoin/bitcoin/pull/23140
<bitcoin-git>
[bitcoin] jonatack opened pull request #23139: rpc: fix "trusted" field in TransactionDescriptionString(), add coverage (master...fix-rpc-trusted-field-help) https://github.com/bitcoin/bitcoin/pull/23139
<bitcoin-git>
[bitcoin] MarcoFalke closed pull request #23115: bloom: use Span instead of std::vector for `insert` and `contains` (master...18985_rebased) https://github.com/bitcoin/bitcoin/pull/23115
<bitcoin-git>
bitcoin/master 10c6929 Samuel Dobson: Include vout when copying transaction ID from coin selection
<bitcoin-git>
bitcoin/master 8d83f9c Hennadii Stepanov: Merge bitcoin-core/gui#436: Include vout when copying transaction ID from ...
<bitcoin-git>
[gui] hebasto merged pull request #436: Include vout when copying transaction ID from coin selection (master...202109_coinselection_copy_vout) https://github.com/bitcoin-core/gui/pull/436
<bitcoin-git>
[bitcoin] jonatack opened pull request #23136: test: update fee rate assertion helper in the functional test framework (master...update-assert_fee_amount) https://github.com/bitcoin/bitcoin/pull/23136
<bitcoin-git>
bitcoin/master 2ba4ddf William Casarin: bloom: use Span instead of std::vector for `insert` and `contains`