2022-06-08

<bitcoin-git> [bitcoin] ryanofsky opened pull request #25308: refactor: Reduce number of LoadChainstate parameters and return values (master...pr/retcode) https://github.com/bitcoin/bitcoin/pull/25308
<bitcoin-git> [bitcoin] brunoerg opened pull request #25307: doc: fix typo in kernel/context.h and add `desig` to ignore-words (master...2022-06-fix-typo-kernel) https://github.com/bitcoin/bitcoin/pull/25307
<bitcoin-git> [gui] jadijadi opened pull request #615: If -prune=0 is set, Uncheck Prune on Intro page (master...jadi-prune-uncheck) https://github.com/bitcoin-core/gui/pull/615
<bitcoin-git> [bitcoin] jonatack opened pull request #25306: logging: add LogPrintfCategory to log unconditionally with category (master...2022-06-logprintfcategory) https://github.com/bitcoin/bitcoin/pull/25306
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #25304: Revert "ci: Temporarily use clang-13 to work around clang-14 TSan bug" (master...2206-ci-rev-14-💁) https://github.com/bitcoin/bitcoin/pull/25304
<bitcoin-git> [bitcoin] fanquake merged pull request #25096: [net] Minor improvements to addr caching (master...2022-05-improve-addr-cache) https://github.com/bitcoin/bitcoin/pull/25096
<bitcoin-git> bitcoin/master 292828c dergoegge: [test] Test addr cache for multiple onion binds
<bitcoin-git> bitcoin/master f10e80b dergoegge: [net] Use ConnectedThroughNetwork() instead of GetNetwork() to seed addr c...
<bitcoin-git> bitcoin/master 3382905 dergoegge: [net] Seed addr cache randomizer with port from binding address
<bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/bbf2a2504459...b9416c3847cd
<bitcoin-git> [bitcoin] hebasto closed pull request #25305: [WIP] build: Add CMake-based build system (master...cmake/pr) https://github.com/bitcoin/bitcoin/pull/25305
<bitcoin-git> [bitcoin] hebasto opened pull request #25305: [WIP] build: Add CMake-based build system (master...cmake/pr) https://github.com/bitcoin/bitcoin/pull/25305
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25304: Revert "ci: Temporarily use clang-13 to work around clang-14 TSan bug" (master...2206-ci-rev-14-💁) https://github.com/bitcoin/bitcoin/pull/25304
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25303: refactor: Remove redundant addrman time checks (master...2206-less-addrman-time-checks-🚶) https://github.com/bitcoin/bitcoin/pull/25303
<bitcoin-git> [bitcoin] brokenprogrammer opened pull request #25302: build: Check usages of #if defined(...) (master...build-ifdef) https://github.com/bitcoin/bitcoin/pull/25302
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25298: doc: Fix command in "OpenBSD Build Guide" (master...220607-openbsd) https://github.com/bitcoin/bitcoin/pull/25298
<bitcoin-git> bitcoin/master b1f662b Hennadii Stepanov: doc: Fix command in "OpenBSD Build Guide"
<bitcoin-git> bitcoin/master bbf2a25 MacroFake: Merge bitcoin/bitcoin#25298: doc: Fix command in "OpenBSD Build Guide"
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9dae9f5f1e2b...bbf2a2504459

2022-06-07

<bitcoin-git> [bitcoin] Empact opened pull request #25299: doc: Correct comments re. units of constants (master...2022-06-prune-target) https://github.com/bitcoin/bitcoin/pull/25299
<bitcoin-git> [bitcoin] hebasto opened pull request #25298: doc: Fix command in "OpenBSD Build Guide" (master...220607-openbsd) https://github.com/bitcoin/bitcoin/pull/25298
<bitcoin-git> [bitcoin] laanwj merged pull request #25292: Add LogPrintLevel to lint-format-strings, drop LogPrint-vs-LogPrintf section in dev notes (master...update-lint-format-strings-and-dev-notes) https://github.com/bitcoin/bitcoin/pull/25292
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/79cabe3a5b03...9dae9f5f1e2b
<bitcoin-git> bitcoin/master 433b525 Jon Atack: Add LogPrintLevel to lint-format-strings, drop LogPrint-vs-LogPrintf secti...
<bitcoin-git> bitcoin/master 9dae9f5 laanwj: Merge bitcoin/bitcoin#25292: Add LogPrintLevel to lint-format-strings, dro...
<bitcoin-git> [bitcoin] achow101 merged pull request #25239: wallet: 'CommitTransaction', remove extra wtx lookup and add exception for db write error (master...2022_wallet_CommitTransaction_extra_lookup) https://github.com/bitcoin/bitcoin/pull/25239
<bitcoin-git> bitcoin/master 79cabe3 Andrew Chow: Merge bitcoin/bitcoin#25239: wallet: 'CommitTransaction', remove extra wtx...
<bitcoin-git> bitcoin/master 57fb37c furszy: wallet: CommitTransaction, remove extra wtx lookup and add exception for a...
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e282764e0495...79cabe3a5b03
<bitcoin-git> [bitcoin] furszy opened pull request #25297: wallet: speedup transactions sync, rescan and load not flushing to db constantly (master...2022_wallet_unified_dbbatch) https://github.com/bitcoin/bitcoin/pull/25297
<bitcoin-git> [bitcoin] laanwj merged pull request #25228: test: add BIP-125 rule 5 testcase with default mempool (master...2022-05-bip125-rule5-test) https://github.com/bitcoin/bitcoin/pull/25228
<bitcoin-git> bitcoin/master e282764 laanwj: Merge bitcoin/bitcoin#25228: test: add BIP-125 rule 5 testcase with defaul...
<bitcoin-git> bitcoin/master 687adda James O'Beirne: test: add BIP-125 rule 5 testcase with default mempool
<bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d8ae50444882...e282764e0495
<bitcoin-git> bitcoin/master 6120e8e James O'Beirne: test: allow passing sequence through create_self_transfer_multi
<bitcoin-git> [bitcoin] laanwj merged pull request #25245: refactor: Remove no-op TIME_INIT on deser (master...2205-no-time-deser-🌗) https://github.com/bitcoin/bitcoin/pull/25245
<bitcoin-git> bitcoin/master d8ae504 laanwj: Merge bitcoin/bitcoin#25245: refactor: Remove no-op TIME_INIT on deser
<bitcoin-git> bitcoin/master fa243e9 MarcoFalke: Remove no-op TIME_INIT on deser
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/45d8b1e94a8e...d8ae50444882
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25296: Add DataStream without ser-type and ser-version and use it where possible (master...2206-datastream-🎑) https://github.com/bitcoin/bitcoin/pull/25296
<jonatack> Please block Adminsupportteam and remove https://github.com/bitcoin/bitcoin/pull/25293#issuecomment-1148809796
<bitcoin-git> [bitcoin] butterfly1924 opened pull request #25295: Move DEFAULT_ANCESTOR_LIMIT to policy/settings (master...move_the_global_variable_to_policy/settings) https://github.com/bitcoin/bitcoin/pull/25295
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25294: test: Fix wait_for_debug_log UnicodeDecodeError (master...2206-test-emoji-decode-🎲) https://github.com/bitcoin/bitcoin/pull/25294
<bitcoin-git> [bitcoin] butterfly1924 opened pull request #25293: scripted-diff: remove duplicate categories from LogPrint output (master...remove_duplicate_categories_from_logprint_output) https://github.com/bitcoin/bitcoin/pull/25293
<bitcoin-git> [bitcoin] jonatack opened pull request #25292: Add LogPrintLevel to lint-format-strings, drop LogPrint-vs-LogPrintf section in dev notes (master...update-lint-format-strings-and-dev-notes) https://github.com/bitcoin/bitcoin/pull/25292
<hebasto> as laanwj has noted, let's move further discussion into #bitcoin-core-builds
<laanwj> btw no idea if it's bothering anyone but i just realize maybe we should move build system discourse back to #bitcoin-core-build
<bitcoin-git> [bitcoin] akankshakashyap opened pull request #25291: Refactor rpc_fundrawtransaction.py (master...refactor-rpc_fundrawtransaction.py) https://github.com/bitcoin/bitcoin/pull/25291
<hebasto> after building `bitcoin-qt`, I guess :)
<vasild> it compiles now and bitcoin-cli and bitcoind seem to be working
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25286: scripted-diff: remove duplicate categories from LogPrint output (master...remove-duplicate-categories-from-LogPrint-output) https://github.com/bitcoin/bitcoin/pull/25286
<bitcoin-git> bitcoin/master d40550d Jon Atack: scripted-diff: remove duplicate categories from LogPrint output
<bitcoin-git> bitcoin/master 45d8b1e MacroFake: Merge bitcoin/bitcoin#25286: scripted-diff: remove duplicate categories fr...
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2ab4a80480b6...45d8b1e94a8e
<vasild> maybe it is an overkill to link all executables with pthread, does bitcoin-cli use threads?
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25254: Move minRelayTxFee to policy/settings (master...2205-fee-setting-🕹) https://github.com/bitcoin/bitcoin/pull/25254
<bitcoin-git> bitcoin/master 2ab4a80 MacroFake: Merge bitcoin/bitcoin#25254: Move minRelayTxFee to policy/settings
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f66633d9cbe7...2ab4a80480b6
<bitcoin-git> bitcoin/master fa4068b MacroFake: Move minRelayTxFee to policy/settings
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25288: test: Reliably don't start itself (lint-all.py runs all tests twice) (master...2022-06-fix-lint-all-starting-itself) https://github.com/bitcoin/bitcoin/pull/25288
<bitcoin-git> bitcoin/master f66633d MacroFake: Merge bitcoin/bitcoin#25288: test: Reliably don't start itself (lint-all.p...
<bitcoin-git> bitcoin/master 64d72c4 Martin Leitner-Ankerl: test: rename lint-all.py to all-lint.py
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/581e2bdbac6f...f66633d9cbe7
<bitcoin-git> bitcoin/master f26a496 Martin Leitner-Ankerl: test: clean up all-lint.py
<gribble> https://github.com/bitcoin/bitcoin/issues/24148 | Miniscript support in Output Descriptors by darosior · Pull Request #24148 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/3 | Encrypt wallet · Issue #3 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24629: Bugfix: RPC/blockchain: pruneblockchain: Return the height of the actual last pruned block (master...bugfix_rpc_prunebc_retval) https://github.com/bitcoin/bitcoin/pull/24629
<bitcoin-git> bitcoin/master 581e2bd MacroFake: Merge bitcoin/bitcoin#24629: Bugfix: RPC/blockchain: pruneblockchain: Retu...
<bitcoin-git> bitcoin/master e593ae0 Luke Dashjr: Bugfix: RPC/blockchain: pruneblockchain: Return the height of the actual l...
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/06ea2783a2c1...581e2bdbac6f
<bitcoin-git> [bitcoin] dongcarl opened pull request #25290: [kernel 3a/n] Decouple `CTxMemPool` from `ArgsManager` (master...2022-02-libbitcoinkernel-argsman-mempool) https://github.com/bitcoin/bitcoin/pull/25290
<bitcoin-git> [bitcoin] theStack opened pull request #25289: test: implement 'bech32m' mode for `getnewdestination()` helper (master...202206-test-add_bech32m_mode_for_getnewdestination) https://github.com/bitcoin/bitcoin/pull/25289

2022-06-06

<bitcoin-git> [bitcoin] martinus opened pull request #25288: test: Reliably don't start itself in lint-all.py runs all tests twice (master...2022-06-fix-lint-all-starting-itself) https://github.com/bitcoin/bitcoin/pull/25288
<bitcoin-git> [bitcoin] klementtan reopened pull request #23395: util: Add -shutdownnotify option (master...shutdown-notify) https://github.com/bitcoin/bitcoin/pull/23395
<laanwj> hebasto: just tested it and could succesfully build bitcoind and bitcoin-cli (very basic test on Linux)
<bitcoin-git> [bitcoin] klementtan opened pull request #25287: logging: threshold log level (master...threshold_log_level) https://github.com/bitcoin/bitcoin/pull/25287
<bitcoin-git> [bitcoin] jonatack opened pull request #25286: scripted-diff: remove duplicate categories from LogPrint output (master...remove-duplicate-categories-from-LogPrint-output) https://github.com/bitcoin/bitcoin/pull/25286
<bitcoin-git> [bitcoin] klementtan closed pull request #23395: util: Add -shutdownnotify option (master...shutdown-notify) https://github.com/bitcoin/bitcoin/pull/23395
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25285: Add AutoFile without ser-type and ser-version and use it where possible (master...2206-autofile-🌟) https://github.com/bitcoin/bitcoin/pull/25285
<bitcoin-git> [bitcoin] laanwj merged pull request #25220: rpc: fix incorrect warning for address type p2sh-segwit in createmultisig (master...2022-05-fix-incorrect-warning-createmultisig) https://github.com/bitcoin/bitcoin/pull/25220
<bitcoin-git> bitcoin/master 06ea278 laanwj: Merge bitcoin/bitcoin#25220: rpc: fix incorrect warning for address type p...
<bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/e82d8069bcd0...06ea2783a2c1
<bitcoin-git> bitcoin/master eaf6f63 brunoerg: rpc: fix inappropriate warning for address type p2sh-segwit in createmulti...
<bitcoin-git> bitcoin/master 3a9b9bb brunoerg: test: ensure createmultisig and addmultisigaddress are not returning any w...
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25276: doc: Fix typo in importdescriptors (master...patch-13) https://github.com/bitcoin/bitcoin/pull/25276
<bitcoin-git> bitcoin/master e82d806 MacroFake: Merge bitcoin/bitcoin#25276: doc: Fix typo in importdescriptors
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fcde5d130029...e82d8069bcd0
<bitcoin-git> bitcoin/master 210cd59 Kolby Moroz Liebl: doc: Fix typo in importdescriptors
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25255: ci: Improve "ARM64 Android APK" task (master...220531-android) https://github.com/bitcoin/bitcoin/pull/25255
<bitcoin-git> bitcoin/master 8790da3 Hennadii Stepanov: ci: Drop unneeded packages in "ARM64 Android APK" task
<bitcoin-git> bitcoin/master ca0c3e5 Hennadii Stepanov: ci, android: Update Command-line Tools from 2.1 up to 7.0
<bitcoin-git> bitcoin/master 7739438 Hennadii Stepanov: ci, android: Update NDK up to r23c
<bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/1b2e1d179c5b...fcde5d130029
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25284: [WIP] consensus: Remove dependency on net (BIP 155 / ADDRV2_FORMAT) (master...2206-split-consensus-net-😻) https://github.com/bitcoin/bitcoin/pull/25284

2022-06-05

<bitcoin-git> [bitcoin] luke-jr opened pull request #25282: Bugfix: configure: Define default for use_libevent (master...fix_configure_def_use_libevent) https://github.com/bitcoin/bitcoin/pull/25282
<bitcoin-git> [bitcoin] hebasto opened pull request #25281: build: Remove unused `LIBBITCOIN_KERNEL` variable (master...220605-kernel) https://github.com/bitcoin/bitcoin/pull/25281
<bitcoin-git> bitcoin/master 1b2e1d1 Hennadii Stepanov: Merge bitcoin-core/gui#614: Drop no longer supported Android architecture
<bitcoin-git> bitcoin/master d1b7bcb Hennadii Stepanov: qt: Drop no longer supported Android architecture
<bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/695ca641a4e3...1b2e1d179c5b
<bitcoin-git> [gui] hebasto merged pull request #614: Drop no longer supported Android architecture (master...220604-android) https://github.com/bitcoin-core/gui/pull/614
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #25278: . (0.20...0.21) https://github.com/bitcoin/bitcoin/pull/25278
<bitcoin-git> [bitcoin] herculepoirot42 opened pull request #25278: Identify Satoshi Nakamoto in 24 hours (0.20...0.21) https://github.com/bitcoin/bitcoin/pull/25278
<DavidBakin> it then reports ` with coverage = no` and the targets are NOT in the generated makefiles! This used to work - but I just did a pull from bitcoin/bitcoin and picked up about 175 recent commits and now it is broken. Anyone tried it recently?
<bitcoin-git> [bitcoin] KolbyML opened pull request #25276: doc: Fix typo in importdescriptors (master...patch-13) https://github.com/bitcoin/bitcoin/pull/25276

2022-06-04

<bitcoin-git> [bitcoin] fanquake merged pull request #24860: Miniscript integration follow-ups (master...miniscript_updates) https://github.com/bitcoin/bitcoin/pull/24860
<bitcoin-git> bitcoin/master 1ab8d89 Antoine Poinsot: miniscript: make equality operator non-recursive
<bitcoin-git> [bitcoin] fanquake pushed 15 commits to master: https://github.com/bitcoin/bitcoin/compare/aac9c259b045...695ca641a4e3
<bitcoin-git> bitcoin/master c5f65db Antoine Poinsot: miniscript: remove a workaround for a GCC 4.8 bug
<bitcoin-git> bitcoin/master 5922c66 Antoine Poinsot: scripted-diff: miniscript: rename 'nodetype' variables to 'fragment'
<bitcoin-git> [bitcoin] fanquake merged pull request #25065: [kernel 2c/n] Introduce `kernel::Context`, encapsulate global init/teardown (master...2022-03-libbitcoinkernel-initcommon) https://github.com/bitcoin/bitcoin/pull/25065
<bitcoin-git> bitcoin/master fed085a Carl Dong: init: Initialize globals with kernel::Context's life
<bitcoin-git> [bitcoin] fanquake pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/2cf8c2caea90...aac9c259b045
<bitcoin-git> bitcoin/master 7d03fee Carl Dong: kernel: Introduce empty and unused kernel::Context
<bitcoin-git> bitcoin/master eeb4fc2 Carl Dong: test: Use Set/UnsetGlobals in BasicTestingSetup
<bitcoin-git> [bitcoin] LarryRuane opened pull request #25275: [refactor] use ITEMS macro to unify NetMsgType, allNetMessageTypes lists (master...2022-06-ITEMS-macro) https://github.com/bitcoin/bitcoin/pull/25275
<sipa> The python code in https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_taproot.py does generate lots of examples (by signing with a separate python implementation, and checking using bitcoind).
<bitcoin-git> [gui] hebasto opened pull request #614: qt: Drop no longer supported Android architecture (master...220604-android) https://github.com/bitcoin-core/gui/pull/614

2022-06-03

<bitcoin-git> [bitcoin] Crypt-iQ closed pull request #24926: mempool: use mapNextTx.lower_bound in removeRecursive (master...mapnexttx_04192022) https://github.com/bitcoin/bitcoin/pull/24926
<gribble> https://github.com/bitcoin/bitcoin/issues/25065 | [kernel 2c/n] Introduce `kernel::Context`, encapsulate global init/teardown by dongcarl · Pull Request #25065 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] JeremyRubin opened pull request #25274: [WIP] add free list to unordered map (master...wip-freelist) https://github.com/bitcoin/bitcoin/pull/25274
<Murch> I'll be talking about work on the wallet at Bitcoin Plus Plus, so I've been spending some time looking into what's been happening and distilling slides from it
<gribble> https://github.com/bitcoin/bitcoin/issues/25272 | wallet: guard and alert about a wallet invalid state during chain sync by furszy · Pull Request #25272 · bitcoin/bitcoin · GitHub
<achow101> #bitcoin-core-dev Wallet Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack josibake jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos Murch nehan NicolasDorier
<bitcoin-git> [bitcoin] achow101 opened pull request #25273: wallet: Pass through transaction locktime and preset input sequences and scripts to CreateTransaction (master...use-preset-tx-things) https://github.com/bitcoin/bitcoin/pull/25273
<bitcoin-git> [bitcoin] furszy opened pull request #25272: wallet: guard and alert about a wallet invalid state during chain sync (master...2022_wallet_invalid_state) https://github.com/bitcoin/bitcoin/pull/25272
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #25219: test: deploymentinfo.cpp unit tests (master...deploymentinfo_unit_test) https://github.com/bitcoin/bitcoin/pull/25219
<bitcoin-git> [bitcoin] jonatack closed pull request #25271: net: helpfully log in ConnectNode() which peer we are already connected to (master...ConnectNode-say-which-peer-we-are-already-connected-to) https://github.com/bitcoin/bitcoin/pull/25271
<bitcoin-git> [bitcoin] martinus closed pull request #22702: Add allocator for node based containers (master...2019-08-bulkpoolallocator) https://github.com/bitcoin/bitcoin/pull/22702
<bitcoin-git> [bitcoin] jonatack opened pull request #25271: net: helpfully log in ConnectNode() which peer we are already connected to (master...ConnectNode-say-which-peer-we-are-already-connected-to) https://github.com/bitcoin/bitcoin/pull/25271
<bitcoin-git> [bitcoin] fanquake closed pull request #25260: consensus: move version.h into consensus/ (master...move_version_h_into_consensus) https://github.com/bitcoin/bitcoin/pull/25260
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25256: logging: fix logging empty thread name (master...add_leveldb_threadname) https://github.com/bitcoin/bitcoin/pull/25256
<bitcoin-git> bitcoin/master 3a171f7 klementtan: logging: fix logging empty threadname
<bitcoin-git> bitcoin/master 2cf8c2c MacroFake: Merge bitcoin/bitcoin#25256: logging: fix logging empty thread name
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/00ce8543f16f...2cf8c2caea90
<nullcon> Nullcon 2022 CFP closes on Jun 05, 2022. If anyone interested to submit a research related to bitcoin core security or cryptography: https://nullcon.net/goa-2022/cfp/

2022-06-02

<bitcoin-git> [bitcoin] laanwj merged pull request #24171: p2p: Sync chain more readily from inbound peers during IBD (master...2022-01-download-from-inbound) https://github.com/bitcoin/bitcoin/pull/24171
<bitcoin-git> bitcoin/master 00ce854 laanwj: Merge bitcoin/bitcoin#24171: p2p: Sync chain more readily from inbound pee...
<bitcoin-git> bitcoin/master 0569b5c Suhas Daftuar: Sync chain more readily from inbound peers during IBD
<bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1f63b460a850...00ce8543f16f
<bitcoin-git> bitcoin/master 48262a0 Suhas Daftuar: Add functional test for block sync from inbound peers
<gribble> https://github.com/bitcoin/bitcoin/issues/19772 | build: Cross-compiling libbitcoinconsensus for Windows fails with DEBUG=1 · Issue #19772 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/22702 | Add allocator for node based containers by martinus · Pull Request #22702 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/20962 | Alter the ChaCha20Poly1305@Bitcoin AEAD to the new specification by jonasschnelli · Pull Request #20962 · bitcoin/bitcoin · GitHub
<sipa> Also continued review of the PRs darosior has been working on to get Miniscript integrated into Bitcoin Core.
<gribble> https://github.com/bitcoin/bitcoin/issues/24864 | contrib: Use asmap for ASN lookup in makeseeds by laanwj · Pull Request #24864 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/24931 | Strengthen thread safety assertions by ajtowns · Pull Request #24931 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/25065 | [kernel 2c/n] Introduce `kernel::Context`, encapsulate global init/teardown by dongcarl · Pull Request #25065 · bitcoin/bitcoin · GitHub
<laanwj> https://github.com/bitcoin/bitcoin/projects/8 | currently we have 10 blocker PRs, 2 chasing concept ACK
<gribble> https://github.com/bitcoin/bitcoin/issues/25096 | [net] Minor improvements to addr caching by dergoegge · Pull Request #25096 · bitcoin/bitcoin · GitHub
<laanwj> welcome to the weekly general bitcoin-core-dev meeting
<laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard b10c BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo
<gribble> https://github.com/bitcoin/bitcoin/issues/24171 | p2p: Sync chain more readily from inbound peers during IBD by sdaftuar · Pull Request #24171 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] laanwj merged pull request #25267: test: check `replaceable` mismatch error in `createrawtransaction` RPC (master...202206-test-check_rbf_mismatch_in_createrawtransaction) https://github.com/bitcoin/bitcoin/pull/25267
<bitcoin-git> bitcoin/master 1f63b46 laanwj: Merge bitcoin/bitcoin#25267: test: check `replaceable` mismatch error in `...
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b11ab25afb44...1f63b460a850
<bitcoin-git> bitcoin/master 1bace0c Sebastian Falbesoner: test: check `replaceable` mismatch error in `createrawtransaction` RPC
<bitcoin-git> bitcoin/master 8cfb562 w0xlt: qt, refactor: add translator comments in `TransactionDesc::FormatTxStatus(...
<bitcoin-git> bitcoin/master b11ab25 Hennadii Stepanov: Merge bitcoin-core/gui#583: Add translator comments to `TransactionDesc::F...
<bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/da6792b2eb6a...b11ab25afb44
<bitcoin-git> [gui] hebasto merged pull request #583: Add translator comments to `TransactionDesc::FormatTxStatus` (master...translator_comments_transactiondesc) https://github.com/bitcoin-core/gui/pull/583
<bitcoin-git> bitcoin/master da6792b Hennadii Stepanov: Merge bitcoin-core/gui#613: Remove unnecessary wallet includes from rpccon...
<bitcoin-git> bitcoin/master 0994273 laanwj: qt: Remove unnecessary wallet includes from rpcconsole.cpp
<bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a100c42a136d...da6792b2eb6a
<bitcoin-git> [gui] hebasto merged pull request #613: Remove unnecessary wallet includes from rpcconsole.cpp (master...2022-06-qtconsole-includes) https://github.com/bitcoin-core/gui/pull/613
<bitcoin-git> [bitcoin] laanwj merged pull request #24927: Add test util to populate mempool with random transactions, fix #24634 bug (master...2022-04-test-util-populate-mempool) https://github.com/bitcoin/bitcoin/pull/24927
<bitcoin-git> bitcoin/master 2118750 glozow: [test util] to populate mempool with random transactions/packages
<bitcoin-git> bitcoin/master 5374dfc glozow: [test util] use -checkmempool for TestingSetup mempool check ratio
<bitcoin-git> bitcoin/master d7d9c7b glozow: [test util] add chain name to TestChain100Setup ctor
<bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/636991d0c0f9...a100c42a136d
<bitcoin-git> [bitcoin] laanwj merged pull request #25264: kernel: pass params to BlockManager rather than using a global (master...no-kernel-global-params) https://github.com/bitcoin/bitcoin/pull/25264
<bitcoin-git> bitcoin/master 636991d laanwj: Merge bitcoin/bitcoin#25264: kernel: pass params to BlockManager rather th...
<bitcoin-git> bitcoin/master a4741bd Cory Fields: kernel: pass params to BlockManager rather than using a global
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/39ddd522c37f...636991d0c0f9
<bitcoin-git> [gui] laanwj opened pull request #613: qt: Remove unnecessary wallet includes from rpcconsole.cpp (master...2022-06-qtconsole-includes) https://github.com/bitcoin-core/gui/pull/613
<sipa> BIP340 describes a digital signature scheme, it has no notion of sighash types or even anything related to Bitcoin at all.
<sipa> davidbakin: (1) luke-jr gave the link to the spec for key path spending in BIP341. For tapscript script path spending it's in BIP342, https://github.com/bitcoin/bips/blob/master/bip-0342.mediawiki#signature-validation
<bitcoin-git> [bitcoin] furszy opened pull request #25269: wallet: re-activate the not triggered "AmountWithFeeExceedsBalance" (master...2022_wallet_fix_missing_AmountWithFeeExceedsBalance) https://github.com/bitcoin/bitcoin/pull/25269
<jamesob> Can someone help me understand why this CI job is failing when all others are passing? The compiler error given seems to correspond to old (or otherwise changed) code: https://github.com/bitcoin/bitcoin/pull/24232/checks?check_run_id=6561221006
<reardencode> davidbakin: 2: The extension is to the `Common Signature Message` which is hashed with hash_TapSighash. 3: https://github.com/bitcoin/bips/blob/master/bip-0341.mediawiki#cite_ref-10-0
<bitcoin-git> [bitcoin] dergoegge opened pull request #25268: refactor: Introduce EvictionManager (master...2022-05-eviction-manager) https://github.com/bitcoin/bitcoin/pull/25268
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24531: Use designated initializers (master...2203-designated_init-🛍) https://github.com/bitcoin/bitcoin/pull/24531
<bitcoin-git> bitcoin/master 39ddd52 MacroFake: Merge bitcoin/bitcoin#24531: Use designated initializers
<bitcoin-git> bitcoin/master fa72e0b MarcoFalke: Use designated initializers
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1c7ef0abd11f...39ddd522c37f
<bitcoin-git> [bitcoin] theStack opened pull request #25267: test: check `replaceable` mismatch error in `createrawtransaction` RPC (master...202206-test-check_rbf_mismatch_in_createrawtransaction) https://github.com/bitcoin/bitcoin/pull/25267
<laanwj> davidbakin: if you don't get an answer here, you might want to ask in #bitcoin-wizards

2022-06-01

<bitcoin-git> [bitcoin] theuni opened pull request #25264: kernel: pass params to BlockManager rather than using a global (master...no-kernel-global-params) https://github.com/bitcoin/bitcoin/pull/25264
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25262: test: Set maxfeerate=0 in MiniWallet sendrawtransaction() (master...2206-test-mini-fast-📨) https://github.com/bitcoin/bitcoin/pull/25262
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/86cc31dab6ba...1c7ef0abd11f
<bitcoin-git> bitcoin/master fafaad9 MacroFake: test: Set maxfeerate=0 in MiniWallet sendrawtransaction()
<bitcoin-git> bitcoin/master 1c7ef0a MacroFake: Merge bitcoin/bitcoin#25262: test: Set maxfeerate=0 in MiniWallet sendrawt...
<bitcoin-git> [bitcoin] fanquake merged pull request #25249: Bump univalue subtree (master...2205-univalue-🎖) https://github.com/bitcoin/bitcoin/pull/25249
<bitcoin-git> bitcoin/master 025c6ca MacroFake: Squashed 'src/univalue/' changes from 6c19d050a9..de4f73ddca
<bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/b752dade048c...86cc31dab6ba
<bitcoin-git> [bitcoin] fanquake opened pull request #25263: build: pass minisketch cppflags only where needed (master...minisketch_cpp_needed) https://github.com/bitcoin/bitcoin/pull/25263
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25262: test: Set maxfeerate=0 in MiniWallet sendrawtransaction() (master...2206-test-mini-fast-📨) https://github.com/bitcoin/bitcoin/pull/25262
<bitcoin-git> [bitcoin] fanquake merged pull request #25244: build: pass bdb cppflags only where needed (master...use_bdb_cppflags_needed) https://github.com/bitcoin/bitcoin/pull/25244
<bitcoin-git> bitcoin/master b752dad fanquake: Merge bitcoin/bitcoin#25244: build: pass bdb cppflags only where needed
<bitcoin-git> bitcoin/master 46a8909 fanquake: build: pass bdb cppflags only where needed
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9cc010f5a9d7...b752dade048c
<bitcoin-git> bitcoin/master 1da5e45 Sebastian Falbesoner: test: use MiniWallet for feature_dbcrash.py
<bitcoin-git> bitcoin/master 9cc010f MacroFake: Merge bitcoin/bitcoin#25087: test: use MiniWallet for feature_dbcrash.py
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25087: test: use MiniWallet for feature_dbcrash.py (master...202205-test-use_MiniWallet_for_feature_dbcrash) https://github.com/bitcoin/bitcoin/pull/25087
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/dd52f79a73ec...9cc010f5a9d7
<bitcoin-git> [bitcoin] fanquake closed pull request #23330: WIP: [RPC] allow fetching headers by pages (master...header-fetch) https://github.com/bitcoin/bitcoin/pull/23330
<bitcoin-git> [bitcoin] natanleung opened pull request #25261: rpc: fetch multiple headers in getblockheader() (master...rpc_getblockheader_count) https://github.com/bitcoin/bitcoin/pull/25261
<bitcoin-git> [bitcoin] fanquake opened pull request #25260: consensus: move version.h into consensus/ (master...move_version_h_into_consensus) https://github.com/bitcoin/bitcoin/pull/25260
<bitcoin-git> [bitcoin] laanwj merged pull request #24416: doc: Avoid ADL for function calls (master...220222-adl) https://github.com/bitcoin/bitcoin/pull/24416
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e157b98640c7...dd52f79a73ec
<bitcoin-git> bitcoin/master dd52f79 laanwj: Merge bitcoin/bitcoin#24416: doc: Avoid ADL for function calls
<bitcoin-git> bitcoin/master 52a797b Hennadii Stepanov: doc: Avoid ADL for function calls
<gribble> https://github.com/bitcoin/bitcoin/issues/24356 | refactor: replace CConnman::SocketEvents() with mockable Sock::WaitMany() by vasild · Pull Request #24356 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/21878 | Make all networking code mockable by vasild · Pull Request #21878 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #25257: p2p: Disconnect manual peers and not discourage all peers with the same address on getblocktxn msg corruption (master...2205-no-misbehaving-🌷) https://github.com/bitcoin/bitcoin/pull/25257
<bitcoin-git> [bitcoin] laanwj merged pull request #25165: doc: Explain squashing with merge commits (master...2205-doc-squash-🐾) https://github.com/bitcoin/bitcoin/pull/25165
<bitcoin-git> bitcoin/master e157b98 laanwj: Merge bitcoin/bitcoin#25165: doc: Explain squashing with merge commits
<bitcoin-git> bitcoin/master fa2d226 MacroFake: doc: Explain squashing with merge commits
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/beb18d3fbc0d...e157b98640c7
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25259: test: check pre-segwit peer error in `getblockfrompeer` RPC (master...202205-test-rpc-getblockfrompeer_check_presegwit_peer_error) https://github.com/bitcoin/bitcoin/pull/25259
<bitcoin-git> bitcoin/master 7d0f67a Sebastian Falbesoner: test: check pre-segwit peer error in `getblockfrompeer` RPC
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d4d9daff7ab6...beb18d3fbc0d
<bitcoin-git> bitcoin/master beb18d3 MacroFake: Merge bitcoin/bitcoin#25259: test: check pre-segwit peer error in `getbloc...

2022-05-31

<jonatack> dongcarl: yes, i think it has been ongoing for quite some time now https://github.com/bitcoin/bitcoin/issues/23165
<bytes1440000> hebasto: I am still getting error. Thanks for your help but I give up. Working on something else now so will try this later. I think this doc can be improved though: https://github.com/bitcoin/bitcoin/blob/master/doc/build-android.md
<bitcoin-git> [bitcoin] theStack opened pull request #25259: test: check pre-segwit peer error in `getblockfrompeer` RPC (master...202205-test-rpc-getblockfrompeer_check_presegwit_peer_error) https://github.com/bitcoin/bitcoin/pull/25259
<bitcoin-git> [gui] hebasto closed pull request #199: Added updated bitcoin PNG / SVG icon (master...bitcoin_icon) https://github.com/bitcoin-core/gui/pull/199
<gribble> https://github.com/bitcoin/bitcoin/issues/23677 | build, qt: Use Android NDK r23 LTS by hebasto · Pull Request #23677 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] ryanofsky reopened pull request #22764: build: Include qt sources for parsing with extract_strings.py (master...210821-translation) https://github.com/bitcoin/bitcoin/pull/22764
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25257: p2p: Disconnect manual peers and not discourage all peers with the same address on getblocktxn msg corruption (master...2205-no-misbehaving-🌷) https://github.com/bitcoin/bitcoin/pull/25257
<bitcoin-git> [bitcoin] klementtan opened pull request #25256: logging: Add leveldb thread name and fix logging empty thread name (master...add_leveldb_threadname) https://github.com/bitcoin/bitcoin/pull/25256
<gribble> https://github.com/bitcoin/bitcoin/issues/31 | -keypool option not advertised when using --help switch · Issue #31 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] hebasto opened pull request #25255: ci: Improve "ARM64 Android APK" task (master...220531-android) https://github.com/bitcoin/bitcoin/pull/25255
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25200: doc: Fix spelling errors identified by codespell in comments (master...2022-05-codespell) https://github.com/bitcoin/bitcoin/pull/25200
<bitcoin-git> bitcoin/master d4d9daf MacroFake: Merge bitcoin/bitcoin#25200: doc: Fix spelling errors identified by codesp...
<bitcoin-git> bitcoin/master f565b28 Ben Woosley: Fixup option name in bench message
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1f932de67392...d4d9daff7ab6
<bitcoin-git> bitcoin/master bf209ac Ben Woosley: doc: Fix spelling errors identified by codespell in coments
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25253: test: add coverage for non-hex value to -minimumchainwork (master...2022-05-minimumchainwork-nonhex) https://github.com/bitcoin/bitcoin/pull/25253
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5f65afff9c4c...1f932de67392
<bitcoin-git> bitcoin/master ebfc308 brunoerg: test: add coverage for non-hex value to -minimumchainwork
<bitcoin-git> bitcoin/master 1f932de MacroFake: Merge bitcoin/bitcoin#25253: test: add coverage for non-hex value to -mini...
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25254: Move minRelayTxFee to policy/settings (master...2205-fee-setting-🕹) https://github.com/bitcoin/bitcoin/pull/25254
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24178: p2p: Respond to getheaders if we have sufficient chainwork (master...2022-01-headers-response-requires-minchainwork) https://github.com/bitcoin/bitcoin/pull/24178
<bitcoin-git> bitcoin/master a35f963 Suhas Daftuar: Add test for getheaders behavior
<bitcoin-git> bitcoin/master 5f65aff MacroFake: Merge bitcoin/bitcoin#24178: p2p: Respond to getheaders if we have suffici...
<bitcoin-git> bitcoin/master ef6dbe6 Suhas Daftuar: Respond to getheaders if we have sufficient chainwork
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/bd6c5e410829...5f65afff9c4c
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25250: [22.x] test: replace hashlib.ripemd160 with an own implementation (22.x...2205-backport-ripemd160-👥) https://github.com/bitcoin/bitcoin/pull/25250
<bitcoin-git> bitcoin/22.x d2e0c27 MacroFake: Merge bitcoin/bitcoin#25250: [22.x] test: replace hashlib.ripemd160 with a...
<bitcoin-git> bitcoin/22.x ea3e028 Pieter Wuille: Swap out hashlib.ripemd160 for own implementation
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to 22.x: https://github.com/bitcoin/bitcoin/compare/34cb63e89597...d2e0c27e45ab
<bitcoin-git> bitcoin/22.x 5203691 Pieter Wuille: Add pure Python RIPEMD-160
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25246: Revert "build: more robustly check for fcf-protection support" (master...remove_clang_7_note) https://github.com/bitcoin/bitcoin/pull/25246
<bitcoin-git> bitcoin/master bd6c5e4 MacroFake: Merge bitcoin/bitcoin#25246: Revert "build: more robustly check for fcf-pr...
<bitcoin-git> bitcoin/master a7973bf fanquake: Revert "build: more robustly check for fcf-protection support"
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b9ef5a10e2fa...bd6c5e410829

2022-05-30

<bitcoin-git> [bitcoin] brunoerg opened pull request #25253: test: add coverage for non-hex value to -minimumchainwork (master...2022-05-minimumchainwork-nonhex) https://github.com/bitcoin/bitcoin/pull/25253
<bitcoin-git> bitcoin/master 151009c Hennadii Stepanov: qt, wallet, refactor: Drop unused `WalletModel::PaymentRequestExpired`
<bitcoin-git> bitcoin/master b9ef5a1 Hennadii Stepanov: Merge bitcoin-core/gui#609: wallet, refactor: Drop unused `WalletModel::Pa...
<bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/269fa667f248...b9ef5a10e2fa
<bitcoin-git> [gui] hebasto merged pull request #609: wallet, refactor: Drop unused `WalletModel::PaymentRequestExpired` (master...220529-expired) https://github.com/bitcoin-core/gui/pull/609
<bitcoin-git> [bitcoin] fanquake opened pull request #25251: Consolidate Windows ASLR workarounds for upstream secp256k1 changes (master...libsecp256k1_no_more_static_export) https://github.com/bitcoin/bitcoin/pull/25251
<instagibbs> _aj_, https://github.com/bitcoin/bitcoin/issues/22028 dun dun dunn
<sipa> @theStack Oh, this isn't the *bitcoin* version message, but the version of the transport protocol I'm talking about.
<bitcoin-git> bitcoin/22.x 34cb63e laanwj: Merge bitcoin/bitcoin#25242: [22.x] rpc: Capture potentially large UniValu...
<bitcoin-git> [bitcoin] laanwj merged pull request #25242: [22.x] rpc: Capture potentially large UniValue by ref for rpcdoccheck (22.x...2205-uni-no-copy-📊) https://github.com/bitcoin/bitcoin/pull/25242
<bitcoin-git> bitcoin/22.x 7fcac96 Martin Zumsande: rpc: Capture potentially large UniValue by ref for rpcdoccheck
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to 22.x: https://github.com/bitcoin/bitcoin/compare/04fdd644b43a...34cb63e89597
<bitcoin-git> [bitcoin] laanwj merged pull request #25241: [23.x] rpc: Capture potentially large UniValue by ref for rpcdoccheck (23.x...2205-uni-no-copy-📊) https://github.com/bitcoin/bitcoin/pull/25241
<bitcoin-git> bitcoin/23.x 7fcac96 Martin Zumsande: rpc: Capture potentially large UniValue by ref for rpcdoccheck
<bitcoin-git> bitcoin/23.x c3936cc laanwj: Merge bitcoin/bitcoin#25241: [23.x] rpc: Capture potentially large UniValu...
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to 23.x: https://github.com/bitcoin/bitcoin/compare/fcf6c8f4eb21...c3936cc53dab
<bitcoin-git> [gui] hebasto opened pull request #612: refactor: Drop unused `QFrame`s in `SendCoinsEntry` (master...220530-sendcoins) https://github.com/bitcoin-core/gui/pull/612
<theStack> sipa: thanks, good to know. that explains why there are PRs around implementing elligator squared pubkeys (both in secp256k1 and bitcoin core), but no mention of it in the (obviously outdated) spec i read
<theStack> bip324 question about handshake: in older slides (from breaking bitcoin 2019) i saw it was proposed that only odd pubkeys (i.e. starting with 0x03) are allowed, but the current BIP states only even pubkeys (i.e. starting with 0x02) are. any specific reason for this change?
<sipa> And Bitcoin Core from back then cannot be used unmodified against today's OpenSSL's versions.
<sipa> Well, it didn't happen with Bitcoin Core versions from 2014 linked against OpenSSL from 2014 and before.
<sipa> but i believe that no version of bitcoin core (including very old ones) would emit such encodings
<sipa> there are certainly DER private key encodings that are valid but bitcoin core today wouldn't be able to parse, as it doesn't have a full DER parser
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25250: [22.x] test: replace hashlib.ripemd160 with an own implementation (22.x...2205-backport-ripemd160-👥) https://github.com/bitcoin/bitcoin/pull/25250
<sipa> it's not clear to me whether this is an issue for the bitcoin core codebase at all (includin historical versions)
<DavidBakin> so that means someone with such a wallet can't in fact use a newer bitcoin core to read it?
<div72> laanwj: You're right, I've encountered the issue in a downstream where OpenSSL was still being used. The chances of this affecting Bitcoin is pretty slim as a wallet from a 7y old version which needs to be compiled with a pre 3 recent OpenSSL version is needed.
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25044: test: Use MiniWallet in rpc_rawtransaction.py (master...test_rawtransaction_miniwallet) https://github.com/bitcoin/bitcoin/pull/25044
<bitcoin-git> bitcoin/master 269fa66 MacroFake: Merge bitcoin/bitcoin#25044: test: Use MiniWallet in rpc_rawtransaction.py
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ad9e5eaf77bf...269fa667f248
<bitcoin-git> bitcoin/master e93046c Daniela Brozzoni: MOVEONLY: Move signrawtransactionwithwallet test
<bitcoin-git> bitcoin/master e895900 Daniela Brozzoni: test: Use MiniWallet in rpc_rawtransaction.py
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25249: Bump univalue subtree (master...2205-univalue-🎖) https://github.com/bitcoin/bitcoin/pull/25249