2020-12-21

< bitcoin-git> bitcoin/master c123892 Hennadii Stepanov: ci: Drop Travis-specific workaround for shellcheck
< bitcoin-git> bitcoin/master 93504da Hennadii Stepanov: ci: Fix COMMIT_RANGE variable value for PRs
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/e9efb64a0772...f061da288783
< wumpus> MarcoFalke: https://github.com/bitcoin/bitcoin/pull/20720#issuecomment-748815722 beware, github-merge will still include your not-an-ACK as if an ACK :)
< wumpus> the metadata archive (https://github.com/zw/bitcoin-gh-meta) doesn't have a file for it *at all* so it was not visible through the API either
< jonasschnelli> achow101: after entering the .p12 password (your tool) I'm getting FileNotFoundError: [Errno 2] No such file or directory: '/Users/jonasschnelli/Desktop/bitcoin-0.21.0rc3-osx-unsigned/dist/Bitcoin-Qt.app/Contents/_CodeSignature/CodeResources'
< jonasschnelli> set -x tell me: /Users/jonasschnelli/Documents/bitcoin/signapple/codesign.py sign -f --file-list sign.temp/signatures.txt -s Bitcoin dist/Bitcoin-Qt.app
< jonasschnelli> achow101: I'm at 56e5493,... ./detached-sig-create.sh -s "Bitcoin" gives me "codesign.py: error: argument command: invalid choice: 'sign.temp/signatures.txt' (choose from 'verify', 'sign', 'dump')"
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20733: inline non-member functions with body in fuzzing headers (master...2020-12-20-fuzz-inline) https://github.com/bitcoin/bitcoin/pull/20733
< bitcoin-git> bitcoin/master e9efb64 MarcoFalke: Merge #20733: inline non-member functions with body in fuzzing headers
< bitcoin-git> bitcoin/master d8b9cec Patrick Strateman: inline non-member functions with body in fuzzing headers
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f1dbf92ff047...e9efb64a0772
< bitcoin-git> [bitcoin] hebasto opened pull request #20734: build: Make platform-specific targets available for proper platform builds only (master...201221-targets) https://github.com/bitcoin/bitcoin/pull/20734
< bitcoin-git> [bitcoin] fanquake closed pull request #16169: omnilayerDevelop88 (0.18...develop) https://github.com/bitcoin/bitcoin/pull/16169

2020-12-20

< bitcoin-git> [bitcoin] pstratem opened pull request #20733: inline non-member functions with body in fuzzing headers (master...2020-12-20-fuzz-inline) https://github.com/bitcoin/bitcoin/pull/20733
< fanquake> No worries. What you're seeing now could be the same as what was reported here: https://github.com/bitcoin/bitcoin/pull/20560#issuecomment-748339644
< fanquake> how is "/usr/bin/ld: error: ... <corrupt x86 feature size: 0x8>" the same as "multiple definition of `ConsumeNode(FuzzedDataProvider&)'; test/fuzz/fuzz-addition_overflow.o:/home/bitcoin/bitcoin/src/./test/fuzz/util.h:290: first defined here"
< bitcoin-git> [bitcoin] benthecarman opened pull request #20731: rpc: Add missing description of vout in getrawtransaction help text (master...fix-getrawtransaction-help-text) https://github.com/bitcoin/bitcoin/pull/20731
< bitcoin-git> [bitcoin] jonatack opened pull request #20729: p2p: standardize on outbound-{full, block}-relay connection type naming (master...outbound-connection-type-naming) https://github.com/bitcoin/bitcoin/pull/20729
< bitcoin-git> [bitcoin] hebasto closed pull request #20717: ci: Fix COMMIT_RANGE variable value for cloned repos (master...201218-clone) https://github.com/bitcoin/bitcoin/pull/20717

2020-12-19

< bitcoin-git> [bitcoin] sdaftuar opened pull request #20726: p2p: Add BLOCKRELAY message for negotiating block-relay-only connection (master...2020-12-negotiate-block-relay) https://github.com/bitcoin/bitcoin/pull/20726
< bitcoin-git> [bitcoin] ajtowns opened pull request #20724: Cleanup of -debug=net log messages (master...202012-net-log-cleanup) https://github.com/bitcoin/bitcoin/pull/20724
< bitcoin-git> [bitcoin] hebasto closed pull request #20206: wallet, refactor: Include headers instead of function declarations (master...201020-headers) https://github.com/bitcoin/bitcoin/pull/20206
< bitcoin-git> [bitcoin] jonatack opened pull request #20723: p2p: improve logging in EvictExtraOutboundPeers() (master...improve-EvictExtraOutboundPeers-logging) https://github.com/bitcoin/bitcoin/pull/20723
< bitcoin-git> [bitcoin] laanwj closed pull request #20678: Add on autoconf as a dependency when building on macOS (master...autoconf-dependency) https://github.com/bitcoin/bitcoin/pull/20678
< bitcoin-git> [bitcoin] jnewbery opened pull request #20721: Net: Move ping data to net_processing (master...2020-12-ping-in-peer) https://github.com/bitcoin/bitcoin/pull/20721
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #20717: ci: Fix COMMIT_RANGE variable value for cloned repos (master...201218-clone) https://github.com/bitcoin/bitcoin/pull/20717
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #20717: ci: Fix COMMIT_RANGE variable value for cloned repos (master...201218-clone) https://github.com/bitcoin/bitcoin/pull/20717
< bitcoin-git> [bitcoin] hebasto reopened pull request #20717: ci: Fix COMMIT_RANGE variable value for cloned repos (master...201218-clone) https://github.com/bitcoin/bitcoin/pull/20717
< bitcoin-git> [bitcoin] hebasto closed pull request #20717: ci: Fix COMMIT_RANGE variable value for cloned repos (master...201218-clone) https://github.com/bitcoin/bitcoin/pull/20717
< bitcoin-git> [bitcoin] fanquake opened pull request #20720: build: more robustly check for fcf-protection support (master...more_robust_fcf_protection) https://github.com/bitcoin/bitcoin/pull/20720
< fanquake> I've just built bitcoin-cli and see the same linking issue.
< phantomcircuit> sipa, exactly what i did http://192.241.205.97/bitcoin-fuzz.txt
< bitcoin-git> [bitcoin] fanquake closed pull request #20719: (master) (master...(master)) https://github.com/bitcoin/bitcoin/pull/20719

2020-12-18

< sipa> though it seems something was changed w.r.t not doing that, as dongcarl noticed: https://github.com/bitcoin/bitcoin/pull/20560#issuecomment-748339644
< gribble> https://github.com/bitcoin/bitcoin/issues/20560 | fuzz: Link all targets once by MarcoFalke · Pull Request #20560 · bitcoin/bitcoin · GitHub
< andytoshi> /home/apoelstra/code/bitcoin/bitcoin/fuzz/src/./test/fuzz/fuzz.h:18: multiple definition of `FuzzFrameworkEmptyFun()'; test/fuzz/fuzz-addition_overflow.o:/home/apoelstra/code/bitcoin/bitcoin/fuzz/src/./test/fuzz/fuzz.h:18: first defined here
< core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
< achow101> #bitcoin-core-dev Wallet Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik petertodd phantomcircuit promag provoostenator
< core-meetingbot> Meeting started Fri Dec 18 19:03:49 2020 UTC. The chair is achow101. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
< bitcoin-git> [gui] luke-jr opened pull request #157: Refactor P2PKH filtering, via AddressBookSortFilterProxyModel (master...gui_filter_p2pkh) https://github.com/bitcoin-core/gui/pull/157
< bitcoin-git> [bitcoin] hebasto opened pull request #20717: ci: Fix COMMIT_RANGE variable value for cloned repos (master...201218-clone) https://github.com/bitcoin/bitcoin/pull/20717
< bitcoin-git> [bitcoin] hebasto closed pull request #20716: ci: Fix COMMIT_RANGE variable value for cloned repos (master...201218-cloned) https://github.com/bitcoin/bitcoin/pull/20716
< bitcoin-git> [bitcoin] hebasto reopened pull request #20716: ci: Fix COMMIT_RANGE variable value for cloned repos (master...201218-cloned) https://github.com/bitcoin/bitcoin/pull/20716
< bitcoin-git> [bitcoin] hebasto closed pull request #20716: ci: Fix COMMIT_RANGE variable value for cloned repos (master...201218-cloned) https://github.com/bitcoin/bitcoin/pull/20716
< bitcoin-git> [bitcoin] hebasto opened pull request #20716: ci: Fix COMMIT_RANGE variable value for cloned repos (master...201218-cloned) https://github.com/bitcoin/bitcoin/pull/20716
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20715: util: Add ArgsManager::GetCommands() and use it in bitcoin-wallet (master...2012-argsCmd) https://github.com/bitcoin/bitcoin/pull/20715
< bitcoin-git> [bitcoin] romanz opened pull request #20702: rpc: Add getblocklocations (master...locations) https://github.com/bitcoin/bitcoin/pull/20702
< bitcoin-git> [bitcoin] hebasto opened pull request #20697: ci: Fix COMMIT_RANGE variable value (master...201218-range) https://github.com/bitcoin/bitcoin/pull/20697
< bitcoin-git> [bitcoin] laanwj merged pull request #20434: contrib: Parse ELF directly for symbol and security checks (master...2020_11_pixie) https://github.com/bitcoin/bitcoin/pull/20434
< bitcoin-git> bitcoin/master a0a7718 Luke Dashjr: contrib: Changes to checks for PowerPC64
< bitcoin-git> bitcoin/master f1dbf92 Wladimir J. van der Laan: Merge #20434: contrib: Parse ELF directly for symbol and security checks
< bitcoin-git> bitcoin/master 634f6ec Wladimir J. van der Laan: contrib: Parse ELF directly for symbol and security checks
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/83e4670fd7cd...f1dbf92ff047
< vasild> Sure, if no downsides. What is that "random ports mapping" luke-jr mentioned (https://github.com/bitcoin/bitcoin/pull/18077#issuecomment-588484002)?
< wumpus> i think UPnP is a terrible protocol, but I'm biased because the only RCE for bitcoin core that I know of used a UPnP xml parsing vulnerability
< gleb> On the Bitcoin p2p protocol layer I mean.
< vasild> gleb: wrt https://github.com/bitcoin/bitcoin/pull/20685#issuecomment-747959538 -- by "non-popular overlay" do you mean I2P? What "privacy/security side-effects" side effects?
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20690: Clean up logging of outbound connection type (master...2020-12-clean-up-outbound-logging) https://github.com/bitcoin/bitcoin/pull/20690
< bitcoin-git> bitcoin/master 83e4670 MarcoFalke: Merge #20690: Clean up logging of outbound connection type
< bitcoin-git> bitcoin/master 6d1e85f Suhas Daftuar: Clean up logging of outbound connection type
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/20f4a9421ba6...83e4670fd7cd
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20682: ci: Install missing lint packages (master...2012-testDel) https://github.com/bitcoin/bitcoin/pull/20682
< bitcoin-git> bitcoin/master 20f4a94 MarcoFalke: Merge #20682: ci: Install missing lint packages
< bitcoin-git> bitcoin/master faeb40b MarcoFalke: ci: Install missing lint packages
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3dd3f7c0af7e...20f4a9421ba6
< bitcoin-git> bitcoin/master 3dd3f7c MarcoFalke: Merge bitcoin-core/gui#155: Fix checkbox layout in Create Wallet dialog
< bitcoin-git> bitcoin/master e71b656 Hennadii Stepanov: qt: Align layout of checkboxes
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b27104dc5276...3dd3f7c0af7e
< bitcoin-git> [gui] MarcoFalke merged pull request #155: Fix checkbox layout in Create Wallet dialog (master...201218-i3) https://github.com/bitcoin-core/gui/pull/155
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20687: wallet: Add missing check for -descriptors wallet tool option (master...2012-walletToolSqlite) https://github.com/bitcoin/bitcoin/pull/20687
< bitcoin-git> bitcoin/master fae32f2 MarcoFalke: wallet: Add missing check for -descriptors wallet tool option
< bitcoin-git> bitcoin/master faf8f61 MarcoFalke: test: Add missing check for is_sqlite_compiled
< bitcoin-git> bitcoin/master fa7dde1 MarcoFalke: wallet: Pass ArgsManager into ExecuteWalletToolFunc instead of using global
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/9b28bd73a33b...b27104dc5276
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20691: ci, doc: Travis CI features and mentions cleanup (master...201217-travis) https://github.com/bitcoin/bitcoin/pull/20691
< bitcoin-git> bitcoin/master 9b28bd7 MarcoFalke: Merge #20691: ci, doc: Travis CI features and mentions cleanup
< bitcoin-git> bitcoin/master 95487b0 Hennadii Stepanov: doc: Drop mentions of Travis CI as it is no longer used
< bitcoin-git> bitcoin/master 09d105e Hennadii Stepanov: ci: Drop travis_fold feature as Travis CI is no longer used
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/816314ef0f7b...9b28bd73a33b

2020-12-17

< sipa> #bitcoin please
< bitcoin-git> [gui] hebasto opened pull request #155: Fix checkbox layout in Create Wallet dialog (master...201218-i3) https://github.com/bitcoin-core/gui/pull/155
< bitcoin-git> [bitcoin] glowang closed pull request #19297: [test] WIP: rewrite generate() in test_node to gain determinism in test data (master...2020/05/21/rewrite_generate_in_testnode) https://github.com/bitcoin/bitcoin/pull/19297
< bitcoin-git> [bitcoin] mjdietzx opened pull request #20692: test: run mempool_resurrect.py even with wallet disabled (master...mempool-resurrect-to-miniwallet) https://github.com/bitcoin/bitcoin/pull/20692
< sipa> yeah, someone testing protocol support against bitcoin core will likely use master anyway
< gribble> https://github.com/bitcoin/bitcoin/issues/20646 | p2p: ignore post-verack sendaddrv2 instead of disconnecting by jonatack · Pull Request #20646 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20669 | [0.21] final rc4 backports by MarcoFalke · Pull Request #20669 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj merged pull request #20644: Add patch to make codesign_allocate compatible with Apple's (master...202012_codesign_allocate_segalign) https://github.com/bitcoin/bitcoin/pull/20644
< bitcoin-git> bitcoin/master 816314e Wladimir J. van der Laan: Merge #20644: Add patch to make codesign_allocate compatible with Apple's
< bitcoin-git> bitcoin/master a4118c6 Pieter Wuille: Add patch to make codesign_allocate compatible with Apple's
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b7136c11ab64...816314ef0f7b
< gribble> https://github.com/bitcoin/bitcoin/issues/15946 | Allow maintaining the blockfilterindex when using prune by jonasschnelli · Pull Request #15946 · bitcoin/bitcoin · GitHub
< wumpus> bitcoin core is clearly the only client implementing sendaddrv2
< bitcoin-git> [bitcoin] hebasto closed pull request #20357: ci: Use travis_fold on Travis CI only (master...201109-travis) https://github.com/bitcoin/bitcoin/pull/20357
< bitcoin-git> [bitcoin] hebasto opened pull request #20691: ci, doc: Travis CI features and mentions cleanup (master...201217-travis) https://github.com/bitcoin/bitcoin/pull/20691
< core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
< gribble> https://github.com/bitcoin/bitcoin/issues/20564 | Dont send sendaddrv2 to pre-70016 software, and send before verack by sipa · Pull Request #20564 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19937 | signet mining utility by ajtowns · Pull Request #19937 · bitcoin/bitcoin · GitHub
< aj> sipa: had bitcoin-qt and bitcoind refusing to connect, didn't realise bitcoin-qt was still rc2
< gribble> https://github.com/bitcoin/bitcoin/issues/20646 | p2p: ignore post-verack sendaddrv2 instead of disconnecting by jonatack · Pull Request #20646 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20644 | Add patch to make codesign_allocate compatible with Apples by sipa · Pull Request #20644 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20644 | Add patch to make codesign_allocate compatible with Apples by sipa · Pull Request #20644 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20638 | build: Fix macOS code signing by pre-allocating space for the code signature during gitian build by achow101 · Pull Request #20638 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20664 | Add scanblockfilters RPC call by jonasschnelli · Pull Request #20664 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sdaftuar opened pull request #20690: Clean up logging of outbound connection type (master...2020-12-clean-up-outbound-logging) https://github.com/bitcoin/bitcoin/pull/20690
< wumpus> let's fork electrs into bitcoin-core then :)
< wumpus> just not everything needs to be part of the bitcoin core repostiory
< wumpus> well then people could make a bitcoin core + electrs bundle, for example
< MarcoFalke> https://github.com/bitcoin-core/btcdeb is also scope creep
< MarcoFalke> bitcoin-tx is scope creep as well (playing devils advocate)
< MarcoFalke> It would be nice if indexes could be attached to bitcoin core at runtime (external modules), but we are not there yet
< wumpus> bitcoin core is not a blob that needs to absorb the entire bitcoin ecosystem
< gribble> https://github.com/bitcoin/bitcoin/issues/20664 | Add scanblockfilters RPC call by jonasschnelli · Pull Request #20664 · bitcoin/bitcoin · GitHub
< sipa> it's a difficult question... (IMO) people shouldn't be building infrastructure that relies on having such an index, but if they're going to do it anyway, it's perhaps not any worse to have in bitcoin core
< gribble> https://github.com/bitcoin/bitcoin/issues/14053 | Add address-based index (attempt 4?) by marcinja · Pull Request #14053 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15946 | Allow maintaining the blockfilterindex when using prune by jonasschnelli · Pull Request #15946 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20546 | policy, wallet, refactor: check for non-representable CFeeRates by jonatack · Pull Request #20546 · bitcoin/bitcoin · GitHub
< wumpus> https://github.com/bitcoin/bitcoin/projects/8 10 blockers, 2 chasing concept ACK
< gribble> https://github.com/bitcoin/bitcoin/issues/15946 | Allow maintaining the blockfilterindex when using prune by jonasschnelli · Pull Request #15946 · bitcoin/bitcoin · GitHub
< wumpus> #bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik
< bitcoin-git> [bitcoin] theStack opened pull request #20689: contrib: replace binary verification script verify.sh with python rewrite (master...202012-contrib-replace-verify-binaries-script-with-python) https://github.com/bitcoin/bitcoin/pull/20689
< core-meetingbot> Meeting started Thu Dec 17 19:00:21 2020 UTC. The chair is wumpus. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
< bitcoin-git> [bitcoin] mjdietzx opened pull request #20688: test: run mempool_compatibility.py even with wallet disabled (master...mempool-compatibility-to-miniwallet) https://github.com/bitcoin/bitcoin/pull/20688
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20686: fuzz, refactor: replace CNode code with fuzz/util.h::ConsumeNode() (master...net-fuzzer-ConsumeNode) https://github.com/bitcoin/bitcoin/pull/20686
< bitcoin-git> bitcoin/master b7136c1 MarcoFalke: Merge #20686: fuzz, refactor: replace CNode code with fuzz/util.h::Consume...
< bitcoin-git> bitcoin/master 23d8f34 Jon Atack: fuzz: replace CNode code with fuzz/util.h::ConsumeNode()
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/190d3d8a75d2...b7136c11ab64
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20687: wallet: Add missing check for -descriptors wallet tool option (master...2012-walletToolSqlite) https://github.com/bitcoin/bitcoin/pull/20687
< bitcoin-git> [bitcoin] jonatack opened pull request #20686: fuzz, refactor: replace CNode code with fuzz/util.h::ConsumeNode() (master...net-fuzzer-ConsumeNode) https://github.com/bitcoin/bitcoin/pull/20686
< bitcoin-git> [bitcoin] sdaftuar closed pull request #20676: Replace m_tx_relay/nullptr checks in net_processing.cpp (master...2020-12-refactor-m_tx_relay) https://github.com/bitcoin/bitcoin/pull/20676
< bitcoin-git> [bitcoin] laanwj merged pull request #20681: doc: Convert depends options list from html to markdown (master...2020_12_dependdoc) https://github.com/bitcoin/bitcoin/pull/20681
< bitcoin-git> bitcoin/master 190d3d8 Wladimir J. van der Laan: Merge #20681: doc: Convert depends options list from html to markdown
< bitcoin-git> bitcoin/master 7b6887e Wladimir J. van der Laan: doc: Convert depends options list from html to markdown
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/143bd108ed66...190d3d8a75d2
< wumpus> there's still a bitcoin core wallet meeting on jan 1, probably also not going to be?
< bitcoin-git> [bitcoin] lontivero closed pull request #20662: Allow setting I2P addresses (master...set-i2p) https://github.com/bitcoin/bitcoin/pull/20662
< bitcoin-git> [gui] goums opened pull request #154: qt: Colorize icons on macOS for Dark mode support (master...macos_color_icons) https://github.com/bitcoin-core/gui/pull/154
< jonasschnelli> Review bag for https://github.com/bitcoin/bitcoin/pull/20273 (concept ACK/NACK). Helps me to decide if I should drag that PR along. I really like the functionality of nested commands in CLI.
< wumpus> my policy allows mapping high ports 1024-65535, denies the rest, but this should be enough for bitcoin
< gribble> https://github.com/bitcoin/bitcoin/issues/18077 | net: Add NAT-PMP port forwarding support by hebasto · Pull Request #18077 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19137: wallettool: Add dump and createfromdump commands (master...dumpwalletrecords) https://github.com/bitcoin/bitcoin/pull/19137
< bitcoin-git> bitcoin/master 23cac24 Andrew Chow: tests: Test bitcoin-wallet dump and createfromdump
< bitcoin-git> bitcoin/master a88c320 Andrew Chow: wallettool: Add createfromdump command
< bitcoin-git> bitcoin/master e1e7a90 Andrew Chow: wallettool: Add dump command
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/af4ce674dafa...143bd108ed66
< bitcoin-git> [bitcoin] laanwj merged pull request #20635: fix misleading comment about call to non-existing function (master...master) https://github.com/bitcoin/bitcoin/pull/20635
< bitcoin-git> bitcoin/master af4ce67 Wladimir J. van der Laan: Merge #20635: fix misleading comment about call to non-existing function
< bitcoin-git> bitcoin/master cc3044c pox: fix misleading comment about call to non-existing function
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cfbfd389f6dd...af4ce674dafa
< hebasto> wumpus: MarcoFalke: please remove spam https://github.com/bitcoin/bitcoin/pull/20658#issuecomment-747452862
< bitcoin-git> [bitcoin] vasild closed pull request #20254: Add I2P support using statically configured destinations (master...i2p_static) https://github.com/bitcoin/bitcoin/pull/20254
< bitcoin-git> [bitcoin] vasild opened pull request #20685: Add I2P support using I2P SAM (master...i2p_sam) https://github.com/bitcoin/bitcoin/pull/20685
< hebasto> wumpus: i'm confused by your https://github.com/bitcoin/bitcoin/pull/20678#issuecomment-747406247 -- did you ack for explicit mention of autoconf?
< bitcoin-git> [bitcoin] hebasto opened pull request #20684: build: Define .INTERMEDIATE target once only (master...201217-target) https://github.com/bitcoin/bitcoin/pull/20684
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20683: test: Fix restart node race (master...2012-testNodeStart) https://github.com/bitcoin/bitcoin/pull/20683
< bitcoin-git> [bitcoin] laanwj merged pull request #20668: doc: warn that incoming conns are unlikely when not using default ports (master...121520-non-standard-port-doc) https://github.com/bitcoin/bitcoin/pull/20668
< bitcoin-git> bitcoin/master cfbfd38 Wladimir J. van der Laan: Merge #20668: doc: warn that incoming conns are unlikely when not using de...
< bitcoin-git> bitcoin/master 010eed3 Adam Jonas: doc: warn that incoming conns are unlikely when not using default ports
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f0913f2f950c...cfbfd389f6dd
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20682: ci: Install missing lint packages (master...2012-testDel) https://github.com/bitcoin/bitcoin/pull/20682
< bitcoin-git> [bitcoin] laanwj merged pull request #20677: doc: Remove shouty enums in net_processing comments (master...2020-12-remove-shouty-enums) https://github.com/bitcoin/bitcoin/pull/20677
< bitcoin-git> bitcoin/master f0913f2 Wladimir J. van der Laan: Merge #20677: doc: Remove shouty enums in net_processing comments
< bitcoin-git> bitcoin/master 0c41c10 Suhas Daftuar: doc: Remove shouty enums in net_processing comments
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7ef6b1c51d4a...f0913f2f950c
< bitcoin-git> [bitcoin] laanwj opened pull request #20681: doc: Convert depends options list from html to markdown (master...2020_12_dependdoc) https://github.com/bitcoin/bitcoin/pull/20681
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #20083: p2p: Disconnect, not discourage, misbehaving NODE_BLOOM peers (master...2010-p2pBloomPeer) https://github.com/bitcoin/bitcoin/pull/20083
< bitcoin-git> [bitcoin] laanwj merged pull request #19961: doc: tor.md updates (master...update-tor-md) https://github.com/bitcoin/bitcoin/pull/19961
< bitcoin-git> bitcoin/master a34eceb Jon Atack: doc: update -externalip documentation in tor.md
< bitcoin-git> bitcoin/master dc8a591 Jon Atack: doc: add tor.md section on how to get tor info via bitcoind
< bitcoin-git> bitcoin/master e1765d8 Jon Atack: doc: update tor.md address examples from onion v2 to v3
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/d0e76b5050a2...7ef6b1c51d4a
< bitcoin-git> bitcoin/master d0e76b5 MarcoFalke: Merge bitcoin-core/gui#153: Define MAX_DIGITS_BTC for magic number in Bitc...
< bitcoin-git> bitcoin/master 198fff8 Luke Dashjr: GUI: Define MAX_DIGITS_BTC for magic number in BitcoinUnits::format
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/83abd6b126c2...d0e76b5050a2
< bitcoin-git> [gui] MarcoFalke merged pull request #153: Define MAX_DIGITS_BTC for magic number in BitcoinUnits::format (master...const_max_digits) https://github.com/bitcoin-core/gui/pull/153
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20680: ci: Only use credits for pull requests to the main repo (master...2012-ciCredits) https://github.com/bitcoin/bitcoin/pull/20680
< bitcoin-git> bitcoin/master 83abd6b MarcoFalke: Merge #20680: ci: Only use credits for pull requests to the main repo
< bitcoin-git> bitcoin/master facf5e3 MarcoFalke: ci: Only use credits for pull requests to the main repo
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8452f922d211...83abd6b126c2
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19050: doc: Add warning for rest interface limitation (master...rest_fd) https://github.com/bitcoin/bitcoin/pull/19050
< bitcoin-git> bitcoin/master 8452f92 MarcoFalke: Merge #19050: doc: Add warning for rest interface limitation
< bitcoin-git> bitcoin/master 5c3eaf9 Fabian Jahr: doc: Add warnings for http interfaces limitations
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6f2ca726ce2e...8452f922d211
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20680: ci: Only use credits for pull requests to the main repo (master...2012-ciCredits) https://github.com/bitcoin/bitcoin/pull/20680
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20658: ci: Move linter task to cirrus (master...linter-on-cirrus) https://github.com/bitcoin/bitcoin/pull/20658
< bitcoin-git> bitcoin/master 6f2ca72 MarcoFalke: Merge #20658: ci: Move linter task to cirrus
< bitcoin-git> bitcoin/master 4045a67 Dhruv Mehta: ci: Use cpu=1 for linter
< bitcoin-git> bitcoin/master 739d390 Dhruv Mehta: ci: Move linter task to cirrus
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1811e488d53b...6f2ca726ce2e
< bitcoin-git> [bitcoin] fanquake closed pull request #20679: Fix insecure links (master...https) https://github.com/bitcoin/bitcoin/pull/20679
< bitcoin-git> [bitcoin] rex4539 opened pull request #20679: Fix insecure links (master...https) https://github.com/bitcoin/bitcoin/pull/20679
< MarcoFalke> I think to reset Cirrus CI, you'd need to be added to the Bitcoin Core project and then authed on Cirrus via GitHub
< bitcoin-git> [bitcoin] fanquake closed pull request #20600: Depends : Qt Use Top-Level Structure (master...add-qml-depends) https://github.com/bitcoin/bitcoin/pull/20600
< fanquake> sipa: https://github.com/bitcoin/bitcoin/issues/20627#issuecomment-747216439 moving to using Qt 6 would drop support for Windows 7 & 8.x, as well as Ubuntu 18.04.
< fanquake> It's strange how people fight against dropping support for versions of macOS (at the potential detriment of the rest of the project), while at the same time seemingly have no issue with dropping support for versions of operating systems that are almost certainly used by more Bitcoin Core users, and/or are supported for far longer into the future.
< bitcoin-git> [bitcoin] fanquake closed pull request #20504: build: use more legible (q)make commands in qt package (master...legible_qt_config_cmds) https://github.com/bitcoin/bitcoin/pull/20504
< bitcoin-git> [bitcoin] sh-abhi opened pull request #20678: Add on autoconf as a dependency when building on macOS (master...autoconf-dependency) https://github.com/bitcoin/bitcoin/pull/20678

2020-12-16

< bitcoin-git> [bitcoin] laanwj merged pull request #20575: Do not run functions with necessary side-effects in assert() (master...side-effect-free-assert) https://github.com/bitcoin/bitcoin/pull/20575
< bitcoin-git> bitcoin/master 1811e48 Wladimir J. van der Laan: Merge #20575: Do not run functions with necessary side-effects in assert()...
< bitcoin-git> bitcoin/master 5021810 practicalswift: Make CanFlushToDisk a const member function
< bitcoin-git> bitcoin/master 281cf99 practicalswift: Do not run functions with necessary side-effects in assert()
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/4acbcfa97d20...1811e488d53b
< bitcoin-git> [bitcoin] sdaftuar opened pull request #20677: doc: Remove shouty enums in net_processing comments (master...2020-12-remove-shouty-enums) https://github.com/bitcoin/bitcoin/pull/20677
< bitcoin-git> bitcoin/master 7587d11 fanquake: build: remove cdrkit package from depends
< bitcoin-git> [bitcoin] laanwj merged pull request #20470: build: Replace genisoimage with xorriso (master...2020-11-xorriso) https://github.com/bitcoin/bitcoin/pull/20470
< bitcoin-git> bitcoin/master 0df9819 fanquake: build: Replace genisoimage with xorriso
< bitcoin-git> bitcoin/master 22437fc Carl Dong: build: Run libdmg-hfsplus's DMG tool in make deploy
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/ae9ee5bdb18c...4acbcfa97d20
< Kiminuo> @MarcoFalke, Hi, could you mark this https://github.com/bitcoin/bitcoin/pull/19245 PR with "up for grabs", "looking for help" or something in similar vein?
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #20675: Vova557 (master...patch-11) https://github.com/bitcoin/bitcoin/pull/20675
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20651: net: Make p2p recv buffer timeout 20 minutes for all peers (master...2020-12-recv-buffer-timeout) https://github.com/bitcoin/bitcoin/pull/20651
< bitcoin-git> bitcoin/master ae9ee5b MarcoFalke: Merge #20651: net: Make p2p recv buffer timeout 20 minutes for all peers
< bitcoin-git> bitcoin/master ea36a45 John Newbery: [net] Make p2p recv buffer timeout 20 minutes for all peers
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/427f8c2cff01...ae9ee5bdb18c
< sdaftuar> i assume this is the code: https://github.com/sipa/bitcoin-seeder ?
< sipa> well, one option is to just integrate the dns seeder (excluding the dns serving feature and/or crawling, but at least the database part) into bitcoin core, and
< bitcoin-git> [bitcoin] sdaftuar opened pull request #20676: Replace m_tx_relay/nullptr checks in net_processing.cpp (master...2020-12-refactor-m_tx_relay) https://github.com/bitcoin/bitcoin/pull/20676
< Kiminuo> sipa, I will need to find somebody who would like to finish that PR 19245. C++ building, linking and Bitcoin build system is not something I have adequate knowledge of. It takes me ages to move it an inch forward. I kind of did what I could. Can this be possibly discussed at a dev meeting?
< bitcoin-git> [bitcoin] vova557 opened pull request #20675: Vova557 (master...patch-11) https://github.com/bitcoin/bitcoin/pull/20675
< bitcoin-git> bitcoin/master 427f8c2 Wladimir J. van der Laan: Merge #20248: test: fix length of R check in key_signature_tests
< bitcoin-git> [bitcoin] laanwj merged pull request #20248: test: fix length of R check in key_signature_tests (master...fix-test-key-signature-low-r) https://github.com/bitcoin/bitcoin/pull/20248
< bitcoin-git> bitcoin/master 8989577 Dmitry Petukhov: Fix length of R check in test/key_tests.cpp:key_signature_tests
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5b6f970e3fda...427f8c2cff01
< Kiminuo> but that's just my impression, I just check bitcoin core PRs but not in-depth
< Kiminuo> https://github.com/bitcoin/bitcoin/pull/20658 i think this PR moves completely testing from Travis to Cirrus CI
< Kiminuo> https://github.com/bitcoin/bitcoin/runs/1562869764 I can see tests on the left, can you?
< Kiminuo> I have tested locally using https://github.com/bitcoin/bitcoin/tree/master/ci#configurations before pushing that commit and it was green for Win64 test.
< Kiminuo> The idea being that I'm struggling with Ubuntu 18.04 & std::filesystem so when I upgrade to 20.04 for my https://github.com/bitcoin/bitcoin/pull/19245 I can at least move it an inch forward to have green tests.
< Kiminuo> I have, out of frustration, changed CI tests from Ubuntu 18.04 to Ubuntu 20.04 and also bumped Clang (https://github.com/bitcoin/bitcoin/pull/19245/commits/cf948ffac6fc950066cd8975485a37a90d15ae07) but CI did not notice the change (https://github.com/bitcoin/bitcoin/runs/1562869764). Does CI require some sort of cache invalidation to do the build I want?
< sipa> yeah... maybe it's better to do it as a patch to bitcoin core itself
< sipa> it does have support for bitcoin P2P connections though (as it uses those for crawling)
< sdaftuar> as i think that behavior in bitcoin core causes problems with the addrfetch logic
< sdaftuar> when you say "we could have seed nodes that are available for getaddr one shot connections" - does that mean that we have hardcoded addresses available for that, or are you saying that there's a dns resolution that happens so that we would connect to a random bitcoin core node for the addrfetch behavior?
< sdaftuar> actually, i think it's only an issue if the addrfetch peer you connect to is running bitcoin core, so maybe not an issue if your seeder is custom sofwtare with different behavior
< bitcoin-git> [bitcoin] laanwj merged pull request #20171: Add functional test test_txid_inv_delay (master...2020-10-txid-delay-test) https://github.com/bitcoin/bitcoin/pull/20171
< bitcoin-git> bitcoin/master d3b5eac Antoine Riard: Add mutation for functional test test_preferred_inv
< bitcoin-git> bitcoin/master 06efb31 Antoine Riard: Add functional test test_txid_inv_delay
< bitcoin-git> bitcoin/master a07910a Antoine Riard: test: Makes wtxidrelay support a generic P2PInterface option
< bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/ad3d4b3929ab...5b6f970e3fda
< luke-jr> wen bitcoin-dnsseed support v3? :P
< gribble> https://github.com/bitcoin/bitcoin/issues/20561 | p2p: periodically clear m_addr_known by sdaftuar · Pull Request #20561 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20661 | Only select from addrv2-capable peers for torv3 address relay by sipa · Pull Request #20661 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19763 | net: dont try to relay to the address originator by vasild · Pull Request #19763 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19763 | net: dont try to relay to the address originator by vasild · Pull Request #19763 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj merged pull request #20661: Only select from addrv2-capable peers for torv3 address relay (master...202012_torv2_relay_only_addrv2) https://github.com/bitcoin/bitcoin/pull/20661
< bitcoin-git> bitcoin/master ad3d4b3 Wladimir J. van der Laan: Merge #20661: Only select from addrv2-capable peers for torv3 address rela...
< bitcoin-git> bitcoin/master 37fe80e Pieter Wuille: Only consider addrv2 peers for relay of non-addrv1 addresses
< bitcoin-git> bitcoin/master 83f8821 Pieter Wuille: refactor: add IsAddrCompatible() to CNode
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/69f1ee1922e3...ad3d4b3929ab
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20365: wallettool: add parameter to create descriptors wallet (master...wallet_tool_create_descriptors) https://github.com/bitcoin/bitcoin/pull/20365
< bitcoin-git> bitcoin/master 173cc9b Ivan Metlushko: test: walettool create descriptors
< bitcoin-git> bitcoin/master 345e88e Ivan Metlushko: wallettool: add param to create descriptors wallet
< bitcoin-git> bitcoin/master 6d3af3a Ivan Metlushko: wallettool: pass in DatabaseOptions into MakeWallet
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/3f205808a5f2...69f1ee1922e3
< bitcoin-git> [bitcoin] laanwj merged pull request #20605: init: Signal-safe instant shutdown (master...2020_12_instant_shutdown) https://github.com/bitcoin/bitcoin/pull/20605
< bitcoin-git> bitcoin/master 3f20580 Wladimir J. van der Laan: Merge #20605: init: Signal-safe instant shutdown
< bitcoin-git> bitcoin/master cd03513 Wladimir J. van der Laan: init: Signal-safe instant shutdown
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9dbcd3710521...3f205808a5f2
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20674: fuzz: Call SendMessages after ProcessMessage to increase coverage (master...2012-fuzzSendMessages) https://github.com/bitcoin/bitcoin/pull/20674
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20569: test: Fix intermittent wallet_multiwallet issue with got_loading_error (master...2012-testWalletInt) https://github.com/bitcoin/bitcoin/pull/20569
< bitcoin-git> bitcoin/master 9dbcd37 MarcoFalke: Merge #20569: test: Fix intermittent wallet_multiwallet issue with got_loa...
< bitcoin-git> bitcoin/master fa8e15f MarcoFalke: test: pep8 wallet_multiwallet.py
< bitcoin-git> bitcoin/master fab48da MarcoFalke: test: Fix intermittent wallet_multiwallet issue with got_loading_error
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/2d4eeaf9c588...9dbcd3710521
< bitcoin-git> [bitcoin] laanwj merged pull request #20601: doc: Update for FreeBSD 12.2, add GUI Build Instructions (master...master) https://github.com/bitcoin/bitcoin/pull/20601
< bitcoin-git> bitcoin/master 2d4eeaf Wladimir J. van der Laan: Merge #20601: doc: Update for FreeBSD 12.2, add GUI Build Instructions
< bitcoin-git> bitcoin/master c175690 Jarol Rodriguez: doc: Update for FreeBSD 12.2, add GUI Build Instructions
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a023094fc417...2d4eeaf9c588
< sdaftuar> aj: i've tried to debug this same issue (where a node appears to send us inv's after we start a blocks-only connection) many times over the years, and never been able to replicate using known bitcoin core software on both ends.
< aj> Jackielove4u: what's a bitcoin core rc3 client?
< aj> jnewbery: yeah; as per the comment i added -- i forgot to redact my ip before pasting that log snippet, then noticed my ip wasn't in the log; so those peers are definitely not pristine bitcoin core, so don't think it's our bug on the sending side either
< Jackielove4u> bitcoin core rc3 client (run on a desktop) and my schildbach wallet (run on android) does connect to bitcoin core 0.20.x and lower
< Jackielove4u> upon testing i saw that my bitcoin core rc3 client (run on a desktop) and my schildbach wallet (run on android) does not connect to my rc3 bitcoin core node (run on a server)
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20276: test: run mempool_expiry.py even with wallet disabled (master...mempool-expiry-miniwallet) https://github.com/bitcoin/bitcoin/pull/20276
< bitcoin-git> bitcoin/master a023094 MarcoFalke: Merge #20276: test: run mempool_expiry.py even with wallet disabled
< bitcoin-git> bitcoin/master 3b064fc Michael Dietz: test: run mempool_expiry.py even with wallet disabled
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6af8a6232b2d...a023094fc417
< jnewbery> vasild: there's something wrong with that peer. It's also not _sending_ pings every two minutes as we'd expect from a Bitcoin Core node
< jnewbery> Jackielove4u: I assume you also dropped the subsequent commit https://github.com/bitcoin/bitcoin/pull/20612/commits/9e806887a8f9ef63431b28d7dfd0470aa663dd02 as well? rc2 and rc3 don't play nice together with that commit, but rc3 <-> rc3 should be fine (and we have big problems if not)
< bitcoin-git> [bitcoin] hebasto opened pull request #20673: depends: Use more legible qmake commands in qt package (master...201216-subdir) https://github.com/bitcoin/bitcoin/pull/20673
< Jackielove4u> i was able to get it fixed though by reverting this commit: https://github.com/bitcoin/bitcoin/pull/20612/commits/9e806887a8f9ef63431b28d7dfd0470aa663dd02
< gribble> https://github.com/bitcoin/bitcoin/issues/20555 | v0.21.0 testing · Issue #20555 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20669 | [0.21] final rc4 backports by MarcoFalke · Pull Request #20669 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #20650: depends: Drop workaround for a fixed bug in Qt build system (master...201214-xcb) https://github.com/bitcoin/bitcoin/pull/20650
< bitcoin-git> bitcoin/master 6af8a62 Jonas Schnelli: Merge #20650: depends: Drop workaround for a fixed bug in Qt build system
< bitcoin-git> bitcoin/master 267f259 Hennadii Stepanov: depends: Drop workaround for a fixed bug in Qt build system
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b440c33179e7...6af8a6232b2d
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20477: net: Add unit testing of node eviction logic (master...unit-test-node-eviction-logic) https://github.com/bitcoin/bitcoin/pull/20477
< bitcoin-git> bitcoin/master fee8823 practicalswift: Assert eviction at >= 29 candidates. Assert non-eviction at <= 20 candidat...
< bitcoin-git> bitcoin/master 685c428 practicalswift: test: Add unit testing of node eviction logic
< bitcoin-git> bitcoin/master ed73f8c practicalswift: net: Move eviction node selection logic to SelectNodeToEvict(...)
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/dff0f6f753ea...b440c33179e7
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #16168: DevelopOmniLayer (master...develop) https://github.com/bitcoin/bitcoin/pull/16168