<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #25156: Disconnect block-relay-only peers with relay permission when they fill tx announcements (master...2205-block-relay-only-why-tx-inv-🤗) https://github.com/bitcoin/bitcoin/pull/25156
<bitcoin-git>
bitcoin/master c9fdaa5 Sebastian Falbesoner: wallet: CreateTransactionInternal(): return out-params as (optional) struct
<bitcoin-git>
bitcoin/master 4c5ceb0 Sebastian Falbesoner: wallet: CreateTransaction(): return out-params as (optional) struct
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #25153: scripted-diff: Use getIntT over get_int/get_int64 (master...2205-uni-int-🗝) https://github.com/bitcoin/bitcoin/pull/25153
<bitcoin-git>
[bitcoin] Empact closed pull request #24455: refactor: Split ArgsManager out of util/system (master...2022-03-util-args-manager) https://github.com/bitcoin/bitcoin/pull/24455
<bitcoin-git>
[bitcoin] Empact opened pull request #25152: refactor: Split util/system into exception, shell, and fs-specific files (master...2022-05-split-system) https://github.com/bitcoin/bitcoin/pull/25152
<david-bakin>
ok. here's a question I have about the bitcoin CR experience vs that I've experienced at companies: Is the line-by-line review not valued in general or is it just the unfortunate lack of reviewers + reviewer's time? IOW, I don't have the experience (yet) to do the "big picture" concept acks/nacks - but I _do_ know how to do close-reading of code for correctness. Is it worth doing?
<sipa>
There is a general philosophical divide on this among projects, but Bitcoin Core follows a very strong squash-before-merging policy.
<bitcoin-git>
[bitcoin] hebasto opened pull request #25149: refactor: Add thread safety annotation to `BanMan::SweepBanned()` (master...220516-bantsa) https://github.com/bitcoin/bitcoin/pull/25149
<bitcoin-git>
[bitcoin] achow101 merged pull request #25019: parse external signer master fp as bytes in ExternalSigner::SignTransaction (master...lower_master_fp_of_ext_signer_in_SignTransaction) https://github.com/bitcoin/bitcoin/pull/25019
<bitcoin-git>
bitcoin/master 2a22f03 avirgovi: parsing external signer master fingerprint string as bytes instead of cari...
<bitcoin-git>
bitcoin/master 91a42d6 Andrew Chow: Merge bitcoin/bitcoin#25019: parse external signer master fp as bytes in E...
<bitcoin-git>
[bitcoin] achow101 merged pull request #25088: Wallet: Ensure m_attaching_chain is set before registering for signals (master...fix_wallet_race_attachingbb) https://github.com/bitcoin/bitcoin/pull/25088
<bitcoin-git>
bitcoin/master ba10b90 Luke Dashjr: Wallet: Ensure m_attaching_chain is set before registering for signals
<bitcoin-git>
bitcoin/master 98f4db3 Andrew Chow: Merge bitcoin/bitcoin#25088: Wallet: Ensure m_attaching_chain is set befor...
<bitcoin-git>
[bitcoin] jnewbery opened pull request #25147: Net processing: follow ups to #20799 (removing support for v1 compact blocks) (master...20205_20799_follow_ups) https://github.com/bitcoin/bitcoin/pull/25147
<bitcoin-git>
[bitcoin] fanquake merged pull request #20799: net processing: Only support version 2 compact blocks (master...2020-12-remove-cmpctblock-v1) https://github.com/bitcoin/bitcoin/pull/20799
<bitcoin-git>
bitcoin/master 42882fc John Newbery: [net processing] Only accept `sendcmpct` with version=2
<bytes1440000>
luke-jr: let me rephrase: its not just consensus related code, bitcoin core can have bugs and vulnerabilities in different thing. Example: CVE-2018–20587
2022-05-15
<bytes1440000>
Bitcoin Core or any bitcoin implementation has lot of things that can be exploited with no soft fork. It can be p2p, mempool wallet, rpc etc. anything
<bytes1440000>
What does that have to do with mempool? Maybe you can read the pull requests that are open in bitcoin core repository related to mempool and discuss lightning
<bytes1440000>
fjahr:iiuc most of the people use 20f2 or 2of3 mutlsig in bitcoin based on https://mempool.observer/monitor/ and 2of2 is mostly used for lightning
<bytes1440000>
fjahr: I understand this channel is used for bitcoin core which is used by majority of bitcoin nodes. Sorry if it was off topic although context was taproot, above messages related to 2of2 multisig and PR #23789
<bytes1440000>
4. Jeremy Rubin made a good point in this comment: https://github.com/bitcoin/bitcoin/pull/23789#issuecomment-998303608 And the observability of this pattern (change matching) is also... pretty observable, especially if bitcoin core (and only upgraded wallets) are the ones doing it.”
<bitcoin-git>
[bitcoin] aureleoules closed pull request #25026: rpc: Make pruneblockchain fetch old blocks if height is lower than pruned height (master...2022-04-pruneblockchain-fetch-old-blocks) https://github.com/bitcoin/bitcoin/pull/25026
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #25117: test: Check msg type in msg capture is followed by zeros (master...2205-test-zero-🚛) https://github.com/bitcoin/bitcoin/pull/25117
<bitcoin-git>
bitcoin/master faa5a7a MacroFake: test: Check msg type in msg capture is followed by zeros
<bitcoin-git>
bitcoin/master 1d5325a MacroFake: Merge bitcoin/bitcoin#25117: test: Check msg type in msg capture is follow...
<bitcoin-git>
[bitcoin] fjahr opened pull request #25123: test: Use addconnection for robustness in index prune test (master...202205-index-prune-fix) https://github.com/bitcoin/bitcoin/pull/25123
<bitcoin-git>
[bitcoin] furszy opened pull request #25122: rpc: getreceivedbylabel, return early if no addresses were found in the address book. (master...2022_RPC_getreceivedbylabel_return_early) https://github.com/bitcoin/bitcoin/pull/25122
<bitcoin-git>
[bitcoin] brunoerg opened pull request #25121: test: compare `/mempool/info` response with `getmempoolinfo` RPC (master...2022-05-rest-mempool-info) https://github.com/bitcoin/bitcoin/pull/25121
<gribble>
https://github.com/bitcoin/bitcoin/issues/22954 | [TESTS] Allow tx_invalid.json tests to include flag rules for if_unset: [A,B,C] then_unset: [D] by JeremyRubin · Pull Request #22954 · bitcoin/bitcoin · GitHub
<gribble>
https://github.com/bitcoin/bitcoin/issues/22876 | [TESTS] Update Transaction Tests to permit setting a flag as always on and disabling the exhaustive failure test by JeremyRubin · Pull Request #22876 · bitcoin/bitcoin · GitHub
<bitcoin-git>
[bitcoin] jonatack opened pull request #25120: test: fix DWARF string_view linker error in blockfilter_tests (master...fix-DWARF-string_view-linker-error) https://github.com/bitcoin/bitcoin/pull/25120
<bitcoin-git>
[bitcoin] jonatack opened pull request #25119: net, refactor: move StartExtraBlockRelayPeers() from header to implementation (master...move-StartExtraBlockRelayPeers-from-header-to-implementation) https://github.com/bitcoin/bitcoin/pull/25119
<bitcoin-git>
[bitcoin] furszy opened pull request #25118: wallet: unify “allow/block other inputs“ concept (master...2022_coinControl_unify_allowOtherInputs) https://github.com/bitcoin/bitcoin/pull/25118
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #25117: test: Check msg type in msg capture is followed by zeros (master...2205-test-zero-🚛) https://github.com/bitcoin/bitcoin/pull/25117
<bitcoin-git>
[bitcoin] fanquake closed pull request #18988: RFC: Introducing AltNet, a pluggable framework for alternative transports (master...2020-05-rfc-altstack) https://github.com/bitcoin/bitcoin/pull/18988
<bitcoin-git>
[bitcoin] fanquake closed pull request #19880: fix CTxMemPool::TrimToSize to put only confirmed coins in pvNoSpendsRemaining (master...simplify-trimtosize) https://github.com/bitcoin/bitcoin/pull/19880
<bitcoin-git>
[bitcoin] fanquake closed pull request #19358: torcontrol : avoid to set wrong outbound proxy and network settings when creating an inbound onion service. (master...pr351-bitcoin) https://github.com/bitcoin/bitcoin/pull/19358
<bitcoin-git>
[bitcoin] fanquake closed pull request #18689: rpc: allow dumptxoutset to dump human-readable data (master...feature-utxo-ascii) https://github.com/bitcoin/bitcoin/pull/18689
<laanwj>
seems like a bug (though, there are various compromises with regard to bitcoin-qt initialization, that might make it necessary to initialize qt before showing the options/help, dunno)
<bitcoin-git>
[bitcoin] theStack opened pull request #25114: rpc: remove deprecated "softforks" field from getblockchaininfo (master...202205-rpc-remove_deprecated_softforks_from_getblockchaininfo) https://github.com/bitcoin/bitcoin/pull/25114
<earnestly>
Is it possible to generate the manuals without X11 (for bitcoin-qt)? It appears when using --version, I get 'qt.qpa.xcb: could not connect to display' and an IOT instruction abort
<sipa>
bitcoin core is really intended to be able to connect to the network; if there are things it can do without, those should be moved (or at least made accessible) to utility binaries
<sipa>
Yeah, that's fair. There really should be a utility binary that can do offline signing with all the features bitcoin core itself has.
<sipa>
Earnestly: I don't think so. But why are you running bitcoin core in the first place then?
<bitcoin-git>
[bitcoin] fanquake opened pull request #25110: tidy: use modernize-use-raw-string-literal (master...modernize_use_raw_string_literal) https://github.com/bitcoin/bitcoin/pull/25110
<bitcoin-git>
[bitcoin] laanwj opened pull request #25107: bench: Add `--one-iteration` flag, use it in `make check` (master...2022-05-bench-one-iteration) https://github.com/bitcoin/bitcoin/pull/25107
<bitcoin-git>
[gui] hebasto merged pull request #591: test: Add tests for `tableView` in `AddressBookPage` dialog (master...220423-test-ab) https://github.com/bitcoin-core/gui/pull/591
<bitcoin-git>
[bitcoin] david-bakin opened pull request #25097: Unit tests for taproot/tapscript coverage in `interpreter.cpp` (master...23279-taproot-unit-tests) https://github.com/bitcoin/bitcoin/pull/25097
<bitcoin-git>
[bitcoin] dergoegge opened pull request #25096: [net] Minor improvements to addr caching (master...2022-05-improve-addr-cache) https://github.com/bitcoin/bitcoin/pull/25096
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #25095: rpc: Fix implicit-integer-sign-change in gettxout (master...2205-rpc-int-ubsan-😛) https://github.com/bitcoin/bitcoin/pull/25095
<bitcoin-git>
[gui] furszy opened pull request #598: Avoid recalculating the wallet balance - use model cache (master...2022_GUI_use_model_cached_balance) https://github.com/bitcoin-core/gui/pull/598
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #25093: rpc: Fix incorrect sendmany doc and check all docs (master...2205-doc-rpc-opt-🚈) https://github.com/bitcoin/bitcoin/pull/25093
<bitcoin-git>
[bitcoin] jonatack opened pull request #25092: doc: various developer notes updates (master...developer-notes-updates-may-2022) https://github.com/bitcoin/bitcoin/pull/25092
<bitcoin-git>
[bitcoin] luke-jr opened pull request #25088: Wallet: Ensure m_attaching_chain is set before registering for signals (master...fix_wallet_race_attachingbb) https://github.com/bitcoin/bitcoin/pull/25088
2022-05-08
<bitcoin-git>
[bitcoin] theStack opened pull request #25087: test: use MiniWallet for feature_dbcrash.py (master...202205-test-use_MiniWallet_for_feature_dbcrash) https://github.com/bitcoin/bitcoin/pull/25087
<bitcoin-git>
[bitcoin] ishaanam opened pull request #25083: Set effective_value when initializing a COutput (master...draft-CalculateEffectiveValue2) https://github.com/bitcoin/bitcoin/pull/25083
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #25077: Fix chain tip data race and corrupt rest response (master...2205-tip-race-🤠) https://github.com/bitcoin/bitcoin/pull/25077
<bitcoin-git>
[bitcoin] fanquake opened pull request #25076: guix: native GCC 10 toolchain for Linux builds (master...native_gcc_10_linux) https://github.com/bitcoin/bitcoin/pull/25076
<bitcoin-git>
[bitcoin] mzumsande opened pull request #25074: index: During sync, commit best block after indexing (master...202205_index_sync_order) https://github.com/bitcoin/bitcoin/pull/25074