2020-12-10

< bitcoin-git> bitcoin/0.20 a4bc4c1 Wladimir J. van der Laan: doc: Update manual pages pre-rc1
< bitcoin-git> bitcoin/0.20 98c9d79 Wladimir J. van der Laan: gui: Pre-rc1 translations update
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.20: https://github.com/bitcoin/bitcoin/compare/2808593b7c8c...a4bc4c1f79d7
< jonasschnelli> luke-jr: macOS builds are fast (my script does that first): https://bitcoin.jonasschnelli.ch/gitian/build/358
< jonasschnelli> bb8c59034420709cdbae2e47ec1a1dce03c68ab4142ff3b67a23c415e6557be1 bitcoin-0.21.0rc3-osx-unsigned.dmg
< jonasschnelli> then probably: ./gitian-build.py --setup (see https://github.com/bitcoin-core/docs/blob/master/gitian-building.md)
< bitcoin-git> [bitcoin] laanwj pushed tag v0.21.0rc3: https://github.com/bitcoin/bitcoin/compare/v0.21.0rc3
< bitcoin-git> bitcoin/0.20 2808593 Wladimir J. van der Laan: build: Bump version to 0.20.2rc1
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.20: https://github.com/bitcoin/bitcoin/compare/953dddbd2058...2808593b7c8c
< core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
< core-meetingbot> Meeting started Thu Dec 10 19:26:15 2020 UTC. The chair is jonasschnelli. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
< bitcoin-git> bitcoin/0.19 5f2f304 Wladimir J. van der Laan: build: Bump version to 0.19.2rc1
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.19: https://github.com/bitcoin/bitcoin/compare/5baaea4410a1...5f2f304cbec9
< wumpus> Murch: yes a bit of a inside joke there was some discussion about bitcoin units again on twitter
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19740: [0.20] wallet: Simplify and fix CWallet::SignTransaction (0.20...backport-17204-fix) https://github.com/bitcoin/bitcoin/pull/19740
< bitcoin-git> bitcoin/0.20 953dddb MarcoFalke: Merge #19740: [0.20] wallet: Simplify and fix CWallet::SignTransaction
< bitcoin-git> bitcoin/0.20 6a326cf Andrew Chow: tests: Test that a fully signed tx given to signrawtx is unchanged
< bitcoin-git> bitcoin/0.20 2d48d7d Andrew Chow: Simplify and fix CWallet::SignTransaction
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to 0.20: https://github.com/bitcoin/bitcoin/compare/75bf23d8613a...953dddbd2058
< gribble> https://github.com/bitcoin/bitcoin/issues/20546 | policy, wallet, refactor: check for non-representable CFeeRates by jonatack · Pull Request #20546 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19740 | [0.20] wallet: Simplify and fix CWallet::SignTransaction by achow101 · Pull Request #19740 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19858 | Periodically make block-relay connections and sync headers by sdaftuar · Pull Request #19858 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20040 | wallet: Refactor OutputGroups to handle fees and spending eligibility on grouping by achow101 · Pull Request #20040 · bitcoin/bitcoin · GitHub
< wumpus> no proposed topics for this week on http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
< bitcoin-git> bitcoin/0.21 9ae536d Wladimir J. van der Laan: build: Bump RC to rc3
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.21: https://github.com/bitcoin/bitcoin/compare/e6d0fa3ef6f6...9ae536d3684e
< wumpus> #bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik
< bitcoin-git> bitcoin/0.21 e6d0fa3 Wladimir J. van der Laan: gui: pre-rc3 translations update
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.21: https://github.com/bitcoin/bitcoin/compare/3fee499bc3af...e6d0fa3ef6f6
< bitcoin-git> [bitcoin] hebasto closed pull request #19882: depends: Export variables from make to environment explicitly (master...200905-build) https://github.com/bitcoin/bitcoin/pull/19882
< bitcoin-git> [bitcoin] laanwj merged pull request #20612: [0.21] final rc3 backports (0.21...2012-finalRc3Backports) https://github.com/bitcoin/bitcoin/pull/20612
< bitcoin-git> bitcoin/0.21 06c8423 Jon Atack: wallet, bugfix: allow send to take string fee rate values
< bitcoin-git> bitcoin/0.21 bead935 Pieter Wuille: Send and require SENDADDRV2 before VERACK
< bitcoin-git> bitcoin/0.21 9e80688 Pieter Wuille: Don't send 'sendaddrv2' to pre-70016 software
< bitcoin-git> [bitcoin] laanwj pushed 12 commits to 0.21: https://github.com/bitcoin/bitcoin/compare/aa4b8ebfecdd...3fee499bc3af
< bitcoin-git> [bitcoin] ariard opened pull request #20617: p2p: Remove m_is_manual_connection from CNodeState (master...2020-12-remove-is-manual-connection) https://github.com/bitcoin/bitcoin/pull/20617
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20613: test: Use Popen.wait instead of RPC in assert_start_raises_init_error (master...2012-testFastFailInitError) https://github.com/bitcoin/bitcoin/pull/20613
< bitcoin-git> bitcoin/master da957cd MarcoFalke: Merge #20613: test: Use Popen.wait instead of RPC in assert_start_raises_i...
< bitcoin-git> bitcoin/master fa918dd MarcoFalke: test: Use Popen.wait instead of RPC in assert_start_raises_init_error
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b76abae387b9...da957cd62ecc
< bitcoin-git> [bitcoin] lontivero opened pull request #20616: Check CJDNS address is valid (master...validate-cjdns-addresses) https://github.com/bitcoin/bitcoin/pull/20616
< gribble> https://github.com/bitcoin/bitcoin/issues/19858 | Periodically make block-relay connections and sync headers by sdaftuar · Pull Request #19858 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19763 | net: dont try to relay to the address originator by vasild · Pull Request #19763 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20615: cirrus: Schedule one task with paid credits for faster CI feedback (master...2012-ciFasterFeedback) https://github.com/bitcoin/bitcoin/pull/20615
< queip> the "score" field in getnetworkinfo, what does it actually mean? we are confused about it trying to provide support to user in #bitcoin . Could RPC help xxx command include short explanation for the outputed JSON fields for most commands?
< bitcoin-git> [bitcoin] Sjors opened pull request #20614: util: RunCommandParseJSON followups (master...2020/12/build-aux) https://github.com/bitcoin/bitcoin/pull/20614
< bitcoin-git> [bitcoin] laanwj merged pull request #20587: [doc] Tidy up Tor doc (more stringent) (master...patch-2) https://github.com/bitcoin/bitcoin/pull/20587
< bitcoin-git> bitcoin/master b76abae Wladimir J. van der Laan: Merge #20587: [doc] Tidy up Tor doc (more stringent)
< bitcoin-git> bitcoin/master 32045bb wodry: [doc] Tidy up Tor doc (more stringent)
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/86f20071931b...b76abae387b9
< gribble> https://github.com/bitcoin/bitcoin/issues/19858 | Periodically make block-relay connections and sync headers by sdaftuar · Pull Request #19858 · bitcoin/bitcoin · GitHub
< hebasto> promag: the combined branch for qml static builds https://github.com/hebasto/bitcoin/commits/201210-qml
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #20527: build: Do not ignore Homebrew's SQLite on macOS (master...201129-sqlite) https://github.com/bitcoin/bitcoin/pull/20527
< bitcoin-git> bitcoin/master c932e0d Hennadii Stepanov: doc: Update wallet database installation guide for macOS
< bitcoin-git> bitcoin/master ee7b84e Hennadii Stepanov: build: Use Homebrew's sqlite package if it is available
< bitcoin-git> bitcoin/master c96d1f6 Hennadii Stepanov: build, refactor: Check that Homebrew's qt5 package is actually installed
< bitcoin-git> [bitcoin] jonasschnelli pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/8e1f9d62731c...86f20071931b
< bitcoin-git> [bitcoin] laanwj merged pull request #20549: Support make src/bitcoin-node and src/bitcoin-gui (master...2020-12-make-bitcoin-node) https://github.com/bitcoin/bitcoin/pull/20549
< bitcoin-git> bitcoin/master 8e1f9d6 Wladimir J. van der Laan: Merge #20549: Support make src/bitcoin-node and src/bitcoin-gui
< bitcoin-git> bitcoin/master 206f74e João Barbosa: Support make src/bitcoin-node and src/bitcoin-gui
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e20b488395c1...8e1f9d62731c
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20613: test: Use Popen.wait instead of RPC in assert_start_raises_init_error (master...2012-testFastFailInitError) https://github.com/bitcoin/bitcoin/pull/20613
< bitcoin-git> [bitcoin] laanwj merged pull request #20567: test: Add option to git-subtree-check to do full check, add help (master...2020_12_subtree_check) https://github.com/bitcoin/bitcoin/pull/20567
< bitcoin-git> bitcoin/master e20b488 Wladimir J. van der Laan: Merge #20567: test: Add option to git-subtree-check to do full check, add ...
< bitcoin-git> bitcoin/master 34c80d9 Wladimir J. van der Laan: test: Add option to git-subtree-check to do full check, add help
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/dcff2ee1fbf4...e20b488395c1
< bitcoin-git> [bitcoin] laanwj merged pull request #20589: log: Clarify that failure to read/write fee_estimates.dat is non-fatal (master...2012-logFeeest) https://github.com/bitcoin/bitcoin/pull/20589
< bitcoin-git> bitcoin/master fa0d835 MarcoFalke: log: Clarify that failure to read fee_estimates.dat is non-fatal
< bitcoin-git> bitcoin/master dcff2ee Wladimir J. van der Laan: Merge #20589: log: Clarify that failure to read/write fee_estimates.dat is...
< bitcoin-git> bitcoin/master faefa5d MarcoFalke: log: Clarify that failure to write fee_estimates.dat is non-fatal
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/eb53c03b3680...dcff2ee1fbf4
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20612: [0.21] final rc3 backports (0.21...2012-finalRc3Backports) https://github.com/bitcoin/bitcoin/pull/20612
< promag> fanquake: I have an issue, not sure how to proceed. see https://github.com/icota/bitcoin/commit/683710e072eb90296ae5a57f53bce7cac799fc41
< bitcoin-git> [bitcoin] laanwj merged pull request #20595: Improve heuristic hex transaction decoding (master...202012_fancy_tx_hex_decode) https://github.com/bitcoin/bitcoin/pull/20595
< bitcoin-git> bitcoin/master eb53c03 Wladimir J. van der Laan: Merge #20595: Improve heuristic hex transaction decoding
< bitcoin-git> bitcoin/master 39c42c4 Pieter Wuille: Improve heuristic hex transaction decoding
< bitcoin-git> bitcoin/master 0f949cd Pieter Wuille: Add regression test for incorrect decoding
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c8fdbb46bd92...eb53c03b3680
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20611: Move TX_MAX_STANDARD_VERSION to policy (master...2012-mvTxStandardVersion) https://github.com/bitcoin/bitcoin/pull/20611
< az0re> (I am new to the Bitcoin codebase and would appreciate some tips on the most relevant data structures)
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20609: configure: output notice that test binary is disabled by fuzzing (master...2020-12--fuzz-config-output) https://github.com/bitcoin/bitcoin/pull/20609
< bitcoin-git> bitcoin/master c8fdbb4 MarcoFalke: Merge #20609: configure: output notice that test binary is disabled by fuz...
< bitcoin-git> bitcoin/master 904d875 Andrew Poelstra: configure: output notice that test binary is disabled by fuzzing
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/38176dc66523...c8fdbb46bd92
< bitcoin-git> [bitcoin] jarolrod opened pull request #20610: doc: update for NetBSD 9.1, add GUI Build Instructions (master...netbsd-docs) https://github.com/bitcoin/bitcoin/pull/20610
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20573: wallet, bugfix: allow send with string fee_rate amounts (master...send-allow-feerates-as-strings) https://github.com/bitcoin/bitcoin/pull/20573
< bitcoin-git> bitcoin/master 38176dc MarcoFalke: Merge #20573: wallet, bugfix: allow send with string fee_rate amounts
< bitcoin-git> bitcoin/master 6fa72ce Jon Atack: test: add coverage for passing fee rate as a string
< bitcoin-git> bitcoin/master ce207d6 Jon Atack: wallet, bugfix: allow send to take string fee rate values
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/22f13c1e088e...38176dc66523
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19776: net, rpc: expose high bandwidth mode state via getpeerinfo (master...20200821-rpc-expose-high-handwidth-mode-state-via-getpeerinfo) https://github.com/bitcoin/bitcoin/pull/19776
< bitcoin-git> bitcoin/master dab6583 Sebastian Falbesoner: doc: release note for new getpeerinfo fields "bip152_hb_{from,to}"
< bitcoin-git> bitcoin/master a7ed00f Sebastian Falbesoner: rpc: expose high-bandwidth mode states via getpeerinfo
< bitcoin-git> bitcoin/master 30bc8fa Sebastian Falbesoner: net: save high-bandwidth mode states in CNodeStats
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/f5b2ea3e5918...22f13c1e088e
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20217: net: Remove g_relay_txes (master...2020-10-remove-grelaytxes) https://github.com/bitcoin/bitcoin/pull/20217
< bitcoin-git> bitcoin/master 4d510aa John Newbery: [init] Use MakeUnique<> to construct peerman
< bitcoin-git> bitcoin/master f3f61d0 John Newbery: [net processing] Add IgnoresIncomingTxs() function to PeerManager
< bitcoin-git> bitcoin/master 5805b82 John Newbery: [net processing] Move PushNodeVersion into PeerManager
< bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/054710615c5e...f5b2ea3e5918
< bitcoin-git> [bitcoin] fanquake merged pull request #20608: contrib: add symbol check test for PE binaries (master...symbol_check_test_pe) https://github.com/bitcoin/bitcoin/pull/20608
< bitcoin-git> bitcoin/master 0547106 fanquake: Merge #20608: contrib: add symbol check test for PE binaries
< bitcoin-git> bitcoin/master ae9b489 fanquake: contrib: add symbol check test for PE
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/17918a987aee...054710615c5e
< bitcoin-git> [bitcoin] fanquake merged pull request #20046: depends: Set CMAKE_INSTALL_RPATH for native packages (master...pr/ipc-rpath) https://github.com/bitcoin/bitcoin/pull/20046
< bitcoin-git> bitcoin/master 17918a9 fanquake: Merge #20046: depends: Set CMAKE_INSTALL_RPATH for native packages
< bitcoin-git> bitcoin/master 7d0271b Russell Yanofsky: depends: Set CMAKE_INSTALL_RPATH for native packages
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0038ce97584f...17918a987aee
< gribble> https://github.com/bitcoin/bitcoin/issues/20560 | fuzz: Link all targets once by MarcoFalke · Pull Request #20560 · bitcoin/bitcoin · GitHub

2020-12-09

< bitcoin-git> [bitcoin] apoelstra opened pull request #20609: configure: output notice that test binary is disabled by fuzzing (master...2020-12--fuzz-config-output) https://github.com/bitcoin/bitcoin/pull/20609
< bitcoin-git> [gui] luke-jr opened pull request #148: Bugfix: GUI: Restore SendConfirmationDialog button default to "Yes" (master...bugfix_gui_bumpyes) https://github.com/bitcoin-core/gui/pull/148
< bitcoin-git> [bitcoin] laanwj merged pull request #20603: build: Update crc32c subtree (master...2012-crcSubtree) https://github.com/bitcoin/bitcoin/pull/20603
< bitcoin-git> bitcoin/master 0038ce9 Wladimir J. van der Laan: Merge #20603: build: Update crc32c subtree
< bitcoin-git> bitcoin/master fa7c8d1 MarcoFalke: build: Update crc32c subtree
< bitcoin-git> bitcoin/master 90c0f26 MarcoFalke: Squashed 'src/crc32c/' changes from 224988680f..b5ef9be675
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/7212db4d2a55...0038ce97584f
< gribble> https://github.com/bitcoin/bitcoin/issues/19858 | Periodically make block-relay connections and sync headers by sdaftuar · Pull Request #19858 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20602: util: Allow use of C++14 chrono literals (master...2012-chronoLiterals) https://github.com/bitcoin/bitcoin/pull/20602
< bitcoin-git> bitcoin/master 7212db4 MarcoFalke: Merge #20602: util: Allow use of C++14 chrono literals
< bitcoin-git> bitcoin/master fa11110 MarcoFalke: util: Allow use of C++14 chrono literals
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/42ed7f51fafa...7212db4d2a55
< bitcoin-git> [bitcoin] laanwj merged pull request #20606: Remove unused bits from service flags enum (master...2012-netServiceFlags) https://github.com/bitcoin/bitcoin/pull/20606
< bitcoin-git> bitcoin/master 42ed7f5 Wladimir J. van der Laan: Merge #20606: Remove unused bits from service flags enum
< bitcoin-git> bitcoin/master fa40168 MarcoFalke: Remove unused bits from service flags enum
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/795afe6e63a1...42ed7f51fafa
< bitcoin-git> [bitcoin] fanquake opened pull request #20608: contrib: add symbol check test for PE binaries (master...symbol_check_test_pe) https://github.com/bitcoin/bitcoin/pull/20608
< bitcoin-git> [bitcoin] fanquake merged pull request #19910: net processing: Move peer_map to PeerManager (master...2020-08-peer-plv2) https://github.com/bitcoin/bitcoin/pull/19910
< bitcoin-git> bitcoin/master a20ab22 John Newbery: [net processing] Make GetPeerRef const
< bitcoin-git> bitcoin/master a529fd3 John Newbery: [net processing] Move GetNodeStateStats into PeerManager
< bitcoin-git> bitcoin/master ed7e469 John Newbery: [net_processing] Move peer_map to PeerManager
< bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/a3586d592078...795afe6e63a1
< bitcoin-git> [bitcoin] naumenkogs reopened pull request #19843: Refactoring and minor improvement for self-advertisements (master...2020-08-refactor-advertiselocal) https://github.com/bitcoin/bitcoin/pull/19843
< bitcoin-git> [bitcoin] naumenkogs closed pull request #19843: Refactoring and minor improvement for self-advertisements (master...2020-08-refactor-advertiselocal) https://github.com/bitcoin/bitcoin/pull/19843
< gribble> https://github.com/bitcoin/bitcoin/issues/14066 | gitian-linux: Build binaries for 64-bit POWER by luke-jr · Pull Request #14066 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20434 | contrib: Parse ELF directly for symbol and security checks by laanwj · Pull Request #20434 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20606: Remove unused bits from service flags enum (master...2012-netServiceFlags) https://github.com/bitcoin/bitcoin/pull/20606
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20323: tests: Create or use existing properly initialized NodeContexts (master...2020-10-chainman-fixes) https://github.com/bitcoin/bitcoin/pull/20323
< bitcoin-git> bitcoin/master a3586d5 MarcoFalke: Merge #20323: tests: Create or use existing properly initialized NodeConte...
< bitcoin-git> bitcoin/master 81137c6 Carl Dong: test: Add new ChainTestingSetup and use it
< bitcoin-git> bitcoin/master 7e9e7fe Carl Dong: qt/test: [FIX] Add forgotten Context setting in RPCNestedTests
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/90ef622ab534...a3586d592078
< gribble> https://github.com/bitcoin/bitcoin/issues/17145 | GUI event loop should be block free · Issue #17145 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20564: Don't send 'sendaddrv2' to pre-70016 software, and send before 'verack' (master...202012_no_old_sendaddrv2) https://github.com/bitcoin/bitcoin/pull/20564
< bitcoin-git> bitcoin/master 90ef622 MarcoFalke: Merge #20564: Don't send 'sendaddrv2' to pre-70016 software, and send befo...
< bitcoin-git> bitcoin/master 1583498 Pieter Wuille: Send and require SENDADDRV2 before VERACK
< bitcoin-git> bitcoin/master c5a8919 Pieter Wuille: Don't send 'sendaddrv2' to pre-70016 software
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/e98d1d674091...90ef622ab534
< bitcoin-git> [gui] RandyMcMillan opened pull request #147: splash:bitcoin branding and cleanup (master...splash) https://github.com/bitcoin-core/gui/pull/147

2020-12-08

< bitcoin-git> [bitcoin] laanwj opened pull request #20605: init: Signal-safe instant shutdown (master...2020_12_instant_shutdown) https://github.com/bitcoin/bitcoin/pull/20605
< bitcoin-git> [gui] RandyMcMillan opened pull request #146: modeloverlay:make transition faster (master...modal) https://github.com/bitcoin-core/gui/pull/146
< queip> some users looking at bitcoin-qt have a feeling that node "is stuck". Perhaps GUI is not re-assuring enough progress is happening. This leads to second problem: "bored" users then look into debug.log and some of normal messages look "worrying" like the ones with invalid blocks, rejected peers (result of forkcoin peers). Apparently some users think node is not working and seek help then
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19425: refactor: Get rid of more redundant chain methods (master...pr/next) https://github.com/bitcoin/bitcoin/pull/19425
< bitcoin-git> bitcoin/master 5baa88f Russell Yanofsky: test: Remove no longer needed MakeChain calls
< bitcoin-git> bitcoin/master 6965f13 Russell Yanofsky: refactor: Replace uses ChainActive() in interfaces/chain.cpp
< bitcoin-git> bitcoin/master 3fbbb9a Russell Yanofsky: refactor: Get rid of more redundant chain methods
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/16b31cc4c516...e98d1d674091
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20603: build: Update crc32c subtree (master...2012-crcSubtree) https://github.com/bitcoin/bitcoin/pull/20603
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20602: util: Allow use of C++14 chrono literals (master...2012-chronoLiterals) https://github.com/bitcoin/bitcoin/pull/20602
< bitcoin-git> [bitcoin] jarolrod opened pull request #20601: doc: Update for FreeBSD 12.2, add GUI Build Instructions (master...master) https://github.com/bitcoin/bitcoin/pull/20601
< bitcoin-git> [bitcoin] BlockMechanic opened pull request #20600: Depends : Qt Use Top-Level Structure (master...add-qml-depends) https://github.com/bitcoin/bitcoin/pull/20600
< jnewbery> sipa: that's correct. The address that we send may also be different in those two cases: https://github.com/bitcoin/bitcoin/pull/19843#issuecomment-707679704
< gribble> https://github.com/bitcoin/bitcoin/issues/19658 | [rpc] Allow RPC to fetch all addrman records and add records to addrman by jnewbery · Pull Request #19658 · bitcoin/bitcoin · GitHub
< vasild> it is trivial patch, but not very convenient to use: https://github.com/vasild/bitcoin/commit/f51d964575709806d26f2401a41e9794cb39d414
< bitcoin-git> [bitcoin] jnewbery opened pull request #20599: [net processing] Tolerate sendheaders and sendcmpct messages before verack (master...2020-12-tolerate-early-send-messages) https://github.com/bitcoin/bitcoin/pull/20599
< bitcoin-git> [bitcoin] fanquake merged pull request #20422: build: mac deployment unification (master...macdeploy_unify) https://github.com/bitcoin/bitcoin/pull/20422
< bitcoin-git> bitcoin/master 827d382 fanquake: macdeploy: remove add-resources argument
< bitcoin-git> bitcoin/master 464b34d fanquake: macdeploy: remove codesigning argument
< bitcoin-git> bitcoin/master 4d70d3d fanquake: build: automatically determine macOS translations
< bitcoin-git> [bitcoin] fanquake pushed 12 commits to master: https://github.com/bitcoin/bitcoin/compare/1a9fa4c5ba27...16b31cc4c516
< bitcoin-git> [bitcoin] RandyMcMillan closed pull request #20597: bug fix: bitcoind -h & -version output logic fixes issue #20596 (master...bitcoind-h-logic) https://github.com/bitcoin/bitcoin/pull/20597
< bitcoin-git> [bitcoin] RandyMcMillan opened pull request #20597: bug fix: bitcoind -h & -version output logic fixes issue #20596 (master...bitcoind-h-logic) https://github.com/bitcoin/bitcoin/pull/20597

2020-12-07

< hebasto> sipa> Pieter Wuille hebasto: 01:13:58 the opposition to that idea was on the bitcoin-dev mailing list -- mind point out?
< sipa> the opposition to that idea was on the bitcoin-dev mailing list
< bitcoin-git> [bitcoin] laanwj merged pull request #20561: p2p: periodically clear m_addr_known (master...2020-12-moar-addrz) https://github.com/bitcoin/bitcoin/pull/20561
< bitcoin-git> bitcoin/master 1a9fa4c Wladimir J. van der Laan: Merge #20561: p2p: periodically clear m_addr_known
< bitcoin-git> bitcoin/master 65273fa Suhas Daftuar: Clear m_addr_known before our periodic self-advertisement
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d38feb6134e2...1a9fa4c5ba27
< bitcoin-git> [bitcoin] sipa opened pull request #20595: Improve heuristic hex decoding (master...202012_fancy_tx_hex_decode) https://github.com/bitcoin/bitcoin/pull/20595
< gribble> https://github.com/bitcoin/bitcoin/issues/19843 | Refactoring and minor improvement for self-advertisements by naumenkogs · Pull Request #19843 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20594 | Fix getauxval calls in randomenv.cpp by jonasschnelli · Pull Request #20594 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20594 | Fix getauxval calls in randomenv.cpp by jonasschnelli · Pull Request #20594 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #20594: Fix getauxval calls in randomenv.cpp (master...2020/12/getauxval) https://github.com/bitcoin/bitcoin/pull/20594
< sipa> jonasschnelli: plz test if it actually works with bitcoin core before acking :)
< jonasschnelli> Related to that though different: I think commit https://github.com/bitcoin/bitcoin/commit/330cb33985d0ce97c20f4a0f0bbda0fbffe098d4 did had no effect
< wumpus> yes, bitcoin-fork is the branch we use
< gribble> https://github.com/bitcoin/bitcoin/issues/41 | Display version in help by mhanne · Pull Request #41 · bitcoin/bitcoin · GitHub
< sipa> jonasschnelli: we use the "bitcoin-fork" branch i think
< wumpus> jonasschnelli: I think you missed it, see https://github.com/bitcoin-core/crc32c
< jonasschnelli> wumpus: I tried to update the crc32c subtree but it looks like our subtree has a commit unknown to upstream (https://github.com/bitcoin/bitcoin/commit/2e1819311a59fb5cb26e3ca50a510bfe01358350)
< bitcoin-git> [bitcoin] laanwj merged pull request #20535: test: Fix intermittent feature_taproot issue (master...2011-testTapInt) https://github.com/bitcoin/bitcoin/pull/20535
< bitcoin-git> bitcoin/master d38feb6 Wladimir J. van der Laan: Merge #20535: test: Fix intermittent feature_taproot issue
< bitcoin-git> bitcoin/master fa275e1 MarcoFalke: test: Fix intermittent feature_taproot issue
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5c4911e7e752...d38feb6134e2
< bitcoin-git> [bitcoin] jonatack opened pull request #20592: p2p: update wtxidrelay documentation per BIP339 (master...update-wtxid-documentation-per-BIP339) https://github.com/bitcoin/bitcoin/pull/20592
< bitcoin-git> [bitcoin] BitcoinTsunami opened pull request #20591: wallet, bugfix: fix ComputeTimeSmart function during rescanning process. fixes #20181 (master...fix-computetimesmart) https://github.com/bitcoin/bitcoin/pull/20591
< vasild> updated https://github.com/bitcoin/bips/pull/1043 - "send sendaddrv2 berfore sending verack"
< gribble> https://github.com/bitcoin/bitcoin/issues/20579 | invalid transaction decoding · Issue #20579 · bitcoin/bitcoin · GitHub
< vasild> right now bitcoin core is the only implementation that exists, I guess. I would be a problem if another implementation arrives that expects sendaddrv2 at a certain time and is upset otherwise
< vasild> sipa: wumpus: wrt sending sendaddrv2 and the difference between the code and the BIP, I opened https://github.com/bitcoin/bips/pull/1043 to change the BIP.
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20589: log: Clarify that failure to read/write fee_estimates.dat is non-fatal (master...2012-logFeeest) https://github.com/bitcoin/bitcoin/pull/20589
< bitcoin-git> [bitcoin] laanwj merged pull request #20568: doc: Use FeeModes doc helper in estimatesmartfee (master...2012-rpcDocFee) https://github.com/bitcoin/bitcoin/pull/20568
< bitcoin-git> bitcoin/master 5c4911e Wladimir J. van der Laan: Merge #20568: doc: Use FeeModes doc helper in estimatesmartfee
< bitcoin-git> bitcoin/master fa8abdc MarcoFalke: rpc: Use FeeModes doc helper in estimatesmartfee
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/03b1db611495...5c4911e7e752
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18766: Disable fee estimation in blocksonly mode (by removing the fee estimates global) (master...disable_feeest_blocksonly) https://github.com/bitcoin/bitcoin/pull/18766
< bitcoin-git> bitcoin/master 86ff2cf Antoine Poinsot: Remove the remaining fee estimation globals
< bitcoin-git> bitcoin/master e8ea6ad Antoine Poinsot: init: don't create a CBlockPolicyEstimator if we don't relay transactions
< bitcoin-git> bitcoin/master 03bfeee Antoine Poinsot: interface: remove unused estimateSmartFee method from node
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/00f4dcd5520e...03b1db611495
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20138: net: Assume that SetCommonVersion is called at most once per peer (master...2010-netVersionOnlyOnce) https://github.com/bitcoin/bitcoin/pull/20138
< bitcoin-git> bitcoin/master 00f4dcd MarcoFalke: Merge #20138: net: Assume that SetCommonVersion is called at most once per...
< bitcoin-git> bitcoin/master fa0f415 MarcoFalke: net: Assume that SetCommonVersion is called at most once per peer
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f3e17686b37a...00f4dcd5520e
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20588: Remove unused and confusing CTransaction constructor (master...2012-txConstructor) https://github.com/bitcoin/bitcoin/pull/20588
< bitcoin-git> [bitcoin] laanwj reopened pull request #20434: contrib: Parse ELF directly for symbol and security checks (master...2020_11_pixie) https://github.com/bitcoin/bitcoin/pull/20434
< bitcoin-git> [bitcoin] laanwj closed pull request #20434: contrib: Parse ELF directly for symbol and security checks (master...2020_11_pixie) https://github.com/bitcoin/bitcoin/pull/20434
< bitcoin-git> [bitcoin] laanwj merged pull request #20468: build: warn when generating man pages for binaries built from a dirty branch (master...fix-20412) https://github.com/bitcoin/bitcoin/pull/20468
< bitcoin-git> bitcoin/master f3e1768 Wladimir J. van der Laan: Merge #20468: build: warn when generating man pages for binaries built fro...
< bitcoin-git> bitcoin/master 6690adb Tyler Chambers: Warn when binaries are built from a dirty branch.
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/31438cc8184f...f3e17686b37a
< bitcoin-git> [bitcoin] laanwj merged pull request #20482: Add depends qt fix for ARM macs (master...2020/11/qt_mac_arm) https://github.com/bitcoin/bitcoin/pull/20482
< bitcoin-git> bitcoin/master 31438cc Wladimir J. van der Laan: Merge #20482: Add depends qt fix for ARM macs
< bitcoin-git> bitcoin/master c23f6f8 Jonas Schnelli: Add depends qt fix for ARM macs
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/eab63b971d5f...31438cc8184f
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #19847: rpc, refactor: Avoid duplicate set lookup in gettxoutproof (master...2020-08-gettxoutproof) https://github.com/bitcoin/bitcoin/pull/19847
< bitcoin-git> bitcoin/master eab63b9 Jonas Schnelli: Merge #19847: rpc, refactor: Avoid duplicate set lookup in gettxoutproof
< bitcoin-git> bitcoin/master 52fc399 João Barbosa: rpc: Reject empty txids in gettxoutproof
< bitcoin-git> bitcoin/master 73dc19a João Barbosa: rpc, refactor: Avoid duplicate set lookup in gettxoutproof
< bitcoin-git> [bitcoin] jonasschnelli pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1a04f45fe967...eab63b971d5f
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19832: p2p: Put disconnecting logs into BCLog::NET category (master...200829-log) https://github.com/bitcoin/bitcoin/pull/19832
< bitcoin-git> bitcoin/master 1a04f45 MarcoFalke: Merge #19832: p2p: Put disconnecting logs into BCLog::NET category
< bitcoin-git> bitcoin/master 1816327 Hennadii Stepanov: p2p: Put disconnecting logs into BCLog::NET category
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d0ca394596cf...1a04f45fe967
< bitcoin-git> [bitcoin] fanquake merged pull request #20476: contrib: Add test for ELF symbol-check (master...2020_11_test_symbol_check) https://github.com/bitcoin/bitcoin/pull/20476
< bitcoin-git> bitcoin/master d0ca394 fanquake: Merge #20476: contrib: Add test for ELF symbol-check
< bitcoin-git> bitcoin/master ed1bbce fanquake: contrib: add MACHO tests to symbol-check tests
< bitcoin-git> bitcoin/master 5bab08d Wladimir J. van der Laan: contrib: Add test for ELF symbol-check
< bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/cef2efafcecc...d0ca394596cf
< bitcoin-git> [bitcoin] wodry opened pull request #20587: [doc] Tidy up Tor doc (more stringent) (master...patch-2) https://github.com/bitcoin/bitcoin/pull/20587
< bitcoin-git> [bitcoin] fanquake merged pull request #20577: doc: libconsensus: add missing error code description, fix NBitcoin link (master...201212-doc-libbitcoinconsensus-fixes) https://github.com/bitcoin/bitcoin/pull/20577
< bitcoin-git> bitcoin/master cef2efa fanquake: Merge #20577: doc: libconsensus: add missing error code description, fix N...
< bitcoin-git> bitcoin/master cb0b712 Sebastian Falbesoner: doc: libbitcoinconsensus: add missing error code description, fix NBitcoin...
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/64156ad4d1f5...cef2efafcecc

2020-12-06

< bitcoin-git> [bitcoin] hebasto opened pull request #20586: Fix Windows build with --enable-werror (master...201206-win) https://github.com/bitcoin/bitcoin/pull/20586
< bitcoin-git> [bitcoin] hebasto closed pull request #20571: refactor: Use deduction guide for std::array<uint8_t, N> (master...201204-u8) https://github.com/bitcoin/bitcoin/pull/20571
< bitcoin-git> [bitcoin] practicalswift opened pull request #20584: Don't declare de facto const member functions as non-const. Don't declare de facto const reference variables as non-const. (master...const-member-fn-and-const-ref-var) https://github.com/bitcoin/bitcoin/pull/20584
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20583: rpc: Add missing BlockUntilSyncedToCurrentChain to wallet RPCs (master...2012-walletSync) https://github.com/bitcoin/bitcoin/pull/20583
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19893: test: Remove or explain syncwithvalidationinterfacequeue (master...2009-testSync) https://github.com/bitcoin/bitcoin/pull/19893
< bitcoin-git> bitcoin/master 64156ad MarcoFalke: Merge #19893: test: Remove or explain syncwithvalidationinterfacequeue
< bitcoin-git> bitcoin/master fa6af31 MarcoFalke: test: Document why syncwithvalidationinterfacequeue is needed in tests
< bitcoin-git> bitcoin/master fa135a1 MarcoFalke: Revert "test: Add missing sync_all to wallet_balance test"
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/9385549a31e7...64156ad4d1f5
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20581: Don't make "in" parameters look like "out"/"in-out" parameters: pass by ref to const instead of ref to non-const (master...const-ref-parameters) https://github.com/bitcoin/bitcoin/pull/20581
< bitcoin-git> bitcoin/master 9385549 MarcoFalke: Merge #20581: Don't make "in" parameters look like "out"/"in-out" paramete...
< bitcoin-git> bitcoin/master 12dcdaa practicalswift: Don't make "in" parameters look like "out"/"in-out" parameters: pass by re...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f35e4d906fee...9385549a31e7
< bitcoin-git> [bitcoin] wodry opened pull request #20582: [doc] Fix documenation of options onlynet and listenonion (master...patch-1) https://github.com/bitcoin/bitcoin/pull/20582
< bitcoin-git> [bitcoin] practicalswift opened pull request #20581: Don't make "in" parameters look like "out"/"in-out" parameters: pass by ref to const instead of ref to non-const (master...const-ref-parameters) https://github.com/bitcoin/bitcoin/pull/20581

2020-12-05

< bitcoin-git> [bitcoin] promag closed pull request #20580: wallet: Some cleanups around LegacyScriptPubKeyMan (master...2020-12-wallet-legacy) https://github.com/bitcoin/bitcoin/pull/20580
< pinheadmz> re: coordination though - BIPs are good places to pick service bits, etc at the community level - thats not really "bitcoin core deciding:
< sipa> (also bitcoin core itself has always ignored unknown messages
< sipa> bitcoin core shouldn't be decided what messages are allowed on the network
< sipa> it seems everyone working on bitcoin core feels this is weird and makes things harder for alternative implementations
< pinheadmz> at the meeting this week there was talk about btcd and libbitcoin disconnecting on unkown p2p message types. i think bcoin does this as well, but that behavior could be changed. does Bitcoin Core have another way to mitigate spam attacks with unknown messages? or is it not a concern because they are simply not processed?
< gribble> https://github.com/bitcoin/bitcoin/issues/20243 | rpc, wallet: Expose wallet id in getwalletinfo RPC output by hebasto · Pull Request #20243 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20205 | wallet: Properly support a wallet id by achow101 · Pull Request #20205 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sipa closed pull request #20578: Добавить лицензию (master...patch-9) https://github.com/bitcoin/bitcoin/pull/20578
< bitcoin-git> [bitcoin] promag opened pull request #20580: wallet: Some cleanups around LegacyScriptPubKeyMan (master...2020-12-wallet-legacy) https://github.com/bitcoin/bitcoin/pull/20580
< bitcoin-git> [bitcoin] vova557 opened pull request #20578: Добавить лицензию (master...patch-9) https://github.com/bitcoin/bitcoin/pull/20578
< bitcoin-git> [bitcoin] theStack closed pull request #20537: refactor: replace manual Satoshis-to-BTC conversions with FormatMoney() (master...20201129-use-formatmoney) https://github.com/bitcoin/bitcoin/pull/20537
< bitcoin-git> [bitcoin] theStack opened pull request #20577: doc: libconsensus: add missing error code description, fix NBitcoin link (master...201212-doc-libbitcoinconsensus-fixes) https://github.com/bitcoin/bitcoin/pull/20577
< bitcoin-git> [bitcoin] practicalswift opened pull request #20575: Do not run functions with necessary side-effects in assert() (master...side-effect-free-assert) https://github.com/bitcoin/bitcoin/pull/20575
< bitcoin-git> [bitcoin] hebasto reopened pull request #19832: p2p: Put disconnecting logs into BCLog::NET category (master...200829-log) https://github.com/bitcoin/bitcoin/pull/19832
< bitcoin-git> [bitcoin] laanwj closed pull request #20574: Update README.md (master...patch-2) https://github.com/bitcoin/bitcoin/pull/20574
< Arvidt> Ah, found the v3 inbound issue report here: https://github.com/bitcoin/bitcoin/issues/20555
< Arvidt> (bitcoin.conf: server=1 onlynet=onion onion=127.0.0.1:9050 listen=1)
< bitcoin-git> bitcoin/master f35e4d9 MarcoFalke: Merge #20572: ci: Adjust Cirrus CI task names (follow up)
< bitcoin-git> bitcoin/master 667b6a2 Hennadii Stepanov: ci: Adjust Cirrus CI task names (follow up)
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/751ffaabad82...f35e4d906fee
< bitcoin-git> [bitcoin] SoiledCold5 opened pull request #20574: Update README.md (master...patch-2) https://github.com/bitcoin/bitcoin/pull/20574
< bitcoin-git> [bitcoin] fanquake closed pull request #20570: Logo added to the readme file. (master...master) https://github.com/bitcoin/bitcoin/pull/20570

2020-12-04

< bitcoin-git> [bitcoin] jonatack opened pull request #20573: wallet, bugfix: allow send with string fee_rate amounts (master...send-allow-feerates-as-strings) https://github.com/bitcoin/bitcoin/pull/20573
< bitcoin-git> [bitcoin] hebasto opened pull request #20572: ci: Adjust Cirrus CI task names (follow up) (master...201204-cirrus) https://github.com/bitcoin/bitcoin/pull/20572
< bitcoin-git> [bitcoin] hebasto opened pull request #20571: refactor: Use deduction guide for std::array<uint8_t, N> (master...201204-u8) https://github.com/bitcoin/bitcoin/pull/20571
< core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt