2020-12-04

< provoostenator> Unless you parse bitcoin.conf
< gribble> https://github.com/bitcoin/bitcoin/issues/19055 | Add MuHash3072 implementation by fjahr · Pull Request #19055 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20546 | wallet: check for non-representable CFeeRates (0-0.0009 sat/vB) by jonatack · Pull Request #20546 · bitcoin/bitcoin · GitHub
< achow101> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball ariard digi_james amiti fjahr jeremyrubin emilengler jonatack hebasto
< core-meetingbot> Meeting started Fri Dec 4 19:01:29 2020 UTC. The chair is achow101. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
< bitcoin-git> [bitcoin] OliverPetrovic opened pull request #20570: Logo added to the readme file. (master...master) https://github.com/bitcoin/bitcoin/pull/20570
< gribble> https://github.com/bitcoin/bitcoin/issues/20240 | script: fix linter error in test runner by jonatack · Pull Request #20240 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20510: [backport] wallet: allow zero-fee fundrawtransaction/walletcreatefundedpsbt and other fixes (0.21...backport-fee_rate-follow-ups) https://github.com/bitcoin/bitcoin/pull/20510
< bitcoin-git> bitcoin/0.21 6e4969f Jon Atack: Update feeRate (BTC/kvB) to fee_rate (sat/vB) in wallet_bumpfee
< bitcoin-git> bitcoin/0.21 6313362 Jon Atack: Use the correct incremental fee constant in bumpfee help
< bitcoin-git> bitcoin/0.21 54e1edc Jon Atack: Allow zero-fee fundrawtxn and walletcreatefundedpsbt calls
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to 0.21: https://github.com/bitcoin/bitcoin/compare/68bd88597a79...aa4b8ebfecdd
< luke-jr> Provostro: this channel is for Bitcoin Core development, not for speaking with specific people about other topics
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20562: tests: Test that a fully signed tx given to signrawtx is unchanged (master...test-signraw-fullysigned) https://github.com/bitcoin/bitcoin/pull/20562
< bitcoin-git> bitcoin/master 751ffaa MarcoFalke: Merge #20562: tests: Test that a fully signed tx given to signrawtx is unc...
< bitcoin-git> bitcoin/master 773c42b Andrew Chow: tests: Test that a fully signed tx given to signrawtx is unchanged
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c1604483d34f...751ffaabad82
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20566: refactor: Use C++17 std::array where possible (master...2012-array) https://github.com/bitcoin/bitcoin/pull/20566
< bitcoin-git> bitcoin/master c160448 MarcoFalke: Merge #20566: refactor: Use C++17 std::array where possible
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9601c0d7aab7...c1604483d34f
< bitcoin-git> bitcoin/master fac7ab1 MarcoFalke: refactor: Use C++17 std::array where possible
< bitcoin-git> [bitcoin] fanquake merged pull request #20565: Android : Ensure pic build for bdb (master...fix-bdb-android) https://github.com/bitcoin/bitcoin/pull/20565
< bitcoin-git> bitcoin/master 9601c0d fanquake: Merge #20565: Android : Ensure pic build for bdb
< bitcoin-git> bitcoin/master e373959 Block Mechanic: Android : Ensure pic build for bdb
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/dca80ffb45fc...9601c0d7aab7
< harding> problems, please reply to the thread." http://bitcoinops.org/en/newsletters/2020/03/04/#improving-feature-negotiation-between-full-nodes-at-startup Later (August), about the new wtxidrelay message, we wrote, "This behavior is already implemented in an unreleased development version of Bitcoin Core. If the maintainers of other implementations, or anyone else, opposes this change, please respond to the mailing list thread."
< wumpus> e.g. https://github.com/bitcoin/bips/pull/766 had some of the most fruitful discussion
< wumpus> well, it also helps coordinate between bitcoin core developers on a more conceptual level than implementation details, but that discussion happened on the BIP repo PRs, not on the mailing list
< wumpus> but I agree, the whole BIP process is there to standardize the bitcoin protocols, to coordinate between implementations, that's the point
< gribble> https://github.com/bitcoin/bitcoin/issues/20564 | Dont send sendaddrv2 to pre-70016 software by sipa · Pull Request #20564 · bitcoin/bitcoin · GitHub
< wumpus> I don't think people are exagerrating when they claim it has become almost imposible to make changes to bitcoin, even non-consensus, maybe this is a good thing! I don't know
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20255: util: Add Assume() identity function (master...2010-assume) https://github.com/bitcoin/bitcoin/pull/20255
< bitcoin-git> bitcoin/master faa0585 MarcoFalke: util: Remove probably misleading TODO
< bitcoin-git> bitcoin/master fac5efe MarcoFalke: util: Add Assume() identity function
< bitcoin-git> bitcoin/master fa86156 practicalswift: util: Allow Assert(...) to be used in all contexts
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/ca759bc743c9...dca80ffb45fc
< jonasschnelli> fanquake: I think you can un-draft https://github.com/bitcoin/bitcoin/pull/19817
< gribble> https://github.com/bitcoin/bitcoin/issues/20567 | test: Add option to git-subtree-check to do full check, add help by laanwj · Pull Request #20567 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj merged pull request #20200: doc: rename CODEOWNERS to REVIEWERS (master...102020-fix-codeowners) https://github.com/bitcoin/bitcoin/pull/20200
< bitcoin-git> bitcoin/master ca759bc Wladimir J. van der Laan: Merge #20200: doc: rename CODEOWNERS to REVIEWERS
< bitcoin-git> bitcoin/master 86e6add Adam Jonas: doc: rename CODEOWNERS to REVIEWERS
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/257cf05f9b84...ca759bc743c9
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20569: test: Fix intermittent wallet_multiwallet issue with got_loading_error (master...2012-testWalletInt) https://github.com/bitcoin/bitcoin/pull/20569
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #20563: build: Check that Homebrew's berkeley-db4 package is actually installed (master...201203-bdb) https://github.com/bitcoin/bitcoin/pull/20563
< bitcoin-git> bitcoin/master 257cf05 Jonas Schnelli: Merge #20563: build: Check that Homebrew's berkeley-db4 package is actuall...
< bitcoin-git> bitcoin/master d3ef947 Hennadii Stepanov: build: Check that Homebrew's berkeley-db4 package is actually installed
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e2ae6a2befad...257cf05f9b84
< gribble> https://github.com/bitcoin/bitcoin/issues/20566 | refactor: Use C++17 std::array where possible by MarcoFalke · Pull Request #20566 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20568: rpc: Use FeeModes doc helper in estimatesmartfee (master...2012-rpcDocFee) https://github.com/bitcoin/bitcoin/pull/20568
< bitcoin-git> [bitcoin] laanwj opened pull request #20567: test: Add option to git-subtree-check to do full check, add help (master...2020_12_subtree_check) https://github.com/bitcoin/bitcoin/pull/20567
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20566: refactor: Use C++17 std::array where possible (master...2012-array) https://github.com/bitcoin/bitcoin/pull/20566
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20182: ci: Build with --enable-werror by default, and document exceptions (master...201018-error) https://github.com/bitcoin/bitcoin/pull/20182
< bitcoin-git> bitcoin/master e2ae6a2 MarcoFalke: Merge #20182: ci: Build with --enable-werror by default, and document exce...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a0489f3472f3...e2ae6a2befad
< bitcoin-git> bitcoin/master 2f6fe4e Hennadii Stepanov: ci: Build with --enable-werror by default, and document exceptions
< bitcoin-git> [bitcoin] BlockMechanic opened pull request #20565: Android : Ensure pic build for bdb (master...fix-bdb-android) https://github.com/bitcoin/bitcoin/pull/20565

2020-12-03

< bitcoin-git> [bitcoin] laanwj reopened pull request #20476: contrib: Add test for ELF symbol-check (master...2020_11_test_symbol_check) https://github.com/bitcoin/bitcoin/pull/20476
< bitcoin-git> [bitcoin] laanwj closed pull request #20476: contrib: Add test for ELF symbol-check (master...2020_11_test_symbol_check) https://github.com/bitcoin/bitcoin/pull/20476
< wumpus> Connecting to chat.freenode.net:6697 with nick bitcoin-git and channels: #bitcoin-commits,#bitcoin-core-dev: There was a problem sending messages to IRC: timed out
< wumpus> one thing I had never imagined was having to do this for the bitcoin P2P protocol, I mean usually it's about trying to smuggle bitcoin P2P data like blocks and transactions over some other layer
< bitcoin-git> [bitcoin] hebasto opened pull request #20563: build: Check that Homebrew's berkeley-db4 package is actually installed (master...201203-bdb) https://github.com/bitcoin/bitcoin/pull/20563
< gribble> https://github.com/bitcoin/bitcoin/issues/19362 | rpc/blockchain: Reset scantxoutset progress before inferring descriptors by prusnak · Pull Request #19362 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20483 | wallet: deprecate feeRate in fundrawtransaction/walletcreatefundedpsbt by jonatack · Pull Request #20483 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20483 | wallet: deprecate feeRate in fundrawtransaction/walletcreatefundedpsbt by jonatack · Pull Request #20483 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19740 | [0.20] wallet: Simplify and fix CWallet::SignTransaction by achow101 · Pull Request #19740 · bitcoin/bitcoin · GitHub
< jonatack> bitcoin-util SGTM
< core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
< wumpus> aj: if there are plans for bitcoin-util it's okay with me
< aj> might make sense to do it in bitcoin-tx now, and have a new PR later that adds bitcoin-util with multiple functionality bits (and better arg handling like MarcoFalke suggests)
< wumpus> it's too bad we already have bitcoin-tx with the same (in)dependency idea
< aj> wumpus suggested adding it to bitcoin-tx which works fine (it already links libconsensus), but is klunky
< wumpus> I guess the drawback is adding yet another executable, which links in a lot of stuff, but if we have other plans for bitcoin-util apart from just the signet grinding it may be worth it
< gribble> https://github.com/bitcoin/bitcoin/issues/14671 | Utility to replace RPC calls that dont need wallet or chain context · Issue #14671 · bitcoin/bitcoin · GitHub
< aj> bitcoin-util as a generic thing has been proposed in #14671 iirc for doing things like psbt without needing a running node
< aj> signet mining has high enough difficulty that grinding in python doesn't work. but gridning needs libconsensus code so can't be stuck in bitcoin-cli without bloating it
< gribble> https://github.com/bitcoin/bitcoin/issues/19937 | signet mining utility by ajtowns · Pull Request #19937 · bitcoin/bitcoin · GitHub
< core-meetingbot> topic: bitcoin-util (aj)
< wumpus> #topic bitcoin-util (aj)
< aj> 4min left if we want to quickly discuss bitcoin-util
< bitcoin-git> [bitcoin] achow101 opened pull request #20562: tests: Test that a fully signed tx given to signrawtx is unchanged (master...test-signraw-fullysigned) https://github.com/bitcoin/bitcoin/pull/20562
< gribble> https://github.com/bitcoin/bitcoin/issues/18044 | Use wtxid for transaction relay by sdaftuar · Pull Request #18044 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20511 | anchors.dat doesnt support V2 addresses · Issue #20511 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20511 | anchors.dat doesnt support V2 addresses · Issue #20511 · bitcoin/bitcoin · GitHub
< sipa> short topic: can people read over https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.21.0-Release-Notes-Draft? i think a few things are missing
< gribble> https://github.com/bitcoin/bitcoin/issues/17204 | wallet: Do not turn OP_1NEGATE in scriptSig into 0x0181 in signing code (sipa) by meshcollider · Pull Request #17204 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19740 | [0.20] wallet: Simplify and fix CWallet::SignTransaction by achow101 · Pull Request #19740 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19910 | net processing: Move peer_map to PeerManager by jnewbery · Pull Request #19910 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19937 | signet mining utility by ajtowns · Pull Request #19937 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20362 | test: Implicitly sync after generate* to preempt races and intermittent test failures by MarcoFalke · Pull Request #20362 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20483 | wallet: deprecate feeRate in fundrawtransaction/walletcreatefundedpsbt by jonatack · Pull Request #20483 · bitcoin/bitcoin · GitHub
< wumpus> https://github.com/bitcoin/bitcoin/projects/8 11 blockers, 2 chasing concept ACK
< gribble> https://github.com/bitcoin/bitcoin/issues/19937 | signet mining utility by ajtowns · Pull Request #19937 · bitcoin/bitcoin · GitHub
< wumpus> two proposed topics for today: rc3, 0.19 release, 0.20 release (marcofalke), bitcoin-util cli utility for 19937 (aj)
< gribble> https://github.com/bitcoin/bitcoin/issues/10615 | RPC: Allow rpcauth configs to specify a 4th parameter naming a specific wallet by luke-jr · Pull Request #10615 · bitcoin/bitcoin · GitHub
< wumpus> #bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik
< core-meetingbot> Meeting started Thu Dec 3 19:00:38 2020 UTC. The chair is wumpus. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
< jnewbery> luke-jr: not trolling. If a PR is opened where the goal is primarily to make things easier for downstream projects, then (1) that should be explicitly declared in the PR description (2) it should be judged for inclusion in Bitcoin Core solely on whether it's a benefit to the users of this project.
< bitcoin-git> [bitcoin] sdaftuar opened pull request #20561: p2p: periodically clear m_addr_known, and choose new peers to receive relayed addresses (master...2020-12-moar-addrz) https://github.com/bitcoin/bitcoin/pull/20561
< luke-jr> then people who want to switch between versions regularly can just put strict=0 in bitcoin.conf
< gribble> https://github.com/bitcoin/bitcoin/issues/20548 | RPC: Tolerate unknown parameters, but with clear warning/errors by luke-jr · Pull Request #20548 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #20550: RPC: Tolerate invalid rpcauth options (master...soften_rpcauth2) https://github.com/bitcoin/bitcoin/pull/20550
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #20550: RPC: Tolerate invalid rpcauth options (master...soften_rpcauth2) https://github.com/bitcoin/bitcoin/pull/20550
< harding> Ah, that was a comment from https://github.com/bitcoin/bitcoin/pull/20548
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20560: fuzz: Link all targets once (master...2012-fuzzLinkOnce) https://github.com/bitcoin/bitcoin/pull/20560
< fanquake> Yes that's possible, and probably quite likely. I'd imagine there are many people running bitcoin nodes, that have no interest in it supporting UPNP, ZMQ, or even having the wallet compiled into it.
< miketwenty1> in the future / even with guix .. would you imagine gitian sigs for multiple common options for each minor/major release of bitcoin? like one with everything enabled.. another build is just the node.. another build with zmq and maybe a few other things .. etc..
< miketwenty1> Question about bitcoin builds and gitian builds, when you build from source you can put in build options/flags to exclude/include certain things like whether or not the wallet, UPnP, zmq.. are these build options baked into gitian builds to enable everything? If I for example wanted to do a gitian build and not build someone or include something do I have this flexibility?
< vasild> hebasto: I guess s/a0489f3/0e2d9ef/ in your comment https://github.com/bitcoin/bitcoin/pull/20182#issuecomment-738023008
< bitcoin-git> [bitcoin] laanwj closed pull request #20559: Update README.md (master...fix-readme-term-change) https://github.com/bitcoin/bitcoin/pull/20559
< bitcoin-git> [bitcoin] testingaccount234234 opened pull request #20559: Update README.md (master...fix-readme-term-change) https://github.com/bitcoin/bitcoin/pull/20559
< bitcoin-git> [bitcoin] laanwj merged pull request #20221: net: compat.h related cleanup (master...201022-compat) https://github.com/bitcoin/bitcoin/pull/20221
< bitcoin-git> bitcoin/master cadb77a Hennadii Stepanov: net: Add compat.h header for htonl function
< bitcoin-git> bitcoin/master f796f00 Hennadii Stepanov: net: Drop unneeded headers when compat.h included
< bitcoin-git> bitcoin/master 467c346 Hennadii Stepanov: net: Drop unneeded Windows headers in compat.h
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/3fa6a9fc8c90...a0489f3472f3
< bitcoin-git> bitcoin/master 3fa6a9f Wladimir J. van der Laan: Merge #20506: ci: AppVeyor fixes for Visual Studio 2019 16.8.1 image
< bitcoin-git> [bitcoin] laanwj merged pull request #20506: ci: AppVeyor fixes for Visual Studio 2019 16.8.1 image (master...msvc-no-optimise) https://github.com/bitcoin/bitcoin/pull/20506
< bitcoin-git> bitcoin/master 2c69381 Aaron Clauson: Removed redundant git pull from appveyor config.
< bitcoin-git> bitcoin/master 8b99e60 Aaron Clauson: Adjusted msvc compiler and linker settings to remove optimisations that ar...
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/a3186b6da60e...3fa6a9fc8c90
< bitcoin-git> [bitcoin] naumenkogs closed pull request #20539: Avoid rebucketing on restart when it's not necessary (master...2020-12-01-rebucket-asmap-fix) https://github.com/bitcoin/bitcoin/pull/20539
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20558: test: Add MaybeCompactWalletDB tsan suppression (take 2) (master...2012-testSanTsan) https://github.com/bitcoin/bitcoin/pull/20558
< bitcoin-git> [bitcoin] laanwj merged pull request #20520: depends: Do not force Precompiled Headers (PCH) for building Qt on Linux (master...201127-pch) https://github.com/bitcoin/bitcoin/pull/20520
< bitcoin-git> bitcoin/master a3186b6 Wladimir J. van der Laan: Merge #20520: depends: Do not force Precompiled Headers (PCH) for building...
< bitcoin-git> bitcoin/master c82d15b Hennadii Stepanov: depends: Do not force Precompiled Headers (PCH) for building Qt on Linux
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/681ce59d0eac...a3186b6da60e
< bitcoin-git> [bitcoin] jnewbery opened pull request #20557: addrman: Fix new table bucketing during unserialization (master...2020-12-fix-addrman-bucketing) https://github.com/bitcoin/bitcoin/pull/20557
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #20548: RPC: Tolerate unknown parameters, but with clear warning/errors (master...soften_rpcauth) https://github.com/bitcoin/bitcoin/pull/20548
< gribble> https://github.com/bitcoin/bitcoin/issues/20017 | rpc: Add RPCContext by promag · Pull Request #20017 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20556: rpc: Properly document return values (submitblock, gettxout, getblocktemplate, scantxoutset) (master...2012-rpcDoc) https://github.com/bitcoin/bitcoin/pull/20556
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20466: test: Fix intermittent p2p_fingerprint issue (master...2011-testIntFixp2p) https://github.com/bitcoin/bitcoin/pull/20466
< bitcoin-git> bitcoin/master 681ce59 MarcoFalke: Merge #20466: test: Fix intermittent p2p_fingerprint issue
< bitcoin-git> bitcoin/master fad7be5 MarcoFalke: test: Fix intermittent p2p_finerprint issue
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a35b948836db...681ce59d0eac
< bitcoin-git> [gui] Bosch-0 closed pull request #144: Merge pull request #1 from bitcoin-core/master (master...master) https://github.com/bitcoin-core/gui/pull/144
< bitcoin-git> [gui] Bosch-0 opened pull request #144: Merge pull request #1 from bitcoin-core/master (master...master) https://github.com/bitcoin-core/gui/pull/144
< bitcoin-git> [gui] Bosch-0 opened pull request #143: Add icon policy documentation (master...icon_policy) https://github.com/bitcoin-core/gui/pull/143
< aj> #proposedmeetingtopic bitcoin-util cli utility for 19937 (see also 14671 and 18573)

2020-12-02

< bitcoin-git> [bitcoin] luke-jr opened pull request #20551: RPC/Net: Allow changing the connection_type for addnode onetry (master...rpc_onetry_conntype) https://github.com/bitcoin/bitcoin/pull/20551
< bitcoin-git> [bitcoin] luke-jr closed pull request #12674: RPC: Support addnode onetry without making the connection priviliged (master...rpc_onetry_nonpriv) https://github.com/bitcoin/bitcoin/pull/12674
< bitcoin-git> [bitcoin] luke-jr opened pull request #20550: RPC: Tolerate invalid rpcauth options (master...soften_rpcauth2) https://github.com/bitcoin/bitcoin/pull/20550
< luke-jr> MarcoFalke: you mean https://github.com/luke-jr/bitcoin/pull/new/soften_rpcauth2 ? that doesn't address your fears of harder debugging though
< bitcoin-git> [bitcoin] promag opened pull request #20549: Support make src/bitcoin-node (master...2020-12-make-bitcoin-node) https://github.com/bitcoin/bitcoin/pull/20549
< bitcoin-git> [bitcoin] luke-jr opened pull request #20548: RPC: Tolerate unknown parameters, but with clear warning/errors (master...soften_rpcauth) https://github.com/bitcoin/bitcoin/pull/20548
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20545: ci: Adjust cirrus ci task names (master...2012-ciNames) https://github.com/bitcoin/bitcoin/pull/20545
< bitcoin-git> bitcoin/master a35b948 MarcoFalke: Merge #20545: ci: Adjust cirrus ci task names
< bitcoin-git> bitcoin/master fa5c4f1 MarcoFalke: ci: Adjust cirrus ci task names
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0a13d15c1439...a35b948836db
< gribble> https://github.com/bitcoin/bitcoin/issues/20461 | rpc: Validate -rpcauth arguments by promag · Pull Request #20461 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonatack opened pull request #20546: wallet: check for non-representable CFeeRates (0-0.0009 sat/vB) (master...non-representable-CFeeRate-check) https://github.com/bitcoin/bitcoin/pull/20546
< bitcoin-git> [bitcoin] fanquake merged pull request #20530: lint, refactor: Update cppcheck linter to c++17 and improve explicit usage (master...cppcheck17) https://github.com/bitcoin/bitcoin/pull/20530
< bitcoin-git> bitcoin/master 0a13d15 fanquake: Merge #20530: lint, refactor: Update cppcheck linter to c++17 and improve ...
< bitcoin-git> bitcoin/master 1e62350 Fabian Jahr: refactor: Improve use of explicit keyword
< bitcoin-git> bitcoin/master c502a6d Fabian Jahr: lint: Use c++17 std in cppcheck linter
< bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/3693fccc3acd...0a13d15c1439
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20545: ci: Adjust cirrus ci task names (master...2012-ciNames) https://github.com/bitcoin/bitcoin/pull/20545
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20543: ci: no-longer exclude feature_block in TSAN job (master...dont_exclude_feature_block_cirrus) https://github.com/bitcoin/bitcoin/pull/20543
< bitcoin-git> bitcoin/master 2b35611 fanquake: ci: no-longer exclude feature_block in TSAN job
< bitcoin-git> bitcoin/master 3693fcc MarcoFalke: Merge #20543: ci: no-longer exclude feature_block in TSAN job
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c33662a0eaff...3693fccc3acd
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #18948: qt: Call setParent() in the parent's context (master...200511-qt-assert) https://github.com/bitcoin/bitcoin/pull/18948
< bitcoin-git> bitcoin/master 8963b2c Hennadii Stepanov: qt: Improve comments in WalletController::getOrCreateWallet()
< bitcoin-git> bitcoin/master 5659e73 Hennadii Stepanov: qt: Add ObjectInvoke template function
< bitcoin-git> bitcoin/master 5fcfee6 Hennadii Stepanov: qt: Call setParent() in the parent's context
< bitcoin-git> [bitcoin] jonasschnelli pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/7f0f01f0ab45...c33662a0eaff
< bitcoin-git> [bitcoin] hebasto opened pull request #20544: build: Do not repeat warning names in -Werror=... options (master...201202-werror) https://github.com/bitcoin/bitcoin/pull/20544
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20507: sync: print proper lock order location when double lock is detected (master...double_lock_print_location) https://github.com/bitcoin/bitcoin/pull/20507
< bitcoin-git> bitcoin/master db058ef Vasil Dimov: sync: use HasReason() in double lock tests
< bitcoin-git> bitcoin/master a21dc46 Vasil Dimov: sync: const-qualify the argument of double_lock_detected()
< bitcoin-git> bitcoin/master 6d3689f Vasil Dimov: sync: print proper lock order location when double lock is detected
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/283f22cabb9a...7f0f01f0ab45
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20461: rpc: Validate -rpcauth arguments (master...2020-11-validate-rpcauth) https://github.com/bitcoin/bitcoin/pull/20461
< bitcoin-git> bitcoin/master 053b4fb João Barbosa: doc: Release note regarding -rpcauth validation
< bitcoin-git> bitcoin/master 4600132 João Barbosa: rpc: Validate -rpcauth arguments
< bitcoin-git> bitcoin/master d37c813 João Barbosa: rpc: Refactor to process -rpcauth once
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/607c844f3720...283f22cabb9a
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20150: [0.19] Backports (0.19...more_019_backports) https://github.com/bitcoin/bitcoin/pull/20150
< bitcoin-git> bitcoin/0.19 27bb2cc MIZUTA Takeshi: util: Don't reference errno when pthread fails.
< bitcoin-git> [bitcoin] MarcoFalke pushed 9 commits to 0.19: https://github.com/bitcoin/bitcoin/compare/aee9d2306ad1...5baaea4410a1
< bitcoin-git> bitcoin/0.19 a8411b3 Hennadii Stepanov: qt: Fix QFileDialog for static builds
< bitcoin-git> bitcoin/0.19 8bd2ab1 Nadav Ivgi: docs: Correct description for getblockstats's txs field
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20540: test: Fix wallet_multiwallet issue on windows (master...2012-testmw) https://github.com/bitcoin/bitcoin/pull/20540
< bitcoin-git> bitcoin/master 607c844 MarcoFalke: Merge #20540: test: Fix wallet_multiwallet issue on windows
< bitcoin-git> bitcoin/master fada2df MarcoFalke: test: Fix wallet_multiwallet issue on windows
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/80d4231e1638...607c844f3720
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #20357: ci: Use travis_fold on Travis CI only (master...201109-travis) https://github.com/bitcoin/bitcoin/pull/20357
< fanquake> What is the point of this intermediate "checks" page (i.e https://github.com/bitcoin/bitcoin/pull/20543/checks?check_run_id=1484331810) that just lists "view more details" links
< gribble> https://github.com/bitcoin/bitcoin/issues/20150 | [0.19] Backports by fanquake · Pull Request #20150 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake closed pull request #20357: ci: Use travis_fold on Travis CI only (master...201109-travis) https://github.com/bitcoin/bitcoin/pull/20357
< bitcoin-git> [bitcoin] fanquake opened pull request #20543: ci: no-longer exclude feature_block in TSAN job (master...dont_exclude_feature_block_cirrus) https://github.com/bitcoin/bitcoin/pull/20543
< bitcoin-git> [bitcoin] fanquake merged pull request #20505: [backport] build: Avoid secp256k1.h include from system (0.21...21_backport) https://github.com/bitcoin/bitcoin/pull/20505
< bitcoin-git> bitcoin/0.21 68bd885 fanquake: Merge #20505: [backport] build: Avoid secp256k1.h include from system
< bitcoin-git> bitcoin/0.21 01b647b Niklas Gögge: build: Avoid secp256k1.h include from system
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to 0.21: https://github.com/bitcoin/bitcoin/compare/9facca3ce0ad...68bd88597a79
< bitcoin-git> [bitcoin] fanquake merged pull request #19980: refactor: Some wallet cleanups (master...2020-09-wallet-cleanups) https://github.com/bitcoin/bitcoin/pull/19980
< bitcoin-git> bitcoin/master 80d4231 fanquake: Merge #19980: refactor: Some wallet cleanups
< bitcoin-git> bitcoin/master 9b74461 João Barbosa: refactor: Assert before dereference in CWallet::GetDatabase
< bitcoin-git> bitcoin/master 021feb3 João Barbosa: refactor: Drop redudant CWallet::GetDBHandle
< bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/f17e8ba3a17b...80d4231e1638

2020-12-01

< bitcoin-git> [bitcoin] sipa opened pull request #20541: Move special CAddress-without-nTime logic to net_processing (master...202012_addr_without_time_is_no_addr) https://github.com/bitcoin/bitcoin/pull/20541
< gribble> https://github.com/bitcoin/bitcoin/issues/20516 | Well-defined CAddress disk serialization, and addrv2 anchors.dat by sipa · Pull Request #20516 · bitcoin/bitcoin · GitHub
< jnewbery> vasild: your suggested change to BIP155 isn't what Bitcoin Core is doing. It sends the message after receiving a version message
< jnewbery> in the implementation, we send it on receiving the version message: https://github.com/bitcoin/bitcoin/blob/f17e8ba3a17b6516a1b1fb7f45d506a339e99f90/src/net_processing.cpp#L2368
< jnewbery> in BIP 155, it says "sendaddrv2 SHOULD be sent after receiving the verack message from the peer": https://github.com/bitcoin/bips/blob/7e3284dafda168da34888977dbf4a55519b0c54d/bip-0155.mediawiki#L137
< jnewbery> vasild: if you're still around, I have a question about addrv2 support negotiation. There seems to be a discrepency between the bip and the implementation in Bitcoin Core
< core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
< gribble> https://github.com/bitcoin/bitcoin/issues/18261 | Erlay: bandwidth-efficient transaction relay protocol by naumenkogs · Pull Request #18261 · bitcoin/bitcoin · GitHub
< gleb> So I switched the code to do sketch extensions instead. It's much less code, and the code complexity is now more aligned with general Bitcoin project complexity.
< gleb> In practice, the implementation turned out to be too complicated on the Bitcoin Core p2p protocol side.
< cdecker> If there's interest from miners to get access I can write up a faux-bitcoin-node that acts as a bridge between bitcoin p2p and the ln overlay relay network
< sipa> i was hoping LN, because it's an inherently different situation than bitcoin's identityless P2P
< ariard> sipa: define general ? if you mean for any bitcoin protocol without care of protocol designer I likely agree with you
< ariard> michaelfolkson: note also that pinning doesn't only affect LN but also bitcoin protocol like vaults, DLC
< gribble> https://github.com/bitcoin/bitcoin/issues/1 | JSON-RPC support for mobile devices ("ultra-lightweight" clients) · Issue #1 · bitcoin/bitcoin · GitHub
< jnewbery> hi folks. No proposed topics in https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings#1-dec-2020 so could be a short meeting
< jnewbery> #bitcoin-core-dev P2P Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james
< core-meetingbot> Meeting started Tue Dec 1 15:00:17 2020 UTC. The chair is jnewbery. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
< bitcoin-git> bitcoin/master 8dbb7de Pieter Wuille: Add comments to VerifyTaprootCommitment
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20207: Follow-up extra comments on taproot code and tests (master...202010_taproot-comments) https://github.com/bitcoin/bitcoin/pull/20207
< bitcoin-git> bitcoin/master cdf900c Pieter Wuille: Document need_vin_vout_mismatch argument to make_spender
< bitcoin-git> bitcoin/master 18246ed Pieter Wuille: Fix and improve taproot_construct comments
< bitcoin-git> [bitcoin] MarcoFalke pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/dfd0b700886c...f17e8ba3a17b
< gribble> https://github.com/bitcoin/bitcoin/issues/1 | JSON-RPC support for mobile devices ("ultra-lightweight" clients) · Issue #1 · bitcoin/bitcoin · GitHub
< jnewbery> hi folks. It's p2p irc meeting day. There aren't currently any topics in https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings#1-dec-2020. Feel free to add anything you want to discuss. The meeting starts in just over an hour.
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20425: fuzz: Make CAddrMan fuzzing harness deterministic (master...fuzzers-make-addrman-harness-deterministic) https://github.com/bitcoin/bitcoin/pull/20425
< bitcoin-git> bitcoin/master dfd0b70 MarcoFalke: Merge #20425: fuzz: Make CAddrMan fuzzing harness deterministic
< bitcoin-git> bitcoin/master 17a5f17 practicalswift: fuzz: Make addrman fuzzing harness deterministic
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/277c225b8421...dfd0b700886c
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20540: test: Fix wallet_multiwallet issue on windows (master...2012-testmw) https://github.com/bitcoin/bitcoin/pull/20540
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #20478: Don't set BDB flags when configuring without (master...2020/11/bdbless_mac) https://github.com/bitcoin/bitcoin/pull/20478
< bitcoin-git> bitcoin/master 277c225 Jonas Schnelli: Merge #20478: Don't set BDB flags when configuring without
< bitcoin-git> bitcoin/master 982e548 Jonas Schnelli: Don't set BDB flags when configuring without
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/dcb7518067cd...277c225b8421
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #20496: build: Drop unneeded macOS framework dependencies (master...201125-as) https://github.com/bitcoin/bitcoin/pull/20496
< bitcoin-git> bitcoin/master dcb7518 Jonas Schnelli: Merge #20496: build: Drop unneeded macOS framework dependencies
< bitcoin-git> bitcoin/master ec4a46d Hennadii Stepanov: build: Drop unneeded IOKit framework dependency
< bitcoin-git> bitcoin/master 65afe4c Hennadii Stepanov: build: Drop unneeded ApplicationServices framework dependency
< bitcoin-git> [bitcoin] jonasschnelli pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/335d27d08141...dcb7518067cd
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #20512: doc: Add bash as an OpenBSD dependency (master...2020-11-doc-build-openbsd-bash-dependency) https://github.com/bitcoin/bitcoin/pull/20512
< bitcoin-git> bitcoin/master 335d27d Jonas Schnelli: Merge #20512: doc: Add bash as an OpenBSD dependency
< bitcoin-git> bitcoin/master 1d578c0 Emil Engler: doc: Add bash as an OpenBSD dependency
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f2a673f15b51...335d27d08141
< bitcoin-git> [gui] jonasschnelli merged pull request #137: refactor: Replace deprecated Qt::SystemLocale{Short,Long}Date (master...201127-locale) https://github.com/bitcoin-core/gui/pull/137
< bitcoin-git> bitcoin/master f2a673f Jonas Schnelli: Merge bitcoin-core/gui#137: refactor: Replace deprecated Qt::SystemLocale{...
< bitcoin-git> bitcoin/master 86b1ab6 Hennadii Stepanov: refactor: Replace deprecated Qt::SystemLocale{Short,Long}Date
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cd720337fe9c...f2a673f15b51
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20222: refactor: CTxMempool constructor clean up (master...ctxmempool_refactor) https://github.com/bitcoin/bitcoin/pull/20222
< bitcoin-git> bitcoin/master f15e780 Elle Mouton: refactor: Clean up CTxMemPool initializer list
< bitcoin-git> bitcoin/master e331069 Elle Mouton: refactor: Make CTxMemPool::m_check_ratio a const and a constructor argumen...
< bitcoin-git> bitcoin/master 9d4b4b2 Elle Mouton: refactor: Avoid double to int cast for nCheckFrequency
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/24e4857b29b3...cd720337fe9c
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20494: refactor: Move node and wallet code out of src/interfaces (master...pr/ipc-mv) https://github.com/bitcoin/bitcoin/pull/20494
< bitcoin-git> bitcoin/master 629a929 Russell Yanofsky: Move WalletImpl from interfaces/wallet.cpp to wallet/interfaces.cpp
< bitcoin-git> bitcoin/master 2a26771 Russell Yanofsky: Move ChainImpl from interfaces/chain.cpp to node/interfaces.cpp
< bitcoin-git> bitcoin/master 12bd0fc Russell Yanofsky: Move NodeImpl from interfaces/node.cpp to node/interfaces.cpp
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/ffd5e7a8567d...24e4857b29b3
< bitcoin-git> [bitcoin] naumenkogs opened pull request #20539: Avoid rebucketing on restart when it's not necessary (master...2020-12-01-rebucket-asmap-fix) https://github.com/bitcoin/bitcoin/pull/20539
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20519: Handle rename failure in DumpMempool(...) by using the RenameOver(...) return value. Add [[nodiscard]] to RenameOver(...). (master...renameover-nodiscard) https://github.com/bitcoin/bitcoin/pull/20519
< bitcoin-git> bitcoin/master ffd5e7a MarcoFalke: Merge #20519: Handle rename failure in DumpMempool(...) by using the Renam...
< bitcoin-git> bitcoin/master ce9dd45 practicalswift: Add [[nodiscard]] to RenameOver(...)
< bitcoin-git> bitcoin/master 9429a39 practicalswift: Handle rename failure in DumpMempool(...) by using RenameOver(...) return ...
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/81d5af42f4db...ffd5e7a8567d
< bitcoin-git> [bitcoin] theStack opened pull request #20537: refactor: replace manual Satoshis-to-BTC conversions with FormatMoney() (master...20201129-use-formatmoney) https://github.com/bitcoin/bitcoin/pull/20537

2020-11-30

< bitcoin-git> [bitcoin] achow101 opened pull request #20536: wallet: Error with "Transaction too large" if the funded tx will end up being too large after signing (master...fundtx-error-large-tx) https://github.com/bitcoin/bitcoin/pull/20536
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20535: test: Fix intermittent feature_taproot issue (master...2011-testTapInt) https://github.com/bitcoin/bitcoin/pull/20535
< sipa> seed.bitcoin.sipa.be may not even *have* a full node
< pinheadmz> oh I see, so it still may not be the full node at bitcoin.sipa.be that we conenct to, but any one of the nodes returned in A records to the exit node, which thinks we are just resolving a single service by name
< sipa> yes, because you can't do DNS resolving over Tor (that'd require a DNS implementation in bitcoin core, and route it over tor)
< sipa> but from bitcoin core's perspective there is no such thing as A or AAAA or CNAME or whatever records or DNS involved
< pinheadmz> actually im not getting anything from seed.bitcoin.sipa.be but I am from `dig dnsseed.bluematt.me`
< sipa> doing so likely makes your OS's/ISP's resolver connect to the DNS seed server, but that's transparent from bitcoin core's perspective
< pinheadmz> ah, TIL so there is no `dig bitcoin.sipa.de` or whatever. I always thought we use A records from the seed to bootstrap
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20499: Remove obsolete NODISCARD ifdef forest. Use [[nodiscard]] (C++17). (master...remove-nodiscard-cruft) https://github.com/bitcoin/bitcoin/pull/20499
< bitcoin-git> bitcoin/master 81d5af4 MarcoFalke: Merge #20499: Remove obsolete NODISCARD ifdef forest. Use [[nodiscard]] (C...
< bitcoin-git> bitcoin/master 79bff8e practicalswift: Remove NODISCARD
< bitcoin-git> bitcoin/master 4848e71 practicalswift: scripted-diff: Use [[nodiscard]] (C++17) instead of NODISCARD
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/817aeca57a4c...81d5af42f4db
< willcl_ark> Agreed. I imagined Luke might be trying to grep bitcoin and bitcoin-gui repos at the same time, and using some small script to bolt together two git searches? Not familiar with git-grep-all tbh :)
< sipa> i've never had a situation where "git grep" in the bitcoin repo wasn't fast enough
< willcl_ark> luke-jr: I've been trying out ripgrep recently. It can handle multiple directories and seems to be pretty fast. e.g. `rg CTxDestination bitcoin*` will search all directories in current dir starting with bitcoin.
< bitcoin-git> [bitcoin] fanquake merged pull request #20491: refactor: Drop noop gcc version checks (master...201125-gcc) https://github.com/bitcoin/bitcoin/pull/20491
< bitcoin-git> bitcoin/master 817aeca fanquake: Merge #20491: refactor: Drop noop gcc version checks
< bitcoin-git> bitcoin/master 830ddf4 Hennadii Stepanov: Drop noop gcc version checks
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2e1336dbfe8a...817aeca57a4c