2021-07-18

< bitcoin-git> [bitcoin] fanquake merged pull request #20641: depends: Use Qt top-level build facilities (master...201213-top) https://github.com/bitcoin/bitcoin/pull/20641
< bitcoin-git> bitcoin/master 6a1f98f Hennadii Stepanov: build, qt: Drop lrelease dependency patch
< bitcoin-git> bitcoin/master 39e561e Hennadii Stepanov: build, qt: Add linguist_tools list
< bitcoin-git> bitcoin/master 27d3def Hennadii Stepanov: build: Use Qt top-level build facilities
< bitcoin-git> [bitcoin] fanquake pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/b5889611c7ad...4315dc02a1eb
< bitcoin-git> [bitcoin] fanquake merged pull request #22234: build: Mark print-% target as phony. (master...mark_print_as_phony) https://github.com/bitcoin/bitcoin/pull/22234
< bitcoin-git> bitcoin/master b588961 fanquake: Merge bitcoin/bitcoin#22234: build: Mark print-% target as phony.
< bitcoin-git> bitcoin/master fb7be92 Dmitry Goncharov: Mark print-% target as phony.
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6baabc4d1dfa...b5889611c7ad
< bitcoin-git> [bitcoin] fanquake merged pull request #21430: build: Add -Werror=implicit-fallthrough compile flag (master...210313-fall) https://github.com/bitcoin/bitcoin/pull/21430
< bitcoin-git> bitcoin/master 6baabc4 fanquake: Merge bitcoin/bitcoin#21430: build: Add -Werror=implicit-fallthrough compi...
< bitcoin-git> bitcoin/master 3c4c8e7 Hennadii Stepanov: build: Add -Werror=implicit-fallthrough compile flag
< bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/f8b20fd35b0e...6baabc4d1dfa
< bitcoin-git> bitcoin/master 014110c Hennadii Stepanov: Use C++17 [[fallthrough]] attribute, and drop -Wno-implicit-fallthrough
< bitcoin-git> [bitcoin] jonatack opened pull request #22481: mempool: apply rule of 3 to epochguard.h, fix compiler warnings (master...epochguard-rule-of-three) https://github.com/bitcoin/bitcoin/pull/22481

2021-07-17

< bitcoin-git> [bitcoin] keystrike closed pull request #22480: doc: Moved -debuglogfile option to Debugging options (master...master) https://github.com/bitcoin/bitcoin/pull/22480
< bitcoin-git> [bitcoin] keystrike opened pull request #22480: doc: Moved -debuglogfile option to Debugging options (master...master) https://github.com/bitcoin/bitcoin/pull/22480
< bitcoin-git> [bitcoin] jonatack opened pull request #22479: p2p, doc: log DEBUG_ADDRMAN consistency checks, add developer notes info (master...debug-addrman) https://github.com/bitcoin/bitcoin/pull/22479
<@gribble> https://github.com/bitcoin/bitcoin/issues/22341 | rpc: add getxpub by Sjors · Pull Request #22341 · bitcoin/bitcoin · GitHub
< roconnor> hopefully the build of Bitcoin is independent of which version of guix you are using? Or maybe the specific bootstrap data is tied to guix versions, and that is what you are worried about?

2021-07-16

<@gribble> https://github.com/bitcoin/bitcoin/issues/22471 | addrman: reset I2P ports in all "new" buckets by vasild · Pull Request #22471 · bitcoin/bitcoin · GitHub
<@gribble> https://github.com/bitcoin/bitcoin/issues/17975 | TestFramework: Add Python Miniscript Support by jachiang · Pull Request #17975 · bitcoin/bitcoin · GitHub
<@gribble> https://github.com/bitcoin/bitcoin/issues/16800 | Basic Miniscript support in output descriptors by sipa · Pull Request #16800 · bitcoin/bitcoin · GitHub
< core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
< sipa> so it's not very appealing to see them diverge further if more feature are added to miniscript, independently of bitcoin core's script code
< sipa> and testing it is effectively dependent on being able to use bitcoin core's scripting engine
< sipa> the miniscript c++ repository is currently somewhat in limbo; it works, but it heavily depends on code copied from bitcoin core
< michaelfolkson> "I'd very much want to see it further along in integrating into Bitcoin Core" <- That sounded to me like you'd rather Miniscript was merged into Core before it supported Taproot
< sipa> if integrated into bitcoin core, it'd be also easy to e.g. produce test sets using fuzzing, which could be tested in other implementations
< sipa> and the Bitcoin Core wallet does support taproot scripts by the way, just only very limited ones (effectively just "<pubkey> OP_CHECKSIG")
< achow101> There are proposed taproot fields for psbt PR'd to the bips repo: https://github.com/bitcoin/bips/pull/1139
<@gribble> https://github.com/bitcoin/bitcoin/issues/22461 | wallet: Change ScriptPubKeyMan::Upgrade default to True by achow101 · Pull Request #22461 · bitcoin/bitcoin · GitHub
< meshcollider> #bitcoin-core-dev Wallet Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik petertodd phantomcircuit promag
< core-meetingbot> Meeting started Fri Jul 16 19:00:56 2021 UTC. The chair is meshcollider. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
<@gribble> https://github.com/bitcoin/bitcoin/issues/22112 | Force port 0 in I2P by vasild · Pull Request #22112 · bitcoin/bitcoin · GitHub
<@gribble> https://github.com/bitcoin/bitcoin/issues/22470 | Changing I2P ports in addrman may wronly skip some entries from "new" buckets · Issue #22470 · bitcoin/bitcoin · GitHub
<@gribble> https://github.com/bitcoin/bitcoin/issues/22467 | Assertion `nRndPos1 < vRandom.size() && nRndPos2 < vRandom.size() failed · Issue #22467 · bitcoin/bitcoin · GitHub
<@gribble> https://github.com/bitcoin/bitcoin/issues/22112 | Force port 0 in I2P by vasild · Pull Request #22112 · bitcoin/bitcoin · GitHub
<@gribble> https://github.com/bitcoin/bitcoin/issues/22471 | addrman: reset I2P ports in all "new" buckets by vasild · Pull Request #22471 · bitcoin/bitcoin · GitHub
<@gribble> https://github.com/bitcoin/bitcoin/issues/22470 | Changing I2P ports in addrman may wronly skip some entries from "new" buckets · Issue #22470 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] agroce opened pull request #22472: fuzz: Add environment option to keep /tmp/ clean (master...master) https://github.com/bitcoin/bitcoin/pull/22472
< bitcoin-git> [bitcoin] vasild opened pull request #22471: addrman: reset I2P ports in all "new" buckets (master...reset_all_new_i2p_ports) https://github.com/bitcoin/bitcoin/pull/22471
< vasild> 3. https://github.com/bitcoin/bitcoin/issues/22450#issuecomment-880602891 - I am working on it now, will also report it separately and open PR with a fix
<@gribble> https://github.com/bitcoin/bitcoin/issues/22468 | addrman: dont overwrite addr_info when resetting I2P ports by vasild · Pull Request #22468 · bitcoin/bitcoin · GitHub
<@gribble> https://github.com/bitcoin/bitcoin/issues/22467 | Assertion `nRndPos1 < vRandom.size() && nRndPos2 < vRandom.size() failed · Issue #22467 · bitcoin/bitcoin · GitHub
< vasild> 2. https://github.com/bitcoin/bitcoin/issues/22450#issuecomment-880629375 which I also reported separately in #22467, fixed in #22468
<@gribble> https://github.com/bitcoin/bitcoin/issues/22455 | addrman: detect on-disk corrupted nNew and nTried during unserialization by vasild · Pull Request #22455 · bitcoin/bitcoin · GitHub
<@gribble> https://github.com/bitcoin/bitcoin/issues/22450 | addrman serialize: nNew was wrong, oh ow · Issue #22450 · bitcoin/bitcoin · GitHub
< vasild> sipa_: yes, it is not in any previous releases, but there are already a bunch of nodes and in seeds.txt, so the i2p bitcoin network exists
<@gribble> https://github.com/bitcoin/bitcoin/issues/22468 | addrman: dont overwrite addr_info when resetting I2P ports by vasild · Pull Request #22468 · bitcoin/bitcoin · GitHub
< vasild> sipa_: https://github.com/bitcoin/bitcoin/pull/22455#issuecomment-881525272 -- that is a good question but I think you posted it in the wrong PR, that PR is not related to I2P at all. Maybe you intended to post to #22468 instead?
<@gribble> https://github.com/bitcoin/bitcoin/issues/22468 | addrman: dont overwrite addr_info when resetting I2P ports by vasild · Pull Request #22468 · bitcoin/bitcoin · GitHub
< jonatack> yup, I called for more people to review in https://github.com/bitcoin/bitcoin/pull/22112#pullrequestreview-699042238, one can't be a review army by oneself but there are indeed few regular p2p contributors who look at work on privacy networks
< bitcoin-git> [bitcoin] hebasto opened pull request #22469: build: Add support for Android NDK r22+ (master...210716-ndk) https://github.com/bitcoin/bitcoin/pull/22469
<@gribble> https://github.com/bitcoin/bitcoin/issues/22450 | addrman serialize: nNew was wrong, oh ow · Issue #22450 · bitcoin/bitcoin · GitHub
< MarcoFalke> > [09:43] <vasild> MarcoFalke: do you think that the fuzzer inputs from #22450 should be collected and added to bitcoin-core/qa-assets ?
< bitcoin-git> [bitcoin] vasild opened pull request #22468: addrman: don't overwrite addr_info when resetting I2P ports (master...reset_i2p_ports_no_overwrite_pos) https://github.com/bitcoin/bitcoin/pull/22468
< vasild> jnewbery: https://github.com/bitcoin/bitcoin/issues/22450#issuecomment-880602891 is a 3rd issue, I have not confirmed it yet, but read the comment: yes, it looks like it can cause a corruption, but again that is a 3rd distinct problem. I suspect it may be resolved by just removing "addr_info.GetPort() == I2P_SAM31_PORT"
< jnewbery> vasild: do you disagree that https://github.com/bitcoin/bitcoin/issues/22450#issuecomment-880602891 can cause corruption?
< vasild> I am now looking at https://github.com/bitcoin/bitcoin/issues/22450#issuecomment-880629375 which is a different issue, not sure yet where is the problem
<@gribble> https://github.com/bitcoin/bitcoin/issues/22450 | addrman serialize: nNew was wrong, oh ow · Issue #22450 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jnewbery closed pull request #18685: consensus: Simplify ConnectTrace (master...2020-04-connecttrace-simplify) https://github.com/bitcoin/bitcoin/pull/18685
<@gribble> https://github.com/bitcoin/bitcoin/issues/22450 | addrman serialize: nNew was wrong, oh ow · Issue #22450 · bitcoin/bitcoin · GitHub
< vasild> MarcoFalke: do you think that the fuzzer inputs from #22450 should be collected and added to bitcoin-core/qa-assets ?
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #22464: bench: fix 32-bit narrowing warning in bench/peer_eviction.cpp (master...fix-32bit-narrowing-warning) https://github.com/bitcoin/bitcoin/pull/22464
< bitcoin-git> bitcoin/master f8b20fd MarcoFalke: Merge bitcoin/bitcoin#22464: bench: fix 32-bit narrowing warning in bench/...
< bitcoin-git> bitcoin/master e49d50c Jon Atack: bench: fix 32-bit narrowing warning in bench/peer_eviction.cpp
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a88fa1a55519...f8b20fd35b0e
< fanquake> Guix is also a much more likely pathway to fully bootstrapable Bitcoin Core builds that what gitian could ever provide.
< fanquake> These are just two very practical benefits that using Guix provides (there are more), which ultimately all boil down to us being in much greater control of our release build environment. Something I am very happy about, and I think makes a lot of sense for a project like Bitcoin Core.
<@gribble> https://github.com/bitcoin/bitcoin/issues/22405 | build: remove --enable-glibc-back-compat from Guix build by fanquake · Pull Request #22405 · bitcoin/bitcoin · GitHub
<@gribble> https://github.com/bitcoin/bitcoin/issues/22365 | guix: Avoid relying on newer symbols by rebasing our cross toolchains on older glibcs by dongcarl · Pull Request #22365 · bitcoin/bitcoin · GitHub
< fanquake> This means that as you use newer versions of glibc, the number of "workarounds" you need to maintain backwards compatibility pile up, get continually more complicated, and even start to leak out of Bitcoin Core code, and into our dependency system. See all the PRs linked in this comment: https://github.com/bitcoin/bitcoin/pull/22418#issuecomment-876379846.
<@gribble> https://github.com/bitcoin/bitcoin/issues/22381 | guix: Test security-check sanity before performing them (with macOS) by fanquake · Pull Request #22381 · bitcoin/bitcoin · GitHub
<@gribble> https://github.com/bitcoin/bitcoin/issues/18629 | scripts: add PE .reloc section check to security-check.py by fanquake · Pull Request #18629 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] dongcarl opened pull request #22465: guix: Pin kernel-header version, time-machine to upstream 1.3.0 commit (master...2021-07-guix-kernel-old) https://github.com/bitcoin/bitcoin/pull/22465
< bitcoin-git> [bitcoin] fanquake closed pull request #22336: [TESTBED][NO-MERGE][POC] Use std::filesystem. Remove Boost Filesystem & System (master...feature/use_std_filesystem_testbed) https://github.com/bitcoin/bitcoin/pull/22336
< bitcoin-git> [bitcoin] fanquake closed pull request #22463: [TESTBED][NO-MERGE] Verbosity level 3 getblock rebase (master...verbosity-level-3-getblock-rebase) https://github.com/bitcoin/bitcoin/pull/22463

2021-07-15

< bitcoin-git> [bitcoin] hebasto closed pull request #22456: [WIP] build: Use specific cross-compilers instead of multilib one (master...210715-multilib) https://github.com/bitcoin/bitcoin/pull/22456
< bombingmiami> belcher is a liar piece of shit is that right belcher? He got 50.000 dollars from hrf.org to attack me and my organization. I had edit privileges on Bitcoin Wiki since 2015 with the username "humanrightsfoundation" https://web.archive.org/web/20151031001911/https://bitcointalk.org/index.php?topic=1025908.40. On 2020 Jun belcher was attacked me and
<@gribble> https://github.com/bitcoin/bitcoin/issues/22456 | [WIP] build: Use specific cross-compilers instead of multilib one by hebasto · Pull Request #22456 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonatack opened pull request #22464: bench: fix 32-bit narrowing warning in bench/peer_eviction.cpp (master...fix-32bit-narrowing-warning) https://github.com/bitcoin/bitcoin/pull/22464
< bitcoin-git> [bitcoin] kiminuo opened pull request #22463: [TESTBED][NO-MERGE] Verbosity level 3 getblock rebase (master...verbosity-level-3-getblock-rebase) https://github.com/bitcoin/bitcoin/pull/22463
<@gribble> https://github.com/bitcoin/bitcoin/issues/22439 | build: Use guix within gitian by achow101 · Pull Request #22439 · bitcoin/bitcoin · GitHub
< core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
< BlueMatt> jonatack: I mean have y'all bothered to ask if people *are* vaccinated? In my experience among bitcoin *developers* its like 100%. among bitcoin twitter users its much different.
<@gribble> https://github.com/bitcoin/bitcoin/issues/22421 | Make IsSegWitOutput return true for taproot outputs by sipa · Pull Request #22421 · bitcoin/bitcoin · GitHub
< luke-jr> [19:04:24] <gribble> https://github.com/bitcoin/bitcoin/issues/22421 | Make IsSegWitOutput return true for taproot outputs by sipa · Pull Request #22421 · bitcoin/bitcoin · GitHub
<@gribble> https://github.com/bitcoin/bitcoin/issues/22421 | Make IsSegWitOutput return true for taproot outputs by sipa · Pull Request #22421 · bitcoin/bitcoin · GitHub
<@gribble> https://github.com/bitcoin/bitcoin/issues/22450 | addrman serialize: nNew was wrong, oh ow · Issue #22450 · bitcoin/bitcoin · GitHub
< laanwj> we're getting even closer, the last PRs are nearly ready for merge https://github.com/bitcoin/bitcoin/milestone/47 , after which we should tag rc1 imo, but some last-minute issue came up while fuzzing addrman serialization (#22450)
<@gribble> https://github.com/bitcoin/bitcoin/issues/22450 | addrman serialize: nNew was wrong, oh ow · Issue #22450 · bitcoin/bitcoin · GitHub
< laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos
< core-meetingbot> Meeting started Thu Jul 15 19:00:17 2021 UTC. The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #22457: refactor: Remove unused "disconnectpool is nullptr" feature (master...2107-refactorDisconnectPool) https://github.com/bitcoin/bitcoin/pull/22457
< bitcoin-git> [bitcoin] achow101 opened pull request #22461: wallet: Change ScriptPubKeyMan::Upgrade default to True (master...implement-desc-upgrade) https://github.com/bitcoin/bitcoin/pull/22461
<@gribble> https://github.com/bitcoin/bitcoin/issues/22112 | Force port 0 in I2P by vasild · Pull Request #22112 · bitcoin/bitcoin · GitHub
< luke-jr> off-topic here tho, further ?s to #bitcoin please
< ron-slc> any word on why bitcoin.org is down?
<@gribble> https://github.com/bitcoin/bitcoin/issues/22450 | addrman serialize: nNew was wrong, oh ow · Issue #22450 · bitcoin/bitcoin · GitHub
<@gribble> https://github.com/bitcoin/bitcoin/issues/21711 | guix: Add full installation and usage documentation by dongcarl · Pull Request #21711 · bitcoin/bitcoin · GitHub
<@gribble> https://github.com/bitcoin/bitcoin/issues/22421 | Make IsSegWitOutput return true for taproot outputs by sipa · Pull Request #22421 · bitcoin/bitcoin · GitHub
<@gribble> https://github.com/bitcoin/bitcoin/issues/22387 | Rate limit the processing of rumoured addresses by sipa · Pull Request #22387 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj merged pull request #22211: net: relay I2P addresses even if not reachable (by us) (master...i2p_IsRelayable) https://github.com/bitcoin/bitcoin/pull/22211
< bitcoin-git> bitcoin/master 33e211d Vasil Dimov: test: implement ser/unser of I2P addresses in functional tests
< bitcoin-git> bitcoin/master 8674281 Vasil Dimov: test: use NODE_* constants instead of magic numbers
< bitcoin-git> bitcoin/master ba45f02 Vasil Dimov: net: relay I2P addresses even if not reachable (by us)
< bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/853ac47705c8...a88fa1a55519
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #22393: doc: added info to bitcoin.conf doc (master...patch-1) https://github.com/bitcoin/bitcoin/pull/22393
< bitcoin-git> bitcoin/master 853ac47 MarcoFalke: Merge bitcoin/bitcoin#22393: doc: added info to bitcoin.conf doc
< bitcoin-git> bitcoin/master fa84cae Brian Liotti: doc: added info to bitcoin.conf doc
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d86e6625e857...853ac47705c8
< bitcoin-git> [bitcoin] laanwj merged pull request #22369: doc: Add steps for Transifex to release process (master...update-transifex-release-process) https://github.com/bitcoin/bitcoin/pull/22369
< bitcoin-git> bitcoin/master d86e662 W. J. van der Laan: Merge bitcoin/bitcoin#22369: doc: Add steps for Transifex to release proce...
< bitcoin-git> bitcoin/master a16378e Wladimir J. van der Laan: doc: Remove unnecessary steps from translations update process
< bitcoin-git> bitcoin/master 2584929 Wladimir J. van der Laan: doc: Add steps for transifex to release process
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/21998bc028d6...d86e6625e857
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #22457: refactor: Remove unused disconnectpool is nullptr feature (master...2107-refactorDisconnectPool) https://github.com/bitcoin/bitcoin/pull/22457
< bitcoin-git> [bitcoin] laanwj merged pull request #22284: p2p, refactor: performance improvements to ProtectEvictionCandidatesByRatio() (master...ProtectEvictionCandidatesByRatio-perf-enhancements) https://github.com/bitcoin/bitcoin/pull/22284
< bitcoin-git> bitcoin/master 02e411e Jon Atack: p2p: iterate eviction protection only on networks having candidates
< bitcoin-git> bitcoin/master 5adb064 Jon Atack: bench: add peer eviction protection benchmarks
< bitcoin-git> bitcoin/master 566357f Jon Atack: refactor: move GetRandomNodeEvictionCandidates() to test utilities
< bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/c0224bc96287...21998bc028d6
< vasild> jnewbery: https://github.com/bitcoin/bitcoin/pull/22455 -- the underlying issue is that nNew came as -1 from disk (fuzzer), from here one way or another we are f**d up
< bitcoin-git> [bitcoin] hebasto opened pull request #22456: [WIP] build: Use specific cross-compilers instead of multilib one (master...210715-multilib) https://github.com/bitcoin/bitcoin/pull/22456
< bitcoin-git> [bitcoin] vasild opened pull request #22455: addrman: detect on-disk corrupted nNew and nTried during unserialization (master...addrman_detect_negative) https://github.com/bitcoin/bitcoin/pull/22455
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #22415: Make m_mempool optional in CChainState (master...2021-07-mempool-ptr) https://github.com/bitcoin/bitcoin/pull/22415
< bitcoin-git> bitcoin/master 4abf077 James O'Beirne: refactor: no mempool arg to GetCoinsCacheSizeState
< bitcoin-git> bitcoin/master 46e3efd James O'Beirne: refactor: move UpdateMempoolForReorg into CChainState
< bitcoin-git> bitcoin/master 6176617 James O'Beirne: validation: make CChainState::m_mempool optional
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/97153a702600...c0224bc96287
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #22454: fuzz: Limit max ops in tx_pool fuzz targets (master...2107-fuzzPool) https://github.com/bitcoin/bitcoin/pull/22454
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #22453: fuzz: Speed up rolling_bloom_filter fuzz test (master...2107-fuzzRoll) https://github.com/bitcoin/bitcoin/pull/22453
<@gribble> https://github.com/bitcoin/bitcoin/issues/22415 | Make m_mempool optional in CChainState by jamesob · Pull Request #22415 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #22385: refactor: Use DeploymentEnabled to hide VB deployments (master...2107-dep) https://github.com/bitcoin/bitcoin/pull/22385
< bitcoin-git> bitcoin/master 97153a7 MarcoFalke: Merge bitcoin/bitcoin#22385: refactor: Use DeploymentEnabled to hide VB de...
< bitcoin-git> bitcoin/master fa5658e MarcoFalke: Use DeploymentEnabled to hide VB deployments
< bitcoin-git> bitcoin/master fa11fec MarcoFalke: doc: Move buried deployment doc to the enum that enumerates them
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/e2c4ac7cfb58...97153a702600
< bitcoin-git> [bitcoin] fanquake merged pull request #22447: test: whitelist rpc_rawtransaction peers to speed up tests (master...speed-up-rpc_rawtransaction-test) https://github.com/bitcoin/bitcoin/pull/22447
< bitcoin-git> bitcoin/master e2c4ac7 fanquake: Merge bitcoin/bitcoin#22447: test: whitelist rpc_rawtransaction peers to s...
< bitcoin-git> bitcoin/master a3d6ec5 Jon Atack: test: move rpc_rawtransaction tests to < 30s group
< bitcoin-git> bitcoin/master 5a1ed96 Jon Atack: test: whitelist rpc_rawtransaction peers to speed up tests
< bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/fdf9b3eba3bc...e2c4ac7cfb58
< bitcoin-git> [bitcoin] fanquake merged pull request #22446: test: Fix wallet_listdescriptors.py if bdb is not compiled (master...210714-desc) https://github.com/bitcoin/bitcoin/pull/22446
< bitcoin-git> bitcoin/master fdf9b3e fanquake: Merge bitcoin/bitcoin#22446: test: Fix wallet_listdescriptors.py if bdb is...
< bitcoin-git> bitcoin/master 0c845e3 Hennadii Stepanov: test: Fix wallet_listdescriptors.py if bdb is not compiled
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/531c2b7c0489...fdf9b3eba3bc
< Bilnon> https://ieeexplore.ieee.org/document/8855738 - "Is Bitcoin Mining Halal? Investigating the Sharia Compliance of Bitcoin Mining"
< sipa> and it's unrelated to the development of the bitcoin core software
< Bilnon> what gets to me the most with acronyms like "uPoW" is how much these people take for granted the proof-of-work scheme used in bitcoin, like that useful proofs of work could be integrated at all without converting the entire system to a PoS system,
< Bilnon> I dont know how these idiot get their papers published, this is a terrible idea written by morons who clearly cant grasp even the basic concepts of bitcoin

2021-07-14

< bitcoin-git> [bitcoin] sipa opened pull request #22448: Update libsecp256k1 subtree to latest upstream (master...202107_secp256k1) https://github.com/bitcoin/bitcoin/pull/22448
< bitcoin-git> [bitcoin] jonatack opened pull request #22447: test: whitelist rpc_rawtransaction peers to speed up tests (master...speed-up-rpc_rawtransaction-test) https://github.com/bitcoin/bitcoin/pull/22447
< bitcoin-git> [bitcoin] hebasto opened pull request #22446: test: Fix wallet_listdescriptors.py if bdb is not compiled (master...210714-desc) https://github.com/bitcoin/bitcoin/pull/22446
< bitcoin-git> [bitcoin] sriramdvt opened pull request #22445: fuzz: Move implementations of non-template fuzz helpers from util.h to util.cpp (master...fuzz_move) https://github.com/bitcoin/bitcoin/pull/22445
< bitcoin-git> [bitcoin] fanquake closed pull request #20354: test: Add feature_taproot.py --previous_release (master...2010-testFeatureTaprootPreviousVersion) https://github.com/bitcoin/bitcoin/pull/20354
< bitcoin-git> [gui] hebasto opened pull request #381: refactor: Make BitcoinCore class reusable (master...210714-core) https://github.com/bitcoin-core/gui/pull/381
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #22444: fuzz: Speed up prevector fuzz target (master...2107-fuzzPrev) https://github.com/bitcoin/bitcoin/pull/22444
< bitcoin-git> [bitcoin] NelsonGaldeman opened pull request #22442: util: improves error messages on get_previous_releases script (master...improves-error-message-on-utils) https://github.com/bitcoin/bitcoin/pull/22442
< bitcoin-git> bitcoin/master 29d6b1d Sjors Provoost: test: previous releases: add v0.20.1
< bitcoin-git> bitcoin/master 85ccffa Sjors Provoost: test: move releases download incantation to README
< bitcoin-git> bitcoin/master fa80e10 MarcoFalke: test: Add feature_taproot.py --previous_release
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/d8f1e1327f9c...531c2b7c0489
< bitcoin-git> [bitcoin] JeremyRubin opened pull request #22440: Eliminate Signature Checker/Creator Ambiguity w/ LIFETIMEBOUND References (master...lifetimeboundcheckers) https://github.com/bitcoin/bitcoin/pull/22440

2021-07-13

< bitcoin-git> [bitcoin] achow101 opened pull request #22439: build: Use guix within gitian (master...guix-in-gitian) https://github.com/bitcoin/bitcoin/pull/22439
< bitcoin-git> [bitcoin] vasild closed pull request #21514: p2p: Ignore ports on I2P addresses (master...ignore_port_in_i2p) https://github.com/bitcoin/bitcoin/pull/21514
< Insane> The perfect way to make profits from our bitcoin asset is by liquidating
< MarcoFalke> I replied on the pull request: https://github.com/bitcoin/bitcoin/pull/22415#issuecomment-879147719 (The secp failure is expected)
< roconnor> [Monday, June 28, 2021] [10:07:08 AM EDT] <real_or_random> https://github.com/bitcoin-core/secp256k1/pull/959 :O this had a red cirrus run (due to failed randomness tests), which scared me of for a second...
< jamesob> kinda scary looking secp test failure; anyone seen this before? https://github.com/bitcoin/bitcoin/pull/22415#issuecomment-879089245
< bitcoin-git> [bitcoin] jonatack opened pull request #22437: test, refactor: add GetTransaction() coverage, improve rpc_rawtransaction (master...improve-gettransaction-test-coverage) https://github.com/bitcoin/bitcoin/pull/22437
< bitcoin-git> [bitcoin] laanwj merged pull request #22112: Force port 0 in I2P (master...force_port_0_in_i2p) https://github.com/bitcoin/bitcoin/pull/22112
< bitcoin-git> bitcoin/master 1f096f0 Vasil Dimov: net: distinguish default port per network
< bitcoin-git> bitcoin/master aeac3bc Vasil Dimov: net: change I2P seeds' ports to 0
< bitcoin-git> bitcoin/master 38f9002 Vasil Dimov: net: change assumed I2P port to 0
< bitcoin-git> [bitcoin] laanwj pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/7e1ba37b5dac...d8f1e1327f9c
< bitcoin-git> [bitcoin] fanquake opened pull request #22436: build: use aarch64 Clang if cross-compiling for darwin on aarch64 (master...arm64_macos_cross_clang) https://github.com/bitcoin/bitcoin/pull/22436
< laanwj> if you want to fork bitcoin core, go ahead, i don't think it would be bad to have more projects at all, you'll also discover soon enough that maintaining a project like this is difficult
<@gribble> https://github.com/bitcoin/bitcoin/issues/22403 | Installation via Bitcoin-Core.dmg is broken on macOS (Apple Silicon) · Issue #22403 · bitcoin/bitcoin · GitHub
<@gribble> https://github.com/bitcoin/bitcoin/issues/21851 | [WIP] build: support cross-compiling for arm64-apple-darwin20 (Apple M1) in depends by fanquake · Pull Request #21851 · bitcoin/bitcoin · GitHub

2021-07-12

< prayank> And I didn't use bitcoin because of number go up FYI
< sipa> prayank: i would encourage you to find other things in life to do too; making everything about bitcoin (or any single thing) is going to drive you nuts
< prayank> married lots of other things. I just want to focus on learning and doing better. I have issues idk. Lets see. If not Core. Fork. But Bitcoin.
< prayank> sipa I dont know much about you to be honest but I started using bitcoin in 2015 because of some reasons and have some background. I am not as goood as you in programming. But maybe I was never good in anything thats why chatting here today, or I care too much about Bitcoin. I think I have decided that I can do anything for Bitcoin. Younger bro
< sipa> okay - as long as you don't have an expectation that these tests will be integrated into the bitcoin core repository or test infrastructure
< prayank> Goal: 1. Internship project 2. Nice GUI for script kiddies to play and think Bitcoin is not Digital Gold mem they can play with it and pentest. 3. Reference in Infosec Conf: I dont need followers. Bitcoin needs software devs. 4. Experiment and lets see see if we if find something new
< prayank> Thoughts on this issue: https://github.com/bitcoin/bitcoin/issues/22424
< prayank> Idk. I am true to myself and others. I tried everything. Its not helping. I will look for funding or do something to start a better fork (better than Luke Dash Jr). I don't care about anyone to be honest but Bitcoin. Only person I liked during conversations was Pieter Wuille, Greg Maxwell and Sometimes Drunk conversations with others. But I always
< sipa> and wrote the tor hidden service support in bitcoin core
< prayank> Thoughts on this issue: https://github.com/bitcoin/bitcoin/issues/22424
< prayank> and Bitcoin needs nothing?
< prayank> achow101: please do not take anything for you. Because its not. Maintainers suck, And its for them. Or maybe compromised by now. However, I couldnt find a vulnerability that they introduced so they can enjoy. You need examples: Ex1: https://github.com/bitcoin/bitcoin/pull/22432 (how to merge quickly) with less ACKs. No merge after few ACKs:
< bitcoin-git> [bitcoin] prayank23 closed pull request #21870: github: Add `config.yml` for GUI issues (master...issue-templates) https://github.com/bitcoin/bitcoin/pull/21870
< bitcoin-git> [bitcoin] prayank23 closed pull request #21755: Add more info about prefix in error message for invalid address (master...error-address) https://github.com/bitcoin/bitcoin/pull/21755
< bitcoin-git> [bitcoin] prayank23 closed pull request #22316: doc: Add 5 privacy recommendations in tor.md (master...tor-privacy-recommend) https://github.com/bitcoin/bitcoin/pull/22316
< bitcoin-git> [bitcoin] prayank23 closed pull request #22430: Fix syntax for `getindexinfo` params in help examples (master...getindexinfo) https://github.com/bitcoin/bitcoin/pull/22430
< bitcoin-git> [bitcoin] prayank23 closed pull request #22317: doc: Highlight DNS requests part in tor.md (master...highlight-dns-request) https://github.com/bitcoin/bitcoin/pull/22317
< prayank> How many ACKs are required for a PR to get merged if the author is not from chaincode labs or blockstream or OG dev for a simple change that doesn't affect functionality in Bitcoin Core?
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #22434: Copyright fix to 2021 from 2020 (master...patch-1) https://github.com/bitcoin/bitcoin/pull/22434
< bitcoin-git> [bitcoin] salemalem opened pull request #22434: Copyright fix to 2021 from 2020 (master...patch-1) https://github.com/bitcoin/bitcoin/pull/22434
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #22433: init: remove straggling boost thread_group related code (master...struggling_thread_group) https://github.com/bitcoin/bitcoin/pull/22433
< bitcoin-git> bitcoin/master aa72ffb fanquake: init: remove straggling boost thread_group code
< bitcoin-git> bitcoin/master 7e1ba37 MarcoFalke: Merge bitcoin/bitcoin#22433: init: remove straggling boost thread_group re...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/839f5d06d6de...7e1ba37b5dac
< vasild> there are some ipv4, ipv6, i2p and incoming tor (127.0.0.1) - https://github.com/bitcoin/bitcoin/pull/22387#issuecomment-878426183
< vasild> sipa: in https://github.com/bitcoin/bitcoin/pull/22387#issuecomment-878417152, do you mean that if a node is connected to e.g. only 3 others and I am one of those 3, then every time that node chooses 2 random peers to relay to, then I am very likely to be the chosen one?
< sipa> is your question about whether there is a benefit to *using* an old bitcoin core version to spy with (no, spy nodes aren't bitcoin core at all, or heavily modified ones at least), or whether there is a benefit to *claiming* you're an old bitcoin core version when spying (not really, you can claim whatever you want, the data isn't used for anything except statistics etc)
< prayank> Is there any way to make version spoofing difficult in software like Bitcoin Core?
< bitcoin-git> [bitcoin] fanquake opened pull request #22433: init: remove straggling boost thread_group related code (master...struggling_thread_group) https://github.com/bitcoin/bitcoin/pull/22433
< bitcoin-git> bitcoin/master 9169be0 glozow: fix incorrect testmempoolaccept doc
< bitcoin-git> bitcoin/master 839f5d0 fanquake: Merge bitcoin/bitcoin#22432: doc: fix incorrect testmempoolaccept doc
< bitcoin-git> [bitcoin] fanquake merged pull request #22432: doc: fix incorrect testmempoolaccept doc (master...2021-07-testmempoolaccept-doc) https://github.com/bitcoin/bitcoin/pull/22432
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/842e2a9c54bd...839f5d06d6de
< bitcoin-git> [bitcoin] laanwj merged pull request #20234: net: don't bind on 0.0.0.0 if binds are restricted to Tor (master...bind) https://github.com/bitcoin/bitcoin/pull/20234
< bitcoin-git> bitcoin/master 842e2a9 W. J. van der Laan: Merge bitcoin/bitcoin#20234: net: don't bind on 0.0.0.0 if binds are restr...
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e0fe658b863e...842e2a9c54bd
< bitcoin-git> bitcoin/master 2feec3c Vasil Dimov: net: don't bind on 0.0.0.0 if binds are restricted to Tor
< bitcoin-git> bitcoin/master e0fe658 W. J. van der Laan: Merge bitcoin/bitcoin#22335: doc: recommend `--disable-external-signer` in...
< bitcoin-git> [bitcoin] laanwj merged pull request #22335: doc: recommend `--disable-external-signer` in OpenBSD build guide (master...202106-doc-openbsd_mention_missing_external_signer_support) https://github.com/bitcoin/bitcoin/pull/22335
< bitcoin-git> bitcoin/master e65d1d4 Sebastian Falbesoner: doc: recommend `--disable-external-signer` in OpenBSD build guide
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8ab0c77299a5...e0fe658b863e
< bitcoin-git> [bitcoin] glozow opened pull request #22432: fix incorrect testmempoolaccept doc (master...2021-07-testmempoolaccept-doc) https://github.com/bitcoin/bitcoin/pull/22432

2021-07-11

< shiza> Oh, my bad, I thought this was #bitcoin.
< ZEFRON> 2. When I tried to fork Bitcoin-core I hit a roadblock with my implementation at the inability to gracefully access node.chainman within CheckProofOfWork()
< bitcoin-git> [bitcoin] prayank23 opened pull request #22430: Fix syntax for `getindexinfo` params in help examples (master...getindexinfo) https://github.com/bitcoin/bitcoin/pull/22430
< bitcoin-git> [bitcoin] theStack opened pull request #22429: test: refactor: fix segwit terminology (s/witness_program/witness_script/) (master...202107-test-fix_segwit_terminology) https://github.com/bitcoin/bitcoin/pull/22429
< bitcoin-git> [bitcoin] sanket1729 opened pull request #22428: [Refactor] Rename scriptPubKey -> witness_script (master...witness_script_rename) https://github.com/bitcoin/bitcoin/pull/22428
< bitcoin-git> [bitcoin] hebasto opened pull request #22427: [0.21] gui: Backports for 0.21.2 (0.21...210711-21.2-gui-backports) https://github.com/bitcoin/bitcoin/pull/22427

2021-07-10

< brcolow> I am confused by something. If you look at this line of code: https://github.com/bitcoin/bitcoin/blob/master/src/crypto/sha256_avx2.cpp#L63 it is writing a 32-bit (4byte) integer. In the case of -1996298034 that is, in big endian, 8902 e8ce - then it's converted to little endian which is CEE8 0289 - however what's strange is that WriteLE32 function writes CEE8289 - it skips the
< bitcoin-git> [bitcoin] theStack opened pull request #22423: test: wallet_listtransactions improvements (speedup, cleanup, logging) (master...202106-test-improve-wallet_listtransactions_test) https://github.com/bitcoin/bitcoin/pull/22423
< michaelfolkson> gazza: As the topic of the channel says this channel is for development discussion. #bitcoin for general usage

2021-07-09

< prayank> Cool. Any thoughts on this issue? https://github.com/bitcoin/bitcoin/issues/22368
< bitcoin-git> [bitcoin] sipa opened pull request #22421: Make IsSegWitOutput return true for taproot outputs (master...202107_taproot_is_segwit) https://github.com/bitcoin/bitcoin/pull/22421
< bitcoin-git> [bitcoin] laanwj merged pull request #22253: validation: distinguish between same tx and same-nonwitness-data tx in mempool (master...2021-06-same-txid-diff-wtxid) https://github.com/bitcoin/bitcoin/pull/22253
< bitcoin-git> bitcoin/master fdb4816 glozow: [validation] distinguish same txid different wtxid in mempool
< bitcoin-git> bitcoin/master b7a8cd9 glozow: [test] submit same txid different wtxid as mempool tx
< bitcoin-git> bitcoin/master 8ab0c77 W. J. van der Laan: Merge bitcoin/bitcoin#22253: validation: distinguish between same tx and s...
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d1e4c56309ae...8ab0c77299a5
< bitcoin-git> [bitcoin] lsilva01 opened pull request #22420: Specifies how to set the value of TORGROUP (master...patch-1) https://github.com/bitcoin/bitcoin/pull/22420
<@gribble> https://github.com/bitcoin/bitcoin/issues/22253 | validation: distinguish between same tx and same-nonwitness-data tx in mempool by glozow · Pull Request #22253 · bitcoin/bitcoin · GitHub
< bitcoin-git> bitcoin/master 285a65c Sebastian Falbesoner: test: use script_util helpers for creating P2SH scripts
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #22363: test: refactor: use `script_util` helpers for creating P2{PKH,SH,WPKH,WSH} scripts (master...202106-test-refactor-use_scriptpubkey_helpers) https://github.com/bitcoin/bitcoin/pull/22363
< bitcoin-git> bitcoin/master b57b633 Sebastian Falbesoner: test: use script_util helpers for creating P2PKH scripts
< bitcoin-git> bitcoin/master 61b6a01 Sebastian Falbesoner: test: wallet util: fix multisig P2SH-P2WSH script creation
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/efff9c3494a9...d1e4c56309ae
< bitcoin-git> [bitcoin] Terrificdatabytes closed pull request #22419: 0.21 (master...0.21) https://github.com/bitcoin/bitcoin/pull/22419
< bitcoin-git> [bitcoin] Terrificdatabytes opened pull request #22419: 0.21 (master...0.21) https://github.com/bitcoin/bitcoin/pull/22419
< bitcoin-git> [bitcoin] fanquake merged pull request #22176: test: Correct outstanding -Werror=sign-compare errors (master...2021-06-sign-compare) https://github.com/bitcoin/bitcoin/pull/22176
< bitcoin-git> bitcoin/master efff9c3 fanquake: Merge bitcoin/bitcoin#22176: test: Correct outstanding -Werror=sign-compar...
< bitcoin-git> bitcoin/master 4e44f5b Ben Woosley: test: Correct outstanding -Werror=sign-compare errors
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/34d1d6a11270...efff9c3494a9
< bitcoin-git> [bitcoin] fanquake merged pull request #22381: guix: Test security-check sanity before performing them (with macOS) (master...20980_macOS_fixups) https://github.com/bitcoin/bitcoin/pull/22381
< bitcoin-git> bitcoin/master bda62ea fanquake: ci: skip running the Linux test-security-check target for now
< bitcoin-git> bitcoin/master 9fdc8af Carl Dong: devtools: Improve *-check.py tool detection
< bitcoin-git> [bitcoin] fanquake pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/df2b5dadfb2d...34d1d6a11270
< bitcoin-git> bitcoin/master d6ef354 Carl Dong: lint: Run mypy with --show-error-codes

2021-07-08

<@gribble> https://github.com/bitcoin/bitcoin/issues/21800 | mempool/validation: mempool ancestor/descendant limits for packages by glozow · Pull Request #21800 · bitcoin/bitcoin · GitHub
< bitcoin-git> [gui] ryanofsky opened pull request #379: Prompt to reset settings when settings.json cannot be read (master...pr/badset) https://github.com/bitcoin-core/gui/pull/379
<@gribble> https://github.com/bitcoin/bitcoin/issues/21859 | Add minisketch subtree and integrate in build/test by sipa · Pull Request #21859 · bitcoin/bitcoin · GitHub
< core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
<@gribble> https://github.com/bitcoin/bitcoin/issues/22112 | Force port 0 in I2P by vasild · Pull Request #22112 · bitcoin/bitcoin · GitHub
<@gribble> https://github.com/bitcoin/bitcoin/issues/22412 | Bugfix: Workaround UniValue push_back(bool) limitation with push_back(UniValue(bool)) by luke-jr · Pull Request #22412 · bitcoin/bitcoin · GitHub
<@gribble> https://github.com/bitcoin/bitcoin/issues/20234 | net: dont bind on 0.0.0.0 if binds are restricted to Tor by vasild · Pull Request #20234 · bitcoin/bitcoin · GitHub
< laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos
< core-meetingbot> Meeting started Thu Jul 8 19:00:22 2021 UTC. The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #22408: test: add tests for `bad-txns-prevout-null` reject reason (master...202107-test-add_test_for_bad-txns-prevout-null) https://github.com/bitcoin/bitcoin/pull/22408
< bitcoin-git> bitcoin/master 1f44958 Sebastian Falbesoner: test: add `bad-txns-prevout-null` test to mempool_accept.py
< bitcoin-git> bitcoin/master df2b5da MarcoFalke: Merge bitcoin/bitcoin#22408: test: add tests for `bad-txns-prevout-null` r...
< bitcoin-git> bitcoin/master aa0a5bb Sebastian Falbesoner: test: add `bad-txns-prevout-null` test case to invalid_txs.py
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d96861642200...df2b5dadfb2d
< bitcoin-git> [gui] hebasto closed pull request #225: Fix PaymentServer::handleURIOrFile warning message (master...210224-server) https://github.com/bitcoin-core/gui/pull/225
< bitcoin-git> [bitcoin] laanwj merged pull request #22179: Torv2 removal followups (master...torv2_removal_followup) https://github.com/bitcoin/bitcoin/pull/22179
< bitcoin-git> bitcoin/master a164cd3 Vasil Dimov: net: simplify CNetAddr::IsRoutable()
< bitcoin-git> bitcoin/master bdb6209 Vasil Dimov: fuzz: reduce possible networks check
< bitcoin-git> bitcoin/master 00b875b Vasil Dimov: addrman: remove invalid addresses when unserializing
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/4129134e844f...d96861642200
< bitcoin-git> [bitcoin] fanquake opened pull request #22418: [WIIP] release: Remove gitian (master...remove_gitian) https://github.com/bitcoin/bitcoin/pull/22418
< bitcoin-git> [bitcoin] luke-jr opened pull request #22417: util/system: Close non-std fds before execing slave processes (master...bpchild_closefds) https://github.com/bitcoin/bitcoin/pull/22417
< bitcoin-git> [bitcoin] fanquake merged pull request #22366: [0.21] fuzz: add missing ECCVerifyHandle to base_encode_decode (0.21...backport_22279) https://github.com/bitcoin/bitcoin/pull/22366
< bitcoin-git> bitcoin/0.21 513613d MarcoFalke: Cleanup -includeconf error message
< bitcoin-git> bitcoin/0.21 70eac6f MarcoFalke: Fix crash when parsing command line with -noincludeconf=0
< bitcoin-git> bitcoin/0.21 c5357fa Andrew Poelstra: fuzz: add missing ECCVerifyHandle to base_encode_decode
< bitcoin-git> [bitcoin] fanquake pushed 5 commits to 0.21: https://github.com/bitcoin/bitcoin/compare/4c29b63cfba3...bd2f4164c6be

2021-07-07

< bitcoin-git> [bitcoin] jamesob opened pull request #22415: Make m_mempool optional in CChainState (master...2021-07-mempool-ptr) https://github.com/bitcoin/bitcoin/pull/22415
< prayank> Overall goal: Get feedback for my project which is related to testing bitcoin core in a different way from people who are involved in testing core regularly
< prayank> Hi everyone 👋 I wanted to get some feedback on few things related to testing in Bitcoin Core. So, created this form with 5 simple questions. Will be helpful if you could answer them:
<@gribble> https://github.com/bitcoin/bitcoin/issues/21500 | wallet, rpc: add an option to list private descriptors by S3RK · Pull Request #21500 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #22205: doc: Condense README.md (master...master) https://github.com/bitcoin/bitcoin/pull/22205
< bitcoin-git> [bitcoin] fanquake merged pull request #22402: doc: Install Rosetta on M1-macOS for qt in depends (master...210705-rosetta) https://github.com/bitcoin/bitcoin/pull/22402
< bitcoin-git> bitcoin/master 4129134 fanquake: Merge bitcoin/bitcoin#22402: doc: Install Rosetta on M1-macOS for qt in de...