< GIANTWORLDKEEPER>
anyone knows why ban on #bitcoin-core-dev at freenode?
< andytoshi>
MarcoFalke: just want to say thanks for https://github.com/bitcoin/bitcoin/pull/20560 ... i am merging (and build/test/fuzzing) all the 22.0 PRs from bitcoin into elements one-by-one, and the speedup building the fuzztests is *incredible*, i'm getting through PRs 25-30% faster
< bitcoin-git>
[bitcoin] kiminuo opened pull request #22336: [TESTBED][NO-MERGE][POC] Use std::filesystem. Remove Boost Filesystem & System (master...feature/use_std_filesystem_testbed) https://github.com/bitcoin/bitcoin/pull/22336
< bitcoin-git>
[bitcoin] theStack opened pull request #22335: doc: recommend `--disable-external-signer` in OpenBSD build guide (master...202106-doc-openbsd_mention_missing_external_signer_support) https://github.com/bitcoin/bitcoin/pull/22335
< bitcoin-git>
bitcoin/master 699dfcd Andrew Chow: Opportunistically use bech32m change addresses if available
< bitcoin-git>
[bitcoin] laanwj merged pull request #22154: Add OutputType::BECH32M and related wallet support for fetching bech32m addresses (master...outputtype-bech32m) https://github.com/bitcoin/bitcoin/pull/22154
< bitcoin-git>
bitcoin/master 0262536 Andrew Chow: Add OutputType::BECH32M
< bitcoin-git>
bitcoin/master 177c15d Andrew Chow: Limit LegacyScriptPubKeyMan address types
< bitcoin-git>
[bitcoin] S3RK opened pull request #22334: wallet: do not spam about non-existent spk managers (master...stop_non_existing_spkman_spam) https://github.com/bitcoin/bitcoin/pull/22334
< bitcoin-git>
[gui] luke-jr opened pull request #368: Bugfix: GUI: When restoring table columns, still set their minimum column width and stretch on last section (master...bugfix_gui_restored_columns_stretch) https://github.com/bitcoin-core/gui/pull/368
< bitcoin-git>
[bitcoin] theStack opened pull request #22330: test: use MiniWallet for simple doublespend sub-test in feature_rbf.py (master...202106-test-feature_rbf_use_miniwallet_for_doublespend) https://github.com/bitcoin/bitcoin/pull/22330
< vasild>
it will only be a problem if some bitcoin node exists which uses SAM 3.2 and "listens" on port 8333 only (checks TO_PORT and drops the incoming connection if it is not 8333)
< vasild>
* Added support for running Bitcoin Core as an [I2P (Invisible Internet Project)](https://en.wikipedia.org/wiki/I2P) service and connect to such services. See doc/i2p.md for details. (#20685)
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #20966: banman: save the banlist in a JSON format on disk (master...json_bans) https://github.com/bitcoin/bitcoin/pull/20966
< bitcoin-git>
[bitcoin] prayank23 opened pull request #22317: doc: Highlight DNS requests part in tor.md (master...highlight-dns-request) https://github.com/bitcoin/bitcoin/pull/22317
< bitcoin-git>
[bitcoin] prayank23 opened pull request #22316: doc: Add 5 privacy recommendations in tor.md (master...tor-privacy-recommend) https://github.com/bitcoin/bitcoin/pull/22316
2021-06-22
< darosior>
morcos: why does the fee estimator disregard CPFP? You mentioned in https://www.mail-archive.com/bitcoin-development@lists.sourceforge.net/msg06405.html that it would skew estimates, but how so? I don't have statistics but i think CPFP is widely used on the network and might be even more in the future with package relay and it becoming a first
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #22313: test: Add missing sync_all to feature_coinstatsindex (master...2106-testSync) https://github.com/bitcoin/bitcoin/pull/22313
< bitcoin-git>
[bitcoin] siv2r opened pull request #22312: changes for wait_for_getheaders to include hash_list (master...modify-wait-getheaders) https://github.com/bitcoin/bitcoin/pull/22312
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #22311: test: Add missing syncwithvalidationinterfacequeue in p2p_blockfilters (master...2106-testsyncwithvalidationinterfacequeue) https://github.com/bitcoin/bitcoin/pull/22311
< bitcoin-git>
[bitcoin] ariard opened pull request #22310: test: Add functional test for replacement penalty check (master...2021-06-add-rbf5-test) https://github.com/bitcoin/bitcoin/pull/22310
< angela>
Hello! :) I have been reading a lot about bitcoin recently and have been thoroughly moved! I want to start understanding and contributing to bitcoin-core. Can someone recommend good newbie contributor resources? Thanks
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #22296: doc: Final merge of release notes snippets, mv to wiki (master...2106-doRel) https://github.com/bitcoin/bitcoin/pull/22296
< bitcoin-git>
bitcoin/master 398dd67 MarcoFalke: Merge bitcoin/bitcoin#22296: doc: Final merge of release notes snippets, m...
< bitcoin-git>
bitcoin/master fa09fd1 MarcoFalke: doc: Final merge of release notes snippets
< bitcoin-git>
[bitcoin] jonatack opened pull request #22292: bench, doc: benchmarking updates and fixups (master...benchmarking-updates) https://github.com/bitcoin/bitcoin/pull/22292
< bitcoin-git>
[bitcoin] ViralTaco opened pull request #22291: Added comment about narrow contract for Span(T* begin, T* end) ctor (master...master) https://github.com/bitcoin/bitcoin/pull/22291
< bitcoin-git>
[bitcoin] glozow opened pull request #22290: Package Mempool Submission with Package Fee-Bumping (master...package-mempool-accept) https://github.com/bitcoin/bitcoin/pull/22290
< bitcoin-git>
[bitcoin] adriansmares opened pull request #22288: Resolve Tor control plane address (master...feature/tor-control-dns-resolve) https://github.com/bitcoin/bitcoin/pull/22288
< bitcoin-git>
[bitcoin] hebasto reopened pull request #22287: build: Avoid fcntl64@GLIBC_2.28 symbol when --enable-glibc-back-compat (master...210619-fcntl) https://github.com/bitcoin/bitcoin/pull/22287
< bitcoin-git>
[bitcoin] hebasto closed pull request #22287: build: Avoid fcntl64@GLIBC_2.28 symbol when --enable-glibc-back-compat (master...210619-fcntl) https://github.com/bitcoin/bitcoin/pull/22287
< bitcoin-git>
[bitcoin] hebasto opened pull request #22287: build: Avoid fcntl64@GLIBC_2.28 symbol when --enable-glibc-back-compat (master...210619-fcntl) https://github.com/bitcoin/bitcoin/pull/22287
2021-06-19
< kittywhiskers>
i think the idea of having a refactor where all references to bitcoin in filenames are replaced with core and all mentions of Bitcoin in the source lead back to a static variable is worth considering
< kittywhiskers>
similar to the PR that unified all uses of BTC across the codebase, now that with the word Bitcoin itself
< kittywhiskers>
would a PR that tries to unify all instances of the word "Bitcoin" be welcome?
< kittywhiskers>
i did some preliminary work on getting bitcoin core to build using cmake, like how monero does it
< bitcoin-git>
[bitcoin] whitslack opened pull request #22285: contrib/init: (OpenRC) use -startupnotify to wait for startup completion (master...openrc-startupnotify) https://github.com/bitcoin/bitcoin/pull/22285
< bitcoin-git>
[bitcoin] jonatack opened pull request #22284: p2p, refactor: performance improvements to ProtectEvictionCandidatesByRatio() (master...ProtectEvictionCandidatesByRatio-perf-enhancements) https://github.com/bitcoin/bitcoin/pull/22284
< bitcoin-git>
[bitcoin] dgoncharov opened pull request #22283: build: Replace $(AT) with .SILENCE. (master...replace_AT_with_dotsilence) https://github.com/bitcoin/bitcoin/pull/22283
< bitcoin-git>
[bitcoin] klementtan opened pull request #22282: refactor: CheckFinalTx pass by reference instead of ptr (master...CheckFinalTx_ptr_to_ref) https://github.com/bitcoin/bitcoin/pull/22282
< bitcoin-git>
[bitcoin] hebasto opened pull request #22281: build: Avoid @GLIBC_2.29 libm symbols when --enable-glibc-back-compat (master...210619-lm) https://github.com/bitcoin/bitcoin/pull/22281
2021-06-18
<@gribble>
https://github.com/bitcoin/bitcoin/issues/22252 | policy: Trim Packages when transaction with same txid exists in mempool by glozow · Pull Request #22252 · bitcoin/bitcoin · GitHub
<@gribble>
https://github.com/bitcoin/bitcoin/issues/21329 | descriptor wallet: Cache last hardened xpub and use in normalized descriptors by achow101 · Pull Request #21329 · bitcoin/bitcoin · GitHub
<@gribble>
https://github.com/bitcoin/bitcoin/issues/22154 | Add OutputType::BECH32M and related wallet support for fetching bech32m addresses by achow101 · Pull Request #22154 · bitcoin/bitcoin · GitHub
<@gribble>
https://github.com/bitcoin/bitcoin/issues/22154 | Add OutputType::BECH32M and related wallet support for fetching bech32m addresses by achow101 · Pull Request #22154 · bitcoin/bitcoin · GitHub
<@gribble>
https://github.com/bitcoin/bitcoin/issues/21329 | descriptor wallet: Cache last hardened xpub and use in normalized descriptors by achow101 · Pull Request #21329 · bitcoin/bitcoin · GitHub
<@gribble>
https://github.com/bitcoin/bitcoin/issues/22154 | Add OutputType::BECH32M and related wallet support for fetching bech32m addresses by achow101 · Pull Request #22154 · bitcoin/bitcoin · GitHub
<@gribble>
https://github.com/bitcoin/bitcoin/issues/22154 | Add OutputType::BECH32M and related wallet support for fetching bech32m addresses by achow101 · Pull Request #22154 · bitcoin/bitcoin · GitHub
< vasild>
I am not sure either, but it just does not seem right if a user has bothered to setup I2P proxy and configure bitcoin core to use it and to have 0 i2p connections (same for tor)
< vasild>
laanwj: "it's not possible to not bind a P2P port at all" -- https://github.com/bitcoin/bitcoin/pull/20234 is not supposed to change this behavior which is - no, you can't specify "don't bind at all" using -bind=... if -bind is not given then we bind on 0.0.0.0, if -bind=foo is given then we bind on foo
< vasild>
and also I did not want to turn the bitcoin doc i2p.md into "how to install and configure i2p router", which obviously belongs to that i2p router docs
< vasild>
laanwj: "~monthly segfaults" -- I hope you mean i2pd, not bitcoin core
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #22249: test: kill process group to avoid dangling processes when using `--failfast` (master...test_kill_process_group) https://github.com/bitcoin/bitcoin/pull/22249
< bitcoin-git>
bitcoin/master 0844084 MarcoFalke: Merge bitcoin/bitcoin#22249: test: kill process group to avoid dangling pr...
< bitcoin-git>
bitcoin/master 451b96f S3RK: test: kill process group to avoid dangling processes
< bitcoin-git>
[bitcoin] glozow reopened pull request #22253: validation: distinguish between same tx and same-nonwitness-data tx in mempool (master...2021-06-same-txid-diff-wtxid) https://github.com/bitcoin/bitcoin/pull/22253
< bitcoin-git>
[bitcoin] glozow closed pull request #22253: validation: distinguish between same tx and same-nonwitness-data tx in mempool (master...2021-06-same-txid-diff-wtxid) https://github.com/bitcoin/bitcoin/pull/22253
< michaelfolkson>
amiti: My two cents. I don't think you could have done any more to ensure everyone was aware of the PR and I can see why you're frustrated. A Bitcoin Core PR review club, bringing it up in P2P meeting(s), bringing it up in Core dev meeting, mailing list post etc
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #22277: test: Properly set BIP34 height in CreateNewBlock_validity unit test (master...2106-test34) https://github.com/bitcoin/bitcoin/pull/22277
< amiti>
“I wasn't aware of your work before yesterday. I think late concerns are normal annoyance in software development, not specific to Bitcoin Core or decentralized projects (I worked 10 years in Oracle, I know!). It is annoying, but being late does not make the concerns automatically less valid.“ - I’m not suggesting that being late means the concerns are invalid. I am asking how we can pause to reflect on the disconnect.
< bitcoin-git>
[bitcoin] sipa opened pull request #22275: A few follow-ups for taproot signing (master...202106_taproot_sign_followup) https://github.com/bitcoin/bitcoin/pull/22275
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #22274: This will be implemented into bitcoin core at one point, with or without you.. your choice. (master...master) https://github.com/bitcoin/bitcoin/pull/22274
< bitcoin-git>
[bitcoin] steffanjensen opened pull request #22274: This will be implemented into bitcoin core at one point, with or without you.. your choice. (master...master) https://github.com/bitcoin/bitcoin/pull/22274
< schmidty>
ariard: Im happy to help planning. Some light discussions with Advancing Bitcoin about piggybacking there. But dates getting moved.