<glozow>
If somebody could help get in touch with miners it would be really nice to hear what their plans are and/or what a reasonable timeline could be. It's the biggest missing piece of information for me, but I don't think we can speculate whether/when they'll do something because it's rational or because a Bitcoin Core option makes it easy.
<bitcoin-git>
[bitcoin] hebasto opened pull request #26388: ci: Use macos-ventura-xcode:14.1 image for "macOS native" task (master...221025-ventura) https://github.com/bitcoin/bitcoin/pull/26388
<bitcoin-git>
bitcoin/master 393be86 Hennadii Stepanov: build, msvc: Drop no longer required macro definitions for leveldb
2022-10-24
<bitcoin-git>
[bitcoin] sipa opened pull request #26383: Add feature_taproot case involved invalid internal pubkey (master...202210_invalid_internal) https://github.com/bitcoin/bitcoin/pull/26383
<bytes1440000>
Context: Recent default that is being discussed in some PRs in bitcoin core and on mailing list
<bytes1440000>
I am not sure how useful is this poll with 25 votes but I am not a big twitter influencer. It was about "defaults" in bitcoin projects and kind of mixed response: https://twitter.com/1440000bytes/status/1584311735741140992
<bitcoin-git>
[bitcoin] aureleoules reopened pull request #24865: rpc: Enable wallet import on pruned nodes and add test (master...2022-04-importwallet-pruned) https://github.com/bitcoin/bitcoin/pull/24865
<bitcoin-git>
[bitcoin] aureleoules closed pull request #24865: rpc: Enable wallet import on pruned nodes and add test (master...2022-04-importwallet-pruned) https://github.com/bitcoin/bitcoin/pull/24865
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #26380: Revert "test: check importing wallets when blocks are pruned throw an error" (master...2210-test-revert-📒) https://github.com/bitcoin/bitcoin/pull/26380
<bitcoin-git>
[bitcoin] glozow opened pull request #26382: [24.x] p2p: Handle IsContinuationOfLowWorkHeadersSync return value correctly when new headers sync is started (24.x...2022-10-backport-26355) https://github.com/bitcoin/bitcoin/pull/26382
<bitcoin-git>
[bitcoin] glozow merged pull request #26355: p2p: Handle IsContinuationOfLowWorkHeadersSync return value correctly when new headers sync is started (master...2022-10-nbits-headerssync) https://github.com/bitcoin/bitcoin/pull/26355
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #26378: refactor: Pass reference to last header, not pointer (master...2210-p2p-less-pointers-🍟) https://github.com/bitcoin/bitcoin/pull/26378
<bitcoin-git>
[bitcoin] hebasto opened pull request #26377: test: Make `system_tests/run_command` test locale and platform agnostic (master...221024-nonloc) https://github.com/bitcoin/bitcoin/pull/26377
<bitcoin-git>
bitcoin/22.x 2c6c628 Hennadii Stepanov: Prevent data race for `pathHandlers`
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #26350: [22.x] Revert "build: Use Homebrew's sqlite package if it is available" (22.x...revert_slow_macos_sqlite_22_x) https://github.com/bitcoin/bitcoin/pull/26350
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #26333: [23.x] Revert "build: Use Homebrew's sqlite package if it is available" (23.x...revert_slow_macos_sqlite_23_x) https://github.com/bitcoin/bitcoin/pull/26333
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #26376: test: Use type-safe NodeSeconds for TestMemPoolEntryHelper (master...2210-time-🏾) https://github.com/bitcoin/bitcoin/pull/26376
<bitcoin-git>
[bitcoin] MarcoFalke closed pull request #26361: NO MERGE gui test [skip ci] [ci skip] (master...2210-no-merge-gui-test-🏌) https://github.com/bitcoin/bitcoin/pull/26361
<bitcoin-git>
[gui] MarcoFalke merged pull request #673: Use fallback value for Version and User Agent during peer connection (master...2022-09-display-fallback-for-gui-peers-version-and-user-agent) https://github.com/bitcoin-core/gui/pull/673
<bitcoin-git>
bitcoin/master 8fb3fd2 MacroFake: Merge bitcoin-core/gui#673: Use fallback value for Version and User Agent ...
<bitcoin-git>
bitcoin/master c2a21c0 Jon Atack: gui: use fallback value for Version and User Agent during peer connection
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #26358: doc: Rearrange a few lines in the dependency graph of libraries (master...patch-1) https://github.com/bitcoin/bitcoin/pull/26358
<bitcoin-git>
bitcoin/master 1184a66 Stacie Waleyko: doc: Rearrange some lines in the dependency graph of libraries
<bitcoin-git>
bitcoin/master c056735 MacroFake: Merge bitcoin/bitcoin#26358: doc: Rearrange a few lines in the dependency ...
<sipa>
bitcoin core doesn't require the peer to ping ever, at all
<bitcoin-git>
[bitcoin] andrewtoth opened pull request #26375: validation, zmq: pass block in UpdatedBlockTip to avoid duplicate read (master...no-read-zmq) https://github.com/bitcoin/bitcoin/pull/26375
<bitcoin-git>
[bitcoin] fanquake merged pull request #26302: refactor: Use type-safe time point for CWallet::m_next_resend (master...2210-wallet-time-🤗) https://github.com/bitcoin/bitcoin/pull/26302
<ariard>
that type of PR: https://github.com/bitcoin/bitcoin/pull/25434#issuecomment-1288227190 blocked on lot of context across layers, let me think that it could be interesting to have a board/wiki page on "Mempool" subjects and to know if progress is blocked on the mailing list/meeting discussions/conceptual code review/lack of review bandwidth etc
<sipa>
i suspect bitcoin core has always done this, but other implementations may or may not have relied on the assumption that it always is
<bitcoin-git>
[bitcoin] hebasto opened pull request #26372: build, msvc: Drop no longer required macro definitions for leveldb (master...221023-msvc-cleanup) https://github.com/bitcoin/bitcoin/pull/26372
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #26248: net: Set relay in version msg to peers with relay permission in -blocksonly mode (master...2210-version-relay-🥐) https://github.com/bitcoin/bitcoin/pull/26248
<bitcoin-git>
[bitcoin] aureleoules closed pull request #25903: Use static member functions from class instead of instances (master...2022-08-tidy-use-static-functions) https://github.com/bitcoin/bitcoin/pull/25903
<bitcoin-git>
[bitcoin] fanquake opened pull request #26360: build: remove threadinterrupt from libbitcoinkernel (master...kernel_remove_threadinterrupt) https://github.com/bitcoin/bitcoin/pull/26360
<bitcoin-git>
[bitcoin] fanquake merged pull request #25727: util, config: error on startup if `conf` or `reindex` are set in config file (master...josibake-update-config-errors) https://github.com/bitcoin/bitcoin/pull/25727
<bitcoin-git>
bitcoin/master 6bcd7e2 Andrew Chow: wallet: Correctly check ismine for sendall
<bitcoin-git>
bitcoin/master 708b72b Andrew Chow: test: Test that sendall works with watchonly spending specific utxos
<bitcoin-git>
bitcoin/master b132c85 Andrew Chow: wallet: Check utxo prevout index out of bounds in sendall
<bitcoin-git>
[bitcoin] naumenkogs opened pull request #26359: p2p, refactor: #23443 (Erlay support signaling) follow-ups (master...2021-11-erlay1_followup) https://github.com/bitcoin/bitcoin/pull/26359
<bitcoin-git>
[bitcoin] satsie opened pull request #26358: doc: Rearrange a few lines in the dependency graph of libraries (master...patch-1) https://github.com/bitcoin/bitcoin/pull/26358
<NorrinRadd>
ariard i read it. it basically kills zero conf but he also said there's something worse; replacements will be further incentized by changes in exchange rates, where customers will adjust their sats paid lower if bitcoin goes up in price after the purchase was made. which creates business risk for the zero conf merchants.
<glozow>
ariard: my impression is an agreement that it is inevitable, but if it happens before users have a lot of access to LN, it might just make Bitcoin worse
<gribble>
https://github.com/bitcoin/bitcoin/issues/25600 | p2p: Advertise `NODE_FULL_RBF` and connect to 4 outbound full-rbf peers if `-mempoolfullrbf` is set by ariard · Pull Request #25600 · bitcoin/bitcoin · GitHub
<jarolrod>
development on bitcoin-core/gui-qml has been slow, at times it's only been me working on it, but that is where the future of the gui is
<ariard>
achow101: tbh, few contributors have already to live in a multi repo world, in the sense monitoring libsecp256k1, the bips repo, the bolts repo, maybe a lightning implem, maybe bitcoin-inquisition, sounds more a question of personal time-management
<hebasto>
quoting fanquake from oct 15 "I think merging GUI development back into the main repo would quite be a regression. As far as I'm aware, for non-GUI contributors, it's been a great filter for keeping all the not-related-to-bitcoin GUI stuff out of their inboxes (probably similar for the thousands of bitcoin/bitcoin subscribers)."
<achow101>
While I agree that we should want to have components of Bitcoin Core separated into separate repos, I think doing so now is premature. We should perhaps wait until it is possible to fully separate componenets before doing so. That way, cloning the main repo does not fetch the GUI repo, and work on each specific component requires going to each individual repo to even get the code.
<achow101>
contributors as the GUI is in the main repo, so work can be done in a fork of the main repo before realizing that the GUI repo exists. There was also a concern about funding as some funders may not recognize that the GUI repo is in fact part of Bitcoin Core.
<jarolrod>
i don't have a strong opinion on wether we move in the development from bitcoin-core/gui into bitcoin/bitcoin
<bitcoin-git>
[bitcoin] NorrinRadd opened pull request #26356: test: Use a consistent assert functions: ref #23119 (master...issue/23119/part-1) https://github.com/bitcoin/bitcoin/pull/26356
<gribble>
https://github.com/bitcoin/bitcoin/issues/25515 | net, test: Virtualise CConnman and add initial PeerManager unit tests by dergoegge · Pull Request #25515 · bitcoin/bitcoin · GitHub
<bitcoin-git>
[bitcoin] dergoegge opened pull request #26355: p2p: Handle IsContinuationOfLowWorkHeadersSync return value correctly when new headers sync is started (master...2022-10-nbits-headerssync) https://github.com/bitcoin/bitcoin/pull/26355
<dhruv>
i felt like there might be some issue with the Github APIs being used by Cirrus, but then bitcoin/bitcoin builds seems to work fine
<bitcoin-git>
[bitcoin] theStack opened pull request #26352: doc: add `scanblocks` to list of descriptor RPCs (master...202210-doc-add_scanblocks_to_doc_descriptors) https://github.com/bitcoin/bitcoin/pull/26352
<bitcoin-git>
[bitcoin] achow101 merged pull request #26158: bench: add "priority level" to the benchmark framework (master...2022_bench_priority_level) https://github.com/bitcoin/bitcoin/pull/26158
<bitcoin-git>
bitcoin/master 05b8c76 furszy: bench: add "priority level" to the benchmark framework
<bitcoin-git>
bitcoin/master 3da7cd2 furszy: bench: explicitly make all current benchmarks "high" priority
<bitcoin-git>
[bitcoin] Sjors opened pull request #26351: guix: bump time-machine to 39dcbc7fa3c02ff5c9682f25e1c29667dbfe7827 (master...2022/10/guix-bump-timemachine) https://github.com/bitcoin/bitcoin/pull/26351
<bitcoin-git>
[bitcoin] fanquake opened pull request #26350: [22.x] Revert "build: Use Homebrew's sqlite package if it is available" (22.x...revert_slow_macos_sqlite_22_x) https://github.com/bitcoin/bitcoin/pull/26350
<bitcoin-git>
[bitcoin] w0xlt opened pull request #26349: rpc: make `address` field optional `list{transactions, sinceblock}` response (master...issue_26338) https://github.com/bitcoin/bitcoin/pull/26349
<bitcoin-git>
[bitcoin] SergioDemianLerner opened pull request #26348: Make P2SH redeem script "IF .. PUSH x ELSE ... PUSH y ENDIF CHECKMULTISIG .. " standard (master...master) https://github.com/bitcoin/bitcoin/pull/26348
<bitcoin-git>
[bitcoin] ishaanam opened pull request #26347: wallet: ensure the wallet is unlocked when needed for rescanning (master...rescanblockchain_unlock_wallet) https://github.com/bitcoin/bitcoin/pull/26347
<bitcoin-git>
[bitcoin] fanquake merged pull request #25595: Verify PSBT inputs rather than check for fields being empty (master...verify_psbt_input) https://github.com/bitcoin/bitcoin/pull/25595
<bitcoin-git>
bitcoin/master d256992 Greg Sanders: Verify PSBT inputs rather than check for fields being empty
<bitcoin-git>
bitcoin/master e133264 Greg Sanders: Add test for PSBT input verification
<bitcoin-git>
bitcoin/master 2ac71d2 fanquake: Merge bitcoin/bitcoin#25595: Verify PSBT inputs rather than check for fiel...
<bitcoin-git>
[bitcoin] PastaPastaPasta opened pull request #26345: refactor: modernize the implementation of uint256.* (master...refactor/uint256-modernize) https://github.com/bitcoin/bitcoin/pull/26345
<bitcoin-git>
[bitcoin] achow101 opened pull request #26344: wallet: Fix sendall with watchonly wallets and specified inputs (master...fix-sendall-watchonly) https://github.com/bitcoin/bitcoin/pull/26344
<bitcoin-git>
[bitcoin] mzumsande opened pull request #26343: p2p: Don't require services from `ADDR_FETCH` peers (master...202210_addrfetch_servicebits) https://github.com/bitcoin/bitcoin/pull/26343
<bitcoin-git>
bitcoin/master fad7f22 MacroFake: test: Remove unused txmempool include from tests
<bitcoin-git>
bitcoin/master 1c48dae MacroFake: test: Use C++11 member initializers for TestMemPoolEntryHelper
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #26142: Use `PACKAGE_NAME` in messages rather than hardcoding "Bitcoin Core" (master...220920-package) https://github.com/bitcoin/bitcoin/pull/26142
<bitcoin-git>
[bitcoin] fanquake closed pull request #26332: [24.x] Revert "build: Use Homebrew's sqlite package if it is available" (master...revert_slow_macos_sqlite_23_x) https://github.com/bitcoin/bitcoin/pull/26332
<bitcoin-git>
[bitcoin] fanquake opened pull request #26332: [24.x] Revert "build: Use Homebrew's sqlite package if it is available" (master...revert_slow_macos_sqlite_23_x) https://github.com/bitcoin/bitcoin/pull/26332
<bitcoin-git>
[bitcoin] fanquake merged pull request #26327: [24.x] Revert "build: Use Homebrew's sqlite package if it is available" (24.x...revert_slow_macos_sqlite) https://github.com/bitcoin/bitcoin/pull/26327
<bitcoin-git>
[bitcoin] aureleoules opened pull request #26331: Implement `CCoinsViewErrorCatcher::HaveCoin` and check disk space periodically (master...2022-10-disk-space-problems-fix) https://github.com/bitcoin/bitcoin/pull/26331
<bitcoin-git>
[bitcoin] jonatack opened pull request #26328: doc: fix up -netinfo relaytxes help (master...update-netinfo-relaytxes-help) https://github.com/bitcoin/bitcoin/pull/26328
<gribble>
https://github.com/bitcoin/bitcoin/issues/24125 | p2p: Replace RecursiveMutex `cs_tx_inventory` with Mutex and rename it by w0xlt · Pull Request #24125 · bitcoin/bitcoin · GitHub
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #26327: [24.x] Revert "build: Use Homebrew's sqlite package if it is available" (24.x...revert_slow_macos_sqlite) https://github.com/bitcoin/bitcoin/pull/26327
<bitcoin-git>
[bitcoin] andrewtoth opened pull request #26326: net: don't lock cs_main while reading blocks in net processing (master...remove-read-lock-in-net) https://github.com/bitcoin/bitcoin/pull/26326
<bitcoin-git>
[bitcoin] aureleoules opened pull request #26325: rpc: Return accurate results for scanblocks (master...2022-10-improve-scanblocks) https://github.com/bitcoin/bitcoin/pull/26325
<bitcoin-git>
bitcoin/master a52ff61 Andrew Chow: Merge bitcoin/bitcoin#25985: Revert "build: Use Homebrew's sqlite package ...
<bitcoin-git>
[bitcoin] achow101 merged pull request #25985: Revert "build: Use Homebrew's sqlite package if it is available" (master...revert_slow_macos_sqlite) https://github.com/bitcoin/bitcoin/pull/25985
<bitcoin-git>
bitcoin/master d216d71 fanquake: Revert "build: Use Homebrew's sqlite package if it is available"
<bitcoin-git>
[bitcoin] MarcoFalke closed pull request #19531: add static_check_equal for easier to read compiler errors (master...static_check) https://github.com/bitcoin/bitcoin/pull/19531
2022-10-16
<bitcoin-git>
[bitcoin] ajtowns opened pull request #26323: Make full RBF default, but defer mainnet enablement (master...202210-deferfullrbf) https://github.com/bitcoin/bitcoin/pull/26323
<fanquake>
At a higher level, it'd be great if someone working on the GUI could explain what the longer term plan for it is. My understanding was that the current GUI was almost in somewhat of a maintenance mode (no real new features / development etc), because there's more effort being spent on https://github.com/bitcoin-core/gui-qml.
<fanquake>
In regards to review/contributing being more difficult. I think that's just a reflection of the reality that most devs don't want to work on/review the GUI, and I think it'd be suboptimal if we pulled the GUI back in, and that started taking away (in any amount) from the already severely limited review capacity we currently have in bitcoin/bitcoin.
<fanquake>
I think merging GUI development back into the main repo would quite be a regression. As far as I'm aware, for non-GUI contributors, it's been a great filter for keeping all the not-related-to-bitcoin GUI stuff out of their inboxes (probably similar for the thousands of bitcoin/bitcoin subscribers).
<bitcoin-git>
[bitcoin] andrewtoth opened pull request #26316: use shared mutex to guard against block files being removed before read (master...block-read-shared-mutex) https://github.com/bitcoin/bitcoin/pull/26316
2022-10-14
<bitcoin-git>
[bitcoin] brunoerg opened pull request #26314: test: perturb anchors.dat to test error during initialization (master...2022-10-test-perturb-anchors) https://github.com/bitcoin/bitcoin/pull/26314
<bitcoin-git>
[bitcoin] fanquake merged pull request #26297: ci: Use all available CPUs for functional tests in "Win64 native" task (master...221011-job6) https://github.com/bitcoin/bitcoin/pull/26297
<bitcoin-git>
bitcoin/master 6fbd173 Hennadii Stepanov: ci: Use all available CPUs for functional tests in "Win64 native" task
<bitcoin-git>
bitcoin/master 3b85e17 fanquake: Merge bitcoin/bitcoin#26297: ci: Use all available CPUs for functional tes...
<bitcoin-git>
bitcoin/master cbb2da8 glozow: add lock annotation for FeeFilterRounder::round()
<bitcoin-git>
bitcoin/master deeb70a Andrew Chow: Merge bitcoin/bitcoin#26306: add lock annotation for FeeFilterRounder::rou...
<bitcoin-git>
[bitcoin] andrewtoth opened pull request #26308: rest: reduce LOCK(cs_main) scope in rest_block: ~6 times as many requests per second (master...no-lock-for-read-block) https://github.com/bitcoin/bitcoin/pull/26308
<bitcoin-git>
[bitcoin] theStack opened pull request #26307: test: use MiniWallet for rpc_scanblocks.py (master...202210-test-use_MiniWallet_for_scanblocks) https://github.com/bitcoin/bitcoin/pull/26307
<bitcoin-git>
[bitcoin] achow101 merged pull request #24407: fees: make the class FeeFilterRounder thread-safe (master...FeeFilterRounder_thread_safe) https://github.com/bitcoin/bitcoin/pull/24407