< jonasschnelli>
ryanofsky: the reason why I look at that issue is that probably some users have specified --wallet(s) in bitcoin.conf (or CLI parameter) and will eventually run into the load/unload issue
< ryanofsky>
but in general the idea is for the gui to simply reload the same wallets you loaded last time, so you can stop using bitcoin.conf
< ryanofsky>
there maybe be similar cases worth fixing. like if a bitcoin.conf specifies a wallet to load, and you unload it and reload it in the gui, that should not trigger any duplicate wallet error
< jonasschnelli>
I guess the issue if someone creates a wallet with --wallet=mywallet in bitcoin.conf or via cli parameter, unloaded it and loads it again in the GUI (or with load_on_startup), restarts bitcoin with the same parameter will lead to a halt due to a duplicate -wallet parameter?
< bitcoin-git>
[bitcoin] vasild opened pull request #20196: net: fix GetListenPort() to derive the proper port (master...fix_GetListenPort) https://github.com/bitcoin/bitcoin/pull/20196
< bitcoin-git>
[bitcoin] fanquake opened pull request #20195: build: fix mutex detection when building bdb on macOS (master...bdb_xcode12_implicit_function_decleration) https://github.com/bitcoin/bitcoin/pull/20195
< bitcoin-git>
[bitcoin] S3RK opened pull request #20191: wallet, refactor: make DescriptorScriptPubKeyMan agnostic of internal flag (master...remove_m_internal) https://github.com/bitcoin/bitcoin/pull/20191
< bitcoin-git>
[bitcoin] sipa opened pull request #20189: Switch to BIP341's suggested scheme for outputs without script (master...202010_taproot_std_noscript) https://github.com/bitcoin/bitcoin/pull/20189
< bitcoin-git>
[bitcoin] practicalswift closed pull request #20122: Make Assert(…) usable in all contexts. Make implicit assumptions explicit. (master...Assert) https://github.com/bitcoin/bitcoin/pull/20122
< bitcoin-git>
[bitcoin] practicalswift opened pull request #20188: tests: Add fuzzing harness for CConnman (master...fuzzers-connman) https://github.com/bitcoin/bitcoin/pull/20188
< bitcoin-git>
[bitcoin] sdaftuar opened pull request #20187: Addrman: test-before-evict bugfix and improvements for block-relay-only peers (master...2020-10-addrman-block-relay) https://github.com/bitcoin/bitcoin/pull/20187
< bitcoin-git>
[bitcoin] fanquake merged pull request #20082: [bugfix] random: fixes read buffer to use min rather than max (master...perfmon) https://github.com/bitcoin/bitcoin/pull/20082
< bitcoin-git>
bitcoin/master 62af467 fanquake: Merge #20082: [bugfix] random: fixes read buffer to use min rather than ma...
< bitcoin-git>
[bitcoin] practicalswift opened pull request #20169: Taproot follow-up: Make ComputeEntrySchnorr and ComputeEntryECDSA const to clarify contract (master...const-ComputeEntrySchnorr) https://github.com/bitcoin/bitcoin/pull/20169
< bitcoin-git>
bitcoin/master 9e8d2bd MarcoFalke: Merge bitcoin-core/gui#97: Relax GUI freezes during IBD (when using wallet...
< bitcoin-git>
bitcoin/master 0d9d2a1 Jonas Schnelli: Only update the updateSmartFeeLabel once in sync
< bitcoin-git>
[bitcoin] fanquake closed pull request #20164: [test] undo truncation of digits in btc amount (master...rpc-testmempoolaccept-fee) https://github.com/bitcoin/bitcoin/pull/20164
< bitcoin-git>
[bitcoin] laanwj closed pull request #19419: wallet: let Listwalletdir do not iterate through our blocksdata. (master...wallet_351) https://github.com/bitcoin/bitcoin/pull/19419
< bitcoin-git>
[bitcoin] laanwj closed pull request #19635: param: add bool parameter -ephemeraltoronion to generate ephemeral tor addreses (master...ephemeral-tor-onion) https://github.com/bitcoin/bitcoin/pull/19635
< bitcoin-git>
[bitcoin] sipa opened pull request #20165: Only relay Taproot spends if next block has it active (master...202010_taproot_policy) https://github.com/bitcoin/bitcoin/pull/20165
< bitcoin-git>
[bitcoin] fanquake merged pull request #19836: rpc: Properly deserialize txs with witness before signing (master...2008-rpcDeserTxsWitness) https://github.com/bitcoin/bitcoin/pull/19836
< bitcoin-git>
bitcoin/master cbb5f3a fanquake: Merge #19836: rpc: Properly deserialize txs with witness before signing
< jeremyrubin>
the point being that a lot of various regulators want to chat about how Bitcoin works and how they engage, but also understanding how standards emerge
< sipa>
one is relay of v1 transaction outputs; bitcoin core will do that since #15846
< bitcoin-git>
[bitcoin] meshcollider closed pull request #19933: wallet: bugfix; if datadir has a trailing '/' listwalletdir would strip lead char of walletname (master...wallet-fix-missing-chars-boost-1.47) https://github.com/bitcoin/bitcoin/pull/19933
< gribble>
https://github.com/bitcoin/bitcoin/issues/19933 | wallet: bugfix; if datadir has a trailing / listwalletdir would strip lead char of walletname by Saibato · Pull Request #19933 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] laanwj merged pull request #20090: [doc] Tiny followups to new getpeerinfo connection type field (master...2020-09-getpeerinfo-conn-type-release-notes) https://github.com/bitcoin/bitcoin/pull/20090
< bitcoin-git>
bitcoin/master 9ad7cd2 Wladimir J. van der Laan: Merge #20090: [doc] Tiny followups to new getpeerinfo connection type fiel...
< bitcoin-git>
bitcoin/master 41dca08 Amiti Uttarwar: [trivial] Extract connection type doc into file where it is used.
< bitcoin-git>
bitcoin/master 3069b56 Amiti Uttarwar: [doc] Improve help for getpeerinfo connection_type field.
< kallewoof>
andytoshi: it seems to integrate really well with bitcoin core, from what i can tell so far. the old code was a split out thing of its own
< andytoshi>
kallewoof: no, i spent about 30 minutes on it :) the old spec was super straightforward (at least, with the existing rust-bitcoin/miniscript infrastructure i have)
< kallewoof>
andytoshi: hope you didn't spend too much time on your implementation. I have begun working on a rough implementation of BIP 322 support here, FYI: https://github.com/bitcoin/bitcoin/pull/20154
< bitcoin-git>
[bitcoin] S3RK opened pull request #20153: wallet: do not import a descriptor with hardened derivations into a watch-only wallet (master...importdesc_silent_fail) https://github.com/bitcoin/bitcoin/pull/20153
< bitcoin-git>
[bitcoin] laanwj merged pull request #17775: DecodeHexTx: Try case where txn has inputs first (master...decode_wit_first) https://github.com/bitcoin/bitcoin/pull/17775
< bitcoin-git>
bitcoin/master 3956165 Wladimir J. van der Laan: Merge #17775: DecodeHexTx: Try case where txn has inputs first
< bitcoin-git>
bitcoin/master 27fc6a3 Gregory Sanders: DecodeHexTx: Break out transaction decoding logic into own function
< bitcoin-git>
bitcoin/master 6020ce3 Gregory Sanders: DecodeHexTx: Try case where txn has inputs first
< bitcoin-git>
[bitcoin] meshcollider merged pull request #19077: wallet: Add sqlite as an alternative wallet database and use it for new descriptor wallets (master...sqlite-wallet) https://github.com/bitcoin/bitcoin/pull/19077
< bitcoin-git>
bitcoin/master 7577b6e Andrew Chow: Add SQLiteDatabase and SQLiteBatch dummy classes
< bitcoin-git>
bitcoin/master e87df82 Andrew Chow: Add sqlite to travis and depends
< bitcoin-git>
bitcoin/master 54729f3 Andrew Chow: Add libsqlite3
< bitcoin-git>
[bitcoin] sipa opened pull request #20147: Update libsecp256k1 (endomorphism, test improvements) (master...202010_secp256k1) https://github.com/bitcoin/bitcoin/pull/20147
< wumpus>
bitcoin-commits did have secp256k1 notifications as far as I know? but don't know if it's still the case since github removed their own IRC notification
< jnewbery>
hmmm, #19988 is no longer showing up in my notifications stream in github. I can still open the PR and see it in the list of open bitcoin/bitcoin PRs
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #20146: net: Send post-verack handshake messages at most once (master...2010-netPostVerackHandshake) https://github.com/bitcoin/bitcoin/pull/20146
< bitcoin-git>
[bitcoin] kallewoof opened pull request #20145: contrib: add getcoins.py script to get coins from (signet) faucet (master...202010-signet-getcoins) https://github.com/bitcoin/bitcoin/pull/20145
< jonatack>
pierre_rochard: thanks! i'm really happy to see you actively maintaining bitcoin-acks, and the new donation feature for PRs and review seems like a great initiative