2021-10-11

<sipa> anything you want to propose/discuss in the context of bitcoin
<sipa> no, it's specifically not about bitcoin core (which is just an implementation)
<yanmaani> But it's not just patches for Bitcoin Core, right
<sipa> bitcoin development
<yanmaani> What is on-topic for the bitcoin-dev list, exactly?
<sipa> for almost all things relates to Bitcoin Core developmemt, you can think of cryptographic algorithms as black boxes
<sipa> heh, that would be offtopic here; DES isn't used in Bitcoin (and considered way too weak nowadays)
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23255: util: Add mincore and clone3 to syscall sandbox (master...2110-syscall) https://github.com/bitcoin/bitcoin/pull/23255
<meshcollider> I accidentally offended drahtbot https://github.com/bitcoin/bitcoin/pull/16807#issuecomment-939993269
<bitcoin-git> [bitcoin] hieblmi opened pull request #23254: Fix typo and grammar (master...patch-1) https://github.com/bitcoin/bitcoin/pull/23254
<bitcoin-git> [bitcoin] hebasto closed pull request #20544: build: Do not repeat warning names in -Werror=... options (master...201202-werror) https://github.com/bitcoin/bitcoin/pull/20544
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23253: bitcoin-tx: Reject non-integral and out of range sequence ids (master...2110-utilTxSeqId) https://github.com/bitcoin/bitcoin/pull/23253
<jnewbery> gleb7: It's ready for review, but I'm not 100% sure that https://github.com/bitcoin/bitcoin/pull/22910/commits/16cef1ba368302531672ffe81d19bf70e61bd127 doesn't change behaviour in some subtle way. I'd need to do a very careful review of it and possibly add more tests to make sure.
<bitcoin-git> [bitcoin] hebasto closed pull request #23250: test pull request (master...master) https://github.com/bitcoin/bitcoin/pull/23250
<bitcoin-git> [bitcoin] SatoshiBitcoin opened pull request #23250: test pull request (master...master) https://github.com/bitcoin/bitcoin/pull/23250
<bitcoin-git> [bitcoin] dougEfresh opened pull request #23249: util: ParseByteUnits - Parse a string with a suffix unit (master...util-parsebyteunit) https://github.com/bitcoin/bitcoin/pull/23249
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #22794: test: Verify if wallet is compiled in rpc_invalid_address_message.py test (master...split_invalid_address_message_test) https://github.com/bitcoin/bitcoin/pull/22794
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5b7210c8745d...1790a8ddacae
<bitcoin-git> bitcoin/master b142f79 lsilva01: skip test_getaddressinfo() if wallet is disabled
<bitcoin-git> bitcoin/master c2fbdca lsilva01: Add BECH32_INVALID_VERSION test
<bitcoin-git> bitcoin/master 1790a8d MarcoFalke: Merge bitcoin/bitcoin#22794: test: Verify if wallet is compiled in rpc_inv...
<gribble> https://github.com/bitcoin/bitcoin/issues/22910 | [RFC] Encapsulate asmap in NetGroupManager by jnewbery · Pull Request #22910 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] fanquake merged pull request #22409: configure: keep relative paths in debug info (master...debug_keep_relative_path) https://github.com/bitcoin/bitcoin/pull/22409
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/829d3e0e7135...5b7210c8745d
<bitcoin-git> bitcoin/master a8b515c S3RK: configure: keep relative paths in debug info
<bitcoin-git> bitcoin/master 0bc666b S3RK: doc: add info for debugging with relative paths
<bitcoin-git> bitcoin/master 5b7210c fanquake: Merge bitcoin/bitcoin#22409: configure: keep relative paths in debug info
<bitcoin-git> [bitcoin] fanquake merged pull request #23199: refactor: use `{Read,Write}BE32` helpers for BIP32 nChild (de)serialization (master...202110-refactor-use_be32_helpers_for_bip32_nchild) https://github.com/bitcoin/bitcoin/pull/23199
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/01129ca37272...829d3e0e7135
<bitcoin-git> bitcoin/master 7fc487a Sebastian Falbesoner: refactor: use `{Read,Write}BE32` helpers for BIP32 nChild (de)serialization
<bitcoin-git> bitcoin/master 829d3e0 fanquake: Merge bitcoin/bitcoin#23199: refactor: use `{Read,Write}BE32` helpers for ...
<bitcoin-git> [bitcoin] fanquake merged pull request #23214: Replace stoul with ToIntegral in dbwrapper (master...2110-dbwInt) https://github.com/bitcoin/bitcoin/pull/23214
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d1e63aa45469...01129ca37272
<bitcoin-git> bitcoin/master 01129ca fanquake: Merge bitcoin/bitcoin#23214: Replace stoul with ToIntegral in dbwrapper
<bitcoin-git> bitcoin/master fa165e9 MarcoFalke: Replace stoul with ToIntegral in dbwrapper
<bitcoin-git> [bitcoin] fanquake merged pull request #23168: build: no-longer fail default configure if BDB isn't available (master...dont_fail_no_bdb_default_configure) https://github.com/bitcoin/bitcoin/pull/23168
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/15587b4f1d21...d1e63aa45469
<bitcoin-git> bitcoin/master 747cd17 fanquake: build: no-longer fail default configure if BDB isn't available
<bitcoin-git> bitcoin/master d1e63aa fanquake: Merge bitcoin/bitcoin#23168: build: no-longer fail default configure if BD...

2021-10-10

<sipa> davidbak: in any case, questions about setting up a dev env tend to also be welcome in #bitcoin-core-pr-reviews i've noticed
<Davidbak> no, i'm new to bitcoin-core but not to development, but for you: that claim will remain to be seen until I produce
<hebasto> davidbak: #bitcoin-core-pr-reviews
<sipa> davidbak: you're probably better off asking people who more recently started participating; both luke-jr and i have been around for a while, like jonatack's guide (https://jonatack.github.io/articles/how-to-contribute-pull-requests-to-bitcoin-core) and amiti's (https://medium.com/@amitiu/onboarding-to-bitcoin-core-7c1a83b20365)
<Davidbak> ok. luke-jr - is "good first issues" still considered a good way to onboard to bitcoin-core development? And with or without the "PR Club" for getting tips?
<Davidbak> anyway, that was created 2020-04-29, and apparently two people worked on PRs - https://github.com/bitcoin/bitcoin/pull/19117 and https://github.com/bitcoin/bitcoin/pull/18827 - rather quickly after that (also April/May 2020) - both of which went nowhere.
<gribble> https://github.com/bitcoin/bitcoin/issues/18222 | Add `blockfilterindex = p2wpkh` · Issue #18222 · bitcoin/bitcoin · GitHub
<Davidbak> I'm looking around after reading the "how to get involved" information - which points to "good first issue" issues. And one of the first ones there is #18222 - https://github.com/bitcoin/bitcoin/issues/18822
<gribble> https://github.com/bitcoin/bitcoin/issues/20664 | Add scanblocks RPC call by jonasschnelli · Pull Request #20664 · bitcoin/bitcoin · GitHub
<stick> I see there is CJDNS being added to bitcoin-core

2021-10-09

<bitcoin-git> [gui] promag closed pull request #450: Prefix makefile variables with QT_ (master...2021-10-qt-makefile) https://github.com/bitcoin-core/gui/pull/450
<bitcoin-git> [bitcoin] promag opened pull request #23242: qt: Prefix makefile variables with QT_ (master...2021-10-qt-makefile) https://github.com/bitcoin/bitcoin/pull/23242
<bitcoin-git> [gui] promag opened pull request #450: Prefix makefile variables with QT_ (master...2021-10-qt-makefile) https://github.com/bitcoin-core/gui/pull/450
<bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/927586990eb9...15587b4f1d21
<bitcoin-git> bitcoin/master d54ec27 João Barbosa: qt: Add helper to load font
<bitcoin-git> bitcoin/master 15587b4 Hennadii Stepanov: Merge bitcoin-core/gui#448: Add helper to load font
<bitcoin-git> [gui] hebasto merged pull request #448: Add helper to load font (master...2021-10-font-helper) https://github.com/bitcoin-core/gui/pull/448
<Kiminuo> prayank: I'm quite happy with the PR as is. Jeremy proposed https://github.com/bitcoin/bitcoin/pull/21422#issuecomment-819566377 but I'm not entirely sure if it is necessary to change it that way.
<gribble> https://github.com/bitcoin/bitcoin/issues/21422 | Add feerate histogram to getmempoolinfo by kiminuo · Pull Request #21422 · bitcoin/bitcoin · GitHub
<Kiminuo> Ha, merged master with https://github.com/bitcoin/bitcoin/pull/22937 and it works
<prayank> I have tried writing few PowerShell scripts for Bitcoin Core but never used utf 8 in them
<Kiminuo> Anyway, I'm recompiling the PR again and trying to find out why https://github.com/bitcoin/bitcoin/pull/22937 fails for me and it works for you
<bitcoin-git> [bitcoin] ajtowns opened pull request #23235: Reduce unnecessary default logging (master...202110-acceptblockheader-silence) https://github.com/bitcoin/bitcoin/pull/23235

2021-10-08

<gribble> https://github.com/bitcoin/bitcoin/issues/23201 | wallet: Allow users to specify input weights when funding a transaction by achow101 · Pull Request #23201 · bitcoin/bitcoin · GitHub
<achow101> #bitcoin-core-dev Wallet Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik petertodd
<Sp79> Hello. Can someone help me with some info? I want to know how was bitcoin.pdf whitepaper was embedded in the bitcoin blockchain
<gribble> https://github.com/bitcoin/bitcoin/issues/23202 | wallet: allow psbtbumpfee to work with txs with external inputs by achow101 · Pull Request #23202 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/23201 | wallet: Allow users to specify input weights when funding a transaction by achow101 · Pull Request #23201 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23227: bitcoin-tx: Avoid treating overflow as OP_0 (master...2110-ToIntegral) https://github.com/bitcoin/bitcoin/pull/23227
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #23216: clang-format: Set BraceWrapping:AfterControlStatement:MultiLine (master...2110-srcFormat) https://github.com/bitcoin/bitcoin/pull/23216
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23185: test: Add ParseMoney and ParseScript tests (master...2110-ToIntegral) https://github.com/bitcoin/bitcoin/pull/23185
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/97e2435ac43f...927586990eb9
<bitcoin-git> bitcoin/master fa1477e MarcoFalke: test: Add ParseMoney and ParseScript tests
<bitcoin-git> bitcoin/master 9275869 MarcoFalke: Merge bitcoin/bitcoin#23185: test: Add ParseMoney and ParseScript tests
<bitcoin-git> [bitcoin] dougEfresh closed pull request #23224: [RFC] util: Add suffix byte unit parser for ArgsManager (master...add-args-byte-units) https://github.com/bitcoin/bitcoin/pull/23224
<meshcollider> Guest8477: for most help, #bitcoin would be a better channel to ask in
<gribble> https://github.com/bitcoin/bitcoin/issues/23056 | configure script failure · Issue #23056 · bitcoin/bitcoin · GitHub
<fanquake> The only users who get blocked from bitcoin/bitcoin are the ones posting outright nonsense / spam.
<bitcoin-git> [bitcoin] fanquake merged pull request #23053: [fuzz] Use public methods in addrman fuzz tests (master...2021-09-addrman-fuzzer-public-methods2) https://github.com/bitcoin/bitcoin/pull/23053
<bitcoin-git> bitcoin/master 56303e3 John Newbery: [fuzz] Create a FastRandomContext in addrman fuzz tests
<bitcoin-git> bitcoin/master 491975c John Newbery: [fuzz] Pass FuzzedDataProvider& into Fill() in addrman fuzz tests
<bitcoin-git> [bitcoin] fanquake pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/99e53967c85c...97e2435ac43f
<bitcoin-git> bitcoin/master 90ad8ad John Newbery: [fuzz] Make RandAddr() a free function in fuzz/addrman.cpp
<bitcoin-git> [bitcoin] fanquake merged pull request #23188: wallet: fund transaction external input cleanups (master...fundtx-external-inputs_cleanups) https://github.com/bitcoin/bitcoin/pull/23188
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/991753e4d50e...99e53967c85c
<bitcoin-git> bitcoin/master 4356878 Gregory Sanders: External input fund support cleanups
<bitcoin-git> bitcoin/master 99e5396 fanquake: Merge bitcoin/bitcoin#23188: wallet: fund transaction external input clean...
<bitcoin-git> [bitcoin] theuni opened pull request #23226: c++20: Opt-in to modeling view and borrowed_range for Span (master...borrowed-span) https://github.com/bitcoin/bitcoin/pull/23226

2021-10-07

<jeremyrubin> counterpoint, not getting segwit would have been pretty bad for bitcoin overall, no? should we let 'bullies' who don't want bitcoin to progress to roadblock the rest of the network? if we can't get an important upgrade in the face of bad actors, that sounds bad for bitcoin...
<jeremyrubin> many changes to bitcoin core affect the consensus code
<jeremyrubin> i think that leads to the way that we do soft forks for bitcoin being no more unsafe than other changes we make
<jeremyrubin> tbh soft forks aren't particularly more or less dangerous than other changes we make to bitcoin
<michaelfolkson> lightlike: I'm not sure whether the only way you get peer review is by marking it as "high priority for review" and a "blocker" on Bitcoin Core
<bitcoin-git> [bitcoin] katesalazar opened pull request #23225: Reject float at satoshi_round (master...20211006) https://github.com/bitcoin/bitcoin/pull/23225
<gribble> https://github.com/bitcoin/bitcoin/issues/23174 | validation: have LoadBlockIndex account for snapshot use by jamesob · Pull Request #23174 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] dougEfresh opened pull request #23224: [RFC] util: Add suffix byte unit parser for ArgsManager (master...add-args-byte-units) https://github.com/bitcoin/bitcoin/pull/23224
<gribble> https://github.com/bitcoin/bitcoin/issues/21702 | Implement BIP-119 Validation (CheckTemplateVerify) by JeremyRubin · Pull Request #21702 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/21943 | Dedup and RAII-fy the creation of a copy of CConnman::vNodes by vasild · Pull Request #21943 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/22702 | Add allocator for node based containers by martinus · Pull Request #22702 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/21702 | Implement BIP-119 Validation (CheckTemplateVerify) by JeremyRubin · Pull Request #21702 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/22950 | [p2p] Pimpl AddrMan to abstract implementation details by amitiuttarwar · Pull Request #22950 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/22539 | Re-include RBF replacement txs in fee estimation by darosior · Pull Request #22539 · bitcoin/bitcoin · GitHub
<laanwj> https://github.com/bitcoin/bitcoin/projects/8 9 blockers, 2 chasing concept ACK
<laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos
<bitcoin-git> [bitcoin] jonatack opened pull request #23223: Add NoLockLoggingTestingSetup to test utilities, use in checkqueue_tests (master...alleviate-checkqueue-tests-contention-logging) https://github.com/bitcoin/bitcoin/pull/23223
<bitcoin-git> [bitcoin] laanwj merged pull request #23118: test: refactor: introduce `script_util` helper for creating P2PK scripts (master...202109-test-add_helper_for_creating_p2pk_scripts) https://github.com/bitcoin/bitcoin/pull/23118
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6334ff7364e2...991753e4d50e
<bitcoin-git> bitcoin/master 429b493 Sebastian Falbesoner: test: introduce script_util helper for creating P2PK scripts
<bitcoin-git> bitcoin/master 991753e W. J. van der Laan: Merge bitcoin/bitcoin#23118: test: refactor: introduce `script_util` helpe...
<bitcoin-git> [bitcoin] hebasto opened pull request #23220: ci: Reduce Windows memory for faster scheduling (master...211007-mem1) https://github.com/bitcoin/bitcoin/pull/23220
<bitcoin-git> [bitcoin] jonatack opened pull request #23219: p2p: remove unneeded CNetAddr vector in LookupSubNet() and update/tidy up (master...LookupSubNet-todo-fix) https://github.com/bitcoin/bitcoin/pull/23219
<bitcoin-git> [bitcoin] laanwj merged pull request #23196: util: Make syscall sandbox compilable with kernel 4.4.0 (master...2021-10-syscall-sandbox2) https://github.com/bitcoin/bitcoin/pull/23196
<bitcoin-git> bitcoin/master 6334ff7 W. J. van der Laan: Merge bitcoin/bitcoin#23196: util: Make syscall sandbox compilable with ke...
<bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/6f0cbc75be76...6334ff7364e2
<bitcoin-git> bitcoin/master ac402e7 W. J. van der Laan: util: Conditionalize some syscalls in syscall name table
<bitcoin-git> bitcoin/master 64085b3 W. J. van der Laan: util: Add __NR_copy_file_range syscall constant for sandbox
<bitcoin-git> [bitcoin] laanwj merged pull request #22539: Re-include RBF replacement txs in fee estimation (master...fee_est_rbf) https://github.com/bitcoin/bitcoin/pull/22539
<bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/c0b6c96eee7c...6f0cbc75be76
<bitcoin-git> bitcoin/master 06c5ce9 Antoine Poinsot: Re-include RBF replacement txs in fee estimation
<bitcoin-git> bitcoin/master 053415b Antoine Poinsot: qa: split run_test into smaller parts
<bitcoin-git> bitcoin/master 4556406 Antoine Poinsot: qa: test fee estimation with replacement transactions
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23218: p2p: Use mocktime for ping timeout (master...2110-mockPingTime) https://github.com/bitcoin/bitcoin/pull/23218
<bitcoin-git> [bitcoin] hebasto opened pull request #23217: [DO NOT MERGE] ci: Test required resources for native Windows tasks (master...211007-mem) https://github.com/bitcoin/bitcoin/pull/23217
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23216: clang-format: Set BraceWrapping:AfterControlStatement:MultiLine (master...2110-srcFormat) https://github.com/bitcoin/bitcoin/pull/23216
<bitcoin-git> [bitcoin] hebasto opened pull request #23215: ci: Add vcpkg downloads cache (master...211007-ci) https://github.com/bitcoin/bitcoin/pull/23215
<gribble> https://github.com/bitcoin/bitcoin/issues/22539 | Re-include RBF replacement txs in fee estimation by darosior · Pull Request #22539 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23214: Replace stoul with ToIntegral in dbwrapper (master...2110-dbwInt) https://github.com/bitcoin/bitcoin/pull/23214
<bitcoin-git> [gui] promag opened pull request #448: qt: Add helper to load font (master...2021-10-font-helper) https://github.com/bitcoin-core/gui/pull/448
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23146: Test transactions conflicted by double spend in listtransactions (master...test-txns-conflicted-by-double-spend-in-listtransactions) https://github.com/bitcoin/bitcoin/pull/23146
<bitcoin-git> bitcoin/master 502f50d Jon Atack: Test transactions conflicted by double spend in listtransactions
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b4437d7dfe23...c0b6c96eee7c
<bitcoin-git> bitcoin/master c0b6c96 MarcoFalke: Merge bitcoin/bitcoin#23146: Test transactions conflicted by double spend ...
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23210: test: Replace satoshi_round with int() or Decimal() (master...2110-testRound) https://github.com/bitcoin/bitcoin/pull/23210
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f8911de619d4...b4437d7dfe23
<bitcoin-git> bitcoin/master fa2ac58 MarcoFalke: test: Replace satoshi_round with int() or Decimal()
<bitcoin-git> bitcoin/master b4437d7 MarcoFalke: Merge bitcoin/bitcoin#23210: test: Replace satoshi_round with int() or Dec...
<bitcoin-git> [bitcoin] fanquake closed pull request #22844: feature: enable mypy to run without --ignore-imports (master...josibake-fix-mypy-import-errors) https://github.com/bitcoin/bitcoin/pull/22844
<bitcoin-git> [bitcoin] fanquake opened pull request #23212: lint: enable mypy import checking (master...22844_fixedup) https://github.com/bitcoin/bitcoin/pull/23212
<bitcoin-git> [bitcoin] fanquake merged pull request #23172: doc: Extract FundTxDoc in rpcwallet (master...2110-docRpcWallet) https://github.com/bitcoin/bitcoin/pull/23172
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0500a22d8c78...f8911de619d4
<bitcoin-git> bitcoin/master fafff13 MarcoFalke: doc: Extract FundTxDoc
<bitcoin-git> bitcoin/master f8911de fanquake: Merge bitcoin/bitcoin#23172: doc: Extract FundTxDoc in rpcwallet
<bitcoin-git> [bitcoin] fanquake merged pull request #23208: util: Add mremap syscall to AllowAddressSpaceAccess (master...2110-syscall) https://github.com/bitcoin/bitcoin/pull/23208
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a68de12c0ebf...0500a22d8c78
<bitcoin-git> bitcoin/master 0500a22 fanquake: Merge bitcoin/bitcoin#23208: util: Add mremap syscall to AllowAddressSpace...
<bitcoin-git> bitcoin/master fab360a MarcoFalke: util: Add mremap syscall to AllowAddressSpaceAccess
<bitcoin-git> [bitcoin] theStack opened pull request #23211: refactor: move `update_*` structs from txmempool.h to .cpp file (master...202110-refactor-various_mempool_cleanups) https://github.com/bitcoin/bitcoin/pull/23211
<gribble> https://github.com/bitcoin/bitcoin/issues/23168 | build: no-longer fail default configure if BDB isnt available by fanquake · Pull Request #23168 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] fanquake merged pull request #22890: doc: Replace a link to Qt precompiled binaries with compile instructions (master...210904-msvc) https://github.com/bitcoin/bitcoin/pull/22890
<bitcoin-git> bitcoin/master c4139f0 Hennadii Stepanov: doc: Replace a link to Qt precompiled binaries with compile instructions
<bitcoin-git> bitcoin/master 5e42f2a Hennadii Stepanov: build: Make <QtBaseDir> default name Qt and VS versions agnostic
<bitcoin-git> bitcoin/master 6bc4398 Hennadii Stepanov: doc: Suggest using jom instead of nmake
<bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/577b0ffd2ea4...a68de12c0ebf

2021-10-06

<andytoshi> should there be a LOCK(pwallet->cs_wallet) before this line in MaybeCompactWalletDB? https://github.com/bitcoin/bitcoin/blob/master/src/wallet/walletdb.cpp#L1048
<gene> practicalswift: are you around? wondering if you used mull on bitcoin (for mutation testing)?
<bitcoin-git> [gui] hebasto merged pull request #409: Fix window title of wallet loading window (master...wallet-window-title) https://github.com/bitcoin-core/gui/pull/409
<bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7962c97a2e5a...577b0ffd2ea4
<bitcoin-git> bitcoin/master 577b0ff Hennadii Stepanov: Merge bitcoin-core/gui#409: Fix window title of wallet loading window
<bitcoin-git> bitcoin/master 01bff8f Shashwat: qt: Fix WalletControllerActivity progress dialog title
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bb8550b7887d...7962c97a2e5a
<bitcoin-git> bitcoin/master faa5e17 MarcoFalke: RPCConsole: Throw when overflowing size_t type for array indices
<bitcoin-git> bitcoin/master 7962c97 MarcoFalke: Merge bitcoin-core/gui#446: RPCConsole: Throw when overflowing size_t type...
<bitcoin-git> [gui] MarcoFalke merged pull request #446: RPCConsole: Throw when overflowing size_t type for array indices (master...2110-qtRpcCons) https://github.com/bitcoin-core/gui/pull/446
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23209: test: Avoid RPC roundtrip in MiniWallet get_descriptor() (master...2110-testMini) https://github.com/bitcoin/bitcoin/pull/23209
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/66d11b14357c...bb8550b7887d
<bitcoin-git> bitcoin/master bb8550b MarcoFalke: Merge bitcoin/bitcoin#23209: test: Avoid RPC roundtrip in MiniWallet get_d...
<bitcoin-git> bitcoin/master fa3ab7b MarcoFalke: test: Avoid RPC roundtrip in MiniWallet get_descriptor()
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23210: test: Replace satoshi_round with int() or Decimal() (master...2110-testRound) https://github.com/bitcoin/bitcoin/pull/23210
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23209: test: Avoid RPC roundtrip in MiniWallet get_descriptor() (master...2110-testMini) https://github.com/bitcoin/bitcoin/pull/23209
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23208: util: Add mremap syscall to AllowAddressSpaceAccess (master...2110-syscall) https://github.com/bitcoin/bitcoin/pull/23208
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23207: test: Delete generate* calls from TestNode (master...2110-testDelGen) https://github.com/bitcoin/bitcoin/pull/23207
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23200: Fix intermittent failure in wallet_send.py and rpc_fundrawtransaction.py (master...202110_fix_external_tests) https://github.com/bitcoin/bitcoin/pull/23200
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/113b863f0773...66d11b14357c
<bitcoin-git> bitcoin/master eb02dbb Samuel Dobson: Use self.generate not node.generate throughout tests
<bitcoin-git> bitcoin/master 75a9305 Samuel Dobson: Fix intermittent test failures due to missing sync_all
<bitcoin-git> bitcoin/master 66d11b1 MarcoFalke: Merge bitcoin/bitcoin#23200: Fix intermittent failure in wallet_send.py an...
<bitcoin-git> [bitcoin] fanquake closed pull request #22758: bitcoin/bitcoin:alpine-static on hub.docker.com (master...master) https://github.com/bitcoin/bitcoin/pull/22758
<bitcoin-git> [bitcoin] fanquake opened pull request #23203: [POC] build: static musl libc based bitcoind (with LTO) (master...depends_musl_cross_make) https://github.com/bitcoin/bitcoin/pull/23203
<bitcoin-git> [bitcoin] achow101 opened pull request #23202: wallet: allow psbtbumpfee to work with txs with external inputs (master...bumpfee-ext-inputs) https://github.com/bitcoin/bitcoin/pull/23202
<bitcoin-git> [bitcoin] fanquake closed pull request #23195: doc: fixes #23073 Updated the Release Process (master...update_release_process) https://github.com/bitcoin/bitcoin/pull/23195

2021-10-05

<bitcoin-git> [bitcoin] achow101 opened pull request #23201: wallet: Allow users to specify input weights when funding a transaction (master...ext-input-weight) https://github.com/bitcoin/bitcoin/pull/23201
<bitcoin-git> [bitcoin] meshcollider opened pull request #23200: Fix intermittent failure in wallet_send.py and rpc_fundrawtransaction.py (master...202110_fix_external_tests) https://github.com/bitcoin/bitcoin/pull/23200
<bitcoin-git> [bitcoin] theStack opened pull request #23199: refactor: use `{Read,Write}BE32` helpers for BIP32 nChild (de)serialization (master...202110-refactor-use_be32_helpers_for_bip32_nchild) https://github.com/bitcoin/bitcoin/pull/23199
<bitcoin-git> [gui] stratospher opened pull request #447: Never disable HD status icon (master...enable-watch-only-icon) https://github.com/bitcoin-core/gui/pull/447
<bitcoin-git> [bitcoin] CallMeMisterOwl opened pull request #23198: build: fixes #23073 Parse version information in msvc-autogen.py (master...auto_gen_issue) https://github.com/bitcoin/bitcoin/pull/23198
<bitcoin-git> [bitcoin] CallMeMisterOwl closed pull request #23194: build: Parse version information in msvc-autogen.py (master...auto_gen_MSVC_issue) https://github.com/bitcoin/bitcoin/pull/23194
<bitcoin-git> [bitcoin] jonatack opened pull request #23197: p2p: fix CSubNet::ToString() UBSan and banman fuzz crash (master...fix-netaddress-UB-and-banman-fuzz-crash) https://github.com/bitcoin/bitcoin/pull/23197
<bitcoin-git> [bitcoin] laanwj opened pull request #23196: util: Make syscall sandbox compilable with kernel 4.4.0 (master...2021-10-syscall-sandbox2) https://github.com/bitcoin/bitcoin/pull/23196
<gribble> https://github.com/bitcoin/bitcoin/issues/143 | Fix deadlocks in getaccountaddress, setaccount, sendfrom RPC calls by jgarzik · Pull Request #143 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] CallMeMisterOwl opened pull request #23195: doc: fixes #23073 Updated the Release Process (master...update_release_process) https://github.com/bitcoin/bitcoin/pull/23195
<bitcoin-git> [bitcoin] CallMeMisterOwl opened pull request #23194: script: fixes #23073 Added new function to build_msvc/msvc-autogen.py (master...auto_gen_MSVC_issue) https://github.com/bitcoin/bitcoin/pull/23194
<amiti> cfields: speedy indeed, but I think jnewbery has him beat https://github.com/bitcoin/bitcoin/pull/23053#issuecomment-933517415, he rebased yesterday!
<gribble> https://github.com/bitcoin/bitcoin/issues/23053 | [fuzz] Use public methods in addrman fuzz tests by jnewbery · Pull Request #23053 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/23140 | Make CAddrman::Select_ select buckets, not positions, first by sipa · Pull Request #23140 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] laanwj merged pull request #23162: contrib: Ask for captcha in signet getcoins.py (master...2021-10-getcoins) https://github.com/bitcoin/bitcoin/pull/23162
<bitcoin-git> bitcoin/master a6d9675 W. J. van der Laan: contrib: Ask for captcha in signet getcoins.py
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/89b910711c00...113b863f0773
<bitcoin-git> bitcoin/master 113b863 W. J. van der Laan: Merge bitcoin/bitcoin#23162: contrib: Ask for captcha in signet getcoins.p...
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #23183: C++20 designated initializer test WIP DONOTMERGE!!!11 @@ (master...2110-test) https://github.com/bitcoin/bitcoin/pull/23183
<bitcoin-git> [bitcoin] laanwj merged pull request #23178: util: Fix GUIX build with syscall sandbox (master...2021-10-guix-linux-sandbox) https://github.com/bitcoin/bitcoin/pull/23178
<bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c4fc8994427c...89b910711c00
<bitcoin-git> bitcoin/master 8289d19 W. J. van der Laan: util: Define SECCOMP_RET_KILL_PROCESS if not provided by the headers
<bitcoin-git> bitcoin/master 2d02799 W. J. van der Laan: util: Make sure syscall numbers used in profile are defined
<bitcoin-git> bitcoin/master 89b9107 W. J. van der Laan: Merge bitcoin/bitcoin#23178: util: Fix GUIX build with syscall sandbox
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #22950: [p2p] Pimpl AddrMan to abstract implementation details (master...2021-09-impl-addrman-pimpl) https://github.com/bitcoin/bitcoin/pull/22950
<bitcoin-git> [bitcoin] MarcoFalke pushed 14 commits to master: https://github.com/bitcoin/bitcoin/compare/c79d9fb2f6e5...c4fc8994427c
<bitcoin-git> bitcoin/master 5faa7dd Amiti Uttarwar: [move-only] Move CAddrMan function definitions to cpp
<bitcoin-git> bitcoin/master f2e5f38 Amiti Uttarwar: [move-only] Match ordering of CAddrMan declarations and definitions
<bitcoin-git> bitcoin/master 8af5b54 Amiti Uttarwar: [addrman] Introduce CAddrMan::Impl to encapsulate addrman implementation.
<gribble> https://github.com/bitcoin/bitcoin/issues/19461 | multiprocess: Add bitcoin-gui -ipcconnect option by ryanofsky · Pull Request #19461 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23191: build: Disable -Wbraced-scalar-init, which is incompatible with -Wc++11-narrowing (master...2110-buildW) https://github.com/bitcoin/bitcoin/pull/23191
<bitcoin-git> [gui] MarcoFalke opened pull request #446: RPCConsole: Throw when overflowing size_t type for array indices (master...2110-qtRpcCons) https://github.com/bitcoin-core/gui/pull/446
<bitcoin-git> [bitcoin] instagibbs opened pull request #23188: wallet: fund transaction external input cleanups (master...fundtx-external-inputs_cleanups) https://github.com/bitcoin/bitcoin/pull/23188
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23185: test: Add ParseMoney and ParseScript tests (master...2110-ToIntegral) https://github.com/bitcoin/bitcoin/pull/23185
<bitcoin-git> [bitcoin] brunoerg closed pull request #23135: test: Use asset_equal utils where possible in feature_nulldummy (master...2021-09-assert_equal) https://github.com/bitcoin/bitcoin/pull/23135
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #23184: Use stricter ToIntegral over LocaleIndependentAtoi where possible (master...2110-ToIntegral) https://github.com/bitcoin/bitcoin/pull/23184
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23184: Use stricter ToIntegral over LocaleIndependentAtoi where possible (master...2110-ToIntegral) https://github.com/bitcoin/bitcoin/pull/23184
<jonatack> right, running this gives an overview: ./src/bitcoin-cli -addrinfo
<jonatack> note, getnodeaddresses takes a network argument, so can also: ./src/bitcoin-cli getnodeaddresses 0 ipv4 | jq 'map(select(.address | contains(":")))'
<vasild> Am I the only one? I ran: bitcoin-cli getnodeaddresses 0 |jq 'map(select(.network == "ipv4" and (.address |contains(":"))))'
<prayank> michaelfolkson: Do you really think I commented anything in this PR that does not make sense? I was not aware of all this else would have completely avoided and let others decide. I won't be reviewing any PR in future for this author in any repository. Also started contributing in Knots so it might help me do better things with less people and peace: https://github.com/bitcoinknots/bitcoin/discussions/39
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23179: sandbox: add `newfstatat` & `copy_file_range` to allowed filesystem syscalls (master...add_newfstatat_to_syscall_exceptions) https://github.com/bitcoin/bitcoin/pull/23179
<bitcoin-git> bitcoin/master 44d77d2 fanquake: sandbox: add copy_file_range to allowed filesystem syscalls
<bitcoin-git> bitcoin/master ee08741 fanquake: sandbox: add newfstatat to allowed filesystem syscalls
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/371f0aeeb4b1...c79d9fb2f6e5
<bitcoin-git> bitcoin/master c79d9fb MarcoFalke: Merge bitcoin/bitcoin#23179: sandbox: add `newfstatat` & `copy_file_range`...
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23182: build: add python3.10 alias to AC_PATH_PROGS call in configure (master...python_3_10_configure) https://github.com/bitcoin/bitcoin/pull/23182
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/816e15ee81a2...371f0aeeb4b1
<bitcoin-git> bitcoin/master ef15c57 fanquake: build: add python3.10 alias to AC_PATH_PROGS call in configure
<bitcoin-git> bitcoin/master 371f0ae MarcoFalke: Merge bitcoin/bitcoin#23182: build: add python3.10 alias to AC_PATH_PROGS ...
<gribble> https://github.com/bitcoin/bitcoin/issues/17211 | Allow fundrawtransaction and walletcreatefundedpsbt to take external inputs by achow101 · Pull Request #17211 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/23121 | [policy] check ancestor feerate in RBF, remove BIP125 Rule2 by glozow · Pull Request #23121 · bitcoin/bitcoin · GitHub
<glozow> prayank: I blocked you on my personal github account. It has nothing to do with the repo or maintainers. The help text for blocking a user says "Prevent this user from interacting with your repositories and sending you notifications." I didn't realize it would stop you from commenting on my PR in the Bitcoin Core repo. My apologies to everybody for the confusion.
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23183: C++20 test WIP DONOTMERGE!!!11 @@ (master...2110-test) https://github.com/bitcoin/bitcoin/pull/23183
<meshcollider> prayank: indeed, it can only be a github bug, it is absolutely not censorship. I have copied your questions onto the PR for you: https://github.com/bitcoin/bitcoin/pull/23121#issuecomment-934154169
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #22951: consensus: move amount.h into consensus (master...move_amount_h_consensus) https://github.com/bitcoin/bitcoin/pull/22951
<bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/9e530c6352c3...816e15ee81a2
<bitcoin-git> bitcoin/master d09071d fanquake: [MOVEONLY] consensus: move amount.h into consensus
<bitcoin-git> bitcoin/master 863e52f fanquake: consensus: make COIN & MAX_MONEY constexpr
<bitcoin-git> bitcoin/master 9d0379c fanquake: consensus: use <cstdint> over <stdint.h> in amount.h
<vasild> prayank: on github (that is not specific to bitcoin) it is possible to lock one PR for everybody (in which case "Conversation was locked..." is displayed). Or it is possible to ban one person from all PRs in a repository. But it is not possible to ban one person from one PR.
<prayank> Two questions for PR author: 1. Unconfirmed UTXO are discouraged in Core. Does this PR change default behaviour? Context: https://github.com/bitcoin-core/gui/issues/242 2. Why do you think it's not a bug if attacker can confirm a tx with less fee rate by replacing? It can be exploited if we had on chain DeFi but I am not sure what all projects are currently impacted
<vasild> this is how I found peers to connect to: https://www.erisian.com.au/bitcoin-core-dev/log-2021-10-04.html#l-469
<gribble> https://github.com/bitcoin/bitcoin/issues/23121 | [policy] check ancestor feerate in RBF, remove BIP125 Rule2 by glozow · Pull Request #23121 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] fanquake opened pull request #23182: build: add python3.10 alias to AC_PATH_PROGS call in configure (master...python_3_10_configure) https://github.com/bitcoin/bitcoin/pull/23182
<bitcoin-git> [bitcoin] PastaPastaPasta opened pull request #23181: refactor: remove references to deprecated values under std::allocator (master...btc-allocator) https://github.com/bitcoin/bitcoin/pull/23181
<bitcoin-git> [bitcoin] fanquake opened pull request #23179: sandbox: add newfstatat to allowed filesystem syscalls (master...add_newfstatat_to_syscall_exceptions) https://github.com/bitcoin/bitcoin/pull/23179
<bitcoin-git> [bitcoin] D4nte closed pull request #19349: doc: Include wallet path to relevant RPC calls (master...doc-wallet) https://github.com/bitcoin/bitcoin/pull/19349
<gribble> https://github.com/bitcoin/bitcoin/issues/20487 | Add syscall sandboxing using seccomp-bpf (Linux secure computing mode) by practicalswift · Pull Request #20487 · bitcoin/bitcoin · GitHub

2021-10-04

<bitcoin-git> [bitcoin] laanwj opened pull request #23178: util: Fix GUIX build with syscall sandbox (master...2021-10-guix-linux-sandbox) https://github.com/bitcoin/bitcoin/pull/23178
<gribble> https://github.com/bitcoin/bitcoin/issues/1 | JSON-RPC support for mobile devices ("ultra-lightweight" clients) · Issue #1 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] laanwj merged pull request #20487: Add syscall sandboxing using seccomp-bpf (Linux secure computing mode) (master...seccomp-bpf-2020-11) https://github.com/bitcoin/bitcoin/pull/20487
<bitcoin-git> bitcoin/master 4747da3 practicalswift: Add syscall sandboxing (seccomp-bpf)
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/42fedb4acd3c...9e530c6352c3
<bitcoin-git> bitcoin/master 9e530c6 W. J. van der Laan: Merge bitcoin/bitcoin#20487: Add syscall sandboxing using seccomp-bpf (Lin...
<bitcoin-git> [bitcoin] jonatack opened pull request #23175: Add CJDNS network to -addrinfo and -netinfo (master...add-cjdns-to-addrinfo-and-netinfo) https://github.com/bitcoin/bitcoin/pull/23175
<bitcoin-git> [bitcoin] jamesob opened pull request #23174: validation: have LoadBlockIndex account for snapshot use (master...2021-10-au-loadblockindex) https://github.com/bitcoin/bitcoin/pull/23174
<gribble> https://github.com/bitcoin/bitcoin/issues/15936 | Unify bitcoin-qt and bitcoind persistent settings by ryanofsky · Pull Request #15936 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] jnewbery opened pull request #23173: Add `ChainstateManager::ProcessTransaction` (master...2021-09-process-transaction) https://github.com/bitcoin/bitcoin/pull/23173
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23156: refactor: Remove unused ParsePrechecks and ParseDouble (master...2110-refactorParseInt) https://github.com/bitcoin/bitcoin/pull/23156
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/cdb4dfcbf1c8...42fedb4acd3c
<bitcoin-git> bitcoin/master fa9d72a MarcoFalke: Remove unused ParseDouble and ParsePrechecks
<bitcoin-git> bitcoin/master fa3cd28 MarcoFalke: refactor: Remove unused ParsePrechecks from ParseIntegral
<bitcoin-git> bitcoin/master 42fedb4 MarcoFalke: Merge bitcoin/bitcoin#23156: refactor: Remove unused ParsePrechecks and Pa...
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23172: doc: Extract FundTxDoc (master...2110-docRpcWallet) https://github.com/bitcoin/bitcoin/pull/23172
<gribble> https://github.com/bitcoin/bitcoin/issues/15936 | Unify bitcoin-qt and bitcoind persistent settings by ryanofsky · Pull Request #15936 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] MarcoFalke reopened pull request #23156: refactor: Remove unused ParsePrechecks and ParseDouble (master...2110-refactorParseInt) https://github.com/bitcoin/bitcoin/pull/23156
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #23156: refactor: Remove unused ParsePrechecks and ParseDouble (master...2110-refactorParseInt) https://github.com/bitcoin/bitcoin/pull/23156
<bitcoin-git> [bitcoin] laanwj merged pull request #20452: util: Replace use of locale dependent atoi(…) with locale-independent std::from_chars(…) (C++17) (master...remove-atoi) https://github.com/bitcoin/bitcoin/pull/20452
<bitcoin-git> bitcoin/master 4343f11 practicalswift: Replace use of locale dependent atoi(…) with locale-independent std::from_...
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c6f710ec9855...cdb4dfcbf1c8
<bitcoin-git> bitcoin/master cdb4dfc W. J. van der Laan: Merge bitcoin/bitcoin#20452: util: Replace use of locale dependent atoi(…)...
<gribble> https://github.com/bitcoin/bitcoin/issues/17211 | Allow fundrawtransaction and walletcreatefundedpsbt to take external inputs by achow101 · Pull Request #17211 · bitcoin/bitcoin · GitHub
<Kiminuo> https://github.com/bitcoin/bitcoin/pull/22918/checks?check_run_id=3788171337 - does anybody understand why this fails?
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23052: test: use miniwallet in test_rpc function in feature_rbf.py (master...master) https://github.com/bitcoin/bitcoin/pull/23052
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/573b4621cc1f...c6f710ec9855
<bitcoin-git> bitcoin/master 74c0d81 Shubhankar: test: use miniwallet in test_rpc() function in feature_rbf.py
<bitcoin-git> bitcoin/master c6f710e MarcoFalke: Merge bitcoin/bitcoin#23052: test: use miniwallet in test_rpc function in ...
<bitcoin-git> [bitcoin] meshcollider merged pull request #17211: Allow fundrawtransaction and walletcreatefundedpsbt to take external inputs (master...fundtx-external-inputs) https://github.com/bitcoin/bitcoin/pull/17211
<bitcoin-git> bitcoin/master d5cfb86 Andrew Chow: Allow Coin Selection be able to take external inputs
<bitcoin-git> [bitcoin] meshcollider pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/446b70669645...573b4621cc1f
<bitcoin-git> bitcoin/master a00eb38 Andrew Chow: Allow CInputCoin to also be constructed with COutPoint and CTxOut
<bitcoin-git> bitcoin/master 38f5642 Andrew Chow: allow fundtx rpcs to work with external inputs
<bitcoin-git> [bitcoin] darosior opened pull request #23171: qa: test descriptors with mixed xpubs and const pubkeys (master...desc_test_mix) https://github.com/bitcoin/bitcoin/pull/23171
<laanwj> i think we should try to get the CI for https://github.com/bitcoin-core/bitcoincore.org, i don't like blindly merging anything
<gribble> https://github.com/bitcoin/bitcoin/issues/23119 | test: replace bare asserts with assertion helpers (assert_equal() etc.) · Issue #23119 · bitcoin/bitcoin · GitHub
<vincenzopalazzo> Hello guys, I'm working on #23119 and I decided to slip the work in different PR, I would like to know if this approach is good for the review dev, and you preferer it all at once? My start PR is https://github.com/bitcoin/bitcoin/pull/23127
<bitcoin-git> [bitcoin] martinus opened pull request #23169: Fix `-Wmaybe-uninitialized` warnings found by building with `-flto` (master...2021-10-fix-Wmaybe-uninitialized-warnings) https://github.com/bitcoin/bitcoin/pull/23169
<gribble> https://github.com/bitcoin/bitcoin/issues/22966 | doc: Improve documentation around the ACK statement by jarolrod · Pull Request #22966 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] fanquake opened pull request #23168: build: no-longer fail default configure if BDB isn't available (master...dont_fail_no_bdb_default_configure) https://github.com/bitcoin/bitcoin/pull/23168
<gribble> https://github.com/bitcoin/bitcoin/issues/17211 | Allow fundrawtransaction and walletcreatefundedpsbt to take external inputs by achow101 · Pull Request #17211 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] meshcollider closed pull request #23090: Deprecate `main` and `test` `-chain` params (master...20210924) https://github.com/bitcoin/bitcoin/pull/23090

2021-10-03

<bitcoin-git> [gui] luke-jr opened pull request #444: Qt: Network Watch tool (master...gui_netwatch) https://github.com/bitcoin-core/gui/pull/444