< bitcoin-git>
[bitcoin] Crypt-iQ opened pull request #21905: net: set nMessageSize to 0 in CMessageHeader ctor (master...cmessageheader_signchange_05102021) https://github.com/bitcoin/bitcoin/pull/21905
< bitcoin-git>
[gui] hebasto merged pull request #296: Do not use QObject::tr plural syntax for numbers with a unit symbol (master...210425-plurals) https://github.com/bitcoin-core/gui/pull/296
< bitcoin-git>
[bitcoin] laanwj merged pull request #21891: fuzz: Remove strprintf test cases that are known to fail (master...2105-fuzzStr) https://github.com/bitcoin/bitcoin/pull/21891
< bitcoin-git>
bitcoin/master facfc0f MarcoFalke: fuzz: Remove strprintf test cases that are known to fail
< bitcoin-git>
bitcoin/master c9b051b W. J. van der Laan: Merge bitcoin/bitcoin#21891: fuzz: Remove strprintf test cases that are kn...
< bitcoin-git>
[bitcoin] laanwj merged pull request #21836: scripted-diff: Replace three dots with ellipsis in the UI strings (master...210502-ellipsis) https://github.com/bitcoin/bitcoin/pull/21836
< bitcoin-git>
bitcoin/master f8176b7 W. J. van der Laan: Merge bitcoin/bitcoin#21836: scripted-diff: Replace three dots with ellips...
< bitcoin-git>
bitcoin/master d66f283 Hennadii Stepanov: scripted-diff: Replace three dots with ellipsis in the UI strings
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #21786: wallet: ensure sat/vB feerates are in range (mantissa of 3) (master...ensure-sat-vb-feerates-are-in-range) https://github.com/bitcoin/bitcoin/pull/21786
< bitcoin-git>
bitcoin/master b503327 Jon Atack: test: type error and out of range fee rates where missing
< bitcoin-git>
bitcoin/master c5fd434 Jon Atack: test: explicit fee rates with invalid amounts
< sipa>
also, in what context? in the bitcoin core codebase? using rpc? with some library? some api?
2021-05-09
< bitcoin-git>
[bitcoin] theStack opened pull request #21900: test: use MiniWallet for feature_csv_activation.py (master...20210507-test-convert_csvtest_miniwallet) https://github.com/bitcoin/bitcoin/pull/21900
< yanmaani>
does bitcoin have a notion of "intrinsically valid transaction"?
< bitcoin-git>
[bitcoin] hebasto opened pull request #21895: refactor: Add TSA annotations to the WorkQueue class members (master...210509-tsa) https://github.com/bitcoin/bitcoin/pull/21895
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #21892: fuzz: Avoid excessively large min fee rate in tx_pool (master...2105-fuzzPool) https://github.com/bitcoin/bitcoin/pull/21892
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #21891: fuzz: Remove strprintf test cases that are known to fail (master...2105-fuzzStr) https://github.com/bitcoin/bitcoin/pull/21891
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #21890: fuzz: Limit ParseISO8601DateTime fuzzing to 32-bit (master...2105-fuzzTime32) https://github.com/bitcoin/bitcoin/pull/21890
< bitcoin-git>
[bitcoin] fanquake opened pull request #21889: macho: check for control flow instrumentation (master...build_boost_fcf_protectcion) https://github.com/bitcoin/bitcoin/pull/21889
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #21872: net: Sanitize message type for logging (master...2021-05-sanitize-messagetype) https://github.com/bitcoin/bitcoin/pull/21872
< bitcoin-git>
bitcoin/master 5925f1e MarcoFalke: Merge bitcoin/bitcoin#21872: net: Sanitize message type for logging
< bitcoin-git>
bitcoin/master 09205b3 W. J. van der Laan: net: Clarify message header validation errors
< bitcoin-git>
bitcoin/master 955eee7 W. J. van der Laan: net: Sanitize message type for logging
< gmaxwell>
conman: unfortunately bitcoin exposes far too much consensus innards to edge devices, it's a big problem... because it creates interactions with edge devices that ought not exist.
< sipa>
anyway, i agree it's unlikely that bitcoin core would ever be in a position where it needs to set that field
< gmaxwell>
then Bitcoin deploys a softfork that turns OP_NOP3 into some new relative timelock. Boom all those outputs become forever unspendable and they lose 10,000 BTC.
< gmaxwell>
Say litecoin had some OP_INPUT_WASNT_CREATED_IN_THE_SAME_BLOCK which it used as OP_NOP3. Then some exchange was using that on litecoin and starts using it on bitcoin, and f2pool is mining it. It's harmless-- doesn't do anything. Over the next year they assign 10,000 BTC to those outputs.
< gmaxwell>
Unclear why they stopped, other than maybe just that they failed to drop the bitcoin price.
< bitcoin-git>
[bitcoin] windsok opened pull request #21873: test: minor fixes & improvements for files linter test (master...files-lint-fixups) https://github.com/bitcoin/bitcoin/pull/21873
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #21869: depends: Add missing -D_LIBCPP_DEBUG=1 to debug flags (master...2105-dependsDebug) https://github.com/bitcoin/bitcoin/pull/21869
< bitcoin-git>
[bitcoin] theStack opened pull request #21867: test: use MiniWallet for p2p_blocksonly.py (master...20210505-test-convert_p2pblocksonly_miniwallet) https://github.com/bitcoin/bitcoin/pull/21867
2021-05-05
< bitcoin-git>
[bitcoin] dongcarl opened pull request #21866: [Bundle 7/7] validation: Farewell, global Chainstate! (master...2020-10-libbitcoinruntime-v9) https://github.com/bitcoin/bitcoin/pull/21866
< bitcoin-git>
[bitcoin] glozow opened pull request #21864: fix permissions on 00_setup_env_native_fuzz_with_msan.sh (master...2021-05-lint) https://github.com/bitcoin/bitcoin/pull/21864
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #21863: ci: Set depends DEBUG=1 for msan tasks to get line numbers (master...2105-ciMsanDebug) https://github.com/bitcoin/bitcoin/pull/21863
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #21863: ci: Set depends DEBUG=1 for msan tasks to get line numbers (master...2105-ciMsanDebug) https://github.com/bitcoin/bitcoin/pull/21863
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #21681: validation: fix ActivateSnapshot to use hardcoded nChainTx (master...2021-04-au-nchaintx-fix) https://github.com/bitcoin/bitcoin/pull/21681
< bitcoin-git>
bitcoin/master 128b98f MarcoFalke: Merge bitcoin/bitcoin#21681: validation: fix ActivateSnapshot to use hardc...
< bitcoin-git>
bitcoin/master 91d93aa James O'Beirne: validation: remove nchaintx from assumeutxo metadata
< bitcoin-git>
bitcoin/master 931684b James O'Beirne: validation: fix ActivateSnapshot to use hardcoded nChainTx
< bitcoin-git>
[bitcoin] laanwj merged pull request #21664: contrib: use LIEF for macOS and Windows symbol & security checks (master...macos_win_lief) https://github.com/bitcoin/bitcoin/pull/21664
< bitcoin-git>
bitcoin/master 7e7eae7 fanquake: contrib: use f strings in security-check.py
< bitcoin-git>
[bitcoin] jonatack closed pull request #21855: fuzz: enable passing a max value to FuzzedDataProvider::ConsumeEnum() (master...ConsumeEnum-enable-passing-max-value) https://github.com/bitcoin/bitcoin/pull/21855
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #21862: test: Set regtest.BIP65Height = 112 to speed up tests (master...2105-testFasterBip65) https://github.com/bitcoin/bitcoin/pull/21862
< gmaxwell>
well, sipa is weird but his bitcoin node isn't. :P
< gmaxwell>
Like, have we made a series of single steps that were logcal but gives a weird outcome? Step 1. relay faster to outbound peers because we control them, so they're less likely to be spies monitoring our txn. Step 2. Introduce reconcillation, but make flooding only happen for reachable nodes because it has some moral similarity to step 1. Conclusion, 80% of bitcoin nodes no longer participate
< gmaxwell>
for one thing it takes 80% or whatever of bitcoin nodes out of participation in rapidly forwarding transactions, which seems ... like a really big step to take without an obvious reason.
< gmaxwell>
Basically nowhere else in the bitcoin protocol is there this in/out distinction -- just in tx relay privacy timers (which were 'recently' introduced relatively speaking) and in peer eviction.
< gmaxwell>
gleb: I think in general when we talk about erlay (e.g. in the paper and elsewhere) we use this "non-reachable peer" terminology, but non-reachability doesn't exist explicitly anywhere in the implementation of bitcoin core or the bitcoin protocol... so although non-reachable peers were a good concept for modling, it can be a little confusing when it comes to the implementation.
< sipa>
gleb: was it needed to include minisketch in bitcoin-tx?
< gmaxwell>
Current bitcoin core causes really old nodes to be unable to sync and to dos attack you. The issue is that prior to 0.7-ish the size of headers messages wasn't limited, and the node requests headers from everyone. They blast you with a multimegabyte header and disconnect and go do it to someoen else. These old nodes seem to have also formed a fork at an early height, nodes that have this
< bitcoin-git>
[bitcoin] jonatack opened pull request #21855: fuzz: enable passing a max value to FuzzedDataProvider::ConsumeEnum() (master...ConsumeEnum-enable-passing-max-value) https://github.com/bitcoin/bitcoin/pull/21855
< bitcoin-git>
[bitcoin] fanquake opened pull request #21851: [WIP] build: support cross-compiling for arm64-apple-darwin20 (Apple M1) in depends (master...m1_support_depends) https://github.com/bitcoin/bitcoin/pull/21851