2020-08-20

< gribble> https://github.com/bitcoin/bitcoin/issues/19614 | util: use HAVE_FDATASYNC to determine fdatasync() use by fanquake · Pull Request #19614 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19430 | build: configure.ac and netbsd-build.md for NetBSD by midnightmagic · Pull Request #19430 · bitcoin/bitcoin · GitHub

2020-08-19

< bitcoin-git> [bitcoin] luke-jr closed pull request #19243: banman: Limit resources consumed by misbehaving node deprioitisation (master...misbehaving_limit) https://github.com/bitcoin/bitcoin/pull/19243
< bitcoin-git> [bitcoin] jonatack reopened pull request #19405: rpc, cli: add network in/out connections to `getnetworkinfo` and `-getinfo` (master...in-and-out-connections) https://github.com/bitcoin/bitcoin/pull/19405
< jonatack> fwiw it's merged into bitcoin-knots
< jonatack> meanwhile, there's bitcoin-cli getpeerinfo | jq "group_by(.inbound) | map({Inbound: .[0].inbound, Count: length}) | .[]"
< shesek> but that's for the bitcoin-cli client and not something provided by the rpc itself, right?
< gribble> https://github.com/bitcoin/bitcoin/issues/19405 | rpc, cli: add network in/out connections to `getnetworkinfo` and `-getinfo` by jonatack · Pull Request #19405 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19643 | Add `-netinfo` peer connections dashboard by jonatack · Pull Request #19643 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19405 | rpc, cli: add network in/out connections to `getnetworkinfo` and `-getinfo` by jonatack · Pull Request #19405 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj merged pull request #19750: refactor: remove unused c-string variant of atoi64() (master...20200817-util-remove-unused_cstr_atoi64) https://github.com/bitcoin/bitcoin/pull/19750
< bitcoin-git> bitcoin/master 71e0f07 Sebastian Falbesoner: util: remove unused c-string variant of atoi64()
< bitcoin-git> bitcoin/master e9b3012 Wladimir J. van der Laan: Merge #19750: refactor: remove unused c-string variant of atoi64()
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/44ddcd887ddf...e9b30126545d
< bitcoin-git> [bitcoin] laanwj merged pull request #19706: refactor: make EncodeBase58{Check} consume Spans (master...20200810-util-make-base58encode-consume-spans) https://github.com/bitcoin/bitcoin/pull/19706
< bitcoin-git> bitcoin/master 44ddcd8 Wladimir J. van der Laan: Merge #19706: refactor: make EncodeBase58{Check} consume Spans
< bitcoin-git> bitcoin/master 356988e Sebastian Falbesoner: util: make EncodeBase58Check consume Spans
< bitcoin-git> bitcoin/master f0fce06 Sebastian Falbesoner: util: make EncodeBase58 consume Spans
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c6532fa6c14d...44ddcd887ddf
< gribble> https://github.com/bitcoin/bitcoin/issues/19628 | net: change CNetAddr::ip to have flexible size by vasild · Pull Request #19628 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19710 | bench: Prevent thread oversubscription and decreases the variance of result values by hebasto · Pull Request #19710 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19765: doc: Fix getmempoolancestor RPC result doc (master...2008-rpcDoc) https://github.com/bitcoin/bitcoin/pull/19765
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19746: ci: Move valgrind fuzzer to cirrus (master...2008-ciValgrind) https://github.com/bitcoin/bitcoin/pull/19746
< bitcoin-git> bitcoin/master c6532fa MarcoFalke: Merge #19746: ci: Move valgrind fuzzer to cirrus
< bitcoin-git> bitcoin/master fa0538e MarcoFalke: ci: Set cirrus RAM to 8GB
< bitcoin-git> bitcoin/master fa41810 MarcoFalke: ci: Run valgrind fuzzer on cirrus
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/a2a250c7d07b...c6532fa6c14d

2020-08-18

< bitcoin-git> [bitcoin] dongcarl opened pull request #19764: depends: Split boost into build/host packages + bump + cleanup (master...2020-08-boost-build-pickup) https://github.com/bitcoin/bitcoin/pull/19764
< bitcoin-git> [bitcoin] vasild opened pull request #19763: net: don't try to relay to node that knows an addr (master...only_relay_to_unaware) https://github.com/bitcoin/bitcoin/pull/19763
< luke-jr> hebasto: ping, where did you get that hash? https://github.com/bitcoin/bitcoin/pull/19751/files#r472253382
< bitcoin-git> [bitcoin] ryanofsky opened pull request #19762: rpc: Allow named and positional arguments to be used together (master...pr/named) https://github.com/bitcoin/bitcoin/pull/19762
< satoshin> You can send the list by email to: contact@bitcoin.foundation or post it here.
< satoshin> I working on the https://BITCOIN.FOUNDATION domain and I need a list about the Bitcoin core developers (preferably with PGP public keys attached to the list)
< bitcoin-git> [bitcoin] fanquake opened pull request #19761: build: improve sed robustness by not using sed (master...maximum_sed_robustness) https://github.com/bitcoin/bitcoin/pull/19761
< bitcoin-git> [bitcoin] meshcollider merged pull request #19743: -maxapsfee follow-up (master...20200817-maxapsfee-followup) https://github.com/bitcoin/bitcoin/pull/19743
< bitcoin-git> bitcoin/master a2a250c Samuel Dobson: Merge #19743: -maxapsfee follow-up
< bitcoin-git> bitcoin/master 7e31ea9 Karl-Johan Alm: -maxapsfee: follow-up fixes
< bitcoin-git> bitcoin/master 9f77b82 Karl-Johan Alm: doc: release notes for -maxapsfee
< bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/e6e277f9ed4d...a2a250c7d07b
< bitcoin-git> [bitcoin] jnewbery opened pull request #19759: [doc] Struct members should have m_ prefix (master...2020-08-struct-members) https://github.com/bitcoin/bitcoin/pull/19759
< bitcoin-git> [bitcoin] hebasto opened pull request #19758: Drop deprecated and unused GUARDED_VAR and PT_GUARDED_VAR annotations (master...200818-tsa) https://github.com/bitcoin/bitcoin/pull/19758
< bitcoin-git> [bitcoin] vasild closed pull request #18857: build: avoid repetitions when enabling warnings in configure.ac (master...avoid_repetitions_in_configure.ac) https://github.com/bitcoin/bitcoin/pull/18857
< bitcoin-git> [bitcoin] hebasto closed pull request #16641: refactor: Improve special member functions definitions (master...20190817-psbt-copy-ctor) https://github.com/bitcoin/bitcoin/pull/16641
< bitcoin-git> [bitcoin] JeremyRubin opened pull request #19757: net/net_processing: Convert net std::list buffers to std::forward_list (master...net-list-type) https://github.com/bitcoin/bitcoin/pull/19757
< gribble> https://github.com/bitcoin/bitcoin/issues/19743 | -maxapsfee follow-up by kallewoof · Pull Request #19743 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19756: tests: add sync_all to fix race condition in wallet groups test (master...202008-wallet-groups-sync-all) https://github.com/bitcoin/bitcoin/pull/19756
< bitcoin-git> bitcoin/master e6e277f MarcoFalke: Merge #19756: tests: add sync_all to fix race condition in wallet groups t...
< bitcoin-git> bitcoin/master 72ae20f Karl-Johan Alm: tests: add sync_all to fix race condition in wallet groups test
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/772cb03a2816...e6e277f9ed4d
< gribble> https://github.com/bitcoin/bitcoin/issues/19756 | tests: add sync_all to fix race condition in wallet groups test by kallewoof · Pull Request #19756 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake merged pull request #19015: build: Enable some commonly enabled compiler diagnostics (master...compiler-diagnostics) https://github.com/bitcoin/bitcoin/pull/19015
< bitcoin-git> bitcoin/master 772cb03 fanquake: Merge #19015: build: Enable some commonly enabled compiler diagnostics
< bitcoin-git> bitcoin/master 2f8a4c9 practicalswift: build: Enable some commonly enabled compiler diagnostics
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f2d1b9881f68...772cb03a2816
< bitcoin-git> [bitcoin] fanquake merged pull request #19721: p2p: comment out unused MSG_FILTERED_WITNESS_BLOCK (master...2020_8_MSG_FILTERED_WITNESS_BLOCK_comment) https://github.com/bitcoin/bitcoin/pull/19721
< bitcoin-git> bitcoin/master f2d1b98 fanquake: Merge #19721: p2p: comment out unused MSG_FILTERED_WITNESS_BLOCK
< bitcoin-git> bitcoin/master 4792cad Adam Jonas: doc: comment out and add annotation to unused MSG_FILTERED_WITNESS_BLOCK
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/53dac67a97e2...f2d1b9881f68
< bitcoin-git> [bitcoin] fanquake merged pull request #19719: build: Add Werror=range-loop-analysis (master...2008-buildLoopErr) https://github.com/bitcoin/bitcoin/pull/19719
< bitcoin-git> bitcoin/master fa55c1d MarcoFalke: build: Add Werror=range-loop-analysis
< bitcoin-git> bitcoin/master 53dac67 fanquake: Merge #19719: build: Add Werror=range-loop-analysis
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1bc8e8eae2dc...53dac67a97e2
< bitcoin-git> [bitcoin] kallewoof opened pull request #19756: tests: add sync_all to fix race condition in wallet groups test (master...202008-wallet-groups-sync-all) https://github.com/bitcoin/bitcoin/pull/19756

2020-08-17

< gribble> https://github.com/bitcoin/bitcoin/issues/19619 | Remove wallet.dat path handling from wallet.cpp, rpcwallet.cpp by ryanofsky · Pull Request #19619 · bitcoin/bitcoin · GitHub
< ryanofsky> i started changes to clean it up https://github.com/ryanofsky/bitcoin/commits/pr/path.1, #19619 came out of that
< bitcoin-git> [bitcoin] achow101 opened pull request #19754: wallet: Move UpdateWalletSetting to wallet module and use from GUI interface (master...load-on-start-gui) https://github.com/bitcoin/bitcoin/pull/19754
< bitcoin-git> [bitcoin] troygiorshev opened pull request #19753: p2p: fix recentRejects filling bug (master...2020-08-clean-tx-processing) https://github.com/bitcoin/bitcoin/pull/19753
< bitcoin-git> [bitcoin] slmtpz opened pull request #19752: test: Update wait_until usage in tests not to use the one from utils (master...master) https://github.com/bitcoin/bitcoin/pull/19752
< gribble> https://github.com/bitcoin/bitcoin/issues/19316 | [net] Cleanup logic around connection types by amitiuttarwar · Pull Request #19316 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] luke-jr opened pull request #19751: depends: Split libpng out of Qt (master...depends_libpng) https://github.com/bitcoin/bitcoin/pull/19751
< bitcoin-git> [bitcoin] theStack opened pull request #19750: refactor: remove unused c-string variant of atoi64() (master...20200817-util-remove-unused_cstr_atoi64) https://github.com/bitcoin/bitcoin/pull/19750
< bitcoin-git> [bitcoin] S3RK opened pull request #19747: wallet: restore condition for HD chain split upgrade (master...wallet_upgrade_fix) https://github.com/bitcoin/bitcoin/pull/19747
< bitcoin-git> [bitcoin] S3RK closed pull request #19384: test: speed up functional tests (master...test_speed_up) https://github.com/bitcoin/bitcoin/pull/19384
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19734: Move CDiskTxPos to its own file (master...move-disktxpos) https://github.com/bitcoin/bitcoin/pull/19734
< bitcoin-git> bitcoin/master 1bc8e8e MarcoFalke: Merge #19734: Move CDiskTxPos to its own file
< bitcoin-git> bitcoin/master 7668db3 Marcin Jachymiak: Move only: Move CDiskTxPos to its own file
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c831e105c567...1bc8e8eae2dc
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19746: ci: Move valgrind fuzzer to cirrus (master...2008-ciValgrind) https://github.com/bitcoin/bitcoin/pull/19746
< bitcoin-git> [bitcoin] hebasto closed pull request #19745: build: Drop back compatibility code for 32-bit x86 Linux binaries (master...200817-i686) https://github.com/bitcoin/bitcoin/pull/19745
< bitcoin-git> [bitcoin] hebasto opened pull request #19745: build: Drop back compatibility code for 32-bit x86 Linux binaries (master...200817-i686) https://github.com/bitcoin/bitcoin/pull/19745
< bitcoin-git> [bitcoin] kallewoof opened pull request #19743: -maxapsfee follow-up (master...20200817-maxapsfee-followup) https://github.com/bitcoin/bitcoin/pull/19743
< bitcoin-git> [bitcoin] meshcollider merged pull request #14582: wallet: always do avoid partial spends if fees are within a specified range (master...181026-try-avoidpartialspends) https://github.com/bitcoin/bitcoin/pull/14582
< bitcoin-git> bitcoin/master c831e10 Samuel Dobson: Merge #14582: wallet: always do avoid partial spends if fees are within a ...
< bitcoin-git> bitcoin/master 7f13dfb Karl-Johan Alm: test: test the implicit avoid partial spends functionality
< bitcoin-git> bitcoin/master b82067b Karl-Johan Alm: wallet: try -avoidpartialspends mode and use its result if fees are below ...
< bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ffad34816722...c831e105c567
< gribble> https://github.com/bitcoin/bitcoin/issues/19568 | Wallet should not override signing errors by fjahr · Pull Request #19568 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] achow101 opened pull request #19740: [0.20] wallet: Simplify and fix CWallet::SignTransaction (0.20...backport-17204-fix) https://github.com/bitcoin/bitcoin/pull/19740
< gribble> https://github.com/bitcoin/bitcoin/issues/18115 | wallet: Pass in transactions and messages for signing instead of exporting the private keys by achow101 · Pull Request #18115 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17204 | wallet: Do not turn OP_1NEGATE in scriptSig into 0x0181 in signing code (sipa) by meshcollider · Pull Request #17204 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] promag closed pull request #15204: gui: Add Open External Wallet action (master...2019-01-openexternalwallet) https://github.com/bitcoin/bitcoin/pull/15204
< bitcoin-git> [bitcoin] theStack opened pull request #19739: refactor: remove c-string interfaces for DecodeBase58{Check} (master...20200811-util-remove-cstring-decodebase58) https://github.com/bitcoin/bitcoin/pull/19739

2020-08-16

< bitcoin-git> [bitcoin] promag opened pull request #19738: wallet: Avoid multiple BerkeleyBatch in DelAddressBook (master...2020-08-deladdressbook) https://github.com/bitcoin/bitcoin/pull/19738
< bitcoin-git> [bitcoin] laanwj merged pull request #19705: Shrink CAddress from 48 to 40 bytes on x64 (master...shrink_caddress) https://github.com/bitcoin/bitcoin/pull/19705
< bitcoin-git> bitcoin/master 767073f Vasil Dimov: Shrink CAddress from 48 to 40 bytes on x64
< bitcoin-git> bitcoin/master ffad348 Wladimir J. van der Laan: Merge #19705: Shrink CAddress from 48 to 40 bytes on x64
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a57af897ec16...ffad34816722
< bitcoin-git> [bitcoin] hebasto opened pull request #19735: Fix -Wtautological-constant-out-of-range-compare warnings on 32-bit systems (master...200816-size) https://github.com/bitcoin/bitcoin/pull/19735
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19564: test: p2p_feefilter improvements (logging, refactoring, speedup) (master...20200722-test-p2p_feefilter_improvements) https://github.com/bitcoin/bitcoin/pull/19564
< bitcoin-git> bitcoin/master 9e78943 Sebastian Falbesoner: test: speedup p2p_feefilter.py by whitelisting peers (immediate tx relay)
< bitcoin-git> bitcoin/master 6d94192 Sebastian Falbesoner: test: add logging for p2p_feefilter.py
< bitcoin-git> bitcoin/master fe3f0cc Sebastian Falbesoner: test: use wait_until for invs matching in p2p_feefilter.py
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/3ab2582c7fe7...a57af897ec16
< shesek> achow101, one unintended side-effect is that spending from that address reveals that you're using bitcoin core. but that can only be an issue if someone learns your xpub, which should not really happen normally anyway
< bitcoin-git> [bitcoin] adamjonas closed pull request #17232: Sanity assert GetAncestor() != nullptr where appropriate (master...assert_get_ancestor) https://github.com/bitcoin/bitcoin/pull/17232
< gribble> https://github.com/bitcoin/bitcoin/issues/19602 | wallet: Migrate legacy wallets to descriptor wallets by achow101 · Pull Request #19602 · bitcoin/bitcoin · GitHub

2020-08-15

< bitcoin-git> [bitcoin] marcinja opened pull request #19734: Move CDiskTxPos to its own file (master...move-disktxpos) https://github.com/bitcoin/bitcoin/pull/19734
< bitcoin-git> [bitcoin] marcinja opened pull request #19733: Move comment about BaseIndex::DB from TxIndex::DB (master...move-index-comment) https://github.com/bitcoin/bitcoin/pull/19733
< bitcoin-git> [bitcoin] hebasto closed pull request #19588: test: Add random interval upper bound in regtest (master...200725-uni-test) https://github.com/bitcoin/bitcoin/pull/19588
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19730: ci: Set increased --timeout-factor by default (master...2008-ciTimeoutDefault) https://github.com/bitcoin/bitcoin/pull/19730
< bitcoin-git> bitcoin/master 3ab2582 MarcoFalke: Merge #19730: ci: Set increased --timeout-factor by default
< bitcoin-git> bitcoin/master fa330ec MarcoFalke: test: Remove confusing and broken use of wait_until global
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/4cde97374d5c...3ab2582c7fe7
< bitcoin-git> bitcoin/master fa6583c MarcoFalke: ci: Set increased --timeout-factor by default
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #19134: test: Replace global wait_until with BitcoinTestFramework.wait_until and mininode.wait_until (master...master) https://github.com/bitcoin/bitcoin/pull/19134
< bitcoin-git> [bitcoin] jonatack opened pull request #19731: net, rpc: expose nLastBlockTime/nLastTXTime as last block/last_transaction in getpeerinfo (master...add-eviction-criteria-to-getpeerinfo) https://github.com/bitcoin/bitcoin/pull/19731
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19730: ci: Set increased --timeout-factor by default (master...2008-ciTimeoutDefault) https://github.com/bitcoin/bitcoin/pull/19730
< bitcoin-git> [bitcoin] sipa opened pull request #19728: Increase the ip address relay branching factor for unreachable networks (master...202008_increase_addr_branching) https://github.com/bitcoin/bitcoin/pull/19728
< bitcoin-git> [bitcoin] dhruv opened pull request #19727: test: Removing unused classes from p2p_leak.py (master...test-p2p-leak) https://github.com/bitcoin/bitcoin/pull/19727
< bitcoin-git> [bitcoin] amitiuttarwar opened pull request #19725: [RPC] Add connection type to getpeerinfo (master...2020-08-getpeerinfo-conn-type) https://github.com/bitcoin/bitcoin/pull/19725
< bitcoin-git> bitcoin/master 4cde973 fanquake: Merge #19718: build: Add missed gcov files to 'make clean'
< bitcoin-git> [bitcoin] fanquake merged pull request #19718: build: Add missed gcov files to 'make clean' (master...200814-gcno) https://github.com/bitcoin/bitcoin/pull/19718
< bitcoin-git> bitcoin/master 6cb8771 Hennadii Stepanov: build: Add missed gcov files to 'make clean'
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d052f5e6b79b...4cde97374d5c
< bitcoin-git> [bitcoin] fanquake merged pull request #16841: Replace GetScriptForWitness with GetScriptForDestination (master...201909_remove_getscriptforwitness) https://github.com/bitcoin/bitcoin/pull/16841
< bitcoin-git> bitcoin/master 7966aa4 MeshCollider: Add variables for repeated scripts
< bitcoin-git> bitcoin/master fec8336 MeshCollider: Remove GetScriptForWitness function
< bitcoin-git> bitcoin/master b887060 MeshCollider: Replace usage of GetScriptForWitness with GetScriptForDestination
< bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/a0e75bd31dff...d052f5e6b79b
< bitcoin-git> [bitcoin] fanquake closed pull request #18992: qt: AddressBookPage - Hide non PKHash-Addresses and improve GUI messages for signing address book (master...202005-sign-message-ui) https://github.com/bitcoin/bitcoin/pull/18992
< bitcoin-git> [bitcoin] meshcollider merged pull request #15937: Add loadwallet and createwallet load_on_startup options (master...pr/walset) https://github.com/bitcoin/bitcoin/pull/15937
< bitcoin-git> bitcoin/master a0e75bd Samuel Dobson: Merge #15937: Add loadwallet and createwallet load_on_startup options
< bitcoin-git> bitcoin/master 642ad31 Russell Yanofsky: Add loadwallet and createwallet RPC load_on_startup options
< bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f269165edc03...a0e75bd31dff

2020-08-14

< bitcoin-git> [bitcoin] meshcollider merged pull request #17458: Refactor OutputGroup effective value calculations and filtering to occur within the struct (master...cleanup-outputgroups) https://github.com/bitcoin/bitcoin/pull/17458
< bitcoin-git> bitcoin/master f269165 Samuel Dobson: Merge #17458: Refactor OutputGroup effective value calculations and filter...
< bitcoin-git> bitcoin/master 9adc2f8 Andrew Chow: Refactor OutputGroups to handle effective values, fees, and filtering
< bitcoin-git> bitcoin/master 7d07e86 Andrew Chow: Use real value when calculating OutputGroup value
< bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/30dd562fd2c5...f269165edc03
< bitcoin-git> [bitcoin] amitiuttarwar opened pull request #19724: [net] Cleanup connection type- followups (master...2020-08-conn-refactor-followups) https://github.com/bitcoin/bitcoin/pull/19724
< gribble> https://github.com/bitcoin/bitcoin/issues/16841 | Replace GetScriptForWitness with GetScriptForDestination by meshcollider · Pull Request #16841 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sdaftuar opened pull request #19723: Ignore unknown messages before VERACK (master...2020-08-feature-negotiation) https://github.com/bitcoin/bitcoin/pull/19723
< gribble> https://github.com/bitcoin/bitcoin/issues/19700 | wallet: Replace -zapwallettxes with wallet tool command by achow101 · Pull Request #19700 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19671 | wallet: Remove -zapwallettxes by achow101 · Pull Request #19671 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16841 | Replace GetScriptForWitness with GetScriptForDestination by meshcollider · Pull Request #16841 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17331 | Use effective values throughout coin selection by achow101 · Pull Request #17331 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17458 | Refactor OutputGroup effective value calculations and filtering to occur within the struct by achow101 · Pull Request #17458 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14582 | wallet: always do avoid partial spends if fees are within a specified range by kallewoof · Pull Request #14582 · bitcoin/bitcoin · GitHub
< meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball ariard digi_james amiti fjahr
< bitcoin-git> [bitcoin] torhte opened pull request #19722: [test] Add test for getblockheader verboseness (master...test-gbh) https://github.com/bitcoin/bitcoin/pull/19722
< jonatack> perhaps ban "Jssdr" for this spammy comment: https://github.com/bitcoin/bitcoin/issues/2086#issuecomment-674142837
< bitcoin-git> [bitcoin] adamjonas opened pull request #19721: doc: comment out unused MSG_FILTERED_WITNESS_BLOCK (master...2020_8_MSG_FILTERED_WITNESS_BLOCK_comment) https://github.com/bitcoin/bitcoin/pull/19721
< bitcoin-git> [bitcoin] jonatack opened pull request #19720: test: bip157 p2p_blockfilters configuration options (master...bip157-blockfilters-tests) https://github.com/bitcoin/bitcoin/pull/19720
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19719: build: Add Werror=range-loop-analysis (master...2008-buildLoopErr) https://github.com/bitcoin/bitcoin/pull/19719
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19709: test: Fix 'make cov' with clang (master...200813-lcov) https://github.com/bitcoin/bitcoin/pull/19709
< bitcoin-git> bitcoin/master 1a43cd3 MarcoFalke: Merge #19709: test: Fix 'make cov' with clang
< bitcoin-git> bitcoin/master 35cd2da Hennadii Stepanov: test: Fix 'make cov' with clang
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4d4bd5ed7474...1a43cd3f747f
< bitcoin-git> [bitcoin] hebasto opened pull request #19718: build, test: Add missed gcov files to 'make clean' (master...200814-gcno) https://github.com/bitcoin/bitcoin/pull/19718
< bitcoin-git> [bitcoin] laanwj merged pull request #17204: wallet: Do not turn OP_1NEGATE in scriptSig into 0x0181 in signing code (sipa) (master...201910_1negate_rebase) https://github.com/bitcoin/bitcoin/pull/17204
< bitcoin-git> bitcoin/master 4d4bd5e Wladimir J. van der Laan: Merge #17204: wallet: Do not turn OP_1NEGATE in scriptSig into 0x0181 in s...
< bitcoin-git> bitcoin/master e629d07 Pieter Wuille: Do not turn OP_1NEGATE in scriptSig into 0x0181 in signing code
< bitcoin-git> bitcoin/master dca2863 Jon Atack: test: ensure OP_1NEGATE satisfies BIP62 minimal push rule
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/dabab06a1a1a...4d4bd5ed7474
< bitcoin-git> [bitcoin] laanwj merged pull request #19455: rpc generate: print useful help and error message (master...rpc-generate-helpful-error_message) https://github.com/bitcoin/bitcoin/pull/19455
< bitcoin-git> bitcoin/master f0aa8ae Jon Atack: test: add rpc_generate functional test
< bitcoin-git> bitcoin/master 8d32d20 Jon Atack: test: consider generate covered in _get_uncovered_rpc_commands()
< bitcoin-git> bitcoin/master 92d94ff Jon Atack: rpc: print useful help and error message for generate
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/c0b170696432...dabab06a1a1a
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19717: rpc: Assert that RPCArg names are equal to CRPCCommand ones (mining,zmq,rpcdump) (master...2008-rpcMisc) https://github.com/bitcoin/bitcoin/pull/19717
< gribble> https://github.com/bitcoin/bitcoin/issues/19455 | rpc generate: print useful help and error message by jonatack · Pull Request #19455 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake merged pull request #19568: Wallet should not override signing errors (master...err_override) https://github.com/bitcoin/bitcoin/pull/19568
< bitcoin-git> bitcoin/master c0b1706 fanquake: Merge #19568: Wallet should not override signing errors
< bitcoin-git> bitcoin/master e7448d6 Fabian Jahr: wallet: Don't override signing errors
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/31760bb7c9f3...c0b170696432
< gribble> https://github.com/bitcoin/bitcoin/issues/17204 | wallet: Do not turn OP_1NEGATE in scriptSig into 0x0181 in signing code (sipa) by meshcollider · Pull Request #17204 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake opened pull request #19716: build: Qt 5.15.x (master...qt_5_15_x) https://github.com/bitcoin/bitcoin/pull/19716
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19528: rpc: Assert that RPCArg names are equal to CRPCCommand ones (misc) (master...2007-rpcMiscAssert) https://github.com/bitcoin/bitcoin/pull/19528
< bitcoin-git> bitcoin/master fa50bdc MarcoFalke: rpc: Limit echo to 10 args
< bitcoin-git> bitcoin/master fa459bd MarcoFalke: rpc: Treat all args after a hidden arg as hidden as well
< bitcoin-git> bitcoin/master fa89ca9 MarcoFalke: refactor: Use C++11 range based for loops to simplify rpc code
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/609ce2d0da49...31760bb7c9f3
< gribble> https://github.com/bitcoin/bitcoin/issues/13765 | contrib: add gitian build support for github pull request by ken2812221 · Pull Request #13765 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18336 | script: Fix gitian-build.py --pull option by hebasto · Pull Request #18336 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake closed pull request #17659: qt: Do not block GUI thread in RPCConsole (master...20191203-nonblocking-rpcconsole) https://github.com/bitcoin/bitcoin/pull/17659
< bitcoin-git> [bitcoin] fanquake closed pull request #17877: qt, refactor: Make BitcoinUnits::Unit a scoped enum (master...20200105-scoped-enums) https://github.com/bitcoin/bitcoin/pull/17877
< bitcoin-git> [bitcoin] fanquake closed pull request #18133: Fix various edge case bugs in QValidatedLineEdit (master...bugfix_qvalidlineedit) https://github.com/bitcoin/bitcoin/pull/18133
< bitcoin-git> [bitcoin] fanquake closed pull request #17311: build: macOS fix background.svg (master...fix-background-svg) https://github.com/bitcoin/bitcoin/pull/17311
< bitcoin-git> [bitcoin] fanquake closed pull request #18153: doc/release-process: Restore and update PPA note (master...doc_ppa_202002) https://github.com/bitcoin/bitcoin/pull/18153

2020-08-13

< bitcoin-git> [bitcoin] meshcollider merged pull request #19644: rpc: document returned error fields as optional if applicable (master...20200802-rpc-document_errors_fields_as_optional) https://github.com/bitcoin/bitcoin/pull/19644
< bitcoin-git> bitcoin/master 609ce2d Samuel Dobson: Merge #19644: rpc: document returned error fields as optional if applicabl...
< bitcoin-git> bitcoin/master f110b7c Sebastian Falbesoner: rpc: document returned error fields as optional if applicable
< bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b4d0366b47dd...609ce2d0da49
< gribble> https://github.com/bitcoin/bitcoin/issues/19704 | Net processing: move ProcessMessage() to PeerLogicValidation by jnewbery · Pull Request #19704 · bitcoin/bitcoin · GitHub
< michaelfolkson> It seems to me that the experiment has been very short. I will try to find out if there is genuine interest in contributing, reviewing on that Bitcoin Design Slack
< wumpus> luke-jr_: that seems another issue, would make it imopssible to move bitcoin itself there
< luke-jr_> also, while it used to be possible to have multiple forks under the same org (so bitcoin-core/gui and bitcoin-core/foobar), GitHub seems to have removed that possibility too
< wumpus> then again if a lot of people feel like it would be easier if it's a bitcoin/bitcoin fork we could try asking github
< jnewbery> if we delete bitcoin-core/gui and then recreate it as a fork of bitcoin/bitcoin, you'd be able to
< jnewbery> wumpus: if you push a branch to <developer>/bitcoin , then you can't open a PR against bitcoin-core/gui because they don't share a common fork in gitub
< wumpus> he wants to inherit it from bitcoin/bitcoin I think instead of having it as completely disparate repo
< luke-jr_> Can we recreate bitcoin-core/gui so GitHub will let us do PRs from the same <user>/bitcoin forks instead of making a new remote for everyone?
< wumpus> #topic Can we recreate bitcoin-core/gui (Luke-jr)
< gribble> https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19628 | net: change CNetAddr::ip to have flexible size by vasild · Pull Request #19628 · bitcoin/bitcoin · GitHub
< wumpus> https://github.com/bitcoin/bitcoin/projects/8 10 blockers, 1 bugfix, 3 chasing conept
< wumpus> one proposed topic in http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt: Can we recreate bitcoin-core/gui (Luke-jr)
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james
< bitcoin-git> [bitcoin] Crypt-iQ opened pull request #19713: fuzz: fix -fsanitize=integer complaints (master...fuzz_supp_0813) https://github.com/bitcoin/bitcoin/pull/19713
< bitcoin-git> [bitcoin] hebasto reopened pull request #19064: refactor: Cleanup thread ctor calls (master...200524-bind) https://github.com/bitcoin/bitcoin/pull/19064
< bitcoin-git> [bitcoin] hebasto closed pull request #19064: refactor: Cleanup thread ctor calls (master...200524-bind) https://github.com/bitcoin/bitcoin/pull/19064
< gribble> https://github.com/bitcoin/bitcoin/issues/19528 | rpc: Assert that RPCArg names are equal to CRPCCommand ones (misc) by MarcoFalke · Pull Request #19528 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jnewbery closed pull request #18876: [WIP] Serve BIP 157 compact filters (master...pr16442.3) https://github.com/bitcoin/bitcoin/pull/18876
< bitcoin-git> [bitcoin] hebasto opened pull request #19710: bench: Prevent thread oversubscription and decreases the variance of result values (master...200813-var) https://github.com/bitcoin/bitcoin/pull/19710
< bitcoin-git> [bitcoin] laanwj merged pull request #19070: p2p: Signal support for compact block filters with NODE_COMPACT_FILTERS (master...2020-05-node-compact-filters) https://github.com/bitcoin/bitcoin/pull/19070
< bitcoin-git> bitcoin/master f5c003d Jim Posen: [test] Add test for NODE_COMPACT_FILTER.
< bitcoin-git> bitcoin/master 132b30d Jim Posen: [net] Signal NODE_COMPACT_FILTERS if we're serving compact filters.
< bitcoin-git> bitcoin/master b3fbc94 John Newbery: Apply cfilters review fixups
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/6757b3ac8f67...b4d0366b47dd
< bitcoin-git> [bitcoin] hebasto opened pull request #19709: test: Fix 'make cov' with clang (master...200813-lcov) https://github.com/bitcoin/bitcoin/pull/19709
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #19707: net: Remove unused conn_type default arg in OpenNetworkConnection (master...1908-netDefault) https://github.com/bitcoin/bitcoin/pull/19707
< bitcoin-git> [bitcoin] laanwj merged pull request #19655: rpc: Catch listsinceblock target_confirmations exceeding block count (master...listsinceblock_rpc) https://github.com/bitcoin/bitcoin/pull/19655
< bitcoin-git> bitcoin/master 6757b3a Wladimir J. van der Laan: Merge #19655: rpc: Catch listsinceblock target_confirmations exceeding blo...
< bitcoin-git> bitcoin/master c133cdc Adam Stein: Cap listsinceblock target_confirmations param
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1052b09031c6...6757b3ac8f67
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #19011: Reduce cs_main lock accumulation during GUI startup (master...2020/05/guilocks) https://github.com/bitcoin/bitcoin/pull/19011
< bitcoin-git> bitcoin/master d42cb79 Jonas Schnelli: Optionally populate BlockAndHeaderTipInfo during AppInitMain
< bitcoin-git> bitcoin/master 25e1d0b Jonas Schnelli: RPCConsole, take initial chaintip data as parameter
< bitcoin-git> bitcoin/master b354a14 Jonas Schnelli: Add BlockAndHeaderTipInfo to the node interface/appInit
< bitcoin-git> [bitcoin] jonasschnelli pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/8a85377cd0b6...1052b09031c6
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13360: [Policy] Reject SIGHASH_SINGLE with output out of bound (master...insecure_single) https://github.com/bitcoin/bitcoin/pull/13360
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #16548: Make the global flag *fDiscover* an instance variable of CConnman (master...bitcoin_issue_14210) https://github.com/bitcoin/bitcoin/pull/16548
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19707: net: Remove unused conn_type default arg in OpenNetworkConnection (master...1908-netDefault) https://github.com/bitcoin/bitcoin/pull/19707
< bitcoin-git> [bitcoin] meshcollider merged pull request #18654: rpc: separate bumpfee's psbt creation function into psbtbumpfee (master...psbtbumpfee) https://github.com/bitcoin/bitcoin/pull/18654
< bitcoin-git> bitcoin/master 79d6332 Andrew Chow: moveonly: Fix indentation in bumpfee RPC
< bitcoin-git> bitcoin/master 431071c Andrew Chow: Hide bumpfee's psbt creation behavior behind -deprecatedrpc
< bitcoin-git> bitcoin/master 4638224 Andrew Chow: Add psbtbumpfee RPC
< bitcoin-git> [bitcoin] meshcollider pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/038a04eb80a5...8a85377cd0b6

2020-08-12

< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19688: build: Add support for llvm-cov (master...200808-lcov) https://github.com/bitcoin/bitcoin/pull/19688
< bitcoin-git> bitcoin/master 75f9659 Hennadii Stepanov: build: Add missed fuzz.coverage/ directory to .gitignore
< bitcoin-git> bitcoin/master 8ebc050 Hennadii Stepanov: build: Add missed fuzz_filtered.info to COVERAGE_INFO
< bitcoin-git> bitcoin/master c71bdf9 Hennadii Stepanov: build, test: Add support for llvm-cov
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/13c4635a3ecf...038a04eb80a5
< bitcoin-git> [bitcoin] laanwj merged pull request #19696: rpc: Fix addnode remove command error (master...rpc_net_tests) https://github.com/bitcoin/bitcoin/pull/19696
< bitcoin-git> bitcoin/master 13c4635 Wladimir J. van der Laan: Merge #19696: rpc: Fix addnode remove command error
< bitcoin-git> bitcoin/master a51d0ad Fabian Jahr: rpc: Improve addnode remove command error message
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bd00d3b1f203...13c4635a3ecf
< gribble> https://github.com/bitcoin/bitcoin/issues/19388 | Build fuzz tests by default · Issue #19388 · bitcoin/bitcoin · GitHub
< willcl_ark> troygiorshev: I did make a bit of progress on #19388 but could not get the linking working correctly at the end. If you have any ideas on this, my branch is here: https://github.com/willcl-ark/bitcoin/tree/default_fuzz_tests
< bitcoin-git> [bitcoin] achow101 closed pull request #19653: wallet: Replace -zapwallettxes with zapwallettxes RPC (master...zapwallettxes-rpc) https://github.com/bitcoin/bitcoin/pull/19653
< bitcoin-git> [bitcoin] theStack opened pull request #19706: refactor: make EncodeBase58{Check} consume Spans (master...20200810-util-make-base58encode-consume-spans) https://github.com/bitcoin/bitcoin/pull/19706
< bitcoin-git> [bitcoin] vasild opened pull request #19705: Shrink CAddress from 48 to 40 bytes on x64 (master...shrink_caddress) https://github.com/bitcoin/bitcoin/pull/19705
< bitcoin-git> [bitcoin] laanwj merged pull request #19658: [rpc] Allow RPC to fetch all addrman records and add records to addrman (master...2020-07-addrman-get) https://github.com/bitcoin/bitcoin/pull/19658
< bitcoin-git> bitcoin/master 37a480e John Newbery: [net] Add addpeeraddress RPC method
< bitcoin-git> bitcoin/master ae8051b John Newbery: [test] Test that getnodeaddresses() can return all known addresses
< bitcoin-git> bitcoin/master f26502e John Newbery: [addrman] Specify max addresses and pct when calling GetAddresses()
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/ce3bdd0ed1bb...bd00d3b1f203
< gribble> https://github.com/bitcoin/bitcoin/issues/19388 | Build fuzz tests by default · Issue #19388 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jnewbery opened pull request #19704: Net processing: move ProcessMessage() to PeerLogicValidation (master...2020-07-process-message-plv) https://github.com/bitcoin/bitcoin/pull/19704
< gribble> https://github.com/bitcoin/bitcoin/issues/19031 | Implement ADDRv2 support (part of BIP155) by vasild · Pull Request #19031 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19628 | net: change CNetAddr::ip to have flexible size by vasild · Pull Request #19628 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19455 | rpc generate: print useful help and error message by jonatack · Pull Request #19455 · bitcoin/bitcoin · GitHub
< jonatack> review beg for #19455 (which arguably should have been in the last release with -generate to make multiple bitcoin command line tutorials work again for users), as requested by ajonas and MarcoFalke. It's a quick review with complete test coverage.
< kallewoof> Signet pull request has been updated with ajtowns suggestions, and the network is up and running now. Please review! https://github.com/bitcoin/bitcoin/pull/18267
< luke-jr> #proposedmeetingtopic Can we recreate bitcoin-core/gui so GitHub will let us do PRs from the same <user>/bitcoin forks instead of making a new remote for everyone?
< gribble> https://github.com/bitcoin/bitcoin/issues/19528 | rpc: Assert that RPCArg names are equal to CRPCCommand ones (misc) by MarcoFalke · Pull Request #19528 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake merged pull request #19316: [net] Cleanup logic around connection types (master...2020-06-conn-refactor) https://github.com/bitcoin/bitcoin/pull/19316
< bitcoin-git> bitcoin/master 1521c47 Amiti Uttarwar: [net/refactor] Add manual connections to ConnectionType enum
< bitcoin-git> bitcoin/master 26304b4 Amiti Uttarwar: [net/refactor] Introduce an enum to distinguish type of connection
< bitcoin-git> bitcoin/master 3f1b714 Amiti Uttarwar: scripted-diff: Rename OneShot to AddrFetch
< bitcoin-git> [bitcoin] fanquake pushed 20 commits to master: https://github.com/bitcoin/bitcoin/compare/cb1ee1551cf3...ce3bdd0ed1bb
< bitcoin-git> [bitcoin] achow101 opened pull request #19700: wallet: Replace -zapwallettxes with wallet tool command (master...zapwallettxes-wallettool) https://github.com/bitcoin/bitcoin/pull/19700

2020-08-11

< bitcoin-git> [bitcoin] theStack closed pull request #18940: miner: fix off-by-ones in BlockAssembler::TestPackage (master...20200511-miner-fix-off-by-one-in-test-package) https://github.com/bitcoin/bitcoin/pull/18940
< gribble> https://github.com/bitcoin/bitcoin/issues/18654 | rpc: separate bumpfees psbt creation function into psbtbumpfee by achow101 · Pull Request #18654 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] gzhao408 opened pull request #19698: test: apply strict verification flags for transaction tests and assert backwards compatibility (master...test-verify-flags) https://github.com/bitcoin/bitcoin/pull/19698
< gribble> https://github.com/bitcoin/bitcoin/issues/19316 | [net] Cleanup logic around connection types by amitiuttarwar · Pull Request #19316 · bitcoin/bitcoin · GitHub
< adiabat> we got free google cloud credits to run some bitcoin tests / research, and they kept shutting our VPSs down
< phantomcircuit> just observe the traffic patterns, if you consistently see a spike in bandwidth after a block is found, then it's a bitcoin node
< phantomcircuit> adiabat, no even then you can trivially detect that it's a bitcoin node
< phantomcircuit> without significantly delaying block relay, it's impossible to hide that you're running a bitcoin node from the network operator
< phantomcircuit> adiabat, it has to be easy to identify a bitcoin node that's listening, and it's inherently going to be easy to identify a bitcoin node based on the network traffic
< jonatack> i'm running bitcoin locally with nLastBlockTime and nLastTXTime added to getpeerinfo for my peer connections dashboard
< jonatack> i was specifically trying to observe and figure out how to test https://github.com/bitcoin/bitcoin/issues/19500
< troygiorshev> certainly is difficult (i imagine) to distinguish between "this is a really clean PR and I really have no comments on it, it's RFM" and "I've done my best but I'm not familiar enough with bitcoin to really review this"
< aj> adiabat: i think the reason not to do other ports was to prevent bitcoin nodes being used as a primitive botnet that'll start connecting to arbitrary services (or to be mistaken for being part of a botnet if someone spams military.gov's rsh port as a thing to connect to for bitcoin p2p maybe. never been able to judge if that makes much sense these days