<bitcoin-git>
[bitcoin] ajtowns opened pull request #25174: net/net_processing: Add thread safety related annotations for CNode and Peer (master...202205-net-lock-annotations) https://github.com/bitcoin/bitcoin/pull/25174
<david-bakin>
Decl of CTxOut in transactionh shows it is a struct with a CAmount and a CScript - it serializes as one after the other. I think it would be clearer if the 2 fields were in fact serialized separately as it shows in BIP-341. That's in fact what I did in the unit tests I'm writing - see https://github.com/bitcoin/bitcoin/pull/25097/files#diff-21483d0e032747850208f21325b29cde89e9c1f
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #25168: refactor: Avoid passing params where not needed (master...2205-remove-bloat-🏮) https://github.com/bitcoin/bitcoin/pull/25168
<david-bakin>
I have a non-bitcoin-specific "process" question: If I get a suggestion in a PR that has actual code and the button "commit suggestion" and I press the button - how does that fix, committed in bitcoin/bitcoin, get back to my fork? Do I just do it manually (create a patch any apply it) or??
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #25157: Fix -rpcwait with -netinfo returning negative time durations (master...update-time-in-rpcwait-and-netinfo) https://github.com/bitcoin/bitcoin/pull/25157
<bitcoin-git>
[bitcoin] suhailsaqan opened pull request #25161: rpc: Put undocumented JSON failure mode behind a runtime flag (master...master) https://github.com/bitcoin/bitcoin/pull/25161
<achow101>
luke-jr: do you only see the segfaul with bitcoin-qt? and can you get it reliably?
<bitcoin-git>
[bitcoin] ishaanam opened pull request #25159: test: use `sendall` in wallet_taproot.py tests (master...wallet_taproot_sendall_fix) https://github.com/bitcoin/bitcoin/pull/25159
<bitcoin-git>
[bitcoin] brunoerg opened pull request #25158: rpc, wallet: add abandoned field for all categories of transaction in ListTransaction (master...2022-05-abandoned-listtransactions) https://github.com/bitcoin/bitcoin/pull/25158
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #25156: Disconnect block-relay-only peers with relay permission when they fill tx announcements (master...2205-block-relay-only-why-tx-inv-🤗) https://github.com/bitcoin/bitcoin/pull/25156
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #25153: scripted-diff: Use getIntT over get_int/get_int64 (master...2205-uni-int-🗝) https://github.com/bitcoin/bitcoin/pull/25153
<bitcoin-git>
[bitcoin] Empact closed pull request #24455: refactor: Split ArgsManager out of util/system (master...2022-03-util-args-manager) https://github.com/bitcoin/bitcoin/pull/24455
<bitcoin-git>
[bitcoin] Empact opened pull request #25152: refactor: Split util/system into exception, shell, and fs-specific files (master...2022-05-split-system) https://github.com/bitcoin/bitcoin/pull/25152
<david-bakin>
ok. here's a question I have about the bitcoin CR experience vs that I've experienced at companies: Is the line-by-line review not valued in general or is it just the unfortunate lack of reviewers + reviewer's time? IOW, I don't have the experience (yet) to do the "big picture" concept acks/nacks - but I _do_ know how to do close-reading of code for correctness. Is it worth doing?
<sipa>
There is a general philosophical divide on this among projects, but Bitcoin Core follows a very strong squash-before-merging policy.
<bitcoin-git>
[bitcoin] hebasto opened pull request #25149: refactor: Add thread safety annotation to `BanMan::SweepBanned()` (master...220516-bantsa) https://github.com/bitcoin/bitcoin/pull/25149
<bitcoin-git>
[bitcoin] achow101 merged pull request #25019: parse external signer master fp as bytes in ExternalSigner::SignTransaction (master...lower_master_fp_of_ext_signer_in_SignTransaction) https://github.com/bitcoin/bitcoin/pull/25019
<bitcoin-git>
bitcoin/master 91a42d6 Andrew Chow: Merge bitcoin/bitcoin#25019: parse external signer master fp as bytes in E...
<bitcoin-git>
bitcoin/master 2a22f03 avirgovi: parsing external signer master fingerprint string as bytes instead of cari...
<bitcoin-git>
[bitcoin] achow101 merged pull request #25088: Wallet: Ensure m_attaching_chain is set before registering for signals (master...fix_wallet_race_attachingbb) https://github.com/bitcoin/bitcoin/pull/25088
<bitcoin-git>
bitcoin/master 98f4db3 Andrew Chow: Merge bitcoin/bitcoin#25088: Wallet: Ensure m_attaching_chain is set befor...
<bitcoin-git>
bitcoin/master ba10b90 Luke Dashjr: Wallet: Ensure m_attaching_chain is set before registering for signals
<bitcoin-git>
[bitcoin] jnewbery opened pull request #25147: Net processing: follow ups to #20799 (removing support for v1 compact blocks) (master...20205_20799_follow_ups) https://github.com/bitcoin/bitcoin/pull/25147
<bitcoin-git>
[bitcoin] fanquake merged pull request #20799: net processing: Only support version 2 compact blocks (master...2020-12-remove-cmpctblock-v1) https://github.com/bitcoin/bitcoin/pull/20799
<bitcoin-git>
bitcoin/master 42882fc John Newbery: [net processing] Only accept `sendcmpct` with version=2
<bytes1440000>
luke-jr: let me rephrase: its not just consensus related code, bitcoin core can have bugs and vulnerabilities in different thing. Example: CVE-2018–20587
2022-05-15
<bytes1440000>
Bitcoin Core or any bitcoin implementation has lot of things that can be exploited with no soft fork. It can be p2p, mempool wallet, rpc etc. anything
<bytes1440000>
What does that have to do with mempool? Maybe you can read the pull requests that are open in bitcoin core repository related to mempool and discuss lightning
<bytes1440000>
fjahr:iiuc most of the people use 20f2 or 2of3 mutlsig in bitcoin based on https://mempool.observer/monitor/ and 2of2 is mostly used for lightning
<bytes1440000>
fjahr: I understand this channel is used for bitcoin core which is used by majority of bitcoin nodes. Sorry if it was off topic although context was taproot, above messages related to 2of2 multisig and PR #23789
<bytes1440000>
4. Jeremy Rubin made a good point in this comment: https://github.com/bitcoin/bitcoin/pull/23789#issuecomment-998303608 And the observability of this pattern (change matching) is also... pretty observable, especially if bitcoin core (and only upgraded wallets) are the ones doing it.”
<bitcoin-git>
[bitcoin] aureleoules closed pull request #25026: rpc: Make pruneblockchain fetch old blocks if height is lower than pruned height (master...2022-04-pruneblockchain-fetch-old-blocks) https://github.com/bitcoin/bitcoin/pull/25026
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #25117: test: Check msg type in msg capture is followed by zeros (master...2205-test-zero-🚛) https://github.com/bitcoin/bitcoin/pull/25117
<bitcoin-git>
bitcoin/master faa5a7a MacroFake: test: Check msg type in msg capture is followed by zeros
<bitcoin-git>
bitcoin/master 1d5325a MacroFake: Merge bitcoin/bitcoin#25117: test: Check msg type in msg capture is follow...
<bitcoin-git>
[bitcoin] fjahr opened pull request #25123: test: Use addconnection for robustness in index prune test (master...202205-index-prune-fix) https://github.com/bitcoin/bitcoin/pull/25123
<bitcoin-git>
[bitcoin] furszy opened pull request #25122: rpc: getreceivedbylabel, return early if no addresses were found in the address book. (master...2022_RPC_getreceivedbylabel_return_early) https://github.com/bitcoin/bitcoin/pull/25122
<bitcoin-git>
[bitcoin] brunoerg opened pull request #25121: test: compare `/mempool/info` response with `getmempoolinfo` RPC (master...2022-05-rest-mempool-info) https://github.com/bitcoin/bitcoin/pull/25121
<gribble>
https://github.com/bitcoin/bitcoin/issues/22954 | [TESTS] Allow tx_invalid.json tests to include flag rules for if_unset: [A,B,C] then_unset: [D] by JeremyRubin · Pull Request #22954 · bitcoin/bitcoin · GitHub
<gribble>
https://github.com/bitcoin/bitcoin/issues/22876 | [TESTS] Update Transaction Tests to permit setting a flag as always on and disabling the exhaustive failure test by JeremyRubin · Pull Request #22876 · bitcoin/bitcoin · GitHub