2022-05-20

<bitcoin-git> bitcoin/master fa4ee53 MacroFake: Do not pass time getter to Chainstate helpers
<bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/8c61374ba782...4d0c00dffd13
<bitcoin-git> [bitcoin] hebasto opened pull request #25175: refactor: Improve thread safety analysis by propagating some negative capabilities (master...220520-nega) https://github.com/bitcoin/bitcoin/pull/25175
<bitcoin-git> [gui] hebasto merged pull request #581: refactor: Revamp `ClientModel` code to handle core signals (master...220410-invoke) https://github.com/bitcoin-core/gui/pull/581
<hebasto> has bitcoin-git bot just got another holiday?
<bitcoin-git> bitcoin/master 8118970 Hennadii Stepanov: Merge bitcoin-core/gui#594: scripted-diff: replace deprecated Q_OS_MAC wit...
<bitcoin-git> bitcoin/master e3daeca João Barbosa: scripted-diff: replace deprecated Q_OS_MAC with Q_OS_MACOS
<bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0cd1a2eff9e0...8118970c869f
<bitcoin-git> [gui] hebasto merged pull request #594: scripted-diff: replace deprecated Q_OS_MAC with Q_OS_MACOS (master...q_os_macos) https://github.com/bitcoin-core/gui/pull/594
<bitcoin-git> [bitcoin] laanwj merged pull request #23595: util: Add ParseHexstd::byte() helper (master...2111-utilHexByte) https://github.com/bitcoin/bitcoin/pull/23595
<bitcoin-git> bitcoin/master facd1fb MarcoFalke: refactor: Use Span of std::byte in CExtKey::SetSeed
<bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/a7e3afb22136...0cd1a2eff9e0
<bitcoin-git> bitcoin/master fabdf81 MarcoFalke: test: Add test for embedded null in hex string
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25171: rpc: wallet: remove `-deprecatedrpc=exclude_coinbase` logic (master...202205-rpc-remove_deprecated_include_coinbase_option) https://github.com/bitcoin/bitcoin/pull/25171
<bitcoin-git> bitcoin/master a7e3afb MacroFake: Merge bitcoin/bitcoin#25171: rpc: wallet: remove `-deprecatedrpc=exclude_c...
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/a39002e0c642...a7e3afb22136
<bitcoin-git> bitcoin/master a4703ce Sebastian Falbesoner: doc: add release notes about removal of the `deprecatedrpc=exclude_coinbas...
<bitcoin-git> bitcoin/master ef0aa74 Sebastian Falbesoner: rpc: wallet: remove `-deprecatedrpc=exclude_coinbase` logic
<gribble> https://github.com/bitcoin/bitcoin/issues/24150 | refactor: move index class members from protected to private by jonatack · Pull Request #24150 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] fanquake merged pull request #25170: build: Enable RPC_DOC_CHECK on --enable-debug (master...2205-enable-rpc-doc-check-on-debug-🗿) https://github.com/bitcoin/bitcoin/pull/25170
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4a8709821e64...a39002e0c642
<bitcoin-git> bitcoin/master fafae67 MacroFake: build: Enable RPC_DOC_CHECK on --enable-debug
<bitcoin-git> bitcoin/master a39002e fanquake: Merge bitcoin/bitcoin#25170: build: Enable RPC_DOC_CHECK on --enable-debug
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24830: init: Allow -proxy="" setting values (master...pr/proxy) https://github.com/bitcoin/bitcoin/pull/24830
<bitcoin-git> bitcoin/master 4a87098 MacroFake: Merge bitcoin/bitcoin#24830: init: Allow -proxy="" setting values
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d433f59f1eb8...4a8709821e64
<bitcoin-git> bitcoin/master 1d4122d Ryan Ofsky: init: Allow -proxy="" setting values
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25173: test: add coverage for unknown network in -onlynet (master...2022-05-unknown-onlynet) https://github.com/bitcoin/bitcoin/pull/25173
<bitcoin-git> bitcoin/master d433f59 MacroFake: Merge bitcoin/bitcoin#25173: test: add coverage for unknown network in -on...
<bitcoin-git> bitcoin/master 055d94d brunoerg: test: add coverage for unknown network in -onlynet
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6407c0e8a33f...d433f59f1eb8
<gribble> https://github.com/bitcoin/bitcoin/issues/25120 | test: fix DWARF string_view linker error in blockfilter_tests by jonatack · Pull Request #25120 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] fanquake merged pull request #25101: Add mockable clock type (master...2205-mock-clock-😃) https://github.com/bitcoin/bitcoin/pull/25101
<bitcoin-git> bitcoin/master 6407c0e fanquake: Merge bitcoin/bitcoin#25101: Add mockable clock type
<bitcoin-git> bitcoin/master fa305fd MarcoFalke: Add mockable clock type and TicksSinceEpoch helper
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0de36941eca1...6407c0e8a33f

2022-05-19

<bitcoin-git> [bitcoin] ajtowns opened pull request #25174: net/net_processing: Add thread safety related annotations for CNode and Peer (master...202205-net-lock-annotations) https://github.com/bitcoin/bitcoin/pull/25174
<gribble> https://github.com/bitcoin/bitcoin/issues/25153 | scripted-diff: Use getInt over get_int/get_int64 by MarcoFalke · Pull Request #25153 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/24410 | [kernel 2a/n] Split hashing/index `GetUTXOStats` codepaths, decouple from `coinstatsindex` by dongcarl · Pull Request #24410 · bitcoin/bitcoin · GitHub
<dongcarl> libbitcoinkernel #24410 reviewers: I would love feedback on this: https://github.com/bitcoin/bitcoin/pull/24410#issuecomment-1132161124
<bitcoin-git> [gui] ryanofsky opened pull request #602: Unify bitcoin-qt and bitcoind persistent settings #15936 (master...pr/qtsopt) https://github.com/bitcoin-core/gui/pull/602
<bitcoin-git> [bitcoin] brunoerg opened pull request #25173: test: add coverage for unknown network in -onlynet (master...2022-05-unknown-onlynet) https://github.com/bitcoin/bitcoin/pull/25173
<bitcoin-git> [gui] ryanofsky opened pull request #601: refactor: Pass interfaces::Node references to OptionsModel constructor (master...pr/qtnode) https://github.com/bitcoin-core/gui/pull/601
<bitcoin-git> [gui] ryanofsky opened pull request #600: refactor: Add OptionsModel getOption/setOption methods (master...pr/qtopt) https://github.com/bitcoin-core/gui/pull/600
<core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
<gribble> https://github.com/bitcoin/bitcoin/issues/23595 | util: Add ParseHex () helper by MarcoFalke · Pull Request #23595 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/22702 | Add allocator for node based containers by martinus · Pull Request #22702 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/23443 | p2p: Erlay support signaling by naumenkogs · Pull Request #23443 · bitcoin/bitcoin · GitHub
<laanwj> there's currently 12 blockers and 2 chasing concept ACK in https://github.com/bitcoin/bitcoin/projects/8
<laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard b10c BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo
<core-meetingbot> Meeting started Thu May 19 19:00:00 2022 UTC. The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
<david-bakin> Decl of CTxOut in transactionh shows it is a struct with a CAmount and a CScript - it serializes as one after the other. I think it would be clearer if the 2 fields were in fact serialized separately as it shows in BIP-341. That's in fact what I did in the unit tests I'm writing - see https://github.com/bitcoin/bitcoin/pull/25097/files#diff-21483d0e032747850208f21325b29cde89e9c1f
<bitcoin-git> [bitcoin] fanquake opened pull request #25172: refactor: use std:: for mem*( funcs (master...use_std_variants) https://github.com/bitcoin/bitcoin/pull/25172
<bitcoin-git> [bitcoin] fanquake merged pull request #25153: scripted-diff: Use getIntT over get_int/get_int64 (master...2205-uni-int-🗝) https://github.com/bitcoin/bitcoin/pull/25153
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e18fd4763e77...0de36941eca1
<bitcoin-git> [bitcoin] theStack opened pull request #25171: rpc: wallet: remove `-deprecatedrpc=exclude_coinbase` logic (master...202205-rpc-remove_deprecated_include_coinbase_option) https://github.com/bitcoin/bitcoin/pull/25171
<bitcoin-git> [bitcoin] fanquake merged pull request #25074: index: During sync, commit best block after indexing (master...202205_index_sync_order) https://github.com/bitcoin/bitcoin/pull/25074
<bitcoin-git> bitcoin/master e18fd47 fanquake: Merge bitcoin/bitcoin#25074: index: During sync, commit best block after i...
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/345d860f3818...e18fd4763e77
<bitcoin-git> bitcoin/master 7171ebc Martin Zumsande: index: Don't commit a best block before indexing it during sync
<bitcoin-git> [bitcoin] sdaftuar closed pull request #20726: p2p: Add DISABLETX message for negotiating block-relay-only connections (master...2020-12-negotiate-block-relay) https://github.com/bitcoin/bitcoin/pull/20726
<bitcoin-git> [bitcoin] fanquake merged pull request #25166: doc: Add link to NetBSD release (master...NetBSD-release-link) https://github.com/bitcoin/bitcoin/pull/25166
<bitcoin-git> bitcoin/master 174f58c Marnix: Add link to NetBSD release
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fdb82a30bed2...345d860f3818
<bitcoin-git> bitcoin/master 345d860 fanquake: Merge bitcoin/bitcoin#25166: doc: Add link to NetBSD release
<bitcoin-git> [bitcoin] fanquake merged pull request #25147: Net processing: follow ups to #20799 (removing support for v1 compact blocks) (master...20205_20799_follow_ups) https://github.com/bitcoin/bitcoin/pull/25147
<bitcoin-git> bitcoin/master fdb82a3 fanquake: Merge bitcoin/bitcoin#25147: Net processing: follow ups to #20799 (removin...
<bitcoin-git> bitcoin/master bf6526f John Newbery: [test] Remove segwit argument from build_block_on_tip()
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/986bae8e7248...fdb82a30bed2
<bitcoin-git> bitcoin/master c65bf50 John Newbery: Remove fUseWTXID parameter from CBlockHeaderAndShortTxIDs constructor
<bitcoin-git> [bitcoin] fanquake merged pull request #22778: net processing: Reduce resource usage for inbound block-relay-only connections (master...2021-02-tx-relay-init) https://github.com/bitcoin/bitcoin/pull/22778
<bitcoin-git> bitcoin/master 42e3250 John Newbery: [net processing] [refactor] Move m_next_send_feefilter and m_fee_filter_se...
<bitcoin-git> bitcoin/master 290a8da John Newbery: [net processing] Comment all TxRelay members
<bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/bb83aba6c98b...986bae8e7248
<bitcoin-git> bitcoin/master b0a4ac9 John Newbery: [net processing] Add m_tx_relay_mutex to protect m_tx_relay ptr
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25170: build: Enable RPC_DOC_CHECK on --enable-debug (master...2205-enable-rpc-doc-check-on-debug-🗿) https://github.com/bitcoin/bitcoin/pull/25170
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25161: rpc: Put undocumented JSON failure mode behind a runtime flag (master...master) https://github.com/bitcoin/bitcoin/pull/25161
<bitcoin-git> bitcoin/master b953ea6 Suhail Saqan: rpc: Put undocumented JSON failure mode behind a runtime flag
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7b3343f3009d...bb83aba6c98b
<bitcoin-git> bitcoin/master bb83aba MacroFake: Merge bitcoin/bitcoin#25161: rpc: Put undocumented JSON failure mode behin...

2022-05-18

<bitcoin-git> [bitcoin] hebasto opened pull request #25169: guix: Simplify code for Linux builds (master...220518-inputs) https://github.com/bitcoin/bitcoin/pull/25169
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25108: tidy: add modernize-use-default-member-init (master...modernize_use_default_Member_init) https://github.com/bitcoin/bitcoin/pull/25108
<bitcoin-git> bitcoin/master 7b3343f MacroFake: Merge bitcoin/bitcoin#25108: tidy: add modernize-use-default-member-init
<bitcoin-git> bitcoin/master ac6fbf2 fanquake: tidy: use modernize-use-default-member-init
<bitcoin-git> bitcoin/master 7aa40f5 fanquake: refactor: use C++11 default initializers
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/e016c00e98b8...7b3343f3009d
<dhruv> jonatack: that seems to imply i need access to the crash-* file. and CI doesn't seem to be commiting the crash seed to here? https://github.com/bitcoin-core/qa-assets/tree/main/fuzz_seed_corpus Am I missing something?
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25126: test: add BIP157 message parsing support (via MESSAGEMAP) (master...202205-test-support_BIP157_deser_via_messagemap) https://github.com/bitcoin/bitcoin/pull/25126
<bitcoin-git> bitcoin/master 5dc6d92 Sebastian Falbesoner: test: make BIP157 messages default-constructible (MESSAGEMAP compatibility)
<bitcoin-git> bitcoin/master e016c00 MacroFake: Merge bitcoin/bitcoin#25126: test: add BIP157 message parsing support (via...
<bitcoin-git> bitcoin/master 71e4cfe Sebastian Falbesoner: test: p2p: add missing BIP157 message types to MESSAGEMAP
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/002411dc5375...e016c00e98b8
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25168: refactor: Avoid passing params where not needed (master...2205-remove-bloat-🏮) https://github.com/bitcoin/bitcoin/pull/25168
<david-bakin> I have a non-bitcoin-specific "process" question: If I get a suggestion in a PR that has actual code and the button "commit suggestion" and I press the button - how does that fix, committed in bitcoin/bitcoin, get back to my fork? Do I just do it manually (create a patch any apply it) or??
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25157: Fix -rpcwait with -netinfo returning negative time durations (master...update-time-in-rpcwait-and-netinfo) https://github.com/bitcoin/bitcoin/pull/25157
<bitcoin-git> bitcoin/master 002411d MacroFake: Merge bitcoin/bitcoin#25157: Fix -rpcwait with -netinfo returning negative...
<bitcoin-git> bitcoin/master 3a998d2 Jon Atack: Use steady_clock in ConnectAndCallRPC and inline time call in loop conditi...
<bitcoin-git> bitcoin/master 3799d2d Jon Atack: Fix -rpcwait with -netinfo printing negative time durations
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/629e250cbdee...002411dc5375
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25148: refactor: Remove `NO_THREAD_SAFETY_ANALYSIS` from non-test/benchmarking code (master...220516-todo) https://github.com/bitcoin/bitcoin/pull/25148
<bitcoin-git> bitcoin/master a55db4e Hennadii Stepanov: Add more proper thread safety annotations
<bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/139f789d7a9f...629e250cbdee
<bitcoin-git> bitcoin/master ca446f2 Hennadii Stepanov: Add proper thread safety annotation to `CachedTxGetAvailableCredit()`
<bitcoin-git> bitcoin/master 8cfe93e Hennadii Stepanov: Add proper thread safety annotation to `CWallet::GetTxConflicts()`
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25124: test: Fix intermittent race in p2p_unrequested_blocks.py (master...2205-test-race-📦) https://github.com/bitcoin/bitcoin/pull/25124
<bitcoin-git> bitcoin/master 139f789 MacroFake: Merge bitcoin/bitcoin#25124: test: Fix intermittent race in p2p_unrequeste...
<bitcoin-git> bitcoin/master faac67c MacroFake: test: Fix intermittent race in p2p_unrequested_blocks.py
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/84bf31f8e984...139f789d7a9f
<bitcoin-git> [bitcoin] MarnixCroes opened pull request #25166: doc: Add link to NetBSD release (master...NetBSD-release-link) https://github.com/bitcoin/bitcoin/pull/25166
<bitcoin-git> [bitcoin] fanquake merged pull request #25076: guix: native GCC 10 toolchain for Linux builds (master...native_gcc_10_linux) https://github.com/bitcoin/bitcoin/pull/25076
<bitcoin-git> bitcoin/master 0e51913 fanquake: guix: fix glibc 2.27 multiple definition warnings with GCC 10
<bitcoin-git> bitcoin/master 508bd4d fanquake: guix: adjust RISC-V __has_include() patch to work with GCC 10
<bitcoin-git> bitcoin/master c9c5b30 fanquake: guix: compile glibc without -werror
<bitcoin-git> [bitcoin] fanquake pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/f7a1e676d536...84bf31f8e984
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25165: doc: Explain squashing with merge commits (master...2205-doc-squash-🐾) https://github.com/bitcoin/bitcoin/pull/25165
<bitcoin-git> [bitcoin] fanquake closed pull request #25162: metadata.xmp (master...Apache-2.0) https://github.com/bitcoin/bitcoin/pull/25162
<gribble> https://github.com/bitcoin/bitcoin/issues/25082 | Guix build w/o substitutes failing at libgit2 check · Issue #25082 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] WikiExchange opened pull request #25162: metadata.xmp (master...Apache-2.0) https://github.com/bitcoin/bitcoin/pull/25162

2022-05-17

<bitcoin-git> [bitcoin] achow101 merged pull request #25159: test: use `sendall` in wallet_taproot.py tests (master...wallet_taproot_sendall_fix) https://github.com/bitcoin/bitcoin/pull/25159
<bitcoin-git> bitcoin/master f7a1e67 Andrew Chow: Merge bitcoin/bitcoin#25159: test: use `sendall` in wallet_taproot.py tests
<bitcoin-git> bitcoin/master c6122f5 ishaanam: test: use sendall in wallet_taproot.py tests
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d5d40d59f8d1...f7a1e676d536
<bitcoin-git> [bitcoin] suhailsaqan opened pull request #25161: rpc: Put undocumented JSON failure mode behind a runtime flag (master...master) https://github.com/bitcoin/bitcoin/pull/25161
<achow101> if you comment out https://github.com/bitcoin/bitcoin/blob/master/src/qt/splashscreen.cpp#L205, does it still segfault?
<luke-jr> maybe running bitcoin-qt as another user?
<hebasto> luke-jr: it is not obvious that bug exist, in first place -- https://github.com/bitcoin-core/gui/pull/152#issuecomment-757524350
<bitcoin-git> [bitcoin] hebasto opened pull request #25160: ci: Add "macOS 12 native Apple Silicon" task (master...220517-ci) https://github.com/bitcoin/bitcoin/pull/25160
<achow101> luke-jr: do you only see the segfaul with bitcoin-qt? and can you get it reliably?
<bitcoin-git> [bitcoin] ishaanam opened pull request #25159: test: use `sendall` in wallet_taproot.py tests (master...wallet_taproot_sendall_fix) https://github.com/bitcoin/bitcoin/pull/25159
<gribble> https://github.com/bitcoin/bitcoin/issues/24531 | Use designated initializers by MarcoFalke · Pull Request #24531 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/24531 | Use designated initializers by MarcoFalke · Pull Request #24531 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] brunoerg opened pull request #25158: rpc, wallet: add abandoned field for all categories of transaction in ListTransaction (master...2022-05-abandoned-listtransactions) https://github.com/bitcoin/bitcoin/pull/25158
<bitcoin-git> [bitcoin] fanquake merged pull request #23679: Sanitize `port` in `addpeeraddress()` (master...sanitize_port_rpc) https://github.com/bitcoin/bitcoin/pull/23679
<bitcoin-git> bitcoin/master d5d40d5 fanquake: Merge bitcoin/bitcoin#23679: Sanitize `port` in `addpeeraddress()`
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/dd8a2df488f6...d5d40d59f8d1
<bitcoin-git> bitcoin/master ada8358 amadeuszpawlik: Sanitize port in `addpeeraddress()`
<bitcoin-git> [bitcoin] fanquake merged pull request #25107: bench: Add `--sanity-check` flag, use it in `make check` (master...2022-05-bench-one-iteration) https://github.com/bitcoin/bitcoin/pull/25107
<bitcoin-git> bitcoin/master dd8a2df fanquake: Merge bitcoin/bitcoin#25107: bench: Add `--sanity-check` flag, use it in `...
<bitcoin-git> bitcoin/master 652b54e laanwj: bench: Add `--sanity-check` flag, use it in `make check`
<bitcoin-git> bitcoin/master 4f31c21 laanwj: bench: Make all arguments -kebab-case
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1ab389b1bac1...dd8a2df488f6
<gribble> https://github.com/bitcoin/bitcoin/issues/24531 | Use designated initializers by MarcoFalke · Pull Request #24531 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] jonatack opened pull request #25157: Fix -rpcwait with -netinfo returning negative time durations (master...update-time-in-rpcwait-and-netinfo) https://github.com/bitcoin/bitcoin/pull/25157
<bitcoin-git> [bitcoin] jonatack closed pull request #25155: GetTimeSeconds() removal followups (master...GetTimeSeconds-removal-followups) https://github.com/bitcoin/bitcoin/pull/25155
<jamesob> sorry, have been out of IRC for a bit; are we not using designated initializers anymore? https://github.com/bitcoin/bitcoin/pull/25064#issuecomment-1127842628
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25156: Disconnect block-relay-only peers with relay permission when they fill tx announcements (master...2205-block-relay-only-why-tx-inv-🤗) https://github.com/bitcoin/bitcoin/pull/25156
<bitcoin-git> [bitcoin] jonatack opened pull request #25155: GetTimeSeconds() removal followups (master...GetTimeSeconds-removal-followups) https://github.com/bitcoin/bitcoin/pull/25155
<jonatack> david-bakin: i agree, some things can be different coming from companies or other open source projects. if helpful wrote a few articles about it at https://jonatack.github.io/articles, perhaps the most useful one is https://jonatack.github.io/articles/how-to-review-pull-requests-in-bitcoin-core
<bitcoin-git> [bitcoin] fanquake merged pull request #20640: wallet, refactor: return out-params of CreateTransaction() as optional struct (master...202012-refactor-wallet-createtransaction-return_out_params_in_optstruct) https://github.com/bitcoin/bitcoin/pull/20640
<bitcoin-git> bitcoin/master 1ab389b fanquake: Merge bitcoin/bitcoin#20640: wallet, refactor: return out-params of Create...
<bitcoin-git> bitcoin/master c9fdaa5 Sebastian Falbesoner: wallet: CreateTransactionInternal(): return out-params as (optional) struct
<bitcoin-git> bitcoin/master 4c5ceb0 Sebastian Falbesoner: wallet: CreateTransaction(): return out-params as (optional) struct
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/0be1dc1f56f6...1ab389b1bac1
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25153: scripted-diff: Use getIntT over get_int/get_int64 (master...2205-uni-int-🗝) https://github.com/bitcoin/bitcoin/pull/25153
<bitcoin-git> [bitcoin] Empact closed pull request #24455: refactor: Split ArgsManager out of util/system (master...2022-03-util-args-manager) https://github.com/bitcoin/bitcoin/pull/24455
<bitcoin-git> [bitcoin] Empact opened pull request #25152: refactor: Split util/system into exception, shell, and fs-specific files (master...2022-05-split-system) https://github.com/bitcoin/bitcoin/pull/25152
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24062: refactor: replace RecursiveMutex `m_most_recent_block_mutex` with Mutex (master...202201-refactor_replace_recursive_mutex_cs_last_block) https://github.com/bitcoin/bitcoin/pull/24062
<bitcoin-git> bitcoin/master 83003ff Sebastian Falbesoner: refactor: replace RecursiveMutex `m_most_recent_block_mutex` with Mutex
<bitcoin-git> bitcoin/master 0be1dc1 MacroFake: Merge bitcoin/bitcoin#24062: refactor: replace RecursiveMutex `m_most_rece...
<bitcoin-git> bitcoin/master 8edd0d3 Sebastian Falbesoner: refactor: reduce scope of lock `m_most_recent_block_mutex`
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/8270740befa3...0be1dc1f56f6
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25114: rpc: remove deprecated "softforks" field from getblockchaininfo (master...202205-rpc-remove_deprecated_softforks_from_getblockchaininfo) https://github.com/bitcoin/bitcoin/pull/25114
<bitcoin-git> bitcoin/master a01b92a Sebastian Falbesoner: doc: add release notes about removal of the `deprecatedrpc=softforks` flag
<bitcoin-git> bitcoin/master 8c5533c Sebastian Falbesoner: rpc: remove deprecated "softforks" field from getblockchaininfo
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/91a42d63efaf...8270740befa3
<bitcoin-git> bitcoin/master 8270740 MacroFake: Merge bitcoin/bitcoin#25114: rpc: remove deprecated "softforks" field from...

2022-05-16

<david-bakin> ok. here's a question I have about the bitcoin CR experience vs that I've experienced at companies: Is the line-by-line review not valued in general or is it just the unfortunate lack of reviewers + reviewer's time? IOW, I don't have the experience (yet) to do the "big picture" concept acks/nacks - but I _do_ know how to do close-reading of code for correctness. Is it worth doing?
<sipa> There is a general philosophical divide on this among projects, but Bitcoin Core follows a very strong squash-before-merging policy.
<bitcoin-git> [bitcoin] hebasto opened pull request #25149: refactor: Add thread safety annotation to `BanMan::SweepBanned()` (master...220516-bantsa) https://github.com/bitcoin/bitcoin/pull/25149
<bitcoin-git> [bitcoin] achow101 merged pull request #25019: parse external signer master fp as bytes in ExternalSigner::SignTransaction (master...lower_master_fp_of_ext_signer_in_SignTransaction) https://github.com/bitcoin/bitcoin/pull/25019
<bitcoin-git> bitcoin/master 91a42d6 Andrew Chow: Merge bitcoin/bitcoin#25019: parse external signer master fp as bytes in E...
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/98f4db33056b...91a42d63efaf
<bitcoin-git> bitcoin/master 2a22f03 avirgovi: parsing external signer master fingerprint string as bytes instead of cari...
<bitcoin-git> [bitcoin] achow101 merged pull request #25088: Wallet: Ensure m_attaching_chain is set before registering for signals (master...fix_wallet_race_attachingbb) https://github.com/bitcoin/bitcoin/pull/25088
<bitcoin-git> bitcoin/master 98f4db3 Andrew Chow: Merge bitcoin/bitcoin#25088: Wallet: Ensure m_attaching_chain is set befor...
<bitcoin-git> bitcoin/master ba10b90 Luke Dashjr: Wallet: Ensure m_attaching_chain is set before registering for signals
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/187504b038cc...98f4db33056b
<bitcoin-git> [bitcoin] hebasto opened pull request #25148: refactor: Remove `NO_THREAD_SAFETY_ANALYSIS` from non-test/benchmarking code (master...220516-todo) https://github.com/bitcoin/bitcoin/pull/25148
<bitcoin-git> [bitcoin] achow101 merged pull request #23662: rpc: improve `getreceivedby{address,label}` performance (master...202112-rpc-improve_getreceivedby_performance) https://github.com/bitcoin/bitcoin/pull/23662
<bitcoin-git> bitcoin/master 187504b Andrew Chow: Merge bitcoin/bitcoin#23662: rpc: improve `getreceivedby{address,label}` p...
<bitcoin-git> bitcoin/master f336ff7 Sebastian Falbesoner: rpc: avoid expensive `IsMine` calls in `GetReceived` tally
<bitcoin-git> bitcoin/master a7b65af Sebastian Falbesoner: rpc: avoid scriptPubKeyCTxDestination conversions in `GetReceived` tally
<bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/07cb4dee5d12...187504b038cc
<bitcoin-git> [bitcoin] jnewbery opened pull request #25147: Net processing: follow ups to #20799 (removing support for v1 compact blocks) (master...20205_20799_follow_ups) https://github.com/bitcoin/bitcoin/pull/25147
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24962: prevector: enforce is_trivially_copyable_v (master...2022-04_prevector_fixes) https://github.com/bitcoin/bitcoin/pull/24962
<bitcoin-git> bitcoin/master 07cb4de MacroFake: Merge bitcoin/bitcoin#24962: prevector: enforce is_trivially_copyable_v
<bitcoin-git> bitcoin/master 11e7908 Martin Leitner-Ankerl: prevector: only allow trivially copyable types
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6b87fa540c40...07cb4dee5d12
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25144: refactor: Pass Peer& to Misbehaving() (master...2205-mis-peer-🛥) https://github.com/bitcoin/bitcoin/pull/25144
<bitcoin-git> [bitcoin] fanquake merged pull request #25125: test: Slim down versionbits_tests.cpp (master...2205-test-slim-🍄) https://github.com/bitcoin/bitcoin/pull/25125
<bitcoin-git> bitcoin/master fae3200 MacroFake: test: Slim down versionbits_tests.cpp
<bitcoin-git> bitcoin/master 6b87fa5 fanquake: Merge bitcoin/bitcoin#25125: test: Slim down versionbits_tests.cpp
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b019cdc03634...6b87fa540c40
<bitcoin-git> [bitcoin] fanquake merged pull request #25095: rpc: Fix implicit-integer-sign-change in gettxout (master...2205-rpc-int-ubsan-😛) https://github.com/bitcoin/bitcoin/pull/25095
<bitcoin-git> bitcoin/master fa347a9 MacroFake: rpc: Fix implicit-integer-sign-change in gettxout
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/aa3200d89672...b019cdc03634
<bitcoin-git> bitcoin/master b019cdc fanquake: Merge bitcoin/bitcoin#25095: rpc: Fix implicit-integer-sign-change in gett...
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25109: Strengthen AssertLockNotHeld assertions (master...202205-neg-anno-assertnotheld-only) https://github.com/bitcoin/bitcoin/pull/25109
<bitcoin-git> bitcoin/master aa3200d MacroFake: Merge bitcoin/bitcoin#25109: Strengthen AssertLockNotHeld assertions
<bitcoin-git> bitcoin/master 7d73f58 Anthony Towns: Increase threadsafety annotation coverage
<bitcoin-git> bitcoin/master 436ce02 Anthony Towns: sync.h: strengthen AssertLockNotHeld assertion
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/dc0ee573734e...aa3200d89672
<bitcoin-git> [bitcoin] fanquake merged pull request #20799: net processing: Only support version 2 compact blocks (master...2020-12-remove-cmpctblock-v1) https://github.com/bitcoin/bitcoin/pull/20799
<bitcoin-git> bitcoin/master 42882fc John Newbery: [net processing] Only accept `sendcmpct` with version=2
<bitcoin-git> [bitcoin] fanquake pushed 12 commits to master: https://github.com/bitcoin/bitcoin/compare/1511c9efb405...dc0ee573734e
<bitcoin-git> bitcoin/master 16730b6 John Newbery: [net processing] Only advertise support for version 2 compact blocks
<bitcoin-git> bitcoin/master cba909e John Newbery: [net] Stop testing version 1 compact blocks.
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24640: Bugfix: RPC/blockchain: Correct description of getblockchaininfo's pruneheight result (master...fix_rpcdoc_gbci_pruneheight_desc) https://github.com/bitcoin/bitcoin/pull/24640
<bitcoin-git> bitcoin/master 06822f8 Luke Dashjr: Bugfix: RPC/blockchain: Correct description of getblockchaininfo's prunehe...
<bitcoin-git> bitcoin/master 1511c9e MacroFake: Merge bitcoin/bitcoin#24640: Bugfix: RPC/blockchain: Correct description o...
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/195df1eb883d...1511c9efb405
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25067: validationinterface: make MainSignalsInstance() a class, drop unused forward declarations (master...make-MainSignalsInstance-a-class-and-move-to-header-file) https://github.com/bitcoin/bitcoin/pull/25067
<bitcoin-git> bitcoin/master 2aaec23 Jon Atack: refactor: remove unused forward declarations in validationinterface.h
<bitcoin-git> bitcoin/master ca1ac1f Jon Atack: scripted-diff: Rename MainSignalsInstance() class to MainSignalsImpl()
<bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/bc2eee72672a...195df1eb883d
<bitcoin-git> bitcoin/master 23854f8 Jon Atack: refactor: make MainSignalsInstance() a class
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25092: doc: various developer notes updates (master...developer-notes-updates-may-2022) https://github.com/bitcoin/bitcoin/pull/25092
<bitcoin-git> bitcoin/master 370120e Jon Atack: Remove obsolete BDB ENABLE_WALLET section in developer notes
<bitcoin-git> bitcoin/master fc4cb85 Jon Atack: Prefer Python for scripts in developer notes
<bitcoin-git> bitcoin/master 5fca70f Jon Atack: Link in developer notes style to internal interface exception
<bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/b74a6dde8cf5...bc2eee72672a
<bitcoin-git> [bitcoin] lazvegas13 closed pull request #25142: 23.x { "name": "BTC.main", "height": 736585, "hash": "000000000000000000047453805dff15189b57656fe1ada8de603a91e75c4ec6", "time": "2022-05-16T06:06:57.885107912Z", "latest_url": "https://api.blockcypher.com/v1/btc/main/blocks/000000000000000000047453805dff15189b57656fe1ada8de603a91e75c4ec6", "previous_hash":
<bitcoin-git> "000000000000000000073bdb952221c3f22b621cb58c37d0f90f7c51d7c31276", "previous_url": "https://api.blockcypher.com/v1/btc/main/blocks/000000000000000000073bdb952221c3f22b621cb58c37d0f90f7c51d7c31276", "peer_count": 1044, "unconfirmed_count": 6340, "high_fee_per_kb": 18934, "medium_fee_per_kb": 10318, "low_fee_per_kb": 6520, "last_fork_height": 723102, "last_fork_hash":
<bitcoin-git> "00000000000000000006a970fdd8e537521747aff917d909bf3a78b4b68143e1" } (master...23.x) https://github.com/bitcoin/bitcoin/pull/25142
<bitcoin-git> "000000000000000000073bdb952221c3f22b621cb58c37d0f90f7c51d7c31276", "previous_url": "https://api.blockcypher.com/v1/btc/main/blocks/000000000000000000073bdb952221c3f22b621cb58c37d0f90f7c51d7c31276", "peer_count": 1044, "unconfirmed_count": 6340, "high_fee_per_kb": 18934, "medium_fee_per_kb": 10318, "low_fee_per_kb": 6520, "last_fork_height": 723102, "last_fork_hash":
<bitcoin-git> "00000000000000000006a970fdd8e537521747aff917d909bf3a78b4b68143e1" } (master...23.x) https://github.com/bitcoin/bitcoin/pull/25142
<bitcoin-git> [bitcoin] lazvegas13 opened pull request #25142: 23.x { "name": "BTC.main", "height": 736585, "hash": "000000000000000000047453805dff15189b57656fe1ada8de603a91e75c4ec6", "time": "2022-05-16T06:06:57.885107912Z", "latest_url": "https://api.blockcypher.com/v1/btc/main/blocks/000000000000000000047453805dff15189b57656fe1ada8de603a91e75c4ec6", "previous_hash":
<bytes1440000> luke-jr: let me rephrase: its not just consensus related code, bitcoin core can have bugs and vulnerabilities in different thing. Example: CVE-2018–20587

2022-05-15

<bytes1440000> Bitcoin Core or any bitcoin implementation has lot of things that can be exploited with no soft fork. It can be p2p, mempool wallet, rpc etc. anything
<bytes1440000> What does that have to do with mempool? Maybe you can read the pull requests that are open in bitcoin core repository related to mempool and discuss lightning
<gribble> https://github.com/bitcoin/bitcoin/issues/813045 | HTTP Error 404: Not Found
<bytes1440000> fjahr: DLC and atomic swaps on-chain bitcoin used not even for 1% transactions. Taproot helps with any 2of2 but I had mentioned this in : https://bitcoin-irc.chaincode.com/bitcoin-core-dev/2022-05-15#813045;
<bitcoin-git> [bitcoin] luke-jr closed pull request #25140: Translatability fixups (master...ts_20220515) https://github.com/bitcoin/bitcoin/pull/25140
<bitcoin-git> [gui] luke-jr opened pull request #599: Translatability fixups (master...ts_20220515) https://github.com/bitcoin-core/gui/pull/599
<bitcoin-git> [bitcoin] luke-jr opened pull request #25140: Translatability fixups (master...ts_20220515) https://github.com/bitcoin/bitcoin/pull/25140
<luke-jr> but this is kinda off-topic here, maybe better to discuss in #bitcoin
<gribble> https://github.com/bitcoin/bitcoin/issues/23789 | An error has occurred and has been logged. Please contact this bot's administrator for more information.
<bytes1440000> fjahr:iiuc most of the people use 20f2 or 2of3 mutlsig in bitcoin based on https://mempool.observer/monitor/ and 2of2 is mostly used for lightning
<gribble> https://github.com/bitcoin/bitcoin/issues/23789 | wallet: Strictly match tx change type to improve privacy by MarcoFalke · Pull Request #23789 · bitcoin/bitcoin · GitHub
<bytes1440000> fjahr: I understand this channel is used for bitcoin core which is used by majority of bitcoin nodes. Sorry if it was off topic although context was taproot, above messages related to 2of2 multisig and PR #23789
<bytes1440000> 4. Jeremy Rubin made a good point in this comment: https://github.com/bitcoin/bitcoin/pull/23789#issuecomment-998303608 And the observability of this pattern (change matching) is also... pretty observable, especially if bitcoin core (and only upgraded wallets) are the ones doing it.”
<gribble> https://github.com/bitcoin/bitcoin/issues/23789 | wallet: Strictly match tx change type to improve privacy by MarcoFalke · Pull Request #23789 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] Empact closed pull request #24811: refactor: Prepare for moving ArgsManager out of util/system (master...2022-03-util-args-manager-prep) https://github.com/bitcoin/bitcoin/pull/24811
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25123: test: Fix race condition in index prune test (master...202205-index-prune-fix) https://github.com/bitcoin/bitcoin/pull/25123
<bitcoin-git> bitcoin/master 4faa550 Fabian Jahr: test: Fix race condition in index pruning test
<bitcoin-git> bitcoin/master b74a6dd MacroFake: Merge bitcoin/bitcoin#25123: test: Fix race condition in index prune test
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/225e5b57b2ee...b74a6dde8cf5

2022-05-14

<bitcoin-git> [bitcoin] amadeuszpawlik opened pull request #25136: Torcontrol opt check (master...torcontrol_opt_check) https://github.com/bitcoin/bitcoin/pull/25136
<bitcoin-git> [bitcoin] aureleoules closed pull request #25026: rpc: Make pruneblockchain fetch old blocks if height is lower than pruned height (master...2022-04-pruneblockchain-fetch-old-blocks) https://github.com/bitcoin/bitcoin/pull/25026
<bitcoin-git> [bitcoin] david-bakin opened pull request #25132: Add BIP-341 specified constraints as asserts in `ComputeTaprootMerkel… (master...compute-taproot-merkle-root-asserts) https://github.com/bitcoin/bitcoin/pull/25132

2022-05-13

<bitcoin-git> [bitcoin] theStack opened pull request #25126: test: add BIP157 message parsing support (via MESSAGEMAP) (master...202205-test-support_BIP157_deser_via_messagemap) https://github.com/bitcoin/bitcoin/pull/25126
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25125: test: Slim down versionbits_tests.cpp (master...2205-test-slim-🍄) https://github.com/bitcoin/bitcoin/pull/25125
<bitcoin-git> [bitcoin] fanquake merged pull request #25113: Bump univalue subtree (master...2205-uni-bump-🕌) https://github.com/bitcoin/bitcoin/pull/25113
<bitcoin-git> bitcoin/master fac2c79 MacroFake: Bump univalue subtree
<bitcoin-git> bitcoin/master f403531 MacroFake: Squashed 'src/univalue/' changes from a44caf65fe..6c19d050a9
<bitcoin-git> bitcoin/master 225e5b5 fanquake: Merge bitcoin/bitcoin#25113: Bump univalue subtree
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/25dd4d85136c...225e5b57b2ee
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25124: test: Fix intermittent race in p2p_unrequested_blocks.py (master...2205-test-race-📦) https://github.com/bitcoin/bitcoin/pull/25124
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24595: deploymentstatus: move g_versionbitscache global to ChainstateManager (master...202202-cchainparams-chainstatemanager) https://github.com/bitcoin/bitcoin/pull/24595
<bitcoin-git> bitcoin/master 69675ea Anthony Towns: validation: add CChainParams to ChainstateManager
<bitcoin-git> bitcoin/master 38860f9 Anthony Towns: validation: remove redundant CChainParams params from ChainstateManager me...
<bitcoin-git> bitcoin/master 5c67e84 Anthony Towns: validation: replace ::Params() calls with chainstate/chainman member
<bitcoin-git> [bitcoin] MarcoFalke pushed 10 commits to master: https://github.com/bitcoin/bitcoin/compare/1d5325a8f975...25dd4d85136c
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25117: test: Check msg type in msg capture is followed by zeros (master...2205-test-zero-🚛) https://github.com/bitcoin/bitcoin/pull/25117
<bitcoin-git> bitcoin/master faa5a7a MacroFake: test: Check msg type in msg capture is followed by zeros
<bitcoin-git> bitcoin/master 1d5325a MacroFake: Merge bitcoin/bitcoin#25117: test: Check msg type in msg capture is follow...
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b3f0a34389a4...1d5325a8f975
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25119: net, refactor: move StartExtraBlockRelayPeers() from header to implementation (master...move-StartExtraBlockRelayPeers-from-header-to-implementation) https://github.com/bitcoin/bitcoin/pull/25119
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fe1fcdc62916...b3f0a34389a4
<bitcoin-git> bitcoin/master 51ec96b Jon Atack: refactor: move StartExtraBlockRelayPeers from header to implementation
<bitcoin-git> bitcoin/master b3f0a34 MacroFake: Merge bitcoin/bitcoin#25119: net, refactor: move StartExtraBlockRelayPeers...
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25121: test: compare `/mempool/info` response with `getmempoolinfo` RPC (master...2022-05-rest-mempool-info) https://github.com/bitcoin/bitcoin/pull/25121
<bitcoin-git> bitcoin/master fe1fcdc MacroFake: Merge bitcoin/bitcoin#25121: test: compare `/mempool/info` response with `...
<bitcoin-git> bitcoin/master 1df42bc brunoerg: test: compare `/mempool/info` response with `getmempoolinfo` RPC
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2709ffb9da42...fe1fcdc62916

2022-05-12

<bitcoin-git> [bitcoin] fjahr opened pull request #25123: test: Use addconnection for robustness in index prune test (master...202205-index-prune-fix) https://github.com/bitcoin/bitcoin/pull/25123
<bitcoin-git> [bitcoin] furszy opened pull request #25122: rpc: getreceivedbylabel, return early if no addresses were found in the address book. (master...2022_RPC_getreceivedbylabel_return_early) https://github.com/bitcoin/bitcoin/pull/25122
<bitcoin-git> [bitcoin] brunoerg opened pull request #25121: test: compare `/mempool/info` response with `getmempoolinfo` RPC (master...2022-05-rest-mempool-info) https://github.com/bitcoin/bitcoin/pull/25121
<bitcoin-git> [bitcoin] fanquake closed pull request #25120: test: fix DWARF string_view linker error in blockfilter_tests (master...fix-DWARF-string_view-linker-error) https://github.com/bitcoin/bitcoin/pull/25120
<bitcoin-git> [bitcoin] fanquake merged pull request #25115: scripted-diff: replace non-standard fixed width integer types (`u_int`... - `uint`...) (master...202205-refactor-replace_non_std_fixed_width_integer_types) https://github.com/bitcoin/bitcoin/pull/25115
<bitcoin-git> bitcoin/master 672d49c Sebastian Falbesoner: scripted-diff: replace non-standard fixed width integer types (`u_int`...`...
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/dd9f61a184d4...2709ffb9da42
<bitcoin-git> bitcoin/master 2709ffb fanquake: Merge bitcoin/bitcoin#25115: scripted-diff: replace non-standard fixed wid...
<gribble> https://github.com/bitcoin/bitcoin/issues/24595 | deploymentstatus: move g_versionbitscache global to ChainstateManager by ajtowns · Pull Request #24595 · bitcoin/bitcoin · GitHub
<david-bakin> I suppose I should give the link to the PR, huh? OK: https://github.com/bitcoin/bitcoin/pull/25097
<gribble> https://github.com/bitcoin/bitcoin/issues/25065 | [kernel 2c/n] Extract only what we use of `init/common.cpp` by dongcarl · Pull Request #25065 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/25064 | [kernel 2b/n] Add `ChainstateManager::m_adjusted_time_callback` by dongcarl · Pull Request #25064 · bitcoin/bitcoin · GitHub
<core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
<gribble> https://github.com/bitcoin/bitcoin/issues/22954 | [TESTS] Allow tx_invalid.json tests to include flag rules for if_unset: [A,B,C] then_unset: [D] by JeremyRubin · Pull Request #22954 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/22876 | [TESTS] Update Transaction Tests to permit setting a flag as always on and disabling the exhaustive failure test by JeremyRubin · Pull Request #22876 · bitcoin/bitcoin · GitHub
<laanwj> https://github.com/bitcoin/bitcoin/projects/8 has: 13 blockers, 1 chasing conept ACK
<gribble> https://github.com/bitcoin/bitcoin/issues/24032 | Add defaults to vDeployments to avoid uninitialized variables by ajtowns · Pull Request #24032 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/25109 | Strengthen AssertLockNotHeld assertions by ajtowns · Pull Request #25109 · bitcoin/bitcoin · GitHub