2022-05-05

<gribble> https://github.com/bitcoin/bitcoin/issues/24993 | test, contrib, refactor: use `with` when opening a file by brunoerg · Pull Request #24993 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] fanquake merged pull request #25006: guix: consolidate kernel headers to 5.15, specify 3.2.0 as minimum supported (master...specify_minimum_kernel) https://github.com/bitcoin/bitcoin/pull/25006
<bitcoin-git> bitcoin/master eb02713 fanquake: doc: add minimum required kernel version to dependencies.md
<bitcoin-git> bitcoin/master e4478d3 fanquake: Merge bitcoin/bitcoin#25006: guix: consolidate kernel headers to 5.15, spe...
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c367736f85ac...e4478d312f90
<bitcoin-git> bitcoin/master dcad5f7 fanquake: guix: consolidate kernel headers to 5.15
<bitcoin-git> [bitcoin] hunglun opened pull request #25069: test: Add a new unit test for chain.cpp (master...master) https://github.com/bitcoin/bitcoin/pull/25069
<gribble> https://github.com/bitcoin/bitcoin/issues/24410 | [kernel 2a/n] Split hashing/index `GetUTXOStats` codepaths, decouple from `coinstatsindex` by dongcarl · Pull Request #24410 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24840: test: port 'lint-shell.sh' to python (master...24783-port-lint-shell-to-python) https://github.com/bitcoin/bitcoin/pull/24840
<bitcoin-git> bitcoin/master bd6ceb4 whiteh0rse: test: port 'lint-shell.sh' to python
<bitcoin-git> bitcoin/master c367736 MacroFake: Merge bitcoin/bitcoin#24840: test: port 'lint-shell.sh' to python
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7cc1860b12a5...c367736f85ac
<sipa> They were already blocked on the bitcoin org; I also blocked them from the bitcoin-core org.
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25068: Wrap boost::replace_all (master...2205-util-string-📉) https://github.com/bitcoin/bitcoin/pull/25068
<bitcoin-git> [bitcoin] fanquake merged pull request #24566: build: Drop redundant checks for ranlib and strip tools (master...220314-conf) https://github.com/bitcoin/bitcoin/pull/24566
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1ad5d5088d69...7cc1860b12a5
<bitcoin-git> bitcoin/master a0e2a31 Hennadii Stepanov: build: Drop redundant checks for ranlib and strip tools
<bitcoin-git> bitcoin/master 7cc1860 fanquake: Merge bitcoin/bitcoin#24566: build: Drop redundant checks for ranlib and s...
<bitcoin-git> [bitcoin] jonatack opened pull request #25067: validation, refactor: make MainSignalsInstance() a class, move to h (master...make-MainSignalsInstance-a-class-and-move-to-header-file) https://github.com/bitcoin/bitcoin/pull/25067
<bitcoin-git> [bitcoin] fanquake merged pull request #24866: build: No longer need to hack the `PATH` variable in `config.site` (master...220415-tools) https://github.com/bitcoin/bitcoin/pull/24866
<bitcoin-git> [bitcoin] fanquake pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/0d080a183bfc...1ad5d5088d69
<bitcoin-git> bitcoin/master a4fd440 Hennadii Stepanov: build: Pass missed `strip` tool via `config.site`
<bitcoin-git> bitcoin/master 80cd993 Hennadii Stepanov: scripted-diff: Rename INSTALLNAMETOOL -> INSTALL_NAME_TOOL
<bitcoin-git> bitcoin/master f87594d Hennadii Stepanov: build: No need to provide defaults for darwin-specific tools
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24141: Rename message_command variables in src/net* and src/rpc/net.cpp (master...220124-message) https://github.com/bitcoin/bitcoin/pull/24141
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d4475ea7ae70...0d080a183bfc
<bitcoin-git> bitcoin/master e71c51b Shashwat: refactor: rename command -> message type in comments in the src/net* files
<bitcoin-git> bitcoin/master 2b09593 Shashwat: scripted-diff: Rename message command to message type
<bitcoin-git> bitcoin/master 0d080a1 MacroFake: Merge bitcoin/bitcoin#24141: Rename message_command variables in src/net* ...

2022-05-04

<gribble> https://github.com/bitcoin/bitcoin/issues/25065 | [kernel 2c/n] Extract only what we use of `init/common.cpp` by dongcarl · Pull Request #25065 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] dongcarl opened pull request #25065: [kernel 2c/n] Extract only what we use of `init/common.cpp` (master...2022-03-libbitcoinkernel-initcommon) https://github.com/bitcoin/bitcoin/pull/25065
<bitcoin-git> [bitcoin] fanquake closed pull request #24969: Update bitcoin.conf (master...patch-1) https://github.com/bitcoin/bitcoin/pull/24969
<bitcoin-git> [bitcoin] laanwj merged pull request #22235: script: add script to generate example bitcoin.conf (master...josibake-auto-generate-example-bitcoin-conf-file) https://github.com/bitcoin/bitcoin/pull/22235
<bitcoin-git> bitcoin/master 6aac946 Josiah Baker: doc: update bitcoin-conf.md
<bitcoin-git> bitcoin/master 1c7e820 josibake: script: add script to generate example bitcoin.conf
<bitcoin-git> [bitcoin] laanwj pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/5e1aacab576b...d4475ea7ae70
<bitcoin-git> bitcoin/master b483084 josibake: doc: replace bitcoin.conf with placeholder file
<bitcoin-git> [bitcoin] laanwj merged pull request #24933: util: Replace non-threadsafe strerror (master...2022-04-strerror-threadsafe) https://github.com/bitcoin/bitcoin/pull/24933
<bitcoin-git> bitcoin/master 718da30 laanwj: util: Refactor SysErrorString logic
<bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/fe6a299fc002...5e1aacab576b
<bitcoin-git> bitcoin/master 46971c6 laanwj: util: Replace non-threadsafe strerror
<bitcoin-git> bitcoin/master e7f2f77 laanwj: util: Use strerror_s for SysErrorString on Windows
<bitcoin-git> [bitcoin] laanwj merged pull request #24852: util: optimize HexStr (master...2022-03-HexStr-optimizations) https://github.com/bitcoin/bitcoin/pull/24852
<bitcoin-git> bitcoin/master 67c8411 Martin Leitner-Ankerl: test: Adds a test for HexStr that checks all 256 bytes
<bitcoin-git> bitcoin/master 4e2b99f Martin Leitner-Ankerl: bench: Adds a benchmark for HexStr
<bitcoin-git> bitcoin/master 5e61532 Martin Leitner-Ankerl: util: optimizes HexStr
<bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/33aaf434af27...fe6a299fc002
<bitcoin-git> [bitcoin] fanquake merged pull request #24976: netgroup: Follow-up for #22910 (master...2022-04-nStartByte-followup) https://github.com/bitcoin/bitcoin/pull/24976
<bitcoin-git> bitcoin/master 33aaf43 fanquake: Merge bitcoin/bitcoin#24976: netgroup: Follow-up for #22910
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0047d9b89b9f...33aaf434af27
<bitcoin-git> bitcoin/master e5d1831 dergoegge: [netgroup] Use nStartByte as offset for the last byte of the group
<bitcoin-git> [bitcoin] laanwj merged pull request #24993: test, contrib, refactor: use `with` when opening a file (master...2022-04-contrib-close-file) https://github.com/bitcoin/bitcoin/pull/24993
<bitcoin-git> bitcoin/master 027aab6 brunoerg: test, contrib, refactor: use `with` when opening a file
<bitcoin-git> bitcoin/master 0047d9b laanwj: Merge bitcoin/bitcoin#24993: test, contrib, refactor: use `with` when open...
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bde5836f9996...0047d9b89b9f
<bitcoin-git> [bitcoin] fanquake merged pull request #25057: refactor: replace remaining boost::split with SplitString (master...2022-04-boost-split-exorcism) https://github.com/bitcoin/bitcoin/pull/25057
<bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/9183c66cc6ae...bde5836f9996
<bitcoin-git> bitcoin/master b7ab9db Martin Leitner-Ankerl: Extend Split to work with multiple separators
<bitcoin-git> bitcoin/master 0d7efcd Martin Leitner-Ankerl: core_read: Replace boost::split with SplitString
<bitcoin-git> bitcoin/master d1a9850 Martin Leitner-Ankerl: http: replace boost::split with SplitString
<gribble> https://github.com/bitcoin/bitcoin/issues/25064 | [kernel 2b/n] Add `ChainstateManager::m_adjusted_time_callback` by dongcarl · Pull Request #25064 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] dongcarl opened pull request #25064: [kernel 2b/n] Add `ChainstateManager::m_adjusted_time_callback` (master...2022-05-libbitcoinkernel-adjtime) https://github.com/bitcoin/bitcoin/pull/25064
<bitcoin-git> [bitcoin] fanquake merged pull request #25046: build: Fix `libmultiprocess` cross-compiling to Linux hosts (master...220501-mp-cross) https://github.com/bitcoin/bitcoin/pull/25046
<bitcoin-git> bitcoin/master 9183c66 fanquake: Merge bitcoin/bitcoin#25046: build: Fix `libmultiprocess` cross-compiling ...
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d17bbc3c484e...9183c66cc6ae
<bitcoin-git> bitcoin/master c0f5cc1 Hennadii Stepanov: build: Fix `libmultiprocess` cross-compiling to Linux hosts
<bitcoin-git> [bitcoin] dongcarl closed pull request #24456: blockman: Properly guard blockfile members (master...2022-02-kirby-p4) https://github.com/bitcoin/bitcoin/pull/24456
<bitcoin-git> [bitcoin] Sjors opened pull request #25063: test: previous releases: add v23.0 (master...2022/05/add_previous_release) https://github.com/bitcoin/bitcoin/pull/25063
<gribble> https://github.com/bitcoin/bitcoin/issues/24921 | Add time helpers for std::chrono::steady_clock and FastRandomContext::rand_uniform_delay by MarcoFalke · Pull Request #24921 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] MarcoFalke reopened pull request #19426: refactor: Change * to & in MutableTransactionSignatureCreator (master...2007-refactorSign) https://github.com/bitcoin/bitcoin/pull/19426
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25060: blockstorage: add LIFETIMEBOUND to GetFirstStoredBlock()::start_time (master...add-LIFETIMEBOUND-to-GetFirstStoredBlock-start_time) https://github.com/bitcoin/bitcoin/pull/25060
<bitcoin-git> bitcoin/master d17bbc3 MacroFake: Merge bitcoin/bitcoin#25060: blockstorage: add LIFETIMEBOUND to GetFirstSt...
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c290249fff81...d17bbc3c484e
<bitcoin-git> bitcoin/master 4cb9d21 Jon Atack: blockstorage: add LIFETIMEBOUND to GetFirstStoredBlock()::start_time
<bitcoin-git> [bitcoin] fanquake closed pull request #23035: p2p, rpc, test: expose tried and refcount in getnodeaddresses, update/improve tests (master...getnodeaddresses-tried-and-reference_count) https://github.com/bitcoin/bitcoin/pull/23035
<bitcoin-git> [bitcoin] fanquake merged pull request #25058: rpc: Move output script RPCs to separate file, rename misc.cpp (master...2205-rpc-out-script-📂) https://github.com/bitcoin/bitcoin/pull/25058
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/14cb53dfe95e...c290249fff81
<bitcoin-git> bitcoin/master c290249 fanquake: Merge bitcoin/bitcoin#25058: rpc: Move output script RPCs to separate file...
<bitcoin-git> bitcoin/master fa87eb8 MacroFake: rpc: Move output script RPCs to separate file
<bitcoin-git> bitcoin/master fa758f9 MacroFake: scripted-diff: Rename rpc/misc.cpp to rpc/node.cpp
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25040: refactor: Pass lifetimebound reference to SingleThreadedSchedulerClient (master...2204-sched-🔭) https://github.com/bitcoin/bitcoin/pull/25040
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9b42d62f426f...14cb53dfe95e
<bitcoin-git> bitcoin/master fa4652c MacroFake: Pass lifetimebound reference to SingleThreadedSchedulerClient
<bitcoin-git> bitcoin/master 14cb53d MacroFake: Merge bitcoin/bitcoin#25040: refactor: Pass lifetimebound reference to Sin...
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25045: test: add coverage for invalid requests for `blockfilterheaders` (REST) (master...2022-04-invalid-blockfilterheaders) https://github.com/bitcoin/bitcoin/pull/25045
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/880cec91fab1...9b42d62f426f
<bitcoin-git> bitcoin/master d1bfe5e brunoerg: test: add coverage for invalid requests for `blockfilterheaders`
<bitcoin-git> bitcoin/master 9b42d62 MacroFake: Merge bitcoin/bitcoin#25045: test: add coverage for invalid requests for `...
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25047: tidy: add readability-redundant-declaration (master...tidy_redundant_externs) https://github.com/bitcoin/bitcoin/pull/25047
<bitcoin-git> bitcoin/master 880cec9 MacroFake: Merge bitcoin/bitcoin#25047: tidy: add readability-redundant-declaration
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/12455acca2c3...880cec91fab1
<bitcoin-git> bitcoin/master c2b2958 fanquake: tidy: add readability-redundant-declaration

2022-05-03

<merlin_moci47> - How many members of Bitcoin Core have to agree for Bob to get invited?
<merlin_moci47> Actually I was thinking about a hypothetical social engineering scenario. Suppose Bob likes ethereum and Bob is in love with Alice. However, Alice wants to marry a member of Bitcoin Core because she wants her Kids to become real cypherpunks. How can Bob get Alice while minimising his effort?
<bitcoin-git> [bitcoin] jonatack opened pull request #25060: blockstorage: add LIFETIMEBOUND to GetFirstStoredBlock()::start_time (master...add-LIFETIMEBOUND-to-GetFirstStoredBlock-start_time) https://github.com/bitcoin/bitcoin/pull/25060
<jonatack> merlin_moci: if you have the knack and work at it consistently over time, it may be possible, or at least, not impossible? enjoying the process, the concepts, the code, the challenge, and having a deep desire to help bitcoin, and people, and your fellow contributors...might be some viable motivations for doing it over the long term...just an
<merlin_moci> Can you make good-quality code reviews and become a member of bitcoin-core without being a developer?
<jonatack> merlin_moci: it's possible to learn! participate in https://bitcoincore.reviews, apply for the chaincode labs seminars, and see (for instance) https://jonatack.github.io/articles/how-to-review-pull-requests-in-bitcoin-core for more info
<merlin_moci> Who decides to add new people to the bitcoin-core organisation on Github?
<merlin_moci> Who decides to add new people to the bitcoin-core organisation on Github?
<bytes1440000> How are people added to this github org? https://github.com/orgs/bitcoin-core/people
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24470: Disallow more unsafe string-path conversions allowed by path append operators (master...pr/patha) https://github.com/bitcoin/bitcoin/pull/24470
<bitcoin-git> bitcoin/master f64aa9c Ryan Ofsky: Disallow more unsafe string->path conversions allowed by path append opera...
<bitcoin-git> bitcoin/master 12455ac MacroFake: Merge bitcoin/bitcoin#24470: Disallow more unsafe string->path conversions...
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/64d2715533b5...12455acca2c3
<bitcoin-git> [bitcoin] fanquake merged pull request #25053: Guard `#include config/bitcoin-config.h` (master...220502-config) https://github.com/bitcoin/bitcoin/pull/25053
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d24318a40cad...64d2715533b5
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24941: test: MiniWallet: support skipping mempool checks (feature_fee_estimation.py performance fix) (master...202204-test-MiniWallet-support_creating_txs_without_mempool_checks) https://github.com/bitcoin/bitcoin/pull/24941
<bitcoin-git> bitcoin/master 01552e8 Sebastian Falbesoner: test: MiniWallet: always rehash after signing (P2PK mode)
<bitcoin-git> bitcoin/master d24318a MacroFake: Merge bitcoin/bitcoin#24941: test: MiniWallet: support skipping mempool ch...
<bitcoin-git> bitcoin/master a498acc Sebastian Falbesoner: test: MiniWallet: skip mempool check if `mempool_valid=False`
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/2c56404088f7...d24318a40cad
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25058: rpc: Move output script RPCs to separate file, rename misc.cpp (master...2205-rpc-out-script-📂) https://github.com/bitcoin/bitcoin/pull/25058
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25029: rpc: Move fee estimation RPCs to separate file (master...2204-rpc-fees-😊) https://github.com/bitcoin/bitcoin/pull/25029
<bitcoin-git> bitcoin/master fa753ab MacroFake: rpc: Move fee estimation RPCs to separate file
<bitcoin-git> Can be reviewed with --col...
<bitcoin-git> bitcoin/master 2c56404 MacroFake: Merge bitcoin/bitcoin#25029: rpc: Move fee estimation RPCs to separate fil...
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/037c5e511fe2...2c56404088f7
<bitcoin-git> [bitcoin] martinus opened pull request #25057: refactor: replace remaining boost::split with StringSplit (master...2022-04-boost-split-exorcism) https://github.com/bitcoin/bitcoin/pull/25057

2022-05-02

<Murch> A few weeks ago I was trying to follow a Bitcoin PR Review Club but got only one in a dozen messages on Matrix
<bitcoin-git> [bitcoin] laanwj merged pull request #25042: lint: Fix lint-circular-dependencies.py file list (master...2204-lint-circ-🚄) https://github.com/bitcoin/bitcoin/pull/25042
<bitcoin-git> [bitcoin] hebasto opened pull request #25053: Guard `#include config/bitcoin-config.h` (master...220502-config) https://github.com/bitcoin/bitcoin/pull/25053
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5c93fc188d61...037c5e511fe2
<bitcoin-git> bitcoin/master fad0abf MacroFake: lint: Fix lint-circular-dependencies.py file list
<bitcoin-git> bitcoin/master 037c5e5 laanwj: Merge bitcoin/bitcoin#25042: lint: Fix lint-circular-dependencies.py file ...
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25017: validation: make CScriptCheck and prevector swap members noexcept (master...swap-noexcept) https://github.com/bitcoin/bitcoin/pull/25017
<bitcoin-git> bitcoin/master abc1ee5 Jon Atack: validation: make CScriptCheck and prevector swap member functions noexcept...
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/e389c4d30881...5c93fc188d61
<bitcoin-git> bitcoin/master e5485e8 Jon Atack: test, bench: make prevector and checkqueue swap member functions noexcept
<bitcoin-git> bitcoin/master 5c93fc1 MacroFake: Merge bitcoin/bitcoin#25017: validation: make CScriptCheck and prevector s...
<bitcoin-git> [bitcoin] luke-jr opened pull request #25051: Bugfix: configure: Define defaults for enable_arm_{crc,shani} (master...fix_configure_def_enable_arm_asms) https://github.com/bitcoin/bitcoin/pull/25051

2022-05-01

<bitcoin-git> [bitcoin] luke-jr opened pull request #25050: CValidationInterface: ValidationInterfaceUnregistering, called when being unregistered (master...validationIF_unregister) https://github.com/bitcoin/bitcoin/pull/25050
<bitcoin-git> [bitcoin] fanquake merged pull request #25043: Reject invalid rpcauth formats (master...2204-rpcauth-invalid-format-🍰) https://github.com/bitcoin/bitcoin/pull/25043
<bitcoin-git> bitcoin/master fa12706 MacroFake: Reject invalid rpcauth formats
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5d53cf38784d...e389c4d30881
<bitcoin-git> bitcoin/master e389c4d fanquake: Merge bitcoin/bitcoin#25043: Reject invalid rpcauth formats
<bitcoin-git> [bitcoin] fanquake opened pull request #25047: tidy: add readability-redundant-declaration (master...tidy_redundant_externs) https://github.com/bitcoin/bitcoin/pull/25047
<bitcoin-git> [bitcoin] hebasto opened pull request #25046: build: Fix `libmultiprocess` cross-compiling to Linux hosts (master...220501-mp-cross) https://github.com/bitcoin/bitcoin/pull/25046

2022-04-30

<bitcoin-git> [bitcoin] brunoerg opened pull request #25045: test: add coverage for invalid requests for `blockfilterheaders` (master...2022-04-invalid-blockfilterheaders) https://github.com/bitcoin/bitcoin/pull/25045
<bitcoin-git> [bitcoin] danielabrozzoni opened pull request #25044: test: Use MiniWallet in rpc_rawtransaction.py (master...test_rawtransaction_miniwallet) https://github.com/bitcoin/bitcoin/pull/25044
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25043: Reject invalid rpcauth formats (master...2204-rpcauth-invalid-format-🍰) https://github.com/bitcoin/bitcoin/pull/25043
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24543: net processing: Move remaining globals into PeerManagerImpl (master...deglobl_net_processing) https://github.com/bitcoin/bitcoin/pull/24543
<bitcoin-git> [bitcoin] MarcoFalke pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/23daa86ec132...5d53cf38784d
<bitcoin-git> bitcoin/master 37ecaf3 dergoegge: [net processing] Move CNodeState declaration above PeerManagerImpl
<bitcoin-git> bitcoin/master a292df2 dergoegge: [net processing] Move mapNodeState into PeerManagerImpl
<bitcoin-git> bitcoin/master 490c08f dergoegge: [net processing] Move nPreferredDownload into PeerManagerImpl
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25042: lint: Fix lint-circular-dependencies.py file list (master...2204-lint-circ-🚄) https://github.com/bitcoin/bitcoin/pull/25042
<bitcoin-git> [bitcoin] fanquake merged pull request #25027: test: Remove boost::split from getarg_tests.cpp (master...2204-boost-split-less-🚔) https://github.com/bitcoin/bitcoin/pull/25027
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c086ebaf74a8...23daa86ec132
<bitcoin-git> bitcoin/master 23daa86 fanquake: Merge bitcoin/bitcoin#25027: test: Remove boost::split from getarg_tests.c...
<bitcoin-git> bitcoin/master fafa727 MacroFake: test: Remove boost::split from getarg_tests.cpp
<bitcoin-git> [bitcoin] fanquake merged pull request #25028: ci: Clone iwyu only if missing (master...2204-iwyu-clone-📤) https://github.com/bitcoin/bitcoin/pull/25028
<bitcoin-git> bitcoin/master fa847ed MacroFake: ci: Clone iwyu only if missing
<bitcoin-git> bitcoin/master c086eba fanquake: Merge bitcoin/bitcoin#25028: ci: Clone iwyu only if missing
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/becea48fe072...c086ebaf74a8
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25034: test: add missing stop_node calls to feature_coinstatsindex and feature_prune (master...20224_coinstatsindex_fix) https://github.com/bitcoin/bitcoin/pull/25034
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/26296eba3dc3...becea48fe072
<bitcoin-git> bitcoin/master a3cd7db Martin Zumsande: test: stop node before calling assert_start_raises_init_error
<bitcoin-git> bitcoin/master becea48 MacroFake: Merge bitcoin/bitcoin#25034: test: add missing stop_node calls to feature_...
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25040: refactor: Pass lifetimebound reference to SingleThreadedSchedulerClient (master...2204-sched-🔭) https://github.com/bitcoin/bitcoin/pull/25040
<bitcoin-git> [bitcoin] jacobpfickes opened pull request #25039: lint: converts git-subtree-check.sh to Python (master...convert_git_subtree_check) https://github.com/bitcoin/bitcoin/pull/25039
<bitcoin-git> [bitcoin] glozow opened pull request #25038: BIP125-based Package RBF (master...package-rbf) https://github.com/bitcoin/bitcoin/pull/25038

2022-04-29

<bitcoin-git> [bitcoin] scgbckbone closed pull request #25032: normalize PSBT entry instead of external signer master fingerprint (master...upper_master_fp_cor_cmp) https://github.com/bitcoin/bitcoin/pull/25032
<bitcoin-git> [bitcoin] hebasto opened pull request #25037: build: Create `noinst_LTLIBRARIES` conditionally (master...220429-targets) https://github.com/bitcoin/bitcoin/pull/25037
<bitcoin-git> [bitcoin] w0xlt opened pull request #25036: wallet: Save wallet scan progress (master...save_scan_progress) https://github.com/bitcoin/bitcoin/pull/25036
<bitcoin-git> [bitcoin] mzumsande opened pull request #25034: test: add missing stop_node call to feature_coinstatsindex (master...20224_coinstatsindex_fix) https://github.com/bitcoin/bitcoin/pull/25034
<gribble> https://github.com/bitcoin/bitcoin/issues/24595 | deploymentstatus: move g_versionbitscache global to ChainstateManager by ajtowns · Pull Request #24595 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] scgbckbone opened pull request #25033: add explicit condition fo master fingerprint to be lowercase hex (master...explicit_master_fp_str_encoding_in_docs) https://github.com/bitcoin/bitcoin/pull/25033
<bitcoin-git> [bitcoin] scgbckbone opened pull request #25032: normalize PSBT entry instead of external signer master fingerprint (master...upper_master_fp_cor_cmp) https://github.com/bitcoin/bitcoin/pull/25032
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #22525: docs: Update the explainer text for the listunspent RPC (master...master) https://github.com/bitcoin/bitcoin/pull/22525
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #19985: net: Prevent routing of deprecated Site Local IPv6 (master...net-deprecate-site-local-ipv6) https://github.com/bitcoin/bitcoin/pull/19985
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #19757: net/net_processing: Convert net std::list buffers to std::forward_list (master...net-list-type) https://github.com/bitcoin/bitcoin/pull/19757
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #18987: RFC: Introducing Watchdog, a cross-layer anomaly detection module (master...2020-05-rfc-watchdog) https://github.com/bitcoin/bitcoin/pull/18987
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25029: rpc: Move fee estimation RPCs to separate file (master...2204-rpc-fees-😊) https://github.com/bitcoin/bitcoin/pull/25029
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25028: ci: Clone iwyu only if missing (master...2204-iwyu-clone-📤) https://github.com/bitcoin/bitcoin/pull/25028
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25027: test: Remove boost::split from getarg_tests.cpp (master...2204-boost-split-less-🚔) https://github.com/bitcoin/bitcoin/pull/25027
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25025: test: Remove boost::split from rpc_tests.cpp (master...2204-test-boost-🏓) https://github.com/bitcoin/bitcoin/pull/25025
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/194b41469777...26296eba3dc3
<bitcoin-git> bitcoin/master fad35e9 MacroFake: test: Remove boost::split from rpc_tests.cpp
<bitcoin-git> bitcoin/master 26296eb MacroFake: Merge bitcoin/bitcoin#25025: test: Remove boost::split from rpc_tests.cpp
<bitcoin-git> [bitcoin] jonatack closed pull request #24718: rpc: getblock/getrawtransaction/decode*/gettxout fixups (master...rpc-fixups) https://github.com/bitcoin/bitcoin/pull/24718
<bitcoin-git> [bitcoin] fanquake closed pull request #22094: p2p: fix ubsan addrman errors, make nTime truncation conversion explicit (master...fix-ubsan-implicit-conversion-in-CAddrMan_Connected) https://github.com/bitcoin/bitcoin/pull/22094
<bitcoin-git> [bitcoin] fanquake merged pull request #25016: refactor: GetFirstStoredBlock() and getblockchaininfo follow-ups (master...GetFirstStoredBlock-improvements) https://github.com/bitcoin/bitcoin/pull/25016
<bitcoin-git> bitcoin/master ed12c0a Jon Atack: blockstorage, refactor: make GetFirstStoredBlock() a member of BlockManage...
<bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/246db9889743...194b41469777
<bitcoin-git> bitcoin/master e2b954e Jon Atack: rpc: use GetBlockTime() for getblockchaininfo#time
<bitcoin-git> bitcoin/master 86ce844 Jon Atack: blockstorage, refactor: pass GetFirstStoredBlock() start_block by referenc...
<bitcoin-git> [bitcoin] fanquake merged pull request #25024: test: Split MempoolAncestryTests into two (master...2204-test-split-🕷) https://github.com/bitcoin/bitcoin/pull/25024
<bitcoin-git> bitcoin/master 246db98 fanquake: Merge bitcoin/bitcoin#25024: test: Split MempoolAncestryTests into two
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/91ac12be4426...246db9889743
<bitcoin-git> bitcoin/master fa2102e MacroFake: test: Split MempoolAncestryTests into two
<bitcoin-git> [bitcoin] fanquake merged pull request #25013: Remove cs_main from verifymessage, move msg utils to new file (master...2204-rpc-misc-🔌) https://github.com/bitcoin/bitcoin/pull/25013
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/91a673613646...91ac12be4426
<bitcoin-git> bitcoin/master 91ac12b fanquake: Merge bitcoin/bitcoin#25013: Remove cs_main from verifymessage, move msg u...
<bitcoin-git> bitcoin/master fa94251 MacroFake: Remove cs_main from verifymessage
<bitcoin-git> bitcoin/master fa60169 MacroFake: rpc: Move signmessage RPC util to new file
<bitcoin-git> [bitcoin] fanquake closed pull request #18061: util: Pass size to ParseHex to assist preallocation (master...2020-02-remove-strlen) https://github.com/bitcoin/bitcoin/pull/18061
<bitcoin-git> [bitcoin] aureleoules opened pull request #25026: rpc: Make pruneblockchain fetch old blocks if height is lower than pruned height (master...2022-04-pruneblockchain-fetch-old-blocks) https://github.com/bitcoin/bitcoin/pull/25026
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25025: test: Remove boost::split from rpc_tests.cpp (master...2204-test-boost-🏓) https://github.com/bitcoin/bitcoin/pull/25025
<bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18061: util: Pass size to ParseHex to assist preallocation (master...2020-02-remove-strlen) https://github.com/bitcoin/bitcoin/pull/18061
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25024: test: Split MempoolAncestryTests into two (master...2204-test-split-🕷) https://github.com/bitcoin/bitcoin/pull/25024
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25023: Remove unused SetTip(nullptr) code (master...2204-rem-nullptr-👯) https://github.com/bitcoin/bitcoin/pull/25023
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25009: Crash debug builds on PCKG_MEMPOOL_ERROR (master...2204-crash-debug-🏦) https://github.com/bitcoin/bitcoin/pull/25009
<bitcoin-git> bitcoin/master fa10c9f MacroFake: Crash debug builds on PCKG_MEMPOOL_ERROR
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/606ce05ec225...91a673613646
<bitcoin-git> bitcoin/master 91a6736 MacroFake: Merge bitcoin/bitcoin#25009: Crash debug builds on PCKG_MEMPOOL_ERROR

2022-04-28

<bitcoin-git> [bitcoin] jonatack opened pull request #25021: test: fix intermittent wallet_encryption functional test (master...fix-intermittent-wallet_encryption-test) https://github.com/bitcoin/bitcoin/pull/25021
<bitcoin-git> [bitcoin] achow101 merged pull request #18554: wallet: ensure wallet files are not reused across chains (master...wallet-file-reuse-prevention) https://github.com/bitcoin/bitcoin/pull/18554
<bitcoin-git> bitcoin/master 606ce05 Andrew Chow: Merge bitcoin/bitcoin#18554: wallet: ensure wallet files are not reused ac...
<bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/4cf9fa0b662a...606ce05ec225
<bitcoin-git> bitcoin/master 9687659 Seibart Nedor: wallet: ensure wallet files are not reused across chains
<bitcoin-git> bitcoin/master 5f21321 Seibart Nedor: tests: add tests for cross-chain wallet use prevention
<core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
<cfields> atm the results are intended to be not very usable, but the kernel lib and bitcoin-chainstate (excluding some windows weirdness) should at least build successfully. Please report if that's not the case anywhere.
<gribble> https://github.com/bitcoin/bitcoin/issues/24410 | [kernel 2a/n] Split hashing/index `GetUTXOStats` codepaths, decouple from `coinstatsindex` by dongcarl · Pull Request #24410 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/24322 | [kernel 1/n] Introduce initial `libbitcoinkernel` by dongcarl · Pull Request #24322 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/24410 | [kernel 2a/n] Split hashing/index `GetUTXOStats` codepaths, decouple from `coinstatsindex` by dongcarl · Pull Request #24410 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/24757 | build, ci: add `DEBUG_LOCKCONTENTION` to --enable-debug and CI by jonatack · Pull Request #24757 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/23443 | p2p: Erlay support signaling by naumenkogs · Pull Request #23443 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/24322 | [kernel 1/n] Introduce initial `libbitcoinkernel` by dongcarl · Pull Request #24322 · bitcoin/bitcoin · GitHub
<laanwj> currently 11 blockers 1 chasing concept ACK https://github.com/bitcoin/bitcoin/projects/8
<laanwj> welcome to the weekly general bitcoin-core-dev meeting!
<laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball
<core-meetingbot> Meeting started Thu Apr 28 19:00:52 2022 UTC. The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
<gribble> https://github.com/bitcoin/bitcoin/issues/24387 | build: Fail to build `libmultiprocess` for the `arm-linux-gnueabihf` target · Issue #24387 · bitcoin/bitcoin · GitHub
<hebasto> cfields: in the context of your https://github.com/bitcoin/bitcoin/pull/24322#issuecomment-1112453779 mind looking into #24387 ?
<bitcoin-git> [bitcoin] achow101 merged pull request #24984: wallet: ignore chainStateFlushed notifications while attaching chain (master...202204_wallet_rescan) https://github.com/bitcoin/bitcoin/pull/24984
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/dabec990135c...4cf9fa0b662a
<bitcoin-git> bitcoin/master 2052e3a Martin Zumsande: wallet: ignore chainStateFlushed notifications while attaching chain
<bitcoin-git> bitcoin/master 4cf9fa0 Andrew Chow: Merge bitcoin/bitcoin#24984: wallet: ignore chainStateFlushed notification...
<bitcoin-git> [bitcoin] hebasto opened pull request #25020: contrib: Check symbols in the `bitcoinconsensus` shared library (master...220428-shared) https://github.com/bitcoin/bitcoin/pull/25020
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24956: Call CHECK_NONFATAL only once where needed (master...2204-once-check-tip-🦅) https://github.com/bitcoin/bitcoin/pull/24956
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8730bd3fc87c...dabec990135c
<bitcoin-git> bitcoin/master dabec99 MacroFake: Merge bitcoin/bitcoin#24956: Call CHECK_NONFATAL only once where needed
<bitcoin-git> bitcoin/master fab34d3 MarcoFalke: Call CHECK_NONFATAL only once where needed
<bitcoin-git> [bitcoin] scgbckbone opened pull request #25019: normalize (lowercase) master fp in ExternalSigner::SignTransaction (master...lower_master_fp_of_ext_signer_in_SignTransaction) https://github.com/bitcoin/bitcoin/pull/25019
<bitcoin-git> [bitcoin] jonatack opened pull request #25017: validation: make the CScriptCheck::swap() member function `noexcept` (master...swap-noexcept) https://github.com/bitcoin/bitcoin/pull/25017
<bitcoin-git> [bitcoin] laanwj merged pull request #24958: build: Fix macOS Apple M1 build with miniupnpc and libnatpmp. Again :) (master...220424-flags) https://github.com/bitcoin/bitcoin/pull/24958
<bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/47b8256da872...8730bd3fc87c
<bitcoin-git> bitcoin/master bbbcb96 Hennadii Stepanov: build, refactor: Fix indentation
<bitcoin-git> bitcoin/master 65cddf6 Hennadii Stepanov: build: Fix `AC_CHECK_HEADERS` and `AC_CHECK_LIB` for `miniupnpc` package
<bitcoin-git> bitcoin/master 1659034 Hennadii Stepanov: build: Fix `AC_CHECK_HEADERS` and `AC_CHECK_LIB` for `libnatpmp` package
<bitcoin-git> [bitcoin] laanwj merged pull request #24937: test: Remove previous release check in feature_taproot.py (master...2204-noPrevRelTap-🏥) https://github.com/bitcoin/bitcoin/pull/24937
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/dd17c42a1642...47b8256da872
<bitcoin-git> bitcoin/master 47b8256 laanwj: Merge bitcoin/bitcoin#24937: test: Remove previous release check in featur...
<bitcoin-git> bitcoin/master fafd674 MarcoFalke: test: Remove previous release check
<bitcoin-git> [bitcoin] jonatack opened pull request #25016: blockstorage, refactor: improve GetFirstStoredBlock() (master...GetFirstStoredBlock-improvements) https://github.com/bitcoin/bitcoin/pull/25016
<laanwj> cfields: i mean in the sense that there's an actual kernel in bitcoin now so we can't have anything against "kernel hacking"
<bitcoin-git> [bitcoin] MarcoFalke reopened pull request #19909: txmempool: Remove unused clear() member function (master...2009-noTxpoolClear) https://github.com/bitcoin/bitcoin/pull/19909
<gribble> https://github.com/bitcoin/bitcoin/issues/582 | Bitcoin-Qt signmessage GUI by luke-jr · Pull Request #582 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #20030: validation: Remove useless call to mempool->clear() (master...2009-valMemClear) https://github.com/bitcoin/bitcoin/pull/20030
<bitcoin-git> [bitcoin] fanquake merged pull request #24322: [kernel 1/n] Introduce initial `libbitcoinkernel` (master...2022-02-libbitcoinkernel-p1-minimal) https://github.com/bitcoin/bitcoin/pull/24322
<bitcoin-git> [bitcoin] fanquake pushed 12 commits to master: https://github.com/bitcoin/bitcoin/compare/e36c612e5a9b...dd17c42a1642
<bitcoin-git> bitcoin/master 1392e8e Carl Dong: build: Don't add unrelated libs to LIBTEST_*
<bitcoin-git> bitcoin/master 64caf94 Carl Dong: build: Remove vestigial LIBLEVELDB_SSE42
<bitcoin-git> bitcoin/master 05d1525 Carl Dong: build: Create .la library for crc32c
<laanwj> jamesob: i meann remmeber that we have an actual system call sandbox in bitcoin core, it's scary close to kernel hacking
<bitcoin-git> [bitcoin] fanquake merged pull request #24988: lint: Mention NONFATAL_UNREACHABLE in lint-assertions.py (master...2204-lint-abort-🐛) https://github.com/bitcoin/bitcoin/pull/24988
<bitcoin-git> bitcoin/master fa82a1e MacroFake: lint: Mention NONFATAL_UNREACHABLE in lint-assertions.py
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/85aea18ae660...e36c612e5a9b
<bitcoin-git> bitcoin/master e36c612 fanquake: Merge bitcoin/bitcoin#24988: lint: Mention NONFATAL_UNREACHABLE in lint-as...
<bitcoin-git> [bitcoin] laanwj opened pull request #25015: test: Use permissions from git in lint-files.py (master...2022-04-lint-permissions-git) https://github.com/bitcoin/bitcoin/pull/25015
<bitcoin-git> [bitcoin] laanwj merged pull request #24982: tests: Port `lint-all.sh` to `lint-all.py` (master...port_lint-all.sh_to_python) https://github.com/bitcoin/bitcoin/pull/24982
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b51e60f91472...85aea18ae660
<bitcoin-git> bitcoin/master 85aea18 laanwj: Merge bitcoin/bitcoin#24982: tests: Port `lint-all.sh` to `lint-all.py`
<bitcoin-git> bitcoin/master 29f44fe hiago: Converting `lint-all.sh` to `lint-all.py`.
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #22564: refactor: Move mutable globals cleared in `::UnloadBlockIndex` to `BlockManager` (master...2021-07-kirby-inhale-global-muts) https://github.com/bitcoin/bitcoin/pull/22564
<bitcoin-git> [bitcoin] MarcoFalke pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/9446de160f37...b51e60f91472
<bitcoin-git> bitcoin/master 5921b86 Carl Dong: init: Reset mempool and chainman via reconstruction
<bitcoin-git> bitcoin/master 98f4bda Carl Dong: refactor: Convert warningcache to std::array
<bitcoin-git> bitcoin/master 6e747e8 Anthony Towns: validation: default initialize and guard chainman members
<gribble> https://github.com/bitcoin/bitcoin/issues/25012 | doc: Update blurb in README.md by laanwj · Pull Request #25012 · bitcoin/bitcoin · GitHub
<laanwj> re: #25012 I really hoped to remove the 'whether bitcoin is experimental' concern from our repo once and for all, but seems it just comes back in a different form then, really, never mind
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25013: Remove cs_main from verifymessage, move msg utils to new file (master...2204-rpc-misc-🔌) https://github.com/bitcoin/bitcoin/pull/25013
<bitcoin-git> [bitcoin] laanwj closed pull request #25012: doc: Update blurb in README.md (master...2022-04-readme-blurb) https://github.com/bitcoin/bitcoin/pull/25012
<bitcoin-git> [bitcoin] laanwj opened pull request #25012: doc: Update blurb in README.md (master...2022-04-readme-blurb) https://github.com/bitcoin/bitcoin/pull/25012
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24831: tidy: add include-what-you-use (master...include_what_you_use) https://github.com/bitcoin/bitcoin/pull/24831
<bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/4381681e554d...9446de160f37
<bitcoin-git> bitcoin/master 74cd038 fanquake: refactor: fix includes in src/init
<bitcoin-git> bitcoin/master c79ad93 fanquake: refactor: fix includes in src/compat
<bitcoin-git> bitcoin/master 9b0a13a fanquake: tidy: Add include-what-you-use
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25011: tests: Do not always create a descriptor wallet in wallet_createwallet (master...fix-legacy-createwallet-test) https://github.com/bitcoin/bitcoin/pull/25011
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f0a834e2f10a...4381681e554d
<bitcoin-git> bitcoin/master 786b3a7 Andrew Chow: tests: Do not always create a descriptor wallet in wallet_createwallet
<bitcoin-git> bitcoin/master 4381681 MacroFake: Merge bitcoin/bitcoin#25011: tests: Do not always create a descriptor wall...

2022-04-27

<bitcoin-git> [bitcoin] achow101 opened pull request #25011: tests: Do not always create a descriptor wallet in wallet_createwallet (master...fix-legacy-createwallet-test) https://github.com/bitcoin/bitcoin/pull/25011
<Murch> Not if you're running a patched version of Bitcoin Core for some reason
<Murch> Definitely useful for downstream users. I would go over the list when I was evaluating whether a Bitcoin Core release may cause additional upgrade hurdles for the backend integration at my previous employer's
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #18642: Use std::chrono for the time to rotate destination of addr messages + tests (master...2020_04_mock_addr_rotation_time) https://github.com/bitcoin/bitcoin/pull/18642
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/132d5f8c2f23...f0a834e2f10a
<bitcoin-git> bitcoin/master f0a834e MacroFake: Merge bitcoin/bitcoin#18642: Use std::chrono for the time to rotate destin...
<bitcoin-git> bitcoin/master 77ccb7f Gleb Naumenko: Use std::chrono for salting when randomizing ADDR destination
<bitcoin-git> bitcoin/master 2ff8f4d Gleb Naumenko: Add tests for addr destination rotation
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25009: Crash debug builds on PCKG_MEMPOOL_ERROR (master...2204-crash-debug-🏦) https://github.com/bitcoin/bitcoin/pull/25009
<bitcoin-git> [bitcoin] fanquake opened pull request #25006: guix: consolidate kernel headers to 4.19, specify 3.2.0 as minimum supported (master...specify_minimum_kernel) https://github.com/bitcoin/bitcoin/pull/25006