2021-02-12

< bitcoin-git> [bitcoin] laanwj merged pull request #19145: Add hash_type MUHASH for gettxoutsetinfo (master...csi-3-muhash-rpc) https://github.com/bitcoin/bitcoin/pull/19145
< bitcoin-git> bitcoin/master 0d3b2f6 Fabian Jahr: rpc: Add hash_type MUHASH to gettxoutsetinfo
< bitcoin-git> bitcoin/master a1fccea Fabian Jahr: refactor: Improve encapsulation between MuHash3072 and Num3072
< bitcoin-git> bitcoin/master 2474645 Fabian Jahr: refactor: Separate hash and stats calculation in coinstats
< bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/937dfa839873...8d82eddee640
< bitcoin-git> [bitcoin] fanquake opened pull request #21159: test: fix sign comparison warning in socket tests (master...sign_compare_sock_tests) https://github.com/bitcoin/bitcoin/pull/21159

2021-02-11

< bitcoin-git> [bitcoin] jrawsthorne opened pull request #21158: lib: Add Taproot support to libconsensus (master...libconsensus_taproot) https://github.com/bitcoin/bitcoin/pull/21158
< bitcoin-git> [bitcoin] prayank23 opened pull request #21157: doc: Improve Tor docs (master...tor-docs-add) https://github.com/bitcoin/bitcoin/pull/21157
< bitcoin-git> [bitcoin] prayank23 closed pull request #21155: doc: Improve Tor docs (master...tor-docs-improve) https://github.com/bitcoin/bitcoin/pull/21155
< gribble> https://github.com/bitcoin/bitcoin/issues/21088 | guix: Jump forwards in time-machine and adapt by dongcarl · Pull Request #21088 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/2 | Long-term, safe, store-of-value · Issue #2 · bitcoin/bitcoin · GitHub
< core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
< gribble> https://github.com/bitcoin/bitcoin/issues/20273 | Extend support for nested commands to bitcoin-cli by jonasschnelli · Pull Request #20273 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16439 | cli/gui: support "@height" in place of blockhash for getblock on client side by ajtowns · Pull Request #16439 · bitcoin/bitcoin · GitHub
< sipa> if you guix, presumably you got it in a way you're comfortable with, and if you have that - regardless of how you did so - you can build a reproducible bitcoin core release binary
< warren> Should a goal of bitcoin's release reproduce the bootstrap of guix and challenge? Or you expect guix to be already somehow bootstrapped on your own?
< wumpus> hit some small snags but it they were my own fault (e.g. crap left behind in the build dir), and the issue reported https://github.com/bitcoin/bitcoin/pull/21089#issuecomment-777562303 here which seems to be harmless just spammy
< gribble> https://github.com/bitcoin/bitcoin/issues/21145 | Guix Release Transition Plan for 22.0 · Issue #21145 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19145 | Add hash_type MUHASH for gettxoutsetinfo by fjahr · Pull Request #19145 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20861 | BIP 350: Implement Bech32m and use it for v1+ segwit addresses by sipa · Pull Request #20861 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20726 | p2p: Add DISABLETX message for negotiating block-relay-only connections by sdaftuar · Pull Request #20726 · bitcoin/bitcoin · GitHub
< wumpus> https://github.com/bitcoin/bitcoin/projects/8 open: 7 blockers, no bugfixes, 2 chasing concept ACK
< wumpus> #bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik
< core-meetingbot> Meeting started Thu Feb 11 19:00:17 2021 UTC. The chair is wumpus. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
< bitcoin-git> [bitcoin] laanwj merged pull request #21041: log: Move "Pre-allocating up to position 0x[…] in […].dat" log message to debug category (master...pre-allocation-up-to-position-0xff-in-foo.dat) https://github.com/bitcoin/bitcoin/pull/21041
< bitcoin-git> bitcoin/master 937dfa8 Wladimir J. van der Laan: Merge #21041: log: Move "Pre-allocating up to position 0x[…] in […].dat" l...
< bitcoin-git> bitcoin/master 25f899c practicalswift: log: Move "Pre-allocating up to position 0x[...] in [...].dat" log message...
< bitcoin-git> bitcoin/master acd7980 practicalswift: log: Move "Leaving block file [...]: [...]" log message to debug category
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/0ad46567905a...937dfa839873
< dongcarl> MarcoFalke: You can most likely garbage collect and get some space back. One thing on my list is to pin the latest manifest output so that it doesn't get garbage collected, so that you can safely garbage collect everything else without affecting bitcoin builds
< bitcoin-git> [bitcoin] prayank23 opened pull request #21155: doc: Improve Tor docs (master...tor-docs-improve) https://github.com/bitcoin/bitcoin/pull/21155
< dongcarl> FWIW: All guix package builds are offline (enforced by network namespaces I think) and hermetic. The bitcoin build script I wrote also builds in a completely offline environment by default.
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20370: fuzz: version handshake (master...2011-fuzzNetFlags) https://github.com/bitcoin/bitcoin/pull/20370
< bitcoin-git> bitcoin/master 0ad4656 MarcoFalke: Merge #20370: fuzz: version handshake
< bitcoin-git> bitcoin/master fabce45 MarcoFalke: fuzz: version handshake
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8e1913ae025a...0ad46567905a
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21062: refactor: return MempoolAcceptResult from ATMP (master...2021-02-refactor-validation) https://github.com/bitcoin/bitcoin/pull/21062
< bitcoin-git> bitcoin/master 174cb53 gzhao408: [refactor] const ATMPArgs and non-const Workspace
< bitcoin-git> bitcoin/master f82baf0 gzhao408: [refactor] return MempoolAcceptResult
< bitcoin-git> bitcoin/master 9db10a5 gzhao408: [refactor] clean up logic in testmempoolaccept
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/a1be08405d9b...8e1913ae025a
< bitcoin-git> bitcoin/master ba9d732 Vasil Dimov: net: add RAII socket and use it instead of bare SOCKET
< bitcoin-git> [bitcoin] laanwj merged pull request #20788: net: add RAII socket and use it instead of bare SOCKET (master...sock) https://github.com/bitcoin/bitcoin/pull/20788
< bitcoin-git> bitcoin/master dec9b5e Vasil Dimov: net: move CloseSocket() from netbase to util/sock
< bitcoin-git> bitcoin/master aa17a44 Vasil Dimov: net: move MillisToTimeval() from netbase to util/time
< bitcoin-git> [bitcoin] laanwj pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/685c16fcb2c7...a1be08405d9b
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21043: net: Avoid UBSan warning in ProcessMessage(...) (master...ubsan-nTime) https://github.com/bitcoin/bitcoin/pull/21043
< bitcoin-git> bitcoin/master 685c16f MarcoFalke: Merge #21043: net: Avoid UBSan warning in ProcessMessage(...)
< bitcoin-git> bitcoin/master 3ddbf22 MarcoFalke: util: Disallow negative mocktime
< bitcoin-git> bitcoin/master f5f2f97 practicalswift: net: Avoid UBSan warning in ProcessMessage(...)
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/e498aeffbec9...685c16fcb2c7
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20211: Use -Wswitch for TxoutType where possible (master...2010-WswitchTxoutType) https://github.com/bitcoin/bitcoin/pull/20211
< bitcoin-git> bitcoin/master e498aef MarcoFalke: Merge #20211: Use -Wswitch for TxoutType where possible
< bitcoin-git> bitcoin/master fa650ca MarcoFalke: Use -Wswitch for TxoutType where possible
< bitcoin-git> bitcoin/master fa59e0b MarcoFalke: test: Add missing script_standard_Solver_success cases
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/a59e7ed0bc34...e498aeffbec9
< prusnak> dongcarl: is there a Guix Docker image or what's the preferred way to build bitcoin w/ guix on macos ?
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20915: fuzz: Fail if message type is not fuzzed (master...2101-fuzzFailMsgType) https://github.com/bitcoin/bitcoin/pull/20915
< bitcoin-git> bitcoin/master a59e7ed MarcoFalke: Merge #20915: fuzz: Fail if message type is not fuzzed
< bitcoin-git> bitcoin/master fa4bc89 MarcoFalke: fuzz: Fail if message type is not fuzzed
< bitcoin-git> bitcoin/master faefed8 MarcoFalke: fuzz: Count message type fuzzers before main()
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/dd0521b6408a...a59e7ed0bc34
< michaelfolkson> ishaqm: Does this answer your question? Please upvote if you find it useful https://bitcoin.stackexchange.com/questions/66892/what-are-the-debug-categories
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21023: fuzz: Disable shuffle when merge=1 (master...2101-fuzzMerge) https://github.com/bitcoin/bitcoin/pull/21023
< bitcoin-git> bitcoin/master dd0521b MarcoFalke: Merge #21023: fuzz: Disable shuffle when merge=1
< bitcoin-git> bitcoin/master fabeb5b MarcoFalke: fuzz: Disable shuffle when merge=1
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b69eab902567...dd0521b6408a
< ishaqm> all, does anyone have pointers on compiling bitcoin-core with DEBUG symbols on?
< bitcoin-git> bitcoin/master b69eab9 MarcoFalke: Merge #20663: fuzz: Hide script_assets_test_minimizer
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20663: fuzz: Hide script_assets_test_minimizer (master...2012-fuzzNoReg) https://github.com/bitcoin/bitcoin/pull/20663
< bitcoin-git> bitcoin/master fac726b MarcoFalke: doc: Fixup docs in fuzz/script_assets_test_minimizer.cpp
< bitcoin-git> bitcoin/master fafca47 MarcoFalke: fuzz: Hide script_assets_test_minimizer
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/deb185d2fdcd...b69eab902567
< fanquake> achow: For doing a build of Bitcoin Core, something like: env ADDITIONAL_GUIX_COMMON_FLAGS='--no-substitutes --keep-failed' ADDITIONAL_GUIX_ENVIRONMENT_FLAGS='--bootstrap' `./contrib/guix/guix-build.sh (which will build for all hosts)
< gribble> https://github.com/bitcoin/bitcoin/issues/232527 | HTTP Error 404: Not Found
< dongcarl> sipa: what commit are you on in bitcoin?
< bitcoin-git> [bitcoin] ajtowns opened pull request #21148: Split orphan handling from net_processing into txorphanage (master...202102-txorphanage) https://github.com/bitcoin/bitcoin/pull/21148

2021-02-10

< bitcoin-git> [bitcoin] glozow opened pull request #21146: [WIP] validation/coins: limit MemPoolAccept access to coins cache (master...2021-02-coinsviews) https://github.com/bitcoin/bitcoin/pull/21146
< gribble> https://github.com/bitcoin/bitcoin/issues/21145 | Guix Release Transition Plan for 22.0 · Issue #21145 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] danben opened pull request #21144: test: convert feature_bip_sequence.py to use MiniWallet (master...test-feature-bip68-sequence-without-wallet) https://github.com/bitcoin/bitcoin/pull/21144
< Kiminuo> but then you hit differences between std::fs and boost::fs (https://github.com/bitcoin/bitcoin/pull/19245)
< Kimi> phantomcircuit, Is this what you are looking for https://github.com/bitcoin/bitcoin/pull/20744?
< gribble> https://github.com/bitcoin/bitcoin/issues/19145 | Add hash_type MUHASH for gettxoutsetinfo by fjahr · Pull Request #19145 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj merged pull request #21130: script: Make LXC container size suitable for gitian builds (master...210209-lxc) https://github.com/bitcoin/bitcoin/pull/21130
< bitcoin-git> bitcoin/master deb185d Wladimir J. van der Laan: Merge #21130: script: Make LXC container size suitable for gitian builds
< bitcoin-git> bitcoin/master 166266a Hennadii Stepanov: script: Make LXC container size suitable for gitian builds
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3c514cfe628d...deb185d2fdcd
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21142: fuzz: Add tx_pool fuzz target (master...2102-fuzzPool) https://github.com/bitcoin/bitcoin/pull/21142
< bitcoin-git> [bitcoin] laanwj merged pull request #21114: Deduplicate some block-to-JSON code (master...getblock-dedup) https://github.com/bitcoin/bitcoin/pull/21114
< bitcoin-git> bitcoin/master fa2c521 Daniel Kraft: Deduplicate some block-to-JSON code.
< bitcoin-git> bitcoin/master 3c514cf Wladimir J. van der Laan: Merge #21114: Deduplicate some block-to-JSON code
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b3dda0af0ea0...3c514cfe628d
< bitcoin-git> [bitcoin] laanwj merged pull request #21123: code style: Add EditorConfig file (master...feature/editorconfig) https://github.com/bitcoin/bitcoin/pull/21123
< bitcoin-git> bitcoin/master b3dda0a Wladimir J. van der Laan: Merge #21123: code style: Add EditorConfig file
< bitcoin-git> bitcoin/master 7a135d5 Kiminuo: Add EditorConfig file.
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cda914228a56...b3dda0af0ea0
< bitcoin-git> [bitcoin] maayank opened pull request #21141: Add new format string placeholders for walletnotify (master...walletnotify-blockhash) https://github.com/bitcoin/bitcoin/pull/21141
< bitcoin-git> [bitcoin] fanquake merged pull request #21138: ci: Re-run wine tests once if they fail (master...2102-ciWin) https://github.com/bitcoin/bitcoin/pull/21138
< bitcoin-git> bitcoin/master faa8afe MarcoFalke: ci: Re-run wine tests once if they fail
< bitcoin-git> bitcoin/master cda9142 fanquake: Merge #21138: ci: Re-run wine tests once if they fail
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f61c3a109098...cda914228a56
< wumpus> after, it appears: https://github.com/bitcoin/bitcoin/blob/master/contrib/gitian-descriptors/gitian-linux.yml (at least i suppose it's the split-debug step)
< wumpus> bitcoind has 39360 and bitcoin-cli has 2665 (with fcf, will try without now)
< fanquake> Sure. By different binaries I also meant bitcoind, bitcoin-wallet, bitcoin-util etc. As any sort of counting thresholds will be different
< wumpus> fanquake: https://github.com/bitcoin/bitcoin/pull/21135/files#r573609698 I kind of want to implement this with binary pattern matching now :)
< hebasto> jonasschnelli: done in https://github.com/bitcoin-core/docs/pull/71
< bitcoin-git> [bitcoin] hebasto opened pull request #21140: script: Drop KVM support in gitian-build.py (master...210210-kvm) https://github.com/bitcoin/bitcoin/pull/21140
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21125: test: Change BOOST_CHECK to BOOST_CHECK_EQUAL for paths (master...feature/boost-equal) https://github.com/bitcoin/bitcoin/pull/21125
< bitcoin-git> bitcoin/master f61c3a1 MarcoFalke: Merge #21125: test: Change BOOST_CHECK to BOOST_CHECK_EQUAL for paths
< bitcoin-git> bitcoin/master 059e8cc Kiminuo: Change BOOST_CHECK to BOOST_CHECK_EQUAL to see mismatched values when a ch...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/09530b0255ab...f61c3a109098
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #21139: doc: Add missing copyright header to util/getuniquepath (master...2102-c) https://github.com/bitcoin/bitcoin/pull/21139
< vasild> yeah, I specifically avoid printing the full i2p destination in bitcoin debug.log: https://github.com/vasild/bitcoin/blob/i2p_sam/src/i2p.cpp#L283-L284
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21139: doc: Add missing copyright header to util/getuniquepath (master...2102-c) https://github.com/bitcoin/bitcoin/pull/21139
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21138: ci: Re-run wine tests once if they fail (master...2102-ciWin) https://github.com/bitcoin/bitcoin/pull/21138
< bitcoin-git> [bitcoin] fanquake opened pull request #21135: scripts: check for control flow instrumentation in security-check.py (master...security_check_cf_protection) https://github.com/bitcoin/bitcoin/pull/21135
< bitcoin-git> [bitcoin] mint-young closed pull request #21134: Ecc 0.1.2 (master...ecc-0.1.2) https://github.com/bitcoin/bitcoin/pull/21134
< bitcoin-git> [bitcoin] mint-young opened pull request #21134: Ecc 0.1.2 (master...ecc-0.1.2) https://github.com/bitcoin/bitcoin/pull/21134
< bitcoin-git> [bitcoin] fanquake merged pull request #21126: ci: Properly bump to focal for win cross build (master...2102-ciWin) https://github.com/bitcoin/bitcoin/pull/21126
< bitcoin-git> bitcoin/master 09530b0 fanquake: Merge #21126: ci: Properly bump to focal for win cross build
< bitcoin-git> bitcoin/master fa272df MarcoFalke: ci: Properly bump to focal for win cross build
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d202054675c9...09530b0255ab

2021-02-09

< jonatack> i don't think any other config was needed: https://github.com/bitcoin/bitcoin/pull/20685#issuecomment-761799484
< bitcoin-git> [bitcoin] laanwj merged pull request #21052: refactor: Replace fs::unique_path with GetUniquePath(path) calls (master...feature/fs-unique-path) https://github.com/bitcoin/bitcoin/pull/21052
< bitcoin-git> bitcoin/master d202054 Wladimir J. van der Laan: Merge #21052: refactor: Replace fs::unique_path with GetUniquePath(path) c...
< bitcoin-git> bitcoin/master 1bca2aa Kiminuo: Introduce GetUniquePath(base) helper method to replace boost::filesystem::...
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d48f9e8ebbb7...d202054675c9
< jonatack> bitcoin conf : i2psam=127.0.0.1:7656 and i2pacceptincoming=1
< jonatack> wumpus: idk, i2pd is the only one i've managed to have running with bitcoin
< jonatack> wumpus: vasild: I've been using i2pd these past weeks, been working well for me. apt install i2pd / systemctl enable i2pd.service / systemctl start i2pd.service, update bitcoin.conf, done
< prayank> luke-jr: sad but I will keep trying my best with my contribution and wumpus: Bitcoin Stackexchange is used as reference for lot of things/discussion including Bitcoin Core issues and PRs.
< michaelfolkson> Right #bitcoin
< luke-jr> prayank: Bitcoin's Stackexchange has a history of misinformation
< prayank> wumpus: I think we were discussing about positives of Bitcoin Stackexchange few days back. Sad to see one of the moderators mentioning specific altcoins in answers when it could have been avoided. One of the altcoin mentioned in this answer has few people associated with it who spread misinformation about Bitcoin. And we have people with good reputation making these altcoins sound legit by mentioning in the answers.
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21124: test: remove unnecessary assignment in bdb (master...fix-bdb-test) https://github.com/bitcoin/bitcoin/pull/21124
< bitcoin-git> bitcoin/master d48f9e8 MarcoFalke: Merge #21124: test: remove unnecessary assignment in bdb
< bitcoin-git> bitcoin/master c9095b7 Bruno Garcia: test: remove unnecessary assignment in bdb
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b847f49717d1...d48f9e8ebbb7
< bitcoin-git> [bitcoin] hebasto opened pull request #21130: script: Make LXC container size suitable for gitian builds (master...210209-lxc) https://github.com/bitcoin/bitcoin/pull/21130
< bitcoin-git> [bitcoin] fanquake closed pull request #21128: doc: Update Whitepaper link in README.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/21128
< bitcoin-git> [bitcoin] vasild opened pull request #21129: fuzz: check that ser+unser produces the same AddrMan (master...fuzz_addrman_serunser) https://github.com/bitcoin/bitcoin/pull/21129
< michaelfolkson> The history on rebroadcast is a great idea https://github.com/amitiuttarwar/bitcoin-notes/blob/main/rebroadcast-history.md
< gribble> https://github.com/bitcoin/bitcoin/issues/20758 | net-processing refactoring -- lose globals, move implementation details from .h to .cpp by ajtowns · Pull Request #20758 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20788 | net: add RAII socket and use it instead of bare SOCKET by vasild · Pull Request #20788 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20942 | [refactor] Move some net_processing globals into PeerManagerImpl by ajtowns · Pull Request #20942 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20277 | p2p: Stop processing unrequested transactions and extend p2p_ibd_txrelay.py coverage by ariard · Pull Request #20277 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20788 | net: add RAII socket and use it instead of bare SOCKET by vasild · Pull Request #20788 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20685 | Add I2P support using I2P SAM by vasild · Pull Request #20685 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/21121 | [test] Small unit test improvements, including helper to make mempool transaction by amitiuttarwar · Pull Request #21121 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/21061 | [p2p] Introduce node rebroadcast module by amitiuttarwar · Pull Request #21061 · bitcoin/bitcoin · GitHub
< gleb> michaelfolkson. That's erlay. Minisketch have no idea about bitcoin or transactions and just operates over sets of numbers.
< aj> should it be bitcoin-core/minisketch?
< gribble> https://github.com/bitcoin/bitcoin/issues/18261 | Erlay: bandwidth-efficient transaction relay protocol by naumenkogs · Pull Request #18261 · bitcoin/bitcoin · GitHub
< jnewbery> sipa: ok, so you think it still needs review before merging into Bitcoin Core? Would it therefore make sense to split it into a separate PR?
< gribble> https://github.com/bitcoin/bitcoin/issues/18261 | Erlay: bandwidth-efficient transaction relay protocol by naumenkogs · Pull Request #18261 · bitcoin/bitcoin · GitHub
< jnewbery> To enter Bitcoin Core your PR must have this much <----------------->
< michaelfolkson> I'll probably spend tomorrow looking at Erlay before the PR review club (on UK time so review club is evening for me). Will be on the bitcoin-core-pr-reviews channel trying to avoid the questions set for the review club session
< jnewbery> #bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik petertodd
< bitcoin-git> [bitcoin] SteversIO opened pull request #21128: Update Whitepaper link in README.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/21128
< bitcoin-git> [bitcoin] Sjors opened pull request #21127: wallet: load flags before everything else (master...2021/02/wallet_flags) https://github.com/bitcoin/bitcoin/pull/21127
< jnewbery> Feel free to update your priorities here: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-Current-Priorities to let people know what you're working on.
< jnewbery> Hi folks. Reminder that we have a p2p meeting in half an hour. There are currently no topics in the meeting page: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings.
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21126: ci: Properly bump to focal for win cross build (master...2102-ciWin) https://github.com/bitcoin/bitcoin/pull/21126
< bitcoin-git> [bitcoin] kiminuo opened pull request #21125: test: Change BOOST_CHECK to BOOST_CHECK_EQUAL (master...feature/boost-equal) https://github.com/bitcoin/bitcoin/pull/21125
< jonatack_> for a few days, gh pr view 20557 -c would show everything. now, for the detailed review comments it instead displays, "View the full review: https://github.com/bitcoin/bitcoin/pull/20557#pullrequestreview-586080477"
< bitcoin-git> [bitcoin] brunoerg opened pull request #21124: test: remove unnecessary assignment in bdb (master...fix-bdb-test) https://github.com/bitcoin/bitcoin/pull/21124
< bitcoin-git> [bitcoin] laanwj merged pull request #20557: addrman: Fix new table bucketing during unserialization (master...2020-12-fix-addrman-bucketing) https://github.com/bitcoin/bitcoin/pull/20557
< bitcoin-git> bitcoin/master 8062d92 John Newbery: [addrman] Rename asmap version to asmap checksum
< bitcoin-git> bitcoin/master 009b8e0 John Newbery: [addrman] Improve variable naming/code style of touched code.
< bitcoin-git> [bitcoin] laanwj pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/3641ec1aacfe...b847f49717d1
< bitcoin-git> bitcoin/master b4c5fda John Newbery: [addrman] Fix new table bucketing during unserialization
< jnewbery> wumpus: I think https://github.com/bitcoin/bitcoin/pull/20557 is RFM. ACKs on latest version from ryanofsky, dhruv, naumenkogs, glozow, vasild.
< bitcoin-git> [bitcoin] kiminuo opened pull request #21123: code style: Add EditorConfig file (master...feature/editorconfig) https://github.com/bitcoin/bitcoin/pull/21123
< Kiminuo> Hi, would you mind sharing what IDE/editors you use for Bitcoin Core development?
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21112: ci: use Focal for macOS cross builds (master...actually_use_focal_in_cirrus_ci) https://github.com/bitcoin/bitcoin/pull/21112
< bitcoin-git> bitcoin/master 3641ec1 MarcoFalke: Merge #21112: ci: use Focal for macOS cross builds
< bitcoin-git> bitcoin/master ac24af4 fanquake: ci: use Ubuntu Focal for macOS cross build
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/19b1ceddc716...3641ec1aacfe
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21075: doc: Fix markdown formatting (master...patch-1) https://github.com/bitcoin/bitcoin/pull/21075
< bitcoin-git> bitcoin/master 19b1ced MarcoFalke: Merge #21075: doc: Fix markdown formatting
< bitcoin-git> bitcoin/master e1604b3 Gunar C. Gessner: doc: Replace tabs for spaces
< bitcoin-git> bitcoin/master 98db48d Gunar Gessner: doc: Fix markdown formatting
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c4214d0e0df0...19b1ceddc716
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21117: test: remove assert_blockchain_height (master...2102-testNoTimeout) https://github.com/bitcoin/bitcoin/pull/21117
< bitcoin-git> bitcoin/master c4214d0 MarcoFalke: Merge #21117: test: remove assert_blockchain_height
< bitcoin-git> bitcoin/master fa0a4d6 MarcoFalke: test: remove assert_blockchain_height
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a0077a80b054...c4214d0e0df0
< bitcoin-git> [bitcoin] fanquake merged pull request #21116: build: Disable --disable-fuzz-binary for gitian/guix builds (master...210208-fuzz) https://github.com/bitcoin/bitcoin/pull/21116
< bitcoin-git> bitcoin/master a0077a8 fanquake: Merge #21116: build: Disable --disable-fuzz-binary for gitian/guix builds
< bitcoin-git> bitcoin/master fd7caae Hennadii Stepanov: build: Disable --disable-fuzz-binary for gitian builds
< bitcoin-git> bitcoin/master cb151b7 Hennadii Stepanov: build: Disable --disable-fuzz-binary for guix builds
< bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d8646966497f...a0077a80b054
< bitcoin-git> [bitcoin] fanquake merged pull request #21115: test: Fix Windows cross build (master...210208-win) https://github.com/bitcoin/bitcoin/pull/21115
< bitcoin-git> bitcoin/master d864696 fanquake: Merge #21115: test: Fix Windows cross build
< bitcoin-git> bitcoin/master 723eb43 Hennadii Stepanov: test: Fix Windows cross build
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b09ad737eef6...d8646966497f
< bioverse> Anyway, do you think bitcoin can be used in the future for time-lock encryption?
< sipa> this channel is for development; you may get better help on https://bitcoin.stackexchange.com (but search for relevant questions first)
< bioverse> I have a nano ledger s with some bitcoin. I have the 24 words and wallet in a safe place. I went to https://iancoleman.io/bip39/ using a Ubuntu live from USB. I put the 24 mnemonic words and could not find any bitcoin address ever used. I freaked. I thought. Oh my god! I ordered a second brand new nano ledger s. Put the 24 words, using ledger live in a brand new laptop and my coins were there in the brand new ledger nano s. I am safe. But I have
< kallewoof> can someone with bitcoin-core rights enable cirrus CI for btcdeb repo? i can't find the option so I assume I'm not allowed

2021-02-08

< wumpus> looks like i can at least fully reproduce the hashes here: https://github.com/bitcoin/bitcoin/pull/21036#issuecomment-774522683 so it seems deterministic locally
< bitcoin-git> bitcoin/master b09ad73 MarcoFalke: Merge #20944: rpc: Return total fee in getmempoolinfo
< bitcoin-git> bitcoin/master fa36206 MarcoFalke: rpc: Return total fee in mempool
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b401b093556f...b09ad737eef6
< bitcoin-git> [bitcoin] amitiuttarwar opened pull request #21121: [test] Small unit test improvements, including helper to make mempool transaction (master...2021-01-unit-test-valid-tx) https://github.com/bitcoin/bitcoin/pull/21121
< gribble> https://github.com/bitcoin/bitcoin/issues/21036 | gitian: Bump descriptors to Focal for 22.0 by fanquake · Pull Request #21036 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21117: test: remove assert_blockchain_height (master...2102-testNoTimeout) https://github.com/bitcoin/bitcoin/pull/21117
< gribble> https://github.com/bitcoin/bitcoin/issues/21036 | gitian: Bump descriptors to Focal for 22.0 by fanquake · Pull Request #21036 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] hebasto opened pull request #21116: build: Disable --disable-fuzz-binary for gitian builds (master...210208-fuzz) https://github.com/bitcoin/bitcoin/pull/21116
< bitcoin-git> [bitcoin] hebasto opened pull request #21115: test: Fix Windows cross build (master...210208-win) https://github.com/bitcoin/bitcoin/pull/21115
< bitcoin-git> [bitcoin] domob1812 opened pull request #21114: Deduplicate some block-to-JSON code (master...getblock-dedup) https://github.com/bitcoin/bitcoin/pull/21114
< bitcoin-git> [bitcoin] fanquake opened pull request #21112: ci: use Focal for macOS and Win cross builds (master...actually_use_focal_in_cirrus_ci) https://github.com/bitcoin/bitcoin/pull/21112
< bitcoin-git> [bitcoin] parazyd opened pull request #21111: Improve OpenRC initscript (master...openrc-init-improve) https://github.com/bitcoin/bitcoin/pull/21111
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21107: test: remove type: comments in favour of actual annotations (master...just_use_typing_directly) https://github.com/bitcoin/bitcoin/pull/21107
< bitcoin-git> bitcoin/master b401b09 MarcoFalke: Merge #21107: test: remove type: comments in favour of actual annotations
< bitcoin-git> bitcoin/master 9913419 fanquake: test: remove type: comments in favour of actual annotations
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ca85449f22cb...b401b093556f
< wumpus> shesek: these kind of proposals are as old as bitcoin itself but i don't think anyone ever solved the 'who to trust' issue, how can you have infrastructure that gives you a reasonable confidence in that a certain validation is correct, like you can probably just copy a friend's node and trust them but yo udefinitely don't want to YOLO it off the internet
< gribble> https://github.com/bitcoin/bitcoin/issues/21036 | gitian: Bump descriptors to Focal for 22.0 by fanquake · Pull Request #21036 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake opened pull request #21110: util: remove Boost posix_time usage from GetTime* (master...no_boost_gettime) https://github.com/bitcoin/bitcoin/pull/21110
< bitcoin-git> bitcoin/master ca85449 MarcoFalke: Merge #21036: gitian: Bump descriptors to Focal for 22.0
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21036: gitian: Bump descriptors to Focal for 22.0 (master...gitian_bump_22_0) https://github.com/bitcoin/bitcoin/pull/21036
< bitcoin-git> bitcoin/master 2ecaf21 fanquake: gitian: remove execstack workaround for ricv64 & powerpc64le
< bitcoin-git> bitcoin/master 5baff2b fanquake: build: use focal in gitian descriptors
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c969ab43c388...ca85449f22cb
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21084: test: fix timeout decrease in feature_assumevalid (master...fix-timeout-assumevalid) https://github.com/bitcoin/bitcoin/pull/21084
< bitcoin-git> bitcoin/master 0d39b58 Bruno Garcia: test: fix timeout decrease in feature_assumevalid
< bitcoin-git> bitcoin/master c969ab4 MarcoFalke: Merge #21084: test: fix timeout decrease in feature_assumevalid
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e51f6c4dee3d...c969ab43c388
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20936: build: build fuzz tests by default (master...build-fuzz-tests-by-default) https://github.com/bitcoin/bitcoin/pull/20936
< bitcoin-git> bitcoin/master 32cbb06 Dan Benjamin: build: build fuzz tests by default.
< bitcoin-git> bitcoin/master e51f6c4 MarcoFalke: Merge #20936: build: build fuzz tests by default
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8636288db130...e51f6c4dee3d
< shesek> would be useful if bitcoin-cli had a timeout argument btw. I'm using the `timeout` program as a workaround
< shesek> what about startup? how long would you give `bitcoin-cli -rpcwait` to try before realizing its not going to happen?
< bitcoin-git> [bitcoin] fanquake merged pull request #20720: build: more robustly check for fcf-protection support (master...more_robust_fcf_protection) https://github.com/bitcoin/bitcoin/pull/20720
< bitcoin-git> bitcoin/master 8636288 fanquake: Merge #20720: build: more robustly check for fcf-protection support
< bitcoin-git> bitcoin/master e9189a7 fanquake: build: more robustly check for fcf-protection support
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cf26ca3911f3...8636288db130
< bitcoin-git> [bitcoin] fanquake opened pull request #21107: test: remove type: comments in favour of actual annotations (master...just_use_typing_directly) https://github.com/bitcoin/bitcoin/pull/21107
< bitcoin-git> [bitcoin] fanquake merged pull request #21081: test: fix the unreachable code at feature_taproot (master...taproot-test-return) https://github.com/bitcoin/bitcoin/pull/21081
< bitcoin-git> bitcoin/master cf26ca3 fanquake: Merge #21081: test: fix the unreachable code at feature_taproot
< bitcoin-git> bitcoin/master 5e0cd25 Bruno Garcia: fix the unreachable code at feature_taproot
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1815847103c2...cf26ca3911f3
< bitcoin-git> [bitcoin] fanquake merged pull request #21105: docs: correctly identify script type (master...nifty/spelling-nit) https://github.com/bitcoin/bitcoin/pull/21105
< bitcoin-git> bitcoin/master 4ed064d lisa neigut: docs: correctly identify script type
< bitcoin-git> bitcoin/master 1815847 fanquake: Merge #21105: docs: correctly identify script type
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6c6140846f37...1815847103c2

2021-02-07

< sipa> go to https://bitcoin.stackexchange.com for further questions
< Galvas> I already did but they were selling bitcoin and talking about shitcoins instead 😅
< phantomcircuit> Galvas, this channel is for development, can you ask in #bitcoin instead
< Galvas> LevelDB read failure: Corruption: block checksum mismatch: /home/caiof/.bitcoin/chainstate/330518.ldb
< bitcoin-git> [bitcoin] pstratem opened pull request #21106: add timeout to initial block download (master...2021-02-07-isinitialblockdownload-timeout) https://github.com/bitcoin/bitcoin/pull/21106
< bitcoin-git> [bitcoin] niftynei opened pull request #21105: docs: correctly identify script type (master...nifty/spelling-nit) https://github.com/bitcoin/bitcoin/pull/21105
< bitcoin-git> [bitcoin] wodry opened pull request #21102: Log debug log category (master...log-debug-category) https://github.com/bitcoin/bitcoin/pull/21102
< bitcoin-git> [bitcoin] theStack opened pull request #21100: test: remove unused function xor_bytes (master...2021-test-remove_unused_xor_bytes) https://github.com/bitcoin/bitcoin/pull/21100
< bitcoin-git> [bitcoin] fanquake closed pull request #21097: Fix original whitepaper address (master...eribertomota-fix-url) https://github.com/bitcoin/bitcoin/pull/21097
< bitcoin-git> [bitcoin] eribertomota opened pull request #21097: Fix original whitepaper address (master...eribertomota-fix-url) https://github.com/bitcoin/bitcoin/pull/21097

2021-02-06

< bitcoin-git> [bitcoin] flack opened pull request #21096: Re-add dead code detection (master...resurrect-vulture) https://github.com/bitcoin/bitcoin/pull/21096
< Kiminuo> wumpus, Hi, this is a follow up to the .editorconfig discussion, if you are interested: https://github.com/bitcoin/bitcoin/issues/21092
< sdaftuar> anyone know if CI failures related to fuzzing are a known problem? not sure what to make of this: https://github.com/bitcoin/bitcoin/pull/20726/checks?check_run_id=1833243226
< gribble> https://github.com/bitcoin/bitcoin/issues/21036 | gitian: Bump descriptors to Focal for 22.0 by fanquake · Pull Request #21036 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sipa closed pull request #21091: *#67# phone Create AmancioJSilvJr (master...patch-1) https://github.com/bitcoin/bitcoin/pull/21091
< bitcoin-git> [bitcoin] amanciojsilvjr opened pull request #21091: *#67# phone Create AmancioJSilvJr (master...patch-1) https://github.com/bitcoin/bitcoin/pull/21091
< Bobby123> does anyone by chance know of a bitcoin nonce dataset?

2021-02-05

< bitcoin-git> [bitcoin] dhruv opened pull request #21090: Default to NODE_WITNESS in nLocalServices (master...default-to-node-witness-2021) https://github.com/bitcoin/bitcoin/pull/21090
< bitcoin-git> [bitcoin] dongcarl opened pull request #21089: guix: Add support for powerpc64{,le} (master...2021-02-guix-ppc64-support) https://github.com/bitcoin/bitcoin/pull/21089
< bitcoin-git> [bitcoin] dongcarl opened pull request #21088: guix: Jump forwards in time-machine and adapt (master...2021-02-bump-time-machine) https://github.com/bitcoin/bitcoin/pull/21088
< bitcoin-git> [bitcoin] dongcarl opened pull request #21087: guix: Passthrough BASE_CACHE into container (master...2020-12-guix-base-cache) https://github.com/bitcoin/bitcoin/pull/21087
< dongcarl> copumpkin: Sure, happy to chat, we can also go to #bitcoin-builds, where bitcoin build systems people hang out :-)
< dongcarl> Hi copumpkin, the main (by a large margin) reason is because of Guix's commitment towards bootstrappability at the time I was investigating it as a possible build system for Bitcoin. At that time I had used Nix for a couple of years, and would have preferred to use Nix due to familiarity, but unfortunately there was less of an effort to make it
< copumpkin> is there a writeup somewhere on guix vs. nix from a bitcoin dev perspective?
< bitcoin-git> bitcoin/master 506e658 Jon Atack: gui: display plain "Inbound" in peer details
< bitcoin-git> bitcoin/master 6c61408 Jonas Schnelli: Merge bitcoin-core/gui#203: Display plain "Inbound" in peer details
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/173cf31299eb...6c6140846f37
< bitcoin-git> [gui] jonasschnelli merged pull request #203: Display plain "Inbound" in peer details (master...display-plain-inbound-and-add-release-notes) https://github.com/bitcoin-core/gui/pull/203
< gribble> https://github.com/bitcoin/bitcoin/issues/21036 | gitian: Bump descriptors to Focal for 22.0 by fanquake · Pull Request #21036 · bitcoin/bitcoin · GitHub
< bitcoin-git> [gui] jonatack closed pull request #201: gui: ensure inbound block relay peers have relevant services (master...inbound-block-relay) https://github.com/bitcoin-core/gui/pull/201
< bitcoin-git> bitcoin/master 173cf31 Wladimir J. van der Laan: Merge #20839: fuzz: Avoid extraneous copy of input data, using Span<>
< bitcoin-git> [bitcoin] laanwj merged pull request #20839: fuzz: Avoid extraneous copy of input data, using Span<> (master...2101-fuzzSpan) https://github.com/bitcoin/bitcoin/pull/20839
< bitcoin-git> bitcoin/master faf7d74 MarcoFalke: fuzz: Avoid extraneous copy of input data, using Span<>
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b829894f8483...173cf31299eb
< bitcoin-git> [bitcoin] laanwj merged pull request #20764: cli -netinfo peer connections dashboard updates 🎄 ✨ (master...netinfo-updates-dec-2020) https://github.com/bitcoin/bitcoin/pull/20764
< bitcoin-git> bitcoin/master 5de7a6c Jon Atack: netinfo: display manual peers count
< bitcoin-git> bitcoin/master d3cca3b Jon Atack: netinfo: update to use peer connection types
< bitcoin-git> bitcoin/master 62bf5b7 Jon Atack: netinfo: add ConnectionTypeForNetinfo member helper function