< bitcoin-git>
[bitcoin] laanwj merged pull request #21026: doc: Document use of make-tag script to make tags (master...2021-01-make-tag) https://github.com/bitcoin/bitcoin/pull/21026
< bitcoin-git>
bitcoin/master 56fcf93 Wladimir J. van der Laan: Merge #21026: doc: Document use of make-tag script to make tags
< bitcoin-git>
bitcoin/master cc30dfb Wladimir J. van der Laan: doc: Document use of make-tag script to make tags
< bitcoin-git>
[gui] hebasto closed pull request #87: Choose monospaced font in C++ code rather in `*.ui` file (master...200910-mono) https://github.com/bitcoin-core/gui/pull/87
< bitcoin-git>
[gui] hebasto opened pull request #207: scripted-diff: Use Courier New as tabular figures font in Overview page (master...210201-mono) https://github.com/bitcoin-core/gui/pull/207
< bitcoin-git>
[bitcoin] laanwj merged pull request #20749: [Bundle 1/n] Prune g_chainman usage related to ::LookupBlockIndex (master...2020-09-libbitcoinruntime-v4) https://github.com/bitcoin/bitcoin/pull/20749
< bitcoin-git>
bitcoin/master eae54e6 Carl Dong: scripted-diff: Use BlockManager::LookupBlockIndex
< bitcoin-git>
bitcoin/master 15d20f4 Carl Dong: validation: Move LookupBlockIndex to BlockManager
< bitcoin-git>
bitcoin/master f92dc65 Carl Dong: validation: Guard the active_chainstate with cs_main
< bitcoin-git>
[bitcoin] practicalswift opened pull request #21041: log: Move "Pre-allocating up to position 0x[…] in […].dat" log message to debug category (master...pre-allocation-up-to-position-0xff-in-foo.dat) https://github.com/bitcoin/bitcoin/pull/21041
< Talkless>
Would "getwhitepaper [directory]" RPC for retrieving bitcoin.pdf (using https://bitcoinhackers.org/@jb55/105595146491662406 technique, working for pruned nodes) be considered "waste of reviewer time" ? :)
< bitcoin-git>
[gui] hebasto opened pull request #205: Save/restore TransactionView and recentRequestsView tables column sizes (master...210131-header) https://github.com/bitcoin-core/gui/pull/205
< dongcarl>
sipa: This is also why we can't just use the bitcoin-core package currently in Guix :-)
< sipa>
dongcarl: so is it fair to say that guix (and the binaries it builds) are all living in their own little world, and are unconventional in that they're all built to live the... but what we want for the bitcoin core release builds isn't so much building something that lives there, but using the guix-world stuff to build a "normal" binary?
< dongcarl>
roconnor: Right, nix and guix binaries both share this trait of doing the -rpath and setting a weird dynamic linker. Both these behaviours are thoroughly reverted in the Bitcoin Core guix build
< bitcoin-git>
[bitcoin] laanwj opened pull request #21026: doc: Document use of make-tag script to make tags (master...2021-01-make-tag) https://github.com/bitcoin/bitcoin/pull/21026
< luke-jr>
MarcoFalke: aha, it was a libevent dep for just bitcoin-tx builds
< warren>
There is a way however for users to opt-out of automatic distro upgrades. The .rpm distributed by bitcoincore.org would be identical to the package distributed by Fedora except the Epoch number is higher. That way the Fedora package will never be seen as "newer". It retains the property desired by Bitcoin Core project that nobody is forced into automatic upgrades.
< wumpus>
luke-jr: otoh if the guix trusted base is compromised so will the bitcoin core binaries
< aj>
MarcoFalke: bitcoin's not going in stream/rhel, surely
< warren>
1) Bitcoin Core switch to Guix for release builds (when possible ... Guix is missing some of the architectures?) I believe we want a replacement for what Gitian used to do including exporting a particular tag from git, naming and versioning the output tarballs, anything else?
< warren>
I will not be able to stop them from distributing not-deterministic Bitcoin Core for much longer.
< warren>
A bit concerning to me is Fedora is again approaching possible packaging and distribution of Bitcoin Core. While the openssl-based risk is now eliminated, I now intend to package Guix for Fedora and use that to make binary identical builds. I think I can handle the Fedora specific parts of this. But Guix for Bitcoin Core releases is still missing a few parts of what Gitian used to do?
< ariard>
but yeah libmultiprocess should be moved under bitcoin-core
< aj>
re 19160, it needs rebase? also is there any roadmap for libmultiprocessing, it's out of tree, but seems pretty bitcoin specific? has it really been reviewed much?
< warren>
Suggested Topic: A bit concerning to me is Fedora is again approaching possible packaging and distribution of Bitcoin Core. While the openssl-based risk is now eliminated, I now intend to package Guix for Fedora and use that to make binary identical builds. I think I can handle the Fedora specific parts of this. But Guix for Bitcoin Core releases is still missing a few parts of what Gitian used to do?
< bitcoin-git>
[bitcoin] fanquake opened pull request #21022: [Not for merge] pthread sanity check (master...broken_shared_mutex_sanity_check) https://github.com/bitcoin/bitcoin/pull/21022
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #20995: fuzz: Avoid initializing version to less than MIN_PEER_PROTO_VERSION (master...2101-fuzzVersion0) https://github.com/bitcoin/bitcoin/pull/20995
< bitcoin-git>
bitcoin/master 4d5eaf7 MarcoFalke: Merge #20995: fuzz: Avoid initializing version to less than MIN_PEER_PROTO...
< bitcoin-git>
bitcoin/master fad3d76 MarcoFalke: fuzz: Avoid initializing version to less than MIN_PEER_PROTO_VERSION
< prayank>
wumpus: Not sure if I should comment on this but it's been helpful sometimes and for few things I had to ask questions on r/bitcoin and other places.
< wumpus>
prayank: i keep being surprised how actually-helpful the bitcoin stackexchange is
< bitcoin-git>
[gui] jonasschnelli merged pull request #85: Remove unused "What's This" button in dialogs on Windows OS (master...200907-whatsit) https://github.com/bitcoin-core/gui/pull/85
< bitcoin-git>
bitcoin/master ac7ccd6 Hennadii Stepanov: scripted-diff: Remove unused "What's This" button in dialogs on Windows
< bitcoin-git>
bitcoin/master 68692d3 Jonas Schnelli: Merge bitcoin-core/gui#85: Remove unused "What's This" button in dialogs o...
< bitcoin-git>
bitcoin/master b695148 Hennadii Stepanov: qt: Add flags to prevent a "What's This" button on Windows OS
< bitcoin-git>
[gui] jonasschnelli merged pull request #72: util: Log static plugins meta data and used style (master...200812-log) https://github.com/bitcoin-core/gui/pull/72
< bitcoin-git>
bitcoin/master 02b0165 Jonas Schnelli: Merge bitcoin-core/gui#177: Use "fusion" style on macOS Big Sur with old Q...
< bitcoin-git>
bitcoin/master 4e1154d Hennadii Stepanov: qt: Use "fusion" style on macOS Big Sur with old Qt
< bitcoin-git>
[gui] jonasschnelli merged pull request #177: Use "fusion" style on macOS Big Sur with old Qt (master...210107-style) https://github.com/bitcoin-core/gui/pull/177
< dongcarl>
In the meeting on the 14th, people asked jamesob and me to take a look at potential AssumeUTXO and chainman-deglobalization conflicts and if a certain merge order is preferable. Here is the result: https://github.com/bitcoin/bitcoin/pull/19806#issuecomment-768673523
< gribble>
https://github.com/bitcoin/bitcoin/issues/20892 | tests: Run both descriptor and legacy tests within a single test invocation by achow101 · Pull Request #20892 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] laanwj closed pull request #20957: doc: Update tor.md for notes on how to preserve v2 urls (with a not recommended note) (master...tor-controlport-docs) https://github.com/bitcoin/bitcoin/pull/20957
< bitcoin-git>
[bitcoin] laanwj merged pull request #20964: rpc: Add specific error code for "wallet already loaded" (master...2021-01-wallet-already-loaded-rpc) https://github.com/bitcoin/bitcoin/pull/20964
< bitcoin-git>
bitcoin/master 15a9df0 Wladimir J. van der Laan: Merge #20964: rpc: Add specific error code for "wallet already loaded"
< bitcoin-git>
bitcoin/master a6739cc Wladimir J. van der Laan: rpc: Add specific error code for "wallet already loaded"
< fanquake>
It seems quite annoying if GitHub will close issues in the bitcoin-core/gui repo, when I, or potentially anyone else, push to their own repos (fanquake/bitcoin)
< fanquake>
I fetched upstream, merged it into my bitcoin fork, then pushed that back to GitHub (fanquake/bitcoin).
< bitcoin-git>
[bitcoin] dhruv opened pull request #21015: Make all of net_processing (and some of net) use std::chrono types (master...pr-20044) https://github.com/bitcoin/bitcoin/pull/21015
< sipa>
norisgOG: this is getting off topic; there are several answers about this on https://bitcoin.stackexchange.com, and people are probably willing to help on #bitcoin
< norisgOG>
I followed the build process in doc/unix-build but its missing the configure: error: libdb_cxx headers missing, Bitcoin Core requires this library for wallet functionality
< bitcoin-git>
[bitcoin] stackman27 opened pull request #21014: test: Run mempool_accept.py even with wallet disabled (master...diswallet_mempoolaccept) https://github.com/bitcoin/bitcoin/pull/21014
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #20044: Make all of net_processing (and some of net) use std::chrono types (master...202009_chrono_types) https://github.com/bitcoin/bitcoin/pull/20044
< wumpus>
jonatack: seems like a nice tool, the only thing i dislike is that it's written in go, i'd managed to avoid having to install a go toolchain on my bitcoin dev VM until now :-)
< gribble>
https://github.com/bitcoin/bitcoin/issues/26 | Confirmations not appearing for sent coins after recovering wallet from archive · Issue #26 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/26 | Confirmations not appearing for sent coins after recovering wallet from archive · Issue #26 · bitcoin/bitcoin · GitHub
< aj>
wumpus: i setup https://github.com/bitcoin/bitcoin/pull/%s as a bookmark in firefox with the keyword "btc" so i can type "btc 12345" in the url bar to get to PR 12345
< bitcoin-git>
bitcoin/master a2a3f4c Pavol Rusnak: qt: drop workaround for QTBUG-42503 which was fixed in Qt 5.5.0
< bitcoin-git>
[gui] jonasschnelli merged pull request #189: qt: drop workaround for QTBUG-42503 which was fixed in Qt 5.5.0 (master...qtbug-42503) https://github.com/bitcoin-core/gui/pull/189