<bitcoin-git>
[bitcoin] dhruv opened pull request #23900: rpc: nServices rpc argument for addnode (master...addnode-advertise-services) https://github.com/bitcoin/bitcoin/pull/23900
<bitcoin-git>
[bitcoin] hebasto opened pull request #23897: refactor: Separate lockpoint calculate logic from CheckSequenceLocks function (master...211229-lockpoints) https://github.com/bitcoin/bitcoin/pull/23897
<bitcoin-git>
bitcoin/master fa5d0b6 MarcoFalke: doc: Remove TODO from block fuzz test
<bitcoin-git>
bitcoin/master 45249e7 fanquake: Merge bitcoin/bitcoin#23881: doc: Remove TODO from block fuzz test
<bitcoin-git>
[bitcoin] amadeuszpawlik closed pull request #22212: Guard `fHavePruned` to avoid potential data race (master...fix_guard_fhavepruned) https://github.com/bitcoin/bitcoin/pull/22212
2021-12-27
<bitcoin-git>
[bitcoin] hebasto closed pull request #23670: build: Build test binaries in `make check`, not in `make` (master...211204-check) https://github.com/bitcoin/bitcoin/pull/23670
<bitcoin-git>
[bitcoin] MarcoFalke closed pull request #21652: [WIP NOMERGE DRAFT] ci: Switch more tasks to self-hosted (master...2104-ciMoreSelf) https://github.com/bitcoin/bitcoin/pull/21652
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #23884: doc: Remove outdated scriptChange TODO comment (master...2112-docWall2) https://github.com/bitcoin/bitcoin/pull/23884
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #23882: doc: testnet3 was not reset and is doing BIP30 checks again (master...2112-docBip30Testnet3) https://github.com/bitcoin/bitcoin/pull/23882
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #23880: p2p: Serialize cmpctblock at most once in NewPoWValidBlock (master...2112-p2pAsync) https://github.com/bitcoin/bitcoin/pull/23880
<bitcoin-git>
[bitcoin] brunoerg opened pull request #23879: test: check ban_duration and time_remaining after setting ban (master...2021-12-test-ban_duration-time_remaining) https://github.com/bitcoin/bitcoin/pull/23879
<bitcoin-git>
[bitcoin] rojarsmith closed pull request #23874: linearize: Fix the config item name about rpc port (master...bitcoin-upstream) https://github.com/bitcoin/bitcoin/pull/23874
<bitcoin-git>
[bitcoin] rojarsmith opened pull request #23874: linearize: Fix the config item name about rpc port (master...bitcoin-upstream) https://github.com/bitcoin/bitcoin/pull/23874
<bitcoin-git>
[bitcoin] theStack opened pull request #23873: test: use MiniWallet for p2p_compactblocks.py (master...202112-test-use_MiniWallet_for_p2p_compactblocks) https://github.com/bitcoin/bitcoin/pull/23873
<bitcoin-git>
[bitcoin] luke-jr reopened pull request #16228: Bugfix: make check: Only run tests that were compiled (master...bugfix_raii_check_fail) https://github.com/bitcoin/bitcoin/pull/16228
<bitcoin-git>
[bitcoin] theStack opened pull request #23866: test: use MiniWallet for rpc_scantxoutset.py (master...202112-test-use_MiniWallet_for_rpc_scantxoutset) https://github.com/bitcoin/bitcoin/pull/23866
<prayank>
gmax should consider becoming a maintainer again, maybe things improve and if he has enough time. anyways thanks for all the info. I am going out now and will try things in few hours. It would be great if it helps cj in anyway. And leaks: bitcoin is many like its the easiest thing to become a privacy researcher in bitcoin.
<jeremyrubin>
i should probably write these details up somewhere and link to it from the BIP. GMAX has also discussed it in #bitcoin-wizards
<jeremyrubin>
prayank: sapio depends on rust-bitcoin and rust-miniscript. neither have released Taproot support yet -- once they do, i need to rebase Sapio patches and then do a little work to integrate it, then it will be fine (but I need to check and make sure things like PSBTs still work fine).
<prayank>
jeremyrubin: Compiling #21702 branch. BIP 119 mentioned about coinjoin. I want to test this with a setup of 2-3 regtest nodes. I don't understand the code written here: https://github.com/bitcoin/bips/blob/master/bip-0119.mediawiki#detailed-specification however I can test things based on the description that "participants agree on a single output which pays all participants". Do you have any other suggestion to help me in this
<laanwj>
MarcoFalke: no, i don't think that's possible using build-in functionality afaik, what i usually do is use https://github.com/bitcoin-core/bitcoin-maintainer-tools#fastcopy-chaindata to make a copy of the chain and chainstate, then prune that, then copy the pruned copy to the smaller medium
<jeremyrubin>
FYI in response to some private feedback i've clarified a few points in the BIP around alternative vault designs (the original one is outdated from my latest thinking) and activation stuff https://github.com/bitcoin/bips/pull/1257
<sipa>
RPC, P2P, multiprocess, UI... they're all distinct ways in which Bitcoin Core interacts with other processes/systems; ... and they all have different needs, and use different tools to accomplish that. Just because one uses a particular technology under the hood doesn't mean it's easy to make another one use the same technology.
<sipa>
If you're using Linux, and using bitcoin-qt, Qt is likely for some part at least using a UNIX domain socket to communicate with the X graphics driver. So if your goal was "I want my Bitcoin Core to use UNIX domain sockets!!!", then you probably already have it.
<sipa>
But it doesn't (and can't) provide the Bitcoin Core RPC interface. It's used to provide the multiprocess interface.
<jeremyrubin>
Marcofalke: in my view we want 3 projects to happen: 1 Bitcoin kernel to make consensus boundaries clear, 2 multiprocess to separate out things that don't need to share memory (most important imo would be having the network threads only able to message pass safely to core) and then 3 minimal node where bits of functionality in core are replaced
<laanwj>
instead of removing everything that isn't required i like the libbitcoinkernel direction more, isolate the consensus code, it allows you to use that within anything else if you don't agree with what bitcoin core offers
<sipa>
I'd very much like to see at least a UNIX domain socket added, but it seems earlier attempts to do that were complicated by lack of unix support on the client-side of libevent, which is used in bitcoin-cli.
<jeremyrubin>
overall i think it'd just be good if we only exposed Unix Sockets and had everything else be done via proxy. We can get all the local services working as we want them do (e/g bitcoin-cli) and industrial users should already be proxying. it's just attack surface with little benefit
<jeremyrubin>
also bad would be being able to detect a user is running bitcoin software while web browsing, even if no request is fired. but that applies to jsonrpc too
<bitcoin-git>
[bitcoin] ryanofsky opened pull request #23828: scripted-diff: Rename libbitcoin_server.a to libbitcoin_node.a (master...pr/libnode) https://github.com/bitcoin/bitcoin/pull/23828
<bitcoin-git>
[bitcoin] mzumsande opened pull request #23826: test: Make AddrMan unit tests use public interface, extend coverage (master...202112_addrman_unit_tests_1) https://github.com/bitcoin/bitcoin/pull/23826
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #23796: test: check that pruneblockchain RPC fails for future block or timestamp (master...202112-test-add_pruneblockchain_test_coverage) https://github.com/bitcoin/bitcoin/pull/23796
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #23797: ci: Use Cirrus "greedy" flag to use idle CPU time when available (master...cirrus_greedy) https://github.com/bitcoin/bitcoin/pull/23797
<bitcoin-git>
bitcoin/master cfeb194 Luke Dashjr: ci: Use Cirrus "greedy" flag to use idle CPU time when available
<bitcoin-git>
bitcoin/master 20aea49 MarcoFalke: Merge bitcoin/bitcoin#23797: ci: Use Cirrus "greedy" flag to use idle CPU ...
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #23801: Refactor: Change time variable type from int64_t to std::chrono::seconds in net_processing.cpp (master...time_in_seconds_refactor) https://github.com/bitcoin/bitcoin/pull/23801
<bitcoin-git>
[bitcoin] sipa closed pull request #19503: Add parameter feature to serialization and use it for CAddress (master...202007_ser_options) https://github.com/bitcoin/bitcoin/pull/19503
<bitcoin-git>
[bitcoin] hebasto closed pull request #23609: build: Enables reduced exports by default for macOS host (master...211126-reduce) https://github.com/bitcoin/bitcoin/pull/23609
<bitcoin-git>
[bitcoin] fanquake merged pull request #23811: scripts: match on `EXE_FORMATS` rather than name string (master...sec_check_match_type) https://github.com/bitcoin/bitcoin/pull/23811
<bitcoin-git>
[bitcoin] luke-jr closed pull request #19790: Flag when blocks have had their scripts checked instead of skipped (master...blkindex_scriptschecked_flag) https://github.com/bitcoin/bitcoin/pull/19790
2021-12-18
<bitcoin-git>
[bitcoin] darosior closed pull request #23815: wallet: watchonly support for Miniscript descriptors (master...miniscript_wallet_watchonly) https://github.com/bitcoin/bitcoin/pull/23815
<bitcoin-git>
[bitcoin] darosior opened pull request #23815: wallet: watchonly support for Miniscript descriptors (master...miniscript_wallet_watchonly) https://github.com/bitcoin/bitcoin/pull/23815
<bitcoin-git>
bitcoin/master 507c009 Hennadii Stepanov: test: Fix "echo" subtest in the system_tests for Windows
<bitcoin-git>
bitcoin/master 0aad33d Hennadii Stepanov: test: Fix "false" subtest in system_tests for Windows
<bitcoin-git>
bitcoin/master fb1b059 Hennadii Stepanov: test: Fix "non-zero exit code" subtest in system_tests for Windows
<bitcoin-git>
[bitcoin] hebasto opened pull request #23814: ci: Bump the macOS image to the latest Monterey (master...211218-monterey) https://github.com/bitcoin/bitcoin/pull/23814
<bitcoin-git>
[bitcoin] fjahr opened pull request #23813: Add test and docs for getblockfrompeer (master...2021-12-getblockfrompeer-follow-up) https://github.com/bitcoin/bitcoin/pull/23813
<bitcoin-git>
[bitcoin] mzumsande opened pull request #23812: test: fix intermittent failures in p2p_timeout.py (master...202112_p2p_timeout_fix) https://github.com/bitcoin/bitcoin/pull/23812
<bitcoin-git>
[bitcoin] fanquake opened pull request #23811: scripts: match on `EXE_FORMATS` rather than name string (master...sec_check_match_type) https://github.com/bitcoin/bitcoin/pull/23811
<laanwj>
PSA: as it was clear that fanquake has overwhelming support i've made him an admin of the bitcoin and bitcoin-core organizations
<bitcoin-git>
[bitcoin] PastaPastaPasta opened pull request #23810: refactor: destroy all C-style casts; use modern C++ casts, enforce via `-Wold-style-cast` (master...c-style-cast) https://github.com/bitcoin/bitcoin/pull/23810
<bitcoin-git>
bitcoin/master 97b2fc0 fanquake: Merge bitcoin/bitcoin#23803: ci: Disable s390x gui tests for now
<bitcoin-git>
[bitcoin] jb55 opened pull request #23809: tracing: reduce instructions generated by net:inbound_message tracepoint (master...conntype-enum-usdt) https://github.com/bitcoin/bitcoin/pull/23809
2021-12-17
<jb55>
btw satellite doesn't need to be a bitcoin fork right? couldn't it just be a block-from-space decoder + call submitblock? or is there more to it?
<sipa>
But Bitcoin Core works fine with tor itself, and tor itself also works with browsers.
<sipa>
Yes, he needs a way to communicate with Bitcoin Core. The altnet stuff goes in the direction of providing that functionality. As I said, I conceptually agree with that. I still don't see the point of node-tor, but if there is more functionality for interacting with separate networks, and someone makes it work with node-tor, sure...
<sipa>
That's all very reasonable, but I don't think that has much to do with Bitcoin Core.
<prayank>
sipa: Reason IIUC he doesn't like the way Tor project uses Tor protocol and its flaws etc. but wants to make a better to for different projects and bitcoin is one of them
<jb55>
so basically a way to feed network messages in and out as plaintext, turn bitcoin into a pure function?
<prayank>
sipa: what I understood based on his emails. he likes browsers, js and world around it. so webtorrents kind of things for bitcoin nodes. He is from france, he is good with his project but unable to express or get funding. IDK just wanted to share it here once so that people like you who know better would be able to see if it helps bitcoin at some point. Everything is moving to browsers tbh and this is not about altcoins. I work
<sipa>
But again, while I conceptually agree with making it easier to connect bitcoin nodes in more different ways with eachother, I don't understand the point of node-tor.
<sipa>
I don't think that's at all what he's talking about. He's saying that the communication between bitcoin core and node-tor (if it were to use node-tor rather than actual tor) would not use SOCKS.
<prayank>
hmm tbh I am not the best person to comment anything on this. I liked the idea and his follow up on mailing list. What I understand is: we do bitcoin nodes from browsers similar to one PoC by bcoin but its not safe for production. And this guy wants to make it interesting by using tor protocol for everything. I have issues with JS and WebRTC but if it can help bitcoin nodes usage I dont mind and maybe not full nodes or somethin
<sipa>
I conceptually like having more mechanisms for connecting bitcoin nodes though, so if there were a viable network like that to use as an additional one - sure why not.
<sipa>
I don't understanding anything about node-tor, or why you'd want to use a separate tor network for just bitcoin traffic. That completely defeats the purpose.
<bitcoin-git>
[gui] hebasto opened pull request #509: Respect dialog modality and fix a regression in wallet unlock (master...211217-unlock) https://github.com/bitcoin-core/gui/pull/509
<bitcoin-git>
[bitcoin] glozow opened pull request #23804: validation: followups for de-duplication of packages (master...2021-12-dedup-packages) https://github.com/bitcoin/bitcoin/pull/23804
<bitcoin-git>
[bitcoin] laanwj merged pull request #22704: fuzz: Differential fuzzing to compare Bitcoin Core's and D. J. Bernstein's implementation of ChaCha20 (master...diff-fuzz-chacha20) https://github.com/bitcoin/bitcoin/pull/22704
<bitcoin-git>
bitcoin/master 65ef932 stratospher: [fuzz] Add D. J. Bernstein's implementation of ChaCha20
<bitcoin-git>
bitcoin/master 4d0ac72 stratospher: [fuzz] Add fuzzing harness to compare both implementations of ChaCha20
<meshcollider>
Also, admin perms on bitcoin/bitcoin doesn't require admin on bitcoin/BIPs
<laanwj>
i mean in the end the github structure is contingent, it's not a representation of any formal power structure within bitcoin, if someone would really mess up the onus of development would simply move somewhere else
<laanwj>
glozow: no objections myself, but i do think it's important that people developing bitcoin core widely agree on it (which seems to be the case)
<bitcoin-git>
[bitcoin] shaavan opened pull request #23801: Refactor: Change time variable type from int64_t to std::chrono::seconds in net_processing.cpp (master...time_in_seconds_refactor) https://github.com/bitcoin/bitcoin/pull/23801
<laanwj>
i'm not sure what the fear here is, it seems to me the community around bitcoin dev is sufficiently diffuse and loosely organized that there's ton of ways for someone who is banned in error to have recourse
<bitcoin-git>
[bitcoin] sipa opened pull request #23799: Let test_runner.py start multiple jobs per timeslot (master...202112_multitesturn) https://github.com/bitcoin/bitcoin/pull/23799
<bitcoin-git>
[bitcoin] luke-jr opened pull request #23797: ci: Use Cirrus "greedy" flag to use idle CPU time when available (master...cirrus_greedy) https://github.com/bitcoin/bitcoin/pull/23797
<bitcoin-git>
[bitcoin] theStack opened pull request #23796: test: check that pruneblockchain RPC fails for future block or timestamp (master...202112-test-add_pruneblockchain_test_coverage) https://github.com/bitcoin/bitcoin/pull/23796
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #23795: refactor: Remove implicit-integer-sign-change suppressions in validation (master...2112-refValSup) https://github.com/bitcoin/bitcoin/pull/23795