2020-12-16

< bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/ad3d4b3929ab...5b6f970e3fda
< luke-jr> wen bitcoin-dnsseed support v3? :P
< gribble> https://github.com/bitcoin/bitcoin/issues/20561 | p2p: periodically clear m_addr_known by sdaftuar · Pull Request #20561 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20661 | Only select from addrv2-capable peers for torv3 address relay by sipa · Pull Request #20661 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19763 | net: dont try to relay to the address originator by vasild · Pull Request #19763 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19763 | net: dont try to relay to the address originator by vasild · Pull Request #19763 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj merged pull request #20661: Only select from addrv2-capable peers for torv3 address relay (master...202012_torv2_relay_only_addrv2) https://github.com/bitcoin/bitcoin/pull/20661
< bitcoin-git> bitcoin/master ad3d4b3 Wladimir J. van der Laan: Merge #20661: Only select from addrv2-capable peers for torv3 address rela...
< bitcoin-git> bitcoin/master 37fe80e Pieter Wuille: Only consider addrv2 peers for relay of non-addrv1 addresses
< bitcoin-git> bitcoin/master 83f8821 Pieter Wuille: refactor: add IsAddrCompatible() to CNode
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/69f1ee1922e3...ad3d4b3929ab
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20365: wallettool: add parameter to create descriptors wallet (master...wallet_tool_create_descriptors) https://github.com/bitcoin/bitcoin/pull/20365
< bitcoin-git> bitcoin/master 173cc9b Ivan Metlushko: test: walettool create descriptors
< bitcoin-git> bitcoin/master 345e88e Ivan Metlushko: wallettool: add param to create descriptors wallet
< bitcoin-git> bitcoin/master 6d3af3a Ivan Metlushko: wallettool: pass in DatabaseOptions into MakeWallet
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/3f205808a5f2...69f1ee1922e3
< bitcoin-git> [bitcoin] laanwj merged pull request #20605: init: Signal-safe instant shutdown (master...2020_12_instant_shutdown) https://github.com/bitcoin/bitcoin/pull/20605
< bitcoin-git> bitcoin/master 3f20580 Wladimir J. van der Laan: Merge #20605: init: Signal-safe instant shutdown
< bitcoin-git> bitcoin/master cd03513 Wladimir J. van der Laan: init: Signal-safe instant shutdown
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9dbcd3710521...3f205808a5f2
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20674: fuzz: Call SendMessages after ProcessMessage to increase coverage (master...2012-fuzzSendMessages) https://github.com/bitcoin/bitcoin/pull/20674
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20569: test: Fix intermittent wallet_multiwallet issue with got_loading_error (master...2012-testWalletInt) https://github.com/bitcoin/bitcoin/pull/20569
< bitcoin-git> bitcoin/master 9dbcd37 MarcoFalke: Merge #20569: test: Fix intermittent wallet_multiwallet issue with got_loa...
< bitcoin-git> bitcoin/master fa8e15f MarcoFalke: test: pep8 wallet_multiwallet.py
< bitcoin-git> bitcoin/master fab48da MarcoFalke: test: Fix intermittent wallet_multiwallet issue with got_loading_error
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/2d4eeaf9c588...9dbcd3710521
< bitcoin-git> [bitcoin] laanwj merged pull request #20601: doc: Update for FreeBSD 12.2, add GUI Build Instructions (master...master) https://github.com/bitcoin/bitcoin/pull/20601
< bitcoin-git> bitcoin/master 2d4eeaf Wladimir J. van der Laan: Merge #20601: doc: Update for FreeBSD 12.2, add GUI Build Instructions
< bitcoin-git> bitcoin/master c175690 Jarol Rodriguez: doc: Update for FreeBSD 12.2, add GUI Build Instructions
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a023094fc417...2d4eeaf9c588
< sdaftuar> aj: i've tried to debug this same issue (where a node appears to send us inv's after we start a blocks-only connection) many times over the years, and never been able to replicate using known bitcoin core software on both ends.
< aj> Jackielove4u: what's a bitcoin core rc3 client?
< aj> jnewbery: yeah; as per the comment i added -- i forgot to redact my ip before pasting that log snippet, then noticed my ip wasn't in the log; so those peers are definitely not pristine bitcoin core, so don't think it's our bug on the sending side either
< Jackielove4u> bitcoin core rc3 client (run on a desktop) and my schildbach wallet (run on android) does connect to bitcoin core 0.20.x and lower
< Jackielove4u> upon testing i saw that my bitcoin core rc3 client (run on a desktop) and my schildbach wallet (run on android) does not connect to my rc3 bitcoin core node (run on a server)
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20276: test: run mempool_expiry.py even with wallet disabled (master...mempool-expiry-miniwallet) https://github.com/bitcoin/bitcoin/pull/20276
< bitcoin-git> bitcoin/master a023094 MarcoFalke: Merge #20276: test: run mempool_expiry.py even with wallet disabled
< bitcoin-git> bitcoin/master 3b064fc Michael Dietz: test: run mempool_expiry.py even with wallet disabled
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6af8a6232b2d...a023094fc417
< jnewbery> vasild: there's something wrong with that peer. It's also not _sending_ pings every two minutes as we'd expect from a Bitcoin Core node
< jnewbery> Jackielove4u: I assume you also dropped the subsequent commit https://github.com/bitcoin/bitcoin/pull/20612/commits/9e806887a8f9ef63431b28d7dfd0470aa663dd02 as well? rc2 and rc3 don't play nice together with that commit, but rc3 <-> rc3 should be fine (and we have big problems if not)
< bitcoin-git> [bitcoin] hebasto opened pull request #20673: depends: Use more legible qmake commands in qt package (master...201216-subdir) https://github.com/bitcoin/bitcoin/pull/20673
< Jackielove4u> i was able to get it fixed though by reverting this commit: https://github.com/bitcoin/bitcoin/pull/20612/commits/9e806887a8f9ef63431b28d7dfd0470aa663dd02
< gribble> https://github.com/bitcoin/bitcoin/issues/20555 | v0.21.0 testing · Issue #20555 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20669 | [0.21] final rc4 backports by MarcoFalke · Pull Request #20669 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #20650: depends: Drop workaround for a fixed bug in Qt build system (master...201214-xcb) https://github.com/bitcoin/bitcoin/pull/20650
< bitcoin-git> bitcoin/master 6af8a62 Jonas Schnelli: Merge #20650: depends: Drop workaround for a fixed bug in Qt build system
< bitcoin-git> bitcoin/master 267f259 Hennadii Stepanov: depends: Drop workaround for a fixed bug in Qt build system
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b440c33179e7...6af8a6232b2d
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20477: net: Add unit testing of node eviction logic (master...unit-test-node-eviction-logic) https://github.com/bitcoin/bitcoin/pull/20477
< bitcoin-git> bitcoin/master fee8823 practicalswift: Assert eviction at >= 29 candidates. Assert non-eviction at <= 20 candidat...
< bitcoin-git> bitcoin/master 685c428 practicalswift: test: Add unit testing of node eviction logic
< bitcoin-git> bitcoin/master ed73f8c practicalswift: net: Move eviction node selection logic to SelectNodeToEvict(...)
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/dff0f6f753ea...b440c33179e7
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #16168: DevelopOmniLayer (master...develop) https://github.com/bitcoin/bitcoin/pull/16168
< gribble> https://github.com/bitcoin/bitcoin/issues/20254 | Add I2P support using statically configured destinations by vasild · Pull Request #20254 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20671: Replace boost::optional with std::optional (master...2012-stdOpt) https://github.com/bitcoin/bitcoin/pull/20671
< vasild> also, lontivero mentioned in https://github.com/bitcoin/bitcoin/pull/20254#discussion_r543586946 that even .b32.i2p addresses may have different length :-X
< gribble> https://github.com/bitcoin/bitcoin/issues/20506 | ci: AppVeyor fixes for Visual Studio 2019 16.8.1 image by sipsorcery · Pull Request #20506 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20489 | CI msvc: only build vcpkg dependencies for release (not debug) to reduce build times by sipsorcery · Pull Request #20489 · bitcoin/bitcoin · GitHub
< wumpus> woohoo, appveyor cooked up a new reason to fail "The object or library file 'C:\Qt5.9.8_x64_static_vs2019\lib\Qt5Core.lib' was created by a different version of the compiler than other objects like 'x64\Release\bitcoin-qt\main.obj'; rebuild all objects and libraries with the same"
< wumpus> does anyone maybe have a better idea how we can avoid introducing a circular dependency here between coinstats and validation: https://github.com/bitcoin/bitcoin/pull/19806#pullrequestreview-552964012
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20669: [0.21] final rc4 backports (0.21...2012-rc4) https://github.com/bitcoin/bitcoin/pull/20669
< bitcoin-git> [bitcoin] adamjonas opened pull request #20668: doc: warn that incoming conns are unlikely when not using default ports (master...121520-non-standard-port-doc) https://github.com/bitcoin/bitcoin/pull/20668

2020-12-15

< bitcoin-git> [gui] luke-jr opened pull request #153: GUI: Define MAX_DIGITS_BTC for magic number in BitcoinUnits::format (master...const_max_digits) https://github.com/bitcoin-core/gui/pull/153
< bitcoin-git> [bitcoin] laanwj merged pull request #20611: Move TX_MAX_STANDARD_VERSION to policy (master...2012-mvTxStandardVersion) https://github.com/bitcoin/bitcoin/pull/20611
< bitcoin-git> bitcoin/master dff0f6f Wladimir J. van der Laan: Merge #20611: Move TX_MAX_STANDARD_VERSION to policy
< bitcoin-git> bitcoin/master fade619 MarcoFalke: Move TX_MAX_STANDARD_VERSION to policy
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c434e2cca918...dff0f6f753ea
< bitcoin-git> [bitcoin] laanwj merged pull request #20615: cirrus: Schedule one task with paid credits for faster CI feedback (master...2012-ciFasterFeedback) https://github.com/bitcoin/bitcoin/pull/20615
< bitcoin-git> bitcoin/master c434e2c Wladimir J. van der Laan: Merge #20615: cirrus: Schedule one task with paid credits for faster CI fe...
< bitcoin-git> bitcoin/master faf2c6e MarcoFalke: cirrus: Schedule one task with paid credits for faster CI feedback
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d9a4738c9d3d...c434e2cca918
< bitcoin-git> [bitcoin] laanwj merged pull request #20660: Move signet onion seed from v2 to v3 (master...2020/12/signet-v3-onion) https://github.com/bitcoin/bitcoin/pull/20660
< bitcoin-git> bitcoin/master d9a4738 Wladimir J. van der Laan: Merge #20660: Move signet onion seed from v2 to v3
< bitcoin-git> bitcoin/master 3e6657a Sjors Provoost: Move signet onion seed from v2 to v3
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8bb40d5f56c8...d9a4738c9d3d
< bitcoin-git> [bitcoin] gruve-p opened pull request #20665: Build: update clang patch url and hash (master...master) https://github.com/bitcoin/bitcoin/pull/20665
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #20664: Add scanblockfilters RPC call (master...2020/12/filterblocks_rpc) https://github.com/bitcoin/bitcoin/pull/20664
< bitcoin-git> [bitcoin] lontivero reopened pull request #20662: Allow setting I2P addresses (master...set-i2p) https://github.com/bitcoin/bitcoin/pull/20662
< bitcoin-git> [bitcoin] lontivero closed pull request #20662: Allow setting I2P addresses (master...set-i2p) https://github.com/bitcoin/bitcoin/pull/20662
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20663: fuzz: Leave script_assets_test_minimizer unregistered (master...2012-fuzzNoReg) https://github.com/bitcoin/bitcoin/pull/20663
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20560: fuzz: Link all targets once (master...2012-fuzzLinkOnce) https://github.com/bitcoin/bitcoin/pull/20560
< bitcoin-git> bitcoin/master 8bb40d5 MarcoFalke: Merge #20560: fuzz: Link all targets once
< bitcoin-git> bitcoin/master fa13e1b MarcoFalke: build: Add option --enable-danger-fuzz-link-all
< bitcoin-git> bitcoin/master 44444ba MarcoFalke: fuzz: Link all targets once
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/a35a3466efd1...8bb40d5f56c8
< bitcoin-git> [bitcoin] lontivero opened pull request #20662: Allow setting I2P addresses (master...set-i2p) https://github.com/bitcoin/bitcoin/pull/20662
< bitcoin-git> [bitcoin] sipa opened pull request #20661: Only relay torv3 addresses to addrv2-capable peers (master...202012_torv2_relay_only_addrv2) https://github.com/bitcoin/bitcoin/pull/20661
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20653: doc: Move addr relay comment in net to correct place (master...2012-docNetAddrRelay) https://github.com/bitcoin/bitcoin/pull/20653
< bitcoin-git> bitcoin/master a35a346 MarcoFalke: Merge #20653: doc: Move addr relay comment in net to correct place
< bitcoin-git> bitcoin/master fa86217 MarcoFalke: doc: Move add relay comment in net to correct place
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ec6149c01e6d...a35a3466efd1
< bitcoin-git> [bitcoin] laanwj closed pull request #20525: Init script for debian/ubuntu (master...patch-2) https://github.com/bitcoin/bitcoin/pull/20525
< bitcoin-git> [bitcoin] laanwj merged pull request #20616: Check CJDNS address is valid (master...validate-cjdns-addresses) https://github.com/bitcoin/bitcoin/pull/20616
< bitcoin-git> bitcoin/master f7264ff Lucas Ontivero: Check if Cjdns address is valid
< bitcoin-git> bitcoin/master ec6149c Wladimir J. van der Laan: Merge #20616: Check CJDNS address is valid
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/70150824dc2c...ec6149c01e6d
< jamesob> Hey maintainers, the latest AU PR has 3 solid ACKs. Might be worth a look? https://github.com/bitcoin/bitcoin/pull/19806
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20437: fuzz: Avoid time-based "non-determinism" in fuzzing harnesses by using mocked GetTime() (master...fuzzers-remove-time-based-non-determinism) https://github.com/bitcoin/bitcoin/pull/20437
< bitcoin-git> bitcoin/master 8c09c0c practicalswift: fuzz: Avoid time-based "non-determinism" in fuzzing harnesses by using moc...
< bitcoin-git> bitcoin/master 7015082 MarcoFalke: Merge #20437: fuzz: Avoid time-based "non-determinism" in fuzzing harnesse...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f1f2418433c9...70150824dc2c
< ariard> jonatack: agree on the newsworthy thing, bitcoin medias don't talk about a great ongoing review but maybe we should keep educating them?
< core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
< gribble> https://github.com/bitcoin/bitcoin/issues/19988 | Overhaul transaction request logic by sipa · Pull Request #19988 · bitcoin/bitcoin · GitHub
< MarcoFalke> I presumed it was based on this comment: https://github.com/bitcoin/bitcoin/pull/19569#discussion_r462887483
< gribble> https://github.com/bitcoin/bitcoin/issues/19569 | Enable fetching of orphan parents from wtxid peers by sipa · Pull Request #19569 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16702 | p2p: supplying and using asmap to improve IP bucketing in addrman by naumenkogs · Pull Request #16702 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16401 | Add package acceptance logic to mempool by sdaftuar · Pull Request #16401 · bitcoin/bitcoin · GitHub
< aj> personally, i'm bothered by https://github.com/bitcoin/bitcoin/pull/20599#issuecomment-741631081 ; my opinion is that we should be thoroughly reviewing all p2p changes because there's potential for interactions, so going easy on "boring" PRs seems very unsafe. beyond that, there's a lot of not very beneficial refactoring PRs, that are also causing extra dev and review rework on PRs that change the
< gribble> https://github.com/bitcoin/bitcoin/issues/19858 | Periodically make block-relay connections and sync headers by sdaftuar · Pull Request #19858 · bitcoin/bitcoin · GitHub
< jonatack> ariard: in general, i can think of many outstanding reviews (and there are some outstanding reviewers). Coverage of great reviews was actually proposed one year ago for Bitcoin Optech: https://github.com/bitcoinops/bitcoinops.github.io/issues/301
< ariard> I did attach some past PRs on the wiki page : https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings
< jnewbery> #bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik petertodd
< core-meetingbot> Meeting started Tue Dec 15 15:01:02 2020 UTC. The chair is jnewbery. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
< harding> I heard there was a problem with osx signing. Does that mean https://bitcoincore.org/bin/bitcoin-core-0.21.0/test.rc3/bitcoin-0.21.0rc3-osx.dmg is not going to work or will print some scary warning to users who try to run it?
< gribble> https://github.com/bitcoin/bitcoin/issues/15 | Option to specify external IP address · Issue #15 · bitcoin/bitcoin · GitHub
< jnewbery> Hi folks. We have a p2p meeting in half an hour. Only one proposed topic so far: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings#15-dec-2020. Feel free to add topics between now and 15:00 UTC.
< bitcoin-git> [bitcoin] Sjors opened pull request #20660: Move signet onion seed from v2 to v3 (master...2020/12/signet-v3-onion) https://github.com/bitcoin/bitcoin/pull/20660
< bitcoin-git> [bitcoin] fanquake merged pull request #20253: net: use std::chrono throughout maxOutbound logic (master...net_unused_outbound) https://github.com/bitcoin/bitcoin/pull/20253
< bitcoin-git> bitcoin/master 173d0d3 fanquake: net: remove nMaxOutboundTimeframe from connection options
< bitcoin-git> bitcoin/master b117eb1 fanquake: net: remove SetMaxOutboundTimeframe
< bitcoin-git> bitcoin/master 2f3f1ae fanquake: net: remove SetMaxOutboundTarget
< bitcoin-git> [bitcoin] fanquake pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/33d633726922...f1f2418433c9
< bitcoin-git> bitcoin/master 33d6337 Jonas Schnelli: Merge bitcoin-core/gui#115: Replace "Hide tray icon" option with positive ...
< bitcoin-git> bitcoin/master 03edb52 Hennadii Stepanov: qt: Remove redundant BitcoinGUI::setTrayIconVisible
< bitcoin-git> bitcoin/master 17174f8 Hennadii Stepanov: gui: Replace "Hide tray icon" option with positive "Show tray icon" one
< bitcoin-git> [bitcoin] jonasschnelli pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/94a9cd25fd17...33d633726922
< bitcoin-git> [gui] jonasschnelli merged pull request #115: Replace "Hide tray icon" option with positive "Show tray icon" one (master...201024-tray) https://github.com/bitcoin-core/gui/pull/115
< bitcoin-git> [bitcoin] dhruv opened pull request #20658: ci: Move linter task to cirrus (master...linter-on-cirrus) https://github.com/bitcoin/bitcoin/pull/20658

2020-12-14

< bitcoin-git> [bitcoin] dhruv closed pull request #20656: testing linting travis -> cirrus (master...travis-to-cirrus) https://github.com/bitcoin/bitcoin/pull/20656
< bitcoin-git> [bitcoin] dhruv opened pull request #20656: testing linting travis -> cirrus (master...travis-to-cirrus) https://github.com/bitcoin/bitcoin/pull/20656
< bitcoin-git> [gui] luke-jr opened pull request #152: GUI: Initialise DBus notifications in another thread (master...gui_notify_setup_bg) https://github.com/bitcoin-core/gui/pull/152
< bitcoin-git> [bitcoin] laanwj merged pull request #20594: Fix getauxval calls in randomenv.cpp (master...2020/12/getauxval) https://github.com/bitcoin/bitcoin/pull/20594
< bitcoin-git> bitcoin/master 94a9cd2 Wladimir J. van der Laan: Merge #20594: Fix getauxval calls in randomenv.cpp
< bitcoin-git> bitcoin/master 836a3dc Jonas Schnelli: Avoid weak-linked getauxval support on non-linux platforms (like macOS)
< bitcoin-git> bitcoin/master 41a413b Jonas Schnelli: Define correct symbols for getauxval
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/fff7d056a92f...94a9cd25fd17
< luke-jr> if someone wants to PR it, https://github.com/bitcoin-core/gui/compare/master…luke-jr:drop_dbus?expand=1
< luke-jr> til bitcoin-qt has 195 threads
< achow101> I found it: http://gnusha.org/bitcoin-core-dev/2020-11-24.log at 17:04
< bitcoin-git> [bitcoin] laanwj reopened pull request #20605: init: Signal-safe instant shutdown (master...2020_12_instant_shutdown) https://github.com/bitcoin/bitcoin/pull/20605
< gribble> https://github.com/bitcoin/bitcoin/issues/20605 | init: Signal-safe instant shutdown by laanwj · Pull Request #20605 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20653: doc: Move add relay comment in net to correct place (master...2012-docNetAddrRelay) https://github.com/bitcoin/bitcoin/pull/20653
< achow101> rm -rf gitian-builder/cache/bitcoin-core-osx-22/
< jonatack> make -C ../bitcoin/depends download SOURCES_PATH=`pwd`/cache/common
< achow101> provoostenator: can you provide the bitcoin-7f9d623e0210-osx-unsigned.tar.gz for your build of #20638?
< gribble> https://github.com/bitcoin/bitcoin/issues/20638 | build: Fix macOS code signing by pre-allocating space for the code signature during gitian build by achow101 · Pull Request #20638 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20599: net processing: Tolerate sendheaders and sendcmpct messages before verack (master...2020-12-tolerate-early-send-messages) https://github.com/bitcoin/bitcoin/pull/20599
< bitcoin-git> bitcoin/master fff7d05 MarcoFalke: Merge #20599: net processing: Tolerate sendheaders and sendcmpct messages ...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b103fdcb3bf4...fff7d056a92f
< bitcoin-git> bitcoin/master b316dcb John Newbery: [net processing] Tolerate sendheaders and sendcmpct messages before verack...
< gribble> https://github.com/bitcoin/bitcoin/issues/20599 | net processing: Tolerate sendheaders and sendcmpct messages before verack by jnewbery · Pull Request #20599 · bitcoin/bitcoin · GitHub
< ariard> I proposed the following topic for tmrw p2p meeting : "Review of the P2P Review Process" : https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #20652: Designer fees when coin control is enabled (master...master) https://github.com/bitcoin/bitcoin/pull/20652
< gribble> https://github.com/bitcoin/bitcoin/issues/20638 | build: Fix macOS code signing by pre-allocating space for the code signature during gitian build by achow101 · Pull Request #20638 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] gbizzotto opened pull request #20652: Designer fees when coin control is enabled: (master...master) https://github.com/bitcoin/bitcoin/pull/20652
< bitcoin-git> [bitcoin] jnewbery opened pull request #20651: net: Make p2p recv buffer timeout 20 minutes for all peers (master...2020-12-recv-buffer-timeout) https://github.com/bitcoin/bitcoin/pull/20651
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19763: net: don't try to relay to the address' originator (master...only_relay_to_unaware) https://github.com/bitcoin/bitcoin/pull/19763
< bitcoin-git> bitcoin/master b103fdc MarcoFalke: Merge #19763: net: don't try to relay to the address' originator
< bitcoin-git> bitcoin/master 7fabe0f Vasil Dimov: net: don't relay to the address' originator
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/eec9366f7dd6...b103fdcb3bf4
< bitcoin-git> [bitcoin] hebasto opened pull request #20650: depends: Drop workaround for a fixed bug in Qt build system (master...201214-xcb) https://github.com/bitcoin/bitcoin/pull/20650
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20649: refactor: Remove nMyStartingHeight from CNode/Connman (master...2012-netNoMyHeight) https://github.com/bitcoin/bitcoin/pull/20649
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20624: net processing: Remove nStartingHeight check from block relay (master...2020-12-remove-starting-height) https://github.com/bitcoin/bitcoin/pull/20624
< bitcoin-git> bitcoin/master f636008 John Newbery: [net processing] Clarify UpdatedBlockTip()
< bitcoin-git> bitcoin/master 94d2cc3 John Newbery: [net processing] Remove unnecesary nNewHeight variable in UpdatedBlockTip()
< bitcoin-git> bitcoin/master 8b57013 John Newbery: [net processing] Remove nStartingHeight check from block relay
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/096bd374da28...eec9366f7dd6
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20592: doc: update wtxidrelay documentation per BIP339 (master...update-wtxid-documentation-per-BIP339) https://github.com/bitcoin/bitcoin/pull/20592
< bitcoin-git> bitcoin/master 4b7b58b Jon Atack: Update net_processing WTXID documentation per BIP339
< bitcoin-git> bitcoin/master 096bd37 MarcoFalke: Merge #20592: doc: update wtxidrelay documentation per BIP339
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/25bc840e038f...096bd374da28
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20648: chainparams: Add default fixed seeds for signet (master...2012-chainFixedSeedsSignet) https://github.com/bitcoin/bitcoin/pull/20648
< bitcoin-git> [bitcoin] fanquake merged pull request #20617: p2p: Remove m_is_manual_connection from CNodeState (master...2020-12-remove-is-manual-connection) https://github.com/bitcoin/bitcoin/pull/20617
< bitcoin-git> bitcoin/master 25bc840 fanquake: Merge #20617: p2p: Remove m_is_manual_connection from CNodeState
< bitcoin-git> bitcoin/master a33442f Antoine Riard: Remove m_is_manual_connection from CNodeState
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ade38b6ee8f9...25bc840e038f
< sipa> my best guess is thah somehow it's using the wrong bitcoin-osx-unsigned.tar.gz
< sipa> $ ./codesign_allocate -i dist/Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt -a x86_64 224592 -o out
< achow101> it'll be x86_64-apple-darwin-otool -l Bitcoin-Qt
< sipa> achow101: do you have the unsigned Bitcoin-Qt binary somewhere?
< achow101> sipa: 3021d9722182e2dfdcd29b1dec11514d66f3e566d5ae505d69c2c68b21f68a27 bitcoin-a4118c6e200e-osx-unsigned.tar.gz match?

2020-12-13

< bitcoin-git> [bitcoin] jonatack opened pull request #20646: p2p: do not disconnect post-verack sendaddrv2 on signet (master...signet-keep-post-verack-sendaddrv2-peers) https://github.com/bitcoin/bitcoin/pull/20646
< jonasschnelli> https://bitcoin.jonasschnelli.ch/signature-osx-dbl-sign.tar.gz (<--- the output from detach-sig-create on my mac which run successful on the output above)
< jonasschnelli> https://bitcoin.jonasschnelli.ch/bitcoin-0.21.0rc3-osx-unsigned-dbl-sign.tar.gz (<--- the 1. codesign_alloc, apply rc3 sig)
< jonasschnelli> achow101: still getting /Users/jonasschnelli/Desktop/Bitcoin-Qt.app: invalid Info.plist (plist or signature have been modified)
< jonasschnelli> then downloaded signed-app/Bitcoin-Qt.app to my mac
< jonasschnelli> (bitcoin-0.21.0rc3-osx-unsigned-2.tar.gz is from the rc3 release, unsigned, untouched)
< jonasschnelli> (../bitcoin-detached-sigs/osx hold the new signature)
< jonasschnelli> 2. on linux, I executed ./detached-sig-apply.sh bitcoin-0.21.0rc3-osx-unsigned-2.tar.gz ../bitcoin-detached-sigs/osx
< jonasschnelli> ./detached-sig-apply.sh bitcoin-0.21.0rc3-osx-unsigned.tar.gz ../bitcoin-detached-sigs/osx (<--- the git repo for the signatures)
< jonasschnelli> tar -czf bitcoin-0.21.0rc3-osx-unsigned.tar.gz ./
< jonasschnelli> I did: /home/jonasschnelli/bitcoin-depends2/depends/x86_64-apple-darwin20/native/bin/x86_64-apple-darwin20-codesign_allocate -i dist/Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt -a x86_64 258611376 -o dist/Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt
< jonasschnelli> dist/Bitcoin-Qt.app: replacing existing signature
< jonasschnelli> achow101: still getting dist/Bitcoin-Qt.app: invalid or unsupported format for signature
< jonasschnelli> stat -c %s signed-app/Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt
< jonasschnelli> achow101: fatal error: /home/jonasschnelli/bitcoin-depends2/depends/x86_64-apple-darwin20/native/bin/x86_64-apple-darwin20-codesign_allocate: size for '-a x86_64 258611375' not a multiple of 16
< bitcoin-git> [bitcoin] sipa opened pull request #20644: Add patch to make codesign_allocate compatible with Apple's (master...202012_codesign_allocate_segalign) https://github.com/bitcoin/bitcoin/pull/20644
< jonasschnelli> still getting: dist/Bitcoin-Qt.app: invalid or unsupported format for signature
< achow101> jonasschnelli: if you do "printf "\xfa\xde\x0c\xc0" | dd of=dist/Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt bs=1 seek=26391600 count=4 conv=notrunc" and then try to sign, does it work?
< jonasschnelli> set -x tells me: + codesign -f --file-list sign.temp/signatures.txt -s Bitcoin dist/Bitcoin-Qt.app
< jonasschnelli> sipa: I ran ./detached-sig-create.sh but I guess the one that matter is the dist/Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt
< jonasschnelli> when calling ./detached-sig-create.sh -s "Bitcoin"
< jonasschnelli> dist/Bitcoin-Qt.app: invalid or unsupported format for signature
< jonasschnelli> achow101: 6b2c9ac15da01cc4fa3951059fdf44c4eebd432288af6691ef94604f601b9ab9 bitcoin-6753b74195d8-osx-unsigned.tar.gz
< gribble> https://github.com/bitcoin/bitcoin/issues/20638 | build: Fix macOS code signing by pre-allocating space for the code signature during gitian build by achow101 · Pull Request #20638 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20638 | build: Fix macOS code signing by pre-allocating space for the code signature during gitian build by achow101 · Pull Request #20638 · bitcoin/bitcoin · GitHub
< harding> $ bitcoin-cli help scantxoutset | grep '"range"'
< harding> jamesob: sorry, I meant the derived address range, which I think non-Bitcoin Core software usually calls the gap limit.
< bitcoin-git> [bitcoin] hebasto opened pull request #20642: depends: Drop unneeded patches for qt package (master...201213-patch) https://github.com/bitcoin/bitcoin/pull/20642
< bitcoin-git> [bitcoin] hebasto opened pull request #20641: depends: Use Qt top-level build facilities (master...201213-top) https://github.com/bitcoin/bitcoin/pull/20641
< Talkless> Anyone using QtCreator to work with bitcoin core? It's code model does not find any of bitcoin core includes, all underlined. I've created project as Autotools.
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #20639: doc: fix case of GitHub (master...fix-case-of-github) https://github.com/bitcoin/bitcoin/pull/20639
< bitcoin-git> [bitcoin] theStack opened pull request #20640: wallet, refactor: return out-params of CreateTransaction() as optional struct (master...202012-refactor-wallet-createtransaction-return_out_params_in_optstruct) https://github.com/bitcoin/bitcoin/pull/20640
< bitcoin-git> [bitcoin] fanquake merged pull request #20588: Remove unused and confusing CTransaction constructor (master...2012-txConstructor) https://github.com/bitcoin/bitcoin/pull/20588
< bitcoin-git> bitcoin/master ade38b6 fanquake: Merge #20588: Remove unused and confusing CTransaction constructor
< bitcoin-git> bitcoin/master fac39c1 MarcoFalke: wallet: document that tx in CreateTransaction is purely an out-param
< bitcoin-git> bitcoin/master faac315 MarcoFalke: Remove unused and confusing CTransaction constructor
< bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b18978066d87...ade38b6ee8f9
< gribble> https://github.com/bitcoin/bitcoin/issues/20638 | Mac codesign fixed alloc by achow101 · Pull Request #20638 · bitcoin/bitcoin · GitHub
< fanquake> By Bitcoin-Qt I mean: Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt
< fanquake> It seems like macOS will only stop you from opening the .app though. You can still run Bitcoin-Qt with an invalid signature
< achow101> fanquake: do "codesign -v Bitcoin-Qt.app"
< achow101> I see there are 3 embedded certs: Apple, Devloper ID Certification Authority, and Bitcoin Core Code Signing Association

2020-12-12

< sipa> $ file Bitcoin-Qt.sign
< sipa> Bitcoin-Qt.sign: Mac OS X Detached Code Signature (non-executable) - 216249 bytes
< achow101> sipa: in the bitcoin-detached-sigs repo osx/dist/Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt.sign
< sipa> wumpus: sounds similar to bitcoin's use of a sighash byte
< achow101> The hash is Bitcoin-Qt.app/Contents
< achow101> one of the hashes is of the file Bitcoin-Qt.app/Contents/_CodeSignature/CodeResources, and the other is Bitcoin-Qt.app/Contents/Info.plist
< bitcoin-git> [bitcoin] jbampton opened pull request #20639: doc: fix case of GitHub (master...fix-case-of-github) https://github.com/bitcoin/bitcoin/pull/20639
< achow101> 26891600 Dec 12 11:40 Bitcoin-Qt
< bitcoin-git> [bitcoin] achow101 opened pull request #20638: Mac codesign fixed alloc (master...mac-codesign-fixed-alloc) https://github.com/bitcoin/bitcoin/pull/20638
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20079: p2p: Treat handshake misbehavior like unknown message (master...2010-p2pNoVersion) https://github.com/bitcoin/bitcoin/pull/20079
< bitcoin-git> bitcoin/master b189780 MarcoFalke: Merge #20079: p2p: Treat handshake misbehavior like unknown message
< bitcoin-git> bitcoin/master faaad1b MarcoFalke: p2p: Ignore version msgs after initial version msg
< bitcoin-git> bitcoin/master fad68af MarcoFalke: p2p: Ignore non-version msgs before version msg
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ffc4d0499020...b18978066d87
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20275: wallet: List all wallets in non-SQLite and non-BDB builds (master...pr/exist) https://github.com/bitcoin/bitcoin/pull/20275
< bitcoin-git> bitcoin/master 6a7a636 Russell Yanofsky: refactor: Drop call to GetWalletEnv in wallet salvage code
< bitcoin-git> bitcoin/master 6ee9cbd Russell Yanofsky: refactor: Replace ListWalletDir() function with ListDatabases()
< bitcoin-git> bitcoin/master 5aaeb6c Russell Yanofsky: MOVEONLY: Move IsBDBFile, IsSQLiteFile, and ListWalletDir
< bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/6a4806367177...ffc4d0499020
< jonasschnelli> and if anyone wants to test 0.20.2rc1, I just created the detached signature (no gitian build yet): https://bitcoin.jonasschnelli.ch/signature-osx_0.20.2rc1.tar.gz
< jonasschnelli> https://bitcoin.jonasschnelli.ch/bitcoin-0.21.0rc3-osx-unsigned-again-pagesize0.zip <--- signed with pagesize 0, check that is was not already codesigned
< jonasschnelli> sipa: jonasschnelli staff 18496 12 Dez 08:10 Bitcoin-Qt.sign
< jonasschnelli> sipa: okay... I executed "./detached-sig-create.sh -s "Bitcoin" --pagesize 0"
< bitcoin-git> [bitcoin] pox opened pull request #20635: fix misleading comment about call to non-existing function (master...master) https://github.com/bitcoin/bitcoin/pull/20635
< sipa> if you run "codesign_allocate -i <gitian Bitcoin-Qt filename> -a x86_64 $((225312+1024)) -o <newname>" in linux, does the resulting binary work in macos?
< sipa> codesign_allocate -i <unsigned Bitcoin-Qt filename> -a x86_64 $((225312+1024)) -o <some temp file>
< gribble> https://github.com/bitcoin/bitcoin/issues/67 | does not compile with boost_1_45_0 on OS X 10.6 · Issue #67 · bitcoin/bitcoin · GitHub
< achow101> of which version of Bitcoin-Qt
< sipa> what is the full output from that x86_64-apple-darwin-otool -l Bitcoin-Qt command?

2020-12-11

< sipa> achow101: if you run "codesign_allocate -i <unsigned Bitcoin-Qt filename> -a x86_64 225312 -o <some temp file>
< sipa> if you run "pagestuff -p Bitcoin-Qt | tail -2 | grep size | sed 's/[^0-9]*//g'", what do you get?
< sipa> yeah, what if you run that on the unsigned Bitcoin-Qt binary?
< sipa> x86_64-apple-darwin-otool -l Bitcoin-Qt
< achow101> x86_64-apple-darwin-otool -l Bitcoin-Qt for segment "__LINKEDIT" says "vmsize 0x000000000007b000" but on the other it's "vmsize 0x000000000007c000"
< achow101> the gitian result is https://bitcoin.jonasschnelli.ch/bitcoin-osx-signed3.dmg which comes from gitian builder combining the unsigned with the signature.tar.gz from the above zip
< achow101> the results from https://bitcoin.jonasschnelli.ch/bitcoin-osx-unsigned-nowsigned.zip which come from the signing process. it contains a fully signed binary
< jonasschnelli> my local signed and detached signature directory: https://bitcoin.jonasschnelli.ch/bitcoin-osx-unsigned-nowsigned.zip
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #20630: Allow providing local signatures in gitian osx signer (master...2020/12/macos_gitian_signer) https://github.com/bitcoin/bitcoin/pull/20630
< jonasschnelli> AFAIK 5e3a08ae8195190d6f1b12e3e1e9d710e7ad385941a6e8d04e3391f12deddb11 was the unsigned tarball (bitcoin-osx-unsigned.tar.gz)
< sipa> of bitcoin core?
< jonasschnelli> * /Volumes/Bitcoin-Core 4/Bitcoin-Qt.app: invalid signature (code or signature have been modified)
< jonasschnelli> ./detached-sig-create.sh -s "Bitcoin"
< jonasschnelli> verified code-signature codesign -v dist/Bitcoin-Qt.app
< jonasschnelli> I have downloaded again 5e3a08ae8195190d6f1b12e3e1e9d710e7ad385941a6e8d04e3391f12deddb11 bitcoin-osx-unsigned.tar.gz ...
< bitcoin-git> [bitcoin] dongcarl opened pull request #20629: depends: Improve id string robustness (master...2020-12-improve-depends-id-string) https://github.com/bitcoin/bitcoin/pull/20629
< jonasschnelli> I do that for bitcoin=
< luke-jr> jonasschnelli: -u bitcoin=/path/to/local/bitcoin
< jonasschnelli> but AFAIK the signer always pulls https://github.com/bitcoin-core/bitcoin-detached-sigs.git?
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #20628: Владелец (master...patch-10) https://github.com/bitcoin/bitcoin/pull/20628
< bitcoin-git> [bitcoin] vova557 opened pull request #20628: Владелец (master...patch-10) https://github.com/bitcoin/bitcoin/pull/20628
< jonasschnelli> the build log from the signer was actually a full macOS unsigned build: https://bitcoin.jonasschnelli.ch/gitian/builds/358/build_osx_signer.log (for whatever reason)
< jonasschnelli> my first gitian build went somehow wrong: https://bitcoin.jonasschnelli.ch/gitian/build/358
< jonasschnelli> luke-jr: 46cfa036d365d69db2a3b78377621d6b214f2d78f3082f9c7ebd7a9b89cfc599 is here -> https://bitcoin.jonasschnelli.ch/gitian/build/360
< jonasschnelli> I have verified the signed 5e3a08ae8195190d6f1b12e3e1e9d710e7ad385941a6e8d04e3391f12deddb11 bitcoin-0.21.0rc3-osx-unsigned.tar.gz and it works
< jonasschnelli> I double checked and I can confirm that I have signed 5e3a08ae8195190d6f1b12e3e1e9d710e7ad385941a6e8d04e3391f12deddb11 bitcoin-0.21.0rc3-osx-unsigned.tar.gz
< jonasschnelli> but I signed 5e3a08ae8195190d6f1b12e3e1e9d710e7ad385941a6e8d04e3391f12deddb11 bitcoin-0.21.0rc3-osx-unsigned.tar.gz
< jonasschnelli> But yes,... 46cfa036d365d69db2a3b78377621d6b214f2d78f3082f9c7ebd7a9b89cfc599 bitcoin-osx-signed.dmg has an invalid code signature
< jonasschnelli> I got 998dddf3c0f9b568fc0c39e61e3d61d2843dfb968016b7ceaf23aca94ace2542 bitcoin-osx-signed.dmg as the only one
< jonasschnelli> I codesigned 5e3a08ae8195190d6f1b12e3e1e9d710e7ad385941a6e8d04e3391f12deddb11 bitcoin-0.21.0rc3-osx-unsigned.tar.gz