<bitcoin-git>
bitcoin/master fa243e9 MarcoFalke: Remove no-op TIME_INIT on deser
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #25296: Add DataStream without ser-type and ser-version and use it where possible (master...2206-datastream-🎑) https://github.com/bitcoin/bitcoin/pull/25296
<bitcoin-git>
[bitcoin] butterfly1924 opened pull request #25293: scripted-diff: remove duplicate categories from LogPrint output (master...remove_duplicate_categories_from_logprint_output) https://github.com/bitcoin/bitcoin/pull/25293
<bitcoin-git>
[bitcoin] jonatack opened pull request #25292: Add LogPrintLevel to lint-format-strings, drop LogPrint-vs-LogPrintf section in dev notes (master...update-lint-format-strings-and-dev-notes) https://github.com/bitcoin/bitcoin/pull/25292
<hebasto>
as laanwj has noted, let's move further discussion into #bitcoin-core-builds
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #24629: Bugfix: RPC/blockchain: pruneblockchain: Return the height of the actual last pruned block (master...bugfix_rpc_prunebc_retval) https://github.com/bitcoin/bitcoin/pull/24629
<bitcoin-git>
bitcoin/master e593ae0 Luke Dashjr: Bugfix: RPC/blockchain: pruneblockchain: Return the height of the actual l...
<bitcoin-git>
[bitcoin] dongcarl opened pull request #25290: [kernel 3a/n] Decouple `CTxMemPool` from `ArgsManager` (master...2022-02-libbitcoinkernel-argsman-mempool) https://github.com/bitcoin/bitcoin/pull/25290
<bitcoin-git>
[bitcoin] theStack opened pull request #25289: test: implement 'bech32m' mode for `getnewdestination()` helper (master...202206-test-add_bech32m_mode_for_getnewdestination) https://github.com/bitcoin/bitcoin/pull/25289
2022-06-06
<bitcoin-git>
[bitcoin] martinus opened pull request #25288: test: Reliably don't start itself in lint-all.py runs all tests twice (master...2022-06-fix-lint-all-starting-itself) https://github.com/bitcoin/bitcoin/pull/25288
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #25285: Add AutoFile without ser-type and ser-version and use it where possible (master...2206-autofile-🌟) https://github.com/bitcoin/bitcoin/pull/25285
<bitcoin-git>
[bitcoin] laanwj merged pull request #25220: rpc: fix incorrect warning for address type p2sh-segwit in createmultisig (master...2022-05-fix-incorrect-warning-createmultisig) https://github.com/bitcoin/bitcoin/pull/25220
<bitcoin-git>
bitcoin/master 06ea278 laanwj: Merge bitcoin/bitcoin#25220: rpc: fix incorrect warning for address type p...
<DavidBakin>
it then reports ` with coverage = no` and the targets are NOT in the generated makefiles! This used to work - but I just did a pull from bitcoin/bitcoin and picked up about 175 recent commits and now it is broken. Anyone tried it recently?
<Murch>
I'll be talking about work on the wallet at Bitcoin Plus Plus, so I've been spending some time looking into what's been happening and distilling slides from it
<gribble>
https://github.com/bitcoin/bitcoin/issues/25272 | wallet: guard and alert about a wallet invalid state during chain sync by furszy · Pull Request #25272 · bitcoin/bitcoin · GitHub
<bitcoin-git>
[bitcoin] achow101 opened pull request #25273: wallet: Pass through transaction locktime and preset input sequences and scripts to CreateTransaction (master...use-preset-tx-things) https://github.com/bitcoin/bitcoin/pull/25273
<bitcoin-git>
[bitcoin] furszy opened pull request #25272: wallet: guard and alert about a wallet invalid state during chain sync (master...2022_wallet_invalid_state) https://github.com/bitcoin/bitcoin/pull/25272
<bitcoin-git>
[bitcoin] jonatack closed pull request #25271: net: helpfully log in ConnectNode() which peer we are already connected to (master...ConnectNode-say-which-peer-we-are-already-connected-to) https://github.com/bitcoin/bitcoin/pull/25271
<bitcoin-git>
[bitcoin] martinus closed pull request #22702: Add allocator for node based containers (master...2019-08-bulkpoolallocator) https://github.com/bitcoin/bitcoin/pull/22702
<bitcoin-git>
[bitcoin] jonatack opened pull request #25271: net: helpfully log in ConnectNode() which peer we are already connected to (master...ConnectNode-say-which-peer-we-are-already-connected-to) https://github.com/bitcoin/bitcoin/pull/25271
<nullcon>
Nullcon 2022 CFP closes on Jun 05, 2022. If anyone interested to submit a research related to bitcoin core security or cryptography: https://nullcon.net/goa-2022/cfp/
2022-06-02
<bitcoin-git>
[bitcoin] laanwj merged pull request #24171: p2p: Sync chain more readily from inbound peers during IBD (master...2022-01-download-from-inbound) https://github.com/bitcoin/bitcoin/pull/24171
<bitcoin-git>
bitcoin/master 00ce854 laanwj: Merge bitcoin/bitcoin#24171: p2p: Sync chain more readily from inbound pee...
<gribble>
https://github.com/bitcoin/bitcoin/issues/20962 | Alter the ChaCha20Poly1305@Bitcoin AEAD to the new specification by jonasschnelli · Pull Request #20962 · bitcoin/bitcoin · GitHub
<sipa>
Also continued review of the PRs darosior has been working on to get Miniscript integrated into Bitcoin Core.
<bitcoin-git>
bitcoin/master d7d9c7b glozow: [test util] add chain name to TestChain100Setup ctor
<bitcoin-git>
bitcoin/master 5374dfc glozow: [test util] use -checkmempool for TestingSetup mempool check ratio
<bitcoin-git>
[bitcoin] laanwj merged pull request #25264: kernel: pass params to BlockManager rather than using a global (master...no-kernel-global-params) https://github.com/bitcoin/bitcoin/pull/25264
<bitcoin-git>
bitcoin/master 636991d laanwj: Merge bitcoin/bitcoin#25264: kernel: pass params to BlockManager rather th...
<bitcoin-git>
[bitcoin] furszy opened pull request #25269: wallet: re-activate the not triggered "AmountWithFeeExceedsBalance" (master...2022_wallet_fix_missing_AmountWithFeeExceedsBalance) https://github.com/bitcoin/bitcoin/pull/25269
<laanwj>
davidbakin: if you don't get an answer here, you might want to ask in #bitcoin-wizards
2022-06-01
<bitcoin-git>
[bitcoin] theuni opened pull request #25264: kernel: pass params to BlockManager rather than using a global (master...no-kernel-global-params) https://github.com/bitcoin/bitcoin/pull/25264
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #25262: test: Set maxfeerate=0 in MiniWallet sendrawtransaction() (master...2206-test-mini-fast-📨) https://github.com/bitcoin/bitcoin/pull/25262
<bitcoin-git>
[bitcoin] fanquake opened pull request #25263: build: pass minisketch cppflags only where needed (master...minisketch_cpp_needed) https://github.com/bitcoin/bitcoin/pull/25263
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #25262: test: Set maxfeerate=0 in MiniWallet sendrawtransaction() (master...2206-test-mini-fast-📨) https://github.com/bitcoin/bitcoin/pull/25262
<bitcoin-git>
[bitcoin] fanquake merged pull request #25244: build: pass bdb cppflags only where needed (master...use_bdb_cppflags_needed) https://github.com/bitcoin/bitcoin/pull/25244
<bitcoin-git>
bitcoin/master 46a8909 fanquake: build: pass bdb cppflags only where needed
<bitcoin-git>
bitcoin/master b752dad fanquake: Merge bitcoin/bitcoin#25244: build: pass bdb cppflags only where needed
<bitcoin-git>
[bitcoin] MarcoFalke closed pull request #25257: p2p: Disconnect manual peers and not discourage all peers with the same address on getblocktxn msg corruption (master...2205-no-misbehaving-🌷) https://github.com/bitcoin/bitcoin/pull/25257
<bitcoin-git>
[bitcoin] ryanofsky reopened pull request #22764: build: Include qt sources for parsing with extract_strings.py (master...210821-translation) https://github.com/bitcoin/bitcoin/pull/22764
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #25257: p2p: Disconnect manual peers and not discourage all peers with the same address on getblocktxn msg corruption (master...2205-no-misbehaving-🌷) https://github.com/bitcoin/bitcoin/pull/25257
<bitcoin-git>
[bitcoin] klementtan opened pull request #25256: logging: Add leveldb thread name and fix logging empty thread name (master...add_leveldb_threadname) https://github.com/bitcoin/bitcoin/pull/25256
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #24178: p2p: Respond to getheaders if we have sufficient chainwork (master...2022-01-headers-response-requires-minchainwork) https://github.com/bitcoin/bitcoin/pull/24178
<bitcoin-git>
bitcoin/master a35f963 Suhas Daftuar: Add test for getheaders behavior
<bitcoin-git>
bitcoin/master 5f65aff MacroFake: Merge bitcoin/bitcoin#24178: p2p: Respond to getheaders if we have suffici...
<bitcoin-git>
[bitcoin] brunoerg opened pull request #25253: test: add coverage for non-hex value to -minimumchainwork (master...2022-05-minimumchainwork-nonhex) https://github.com/bitcoin/bitcoin/pull/25253
<bitcoin-git>
[gui] hebasto opened pull request #612: refactor: Drop unused `QFrame`s in `SendCoinsEntry` (master...220530-sendcoins) https://github.com/bitcoin-core/gui/pull/612
<theStack>
sipa: thanks, good to know. that explains why there are PRs around implementing elligator squared pubkeys (both in secp256k1 and bitcoin core), but no mention of it in the (obviously outdated) spec i read
<theStack>
bip324 question about handshake: in older slides (from breaking bitcoin 2019) i saw it was proposed that only odd pubkeys (i.e. starting with 0x03) are allowed, but the current BIP states only even pubkeys (i.e. starting with 0x02) are. any specific reason for this change?
<sipa>
And Bitcoin Core from back then cannot be used unmodified against today's OpenSSL's versions.
<sipa>
Well, it didn't happen with Bitcoin Core versions from 2014 linked against OpenSSL from 2014 and before.
<sipa>
but i believe that no version of bitcoin core (including very old ones) would emit such encodings
<sipa>
there are certainly DER private key encodings that are valid but bitcoin core today wouldn't be able to parse, as it doesn't have a full DER parser
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #25250: [22.x] test: replace hashlib.ripemd160 with an own implementation (22.x...2205-backport-ripemd160-👥) https://github.com/bitcoin/bitcoin/pull/25250
<sipa>
it's not clear to me whether this is an issue for the bitcoin core codebase at all (includin historical versions)
<DavidBakin>
so that means someone with such a wallet can't in fact use a newer bitcoin core to read it?
<div72>
laanwj: You're right, I've encountered the issue in a downstream where OpenSSL was still being used. The chances of this affecting Bitcoin is pretty slim as a wallet from a 7y old version which needs to be compiled with a pre 3 recent OpenSSL version is needed.
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #25044: test: Use MiniWallet in rpc_rawtransaction.py (master...test_rawtransaction_miniwallet) https://github.com/bitcoin/bitcoin/pull/25044
<bitcoin-git>
bitcoin/master 269fa66 MacroFake: Merge bitcoin/bitcoin#25044: test: Use MiniWallet in rpc_rawtransaction.py
<bitcoin-git>
[gui] hebasto opened pull request #611: test, refactor: Use the same shutdown path as in bitcoin-qt binary (master...220530-exec2) https://github.com/bitcoin-core/gui/pull/611
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #25242: [22.x] rpc: Capture potentially large UniValue by ref for rpcdoccheck (22.x...2205-uni-no-copy-📊) https://github.com/bitcoin/bitcoin/pull/25242
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #25241: [23.x] rpc: Capture potentially large UniValue by ref for rpcdoccheck (23.x...2205-uni-no-copy-📊) https://github.com/bitcoin/bitcoin/pull/25241
<bitcoin-git>
bitcoin/master 20ff499 Martin Zumsande: rpc: Capture potentially large UniValue by ref for rpcdoccheck
<laanwj>
div72: how do you even get a foreign key into that function? i don't think it's considered an issue because afaik, that function is only used for loading wallets, and it only supports the keys generated by bitcoin core itself