2020-05-26

< bitcoin-git> [bitcoin] jnewbery opened pull request #19070: p2p: Signal support for compact block filters with NODE_COMPACT_FILTERS (master...2020-05-node-compact-filters) https://github.com/bitcoin/bitcoin/pull/19070
< bitcoin-git> [bitcoin] theStack opened pull request #19069: refactor: replace pointers by references within tx_verify.{h,cpp} (master...20200526-refactor-replace-pointers-by-refs-in-tx_verify) https://github.com/bitcoin/bitcoin/pull/19069
< bitcoin-git> [bitcoin] laanwj merged pull request #19032: Serialization improvements: final step (master...202005_noncastserial_final) https://github.com/bitcoin/bitcoin/pull/19032
< bitcoin-git> bitcoin/master ef17c03 Pieter Wuille: Convert wallet to new serialization
< bitcoin-git> bitcoin/master 92beff1 Pieter Wuille: Convert LimitedString to formatter
< bitcoin-git> bitcoin/master 65c589e Pieter Wuille: Convert Qt to new serialization
< bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/fe1357a03af1...dcacea096e02
< andrewtoth> I did some rudimentary benchmarking on the connecting blocks with a cleared cache and it does seem to have a performance impact https://github.com/bitcoin/bitcoin/pull/18941#issuecomment-633684774
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18881: Prevent UB in DeleteLock() function (master...200505-cofu) https://github.com/bitcoin/bitcoin/pull/18881
< bitcoin-git> bitcoin/master 8d8921a Hennadii Stepanov: refactor: Add LockStackItem type alias
< bitcoin-git> bitcoin/master f511f61 Hennadii Stepanov: refactor: Add LockPair type alias
< bitcoin-git> bitcoin/master 458992b Hennadii Stepanov: Prevent UB in DeleteLock() function
< bitcoin-git> [bitcoin] MarcoFalke pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/13397dc78fd6...fe1357a03af1
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19056: rpc: Make gettxoutsetinfo/GetUTXOStats interruptible (master...2005-rpcInterrupt) https://github.com/bitcoin/bitcoin/pull/19056
< bitcoin-git> bitcoin/master 13397dc MarcoFalke: Merge #19056: rpc: Make gettxoutsetinfo/GetUTXOStats interruptible
< bitcoin-git> bitcoin/master fa75692 MarcoFalke: rpc: Make gettxoutsetinfo/GetUTXOStats interruptible
< bitcoin-git> bitcoin/master fa7fc5a MarcoFalke: rpc: factor out RpcInterruptionPoint from dumptxoutset
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d3b0ef80f653...13397dc78fd6
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18867: tests: Add fuzzing harness for CCoinsViewCache (master...fuzzers-coins_view) https://github.com/bitcoin/bitcoin/pull/18867
< bitcoin-git> bitcoin/master d3b0ef8 MarcoFalke: Merge #18867: tests: Add fuzzing harness for CCoinsViewCache
< bitcoin-git> bitcoin/master f9b22e3 practicalswift: tests: Add fuzzing harness for CCoinsViewCache
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7d32cce3e75b...d3b0ef80f653
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19010: net processing: Add support for getcfheaders (master...2020-05-cfheaders) https://github.com/bitcoin/bitcoin/pull/19010
< bitcoin-git> bitcoin/master 5308c97 Jim Posen: [test] Add test for cfheaders
< bitcoin-git> bitcoin/master f6b58c1 Jim Posen: [net processing] Message handling for getcfheaders.
< bitcoin-git> bitcoin/master 3bdc7c2 John Newbery: [doc] Add comment for m_headers_cache
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/14f844777746...7d32cce3e75b
< bitcoin-git> [bitcoin] fanquake opened pull request #19068: build: Use a zip instead of dmg for macOS releases (master...macdeploy_zip_instead_of_dmg) https://github.com/bitcoin/bitcoin/pull/19068
< bitcoin-git> [bitcoin] fanquake merged pull request #19059: gui: update Qt base translations for macOS release (master...macdeploy_translations) https://github.com/bitcoin/bitcoin/pull/19059
< bitcoin-git> bitcoin/master 14f8447 fanquake: Merge #19059: gui: update Qt base translations for macOS release
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/24f70290642c...14f844777746
< bitcoin-git> bitcoin/master 69bfcac fanquake: gui: update Qt base translations for macOS release

2020-05-25

< bitcoin-git> [bitcoin] practicalswift opened pull request #19067: tests: Add fuzzing harness for CNode (master...fuzzers-2020-05-25) https://github.com/bitcoin/bitcoin/pull/19067
< gribble> https://github.com/bitcoin/bitcoin/issues/19066 | corruption due to lack of memory is not handled · Issue #19066 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake closed pull request #18151: build: replace libdmg and genisoimage with xorriso (master...xorriso_replaces_libdmg_genisoimage) https://github.com/bitcoin/bitcoin/pull/18151
< elichai2> shesek: feel free to test this https://github.com/bitcoin/bitcoin/pull/18964 (promag )
< fjahr> Is this the same issue? https://github.com/bitcoin/bitcoin/issues/18954
< gribble> https://github.com/bitcoin/bitcoin/issues/17219 | wallet: allow transaction without change if keypool is empty by Sjors · Pull Request #17219 · bitcoin/bitcoin · GitHub

2020-05-24

< bitcoin-git> [bitcoin] practicalswift opened pull request #19065: tests: Add fuzzing harness for CAddrMan. Fill some fuzzing coverage gaps. (master...fuzzers-2020-05-23) https://github.com/bitcoin/bitcoin/pull/19065
< bitcoin-git> [bitcoin] hebasto opened pull request #19064: refactor: Cleanup thread ctor calls (master...200524-bind) https://github.com/bitcoin/bitcoin/pull/19064
< bitcoin-git> [bitcoin] rajarshimaitra opened pull request #19063: rpc: testmempoolaccept returns transaction fee (master...fee-in-testmempoolaccept) https://github.com/bitcoin/bitcoin/pull/19063
< gribble> https://github.com/bitcoin/bitcoin/issues/16432 | qt: Add privacy to the Overview page by hebasto · Pull Request #16432 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] maitrebitcoin opened pull request #19061: doc: new section on to how to build with visual studio (master...master) https://github.com/bitcoin/bitcoin/pull/19061

2020-05-23

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19060: test: Remove global wait_until from p2p_getdata (master...2005-testWaitUntilGetdata) https://github.com/bitcoin/bitcoin/pull/19060
< bitcoin-git> [bitcoin] meshcollider merged pull request #18594: cli: display multiwallet balances in -getinfo (master...cli-getinfo-multiwallet-balances) https://github.com/bitcoin/bitcoin/pull/18594
< bitcoin-git> bitcoin/master 9f01849 Jon Atack: cli: create GetWalletBalances() to fetch multiwallet balances
< bitcoin-git> bitcoin/master 7430775 Jon Atack: cli: lift -rpcwallet logic up to CommandLineRPC()
< bitcoin-git> bitcoin/master 29f2cbd Jon Atack: cli: extract connection exception handler, -rpcwait logic
< bitcoin-git> [bitcoin] meshcollider pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/793e0ff22cba...24f70290642c
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18698: Make g_chainman internal to validation (master...2004-chainman) https://github.com/bitcoin/bitcoin/pull/18698
< bitcoin-git> bitcoin/master fa84b1c MarcoFalke: validation: Make LoadBlockIndex() a member of ChainstateManager
< bitcoin-git> bitcoin/master fa05fdf MarcoFalke: net: Pass chainman into PeerLogicValidation
< bitcoin-git> bitcoin/master fa7b626 MarcoFalke: node: Add chainman alias for g_chainman
< bitcoin-git> [bitcoin] MarcoFalke pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/492cdc56e087...793e0ff22cba
< bitcoin-git> [bitcoin] fanquake opened pull request #19059: gui: update Qt base translations for macOS release (master...macdeploy_translations) https://github.com/bitcoin/bitcoin/pull/19059
< bitcoin-git> bitcoin/master 492cdc5 fanquake: Merge #19058: doc: Drop protobuf stuff
< bitcoin-git> [bitcoin] fanquake merged pull request #19058: doc: Drop protobuf stuff (master...200523-proto) https://github.com/bitcoin/bitcoin/pull/19058
< bitcoin-git> bitcoin/master ea9fcfd Hennadii Stepanov: doc: Drop protobuf stuff
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fa3288cda125...492cdc56e087
< fanquake> Pinged a few people re adding release notes for 0.20.0 to https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.20.0-Release-Notes-Draft. If you end up adding some let me know / comment on the PR and I'll cleanup the last few "needs release notes" labels
< bitcoin-git> [bitcoin] hebasto opened pull request #19058: doc: Drop protobuf stuff (master...200523-proto) https://github.com/bitcoin/bitcoin/pull/19058

2020-05-22

< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19052: tests: Don't limit fuzzing inputs to 1 MB for afl-fuzz (now: ∞ ∀ fuzzers) (master...remove-afl-limit) https://github.com/bitcoin/bitcoin/pull/19052
< bitcoin-git> bitcoin/master fa3288c MarcoFalke: Merge #19052: tests: Don't limit fuzzing inputs to 1 MB for afl-fuzz (now:...
< bitcoin-git> bitcoin/master 6a239e7 practicalswift: tests: Don't limit fuzzing inputs to 1 MB for afl-fuzz (now: ∞ ∀ fuzzers)
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b5c423c48e09...fa3288cda125
< gribble> https://github.com/bitcoin/bitcoin/issues/17331 | Use effective values throughout coin selection by achow101 · Pull Request #17331 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19056: rpc: Make gettxoutsetinfo/GetUTXOStats interruptible (master...2005-rpcInterrupt) https://github.com/bitcoin/bitcoin/pull/19056
< bitcoin-git> [bitcoin] fjahr opened pull request #19055: Calculate UTXO set hash using Muhash (master...csi-1-muhash) https://github.com/bitcoin/bitcoin/pull/19055
< gribble> https://github.com/bitcoin/bitcoin/issues/15382 | util: add runCommandParseJSON by Sjors · Pull Request #15382 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18594 | cli: display multiwallet balances in -getinfo by jonatack · Pull Request #18594 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18918 | wallet: Move salvagewallet into wallettool by achow101 · Pull Request #18918 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18787 | wallet: descriptor wallet release notes and cleanups by achow101 · Pull Request #18787 · bitcoin/bitcoin · GitHub
< meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball ariard digi_james amiti fjahr
< bitcoin-git> [bitcoin] achow101 opened pull request #19054: wallet: Skip hdKeypath of 'm' when determining inactive hd seeds (master...inactive-seed-skip-m) https://github.com/bitcoin/bitcoin/pull/19054
< bitcoin-git> [bitcoin] theStack opened pull request #19053: refactor: replace CNode pointers by references within net_processing.{h,cpp} (master...20200522-refactor-use-cnode-references-within-net_processing) https://github.com/bitcoin/bitcoin/pull/19053
< bitcoin-git> [bitcoin] practicalswift opened pull request #19052: tests: Don't limit fuzzing inputs to 1 MB for afl-fuzz (now: ∞ ∀ fuzzers) (master...remove-afl-limit) https://github.com/bitcoin/bitcoin/pull/19052
< bitcoin-git> [bitcoin] fjahr opened pull request #19050: doc: Add warning for rest interface limitation (master...rest_fd) https://github.com/bitcoin/bitcoin/pull/19050
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19014: test: Replace TEST_PREVIOUS_RELEASES env var with test_framework option (master...2005-testPrevReleases) https://github.com/bitcoin/bitcoin/pull/19014
< bitcoin-git> bitcoin/master b5c423c MarcoFalke: Merge #19014: test: Replace TEST_PREVIOUS_RELEASES env var with test_frame...
< bitcoin-git> bitcoin/master fad798b MarcoFalke: test: Default --previous-releases to false if dir is empty
< bitcoin-git> bitcoin/master faf1c3c MarcoFalke: test: Replace TEST_PREVIOUS_RELEASES env var with test_framework option
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/df303ceb6505...b5c423c48e09
< bitcoin-git> [bitcoin] rajarshimaitra opened pull request #19048: test: changing signature of wait_until(). (master...fixing-waituntil) https://github.com/bitcoin/bitcoin/pull/19048
< bitcoin-git> [bitcoin] achow101 opened pull request #19046: Replace CWallet::Set* functions that use memonly with Add/Load variants (master...rm-load-memonly) https://github.com/bitcoin/bitcoin/pull/19046
< bitcoin-git> [bitcoin] meshcollider merged pull request #18787: wallet: descriptor wallet release notes and cleanups (master...desc-wallet-followup) https://github.com/bitcoin/bitcoin/pull/18787
< bitcoin-git> bitcoin/master 89b1ce1 Andrew Chow: Remove unimplemented SetCrypted from DescriptorScriptPubKeyMan
< bitcoin-git> bitcoin/master b9073c8 Andrew Chow: rpc: createwallet warning that descriptor wallets are experimental
< bitcoin-git> bitcoin/master 610030d Andrew Chow: docs: Add release notes for descriptor wallets
< bitcoin-git> [bitcoin] meshcollider pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/ccd85b57af60...df303ceb6505
< bitcoin-git> [bitcoin] meshcollider merged pull request #17681: wallet: Keep inactive seeds after sethdseed and derive keys from them as needed (master...keep-inactive-seeds) https://github.com/bitcoin/bitcoin/pull/17681
< bitcoin-git> bitcoin/master c93082e Andrew Chow: Generate new keys for inactive seeds after marking used
< bitcoin-git> bitcoin/master 45f2f6a Andrew Chow: Determine inactive HD seeds from key metadata and track them in LegacyScri...
< bitcoin-git> bitcoin/master b59b450 Andrew Chow: have GenerateNewKey and DeriveNewChildKey take a CHDChain as an argument
< bitcoin-git> [bitcoin] meshcollider pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/ad3a61c5f5c9...ccd85b57af60

2020-05-21

< bitcoin-git> bitcoin/master 9d3f7eb gzhao408: [mempool] sanity check that all unbroadcast txns are in mempool
< bitcoin-git> [bitcoin] fanquake merged pull request #18895: p2p: unbroadcast followups: rpcs, nLastResend, mempool sanity check (master...unbroadcast-followup) https://github.com/bitcoin/bitcoin/pull/18895
< bitcoin-git> bitcoin/master a7ebe48 gzhao408: [rpc] add unbroadcast info to mempool entries and getmempoolinfo
< bitcoin-git> bitcoin/master d160069 gzhao408: [wallet] remove nLastResend logic
< bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/9abed46871a7...ad3a61c5f5c9
< bitcoin-git> [bitcoin] fanquake closed pull request #19045: qt: pt_BR translation adjustments (master...2020-05-qt-pt_BR-translation-adjustments) https://github.com/bitcoin/bitcoin/pull/19045
< bitcoin-git> [bitcoin] gabrieldonadel opened pull request #19045: qt: pt_BR translation adjustments (master...2020-05-qt-pt_BR-translation-adjustments) https://github.com/bitcoin/bitcoin/pull/19045
< bitcoin-git> [bitcoin] jnewbery opened pull request #19044: net processing: Add support for getcfilters (master...2020-05-cfilters) https://github.com/bitcoin/bitcoin/pull/19044
< bitcoin-git> [bitcoin] MDrollette opened pull request #19043: torcontrol: add -tortarget config (master...tor-hidden-target) https://github.com/bitcoin/bitcoin/pull/19043
< BlueMatt> my thinking was the goal wasnt to try to just scramble the bitcoin data to make it look like noise on the wire, it was to actually have redundant codepaths (and network paths) to fetch block data
< BlueMatt> ariard: maybe, but (1) provides you ability to get data from things that arent bidirectional high-bandwidth sockets. (2) is just a way to shove bitcoin p2p protocol over top of something else.
< BlueMatt> right, fair. i guess just in my past thinking on this I've always considered mostly more nice bitcoin data providers, less p2p-encryption/modoulation-style providers. I agree that would be a cool goal as well, though i guess is fully separate from things I was thinking about
< BlueMatt> sipa: as for "the goal", thats true, if we want to model after eg tor's pluggable transport, we want a byte stream, but I think bitcoin data is a little too unique for that - because its so small, we end up being able to shove it in all kinds of queries
< wumpus> BlueMatt: yes, I know, it was great! unfortuantely the approach to integrate them into bitcoin core didn't work with regard to review and organizationaly
< jnewbery> perhaps this more speculative discussion is better suited to bitcoin-wizards or similar?
< BlueMatt> eg you can write dns + http + radio + a full second p2p client with only these functions: https://github.com/TheBlueMatt/bitcoin/blob/d3ca09afbc38d7f73866da33948651ac2c40fd58/src/rusty/src/cpp_bridge.cpp
< jnewbery> ariard: what do you need help with? From my perspective, there's still a lot of work to be done internally in Bitcoin Core cleaning up the layer separation between net / net_processing / validation, but I haven't reviewed your branch yet
< BlueMatt> but you magically make the censor think you're connecting to that but are in fact connecting to a bitcoin core reset endpoint
< wumpus> bitcoin core is I/O bound but usually only on disk, not on P2P/network
< wumpus> if it runs in an external process and communicates with bitcoin core that's the right way
< wumpus> while I think alternative transports are great, I don't think we should integrate the code for all the transports into bitcoin core
< gribble> https://github.com/bitcoin/bitcoin/issues/18989 | Towards alternative transports first-class support · Issue #18989 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18787 | wallet: descriptor wallet release notes and cleanups by achow101 · Pull Request #18787 · bitcoin/bitcoin · GitHub
< wumpus> https://github.com/bitcoin/bitcoin/projects/8 4 blockers, 1 bugfix, 4 chasing concept ACK
< gribble> https://github.com/bitcoin/bitcoin/issues/18297 | build: Use pkg-config in BITCOIN_QT_CONFIGURE for all hosts including Windows by hebasto · Pull Request #18297 · bitcoin/bitcoin · GitHub
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james amiti fjahr
< bitcoin-git> [bitcoin] laanwj merged pull request #16946: wallet: include a checksum of encrypted private keys (master...wallet-enckey-checksum) https://github.com/bitcoin/bitcoin/pull/16946
< bitcoin-git> bitcoin/master d67055e Andrew Chow: Upgrade or rewrite encrypted key checksums
< bitcoin-git> bitcoin/master c9a9ddb Andrew Chow: Set fDecryptionThoroughlyChecked based on whether crypted key checksums ar...
< bitcoin-git> bitcoin/master a8334f7 Andrew Chow: Read and write a checksum for encrypted keys
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/4479eb04d928...9abed46871a7
< theStack> luke-jr: yes indeed; bitcoin.org is not under the control of the core devs now i guess?
< jonatack> theStack: luke-jr: i proposed to bring bitcoinacks, with pierre_rochard's permission, into https://github.com/bitcoin-core/ to see more attention
< theStack> i think jonatack proposed to run it on bitcoin.org recently if i remember correctly; any plans about that? or is the idea that people spin it up locally? (should also be quite easy thanks to docker)
< theStack> that's great news! i wondered recently what happened to bitcoin-acks.com
< wumpus> PSA bitcoin-acks has a repository in the bitcoincore organization now: https://github.com/bitcoin-core/bitcoin-acks @ jonatack pierre_rochard
< bitcoin-git> [bitcoin] laanwj merged pull request #18960: indexes: Add compact block filter headers cache (master...2020-05-cfcheckpts-cache) https://github.com/bitcoin/bitcoin/pull/18960
< bitcoin-git> bitcoin/master 4479eb0 Wladimir J. van der Laan: Merge #18960: indexes: Add compact block filter headers cache
< bitcoin-git> bitcoin/master 0187d4c John Newbery: [indexes] Add compact block filter headers cache
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fed1a9043fdf...4479eb04d928
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19041: ci: tsan with -stdlib=libc++ (master...2005-ciTsanFix) https://github.com/bitcoin/bitcoin/pull/19041
< bitcoin-git> [bitcoin] laanwj merged pull request #19020: net: Use C++11 member initialization in protocol (master...2005-netCxx11MemberInit) https://github.com/bitcoin/bitcoin/pull/19020
< bitcoin-git> bitcoin/master fed1a90 Wladimir J. van der Laan: Merge #19020: net: Use C++11 member initialization in protocol
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/99e5e21b38bc...fed1a9043fdf
< bitcoin-git> bitcoin/master fa8bbb1 MarcoFalke: net: Use C++11 member initialization in protocol
< bitcoin-git> [bitcoin] laanwj merged pull request #19023: test: Fix intermittent ETIMEDOUT on FreeBSD (master...2005-testFixIntermFreeBsdTimeout) https://github.com/bitcoin/bitcoin/pull/19023
< bitcoin-git> bitcoin/master 99e5e21 Wladimir J. van der Laan: Merge #19023: test: Fix intermittent ETIMEDOUT on FreeBSD
< bitcoin-git> bitcoin/master fab908f MarcoFalke: test: Fix intermittent ETIMEDOUT on FreeBSD
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/741816936441...99e5e21b38bc
< gribble> https://github.com/bitcoin/bitcoin/issues/18960 | indexes: Add compact block filter headers cache by jnewbery · Pull Request #18960 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/1896 | Translation update for 0.7.1 · Issue #1896 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18997: gui: Remove un-actionable TODO (master...2005-guiNoTodo) https://github.com/bitcoin/bitcoin/pull/18997
< bitcoin-git> bitcoin/master 7418169 MarcoFalke: Merge #18997: gui: Remove un-actionable TODO
< bitcoin-git> bitcoin/master 4444dbf MarcoFalke: gui: Remove un-actionable TODO
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cfe22a5f9e1d...741816936441
< vasild> is "if (GetMainSignals().CallbacksPending() > 10) {" mentioned in https://github.com/bitcoin/bitcoin/issues/14343#issuecomment-426916136 exactly that, "race conditions in threading"?
< gribble> https://github.com/bitcoin/bitcoin/issues/14343 | coverage reports non-deterministic · Issue #14343 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18530: Add test for -blocksonly and -whitelistforcerelay param interaction (master...add_blocksonly_tests) https://github.com/bitcoin/bitcoin/pull/18530
< bitcoin-git> bitcoin/master cfe22a5 MarcoFalke: Merge #18530: Add test for -blocksonly and -whitelistforcerelay param inte...
< bitcoin-git> bitcoin/master 0ea5d70 glowang: Updated comment for the condition where a transaction relay is denied
< bitcoin-git> bitcoin/master be01449 glowang: Add test for param interaction b/w -blocksonly and -whitelistforcerelay
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/25ad2c623af3...cfe22a5f9e1d
< bitcoin-git> [bitcoin] hebasto reopened pull request #19029: net: Fix CThreadInterrupt::sleep_for TSan issues (master...200520-interrupts) https://github.com/bitcoin/bitcoin/pull/19029
< bitcoin-git> bitcoin/master ccb5059 Russell Yanofsky: scripted-diff: Remove g_rpc_node references
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18740: Remove g_rpc_node global (master...pr/frpc) https://github.com/bitcoin/bitcoin/pull/18740
< bitcoin-git> bitcoin/master 6fca33b Russell Yanofsky: refactor: Pass NodeContext to RPC and REST methods through util::Ref
< bitcoin-git> bitcoin/master 691c817 Russell Yanofsky: Add util::Ref class as temporary alternative for c++17 std::any
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/97b21b302a11...25ad2c623af3
< bitcoin-git> [bitcoin] hebasto closed pull request #19029: net: Fix CThreadInterrupt::sleep_for TSan issues (master...200520-interrupts) https://github.com/bitcoin/bitcoin/pull/19029
< fanquake> If you look here: https://travis-ci.org/github/bitcoin/bitcoin/requests, that was the status for your branch
< bitcoin-git> [bitcoin] fanquake merged pull request #18677: Multiprocess build support (master...pr/ipc-build2) https://github.com/bitcoin/bitcoin/pull/18677
< bitcoin-git> bitcoin/master e2bab2a Russell Yanofsky: multiprocess: add multiprocess travis configuration
< bitcoin-git> bitcoin/master 603fd6a Russell Yanofsky: depends: add MULTIPROCESS depends option
< bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/17df15efb546...97b21b302a11
< bitcoin-git> bitcoin/master 5d1377b Russell Yanofsky: build: multiprocess autotools changes
< vasild> fanquake: https://travis-ci.org/github/bitcoin/bitcoin/builds/689316499 that is the result from the initial run after PR was opened. Afterwards I push-f'ed 2 times, hopefully resolving those failures (first push -f) and rebasing (second push -f)
< gribble> https://github.com/bitcoin/bitcoin/issues/19036 | Cannot change passphrase even if it is correct · Issue #19036 · bitcoin/bitcoin · GitHub
< elichai2> Hi, I'm looking at issue #19036, and shouldn't this: https://github.com/bitcoin/bitcoin/blob/master/src/wallet/wallet.cpp#L328 be `continue;` instead of `return false;` so it will continue trying master keys?
< gribble> https://github.com/bitcoin/bitcoin/issues/19031 | Implement ADDRv2 support (part of BIP155) by vasild · Pull Request #19031 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake merged pull request #18958: guix: Make V=1 more powerful for debugging (master...2020-05-guix-improvements) https://github.com/bitcoin/bitcoin/pull/18958
< bitcoin-git> bitcoin/master 17df15e fanquake: Merge #18958: guix: Make V=1 more powerful for debugging
< bitcoin-git> bitcoin/master f852761 Carl Dong: guix: Add clarifying documentation for V env var
< bitcoin-git> bitcoin/master 85f4a4b Carl Dong: guix: Make V=1 more powerful for debugging
< bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/3eda7ea9ba72...17df15efb546

2020-05-20

< bitcoin-git> [bitcoin] promag opened pull request #19033: http: Fix workQueue race on InterruptHTTPServer (master...2020-05-fix-race-interrupt-http-server) https://github.com/bitcoin/bitcoin/pull/19033
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18764: refactor: test: replace inv type magic numbers by constants (master...20200425-test-replace_inv_types_by_constants) https://github.com/bitcoin/bitcoin/pull/18764
< bitcoin-git> bitcoin/master eeaaa58 Sebastian Falbesoner: test: replace inv type magic numbers by constants
< bitcoin-git> bitcoin/master b35e1d2 Sebastian Falbesoner: test: add inventory type constant MSG_CMPCT_BLOCK
< bitcoin-git> bitcoin/master 4a614ff Sebastian Falbesoner: test: explicit imports from test_framework.messages in p2p_invalid_message...
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/448bdff26307...3eda7ea9ba72
< bitcoin-git> [bitcoin] sipa opened pull request #19032: Serialization improvements: final step (master...202005_noncastserial_final) https://github.com/bitcoin/bitcoin/pull/19032
< bitcoin-git> [bitcoin] dongcarl closed pull request #16748: [WIP] Add support for addrv2 (BIP155) (master...2019-07-addrv2v4) https://github.com/bitcoin/bitcoin/pull/16748
< bitcoin-git> [bitcoin] vasild opened pull request #19031: Implement ADDRv2 support (part of BIP155) (master...addrv2) https://github.com/bitcoin/bitcoin/pull/19031
< gribble> https://github.com/bitcoin/bitcoin/issues/18424 | qt: Use parent-child relation to manage lifetime of OptionsModel object by hebasto · Pull Request #18424 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] hebasto opened pull request #19029: net: Fix CThreadInterrupt::sleep_for TSan issues (master...200520-interrupts) https://github.com/bitcoin/bitcoin/pull/19029
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19028: test: Set -logthreadnames in unit tests (master...2005-testThreadNames) https://github.com/bitcoin/bitcoin/pull/19028
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18317: Serialization improvements step 6 (all except wallet/gui) (master...202003_noncastserial_6) https://github.com/bitcoin/bitcoin/pull/18317
< bitcoin-git> bitcoin/master d06fedd Russell Yanofsky: Add SER_READ and SER_WRITE for read/write-dependent statements
< bitcoin-git> bitcoin/master 6f9a1e5 Russell Yanofsky: Extend CustomUintFormatter to support enums
< bitcoin-git> bitcoin/master 769ee5f Pieter Wuille: Merge BigEndian functionality into CustomUintFormatter
< bitcoin-git> [bitcoin] MarcoFalke pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/e20e964cb1ab...448bdff26307
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18996: net: Remove un-actionable TODO (master...2005-netNoTodo) https://github.com/bitcoin/bitcoin/pull/18996
< bitcoin-git> bitcoin/master e20e964 MarcoFalke: Merge #18996: net: Remove un-actionable TODO
< bitcoin-git> bitcoin/master fabea6d MarcoFalke: net: Run clang-format on protocol.h
< bitcoin-git> bitcoin/master facdeea MarcoFalke: net: Remove un-actionable TODO
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/bd5ec7c5284d...e20e964cb1ab
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19006: rpc: Avoid crash when g_thread_http was never started (master...2005-httpNoCrash) https://github.com/bitcoin/bitcoin/pull/19006
< bitcoin-git> bitcoin/master faf45d1 MarcoFalke: http: Avoid crash when g_thread_http was never started
< bitcoin-git> bitcoin/master fa12a37 MarcoFalke: test: Replace inline-comments with logs, pep8 formatting
< bitcoin-git> bitcoin/master fa83b39 MarcoFalke: init: Remove confusing and redundant InitError
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/a587f85853ec...bd5ec7c5284d
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #18587: gui: Avoid wallet tryGetBalances calls in WalletModel::pollBalanceChanged (master...pr/ipc-bal) https://github.com/bitcoin/bitcoin/pull/18587
< bitcoin-git> bitcoin/master bf0a510 Russell Yanofsky: gui: Avoid wallet tryGetBalances calls before TransactionChanged or BlockT...
< bitcoin-git> bitcoin/master 2bc9b92 Russell Yanofsky: Cancel wallet balance timer when shutdown requested
< bitcoin-git> bitcoin/master 83f69fa Russell Yanofsky: Switch transaction table to use wallet height not node height
< bitcoin-git> [bitcoin] jonasschnelli pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/0aa2ff0f660e...a587f85853ec
< PaulTroon> BIP34 was an interesting historic read - is Gavin's speculation about a duplicate coinbase in 2048 technically impossible for a malicous miner? https://github.com/bitcoin/bitcoin/pull/1526#issuecomment-6796145
< bitcoin-git> [bitcoin] fanquake opened pull request #19025: [0.19] Backports (0.19...0_19_2_backports) https://github.com/bitcoin/bitcoin/pull/19025
< sipa> ah, i forgot: https://github.com/bitcoin/bitcoin/pull/16083 added statistics using undo data
< bitcoin-git> [bitcoin] fanquake merged pull request #18956: build: enforce minimum required Windows version (7) (master...window_enforce_runtime_version) https://github.com/bitcoin/bitcoin/pull/18956
< bitcoin-git> bitcoin/master 0aa2ff0 fanquake: Merge #18956: build: enforce minimum required Windows version (7)
< bitcoin-git> bitcoin/master e8a8cff fanquake: build: enforce minimum required Windows version (7)
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/aa8d76806c74...0aa2ff0f660e

2020-05-19

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19023: test: Fix intermittent ETIMEDOUT on FreeBSD (master...2005-testFixIntermFreeBsdTimeout) https://github.com/bitcoin/bitcoin/pull/19023
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19022: test: Fix intermittent failure in feature_dbcrash (master...2005-testFixIntermittentFailDbCrash) https://github.com/bitcoin/bitcoin/pull/19022
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #19007: relax GUI locks: avoid unnecesarry calls to ::ChainstateActive().IsInitialBlockDownload (master...2020/05/fix_macguilock) https://github.com/bitcoin/bitcoin/pull/19007
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19020: net: Use C++11 member initialization in protocol (master...2005-netCxx11MemberInit) https://github.com/bitcoin/bitcoin/pull/19020
< bitcoin-git> [bitcoin] luke-jr opened pull request #19019: [0.20] Fix GBT: Restore "!segwit" and "csv" to "rules" key (0.20...fix_gbt_buried) https://github.com/bitcoin/bitcoin/pull/19019
< bitcoin-git> [bitcoin] limpbrains opened pull request #19018: docs: fixing description of the field sequence in walletcreatefundedpsbt RPC method (master...walletcreatefundedpsbt-fix-docs) https://github.com/bitcoin/bitcoin/pull/19018
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #16756: test: Connection eviction logic tests (master...201908_test_eviction) https://github.com/bitcoin/bitcoin/pull/16756
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #16756: test: Connection eviction logic tests (master...201908_test_eviction) https://github.com/bitcoin/bitcoin/pull/16756
< bitcoin-git> [bitcoin] practicalswift closed pull request #18920: doc: Document how to analyze Bitcoin Core using Clang Static Analysis, clang-tidy and cppcheck (master...static-analysis-clang-tidy) https://github.com/bitcoin/bitcoin/pull/18920
< gribble> https://github.com/bitcoin/bitcoin/issues/18956 | build: enforce minimum required Windows version (7) by fanquake · Pull Request #18956 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17946: Fix GBT: Restore "!segwit" and "csv" to "rules" key (master...fix_gbt_buried) https://github.com/bitcoin/bitcoin/pull/17946
< bitcoin-git> bitcoin/master aa8d768 MarcoFalke: Merge #17946: Fix GBT: Restore "!segwit" and "csv" to "rules" key
< bitcoin-git> bitcoin/master 412d5fe Luke Dashjr: QA: feature_segwit: Check that template "rules" includes "!segwit" as appr...
< bitcoin-git> bitcoin/master 2abe8cc Luke Dashjr: Bugfix: Include "csv","!segwit" in "rules"
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d44dd513226f...aa8d76806c74
< bitcoin-git> [bitcoin] practicalswift opened pull request #19015: build: Enable some commonly enabled compiler diagnostics (master...compiler-diagnostics) https://github.com/bitcoin/bitcoin/pull/19015
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #18152: qt: Use SynchronizationState enum for signals to GUI (master...20200215-pr18121-followup2) https://github.com/bitcoin/bitcoin/pull/18152
< bitcoin-git> bitcoin/master 2bec309 Hennadii Stepanov: refactor: Remove unused bool parameter in RPCNotifyBlockChange()
< bitcoin-git> bitcoin/master 1dab574 Hennadii Stepanov: refactor: Pass SynchronizationState enum to GUI
< bitcoin-git> bitcoin/master 1df7701 Hennadii Stepanov: refactor: Remove unused bool parameter in BlockNotifyGenesisWait()
< bitcoin-git> [bitcoin] jonasschnelli pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/e7736854ef6c...d44dd513226f
< bitcoin-git> [bitcoin] fanquake closed pull request #18903: test: fix TEST_PREVIOUS_RELEASES check (master...getenv_defaults_to_None) https://github.com/bitcoin/bitcoin/pull/18903
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19014: test: Replace TEST_PREVIOUS_RELEASES env var with test_framework option (master...2005-testPrevReleases) https://github.com/bitcoin/bitcoin/pull/19014
< bitcoin-git> [bitcoin] Sjors opened pull request #19013: test: add v0.20.0 to backwards compatibility test (master...2020/05/previous_release_0.20) https://github.com/bitcoin/bitcoin/pull/19013
< bitcoin-git> [bitcoin] fanquake merged pull request #19008: ci: tsan on clang-9 (master...2005-ciTsanFocal) https://github.com/bitcoin/bitcoin/pull/19008
< bitcoin-git> bitcoin/master e773685 fanquake: Merge #19008: ci: tsan on clang-9
< bitcoin-git> bitcoin/master faf5521 MarcoFalke: ci: Set DEBIAN_FRONTEND=noninteractive
< bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/042ff521421f...e7736854ef6c
< bitcoin-git> bitcoin/master fa006ca MarcoFalke: ci: tsan on clang-9
< bitcoin-git> [bitcoin] hosseinamin closed pull request #14898: rpc listtransactions new argument options (paginatebypointer impl) (master...master) https://github.com/bitcoin/bitcoin/pull/14898
< elichai2> Finished reading http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-05-08-19.00.log.html, I have a naive question, no-one suggested using leveldb(since we already use that in validation) to replace bdb, is it because the main reason is for future table features or there is something bad/problematic with leveldb?
< bitcoin-git> [bitcoin] fanquake merged pull request #18999: log: Remove "No rpcpassword set" from logs (master...2005-logRpcPassword) https://github.com/bitcoin/bitcoin/pull/18999
< bitcoin-git> bitcoin/master fa243be MarcoFalke: log: Remove "No rpcpassword set" from logs
< bitcoin-git> bitcoin/master 042ff52 fanquake: Merge #18999: log: Remove "No rpcpassword set" from logs
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c73bd004ae81...042ff521421f
< bitcoin-git> [bitcoin] fanquake merged pull request #18861: Do not answer GETDATA for to-be-announced tx (master...202004_private_getdata) https://github.com/bitcoin/bitcoin/pull/18861
< bitcoin-git> bitcoin/master 2896c41 Pieter Wuille: Do not answer GETDATA for to-be-announced tx
< bitcoin-git> bitcoin/master c6131bf Pieter Wuille: Abstract logic to determine whether to answer tx GETDATA
< bitcoin-git> bitcoin/master f2f32a3 Pieter Wuille: Push down use of cs_main into FindTxForGetData
< bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/362f9c60a54e...c73bd004ae81
< gribble> https://github.com/bitcoin/bitcoin/issues/14066 | gitian-linux: Build binaries for 64-bit POWER by luke-jr · Pull Request #14066 · bitcoin/bitcoin · GitHub
< fanquake> tryphe: It's on by default if you're compiling using Ubuntu, which we are for gitian builds. We do have to add it explicitly when building for RISCV though: https://github.com/bitcoin/bitcoin/blob/master/contrib/gitian-descriptors/gitian-linux.yml#L160
< gribble> https://github.com/bitcoin/bitcoin/issues/18152 | qt: Use SynchronizationState enum for signals to GUI by hebasto · Pull Request #18152 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18986: tests: Add capability to disable RPC timeout in functional tests (master...notimeout-flag) https://github.com/bitcoin/bitcoin/pull/18986
< bitcoin-git> bitcoin/master 362f9c6 MarcoFalke: Merge #18986: tests: Add capability to disable RPC timeout in functional t...
< bitcoin-git> bitcoin/master 784ae09 codeShark149: test: Add capability to disable RPC timeout in functional tests.
< bitcoin-git> bitcoin/master 38c3dd9 codeShark149: docs: Add notes on how to diasble rpc timeout in functional tests while at...
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/dc5333d31f28...362f9c60a54e

2020-05-18

< tryphe> is there any way to resolve these review comments? i guess i've selected the wrong review type but it looks ugly to see all of my comments expanded: https://github.com/bitcoin/bitcoin/pull/19004#pullrequestreview-413807305
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #19011: Reduce cs_main lock accumulation during GUI startup (master...2020/05/guilocks) https://github.com/bitcoin/bitcoin/pull/19011
< bitcoin-git> [bitcoin] jnewbery opened pull request #19010: net processing: Add support for getcfheaders (master...2020-05-cfheaders) https://github.com/bitcoin/bitcoin/pull/19010
< bitcoin-git> [bitcoin] h2o10 opened pull request #19009: Print "verifychain" progress every 1 step if user verifies whole blockchain. (master...patch-3) https://github.com/bitcoin/bitcoin/pull/19009
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19008: ci: tsan on focal (master...2005-ciTsanFocal) https://github.com/bitcoin/bitcoin/pull/19008
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #19007: relax GUI locks: avoid unnecesarry calls to ::ChainstateActive().IsInitialBlockDownload (master...2020/05/fix_macguilock) https://github.com/bitcoin/bitcoin/pull/19007
< gribble> https://github.com/bitcoin/bitcoin/issues/12783 | macOS: disable AppNap during sync by krab · Pull Request #12783 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19006: http: Avoid crash when g_thread_http was never started (master...2005-httpNoCrash) https://github.com/bitcoin/bitcoin/pull/19006
< bitcoin-git> [bitcoin] kcalvinalvin opened pull request #19005: doc: Add documentation for 'checklevel' argument in 'verifychain' RPC… (master...add-documentation-for-verifychain) https://github.com/bitcoin/bitcoin/pull/19005
< bitcoin-git> [bitcoin] kcalvinalvin opened pull request #19004: script: Replace const char* to std::string (master...replace-char-with-string) https://github.com/bitcoin/bitcoin/pull/19004
< shesek> I guess there's no --bitcoin-unlimited parameter that would easily let me make blocks that are larger than the weight limit, right? :p
< hebasto> wumpus: kindly reminder -- is it time to upload rc2 to https://bitcoincore.org/bin/bitcoin-core-0.20.0/ ?
< gribble> https://github.com/bitcoin/bitcoin/issues/17946 | Fix GBT: Restore "!segwit" and "csv" to "rules" key by luke-jr · Pull Request #17946 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] shesek opened pull request #19002: docs: Document that 'fee' is unavailable when there are non-wallet inputs (master...202005-docs-fee) https://github.com/bitcoin/bitcoin/pull/19002
< shesek> I'm afraid that I'm probably not the the right person for the job, but I will happily help with testing. :) but yes, sorry, I know that making these requests without offering any help implementing them is not very useful. bitcoin core has plenty of features that could be added if someone with the expertise and time prioritized them

2020-05-17

< shesek> does bitcoin-qt not show the fee of confirmed incoming transactions (ie where the spent prevouts are no longer in the utxo set)?
< shesek> bitcoin-qt does seem to somehow get it
< bitcoin-git> [bitcoin] sipa closed pull request #18977: [DONTMERGE] Test ranked_index (master...202005_try_ranked) https://github.com/bitcoin/bitcoin/pull/18977
< bitcoin-git> [bitcoin] 10xcryptodev opened pull request #19001: qt: bugfix unsupported QLocale languages (master...202005-bugfix-qlocale) https://github.com/bitcoin/bitcoin/pull/19001
< jonatack> tryphe: on github projects with a small number of collaborators i think they are fun; on more widely-watched ones like bitcoin core i tend to not use them to avoid it turning into a social media or slack feed. using an emoji inside a comment, sure. worked more ideas into the doc from all three of you, thanks!
< tryphe> when getting into bitcoin PR review i feel like there's this -almost- unscalable mountain in front of you; semi-scalable in terms of "things that i can actually review without much historical bitcoin knowlegde" (NATPMP for example, that was easy, but almost straightforward enough that it requires no comments), but also unscalable parts in terms of other PRs where the motivation was so ingenius that trying to review it almost seems like a
< jonatack> i think this was the last time recently where i reviewed the code before the concept ack https://github.com/bitcoin/bitcoin/pull/18962#issuecomment-627635800
< michaelfolkson> On your previous question tryphe I would say follow the guidelines as much as possible https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#code-review
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18999: 2005 log rpc password (master...2005-logRpcPassword) https://github.com/bitcoin/bitcoin/pull/18999