< wumpus> "BIP148 user activated activation of segwit" huuuh that's a bit late
< aj> not if there's a ~100k block reorg!
< bitcoin-git> [bitcoin] laanwj closed pull request #16357: util: Implement modulo for arith_uint256 (master...uint256-modulo) https://github.com/bitcoin/bitcoin/pull/16357
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c799976c86e2...8046a3e0befe
< bitcoin-git> bitcoin/master f27bd96 João Barbosa: gui: Fix missing qRegisterMetaType(WalletModel*)
< bitcoin-git> bitcoin/master 64fee48 João Barbosa: qt: Assert QMetaObject::invokeMethod result
< bitcoin-git> bitcoin/master 8046a3e Wladimir J. van der Laan: Merge #16348: qt: Assert QMetaObject::invokeMethod result
< bitcoin-git> [bitcoin] laanwj merged pull request #16348: qt: Assert QMetaObject::invokeMethod result (master...2019-07-assert-invoke-method) https://github.com/bitcoin/bitcoin/pull/16348
< bitcoin-git> [bitcoin] conscott closed pull request #14691: tests: Speedup feature_pruning test and refactor big transaction logic (master...2018_11_opreturn_splices) https://github.com/bitcoin/bitcoin/pull/14691
< promag> hebasto: please rebase #16349
< gribble> https://github.com/bitcoin/bitcoin/issues/16349 | qt: Remove redundant WalletController::addWallet signal by hebasto · Pull Request #16349 · bitcoin/bitcoin · GitHub
< hebasto> promag: ... in process right now
< hebasto> promag: done.
< promag> #16348 should be backport
< gribble> https://github.com/bitcoin/bitcoin/issues/16348 | qt: Assert QMetaObject::invokeMethod result by promag · Pull Request #16348 · bitcoin/bitcoin · GitHub
< hebasto> MarcoFalke: hi, are you around?
< wumpus> promag: the bug also exists in 0.18?
< hebasto> MarcoFalke: I'm going to rebase my PR and implement your suggestion. Could you look into https://github.com/bitcoin/bitcoin/pull/15864#discussion_r301258664 ?
< promag> wumpus: yes, the code is in 0.18
< wumpus> promag: ok, will label it for backport
< bitcoin-git> [bitcoin] darosior opened pull request #16358: Upgrade encrypted wallet (master...upgrade_encrypted_wallet) https://github.com/bitcoin/bitcoin/pull/16358
< bitcoin-git> [bitcoin] promag opened pull request #16359: 0.18: Backport "qt: Assert QMetaObject::invokeMethod result" (0.18...2019-07-0.18-backports) https://github.com/bitcoin/bitcoin/pull/16359
< promag> thanks wumpus & fanquake
< fanquake> promag 👍
< bitcoin-git> [bitcoin] darosior closed pull request #16358: Upgrade encrypted wallet (master...upgrade_encrypted_wallet) https://github.com/bitcoin/bitcoin/pull/16358
< bitcoin-git> [bitcoin] darosior opened pull request #16360: Upgrade encrypted wallet (master...upgrade_encrypted_wallet) https://github.com/bitcoin/bitcoin/pull/16360
< bitcoin-git> [bitcoin] instagibbs opened pull request #16361: Remove redundant pre-TopUpKeypool checks (master...redundant_topup) https://github.com/bitcoin/bitcoin/pull/16361
< bitcoin-git> [bitcoin] hebasto opened pull request #16362: gui: Bilingual translation (master...20190709-bilingual-part-one) https://github.com/bitcoin/bitcoin/pull/16362
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16363: test: Add test for BIP30 duplicate tx (master...1907-qaBIP30) https://github.com/bitcoin/bitcoin/pull/16363
< bitcoin-git> [bitcoin] LarryRuane opened pull request #16365: Log RPC parameters (arguments) if -debug=rpcparams (master...log-rpc-args) https://github.com/bitcoin/bitcoin/pull/16365
< BillyGarrison> Looking to change a doc typo and I have some questions. Please let me know if I'm in the wrong place.
< sipa> BillyGarrison: shoot
< BillyGarrison> In the CONTRIBUTING.md it says to fork, create branch, commit to branch, and submit PR. Should I submit the PR to put the changes into master? Do I need to worry about branch name conflicts?
< BillyGarrison> Under the refactoring section of the contributor guide it says that trivial PRs may be rejected to save time. Does this also apply to a trivial typo fix or does it specifically mean trivial refactoring PRs?
< sipa> Yes, always submit changes to master; maintainers will backport them to release branches where desired
< sipa> fixing a single typo is probably not worth it
< sipa> if you have a whole bunch that you can fix at once, maybe
< BillyGarrison> That's good to know, thanks. I will make note of any typos I find and submit them all together at a later point.
< sipa> and thank you for looking into ways to contribute (and reading the guidelines!)
< BillyGarrison> (y) hoping to be able to contribute to functional testing eventually
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/8046a3e0befe...357488f660a5
< bitcoin-git> bitcoin/master 0ab8ba1 Karl-Johan Alm: rpc: fix RPC help requirements for getblocktemplate
< bitcoin-git> bitcoin/master 5c5e32b Karl-Johan Alm: rpc: migrate JSONRPCRequest functionality into request.cpp
< bitcoin-git> bitcoin/master c7a9fc2 Karl-Johan Alm: Make the RPCHelpMan aware of JSONRPCRequest and add Check() helper
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16240: JSONRPCRequest-aware RPCHelpMan (master...2019-06-json-aware-helper) https://github.com/bitcoin/bitcoin/pull/16240
< bitcoin-git> [bitcoin] darosior closed pull request #16360: Upgrade encrypted wallet (master...upgrade_encrypted_wallet) https://github.com/bitcoin/bitcoin/pull/16360