< bitcoin-git> [bitcoin] fanquake opened pull request #19256: refactor: fix Boost signals2 -Wmaybe-uninitialized warning (master...boost_optional_last_value) https://github.com/bitcoin/bitcoin/pull/19256
< jonasschnelli> dongcarl: I think its good to wait for now with further implementations. The main reason is the v2 upgrade functionality with downgrade-attack prevention
< bitcoin-git> [bitcoin] fanquake opened pull request #19257: build: remove BIP70 configure option (master...remove_bip70_configure) https://github.com/bitcoin/bitcoin/pull/19257
< bitcoin-git> [bitcoin] Sjors opened pull request #19258: doc: improve subtree check instructions (master...2020/06/subtree-docs) https://github.com/bitcoin/bitcoin/pull/19258
< Kiminuo> Hi, is there some consensus regarding migration from c++11 to c++17 in Bitcoin core? I mean it seems that c++17 is not as widespread as I thought. So the migration will happen in medium term horizon, right? Like maybe in a year or two, right?
< sipsorcery> Kiminuo: see #16684.
< gribble> https://github.com/bitcoin/bitcoin/issues/16684 | Discussion: upgrading to C++17 · Issue #16684 · bitcoin/bitcoin · GitHub
< Kiminuo> that's very informative, thanks
< bitcoin-git> [bitcoin] practicalswift opened pull request #19259: tests: Add fuzzing harness for LoadMempool(...) and DumpMempool(...) (master...fuzzers-mempool-io) https://github.com/bitcoin/bitcoin/pull/19259
< jamesob> Curious - is there a compelling reason against pulling out all the indexes into a separate codebase/runtime, perhaps also in a repo under the bitcoin org? Only exception I can think of would be that `getrawtransaction` rpc would need to be moved into that codebase for txindex=1, but is there any other instance where existing core behavior relies on the existence of those indexes?
< jamesob> Separating out the indexing stuff would be a good candidate for rust use, and would let us add indexes we've been debating about for a while (e.g. address index) without feeling too bad.
< jamesob> This issue of the message handling thread being potentially blocked by indexing (BIP157/158) that jnewbery raised is disconcerting, and separating out the indexing stuff seems more or less in line with the spirit of the process separation work.
< jonasschnelli> jamesob: have a look at my sketch experiment https://github.com/jonasschnelli/bitcoincore-indexd
< jonasschnelli> The main downside to have it outside the main codebase is performance IMO
< jonasschnelli> And there are already projects doing the index "outside of the codebase" (like ElectrumX, etc.).
< jamesob> jonasschnelli: yeah, I agree - just might be good to have one that's clearly maintained by the bitcoin github org
< jonasschnelli> jamesob: I think a way would be: start in your own personal account (or a new entity), find (a) capable maintainer(s), find contributors. If there is acceptable development performance, migrate it to the bitcoin-core github organization.
< provoostenator> jamesob: we could start by giving them their own process? With #10102 you could then swap out the indexer process for your favorite Rust tool.
< gribble> https://github.com/bitcoin/bitcoin/issues/10102 | [experimental] Multiprocess bitcoin by ryanofsky · Pull Request #10102 · bitcoin/bitcoin · GitHub
< provoostenator> And then later on maybe seperate the code.
< ryanofsky> I wrote a comment with info about this yesterday https://github.com/bitcoin/bitcoin/pull/18988#issuecomment-642731876
< ryanofsky> with 01c31f9 commit mentioned there, rust code could connect to the socket, access the chain interface, implement an index
< ryanofsky> ariards rescan changes would also make chain interface more index-friendly: https://github.com/bitcoin/bitcoin/issues/11756#issuecomment-637038714
< provoostenator> Indexes sound like a nice advanced use case for process seperation.
< ryanofsky> yep, ariard's changes refactor existing indexes to use Chain interface, so there is even potential for moving those
< ryanofsky> #19160 is the next to review for those interested
< gribble> https://github.com/bitcoin/bitcoin/issues/19160 | multiprocess: Add basic spawn and IPC support by ryanofsky · Pull Request #19160 · bitcoin/bitcoin · GitHub
< jamesob> provoostenator ryanofsky: sounds like the best of all worlds to me
< jamesob> will give that discussion a closer look over the weekend
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b33136b6ba98...19e919217e6d
< bitcoin-git> bitcoin/master fad889c MarcoFalke: wallet: Make RPC help compile-time static
< bitcoin-git> bitcoin/master fadf6bd MarcoFalke: refactor: Remove unused request.fHelp
< bitcoin-git> bitcoin/master 19e9192 MarcoFalke: Merge #19250: wallet: Make RPC help compile-time static
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19250: wallet: Make RPC help compile-time static (master...2006-rpcWalletHelp) https://github.com/bitcoin/bitcoin/pull/19250
< bitcoin-git> [bitcoin] gzhao408 opened pull request #19260: p2p: disconnect peers that send filterclear (master...filterclear-disconnect) https://github.com/bitcoin/bitcoin/pull/19260
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/19e919217e6d...5af16a4db76f
< bitcoin-git> bitcoin/master 45eff75 Martin Zumsande: Add functional test for P2P eviction logic of inbound peers
< bitcoin-git> bitcoin/master 5af16a4 MarcoFalke: Merge #16756: test: Connection eviction logic tests
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16756: test: Connection eviction logic tests (master...201908_test_eviction) https://github.com/bitcoin/bitcoin/pull/16756
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/5af16a4db76f...f154071ec817
< bitcoin-git> bitcoin/master 57890ab Troy Giorshev: Remove two unneeded tests
< bitcoin-git> bitcoin/master ff1e7b8 Troy Giorshev: Move size limits to module-global
< bitcoin-git> bitcoin/master 5c4648d Troy Giorshev: Fix "invalid message size" test
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19177: test: Fix and clean p2p_invalid_messages functional tests (master...p2p-refactor-fix-tests) https://github.com/bitcoin/bitcoin/pull/19177
< bitcoin-git> [bitcoin] jnewbery closed pull request #17335: Add test for syncing blocks generated after invalidateblock. (master...2019-10-invalid-mine-test) https://github.com/bitcoin/bitcoin/pull/17335
< bitcoin-git> [bitcoin] promag opened pull request #19261: refactor: Drop ::HasWallets() (master...2020-06-drop-has-wallets) https://github.com/bitcoin/bitcoin/pull/19261
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19262: rpc: Replace OMITTED_NAMED_ARG with OMITTED (master...2006-rpcHelpRefactor) https://github.com/bitcoin/bitcoin/pull/19262