< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #22210: test: Use MiniWallet in test_no_inherited_signaling RBF test (master...2106-testMiniWallet) https://github.com/bitcoin/bitcoin/pull/22210
< bitcoin-git>
[bitcoin] vasild opened pull request #22211: net: relay I2P addresses even if not reachable (by us) (master...i2p_IsRelayable) https://github.com/bitcoin/bitcoin/pull/22211
< bitcoin-git>
[bitcoin] amadeuszpawlik opened pull request #22212: Guard `fHavePruned` to avoid potential data race (master...fix_guard_fhavepruned) https://github.com/bitcoin/bitcoin/pull/22212
< bitcoin-git>
bitcoin/master 85e058b John Newbery: [net processing] Remove unnecessary hash arg from MarkBlockAsInFlight()
< bitcoin-git>
bitcoin/master b4e29f2 John Newbery: [net processing] Remove QueuedBlock.fValidatedHeaders
< bitcoin-git>
bitcoin/master b03de9c John Newbery: [net processing] Remove CNodeState.nBlocksInFlightValidHeaders
< bitcoin-git>
[bitcoin] laanwj merged pull request #22141: net processing: Remove hash and fValidatedHeaders from QueuedBlock (master...2021-06-blocks-in-flight) https://github.com/bitcoin/bitcoin/pull/22141
< jamesob>
you know what would be an awesome attack: if someone did a giant commit that *looked like* a scripted diff, but was slightly off in the headers (like "~BEGIN VERIFY SCRIPT-") and contained some subtle malicious change
< jamesob>
would probably get caught but I guess worth keeping in mind
< sipa>
jamesob: they'd also need to have a commit title that looked bit wasn't quite "scripted-diff:"
< jamesob>
scripted~diff?
< sipa>
scripted diffs need both a marker in the commit title and in the body
< sipa>
and iirc when it only has one of the two, it fails validation
< jamesob>
maybe you're proving my point - I wrote "scripted~diff" and not "scripted-diff"!
< laanwj>
i think it's a good reason (apart from breaking other PRs) to keep the number of all-over-the-tree changes to a lot of files to a minimum, even as scripted diffs
< sipa>
jamesob: hahaha
< bitcoin-git>
[gui] ryanofsky opened pull request #360: gui: Unregister wallet notifications before unloading wallets (master...pr/qtwd) https://github.com/bitcoin-core/gui/pull/360
< jnewbery>
I hope that reviewers are reviewing the code changes in scripted diff commits and not just the commit log
< MarcoFalke>
I could imagine a subtle change like "+" -> "-" easily getting missed in review of a massive scripted diff
< MarcoFalke>
"scripted~diff"
< MarcoFalke>
Would be good to run the script locally (or at least check the ci log that it was run)
< laanwj>
that was my point, kind of, if large scripted diffs are rare then it's more likely people will review them properly, less so if it becomes a run of the mill thing; smaller ones are easy to review anyhow
< sipa>
often with scripted diffs it's easy to ask yourself what's the worst that can happen if it's not
< sipa>
e.g. something that renames a variable/function name.. if if's wrong in a non-obvious way it just won't compile
< laanwj>
right, but the sneaky thing would be to change something else on a line with the variable name change, if there's hundreds something like that is easier to hide
< jonatack>
Am about to push an update to the inbound eviction protection one. I was hoping to get back to the BTC/kvB-to-sat/vB transition in time for the release but that's unfeasible so just concentrating on finishing up https://github.com/bitcoin/bitcoin/pull/21261
< laanwj>
sipa: seems more like a bugfix than a feature anyhow
< jonatack>
and then reviewing the other PRs tagged for v22
< achow101>
I would consider #22156 and #22154 to be bug fixes rather than features, especially if #21365 is merged
<@gribble>
https://github.com/bitcoin/bitcoin/issues/22154 | Add OutputType::BECH32M and related wallet support for fetching bech32m addresses by achow101 · Pull Request #22154 · bitcoin/bitcoin · GitHub