<bitcoin-git>
bitcoin/master 59ba7d2 Andrew Chow: tests: rpc_fundrawtx better test for UTXO inclusion with include_unsafe
<bitcoin-git>
bitcoin/master a165bfb Andrew Chow: tests: rpc_fundrawtx use specific inputs for unavailable change test
<bitcoin-git>
bitcoin/master df765a4 Andrew Chow: tests: rpc_fundrawtx lock to UTXO types
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] meshcollider merged pull request #17526: Add Single Random Draw as an additional coin selection algorithm (master...srd-fallback-2) https://github.com/bitcoin/bitcoin/pull/17526
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<achow101>
\o/
jarthur has quit [Quit: jarthur]
<meshcollider>
Oops, I messed up my system time again, ignore that please
<meshcollider>
I really need to sort it out
<fanquake>
meshcollider coming to you from the past heh
<meshcollider>
I swear I checked datetime before merging! Argh, I'll write a script to check before pushing lol
c_arc has joined #bitcoin-core-dev
jarthur has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
upekkha has quit [Quit: upekkha]
upekkha has joined #bitcoin-core-dev
<achow101>
... does your computer not have a clock?
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] meshcollider opened pull request #23113: Add warnings to createmultisig and addmultisig if using uncompressed keys (master...202109_createmultisig_warnings) https://github.com/bitcoin/bitcoin/pull/23113
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Henrik has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
<meshcollider>
achow101: it is a hardware issue
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
Henrik has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
<bitcoin-git>
bitcoin/master a8bbd4c Samuel Dobson: Merge bitcoin/bitcoin#22938: test: Add remaining scenarios of 0 waste, in ...
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] meshcollider merged pull request #22938: test: Add remaining scenarios of 0 waste, in wallet waste_test (master...waste-test-add) https://github.com/bitcoin/bitcoin/pull/22938
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
vysn has quit [Ping timeout: 252 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake opened pull request #23115: bloom: use Span instead of std::vector for `insert` and `contains` (#18985) (master...18985_rebased) https://github.com/bitcoin/bitcoin/pull/23115
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<meshcollider>
fanquake: want to merge #23106 for me? :)
<gribble>
https://github.com/bitcoin/bitcoin/issues/23106 | Ensure wallet is unlocked before signing PSBT with walletprocesspsbt and GUI by meshcollider · Pull Request #23106 · bitcoin/bitcoin · GitHub
<fanquake>
meshcollider: yea can do
dunxen has joined #bitcoin-core-dev
<meshcollider>
thanks!
c_arc has joined #bitcoin-core-dev
jonatack has quit [Quit: Ping timeout (120 seconds)]
<bitcoin-git>
bitcoin/master 0e89521 Samuel Dobson: Ensure wallet is unlocked before signing in walletprocesspsbt
<bitcoin-git>
bitcoin/master 0f3acec Samuel Dobson: Add test that walletprocesspsbt requires unlocked wallet when signing
<bitcoin-git>
bitcoin/master 7e3ee4c Samuel Dobson: GUI: Ask user to unlock wallet before signing psbt
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #23106: Ensure wallet is unlocked before signing PSBT with walletprocesspsbt and GUI (master...202109_walletprocesspsbt_unlocked) https://github.com/bitcoin/bitcoin/pull/23106
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
saranshsharma has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
saranshsharma has quit [Ping timeout: 252 seconds]
c_arc has joined #bitcoin-core-dev
raj has quit [Killed (NickServ (GHOST command used by raj_!uid72176@user/raj))]
raj has joined #bitcoin-core-dev
raj has quit [Killed (NickServ (GHOST command used by raj_!uid72176@user/raj))]
raj has joined #bitcoin-core-dev
raj has quit [Killed (NickServ (GHOST command used by raj_!uid72176@user/raj))]
raj has joined #bitcoin-core-dev
raj has quit [Killed (NickServ (GHOST command used by raj_!uid72176@user/raj))]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #23117: test: Use assert_equal over assert for easier debugging (master...2109-testAssertEq) https://github.com/bitcoin/bitcoin/pull/23117
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<bitcoin-git>
bitcoin/master dccf3d2 fanquake: Merge bitcoin/bitcoin#23117: test: Use assert_equal over assert for easier...
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake merged pull request #23117: test: Use assert_equal over assert for easier debugging (master...2109-testAssertEq) https://github.com/bitcoin/bitcoin/pull/23117
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitdex has quit [Quit: = ""]
c_arc has joined #bitcoin-core-dev
gleb7 has quit [Quit: Ping timeout (120 seconds)]
gleb7 has joined #bitcoin-core-dev
gleb7 has quit [Client Quit]
gleb7 has joined #bitcoin-core-dev
prayank has joined #bitcoin-core-dev
<prayank>
I am trying to understand https://github.com/bitcoin/bitcoin/projects/11. After reading lot of comments in few PRs and issues I realised it's beyond my understanding and some PRs are already merged. Is this going to be an option like assumeutxo=1 will help in bootstrapping else it will work same by default? Or we have changed default behaviour for this project in Core?
<bitcoin-git>
bitcoin/master b8909b0 Samuel Dobson: Run functional tests with all possible flags
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #23120: test: Remove unused and confusing main parameter from script_util (master...2109-testCleanupScript) https://github.com/bitcoin/bitcoin/pull/23120
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
white5moke has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
Henrik has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke closed pull request #23097: Run specified functional tests with all matching flags (master...202109_tests_matchall) https://github.com/bitcoin/bitcoin/pull/23097
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Henrik has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
CoinForensics has quit []
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
vysn has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
prayank has joined #bitcoin-core-dev
common has quit [Ping timeout: 265 seconds]
grettke has joined #bitcoin-core-dev
<prayank>
c_arc: I am not the best person to comment on IRC related things but in last 24h logs I see your account constantly join and quit. Is this normal? Or something wrong with client?
<prayank>
504 2021-09-28T16:09:07 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection) 505 2021-09-28T16:09:15 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
<sipa>
i've /ignore'd him
<prayank>
Okay
common has joined #bitcoin-core-dev
<laanwj>
i have joins and part notifications disabled (well, not entirely, using weechat's "smart filter" to only show them for people who talked recently)
<laanwj>
in any case i'm not seeing their joins and parts, if it's really annoying to people i can ban them until they fix it
lightlike has joined #bitcoin-core-dev
<prayank>
Don't ban. Just wanted to know. I use IRC very differently. Check logs when I am free/bored. On mobile -> Riseup VPN -> AndroIRC to respond or ask something.
c_arc has joined #bitcoin-core-dev
Henrik has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
<prayank>
lightlike: Nice. Yeah I forgot this link. Will check this from now.
white5moke has quit [Remote host closed the connection]
c_arc has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
Henrik has joined #bitcoin-core-dev
koolazer has joined #bitcoin-core-dev
Henrik has quit [Client Quit]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
vysn has quit [Ping timeout: 250 seconds]
masta_ has joined #bitcoin-core-dev
masta`` has quit [Ping timeout: 265 seconds]
masta_ is now known as masta``
Guest49 has joined #bitcoin-core-dev
lightlike has quit [Quit: Leaving]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] glozow opened pull request #23121: [policy] check ancestor feerate in RBF, remove BIP125 Rule2 (master...ancestorscore-remove-bip1252) https://github.com/bitcoin/bitcoin/pull/23121
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
prayank has quit [Quit: irc thread exit]
<darosior>
wow
Henrik has joined #bitcoin-core-dev
Guest49 has quit [Quit: Client closed]
c_arc has joined #bitcoin-core-dev
gene has joined #bitcoin-core-dev
Henrik has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
c_arc has joined #bitcoin-core-dev
<dongcarl>
Hi all, looking at our initialization code right now, and I'm wondering why (ordering-wise) we need to start the indexers and load the wallet between our Chainstate loading logic and our Chainstate activation logic.
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #23122: doc: Remove un-actionable TODO from chainparams.cpp (master...2109-docTodo) https://github.com/bitcoin/bitcoin/pull/23122
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
c_arc has joined #bitcoin-core-dev
Obli has joined #bitcoin-core-dev
smartin has quit [Quit: smartin]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
Obli has quit [Ping timeout: 256 seconds]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
Henrik has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
<jamesob>
I was talking to dongcarl about this earlier and I hypothesized that possibly the indexers and wallet in some cases rely on handling validationinterface events to stay current, and so we may not want to call ABC (which emits those events) until those "clients" are set up to consume them. But I'm not sure if this is actually the case or intentional, and would take a little spelunking to verify. (cc ryanofsky maybe)
c_arc has joined #bitcoin-core-dev
<ryanofsky>
Wallet and indexes both have code to rescan blocks and should in theory be able to catch up and then register for events, without chainstate activation needing to wait for them
<ryanofsky>
But delaying chainstate activation would put less stress on this code as james suggests and maybe cut back on some frantic rescanning if this stuff is happening asynchronously
Talkless has quit [Quit: Konversation terminated!]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
Henrik has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
<bitcoin-git>
bitcoin/master 03a5fe0 João Barbosa: qt: Keep InitExecutor in main gui thread
<bitcoin-git>
bitcoin/master f000cdc Hennadii Stepanov: Merge bitcoin-core/gui#434: Keep InitExecutor in main gui thread
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
<dongcarl>
ryanofsky: could you point me to where I should look for 1. the "code to rescan blocks" and, 2. the codepaths that would be stressed if index init and ABC were happening at the same time? Many thanks in advance!
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
Henrik has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
<ryanofsky>
dongcarl, see CWallet::AttachChain and BaseIndex::ThreadSync
<dongcarl>
ryanofsky: Thanks!
Henrik has joined #bitcoin-core-dev
<ryanofsky>
If this code is running before validation, might be have an easier / more efficient time than if it is running at the same time as validation
<ryanofsky>
This code is not good and should just being doing a shared rescan instead of separate repeated rescans, see #11756
<bitcoin-git>
bitcoin/master ea31caf pranabp-bit: update estimatesmartfee rpc to return max of estimateSmartFee, mempoolMinF...
<bitcoin-git>
bitcoin/master b55232a Samuel Dobson: Merge bitcoin/bitcoin#22722: rpc: update estimatesmartfee to return max of...
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] meshcollider merged pull request #22722: rpc: update estimatesmartfee to return max of CBlockPolicyEstimator::estimateSmartFee, mempoolMinFee and minRelayTxFee (master...estimatesmartfee) https://github.com/bitcoin/bitcoin/pull/22722
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
Henrik has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
Henrik has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
<cfields>
sipa: the minisketch .cirrus.yml sets CFLAGS rather than CXXFLAGS for its sanitizer builds, so the flags don't carry through to the build. I'm guessing that's just c/p from somewhere else? Will PR a fix.
<sipa>
if it compiles/works with the unsigned int sanitizer, we might as well keep it
<cfields>
ACK, thanks.
vysn has quit [Ping timeout: 246 seconds]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] mjdietzx closed pull request #23091: fuzz: fix checks on number of required sigs and keys in multisig scripts (master...fuzz_extract_destinations_bug_fix) https://github.com/bitcoin/bitcoin/pull/23091
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
kappa has quit [Ping timeout: 256 seconds]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]