Yihen has quit [Remote host closed the connection]
saranshsharma has joined #bitcoin-core-dev
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Guest2020 has quit [Quit: Client closed]
vnogueir- has joined #bitcoin-core-dev
saranshsharma has quit [Remote host closed the connection]
saranshsharma has joined #bitcoin-core-dev
vnogueira has quit [Ping timeout: 276 seconds]
mikehu44 has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
mikehu44 has quit [Client Quit]
Yihen has joined #bitcoin-core-dev
saranshsharma has quit [Remote host closed the connection]
saranshsharma has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
smach has joined #bitcoin-core-dev
smach has quit [Remote host closed the connection]
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
smach has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
saranshsharma has quit [Remote host closed the connection]
<achow101>
Does anyone else see a compile error for src/fs.h? "./fs.h:91:8: error: no match for ‘operator+=’" Just updated to boost 1.78 and this seems to be happening.
Yihen has quit [Remote host closed the connection]
<achow101>
hmm, docs seems like they did indeed remove `path& operator+=(const path& p)` in 1.78
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
<achow101>
or perhaps they didn't, but it seems to be missing from my system's path.hpp...
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
saranshsharma has joined #bitcoin-core-dev
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
<laanwj>
they're just removing functions from boost::path now?
Yihen has quit [Remote host closed the connection]
yanmaani has quit [Ping timeout: 276 seconds]
saranshsharma has quit [Remote host closed the connection]
<jb55>
removing boost fixes this
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
yanmaani has joined #bitcoin-core-dev
<achow101>
not entirely sure what happenedc
saranshsharma has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
<achow101>
I misread the doc, it does still have operator+=, just my path.hpp doesn't have it
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
saranshsharma has quit [Ping timeout: 240 seconds]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
saranshsharma has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
saranshsharma has quit [Ping timeout: 256 seconds]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
saranshsharma has joined #bitcoin-core-dev
saranshsharma has quit [Remote host closed the connection]
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
<bitcoin-git>
bitcoin/master 92082ea Shashwat: Change time variable type to std::chrono::seconds in src/net_processing.cp...
<bitcoin-git>
bitcoin/master 3ec8f9f MarcoFalke: Merge bitcoin/bitcoin#23801: Refactor: Change time variable type from int6...
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #23801: Refactor: Change time variable type from int64_t to std::chrono::seconds in net_processing.cpp (master...time_in_seconds_refactor) https://github.com/bitcoin/bitcoin/pull/23801
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
<bitcoin-git>
bitcoin/master cfeb194 Luke Dashjr: ci: Use Cirrus "greedy" flag to use idle CPU time when available
<bitcoin-git>
bitcoin/master 20aea49 MarcoFalke: Merge bitcoin/bitcoin#23797: ci: Use Cirrus "greedy" flag to use idle CPU ...
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #23797: ci: Use Cirrus "greedy" flag to use idle CPU time when available (master...cirrus_greedy) https://github.com/bitcoin/bitcoin/pull/23797
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
yanmaani has joined #bitcoin-core-dev
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Guest15 has joined #bitcoin-core-dev
Guest15 has quit [Client Quit]
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
yanmaani has quit [Ping timeout: 276 seconds]
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
sdfgsdfg has quit [Quit: ZzzZ]
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
yanmaani has joined #bitcoin-core-dev
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] mzumsande opened pull request #23826: test: Make AddrMan unit tests use public interface, extend coverage (master...202112_addrman_unit_tests_1) https://github.com/bitcoin/bitcoin/pull/23826
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
masta`` has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
mikehu44 has quit [Ping timeout: 240 seconds]
Yihen has quit [Remote host closed the connection]
dougefish has quit [Ping timeout: 252 seconds]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
sirdigby727 has quit [Quit: Connection closed for inactivity]
Yihen has joined #bitcoin-core-dev
evbo has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] ryanofsky opened pull request #23828: scripted-diff: Rename libbitcoin_server.a to libbitcoin_node.a (master...pr/libnode) https://github.com/bitcoin/bitcoin/pull/23828
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
sirdigby727 has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
smach has joined #bitcoin-core-dev
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
yanmaani has quit [Ping timeout: 276 seconds]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
grettke has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
deanguss is now known as DeanGuss
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
grettke has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
yanmaani has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
realies has quit [Read error: Connection reset by peer]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
realies has joined #bitcoin-core-dev
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
yanmaani has quit [Remote host closed the connection]
yanmaani has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
jb55 has joined #bitcoin-core-dev
jb55 has quit [Changing host]
jb55 has joined #bitcoin-core-dev
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
bomb-on has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
Yihen has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
sirdigby727 has quit [Quit: Connection closed for inactivity]
<laanwj>
achow101: congrats on becoming maintainer! you should have the right permissions to merge now
<jamesob>
achow101: yeah congrats, meant to ACK
<laanwj>
jamesob: you still can :)
<jamesob>
good point!
<jamesob>
posthumous ACKs are good ACKs
<laanwj>
exactly, reviewing things that are merged is also important
<sipa>
right!
lucasdcf has joined #bitcoin-core-dev
bomb-on has quit [Read error: Connection reset by peer]
<jeremyrubin>
dont' want to make github noisier, but the reason why i think that merging more features into a system that should be fully deprecated (IMO) is that if this is "the feature" that is currently blocking a user from relying on REST API then while it doesn't increase the mechanical work of deprecation, it does increase the future inconvenience/users
<jeremyrubin>
arguing against deprecation.
<jeremyrubin>
so that's why i don't feel the 'adding features to something that should go away' is separate from 'patch giving an alternative path for users to get same feature outside of core'
<jeremyrubin>
because we should steer users in that direction anyways.
<sipa>
If there were already agreement that the built-in REST interface should be deprecated, I might have agreed with that, but I don't feel that's the case (of course, I may be biased, because I personally don't feel it should be).
<jb55>
didn't even know there was a rest interface
<earnestly>
TIL
<jeremyrubin>
definitely a larger question. I think we should remove almost everything that isn't required to keep a node operating in the 'standard' network, which is clearly a lot more aggressive than most, but the REST API seemed to be an easy punching bag of something that really clearly doesn't need to be in core
<jeremyrubin>
and there are negative security risks of turning on the feature
<jeremyrubin>
jb55 if this makes you start using it *shakes fist*
<jb55>
all my scripts are built around the jsonrpc, I don't see why I would need it
<sipa>
I don't think there are negative security risks of turning it on, given that there already is an RPC interface.
<jeremyrubin>
not true
<jeremyrubin>
if you expose REST on your system immediately any malicious website can DoS your nodes RPC interface
<sipa>
They can DoS your RPC interface too.
<jb55>
when graphql interface
<jeremyrubin>
jb55 idk make a PR. but i really think these should be layers on top of RPC api as a proxy
<jeremyrubin>
sipa not as badly since they won't pass auth
<sipa>
There is no rate-limiting on the pre-auth aspect of RPC either.
<jeremyrubin>
whereas the REST API i can troll to make my node output gigabytes of data pretty cheaply
<jb55>
I have always dreamed of a custom query engine, might be overkill but would be neat
<sipa>
You can send gigabytes to the RPC interface too, without authentication.
<jeremyrubin>
send gigabytes from attacker is "backpressured" though by requiring the client to also push that amount of data through.
<jeremyrubin>
Receive gigabytes is an amplification attack
<jeremyrubin>
if I can send O(1) data and get O(N) back that's bad
<jeremyrubin>
send and recv are not symmetric in costs to our node
<sipa>
Hmm, I think they are. Both have a processing cost to bitcoind. The constant factors may differ a bit, but there is no qualitative difference I'd say.
<jamesob>
does the REST server use a separate HTTP/auth mechanism than the RPC server? Because if so running it almost definitionally increases attack surface, just a matter of how marginally it does so
<jeremyrubin>
it uses exaclty the same HTTP server
<sipa>
REST is unauthenticated.
<jeremyrubin>
REST is 100% unauthenticated
<jamesob>
oh gotcha
<jeremyrubin>
jamesob not even a separate instance of the same server, the same one
<sipa>
I'm obviously assuming no bugs in the REST handling code itself.
<sipa>
Additional code obviously increases attack surface - but that's true for literally every feature we want. It's also true for having it in a wrapper, as the wrapper needs RPC auth access, which means a bug in the wrapper could also expose more issues.
<jamesob>
right, I think that's what jeremyrubin was getting at, eh?
<jamesob>
but the actual risk is probably not big if REST is disabled by default...
<jb55>
does anyone know anyone actually using the rest interface in production apps? a bit sketch that we are maintaining two separate rpc interfaces.
<jamesob>
jb55 good question; I sure don't
<jeremyrubin>
There absolutely is a difference between receiving a GB and sending a GB. there are inherent backpressures driven by OS scheduling and similar and similar that make sending dampened.
<jamesob>
everyone I know backs up to the JSON-RPC interface
<jeremyrubin>
sipa the nice thing about the wrapper is that a wrapper can live on e.g. a separate user, separate process, separate server, can also load balance across nodes if desireable, and can use RPC Whitelist credentials so that it being broken mitigates what can happen
<sipa>
jeremyrubin: I think that's true for network interfaces, because aplification can be used to overload the network link before exhausting CPU on either attacker of victim system.
<jeremyrubin>
well so here the 'call is coming inside the house' as the issue is you visit a webpage and they ping your localhost server
<sipa>
But if you assume a local attacker, they can do whatever causes max CPU usage in bitcoind, whether that's done through sending or receiving.
<jeremyrubin>
i guess it's worth testing. i'd assume browsers protect you from your webpages hosing your network.
<jeremyrubin>
(network interfaces)
<sipa>
Unless the website itself is running on http://localhost, I don't think you can make connections to localhost? same origin policy etc.
BlueMatt has quit [Remote host closed the connection]
BlueMatt has joined #bitcoin-core-dev
jetpack has quit [Quit: ZNC 1.7.2+deb3 - https://znc.in]
ghost43_ has joined #bitcoin-core-dev
<jeremyrubin>
also bad would be being able to detect a user is running bitcoin software while web browsing, even if no request is fired. but that applies to jsonrpc too
mandeezy has joined #bitcoin-core-dev
ghost43 has quit [Ping timeout: 276 seconds]
<jeremyrubin>
overall i think it'd just be good if we only exposed Unix Sockets and had everything else be done via proxy. We can get all the local services working as we want them do (e/g bitcoin-cli) and industrial users should already be proxying. it's just attack surface with little benefit
jetpack has joined #bitcoin-core-dev
<sipa>
I'd very much like to see at least a UNIX domain socket added, but it seems earlier attempts to do that were complicated by lack of unix support on the client-side of libevent, which is used in bitcoin-cli.
<sipa>
There have been discussions about alternative approaches, but so far nobody who has investigated/worked on it further.
geyaeb has quit [Ping timeout: 276 seconds]
geyaeb has joined #bitcoin-core-dev
<jamesob>
> see at least a UNIX domain socket added
<jamesob>
sounds like a great first project for an enterprising new contributor...
<jeremyrubin>
i agree that'd be a good first step
<jb55>
we use unix sockets on the clightning side and people mostly complain about it and want web rpcs
mandeezy has quit [Quit: Client closed]
mandeezy has joined #bitcoin-core-dev
Talkless has quit [Quit: Konversation terminated!]
<earnestly>
jb55: Can't they use web sockets?
<jb55>
earnestly: no that is not the same thing other than having the same word in the name
<earnestly>
Hmmm
<sipa>
<jamesob> "sounds like a great first..." <- Given that laanwj tried and gave up, I'm not sure I'd classify it as "great first project".
<earnestly>
jb55: Yeah I was thinking of something else, that doesn't exist, fever dream
<sipa>
(by which I absolutely don't want to discourage anyone who wants to try either!)
<jamesob>
sipa: oh I thought laanwj tried to allow p2p access via unix socket, but maybe he triedboth
<sipa>
No, RPC. P2P doesn't use libevent.
<sipa>
Unless we're talking about different things.