bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<fanquake>
moar automation
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] kcalvinalvin opened pull request #24832: index: Verify the block filter hash when reading the filter from disk. (master...2020-06-14-blockfilterindex-checksums) https://github.com/bitcoin/bitcoin/pull/24832
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<jonatack>
fanquake: nice, this could save a bunch of review time if it works well
<sipa>
I guess all those differences can be explained due to differences in topology, I think.
<jonatack>
b10c: awesome. i need to try using tracepoints
<lightlike>
what do you mean with "topology" here?
<sipa>
where in the network connectivity graph you are located
<sipa>
as in: who your peers are
<b10c>
maybe also how many peers you have? more peers means e.g. more inbound INVs for blocks and tx, but you hopefully download the block/tx only once
<_aj_>
sipa: (node with only outbounds: 423 outbound, 358 manual, 33 feeler, 17 block-relay-only)
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] dergoegge opened pull request #24835: Revert "Do not consider blocked networks local" (master...2022-04-revert-1653f97c) https://github.com/bitcoin/bitcoin/pull/24835
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
theStack has left #bitcoin-core-dev [#bitcoin-core-dev]
theStack has joined #bitcoin-core-dev
Guest69 has joined #bitcoin-core-dev
<theStack>
sipa: does it matter for the statistics whether are non-pruned or pruned node is used? happy to run your patch for a few days and report back, but i only have a pruned node available right now
Guest69 has quit [Client Quit]
Guest69 has joined #bitcoin-core-dev
Guest69 has quit [Client Quit]
Guest69 has joined #bitcoin-core-dev
<sipa>
Both are interesting actually; the context is for BIP324 it'd be good to have an idea of how much per-message CPU cost overhead has. If most of the bandwidth on the network is due to large messages, this doesn't matter as much, for example.
Guest69 has quit [Client Quit]
Guest69 has joined #bitcoin-core-dev
An0rak has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
<jamesob>
b10c: very cool!
szkl has quit [Quit: Connection closed for inactivity]
Guest69 has quit [Quit: Client closed]
bitcoin-git has joined #bitcoin-core-dev
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<bitcoin-git>
[bitcoin] glozow opened pull request #24836: add RPC (-regtest only) for testing package policy (master...client-submitpackage) https://github.com/bitcoin/bitcoin/pull/24836
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
orville has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] ryanofsky opened pull request #24837: init: Prevent -noproxy and -proxy=0 from interacting with other settings (master...pr/proxyi) https://github.com/bitcoin/bitcoin/pull/24837
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
orville has quit [Quit: Going offline, see ya! (www.adiirc.com)]
AaronvanW has quit [Ping timeout: 250 seconds]
Kaizen_K_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 272 seconds]
AaronvanW has joined #bitcoin-core-dev
szkl has joined #bitcoin-core-dev
Kaizen_K_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 250 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Talkless has quit [Quit: Konversation terminated!]
<jamesob>
Can we reopen this PR or is it truly not open for reconsideration? #14635 cc ryanofsky _aj_ jonatack
real_or_random has quit [Ping timeout: 256 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] theStack opened pull request #24839: test: use MiniWallet for mining_prioritisetransaction.py (master...202204-test-use_MiniWallet_for_mining_prioritisetransaction) https://github.com/bitcoin/bitcoin/pull/24839
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<jamesob>
Anyone know if we have docs on translations (e.g. using `_(...)`)? I'm wondering if the argument to _(...) has to be a raw string in order for whatever translation script to pick up on its contents
<fanquake>
If no docs probably best to ask hebasto / laanwj
real_or_random has joined #bitcoin-core-dev
<hebasto>
jamesob: yes
<hebasto>
strings to be translated being extracted from the sources
<jamesob>
hebasto: do the raw strings need to be on a single line?
<hebasto>
no
<jamesob>
okay great, thanks hebasto
<hebasto>
yw
<jamesob>
do we have docs somewhere or should I make a note to add to developer-notes?
<hebasto>
`share/qt/extract_strings_qt.py`
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
<hebasto>
and `doc/translation_strings_policy.md`
Kaizen_Kintsugi_ has quit [Ping timeout: 250 seconds]
dunxen has joined #bitcoin-core-dev
<jonatack>
jamesob: i was thinking of maybe writing an update to the developer notes that at least explains what that style is (what, why, where) to provide context for reviewers
<jonatack>
the idea was that regardless of consensus on using it, in any case reviewers need context
<jonatack>
said update wouldn't propose the style change
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
<jamesob>
jonatack: I think it's worth just proposing the change again, since I think there's a good chance that no one materially opposes it
Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]
belcher has quit [Ping timeout: 260 seconds]
brunoerg has quit [Remote host closed the connection]
ronoaldo has quit [Quit: Konversation terminated!]