<fanquake>
Unless this is some Nix specific thing, I can't see why this would be necessary. We build our release binaries with both, and they work fine for native builds.
<bitcoin-git>
[bitcoin] fanquake opened pull request #26159: build: Remove `stdlib.h` from header checks (master...remove_stdlib_h_configure) https://github.com/bitcoin/bitcoin/pull/26159
_apex2_ has joined #bitcoin-core-dev
_apex2_ has quit [Ping timeout: 260 seconds]
SpellChecker_ has joined #bitcoin-core-dev
SpellChecker has quit [Ping timeout: 258 seconds]
bitdex has quit [Read error: Connection reset by peer]
SpellChecker_ has quit [Remote host closed the connection]
_andrewtoth_ has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
_andrewtoth_ has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
fjMSX has quit [Read error: Connection reset by peer]
fjMSX has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
halosghost has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
vasild has joined #bitcoin-core-dev
ghost43 has quit [Ping timeout: 258 seconds]
ghost43 has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #26160: [24.x] fuzz: Avoid timeout in bitdeque fuzz target (24.x...2209-fuzz-timeout-🏺) https://github.com/bitcoin/bitcoin/pull/26160
ghost43_ has quit [Remote host closed the connection]
yanmaani2 has joined #bitcoin-core-dev
ghost43 has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] Sjors opened pull request #26162: Remove taproot chain param and list exception blocks in getdeploymentinfo (master...2022/09/taproot) https://github.com/bitcoin/bitcoin/pull/26162
_apex2_ has joined #bitcoin-core-dev
_apex2_ has quit [Ping timeout: 250 seconds]
Guyver2 has left #bitcoin-core-dev [Closing Window]
jon_atack has joined #bitcoin-core-dev
cryptapus has quit [Remote host closed the connection]
cryptapus has joined #bitcoin-core-dev
larryruane_ has left #bitcoin-core-dev [#bitcoin-core-dev]
Guest96 has joined #bitcoin-core-dev
_andrewtoth_ has quit [Remote host closed the connection]
andrewtoth_ has joined #bitcoin-core-dev
Guest96 has quit [Ping timeout: 252 seconds]
<luke-jr>
fanquake: git 2.33 is the minimum required apparently
amovfx has quit [Remote host closed the connection]
amovfx has joined #bitcoin-core-dev
_apex2_ has joined #bitcoin-core-dev
_apex2_ has quit [Ping timeout: 265 seconds]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
adam2k has joined #bitcoin-core-dev
<adam2k>
👋 I'm looking to help out cleaning up or picking up on some older stale issues. Any opinions on this issue https://github.com/bitcoin/bitcoin/issues/4176 or any others that are more pressing?
vasild has quit [Ping timeout: 258 seconds]
<amovfx>
adam2k: I'm reading through it right now, it seems like a really good idea acctually
vasild has joined #bitcoin-core-dev
<amovfx>
i like the -dangerouswalletinternals flag idea to disable the walk through for industrial users
<adam2k>
Thanks amovfx! I'll start looking into the options more and get feedback on the issue. Yes, the idea of a flag sounds promising to me as well.
<amovfx>
I would get some input from some people that have more experience with bitcoin than me, they may provide guidance that will save you a fair amount of time.
<amovfx>
Isn't their supposed to be a wallet meeting today?
<brunoerg>
amovfx: I think so
<adam2k>
oh, I didn't know that. When & where is the wallet meeting?
<sipa>
Right now, here.
<sipa>
achow101: ?
<sipa>
Oh, I think achow101 announced he was unable to make the meeting today.
<sipa>
<achow101> fyi I will be unavailable for the wallet meeting tomorrow, if someone else would like to run it, that'd be great.
<adam2k>
is there anybody else available to run the meeting? If not, I can ask the question in github and check back in during the next meeting.
<sipa>
Whether or not someone runs the meeting won't change whether someone is here to answer your question.
<sipa>
And it doesn't appear many people are present.
<sipa>
I'd suggest just commenting on github.
<adam2k>
ok, thanks. Will do!
<furszy>
adam2k: could also force users to type the command twice. First time will return a warning "dangerous command, be aware of the implications of this etc.. <continue scaring the users>", then the second time will be processed.
bcdarc_ has joined #bitcoin-core-dev
bcdarc has quit [Ping timeout: 250 seconds]
<amovfx>
I really like the type out the warning
sdaftuar1 has joined #bitcoin-core-dev
<adam2k>
furszy that's a good idea too. Do you see that as something that is the default behavior or would require a flag to enable?
kouloumos has quit [Quit: Connection closed for inactivity]
<furszy>
well, if it's under a flag and users need to enable it to get the warning, then loses it effectiveness.
<adam2k>
That makes sense. We can enable by default and add a flag to disable in case somebody wants that.
<furszy>
still, not sure if it worth it. The dump commands (dumpprivkey, dumpwallet) only work with legacy wallets
yanmaani2 has quit [Ping timeout: 258 seconds]
<adam2k>
Then is the assumption that people using legacy wallets know what they're doing or already have run into this issue, so it's moot to implement something like this?
<sipa>
listdescriptors with private=true poses similar risks
<sipa>
for descriptor wallets
amovfx has quit [Remote host closed the connection]
Guest9669 has joined #bitcoin-core-dev
amovfx has joined #bitcoin-core-dev
<adam2k>
sipa is there a separate issue for this already? It seems like they could be potentially handled in separate PRs?
<sipa>
I don't see why.
<sipa>
Whatever solution is adopted for the dangerous legacy commands should also be used for dangerous descriptor commands/
<furszy>
yeah true, same thing there.
<adam2k>
if it doesn't seem like scope creep I'm all for it.
yanmaani2 has joined #bitcoin-core-dev
<sipa>
I think it's literally less work to do it all the same for all dangerous commands at once.
<adam2k>
oh, nice! OK, I'll approach it that way then. Thanks!
bcdarc has joined #bitcoin-core-dev
bcdarc has joined #bitcoin-core-dev
amovfx has joined #bitcoin-core-dev
adam2k has joined #bitcoin-core-dev
adam2k has quit [Client Quit]
ghost43 has quit [Remote host closed the connection]
andrewtoth_ has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
andrewtoth_ has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
brunoerg has quit []
_apex2_ has joined #bitcoin-core-dev
_apex2_ has quit [Ping timeout: 265 seconds]
_andrewtoth_ has joined #bitcoin-core-dev
andrewtoth_ has quit [Remote host closed the connection]
Guest4059 has joined #bitcoin-core-dev
Guest4059 has quit [Quit: Client closed]
Talkless has quit [Quit: Konversation terminated!]
amovfx has quit [Remote host closed the connection]
amovfx has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 244 seconds]
sipsorcery has joined #bitcoin-core-dev
_apex2_ has joined #bitcoin-core-dev
_apex2_ has quit [Ping timeout: 252 seconds]
_andrewtoth_ has quit [Remote host closed the connection]
yanmaani2 has quit [Ping timeout: 258 seconds]
sipsorcery has quit [Ping timeout: 246 seconds]
yanmaani2 has joined #bitcoin-core-dev
amovfx has quit [Remote host closed the connection]
amovfx has joined #bitcoin-core-dev
amovfx has quit [Remote host closed the connection]