weylin_ has quit [Remote host closed the connection]
brunoerg has quit [Ping timeout: 265 seconds]
<phantomcircuit>
theStack: no 8k elements is quite small, older non descriptor wallets often had on the order of 100k keys
<phantomcircuit>
sipa: it was suggested that the filters could use the same key as the block obfuscation, but that isn't currently guaranteed to be a real key, it's been there for a long time though, maybe logic to guarantee the block obfuscation key is non-zero would be accepted now?
<phantomcircuit>
(either just asserting that the key is non-zero or migrating zero key blocks to non-zero)
<sipa>
It's also only a 64-bit key, the obfuscation one.
<sipa>
I think it'd be a lot easier to have an independent key; the filters are already very separate code organization wise too.
<phantomcircuit>
sipa: the filters are siphash , so a 64 bit key is probably fine anyways?
<sipa>
If we'd want to do something like that.
<phantomcircuit>
sipa: or are these some 128 bit siphash variant?
<phantomcircuit>
oh it's a 64 bit result from a 128 bit key
<sipa>
siphash has a 128 bit key
<phantomcircuit>
nvm
weylin_ has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
BUSY has joined #bitcoin-core-dev
<phantomcircuit>
sipa: any opinion on where that key should go
<sipa>
in the filter itself?
AaronvanW has quit [Ping timeout: 265 seconds]
<phantomcircuit>
sipa: i maybe can do that, iirc it's kind of annoying because of the existing format not having any version
brunoerg has joined #bitcoin-core-dev
<phantomcircuit>
sipa: i guess there's GCS_SER_VERSION actually
<sipa>
this would be a totally separate index, i'd imagine
<phantomcircuit>
sipa: yes, there's a BlockFilterType that i could use but i think just doing it as a completely separate thing would be easier
jarthur_ has quit [Read error: Connection reset by peer]
jarthur has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 264 seconds]
<bitcoin-git>
[bitcoin] brunoerg opened pull request #26899: p2p: set `-dnsseed` and `-listen` false if `maxconnections=0` (master...2023-01-maxconnections-0) https://github.com/bitcoin/bitcoin/pull/26899
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
AmunRa has joined #bitcoin-core-dev
Norrin has quit [Ping timeout: 255 seconds]
user has quit [Quit: leaving]
brunoerg has quit [Ping timeout: 260 seconds]
user has joined #bitcoin-core-dev
AmunRa has quit [Remote host closed the connection]
Norrin has joined #bitcoin-core-dev
user has quit [Quit: leaving]
user has joined #bitcoin-core-dev
user has quit [Client Quit]
Talkless has joined #bitcoin-core-dev
user has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
gnaf has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
w0xlt has quit []
w0xlt has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
user__ has joined #bitcoin-core-dev
user__ has quit [Client Quit]
brunoerg has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 272 seconds]
brunoerg has quit [Ping timeout: 265 seconds]
brunoerg has joined #bitcoin-core-dev
codo has left #bitcoin-core-dev [nil]
brunoerg has quit [Ping timeout: 246 seconds]
codo has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Norrin has quit [Ping timeout: 255 seconds]
Norrin has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
user__ has joined #bitcoin-core-dev
user__ has quit [Client Quit]
jon_atack has quit [Ping timeout: 246 seconds]
jon_atack has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
user has quit [Quit: leaving]
brunoerg has quit [Ping timeout: 265 seconds]
user has joined #bitcoin-core-dev
user has quit [Client Quit]
user has joined #bitcoin-core-dev
bitdex has quit [Ping timeout: 255 seconds]
brunoerg has joined #bitcoin-core-dev
user has quit [Quit: leaving]
brunoerg has quit [Ping timeout: 246 seconds]
Talkless has quit [Quit: Konversation terminated!]
Jackielove4u has quit [*.net *.split]
sanket1729 has quit [*.net *.split]
cncr04s has quit [*.net *.split]
bitdex has joined #bitcoin-core-dev
Jackielove4u has joined #bitcoin-core-dev
sanket1729 has joined #bitcoin-core-dev
cncr04s has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] rodentrabies opened pull request #26902: wallet: do not backdate locktime if it may lead to fingerprinting (master...avoid-locktime-backdating) https://github.com/bitcoin/bitcoin/pull/26902
brunoerg has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
gnaf has quit [Quit: Konversation terminated!]
MrFrancis has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 268 seconds]
Norrin has quit [Remote host closed the connection]
MrFrancis has quit [Ping timeout: 256 seconds]
Norrin has joined #bitcoin-core-dev
weylin_ has quit [Remote host closed the connection]
user has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
Norrin has quit [Ping timeout: 255 seconds]
b_101 has joined #bitcoin-core-dev
Norrin has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
weylin_ has joined #bitcoin-core-dev
andrewtoth_ has quit [Remote host closed the connection]