ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposed
henghonglee has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] theStack opened pull request #27733: test: refactor: introduce `generate_keypair` helper with WIF support (master...generate_wif_bytes_keypair) https://github.com/bitcoin/bitcoin/pull/27733
henghonglee has quit [Remote host closed the connection]
henghonglee has joined #bitcoin-core-dev
vysn has joined #bitcoin-core-dev
dougefish_ has quit [Ping timeout: 248 seconds]
henghonglee has quit [Ping timeout: 268 seconds]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
henghonglee has joined #bitcoin-core-dev
henghonglee has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
luke-jr has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
henghonglee has joined #bitcoin-core-dev
henghonglee has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
henghonglee has joined #bitcoin-core-dev
pharonix71 has quit [Ping timeout: 240 seconds]
vasild has quit [Ping timeout: 240 seconds]
pharonix71 has joined #bitcoin-core-dev
vasild has joined #bitcoin-core-dev
henghonglee has quit [Ping timeout: 265 seconds]
brunoerg has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
flooded has joined #bitcoin-core-dev
test_ has quit [Ping timeout: 240 seconds]
henghonglee has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
henghonglee has quit [Ping timeout: 246 seconds]
brunoerg has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
brunoerg has joined #bitcoin-core-dev
henghonglee has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
henghonglee has quit [Ping timeout: 240 seconds]
vasild has quit [Ping timeout: 240 seconds]
vasild has joined #bitcoin-core-dev
henghonglee has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
henghonglee has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
AaronvanW has quit [Remote host closed the connection]
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
henghonglee has joined #bitcoin-core-dev
EleYah has quit [Quit: EleYah]
dougefish has joined #bitcoin-core-dev
b_101 has quit [Ping timeout: 240 seconds]
henghonglee has quit [Read error: Connection reset by peer]
henghonglee has joined #bitcoin-core-dev
henghong_ has joined #bitcoin-core-dev
henghong_ has quit [Client Quit]
brunoerg has joined #bitcoin-core-dev
henghonglee has quit [Ping timeout: 268 seconds]
brunoerg has quit [Ping timeout: 240 seconds]
conman has joined #bitcoin-core-dev
preimage has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
evri has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
b_101 has joined #bitcoin-core-dev
b_101 has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
Guest84 has joined #bitcoin-core-dev
Guest84 has quit [Client Quit]
brunoerg has quit [Ping timeout: 264 seconds]
Guyver2 has joined #bitcoin-core-dev
AmishBTC has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #27735: test: Disable legacy wallet for mempool_packages.py (master...2305-mempool-legacy-wallet-) https://github.com/bitcoin/bitcoin/pull/27735
jarthur_ has quit [Quit: jarthur_]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]
earnestly has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fjahr closed pull request #27730: init: Improve file descriptor limit handling (master...2023-05-fd-limit) https://github.com/bitcoin/bitcoin/pull/27730
brunoerg has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
robobub has quit [Quit: Connection closed for inactivity]
Cory has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
test_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
flooded has quit [Ping timeout: 240 seconds]
ZeroMaster has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
Guyver2 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/3132ec64d9e0...51c050787fd6
<bitcoin-git> bitcoin/master 86cff8b Greg Sanders: alias BlockDownloadMap for mapBlocksInFlight
<bitcoin-git> bitcoin/master a905954 Greg Sanders: Remove nBlocksInFlight
<bitcoin-git> bitcoin/master cce9618 Greg Sanders: Convert mapBlocksInFlight to a multimap
<bitcoin-git> [bitcoin] fanquake merged pull request #27626: Parallel compact block downloads, take 3 (master...2023-05-parallel-block-downloads) https://github.com/bitcoin/bitcoin/pull/27626
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
jon_atack has quit [Quit: WeeChat 3.8]
brunoerg has joined #bitcoin-core-dev
Guest61 has joined #bitcoin-core-dev
Guest61 has quit [Client Quit]
izmael has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
brunoerg has quit [Ping timeout: 264 seconds]
ZeroMaster has joined #bitcoin-core-dev
izmael has quit [Client Quit]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
jonatack has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake closed pull request #27485: ci: standardize custom libc++ usage in MSAN jobs (master...msan_use_isystem_nostdlib) https://github.com/bitcoin/bitcoin/pull/27485
brunoerg has quit [Ping timeout: 246 seconds]
<bitcoin-git> [bitcoin] fanquake opened pull request #27737: ci: compile Clang and compiler-rt in msan jobs (master...fix_native_fuzz_with_msan) https://github.com/bitcoin/bitcoin/pull/27737
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
abubakarsadiq has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
SpellChecker has joined #bitcoin-core-dev
SpellChecker_ has quit [Ping timeout: 240 seconds]
martinus has quit [Remote host closed the connection]
PaperSword has quit [Quit: PaperSword]
<fanquake> provoostenator: did you bump the timeout
martinus has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
b_101 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
brunoerg has joined #bitcoin-core-dev
b_101 has quit [Ping timeout: 240 seconds]
brunoerg has quit [Ping timeout: 250 seconds]
brunoerg has joined #bitcoin-core-dev
flooded has joined #bitcoin-core-dev
test_ has quit [Ping timeout: 248 seconds]
salvatoshi has joined #bitcoin-core-dev
Guest58 has joined #bitcoin-core-dev
bitdex has quit [Quit: = ""]
Guest58 has quit [Quit: Client closed]
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #27739: ci: Add missing set -e to 01_base_install.sh (master...2305-ci-bash-sob-) https://github.com/bitcoin/bitcoin/pull/27739
mudsip has joined #bitcoin-core-dev
mudsip has quit []
mudsip has joined #bitcoin-core-dev
mudsip has quit []
<instagibbs> brunoerg I'll review #26969 as soon as it's rebased, I think at least one more reviewer has expressed interest as well
<gribble> https://github.com/bitcoin/bitcoin/issues/26969 | net, refactor: net_processing, add `ProcessCompactBlockTxns` by brunoerg · Pull Request #26969 · bitcoin/bitcoin · GitHub
<brunoerg> instagibbs: thank you, I'm rebasing it now
bugs_ has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
AaronvanW has quit [Remote host closed the connection]
<kanzure> what's with the recent increase in file descriptor work? not that i'm complaining or anything. just curious.
<fjahr> kanzure: New libevent version alpha was released that has some new features that potentially allow to prevent some issues around fd like #11368
<gribble> https://github.com/bitcoin/bitcoin/issues/11368 | bitcoin core crashes when too many rpc calls are made · Issue #11368 · bitcoin/bitcoin · GitHub
test_ has joined #bitcoin-core-dev
preimage has joined #bitcoin-core-dev
<kanzure> i used to have a bunch of issues around too many rpc calls, even when using the _batch stuff https://github.com/bitcoin/bitcoin/issues/6454
<kanzure> anyway, that's interesting, thanks.
flooded has quit [Ping timeout: 264 seconds]
<instagibbs> anyone have tricks to make range-diff output sensible?
<instagibbs> cant make heads or tails of output
b_101 has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
SpellChecker has quit [Client Quit]
SpellChecker has joined #bitcoin-core-dev
b_101 has quit [Ping timeout: 240 seconds]
puchka has quit [Ping timeout: 248 seconds]
b_101 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] glozow opened pull request #27742: [NO MERGE] BIP331 Ancestor Package Relay (master...package-relay-token-bucket) https://github.com/bitcoin/bitcoin/pull/27742
puchka has joined #bitcoin-core-dev
<instagibbs> 👀
<fanquake> 🚀
<glozow> whew, lint passed
<sdaftuar> merge?
<instagibbs> RFM
<glozow> opening milestone 1 PR soon
jarthur has joined #bitcoin-core-dev
salvatoshi has quit [Ping timeout: 248 seconds]
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/51c050787fd6...a13f3746dccd
<bitcoin-git> bitcoin/master eeee55f MarcoFalke: rpc: Fix invalid bech32 handling
<bitcoin-git> bitcoin/master a13f374 Andrew Chow: Merge bitcoin/bitcoin#27727: rpc: Fix invalid bech32 address handling
<bitcoin-git> [bitcoin] achow101 merged pull request #27727: rpc: Fix invalid bech32 address handling (master...2305-rpc-bech32-) https://github.com/bitcoin/bitcoin/pull/27727
ghost43_ has joined #bitcoin-core-dev
ghost43 has quit [Ping timeout: 240 seconds]
b_101 has quit [Ping timeout: 240 seconds]
b_101 has joined #bitcoin-core-dev
<jamesob> Something cool for debugging I found out recently; if you override `std::ostream& operator<<(std::ostream& os, const YourObject& o)`, you can just use `tfm::format("%s", your_object);` with no goofy ToString() method call. This of course works with LogPrint* too.
<jamesob> s/override/declare
<jamesob> sdaftuar: oops! missed your message earlier
puchka has quit [Ping timeout: 264 seconds]
earnestly has joined #bitcoin-core-dev
hernanmarino has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
puchka has joined #bitcoin-core-dev
<brunoerg> instagibbs: #26969 rebased
<gribble> https://github.com/bitcoin/bitcoin/issues/26969 | net, refactor: net_processing, add `ProcessCompactBlockTxns` by brunoerg · Pull Request #26969 · bitcoin/bitcoin · GitHub
SpellChecker has quit [Ping timeout: 240 seconds]
SpellChecker has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] instagibbs opened pull request #27743: Unconditionally return when compact block status == READ_STATUS_FAILED (master...parallel_fail_fix) https://github.com/bitcoin/bitcoin/pull/27743
b_101 has quit [Ping timeout: 240 seconds]
flooded has joined #bitcoin-core-dev
wpaulino has left #bitcoin-core-dev [#bitcoin-core-dev]
test_ has quit [Ping timeout: 240 seconds]
b_101 has joined #bitcoin-core-dev
b_101 has quit [Ping timeout: 240 seconds]
b_101 has joined #bitcoin-core-dev
b_101 has quit [Ping timeout: 246 seconds]
Guest30 has joined #bitcoin-core-dev
___nick___ has joined #bitcoin-core-dev
___nick___ has quit [Client Quit]
puchka has quit [Ping timeout: 240 seconds]
___nick___ has joined #bitcoin-core-dev
puchka has joined #bitcoin-core-dev
Guest14 has joined #bitcoin-core-dev
Talkless has quit [Quit: Konversation terminated!]
<bitcoin-git> [bitcoin] amitiuttarwar opened pull request #27745: addrman: select addresses by network follow-up (master...2023-04-sbn-followups) https://github.com/bitcoin/bitcoin/pull/27745
aielima has joined #bitcoin-core-dev
Guest14 has quit [Quit: Client closed]
b_101 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] sdaftuar opened pull request #27746: Draft: rework validation logic for assumeutxo (master...2023-05-assumeutxo-validation-improvements) https://github.com/bitcoin/bitcoin/pull/27746
Guest30 has quit [Ping timeout: 245 seconds]
b_101 has quit [Ping timeout: 265 seconds]
vysn has quit [Remote host closed the connection]
___nick___ has quit [Ping timeout: 268 seconds]
mudsip has joined #bitcoin-core-dev
mudsip has quit []
aielima has quit [Killed (NickServ (Forcing logout aielima -> aielima))]
aielima has joined #bitcoin-core-dev
bugs_ has quit [Quit: Leaving]
preimage has quit [Quit: WeeChat 3.8]
b_101 has joined #bitcoin-core-dev
b_101 has quit [Ping timeout: 240 seconds]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
b_101 has joined #bitcoin-core-dev
b_101 has quit [Ping timeout: 240 seconds]
evri has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
b_101 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
<jamesob> kind of dumb, but does anyone know of a shorthand for wiping a node's datadir in the functional test framework?
<achow101> jamesob: 'os.unlink(node.datadir)'?
b_101 has quit [Ping timeout: 265 seconds]
b_101 has joined #bitcoin-core-dev
<jamesob> achow101: yeah I'm doing something equivalent and it's screwing up on restart... I'll figure it out, just didn't know if we had an established pattern
b_101 has quit [Ping timeout: 240 seconds]
hernanmarino has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
hernanmarino has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
Guest2792 has quit [Changing host]
Guest2792 has joined #bitcoin-core-dev
Guest2792 is now known as gwillen
puchka has quit [Ping timeout: 264 seconds]
Evel-Knievel has quit [Ping timeout: 240 seconds]
ZeroMaster has quit [Ping timeout: 248 seconds]
martinus_ has joined #bitcoin-core-dev
martinus has quit [Ping timeout: 246 seconds]
<cfields> provoostenator: thanks for the great in-depth review on 27626.
b_101 has joined #bitcoin-core-dev
aielima has quit [Quit: Ciao]
PaperSword has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
ZeroMaster has joined #bitcoin-core-dev
b_101 has quit [Ping timeout: 268 seconds]
brunoerg has quit [Ping timeout: 248 seconds]
EleYah has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
b_101 has joined #bitcoin-core-dev
b_101 has quit [Ping timeout: 264 seconds]
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev