memset has quit [Remote host closed the connection]
adil has joined #bitcoin-core-dev
adil has quit [Quit: adil]
pzafonte has joined #bitcoin-core-dev
pzafonte has quit [Ping timeout: 248 seconds]
GoldenGoose has quit [Remote host closed the connection]
GoldenGoose has joined #bitcoin-core-dev
pzafonte_ has joined #bitcoin-core-dev
BrandonOdiwuor has joined #bitcoin-core-dev
pzafonte_ has quit [Ping timeout: 244 seconds]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
adil has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
pzafonte_ has joined #bitcoin-core-dev
pzafonte_ has quit [Ping timeout: 265 seconds]
conman has quit [Quit: Konversation terminated!]
conman has joined #bitcoin-core-dev
pzafonte has joined #bitcoin-core-dev
pzafonte has quit [Ping timeout: 252 seconds]
pzafonte has joined #bitcoin-core-dev
dviola has quit [Ping timeout: 248 seconds]
diego has joined #bitcoin-core-dev
durandal__ has joined #bitcoin-core-dev
durandal_ has quit [Remote host closed the connection]
adil has quit [Quit: adil]
l0rinc has quit [Quit: l0rinc]
cman has joined #bitcoin-core-dev
conman has quit [Ping timeout: 273 seconds]
cman has quit [Quit: Konversation terminated!]
conman has joined #bitcoin-core-dev
conman has quit [Quit: Konversation terminated!]
conman has joined #bitcoin-core-dev
adil has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
meebey has quit [Ping timeout: 248 seconds]
cman has joined #bitcoin-core-dev
conman has quit [Ping timeout: 241 seconds]
meebey has joined #bitcoin-core-dev
rogeliodh has quit [Server closed connection]
rogeliodh has joined #bitcoin-core-dev
watAboutMe has joined #bitcoin-core-dev
adil has quit [Quit: adil]
watAboutMe has quit [Changing host]
watAboutMe has joined #bitcoin-core-dev
watAboutMe has quit [Remote host closed the connection]
tigerMafia has joined #bitcoin-core-dev
pzafonte has quit [Ping timeout: 260 seconds]
<tigerMafia>
_aj_: i've always thought of it as: "wrote some of the code in this commit"
tigerMafia has quit [Client Quit]
pzafonte_ has joined #bitcoin-core-dev
pzafonte_ has quit [Ping timeout: 257 seconds]
cman has quit [Quit: Konversation terminated!]
conman has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [#bitcoin-core-dev]
otoburb has quit [Ping timeout: 244 seconds]
otoburb has joined #bitcoin-core-dev
PaperSword has quit [Quit: PaperSword]
PaperSword has joined #bitcoin-core-dev
PaperSword has quit [Client Quit]
diego has quit [Ping timeout: 276 seconds]
diego has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 244 seconds]
pzafonte_ has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
pzafonte_ has quit [Ping timeout: 244 seconds]
diego has left #bitcoin-core-dev [#bitcoin-core-dev]
dviola has joined #bitcoin-core-dev
pzafonte_ has joined #bitcoin-core-dev
pzafonte_ has quit [Ping timeout: 260 seconds]
WizJin_ has quit [Quit: Leaving]
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 276 seconds]
pzafonte has joined #bitcoin-core-dev
pzafonte has quit [Ping timeout: 244 seconds]
pzafonte has joined #bitcoin-core-dev
pzafonte has quit [Ping timeout: 249 seconds]
bugs_ has joined #bitcoin-core-dev
ozdeadman has quit [Ping timeout: 252 seconds]
deadmanoz has joined #bitcoin-core-dev
jon_atack has quit [Read error: Connection reset by peer]
pzafonte has joined #bitcoin-core-dev
pzafonte has quit [Ping timeout: 248 seconds]
pzafonte_ has joined #bitcoin-core-dev
pzafonte_ has quit [Ping timeout: 276 seconds]
adil has joined #bitcoin-core-dev
adil has quit [Client Quit]
ghost43 has quit [Remote host closed the connection]
pzafonte_ has joined #bitcoin-core-dev
pzafonte_ has quit [Ping timeout: 256 seconds]
ghost43 has joined #bitcoin-core-dev
pzafonte_ has joined #bitcoin-core-dev
pzafonte_ has quit [Ping timeout: 244 seconds]
l0rinc has joined #bitcoin-core-dev
___nick___ has quit [Ping timeout: 251 seconds]
___nick___ has joined #bitcoin-core-dev
<sipa>
_aj_: i've always used it as "contributed a significant part of the code in this commit" (more than just the idea, and more than a few individual lines/nits)
<sliv3r__>
_aj_; same, I use it as "contributed to a significant part of the code", however in one specific case I used it when no code was provided as it was a bug fix that was really detailed, how to trigger, what code is wrong, etc. And the change was really small, just 2 lines.
l0rinc has quit [Quit: l0rinc]
pzafonte_ has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
pzafonte_ has quit [Ping timeout: 265 seconds]
jonatack has joined #bitcoin-core-dev
<l0rinc>
_aj_: ```are we using co-author to mean "wrote some of the code in this commit" or "contributed to the design" these days?``` - I noticed that people interpret this differently. I usually add everyone as a co-author who helped me get to the final shape, as a token of appreciation - whether through non-trivial ideas, reviews or suggestions. Are we supposed to reserve it for special occasions?
pzafonte_ has joined #bitcoin-core-dev
pzafonte_ has quit [Ping timeout: 268 seconds]
l0rinc has quit [Quit: l0rinc]
pzafonte_ has joined #bitcoin-core-dev
<lightlike>
when someone else contributed the idea for a commit (but no code) I usually just put "Idea by xxx" into the commit msg, but co-author only for non-trivial code. but happy to do whatever the consensus is.
pzafonte_ has quit [Ping timeout: 270 seconds]
smartin has joined #bitcoin-core-dev
<sedited>
_aj_ I would prefer if people would use co-author to mean "fully understands the commit and contributed to its code"
<nkaretnikov>
imo spelling it out resolves any ambiguity: “based on a patch by”, “inspired by an idea by”, etc. if someone provided a patch, i would try to add it to a branch as a separate commit and then apply changes on top to make it clear who contributed what.