achow101 changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 16:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
afiore has quit [Remote host closed the connection]
afiore has joined #bitcoin-core-dev
ghost43_ has joined #bitcoin-core-dev
ghost43 has quit [Ping timeout: 252 seconds]
jonatack has quit [Read error: Connection reset by peer]
l0rinc has joined #bitcoin-core-dev
sliv3r__- has quit [Ping timeout: 249 seconds]
sliv3r__ has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
adil has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
l0rinc has joined #bitcoin-core-dev
adil has quit [Quit: adil]
jonatack has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
l0rinc has joined #bitcoin-core-dev
Guest68 has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
l0rinc has joined #bitcoin-core-dev
jonatack has quit [Read error: Connection reset by peer]
dviola has quit [Ping timeout: 248 seconds]
diego has joined #bitcoin-core-dev
Guest68 has quit [Quit: Client closed]
l0rinc has quit [Quit: l0rinc]
BrandonOdiwuor has joined #bitcoin-core-dev
sliv3r__ has quit [Ping timeout: 251 seconds]
sliv3r__ has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
BrandonOdiwuor has quit [Quit: Client closed]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
phungus8153520 has joined #bitcoin-core-dev
sliv3r__ has quit [Quit: ZNC 1.8.2+deb3.1+deb12u1 - https://znc.in]
sliv3r__ has joined #bitcoin-core-dev
syrup_trap2444 has joined #bitcoin-core-dev
syrup_trap244 has quit [Ping timeout: 241 seconds]
<bitcoin-git> [gui-qml] pseudoramdom opened pull request #860: Improve Send and Send Review pages (qt6...send-improvements) https://github.com/bitcoin-core/gui-qml/pull/860
sliv3r__ has quit [Read error: Connection reset by peer]
sliv3r__- has joined #bitcoin-core-dev
dermoth has quit [Ping timeout: 258 seconds]
l0rinc has quit [Quit: l0rinc]
dermoth has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
WizJin has joined #bitcoin-core-dev
WizJin has quit [Remote host closed the connection]
WizJin has joined #bitcoin-core-dev
Guest38 has joined #bitcoin-core-dev
Guest38 has quit [Client Quit]
Guyver2 has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [#bitcoin-core-dev]
cfields has quit [Read error: Connection reset by peer]
cfields has joined #bitcoin-core-dev
sliv3r__- is now known as sliv3r__
Guest44 has joined #bitcoin-core-dev
Guest44 has quit [Client Quit]
___nick___ has joined #bitcoin-core-dev
___nick___ has quit [Client Quit]
___nick___ has joined #bitcoin-core-dev
ghost43 has joined #bitcoin-core-dev
ghost43_ has quit [Ping timeout: 252 seconds]
svanstaa_ has joined #bitcoin-core-dev
svanstaa has quit [Ping timeout: 252 seconds]
<bitcoin-git> [bitcoin] Shaurya2k06 opened pull request #35968: test: sync funding block before isolating nodes (master...test-wallet-listtransactions-sync) https://github.com/bitcoin/bitcoin/pull/35968
greypw1495085720 has joined #bitcoin-core-dev
afiore has quit [Remote host closed the connection]
afiore has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake opened pull request #35969: [31.x] More Backports (31.x...even_more_31_x_backports) https://github.com/bitcoin/bitcoin/pull/35969
afiore has quit [Remote host closed the connection]
afiore has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] musaHaruna opened pull request #35970: Test persisted health requires mempool restore (master...test-persisted-health-requires-mempool-restore) https://github.com/bitcoin/bitcoin/pull/35970
<bitcoin-git> [bitcoin] musaHaruna closed pull request #35970: Test persisted health requires mempool restore (master...test-persisted-health-requires-mempool-restore) https://github.com/bitcoin/bitcoin/pull/35970
conman has quit [Quit: Konversation terminated!]
conman has joined #bitcoin-core-dev
diego has left #bitcoin-core-dev [#bitcoin-core-dev]
dviola has joined #bitcoin-core-dev
conman has quit [Quit: Konversation terminated!]
conman has joined #bitcoin-core-dev
jerryf has joined #bitcoin-core-dev
conman has quit [Quit: Konversation terminated!]
conman has joined #bitcoin-core-dev
<bitcoin-git> [qa-assets] frankomosh opened pull request #286: Add p2p_private_broadcast corpus (main...add-p2p-private-broadcast-corpus) https://github.com/bitcoin-core/qa-assets/pull/286
conman has quit [Quit: Konversation terminated!]
conman has joined #bitcoin-core-dev
conman has quit [Quit: Konversation terminated!]
conman has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake opened pull request #35971: net_processing: remove unused code (master...dead_netcode) https://github.com/bitcoin/bitcoin/pull/35971
Guest77 has joined #bitcoin-core-dev
Guest77 has quit [Client Quit]
eugenesiegel has joined #bitcoin-core-dev
ozdeadman has quit [Ping timeout: 264 seconds]
deadmanoz has joined #bitcoin-core-dev
pzafonte_ has quit [Ping timeout: 245 seconds]
jerryf has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
bugs_ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/11090c8bb359...aad830ac4a65
<bitcoin-git> bitcoin/master 954985e Martin Zumsande: test: simplify blockfilter test's BuildChain helper
<bitcoin-git> bitcoin/master a3597e2 Martin Zumsande: test: move BuildChain helper into test mining util
<bitcoin-git> bitcoin/master 2232d6a Martin Zumsande: test: move index_reorg_crash to baseindex_tests
<bitcoin-git> [bitcoin] fanquake merged pull request #35847: test: move more tests to `baseindex_tests` and run them for all indexes (master...202607_baseindex_tests) https://github.com/bitcoin/bitcoin/pull/35847
PaperSword has quit [Read error: Connection reset by peer]
jerryf has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/aad830ac4a65...e95bab98f03c
<bitcoin-git> bitcoin/master 8b5da67 fanquake: common: remove ::runtime_error from RunCommandParseJSON
<bitcoin-git> bitcoin/master e95bab9 merge-script: Merge bitcoin/bitcoin#35960: common: remove `::runtime_error` from `RunCom...
<bitcoin-git> [bitcoin] fanquake merged pull request #35960: common: remove `::runtime_error` from `RunCommandParseJSON` (master...run_command_json) https://github.com/bitcoin/bitcoin/pull/35960
<fanquake> sipa: could you take a look at https://github.com/bitcoin-core/minisketch/pull/102 when you're back online
jonatack has quit [Read error: Connection reset by peer]
jerryf has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
bugs_ has quit [Quit: Leaving]
jerryf has quit [Remote host closed the connection]
jerryf_ has joined #bitcoin-core-dev
jerryf_ has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
jerryf has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
WizJin has quit [Quit: Leaving]
<bitcoin-git> [bitcoin] fanquake pushed 10 commits to master: https://github.com/bitcoin/bitcoin/compare/e95bab98f03c...dec68f997e7c
<bitcoin-git> bitcoin/master fa6e1a1 MarcoFalke: refactor: Remove static from constexpr functions in headers
<bitcoin-git> bitcoin/master 5555d5d MarcoFalke: scripted-diff: Use inline constexpr over static constexpr
<bitcoin-git> bitcoin/master faedb52 MarcoFalke: refactor: Make CFeeRate(integral) ctor constexpr
<bitcoin-git> [bitcoin] fanquake merged pull request #35852: scripted-diff: Use inline const(expr) over static constexpr in headers (master...2607-refactor-inline-constexpr) https://github.com/bitcoin/bitcoin/pull/35852
jonatack has joined #bitcoin-core-dev
jerryf has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
___nick___ has quit [Ping timeout: 276 seconds]
___nick___ has joined #bitcoin-core-dev
jackielove4u has joined #bitcoin-core-dev
afiore has quit [Remote host closed the connection]
jerryf has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
afiore has joined #bitcoin-core-dev
afiore has quit [Remote host closed the connection]
jerryf has quit [Remote host closed the connection]
jonatack has quit [Ping timeout: 248 seconds]
jerryf has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] marcofleon opened pull request #35972: fuzz: Fix assertion in `txorphan` (master...2026/08/fix-txorphan-assert) https://github.com/bitcoin/bitcoin/pull/35972
afiore has joined #bitcoin-core-dev
Guest3 has joined #bitcoin-core-dev
Guest3 has quit [Client Quit]
greypw1495085720 has quit [Quit: Ping timeout (120 seconds)]
greypw1495085720 has joined #bitcoin-core-dev
pzafonte has joined #bitcoin-core-dev
pzafonte has quit [Ping timeout: 252 seconds]
pzafonte_ has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
l0rinc has quit [Client Quit]
WizJin has joined #bitcoin-core-dev
WizJin has quit [Remote host closed the connection]
greypw1495085720 has quit [Remote host closed the connection]
greypw1495085720 has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
eugenesiegel has quit [Quit: Client closed]
pzafonte_ has quit [Ping timeout: 274 seconds]
<bitcoin-git> [bitcoin] xHope-tech opened pull request #35973: doc: adding display server protocol after X11 (master...master) https://github.com/bitcoin/bitcoin/pull/35973
<bitcoin-git> [bitcoin] SARK993369 opened pull request #35974: Create cmake-single-platform.yml (master...master) https://github.com/bitcoin/bitcoin/pull/35974
<bitcoin-git> [bitcoin] DrahtBot closed pull request #35974: Create cmake-single-platform.yml (master...master) https://github.com/bitcoin/bitcoin/pull/35974
<l0rinc> bitcoindev1337: I have reproduced the speedup with IBD as well now - 20% faster on a HDD. Excellent finding!
<pinheadmz> any macOS devs using cmake 4.3 or greater? They changed FindSQLite3 and it looks like it's injecting the macOS SDK usr/include as a system include, which breaks clang/libc++ header ordering. Effect is brilliant errors like "error: unknown type name '__uint32_t'"... for me the fix was adding -DSQLite3_ROOT="$(brew --prefix sqlite)"
<l0rinc> I always had that on local non-Apple clang
<pinheadmz> i.e. forcing the compiler to use the homebrew sqlite instead of make 4.3 looking for it in the system shit, and pulling in all the system headers too early
<pinheadmz> i only pulled cmake 4.4 this week
<pinheadmz> we could add something to cmakelists.txt to avoid MacOSX.sdk for sqlite @hebasto ?
<bitcoin-git> [bitcoin] sedited pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/dec68f997e7c...230185a5ee74
<bitcoin-git> bitcoin/master c7eacbd fanquake: net_processing: remove Peer& from UpdatePeerStateForReceivedHeaders
<bitcoin-git> bitcoin/master 0cff3cc fanquake: net_processing: Remove redundant porphanTx in ProcessOrphanTx
<bitcoin-git> bitcoin/master 230185a merge-script: Merge bitcoin/bitcoin#35971: net_processing: remove unused code
<bitcoin-git> [bitcoin] sedited merged pull request #35971: net_processing: remove unused code (master...dead_netcode) https://github.com/bitcoin/bitcoin/pull/35971
<bitcoin-git> [bitcoin] sedited pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/230185a5ee74...683e05a265c8
<bitcoin-git> bitcoin/master 221a3fe Lőrinc: test: cover mixed `gettxspendingprevout` order
<bitcoin-git> bitcoin/master f98753e Lőrinc: refactor: identify prevouts by request index
<bitcoin-git> bitcoin/master da1eaeb Lőrinc: rpc: preserve `gettxspendingprevout` order
<bitcoin-git> [bitcoin] sedited merged pull request #35889: rpc: avoid quadratic `gettxspendingprevout` work and preserve order (master...l0rinc/rpc-gettxspendingprevout-linear) https://github.com/bitcoin/bitcoin/pull/35889
jerryf has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
___nick___ has quit [Ping timeout: 260 seconds]
l0rinc has quit [Quit: l0rinc]
l0rinc has joined #bitcoin-core-dev
conman has quit [Quit: Konversation terminated!]
conman has joined #bitcoin-core-dev
conman has quit [Quit: Konversation terminated!]
conman has joined #bitcoin-core-dev
jerryf_ has joined #bitcoin-core-dev
jerryf has quit [Remote host closed the connection]
jonatack has joined #bitcoin-core-dev
jerryf_ has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] achow101 opened pull request #35975: wallet: Fix `CWalletTx` malleated transaction metadata sync (master...syncmetadata-nonsegwit) https://github.com/bitcoin/bitcoin/pull/35975
conman has quit [Quit: Konversation terminated!]
jonatack has quit [Ping timeout: 276 seconds]
conman has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] sedited opened pull request #35976: test: Speedup fee estimation functional test with batching (master...fee_estimation_test_speedup) https://github.com/bitcoin/bitcoin/pull/35976
uqlidi54 has joined #bitcoin-core-dev
uqlidi5 has quit [Read error: Connection reset by peer]
greypw1495085720 has quit [Remote host closed the connection]
greypw1495085720 has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
___nick___ has joined #bitcoin-core-dev
<_aj_> are we using co-author to mean "wrote some of the code in this commit" or "contributed to the design" these days? i thought the former, but i've seen a few cases where the latter seems to be more in play? does the distinction matter for some people's grant KPIs?
uqlidi54 has quit [Read error: Connection reset by peer]
uqlidi547 has joined #bitcoin-core-dev
jerryf has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev