achow101 changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 16:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
timbo_xyz has quit [Ping timeout: 252 seconds]
timbo_xyz has joined #bitcoin-core-dev
janb84 has quit [Ping timeout: 252 seconds]
janb84 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/88a7294356e7...57350c5352fa
<bitcoin-git> bitcoin/master 2f5b1c5 Lőrinc: psbt: Fix `PSBTInputSignedAndVerified` bounds `assert`
<bitcoin-git> bitcoin/master 57350c5 Ava Chow: Merge bitcoin/bitcoin#34272: psbt: Fix `PSBTInputSignedAndVerified` bounds...
<bitcoin-git> [bitcoin] achow101 merged pull request #34272: psbt: Fix `PSBTInputSignedAndVerified` bounds `assert` (master...l0rincpsbt-bounds-assert) https://github.com/bitcoin/bitcoin/pull/34272
afiore has quit [Quit: GNU inetutils 1.3a (telnet)]
Cory92 has joined #bitcoin-core-dev
Cory16 has quit [Ping timeout: 272 seconds]
bitdex has quit [Ping timeout: 252 seconds]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
aleggg has quit [Remote host closed the connection]
afiore has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
jerryf_ has joined #bitcoin-core-dev
timbo_xyz has quit [Ping timeout: 252 seconds]
jerryf has quit [Remote host closed the connection]
Cory85 has joined #bitcoin-core-dev
Cory92 has quit [Ping timeout: 272 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 240 seconds]
timbo_xyz has joined #bitcoin-core-dev
timbo_xyz has quit [Ping timeout: 252 seconds]
timbo_xyz has joined #bitcoin-core-dev
jadi has quit [Ping timeout: 264 seconds]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 246 seconds]
aleggg has joined #bitcoin-core-dev
timbo_xyz has quit [Ping timeout: 252 seconds]
adil has joined #bitcoin-core-dev
timbo_xyz has joined #bitcoin-core-dev
S3RK has joined #bitcoin-core-dev
S3RK_ has quit [Ping timeout: 264 seconds]
jadi has joined #bitcoin-core-dev
jadi has quit [Ping timeout: 264 seconds]
bitdex has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 260 seconds]
timbo_xyz has quit [Ping timeout: 252 seconds]
cmirror has quit [Read error: Connection reset by peer]
timbo_xyz has joined #bitcoin-core-dev
timbo_xyz has quit [Ping timeout: 252 seconds]
jarthur has quit [Quit: jarthur]
timbo_xyz has joined #bitcoin-core-dev
timbo_xyz has quit [Ping timeout: 252 seconds]
adil has quit [Quit: adil]
adil has joined #bitcoin-core-dev
timbo_xyz has joined #bitcoin-core-dev
timbo_xyz has quit [Ping timeout: 252 seconds]
jadi has joined #bitcoin-core-dev
jadi has quit [Ping timeout: 256 seconds]
robszarka has quit [Read error: Connection reset by peer]
robszarka has joined #bitcoin-core-dev
timbo_xyz has joined #bitcoin-core-dev
adil has quit [Ping timeout: 260 seconds]
adil has joined #bitcoin-core-dev
ghost43 has quit [Ping timeout: 252 seconds]
timbo_xyz has quit [Ping timeout: 252 seconds]
ghost43 has joined #bitcoin-core-dev
timbo_xyz has joined #bitcoin-core-dev
timbo_xyz has quit [Ping timeout: 252 seconds]
adil has quit [Quit: adil]
adil has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
timbo_xyz has joined #bitcoin-core-dev
timbo_xyz has quit [Ping timeout: 252 seconds]
timbo_xyz has joined #bitcoin-core-dev
Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]
timbo_xyz has quit [Ping timeout: 252 seconds]
flooded has quit [Remote host closed the connection]
flooded has joined #bitcoin-core-dev
Cory9 has joined #bitcoin-core-dev
flooded has quit [Remote host closed the connection]
flooded has joined #bitcoin-core-dev
Cory85 has quit [Ping timeout: 272 seconds]
flooded has quit [Remote host closed the connection]
l0rinc has quit [Read error: Connection reset by peer]
l0rinc_ has joined #bitcoin-core-dev
flooded has joined #bitcoin-core-dev
adil has quit [Ping timeout: 260 seconds]
flooded has quit [Remote host closed the connection]
flooded has joined #bitcoin-core-dev
timbo_xyz has joined #bitcoin-core-dev
PaperSword has quit [Quit: PaperSword]
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/57350c5352fa...ac76d94117be
<bitcoin-git> bitcoin/master fa1d17d MarcoFalke: refactor: Use uint64_t over size_t for serialize corruption check in fees....
<bitcoin-git> bitcoin/master ac76d94 merge-script: Merge bitcoin/bitcoin#34109: refactor: Use uint64_t over size_t for serial...
<bitcoin-git> [bitcoin] fanquake merged pull request #34109: refactor: Use uint64_t over size_t for serialize corruption check in fees.dat (master...2512-fix-u64) https://github.com/bitcoin/bitcoin/pull/34109
jadi has joined #bitcoin-core-dev
jadi has quit [Ping timeout: 245 seconds]
timbo_xy1 has joined #bitcoin-core-dev
timbo_xyz has quit [Remote host closed the connection]
<bitcoin-git> [bitcoin] maflcko opened pull request #34279: test: Fail on self-check warnings in test_runner.py (master...2601-test-runner-fail-on-warn) https://github.com/bitcoin/bitcoin/pull/34279
adil has joined #bitcoin-core-dev
WizJin_ has quit [Ping timeout: 246 seconds]
<bitcoin-git> [bitcoin] l0rinc closed pull request #32043: [IBD] Tracking PR for speeding up Initial Block Download (master...l0rinc/IBD-optimizations) https://github.com/bitcoin/bitcoin/pull/32043
Guyver2 has joined #bitcoin-core-dev
timbo_xy1 is now known as timbo
timbo is now known as timbo_xyz
adil has quit [Quit: adil]
adys has quit [Read error: Connection reset by peer]
adys has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 4 commits to 28.x: https://github.com/bitcoin/bitcoin/compare/ad8b23e58909...3de2c3fd1769
<bitcoin-git> bitcoin/28.x 38d338d SatsAndSports: Remove unreliable seed from chainparams.cpp, and the associated README
<bitcoin-git> bitcoin/28.x 3dd011e Hennadii Stepanov: guix: Fix `osslsigncode` tests
<bitcoin-git> bitcoin/28.x 514cf39 fanquake: doc: update release notes for v28.x
<bitcoin-git> [bitcoin] fanquake merged pull request #34270: [28.x] Backports (28.x...28_backports) https://github.com/bitcoin/bitcoin/pull/34270
durandal_ has quit [Ping timeout: 240 seconds]
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ac76d94117be...28f70c571bd4
<bitcoin-git> bitcoin/master fa5032f MarcoFalke: ci: Run feature_unsupported_utxo_db.py on Windows
<bitcoin-git> bitcoin/master 28f70c5 merge-script: Merge bitcoin/bitcoin#34240: ci: Run feature_unsupported_utxo_db.py on Win...
<bitcoin-git> [bitcoin] fanquake merged pull request #34240: ci: Run feature_unsupported_utxo_db.py on Windows (master...2601-ci-ancient-windows) https://github.com/bitcoin/bitcoin/pull/34240
durandal_ has joined #bitcoin-core-dev
jadi has joined #bitcoin-core-dev
l0rinc_ has quit [Quit: l0rinc_]
jadi has quit [Ping timeout: 264 seconds]
<bitcoin-git> [bitcoin] maflcko opened pull request #34281: build: Temporarily remove confusing and brittle `-fdebug-prefix-map` (master...2601-build-fix-remove) https://github.com/bitcoin/bitcoin/pull/34281
Cory11 has joined #bitcoin-core-dev
Cory9 has quit [Ping timeout: 272 seconds]
l0rinc has joined #bitcoin-core-dev
l0rinc has quit [Client Quit]
l0rinc has joined #bitcoin-core-dev
l0rinc has quit [Client Quit]
timbo_xyz has quit [Ping timeout: 252 seconds]
<bitcoin-git> [bitcoin] fanquake closed pull request #34116: cmake: Fix debugging info (master...251219-debug-path) https://github.com/bitcoin/bitcoin/pull/34116
Cory99 has joined #bitcoin-core-dev
Cory11 has quit [Ping timeout: 272 seconds]
durandal_ has quit [Ping timeout: 244 seconds]
<bitcoin-git> [bitcoin] hebasto opened pull request #34282: qa: Fix Windows logging bug (master...260114-win-skip-reason) https://github.com/bitcoin/bitcoin/pull/34282
<bitcoin-git> [bitcoin] fanquake opened pull request #34283: [30.x] More backports (30.x...30_3_backports) https://github.com/bitcoin/bitcoin/pull/34283
bitdex has quit [Quit: = ""]
durandal_ has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] ryanofsky opened pull request #34284: ipc, test: Add tests for unclean disconnect and thread busy behavior (master...pr/ipc-testasync) https://github.com/bitcoin/bitcoin/pull/34284
josie has quit [Quit: ZNC 1.8.2 - https://znc.in]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
josie has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
timbo_xyz has joined #bitcoin-core-dev
timbo_xyz has quit [Ping timeout: 252 seconds]
l0rinc has joined #bitcoin-core-dev
sbddesign has joined #bitcoin-core-dev
jadi has joined #bitcoin-core-dev
timbo_xyz has joined #bitcoin-core-dev
jadi has quit [Ping timeout: 244 seconds]
sbddesign has quit [Ping timeout: 244 seconds]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
bugs_ has joined #bitcoin-core-dev
sbddesign has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
timbo_xy1 has joined #bitcoin-core-dev
timbo_xyz has quit [Ping timeout: 252 seconds]
timbo_xyz has joined #bitcoin-core-dev
timbo_xy1 has quit [Ping timeout: 252 seconds]
timbo_xyz has quit [Remote host closed the connection]
timbo_xy1 has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
Cory99 has quit [Quit: Client closed]
Cory99 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] hebasto opened pull request #34285: ci: Install `pyzmq` for functional tests on Windows (master...260114-windows-pyzmq) https://github.com/bitcoin/bitcoin/pull/34285
timbo_xyz has joined #bitcoin-core-dev
timbo_xy1 has quit [Ping timeout: 252 seconds]
SpellChecker has quit [Remote host closed the connection]
Cory84 has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
SpellChecker has joined #bitcoin-core-dev
Cory99 has quit [Ping timeout: 272 seconds]
timbo_xy1 has joined #bitcoin-core-dev
timbo_xyz has quit [Ping timeout: 252 seconds]
timbo_xyz has joined #bitcoin-core-dev
timbo_xy1 has quit [Ping timeout: 252 seconds]
___nick___ has joined #bitcoin-core-dev
___nick___ has quit [Client Quit]
___nick___ has joined #bitcoin-core-dev
___nick___ has quit [Client Quit]
___nick___ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] yashbhutwala opened pull request #34286: test: verify node state after restart in assumeutxo (master...test-wallet-assumeutxo-restart-state) https://github.com/bitcoin/bitcoin/pull/34286
Cory83 has joined #bitcoin-core-dev
jadi has joined #bitcoin-core-dev
Cory84 has quit [Ping timeout: 272 seconds]
jadi has quit [Ping timeout: 246 seconds]
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/28f70c571bd4...c447eea43d5a
<bitcoin-git> bitcoin/master b762538 billymcbip: test: Add unit test for SCRIPT_ERR_NUMEQUALVERIFY
<bitcoin-git> bitcoin/master c447eea merge-script: Merge bitcoin/bitcoin#34145: test: Add unit test for OP_NUMEQUALVERIFY
<bitcoin-git> [bitcoin] fanquake merged pull request #34145: test: Add unit test for OP_NUMEQUALVERIFY (master...num) https://github.com/bitcoin/bitcoin/pull/34145
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c447eea43d5a...db6e576710ad
<bitcoin-git> bitcoin/master fa2959e MarcoFalke: test: Fail on self-check warnings in test_runner.py
<bitcoin-git> bitcoin/master db6e576 merge-script: Merge bitcoin/bitcoin#34279: test: Fail on self-check warnings in test_run...
<bitcoin-git> [bitcoin] fanquake merged pull request #34279: test: Fail on self-check warnings in test_runner.py (master...2601-test-runner-fail-on-warn) https://github.com/bitcoin/bitcoin/pull/34279
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/db6e576710ad...2d380aee43cd
memset has quit [Remote host closed the connection]
<bitcoin-git> bitcoin/master 1412b77 ismaelsadeeq: refactor: execute `PackageMempoolChecks` during package rbf only
<bitcoin-git> bitcoin/master 7fc465e ismaelsadeeq: doc: fix incorrect description of `PackageMempoolChecks`
<bitcoin-git> bitcoin/master 2d380ae merge-script: Merge bitcoin/bitcoin#34243: doc: validation: fix `PackageMempoolChecks` i...
<bitcoin-git> [bitcoin] fanquake merged pull request #34243: doc: validation: fix `PackageMempoolChecks` incorrect comment (master...01-2026-fix-PackageMempoolChecks-incorrect-comment) https://github.com/bitcoin/bitcoin/pull/34243
memset has joined #bitcoin-core-dev
Cory83 has quit [Quit: Client closed]
Cory83 has joined #bitcoin-core-dev
Cory20 has joined #bitcoin-core-dev
Cory83 has quit [Ping timeout: 272 seconds]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2d380aee43cd...c0219f6beaa0
<bitcoin-git> bitcoin/master f62568c Hennadii Stepanov: ci: Install `pyzmq` for functional tests on Windows
<bitcoin-git> bitcoin/master c0219f6 merge-script: Merge bitcoin/bitcoin#34285: ci: Install `pyzmq` for functional tests on W...
<bitcoin-git> [bitcoin] fanquake merged pull request #34285: ci: Install `pyzmq` for functional tests on Windows (master...260114-windows-pyzmq) https://github.com/bitcoin/bitcoin/pull/34285
Cory65 has joined #bitcoin-core-dev
jadi has joined #bitcoin-core-dev
Cory20 has quit [Ping timeout: 272 seconds]
<bitcoin-git> [bitcoin] theStack opened pull request #34287: [RFC] test: integrate secp256k1lab as subtree and use it for low-level EC ops (master...2026-add-secp256k1lab-subtree2) https://github.com/bitcoin/bitcoin/pull/34287
l0rinc has quit [Quit: l0rinc]
<bitcoin-git> [bitcoin] maflcko opened pull request #34288: fuzz: Exclude too expensive inputs in miniscript_string target (master...2601-fuzz-ms-str) https://github.com/bitcoin/bitcoin/pull/34288
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
Cory48 has joined #bitcoin-core-dev
Cory65 has quit [Ping timeout: 272 seconds]
timbo_xy1 has joined #bitcoin-core-dev
timbo_xyz has quit [Ping timeout: 252 seconds]
timbo_xyz has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 252 seconds]
timbo_xy1 has quit [Ping timeout: 252 seconds]
Cory88 has joined #bitcoin-core-dev
Cory48 has quit [Ping timeout: 272 seconds]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
durandal_ has quit [Ping timeout: 240 seconds]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
durandal_ has joined #bitcoin-core-dev
sbddesign has quit [Remote host closed the connection]
<bitcoin-git> [bitcoin] achow101 pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/c0219f6beaa0...b0b65336e761
<bitcoin-git> bitcoin/master 0bf6139 Pieter Wuille: p2p: Avoid an IsAncestorOfBestHeaderOrTip call
<bitcoin-git> bitcoin/master 4066bfe Daniela Brozzoni: refactor: Compute work from headers without CBlockIndex
<bitcoin-git> bitcoin/master 4568652 Daniela Brozzoni: refactor: Use std::span in HasValidProofOfWork
<bitcoin-git> [bitcoin] achow101 merged pull request #32740: refactor: Header sync optimisations & simplifications (master...upforgrabs/25968) https://github.com/bitcoin/bitcoin/pull/32740
Chris_Stewart_5 has joined #bitcoin-core-dev
mudsip has joined #bitcoin-core-dev
mudsip has quit [Client Quit]
<instagibbs> sipa have you given any thought to having some logging when txgraph reports a non-optimal graph (say after a DoWork) to track if it happens. I guess what would be useful for diagnostics?
<sipa> instagibbs: i hadn't really thought about that, but for debugging that seems useful
<sipa> not as a default log level though
<instagibbs> right, mempool topic only
<instagibbs> topic, or label, whatever we call them
Cory88 has quit [Quit: Client closed]
<instagibbs> For the instance in Apply() I think it could make sense just to say it ended up being non-optimal, and based on how many times you see this log you along with other mempool messages can probably reconstruct a cluster and reason about how much time was spent?
Cory88 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] Niharikajakkula opened pull request #34289: Add functional test for getnetworkinfo RPC command (master...add-getnetworkinfo-test) https://github.com/bitcoin/bitcoin/pull/34289
<bitcoin-git> [bitcoin] DrahtBot closed pull request #34289: Add functional test for getnetworkinfo RPC command (master...add-getnetworkinfo-test) https://github.com/bitcoin/bitcoin/pull/34289
<bitcoin-git> [bitcoin] Niharikajakkula opened pull request #34290: Add functional test for getnetworkinfo RPC command (master...add-getnetworkinfo-test) https://github.com/bitcoin/bitcoin/pull/34290
<bitcoin-git> [bitcoin] DrahtBot closed pull request #34290: Add functional test for getnetworkinfo RPC command (master...add-getnetworkinfo-test) https://github.com/bitcoin/bitcoin/pull/34290
durandal_ has quit [Ping timeout: 240 seconds]
bugs_ has quit [Quit: Leaving]
<bitcoin-git> [bitcoin] Niharikajakkula opened pull request #34291: Add functional test for getnetworkinfo RPC command (master...add-getnetworkinfo-test) https://github.com/bitcoin/bitcoin/pull/34291
<instagibbs> could also easily query done-ness in an RPC with a DoWork(0)...
<bitcoin-git> [bitcoin] DrahtBot closed pull request #34291: Add functional test for getnetworkinfo RPC command (master...add-getnetworkinfo-test) https://github.com/bitcoin/bitcoin/pull/34291
<bitcoin-git> [bitcoin] Niharikajakkula opened pull request #34292: Add functional test for getnetworkinfo RPC command (master...add-getnetworkinfo-test) https://github.com/bitcoin/bitcoin/pull/34292
<bitcoin-git> [bitcoin] DrahtBot closed pull request #34292: Add functional test for getnetworkinfo RPC command (master...add-getnetworkinfo-test) https://github.com/bitcoin/bitcoin/pull/34292
<instagibbs> sigh
<sipa> ?
<sipa> txgraph tracks whether clusters are optimal too, so it could expose it, making it RPC-queryable?
<instagibbs> sighing at the spam not you
<instagibbs> yeah I think DoWork(0) is literally this
<instagibbs> in round about way
durandal_ has joined #bitcoin-core-dev
<instagibbs> (if we know were not oversized which we should not be at call sites we have)
<sipa> ah right, but DoWork() doesn't tell you which cluster is suboptimal
<instagibbs> true, knowing which one then being able to query it would be nice
<instagibbs> vs reconstructing from logs and data mining
jonatack has joined #bitcoin-core-dev
ozdeadman has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] luke-jr opened pull request #34293: Bugfix: net_processing: Restore missing comma between peer and peeraddr in "receive version message" (master...fix_vermsg_missing_comma) https://github.com/bitcoin/bitcoin/pull/34293
deadmanoz has quit [Ping timeout: 260 seconds]
andrewtoth has quit [Remote host closed the connection]
andrewtoth has joined #bitcoin-core-dev
conman has quit [Remote host closed the connection]
Guest77 has joined #bitcoin-core-dev
timbo_xyz has quit [Ping timeout: 252 seconds]
Guest77 has quit [Client Quit]
<bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b0b65336e761...cd0959ce9b7c
<bitcoin-git> bitcoin/master 9b57c8d brunoerg: test: fix feature_pruning when built without wallet
<bitcoin-git> bitcoin/master 8fb5e5f brunoerg: test: check wallet rescan properly in feature_pruning
<bitcoin-git> bitcoin/master cd0959c Ava Chow: Merge bitcoin/bitcoin#34185: test: fix `feature_pruning` when built withou...
<bitcoin-git> [bitcoin] achow101 merged pull request #34185: test: fix `feature_pruning` when built without wallet (master...2025-12-test-pruning-wout-wallet) https://github.com/bitcoin/bitcoin/pull/34185
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
timbo_xyz has joined #bitcoin-core-dev
Cory90 has joined #bitcoin-core-dev
___nick___ has quit [Ping timeout: 256 seconds]
timbo_xyz has quit [Ping timeout: 252 seconds]
Cory88 has quit [Ping timeout: 272 seconds]
jadi has quit [Quit: WeeChat 4.8.1]
andrewtoth_ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] billymcbip opened pull request #34294: test: Remove redundant STRICTENC flag from script_tests (master...strictenc) https://github.com/bitcoin/bitcoin/pull/34294
andrewtoth has quit [Ping timeout: 252 seconds]
Holz has quit [Remote host closed the connection]