<bitcoin-git>
[bitcoin] kevkevinpal opened pull request #35329: refactor: use NodeClock for m_headers_sync_timeout (master...refactor-m_headers_sync_timeout) https://github.com/bitcoin/bitcoin/pull/35329
l0rinc has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake closed pull request #35329: refactor: use NodeClock for m_headers_sync_timeout (master...refactor-m_headers_sync_timeout) https://github.com/bitcoin/bitcoin/pull/35329
<darosior>
I spent some time trying to adapt them to be BIP 54 compatible, but i think i'll just disable BIP 54 for this test until i better understand how to properly re-generate them
smartin has quit [Remote host closed the connection]
smartin has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] darosior opened pull request #35335: Make deployment configuration available outside of regtest in unit tests (master...2605_more_deployment_config) https://github.com/bitcoin/bitcoin/pull/35335
frankomosh has quit [Quit: Client closed]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
<sedited>
darosior, it's a regtest chain with a few silent payment transactions. I think we should re-generate it no matter what, to add some more interesting data.
eugenesiegel has joined #bitcoin-core-dev
<sedited>
maybe we can use rpc_getblockstats's --gen-test-data?
frankomosh has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
<darosior>
Ok, i'll have a look into this then. Unsure whether rpc_getblockstats would be sufficient though, it's only creating 4 transactions and 1 block. I'll take a look at other transaction heavy functional tests we have, or possibly that from other projects.
frankomosh has quit [Quit: Client closed]
l0rinc has joined #bitcoin-core-dev
dzxzg has joined #bitcoin-core-dev
twistedline has quit [Ping timeout: 272 seconds]
twistedline_ has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] l0rinc closed pull request #35173: util: shorten thread names to avoid Linux truncation (master...l0rinc/thread-name-truncation) https://github.com/bitcoin/bitcoin/pull/35173
<bitcoin-git>
[bitcoin] l0rinc reopened pull request #35173: util: shorten thread names to avoid Linux truncation (master...l0rinc/thread-name-truncation) https://github.com/bitcoin/bitcoin/pull/35173
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
twistedline_ has quit [Ping timeout: 256 seconds]
twistedline has joined #bitcoin-core-dev
twistedline_ has joined #bitcoin-core-dev
twistedline has quit [Ping timeout: 276 seconds]
<darosior>
One CI job on #35335 hit a 404 on some Windows related download. Can someone with permissions restart it?
<corebot>
https://github.com/bitcoin/bitcoin/issues/35335 | Make deployment configuration available outside of regtest in unit tests by darosior · Pull Request #35335 · bitcoin/bitcoin · GitHub
<darosior>
Sigh.. it seems some of the checks rely on the specific hardcoded blocks.
<bitcoin-git>
[bitcoin] fernandguil opened pull request #35337: doc: add feature deprecation and removal process to developer notes (master...doc/deprecation-removal-process-v2) https://github.com/bitcoin/bitcoin/pull/35337
dzxzg has quit [Quit: Konversation terminated!]
dzxzg has joined #bitcoin-core-dev
eugenesiegel has quit [Ping timeout: 245 seconds]
<bitcoin-git>
[bitcoin] darosior opened pull request #35338: qa: regenerate hardcoded regtest chain for kernel lib unit tests (master...2605_regenerate_hardcoded_regtest_chain) https://github.com/bitcoin/bitcoin/pull/35338
twistedline has quit [Ping timeout: 265 seconds]
twistedline has joined #bitcoin-core-dev
eugenesiegel has joined #bitcoin-core-dev
twistedline has quit [Ping timeout: 252 seconds]
twistedline has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
bugs_ has quit [Quit: Leaving]
eugenesiegel has quit [Ping timeout: 245 seconds]
dzxzg has quit [Quit: Konversation terminated!]
dzxzg has joined #bitcoin-core-dev
dzxzg has quit [Quit: Konversation terminated!]
dzxzg has joined #bitcoin-core-dev
smartin has quit [Remote host closed the connection]