bitcoinninjatest has quit [Ping timeout: 244 seconds]
bitcoin-git has quit [Ping timeout: 267 seconds]
BlueMatt[m] has quit [Ping timeout: 267 seconds]
Sjors[m] has quit [Ping timeout: 246 seconds]
stratospher[m]1 has quit [Ping timeout: 246 seconds]
pinheadmz[m] has quit [Ping timeout: 259 seconds]
laanwj has quit [Ping timeout: 259 seconds]
sr_gi[m] has quit [Ping timeout: 259 seconds]
b10c[m] has quit [Ping timeout: 259 seconds]
BlueMattMtrxBot has quit [Ping timeout: 259 seconds]
memset_ has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
b10c has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
sr_gi[m] has joined #bitcoin-core-dev
BlueMattMtrxBot has joined #bitcoin-core-dev
b10c[m] has joined #bitcoin-core-dev
Sjors[m] has joined #bitcoin-core-dev
stratospher[m]1 has joined #bitcoin-core-dev
BlueMatt[m] has joined #bitcoin-core-dev
bitcoinninjatest has joined #bitcoin-core-dev
laanwj has joined #bitcoin-core-dev
pinheadmz[m] has joined #bitcoin-core-dev
memset_ has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
afiore has quit [Ping timeout: 253 seconds]
andrewtoth_ has joined #bitcoin-core-dev
andrewtoth has quit [Remote host closed the connection]
bitdex has joined #bitcoin-core-dev
synexic has quit [Quit: .]
synexic has joined #bitcoin-core-dev
bitdex has quit [Remote host closed the connection]
bitdex has joined #bitcoin-core-dev
svanstaa has joined #bitcoin-core-dev
svanstaa_ has quit [Ping timeout: 247 seconds]
_andrewtoth_ has joined #bitcoin-core-dev
cmirror has joined #bitcoin-core-dev
andrewtoth_ has quit [Ping timeout: 257 seconds]
greypw1495085720 has quit [Ping timeout: 257 seconds]
additivefree has joined #bitcoin-core-dev
bitdex has quit [Ping timeout: 246 seconds]
bitdex has joined #bitcoin-core-dev
yuvicc has quit [Quit: Ping timeout (120 seconds)]
yuvicc has joined #bitcoin-core-dev
hacker4web3bitco has joined #bitcoin-core-dev
_andrewtoth_ has quit [Remote host closed the connection]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
memset_ has joined #bitcoin-core-dev
_andrewtoth_ has joined #bitcoin-core-dev
memset_ has quit [Remote host closed the connection]
memset has quit [Ping timeout: 251 seconds]
memset has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
purpleKarrot has joined #bitcoin-core-dev
memset has joined #bitcoin-core-dev
sliv3r__ has quit [Read error: Connection reset by peer]
sliv3r__ has joined #bitcoin-core-dev
jerryf_ has joined #bitcoin-core-dev
jerryf has quit [Remote host closed the connection]
jonatack has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
_andrewtoth_ has quit [Remote host closed the connection]
andrewtoth_ has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 265 seconds]
jonatack has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 247 seconds]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
purpleKarrot has quit [Quit: purpleKarrot]
purpleKarrot has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 248 seconds]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
andrewtoth_ has quit [Remote host closed the connection]
bitdex has quit [Remote host closed the connection]
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
andrewtoth_ has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
purpleKarrot has quit [Quit: purpleKarrot]
jonatack has quit [Ping timeout: 247 seconds]
c1ph3w-lib has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 258 seconds]
Guyver2 has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
smartin has joined #bitcoin-core-dev
hacker4web3bitco has quit [Remote host closed the connection]
hacker4web3bitco has joined #bitcoin-core-dev
purpleKarrot has joined #bitcoin-core-dev
vasild has quit [Ping timeout: 272 seconds]
andrewtoth_ has quit [Remote host closed the connection]
andrewtoth_ has joined #bitcoin-core-dev
yuvicc has quit [Quit: Ping timeout (120 seconds)]
yuvicc has joined #bitcoin-core-dev
Zenton has quit [Ping timeout: 252 seconds]
yuvicc has quit [Quit: Ping timeout (120 seconds)]
yuvicc has joined #bitcoin-core-dev
Zenton has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 249 seconds]
jonatack has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 247 seconds]
smartin has quit [Remote host closed the connection]
purpleKarrot has quit [Quit: purpleKarrot]
l0rinc has joined #bitcoin-core-dev
sr_gi[m] has quit [Ping timeout: 245 seconds]
b10c has quit [Ping timeout: 268 seconds]
pinheadmz[m] has quit [Ping timeout: 254 seconds]
bitcoinninjatest has quit [Ping timeout: 254 seconds]
bitcoin-git has quit [Ping timeout: 254 seconds]
stratospher[m]1 has quit [Ping timeout: 245 seconds]
b10c[m] has quit [Ping timeout: 245 seconds]
BlueMattMtrxBot has quit [Ping timeout: 273 seconds]
laanwj has quit [Ping timeout: 249 seconds]
BlueMatt[m] has quit [Ping timeout: 249 seconds]
Sjors[m] has quit [Ping timeout: 260 seconds]
enochazariah has joined #bitcoin-core-dev
bitcoinninjatest has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
b10c has joined #bitcoin-core-dev
sr_gi[m] has joined #bitcoin-core-dev
BlueMatt[m] has joined #bitcoin-core-dev
laanwj has joined #bitcoin-core-dev
Sjors[m] has joined #bitcoin-core-dev
BlueMattMtrxBot has joined #bitcoin-core-dev
b10c[m] has joined #bitcoin-core-dev
stratospher[m]1 has joined #bitcoin-core-dev
purpleKarrot has joined #bitcoin-core-dev
pinheadmz[m] has joined #bitcoin-core-dev
vasild has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
enochazariah__ has joined #bitcoin-core-dev
dviola has quit [Ping timeout: 262 seconds]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
sliv3r__ has quit [Ping timeout: 254 seconds]
memset has quit [Remote host closed the connection]
sliv3r__ has joined #bitcoin-core-dev
diego has joined #bitcoin-core-dev
diego is now known as Guest4808
memset has joined #bitcoin-core-dev
sliv3r__ has quit [Ping timeout: 241 seconds]
sliv3r__ has joined #bitcoin-core-dev
<fanquake>
@willcl-ark: could you add a Ralph pass that looks for dead/unused code in PRs (scoped to lines touched). Either introduced dead, or made dead by the diff.
l0rinc has quit [Quit: l0rinc]
bcdarc_ has joined #bitcoin-core-dev
bcdarc has quit [Ping timeout: 260 seconds]
sdaftuar has joined #bitcoin-core-dev
enochazariah has quit [Ping timeout: 261 seconds]
purpleKarrot has joined #bitcoin-core-dev
purpleKarrot has quit [Client Quit]
purpleKarrot has joined #bitcoin-core-dev
purpleKarrot has quit [Client Quit]
enochazariah has joined #bitcoin-core-dev
<willcl-ark>
Sure, I can add that
purpleKarrot has joined #bitcoin-core-dev
BlueMattMtrxBot has quit [Ping timeout: 245 seconds]
Sjors[m] has quit [Ping timeout: 245 seconds]
purpleKarrot has quit [Client Quit]
b10c[m] has quit [Ping timeout: 264 seconds]
stratospher[m]1 has quit [Ping timeout: 242 seconds]
bitcoinninjatest has quit [Ping timeout: 254 seconds]
laanwj has quit [Ping timeout: 258 seconds]
sr_gi[m] has quit [Ping timeout: 258 seconds]
b10c has quit [Ping timeout: 258 seconds]
bitcoin-git has quit [Ping timeout: 246 seconds]
pinheadmz[m] has quit [Ping timeout: 265 seconds]
BlueMatt[m] has quit [Ping timeout: 248 seconds]
<brunoerg>
Isn't there some static tool that could do this?
pinheadmz[m] has joined #bitcoin-core-dev
purpleKarrot has joined #bitcoin-core-dev
bitcoinninjatest has joined #bitcoin-core-dev
purpleKarrot has quit [Client Quit]
Guyver2 has left #bitcoin-core-dev [Closing Window]
purpleKarrot has joined #bitcoin-core-dev
<willcl-ark>
yeah I think you can use cppcheck and various clang tools, but I don't think there's any single "perfect" tool (might be mistaken here)
stratospher[m]1 has joined #bitcoin-core-dev
b10c[m] has joined #bitcoin-core-dev
<fanquake>
Yea there's all sorts of tools, that will catch some subset of issues
bitcoin-git has joined #bitcoin-core-dev
Sjors[m] has joined #bitcoin-core-dev
BlueMattMtrxBot has joined #bitcoin-core-dev
b10c has joined #bitcoin-core-dev
memset_ has joined #bitcoin-core-dev
BlueMatt[m] has joined #bitcoin-core-dev
laanwj has joined #bitcoin-core-dev
memset_ has quit [Remote host closed the connection]
sr_gi[m] has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 254 seconds]
memset has joined #bitcoin-core-dev
enochazariah has quit [Ping timeout: 259 seconds]
bcdarc has joined #bitcoin-core-dev
sdaftuar has joined #bitcoin-core-dev
memset_ has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
bcdarc has joined #bitcoin-core-dev
bcdarc has joined #bitcoin-core-dev
skr0 has joined #bitcoin-core-dev
skr0 has quit [Remote host closed the connection]
hacker4web3bitco has quit [Remote host closed the connection]
hacker4web3bitco has joined #bitcoin-core-dev
purpleKarrot has quit [Quit: purpleKarrot]
hacker4web3bitco has quit [Remote host closed the connection]
hacker4web3bitco has joined #bitcoin-core-dev
hodlinator has quit [Quit: hodlinator]
hodlinator has joined #bitcoin-core-dev
enochazariah has joined #bitcoin-core-dev
purpleKarrot has joined #bitcoin-core-dev
achow101_ is now known as achow101
<achow101>
bot dead, 32.0 code signatures are up
eugenesiegel has joined #bitcoin-core-dev
enochaza1 has joined #bitcoin-core-dev
enochazariah has quit [Ping timeout: 256 seconds]
enochaza1 has quit [Ping timeout: 262 seconds]
jon_atack has quit [Ping timeout: 270 seconds]
l0rinc has joined #bitcoin-core-dev
purpleKarrot has quit [Quit: purpleKarrot]
enochazariah has joined #bitcoin-core-dev
enochazariah has quit [Ping timeout: 262 seconds]
jonatack has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
achow101 has quit [Quit: Bye]
<darosior>
stickies-v: taking a shot at rewording the easy-to-find vulns policy
achow101 has joined #bitcoin-core-dev
eugenesiegel has quit [Ping timeout: 267 seconds]
enochazariah has joined #bitcoin-core-dev
purpleKarrot has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
jerryf_ has quit [Remote host closed the connection]
TheRec_ has joined #bitcoin-core-dev
jerryf has joined #bitcoin-core-dev
TheRec has quit [Ping timeout: 271 seconds]
jerryf has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
Sjors[m] has quit [Ping timeout: 246 seconds]
bitcoinninjatest has quit [Ping timeout: 246 seconds]
pinheadmz[m] has quit [Ping timeout: 246 seconds]
bitcoin-git has quit [Ping timeout: 260 seconds]
BlueMatt[m] has quit [Ping timeout: 242 seconds]
b10c[m] has quit [Ping timeout: 242 seconds]
stratospher[m]1 has quit [Ping timeout: 242 seconds]
b10c has quit [Ping timeout: 248 seconds]
laanwj has quit [Ping timeout: 258 seconds]
BlueMattMtrxBot has quit [Ping timeout: 251 seconds]
sr_gi[m] has quit [Ping timeout: 244 seconds]
PaperSword has quit [Remote host closed the connection]
Guest89 has joined #bitcoin-core-dev
macgyver13 has joined #bitcoin-core-dev
eugenesiegel has joined #bitcoin-core-dev
Guest89 has quit [Client Quit]
bitdex has quit [Quit: = ""]
Guest64 has joined #bitcoin-core-dev
bugs_ has joined #bitcoin-core-dev
Guest91820 has joined #bitcoin-core-dev
Guest64 has quit [Ping timeout: 242 seconds]
Guest91820 has quit [Ping timeout: 270 seconds]
c1ph3w-lib has quit [Quit: Konversation terminated!]
jerryf has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
b10c has joined #bitcoin-core-dev
laanwj has joined #bitcoin-core-dev
BlueMattMtrxBot has joined #bitcoin-core-dev
Sjors[m] has joined #bitcoin-core-dev
pinheadmz[m] has joined #bitcoin-core-dev
bitcoinninjatest has joined #bitcoin-core-dev
sr_gi[m] has joined #bitcoin-core-dev
b10c[m] has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 253 seconds]
stratospher[m]1 has joined #bitcoin-core-dev
BlueMatt[m] has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
bugs_ has quit [Quit: Leaving]
PaperSword has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
viniciuscestarii has joined #bitcoin-core-dev
<darosior>
big meeting incoming, as i see PRs related to last week's Coredev are being open?
purpleKarrot has quit [Quit: purpleKarrot]
tigerMafia has joined #bitcoin-core-dev
<yancy>
re dead code, I've a PR that's been lying around a while that removes dead code from the fuzzer #36071. Its only been reviewed by brunoerg. A tool that finds such dead code enlarge would be great.
<achow101>
would like for my topic to be first, so I can go to sleep
<brunoerg>
Hi
<stickies-v>
we have one pre-proposed meeting topic for this week, any others to add?
<enochazariah>
hi
<darosior>
9AM bedtime?
Murch[m] has joined #bitcoin-core-dev
Murch[m] has joined #bitcoin-core-dev
<tigerMafia>
hello world
<instagibbs>
stickies-v I'd like to speak briefly about #36608 later
<achow101>
i'm still in <redacted>, it's 1 am
<corebot>
https://github.com/bitcoin/bitcoin/issues/36608 | Reimplement private broadcast as node state-less jobs + package relay support by instagibbs · Pull Request #36608 · bitcoin/bitcoin · GitHub
<stickies-v>
achow101: sure, i'll take that one first after the WGs if that's okay
memset_ has quit [Remote host closed the connection]
<yancy>
hi
<achow101>
stickies-v: ok
<Murch[m]>
hi
<stickies-v>
instagibbs: will add it
<yancy>
s/lying/laying
<kanzure_>
hi
<stickies-v>
#topic Fuzzing WG Update (eugenesiegel, marcofleon)
memset has joined #bitcoin-core-dev
<marcofleon>
no update from me
<eugenesiegel>
currently just working on getting bedrock into shape so we can run fuzzamoto with it. some faults I added found some really minor database consistency issues
<stickies-v>
#topic QML GUI WG Update (johnny9dev)
<eugenesiegel>
like e.g. a node having a power loss at a super specific point during -reindex prevents the node from starting up again. should things like that be fixed?
<johnny9dev>
We got a lot of good feedback last week and we've started working through that.
<stickies-v>
oops sorry
<stickies-v>
#topic Fuzzing WG Update (eugenesiegel, marcofleon)
<eugenesiegel>
woops, too slow
<stickies-v>
eugenesiegel: if it's a loud failure, i wouldn't personally consider that worth spending a lot of energy or complexity on
memset has quit [Remote host closed the connection]
<yancy>
eugensiegel: might it also be OS disk corruption?
<stickies-v>
silent consensus failures/money losing behaviour is a different thing of course
<eugenesiegel>
I don't think it's a disk corruption issue, just a things not being persisted in the proper order/way. It wasn't clear to me what guarantees the codebase should have against all possible scenarios like that where there's no critical failure like consensus failure / money loss
<brunoerg>
perhaps it depends on how complex the fix would be?
memset has joined #bitcoin-core-dev
yuvicc has quit [Quit: Ping timeout (120 seconds)]
yuvicc has joined #bitcoin-core-dev
<eugenesiegel>
I think the fixes are pretty small. I don't think it's likely that anybody will run into these issues though
<eugenesiegel>
that's it from me though
<stickies-v>
#topic QML GUI WG Update (johnny9dev)
<johnny9dev>
As I mentioned were working on the feedback from last week.
<johnny9dev>
We've got a pr to clarify storage choices during onboarding
<johnny9dev>
Priority is getting the staging branch ready
<johnny9dev>
I am increasingly interested in making a pruned wallet setup working and have started looking into the txindex and compact block filters
<darosior>
You mean pruned rescans?
<sipa>
hi
<johnny9dev>
Yeah pruned rescans
<johnny9dev>
Block retrieval
<johnny9dev>
Anyway I think that will become a high priority for the Qml project once the staging branch is settled
<johnny9dev>
That's all for now.
<darosior>
eugenesiegel: worth at least opening an issue for those IMO, may be a symptom of a bug that could open up more serious inconsistencies down the road. As far as i know we should always be able to recover from a crash?
<eugenesiegel>
darosior: (y)
<Murch[m]>
We chatted a bit about potential release timeline for the new GUI recently. There was an argument that such a big change should be merged very early in a release cycle, right after branch-off, and that it therefore should only be considered for v34. However, I’d like to submit that it sounds like the new GUI has significantly better testing infrastructure, way more eyes, and it feels somewhat uncomfortable to release with the old GUI in
<Murch[m]>
the time of daily RCEs when hardly anyone is actually looking at the old GUI.
<Murch[m]>
Maybe we should talk more about whether we should try to get the new GUI into v33.
<hebasto>
it seems premature until the staging branch is ready
flooded has joined #bitcoin-core-dev
<johnny9dev>
My current view on it is that we'll have the PR by the end of the year. Likely end of November or early December if I had to guess right now.
<stickies-v>
i'm not sure merging a huge amount of new code is necessarily safer RCE/vulnerability wise, so I don't think we should feel time pressure because of that
<Murch[m]>
Sure, let’s revisit when the staging branch is available
<hebasto>
^ agree
<stickies-v>
#topic QA WG Update (brunoerg)
<brunoerg>
no updates this week
<cfields>
hi
<stickies-v>
alright, that's all for the WG updates then
<stickies-v>
#topic another windows code signer (achow101)
<achow101>
right now windows code signing is done by only me, which is a single point of failure that i would prefer we did not have. if anyone is interested in being a code signer, shoot me a message
<achow101>
needs to be someone who currently builds, or will commmit to building, all releases and release candidates shortly after tagging
<achow101>
that's all
<stickies-v>
#topic Reimplement private broadcast as node state-less jobs + package relay support (#36608) (instagibbs)
<corebot>
https://github.com/bitcoin/bitcoin/issues/36608 | Reimplement private broadcast as node state-less jobs + package relay support by instagibbs · Pull Request #36608 · bitcoin/bitcoin · GitHub
<instagibbs>
Hi, I'd like to share something I've been working on for the last few months.
<instagibbs>
I've been working on a node state-less variant of private broadcast, and I believe
<instagibbs>
it's mature enough to be considered for replacement for v33 release. It makes
<instagibbs>
some opinionated decisions in order to make reasoning about the afforded privacy easier.
<instagibbs>
It's meant to be a feature swap out, still using the same `sendrawtransaction` path,
<instagibbs>
and at the end has 1p1c package relay support tacked on for good measure. Also
<instagibbs>
includes a stand-alone tool that is a thin wrapper around the same job.
<instagibbs>
sorry for breaks
<instagibbs>
A bit of sticker shock but: Roughly +4,600 net in logic loc, and *all* outside of consensus critical
<instagibbs>
code (all in-master net_processing stuff for private broadcast gone), and the rest is tests and then documentation
<instagibbs>
What I'm looking for in the short-term:
<instagibbs>
1. High level spec discussions / concept and approach (n)ACKs, and *a general project buy-in that we want this to happen by v33*. Now is the time to fix it fundamentally.
<instagibbs>
2. Do we care about an individual tool variant, which is currently included? Could be folded into another tool like bitcoin-util, or simply removed. The underlying architecture remains, whatever we choose, but could save some boilerplate and move-only commits if removed.
<instagibbs>
3. Should this be 2 PRs: one PR to swap everything out, and then one follow-up PR for package relay support? More? less?
<instagibbs>
that's all, thanks
nanotube has quit [Ping timeout: 266 seconds]
<andrewtoth_>
I haven't looked at this in depth yet, but I'm not sure a 17k line PR is realistic to get in for v33?
<andrewtoth_>
I left some conceptual feedback on the previous branch. It doesn't seem like any of my concerns or suggestions were addressed?
<instagibbs>
I responded to all your comments, AFAIK
<cfields>
instagibbs: I think that has a lot of overlap with my multi-process p2p work which may be worth reviving and teaming up on. I'll take a look and bug you out-of-band.
<instagibbs>
and to be clear, it's ~4.6k loc net of logic, rest is tests. I can delete tests but I think it should be motivated
<stickies-v>
yeah i think this is a big lift for a single feature, but if it goes hand in hand with a better architecture, that would be nice
<instagibbs>
right, maybe it's two releases, but I don't think it has to be, it's removal of risk imo
<darosior>
I agree with the approach: we should fix the node state leaks structurally, and then potentially consider carving out some exceptions if necessary to improve UX, instead of the opposite
<andrewtoth_>
Can we better quantify the risks this is addressing? There were several fixes for private broadcast in v32. What are the remaining gaps that we are doing this work for?
<instagibbs>
I'm not going to list them all, and I think missing hte point
<instagibbs>
The risks is sharing node state, which seeps out in dozens of ways
<darosior>
We can never guarantee perfect privacy or anonymity, but if the point of private broadcast is to provide *any* limited guarantee in adversarial conditions, separating from the node's state is a requirement. If the point isn't to provide such limited guarantees in adversarial conditions, i don't know what we are doing.
ozdeadman has joined #bitcoin-core-dev
deadmanoz has quit [Ping timeout: 263 seconds]
<instagibbs>
cfields cool let's chat
<andrewtoth_>
For asking reviewers to review this work it would be good to be more forthcoming on the benefits of the work. We have private broadcast marked experimental now, and we have softened the guarantees we make about it. What are the remaining gaps in light of that?
<darosior>
The remaining gap is that there is little point in a feature that protects a user's privacy if nobody cares to attack them in the first place
<andrewtoth_>
linking lion is attacking all users
<darosior>
Sure, and?
<instagibbs>
I'd say the most interesting thing to debate about a design is the addrman-less design, since addrman is attacker influenced quite heavily, and there's tradeoffs in that direction
<andrewtoth_>
using private broadcast protects user's privacy against linking lion today
<instagibbs>
but certainly not limited to that
<darosior>
This is akin to saying linking lion isn't using bip324 connections today, so let's switch to using exclusively that, and call it "private" even though it doesn't offer any privacy
<andrewtoth_>
no i don't think that's a fair comparison
<instagibbs>
We can do better, let's do better.
<andrewtoth_>
default broadcast trivially exposes the transaction origin, even with bip324.
<darosior>
Current private broadcast can expose it too, if someone cares enough to attack
<instagibbs>
Ok, I don't want to hold people here, we can continue debating offline
<andrewtoth_>
i'm not sure it's that trivial darosior
<darosior>
I don't say it's exactly trivial, but i also don't think it's reasonable for a project like ours to be offering feature branded as privacy that don't hold up to a certain bar
<darosior>
Regarding your questions, instagibbs
<darosior>
For 2) i don't see why we'd need a new tool. bitcoin-util seems fine for this. A separate tool seems like a minor cost for a potentially useful feature (broadcast without having to fire up node), and is also useful as a canary against reintroducing state
Guest4808 has left #bitcoin-core-dev [#bitcoin-core-dev]
<instagibbs>
I started with the tool, to make sure I wasn't re-adding node state to jobs, then took that library and reused it inside the node.
<instagibbs>
so kind of lines up
<darosior>
For 3) i think package relay can go in a followup as an improvement, but i don't think the swap out should be broken down, to make sure we don't end up with two implementations of the same feature in master
dviola has joined #bitcoin-core-dev
<darosior>
No strong opinion though. Thanks for working on this