achow101 changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 16:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
flooded has quit [Ping timeout: 246 seconds]
l0rinc has joined #bitcoin-core-dev
nemo60 has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
nemo60 has quit [Client Quit]
brunoerg_ has quit [Remote host closed the connection]
chriszeng1010 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
tester has joined #bitcoin-core-dev
chriszeng1010 has quit [Changing host]
chriszeng1010 has joined #bitcoin-core-dev
<chriszeng1010> I'm a new contributor looking to get started. What areas of the codebase could use help right now?
<chriszeng1010> Would greatly appreciate it if someone can point me to the right direction.
<chriszeng1010> Thank~~..
l0rinc has joined #bitcoin-core-dev
tester has quit [Quit: Client closed]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
chriszeng1010 has quit [Ping timeout: 240 seconds]
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d58e0ad0a42e...d14293c3a929
<bitcoin-git> bitcoin/master fa71c6e MarcoFalke: ci: Avoid intermittent Windows generate download failures
<bitcoin-git> bitcoin/master d14293c merge-script: Merge bitcoin/bitcoin#34859: ci: Retry on intermittent Windows generate do...
<bitcoin-git> [bitcoin] fanquake merged pull request #34859: ci: Retry on intermittent Windows generate download failures (master...2603-ci-windows-dowload-fail) https://github.com/bitcoin/bitcoin/pull/34859
l0rinc has quit [Quit: l0rinc]
brunoerg has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d14293c3a929...b425a81f0706
<bitcoin-git> bitcoin/master 658e68f Hennadii Stepanov: scripted-diff: Rename `WAIT_TIMEOUT` to `TEST_WAIT_TIMEOUT`
<bitcoin-git> bitcoin/master b425a81 merge-script: Merge bitcoin/bitcoin#34868: scripted-diff: Rename `WAIT_TIMEOUT` to `TEST...
<bitcoin-git> [bitcoin] fanquake merged pull request #34868: scripted-diff: Rename `WAIT_TIMEOUT` to `TEST_WAIT_TIMEOUT` (master...260319-win-macro) https://github.com/bitcoin/bitcoin/pull/34868
brunoerg has quit [Ping timeout: 244 seconds]
abubakarsadiq has quit [Quit: Connection closed for inactivity]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 276 seconds]
brunoerg has joined #bitcoin-core-dev
infernix has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
Guest84 has joined #bitcoin-core-dev
Guest84 has quit [Client Quit]
Guest84 has joined #bitcoin-core-dev
Guest84 has quit [Client Quit]
l0rinc has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 276 seconds]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
Guest32 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b425a81f0706...f80bf5128d79
<bitcoin-git> bitcoin/master b14f2c7 kevkevinpal: tests: applied PYTHON_GIL to the env for every test
<bitcoin-git> bitcoin/master f80bf51 merge-script: Merge bitcoin/bitcoin#34869: tests: applied PYTHON_GIL to the env for ever...
<bitcoin-git> [bitcoin] fanquake merged pull request #34869: tests: applied PYTHON_GIL to the env for every test (master...usePythonGILInTests) https://github.com/bitcoin/bitcoin/pull/34869
pablomartin has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
Guest32 has quit [Quit: Client closed]
aleggg has quit [Ping timeout: 268 seconds]
aleggg has joined #bitcoin-core-dev
<dzxzg> chriszeng1010: New contributors are very welcome; There are many many ways to answer your question, but I would start here: https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md; sadly there are not any bitcoin core review clubs scheduled at the moment but those are also a great way to get started, the pr review club website also links to some great resources: https://bitcoincore.reviews/#other-resources-for-new-contributors
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
luke-jr_ has quit [Ping timeout: 264 seconds]
cmirror has quit [Remote host closed the connection]
brunoerg has quit [Ping timeout: 245 seconds]
cmirror has joined #bitcoin-core-dev
corebot has quit [Remote host closed the connection]
corebot has joined #bitcoin-core-dev
corebot has quit [Remote host closed the connection]
corebot has joined #bitcoin-core-dev
<achow101> #proposedtopic Ignore. just testing a thing
cotsuka has quit [Read error: Connection reset by peer]
<achow101> #proposedmeetingtopic Ignore. just testing a thing
<achow101> I've updated corebot to gather proposed meeting topics at https://achow101.com/ircmeetings/bitcoin-core-dev.proposedmeetingtopics.txt It will detect if you use #proposedmeetingtopic or #proposedtopic, and it should stop saying unknown command when you do that in a meeting. also it updates the file in real time.
cotsuka has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] Mccalabrese opened pull request #34873: net: fix 1970 epoch stale tx bug in private_broadcast - Issue #34862 (master...fix/private-broadcast-epoch) https://github.com/bitcoin/bitcoin/pull/34873
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
<l0rinc> chriszeng1010 you can help by reviewing existing changes deeply. Usually the best way to review a PR is by recreating it locally step by step, that way you're forced to understand it thoroughly and can comment meaningfully.
kevkevin has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
jkczyz has joined #bitcoin-core-dev
real_or_random has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 248 seconds]
<bitcoin-git> [bitcoin] pzafonte closed pull request #34843: kernel: add block locator to the C API (master...kernel-api-block-locator) https://github.com/bitcoin/bitcoin/pull/34843
vasild has quit [Ping timeout: 258 seconds]
vasild has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
cotsuka has quit [Read error: Connection reset by peer]
brunoerg has joined #bitcoin-core-dev
cotsuka has joined #bitcoin-core-dev
pablomartin has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 245 seconds]
<bitcoin-git> [bitcoin] l0rinc opened pull request #34875: refactor: separate deferred script check collection from `CheckInputScripts` (master...l0rinc/checkinputscripts-split) https://github.com/bitcoin/bitcoin/pull/34875
conman has quit [Ping timeout: 264 seconds]
kevkevin has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
conman has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
PaperSword has quit [Quit: PaperSword]
brunoerg has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake closed pull request #34871: test: remove unused `NodeClockContext` default ctor (master...test-nodeclockcontext-avoid-system-time) https://github.com/bitcoin/bitcoin/pull/34871
Guest58 has joined #bitcoin-core-dev
Guest58 has quit [Client Quit]
<bitcoin-git> [bitcoin] optout21 closed pull request #34863: test: Clean shutdown in Socks5Server (CI fix) (master...socks5-close-fix) https://github.com/bitcoin/bitcoin/pull/34863
<bitcoin-git> [bitcoin] optout21 reopened pull request #34863: test: Clean shutdown in Socks5Server (CI fix) (master...socks5-close-fix) https://github.com/bitcoin/bitcoin/pull/34863
l0rinc has quit [Quit: l0rinc]
ghost43 has quit [Ping timeout: 258 seconds]
yonson has quit [Ping timeout: 268 seconds]
danielabrozzoni has joined #bitcoin-core-dev
ghost43 has joined #bitcoin-core-dev
yonson has joined #bitcoin-core-dev
Cory39 has quit [Quit: Client closed]
Cory39 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
Cory39 has quit [Quit: Client closed]
Cory39 has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 268 seconds]
edouardparis has quit [Ping timeout: 244 seconds]
edouardparis has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 269 seconds]
brunoerg has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 245 seconds]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] sedited pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/f80bf5128d79...6e295d8ad5ff
<bitcoin-git> bitcoin/master fa55723 MarcoFalke: move-only: Extract ProcessAddrs() helper
<bitcoin-git> bitcoin/master 3333c50 MarcoFalke: refactor: Use NodeClock::time_point for m_addr_token_timestamp
<bitcoin-git> bitcoin/master faaea78 MarcoFalke: refactor: Use current_time over redundant call to Now()
<bitcoin-git> [bitcoin] sedited merged pull request #34059: refactor: Use NodeClock::time_point for m_addr_token_timestamp (master...2512-net-less-GetTime) https://github.com/bitcoin/bitcoin/pull/34059
brunoerg has quit [Ping timeout: 245 seconds]
kevkevin has quit [Remote host closed the connection]
Guyver2 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 276 seconds]
kevkevin has joined #bitcoin-core-dev
aleggg has quit [Ping timeout: 268 seconds]
aleggg has joined #bitcoin-core-dev
moneyball_______ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
aleggg has quit [Ping timeout: 245 seconds]
aleggg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
Guyver2 has left #bitcoin-core-dev [Closing Window]
<bitcoin-git> [bitcoin] ekzyis opened pull request #34876: doc: Fix missing -B option for cmake in fuzzing quickstart guide (master...fix-fuzzing-quickstart-guide-missing-cmake-B-option) https://github.com/bitcoin/bitcoin/pull/34876
deadmanoz has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
cold has joined #bitcoin-core-dev
midnight has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
sliv3r__ has quit [Quit: ZNC 1.8.2+deb3.1+deb12u1 - https://znc.in]
sliv3r__ has joined #bitcoin-core-dev
umar has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
umar has quit [Client Quit]
brunoerg has joined #bitcoin-core-dev
maxedw has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
deadmanoz has quit [Ping timeout: 276 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 245 seconds]
brunoerg has joined #bitcoin-core-dev
aleggg has quit [Ping timeout: 255 seconds]
aleggg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
aleggg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] hebasto opened pull request #34877: guix: Remove `make-lld-wrapper` (master...260320-no-lld-wrapper) https://github.com/bitcoin/bitcoin/pull/34877
brunoerg has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev