achow101 changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 16:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
<bitcoin-git> [bitcoin] w0xlt opened pull request #35490: test: cover unused mempool space in coins cache limit (master...mempool-kernel-regression-tests) https://github.com/bitcoin/bitcoin/pull/35490
sliv3r__ has quit [Ping timeout: 245 seconds]
sliv3r__ has joined #bitcoin-core-dev
memset_ has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
<yancy> PaperSword, besides scp/ssh, some things could also be learned using tcpdump.
<yancy> Unless using V2 p2p protocol ;)
sliv3r__ has quit [Ping timeout: 252 seconds]
sliv3r__ has joined #bitcoin-core-dev
adil has joined #bitcoin-core-dev
luke-jr has quit [Ping timeout: 265 seconds]
luke-jr has joined #bitcoin-core-dev
adil has quit [Quit: adil]
adil has joined #bitcoin-core-dev
adil has quit [Client Quit]
memset_ has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
adil has joined #bitcoin-core-dev
adil has quit [Quit: adil]
bitdex has joined #bitcoin-core-dev
bitdex has quit [Remote host closed the connection]
bitdex has joined #bitcoin-core-dev
luke-jr has quit [Ping timeout: 248 seconds]
luke-jr has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
memset_ has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
bitdex has quit [Ping timeout: 245 seconds]
Kraig has joined #bitcoin-core-dev
Kraig has quit [Client Quit]
Kraig has joined #bitcoin-core-dev
Kraig has quit [Client Quit]
Kraig has joined #bitcoin-core-dev
Kraig has quit [Client Quit]
bitdex has joined #bitcoin-core-dev
nanotube has quit [Ping timeout: 272 seconds]
cman has joined #bitcoin-core-dev
conman has quit [Ping timeout: 246 seconds]
nanotube has joined #bitcoin-core-dev
svanstaa_ has quit [Ping timeout: 276 seconds]
svanstaa has joined #bitcoin-core-dev
Nebraskka has quit [Read error: Connection reset by peer]
Nebraskka has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] OSINTv96 opened pull request #35492: wallet: fail dump on incomplete writes (master...codex/wallet-dump-write-failure) https://github.com/bitcoin/bitcoin/pull/35492
memset_ has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] w0xlt opened pull request #35493: wallet, descriptor: Fix MuSig private key completeness checks on `importdescriptors` (master...descriptors-musig-import-privkey-completeness) https://github.com/bitcoin/bitcoin/pull/35493
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
smartin has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
Guyver2 has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
rszarka has joined #bitcoin-core-dev
luke-jr has quit [Remote host closed the connection]
robszarka has quit [Ping timeout: 248 seconds]
luke-jr has joined #bitcoin-core-dev
luke-jr has quit [Ping timeout: 256 seconds]
Guest76 has joined #bitcoin-core-dev
luke-jr has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] sedited pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/577999c2ce9c...9868e1bf651d
<bitcoin-git> bitcoin/master fba713a Hennadii Stepanov: scripted-diff: Rename UNIQUE_NAME to BITCOIN_UNIQUE_NAME
<bitcoin-git> bitcoin/master 9868e1b merge-script: Merge bitcoin/bitcoin#35487: scripted-diff: Rename UNIQUE_NAME to BITCOIN_...
<bitcoin-git> [bitcoin] sedited merged pull request #35487: scripted-diff: Rename UNIQUE_NAME to BITCOIN_UNIQUE_NAME (master...260608-win-macro) https://github.com/bitcoin/bitcoin/pull/35487
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
Guest76 has quit [Quit: Client closed]
memset has quit [Ping timeout: 245 seconds]
memset has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
<bitcoin-git> [bitcoin] hodlinator closed pull request #31723: qa: Facilitate debugging bitcoind inside functional tests (master...2024/06/wait_for_debugger) https://github.com/bitcoin/bitcoin/pull/31723
<fanquake> pinheadz: just tested a build, and didn't seem to have any issues
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9868e1bf651d...17ed7f506096
<bitcoin-git> bitcoin/master fa2afba MarcoFalke: p2p: Release m_peer_mutex early in InitiateTxBroadcastToAll
<bitcoin-git> bitcoin/master 17ed7f5 merge-script: Merge bitcoin/bitcoin#35297: p2p: Release m_peer_mutex early in InitiateTx...
<bitcoin-git> [bitcoin] fanquake merged pull request #35297: p2p: Release m_peer_mutex early in InitiateTxBroadcastToAll (master...2605-p2p-mutex-early) https://github.com/bitcoin/bitcoin/pull/35297
smartin2 has joined #bitcoin-core-dev
smartin has quit [Ping timeout: 272 seconds]
smartin2 is now known as smartin
abubakarsadiq has quit [Quit: Connection closed for inactivity]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
enochazariah has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
luke-jr has quit [Remote host closed the connection]
memset has quit [Remote host closed the connection]
luke-jr has joined #bitcoin-core-dev
memset has joined #bitcoin-core-dev
<pinheadmz> fanquake thanks i realized the issue was building fuzz on macos. i thought for sure i was setup for this already. used debian container instead
enochazariah has quit [Quit: Client closed]
deadmanoz has joined #bitcoin-core-dev
ozdeadman has quit [Ping timeout: 248 seconds]
<bitcoin-git> [bitcoin] sedited pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/17ed7f506096...543c00f47dd2
<bitcoin-git> bitcoin/master 6d47f7c fanquake: ci: use llvm 22.1.7
<bitcoin-git> bitcoin/master 087f02c fanquake: ci: skip libunwind runtime in LLVM build
<bitcoin-git> bitcoin/master 543c00f merge-script: Merge bitcoin/bitcoin#35448: ci: don't build libunwind in msan
<bitcoin-git> [bitcoin] sedited merged pull request #35448: ci: don't build libunwind in msan (master...dont_build_libunwind) https://github.com/bitcoin/bitcoin/pull/35448
bitdex has quit [Ping timeout: 245 seconds]
bitdex has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] sedited pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/543c00f47dd2...bcbf5bae1645
<bitcoin-git> bitcoin/master 7c2ec39 seduless: test: Enter mocktime before peer creation in block_relay_only_eviction
<bitcoin-git> bitcoin/master 758fea5 seduless: test: Drop ++ from NodeClockContext default constructor
<bitcoin-git> bitcoin/master 1e9546f seduless: test: Use NodeClockContext in more call sites
<bitcoin-git> [bitcoin] sedited merged pull request #35114: test: NodeClockContext follow-ups (master...34858-followup) https://github.com/bitcoin/bitcoin/pull/35114
bitdex has quit [Quit: = ""]
<maflcko> hebasto: #24773 is locked, so the lack of review may be caused by that. Generally it is best to first unlock an archived conversation before re-opening it or before leaving a comment
<corebot> https://github.com/bitcoin/bitcoin/issues/24773 | Enable HW-accelerated implementations of SHA256 for MSVC builds by hebasto · Pull Request #24773 · bitcoin/bitcoin · GitHub
<hebasto> maflcko: ty, unlocked
luke-jr has quit [Ping timeout: 268 seconds]
roconnor has quit [Ping timeout: 263 seconds]
roconnor has joined #bitcoin-core-dev
luke-jr has joined #bitcoin-core-dev
enochazariah has joined #bitcoin-core-dev
enochazariah has quit [Quit: Client closed]
<dviola> hebasto: hi, I think I saw an issue that was something about reworking depends and if I'm not mistaken, it was authored by you, is that something that is still being decided/planned?
luke-jr_ has joined #bitcoin-core-dev
luke-jr has quit [Read error: Connection reset by peer]
enochazariah has joined #bitcoin-core-dev
<hebasto> dviola: you means this one https://github.com/bitcoin/bitcoin/issues/35048 or something else?
<hebasto> * mean
GoldenGoose has quit [Ping timeout: 252 seconds]
dviola has quit [Ping timeout: 245 seconds]
diego has joined #bitcoin-core-dev
luke-jr_ has quit [Remote host closed the connection]
memset has quit [Remote host closed the connection]
bugs_ has joined #bitcoin-core-dev
memset has joined #bitcoin-core-dev
GoldenGoose has joined #bitcoin-core-dev
diego has left #bitcoin-core-dev [#bitcoin-core-dev]
dviola has joined #bitcoin-core-dev
<dviola> hebasto: yes, that one
<hebasto> dviola: it's still an ongoing discussion
<dviola> hebasto: though I think I also remember this one: https://github.com/bitcoin/bitcoin/issues/24911
<dviola> hebasto: I see
<hebasto> I think that #24911 is mostly superseded by #29914
<corebot> https://github.com/bitcoin/bitcoin/issues/24911 | [POC] [RFC] build: Separate GUI application build system · Issue #24911 · bitcoin/bitcoin · GitHub
<corebot> https://github.com/bitcoin/bitcoin/issues/29914 | RFC: In guix compile the GUI sequentially from everything else? · Issue #29914 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] stringintech opened pull request #35496: kernel: add `btck_set_mock_time` for testing time-dependent paths (master...2026/06/kernel-mocktime) https://github.com/bitcoin/bitcoin/pull/35496
jon_atack has quit [Ping timeout: 276 seconds]
deadmano- has quit [Ping timeout: 264 seconds]
ozdeadman has joined #bitcoin-core-dev
<dviola> hebasto: anyway, the reason I ask, I wonder whether it makes sense to reconsider: https://github.com/bitcoin/bitcoin/pull/22708
<hebasto> dviola: it's bound to the release build scripts. The current priority among the build crowd is #25573. Next is #35098 or its alternative. After that, we might introduce more GUI-specific dependencies needed for #22708
<corebot> https://github.com/bitcoin/bitcoin/issues/25573 | guix: produce a `-static-pie` bitcoind by fanquake · Pull Request #25573 · bitcoin/bitcoin · GitHub
<corebot> https://github.com/bitcoin/bitcoin/issues/35098 | guix: Compile GUI separately from other binaries by hebasto · Pull Request #35098 · bitcoin/bitcoin · GitHub
<corebot> https://github.com/bitcoin/bitcoin/issues/22708 | build, qt: Add Wayland support for Linux builds with depends by hebasto · Pull Request #22708 · bitcoin/bitcoin · GitHub
<dviola> hebasto: cool
<fanquake> hebasto: doesn't 25573 already achieve that same as 35098, along with static bins?
jerryf_ has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
<hebasto> it does basically
<fanquake> Right, so what do you mean by doing that next, after 25573?
<hebasto> that PR had some optimizations, so my idea is to think about similar or other optimizations for post-25573
<dviola> BTW, I wanted to say that there's no need to specify qt6-wayland as a dependency here anymore: https://github.com/bitcoin/bitcoin/blob/master/doc/build-unix.md#dependencies -- nor in the installation scripts. That dependency is now part of Qt itself: https://code.qt.io/cgit/qt/qtbase.git/commit/?id=2d790125429123aec4fb3dbee8335732f2d122eb
<dviola> starting from Qt 6.10.0, IIRC
<dviola> I've made the same suggestion to the Arch devs recently: https://gitlab.archlinux.org/archlinux/packaging/packages/bitcoin/-/merge_requests/4#note_480475
<hebasto> dviola: good to know, ty
<dviola> yw!
<dviola> depends is still on qt 6.8.x it seems, it makes sense to keep it still
<dviola> but yeah, wayland is slowly getting there
<hebasto> re "depends is still on qt 6.8.x" -- it's due to this Qt bug https://qt-project.atlassian.net/browse/QTBUG-144294
<dviola> I see, interesting
enochazariah has quit [Ping timeout: 245 seconds]
Guest74 has joined #bitcoin-core-dev
Guest74 has quit [Client Quit]
memset_ has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
<bitcoin-git> [bitcoin] maflcko opened pull request #35497: test: FakeNodeClock follow-ups in unit tests (master...2606-tests-mocktime-refactor) https://github.com/bitcoin/bitcoin/pull/35497
<bitcoin-git> [bitcoin] Crypt-iQ opened pull request #35498: net: move cs_main up in FetchBlock to fix rpc assert crash (master...06092026/fetchblock_fix) https://github.com/bitcoin/bitcoin/pull/35498
ghost43_ has joined #bitcoin-core-dev
ghost43 has quit [Ping timeout: 245 seconds]
<bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bcbf5bae1645...4b91316643fa
<bitcoin-git> bitcoin/master 54de023 fanquake: guix: add setup.sh
<bitcoin-git> bitcoin/master 4b91316 Hennadii Stepanov: Merge bitcoin/bitcoin#35459: guix: add setup.sh
<bitcoin-git> [bitcoin] hebasto merged pull request #35459: guix: add setup.sh (master...split_setup_code) https://github.com/bitcoin/bitcoin/pull/35459
nymius has joined #bitcoin-core-dev
<dviola> hebasto: actually, those instructions are for system dependencies (outside depends), only debian in that list is still using qt6 6.8.x (I think)
<dviola> they have 6.10.2 in testing
jonatack has joined #bitcoin-core-dev