cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
andrewtoth_ has joined #bitcoin-core-dev
_flood has quit [Read error: Connection reset by peer]
andrewtoth has quit [Remote host closed the connection]
BUSY has quit [Quit: Leaving]
nanotube has quit [Ping timeout: 252 seconds]
nanotube has joined #bitcoin-core-dev
memset_ has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 257 seconds]
Nebraskka has quit [Read error: Connection reset by peer]
Nebraskka has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
jurraca has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] hodlinator opened pull request #35456: test: Perform full reset of CoinsResult in order to avoid passing 21M BTC (master...2026/06/camount_gifts_2) https://github.com/bitcoin/bitcoin/pull/35456
l0rinc has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
dermoth has quit [Read error: Connection reset by peer]
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
jurraca has quit [Ping timeout: 265 seconds]
<bitcoin-git>
[bitcoin] hodlinator opened pull request #35458: qa: Avoid extra tracebacks when exception is raised (master...2026/06/simplify_tracebacks) https://github.com/bitcoin/bitcoin/pull/35458
<bitcoin-git>
[bitcoin] fanquake merged pull request #35410: net: use the proxy if overriden when doing v2-v1 reconnections (master...keep_using_override_proxy_for_v1_reconnects_with_functional_test) https://github.com/bitcoin/bitcoin/pull/35410
jon_atack has joined #bitcoin-core-dev
<fanquake>
New issue re potential leveldb related IBD regression #35457
<corebot>
https://github.com/bitcoin/bitcoin/issues/35457 | Partial IBD speed regression between 9c150222604478431669b66b2caa0d75e8324d4c and 1ea532e590cdc16b86436a2bc4f92d74082307f9 · Issue #35457 · bitcoin/bitcoin · GitHub
cotsuka has quit [Read error: Connection reset by peer]
<nkaretnikov>
also because of the above mistake I actually noticed there is a whole dedicated website for visualizing coverage and test metrics, which I somehow missed before. so the work I’ve been doing the whole week to add a simple ci action and diff coverage script is useless. oh well, but at least I learned about ci a bit more
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
dermoth has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] optout21 opened pull request #35461: Clarify the assertion message in Assert, Assume and CHECK_NONFATAL (master...2606-assert-msg) https://github.com/bitcoin/bitcoin/pull/35461
<janb84>
nkaretnikov: do you mean corecheck.dev ? (and yes there is a lot of tooling already)
dermoth has quit [Remote host closed the connection]
<nkaretnikov>
janb84: yes I was talking about corecheck
brunoerg has joined #bitcoin-core-dev
smartin has joined #bitcoin-core-dev
flooded has joined #bitcoin-core-dev
abubakarsadiq has joined #bitcoin-core-dev
hacker4web3bitco has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
bugs_ has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] hebasto opened pull request #35463: depends: Drop trailing slash from `CMAKE_INSTALL_LIBDIR` (master...260604-depends-slash) https://github.com/bitcoin/bitcoin/pull/35463
robobub has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
BUSY has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
l0rinc has joined #bitcoin-core-dev
PaperSword has quit [Remote host closed the connection]
PaperSword has joined #bitcoin-core-dev
l0rinc_ has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
l0rinc has quit [Ping timeout: 262 seconds]
<bitcoin-git>
[bitcoin] sedited opened pull request #35464: kernel: Add function for creating chainparams with a signet challenge (master...kernel_signet_challenge) https://github.com/bitcoin/bitcoin/pull/35464
<kanzure>
is the docker buildkit cache always used for CI builds? are there any regular intentionally-fresh-cache builds?
brunoerg has quit [Ping timeout: 244 seconds]
musaHaruna has joined #bitcoin-core-dev
purpleKarrot has joined #bitcoin-core-dev
deadmanoz has joined #bitcoin-core-dev
deadmano- has quit [Ping timeout: 252 seconds]
eugenesiegel has joined #bitcoin-core-dev
musa has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
<willcl-ark>
kanzure: the buildkit cache is always used where it matches (and nothing has changed), however there are pretty regular rebuilds of it for example when things in ./ci and ./depends change.
<willcl-ark>
these will cache-miss in the PR, and also on merge to master. If the master run is successful they are saved (and then used as the restore for both future master and all PR runs)
nervana21 has joined #bitcoin-core-dev
<kanzure>
willcl-ark: ok thanks.
<stickies-v>
#startmeeting
<corebot>
stickies-v: Meeting started at 2026-06-04T16:00+0000
<stickies-v>
There are no pre-proposed meeting topics this week. Any last minute ones to add?
ViniciusCestarii has joined #bitcoin-core-dev
<cfields>
hi
<stickies-v>
#topic Fuzzing WG Update (dergoegge)
<dergoegge>
no update
<stickies-v>
#topic Kernel WG Update (sedited)
<sedited>
#32427 has been getting a bunch of review over the past week and has accrued a few ACKs
<corebot>
https://github.com/bitcoin/bitcoin/issues/32427 | kernel: Replace leveldb-based BlockTreeDB with flat-file based store by sedited · Pull Request #32427 · bitcoin/bitcoin · GitHub
<sedited>
For a change that will break backwards compatibility and completely changes one of our persistence layers, I think it requires still more buy-in.
<jon_atack>
hi
<bitcoin-git>
[bitcoin] l0rinc opened pull request #35465: validation: compact chainstate after connecting assumevalid block (master...l0rinc/forcecompactdb-ibd-exit) https://github.com/bitcoin/bitcoin/pull/35465
<l0rinc_>
hi
<johnny9dev>
hi
<willcl-ark>
yes would be nice to see more Concept ACK-ers (and others!) review that one
<sedited>
So I'd like to invite more people to come review it.
<stickies-v>
anything else?
<sedited>
that's all
<stickies-v>
#topic Benchmarking WG Update (l0rinc, andrewtoth)
<l0rinc_>
A followup was just pushed to #35465 - it does the compaction at the assumevalid boundary to guarantee uniqueness. It's similar to darosior's suggestion last week, just easier to implement and explain.
<fjahr>
pinheadmz isn’t here today but full focus is on review of #35182. IMO it’s getting very close and it would be great if we can get it in early in the release cycle.
<corebot>
https://github.com/bitcoin/bitcoin/issues/35182 | Replace libevent with our own HTTP and socket-handling implementation by pinheadmz · Pull Request #35182 · bitcoin/bitcoin · GitHub
<darosior>
I don't think compacting is particularly important in the first place, so take my nit with a grain of salt, but using assumevalid instead of minchainwork means that people actually validating the historical chain won't benefit from the compaction?
<l0rinc_>
the compaction doesn't necessarily result in a measurable speedup - except maybe smaller files, so a few more can fit into the OS memory. But without compaction (especially on HDD) we were about ~15% faster
pseudoramdom has joined #bitcoin-core-dev
<sipa>
hi
<l0rinc_>
"it seems that this check would never be true for people running with -assumevalid=0" - good point, it's why originally this was triggered by getting out of IBD mode. I'll find something, thanks for the hint.
cotsuka has quit [Remote host closed the connection]
pseudoramdom has quit [Changing host]
pseudoramdom has joined #bitcoin-core-dev
<stickies-v>
looks like we're done here? thanks for the conversation, folks
<l0rinc_>
I want to avoid on events that can happen multiple times, e.g. when someone starts their node weekly - we don't want every one of these resulting in a compaction
<stickies-v>
#endmeeting
<corebot>
stickies-v: Meeting ended at 2026-06-04T16:17+0000
<cfields>
We could run it at the assumevalid height, regardless of whether assumevalid is on or not.
pseudoramdom has quit [Remote host closed the connection]
<l0rinc_>
"We could run it at the assumevalid height, regardless of whether assumevalid is on or not." i thought of that but it would make usage a bit more confusing - they explicitly set an invalid value to always enable it and it's not used.
<instagibbs>
I presume we're cutting a release without that? if not we should say so and get it in asap
<sedited>
"that" being your or l0rinc_'s PR?
<l0rinc_>
it would be preferable to have the force compaction in the same releases as the ones that removed seek compaction
<instagibbs>
sedited mine, sorry
<instagibbs>
i dont know about the compaction stuff :)
<instagibbs>
rebased my PR on top of the privacy fix
<darosior>
Seems useful to backport, but also less urgent than releasing the main fix?
<instagibbs>
darosior was my assumption 👍
<sedited>
kk
<sipa>
l0rinc_: there could also be an independent chainparam that controls force-compaction height, i guess?
<l0rinc_>
sipa: defaulting to the assumevalid height? I don't think we want to adjust that at every release
<sipa>
just a fixed height at which compaction runs, not a default
<l0rinc_>
yeah, but those should be adjusted regularly, we don't want compaction to happen at the same height in 10 years
<l0rinc_>
I'll figure something out, thanks for the comments