cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
ghost43 has quit [Ping timeout: 265 seconds]
ghost43 has joined #bitcoin-core-dev
ghost43_ has joined #bitcoin-core-dev
ghost43 has quit [Ping timeout: 265 seconds]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [#bitcoin-core-dev]
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] maflcko opened pull request #34976: lint: Clarify rmtree/remove_all error message with preferred alternatives (master...2604-lint-msg) https://github.com/bitcoin/bitcoin/pull/34976
jerryf_ has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] Sjors opened pull request #34977: Update libmultiprocess subtree to fix test timeout (master...2026/04/libmultiprocess-subtree) https://github.com/bitcoin/bitcoin/pull/34977
jerryf has quit [Ping timeout: 265 seconds]
<bitcoin-git>
[bitcoin] enirox001 opened pull request #34978: init: Reserve file descriptors for IPC connections (master...04-26-ipc-maxconnections) https://github.com/bitcoin/bitcoin/pull/34978
l0rinc has quit [Quit: l0rinc]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] pinheadmz opened pull request #34980: Require captcha for all pull request submissions to prevent LLM abuse (master...patch-1) https://github.com/bitcoin/bitcoin/pull/34980
jonatack has quit [Ping timeout: 248 seconds]
jonatack has joined #bitcoin-core-dev
<janb84_>
lol
<sliv3r__>
hahhaahah
l0rinc has joined #bitcoin-core-dev
l0rinc has quit [Client Quit]
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
<fanquake>
Also wondering why we'd change our requirements, in regards to CMake, but not other other dependencies / build reuquirements?
<fanquake>
(if it's fine to force devs/users/anyone to install a newer version of CMake than is shipped with their OS, then we could/should be doing the same for everything else?)
<hebasto>
fanquake: quoting myself from September IRC meeting -- "This gives us a few useful features such as (1) file sets; (2) `COMPILE_WARNING_AS_ERROR`; (3) better support for IPO/LTO; (4) scope management"
<fanquake>
We already use COMPILE_WARNING_AS_ERROR
<fanquake>
What are the benefits of the other things
timbo_xyz has quit [Remote host closed the connection]
<fanquake>
does CMAKE_INTERPROCEDURAL_OPTIMIZATION not work properly for earlier CMake versions?
l0rinc has joined #bitcoin-core-dev
<hebasto>
"We already use COMPILE_WARNING_AS_ERROR" -- it does nothing in CMake 3.22
timbo_xyz has joined #bitcoin-core-dev
<fanquake>
Sure, but that doesn't really matter, as long as it works in our CI / any dev machine
<fanquake>
Ok, I think anyone wanting to use LTO, is likely already using newer versions of CMake, as you'd want to be using newer compilers / toolchains. i.e old cmake but much newer compilers / toolchains seems unlikely (we also haven't had anyone report the combo of old cmake + lto as not working)
<hebasto>
in my opinion, benefits of bumping are greater than zero, while drawbacks are near to zero
<fanquake>
At least one drawback is that build setups which currently just work, just wont
<fanquake>
Another is ambiguity around what it means for us to "support" and OS. Genearlly that has meant being able to build with packages from the system package manager, this will break that assumption
<fanquake>
If we think it's fine to force users/devs to install packages from the distribution site, then we should just do that for everything (i.e compiles) no?
<hebasto>
this is a much broader assumption; I was talking only about Ubuntu LTS of the grandparent generation, which people deliberately chose to keep, instead of updating to 24.04 LTS or 26.04 LTS
<hebasto>
* upgrading
<fanquake>
Yea, I mean for the same users, given for example, that we keep our minimum support compiler as something similar to what is shipped by the LTS, if we decide to force users to install newer tools, why not do that for compilers as well?
<fanquake>
(and bump the minumum supported compiler)
<hebasto>
(1) it depends on expected user's effort; (2) we have already forced user's choice regarding building tools, e.g. #33555
<hebasto>
getting the recent version of CMake is super easy; it's not the case for GCC
<bitcoin-git>
[bitcoin] alexanderwiederin opened pull request #34982: kernel: Remove NONNULL annotation from destroy method (master...remove-non-null-block-validation) https://github.com/bitcoin/bitcoin/pull/34982
<fanquake>
I think installing GCC and/or Clang is about on par?
eugenesiegel has joined #bitcoin-core-dev
___nick___ has joined #bitcoin-core-dev
timbo_xyz has quit [Remote host closed the connection]
timbo_xyz has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
garlic has joined #bitcoin-core-dev
___nick___ has quit [Read error: Connection reset by peer]
___nick___ has joined #bitcoin-core-dev
garlic has quit []
<bitcoin-git>
[bitcoin] it-education-md opened pull request #34983: [WIP] validation, rpc: add height and time to testmempoolaccept (master...feat-testmempoolaccept-timelock-context) https://github.com/bitcoin/bitcoin/pull/34983
memset has quit [Remote host closed the connection]
kevkevin has quit [Ping timeout: 246 seconds]
memset has joined #bitcoin-core-dev
mudsip has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
mudsip has quit [Client Quit]
cotsuka has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
kevkevin_ has quit [Ping timeout: 246 seconds]
<bitcoin-git>
[bitcoin] w0xlt opened pull request #34989: doc: remove stale shortid collision TODO (master...remove_stale_blockencodings_comment) https://github.com/bitcoin/bitcoin/pull/34989