achow101 changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 16:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
phungus8153520 has quit [Ping timeout: 248 seconds]
hardtotell8 has quit [Quit: pz]
hardtotell8 has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
Guest1 has joined #bitcoin-core-dev
bitcoindev1337 has quit [Remote host closed the connection]
Guest1 has quit [Quit: Client closed]
jonatack has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] l0rinc closed pull request #35654: txdb: reject undecodable first coin cursor key (master...l0rinc/txdb-malformed-first-coin-cursor-key) https://github.com/bitcoin/bitcoin/pull/35654
pablomartin is now known as pablomartin4btc
PaperSword has quit [Quit: PaperSword]
Cory has quit [Quit: Client closed]
jonatack has quit [Read error: Connection reset by peer]
cmirror has quit [Remote host closed the connection]
l0rinc has joined #bitcoin-core-dev
cmirror has joined #bitcoin-core-dev
bitcoindev1337 has joined #bitcoin-core-dev
afiore has quit [Remote host closed the connection]
SpellChecker has quit [Remote host closed the connection]
afiore has joined #bitcoin-core-dev
SpellChecker has joined #bitcoin-core-dev
afiore has quit [Remote host closed the connection]
afiore has joined #bitcoin-core-dev
bitcoindev1337 has quit [Remote host closed the connection]
satsfy_ is now known as satsfy
l0rinc has quit [Quit: l0rinc]
eugenesiegel has quit [Ping timeout: 245 seconds]
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
Nebraskka has quit [Read error: Connection reset by peer]
Nebraskka has joined #bitcoin-core-dev
sliv3r__ has quit [Read error: Connection reset by peer]
sliv3r__ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] Lamcute-lan opened pull request #35953: Add PoA/BFT and experimental P2P routing prototype (feature-flagged) (master...lamcute-lan-poa-bft-prototype) https://github.com/bitcoin/bitcoin/pull/35953
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] achow101 closed pull request #35953: Add PoA/BFT and experimental P2P routing prototype (feature-flagged) (master...lamcute-lan-poa-bft-prototype) https://github.com/bitcoin/bitcoin/pull/35953
dct555 has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
dct87 has joined #bitcoin-core-dev
dct555 has quit [Ping timeout: 245 seconds]
dct87 has quit [Client Quit]
enochazariah has joined #bitcoin-core-dev
___nick___ has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [#bitcoin-core-dev]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] hebasto opened pull request #35954: qa: Disable Qt's glib event dispatcher for GUI tests on OpenBSD (master...260811-openbsd-gui-test) https://github.com/bitcoin/bitcoin/pull/35954
<bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1bec7fa22c9f...1f5c46f7ce25
<bitcoin-git> bitcoin/master 67fee5b Hennadii Stepanov: ci: Check DLL imports of cross-built `bitcoind.exe`
<bitcoin-git> bitcoin/master 1f5c46f Hennadii Stepanov: Merge bitcoin/bitcoin#35931: ci: Check DLL imports of cross-built `bitcoin...
<bitcoin-git> [bitcoin] hebasto merged pull request #35931: ci: Check DLL imports of cross-built `bitcoind.exe` (master...260807-ci-win-imports) https://github.com/bitcoin/bitcoin/pull/35931
kanzure has quit [Ping timeout: 246 seconds]
kanzure has joined #bitcoin-core-dev
enochazariah has quit [Ping timeout: 242 seconds]
Zenton has quit [Ping timeout: 263 seconds]
enochazariah has joined #bitcoin-core-dev
memset_ has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
Guest13 has joined #bitcoin-core-dev
Guest13 has quit [Client Quit]
enochazariah has quit [Read error: Connection reset by peer]
enochazariah has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] laxmanacharya8 opened pull request #35955: wallet: remove orphaned GetAffectedKeys declaration (master...remove-orphaned-getaffectedkeys) https://github.com/bitcoin/bitcoin/pull/35955
svanstaa_ has quit [Ping timeout: 245 seconds]
svanstaa has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1f5c46f7ce25...b0615672352f
<bitcoin-git> bitcoin/master a314256 Hennadii Stepanov: build, msvc: Update vcpkg manifest baseline
<bitcoin-git> bitcoin/master e2bf515 Hennadii Stepanov: build, msvc: Disable default features of the `sqlite3` package
<bitcoin-git> bitcoin/master b061567 merge-script: Merge bitcoin/bitcoin#35947: build, msvc: Update vcpkg manifest baseline
<bitcoin-git> [bitcoin] fanquake merged pull request #35947: build, msvc: Update vcpkg manifest baseline (master...250810-vcpkg) https://github.com/bitcoin/bitcoin/pull/35947
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b0615672352f...4c045f1a0323
<bitcoin-git> bitcoin/master e8500cb Hennadii Stepanov: depends, qt: Add patch for missing headers
<bitcoin-git> bitcoin/master 4c045f1 merge-script: Merge bitcoin/bitcoin#35945: depends, qt: Add patch for missing headers
<bitcoin-git> [bitcoin] fanquake merged pull request #35945: depends, qt: Add patch for missing headers (master...260810-depends-qt-syncqt) https://github.com/bitcoin/bitcoin/pull/35945
enochazariah has quit [Ping timeout: 248 seconds]
enochazariah has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] HowHsu opened pull request #35956: fuzz: scope fake clocks to target phases (master...fuzz-target-local-clock) https://github.com/bitcoin/bitcoin/pull/35956
<bitcoin-git> [bitcoin] hebasto opened pull request #35957: ci: Define `BOOST_MULTI_INDEX_ENABLE_SAFE_MODE` for debug builds (master...260812-boost-debug) https://github.com/bitcoin/bitcoin/pull/35957
WizJin has joined #bitcoin-core-dev
bitcoindev1337 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] brunoerg opened pull request #35958: net: align v2 message type validation with v1 range (master...2026-08-v2-fix) https://github.com/bitcoin/bitcoin/pull/35958
___nick___ has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
eugenesiegel has joined #bitcoin-core-dev
___nick___ has joined #bitcoin-core-dev
___nick___ has quit [Client Quit]
___nick___ has joined #bitcoin-core-dev
bitcoindev1337 has quit [Remote host closed the connection]
jonatack has joined #bitcoin-core-dev
memset_ has quit [Ping timeout: 252 seconds]
jonatack has quit [Ping timeout: 265 seconds]
memset has joined #bitcoin-core-dev
SpellChecker has quit [Ping timeout: 252 seconds]
SpellChecker has joined #bitcoin-core-dev
bugs_ has joined #bitcoin-core-dev
ozdeadman has quit [Ping timeout: 242 seconds]
jonatack has joined #bitcoin-core-dev
deadmanoz has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
ghost43_ has joined #bitcoin-core-dev
ghost43 has quit [Read error: Connection reset by peer]
bitcoindev1337 has joined #bitcoin-core-dev
<bitcoindev1337> _aj_, darosior sedited this is the minimal patch http://51.79.26.189/minimal.patch
<lightlike> bitcoindev1337: could you upload to a github repo? I'd prefer not to click on random links :)
<bitcoindev1337> github has gotten very annoying about registering accounts
<bitcoindev1337> i can pastebin it? it's only ~300 lines
<bitcoindev1337> oops that one expires in 24h, https://paste.debian.net/hidden/f72e65dd
janb84_ has joined #bitcoin-core-dev
janb84 has quit [Ping timeout: 252 seconds]
janb84_ is now known as janb84
bitcoindev1337 has quit [Remote host closed the connection]
bitcoindev1337 has joined #bitcoin-core-dev
purpleKarrot has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake opened pull request #35959: Update secp256k1 subtree to latest master (master...update_secp_subtree) https://github.com/bitcoin/bitcoin/pull/35959
purpleKarrot has quit [Client Quit]
jonatack has quit [Ping timeout: 256 seconds]
bitcoindev1337 has quit [Ping timeout: 265 seconds]
jonatack has joined #bitcoin-core-dev
Guest17 has joined #bitcoin-core-dev
Guest17 has quit [Client Quit]
dzxzg has joined #bitcoin-core-dev
dzxzg has quit [Quit: Konversation terminated!]
eugenesiegel has quit [Quit: Client closed]
eugenesiegel has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 264 seconds]
WizJin has quit [Ping timeout: 260 seconds]
<bitcoin-git> [bitcoin] fanquake opened pull request #35960: common: remove `::runtime_error` from `RunCommandParseJSON` (master...run_command_json) https://github.com/bitcoin/bitcoin/pull/35960
WizJin has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
WizJin_ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4c045f1a0323...2f72123f613f
<bitcoin-git> bitcoin/master 4e8c4bc Henry Romp: test: classify SOCKS5 peers via getpeerinfo addrbind
<bitcoin-git> bitcoin/master 2f72123 merge-script: Merge bitcoin/bitcoin#35867: test: classify SOCKS5 peers via getpeerinfo a...
WizJin has quit [Ping timeout: 264 seconds]
<bitcoin-git> [bitcoin] fanquake merged pull request #35867: test: classify SOCKS5 peers via getpeerinfo addrbind (master...fix-35843-private-broadcast-stale-conn-type) https://github.com/bitcoin/bitcoin/pull/35867
<hebasto> #proposedmeetingtopic Compiler diversity: to drop MSVC or keep it?
<hebasto> notes for the proposed topic are here -- https://gist.github.com/hebasto/04d475830a3f6b42f2f66976bdf6c5b9
<fanquake> hebasto: forgot to add yourself to the "inclined to remove" ? Given you have a PR open doing so
___nick___ has quit [Ping timeout: 264 seconds]
__nick__ has joined #bitcoin-core-dev
<hebasto> fair point :)
<hebasto> I do prefer clang-cl for my own binaries
<hebasto> but maybe it's worth keeping a single MSVC CI job as a canary, at some cost to code cleanliness -- that's the trade-off I want the meeting to weigh
<dviola> I'm curious if anyone have any objections: https://github.com/bitcoin-core/gui/pull/948
WizJin_ has quit [Quit: Leaving]
<hebasto> dviola: my apologies, I'll look into it this week
<dviola> hebasto: no worries, I know you've been busy
<fanquake> hebasto: sure, but you should be listed there, probably along with the PR?
<fanquake> A bit confusing to have had a PR open for ~6months dropping MSVC support, if you're not actually in favour of doing so
<fanquake> Maybe we should drop #31507 from the 32 milestone if there's not actually agreement on what is being done?
<corebot> fanquake: Error: That URL raised <Remote end closed connection without response>
<hebasto> fanquake: removed it from 32.0 milestone
l0rinc has joined #bitcoin-core-dev
<achow101> #31507
<corebot> https://github.com/bitcoin/bitcoin/issues/31507 | build: Use clang-cl to build on Windows natively by hebasto · Pull Request #31507 · bitcoin/bitcoin · GitHub
bitcoindev1337 has joined #bitcoin-core-dev
<bitcoindev1337> yes can confirm benchmarks at least 20% faster with block read ahead
enochazariah has quit [Ping timeout: 256 seconds]
jonatack has quit [Ping timeout: 265 seconds]
jonatack has joined #bitcoin-core-dev
<l0rinc> I wrote these yesterday but I can't see them in the logs (I hate IRC), so let me try again
<l0rinc> I think #35531 would fit nicely in v32 with our existing optimizations and disk usage fixes (txindex size dropping from 68G to 26G and rebuild time from 1h58m to 1h16m).
<corebot> https://github.com/bitcoin/bitcoin/issues/35531 | txindex: hash keys and pack positions to reduce disk usage by andrewtoth · Pull Request #35531 · bitcoin/bitcoin · GitHub
<l0rinc> bitcoindev1337, care to share a branch? I would be surprised if the block prefetching would result in more than a 5% speedup
<l0rinc> I see there's a link now, but all of them give me "Your requested paste entry '05e0ceff' could not be found"
ghost43_ has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
<bitcoindev1337> l0rinc, not sure what's wrong with the paste but this ones live right now https://paste.debian.net/hidden/f8c50446
<l0rinc> this works, thanks
<bitcoindev1337> the code was entirely written by ai but i don't see any issues with what it wrote
<bitcoindev1337> other than some of it being a little weird
jonatack has quit [Ping timeout: 264 seconds]
fearbeag has quit [Ping timeout: 248 seconds]
<bitcoindev1337> l0rinc, my internet is kinda bad but i'll read the channel logs later if you have thoughts on it
<l0rinc> I'll investigate and benchmark it
bitcoindev1337 has quit [Ping timeout: 245 seconds]
bitcoindev1337 has joined #bitcoin-core-dev
<bitcoindev1337> l0rinc, one note, the benchmark was done on a fairly slow cpu with a fairly fast ssd and with txindex=1 and dbcache=8192 with 32gb of ram total, iono if that mattered much but i thought i would mention it
<bitcoin-git> [bitcoin] hebasto opened pull request #35961: depends: Update `boost` package to 1.92.0 (master...260812-boost) https://github.com/bitcoin/bitcoin/pull/35961
PaperSword has joined #bitcoin-core-dev
bitcoindev1337 has quit [Remote host closed the connection]
jonatack has joined #bitcoin-core-dev
HermesIRC has quit [Ping timeout: 258 seconds]
dzxzg has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
eugenesiegel has quit [Quit: Client closed]
eugenesiegel has joined #bitcoin-core-dev
nanotube has quit [Ping timeout: 251 seconds]
jonatack has quit [Ping timeout: 264 seconds]
bugs_ has quit [Quit: Leaving]
jonatack has joined #bitcoin-core-dev
nanotube has joined #bitcoin-core-dev