achow101 changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 16:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
adil has joined #bitcoin-core-dev
adil has quit [Client Quit]
adil has joined #bitcoin-core-dev
adil has quit [Client Quit]
adil has joined #bitcoin-core-dev
roy8144225309 has joined #bitcoin-core-dev
roy8144225309 has quit [Client Quit]
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
aleggg has joined #bitcoin-core-dev
adil has quit [Quit: adil]
cotsuka has quit [Remote host closed the connection]
cotsuka has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
abubakarsadiq has quit [Quit: Connection closed for inactivity]
cotsuka has joined #bitcoin-core-dev
SpellChecker_ has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
willcl-ark has quit [Ping timeout: 264 seconds]
cotsuka has quit [Remote host closed the connection]
cotsuka has joined #bitcoin-core-dev
willcl-ark has joined #bitcoin-core-dev
ghost43_ has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
adil has joined #bitcoin-core-dev
jerryf has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
jerryf has quit [Remote host closed the connection]
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
jerryf has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
SpellChecker has quit [Remote host closed the connection]
vasild has quit [Remote host closed the connection]
afiore has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
SpellChecker has joined #bitcoin-core-dev
afiore has joined #bitcoin-core-dev
memset has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
adil has quit [Ping timeout: 248 seconds]
l0rinc has quit [Quit: l0rinc]
adil has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
sliv3r__ has quit [Read error: Connection reset by peer]
sliv3r__- has joined #bitcoin-core-dev
janb84 has quit [Ping timeout: 272 seconds]
Guest85 has joined #bitcoin-core-dev
janb84 has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
BrandonOdiwuor has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 252 seconds]
memset has quit [Ping timeout: 252 seconds]
jonatack has joined #bitcoin-core-dev
memset has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 256 seconds]
BrandonOdiwuor has quit [Quit: Client closed]
smartin2 has joined #bitcoin-core-dev
smartin has quit [Ping timeout: 248 seconds]
smartin2 is now known as smartin
ozdeadman has quit [Ping timeout: 245 seconds]
deadmanoz has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] alhudz opened pull request #35440: wallet: check descriptor cache xpub length before decoding (master...walletdb-xpub-size-check) https://github.com/bitcoin/bitcoin/pull/35440
Guyver2 has left #bitcoin-core-dev [Closing Window]
Guest85 has quit [Quit: Client closed]
<bitcoin-git> [bitcoin] sedited pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/654a5223af53...255f7c720f13
<bitcoin-git> bitcoin/master 8877eec rkrux: wallet: allow anti-fee-sniping in sendall RPC while not relying on RBF def...
<bitcoin-git> bitcoin/master 9c1fcac rkrux: wallet, test: fix sendall anti-fee-sniping when locktime is not specified
<bitcoin-git> bitcoin/master 255f7c7 merge-script: Merge bitcoin/bitcoin#35404: wallet: allow anti-fee-sniping in sendall RPC...
<bitcoin-git> [bitcoin] sedited merged pull request #35404: wallet: allow anti-fee-sniping in sendall RPC while not relying on RBF default (master...antifeesniping) https://github.com/bitcoin/bitcoin/pull/35404
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/255f7c720f13...53373d07c3ee
<bitcoin-git> bitcoin/master 2ce4ae7 will: ci: Add dynamic cache switching to warp cache
<bitcoin-git> bitcoin/master 53373d0 merge-script: Merge bitcoin/bitcoin#35430: ci: use warp caching on warp runners
<bitcoin-git> [bitcoin] fanquake merged pull request #35430: ci: use warp caching on warp runners (master...cache-switching) https://github.com/bitcoin/bitcoin/pull/35430
l0rinc has joined #bitcoin-core-dev
enochazariah has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] sedited pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/53373d07c3ee...2e0a36c36062
<bitcoin-git> bitcoin/master c8b8c27 xyzconstant: test: Improve loopback address check in `rcp_bind.py`
<bitcoin-git> bitcoin/master 2e0a36c merge-script: Merge bitcoin/bitcoin#35439: test: Improve loopback address check in `rpc_...
<bitcoin-git> [bitcoin] sedited merged pull request #35439: test: Improve loopback address check in `rpc_bind.py` (master...fix_loopback_check_in_rpc_bind_tests) https://github.com/bitcoin/bitcoin/pull/35439
Guest23 has joined #bitcoin-core-dev
Guest23 has quit [Client Quit]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
sliv3r__- has quit [Read error: Connection reset by peer]
brunoerg has quit [Ping timeout: 264 seconds]
sliv3r__ has joined #bitcoin-core-dev
adil has quit [Quit: adil]
deadmano- has quit [Ping timeout: 245 seconds]
adil has joined #bitcoin-core-dev
ozdeadman has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] willcl-ark opened pull request #35441: ci: inline runner selection (master...drop-determine-runners) https://github.com/bitcoin/bitcoin/pull/35441
<bitcoin-git> [bitcoin] sedited pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2e0a36c36062...61d1c78ed416
<bitcoin-git> bitcoin/master 6c525c2 rkrux: wallet: unfriend LegacyDataSPKM and DescriptorScriptPubKeyMan classes
<bitcoin-git> bitcoin/master 61d1c78 merge-script: Merge bitcoin/bitcoin#35192: wallet: unfriend LegacyDataSPKM and Descripto...
<bitcoin-git> [bitcoin] sedited merged pull request #35192: wallet: unfriend LegacyDataSPKM and DescriptorScriptPubKeyMan (master...spkms-unfriend) https://github.com/bitcoin/bitcoin/pull/35192
adil has quit [Quit: adil]
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
abubakarsadiq has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
eugenesiegel has joined #bitcoin-core-dev
<fjahr> FYI, the next asmap collaborative launch is in 2 days: https://github.com/bitcoin-core/asmap-data/issues/51
<fjahr> We still have an open PR to add the attestations into the data repo, as discussed at CoreDev. Would be great if we could get a few more eyes on this soon so we can complete the transition: https://github.com/bitcoin-core/asmap-data/pull/50
bugs_ has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] rkrux opened pull request #35442: test: remove usages of MAX_BIP125_RBF_SEQUENCE constant from functional tests (master...rbfsequence-test) https://github.com/bitcoin/bitcoin/pull/35442
brunoerg has quit [Ping timeout: 264 seconds]
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
aleggg has quit [Ping timeout: 246 seconds]
aleggg has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
l0rinc has quit [Remote host closed the connection]
l0rinc has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
enochazariah has quit [Quit: Ping timeout (120 seconds)]
jonatack has quit [Quit: WeeChat 4.9.0]
<bitcoin-git> [bitcoin] mjdietzx opened pull request #35443: tests: add functional test for tr musig2 miniscript decaying multisig (master...test_tr_miniscript_decaying_multiscript_descriptor) https://github.com/bitcoin/bitcoin/pull/35443
bugs_ has quit [Ping timeout: 264 seconds]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
frankomosh has joined #bitcoin-core-dev
frankomosh has quit [Client Quit]
frankomosh has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] w0xlt opened pull request #35444: wallet: make descriptor SPKM mutex non-recursive (master...wallet-descriptor-spkm-mutex-19303-simple-index) https://github.com/bitcoin/bitcoin/pull/35444
w0xlt has quit [Remote host closed the connection]
abubakarsadiq has quit [Quit: Connection closed for inactivity]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
<nkaretnikov> fjahr: i’ve never done this. is the process just doing what issue 51 says (aka running that command on master)? are there any special requirements for this (lots of disk space or network traffic)?
<darosior> for anyone off xitter, this is the chart shown in the tweet fanquake shared above https://imgur.com/a/h0dLBY9
<sliv3r__> or if you want the full thread: https://nitter.net/caesrcd/status/2061830168209944719
<fjahr> nkaretnikov: disk space needed is about 2-3 GB, faster network traffic and machine will help finishing faster but it's not a requirement. I've even done it on hotel wifi ;) You just start it at some point before the time in the issue and you will see a countdown. Then it will start when the countdown runs out. On a fast machine it can take less than 10min, on a slow machine/network I saw 1h 20min.
frankomosh has quit [Quit: Client closed]
<fjahr> Thanks for your interest :) Let me know if you have more questions.
<nkaretnikov> fjahr: do you care where users run this? i would prefer not to run this at home atm, but i can run on gcp. would the be ok?
<darosior> sliv3r__'s link didn't work for me but https://nitter.poast.org/caesrcd/status/2061830168209944719 did
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
<darosior> Andrew: how is that seek compaction related?
<fjahr> nkaretnikov: Sure, that's ok. I know several people do it at home and as long as not everyone move to gcp that's a good contribution.
<nkaretnikov> fjahr: ok, will do and report back
<fjahr> nkaretnikov: cool!
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
andrewtoth has joined #bitcoin-core-dev
nanotube has quit [Ping timeout: 241 seconds]
<andrewtoth> darosior: I am speculating, but the cache only fills up around ~800k blocks and gets emptied, causing reads to now go to disk
<andrewtoth> for the big cache values
<andrewtoth> before that there was no seek compaction since no reads hit disk. For the smaller cache sizes, they were compacting the whole time, so probably fewer files needing compaction
<andrewtoth> For smaller cache sizes, they get seek compacted along the way. For the bigger caches, they do writes every ~hour, but those files just stay higher in the tree since they're not seek compacted. Then, when they finally start getting seek compacted, there are files at every level, which is a lot more compacting.
<andrewtoth> Hmm based on https://github.com/bitcoin-core/leveldb-subtree/pull/61#issuecomment-4524808917, it doesn't seem like there's that much less compaction with higher dbcache values. So, might not be the issue.
<darosior> So does that mean that compaction takes an amount of time superlinear in the size of what needs to be compacted? Because they would need to compact strictly less data than those nodes with lower caches. (Presumably a lot more since as we've seen stuff gets re-compacted.)
<darosior> If so, is it wise to enable one big seek compaction at the end of IBD?
brunoerg has joined #bitcoin-core-dev
<andrewtoth> I also noticed the disk reads exploding for smaller cache sizes. In https://github.com/bitcoin/bitcoin/pull/31132#issuecomment-3678847806, the green line is around block 800k, where the bottleneck is random reading from the db.
<andrewtoth> The majority of time in IBD is spent from 800k-900k
<andrewtoth> darosior: it's a little more complicated than total data size. seek compaction will trigger random files to get compacted, depending on when they get read. If we do a single manual compaction, it will go through each level and compact all files there at once I think.
l0rinc has quit [Quit: l0rinc]
l0rinc has joined #bitcoin-core-dev
bugs_ has joined #bitcoin-core-dev
eugenesiegel has quit [Ping timeout: 245 seconds]
l0rinc has quit [Quit: l0rinc]
bugs_ has quit [Quit: Leaving]
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev