achow101 changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 16:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
bomb-on has quit [Read error: Connection reset by peer]
bomb-on has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/de925455c802...acea6f2caf89
<bitcoin-git> bitcoin/master f05b1a3 optout: rpc: Fix for duplicate external signers case
<bitcoin-git> bitcoin/master acea6f2 Ava Chow: Merge bitcoin/bitcoin#35251: wallet: Fix for duplicate external signers ca...
<bitcoin-git> [bitcoin] achow101 merged pull request #35251: wallet: Fix for duplicate external signers case (master...2605-external-signer-duplicate-fix) https://github.com/bitcoin/bitcoin/pull/35251
<bitcoin-git> [bitcoin] achow101 pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/acea6f2caf89...dd0dea3e898d
<bitcoin-git> bitcoin/master c4a7613 rkrux: wallet: mark `bip125-replaceable` key as deprecated in transaction RPCs
<bitcoin-git> bitcoin/master 97f7cc0 rkrux: wallet: mark -walletrbf startup option as deprecated
<bitcoin-git> bitcoin/master aba24a9 rkrux: wallet: remove "RPC Only" from -walletrbf option help description
<bitcoin-git> [bitcoin] achow101 merged pull request #34917: wallet: mark bip125-replaceable RPC key and walletrbf startup option as deprecated (master...wallet-rbf) https://github.com/bitcoin/bitcoin/pull/34917
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
bomb-on has quit [Read error: Connection reset by peer]
bomb-on has joined #bitcoin-core-dev
adil has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
conman has quit [Quit: Konversation terminated!]
conman has joined #bitcoin-core-dev
cotsuka has joined #bitcoin-core-dev
adil has quit [Quit: adil]
Guest99 has joined #bitcoin-core-dev
Guest99 has quit [Client Quit]
Guest99 has joined #bitcoin-core-dev
Guest99 has quit [Client Quit]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
spynxic has quit [Ping timeout: 245 seconds]
spynxic has joined #bitcoin-core-dev
svanstaa has quit [Ping timeout: 252 seconds]
svanstaa_ has joined #bitcoin-core-dev
janb84 has joined #bitcoin-core-dev
Zenton has quit [Ping timeout: 245 seconds]
Zenton has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
smartin has joined #bitcoin-core-dev
BrandonOdiwuor has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/dd0dea3e898d...743bf350f212
<bitcoin-git> bitcoin/master 779f444 rkrux: test: move out JSONRPCException from authproxy to util
<bitcoin-git> bitcoin/master 7be0d6f rkrux: test: remove the lazy import of util in authproxy
<bitcoin-git> bitcoin/master 743bf35 merge-script: Merge bitcoin/bitcoin#35049: test: remove circular dependency between auth...
<bitcoin-git> [bitcoin] fanquake merged pull request #35049: test: remove circular dependency between authproxy and util (master...test-circular) https://github.com/bitcoin/bitcoin/pull/35049
Guyver2 has left #bitcoin-core-dev [Closing Window]
janb84 has quit [Ping timeout: 265 seconds]
janb84 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/743bf350f212...d5188b559243
<bitcoin-git> bitcoin/master fa4fc8c MarcoFalke: test: Set TestNode url field early, so that feature_loadblock.py --usecli ...
<bitcoin-git> bitcoin/master faf993e MarcoFalke: test: Stop node before modifying config to support rpc_users.py --usecli
<bitcoin-git> bitcoin/master faf0f84 MarcoFalke: test: use echojson to allow rpc_named_arguments.py --usecli
<bitcoin-git> [bitcoin] fanquake merged pull request #35363: test: Allow --usecli in more tests (master...2605-test-use-cli-more) https://github.com/bitcoin/bitcoin/pull/35363
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d5188b559243...b43a9363556b
<bitcoin-git> bitcoin/master a154c05 Hennadii Stepanov: cmake: Check dependencies after build option interaction
<bitcoin-git> bitcoin/master b43a936 merge-script: Merge bitcoin/bitcoin#33974: cmake: Check dependencies after build option ...
<bitcoin-git> [bitcoin] fanquake merged pull request #33974: cmake: Check dependencies after build option interaction (master...251130-cmake-options) https://github.com/bitcoin/bitcoin/pull/33974
smartin has quit [Quit: smartin]
smartin has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] willcl-ark opened pull request #35378: ci: switch to warp runners (master...warpbuild-runners) https://github.com/bitcoin/bitcoin/pull/35378
<bitcoin-git> [bitcoin] sedited pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b43a9363556b...9ec4efebd1e3
<bitcoin-git> bitcoin/master 08c3c37 Ryan Ofsky: bitcoin-cli: note -rpcclienttimeout is not implemented for IPC connections
<bitcoin-git> bitcoin/master 9ec4efe merge-script: Merge bitcoin/bitcoin#35015: bitcoin-cli: note -rpcclienttimeout is not im...
<bitcoin-git> [bitcoin] sedited merged pull request #35015: bitcoin-cli: note -rpcclienttimeout is not implemented for IPC connections (master...pr/ipc-timeout) https://github.com/bitcoin/bitcoin/pull/35015
enochazariah has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] maflcko opened pull request #35379: test: Fix feature_dbcrash.py --usecli error (master...2605-test-use-cli) https://github.com/bitcoin/bitcoin/pull/35379
enochazariah has quit [Ping timeout: 245 seconds]
satoshinakamoto has joined #bitcoin-core-dev
satoshinakamoto has quit [Client Quit]
<bitcoin-git> [bitcoin] sedited pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/9ec4efebd1e3...9767e80b2138
<bitcoin-git> bitcoin/master fa9c2dd MarcoFalke: doc: Fix to use lower-case anchors in links to C++ Core Guidelines
<bitcoin-git> bitcoin/master fa37606 MarcoFalke: doc: Regroup clang-tidy rules
<bitcoin-git> bitcoin/master fa0202f MarcoFalke: doc: move-only Python section
<bitcoin-git> [bitcoin] sedited merged pull request #35296: doc: Fix broken links in dev notes, move sections (master...2605-doc-fix-links) https://github.com/bitcoin/bitcoin/pull/35296
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 254 seconds]
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
enochazariah has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
smartin has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
<maflcko> Looks like GitHub is down again and suspeneded Actions??
<maflcko> When was the last day that GitHub was working for full 24hours in a go?
<janb84> maflcko: "degraded availability" so yes, bloody awful.
<bitcoin-git> [bitcoin] sedited pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9767e80b2138...ac9424fdc633
<bitcoin-git> bitcoin/master 1d66963 ViniciusCestarii: log: clarify VerifyDB summary log
<bitcoin-git> bitcoin/master ac9424f merge-script: Merge bitcoin/bitcoin#35145: validation: fix misleading VerifyDB summary l...
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Read error: Connection reset by peer]
brunoerg has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
bitdex has joined #bitcoin-core-dev
cotsuka has joined #bitcoin-core-dev
Guest52 has joined #bitcoin-core-dev
Guest52 has quit [Client Quit]
<bitcoin-git> [bitcoin] ryanofsky pushed 16 commits to master: https://github.com/bitcoin/bitcoin/compare/ac9424fdc633...a4157fc24a29
<bitcoin-git> bitcoin/master 63ee9cd Sjors Provoost: test: misc interface_ipc_mining.py improvements
<bitcoin-git> bitcoin/master 63b23ea Sjors Provoost: test: regression test for waitNext mining policy
<bitcoin-git> bitcoin/master 24750f8 Sjors Provoost: test: add createNewBlock failure helper
<bitcoin-git> [bitcoin] ryanofsky merged pull request #33966: refactor: disentangle miner startup defaults from runtime options (master...2025/11/miner-options) https://github.com/bitcoin/bitcoin/pull/33966
nymius has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
<bitcoin-git> [bitcoin] pzafonte opened pull request #35380: kernel: expose witness stack items for btck_TransactionInput (master...kernel-api-txin-witness-stack) https://github.com/bitcoin/bitcoin/pull/35380
enochazariah has quit [Quit: Ping timeout (120 seconds)]
enochazariah has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] rkrux opened pull request #35381: Wallet optinrbf deprecation followups (master...walletrbf2) https://github.com/bitcoin/bitcoin/pull/35381
BrandonOdiwuor has quit [Quit: Client closed]
<bitcoin-git> [bitcoin] pzafonte opened pull request #35382: kernel: expose btck_transaction_input_get_script_sig (master...kernel-api-txin-script-sig) https://github.com/bitcoin/bitcoin/pull/35382
enochazariah has quit [Ping timeout: 245 seconds]
<bitcoin-git> [bitcoin] sedited pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a4157fc24a29...9c1502226044
<bitcoin-git> bitcoin/master 2e9fdcc Guillermo Fernandes: doc: add feature deprecation and removal process to developer notes
<bitcoin-git> bitcoin/master 9c15022 merge-script: Merge bitcoin/bitcoin#35337: doc: add feature deprecation and removal proc...
<bitcoin-git> [bitcoin] sedited merged pull request #35337: doc: add feature deprecation and removal process to developer notes (master...doc/deprecation-removal-process-v2) https://github.com/bitcoin/bitcoin/pull/35337
enochazariah has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
memset_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
memset_ has quit [Remote host closed the connection]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
flooded has joined #bitcoin-core-dev
_flood has joined #bitcoin-core-dev
flooded has quit [Ping timeout: 252 seconds]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
bitdex has quit [Quit: = ""]
smartin has joined #bitcoin-core-dev
<darosior> stickies-v: i think you made a typo in the PR number in https://github.com/bitcoin/bitcoin/pull/35382#pullrequestreview-4364168648
<stickies-v> ty, fixed
brunoerg has quit [Read error: Connection reset by peer]
GoldenGoose has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
sliv3r__ has quit [Quit: ZNC 1.8.2+deb3.1+deb12u1 - https://znc.in]
sliv3r__ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] DrahtBot closed pull request #35379: test: Fix feature_dbcrash.py --usecli error (master...2605-test-use-cli) https://github.com/bitcoin/bitcoin/pull/35379
<bitcoin-git> [bitcoin] DrahtBot reopened pull request #35379: test: Fix feature_dbcrash.py --usecli error (master...2605-test-use-cli) https://github.com/bitcoin/bitcoin/pull/35379
<bitcoin-git> [bitcoin] pzafonte closed pull request #35382: kernel: expose btck_transaction_input_get_script_sig (master...kernel-api-txin-script-sig) https://github.com/bitcoin/bitcoin/pull/35382
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Read error: Connection reset by peer]
sliv3r__ has quit [Quit: ZNC 1.8.2+deb3.1+deb12u1 - https://znc.in]
sliv3r__ has joined #bitcoin-core-dev
GoldenGoose has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] sh011 opened pull request #35384: Fix for #35373. Updated Error Message (master...sh011-35373-improve-error-msg) https://github.com/bitcoin/bitcoin/pull/35384
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] rkrux opened pull request #35385: test: restore JSONRPCException error format (master...jsonrpcexception) https://github.com/bitcoin/bitcoin/pull/35385
<dergoegge> josie abubakarsadiq RubenSomsen: just curious, what are you guys cooking up over here https://github.com/2140-dev/bitcoin?
<bitcoin-git> [bitcoin] willcl-ark opened pull request #35386: doc: add an AI contribution policy (master...ai-contributions) https://github.com/bitcoin/bitcoin/pull/35386
abubakarsadiq has joined #bitcoin-core-dev
<abubakarsadiq> dergoegge: 2140-dev/bitcoin is a fork of bitcoin-core where we at the 2140 team will marinate bigger, more intrusive ideas and have an e2e implementation that is well-tested and running in production. The plan is to take a move-fast-break-things approach and have most edge cases and ideas more thoroughly thought through before proposing to port them upstream to bitcoin/bitcoin.
<abubakarsadiq> However, we will ping experts on certain components for conceptual feedback in the early stages, so we are not working in silos.
<abubakarsadiq> It's also not limited to the 2140 team anyone is welcome to propose ideas and PRs there.
<abubakarsadiq> The readme will be updated with this information.
<dergoegge> I see, thanks for explaining
nymius has quit [Quit: nymius]
bugs_ has joined #bitcoin-core-dev
kinlo has quit [Quit: !]
bomb-on has quit [Remote host closed the connection]
bomb-on has joined #bitcoin-core-dev
enochazariah has quit [Ping timeout: 245 seconds]
eugenesiegel has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
kinlo has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 258 seconds]
andrewtoth_ has joined #bitcoin-core-dev
_andrewtoth_ has quit [Remote host closed the connection]
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
cotsuka has quit [Remote host closed the connection]
cotsuka has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
afiore has joined #bitcoin-core-dev
nymius has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
<bitcoin-git> [gui] johnny9 closed pull request #933: [DRAFT] Introduce Qt test automation bridge and gui functional tests (master...qt-test-bridge) https://github.com/bitcoin-core/gui/pull/933
S3RK has joined #bitcoin-core-dev
Chris_Stewart_5 has joined #bitcoin-core-dev
S3RK_ has quit [Ping timeout: 246 seconds]
<bitcoin-git> [gui-qml] pseudoramdom opened pull request #727: Watch-only wallet, wallet loading status (qt6...wallet-loading-status) https://github.com/bitcoin-core/gui-qml/pull/727
l0rinc has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
afiore has quit [Remote host closed the connection]
afiore has joined #bitcoin-core-dev
twistedline has quit [Ping timeout: 244 seconds]
twistedline has joined #bitcoin-core-dev
adys1 has quit [Ping timeout: 259 seconds]
<bitcoin-git> [gui-qml] pseudoramdom closed pull request #686: qml: Validate wallet name during wallet creation (qt6...duplicate-wallet-name) https://github.com/bitcoin-core/gui-qml/pull/686
instagibbs has quit [Quit: Ping timeout (120 seconds)]
instagibbs has joined #bitcoin-core-dev
adys has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg_ has joined #bitcoin-core-dev
brunoerg has quit [Read error: Connection reset by peer]
brunoerg_ has quit [Ping timeout: 256 seconds]
adys6 has joined #bitcoin-core-dev
adys has quit [Ping timeout: 244 seconds]
adys6 is now known as adys
adys has quit [Read error: Connection reset by peer]
adys has joined #bitcoin-core-dev
skr0 has joined #bitcoin-core-dev
skr0 has quit [Client Quit]
bomb-on has quit [Ping timeout: 256 seconds]
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
bomb-on has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] ryanofsky opened pull request #35387: logging: make trace logging easily usable (master...pr/loglevel) https://github.com/bitcoin/bitcoin/pull/35387
<eugenesiegel> I want to propose a change that creates an interface between net_processing and validation so the net_processing code is nicely separated (and easier, quicker to fuzz). Is this something that should have a tracking issue first so debate on the approach can happen there?
<darosior> eugenesiegel: what type of interface? Would they still leave in the same thread? Would you propose something like a "validation queue" that previously floated?
<darosior> Sorry i realize i don't reply to your question. I don't have an answer to tracking issue or not.
<eugenesiegel> Uh I might be misunderstanding your question, but this interface would just allow mocking any calls to chainman. _aj_ mentioned a PeerManChainPoolInterface here (https://github.com/bitcoin/bitcoin/issues/27502#issuecomment-1681492139) and it's pretty much that. I had claude prototype the interface and use it instead of a TestingSetup in a fuzz
<eugenesiegel> test. I'll need to de-claude the patch
<eugenesiegel> threading shouldn't be a concern here
<eugenesiegel> it allows the fuzzer to set return values of functions like LoadingBlocks(), ProcessNewBlockHeaders, etc
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
eugenesiegel has quit [Ping timeout: 245 seconds]
smartin has quit [Remote host closed the connection]
nymius has quit [Quit: nymius]
l0rinc has quit [Quit: l0rinc]