achow101 changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 16:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
brunoerg has joined #bitcoin-core-dev
bitdex has quit [Ping timeout: 252 seconds]
brunoerg has quit [Ping timeout: 256 seconds]
<_aj_> _aj_ mentioned a PeerManChainPoolInterface here
<_aj_> oops
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 274 seconds]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
tinova4 has quit [Quit: Ping timeout (120 seconds)]
tinova4 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
adil has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
brunoerg has quit [Ping timeout: 245 seconds]
sliv3r__ has quit [Quit: ZNC 1.8.2+deb3.1+deb12u1 - https://znc.in]
sliv3r__ has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 244 seconds]
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
adil1 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
adil has quit [Ping timeout: 246 seconds]
adil1 is now known as adil
adil has quit [Quit: adil]
bitdex has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
satsfy has quit [Ping timeout: 252 seconds]
cfields has quit [Quit: No Ping reply in 180 seconds.]
reardencode has quit [Ping timeout: 248 seconds]
satsfy has joined #bitcoin-core-dev
cfields has joined #bitcoin-core-dev
reardencode has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
kevkevin has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 258 seconds]
kevkevin has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 249 seconds]
brunoerg has quit [Ping timeout: 256 seconds]
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
afiore has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
<bitcoin-git> [gui-qml] johnny9 closed pull request #565: Watch only wallet (qt6...watch-only-wallet) https://github.com/bitcoin-core/gui-qml/pull/565
brunoerg has quit [Ping timeout: 245 seconds]
afiore has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
<lightlike> eugenesiegel: I would say yes to opening an issue, just "tracking issue" is the wrong term at this stage. An issue (or alternatively a draft PR) where you detail your proposal for conceptual discussion would be the way to go. Individual PRs and and possibly a separate issue tracking them would naturally come after conceptual buy-in from others.
brunoerg has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 269 seconds]
kevkevin has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 276 seconds]
kevkevin has joined #bitcoin-core-dev
BUSY has quit [Ping timeout: 276 seconds]
brunoerg has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
BUSY has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 245 seconds]
kevkevin has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
GoldenGoose has quit [Ping timeout: 268 seconds]
GoldenGoose has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] rustaceanrob opened pull request #35390: contrib: Add `compare-benches` tool (master...26-5-26-compare-bench) https://github.com/bitcoin/bitcoin/pull/35390
brunoerg has quit [Ping timeout: 253 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
<ekzyis> how much interest is there still in adding honggfuzz: https://github.com/bitcoin-core/qa-assets/issues/267? the ticket is 2 years old, and I'm thinking, "maybe it's more important to review fuzzing PRs?"
twistedline has quit [Remote host closed the connection]
twistedline has joined #bitcoin-core-dev
<nkaretnikov> ekzyis: what is the current state of fuzzing efforts? what tools are being used and what is being fuzzed?
l0rinc has quit [Quit: l0rinc]
brunoerg has quit [Ping timeout: 244 seconds]
aleggg has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 256 seconds]
cotsuka has quit [Read error: Connection reset by peer]
brunoerg has joined #bitcoin-core-dev
cotsuka has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
kevkevin has quit [Ping timeout: 244 seconds]
Guyver2 has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] Sjors closed pull request #34970: init: add -test=pause_load_mempool, test mempool save before loaded (master...2026/03/pause-mempool-load) https://github.com/bitcoin/bitcoin/pull/34970
brunoerg has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 276 seconds]
BrandonOdiwuor has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
<bitcoin-git> [bitcoin] maflcko opened pull request #35391: test: Use operator for time_points instead of manual TickSinceEpoch (master...2605-test-iwyu-op-less-less) https://github.com/bitcoin/bitcoin/pull/35391
brunoerg has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] maflcko closed pull request #35318: fuzz: Bound package eval tx fanout (master...fuzz-package-eval-bounds) https://github.com/bitcoin/bitcoin/pull/35318
brunoerg has quit [Ping timeout: 245 seconds]
sliv3r__ has quit [Quit: ZNC 1.8.2+deb3.1+deb12u1 - https://znc.in]
sliv3r__ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] maflcko closed pull request #34839: doc: remove unshipped doc references from help and warning text (master...doc/unshipped-doc-links-helptext) https://github.com/bitcoin/bitcoin/pull/34839
brunoerg has joined #bitcoin-core-dev
<maflcko> ekzyis: I'd say it can be considered, if it has meaningfully different coverage instrumentation. (Haven't looked into it at all)
brunoerg has quit [Ping timeout: 248 seconds]
kevkevin has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] Sjors opened pull request #35392: test: add v31.0 and basic IPC backward compatibility check (master...2026/05/backward-v31-ipc) https://github.com/bitcoin/bitcoin/pull/35392
kevkevin has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
brunoerg has quit [Ping timeout: 256 seconds]
cotsuka has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
eugenesiegel has joined #bitcoin-core-dev
<eugenesiegel> lightlike: ok thanks, I will open an issue for discussion
sliv3r__ has quit [Quit: ZNC 1.8.2+deb3.1+deb12u1 - https://znc.in]
sliv3r__ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] sedited pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/9c1502226044...0687438e94d7
<bitcoin-git> bitcoin/master a815e3e Hodlinator: rpc: Correct type for tx_sigops
<bitcoin-git> bitcoin/master 0774eaa Hodlinator: util: Require integers for SaturatingAdd() and AdditionOverflow()
<bitcoin-git> bitcoin/master 0687438 merge-script: Merge bitcoin/bitcoin#35372: refactor: Enhance type safety in overflow ope...
<bitcoin-git> [bitcoin] sedited merged pull request #35372: refactor: Enhance type safety in overflow operations (master...2026/05/overflow_ints) https://github.com/bitcoin/bitcoin/pull/35372
brunoerg has quit [Ping timeout: 244 seconds]
brunoerg has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 267 seconds]
<ekzyis> nkaretnikov: libfuzzer and afl++ is used, see linked qa-assets repo. can't tell you much more, i am new to fuzzing myself. you can start at doc/fuzzing.md i guess
<ekzyis> maflcko: ok thx
<eugenesiegel> honggfuzz once found an integer issue that libfuzzer / afl did not, but I think that may have just been bias in the fuzzing harnesses
<bitcoin-git> [bitcoin] Sjors opened pull request #35393: 2026/05/empty template (master...2026/05/empty-template) https://github.com/bitcoin/bitcoin/pull/35393
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 271 seconds]
<nkaretnikov> ekzyis: I remembered there’s also this project from dergoegge https://github.com/dergoegge/fuzzamoto but I’m not sure how the fuzzing effort is organized here. is there a dedicated fuzzing group or is it random people? IIRC brink donates infra to core, are fuzzers running 24/7? who is configuring them and triaging crashes?
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 264 seconds]
<nkaretnikov> In general fuzzing is both tooling and researcher’s time/creativity. So setting them up and forgetting doesn’t make sense to me. It needs to be a constant process of improving coverage and looking at crashes. As well as doing something to increase speed of fuzz tooling etc.
<nkaretnikov> One related issue that I’ve started to work on is making standard test coverage more visible. It needs to be on CI to increase the baseline of what’s being tested normally. Not directly related to fuzzing but has implications.
<dergoegge> Hi Nikita! We have ~250 harnesses in the main repo (bitcoin/bitcoin), there's fuzzamoto, and there's also https://github.com/bitcoinfuzz/bitcoinfuzz. All of these are fuzzing 24/7. The harnesses in the main repo get fuzzed on oss-fuzz and also on machines of various contributors.
brunoerg has joined #bitcoin-core-dev
<dergoegge> There are people (e.g. me) that spend a lot of their time on fuzzing. There is an irc channel (#bitcoin-core-fuzzing) for the fuzzing working group, although that chat is pretty quiet
<dergoegge> Let me know if you have any other questions
brunoerg has quit [Ping timeout: 265 seconds]
cfields has quit [Ping timeout: 252 seconds]
cfields has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] willcl-ark opened pull request #35394: test: remove unnecessary rpc calls from feature_dbcrash (master...faster-dbcrash) https://github.com/bitcoin/bitcoin/pull/35394
<ekzyis> cool, didn't know about that irc channel. would you prefer we ask questions there?
kevkevin has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
<nkaretnikov> dergoegge: yeah, I’ll follow up on the fuzzing channel.
kevkevin has quit [Ping timeout: 240 seconds]
brunoerg has quit [Ping timeout: 252 seconds]
<bitcoin-git> [bitcoin] Sjors closed pull request #35392: test: add v31.0 and basic IPC backward compatibility check (master...2026/05/backward-v31-ipc) https://github.com/bitcoin/bitcoin/pull/35392
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0687438e94d7...615c0aefa8fd
<bitcoin-git> bitcoin/master fad4f41 MarcoFalke: test: Use operator<< for time_points instead of manual TickSinceEpoch
<bitcoin-git> bitcoin/master 615c0ae merge-script: Merge bitcoin/bitcoin#35391: test: Use operator<< for time_points instead ...
<bitcoin-git> [bitcoin] fanquake merged pull request #35391: test: Use operator for time_points instead of manual TickSinceEpoch (master...2605-test-iwyu-op-less-less) https://github.com/bitcoin/bitcoin/pull/35391
<dergoegge> ekzyis: no strong preference but the fuzzing channel should have most folks in it that are interested
bomb-on has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 248 seconds]
brunoerg has quit [Ping timeout: 272 seconds]
kevkevin has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
bitdex has quit [Quit: = ""]
<bitcoin-git> [bitcoin] Sjors closed pull request #35393: mining: add always_add_coinbase_commitment option (master...2026/05/empty-template) https://github.com/bitcoin/bitcoin/pull/35393
<Sjors[m]> Net open pull requests today: 0 :-)
<fjahr> sjors is pr-neutral
BrandonOdiwuor has quit [Ping timeout: 245 seconds]
<bitcoin-git> [bitcoin] stickies-v closed pull request #33943: kernel: don't use assert to handle invalid user input (master...2025-11/kernel-less-assert) https://github.com/bitcoin/bitcoin/pull/33943
szarka has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/615c0aefa8fd...85c27c9de569
<bitcoin-git> bitcoin/master c17cc76 will: test: speed up feature_dbcrash
<bitcoin-git> bitcoin/master 85c27c9 merge-script: Merge bitcoin/bitcoin#35394: test: remove unnecessary rpc calls from featu...
<bitcoin-git> [bitcoin] fanquake merged pull request #35394: test: remove unnecessary rpc calls from feature_dbcrash (master...faster-dbcrash) https://github.com/bitcoin/bitcoin/pull/35394
cotsuka has quit [Read error: Connection reset by peer]
<bitcoin-git> [bitcoin] hebasto opened pull request #35395: doc: Improve test suite dependencies documentation (master...260527-ft-needed) https://github.com/bitcoin/bitcoin/pull/35395
cotsuka has joined #bitcoin-core-dev
eugenesiegel has quit [Quit: Client closed]
bugs_ has joined #bitcoin-core-dev
brunoerg_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
justache has quit [Quit: ZNC 1.10.1 - https://znc.in]
justache has joined #bitcoin-core-dev
GoldenGoose has quit [Remote host closed the connection]
GoldenGoose has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/85c27c9de569...00af5620f01d
<bitcoin-git> bitcoin/master d5adb9d Matthew Zipkin: doc: fix doxygen links to threads in developer-notes.md
<bitcoin-git> bitcoin/master 00af562 merge-script: Merge bitcoin/bitcoin#35206: doc: fix doxygen links to threads in develope...
<bitcoin-git> [bitcoin] fanquake merged pull request #35206: doc: fix doxygen links to threads in developer-notes.md (master...doxygen-threads) https://github.com/bitcoin/bitcoin/pull/35206
<bitcoin-git> [bitcoin] maflcko opened pull request #35396: ci: Rewrite broken wrap-valgrind.sh to .py (master...2605-ci-less-sh) https://github.com/bitcoin/bitcoin/pull/35396
brunoerg has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
brunoerg_ has quit [Ping timeout: 276 seconds]
memset has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake opened pull request #35397: ci: add OpenBSD Clang cross job (master...openbsd_clang_cross) https://github.com/bitcoin/bitcoin/pull/35397
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
jonatack has quit [Quit: WeeChat 4.9.0]
<fanquake> Looking for any more opinions/review in https://github.com/bitcoin-core/leveldb-subtree/pull/61
<b10c> got matching hashes between a Nix-built bitcoind and the v31.0 bitcoind for x86_64-pc-linux-gnu built with Guix 😎 wen cross toolchain reproducible bulids? https://b10c.me/projects/027-bitcoind-gunix-match/
<nkaretnikov> I mean that’s not very surprising since they are based on the same idea. Guix also uses the nix daemon. So if you provide the same input you get the same output in both. The difference is the layer of scheme on top compared to nix
<b10c> and a few other, minor, differences between the two
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
<sipa> nkaretnikov: guix uses the nix daemon?
<darosior> that sounds surprising. The guix daemon is written in GNU Guile
<nkaretnikov> sipa: at least it used to when i worked on it a long time ago. maybe they rewrote it since then, so i guess i should not have said it so confidently. a historical note: ludovic created guix because he was a nixos user, but wanted nix with only free software, and he was a guile developer, so he wanted the flexibility of scheme instead of nix. i was the first contributor to guix and worked with ludovic the first two
<nkaretnikov> years of the project and at the time it definitely used the nix daemon.
<nkaretnikov> darosior: yeah, ignore it then. they must have ported it in the meantime.
jonatack has joined #bitcoin-core-dev
robszarka has joined #bitcoin-core-dev
<nkaretnikov> speaking of nix, can we reach some decision here? https://github.com/bitcoin/bitcoin/pull/35375 i feel like i responded to a lot of concerns, made compromises, and i honestly don’t understand what the big deal is with getting this merged. there’s more discussion on that PR compared to the text in the PR itself. right now it sits at 1 ack and 1 nack and people are also discussing what to do with installation docs in
<nkaretnikov> general. what do you do in cases like this? just let it sit opened until acks or nacks outbalance each other? will it get closed automatically at some point. when i started this, i thought “hey, let me do a 30 min PR since i already did all that work” and now it’s been two days of discussion with no action.
szarka has quit [Ping timeout: 248 seconds]
<ekzyis> nkaretnikov: i think you need to have more patience
<nkaretnikov> ekzyis: i’m happy to wait, it’s the first pr i’ve opened so i’m not familiar with the process. i also don’t like indeterminate states with no action or decision maker. i want to open more prs in the future, but if a doc change is taking so long, i don’t know what i should expect for code changes.
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 244 seconds]
bomb-on has joined #bitcoin-core-dev
<pinheadmz> nkaretnikov this project is overwhelmed with work and underpowered by contributors. expect everything, even doc changes, to take a long time. I authored a doc update a month ago that just got merged today
<pinheadmz> show everyone you are patient and have other work to do while you wait, and your reputation will increase
<nkaretnikov> ok
<pinheadmz> :-) and welcome to the club !
<nkaretnikov> ty
jonatack has joined #bitcoin-core-dev