#bitcoin-core-dev on 2026-05-18 — searchable irc log

2025-01-16 14:22 achow101 changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 16:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt

00:05 cotsuka has quit [Read error: Connection reset by peer]

00:05 cotsuka has joined #bitcoin-core-dev

00:24 kevkevin has joined #bitcoin-core-dev

00:29 kevkevin has quit [Ping timeout: 276 seconds]

00:35 cotsuka has quit [Read error: Connection reset by peer]

00:37 cotsuka has joined #bitcoin-core-dev

00:59 bitdex has quit [Ping timeout: 276 seconds]

01:03 greypw1495085720 has quit [Remote host closed the connection]

01:04 greypw1495085720 has joined #bitcoin-core-dev

01:21 <bitcoin-git> [bitcoin] savagemechanic opened pull request #35311: test: cover generateblock fee behavior (master...doc-generateblock-fees) https://github.com/bitcoin/bitcoin/pull/35311

01:35 cotsuka has quit [Read error: Connection reset by peer]

01:37 cotsuka has joined #bitcoin-core-dev

01:43 stringintech has quit [Quit: Ping timeout (120 seconds)]

01:44 stringintech has joined #bitcoin-core-dev

01:49 bitdex has joined #bitcoin-core-dev

02:00 Flow has quit [Quit: WeeChat 4.7.2]

02:01 Flow has joined #bitcoin-core-dev

02:05 cotsuka has quit [Read error: Connection reset by peer]

02:07 cotsuka has joined #bitcoin-core-dev

02:44 jetpack has quit [Ping timeout: 255 seconds]

02:53 bitdex has quit [Ping timeout: 276 seconds]

03:05 cotsuka has quit [Read error: Connection reset by peer]

03:07 cotsuka has joined #bitcoin-core-dev

03:08 bitdex has joined #bitcoin-core-dev

03:35 cotsuka has quit [Read error: Connection reset by peer]

03:35 cotsuka has joined #bitcoin-core-dev

04:01 cmirror has joined #bitcoin-core-dev

04:35 cotsuka has quit [Read error: Connection reset by peer]

04:37 cotsuka has joined #bitcoin-core-dev

05:05 cotsuka has quit [Read error: Connection reset by peer]

05:07 cotsuka has joined #bitcoin-core-dev

05:07 memset has quit [Remote host closed the connection]

05:18 memset has joined #bitcoin-core-dev

05:51 memset has quit [*.net *.split]

05:51 bitdex has quit [*.net *.split]

05:51 ghost43 has quit [*.net *.split]

05:51 greypw1495085720 has quit [*.net *.split]

05:51 SpellChecker_ has quit [*.net *.split]

05:51 vasild has quit [*.net *.split]

05:51 andrewtoth_ has quit [*.net *.split]

05:51 ChanServ has quit [*.net *.split]

05:54 GoldenGoose has quit [Remote host closed the connection]

05:55 ChanServ has joined #bitcoin-core-dev

05:56 SpellChecker has joined #bitcoin-core-dev

05:57 ghost43 has joined #bitcoin-core-dev

05:57 bitdex has joined #bitcoin-core-dev

06:01 vasild has joined #bitcoin-core-dev

06:01 memset has joined #bitcoin-core-dev

06:05 cotsuka has quit [Read error: Connection reset by peer]

06:07 cotsuka has joined #bitcoin-core-dev

06:10 <bitcoin-git> [bitcoin] maflcko closed pull request #35311: test: cover generateblock fee behavior (master...doc-generateblock-fees) https://github.com/bitcoin/bitcoin/pull/35311

06:16 justache has quit [Read error: Connection reset by peer]

06:20 vasild has quit [Remote host closed the connection]

06:20 vasild has joined #bitcoin-core-dev

06:20 justache has joined #bitcoin-core-dev

06:21 GoldenGoose has joined #bitcoin-core-dev

06:38 <bitcoin-git> [bitcoin] stringintech opened pull request #35312: kernel: assert invalid buffer preconditions in `btck_*_create` functions (master...2026/05/kernel-assert-buffer-preconditions) https://github.com/bitcoin/bitcoin/pull/35312

06:58 upekkha has quit []

06:58 upekkha has joined #bitcoin-core-dev

06:58 upekkha has quit [Client Quit]

06:59 upekkha has joined #bitcoin-core-dev

06:59 upekkha has quit [Client Quit]

07:00 upekkha has joined #bitcoin-core-dev

07:01 upekkha has quit [Client Quit]

07:01 upekkha has joined #bitcoin-core-dev

07:13 l0rinc has joined #bitcoin-core-dev

07:30 satsfy has quit [Ping timeout: 265 seconds]

07:33 satsfy has joined #bitcoin-core-dev

07:45 antanst7125 has quit [Quit: The Lounge - https://thelounge.chat]

07:45 antanst71255 has joined #bitcoin-core-dev

07:49 Guyver2 has joined #bitcoin-core-dev

07:59 szkl has joined #bitcoin-core-dev

08:17 enochazariah has joined #bitcoin-core-dev

08:18 enochazariah31 has joined #bitcoin-core-dev

08:22 enochazariah has quit [Ping timeout: 245 seconds]

08:23 enochazariah31 has quit [Ping timeout: 245 seconds]

08:26 enochazariah has joined #bitcoin-core-dev

08:27 enochazariah66 has joined #bitcoin-core-dev

08:28 zumbi has quit [Server closed connection]

08:28 zumbi has joined #bitcoin-core-dev

08:30 enochazariah has quit [Ping timeout: 245 seconds]

08:34 Guyver2 has left #bitcoin-core-dev [Closing Window]

09:27 aleggg has quit [Ping timeout: 264 seconds]

09:28 aleggg has joined #bitcoin-core-dev

09:33 mbrochh has quit [Server closed connection]

09:33 mbrochh has joined #bitcoin-core-dev

09:34 enochazariah66 has quit [Quit: Client closed]

09:40 mbrochh has quit [*.net *.split]

09:40 antanst71255 has quit [*.net *.split]

09:40 mbrochh has joined #bitcoin-core-dev

09:41 antanst71255 has joined #bitcoin-core-dev

10:00 furszy has quit [Server closed connection]

10:01 enochazariah has joined #bitcoin-core-dev

10:01 furszy has joined #bitcoin-core-dev

10:05 cotsuka has quit [Read error: Connection reset by peer]

10:07 cotsuka has joined #bitcoin-core-dev

10:10 enochazariah has quit [Quit: Ping timeout (120 seconds)]

10:18 durandal_ has quit [Remote host closed the connection]

10:18 durandal_ has joined #bitcoin-core-dev

10:27 <bitcoin-git> [bitcoin-maintainer-tools] hebasto opened pull request #199: github-merge: Allow using git submodules (main...260518-merge-subtree) https://github.com/bitcoin-core/bitcoin-maintainer-tools/pull/199

10:27 l0rinc has quit [Quit: l0rinc]

10:31 enochazariah has joined #bitcoin-core-dev

10:31 l0rinc has joined #bitcoin-core-dev

10:35 <bitcoin-git> [leveldb-subtree] fanquake pushed 3 commits to bitcoin-fork: https://github.com/bitcoin-core/leveldb-subtree/compare/ab6c84e6f38f...70142e186bca

10:35 <bitcoin-git> leveldb-subtree/bitcoin-fork 31361bf Victor Costan: Allow different C/C++ standards when this is used as a subproject.

10:35 <bitcoin-git> leveldb-subtree/bitcoin-fork d123cf5 Victor Costan: Effectively, this change

10:35 <bitcoin-git> leveldb-subtree/bitcoin-fork 70142e1 merge-script: Merge bitcoin-core/leveldb-subtree#55: build: Require C++17

10:35 <bitcoin-git> [leveldb-subtree] fanquake merged pull request #55: build: Require C++17 (bitcoin-fork...5-28-25-C++-version-required) https://github.com/bitcoin-core/leveldb-subtree/pull/55

10:38 <bitcoin-git> [leveldb-subtree] fanquake pushed 2 commits to bitcoin-fork: https://github.com/bitcoin-core/leveldb-subtree/compare/70142e186bca...68740f586f08

10:38 <bitcoin-git> leveldb-subtree/bitcoin-fork 0711e6d Hennadii Stepanov: Fix Clang `-Wconditional-uninitialized` warning

10:38 <bitcoin-git> leveldb-subtree/bitcoin-fork 68740f5 merge-script: Merge bitcoin-core/leveldb-subtree#59: Fix Clang `-Wconditional-uninitiali...

10:38 <bitcoin-git> [leveldb-subtree] fanquake merged pull request #59: Fix Clang `-Wconditional-uninitialized` warning (bitcoin-fork...260203-uninitialized) https://github.com/bitcoin-core/leveldb-subtree/pull/59

10:39 <bitcoin-git> [leveldb-subtree] fanquake pushed 2 commits to bitcoin-fork: https://github.com/bitcoin-core/leveldb-subtree/compare/68740f586f08...c274b508676d

10:39 <bitcoin-git> leveldb-subtree/bitcoin-fork 85665f9 Hennadii Stepanov: refactor: Delete unused `ScopedHandle:operator=(ScopedHandle&&)`

10:39 <bitcoin-git> leveldb-subtree/bitcoin-fork c274b50 merge-script: Merge bitcoin-core/leveldb-subtree#53: refactor: Delete unused `ScopedHand...

10:39 <bitcoin-git> [leveldb-subtree] fanquake merged pull request #53: refactor: Delete unused `ScopedHandle:operator=(ScopedHandle&&)` (bitcoin-fork...250517-unused) https://github.com/bitcoin-core/leveldb-subtree/pull/53

10:48 <bitcoin-git> [bitcoin] fanquake opened pull request #35313: Bump leveldb subtree (master...bump_leveldb_subtree) https://github.com/bitcoin/bitcoin/pull/35313

10:58 enochazariah has quit [Ping timeout: 245 seconds]

11:04 durandal_ has quit [*.net *.split]

11:04 cotsuka has quit [*.net *.split]

11:04 antanst71255 has quit [*.net *.split]

11:04 szkl has quit [*.net *.split]

11:05 antanst71255 has joined #bitcoin-core-dev

11:05 szkl has joined #bitcoin-core-dev

11:05 durandal_ has joined #bitcoin-core-dev

11:05 durandal_ has quit [Remote host closed the connection]

11:06 durandal_ has joined #bitcoin-core-dev

11:09 cotsuka has joined #bitcoin-core-dev

11:33 Robotico has joined #bitcoin-core-dev

11:38 reardencode has quit [Server closed connection]

11:39 reardencode has joined #bitcoin-core-dev

11:42 Robotico has quit [Quit: Leaving]

11:52 furszy has quit [Quit: ZNC - https://znc.in]

12:22 ___nick___ has joined #bitcoin-core-dev

12:30 strat___ has quit [Server closed connection]

12:30 strat___ has joined #bitcoin-core-dev

12:39 bitdex has quit [Quit: = ""]

12:45 kevkevin has joined #bitcoin-core-dev

12:56 memset_ has joined #bitcoin-core-dev

12:58 memset has quit [Remote host closed the connection]

13:05 kevkevin has quit [Read error: Connection reset by peer]

13:05 kevkevin has joined #bitcoin-core-dev

13:06 ___nick___ has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]

13:07 ozdeadman has quit [Ping timeout: 246 seconds]

13:07 deadmanoz has joined #bitcoin-core-dev

13:08 ___nick___ has joined #bitcoin-core-dev

13:08 ___nick___ has quit [Client Quit]

13:10 ___nick___ has joined #bitcoin-core-dev

13:19 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7802e578c3f1...b2a3ca3df901

13:19 <bitcoin-git> bitcoin/master b6c3670 takeshikurosawaa: i2p: clean up SAM error logging

13:19 <bitcoin-git> bitcoin/master b2a3ca3 merge-script: Merge bitcoin/bitcoin#35117: i2p: clean up SESSION CREATE error logging

13:19 <bitcoin-git> [bitcoin] fanquake merged pull request #35117: i2p: clean up SESSION CREATE error logging (master...i2p-session-create-redaction) https://github.com/bitcoin/bitcoin/pull/35117

13:25 brunoerg has joined #bitcoin-core-dev

13:30 enochazariah has joined #bitcoin-core-dev

13:42 <bitcoin-git> [leveldb-subtree] fanquake opened pull request #60: util: use [[fallthrough]] directly (bitcoin-fork...fallthrough_default) https://github.com/bitcoin-core/leveldb-subtree/pull/60

13:45 <bitcoin-git> [gui-qml] hebasto merged pull request #551: Wallet close, settings, and mempool information (qt6...wallet-settings) https://github.com/bitcoin-core/gui-qml/pull/551

13:46 l0rinc has quit [Quit: l0rinc]

13:47 l0rinc has joined #bitcoin-core-dev

13:47 GoldenGoose has quit [Ping timeout: 265 seconds]

13:48 l0rinc has quit [Client Quit]

13:54 <instagibbs> _aj_ in master what are the implications of being in MANDATORY_SCRIPT_VERIFY_FLAGS these days

14:15 GoldenGoose has joined #bitcoin-core-dev

14:15 svanstaa has joined #bitcoin-core-dev

14:16 svanstaa_ has quit [Ping timeout: 268 seconds]

14:19 <darosior> instagibbs: since v30 this just affects the error string IIRC

14:19 * darosior checking

14:19 <instagibbs> Yeah i think so, ends up being just a reporting change

14:21 <instagibbs> in block we've always disconnected regardless, and in mempool we never do so

14:21 <instagibbs> anymore*

14:21 enochazariah11 has joined #bitcoin-core-dev

14:22 <darosior> Yep

14:23 <bitcoin-git> [bitcoin] rustaceanrob opened pull request #35314: kernel: Add `btck_script_pubkey_is_p2tr` (master...26-5-18-is-p2tr) https://github.com/bitcoin/bitcoin/pull/35314

14:24 <instagibbs> ok the STANDARD_BUT_NOT_MANDATORY is basically a "is block context or not" switch

14:24 enochazariah has quit [Ping timeout: 245 seconds]

14:24 <instagibbs> I know I reviewed this PR, just been a minute

14:26 enochazariah11 has quit [Ping timeout: 245 seconds]

14:29 <darosior> yeah, with the caveat that we do call it with consensus flags only also for the mempool (for the cache)

14:32 <instagibbs> sure, GetBlockScripts

14:34 <instagibbs> #29843 related ....

14:34 <corebot> https://github.com/bitcoin/bitcoin/issues/29843 | policy: Allow non-standard scripts with -acceptnonstdtxn=1 (test nets only) by ajtowns · Pull Request #29843 · bitcoin/bitcoin · GitHub

14:44 brunoerg has quit [Remote host closed the connection]

14:45 brunoerg has joined #bitcoin-core-dev

14:48 timbo_xyz has joined #bitcoin-core-dev

14:50 brunoerg has quit [Ping timeout: 268 seconds]

15:02 Lightsword has quit [Server closed connection]

15:03 Lightsword has joined #bitcoin-core-dev

15:11 l0rinc has joined #bitcoin-core-dev

15:16 bugs_ has joined #bitcoin-core-dev

15:21 <bitcoin-git> [bitcoin] maflcko opened pull request #35315: refactor: Use NodeClock::time_point in more places (master...2603-net-less-GetTime) https://github.com/bitcoin/bitcoin/pull/35315

15:27 roconnor_ has joined #bitcoin-core-dev

15:27 roconnor has quit [Ping timeout: 272 seconds]

15:33 <bitcoin-git> [bitcoin] nervana21 opened pull request #35316: musig: Reject empty pubkey list in GetMuSig2KeyAggCache (master...reject-empty-pubkey-list) https://github.com/bitcoin/bitcoin/pull/35316

16:00 andrewtoth_ has joined #bitcoin-core-dev

16:07 deadmanoz has quit [Quit: Leaving]

16:07 deadmanoz has joined #bitcoin-core-dev

16:19 eugenesiegel has joined #bitcoin-core-dev

16:35 enochazariah has joined #bitcoin-core-dev

16:37 timbo_xyz has quit [Ping timeout: 252 seconds]

16:38 timbo_xyz has joined #bitcoin-core-dev

16:42 timbo_xy1 has joined #bitcoin-core-dev

16:43 timbo_xyz has quit [Ping timeout: 252 seconds]

16:55 roconnor_ is now known as roconnor

16:58 <bitcoin-git> [bitcoin] fanquake closed pull request #35114: test: NodeClockContext follow-ups (master...34858-followup) https://github.com/bitcoin/bitcoin/pull/35114

16:58 <bitcoin-git> [bitcoin] fanquake reopened pull request #35114: test: NodeClockContext follow-ups (master...34858-followup) https://github.com/bitcoin/bitcoin/pull/35114

17:00 Guest66 has joined #bitcoin-core-dev

17:02 enochazariah has quit [Ping timeout: 245 seconds]

17:02 Guest66 has quit [Client Quit]

17:12 cotsuka has quit [Remote host closed the connection]

17:13 cotsuka has joined #bitcoin-core-dev

17:22 timbo_xy1 has quit [Remote host closed the connection]

17:22 timbo_xyz has joined #bitcoin-core-dev

17:34 cotsuka has quit [Read error: Connection reset by peer]

17:35 cotsuka has joined #bitcoin-core-dev

17:55 brunoerg has joined #bitcoin-core-dev

17:56 helo has quit [Server closed connection]

17:56 helo has joined #bitcoin-core-dev

17:58 <bitcoin-git> [bitcoin] l0rinc closed pull request #35078: validation: merge `PeekCoin` into `GetCoin` (master...l0rinc/peekcoin-getcoin-merge) https://github.com/bitcoin/bitcoin/pull/35078

17:58 timbo_xyz has quit [Ping timeout: 252 seconds]

18:00 timbo_xyz has joined #bitcoin-core-dev

18:01 brunoerg has quit [Remote host closed the connection]

18:01 brunoerg has joined #bitcoin-core-dev

18:04 theStack has quit [Remote host closed the connection]

18:05 cotsuka has quit [Read error: Connection reset by peer]

18:05 cotsuka has joined #bitcoin-core-dev

18:17 brunoerg_ has joined #bitcoin-core-dev

18:20 brunoerg has quit [Ping timeout: 272 seconds]

18:26 brunoerg_ has quit [Read error: Connection reset by peer]

18:27 brunoerg has joined #bitcoin-core-dev

18:34 brunoerg has quit [Read error: Connection reset by peer]

18:40 mudsip has joined #bitcoin-core-dev

18:42 l0rinc has quit [Quit: l0rinc]

18:44 mudsip has quit [Client Quit]

18:45 <eugenesiegel> It seems like the private broadcast proxy isn't re-used if connect failed to a peer for not supporting v2 transport but had the service flag. I'm not sure if that was overlooked

18:45 mudsip has joined #bitcoin-core-dev

18:46 l0rinc has joined #bitcoin-core-dev

18:47 <fanquake> cc andrewtoth_ vasild

18:54 eugenesiegel has quit [Quit: Client closed]

18:54 damic has quit [Remote host closed the connection]

18:54 eugenesiegel has joined #bitcoin-core-dev

18:58 nanotube has quit [Ping timeout: 245 seconds]

18:59 mudsip has quit []

19:08 jon_atack has joined #bitcoin-core-dev

19:10 jonatack has quit [Ping timeout: 276 seconds]

19:57 cotsuka has quit [Read error: Connection reset by peer]

19:57 cotsuka has joined #bitcoin-core-dev

20:02 ___nick___ has quit [Remote host closed the connection]

20:02 <bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b2a3ca3df901...c7056ff03f63

20:02 <bitcoin-git> bitcoin/master 3f5b3c7 w0xlt: psbt: preserve proprietary fields when combining PSBTs

20:02 <bitcoin-git> bitcoin/master da76985 w0xlt: test: add PSBT proprietary merge regression coverage

20:02 <bitcoin-git> [bitcoin] achow101 merged pull request #34893: psbt: preserve proprietary fields when combining PSBTs (master...psbt-proprietary-merge-fix) https://github.com/bitcoin/bitcoin/pull/34893

20:02 <bitcoin-git> bitcoin/master c7056ff Ava Chow: Merge bitcoin/bitcoin#34893: psbt: preserve proprietary fields when combin...

20:18 da2ce7 has quit [Server closed connection]

20:18 adys has joined #bitcoin-core-dev

20:19 adys has quit [Read error: Connection reset by peer]

20:21 adys has joined #bitcoin-core-dev

20:23 dongcarl0002649 has quit [Server closed connection]

20:23 dongcarl0002649 has joined #bitcoin-core-dev

20:27 da2ce7 has joined #bitcoin-core-dev

20:29 eugenesiegel has quit [Ping timeout: 245 seconds]

20:32 memset_ has quit [Remote host closed the connection]

20:33 memset has joined #bitcoin-core-dev

20:33 afiore has joined #bitcoin-core-dev

20:37 <bitcoin-git> [bitcoin] achow101 pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/c7056ff03f63...4f348c2d730c

20:37 <bitcoin-git> bitcoin/master d21e82b Anthony Towns: ArgsManager: support command-specific options

20:37 <bitcoin-git> bitcoin/master 186354a Anthony Towns: bitcoin-wallet: use command-specific options

20:37 <bitcoin-git> bitcoin/master 33c8090 Anthony Towns: ArgsManager: automate checking for correct command options

20:37 <bitcoin-git> [bitcoin] achow101 merged pull request #28802: ArgsManager: support command-specific options (master...202311-argsman-subcmd-options) https://github.com/bitcoin/bitcoin/pull/28802

20:51 ___nick___ has joined #bitcoin-core-dev

21:10 l0rinc has quit [Quit: l0rinc]

21:21 bugs_ has quit [Quit: Leaving]

21:56 timbo_xyz has quit [Quit: WeeChat 4.8.1]

21:57 cotsuka has quit [Read error: Connection reset by peer]

22:00 cotsuka has joined #bitcoin-core-dev

22:29 brunoerg has joined #bitcoin-core-dev

22:57 cotsuka has quit [Read error: Connection reset by peer]

23:00 cotsuka has joined #bitcoin-core-dev

23:09 brunoerg has quit [Remote host closed the connection]

23:10 brunoerg has joined #bitcoin-core-dev

23:14 brunoerg has quit [Ping timeout: 256 seconds]

23:30 cfields_ has quit [Read error: Connection reset by peer]

23:31 cfields has joined #bitcoin-core-dev