cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
Guest40 has joined #bitcoin-core-dev
Guest40 has quit [Client Quit]
cotsuka has quit [Read error: Connection reset by peer]
kevkevin has quit [Quit: Leaving...]
cotsuka has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
w0xlt has quit [Ping timeout: 264 seconds]
memset_ has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
dzxzg has quit [Remote host closed the connection]
robszarka has joined #bitcoin-core-dev
jerryf has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
szarka has quit [Ping timeout: 246 seconds]
svanstaa_ has quit [Ping timeout: 245 seconds]
svanstaa has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
dzxzg has joined #bitcoin-core-dev
dzxzg has quit [Remote host closed the connection]
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
ghost43 has quit [Ping timeout: 252 seconds]
ghost43 has joined #bitcoin-core-dev
Guest71 has joined #bitcoin-core-dev
Guest71 has quit [Client Quit]
Guest71 has joined #bitcoin-core-dev
Guest71 has quit [Client Quit]
luke-jr_ has quit [Read error: Connection reset by peer]
luke-jr_ has joined #bitcoin-core-dev
<sedited>
it was brought up in the meeting, but might bear repeating since the meeting was quite busy: Feature freeze is in seven days per the release schedule: https://github.com/bitcoin/bitcoin/issues/33607
luke-jr_ has quit [Remote host closed the connection]
luke-jr_ has joined #bitcoin-core-dev
timbo_xyz has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
Guest87 has joined #bitcoin-core-dev
Guest87 has quit [Client Quit]
adys has joined #bitcoin-core-dev
timbo_xyz has quit [Remote host closed the connection]
timbo_xyz has joined #bitcoin-core-dev
aleggg has joined #bitcoin-core-dev
<sliv3r__>
For some reason I am unable to compile using the libfuzzer preset, I though it was my branch but I cannot do it in master neither. (used to work :P). Am I doing something wrong?
<sliv3r__>
I am just using "cmake --preset=libfuzzer" and "cmake --build build_fuzz"
luke-jr_ has quit [Read error: Connection reset by peer]
luke-jr has joined #bitcoin-core-dev
<sliv3r__>
the compilation just fails in src/wallet/transaction.h and src/util/overloaded.h
amadioha has quit [Quit: Client closed]
<vasild>
sliv3r__: what might help - pastebin here the full error; see if CI is using that, if it does and is green then it is probably something in your environment; if it used to work, then git-bisect to find out which commit broke it.
jerryf has quit [Remote host closed the connection]
<sliv3r__>
vasild: that would be nice, will try to see if I can add it
<vasild>
sliv3r__: concept ACK, ping me for review if you PR it :)
<fanquake>
silv3r_-: please don't add checks that hardcode version numbers
<fanquake>
add checks for features that we use
<vasild>
fanquake: doc/dependencies.md already insists a minimum required clang 17.0, stopping early if that is not met would save some developer's time and frustration. IMO it would be no different than e.g. find_package(Boost 1.74.0 REQUIRED CONFIG) which has hardcoded version number.
<fanquake>
vasild: are you adding these hardcoded versions for all known compilers and stdlib combos?
<fanquake>
It seems easier to add a single feature check, for a known requirement, than try and determine every combo of things that may/may not , and then maintain that
<fanquake>
(that's why it's not the same as boost having a known working verison)
<fanquake>
Also not sure if you saw the discussion above, but it seems like the privatebroadcast release notes could be fleshed out somewhat. i.e its somewhat unintuitive that a user could startup with that option, just for things to fail later on, when tor doesn't exist?
<vasild>
fanquake: then how come the contents of doc/dependencies.md came to be? It has hardcoded version numbers of clang, gcc and glibc.
<sliv3r__>
fanquake: should only add it for gcc and clang no? We do have hardcoded versions for other things like cmake, sqlite, zmq, among others
<vasild>
If we don't support clang 16, then it makes perfect sense to me to stop at configure time with a friendly message
<fanquake>
silv3r__: why not all the other compilers we support?
<fanquake>
(if anything is done, it should at least be consistent)
<fanquake>
silvr3r__: yes, but for example, we support compiling with MSVC (might have a version in other docs)
<vasild>
I do not see it as either "all" or "none". Saving some time for clang < 17 and gcc < 12.1 users is an improvement even if we don't do the same for others
<bitcoin-git>
bitcoin/master 2cb7e99 Vasil Dimov: test: also reset CConnman::m_private_broadcast in tests
<bitcoin-git>
bitcoin/master 84e826d merge-script: Merge bitcoin/bitcoin#34511: test: fully reset the state of CConnman in te...
<bitcoin-git>
[bitcoin] fanquake merged pull request #34511: test: fully reset the state of CConnman in tests (master...test_reset_connman_pb) https://github.com/bitcoin/bitcoin/pull/34511
vasild has quit [Ping timeout: 252 seconds]
vasild_ is now known as vasild
<sliv3r__>
fanquake: vasild: I'll open the PR with hardcoded version (for now) so we can discuss there the best approach
<bitcoin-git>
[bitcoin] polespinasa opened pull request #34580: build: Add a compiler minimum version check (master...clang_min_version_check) https://github.com/bitcoin/bitcoin/pull/34580